{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/159139502","pull_request_review_id":86046388,"id":159139502,"diff_hunk":"@@ -3620,10 +3619,11 @@ pub extern \"C\" fn Servo_ReparentStyle(\n     let element = element.map(GeckoElement);\n \n     let mut cascade_flags = CascadeFlags::empty();\n-    if style_to_reparent.is_anon_box() {\n-        cascade_flags.insert(CascadeFlags::SKIP_ROOT_AND_ITEM_BASED_DISPLAY_FIXUP);\n-    }\n     if let Some(element) = element {\n+        // NOTE(emilio): This relies on element.is_none() == pseudo.is_none(),\n+        // which the caller guarantees, fortunately. But this doesn't handle the","path":"ports/geckolib/glue.rs","position":23,"original_position":23,"commit_id":"c4fa5ac3d670beb212f9cb409e152393c12dae94","original_commit_id":"c4fa5ac3d670beb212f9cb409e152393c12dae94","user":{"login":"upsuper","id":333750,"avatar_url":"https://avatars3.githubusercontent.com/u/333750?v=4","gravatar_id":"","url":"https://api.github.com/users/upsuper","html_url":"https://github.com/upsuper","followers_url":"https://api.github.com/users/upsuper/followers","following_url":"https://api.github.com/users/upsuper/following{/other_user}","gists_url":"https://api.github.com/users/upsuper/gists{/gist_id}","starred_url":"https://api.github.com/users/upsuper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upsuper/subscriptions","organizations_url":"https://api.github.com/users/upsuper/orgs","repos_url":"https://api.github.com/users/upsuper/repos","events_url":"https://api.github.com/users/upsuper/events{/privacy}","received_events_url":"https://api.github.com/users/upsuper/received_events","type":"User","site_admin":false},"body":"It is not clear to me how is it guaranteed... Maybe you mean when `element.is_none()` is true, then `pseudo.is_none()` is also true? I'm not sure why we cannot reparent non-pseudo element here.\r\n\r\nIt is also unclear to me why this relies on that... What would happen if it is not that case?","created_at":"2017-12-31T12:43:35Z","updated_at":"2017-12-31T12:45:10Z","html_url":"https://github.com/servo/servo/pull/19666#discussion_r159139502","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/19666","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/159139502"},"html":{"href":"https://github.com/servo/servo/pull/19666#discussion_r159139502"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/19666"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/19666","id":160618190,"html_url":"https://github.com/servo/servo/pull/19666","diff_url":"https://github.com/servo/servo/pull/19666.diff","patch_url":"https://github.com/servo/servo/pull/19666.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/19666","number":19666,"state":"open","locked":false,"title":"style: Simplify the skip item based display fixup adjustment.","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars1.githubusercontent.com/u/1323194?v=4","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"body":"In practice the only NAC that possibly inherits from a grid or flex container\r\nare pseudos.\r\n\r\nIn Gecko, if the root element is an item container, custom anon content would\r\nalso sometimes incorrectly inherit from that (see bug 1405635), but that's fixed\r\nin Stylo.\r\n\r\nWe remove the IS_ROOT_ELEMENT blockification from the \"skip display fixup\"\r\ncheck, since the root element is never NAC or anything like that, so there's no\r\nneed for the check.\r\n\r\nThis also fixes some reparenting fishiness related to pseudo-elements. We were\r\nonly skipping the fixup when reparenting anon boxes, not when reparenting normal\r\nelement styles, nor when reparenting other pseudo styles which are not anon\r\nboxes.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/19666)\n<!-- Reviewable:end -->\n","created_at":"2017-12-31T12:11:30Z","updated_at":"2017-12-31T12:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e515e87ba5a9b81de9744e5e0b3aa6f693bc5bc3","assignee":{"login":"upsuper","id":333750,"avatar_url":"https://avatars3.githubusercontent.com/u/333750?v=4","gravatar_id":"","url":"https://api.github.com/users/upsuper","html_url":"https://github.com/upsuper","followers_url":"https://api.github.com/users/upsuper/followers","following_url":"https://api.github.com/users/upsuper/following{/other_user}","gists_url":"https://api.github.com/users/upsuper/gists{/gist_id}","starred_url":"https://api.github.com/users/upsuper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upsuper/subscriptions","organizations_url":"https://api.github.com/users/upsuper/orgs","repos_url":"https://api.github.com/users/upsuper/repos","events_url":"https://api.github.com/users/upsuper/events{/privacy}","received_events_url":"https://api.github.com/users/upsuper/received_events","type":"User","site_admin":false},"assignees":[{"login":"upsuper","id":333750,"avatar_url":"https://avatars3.githubusercontent.com/u/333750?v=4","gravatar_id":"","url":"https://api.github.com/users/upsuper","html_url":"https://github.com/upsuper","followers_url":"https://api.github.com/users/upsuper/followers","following_url":"https://api.github.com/users/upsuper/following{/other_user}","gists_url":"https://api.github.com/users/upsuper/gists{/gist_id}","starred_url":"https://api.github.com/users/upsuper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upsuper/subscriptions","organizations_url":"https://api.github.com/users/upsuper/orgs","repos_url":"https://api.github.com/users/upsuper/repos","events_url":"https://api.github.com/users/upsuper/events{/privacy}","received_events_url":"https://api.github.com/users/upsuper/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/19666/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/19666/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/19666/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/c4fa5ac3d670beb212f9cb409e152393c12dae94","head":{"label":"emilio:root-and-item","ref":"root-and-item","sha":"c4fa5ac3d670beb212f9cb409e152393c12dae94","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars1.githubusercontent.com/u/1323194?v=4","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"repo":{"id":34808649,"name":"servo","full_name":"emilio/servo","owner":{"login":"emilio","id":1323194,"avatar_url":"https://avatars1.githubusercontent.com/u/1323194?v=4","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emilio/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/emilio/servo","forks_url":"https://api.github.com/repos/emilio/servo/forks","keys_url":"https://api.github.com/repos/emilio/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emilio/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emilio/servo/teams","hooks_url":"https://api.github.com/repos/emilio/servo/hooks","issue_events_url":"https://api.github.com/repos/emilio/servo/issues/events{/number}","events_url":"https://api.github.com/repos/emilio/servo/events","assignees_url":"https://api.github.com/repos/emilio/servo/assignees{/user}","branches_url":"https://api.github.com/repos/emilio/servo/branches{/branch}","tags_url":"https://api.github.com/repos/emilio/servo/tags","blobs_url":"https://api.github.com/repos/emilio/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emilio/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emilio/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/emilio/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emilio/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/emilio/servo/languages","stargazers_url":"https://api.github.com/repos/emilio/servo/stargazers","contributors_url":"https://api.github.com/repos/emilio/servo/contributors","subscribers_url":"https://api.github.com/repos/emilio/servo/subscribers","subscription_url":"https://api.github.com/repos/emilio/servo/subscription","commits_url":"https://api.github.com/repos/emilio/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/emilio/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/emilio/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/emilio/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/emilio/servo/contents/{+path}","compare_url":"https://api.github.com/repos/emilio/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emilio/servo/merges","archive_url":"https://api.github.com/repos/emilio/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emilio/servo/downloads","issues_url":"https://api.github.com/repos/emilio/servo/issues{/number}","pulls_url":"https://api.github.com/repos/emilio/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/emilio/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/emilio/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emilio/servo/labels{/name}","releases_url":"https://api.github.com/repos/emilio/servo/releases{/id}","deployments_url":"https://api.github.com/repos/emilio/servo/deployments","created_at":"2015-04-29T17:44:08Z","updated_at":"2016-01-12T15:00:17Z","pushed_at":"2017-12-31T12:13:47Z","git_url":"git://github.com/emilio/servo.git","ssh_url":"git@github.com:emilio/servo.git","clone_url":"https://github.com/emilio/servo.git","svn_url":"https://github.com/emilio/servo","homepage":"","size":324365,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"4ba795081cd1efa42ce03c996d574cfe96f68ece","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2017-12-31T05:52:07Z","pushed_at":"2017-12-31T12:25:55Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":403850,"stargazers_count":10913,"watchers_count":10913,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1809,"mirror_url":null,"archived":false,"open_issues_count":2040,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1809,"open_issues":2040,"watchers":10913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/19666"},"html":{"href":"https://github.com/servo/servo/pull/19666"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/19666"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/19666/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/19666/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/19666/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/c4fa5ac3d670beb212f9cb409e152393c12dae94"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"upsuper"}}