{"action":"created","issue":{"url":"https://api.github.com/repos/DAVFoundation/missioncontrol/issues/97","repository_url":"https://api.github.com/repos/DAVFoundation/missioncontrol","labels_url":"https://api.github.com/repos/DAVFoundation/missioncontrol/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/DAVFoundation/missioncontrol/issues/97/comments","events_url":"https://api.github.com/repos/DAVFoundation/missioncontrol/issues/97/events","html_url":"https://github.com/DAVFoundation/missioncontrol/pull/97","id":280005867,"number":97,"title":"Issue #96. Test the url getDavIdIconUrl(davId)","user":{"login":"hongthang152","id":29309458,"avatar_url":"https://avatars3.githubusercontent.com/u/29309458?v=4","gravatar_id":"","url":"https://api.github.com/users/hongthang152","html_url":"https://github.com/hongthang152","followers_url":"https://api.github.com/users/hongthang152/followers","following_url":"https://api.github.com/users/hongthang152/following{/other_user}","gists_url":"https://api.github.com/users/hongthang152/gists{/gist_id}","starred_url":"https://api.github.com/users/hongthang152/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongthang152/subscriptions","organizations_url":"https://api.github.com/users/hongthang152/orgs","repos_url":"https://api.github.com/users/hongthang152/repos","events_url":"https://api.github.com/users/hongthang152/events{/privacy}","received_events_url":"https://api.github.com/users/hongthang152/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-07T05:25:27Z","updated_at":"2017-12-18T03:38:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DAVFoundation/missioncontrol/pulls/97","html_url":"https://github.com/DAVFoundation/missioncontrol/pull/97","diff_url":"https://github.com/DAVFoundation/missioncontrol/pull/97.diff","patch_url":"https://github.com/DAVFoundation/missioncontrol/pull/97.patch"},"body":"\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\nTest whether the url getDavIdIconUrl(davId) returns contains the davId using the indexOf method (on the URL that is returned from the function).\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\nI added the function \"checkIfReturnDavId\" that takes the parameter of the url returned from the method \"getDavIdIconUrl\". It will return false if there is no DavId in the URL, and it will return true if there is the DavId in the URL. \r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\nhttps://github.com/DAVFoundation/missioncontrol/issues/96\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nIt solved the issue that is mentioned.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\nI used \"npm test\". All 5 files passed.\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x ] My code follows the code style of this project.\r\n- [x ] My change requires a change to the documentation.\r\n- [x ] I have read the **CONTRIBUTING** document.\r\n- [x ] I have added tests to cover my changes.\r\n- [x ] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/DAVFoundation/missioncontrol/issues/comments/352318071","html_url":"https://github.com/DAVFoundation/missioncontrol/pull/97#issuecomment-352318071","issue_url":"https://api.github.com/repos/DAVFoundation/missioncontrol/issues/97","id":352318071,"user":{"login":"hongthang152","id":29309458,"avatar_url":"https://avatars3.githubusercontent.com/u/29309458?v=4","gravatar_id":"","url":"https://api.github.com/users/hongthang152","html_url":"https://github.com/hongthang152","followers_url":"https://api.github.com/users/hongthang152/followers","following_url":"https://api.github.com/users/hongthang152/following{/other_user}","gists_url":"https://api.github.com/users/hongthang152/gists{/gist_id}","starred_url":"https://api.github.com/users/hongthang152/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongthang152/subscriptions","organizations_url":"https://api.github.com/users/hongthang152/orgs","repos_url":"https://api.github.com/users/hongthang152/repos","events_url":"https://api.github.com/users/hongthang152/events{/privacy}","received_events_url":"https://api.github.com/users/hongthang152/received_events","type":"User","site_admin":false},"created_at":"2017-12-18T03:38:25Z","updated_at":"2017-12-18T03:38:25Z","author_association":"NONE","body":"Really appreciate that @TalAter . The code is easier to read now."}}
{"actor":{"display_login":"hongthang152"}}