{"action":"created","issue":{"url":"https://api.github.com/repos/mntmn/interim/issues/4","repository_url":"https://api.github.com/repos/mntmn/interim","labels_url":"https://api.github.com/repos/mntmn/interim/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/mntmn/interim/issues/4/comments","events_url":"https://api.github.com/repos/mntmn/interim/issues/4/events","html_url":"https://github.com/mntmn/interim/issues/4","id":106826903,"number":4,"title":"Completion of error handling","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars2.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-09-16T17:59:03Z","updated_at":"2017-03-15T12:12:05Z","closed_at":null,"body":"Would you like to add more error handling for return values from functions like the following?\n- [fseek](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html) ⇒ [posixfs_open](https://github.com/mntmn/interim/blob/32524f7b0fa5f18292871afd89ee72d7764ec19c/devices/posixfs.c#L13)\n- [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [main](https://github.com/mntmn/interim/blob/95d5c838ec646a0081e349261a2d5b559d1e9046/sledge/sledge.c#L23)\n- [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html) ⇒ [init_compiler](https://github.com/mntmn/interim/blob/d3bdbb459fc00c0744a4dc2cf8b4ff5fc7d0a2cb/sledge/compiler_new.c#L1253)\n"},"comment":{"url":"https://api.github.com/repos/mntmn/interim/issues/comments/286723645","html_url":"https://github.com/mntmn/interim/issues/4#issuecomment-286723645","issue_url":"https://api.github.com/repos/mntmn/interim/issues/4","id":286723645,"user":{"login":"wasamasa","id":3588994,"avatar_url":"https://avatars3.githubusercontent.com/u/3588994?v=3","gravatar_id":"","url":"https://api.github.com/users/wasamasa","html_url":"https://github.com/wasamasa","followers_url":"https://api.github.com/users/wasamasa/followers","following_url":"https://api.github.com/users/wasamasa/following{/other_user}","gists_url":"https://api.github.com/users/wasamasa/gists{/gist_id}","starred_url":"https://api.github.com/users/wasamasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasamasa/subscriptions","organizations_url":"https://api.github.com/users/wasamasa/orgs","repos_url":"https://api.github.com/users/wasamasa/repos","events_url":"https://api.github.com/users/wasamasa/events{/privacy}","received_events_url":"https://api.github.com/users/wasamasa/received_events","type":"User","site_admin":false},"created_at":"2017-03-15T12:12:05Z","updated_at":"2017-03-15T12:12:05Z","body":"Personally, I believe that error checking `printf` is a tad overkill, with `snprintf` however a must.  Perhaps `malloc` could be replaced with something like `xmalloc` (which exits if `malloc` threw an error because, well, there isn't much else you can do in that situation).\r\n\r\nOther than that, more error handling in file and string functions would be great and if possible/sensible, the use of safer string functions.   There's at least one occurrence of improperly null-terminated strings in the sources, for that pervasive use of `snprintf` would be a good idea (combined with a warning if the limit is exceeded).  I'll have to investigate what the situation with `strlen`, `strcpy` and `strcmp` is."}}
{"actor":{"display_login":"wasamasa"}}