{"action":"created","issue":{"url":"https://api.github.com/repos/openpnp/openpnp/issues/630","repository_url":"https://api.github.com/repos/openpnp/openpnp","labels_url":"https://api.github.com/repos/openpnp/openpnp/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/openpnp/openpnp/issues/630/comments","events_url":"https://api.github.com/repos/openpnp/openpnp/issues/630/events","html_url":"https://github.com/openpnp/openpnp/pull/630","id":253474414,"number":630,"title":"fix bug 576 by checking for parts on all nozzles and not just current","user":{"login":"johngrabner","id":8209285,"avatar_url":"https://avatars0.githubusercontent.com/u/8209285?v=4","gravatar_id":"","url":"https://api.github.com/users/johngrabner","html_url":"https://github.com/johngrabner","followers_url":"https://api.github.com/users/johngrabner/followers","following_url":"https://api.github.com/users/johngrabner/following{/other_user}","gists_url":"https://api.github.com/users/johngrabner/gists{/gist_id}","starred_url":"https://api.github.com/users/johngrabner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johngrabner/subscriptions","organizations_url":"https://api.github.com/users/johngrabner/orgs","repos_url":"https://api.github.com/users/johngrabner/repos","events_url":"https://api.github.com/users/johngrabner/events{/privacy}","received_events_url":"https://api.github.com/users/johngrabner/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-28T22:24:36Z","updated_at":"2017-08-29T15:53:24Z","closed_at":"2017-08-29T15:52:45Z","pull_request":{"url":"https://api.github.com/repos/openpnp/openpnp/pulls/630","html_url":"https://github.com/openpnp/openpnp/pull/630","diff_url":"https://github.com/openpnp/openpnp/pull/630.diff","patch_url":"https://github.com/openpnp/openpnp/pull/630.patch"},"body":"ran from Eclipse with start parameter of -DoverrideUserConfig=true\r\nopen and ran pnp-test.job.xml ... all is good\r\ncreated a second nozzle with a tip\r\nchange R0805-1K to speed of 1%\r\npicked R0201-1K, jog and observe speed ... fast as expected\r\npicked R0805-1k, jog and observed speed ... slow as expected\r\ndiscarded R0805-1k, after discard joged and observed speed ... fast as expected\r\npicked R0805-1K, jog and observed speed ... slow as expected\r\ndiscarded R0201-1K, and observed speed ... slow as expected\r\ndiscarded R0805-1K, joged and observed speed, ... fast as expected\r\n\r\ndid testing also on brach with dragfeeder with real parts.  All works.\r\n\r\n# Read This First\r\nTo submit a Pull Request for OpenPnP you must use this template or it will not be accepted. \r\n\r\nBe sure to review the [Developers Guide](https://github.com/openpnp/openpnp/wiki/Developers-Guide)\r\nand the [Contributing Guidelines](https://github.com/openpnp/openpnp/blob/develop/CONTRIBUTING.md).\r\n\r\nMake your Pull Request as small as possible. Only include one bug or feature.\r\nLarge pull requests that change dozens of files or add multiple features are unlikely to be accepted.\r\n\r\nFill out all the details below. All sections below are required. If they are not included your Pull Request\r\nwill not be accepted.\r\n\r\n-----------------------------------------------------------------------\r\n\r\n# Description\r\nDescribe the change in detail. Explain how it works. The better you describe the change the more likely it is to be accepted.\r\n\r\n# Justification\r\nWhy should this change be included in OpenPnP? Does it benefit a majority of users or is it specific to one type of user or machine? Machine specific or highly individual code will not be accepted.\r\n\r\n# Instructions for Use\r\nHow does someone use the feature? Be descriptive. Include step by step instructions. If this is a new feature then these instructions will become the Wiki documentation for the feature, so explain here the same way you would explain to someone who had never used the feature.\r\n\r\nThis is documentation for a user, not for a developer.\r\n\r\n# Implementation Details\r\n1. How did you test the change? Be descriptive. Untested code will not be accepted.\r\n2. Did you follow the [coding style](https://github.com/openpnp/openpnp/wiki/Developers-Guide#coding-style)?\r\n3. If you made changes in the `org.openpnp.spi` or `org.openpnp.model` packages you will need to add additional justification for these changes. Changes to these packages require extensive review and testing.\r\n4. Be sure to run `mvn test` before submitting the Pull Request. If the tests do not pass the Pull Request will not be accepted.\r\n"},"comment":{"url":"https://api.github.com/repos/openpnp/openpnp/issues/comments/325708855","html_url":"https://github.com/openpnp/openpnp/pull/630#issuecomment-325708855","issue_url":"https://api.github.com/repos/openpnp/openpnp/issues/630","id":325708855,"user":{"login":"vonnieda","id":1182323,"avatar_url":"https://avatars2.githubusercontent.com/u/1182323?v=4","gravatar_id":"","url":"https://api.github.com/users/vonnieda","html_url":"https://github.com/vonnieda","followers_url":"https://api.github.com/users/vonnieda/followers","following_url":"https://api.github.com/users/vonnieda/following{/other_user}","gists_url":"https://api.github.com/users/vonnieda/gists{/gist_id}","starred_url":"https://api.github.com/users/vonnieda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vonnieda/subscriptions","organizations_url":"https://api.github.com/users/vonnieda/orgs","repos_url":"https://api.github.com/users/vonnieda/repos","events_url":"https://api.github.com/users/vonnieda/events{/privacy}","received_events_url":"https://api.github.com/users/vonnieda/received_events","type":"User","site_admin":false},"created_at":"2017-08-29T15:53:24Z","updated_at":"2017-08-29T15:53:24Z","body":"Merged with minor updates. Thanks @johngrabner!"}}
{"actor":{"display_login":"vonnieda"}}