{"action":"closed","number":513,"pull_request":{"url":"https://api.github.com/repos/fmtlib/fmt/pulls/513","id":122027202,"html_url":"https://github.com/fmtlib/fmt/pull/513","diff_url":"https://github.com/fmtlib/fmt/pull/513.diff","patch_url":"https://github.com/fmtlib/fmt/pull/513.patch","issue_url":"https://api.github.com/repos/fmtlib/fmt/issues/513","number":513,"state":"closed","locked":false,"title":"cmake namespace fixes","user":{"login":"niosHD","id":1627467,"avatar_url":"https://avatars2.githubusercontent.com/u/1627467?v=3","gravatar_id":"","url":"https://api.github.com/users/niosHD","html_url":"https://github.com/niosHD","followers_url":"https://api.github.com/users/niosHD/followers","following_url":"https://api.github.com/users/niosHD/following{/other_user}","gists_url":"https://api.github.com/users/niosHD/gists{/gist_id}","starred_url":"https://api.github.com/users/niosHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosHD/subscriptions","organizations_url":"https://api.github.com/users/niosHD/orgs","repos_url":"https://api.github.com/users/niosHD/repos","events_url":"https://api.github.com/users/niosHD/events{/privacy}","received_events_url":"https://api.github.com/users/niosHD/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nthis PR addresses two small issues which have been missed in PR #511. First, the second target in the find-package-test has not been updated (see 9f48bb8). Second, in my opinion it should not matter how (`add_subdirectory` or `find_package`) the library has been added into a consuming project. I therefore added aliases with the prefix which makes it possible to always use the namespace version (`fmt::fmt`) consistently (see a68c7a8).\r\n\r\nRegards,\r\nniosHD\r\n","created_at":"2017-05-23T15:25:42Z","updated_at":"2017-05-25T11:36:18Z","closed_at":"2017-05-25T11:36:17Z","merged_at":"2017-05-25T11:36:17Z","merge_commit_sha":"ac5484c4e7365b59d8c7e14db6778de26635e428","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fmtlib/fmt/pulls/513/commits","review_comments_url":"https://api.github.com/repos/fmtlib/fmt/pulls/513/comments","review_comment_url":"https://api.github.com/repos/fmtlib/fmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fmtlib/fmt/issues/513/comments","statuses_url":"https://api.github.com/repos/fmtlib/fmt/statuses/a68c7a8db4ec062d51e82e6fb96a93a5b5f5863c","head":{"label":"niosHD:cmake-namespace-fixes","ref":"cmake-namespace-fixes","sha":"a68c7a8db4ec062d51e82e6fb96a93a5b5f5863c","user":{"login":"niosHD","id":1627467,"avatar_url":"https://avatars2.githubusercontent.com/u/1627467?v=3","gravatar_id":"","url":"https://api.github.com/users/niosHD","html_url":"https://github.com/niosHD","followers_url":"https://api.github.com/users/niosHD/followers","following_url":"https://api.github.com/users/niosHD/following{/other_user}","gists_url":"https://api.github.com/users/niosHD/gists{/gist_id}","starred_url":"https://api.github.com/users/niosHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosHD/subscriptions","organizations_url":"https://api.github.com/users/niosHD/orgs","repos_url":"https://api.github.com/users/niosHD/repos","events_url":"https://api.github.com/users/niosHD/events{/privacy}","received_events_url":"https://api.github.com/users/niosHD/received_events","type":"User","site_admin":false},"repo":{"id":49496483,"name":"cppformat","full_name":"niosHD/cppformat","owner":{"login":"niosHD","id":1627467,"avatar_url":"https://avatars2.githubusercontent.com/u/1627467?v=3","gravatar_id":"","url":"https://api.github.com/users/niosHD","html_url":"https://github.com/niosHD","followers_url":"https://api.github.com/users/niosHD/followers","following_url":"https://api.github.com/users/niosHD/following{/other_user}","gists_url":"https://api.github.com/users/niosHD/gists{/gist_id}","starred_url":"https://api.github.com/users/niosHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niosHD/subscriptions","organizations_url":"https://api.github.com/users/niosHD/orgs","repos_url":"https://api.github.com/users/niosHD/repos","events_url":"https://api.github.com/users/niosHD/events{/privacy}","received_events_url":"https://api.github.com/users/niosHD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niosHD/cppformat","description":"Small, safe and fast formatting library for C++","fork":true,"url":"https://api.github.com/repos/niosHD/cppformat","forks_url":"https://api.github.com/repos/niosHD/cppformat/forks","keys_url":"https://api.github.com/repos/niosHD/cppformat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niosHD/cppformat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niosHD/cppformat/teams","hooks_url":"https://api.github.com/repos/niosHD/cppformat/hooks","issue_events_url":"https://api.github.com/repos/niosHD/cppformat/issues/events{/number}","events_url":"https://api.github.com/repos/niosHD/cppformat/events","assignees_url":"https://api.github.com/repos/niosHD/cppformat/assignees{/user}","branches_url":"https://api.github.com/repos/niosHD/cppformat/branches{/branch}","tags_url":"https://api.github.com/repos/niosHD/cppformat/tags","blobs_url":"https://api.github.com/repos/niosHD/cppformat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niosHD/cppformat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niosHD/cppformat/git/refs{/sha}","trees_url":"https://api.github.com/repos/niosHD/cppformat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niosHD/cppformat/statuses/{sha}","languages_url":"https://api.github.com/repos/niosHD/cppformat/languages","stargazers_url":"https://api.github.com/repos/niosHD/cppformat/stargazers","contributors_url":"https://api.github.com/repos/niosHD/cppformat/contributors","subscribers_url":"https://api.github.com/repos/niosHD/cppformat/subscribers","subscription_url":"https://api.github.com/repos/niosHD/cppformat/subscription","commits_url":"https://api.github.com/repos/niosHD/cppformat/commits{/sha}","git_commits_url":"https://api.github.com/repos/niosHD/cppformat/git/commits{/sha}","comments_url":"https://api.github.com/repos/niosHD/cppformat/comments{/number}","issue_comment_url":"https://api.github.com/repos/niosHD/cppformat/issues/comments{/number}","contents_url":"https://api.github.com/repos/niosHD/cppformat/contents/{+path}","compare_url":"https://api.github.com/repos/niosHD/cppformat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niosHD/cppformat/merges","archive_url":"https://api.github.com/repos/niosHD/cppformat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niosHD/cppformat/downloads","issues_url":"https://api.github.com/repos/niosHD/cppformat/issues{/number}","pulls_url":"https://api.github.com/repos/niosHD/cppformat/pulls{/number}","milestones_url":"https://api.github.com/repos/niosHD/cppformat/milestones{/number}","notifications_url":"https://api.github.com/repos/niosHD/cppformat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niosHD/cppformat/labels{/name}","releases_url":"https://api.github.com/repos/niosHD/cppformat/releases{/id}","deployments_url":"https://api.github.com/repos/niosHD/cppformat/deployments","created_at":"2016-01-12T11:42:08Z","updated_at":"2016-01-12T11:42:09Z","pushed_at":"2017-05-23T15:08:09Z","git_url":"git://github.com/niosHD/cppformat.git","ssh_url":"git@github.com:niosHD/cppformat.git","clone_url":"https://github.com/niosHD/cppformat.git","svn_url":"https://github.com/niosHD/cppformat","homepage":"cppformat.github.io","size":4674,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fmtlib:master","ref":"master","sha":"048d2aec277810372919bd6b324fb562601ba9d9","user":{"login":"fmtlib","id":7280830,"avatar_url":"https://avatars3.githubusercontent.com/u/7280830?v=3","gravatar_id":"","url":"https://api.github.com/users/fmtlib","html_url":"https://github.com/fmtlib","followers_url":"https://api.github.com/users/fmtlib/followers","following_url":"https://api.github.com/users/fmtlib/following{/other_user}","gists_url":"https://api.github.com/users/fmtlib/gists{/gist_id}","starred_url":"https://api.github.com/users/fmtlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmtlib/subscriptions","organizations_url":"https://api.github.com/users/fmtlib/orgs","repos_url":"https://api.github.com/users/fmtlib/repos","events_url":"https://api.github.com/users/fmtlib/events{/privacy}","received_events_url":"https://api.github.com/users/fmtlib/received_events","type":"Organization","site_admin":false},"repo":{"id":7056202,"name":"fmt","full_name":"fmtlib/fmt","owner":{"login":"fmtlib","id":7280830,"avatar_url":"https://avatars3.githubusercontent.com/u/7280830?v=3","gravatar_id":"","url":"https://api.github.com/users/fmtlib","html_url":"https://github.com/fmtlib","followers_url":"https://api.github.com/users/fmtlib/followers","following_url":"https://api.github.com/users/fmtlib/following{/other_user}","gists_url":"https://api.github.com/users/fmtlib/gists{/gist_id}","starred_url":"https://api.github.com/users/fmtlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmtlib/subscriptions","organizations_url":"https://api.github.com/users/fmtlib/orgs","repos_url":"https://api.github.com/users/fmtlib/repos","events_url":"https://api.github.com/users/fmtlib/events{/privacy}","received_events_url":"https://api.github.com/users/fmtlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fmtlib/fmt","description":"Small, safe and fast formatting library","fork":false,"url":"https://api.github.com/repos/fmtlib/fmt","forks_url":"https://api.github.com/repos/fmtlib/fmt/forks","keys_url":"https://api.github.com/repos/fmtlib/fmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmtlib/fmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmtlib/fmt/teams","hooks_url":"https://api.github.com/repos/fmtlib/fmt/hooks","issue_events_url":"https://api.github.com/repos/fmtlib/fmt/issues/events{/number}","events_url":"https://api.github.com/repos/fmtlib/fmt/events","assignees_url":"https://api.github.com/repos/fmtlib/fmt/assignees{/user}","branches_url":"https://api.github.com/repos/fmtlib/fmt/branches{/branch}","tags_url":"https://api.github.com/repos/fmtlib/fmt/tags","blobs_url":"https://api.github.com/repos/fmtlib/fmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmtlib/fmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmtlib/fmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmtlib/fmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmtlib/fmt/statuses/{sha}","languages_url":"https://api.github.com/repos/fmtlib/fmt/languages","stargazers_url":"https://api.github.com/repos/fmtlib/fmt/stargazers","contributors_url":"https://api.github.com/repos/fmtlib/fmt/contributors","subscribers_url":"https://api.github.com/repos/fmtlib/fmt/subscribers","subscription_url":"https://api.github.com/repos/fmtlib/fmt/subscription","commits_url":"https://api.github.com/repos/fmtlib/fmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmtlib/fmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmtlib/fmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmtlib/fmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmtlib/fmt/contents/{+path}","compare_url":"https://api.github.com/repos/fmtlib/fmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmtlib/fmt/merges","archive_url":"https://api.github.com/repos/fmtlib/fmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmtlib/fmt/downloads","issues_url":"https://api.github.com/repos/fmtlib/fmt/issues{/number}","pulls_url":"https://api.github.com/repos/fmtlib/fmt/pulls{/number}","milestones_url":"https://api.github.com/repos/fmtlib/fmt/milestones{/number}","notifications_url":"https://api.github.com/repos/fmtlib/fmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmtlib/fmt/labels{/name}","releases_url":"https://api.github.com/repos/fmtlib/fmt/releases{/id}","deployments_url":"https://api.github.com/repos/fmtlib/fmt/deployments","created_at":"2012-12-07T16:26:46Z","updated_at":"2017-05-24T22:15:51Z","pushed_at":"2017-05-25T11:36:17Z","git_url":"git://github.com/fmtlib/fmt.git","ssh_url":"git@github.com:fmtlib/fmt.git","clone_url":"https://github.com/fmtlib/fmt.git","svn_url":"https://github.com/fmtlib/fmt","homepage":"http://fmtlib.net","size":5031,"stargazers_count":2512,"watchers_count":2512,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":346,"mirror_url":null,"open_issues_count":13,"forks":346,"open_issues":13,"watchers":2512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fmtlib/fmt/pulls/513"},"html":{"href":"https://github.com/fmtlib/fmt/pull/513"},"issue":{"href":"https://api.github.com/repos/fmtlib/fmt/issues/513"},"comments":{"href":"https://api.github.com/repos/fmtlib/fmt/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/fmtlib/fmt/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/fmtlib/fmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fmtlib/fmt/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/fmtlib/fmt/statuses/a68c7a8db4ec062d51e82e6fb96a93a5b5f5863c"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vitaut","id":576385,"avatar_url":"https://avatars2.githubusercontent.com/u/576385?v=3","gravatar_id":"","url":"https://api.github.com/users/vitaut","html_url":"https://github.com/vitaut","followers_url":"https://api.github.com/users/vitaut/followers","following_url":"https://api.github.com/users/vitaut/following{/other_user}","gists_url":"https://api.github.com/users/vitaut/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaut/subscriptions","organizations_url":"https://api.github.com/users/vitaut/orgs","repos_url":"https://api.github.com/users/vitaut/repos","events_url":"https://api.github.com/users/vitaut/events{/privacy}","received_events_url":"https://api.github.com/users/vitaut/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":7,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"vitaut"}}