{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/flow/issues/2625","repository_url":"https://api.github.com/repos/vaadin/flow","labels_url":"https://api.github.com/repos/vaadin/flow/issues/2625/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/2625/comments","events_url":"https://api.github.com/repos/vaadin/flow/issues/2625/events","html_url":"https://github.com/vaadin/flow/pull/2625","id":263357004,"number":2625,"title":"Complete rerouting in BeforeNavigationEvent","user":{"login":"torok-peter","id":31210544,"avatar_url":"https://avatars3.githubusercontent.com/u/31210544?v=4","gravatar_id":"","url":"https://api.github.com/users/torok-peter","html_url":"https://github.com/torok-peter","followers_url":"https://api.github.com/users/torok-peter/followers","following_url":"https://api.github.com/users/torok-peter/following{/other_user}","gists_url":"https://api.github.com/users/torok-peter/gists{/gist_id}","starred_url":"https://api.github.com/users/torok-peter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torok-peter/subscriptions","organizations_url":"https://api.github.com/users/torok-peter/orgs","repos_url":"https://api.github.com/users/torok-peter/repos","events_url":"https://api.github.com/users/torok-peter/events{/privacy}","received_events_url":"https://api.github.com/users/torok-peter/received_events","type":"User","site_admin":false},"labels":[{"id":357286055,"url":"https://api.github.com/repos/vaadin/flow/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-06T07:23:23Z","updated_at":"2017-10-06T09:13:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/2625","html_url":"https://github.com/vaadin/flow/pull/2625","diff_url":"https://github.com/vaadin/flow/pull/2625.diff","patch_url":"https://github.com/vaadin/flow/pull/2625.patch"},"body":"* Add new overload `rerouteTo(String route, List<T> routeParams)`\r\n* Extract method `hasRouteTo(String pathString)` in `RouteRegistry` to allow precise error handling in caller code\r\n* Refactor to reuse existing code\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/2625)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/flow/issues/comments/334702217","html_url":"https://github.com/vaadin/flow/pull/2625#issuecomment-334702217","issue_url":"https://api.github.com/repos/vaadin/flow/issues/2625","id":334702217,"user":{"login":"denis-anisimov","id":11425472,"avatar_url":"https://avatars0.githubusercontent.com/u/11425472?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-anisimov","html_url":"https://github.com/denis-anisimov","followers_url":"https://api.github.com/users/denis-anisimov/followers","following_url":"https://api.github.com/users/denis-anisimov/following{/other_user}","gists_url":"https://api.github.com/users/denis-anisimov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-anisimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-anisimov/subscriptions","organizations_url":"https://api.github.com/users/denis-anisimov/orgs","repos_url":"https://api.github.com/users/denis-anisimov/repos","events_url":"https://api.github.com/users/denis-anisimov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-anisimov/received_events","type":"User","site_admin":false},"created_at":"2017-10-06T09:13:25Z","updated_at":"2017-10-06T09:13:25Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 2 of 4 files reviewed at latest revision, 5 unresolved discussions.\n\n---\n\n*[flow-server/src/main/java/com/vaadin/router/event/BeforeNavigationEvent.java, line 204 at r1](https://reviewable.io:443/reviews/vaadin/flow/2625#-KvkiQnq7CzJZ_IlXACM:-KvkwqGN9HybHln1MRJ1:bah273s) ([raw file](https://github.com/vaadin/flow/blob/f6e491b0607de130098db261fdb69ba01cee88ce/flow-server/src/main/java/com/vaadin/router/event/BeforeNavigationEvent.java#L204)):*\n>The difference boiled down to the call to checkUrlParameterType(). It seems to be necessary for the >single parameter (there is a unit test for it), but not for the multiple parameter case.\n\nI think this is pretty incorrect.\nThe check should be done for any parameter type. I don't see any reason why it shouldn't be done.\n\nCurrent behavior at least introduce a logic inconsistence between call:\n`rerouteTo(route, param);`  `rerouteTo(route, Collections.singletonList(param));`\nSo in the first case there will be an exception of parameter is incorrect and there will be no exception in the second case.\nThis is totally confusing.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/flow/2625)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"denis-anisimov"}}