{"action":"opened","number":732,"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/732","id":122077081,"html_url":"https://github.com/nest/nest-simulator/pull/732","diff_url":"https://github.com/nest/nest-simulator/pull/732.diff","patch_url":"https://github.com/nest/nest-simulator/pull/732.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/732","number":732,"state":"open","locked":false,"title":"Fix #74 osx clang problems","user":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars0.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"body":"This PR fixes problems that made NEST fails when built with Clang under OSX. I have tested with everything (except MPI) enabled under OSX 10.12.5 with Clang 4.0.0 from brew [as described here (but with Python)](https://github.com/nest/nest-simulator/issues/74#issuecomment-296107035).\r\n\r\nProblems where of several kinds:\r\n- When building static libraries, duplicate definitions of `Name` objects in nestkernel and topology prevented linking; the duplicates are removed from `topology_names.*`.\r\n- The `ctermid()` system function call from `sli/processes.cc` was called with an incorrectly sized output buffer.\r\n- Output file buffers in `recording_device.*` were not set up properly.\r\n- Explicit template instantiations of `lockPTRDatum` types are required to make these Datum types visible to PyNEST; clang and gcc seem to have different rules on symbol visibility.\r\n\r\nI have tested with clang and gcc 7.1.0.","created_at":"2017-05-23T19:31:29Z","updated_at":"2017-05-23T19:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars0.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"assignees":[{"login":"heplesser","id":1059644,"avatar_url":"https://avatars0.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/732/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/732/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/732/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/f1bb878885d9beffafec3d47ce7d99da44953b0b","head":{"label":"heplesser:fix-74-osx-clang-problems","ref":"fix-74-osx-clang-problems","sha":"f1bb878885d9beffafec3d47ce7d99da44953b0b","user":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars0.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"repo":{"id":35492378,"name":"nest-simulator","full_name":"heplesser/nest-simulator","owner":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars0.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heplesser/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/heplesser/nest-simulator","forks_url":"https://api.github.com/repos/heplesser/nest-simulator/forks","keys_url":"https://api.github.com/repos/heplesser/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heplesser/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heplesser/nest-simulator/teams","hooks_url":"https://api.github.com/repos/heplesser/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/heplesser/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/heplesser/nest-simulator/events","assignees_url":"https://api.github.com/repos/heplesser/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/heplesser/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/heplesser/nest-simulator/tags","blobs_url":"https://api.github.com/repos/heplesser/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heplesser/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heplesser/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/heplesser/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heplesser/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/heplesser/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/heplesser/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/heplesser/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/heplesser/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/heplesser/nest-simulator/subscription","commits_url":"https://api.github.com/repos/heplesser/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/heplesser/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/heplesser/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/heplesser/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/heplesser/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/heplesser/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heplesser/nest-simulator/merges","archive_url":"https://api.github.com/repos/heplesser/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heplesser/nest-simulator/downloads","issues_url":"https://api.github.com/repos/heplesser/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/heplesser/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/heplesser/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/heplesser/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heplesser/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/heplesser/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/heplesser/nest-simulator/deployments","created_at":"2015-05-12T14:16:50Z","updated_at":"2016-01-27T22:26:53Z","pushed_at":"2017-05-23T19:18:18Z","git_url":"git://github.com/heplesser/nest-simulator.git","ssh_url":"git@github.com:heplesser/nest-simulator.git","clone_url":"https://github.com/heplesser/nest-simulator.git","svn_url":"https://github.com/heplesser/nest-simulator","homepage":null,"size":39543,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"7509934cb97d2aa280afd8ec5ee89da6ce3e5d40","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars2.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars2.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2017-05-16T05:10:41Z","pushed_at":"2017-05-23T06:58:48Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":34703,"stargazers_count":107,"watchers_count":107,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":113,"mirror_url":null,"open_issues_count":180,"forks":113,"open_issues":180,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/732"},"html":{"href":"https://github.com/nest/nest-simulator/pull/732"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/732"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/732/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/732/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/732/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/f1bb878885d9beffafec3d47ce7d99da44953b0b"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":94,"deletions":64,"changed_files":10}}
{"actor":{"display_login":"heplesser"}}