{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/112822417","pull_request_review_id":34169244,"id":112822417,"diff_hunk":"@@ -760,12 +760,14 @@ namespace {\n \n \tunsigned short session_handle::listen_port() const\n \t{\n-\t\treturn sync_call_ret<unsigned short>(&session_impl::listen_port);\n+\t\treturn sync_call_ret<unsigned short, unsigned short(session_impl::*)() const>","path":"src/session_handle.cpp","position":5,"original_position":5,"commit_id":"2c765748fafb835cf54ab7bc6ede77e0a8118ed6","original_commit_id":"2c765748fafb835cf54ab7bc6ede77e0a8118ed6","user":{"login":"ssiloti","id":155790,"avatar_url":"https://avatars3.githubusercontent.com/u/155790?v=3","gravatar_id":"","url":"https://api.github.com/users/ssiloti","html_url":"https://github.com/ssiloti","followers_url":"https://api.github.com/users/ssiloti/followers","following_url":"https://api.github.com/users/ssiloti/following{/other_user}","gists_url":"https://api.github.com/users/ssiloti/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiloti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiloti/subscriptions","organizations_url":"https://api.github.com/users/ssiloti/orgs","repos_url":"https://api.github.com/users/ssiloti/repos","events_url":"https://api.github.com/users/ssiloti/events{/privacy}","received_events_url":"https://api.github.com/users/ssiloti/received_events","type":"User","site_admin":false},"body":"We can certainly deprecate this. The only potential issue is that it would leave the `listen_succeeded_alert` as the only way for the client to find out what port(s) it is listening on.","created_at":"2017-04-23T01:08:52Z","updated_at":"2017-04-23T01:08:52Z","html_url":"https://github.com/arvidn/libtorrent/pull/1938#discussion_r112822417","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/112822417"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1938#discussion_r112822417"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938","id":117092671,"html_url":"https://github.com/arvidn/libtorrent/pull/1938","diff_url":"https://github.com/arvidn/libtorrent/pull/1938.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/1938.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1938","number":1938,"state":"open","locked":false,"title":"Multi-home support part 1/3 - DHT","user":{"login":"ssiloti","id":155790,"avatar_url":"https://avatars3.githubusercontent.com/u/155790?v=3","gravatar_id":"","url":"https://api.github.com/users/ssiloti","html_url":"https://github.com/ssiloti","followers_url":"https://api.github.com/users/ssiloti/followers","following_url":"https://api.github.com/users/ssiloti/following{/other_user}","gists_url":"https://api.github.com/users/ssiloti/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiloti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiloti/subscriptions","organizations_url":"https://api.github.com/users/ssiloti/orgs","repos_url":"https://api.github.com/users/ssiloti/repos","events_url":"https://api.github.com/users/ssiloti/events{/privacy}","received_events_url":"https://api.github.com/users/ssiloti/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-22T02:40:50Z","updated_at":"2017-04-23T01:08:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85e9cf5a94a764217fdf27a8c3d41314c7121f56","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1938/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/2c765748fafb835cf54ab7bc6ede77e0a8118ed6","head":{"label":"ssiloti:multi-home-dht","ref":"multi-home-dht","sha":"2c765748fafb835cf54ab7bc6ede77e0a8118ed6","user":{"login":"ssiloti","id":155790,"avatar_url":"https://avatars3.githubusercontent.com/u/155790?v=3","gravatar_id":"","url":"https://api.github.com/users/ssiloti","html_url":"https://github.com/ssiloti","followers_url":"https://api.github.com/users/ssiloti/followers","following_url":"https://api.github.com/users/ssiloti/following{/other_user}","gists_url":"https://api.github.com/users/ssiloti/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiloti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiloti/subscriptions","organizations_url":"https://api.github.com/users/ssiloti/orgs","repos_url":"https://api.github.com/users/ssiloti/repos","events_url":"https://api.github.com/users/ssiloti/events{/privacy}","received_events_url":"https://api.github.com/users/ssiloti/received_events","type":"User","site_admin":false},"repo":{"id":37429203,"name":"libtorrent","full_name":"ssiloti/libtorrent","owner":{"login":"ssiloti","id":155790,"avatar_url":"https://avatars3.githubusercontent.com/u/155790?v=3","gravatar_id":"","url":"https://api.github.com/users/ssiloti","html_url":"https://github.com/ssiloti","followers_url":"https://api.github.com/users/ssiloti/followers","following_url":"https://api.github.com/users/ssiloti/following{/other_user}","gists_url":"https://api.github.com/users/ssiloti/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiloti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiloti/subscriptions","organizations_url":"https://api.github.com/users/ssiloti/orgs","repos_url":"https://api.github.com/users/ssiloti/repos","events_url":"https://api.github.com/users/ssiloti/events{/privacy}","received_events_url":"https://api.github.com/users/ssiloti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssiloti/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/ssiloti/libtorrent","forks_url":"https://api.github.com/repos/ssiloti/libtorrent/forks","keys_url":"https://api.github.com/repos/ssiloti/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssiloti/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssiloti/libtorrent/teams","hooks_url":"https://api.github.com/repos/ssiloti/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/ssiloti/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/ssiloti/libtorrent/events","assignees_url":"https://api.github.com/repos/ssiloti/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/ssiloti/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/ssiloti/libtorrent/tags","blobs_url":"https://api.github.com/repos/ssiloti/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssiloti/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssiloti/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssiloti/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssiloti/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/ssiloti/libtorrent/languages","stargazers_url":"https://api.github.com/repos/ssiloti/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/ssiloti/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/ssiloti/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/ssiloti/libtorrent/subscription","commits_url":"https://api.github.com/repos/ssiloti/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssiloti/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssiloti/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssiloti/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssiloti/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/ssiloti/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssiloti/libtorrent/merges","archive_url":"https://api.github.com/repos/ssiloti/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssiloti/libtorrent/downloads","issues_url":"https://api.github.com/repos/ssiloti/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/ssiloti/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/ssiloti/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/ssiloti/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssiloti/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/ssiloti/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/ssiloti/libtorrent/deployments","created_at":"2015-06-14T20:53:10Z","updated_at":"2016-01-11T16:39:40Z","pushed_at":"2017-04-22T02:38:18Z","git_url":"git://github.com/ssiloti/libtorrent.git","ssh_url":"git@github.com:ssiloti/libtorrent.git","clone_url":"https://github.com/ssiloti/libtorrent.git","svn_url":"https://github.com/ssiloti/libtorrent","homepage":"http://libtorrent.org","size":51822,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"8eafd84273865e62c4ae3f8cee183476748cbd70","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars3.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars3.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2017-04-22T19:20:57Z","pushed_at":"2017-04-22T22:50:53Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":67641,"stargazers_count":755,"watchers_count":755,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"open_issues_count":106,"forks":248,"open_issues":106,"watchers":755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1938"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1938"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1938/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1938/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/2c765748fafb835cf54ab7bc6ede77e0a8118ed6"}}}}
{"actor":{"display_login":"ssiloti"}}