{"action":"created","comment":{"url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/comments/102844343","pull_request_review_id":23614515,"id":102844343,"diff_hunk":"@@ -41,4 +41,31 @@\n       it { is_expected.to_not be_valid }\n     end\n   end\n+\n+  describe '.requiring_notification' do\n+    subject(:events_requiring_notification) { Event.requiring_notification }\n+    context 'when there are events aligning with the NOTIFICATION_PERIOD' do\n+      let(:required_notif) do\n+        FactoryGirl.create(\n+          :event, date: Time.zone.today - Event::NOTIFICATION_PERIOD\n+        )\n+      end\n+      let(:unrequired_notif) do\n+        FactoryGirl.create(\n+          :event, date: Time.zone.today + Event::NOTIFICATION_PERIOD\n+        )\n+      end\n+      it 'returns an array of Events requiring notification' do\n+        expect(events_requiring_notification).to include(required_notif)\n+      end\n+      it 'doesnt include Events that arent requiring notification' do","path":"spec/models/event_spec.rb","position":61,"original_position":21,"commit_id":"0f3e8d09ae5270340edca69c7c65006e58a46069","original_commit_id":"ed516f248513262999c4bac8c732880f4174f671","user":{"login":"gregdaynes","id":43543,"avatar_url":"https://avatars.githubusercontent.com/u/43543?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdaynes","html_url":"https://github.com/gregdaynes","followers_url":"https://api.github.com/users/gregdaynes/followers","following_url":"https://api.github.com/users/gregdaynes/following{/other_user}","gists_url":"https://api.github.com/users/gregdaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdaynes/subscriptions","organizations_url":"https://api.github.com/users/gregdaynes/orgs","repos_url":"https://api.github.com/users/gregdaynes/repos","events_url":"https://api.github.com/users/gregdaynes/events{/privacy}","received_events_url":"https://api.github.com/users/gregdaynes/received_events","type":"User","site_admin":false},"body":"Double negative - reads funny.\r\nit 'only includes events that require notification' or something? minor, and doesn't really matter.","created_at":"2017-02-23T23:18:11Z","updated_at":"2017-02-23T23:18:11Z","html_url":"https://github.com/StemboltHQ/staff_tracker/pull/18#discussion_r102844343","pull_request_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/comments/102844343"},"html":{"href":"https://github.com/StemboltHQ/staff_tracker/pull/18#discussion_r102844343"},"pull_request":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18","id":107522617,"html_url":"https://github.com/StemboltHQ/staff_tracker/pull/18","diff_url":"https://github.com/StemboltHQ/staff_tracker/pull/18.diff","patch_url":"https://github.com/StemboltHQ/staff_tracker/pull/18.patch","issue_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/18","number":18,"state":"open","locked":false,"title":"Feature/event notification","user":{"login":"jacquesporveau","id":13607675,"avatar_url":"https://avatars.githubusercontent.com/u/13607675?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquesporveau","html_url":"https://github.com/jacquesporveau","followers_url":"https://api.github.com/users/jacquesporveau/followers","following_url":"https://api.github.com/users/jacquesporveau/following{/other_user}","gists_url":"https://api.github.com/users/jacquesporveau/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesporveau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesporveau/subscriptions","organizations_url":"https://api.github.com/users/jacquesporveau/orgs","repos_url":"https://api.github.com/users/jacquesporveau/repos","events_url":"https://api.github.com/users/jacquesporveau/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesporveau/received_events","type":"User","site_admin":false},"body":"Once Gregs work is merged the extra commits made by him should disappear. More just throwing this up for some general feedback.","created_at":"2017-02-22T23:23:52Z","updated_at":"2017-02-23T23:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18/commits","review_comments_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18/comments","review_comment_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/18/comments","statuses_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/statuses/0f3e8d09ae5270340edca69c7c65006e58a46069","head":{"label":"StemboltHQ:feature/event-notification","ref":"feature/event-notification","sha":"0f3e8d09ae5270340edca69c7c65006e58a46069","user":{"login":"StemboltHQ","id":1585390,"avatar_url":"https://avatars.githubusercontent.com/u/1585390?v=3","gravatar_id":"","url":"https://api.github.com/users/StemboltHQ","html_url":"https://github.com/StemboltHQ","followers_url":"https://api.github.com/users/StemboltHQ/followers","following_url":"https://api.github.com/users/StemboltHQ/following{/other_user}","gists_url":"https://api.github.com/users/StemboltHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/StemboltHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StemboltHQ/subscriptions","organizations_url":"https://api.github.com/users/StemboltHQ/orgs","repos_url":"https://api.github.com/users/StemboltHQ/repos","events_url":"https://api.github.com/users/StemboltHQ/events{/privacy}","received_events_url":"https://api.github.com/users/StemboltHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":82237455,"name":"staff_tracker","full_name":"StemboltHQ/staff_tracker","owner":{"login":"StemboltHQ","id":1585390,"avatar_url":"https://avatars.githubusercontent.com/u/1585390?v=3","gravatar_id":"","url":"https://api.github.com/users/StemboltHQ","html_url":"https://github.com/StemboltHQ","followers_url":"https://api.github.com/users/StemboltHQ/followers","following_url":"https://api.github.com/users/StemboltHQ/following{/other_user}","gists_url":"https://api.github.com/users/StemboltHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/StemboltHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StemboltHQ/subscriptions","organizations_url":"https://api.github.com/users/StemboltHQ/orgs","repos_url":"https://api.github.com/users/StemboltHQ/repos","events_url":"https://api.github.com/users/StemboltHQ/events{/privacy}","received_events_url":"https://api.github.com/users/StemboltHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StemboltHQ/staff_tracker","description":null,"fork":false,"url":"https://api.github.com/repos/StemboltHQ/staff_tracker","forks_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/forks","keys_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/teams","hooks_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/hooks","issue_events_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/events{/number}","events_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/events","assignees_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/assignees{/user}","branches_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/branches{/branch}","tags_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/tags","blobs_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/languages","stargazers_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/stargazers","contributors_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/contributors","subscribers_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/subscribers","subscription_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/subscription","commits_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/contents/{+path}","compare_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/merges","archive_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/downloads","issues_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues{/number}","pulls_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/labels{/name}","releases_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/releases{/id}","deployments_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/deployments","created_at":"2017-02-16T23:50:01Z","updated_at":"2017-02-17T18:41:04Z","pushed_at":"2017-02-23T23:07:46Z","git_url":"git://github.com/StemboltHQ/staff_tracker.git","ssh_url":"git@github.com:StemboltHQ/staff_tracker.git","clone_url":"https://github.com/StemboltHQ/staff_tracker.git","svn_url":"https://github.com/StemboltHQ/staff_tracker","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"StemboltHQ:master","ref":"master","sha":"51e6fa502f2a098359764d1e9a67f733b29e47a2","user":{"login":"StemboltHQ","id":1585390,"avatar_url":"https://avatars.githubusercontent.com/u/1585390?v=3","gravatar_id":"","url":"https://api.github.com/users/StemboltHQ","html_url":"https://github.com/StemboltHQ","followers_url":"https://api.github.com/users/StemboltHQ/followers","following_url":"https://api.github.com/users/StemboltHQ/following{/other_user}","gists_url":"https://api.github.com/users/StemboltHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/StemboltHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StemboltHQ/subscriptions","organizations_url":"https://api.github.com/users/StemboltHQ/orgs","repos_url":"https://api.github.com/users/StemboltHQ/repos","events_url":"https://api.github.com/users/StemboltHQ/events{/privacy}","received_events_url":"https://api.github.com/users/StemboltHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":82237455,"name":"staff_tracker","full_name":"StemboltHQ/staff_tracker","owner":{"login":"StemboltHQ","id":1585390,"avatar_url":"https://avatars.githubusercontent.com/u/1585390?v=3","gravatar_id":"","url":"https://api.github.com/users/StemboltHQ","html_url":"https://github.com/StemboltHQ","followers_url":"https://api.github.com/users/StemboltHQ/followers","following_url":"https://api.github.com/users/StemboltHQ/following{/other_user}","gists_url":"https://api.github.com/users/StemboltHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/StemboltHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StemboltHQ/subscriptions","organizations_url":"https://api.github.com/users/StemboltHQ/orgs","repos_url":"https://api.github.com/users/StemboltHQ/repos","events_url":"https://api.github.com/users/StemboltHQ/events{/privacy}","received_events_url":"https://api.github.com/users/StemboltHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StemboltHQ/staff_tracker","description":null,"fork":false,"url":"https://api.github.com/repos/StemboltHQ/staff_tracker","forks_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/forks","keys_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/teams","hooks_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/hooks","issue_events_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/events{/number}","events_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/events","assignees_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/assignees{/user}","branches_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/branches{/branch}","tags_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/tags","blobs_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/languages","stargazers_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/stargazers","contributors_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/contributors","subscribers_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/subscribers","subscription_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/subscription","commits_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/contents/{+path}","compare_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/merges","archive_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/downloads","issues_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues{/number}","pulls_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/labels{/name}","releases_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/releases{/id}","deployments_url":"https://api.github.com/repos/StemboltHQ/staff_tracker/deployments","created_at":"2017-02-16T23:50:01Z","updated_at":"2017-02-17T18:41:04Z","pushed_at":"2017-02-23T23:07:46Z","git_url":"git://github.com/StemboltHQ/staff_tracker.git","ssh_url":"git@github.com:StemboltHQ/staff_tracker.git","clone_url":"https://github.com/StemboltHQ/staff_tracker.git","svn_url":"https://github.com/StemboltHQ/staff_tracker","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18"},"html":{"href":"https://github.com/StemboltHQ/staff_tracker/pull/18"},"issue":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/18"},"comments":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/StemboltHQ/staff_tracker/statuses/0f3e8d09ae5270340edca69c7c65006e58a46069"}}}}
{"actor":{"display_login":"gregdaynes"}}