{"action":"closed","number":107,"pull_request":{"url":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/107","id":114458858,"html_url":"https://github.com/KiCad/kicad-library-utils/pull/107","diff_url":"https://github.com/KiCad/kicad-library-utils/pull/107.diff","patch_url":"https://github.com/KiCad/kicad-library-utils/pull/107.patch","issue_url":"https://api.github.com/repos/KiCad/kicad-library-utils/issues/107","number":107,"state":"closed","locked":false,"title":"Rule 8.2: changed rule check to use overpadBounds() instead of padBounds()","user":{"login":"hackscribble","id":7076027,"avatar_url":"https://avatars2.githubusercontent.com/u/7076027?v=3","gravatar_id":"","url":"https://api.github.com/users/hackscribble","html_url":"https://github.com/hackscribble","followers_url":"https://api.github.com/users/hackscribble/followers","following_url":"https://api.github.com/users/hackscribble/following{/other_user}","gists_url":"https://api.github.com/users/hackscribble/gists{/gist_id}","starred_url":"https://api.github.com/users/hackscribble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackscribble/subscriptions","organizations_url":"https://api.github.com/users/hackscribble/orgs","repos_url":"https://api.github.com/users/hackscribble/repos","events_url":"https://api.github.com/users/hackscribble/events{/privacy}","received_events_url":"https://api.github.com/users/hackscribble/received_events","type":"User","site_admin":false},"body":"See https://github.com/KiCad/kicad-library-utils/issues/98\r\n\r\n### Change\r\n\r\n```\r\n    # Get the middle position between pads\r\n    # Use the outer dimensions of pads to handle footprints with pads of different sizes\r\n    def padMiddlePosition(self, pads=None):\r\n        \r\n        bb = self.overpadsBounds(pads)\r\n        return bb.center\r\n```\r\n\r\n### Test data\r\n\r\n[footprints.zip](https://github.com/KiCad/kicad-library-utils/files/900628/footprints.zip)\r\n\r\n| Footprint | All pads same size | Anchor at centre|\r\n|-|-|-|\r\n| SOT-23| Yes | Yes |\r\n| SOT-23_moved| Yes | No |\r\n| TO-252-5-11| No | Yes |\r\n| TO-252-2Lead| No | No |\r\n\r\n### `check_kicad_mod.py` result for Rule 8.2\r\n\r\n| Footprint | Expected result | Result with master | Result with PR |\r\n|-|-|-|-|\r\n| SOT-23|Pass| Pass | Pass |\r\n| SOT-23_moved|Fail| Fail |Fail |\r\n| TO-252-5-11|Pass| Fail <sup>1</sup> | Pass |\r\n| TO-252-2Lead|Fail| Pass <sup>2</sup> | Fail |\r\n\r\n__Notes__\r\n\r\n<sup>1</sup> This incorrect result is what led to the issue being raised.\r\n\r\n<sup>2</sup> This \"false positive\" for an existing footprint may be due to the footprint having been fixed before release by using the current version of `check_kicad_mod.py` with the `--fix` argument.\r\n\r\n","created_at":"2017-04-05T19:53:30Z","updated_at":"2017-04-07T12:50:55Z","closed_at":"2017-04-07T12:50:55Z","merged_at":"2017-04-07T12:50:55Z","merge_commit_sha":"6366875ea77387cf76f73b115c9f97900dcb9bcb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/107/commits","review_comments_url":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/107/comments","review_comment_url":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KiCad/kicad-library-utils/issues/107/comments","statuses_url":"https://api.github.com/repos/KiCad/kicad-library-utils/statuses/cb5938290c23cc943b6ddbe0fe470ff9ff289e27","head":{"label":"hackscribble:fix_8.2_for_different_size_pads","ref":"fix_8.2_for_different_size_pads","sha":"cb5938290c23cc943b6ddbe0fe470ff9ff289e27","user":{"login":"hackscribble","id":7076027,"avatar_url":"https://avatars2.githubusercontent.com/u/7076027?v=3","gravatar_id":"","url":"https://api.github.com/users/hackscribble","html_url":"https://github.com/hackscribble","followers_url":"https://api.github.com/users/hackscribble/followers","following_url":"https://api.github.com/users/hackscribble/following{/other_user}","gists_url":"https://api.github.com/users/hackscribble/gists{/gist_id}","starred_url":"https://api.github.com/users/hackscribble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackscribble/subscriptions","organizations_url":"https://api.github.com/users/hackscribble/orgs","repos_url":"https://api.github.com/users/hackscribble/repos","events_url":"https://api.github.com/users/hackscribble/events{/privacy}","received_events_url":"https://api.github.com/users/hackscribble/received_events","type":"User","site_admin":false},"repo":{"id":87285401,"name":"kicad-library-utils","full_name":"hackscribble/kicad-library-utils","owner":{"login":"hackscribble","id":7076027,"avatar_url":"https://avatars2.githubusercontent.com/u/7076027?v=3","gravatar_id":"","url":"https://api.github.com/users/hackscribble","html_url":"https://github.com/hackscribble","followers_url":"https://api.github.com/users/hackscribble/followers","following_url":"https://api.github.com/users/hackscribble/following{/other_user}","gists_url":"https://api.github.com/users/hackscribble/gists{/gist_id}","starred_url":"https://api.github.com/users/hackscribble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackscribble/subscriptions","organizations_url":"https://api.github.com/users/hackscribble/orgs","repos_url":"https://api.github.com/users/hackscribble/repos","events_url":"https://api.github.com/users/hackscribble/events{/privacy}","received_events_url":"https://api.github.com/users/hackscribble/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hackscribble/kicad-library-utils","description":"Some scripts for helping with library development","fork":true,"url":"https://api.github.com/repos/hackscribble/kicad-library-utils","forks_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/forks","keys_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/teams","hooks_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/hooks","issue_events_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/issues/events{/number}","events_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/events","assignees_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/assignees{/user}","branches_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/branches{/branch}","tags_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/tags","blobs_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/languages","stargazers_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/stargazers","contributors_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/contributors","subscribers_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/subscribers","subscription_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/subscription","commits_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/contents/{+path}","compare_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/merges","archive_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/downloads","issues_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/issues{/number}","pulls_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/labels{/name}","releases_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/releases{/id}","deployments_url":"https://api.github.com/repos/hackscribble/kicad-library-utils/deployments","created_at":"2017-04-05T08:28:46Z","updated_at":"2017-04-05T08:28:48Z","pushed_at":"2017-04-07T11:21:33Z","git_url":"git://github.com/hackscribble/kicad-library-utils.git","ssh_url":"git@github.com:hackscribble/kicad-library-utils.git","clone_url":"https://github.com/hackscribble/kicad-library-utils.git","svn_url":"https://github.com/hackscribble/kicad-library-utils","homepage":null,"size":449,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KiCad:master","ref":"master","sha":"396174026346812a87725b665806839037682736","user":{"login":"KiCad","id":3374914,"avatar_url":"https://avatars3.githubusercontent.com/u/3374914?v=3","gravatar_id":"","url":"https://api.github.com/users/KiCad","html_url":"https://github.com/KiCad","followers_url":"https://api.github.com/users/KiCad/followers","following_url":"https://api.github.com/users/KiCad/following{/other_user}","gists_url":"https://api.github.com/users/KiCad/gists{/gist_id}","starred_url":"https://api.github.com/users/KiCad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiCad/subscriptions","organizations_url":"https://api.github.com/users/KiCad/orgs","repos_url":"https://api.github.com/users/KiCad/repos","events_url":"https://api.github.com/users/KiCad/events{/privacy}","received_events_url":"https://api.github.com/users/KiCad/received_events","type":"Organization","site_admin":false},"repo":{"id":35767764,"name":"kicad-library-utils","full_name":"KiCad/kicad-library-utils","owner":{"login":"KiCad","id":3374914,"avatar_url":"https://avatars3.githubusercontent.com/u/3374914?v=3","gravatar_id":"","url":"https://api.github.com/users/KiCad","html_url":"https://github.com/KiCad","followers_url":"https://api.github.com/users/KiCad/followers","following_url":"https://api.github.com/users/KiCad/following{/other_user}","gists_url":"https://api.github.com/users/KiCad/gists{/gist_id}","starred_url":"https://api.github.com/users/KiCad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiCad/subscriptions","organizations_url":"https://api.github.com/users/KiCad/orgs","repos_url":"https://api.github.com/users/KiCad/repos","events_url":"https://api.github.com/users/KiCad/events{/privacy}","received_events_url":"https://api.github.com/users/KiCad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KiCad/kicad-library-utils","description":"Some scripts for helping with library development","fork":false,"url":"https://api.github.com/repos/KiCad/kicad-library-utils","forks_url":"https://api.github.com/repos/KiCad/kicad-library-utils/forks","keys_url":"https://api.github.com/repos/KiCad/kicad-library-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KiCad/kicad-library-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KiCad/kicad-library-utils/teams","hooks_url":"https://api.github.com/repos/KiCad/kicad-library-utils/hooks","issue_events_url":"https://api.github.com/repos/KiCad/kicad-library-utils/issues/events{/number}","events_url":"https://api.github.com/repos/KiCad/kicad-library-utils/events","assignees_url":"https://api.github.com/repos/KiCad/kicad-library-utils/assignees{/user}","branches_url":"https://api.github.com/repos/KiCad/kicad-library-utils/branches{/branch}","tags_url":"https://api.github.com/repos/KiCad/kicad-library-utils/tags","blobs_url":"https://api.github.com/repos/KiCad/kicad-library-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KiCad/kicad-library-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KiCad/kicad-library-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/KiCad/kicad-library-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KiCad/kicad-library-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/KiCad/kicad-library-utils/languages","stargazers_url":"https://api.github.com/repos/KiCad/kicad-library-utils/stargazers","contributors_url":"https://api.github.com/repos/KiCad/kicad-library-utils/contributors","subscribers_url":"https://api.github.com/repos/KiCad/kicad-library-utils/subscribers","subscription_url":"https://api.github.com/repos/KiCad/kicad-library-utils/subscription","commits_url":"https://api.github.com/repos/KiCad/kicad-library-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/KiCad/kicad-library-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/KiCad/kicad-library-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/KiCad/kicad-library-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/KiCad/kicad-library-utils/contents/{+path}","compare_url":"https://api.github.com/repos/KiCad/kicad-library-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KiCad/kicad-library-utils/merges","archive_url":"https://api.github.com/repos/KiCad/kicad-library-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KiCad/kicad-library-utils/downloads","issues_url":"https://api.github.com/repos/KiCad/kicad-library-utils/issues{/number}","pulls_url":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/KiCad/kicad-library-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/KiCad/kicad-library-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KiCad/kicad-library-utils/labels{/name}","releases_url":"https://api.github.com/repos/KiCad/kicad-library-utils/releases{/id}","deployments_url":"https://api.github.com/repos/KiCad/kicad-library-utils/deployments","created_at":"2015-05-17T13:46:22Z","updated_at":"2017-04-01T22:48:36Z","pushed_at":"2017-04-07T12:50:55Z","git_url":"git://github.com/KiCad/kicad-library-utils.git","ssh_url":"git@github.com:KiCad/kicad-library-utils.git","clone_url":"https://github.com/KiCad/kicad-library-utils.git","svn_url":"https://github.com/KiCad/kicad-library-utils","homepage":null,"size":448,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":16,"forks":44,"open_issues":16,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/107"},"html":{"href":"https://github.com/KiCad/kicad-library-utils/pull/107"},"issue":{"href":"https://api.github.com/repos/KiCad/kicad-library-utils/issues/107"},"comments":{"href":"https://api.github.com/repos/KiCad/kicad-library-utils/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KiCad/kicad-library-utils/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/KiCad/kicad-library-utils/statuses/cb5938290c23cc943b6ddbe0fe470ff9ff289e27"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"SchrodingersGat","id":10080325,"avatar_url":"https://avatars2.githubusercontent.com/u/10080325?v=3","gravatar_id":"","url":"https://api.github.com/users/SchrodingersGat","html_url":"https://github.com/SchrodingersGat","followers_url":"https://api.github.com/users/SchrodingersGat/followers","following_url":"https://api.github.com/users/SchrodingersGat/following{/other_user}","gists_url":"https://api.github.com/users/SchrodingersGat/gists{/gist_id}","starred_url":"https://api.github.com/users/SchrodingersGat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchrodingersGat/subscriptions","organizations_url":"https://api.github.com/users/SchrodingersGat/orgs","repos_url":"https://api.github.com/users/SchrodingersGat/repos","events_url":"https://api.github.com/users/SchrodingersGat/events{/privacy}","received_events_url":"https://api.github.com/users/SchrodingersGat/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"SchrodingersGat"}}