{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/2","id":135953809,"html_url":"https://github.com/abcnews/odyssey-scrollyteller/pull/2","diff_url":"https://github.com/abcnews/odyssey-scrollyteller/pull/2.diff","patch_url":"https://github.com/abcnews/odyssey-scrollyteller/pull/2.patch","issue_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/issues/2","number":2,"state":"closed","locked":false,"title":"Changes to how sections and markers are loaded and fired","user":{"login":"nathanhoad","id":78984,"avatar_url":"https://avatars0.githubusercontent.com/u/78984?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanhoad","html_url":"https://github.com/nathanhoad","followers_url":"https://api.github.com/users/nathanhoad/followers","following_url":"https://api.github.com/users/nathanhoad/following{/other_user}","gists_url":"https://api.github.com/users/nathanhoad/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhoad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhoad/subscriptions","organizations_url":"https://api.github.com/users/nathanhoad/orgs","repos_url":"https://api.github.com/users/nathanhoad/repos","events_url":"https://api.github.com/users/nathanhoad/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhoad/received_events","type":"User","site_admin":false},"body":"* Plays nice with hot reload\r\n* The `#scrollyteller` sections are now loaded outside of the Preact cycle\r\n* Markers are now attached to the section that housed them (`section.markers`)\r\n* Markers now have a `.section` property that references their parent section\r\n* The `mark` event now only fires when the new marker is actually different to the previous one\r\n* Marker content is now the actual nodes extracted from the initial DOM (not their `outerHTML` like before)\r\n* Section/marker config now has some type parsing (for numbers and booleans... and arrays... kind of)\r\n* Markers with no config will now just copy the config from the previous marker\r\n* Markers with `rollupN` (N being a number) will now only group the next N nodes\r\n* Redundant pragma directives have been removed","created_at":"2017-08-16T07:00:23Z","updated_at":"2017-08-17T05:52:27Z","closed_at":"2017-08-17T05:52:27Z","merged_at":"2017-08-17T05:52:27Z","merge_commit_sha":"866cce1551cf6c34b8f42b16cc292cb32de8faef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/2/commits","review_comments_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/2/comments","review_comment_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/issues/2/comments","statuses_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/statuses/d25cc4f510c3f931a747ae0d92978312dfad332a","head":{"label":"nathanhoad:hot-reload","ref":"hot-reload","sha":"d25cc4f510c3f931a747ae0d92978312dfad332a","user":{"login":"nathanhoad","id":78984,"avatar_url":"https://avatars0.githubusercontent.com/u/78984?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanhoad","html_url":"https://github.com/nathanhoad","followers_url":"https://api.github.com/users/nathanhoad/followers","following_url":"https://api.github.com/users/nathanhoad/following{/other_user}","gists_url":"https://api.github.com/users/nathanhoad/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhoad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhoad/subscriptions","organizations_url":"https://api.github.com/users/nathanhoad/orgs","repos_url":"https://api.github.com/users/nathanhoad/repos","events_url":"https://api.github.com/users/nathanhoad/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhoad/received_events","type":"User","site_admin":false},"repo":{"id":100457626,"name":"odyssey-scrollyteller","full_name":"nathanhoad/odyssey-scrollyteller","owner":{"login":"nathanhoad","id":78984,"avatar_url":"https://avatars0.githubusercontent.com/u/78984?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanhoad","html_url":"https://github.com/nathanhoad","followers_url":"https://api.github.com/users/nathanhoad/followers","following_url":"https://api.github.com/users/nathanhoad/following{/other_user}","gists_url":"https://api.github.com/users/nathanhoad/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhoad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhoad/subscriptions","organizations_url":"https://api.github.com/users/nathanhoad/orgs","repos_url":"https://api.github.com/users/nathanhoad/repos","events_url":"https://api.github.com/users/nathanhoad/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhoad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanhoad/odyssey-scrollyteller","description":"A scrollytelling plugin for the Odyssey story format","fork":true,"url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller","forks_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/forks","keys_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/teams","hooks_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/hooks","issue_events_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/issues/events{/number}","events_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/events","assignees_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/assignees{/user}","branches_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/branches{/branch}","tags_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/tags","blobs_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/languages","stargazers_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/stargazers","contributors_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/contributors","subscribers_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/subscribers","subscription_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/subscription","commits_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/contents/{+path}","compare_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/merges","archive_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/downloads","issues_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/issues{/number}","pulls_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/labels{/name}","releases_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/releases{/id}","deployments_url":"https://api.github.com/repos/nathanhoad/odyssey-scrollyteller/deployments","created_at":"2017-08-16T06:51:42Z","updated_at":"2017-08-16T06:51:43Z","pushed_at":"2017-08-17T03:59:05Z","git_url":"git://github.com/nathanhoad/odyssey-scrollyteller.git","ssh_url":"git@github.com:nathanhoad/odyssey-scrollyteller.git","clone_url":"https://github.com/nathanhoad/odyssey-scrollyteller.git","svn_url":"https://github.com/nathanhoad/odyssey-scrollyteller","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abcnews:master","ref":"master","sha":"9a4022999fe6f51782dcbdc0b3bb8ae5f6b0794c","user":{"login":"abcnews","id":9651515,"avatar_url":"https://avatars2.githubusercontent.com/u/9651515?v=4","gravatar_id":"","url":"https://api.github.com/users/abcnews","html_url":"https://github.com/abcnews","followers_url":"https://api.github.com/users/abcnews/followers","following_url":"https://api.github.com/users/abcnews/following{/other_user}","gists_url":"https://api.github.com/users/abcnews/gists{/gist_id}","starred_url":"https://api.github.com/users/abcnews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abcnews/subscriptions","organizations_url":"https://api.github.com/users/abcnews/orgs","repos_url":"https://api.github.com/users/abcnews/repos","events_url":"https://api.github.com/users/abcnews/events{/privacy}","received_events_url":"https://api.github.com/users/abcnews/received_events","type":"Organization","site_admin":false},"repo":{"id":99630087,"name":"odyssey-scrollyteller","full_name":"abcnews/odyssey-scrollyteller","owner":{"login":"abcnews","id":9651515,"avatar_url":"https://avatars2.githubusercontent.com/u/9651515?v=4","gravatar_id":"","url":"https://api.github.com/users/abcnews","html_url":"https://github.com/abcnews","followers_url":"https://api.github.com/users/abcnews/followers","following_url":"https://api.github.com/users/abcnews/following{/other_user}","gists_url":"https://api.github.com/users/abcnews/gists{/gist_id}","starred_url":"https://api.github.com/users/abcnews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abcnews/subscriptions","organizations_url":"https://api.github.com/users/abcnews/orgs","repos_url":"https://api.github.com/users/abcnews/repos","events_url":"https://api.github.com/users/abcnews/events{/privacy}","received_events_url":"https://api.github.com/users/abcnews/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abcnews/odyssey-scrollyteller","description":"A scrollytelling plugin for the Odyssey story format","fork":false,"url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller","forks_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/forks","keys_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/teams","hooks_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/hooks","issue_events_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/issues/events{/number}","events_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/events","assignees_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/assignees{/user}","branches_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/branches{/branch}","tags_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/tags","blobs_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/git/refs{/sha}","trees_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/statuses/{sha}","languages_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/languages","stargazers_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/stargazers","contributors_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/contributors","subscribers_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/subscribers","subscription_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/subscription","commits_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/commits{/sha}","git_commits_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/git/commits{/sha}","comments_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/comments{/number}","issue_comment_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/issues/comments{/number}","contents_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/contents/{+path}","compare_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/merges","archive_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/downloads","issues_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/issues{/number}","pulls_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls{/number}","milestones_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/milestones{/number}","notifications_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/labels{/name}","releases_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/releases{/id}","deployments_url":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/deployments","created_at":"2017-08-07T23:42:26Z","updated_at":"2017-08-08T01:47:51Z","pushed_at":"2017-08-17T05:52:27Z","git_url":"git://github.com/abcnews/odyssey-scrollyteller.git","ssh_url":"git@github.com:abcnews/odyssey-scrollyteller.git","clone_url":"https://github.com/abcnews/odyssey-scrollyteller.git","svn_url":"https://github.com/abcnews/odyssey-scrollyteller","homepage":null,"size":177,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/2"},"html":{"href":"https://github.com/abcnews/odyssey-scrollyteller/pull/2"},"issue":{"href":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/issues/2"},"comments":{"href":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/abcnews/odyssey-scrollyteller/statuses/d25cc4f510c3f931a747ae0d92978312dfad332a"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"drzax","id":596563,"avatar_url":"https://avatars1.githubusercontent.com/u/596563?v=4","gravatar_id":"","url":"https://api.github.com/users/drzax","html_url":"https://github.com/drzax","followers_url":"https://api.github.com/users/drzax/followers","following_url":"https://api.github.com/users/drzax/following{/other_user}","gists_url":"https://api.github.com/users/drzax/gists{/gist_id}","starred_url":"https://api.github.com/users/drzax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drzax/subscriptions","organizations_url":"https://api.github.com/users/drzax/orgs","repos_url":"https://api.github.com/users/drzax/repos","events_url":"https://api.github.com/users/drzax/events{/privacy}","received_events_url":"https://api.github.com/users/drzax/received_events","type":"User","site_admin":false},"comments":1,"review_comments":7,"maintainer_can_modify":false,"commits":5,"additions":4698,"deletions":928,"changed_files":11}}
{"actor":{"display_login":"drzax"}}