{"action":"opened","number":1762,"pull_request":{"url":"https://api.github.com/repos/opnsense/core/pulls/1762","id":133958235,"html_url":"https://github.com/opnsense/core/pull/1762","diff_url":"https://github.com/opnsense/core/pull/1762.diff","patch_url":"https://github.com/opnsense/core/pull/1762.patch","issue_url":"https://api.github.com/repos/opnsense/core/issues/1762","number":1762,"state":"open","locked":false,"title":"proposal: new dialog to request confirmation","user":{"login":"fraenki","id":909706,"avatar_url":"https://avatars0.githubusercontent.com/u/909706?v=4","gravatar_id":"","url":"https://api.github.com/users/fraenki","html_url":"https://github.com/fraenki","followers_url":"https://api.github.com/users/fraenki/followers","following_url":"https://api.github.com/users/fraenki/following{/other_user}","gists_url":"https://api.github.com/users/fraenki/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenki/subscriptions","organizations_url":"https://api.github.com/users/fraenki/orgs","repos_url":"https://api.github.com/users/fraenki/repos","events_url":"https://api.github.com/users/fraenki/events{/privacy}","received_events_url":"https://api.github.com/users/fraenki/received_events","type":"User","site_admin":false},"body":"I needed a generic dialog (for plugins) to request a users confirmation for various actions. Currently there's only `stdDialogRemoveItem()` available, which really only suits the specific situation where one wants to remove an item, because the title reads \"Remove\":\r\n\r\n![dialog_remove](https://user-images.githubusercontent.com/909706/28926373-e1f9f92a-7867-11e7-8c1f-d82582d0c481.png)\r\n\r\nThe new dialog is more generic and the title only says \"Confirmation Required\", that makes it very reusable:\r\n\r\n![dialog_confirmation](https://user-images.githubusercontent.com/909706/28926390-efd0a986-7867-11e7-9e10-4ff19a3b0512.png)\r\n\r\nAdditionally, I am suggesting to replace `stdDialogRemoveItem()` with `stdDialogConfirmation()` everywhere. The old dialog is a little redundant in itself, the header says \"Remove\" and the text usually repeats this somehow. If you agree I'd do the work and submit an additional PRs for core and plugins.","created_at":"2017-08-03T14:26:55Z","updated_at":"2017-08-03T14:26:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opnsense/core/pulls/1762/commits","review_comments_url":"https://api.github.com/repos/opnsense/core/pulls/1762/comments","review_comment_url":"https://api.github.com/repos/opnsense/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opnsense/core/issues/1762/comments","statuses_url":"https://api.github.com/repos/opnsense/core/statuses/e7ef790f9bb7ff0ac2f6a4d393e15beb87a28ca3","head":{"label":"fraenki:js_confirm","ref":"js_confirm","sha":"e7ef790f9bb7ff0ac2f6a4d393e15beb87a28ca3","user":{"login":"fraenki","id":909706,"avatar_url":"https://avatars0.githubusercontent.com/u/909706?v=4","gravatar_id":"","url":"https://api.github.com/users/fraenki","html_url":"https://github.com/fraenki","followers_url":"https://api.github.com/users/fraenki/followers","following_url":"https://api.github.com/users/fraenki/following{/other_user}","gists_url":"https://api.github.com/users/fraenki/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenki/subscriptions","organizations_url":"https://api.github.com/users/fraenki/orgs","repos_url":"https://api.github.com/users/fraenki/repos","events_url":"https://api.github.com/users/fraenki/events{/privacy}","received_events_url":"https://api.github.com/users/fraenki/received_events","type":"User","site_admin":false},"repo":{"id":29302074,"name":"core","full_name":"fraenki/core","owner":{"login":"fraenki","id":909706,"avatar_url":"https://avatars0.githubusercontent.com/u/909706?v=4","gravatar_id":"","url":"https://api.github.com/users/fraenki","html_url":"https://github.com/fraenki","followers_url":"https://api.github.com/users/fraenki/followers","following_url":"https://api.github.com/users/fraenki/following{/other_user}","gists_url":"https://api.github.com/users/fraenki/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenki/subscriptions","organizations_url":"https://api.github.com/users/fraenki/orgs","repos_url":"https://api.github.com/users/fraenki/repos","events_url":"https://api.github.com/users/fraenki/events{/privacy}","received_events_url":"https://api.github.com/users/fraenki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fraenki/core","description":"OPNsense GUI and system management","fork":true,"url":"https://api.github.com/repos/fraenki/core","forks_url":"https://api.github.com/repos/fraenki/core/forks","keys_url":"https://api.github.com/repos/fraenki/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fraenki/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fraenki/core/teams","hooks_url":"https://api.github.com/repos/fraenki/core/hooks","issue_events_url":"https://api.github.com/repos/fraenki/core/issues/events{/number}","events_url":"https://api.github.com/repos/fraenki/core/events","assignees_url":"https://api.github.com/repos/fraenki/core/assignees{/user}","branches_url":"https://api.github.com/repos/fraenki/core/branches{/branch}","tags_url":"https://api.github.com/repos/fraenki/core/tags","blobs_url":"https://api.github.com/repos/fraenki/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fraenki/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fraenki/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/fraenki/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fraenki/core/statuses/{sha}","languages_url":"https://api.github.com/repos/fraenki/core/languages","stargazers_url":"https://api.github.com/repos/fraenki/core/stargazers","contributors_url":"https://api.github.com/repos/fraenki/core/contributors","subscribers_url":"https://api.github.com/repos/fraenki/core/subscribers","subscription_url":"https://api.github.com/repos/fraenki/core/subscription","commits_url":"https://api.github.com/repos/fraenki/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/fraenki/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/fraenki/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/fraenki/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/fraenki/core/contents/{+path}","compare_url":"https://api.github.com/repos/fraenki/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fraenki/core/merges","archive_url":"https://api.github.com/repos/fraenki/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fraenki/core/downloads","issues_url":"https://api.github.com/repos/fraenki/core/issues{/number}","pulls_url":"https://api.github.com/repos/fraenki/core/pulls{/number}","milestones_url":"https://api.github.com/repos/fraenki/core/milestones{/number}","notifications_url":"https://api.github.com/repos/fraenki/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fraenki/core/labels{/name}","releases_url":"https://api.github.com/repos/fraenki/core/releases{/id}","deployments_url":"https://api.github.com/repos/fraenki/core/deployments","created_at":"2015-01-15T14:52:16Z","updated_at":"2016-02-18T15:00:23Z","pushed_at":"2017-08-03T14:18:49Z","git_url":"git://github.com/fraenki/core.git","ssh_url":"git@github.com:fraenki/core.git","clone_url":"https://github.com/fraenki/core.git","svn_url":"https://github.com/fraenki/core","homepage":"","size":53459,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opnsense:master","ref":"master","sha":"3a61bc5fce87d1a6bd0330b83b2fb810b90738f9","user":{"login":"opnsense","id":9979117,"avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"repo":{"id":27965134,"name":"core","full_name":"opnsense/core","owner":{"login":"opnsense","id":9979117,"avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opnsense/core","description":"OPNsense GUI, API and systems backend","fork":false,"url":"https://api.github.com/repos/opnsense/core","forks_url":"https://api.github.com/repos/opnsense/core/forks","keys_url":"https://api.github.com/repos/opnsense/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opnsense/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opnsense/core/teams","hooks_url":"https://api.github.com/repos/opnsense/core/hooks","issue_events_url":"https://api.github.com/repos/opnsense/core/issues/events{/number}","events_url":"https://api.github.com/repos/opnsense/core/events","assignees_url":"https://api.github.com/repos/opnsense/core/assignees{/user}","branches_url":"https://api.github.com/repos/opnsense/core/branches{/branch}","tags_url":"https://api.github.com/repos/opnsense/core/tags","blobs_url":"https://api.github.com/repos/opnsense/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opnsense/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opnsense/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opnsense/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opnsense/core/statuses/{sha}","languages_url":"https://api.github.com/repos/opnsense/core/languages","stargazers_url":"https://api.github.com/repos/opnsense/core/stargazers","contributors_url":"https://api.github.com/repos/opnsense/core/contributors","subscribers_url":"https://api.github.com/repos/opnsense/core/subscribers","subscription_url":"https://api.github.com/repos/opnsense/core/subscription","commits_url":"https://api.github.com/repos/opnsense/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opnsense/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opnsense/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opnsense/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opnsense/core/contents/{+path}","compare_url":"https://api.github.com/repos/opnsense/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opnsense/core/merges","archive_url":"https://api.github.com/repos/opnsense/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opnsense/core/downloads","issues_url":"https://api.github.com/repos/opnsense/core/issues{/number}","pulls_url":"https://api.github.com/repos/opnsense/core/pulls{/number}","milestones_url":"https://api.github.com/repos/opnsense/core/milestones{/number}","notifications_url":"https://api.github.com/repos/opnsense/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opnsense/core/labels{/name}","releases_url":"https://api.github.com/repos/opnsense/core/releases{/id}","deployments_url":"https://api.github.com/repos/opnsense/core/deployments","created_at":"2014-12-13T15:43:50Z","updated_at":"2017-08-03T12:11:28Z","pushed_at":"2017-08-03T12:19:37Z","git_url":"git://github.com/opnsense/core.git","ssh_url":"git@github.com:opnsense/core.git","clone_url":"https://github.com/opnsense/core.git","svn_url":"https://github.com/opnsense/core","homepage":"https://opnsense.org/","size":56110,"stargazers_count":417,"watchers_count":417,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":183,"forks":137,"open_issues":183,"watchers":417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opnsense/core/pulls/1762"},"html":{"href":"https://github.com/opnsense/core/pull/1762"},"issue":{"href":"https://api.github.com/repos/opnsense/core/issues/1762"},"comments":{"href":"https://api.github.com/repos/opnsense/core/issues/1762/comments"},"review_comments":{"href":"https://api.github.com/repos/opnsense/core/pulls/1762/comments"},"review_comment":{"href":"https://api.github.com/repos/opnsense/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opnsense/core/pulls/1762/commits"},"statuses":{"href":"https://api.github.com/repos/opnsense/core/statuses/e7ef790f9bb7ff0ac2f6a4d393e15beb87a28ca3"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":19,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"fraenki"}}