{"action":"created","comment":{"url":"https://api.github.com/repos/apache/wicket/pulls/comments/129402793","pull_request_review_id":52172426,"id":129402793,"diff_hunk":"@@ -353,6 +353,7 @@ private void renderCombinedEventScripts()\n \t\t}\n \t\tif (combinedScript.length() > 0)\n \t\t{\n+\t\t\tcombinedScript.append(\"\\nWicket.Event.publish(Wicket.Event.Topic.AJAX_TIMERS_BOUND);\");","path":"wicket-core/src/main/java/org/apache/wicket/markup/head/ResourceAggregator.java","position":4,"original_position":4,"commit_id":"0e9f908e2e838ff85aea1db35e6ac6412f5023bf","original_commit_id":"0e9f908e2e838ff85aea1db35e6ac6412f5023bf","user":{"login":"Jezza","id":4224088,"avatar_url":"https://avatars0.githubusercontent.com/u/4224088?v=4","gravatar_id":"","url":"https://api.github.com/users/Jezza","html_url":"https://github.com/Jezza","followers_url":"https://api.github.com/users/Jezza/followers","following_url":"https://api.github.com/users/Jezza/following{/other_user}","gists_url":"https://api.github.com/users/Jezza/gists{/gist_id}","starred_url":"https://api.github.com/users/Jezza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jezza/subscriptions","organizations_url":"https://api.github.com/users/Jezza/orgs","repos_url":"https://api.github.com/users/Jezza/repos","events_url":"https://api.github.com/users/Jezza/events{/privacy}","received_events_url":"https://api.github.com/users/Jezza/received_events","type":"User","site_admin":false},"body":"The events themselves are closer to post-`load`s or post-`domready`s","created_at":"2017-07-25T19:31:18Z","updated_at":"2017-07-25T19:31:18Z","html_url":"https://github.com/apache/wicket/pull/223#discussion_r129402793","pull_request_url":"https://api.github.com/repos/apache/wicket/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/apache/wicket/pulls/comments/129402793"},"html":{"href":"https://github.com/apache/wicket/pull/223#discussion_r129402793"},"pull_request":{"href":"https://api.github.com/repos/apache/wicket/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/apache/wicket/pulls/223","id":132292816,"html_url":"https://github.com/apache/wicket/pull/223","diff_url":"https://github.com/apache/wicket/pull/223.diff","patch_url":"https://github.com/apache/wicket/pull/223.patch","issue_url":"https://api.github.com/repos/apache/wicket/issues/223","number":223,"state":"open","locked":false,"title":"WICKET-6427 Fire an event once all ajax timers are registered","user":{"login":"Jezza","id":4224088,"avatar_url":"https://avatars0.githubusercontent.com/u/4224088?v=4","gravatar_id":"","url":"https://api.github.com/users/Jezza","html_url":"https://github.com/Jezza","followers_url":"https://api.github.com/users/Jezza/followers","following_url":"https://api.github.com/users/Jezza/following{/other_user}","gists_url":"https://api.github.com/users/Jezza/gists{/gist_id}","starred_url":"https://api.github.com/users/Jezza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jezza/subscriptions","organizations_url":"https://api.github.com/users/Jezza/orgs","repos_url":"https://api.github.com/users/Jezza/repos","events_url":"https://api.github.com/users/Jezza/events{/privacy}","received_events_url":"https://api.github.com/users/Jezza/received_events","type":"User","site_admin":false},"body":"Fire Wicket.Event.Topic.AJAX_TIMERS_BOUND event once all Wicket.Timer.set() calls are executed","created_at":"2017-07-25T14:16:15Z","updated_at":"2017-07-25T19:31:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d301ab518aa2e6b459b282f6acf921b126c1d2a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/wicket/pulls/223/commits","review_comments_url":"https://api.github.com/repos/apache/wicket/pulls/223/comments","review_comment_url":"https://api.github.com/repos/apache/wicket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/wicket/issues/223/comments","statuses_url":"https://api.github.com/repos/apache/wicket/statuses/0e9f908e2e838ff85aea1db35e6ac6412f5023bf","head":{"label":"Jezza:master","ref":"master","sha":"0e9f908e2e838ff85aea1db35e6ac6412f5023bf","user":{"login":"Jezza","id":4224088,"avatar_url":"https://avatars0.githubusercontent.com/u/4224088?v=4","gravatar_id":"","url":"https://api.github.com/users/Jezza","html_url":"https://github.com/Jezza","followers_url":"https://api.github.com/users/Jezza/followers","following_url":"https://api.github.com/users/Jezza/following{/other_user}","gists_url":"https://api.github.com/users/Jezza/gists{/gist_id}","starred_url":"https://api.github.com/users/Jezza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jezza/subscriptions","organizations_url":"https://api.github.com/users/Jezza/orgs","repos_url":"https://api.github.com/users/Jezza/repos","events_url":"https://api.github.com/users/Jezza/events{/privacy}","received_events_url":"https://api.github.com/users/Jezza/received_events","type":"User","site_admin":false},"repo":{"id":98313036,"name":"wicket","full_name":"Jezza/wicket","owner":{"login":"Jezza","id":4224088,"avatar_url":"https://avatars0.githubusercontent.com/u/4224088?v=4","gravatar_id":"","url":"https://api.github.com/users/Jezza","html_url":"https://github.com/Jezza","followers_url":"https://api.github.com/users/Jezza/followers","following_url":"https://api.github.com/users/Jezza/following{/other_user}","gists_url":"https://api.github.com/users/Jezza/gists{/gist_id}","starred_url":"https://api.github.com/users/Jezza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jezza/subscriptions","organizations_url":"https://api.github.com/users/Jezza/orgs","repos_url":"https://api.github.com/users/Jezza/repos","events_url":"https://api.github.com/users/Jezza/events{/privacy}","received_events_url":"https://api.github.com/users/Jezza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jezza/wicket","description":"Mirror of Apache Wicket","fork":true,"url":"https://api.github.com/repos/Jezza/wicket","forks_url":"https://api.github.com/repos/Jezza/wicket/forks","keys_url":"https://api.github.com/repos/Jezza/wicket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jezza/wicket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jezza/wicket/teams","hooks_url":"https://api.github.com/repos/Jezza/wicket/hooks","issue_events_url":"https://api.github.com/repos/Jezza/wicket/issues/events{/number}","events_url":"https://api.github.com/repos/Jezza/wicket/events","assignees_url":"https://api.github.com/repos/Jezza/wicket/assignees{/user}","branches_url":"https://api.github.com/repos/Jezza/wicket/branches{/branch}","tags_url":"https://api.github.com/repos/Jezza/wicket/tags","blobs_url":"https://api.github.com/repos/Jezza/wicket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jezza/wicket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jezza/wicket/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jezza/wicket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jezza/wicket/statuses/{sha}","languages_url":"https://api.github.com/repos/Jezza/wicket/languages","stargazers_url":"https://api.github.com/repos/Jezza/wicket/stargazers","contributors_url":"https://api.github.com/repos/Jezza/wicket/contributors","subscribers_url":"https://api.github.com/repos/Jezza/wicket/subscribers","subscription_url":"https://api.github.com/repos/Jezza/wicket/subscription","commits_url":"https://api.github.com/repos/Jezza/wicket/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jezza/wicket/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jezza/wicket/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jezza/wicket/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jezza/wicket/contents/{+path}","compare_url":"https://api.github.com/repos/Jezza/wicket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jezza/wicket/merges","archive_url":"https://api.github.com/repos/Jezza/wicket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jezza/wicket/downloads","issues_url":"https://api.github.com/repos/Jezza/wicket/issues{/number}","pulls_url":"https://api.github.com/repos/Jezza/wicket/pulls{/number}","milestones_url":"https://api.github.com/repos/Jezza/wicket/milestones{/number}","notifications_url":"https://api.github.com/repos/Jezza/wicket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jezza/wicket/labels{/name}","releases_url":"https://api.github.com/repos/Jezza/wicket/releases{/id}","deployments_url":"https://api.github.com/repos/Jezza/wicket/deployments","created_at":"2017-07-25T14:06:06Z","updated_at":"2017-07-25T14:06:20Z","pushed_at":"2017-07-25T14:32:26Z","git_url":"git://github.com/Jezza/wicket.git","ssh_url":"git@github.com:Jezza/wicket.git","clone_url":"https://github.com/Jezza/wicket.git","svn_url":"https://github.com/Jezza/wicket","homepage":null,"size":112709,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ef909ab06ee69a3120f27f95280440e9828c75d6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206412,"name":"wicket","full_name":"apache/wicket","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/wicket","description":"Mirror of Apache Wicket","fork":false,"url":"https://api.github.com/repos/apache/wicket","forks_url":"https://api.github.com/repos/apache/wicket/forks","keys_url":"https://api.github.com/repos/apache/wicket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/wicket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/wicket/teams","hooks_url":"https://api.github.com/repos/apache/wicket/hooks","issue_events_url":"https://api.github.com/repos/apache/wicket/issues/events{/number}","events_url":"https://api.github.com/repos/apache/wicket/events","assignees_url":"https://api.github.com/repos/apache/wicket/assignees{/user}","branches_url":"https://api.github.com/repos/apache/wicket/branches{/branch}","tags_url":"https://api.github.com/repos/apache/wicket/tags","blobs_url":"https://api.github.com/repos/apache/wicket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/wicket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/wicket/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/wicket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/wicket/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/wicket/languages","stargazers_url":"https://api.github.com/repos/apache/wicket/stargazers","contributors_url":"https://api.github.com/repos/apache/wicket/contributors","subscribers_url":"https://api.github.com/repos/apache/wicket/subscribers","subscription_url":"https://api.github.com/repos/apache/wicket/subscription","commits_url":"https://api.github.com/repos/apache/wicket/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/wicket/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/wicket/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/wicket/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/wicket/contents/{+path}","compare_url":"https://api.github.com/repos/apache/wicket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/wicket/merges","archive_url":"https://api.github.com/repos/apache/wicket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/wicket/downloads","issues_url":"https://api.github.com/repos/apache/wicket/issues{/number}","pulls_url":"https://api.github.com/repos/apache/wicket/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/wicket/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/wicket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/wicket/labels{/name}","releases_url":"https://api.github.com/repos/apache/wicket/releases{/id}","deployments_url":"https://api.github.com/repos/apache/wicket/deployments","created_at":"2009-05-21T01:51:51Z","updated_at":"2017-07-22T16:26:20Z","pushed_at":"2017-07-25T19:26:10Z","git_url":"git://github.com/apache/wicket.git","ssh_url":"git@github.com:apache/wicket.git","clone_url":"https://github.com/apache/wicket.git","svn_url":"https://github.com/apache/wicket","homepage":null,"size":112700,"stargazers_count":379,"watchers_count":379,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":268,"mirror_url":"git://git.apache.org/wicket.git","open_issues_count":4,"forks":268,"open_issues":4,"watchers":379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/wicket/pulls/223"},"html":{"href":"https://github.com/apache/wicket/pull/223"},"issue":{"href":"https://api.github.com/repos/apache/wicket/issues/223"},"comments":{"href":"https://api.github.com/repos/apache/wicket/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/wicket/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/wicket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/wicket/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/apache/wicket/statuses/0e9f908e2e838ff85aea1db35e6ac6412f5023bf"}}}}
{"actor":{"display_login":"Jezza"}}