{"action":"created","issue":{"url":"https://api.github.com/repos/eclipsesource/tabris-js/issues/1488","repository_url":"https://api.github.com/repos/eclipsesource/tabris-js","labels_url":"https://api.github.com/repos/eclipsesource/tabris-js/issues/1488/labels{/name}","comments_url":"https://api.github.com/repos/eclipsesource/tabris-js/issues/1488/comments","events_url":"https://api.github.com/repos/eclipsesource/tabris-js/issues/1488/events","html_url":"https://github.com/eclipsesource/tabris-js/issues/1488","id":257318550,"number":1488,"title":"In some cases, images are unexpectedly laid out in physical pixels","user":{"login":"cpetrov","id":2341769,"avatar_url":"https://avatars1.githubusercontent.com/u/2341769?v=4","gravatar_id":"","url":"https://api.github.com/users/cpetrov","html_url":"https://github.com/cpetrov","followers_url":"https://api.github.com/users/cpetrov/followers","following_url":"https://api.github.com/users/cpetrov/following{/other_user}","gists_url":"https://api.github.com/users/cpetrov/gists{/gist_id}","starred_url":"https://api.github.com/users/cpetrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpetrov/subscriptions","organizations_url":"https://api.github.com/users/cpetrov/orgs","repos_url":"https://api.github.com/users/cpetrov/repos","events_url":"https://api.github.com/users/cpetrov/events{/privacy}","received_events_url":"https://api.github.com/users/cpetrov/received_events","type":"User","site_admin":false},"labels":[{"id":99273081,"url":"https://api.github.com/repos/eclipsesource/tabris-js/labels/bug","name":"bug","color":"d93f0b","default":true},{"id":317919075,"url":"https://api.github.com/repos/eclipsesource/tabris-js/labels/ios","name":"ios","color":"007aff","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-13T09:41:34Z","updated_at":"2017-09-14T11:44:43Z","closed_at":"2017-09-14T11:44:43Z","author_association":"MEMBER","body":"### Problem description\r\n\r\nSince 2.1, images are laid out in physical pixels instead of device independent pixels when:\r\n\r\n  * the `scaleMode` of the ImageView is set to _auto_ and:\r\n    * the size of the ImageView is bigger than the size of the picture in DIPs\r\n    ... or ...\r\n    * the ImageView does not have explicit size\r\n\r\n    ... or ... \r\n  * the `scaleMode` of the ImageView is set to _none_\r\n\r\n### Expected behavior\r\n\r\nWith the current behavior on Tabris.js, pictures should always be laid out in device independent pixels for those cases. This ensures consistent layout among devices with the same size but with different pixel densities. In case downscaling is needed to prevent pixelized images, the `scale` property of the [`Image`](https://tabrisjs.com/documentation/latest/types.html#image) should be explicitly set.\r\n\r\n### Environment\r\n\r\n- Tabris.js version: 2.1\r\n- Device: iPhone 5s (scale factor 2), Samsung J3 (scale factor 2)\r\n- OS: iOS 10, Android 5.1.1\r\n\r\n### Code snippet\r\n\r\nSee the [imageview-as-a-button.js](https://github.com/eclipsesource/tabris-js/blob/master/snippets/imageview-as-a-button.js) snippet.\r\n\r\n| iPhone 5s (scale factor 2) | Samsung J3 (scale factor 2) |\r\n| --- | --- |\r\n|![img_0056](https://user-images.githubusercontent.com/2341769/30370390-ba5ebb28-9877-11e7-80a0-28035339a273.PNG)|![screenshot_2017-09-13-11-04-07](https://user-images.githubusercontent.com/2341769/30370399-bebbfdf2-9877-11e7-86fe-da9d323e3904.png)|\r\n"},"comment":{"url":"https://api.github.com/repos/eclipsesource/tabris-js/issues/comments/329457227","html_url":"https://github.com/eclipsesource/tabris-js/issues/1488#issuecomment-329457227","issue_url":"https://api.github.com/repos/eclipsesource/tabris-js/issues/1488","id":329457227,"user":{"login":"karolszafranski","id":1746396,"avatar_url":"https://avatars0.githubusercontent.com/u/1746396?v=4","gravatar_id":"","url":"https://api.github.com/users/karolszafranski","html_url":"https://github.com/karolszafranski","followers_url":"https://api.github.com/users/karolszafranski/followers","following_url":"https://api.github.com/users/karolszafranski/following{/other_user}","gists_url":"https://api.github.com/users/karolszafranski/gists{/gist_id}","starred_url":"https://api.github.com/users/karolszafranski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karolszafranski/subscriptions","organizations_url":"https://api.github.com/users/karolszafranski/orgs","repos_url":"https://api.github.com/users/karolszafranski/repos","events_url":"https://api.github.com/users/karolszafranski/events{/privacy}","received_events_url":"https://api.github.com/users/karolszafranski/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T11:44:42Z","updated_at":"2017-09-14T11:44:42Z","author_association":"NONE","body":"fixed https://github.com/eclipsesource/tabris-ios/commit/1a7086c5f4df0792475f0d3825fa6a7d31a2497a"}}
{"actor":{"display_login":"karolszafranski"}}