{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4880","repository_url":"https://api.github.com/repos/checkstyle/checkstyle","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4880/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4880/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4880/events","html_url":"https://github.com/checkstyle/checkstyle/pull/4880","id":247226889,"number":4880,"title":"Issue #4563: fixed stackoverflow with DetailAST.setParent","user":{"login":"rnveach","id":5427943,"avatar_url":"https://avatars1.githubusercontent.com/u/5427943?v=4","gravatar_id":"","url":"https://api.github.com/users/rnveach","html_url":"https://github.com/rnveach","followers_url":"https://api.github.com/users/rnveach/followers","following_url":"https://api.github.com/users/rnveach/following{/other_user}","gists_url":"https://api.github.com/users/rnveach/gists{/gist_id}","starred_url":"https://api.github.com/users/rnveach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnveach/subscriptions","organizations_url":"https://api.github.com/users/rnveach/orgs","repos_url":"https://api.github.com/users/rnveach/repos","events_url":"https://api.github.com/users/rnveach/events{/privacy}","received_events_url":"https://api.github.com/users/rnveach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-01T23:01:24Z","updated_at":"2017-08-01T23:14:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/4880","html_url":"https://github.com/checkstyle/checkstyle/pull/4880","diff_url":"https://github.com/checkstyle/checkstyle/pull/4880.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/4880.patch"},"body":"Issue #4563\r\n\r\nRewrote `setParent` to not do a recursive call but to use a loop instead.\r\n\r\n`testManyComments` was written in a way to avoid putting a 300kb input file into our repository.\r\nIt added 9 seconds runtime on my local PC.\r\n\r\ni assume we don't need regression."},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/319522889","html_url":"https://github.com/checkstyle/checkstyle/pull/4880#issuecomment-319522889","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4880","id":319522889,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-08-01T23:14:24Z","updated_at":"2017-08-01T23:14:24Z","body":"# [Codecov](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=h1) Report\n> Merging [#4880](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=desc) into [master](https://codecov.io/gh/checkstyle/checkstyle/commit/6d290adcd7efb8e9f07d2730e9960c6dc3e713ba?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/checkstyle/checkstyle/pull/4880/graphs/tree.svg?src=pr&token=HmuRTKNFTz&width=650&height=150)](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=tree)\n\n```diff\n@@          Coverage Diff           @@\n##           master   #4880   +/-   ##\n======================================\n  Coverage     100%    100%           \n======================================\n  Files         287     287           \n  Lines       15481   15483    +2     \n  Branches     3513    3514    +1     \n======================================\n+ Hits        15481   15483    +2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...com/puppycrawl/tools/checkstyle/api/DetailAST.java](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vcHVwcHljcmF3bC90b29scy9jaGVja3N0eWxlL2FwaS9EZXRhaWxBU1QuamF2YQ==) | `100% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=footer). Last update [6d290ad...54ab89d](https://codecov.io/gh/checkstyle/checkstyle/pull/4880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}