{"action":"created","comment":{"url":"https://api.github.com/repos/cncf/k8s-conformance/pulls/comments/147501852","pull_request_review_id":72612832,"id":147501852,"diff_hunk":"@@ -1,5 +1,5 @@\n # How to review conformance results\n \n   1. Make sure the list of files matches [the one specified here](https://github.com/cncf/k8s-conformance/blob/master/instructions.md#contents-of-the-pr)\n-  2. Look at `version.txt`.  Make sure the `client` and `server` versions match each other to the minor version level.  Make sure this also matches the `vX.Y` subdirectory that the PR is in.\n+  2. Look at `version.txt`.  Make sure the `client` version is no more than one minor version greater than the `server` version ","path":"reviewing.md","position":5,"original_position":5,"commit_id":"bb9f06994e3f91b99223acb1f56fa9ab831d529a","original_commit_id":"bb9f06994e3f91b99223acb1f56fa9ab831d529a","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"Sorry I mis-read this now when I re-read it.. I'll swap back.. but the other comment below applies. ","created_at":"2017-10-27T19:50:33Z","updated_at":"2017-10-27T19:50:33Z","html_url":"https://github.com/cncf/k8s-conformance/pull/24#discussion_r147501852","pull_request_url":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cncf/k8s-conformance/pulls/comments/147501852"},"html":{"href":"https://github.com/cncf/k8s-conformance/pull/24#discussion_r147501852"},"pull_request":{"href":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24"}},"in_reply_to_id":147487726},"pull_request":{"url":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24","id":148431588,"html_url":"https://github.com/cncf/k8s-conformance/pull/24","diff_url":"https://github.com/cncf/k8s-conformance/pull/24.diff","patch_url":"https://github.com/cncf/k8s-conformance/pull/24.patch","issue_url":"https://api.github.com/repos/cncf/k8s-conformance/issues/24","number":24,"state":"open","locked":false,"title":"Clarifies some of the instructions ","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"Updates the instructions to be more clear and to remove some of the ambiguity that folks have had.  \r\n\r\nFixes #17 \r\nFixes #6 \r\n\r\n/cc @mml @smarterclayton @aaronlevy  @WilliamDenniss ","created_at":"2017-10-24T15:27:27Z","updated_at":"2017-10-27T19:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a294ccdeba62e9d94520068324f662b67dc45aa7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24/commits","review_comments_url":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24/comments","review_comment_url":"https://api.github.com/repos/cncf/k8s-conformance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cncf/k8s-conformance/issues/24/comments","statuses_url":"https://api.github.com/repos/cncf/k8s-conformance/statuses/bb9f06994e3f91b99223acb1f56fa9ab831d529a","head":{"label":"timothysc:clearup","ref":"clearup","sha":"bb9f06994e3f91b99223acb1f56fa9ab831d529a","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"repo":{"id":108145943,"name":"k8s-conformance","full_name":"timothysc/k8s-conformance","owner":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timothysc/k8s-conformance","description":"CNCF K8s Conformance Working Group","fork":true,"url":"https://api.github.com/repos/timothysc/k8s-conformance","forks_url":"https://api.github.com/repos/timothysc/k8s-conformance/forks","keys_url":"https://api.github.com/repos/timothysc/k8s-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timothysc/k8s-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timothysc/k8s-conformance/teams","hooks_url":"https://api.github.com/repos/timothysc/k8s-conformance/hooks","issue_events_url":"https://api.github.com/repos/timothysc/k8s-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/timothysc/k8s-conformance/events","assignees_url":"https://api.github.com/repos/timothysc/k8s-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/timothysc/k8s-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/timothysc/k8s-conformance/tags","blobs_url":"https://api.github.com/repos/timothysc/k8s-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timothysc/k8s-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timothysc/k8s-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/timothysc/k8s-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timothysc/k8s-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/timothysc/k8s-conformance/languages","stargazers_url":"https://api.github.com/repos/timothysc/k8s-conformance/stargazers","contributors_url":"https://api.github.com/repos/timothysc/k8s-conformance/contributors","subscribers_url":"https://api.github.com/repos/timothysc/k8s-conformance/subscribers","subscription_url":"https://api.github.com/repos/timothysc/k8s-conformance/subscription","commits_url":"https://api.github.com/repos/timothysc/k8s-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/timothysc/k8s-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/timothysc/k8s-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/timothysc/k8s-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/timothysc/k8s-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/timothysc/k8s-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timothysc/k8s-conformance/merges","archive_url":"https://api.github.com/repos/timothysc/k8s-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timothysc/k8s-conformance/downloads","issues_url":"https://api.github.com/repos/timothysc/k8s-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/timothysc/k8s-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/timothysc/k8s-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/timothysc/k8s-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timothysc/k8s-conformance/labels{/name}","releases_url":"https://api.github.com/repos/timothysc/k8s-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/timothysc/k8s-conformance/deployments","created_at":"2017-10-24T15:21:49Z","updated_at":"2017-10-24T11:56:42Z","pushed_at":"2017-10-27T15:07:46Z","git_url":"git://github.com/timothysc/k8s-conformance.git","ssh_url":"git@github.com:timothysc/k8s-conformance.git","clone_url":"https://github.com/timothysc/k8s-conformance.git","svn_url":"https://github.com/timothysc/k8s-conformance","homepage":"https://cncf.io","size":22,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cncf:master","ref":"master","sha":"0f79c17640564ee038db9f4513b8fecbf471504b","user":{"login":"cncf","id":13455738,"avatar_url":"https://avatars2.githubusercontent.com/u/13455738?v=4","gravatar_id":"","url":"https://api.github.com/users/cncf","html_url":"https://github.com/cncf","followers_url":"https://api.github.com/users/cncf/followers","following_url":"https://api.github.com/users/cncf/following{/other_user}","gists_url":"https://api.github.com/users/cncf/gists{/gist_id}","starred_url":"https://api.github.com/users/cncf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cncf/subscriptions","organizations_url":"https://api.github.com/users/cncf/orgs","repos_url":"https://api.github.com/users/cncf/repos","events_url":"https://api.github.com/users/cncf/events{/privacy}","received_events_url":"https://api.github.com/users/cncf/received_events","type":"Organization","site_admin":false},"repo":{"id":99268620,"name":"k8s-conformance","full_name":"cncf/k8s-conformance","owner":{"login":"cncf","id":13455738,"avatar_url":"https://avatars2.githubusercontent.com/u/13455738?v=4","gravatar_id":"","url":"https://api.github.com/users/cncf","html_url":"https://github.com/cncf","followers_url":"https://api.github.com/users/cncf/followers","following_url":"https://api.github.com/users/cncf/following{/other_user}","gists_url":"https://api.github.com/users/cncf/gists{/gist_id}","starred_url":"https://api.github.com/users/cncf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cncf/subscriptions","organizations_url":"https://api.github.com/users/cncf/orgs","repos_url":"https://api.github.com/users/cncf/repos","events_url":"https://api.github.com/users/cncf/events{/privacy}","received_events_url":"https://api.github.com/users/cncf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cncf/k8s-conformance","description":"CNCF K8s Conformance Working Group","fork":false,"url":"https://api.github.com/repos/cncf/k8s-conformance","forks_url":"https://api.github.com/repos/cncf/k8s-conformance/forks","keys_url":"https://api.github.com/repos/cncf/k8s-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cncf/k8s-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cncf/k8s-conformance/teams","hooks_url":"https://api.github.com/repos/cncf/k8s-conformance/hooks","issue_events_url":"https://api.github.com/repos/cncf/k8s-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/cncf/k8s-conformance/events","assignees_url":"https://api.github.com/repos/cncf/k8s-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/cncf/k8s-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/cncf/k8s-conformance/tags","blobs_url":"https://api.github.com/repos/cncf/k8s-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cncf/k8s-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cncf/k8s-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/cncf/k8s-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cncf/k8s-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/cncf/k8s-conformance/languages","stargazers_url":"https://api.github.com/repos/cncf/k8s-conformance/stargazers","contributors_url":"https://api.github.com/repos/cncf/k8s-conformance/contributors","subscribers_url":"https://api.github.com/repos/cncf/k8s-conformance/subscribers","subscription_url":"https://api.github.com/repos/cncf/k8s-conformance/subscription","commits_url":"https://api.github.com/repos/cncf/k8s-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/cncf/k8s-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/cncf/k8s-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/cncf/k8s-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/cncf/k8s-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/cncf/k8s-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cncf/k8s-conformance/merges","archive_url":"https://api.github.com/repos/cncf/k8s-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cncf/k8s-conformance/downloads","issues_url":"https://api.github.com/repos/cncf/k8s-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/cncf/k8s-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/cncf/k8s-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/cncf/k8s-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cncf/k8s-conformance/labels{/name}","releases_url":"https://api.github.com/repos/cncf/k8s-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/cncf/k8s-conformance/deployments","created_at":"2017-08-03T19:38:09Z","updated_at":"2017-10-26T04:01:00Z","pushed_at":"2017-10-27T19:49:19Z","git_url":"git://github.com/cncf/k8s-conformance.git","ssh_url":"git@github.com:cncf/k8s-conformance.git","clone_url":"https://github.com/cncf/k8s-conformance.git","svn_url":"https://github.com/cncf/k8s-conformance","homepage":"https://cncf.io","size":22,"stargazers_count":35,"watchers_count":35,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":18,"forks":22,"open_issues":18,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24"},"html":{"href":"https://github.com/cncf/k8s-conformance/pull/24"},"issue":{"href":"https://api.github.com/repos/cncf/k8s-conformance/issues/24"},"comments":{"href":"https://api.github.com/repos/cncf/k8s-conformance/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/cncf/k8s-conformance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cncf/k8s-conformance/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/cncf/k8s-conformance/statuses/bb9f06994e3f91b99223acb1f56fa9ab831d529a"}},"author_association":"NONE"}}
{"actor":{"display_login":"timothysc"}}