{"action":"created","issue":{"url":"https://api.github.com/repos/robiso/wondercms/issues/28","repository_url":"https://api.github.com/repos/robiso/wondercms","labels_url":"https://api.github.com/repos/robiso/wondercms/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/robiso/wondercms/issues/28/comments","events_url":"https://api.github.com/repos/robiso/wondercms/issues/28/events","html_url":"https://github.com/robiso/wondercms/pull/28","id":223949898,"number":28,"title":"Use relative instead of absolute link in wCMS::url(); Change to cURL for grabbing version number.","user":{"login":"Alamantus","id":7747935,"avatar_url":"https://avatars2.githubusercontent.com/u/7747935?v=3","gravatar_id":"","url":"https://api.github.com/users/Alamantus","html_url":"https://github.com/Alamantus","followers_url":"https://api.github.com/users/Alamantus/followers","following_url":"https://api.github.com/users/Alamantus/following{/other_user}","gists_url":"https://api.github.com/users/Alamantus/gists{/gist_id}","starred_url":"https://api.github.com/users/Alamantus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alamantus/subscriptions","organizations_url":"https://api.github.com/users/Alamantus/orgs","repos_url":"https://api.github.com/users/Alamantus/repos","events_url":"https://api.github.com/users/Alamantus/events{/privacy}","received_events_url":"https://api.github.com/users/Alamantus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-04-24T21:01:13Z","updated_at":"2017-04-27T22:50:16Z","closed_at":"2017-04-27T11:06:53Z","pull_request":{"url":"https://api.github.com/repos/robiso/wondercms/pulls/28","html_url":"https://github.com/robiso/wondercms/pull/28","diff_url":"https://github.com/robiso/wondercms/pull/28.diff","patch_url":"https://github.com/robiso/wondercms/pull/28.patch"},"body":"When using `wCMS::url()` as delivered on my web host, it was returning insanely long urls because of how my host's server is set up. Since all pages are displayed on the same level and because `wCMS::url()` is only used for system/menu navigation, switching this from a full url that relies on `$_SERVER['DOCUMENT_ROOT']` to a simple relative `./` link allows the method to work appropriately no matter where WonderCMS is installed.\r\n\r\nAlso, my server was never able to grab the version number from `https://raw.githubusercontent.com/robiso/wondercms/master/version` because it is cross-domain _and_ cross-protocol (http-to-https), which meant that PHP's `file_get_contents()` function did not work. Adding a private `wCMS::_getOfficialVersion()` method that uses cURL to access the `version` file worked more reliably because that is cURL's intended use, while `file_get_contents()` is mostly intended for getting contents from the same domain."},"comment":{"url":"https://api.github.com/repos/robiso/wondercms/issues/comments/297860502","html_url":"https://github.com/robiso/wondercms/pull/28#issuecomment-297860502","issue_url":"https://api.github.com/repos/robiso/wondercms/issues/28","id":297860502,"user":{"login":"robiso","id":6200139,"avatar_url":"https://avatars1.githubusercontent.com/u/6200139?v=3","gravatar_id":"","url":"https://api.github.com/users/robiso","html_url":"https://github.com/robiso","followers_url":"https://api.github.com/users/robiso/followers","following_url":"https://api.github.com/users/robiso/following{/other_user}","gists_url":"https://api.github.com/users/robiso/gists{/gist_id}","starred_url":"https://api.github.com/users/robiso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robiso/subscriptions","organizations_url":"https://api.github.com/users/robiso/orgs","repos_url":"https://api.github.com/users/robiso/repos","events_url":"https://api.github.com/users/robiso/events{/privacy}","received_events_url":"https://api.github.com/users/robiso/received_events","type":"User","site_admin":false},"created_at":"2017-04-27T22:50:16Z","updated_at":"2017-04-27T22:50:16Z","body":"Thank you very much Robbie, 2.0.5 pushing out as we speak! Credits also added. :+1: \r\n\r\nI think the most appropriate place to write this is the wiki? If you agree I'll add it there."}}
{"actor":{"display_login":"robiso"}}