{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/154409523","pull_request_review_id":80574635,"id":154409523,"diff_hunk":"@@ -177,15 +180,20 @@ public SchemaKStream buildStream(final StreamsBuilder builder,\n \n   }\n \n-  private SchemaKTable tableForJoin(\n+  // package private for test\n+  SchemaKTable tableForJoin(\n       final StreamsBuilder builder,\n       final KsqlConfig ksqlConfig,\n       final KafkaTopicClient kafkaTopicClient,\n       final MetastoreUtil metastoreUtil,\n       final FunctionRegistry functionRegistry,\n       final Map<String, Object> props) {\n \n-    final SchemaKStream schemaKStream = right.buildStream(builder, ksqlConfig, kafkaTopicClient, metastoreUtil, functionRegistry, props);\n+    Map<String, Object> joinTableProps = new HashMap<>();\n+    joinTableProps.putAll(props);\n+    joinTableProps.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, \"EARLIEST\");","path":"ksql-engine/src/main/java/io/confluent/ksql/planner/plan/JoinNode.java","position":33,"original_position":33,"commit_id":"9f2dab6339812d21f7b702e423759490d85cc98e","original_commit_id":"9f2dab6339812d21f7b702e423759490d85cc98e","user":{"login":"hjafarpour","id":16784742,"avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"body":"`auto.offset.reset` is configurable for KSQL, however, this one is a special case for Stream-Table join and is required to always be `earliest` and if we have it as `latest` the join would be incorrect.","created_at":"2017-12-01T18:07:05Z","updated_at":"2017-12-01T18:07:05Z","html_url":"https://github.com/confluentinc/ksql/pull/495#discussion_r154409523","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/495","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/154409523"},"html":{"href":"https://github.com/confluentinc/ksql/pull/495#discussion_r154409523"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/495"}},"in_reply_to_id":154300714},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/495","id":155739531,"html_url":"https://github.com/confluentinc/ksql/pull/495","diff_url":"https://github.com/confluentinc/ksql/pull/495.diff","patch_url":"https://github.com/confluentinc/ksql/pull/495.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/495","number":495,"state":"open","locked":false,"title":"Fixed the regression for stream-table join. Table should always read …","user":{"login":"hjafarpour","id":16784742,"avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"body":"…from the beginning of the topic.\r\n","created_at":"2017-11-30T22:47:19Z","updated_at":"2017-12-01T18:07:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bf9ad07a8177ebf10d934ecb367af3662bba8b4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"apurvam","id":830220,"avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/495/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/495/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/495/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/9f2dab6339812d21f7b702e423759490d85cc98e","head":{"label":"hjafarpour:Stream-Table-Join-Regression-Fix","ref":"Stream-Table-Join-Regression-Fix","sha":"9f2dab6339812d21f7b702e423759490d85cc98e","user":{"login":"hjafarpour","id":16784742,"avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"repo":{"id":102027996,"name":"ksql","full_name":"hjafarpour/ksql","owner":{"login":"hjafarpour","id":16784742,"avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjafarpour/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/hjafarpour/ksql","forks_url":"https://api.github.com/repos/hjafarpour/ksql/forks","keys_url":"https://api.github.com/repos/hjafarpour/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjafarpour/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjafarpour/ksql/teams","hooks_url":"https://api.github.com/repos/hjafarpour/ksql/hooks","issue_events_url":"https://api.github.com/repos/hjafarpour/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/hjafarpour/ksql/events","assignees_url":"https://api.github.com/repos/hjafarpour/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/hjafarpour/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/hjafarpour/ksql/tags","blobs_url":"https://api.github.com/repos/hjafarpour/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjafarpour/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjafarpour/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjafarpour/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjafarpour/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/hjafarpour/ksql/languages","stargazers_url":"https://api.github.com/repos/hjafarpour/ksql/stargazers","contributors_url":"https://api.github.com/repos/hjafarpour/ksql/contributors","subscribers_url":"https://api.github.com/repos/hjafarpour/ksql/subscribers","subscription_url":"https://api.github.com/repos/hjafarpour/ksql/subscription","commits_url":"https://api.github.com/repos/hjafarpour/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjafarpour/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjafarpour/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjafarpour/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjafarpour/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/hjafarpour/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjafarpour/ksql/merges","archive_url":"https://api.github.com/repos/hjafarpour/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjafarpour/ksql/downloads","issues_url":"https://api.github.com/repos/hjafarpour/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/hjafarpour/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/hjafarpour/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/hjafarpour/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjafarpour/ksql/labels{/name}","releases_url":"https://api.github.com/repos/hjafarpour/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/hjafarpour/ksql/deployments","created_at":"2017-08-31T17:43:25Z","updated_at":"2017-08-31T18:12:01Z","pushed_at":"2017-12-01T07:03:53Z","git_url":"git://github.com/hjafarpour/ksql.git","ssh_url":"git@github.com:hjafarpour/ksql.git","clone_url":"https://github.com/hjafarpour/ksql.git","svn_url":"https://github.com/hjafarpour/ksql","homepage":"","size":5414,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:4.0.x","ref":"4.0.x","sha":"20fc30397f5cae522f24850a69ce8db1219e1c01","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2017-12-01T05:44:14Z","pushed_at":"2017-12-01T17:38:32Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":5201,"stargazers_count":1152,"watchers_count":1152,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":195,"open_issues":60,"watchers":1152,"default_branch":"4.0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/495"},"html":{"href":"https://github.com/confluentinc/ksql/pull/495"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/495"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/9f2dab6339812d21f7b702e423759490d85cc98e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hjafarpour"}}