{"action":"created","issue":{"url":"https://api.github.com/repos/openstyles/stylus/issues/251","repository_url":"https://api.github.com/repos/openstyles/stylus","labels_url":"https://api.github.com/repos/openstyles/stylus/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/openstyles/stylus/issues/251/comments","events_url":"https://api.github.com/repos/openstyles/stylus/issues/251/events","html_url":"https://github.com/openstyles/stylus/pull/251","id":275229601,"number":251,"title":"Show styles from userstyles.org in Stylus popup","user":{"login":"derv82","id":993464,"avatar_url":"https://avatars3.githubusercontent.com/u/993464?v=4","gravatar_id":"","url":"https://api.github.com/users/derv82","html_url":"https://github.com/derv82","followers_url":"https://api.github.com/users/derv82/followers","following_url":"https://api.github.com/users/derv82/following{/other_user}","gists_url":"https://api.github.com/users/derv82/gists{/gist_id}","starred_url":"https://api.github.com/users/derv82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derv82/subscriptions","organizations_url":"https://api.github.com/users/derv82/orgs","repos_url":"https://api.github.com/users/derv82/repos","events_url":"https://api.github.com/users/derv82/events{/privacy}","received_events_url":"https://api.github.com/users/derv82/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":54,"created_at":"2017-11-20T03:48:41Z","updated_at":"2017-12-12T02:08:04Z","closed_at":"2017-12-09T21:03:18Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openstyles/stylus/pulls/251","html_url":"https://github.com/openstyles/stylus/pull/251","diff_url":"https://github.com/openstyles/stylus/pull/251.diff","patch_url":"https://github.com/openstyles/stylus/pull/251.patch"},"body":"Feature request / enhancement issue: https://github.com/openstyles/stylus/issues/243\r\n\r\nNotes on the first revision of the PR:\r\n\r\n1. I installed `editorconfig` and made my changes using *VisualStudio Code*. Let me know if the formatting is off...\r\n2. `searchResults.js` is encapsulated to only expose `UserStylesAPI` and `SearchResults`\r\n3. Before trying to install the style (`searchResults.js:215`), I fetch the Style object from userstyles.org's API. Sample request: https://userstyles.org/api/v1/styles/70271\r\n   * Should I pull the `style` from somewhere else on the site? E.g. the UserScripts Greasemonkey/Tampermonkey code?\r\n   * Would it be easier to load the actual HTML style page in a hidden iframe, and install it from there?"},"comment":{"url":"https://api.github.com/repos/openstyles/stylus/issues/comments/350921828","html_url":"https://github.com/openstyles/stylus/pull/251#issuecomment-350921828","issue_url":"https://api.github.com/repos/openstyles/stylus/issues/251","id":350921828,"user":{"login":"narcolepticinsomniac","id":14100003,"avatar_url":"https://avatars3.githubusercontent.com/u/14100003?v=4","gravatar_id":"","url":"https://api.github.com/users/narcolepticinsomniac","html_url":"https://github.com/narcolepticinsomniac","followers_url":"https://api.github.com/users/narcolepticinsomniac/followers","following_url":"https://api.github.com/users/narcolepticinsomniac/following{/other_user}","gists_url":"https://api.github.com/users/narcolepticinsomniac/gists{/gist_id}","starred_url":"https://api.github.com/users/narcolepticinsomniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narcolepticinsomniac/subscriptions","organizations_url":"https://api.github.com/users/narcolepticinsomniac/orgs","repos_url":"https://api.github.com/users/narcolepticinsomniac/repos","events_url":"https://api.github.com/users/narcolepticinsomniac/events{/privacy}","received_events_url":"https://api.github.com/users/narcolepticinsomniac/received_events","type":"User","site_admin":false},"created_at":"2017-12-12T02:08:04Z","updated_at":"2017-12-12T02:08:04Z","author_association":"OWNER","body":"Overflow from inline \"find styles\" currently places scrollbars on the popup itself. With a dark style and \"add borders\" enabled, borders are inside the scrollbars, which isn't a good look:\r\n\r\n![popup-overfow](https://user-images.githubusercontent.com/14100003/33863627-aabe3da8-deb6-11e7-8644-f874da068fa5.png)\r\n\r\nSince there's a hard limit on popup height, we can fix it by adding a max-height:\r\n\r\n```\r\nhtml, body {\r\n  height: min-content;\r\n  max-height: 600px;\r\n}\r\n```\r\n"}}
{"actor":{"display_login":"narcolepticinsomniac"}}