{"action":"closed","number":37,"pull_request":{"url":"https://api.github.com/repos/enketo/enketo-transformer/pulls/37","id":159904545,"html_url":"https://github.com/enketo/enketo-transformer/pull/37","diff_url":"https://github.com/enketo/enketo-transformer/pull/37.diff","patch_url":"https://github.com/enketo/enketo-transformer/pull/37.patch","issue_url":"https://api.github.com/repos/enketo/enketo-transformer/issues/37","number":37,"state":"closed","locked":false,"title":"added: backslash as an escape character in markdown mode for * and _","user":{"login":"ajarocki","id":5859066,"avatar_url":"https://avatars0.githubusercontent.com/u/5859066?v=4","gravatar_id":"","url":"https://api.github.com/users/ajarocki","html_url":"https://github.com/ajarocki","followers_url":"https://api.github.com/users/ajarocki/followers","following_url":"https://api.github.com/users/ajarocki/following{/other_user}","gists_url":"https://api.github.com/users/ajarocki/gists{/gist_id}","starred_url":"https://api.github.com/users/ajarocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajarocki/subscriptions","organizations_url":"https://api.github.com/users/ajarocki/orgs","repos_url":"https://api.github.com/users/ajarocki/repos","events_url":"https://api.github.com/users/ajarocki/events{/privacy}","received_events_url":"https://api.github.com/users/ajarocki/received_events","type":"User","site_admin":false},"body":"Initial proposal for #36 \r\n\r\nI have opted for escaping only `*` and `_` for now. I'd like to include `#` in there, and use typical `&#NN;` html escape syntax, but that will require some adjustments in regexes for current markdown rules for headers.\r\n\r\nChanges so far impact two previous tests - one in markdown, where `&lt;span&gt;a&lt;/span&gt;` by old logic is replaced by `'<span>a</span>'`, and with above changes the result is `&lt;span&gt;a&lt;/span&gt;`. I'm not sure if the old behavior should be preserved in this case, since with new result the input is properly escaped.\r\nSimilarly, second failing test case is in transformer tests and portrays the same issue.\r\n\r\n","created_at":"2017-12-22T17:13:13Z","updated_at":"2017-12-27T17:58:34Z","closed_at":"2017-12-27T17:58:34Z","merged_at":"2017-12-27T17:58:34Z","merge_commit_sha":"7661258e29ca20300ba673e63b1f605256ac746b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/enketo/enketo-transformer/pulls/37/commits","review_comments_url":"https://api.github.com/repos/enketo/enketo-transformer/pulls/37/comments","review_comment_url":"https://api.github.com/repos/enketo/enketo-transformer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enketo/enketo-transformer/issues/37/comments","statuses_url":"https://api.github.com/repos/enketo/enketo-transformer/statuses/57ea4e6775b886b5b200f6d2249a2a8f3158226e","head":{"label":"qedsoftware:adding-escape-character","ref":"adding-escape-character","sha":"57ea4e6775b886b5b200f6d2249a2a8f3158226e","user":{"login":"qedsoftware","id":4317758,"avatar_url":"https://avatars0.githubusercontent.com/u/4317758?v=4","gravatar_id":"","url":"https://api.github.com/users/qedsoftware","html_url":"https://github.com/qedsoftware","followers_url":"https://api.github.com/users/qedsoftware/followers","following_url":"https://api.github.com/users/qedsoftware/following{/other_user}","gists_url":"https://api.github.com/users/qedsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/qedsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qedsoftware/subscriptions","organizations_url":"https://api.github.com/users/qedsoftware/orgs","repos_url":"https://api.github.com/users/qedsoftware/repos","events_url":"https://api.github.com/users/qedsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/qedsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":115133349,"name":"enketo-transformer","full_name":"qedsoftware/enketo-transformer","owner":{"login":"qedsoftware","id":4317758,"avatar_url":"https://avatars0.githubusercontent.com/u/4317758?v=4","gravatar_id":"","url":"https://api.github.com/users/qedsoftware","html_url":"https://github.com/qedsoftware","followers_url":"https://api.github.com/users/qedsoftware/followers","following_url":"https://api.github.com/users/qedsoftware/following{/other_user}","gists_url":"https://api.github.com/users/qedsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/qedsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qedsoftware/subscriptions","organizations_url":"https://api.github.com/users/qedsoftware/orgs","repos_url":"https://api.github.com/users/qedsoftware/repos","events_url":"https://api.github.com/users/qedsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/qedsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qedsoftware/enketo-transformer","description":"Node.js module to transform XForms to a format that enketo-core can consume","fork":true,"url":"https://api.github.com/repos/qedsoftware/enketo-transformer","forks_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/forks","keys_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/teams","hooks_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/hooks","issue_events_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/issues/events{/number}","events_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/events","assignees_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/assignees{/user}","branches_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/branches{/branch}","tags_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/tags","blobs_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/git/refs{/sha}","trees_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/statuses/{sha}","languages_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/languages","stargazers_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/stargazers","contributors_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/contributors","subscribers_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/subscribers","subscription_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/subscription","commits_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/commits{/sha}","git_commits_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/git/commits{/sha}","comments_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/comments{/number}","issue_comment_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/issues/comments{/number}","contents_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/contents/{+path}","compare_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/merges","archive_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/downloads","issues_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/issues{/number}","pulls_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/pulls{/number}","milestones_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/milestones{/number}","notifications_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/labels{/name}","releases_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/releases{/id}","deployments_url":"https://api.github.com/repos/qedsoftware/enketo-transformer/deployments","created_at":"2017-12-22T16:42:41Z","updated_at":"2017-12-22T16:42:43Z","pushed_at":"2017-12-27T16:32:10Z","git_url":"git://github.com/qedsoftware/enketo-transformer.git","ssh_url":"git@github.com:qedsoftware/enketo-transformer.git","clone_url":"https://github.com/qedsoftware/enketo-transformer.git","svn_url":"https://github.com/qedsoftware/enketo-transformer","homepage":null,"size":166,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"enketo:master","ref":"master","sha":"379fd666851d6cc634b14a30c8edfe18cc76ad06","user":{"login":"enketo","id":4306589,"avatar_url":"https://avatars2.githubusercontent.com/u/4306589?v=4","gravatar_id":"","url":"https://api.github.com/users/enketo","html_url":"https://github.com/enketo","followers_url":"https://api.github.com/users/enketo/followers","following_url":"https://api.github.com/users/enketo/following{/other_user}","gists_url":"https://api.github.com/users/enketo/gists{/gist_id}","starred_url":"https://api.github.com/users/enketo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enketo/subscriptions","organizations_url":"https://api.github.com/users/enketo/orgs","repos_url":"https://api.github.com/users/enketo/repos","events_url":"https://api.github.com/users/enketo/events{/privacy}","received_events_url":"https://api.github.com/users/enketo/received_events","type":"Organization","site_admin":false},"repo":{"id":32484490,"name":"enketo-transformer","full_name":"enketo/enketo-transformer","owner":{"login":"enketo","id":4306589,"avatar_url":"https://avatars2.githubusercontent.com/u/4306589?v=4","gravatar_id":"","url":"https://api.github.com/users/enketo","html_url":"https://github.com/enketo","followers_url":"https://api.github.com/users/enketo/followers","following_url":"https://api.github.com/users/enketo/following{/other_user}","gists_url":"https://api.github.com/users/enketo/gists{/gist_id}","starred_url":"https://api.github.com/users/enketo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enketo/subscriptions","organizations_url":"https://api.github.com/users/enketo/orgs","repos_url":"https://api.github.com/users/enketo/repos","events_url":"https://api.github.com/users/enketo/events{/privacy}","received_events_url":"https://api.github.com/users/enketo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enketo/enketo-transformer","description":"Node.js module to transform XForms to a format that enketo-core can consume","fork":false,"url":"https://api.github.com/repos/enketo/enketo-transformer","forks_url":"https://api.github.com/repos/enketo/enketo-transformer/forks","keys_url":"https://api.github.com/repos/enketo/enketo-transformer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enketo/enketo-transformer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enketo/enketo-transformer/teams","hooks_url":"https://api.github.com/repos/enketo/enketo-transformer/hooks","issue_events_url":"https://api.github.com/repos/enketo/enketo-transformer/issues/events{/number}","events_url":"https://api.github.com/repos/enketo/enketo-transformer/events","assignees_url":"https://api.github.com/repos/enketo/enketo-transformer/assignees{/user}","branches_url":"https://api.github.com/repos/enketo/enketo-transformer/branches{/branch}","tags_url":"https://api.github.com/repos/enketo/enketo-transformer/tags","blobs_url":"https://api.github.com/repos/enketo/enketo-transformer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enketo/enketo-transformer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enketo/enketo-transformer/git/refs{/sha}","trees_url":"https://api.github.com/repos/enketo/enketo-transformer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enketo/enketo-transformer/statuses/{sha}","languages_url":"https://api.github.com/repos/enketo/enketo-transformer/languages","stargazers_url":"https://api.github.com/repos/enketo/enketo-transformer/stargazers","contributors_url":"https://api.github.com/repos/enketo/enketo-transformer/contributors","subscribers_url":"https://api.github.com/repos/enketo/enketo-transformer/subscribers","subscription_url":"https://api.github.com/repos/enketo/enketo-transformer/subscription","commits_url":"https://api.github.com/repos/enketo/enketo-transformer/commits{/sha}","git_commits_url":"https://api.github.com/repos/enketo/enketo-transformer/git/commits{/sha}","comments_url":"https://api.github.com/repos/enketo/enketo-transformer/comments{/number}","issue_comment_url":"https://api.github.com/repos/enketo/enketo-transformer/issues/comments{/number}","contents_url":"https://api.github.com/repos/enketo/enketo-transformer/contents/{+path}","compare_url":"https://api.github.com/repos/enketo/enketo-transformer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enketo/enketo-transformer/merges","archive_url":"https://api.github.com/repos/enketo/enketo-transformer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enketo/enketo-transformer/downloads","issues_url":"https://api.github.com/repos/enketo/enketo-transformer/issues{/number}","pulls_url":"https://api.github.com/repos/enketo/enketo-transformer/pulls{/number}","milestones_url":"https://api.github.com/repos/enketo/enketo-transformer/milestones{/number}","notifications_url":"https://api.github.com/repos/enketo/enketo-transformer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enketo/enketo-transformer/labels{/name}","releases_url":"https://api.github.com/repos/enketo/enketo-transformer/releases{/id}","deployments_url":"https://api.github.com/repos/enketo/enketo-transformer/deployments","created_at":"2015-03-18T21:09:09Z","updated_at":"2017-12-21T20:05:32Z","pushed_at":"2017-12-27T17:58:34Z","git_url":"git://github.com/enketo/enketo-transformer.git","ssh_url":"git@github.com:enketo/enketo-transformer.git","clone_url":"https://github.com/enketo/enketo-transformer.git","svn_url":"https://github.com/enketo/enketo-transformer","homepage":null,"size":185,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enketo/enketo-transformer/pulls/37"},"html":{"href":"https://github.com/enketo/enketo-transformer/pull/37"},"issue":{"href":"https://api.github.com/repos/enketo/enketo-transformer/issues/37"},"comments":{"href":"https://api.github.com/repos/enketo/enketo-transformer/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/enketo/enketo-transformer/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/enketo/enketo-transformer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enketo/enketo-transformer/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/enketo/enketo-transformer/statuses/57ea4e6775b886b5b200f6d2249a2a8f3158226e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MartijnR","id":627350,"avatar_url":"https://avatars1.githubusercontent.com/u/627350?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnR","html_url":"https://github.com/MartijnR","followers_url":"https://api.github.com/users/MartijnR/followers","following_url":"https://api.github.com/users/MartijnR/following{/other_user}","gists_url":"https://api.github.com/users/MartijnR/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnR/subscriptions","organizations_url":"https://api.github.com/users/MartijnR/orgs","repos_url":"https://api.github.com/users/MartijnR/repos","events_url":"https://api.github.com/users/MartijnR/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnR/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":28,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"MartijnR"}}