{"action":"created","comment":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/125398291","pull_request_review_id":47782411,"id":125398291,"diff_hunk":"@@ -319,6 +306,24 @@ def spectral_model(self):\n         return model\n \n     @property\n+    def _flux_points_table_formatted(self):\n+        \"\"\"Returns formatted version of self.flux_points.table\"\"\"\n+        table = self.flux_points.table.copy()","path":"gammapy/catalog/fermi.py","position":182,"original_position":182,"commit_id":"e327fbc6b4dbf04663bbf5a6d0eb2cc5dc2be47f","original_commit_id":"e327fbc6b4dbf04663bbf5a6d0eb2cc5dc2be47f","user":{"login":"cdeil","id":852409,"avatar_url":"https://avatars0.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"body":"I'd suggest to shorten this method a bit:\r\n- remove all empty lines (empty lines are only useful if they separate steps, just an empty line between every line of code is uncommon)\r\n- Break the line with the long list earlier\r\n- Use a list comprehension for\r\n```\r\n[table[_].format = '.3' for _ in flux_cols]\r\n```\r\nbecause it's just as readable but one line shorter.","created_at":"2017-07-04T06:39:41Z","updated_at":"2017-07-04T06:57:43Z","html_url":"https://github.com/gammapy/gammapy/pull/1078#discussion_r125398291","pull_request_url":"https://api.github.com/repos/gammapy/gammapy/pulls/1078","_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/125398291"},"html":{"href":"https://github.com/gammapy/gammapy/pull/1078#discussion_r125398291"},"pull_request":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1078"}}},"pull_request":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/1078","id":128325254,"html_url":"https://github.com/gammapy/gammapy/pull/1078","diff_url":"https://github.com/gammapy/gammapy/pull/1078.diff","patch_url":"https://github.com/gammapy/gammapy/pull/1078.patch","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/1078","number":1078,"state":"open","locked":false,"title":"Add printout for 3FHL and gamma-cat sources","user":{"login":"vorugantia","id":18579919,"avatar_url":"https://avatars0.githubusercontent.com/u/18579919?v=3","gravatar_id":"","url":"https://api.github.com/users/vorugantia","html_url":"https://github.com/vorugantia","followers_url":"https://api.github.com/users/vorugantia/followers","following_url":"https://api.github.com/users/vorugantia/following{/other_user}","gists_url":"https://api.github.com/users/vorugantia/gists{/gist_id}","starred_url":"https://api.github.com/users/vorugantia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorugantia/subscriptions","organizations_url":"https://api.github.com/users/vorugantia/orgs","repos_url":"https://api.github.com/users/vorugantia/repos","events_url":"https://api.github.com/users/vorugantia/events{/privacy}","received_events_url":"https://api.github.com/users/vorugantia/received_events","type":"User","site_admin":false},"body":"@adonath @cdeil - This PR mainly focuses on the `__str__()` method for `SourceCatalogObject3FHL`, but here is everything it accomplishes:\r\n\r\n* Create full print-out for `SourceCatalogObject3FHL`\r\n\r\n* Add new property, `_flux_points_table_formatted`, to 3FHL and 3FGL source objects - essentially just a cleaner version of `flux_points.table`. It allows people to easily dump a clean + formatted astropy table to JSON, etc.\r\n\r\n* Minor fixes to print-outs for 3FGL and HGPS sources (e.g. add `_flux_points_table_formatted` to print string)\r\n\r\n* Add `sqrt_TS` column to `flux_points.table` for 3FHL and 3FGL source objects\r\n\r\nI haven't really done anything with the tests for `SourceCatalogObject3FHL` and `SourceCatalogObject3FGL` yet - let me know what can be done for them.","created_at":"2017-06-30T09:02:13Z","updated_at":"2017-07-04T06:57:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d22e109007b3e57d04e43e5e7f4957a4bae87412","assignee":{"login":"cdeil","id":852409,"avatar_url":"https://avatars0.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"assignees":[{"login":"cdeil","id":852409,"avatar_url":"https://avatars0.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/gammapy/gammapy/milestones/10","html_url":"https://github.com/gammapy/gammapy/milestone/10","labels_url":"https://api.github.com/repos/gammapy/gammapy/milestones/10/labels","id":2282173,"number":10,"title":"0.7","description":"","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars0.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":124,"closed_issues":46,"state":"open","created_at":"2017-01-27T12:50:29Z","updated_at":"2017-07-03T15:39:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/gammapy/gammapy/pulls/1078/commits","review_comments_url":"https://api.github.com/repos/gammapy/gammapy/pulls/1078/comments","review_comment_url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/1078/comments","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/e327fbc6b4dbf04663bbf5a6d0eb2cc5dc2be47f","head":{"label":"vorugantia:3fhl_str","ref":"3fhl_str","sha":"e327fbc6b4dbf04663bbf5a6d0eb2cc5dc2be47f","user":{"login":"vorugantia","id":18579919,"avatar_url":"https://avatars0.githubusercontent.com/u/18579919?v=3","gravatar_id":"","url":"https://api.github.com/users/vorugantia","html_url":"https://github.com/vorugantia","followers_url":"https://api.github.com/users/vorugantia/followers","following_url":"https://api.github.com/users/vorugantia/following{/other_user}","gists_url":"https://api.github.com/users/vorugantia/gists{/gist_id}","starred_url":"https://api.github.com/users/vorugantia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorugantia/subscriptions","organizations_url":"https://api.github.com/users/vorugantia/orgs","repos_url":"https://api.github.com/users/vorugantia/repos","events_url":"https://api.github.com/users/vorugantia/events{/privacy}","received_events_url":"https://api.github.com/users/vorugantia/received_events","type":"User","site_admin":false},"repo":{"id":82509241,"name":"gammapy","full_name":"vorugantia/gammapy","owner":{"login":"vorugantia","id":18579919,"avatar_url":"https://avatars0.githubusercontent.com/u/18579919?v=3","gravatar_id":"","url":"https://api.github.com/users/vorugantia","html_url":"https://github.com/vorugantia","followers_url":"https://api.github.com/users/vorugantia/followers","following_url":"https://api.github.com/users/vorugantia/following{/other_user}","gists_url":"https://api.github.com/users/vorugantia/gists{/gist_id}","starred_url":"https://api.github.com/users/vorugantia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorugantia/subscriptions","organizations_url":"https://api.github.com/users/vorugantia/orgs","repos_url":"https://api.github.com/users/vorugantia/repos","events_url":"https://api.github.com/users/vorugantia/events{/privacy}","received_events_url":"https://api.github.com/users/vorugantia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vorugantia/gammapy","description":"A Python package for gamma-ray astronomy","fork":true,"url":"https://api.github.com/repos/vorugantia/gammapy","forks_url":"https://api.github.com/repos/vorugantia/gammapy/forks","keys_url":"https://api.github.com/repos/vorugantia/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vorugantia/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vorugantia/gammapy/teams","hooks_url":"https://api.github.com/repos/vorugantia/gammapy/hooks","issue_events_url":"https://api.github.com/repos/vorugantia/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/vorugantia/gammapy/events","assignees_url":"https://api.github.com/repos/vorugantia/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/vorugantia/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/vorugantia/gammapy/tags","blobs_url":"https://api.github.com/repos/vorugantia/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vorugantia/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vorugantia/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vorugantia/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vorugantia/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/vorugantia/gammapy/languages","stargazers_url":"https://api.github.com/repos/vorugantia/gammapy/stargazers","contributors_url":"https://api.github.com/repos/vorugantia/gammapy/contributors","subscribers_url":"https://api.github.com/repos/vorugantia/gammapy/subscribers","subscription_url":"https://api.github.com/repos/vorugantia/gammapy/subscription","commits_url":"https://api.github.com/repos/vorugantia/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vorugantia/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vorugantia/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vorugantia/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/vorugantia/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/vorugantia/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vorugantia/gammapy/merges","archive_url":"https://api.github.com/repos/vorugantia/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vorugantia/gammapy/downloads","issues_url":"https://api.github.com/repos/vorugantia/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/vorugantia/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/vorugantia/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/vorugantia/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vorugantia/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/vorugantia/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/vorugantia/gammapy/deployments","created_at":"2017-02-20T02:43:06Z","updated_at":"2017-02-20T02:43:08Z","pushed_at":"2017-07-03T22:04:38Z","git_url":"git://github.com/vorugantia/gammapy.git","ssh_url":"git@github.com:vorugantia/gammapy.git","clone_url":"https://github.com/vorugantia/gammapy.git","svn_url":"https://github.com/vorugantia/gammapy","homepage":"http://docs.gammapy.org","size":9026,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gammapy:master","ref":"master","sha":"b8b78f3f2e6c6a814d2f70384a49ca2a42e3253a","user":{"login":"gammapy","id":852764,"avatar_url":"https://avatars1.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"repo":{"id":10073640,"name":"gammapy","full_name":"gammapy/gammapy","owner":{"login":"gammapy","id":852764,"avatar_url":"https://avatars1.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gammapy/gammapy","description":"A Python package for gamma-ray astronomy","fork":false,"url":"https://api.github.com/repos/gammapy/gammapy","forks_url":"https://api.github.com/repos/gammapy/gammapy/forks","keys_url":"https://api.github.com/repos/gammapy/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gammapy/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gammapy/gammapy/teams","hooks_url":"https://api.github.com/repos/gammapy/gammapy/hooks","issue_events_url":"https://api.github.com/repos/gammapy/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/gammapy/gammapy/events","assignees_url":"https://api.github.com/repos/gammapy/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/gammapy/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/gammapy/gammapy/tags","blobs_url":"https://api.github.com/repos/gammapy/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gammapy/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gammapy/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gammapy/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/gammapy/gammapy/languages","stargazers_url":"https://api.github.com/repos/gammapy/gammapy/stargazers","contributors_url":"https://api.github.com/repos/gammapy/gammapy/contributors","subscribers_url":"https://api.github.com/repos/gammapy/gammapy/subscribers","subscription_url":"https://api.github.com/repos/gammapy/gammapy/subscription","commits_url":"https://api.github.com/repos/gammapy/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gammapy/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gammapy/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gammapy/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gammapy/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/gammapy/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gammapy/gammapy/merges","archive_url":"https://api.github.com/repos/gammapy/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gammapy/gammapy/downloads","issues_url":"https://api.github.com/repos/gammapy/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/gammapy/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/gammapy/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/gammapy/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gammapy/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/gammapy/gammapy/releases{/id}","deployments_url":"https://api.github.com/repos/gammapy/gammapy/deployments","created_at":"2013-05-15T07:50:40Z","updated_at":"2017-05-04T20:40:37Z","pushed_at":"2017-07-03T22:04:39Z","git_url":"git://github.com/gammapy/gammapy.git","ssh_url":"git@github.com:gammapy/gammapy.git","clone_url":"https://github.com/gammapy/gammapy.git","svn_url":"https://github.com/gammapy/gammapy","homepage":"http://docs.gammapy.org","size":9026,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":207,"forks":59,"open_issues":207,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1078"},"html":{"href":"https://github.com/gammapy/gammapy/pull/1078"},"issue":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/1078"},"comments":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/1078/comments"},"review_comments":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1078/comments"},"review_comment":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/1078/commits"},"statuses":{"href":"https://api.github.com/repos/gammapy/gammapy/statuses/e327fbc6b4dbf04663bbf5a6d0eb2cc5dc2be47f"}}}}
{"actor":{"display_login":"cdeil"}}