{"action":"created","comment":{"url":"https://api.github.com/repos/patronage/bubs/pulls/comments/121744575","pull_request_review_id":43797324,"id":121744575,"diff_hunk":"@@ -8,7 +8,7 @@ var fitVidInit = function(){\n };\n \n var smoothScrollInit = function(){\n-    $('a').smoothScroll();\n+    $('a.scroll').smoothScroll();","path":"wp-content/themes/timber/assets/js/main.js","position":5,"original_position":5,"commit_id":"07c8d2e5b44e4b40180e3869cb47ccd909e60ecd","original_commit_id":"07c8d2e5b44e4b40180e3869cb47ccd909e60ecd","user":{"login":"ccorda","id":45271,"avatar_url":"https://avatars0.githubusercontent.com/u/45271?v=3","gravatar_id":"","url":"https://api.github.com/users/ccorda","html_url":"https://github.com/ccorda","followers_url":"https://api.github.com/users/ccorda/followers","following_url":"https://api.github.com/users/ccorda/following{/other_user}","gists_url":"https://api.github.com/users/ccorda/gists{/gist_id}","starred_url":"https://api.github.com/users/ccorda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccorda/subscriptions","organizations_url":"https://api.github.com/users/ccorda/orgs","repos_url":"https://api.github.com/users/ccorda/repos","events_url":"https://api.github.com/users/ccorda/events{/privacy}","received_events_url":"https://api.github.com/users/ccorda/received_events","type":"User","site_admin":false},"body":"This feels unrelated (and I'd quibble on it). Can we revert and open as a separate issue?","created_at":"2017-06-13T17:30:07Z","updated_at":"2017-06-13T17:39:54Z","html_url":"https://github.com/patronage/bubs/pull/65#discussion_r121744575","pull_request_url":"https://api.github.com/repos/patronage/bubs/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/patronage/bubs/pulls/comments/121744575"},"html":{"href":"https://github.com/patronage/bubs/pull/65#discussion_r121744575"},"pull_request":{"href":"https://api.github.com/repos/patronage/bubs/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/patronage/bubs/pulls/65","id":125416773,"html_url":"https://github.com/patronage/bubs/pull/65","diff_url":"https://github.com/patronage/bubs/pull/65.diff","patch_url":"https://github.com/patronage/bubs/pull/65.patch","issue_url":"https://api.github.com/repos/patronage/bubs/issues/65","number":65,"state":"open","locked":false,"title":"44 plain default mobile nav","user":{"login":"yuvilio","id":128731,"avatar_url":"https://avatars1.githubusercontent.com/u/128731?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvilio","html_url":"https://github.com/yuvilio","followers_url":"https://api.github.com/users/yuvilio/followers","following_url":"https://api.github.com/users/yuvilio/following{/other_user}","gists_url":"https://api.github.com/users/yuvilio/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvilio/subscriptions","organizations_url":"https://api.github.com/users/yuvilio/orgs","repos_url":"https://api.github.com/users/yuvilio/repos","events_url":"https://api.github.com/users/yuvilio/events{/privacy}","received_events_url":"https://api.github.com/users/yuvilio/received_events","type":"User","site_admin":false},"body":"Per discussion in #44, this PR switches the current header navbar nav with a basic starter out of the box mobile nav . It's aims are two fold:\r\n\r\n1. Remove dependency on bootstrap navbar and it's setup. Utilizing navbar added more constrictions than benefits (shown below).\r\n\r\n2. Give a starter option for a basic responsive nav, solving typical needs (mobile nav expand)\r\n\r\nBefore:\r\n====\r\n\r\n* The desktop menu did not show submenu elements\r\n![screenshot from 2017-06-13 13-14-12](https://user-images.githubusercontent.com/128731/27095057-4f1cb462-503a-11e7-81ea-ab42dda34ae2.png)\r\n\r\n\r\n* The mobile menu was always open (increasing usage of space) and it too did not show submenu (dropdown elements) \r\n ![screenshot from 2017-06-13 13-14-39](https://user-images.githubusercontent.com/128731/27095059-521a0598-503a-11e7-9aa2-90711288241f.png)\r\n\r\n\r\nAfter (with this PR):\r\n====\r\n\r\n* The desktop nav has a default hover state for dropdown submenu elements (courtesy of bootstrap hover dropdown): \r\n\r\n![desktop-nav-demo](https://user-images.githubusercontent.com/128731/27094896-bba6e1b2-5039-11e7-9f9e-873985098280.gif)\r\n\r\n* In mobile, the menu starts hidden, and a bars hamburger appears on the top right to toggle it open. If the menu item has a dropdown, it's toggleable with a '+' link\r\n\r\n![mobile-nav-demo](https://user-images.githubusercontent.com/128731/27094823-81834872-5039-11e7-8783-753428793c11.gif)\r\n\r\nAs always, this is just an out of the box _default option_. Feel free to overwrite, if the design you're working with implies a different approach.\r\n","created_at":"2017-06-13T17:16:55Z","updated_at":"2017-06-13T17:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d42416445339dc70052985784a69801e132c30b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/patronage/bubs/pulls/65/commits","review_comments_url":"https://api.github.com/repos/patronage/bubs/pulls/65/comments","review_comment_url":"https://api.github.com/repos/patronage/bubs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patronage/bubs/issues/65/comments","statuses_url":"https://api.github.com/repos/patronage/bubs/statuses/07c8d2e5b44e4b40180e3869cb47ccd909e60ecd","head":{"label":"patronage:44-plain-default-mobile-nav","ref":"44-plain-default-mobile-nav","sha":"07c8d2e5b44e4b40180e3869cb47ccd909e60ecd","user":{"login":"patronage","id":8702994,"avatar_url":"https://avatars2.githubusercontent.com/u/8702994?v=3","gravatar_id":"","url":"https://api.github.com/users/patronage","html_url":"https://github.com/patronage","followers_url":"https://api.github.com/users/patronage/followers","following_url":"https://api.github.com/users/patronage/following{/other_user}","gists_url":"https://api.github.com/users/patronage/gists{/gist_id}","starred_url":"https://api.github.com/users/patronage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patronage/subscriptions","organizations_url":"https://api.github.com/users/patronage/orgs","repos_url":"https://api.github.com/users/patronage/repos","events_url":"https://api.github.com/users/patronage/events{/privacy}","received_events_url":"https://api.github.com/users/patronage/received_events","type":"Organization","site_admin":false},"repo":{"id":28364930,"name":"bubs","full_name":"patronage/bubs","owner":{"login":"patronage","id":8702994,"avatar_url":"https://avatars2.githubusercontent.com/u/8702994?v=3","gravatar_id":"","url":"https://api.github.com/users/patronage","html_url":"https://github.com/patronage","followers_url":"https://api.github.com/users/patronage/followers","following_url":"https://api.github.com/users/patronage/following{/other_user}","gists_url":"https://api.github.com/users/patronage/gists{/gist_id}","starred_url":"https://api.github.com/users/patronage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patronage/subscriptions","organizations_url":"https://api.github.com/users/patronage/orgs","repos_url":"https://api.github.com/users/patronage/repos","events_url":"https://api.github.com/users/patronage/events{/privacy}","received_events_url":"https://api.github.com/users/patronage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patronage/bubs","description":"Gulp + Timber + WP","fork":false,"url":"https://api.github.com/repos/patronage/bubs","forks_url":"https://api.github.com/repos/patronage/bubs/forks","keys_url":"https://api.github.com/repos/patronage/bubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patronage/bubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patronage/bubs/teams","hooks_url":"https://api.github.com/repos/patronage/bubs/hooks","issue_events_url":"https://api.github.com/repos/patronage/bubs/issues/events{/number}","events_url":"https://api.github.com/repos/patronage/bubs/events","assignees_url":"https://api.github.com/repos/patronage/bubs/assignees{/user}","branches_url":"https://api.github.com/repos/patronage/bubs/branches{/branch}","tags_url":"https://api.github.com/repos/patronage/bubs/tags","blobs_url":"https://api.github.com/repos/patronage/bubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patronage/bubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patronage/bubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/patronage/bubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patronage/bubs/statuses/{sha}","languages_url":"https://api.github.com/repos/patronage/bubs/languages","stargazers_url":"https://api.github.com/repos/patronage/bubs/stargazers","contributors_url":"https://api.github.com/repos/patronage/bubs/contributors","subscribers_url":"https://api.github.com/repos/patronage/bubs/subscribers","subscription_url":"https://api.github.com/repos/patronage/bubs/subscription","commits_url":"https://api.github.com/repos/patronage/bubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/patronage/bubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/patronage/bubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/patronage/bubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/patronage/bubs/contents/{+path}","compare_url":"https://api.github.com/repos/patronage/bubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patronage/bubs/merges","archive_url":"https://api.github.com/repos/patronage/bubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patronage/bubs/downloads","issues_url":"https://api.github.com/repos/patronage/bubs/issues{/number}","pulls_url":"https://api.github.com/repos/patronage/bubs/pulls{/number}","milestones_url":"https://api.github.com/repos/patronage/bubs/milestones{/number}","notifications_url":"https://api.github.com/repos/patronage/bubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patronage/bubs/labels{/name}","releases_url":"https://api.github.com/repos/patronage/bubs/releases{/id}","deployments_url":"https://api.github.com/repos/patronage/bubs/deployments","created_at":"2014-12-22T23:21:16Z","updated_at":"2017-05-11T17:03:47Z","pushed_at":"2017-06-13T17:16:55Z","git_url":"git://github.com/patronage/bubs.git","ssh_url":"git@github.com:patronage/bubs.git","clone_url":"https://github.com/patronage/bubs.git","svn_url":"https://github.com/patronage/bubs","homepage":"","size":126,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":3,"default_branch":"master"}},"base":{"label":"patronage:master","ref":"master","sha":"049ce938a766a2f05285bc550eb3e8eec3f80b92","user":{"login":"patronage","id":8702994,"avatar_url":"https://avatars2.githubusercontent.com/u/8702994?v=3","gravatar_id":"","url":"https://api.github.com/users/patronage","html_url":"https://github.com/patronage","followers_url":"https://api.github.com/users/patronage/followers","following_url":"https://api.github.com/users/patronage/following{/other_user}","gists_url":"https://api.github.com/users/patronage/gists{/gist_id}","starred_url":"https://api.github.com/users/patronage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patronage/subscriptions","organizations_url":"https://api.github.com/users/patronage/orgs","repos_url":"https://api.github.com/users/patronage/repos","events_url":"https://api.github.com/users/patronage/events{/privacy}","received_events_url":"https://api.github.com/users/patronage/received_events","type":"Organization","site_admin":false},"repo":{"id":28364930,"name":"bubs","full_name":"patronage/bubs","owner":{"login":"patronage","id":8702994,"avatar_url":"https://avatars2.githubusercontent.com/u/8702994?v=3","gravatar_id":"","url":"https://api.github.com/users/patronage","html_url":"https://github.com/patronage","followers_url":"https://api.github.com/users/patronage/followers","following_url":"https://api.github.com/users/patronage/following{/other_user}","gists_url":"https://api.github.com/users/patronage/gists{/gist_id}","starred_url":"https://api.github.com/users/patronage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patronage/subscriptions","organizations_url":"https://api.github.com/users/patronage/orgs","repos_url":"https://api.github.com/users/patronage/repos","events_url":"https://api.github.com/users/patronage/events{/privacy}","received_events_url":"https://api.github.com/users/patronage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patronage/bubs","description":"Gulp + Timber + WP","fork":false,"url":"https://api.github.com/repos/patronage/bubs","forks_url":"https://api.github.com/repos/patronage/bubs/forks","keys_url":"https://api.github.com/repos/patronage/bubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patronage/bubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patronage/bubs/teams","hooks_url":"https://api.github.com/repos/patronage/bubs/hooks","issue_events_url":"https://api.github.com/repos/patronage/bubs/issues/events{/number}","events_url":"https://api.github.com/repos/patronage/bubs/events","assignees_url":"https://api.github.com/repos/patronage/bubs/assignees{/user}","branches_url":"https://api.github.com/repos/patronage/bubs/branches{/branch}","tags_url":"https://api.github.com/repos/patronage/bubs/tags","blobs_url":"https://api.github.com/repos/patronage/bubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patronage/bubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patronage/bubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/patronage/bubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patronage/bubs/statuses/{sha}","languages_url":"https://api.github.com/repos/patronage/bubs/languages","stargazers_url":"https://api.github.com/repos/patronage/bubs/stargazers","contributors_url":"https://api.github.com/repos/patronage/bubs/contributors","subscribers_url":"https://api.github.com/repos/patronage/bubs/subscribers","subscription_url":"https://api.github.com/repos/patronage/bubs/subscription","commits_url":"https://api.github.com/repos/patronage/bubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/patronage/bubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/patronage/bubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/patronage/bubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/patronage/bubs/contents/{+path}","compare_url":"https://api.github.com/repos/patronage/bubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patronage/bubs/merges","archive_url":"https://api.github.com/repos/patronage/bubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patronage/bubs/downloads","issues_url":"https://api.github.com/repos/patronage/bubs/issues{/number}","pulls_url":"https://api.github.com/repos/patronage/bubs/pulls{/number}","milestones_url":"https://api.github.com/repos/patronage/bubs/milestones{/number}","notifications_url":"https://api.github.com/repos/patronage/bubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patronage/bubs/labels{/name}","releases_url":"https://api.github.com/repos/patronage/bubs/releases{/id}","deployments_url":"https://api.github.com/repos/patronage/bubs/deployments","created_at":"2014-12-22T23:21:16Z","updated_at":"2017-05-11T17:03:47Z","pushed_at":"2017-06-13T17:16:55Z","git_url":"git://github.com/patronage/bubs.git","ssh_url":"git@github.com:patronage/bubs.git","clone_url":"https://github.com/patronage/bubs.git","svn_url":"https://github.com/patronage/bubs","homepage":"","size":126,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patronage/bubs/pulls/65"},"html":{"href":"https://github.com/patronage/bubs/pull/65"},"issue":{"href":"https://api.github.com/repos/patronage/bubs/issues/65"},"comments":{"href":"https://api.github.com/repos/patronage/bubs/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/patronage/bubs/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/patronage/bubs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patronage/bubs/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/patronage/bubs/statuses/07c8d2e5b44e4b40180e3869cb47ccd909e60ecd"}}}}
{"actor":{"display_login":"ccorda"}}