{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/133866976","pull_request_review_id":57096283,"id":133866976,"diff_hunk":"@@ -18,4 +21,40 @@ protected function _getType()\n     {\n         return 'annotation';\n     }\n+\n+    /**\n+     * @group DDC-2632\n+     */\n+    public function testFKDefaultValueOptionExportAnnotationNoNullable() {\n+        $exporter = new AnnotationExporter();\n+\n+        $metadata = $this->getMetadatasDCC2632Nonullable();\n+\n+        $entityGenerator = new EntityGenerator();\n+\n+        $entityGenerator->setAnnotationPrefix(\"\");\n+        $exporter->setEntityGenerator($entityGenerator);\n+\n+        $expectedPattern = '/JoinColumn\\(name=\"user_id\", referencedColumnName=\"id\", nullable=false\\)/';\n+\n+        $this->assertRegExp($expectedPattern,$exporter->exportClassMetadata($metadata['Ddc2059Project']));\n+\n+    }\n+    /**","path":"tests/Doctrine/Tests/ORM/Tools/Export/AnnotationClassMetadataExporterTest.php","position":33,"original_position":33,"commit_id":"ba684fac3173e623501789c87c0765ccde77cfd8","original_commit_id":"ba684fac3173e623501789c87c0765ccde77cfd8","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"Need empty line before this line","created_at":"2017-08-18T01:57:36Z","updated_at":"2017-08-18T02:02:27Z","html_url":"https://github.com/doctrine/doctrine2/pull/6566#discussion_r133866976","pull_request_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566","_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/133866976"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/6566#discussion_r133866976"},"pull_request":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566","id":131285760,"html_url":"https://github.com/doctrine/doctrine2/pull/6566","diff_url":"https://github.com/doctrine/doctrine2/pull/6566.diff","patch_url":"https://github.com/doctrine/doctrine2/pull/6566.patch","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/6566","number":6566,"state":"open","locked":false,"title":"Fix DDC2632.","user":{"login":"enriquesomolinos","id":6418156,"avatar_url":"https://avatars3.githubusercontent.com/u/6418156?v=4","gravatar_id":"","url":"https://api.github.com/users/enriquesomolinos","html_url":"https://github.com/enriquesomolinos","followers_url":"https://api.github.com/users/enriquesomolinos/followers","following_url":"https://api.github.com/users/enriquesomolinos/following{/other_user}","gists_url":"https://api.github.com/users/enriquesomolinos/gists{/gist_id}","starred_url":"https://api.github.com/users/enriquesomolinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enriquesomolinos/subscriptions","organizations_url":"https://api.github.com/users/enriquesomolinos/orgs","repos_url":"https://api.github.com/users/enriquesomolinos/repos","events_url":"https://api.github.com/users/enriquesomolinos/events{/privacy}","received_events_url":"https://api.github.com/users/enriquesomolinos/received_events","type":"User","site_admin":false},"body":"This fix DDC2632 problem. I generate de nullable field for the foreingkey in the case you are using the tool to generate an xml or yml form a database.\r\n\r\nTo run the test you need to use a database that supports foreing keys like mysql.\r\n\r\nI'd like you to add this changes to the 2.5.x release.","created_at":"2017-07-19T10:19:17Z","updated_at":"2017-08-18T02:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96a638ad213e4f01921b184728b52a8a577e982c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566/commits","review_comments_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566/comments","review_comment_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/6566/comments","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/ba684fac3173e623501789c87c0765ccde77cfd8","head":{"label":"enriquesomolinos:DCC_2632","ref":"DCC_2632","sha":"ba684fac3173e623501789c87c0765ccde77cfd8","user":{"login":"enriquesomolinos","id":6418156,"avatar_url":"https://avatars3.githubusercontent.com/u/6418156?v=4","gravatar_id":"","url":"https://api.github.com/users/enriquesomolinos","html_url":"https://github.com/enriquesomolinos","followers_url":"https://api.github.com/users/enriquesomolinos/followers","following_url":"https://api.github.com/users/enriquesomolinos/following{/other_user}","gists_url":"https://api.github.com/users/enriquesomolinos/gists{/gist_id}","starred_url":"https://api.github.com/users/enriquesomolinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enriquesomolinos/subscriptions","organizations_url":"https://api.github.com/users/enriquesomolinos/orgs","repos_url":"https://api.github.com/users/enriquesomolinos/repos","events_url":"https://api.github.com/users/enriquesomolinos/events{/privacy}","received_events_url":"https://api.github.com/users/enriquesomolinos/received_events","type":"User","site_admin":false},"repo":{"id":97703063,"name":"doctrine2","full_name":"enriquesomolinos/doctrine2","owner":{"login":"enriquesomolinos","id":6418156,"avatar_url":"https://avatars3.githubusercontent.com/u/6418156?v=4","gravatar_id":"","url":"https://api.github.com/users/enriquesomolinos","html_url":"https://github.com/enriquesomolinos","followers_url":"https://api.github.com/users/enriquesomolinos/followers","following_url":"https://api.github.com/users/enriquesomolinos/following{/other_user}","gists_url":"https://api.github.com/users/enriquesomolinos/gists{/gist_id}","starred_url":"https://api.github.com/users/enriquesomolinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enriquesomolinos/subscriptions","organizations_url":"https://api.github.com/users/enriquesomolinos/orgs","repos_url":"https://api.github.com/users/enriquesomolinos/repos","events_url":"https://api.github.com/users/enriquesomolinos/events{/privacy}","received_events_url":"https://api.github.com/users/enriquesomolinos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enriquesomolinos/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":true,"url":"https://api.github.com/repos/enriquesomolinos/doctrine2","forks_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/forks","keys_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/teams","hooks_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/events","assignees_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/tags","blobs_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/languages","stargazers_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/subscription","commits_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/merges","archive_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/downloads","issues_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/enriquesomolinos/doctrine2/deployments","created_at":"2017-07-19T10:16:27Z","updated_at":"2017-07-19T10:16:32Z","pushed_at":"2017-07-24T11:19:15Z","git_url":"git://github.com/enriquesomolinos/doctrine2.git","ssh_url":"git@github.com:enriquesomolinos/doctrine2.git","clone_url":"https://github.com/enriquesomolinos/doctrine2.git","svn_url":"https://github.com/enriquesomolinos/doctrine2","homepage":"http://www.doctrine-project.org","size":32122,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"e3ecec36ad77525553bfd4e6a2ec86e80d39ac27","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":597887,"name":"doctrine2","full_name":"doctrine/doctrine2","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":false,"url":"https://api.github.com/repos/doctrine/doctrine2","forks_url":"https://api.github.com/repos/doctrine/doctrine2/forks","keys_url":"https://api.github.com/repos/doctrine/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/doctrine2/teams","hooks_url":"https://api.github.com/repos/doctrine/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/doctrine2/events","assignees_url":"https://api.github.com/repos/doctrine/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/doctrine2/tags","blobs_url":"https://api.github.com/repos/doctrine/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/doctrine2/languages","stargazers_url":"https://api.github.com/repos/doctrine/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/doctrine/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/doctrine/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/doctrine/doctrine2/subscription","commits_url":"https://api.github.com/repos/doctrine/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/doctrine2/merges","archive_url":"https://api.github.com/repos/doctrine/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/doctrine2/downloads","issues_url":"https://api.github.com/repos/doctrine/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/doctrine2/deployments","created_at":"2010-04-06T21:42:59Z","updated_at":"2017-08-17T04:26:23Z","pushed_at":"2017-08-17T13:58:29Z","git_url":"git://github.com/doctrine/doctrine2.git","ssh_url":"git@github.com:doctrine/doctrine2.git","clone_url":"https://github.com/doctrine/doctrine2.git","svn_url":"https://github.com/doctrine/doctrine2","homepage":"http://www.doctrine-project.org","size":32882,"stargazers_count":3700,"watchers_count":3700,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1780,"mirror_url":null,"open_issues_count":1148,"forks":1780,"open_issues":1148,"watchers":3700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/6566"},"issue":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/6566"},"comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/6566/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6566/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/doctrine2/statuses/ba684fac3173e623501789c87c0765ccde77cfd8"}}}}
{"actor":{"display_login":"Ocramius"}}