{"action":"created","comment":{"url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments/108539854","pull_request_review_id":29577877,"id":108539854,"diff_hunk":"@@ -69,7 +69,7 @@ protected\n     \"Add lumped thermal capacitor for window glazing\";\n   final parameter Boolean addCapFra =  fraType.present and not energyDynamics == Modelica.Fluid.Types.Dynamics.SteadyState\n     \"Added lumped thermal capacitor for window frame\";\n-  final parameter Modelica.SIunits.HeatCapacity Cgla = layMul.C\n+  final parameter Modelica.SIunits.HeatCapacity Cgla = layMul.C*(1-fraC)","path":"IDEAS/Buildings/Components/Window.mo","position":null,"original_position":5,"commit_id":"522e6da27b34c26c3960f068b33192280e57dbfe","original_commit_id":"522e6da27b34c26c3960f068b33192280e57dbfe","user":{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars3.githubusercontent.com/u/5970879?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false},"body":"pump","created_at":"2017-03-28T21:19:53Z","updated_at":"2017-03-28T21:19:53Z","html_url":"https://github.com/open-ideas/IDEAS/pull/681#discussion_r108539854","pull_request_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681","_links":{"self":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments/108539854"},"html":{"href":"https://github.com/open-ideas/IDEAS/pull/681#discussion_r108539854"},"pull_request":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681"}}},"pull_request":{"url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681","id":109372403,"html_url":"https://github.com/open-ideas/IDEAS/pull/681","diff_url":"https://github.com/open-ideas/IDEAS/pull/681.diff","patch_url":"https://github.com/open-ideas/IDEAS/pull/681.patch","issue_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/681","number":681,"state":"open","locked":false,"title":"Issue678 window states","user":{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars3.githubusercontent.com/u/5970879?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false},"body":"@damienpicard @GlennReynders this closes #678\r\n\r\nSee #678 for an explanation of what I did.","created_at":"2017-03-06T23:21:35Z","updated_at":"2017-03-28T21:19:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"701d0b5c4cfbd976310fb650e3a7041e1274c291","assignee":{"login":"damienpicard","id":2987659,"avatar_url":"https://avatars2.githubusercontent.com/u/2987659?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpicard","html_url":"https://github.com/damienpicard","followers_url":"https://api.github.com/users/damienpicard/followers","following_url":"https://api.github.com/users/damienpicard/following{/other_user}","gists_url":"https://api.github.com/users/damienpicard/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpicard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpicard/subscriptions","organizations_url":"https://api.github.com/users/damienpicard/orgs","repos_url":"https://api.github.com/users/damienpicard/repos","events_url":"https://api.github.com/users/damienpicard/events{/privacy}","received_events_url":"https://api.github.com/users/damienpicard/received_events","type":"User","site_admin":false},"assignees":[{"login":"damienpicard","id":2987659,"avatar_url":"https://avatars2.githubusercontent.com/u/2987659?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpicard","html_url":"https://github.com/damienpicard","followers_url":"https://api.github.com/users/damienpicard/followers","following_url":"https://api.github.com/users/damienpicard/following{/other_user}","gists_url":"https://api.github.com/users/damienpicard/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpicard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpicard/subscriptions","organizations_url":"https://api.github.com/users/damienpicard/orgs","repos_url":"https://api.github.com/users/damienpicard/repos","events_url":"https://api.github.com/users/damienpicard/events{/privacy}","received_events_url":"https://api.github.com/users/damienpicard/received_events","type":"User","site_admin":false},{"login":"GlennReynders","id":4417460,"avatar_url":"https://avatars0.githubusercontent.com/u/4417460?v=3","gravatar_id":"","url":"https://api.github.com/users/GlennReynders","html_url":"https://github.com/GlennReynders","followers_url":"https://api.github.com/users/GlennReynders/followers","following_url":"https://api.github.com/users/GlennReynders/following{/other_user}","gists_url":"https://api.github.com/users/GlennReynders/gists{/gist_id}","starred_url":"https://api.github.com/users/GlennReynders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlennReynders/subscriptions","organizations_url":"https://api.github.com/users/GlennReynders/orgs","repos_url":"https://api.github.com/users/GlennReynders/repos","events_url":"https://api.github.com/users/GlennReynders/events{/privacy}","received_events_url":"https://api.github.com/users/GlennReynders/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681/commits","review_comments_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681/comments","review_comment_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/681/comments","statuses_url":"https://api.github.com/repos/open-ideas/IDEAS/statuses/522e6da27b34c26c3960f068b33192280e57dbfe","head":{"label":"open-ideas:issue678_windowStates","ref":"issue678_windowStates","sha":"522e6da27b34c26c3960f068b33192280e57dbfe","user":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars1.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"repo":{"id":16949064,"name":"IDEAS","full_name":"open-ideas/IDEAS","owner":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars1.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-ideas/IDEAS","description":"Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.","fork":false,"url":"https://api.github.com/repos/open-ideas/IDEAS","forks_url":"https://api.github.com/repos/open-ideas/IDEAS/forks","keys_url":"https://api.github.com/repos/open-ideas/IDEAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-ideas/IDEAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-ideas/IDEAS/teams","hooks_url":"https://api.github.com/repos/open-ideas/IDEAS/hooks","issue_events_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/events{/number}","events_url":"https://api.github.com/repos/open-ideas/IDEAS/events","assignees_url":"https://api.github.com/repos/open-ideas/IDEAS/assignees{/user}","branches_url":"https://api.github.com/repos/open-ideas/IDEAS/branches{/branch}","tags_url":"https://api.github.com/repos/open-ideas/IDEAS/tags","blobs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-ideas/IDEAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-ideas/IDEAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-ideas/IDEAS/statuses/{sha}","languages_url":"https://api.github.com/repos/open-ideas/IDEAS/languages","stargazers_url":"https://api.github.com/repos/open-ideas/IDEAS/stargazers","contributors_url":"https://api.github.com/repos/open-ideas/IDEAS/contributors","subscribers_url":"https://api.github.com/repos/open-ideas/IDEAS/subscribers","subscription_url":"https://api.github.com/repos/open-ideas/IDEAS/subscription","commits_url":"https://api.github.com/repos/open-ideas/IDEAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-ideas/IDEAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-ideas/IDEAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-ideas/IDEAS/contents/{+path}","compare_url":"https://api.github.com/repos/open-ideas/IDEAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-ideas/IDEAS/merges","archive_url":"https://api.github.com/repos/open-ideas/IDEAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-ideas/IDEAS/downloads","issues_url":"https://api.github.com/repos/open-ideas/IDEAS/issues{/number}","pulls_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls{/number}","milestones_url":"https://api.github.com/repos/open-ideas/IDEAS/milestones{/number}","notifications_url":"https://api.github.com/repos/open-ideas/IDEAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-ideas/IDEAS/labels{/name}","releases_url":"https://api.github.com/repos/open-ideas/IDEAS/releases{/id}","deployments_url":"https://api.github.com/repos/open-ideas/IDEAS/deployments","created_at":"2014-02-18T13:02:55Z","updated_at":"2017-02-16T19:22:59Z","pushed_at":"2017-03-22T23:13:18Z","git_url":"git://github.com/open-ideas/IDEAS.git","ssh_url":"git@github.com:open-ideas/IDEAS.git","clone_url":"https://github.com/open-ideas/IDEAS.git","svn_url":"https://github.com/open-ideas/IDEAS","homepage":"","size":40574,"stargazers_count":21,"watchers_count":21,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":22,"forks":25,"open_issues":22,"watchers":21,"default_branch":"master"}},"base":{"label":"open-ideas:master","ref":"master","sha":"03981e86ad7d538d2da2cf2339cdb76f8e2cd29d","user":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars1.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"repo":{"id":16949064,"name":"IDEAS","full_name":"open-ideas/IDEAS","owner":{"login":"open-ideas","id":5467967,"avatar_url":"https://avatars1.githubusercontent.com/u/5467967?v=3","gravatar_id":"","url":"https://api.github.com/users/open-ideas","html_url":"https://github.com/open-ideas","followers_url":"https://api.github.com/users/open-ideas/followers","following_url":"https://api.github.com/users/open-ideas/following{/other_user}","gists_url":"https://api.github.com/users/open-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ideas/subscriptions","organizations_url":"https://api.github.com/users/open-ideas/orgs","repos_url":"https://api.github.com/users/open-ideas/repos","events_url":"https://api.github.com/users/open-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/open-ideas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-ideas/IDEAS","description":"Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.","fork":false,"url":"https://api.github.com/repos/open-ideas/IDEAS","forks_url":"https://api.github.com/repos/open-ideas/IDEAS/forks","keys_url":"https://api.github.com/repos/open-ideas/IDEAS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-ideas/IDEAS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-ideas/IDEAS/teams","hooks_url":"https://api.github.com/repos/open-ideas/IDEAS/hooks","issue_events_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/events{/number}","events_url":"https://api.github.com/repos/open-ideas/IDEAS/events","assignees_url":"https://api.github.com/repos/open-ideas/IDEAS/assignees{/user}","branches_url":"https://api.github.com/repos/open-ideas/IDEAS/branches{/branch}","tags_url":"https://api.github.com/repos/open-ideas/IDEAS/tags","blobs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-ideas/IDEAS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-ideas/IDEAS/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-ideas/IDEAS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-ideas/IDEAS/statuses/{sha}","languages_url":"https://api.github.com/repos/open-ideas/IDEAS/languages","stargazers_url":"https://api.github.com/repos/open-ideas/IDEAS/stargazers","contributors_url":"https://api.github.com/repos/open-ideas/IDEAS/contributors","subscribers_url":"https://api.github.com/repos/open-ideas/IDEAS/subscribers","subscription_url":"https://api.github.com/repos/open-ideas/IDEAS/subscription","commits_url":"https://api.github.com/repos/open-ideas/IDEAS/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-ideas/IDEAS/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-ideas/IDEAS/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-ideas/IDEAS/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-ideas/IDEAS/contents/{+path}","compare_url":"https://api.github.com/repos/open-ideas/IDEAS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-ideas/IDEAS/merges","archive_url":"https://api.github.com/repos/open-ideas/IDEAS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-ideas/IDEAS/downloads","issues_url":"https://api.github.com/repos/open-ideas/IDEAS/issues{/number}","pulls_url":"https://api.github.com/repos/open-ideas/IDEAS/pulls{/number}","milestones_url":"https://api.github.com/repos/open-ideas/IDEAS/milestones{/number}","notifications_url":"https://api.github.com/repos/open-ideas/IDEAS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-ideas/IDEAS/labels{/name}","releases_url":"https://api.github.com/repos/open-ideas/IDEAS/releases{/id}","deployments_url":"https://api.github.com/repos/open-ideas/IDEAS/deployments","created_at":"2014-02-18T13:02:55Z","updated_at":"2017-02-16T19:22:59Z","pushed_at":"2017-03-22T23:13:18Z","git_url":"git://github.com/open-ideas/IDEAS.git","ssh_url":"git@github.com:open-ideas/IDEAS.git","clone_url":"https://github.com/open-ideas/IDEAS.git","svn_url":"https://github.com/open-ideas/IDEAS","homepage":"","size":40574,"stargazers_count":21,"watchers_count":21,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":22,"forks":25,"open_issues":22,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681"},"html":{"href":"https://github.com/open-ideas/IDEAS/pull/681"},"issue":{"href":"https://api.github.com/repos/open-ideas/IDEAS/issues/681"},"comments":{"href":"https://api.github.com/repos/open-ideas/IDEAS/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-ideas/IDEAS/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/open-ideas/IDEAS/statuses/522e6da27b34c26c3960f068b33192280e57dbfe"}}}}
{"actor":{"display_login":"Mathadon"}}