{"action":"created","comment":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/comments/127431005","pull_request_review_id":50016234,"id":127431005,"diff_hunk":"@@ -199,6 +199,50 @@ buffer_putstr (struct buffer *b, const char *c)\n   buffer_put(b, c, strlen(c));\n }\n \n+/* Expand \\n to \\r\\n */\n+void\n+buffer_put_crlf(struct buffer *b, const void *origp, size_t origsize)\n+{\n+  struct buffer_data *data = b->tail;\n+  const char *p = origp, *end = p + origsize, *lf;\n+  size_t size;\n+\n+  lf = memchr(p, '\\n', end - p);","path":"lib/buffer.c","position":12,"original_position":12,"commit_id":"625e016d14073dfefb69c0fa36cddb81fbe034ed","original_commit_id":"625e016d14073dfefb69c0fa36cddb81fbe034ed","user":{"login":"eqvinox","id":1715611,"avatar_url":"https://avatars2.githubusercontent.com/u/1715611?v=4","gravatar_id":"","url":"https://api.github.com/users/eqvinox","html_url":"https://github.com/eqvinox","followers_url":"https://api.github.com/users/eqvinox/followers","following_url":"https://api.github.com/users/eqvinox/following{/other_user}","gists_url":"https://api.github.com/users/eqvinox/gists{/gist_id}","starred_url":"https://api.github.com/users/eqvinox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqvinox/subscriptions","organizations_url":"https://api.github.com/users/eqvinox/orgs","repos_url":"https://api.github.com/users/eqvinox/repos","events_url":"https://api.github.com/users/eqvinox/events{/privacy}","received_events_url":"https://api.github.com/users/eqvinox/received_events","type":"User","site_admin":false},"body":"The check is 11 lines down in line 221: `size = (lf ? lf : end) - p;`","created_at":"2017-07-14T10:42:45Z","updated_at":"2017-07-14T10:42:45Z","html_url":"https://github.com/FRRouting/frr/pull/813#discussion_r127431005","pull_request_url":"https://api.github.com/repos/FRRouting/frr/pulls/813","_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments/127431005"},"html":{"href":"https://github.com/FRRouting/frr/pull/813#discussion_r127431005"},"pull_request":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/813","id":130437748,"html_url":"https://github.com/FRRouting/frr/pull/813","diff_url":"https://github.com/FRRouting/frr/pull/813.diff","patch_url":"https://github.com/FRRouting/frr/pull/813.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/813","number":813,"state":"open","locked":false,"title":"newline redux","user":{"login":"eqvinox","id":1715611,"avatar_url":"https://avatars2.githubusercontent.com/u/1715611?v=4","gravatar_id":"","url":"https://api.github.com/users/eqvinox","html_url":"https://github.com/eqvinox","followers_url":"https://api.github.com/users/eqvinox/followers","following_url":"https://api.github.com/users/eqvinox/following{/other_user}","gists_url":"https://api.github.com/users/eqvinox/gists{/gist_id}","starred_url":"https://api.github.com/users/eqvinox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqvinox/subscriptions","organizations_url":"https://api.github.com/users/eqvinox/orgs","repos_url":"https://api.github.com/users/eqvinox/repos","events_url":"https://api.github.com/users/eqvinox/events{/privacy}","received_events_url":"https://api.github.com/users/eqvinox/received_events","type":"User","site_admin":false},"body":"kill {VTYNL, VNL, VTY_NEWLINE, vty_outln} and just use `\\n`\r\n\r\nalso includes COMMUNITY.md update & deprecation warnings","created_at":"2017-07-13T18:32:20Z","updated_at":"2017-07-14T10:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4da1c9a9e00287884023eb809f5ed34f37c568d2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"qlyoung","id":6827003,"avatar_url":"https://avatars7.githubusercontent.com/u/6827003?v=4","gravatar_id":"","url":"https://api.github.com/users/qlyoung","html_url":"https://github.com/qlyoung","followers_url":"https://api.github.com/users/qlyoung/followers","following_url":"https://api.github.com/users/qlyoung/following{/other_user}","gists_url":"https://api.github.com/users/qlyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/qlyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlyoung/subscriptions","organizations_url":"https://api.github.com/users/qlyoung/orgs","repos_url":"https://api.github.com/users/qlyoung/repos","events_url":"https://api.github.com/users/qlyoung/events{/privacy}","received_events_url":"https://api.github.com/users/qlyoung/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/813/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/813/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/813/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/625e016d14073dfefb69c0fa36cddb81fbe034ed","head":{"label":"opensourcerouting:newline-redux","ref":"newline-redux","sha":"625e016d14073dfefb69c0fa36cddb81fbe034ed","user":{"login":"opensourcerouting","id":1472465,"avatar_url":"https://avatars7.githubusercontent.com/u/1472465?v=4","gravatar_id":"","url":"https://api.github.com/users/opensourcerouting","html_url":"https://github.com/opensourcerouting","followers_url":"https://api.github.com/users/opensourcerouting/followers","following_url":"https://api.github.com/users/opensourcerouting/following{/other_user}","gists_url":"https://api.github.com/users/opensourcerouting/gists{/gist_id}","starred_url":"https://api.github.com/users/opensourcerouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensourcerouting/subscriptions","organizations_url":"https://api.github.com/users/opensourcerouting/orgs","repos_url":"https://api.github.com/users/opensourcerouting/repos","events_url":"https://api.github.com/users/opensourcerouting/events{/privacy}","received_events_url":"https://api.github.com/users/opensourcerouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76682137,"name":"frr","full_name":"opensourcerouting/frr","owner":{"login":"opensourcerouting","id":1472465,"avatar_url":"https://avatars7.githubusercontent.com/u/1472465?v=4","gravatar_id":"","url":"https://api.github.com/users/opensourcerouting","html_url":"https://github.com/opensourcerouting","followers_url":"https://api.github.com/users/opensourcerouting/followers","following_url":"https://api.github.com/users/opensourcerouting/following{/other_user}","gists_url":"https://api.github.com/users/opensourcerouting/gists{/gist_id}","starred_url":"https://api.github.com/users/opensourcerouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensourcerouting/subscriptions","organizations_url":"https://api.github.com/users/opensourcerouting/orgs","repos_url":"https://api.github.com/users/opensourcerouting/repos","events_url":"https://api.github.com/users/opensourcerouting/events{/privacy}","received_events_url":"https://api.github.com/users/opensourcerouting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensourcerouting/frr","description":"Free Range Routing Protocol Suite","fork":true,"url":"https://api.github.com/repos/opensourcerouting/frr","forks_url":"https://api.github.com/repos/opensourcerouting/frr/forks","keys_url":"https://api.github.com/repos/opensourcerouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensourcerouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensourcerouting/frr/teams","hooks_url":"https://api.github.com/repos/opensourcerouting/frr/hooks","issue_events_url":"https://api.github.com/repos/opensourcerouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/opensourcerouting/frr/events","assignees_url":"https://api.github.com/repos/opensourcerouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/opensourcerouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/opensourcerouting/frr/tags","blobs_url":"https://api.github.com/repos/opensourcerouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensourcerouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensourcerouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensourcerouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensourcerouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/opensourcerouting/frr/languages","stargazers_url":"https://api.github.com/repos/opensourcerouting/frr/stargazers","contributors_url":"https://api.github.com/repos/opensourcerouting/frr/contributors","subscribers_url":"https://api.github.com/repos/opensourcerouting/frr/subscribers","subscription_url":"https://api.github.com/repos/opensourcerouting/frr/subscription","commits_url":"https://api.github.com/repos/opensourcerouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensourcerouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensourcerouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensourcerouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensourcerouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/opensourcerouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensourcerouting/frr/merges","archive_url":"https://api.github.com/repos/opensourcerouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensourcerouting/frr/downloads","issues_url":"https://api.github.com/repos/opensourcerouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/opensourcerouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/opensourcerouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/opensourcerouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensourcerouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/opensourcerouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/opensourcerouting/frr/deployments","created_at":"2016-12-16T20:05:33Z","updated_at":"2017-07-07T08:36:15Z","pushed_at":"2017-07-14T10:25:07Z","git_url":"git://github.com/opensourcerouting/frr.git","ssh_url":"git@github.com:opensourcerouting/frr.git","clone_url":"https://github.com/opensourcerouting/frr.git","svn_url":"https://github.com/opensourcerouting/frr","homepage":"","size":24118,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"4b8197a4f7c1b510c7a0eadc64c78e78ff98f578","user":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars2.githubusercontent.com/u/24592672?v=3","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"name":"frr","full_name":"FRRouting/frr","owner":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars2.githubusercontent.com/u/24592672?v=3","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2017-07-14T10:40:19Z","pushed_at":"2017-07-14T10:24:02Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":20803,"stargazers_count":232,"watchers_count":232,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":90,"forks":75,"open_issues":90,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/813"},"html":{"href":"https://github.com/FRRouting/frr/pull/813"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/813"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/625e016d14073dfefb69c0fa36cddb81fbe034ed"}}}}
{"actor":{"display_login":"eqvinox"}}