{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/app-layout/pulls/comments/95224063","pull_request_review_id":15772208,"id":95224063,"diff_hunk":"@@ -645,10 +637,16 @@\n       },\n \n       _openedPersistentChanged: function() {\n-        if (this.transitionDuration === 0) {\n-          // Reset drawer state now since there will be no transitionend event.\n-          this._resetDrawerState();\n+        // Don't reset drawer state if tracking or flinging, since _trackEnd and _flingDrawer will\n+        // set its own timer.\n+        if (this._drawerState === this._DRAWER_STATE.FLINGING ||\n+            this._drawerState === this._DRAWER_STATE.TRACKING) {\n+          return;\n         }\n+\n+        // Use setTimeout instead of transitionend since transitionend won't fire when app-drawer\n+        // is display: none.\n+        window.setTimeout(this._resetDrawerState.bind(this), this.transitionDuration);","path":"app-drawer/app-drawer.html","position":null,"original_position":82,"commit_id":"a2e90eb9f64d21a1052329afe68a63f996d37f42","original_commit_id":"31ac7f00e53065e07cdfbbcec349f6a3ae270416","user":{"login":"keanulee","id":1319720,"avatar_url":"https://avatars.githubusercontent.com/u/1319720?v=3","gravatar_id":"","url":"https://api.github.com/users/keanulee","html_url":"https://github.com/keanulee","followers_url":"https://api.github.com/users/keanulee/followers","following_url":"https://api.github.com/users/keanulee/following{/other_user}","gists_url":"https://api.github.com/users/keanulee/gists{/gist_id}","starred_url":"https://api.github.com/users/keanulee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keanulee/subscriptions","organizations_url":"https://api.github.com/users/keanulee/orgs","repos_url":"https://api.github.com/users/keanulee/repos","events_url":"https://api.github.com/users/keanulee/events{/privacy}","received_events_url":"https://api.github.com/users/keanulee/received_events","type":"User","site_admin":false},"body":"I updated this branch to use `debounce` instead of `setTimeout`. Don't think I can use `Polymer.dom.flush()` in the tests though, since those are the places where I'm waiting for the debouncers to be called.","created_at":"2017-01-09T19:09:31Z","updated_at":"2017-01-09T19:09:31Z","html_url":"https://github.com/PolymerElements/app-layout/pull/395#discussion_r95224063","pull_request_url":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/app-layout/pulls/comments/95224063"},"html":{"href":"https://github.com/PolymerElements/app-layout/pull/395#discussion_r95224063"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395","id":99014396,"html_url":"https://github.com/PolymerElements/app-layout/pull/395","diff_url":"https://github.com/PolymerElements/app-layout/pull/395.diff","patch_url":"https://github.com/PolymerElements/app-layout/pull/395.patch","issue_url":"https://api.github.com/repos/PolymerElements/app-layout/issues/395","number":395,"state":"open","locked":false,"title":"Use setTimeout instead of transitionend for cleanup","user":{"login":"keanulee","id":1319720,"avatar_url":"https://avatars.githubusercontent.com/u/1319720?v=3","gravatar_id":"","url":"https://api.github.com/users/keanulee","html_url":"https://github.com/keanulee","followers_url":"https://api.github.com/users/keanulee/followers","following_url":"https://api.github.com/users/keanulee/following{/other_user}","gists_url":"https://api.github.com/users/keanulee/gists{/gist_id}","starred_url":"https://api.github.com/users/keanulee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keanulee/subscriptions","organizations_url":"https://api.github.com/users/keanulee/orgs","repos_url":"https://api.github.com/users/keanulee/repos","events_url":"https://api.github.com/users/keanulee/events{/privacy}","received_events_url":"https://api.github.com/users/keanulee/received_events","type":"User","site_admin":false},"body":"(since transitionend won't fire with display: none)","created_at":"2016-12-21T22:15:02Z","updated_at":"2017-01-09T19:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"676cccea36919630150fa67748a7e081cb44480a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/app-layout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/app-layout/issues/395/comments","statuses_url":"https://api.github.com/repos/PolymerElements/app-layout/statuses/a2e90eb9f64d21a1052329afe68a63f996d37f42","head":{"label":"PolymerElements:set-timeout","ref":"set-timeout","sha":"a2e90eb9f64d21a1052329afe68a63f996d37f42","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":40323291,"name":"app-layout","full_name":"PolymerElements/app-layout","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/app-layout","description":"App layout elements","fork":false,"url":"https://api.github.com/repos/PolymerElements/app-layout","forks_url":"https://api.github.com/repos/PolymerElements/app-layout/forks","keys_url":"https://api.github.com/repos/PolymerElements/app-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/app-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/app-layout/teams","hooks_url":"https://api.github.com/repos/PolymerElements/app-layout/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/app-layout/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/app-layout/events","assignees_url":"https://api.github.com/repos/PolymerElements/app-layout/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/app-layout/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/app-layout/tags","blobs_url":"https://api.github.com/repos/PolymerElements/app-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/app-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/app-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/app-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/app-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/app-layout/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/app-layout/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/app-layout/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/app-layout/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/app-layout/subscription","commits_url":"https://api.github.com/repos/PolymerElements/app-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/app-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/app-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/app-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/app-layout/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/app-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/app-layout/merges","archive_url":"https://api.github.com/repos/PolymerElements/app-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/app-layout/downloads","issues_url":"https://api.github.com/repos/PolymerElements/app-layout/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/app-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/app-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/app-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/app-layout/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/app-layout/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/app-layout/deployments","created_at":"2015-08-06T19:34:10Z","updated_at":"2017-01-09T14:56:02Z","pushed_at":"2017-01-09T19:02:10Z","git_url":"git://github.com/PolymerElements/app-layout.git","ssh_url":"git@github.com:PolymerElements/app-layout.git","clone_url":"https://github.com/PolymerElements/app-layout.git","svn_url":"https://github.com/PolymerElements/app-layout","homepage":"https://polymerelements.github.io/app-layout/","size":50394,"stargazers_count":306,"watchers_count":306,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":169,"mirror_url":null,"open_issues_count":29,"forks":169,"open_issues":29,"watchers":306,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"2c2b4ff583e757c156994b02111543dc7f463998","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":40323291,"name":"app-layout","full_name":"PolymerElements/app-layout","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/app-layout","description":"App layout elements","fork":false,"url":"https://api.github.com/repos/PolymerElements/app-layout","forks_url":"https://api.github.com/repos/PolymerElements/app-layout/forks","keys_url":"https://api.github.com/repos/PolymerElements/app-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/app-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/app-layout/teams","hooks_url":"https://api.github.com/repos/PolymerElements/app-layout/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/app-layout/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/app-layout/events","assignees_url":"https://api.github.com/repos/PolymerElements/app-layout/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/app-layout/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/app-layout/tags","blobs_url":"https://api.github.com/repos/PolymerElements/app-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/app-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/app-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/app-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/app-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/app-layout/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/app-layout/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/app-layout/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/app-layout/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/app-layout/subscription","commits_url":"https://api.github.com/repos/PolymerElements/app-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/app-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/app-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/app-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/app-layout/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/app-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/app-layout/merges","archive_url":"https://api.github.com/repos/PolymerElements/app-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/app-layout/downloads","issues_url":"https://api.github.com/repos/PolymerElements/app-layout/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/app-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/app-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/app-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/app-layout/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/app-layout/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/app-layout/deployments","created_at":"2015-08-06T19:34:10Z","updated_at":"2017-01-09T14:56:02Z","pushed_at":"2017-01-09T19:02:10Z","git_url":"git://github.com/PolymerElements/app-layout.git","ssh_url":"git@github.com:PolymerElements/app-layout.git","clone_url":"https://github.com/PolymerElements/app-layout.git","svn_url":"https://github.com/PolymerElements/app-layout","homepage":"https://polymerelements.github.io/app-layout/","size":50394,"stargazers_count":306,"watchers_count":306,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":169,"mirror_url":null,"open_issues_count":29,"forks":169,"open_issues":29,"watchers":306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395"},"html":{"href":"https://github.com/PolymerElements/app-layout/pull/395"},"issue":{"href":"https://api.github.com/repos/PolymerElements/app-layout/issues/395"},"comments":{"href":"https://api.github.com/repos/PolymerElements/app-layout/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/app-layout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/app-layout/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/app-layout/statuses/a2e90eb9f64d21a1052329afe68a63f996d37f42"}}}}
{"actor":{"display_login":"keanulee"}}