{"action":"created","comment":{"url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments/118012435","pull_request_review_id":39765445,"id":118012435,"diff_hunk":"@@ -138,13 +137,20 @@ public void Dispose()\n \n             try\n             {\n-                var table = $\"{_tablePrefix}{nameof(IndexingTask)}\";\n+                var dialect = SqlDialectFactory.For(connection);\n+                var sqlBuilder = dialect.CreateBuilder(_tablePrefix);\n+\n+                sqlBuilder.Select();\n+                sqlBuilder.Table(nameof(IndexingTask));\n+                sqlBuilder.Selector(\"*\");\n+                sqlBuilder.Take(count);\n+                sqlBuilder.WhereAlso($\"{dialect.QuoteForColumnName(\"Id\")} > @Id\");\n \n-                return await connection.QueryAsync<IndexingTask>($\"select top {count} * from [{table}] where Id > @Id\", new { Id = afterTaskId }, transaction);\n+                return await connection.QueryAsync<IndexingTask>(sqlBuilder.ToSqlString(dialect), new { Id = afterTaskId }, transaction);\n             }\n             catch (Exception e)\n             {\n-                Logger.LogError(\"An error occured while reading indexing tasks\", e);\n+                Logger.LogError(\"An error occured while reading indexing tasks: \" + e.Message);","path":"src/OrchardCore.Modules/Orchard.Indexing/IndexingTaskManager.cs","position":53,"original_position":53,"commit_id":"34450ac16601bea66d43d72aa2d9ebc26eb5e82f","original_commit_id":"34450ac16601bea66d43d72aa2d9ebc26eb5e82f","user":{"login":"Jetski5822","id":619530,"avatar_url":"https://avatars2.githubusercontent.com/u/619530?v=3","gravatar_id":"","url":"https://api.github.com/users/Jetski5822","html_url":"https://github.com/Jetski5822","followers_url":"https://api.github.com/users/Jetski5822/followers","following_url":"https://api.github.com/users/Jetski5822/following{/other_user}","gists_url":"https://api.github.com/users/Jetski5822/gists{/gist_id}","starred_url":"https://api.github.com/users/Jetski5822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jetski5822/subscriptions","organizations_url":"https://api.github.com/users/Jetski5822/orgs","repos_url":"https://api.github.com/users/Jetski5822/repos","events_url":"https://api.github.com/users/Jetski5822/events{/privacy}","received_events_url":"https://api.github.com/users/Jetski5822/received_events","type":"User","site_admin":false},"body":"you removed the \", e\"","created_at":"2017-05-23T14:46:20Z","updated_at":"2017-05-23T14:46:20Z","html_url":"https://github.com/OrchardCMS/Orchard2/pull/759#discussion_r118012435","pull_request_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759","_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments/118012435"},"html":{"href":"https://github.com/OrchardCMS/Orchard2/pull/759#discussion_r118012435"},"pull_request":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759"}}},"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759","id":121852743,"html_url":"https://github.com/OrchardCMS/Orchard2/pull/759","diff_url":"https://github.com/OrchardCMS/Orchard2/pull/759.diff","patch_url":"https://github.com/OrchardCMS/Orchard2/pull/759.patch","issue_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/759","number":759,"state":"open","locked":false,"title":"Queries improvements","user":{"login":"sebastienros","id":1165805,"avatar_url":"https://avatars3.githubusercontent.com/u/1165805?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienros","html_url":"https://github.com/sebastienros","followers_url":"https://api.github.com/users/sebastienros/followers","following_url":"https://api.github.com/users/sebastienros/following{/other_user}","gists_url":"https://api.github.com/users/sebastienros/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienros/subscriptions","organizations_url":"https://api.github.com/users/sebastienros/orgs","repos_url":"https://api.github.com/users/sebastienros/repos","events_url":"https://api.github.com/users/sebastienros/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienros/received_events","type":"User","site_admin":false},"body":"Documentation\r\nRecipe steps\r\n\r\nFixes #753\r\nFixes #728\r\nFixes #746\r\n","created_at":"2017-05-22T19:55:01Z","updated_at":"2017-05-23T14:46:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9705f9ee0dfe4f0da1186aa02996eafd0eb2b33e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"agriffard","id":703248,"avatar_url":"https://avatars0.githubusercontent.com/u/703248?v=3","gravatar_id":"","url":"https://api.github.com/users/agriffard","html_url":"https://github.com/agriffard","followers_url":"https://api.github.com/users/agriffard/followers","following_url":"https://api.github.com/users/agriffard/following{/other_user}","gists_url":"https://api.github.com/users/agriffard/gists{/gist_id}","starred_url":"https://api.github.com/users/agriffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agriffard/subscriptions","organizations_url":"https://api.github.com/users/agriffard/orgs","repos_url":"https://api.github.com/users/agriffard/repos","events_url":"https://api.github.com/users/agriffard/events{/privacy}","received_events_url":"https://api.github.com/users/agriffard/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759/commits","review_comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759/comments","review_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/759/comments","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/34450ac16601bea66d43d72aa2d9ebc26eb5e82f","head":{"label":"OrchardCMS:queries","ref":"queries","sha":"34450ac16601bea66d43d72aa2d9ebc26eb5e82f","user":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars1.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"name":"Orchard2","full_name":"OrchardCMS/Orchard2","owner":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars1.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrchardCMS/Orchard2","description":"Open Source Content Management System built with ASP.NET Core on top of Modular and Extensible Application Framework","fork":false,"url":"https://api.github.com/repos/OrchardCMS/Orchard2","forks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/forks","keys_url":"https://api.github.com/repos/OrchardCMS/Orchard2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/Orchard2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/Orchard2/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/events","assignees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/Orchard2/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/Orchard2/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/Orchard2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/Orchard2/merges","archive_url":"https://api.github.com/repos/OrchardCMS/Orchard2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/Orchard2/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/Orchard2/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/Orchard2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard2/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/Orchard2/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2017-05-22T08:53:00Z","pushed_at":"2017-05-23T13:31:03Z","git_url":"git://github.com/OrchardCMS/Orchard2.git","ssh_url":"git@github.com:OrchardCMS/Orchard2.git","clone_url":"https://github.com/OrchardCMS/Orchard2.git","svn_url":"https://github.com/OrchardCMS/Orchard2","homepage":"http://www.orchardproject.net/","size":32952,"stargazers_count":891,"watchers_count":891,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":335,"mirror_url":null,"open_issues_count":137,"forks":335,"open_issues":137,"watchers":891,"default_branch":"master"}},"base":{"label":"OrchardCMS:master","ref":"master","sha":"1c3b9391eeda395db2a866ca3fb3991b4d4c7b61","user":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars1.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"name":"Orchard2","full_name":"OrchardCMS/Orchard2","owner":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars1.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrchardCMS/Orchard2","description":"Open Source Content Management System built with ASP.NET Core on top of Modular and Extensible Application Framework","fork":false,"url":"https://api.github.com/repos/OrchardCMS/Orchard2","forks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/forks","keys_url":"https://api.github.com/repos/OrchardCMS/Orchard2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/Orchard2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/Orchard2/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/events","assignees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/Orchard2/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/Orchard2/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/Orchard2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/Orchard2/merges","archive_url":"https://api.github.com/repos/OrchardCMS/Orchard2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/Orchard2/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/Orchard2/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/Orchard2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard2/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/Orchard2/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2017-05-22T08:53:00Z","pushed_at":"2017-05-23T13:31:03Z","git_url":"git://github.com/OrchardCMS/Orchard2.git","ssh_url":"git@github.com:OrchardCMS/Orchard2.git","clone_url":"https://github.com/OrchardCMS/Orchard2.git","svn_url":"https://github.com/OrchardCMS/Orchard2","homepage":"http://www.orchardproject.net/","size":32952,"stargazers_count":891,"watchers_count":891,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":335,"mirror_url":null,"open_issues_count":137,"forks":335,"open_issues":137,"watchers":891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759"},"html":{"href":"https://github.com/OrchardCMS/Orchard2/pull/759"},"issue":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/759"},"comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/34450ac16601bea66d43d72aa2d9ebc26eb5e82f"}}}}
{"actor":{"display_login":"Jetski5822"}}