{"action":"created","comment":{"url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/comments/144707575","pull_request_review_id":69406152,"id":144707575,"diff_hunk":"@@ -2,11 +2,51 @@ use {compiler, spirv, ErrorCode};\n use bindings::root::*;\n use std::ptr;\n use std::marker::PhantomData;\n+use std::collections::HashMap;\n+use std::ffi::CStr;\n \n /// A MSL target.\n #[derive(Debug, Clone)]\n pub struct Target;\n \n+pub struct TargetData {","path":"spirv_cross/src/msl.rs","position":11,"original_position":11,"commit_id":"92f9e087ab86329a7c6fad2975a49ec0c656d569","original_commit_id":"92f9e087ab86329a7c6fad2975a49ec0c656d569","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"body":"I don't think it needs to be public? at least the members should be used elsewhere","created_at":"2017-10-15T01:34:53Z","updated_at":"2017-10-15T01:38:26Z","html_url":"https://github.com/grovesNL/spirv_cross/pull/26#discussion_r144707575","pull_request_url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/comments/144707575"},"html":{"href":"https://github.com/grovesNL/spirv_cross/pull/26#discussion_r144707575"},"pull_request":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26","id":146591451,"html_url":"https://github.com/grovesNL/spirv_cross/pull/26","diff_url":"https://github.com/grovesNL/spirv_cross/pull/26.diff","patch_url":"https://github.com/grovesNL/spirv_cross/pull/26.patch","issue_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues/26","number":26,"state":"open","locked":false,"title":"[RFC] Refactor #24","user":{"login":"grovesNL","id":2113872,"avatar_url":"https://avatars3.githubusercontent.com/u/2113872?v=4","gravatar_id":"","url":"https://api.github.com/users/grovesNL","html_url":"https://github.com/grovesNL","followers_url":"https://api.github.com/users/grovesNL/followers","following_url":"https://api.github.com/users/grovesNL/following{/other_user}","gists_url":"https://api.github.com/users/grovesNL/gists{/gist_id}","starred_url":"https://api.github.com/users/grovesNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grovesNL/subscriptions","organizations_url":"https://api.github.com/users/grovesNL/orgs","repos_url":"https://api.github.com/users/grovesNL/repos","events_url":"https://api.github.com/users/grovesNL/events{/privacy}","received_events_url":"https://api.github.com/users/grovesNL/received_events","type":"User","site_admin":false},"body":"Builds onto #24 to replace `ParserOptions` with methods. This may also fix the CI failures if memory was being freed too early.","created_at":"2017-10-14T07:27:33Z","updated_at":"2017-10-15T01:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c45b19524c7d56da55080f789472cd11db99ae75","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26/commits","review_comments_url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26/comments","review_comment_url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues/26/comments","statuses_url":"https://api.github.com/repos/grovesNL/spirv_cross/statuses/92f9e087ab86329a7c6fad2975a49ec0c656d569","head":{"label":"grovesNL:kvark-msl","ref":"kvark-msl","sha":"92f9e087ab86329a7c6fad2975a49ec0c656d569","user":{"login":"grovesNL","id":2113872,"avatar_url":"https://avatars3.githubusercontent.com/u/2113872?v=4","gravatar_id":"","url":"https://api.github.com/users/grovesNL","html_url":"https://github.com/grovesNL","followers_url":"https://api.github.com/users/grovesNL/followers","following_url":"https://api.github.com/users/grovesNL/following{/other_user}","gists_url":"https://api.github.com/users/grovesNL/gists{/gist_id}","starred_url":"https://api.github.com/users/grovesNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grovesNL/subscriptions","organizations_url":"https://api.github.com/users/grovesNL/orgs","repos_url":"https://api.github.com/users/grovesNL/repos","events_url":"https://api.github.com/users/grovesNL/events{/privacy}","received_events_url":"https://api.github.com/users/grovesNL/received_events","type":"User","site_admin":false},"repo":{"id":104680194,"name":"spirv_cross","full_name":"grovesNL/spirv_cross","owner":{"login":"grovesNL","id":2113872,"avatar_url":"https://avatars3.githubusercontent.com/u/2113872?v=4","gravatar_id":"","url":"https://api.github.com/users/grovesNL","html_url":"https://github.com/grovesNL","followers_url":"https://api.github.com/users/grovesNL/followers","following_url":"https://api.github.com/users/grovesNL/following{/other_user}","gists_url":"https://api.github.com/users/grovesNL/gists{/gist_id}","starred_url":"https://api.github.com/users/grovesNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grovesNL/subscriptions","organizations_url":"https://api.github.com/users/grovesNL/orgs","repos_url":"https://api.github.com/users/grovesNL/repos","events_url":"https://api.github.com/users/grovesNL/events{/privacy}","received_events_url":"https://api.github.com/users/grovesNL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grovesNL/spirv_cross","description":"Safe Rust wrapper around SPIRV-Cross","fork":false,"url":"https://api.github.com/repos/grovesNL/spirv_cross","forks_url":"https://api.github.com/repos/grovesNL/spirv_cross/forks","keys_url":"https://api.github.com/repos/grovesNL/spirv_cross/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grovesNL/spirv_cross/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grovesNL/spirv_cross/teams","hooks_url":"https://api.github.com/repos/grovesNL/spirv_cross/hooks","issue_events_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues/events{/number}","events_url":"https://api.github.com/repos/grovesNL/spirv_cross/events","assignees_url":"https://api.github.com/repos/grovesNL/spirv_cross/assignees{/user}","branches_url":"https://api.github.com/repos/grovesNL/spirv_cross/branches{/branch}","tags_url":"https://api.github.com/repos/grovesNL/spirv_cross/tags","blobs_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/refs{/sha}","trees_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grovesNL/spirv_cross/statuses/{sha}","languages_url":"https://api.github.com/repos/grovesNL/spirv_cross/languages","stargazers_url":"https://api.github.com/repos/grovesNL/spirv_cross/stargazers","contributors_url":"https://api.github.com/repos/grovesNL/spirv_cross/contributors","subscribers_url":"https://api.github.com/repos/grovesNL/spirv_cross/subscribers","subscription_url":"https://api.github.com/repos/grovesNL/spirv_cross/subscription","commits_url":"https://api.github.com/repos/grovesNL/spirv_cross/commits{/sha}","git_commits_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/commits{/sha}","comments_url":"https://api.github.com/repos/grovesNL/spirv_cross/comments{/number}","issue_comment_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues/comments{/number}","contents_url":"https://api.github.com/repos/grovesNL/spirv_cross/contents/{+path}","compare_url":"https://api.github.com/repos/grovesNL/spirv_cross/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grovesNL/spirv_cross/merges","archive_url":"https://api.github.com/repos/grovesNL/spirv_cross/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grovesNL/spirv_cross/downloads","issues_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues{/number}","pulls_url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls{/number}","milestones_url":"https://api.github.com/repos/grovesNL/spirv_cross/milestones{/number}","notifications_url":"https://api.github.com/repos/grovesNL/spirv_cross/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grovesNL/spirv_cross/labels{/name}","releases_url":"https://api.github.com/repos/grovesNL/spirv_cross/releases{/id}","deployments_url":"https://api.github.com/repos/grovesNL/spirv_cross/deployments","created_at":"2017-09-24T22:19:54Z","updated_at":"2017-09-27T12:07:27Z","pushed_at":"2017-10-14T22:04:18Z","git_url":"git://github.com/grovesNL/spirv_cross.git","ssh_url":"git@github.com:grovesNL/spirv_cross.git","clone_url":"https://github.com/grovesNL/spirv_cross.git","svn_url":"https://github.com/grovesNL/spirv_cross","homepage":"","size":104,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"grovesNL:master","ref":"master","sha":"133da5f02af134ab284bfecbc3921d71ca29a8bb","user":{"login":"grovesNL","id":2113872,"avatar_url":"https://avatars3.githubusercontent.com/u/2113872?v=4","gravatar_id":"","url":"https://api.github.com/users/grovesNL","html_url":"https://github.com/grovesNL","followers_url":"https://api.github.com/users/grovesNL/followers","following_url":"https://api.github.com/users/grovesNL/following{/other_user}","gists_url":"https://api.github.com/users/grovesNL/gists{/gist_id}","starred_url":"https://api.github.com/users/grovesNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grovesNL/subscriptions","organizations_url":"https://api.github.com/users/grovesNL/orgs","repos_url":"https://api.github.com/users/grovesNL/repos","events_url":"https://api.github.com/users/grovesNL/events{/privacy}","received_events_url":"https://api.github.com/users/grovesNL/received_events","type":"User","site_admin":false},"repo":{"id":104680194,"name":"spirv_cross","full_name":"grovesNL/spirv_cross","owner":{"login":"grovesNL","id":2113872,"avatar_url":"https://avatars3.githubusercontent.com/u/2113872?v=4","gravatar_id":"","url":"https://api.github.com/users/grovesNL","html_url":"https://github.com/grovesNL","followers_url":"https://api.github.com/users/grovesNL/followers","following_url":"https://api.github.com/users/grovesNL/following{/other_user}","gists_url":"https://api.github.com/users/grovesNL/gists{/gist_id}","starred_url":"https://api.github.com/users/grovesNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grovesNL/subscriptions","organizations_url":"https://api.github.com/users/grovesNL/orgs","repos_url":"https://api.github.com/users/grovesNL/repos","events_url":"https://api.github.com/users/grovesNL/events{/privacy}","received_events_url":"https://api.github.com/users/grovesNL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grovesNL/spirv_cross","description":"Safe Rust wrapper around SPIRV-Cross","fork":false,"url":"https://api.github.com/repos/grovesNL/spirv_cross","forks_url":"https://api.github.com/repos/grovesNL/spirv_cross/forks","keys_url":"https://api.github.com/repos/grovesNL/spirv_cross/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grovesNL/spirv_cross/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grovesNL/spirv_cross/teams","hooks_url":"https://api.github.com/repos/grovesNL/spirv_cross/hooks","issue_events_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues/events{/number}","events_url":"https://api.github.com/repos/grovesNL/spirv_cross/events","assignees_url":"https://api.github.com/repos/grovesNL/spirv_cross/assignees{/user}","branches_url":"https://api.github.com/repos/grovesNL/spirv_cross/branches{/branch}","tags_url":"https://api.github.com/repos/grovesNL/spirv_cross/tags","blobs_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/refs{/sha}","trees_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grovesNL/spirv_cross/statuses/{sha}","languages_url":"https://api.github.com/repos/grovesNL/spirv_cross/languages","stargazers_url":"https://api.github.com/repos/grovesNL/spirv_cross/stargazers","contributors_url":"https://api.github.com/repos/grovesNL/spirv_cross/contributors","subscribers_url":"https://api.github.com/repos/grovesNL/spirv_cross/subscribers","subscription_url":"https://api.github.com/repos/grovesNL/spirv_cross/subscription","commits_url":"https://api.github.com/repos/grovesNL/spirv_cross/commits{/sha}","git_commits_url":"https://api.github.com/repos/grovesNL/spirv_cross/git/commits{/sha}","comments_url":"https://api.github.com/repos/grovesNL/spirv_cross/comments{/number}","issue_comment_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues/comments{/number}","contents_url":"https://api.github.com/repos/grovesNL/spirv_cross/contents/{+path}","compare_url":"https://api.github.com/repos/grovesNL/spirv_cross/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grovesNL/spirv_cross/merges","archive_url":"https://api.github.com/repos/grovesNL/spirv_cross/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grovesNL/spirv_cross/downloads","issues_url":"https://api.github.com/repos/grovesNL/spirv_cross/issues{/number}","pulls_url":"https://api.github.com/repos/grovesNL/spirv_cross/pulls{/number}","milestones_url":"https://api.github.com/repos/grovesNL/spirv_cross/milestones{/number}","notifications_url":"https://api.github.com/repos/grovesNL/spirv_cross/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grovesNL/spirv_cross/labels{/name}","releases_url":"https://api.github.com/repos/grovesNL/spirv_cross/releases{/id}","deployments_url":"https://api.github.com/repos/grovesNL/spirv_cross/deployments","created_at":"2017-09-24T22:19:54Z","updated_at":"2017-09-27T12:07:27Z","pushed_at":"2017-10-14T22:04:18Z","git_url":"git://github.com/grovesNL/spirv_cross.git","ssh_url":"git@github.com:grovesNL/spirv_cross.git","clone_url":"https://github.com/grovesNL/spirv_cross.git","svn_url":"https://github.com/grovesNL/spirv_cross","homepage":"","size":104,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26"},"html":{"href":"https://github.com/grovesNL/spirv_cross/pull/26"},"issue":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/issues/26"},"comments":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/grovesNL/spirv_cross/statuses/92f9e087ab86329a7c6fad2975a49ec0c656d569"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kvark"}}