{"action":"created","comment":{"url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/comments/140787252","pull_request_review_id":64901181,"id":140787252,"diff_hunk":"@@ -27,87 +42,181 @@ def __init__(self, stix_dir=\"stix_data\"):\n \n \n class FileSystemSink(DataSink):\n-    \"\"\"\n+    \"\"\"FileSystemSink\n+\n+    Provides an interface for adding/pushing STIX objects\n+    to file directory of STIX objects.\n+\n+    Can be paired with a FileSystemSource, together as the two\n+    components of a FileSystemStore.\n+\n+    Args:\n+        stix_dir (str): path to directory of STIX objects\n+\n     \"\"\"\n     def __init__(self, stix_dir=\"stix_data\"):","path":"stix2/sources/filesystem.py","position":49,"original_position":49,"commit_id":"55943847fa2301be0ee397fe6b88eb1610325883","original_commit_id":"55943847fa2301be0ee397fe6b88eb1610325883","user":{"login":"gtback","id":1045796,"avatar_url":"https://avatars1.githubusercontent.com/u/1045796?v=4","gravatar_id":"","url":"https://api.github.com/users/gtback","html_url":"https://github.com/gtback","followers_url":"https://api.github.com/users/gtback/followers","following_url":"https://api.github.com/users/gtback/following{/other_user}","gists_url":"https://api.github.com/users/gtback/gists{/gist_id}","starred_url":"https://api.github.com/users/gtback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtback/subscriptions","organizations_url":"https://api.github.com/users/gtback/orgs","repos_url":"https://api.github.com/users/gtback/repos","events_url":"https://api.github.com/users/gtback/events{/privacy}","received_events_url":"https://api.github.com/users/gtback/received_events","type":"User","site_admin":false},"body":"Does it make sense to have a default value for this kwarg? I know it isn't part of this change, but I just noticed it.","created_at":"2017-09-25T14:12:13Z","updated_at":"2017-09-25T14:25:33Z","html_url":"https://github.com/oasis-open/cti-python-stix2/pull/57#discussion_r140787252","pull_request_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/comments/140787252"},"html":{"href":"https://github.com/oasis-open/cti-python-stix2/pull/57#discussion_r140787252"},"pull_request":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57","id":142618486,"html_url":"https://github.com/oasis-open/cti-python-stix2/pull/57","diff_url":"https://github.com/oasis-open/cti-python-stix2/pull/57.diff","patch_url":"https://github.com/oasis-open/cti-python-stix2/pull/57.patch","issue_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/57","number":57,"state":"open","locked":false,"title":"Update to Data* suite, FileSystem, Memory, TAXII and Filters","user":{"login":"mbastian1135","id":7109639,"avatar_url":"https://avatars0.githubusercontent.com/u/7109639?v=4","gravatar_id":"","url":"https://api.github.com/users/mbastian1135","html_url":"https://github.com/mbastian1135","followers_url":"https://api.github.com/users/mbastian1135/followers","following_url":"https://api.github.com/users/mbastian1135/following{/other_user}","gists_url":"https://api.github.com/users/mbastian1135/gists{/gist_id}","starred_url":"https://api.github.com/users/mbastian1135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbastian1135/subscriptions","organizations_url":"https://api.github.com/users/mbastian1135/orgs","repos_url":"https://api.github.com/users/mbastian1135/repos","events_url":"https://api.github.com/users/mbastian1135/events{/privacy}","received_events_url":"https://api.github.com/users/mbastian1135/received_events","type":"User","site_admin":false},"body":"1. Updated docstrings in Data* suite, CompositeDataSource, FileSystem* suite, Memory* suite, TAXIICollection* suite\r\n2. Modified the format with which STIX data can be pushed and retrieved from Data* suites. \r\n    * FileSystemStore/Sink, MemoryStore/Sink, TAXIICollectionStore/Sink can now be supplied with STIX data in any of the following forms: python STIX objects, dicts,  json-encoded strings, or a list of any of the previous forms\r\n    * FileSystemStore/Source will default to returning python STIX objects (i.e. it will json load STIX object files, and then use parse() to get a python STIX object from that)\r\n    * MemoryStore/Source will return STIX objects in the manner they were added to Memory - but MemoryStore/Sink restricts forms to either python STIX objects or dicts (converting other forms to one of those before adding)\r\n    * TAXIICollectionStore/Source will return python STIX objects, converting TAXII returned dicts to python STIX objects (I know this was still being debated, and be changed, just did this way for now)\r\n3. Tightened the way filters are passed around throughout the API layers. Essentially any filters attached to a DataSource are added to a set and maintained in a set throughout operation. While run time queries (which are also groups of filters) are provided as lists and passed as lists until they reach DataSource.query() where the query list will be converted to a set and then combined with the filter sets of that DataSource and any possible parent CompositeDataSource(s).\r\n4. Updated test_data_sources so would not break. However, need to add tests for 2.","created_at":"2017-09-22T16:22:57Z","updated_at":"2017-09-25T14:25:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d1f1eead844a27e4d68857d8d8751e536edf5ac","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57/commits","review_comments_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57/comments","review_comment_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/57/comments","statuses_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/statuses/55943847fa2301be0ee397fe6b88eb1610325883","head":{"label":"oasis-open:bug_fixes","ref":"bug_fixes","sha":"55943847fa2301be0ee397fe6b88eb1610325883","user":{"login":"oasis-open","id":11744379,"avatar_url":"https://avatars0.githubusercontent.com/u/11744379?v=4","gravatar_id":"","url":"https://api.github.com/users/oasis-open","html_url":"https://github.com/oasis-open","followers_url":"https://api.github.com/users/oasis-open/followers","following_url":"https://api.github.com/users/oasis-open/following{/other_user}","gists_url":"https://api.github.com/users/oasis-open/gists{/gist_id}","starred_url":"https://api.github.com/users/oasis-open/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasis-open/subscriptions","organizations_url":"https://api.github.com/users/oasis-open/orgs","repos_url":"https://api.github.com/users/oasis-open/repos","events_url":"https://api.github.com/users/oasis-open/events{/privacy}","received_events_url":"https://api.github.com/users/oasis-open/received_events","type":"Organization","site_admin":false},"repo":{"id":81590907,"name":"cti-python-stix2","full_name":"oasis-open/cti-python-stix2","owner":{"login":"oasis-open","id":11744379,"avatar_url":"https://avatars0.githubusercontent.com/u/11744379?v=4","gravatar_id":"","url":"https://api.github.com/users/oasis-open","html_url":"https://github.com/oasis-open","followers_url":"https://api.github.com/users/oasis-open/followers","following_url":"https://api.github.com/users/oasis-open/following{/other_user}","gists_url":"https://api.github.com/users/oasis-open/gists{/gist_id}","starred_url":"https://api.github.com/users/oasis-open/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasis-open/subscriptions","organizations_url":"https://api.github.com/users/oasis-open/orgs","repos_url":"https://api.github.com/users/oasis-open/repos","events_url":"https://api.github.com/users/oasis-open/events{/privacy}","received_events_url":"https://api.github.com/users/oasis-open/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oasis-open/cti-python-stix2","description":"OASIS Open Repository: Python APIs for STIX 2","fork":false,"url":"https://api.github.com/repos/oasis-open/cti-python-stix2","forks_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/forks","keys_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/teams","hooks_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/hooks","issue_events_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/events{/number}","events_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/events","assignees_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/assignees{/user}","branches_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/branches{/branch}","tags_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/tags","blobs_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/refs{/sha}","trees_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/statuses/{sha}","languages_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/languages","stargazers_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/stargazers","contributors_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/contributors","subscribers_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/subscribers","subscription_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/subscription","commits_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/commits{/sha}","git_commits_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/commits{/sha}","comments_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/comments{/number}","issue_comment_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/comments{/number}","contents_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/contents/{+path}","compare_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/merges","archive_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/downloads","issues_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues{/number}","pulls_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls{/number}","milestones_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/milestones{/number}","notifications_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/labels{/name}","releases_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/releases{/id}","deployments_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/deployments","created_at":"2017-02-10T17:50:12Z","updated_at":"2017-09-19T17:10:19Z","pushed_at":"2017-09-24T22:24:49Z","git_url":"git://github.com/oasis-open/cti-python-stix2.git","ssh_url":"git@github.com:oasis-open/cti-python-stix2.git","clone_url":"https://github.com/oasis-open/cti-python-stix2.git","svn_url":"https://github.com/oasis-open/cti-python-stix2","homepage":"https://stix2.readthedocs.io/en/latest/","size":573,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":24,"default_branch":"master"}},"base":{"label":"oasis-open:master","ref":"master","sha":"a4819611e03a7c03fc23e41c3a86577256c79c48","user":{"login":"oasis-open","id":11744379,"avatar_url":"https://avatars0.githubusercontent.com/u/11744379?v=4","gravatar_id":"","url":"https://api.github.com/users/oasis-open","html_url":"https://github.com/oasis-open","followers_url":"https://api.github.com/users/oasis-open/followers","following_url":"https://api.github.com/users/oasis-open/following{/other_user}","gists_url":"https://api.github.com/users/oasis-open/gists{/gist_id}","starred_url":"https://api.github.com/users/oasis-open/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasis-open/subscriptions","organizations_url":"https://api.github.com/users/oasis-open/orgs","repos_url":"https://api.github.com/users/oasis-open/repos","events_url":"https://api.github.com/users/oasis-open/events{/privacy}","received_events_url":"https://api.github.com/users/oasis-open/received_events","type":"Organization","site_admin":false},"repo":{"id":81590907,"name":"cti-python-stix2","full_name":"oasis-open/cti-python-stix2","owner":{"login":"oasis-open","id":11744379,"avatar_url":"https://avatars0.githubusercontent.com/u/11744379?v=4","gravatar_id":"","url":"https://api.github.com/users/oasis-open","html_url":"https://github.com/oasis-open","followers_url":"https://api.github.com/users/oasis-open/followers","following_url":"https://api.github.com/users/oasis-open/following{/other_user}","gists_url":"https://api.github.com/users/oasis-open/gists{/gist_id}","starred_url":"https://api.github.com/users/oasis-open/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasis-open/subscriptions","organizations_url":"https://api.github.com/users/oasis-open/orgs","repos_url":"https://api.github.com/users/oasis-open/repos","events_url":"https://api.github.com/users/oasis-open/events{/privacy}","received_events_url":"https://api.github.com/users/oasis-open/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oasis-open/cti-python-stix2","description":"OASIS Open Repository: Python APIs for STIX 2","fork":false,"url":"https://api.github.com/repos/oasis-open/cti-python-stix2","forks_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/forks","keys_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/teams","hooks_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/hooks","issue_events_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/events{/number}","events_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/events","assignees_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/assignees{/user}","branches_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/branches{/branch}","tags_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/tags","blobs_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/refs{/sha}","trees_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/statuses/{sha}","languages_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/languages","stargazers_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/stargazers","contributors_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/contributors","subscribers_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/subscribers","subscription_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/subscription","commits_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/commits{/sha}","git_commits_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/git/commits{/sha}","comments_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/comments{/number}","issue_comment_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/comments{/number}","contents_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/contents/{+path}","compare_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/merges","archive_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/downloads","issues_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues{/number}","pulls_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls{/number}","milestones_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/milestones{/number}","notifications_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/labels{/name}","releases_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/releases{/id}","deployments_url":"https://api.github.com/repos/oasis-open/cti-python-stix2/deployments","created_at":"2017-02-10T17:50:12Z","updated_at":"2017-09-19T17:10:19Z","pushed_at":"2017-09-24T22:24:49Z","git_url":"git://github.com/oasis-open/cti-python-stix2.git","ssh_url":"git@github.com:oasis-open/cti-python-stix2.git","clone_url":"https://github.com/oasis-open/cti-python-stix2.git","svn_url":"https://github.com/oasis-open/cti-python-stix2","homepage":"https://stix2.readthedocs.io/en/latest/","size":573,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57"},"html":{"href":"https://github.com/oasis-open/cti-python-stix2/pull/57"},"issue":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/57"},"comments":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/oasis-open/cti-python-stix2/statuses/55943847fa2301be0ee397fe6b88eb1610325883"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gtback"}}