{"action":"created","comment":{"url":"https://api.github.com/repos/webanno/webanno/pulls/comments/141020222","pull_request_review_id":65172302,"id":141020222,"diff_hunk":"@@ -48,13 +47,14 @@ public void render(VDocument aResponse, AnnotatorState aState, JCas aJCas,\n         // Render visible (custom) layers\n         for (AnnotationLayer layer : aLayers) {\n             List<AnnotationFeature> features = annotationService.listAnnotationFeature(layer);\n-            List<AnnotationFeature> invisibleFeatures = new ArrayList<>();\n-            for (AnnotationFeature feature : features) {\n-                if (!feature.isVisible()) {\n-                    invisibleFeatures.add(feature);\n-                }\n-            }\n-            features.removeAll(invisibleFeatures);\n+            \n+            // FIXME: is this really necessary here??\n+//            for (AnnotationFeature feature : features) {\n+//                if (!feature.isVisible()) {\n+//                    invisibleFeatures.add(feature);\n+//                }\n+//            }\n+//            features.removeAll(invisibleFeatures);","path":"webanno-api-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/annotation/rendering/PreRenderer.java","position":26,"original_position":26,"commit_id":"f6cd6da9136c15dde92496a0dacdf57ad6ef7e1c","original_commit_id":"5920ee1598ca23e68c0cdeea2911edadeb2636dd","user":{"login":"reckart","id":1410238,"avatar_url":"https://avatars0.githubusercontent.com/u/1410238?v=4","gravatar_id":"","url":"https://api.github.com/users/reckart","html_url":"https://github.com/reckart","followers_url":"https://api.github.com/users/reckart/followers","following_url":"https://api.github.com/users/reckart/following{/other_user}","gists_url":"https://api.github.com/users/reckart/gists{/gist_id}","starred_url":"https://api.github.com/users/reckart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reckart/subscriptions","organizations_url":"https://api.github.com/users/reckart/orgs","repos_url":"https://api.github.com/users/reckart/repos","events_url":"https://api.github.com/users/reckart/events{/privacy}","received_events_url":"https://api.github.com/users/reckart/received_events","type":"User","site_admin":false},"body":"Better comment this back in and open another issue. Removing this filtering would presently indirectly affect `Renderer.renderRequiredFeatureErrors()` Probably there should not be a `features` parameter at all in `Renderer.render()`. However, looking a the code, removing this parameter will entail further changes and fixes. Better handle it separately.","created_at":"2017-09-26T10:44:15Z","updated_at":"2017-09-26T10:50:47Z","html_url":"https://github.com/webanno/webanno/pull/642#discussion_r141020222","pull_request_url":"https://api.github.com/repos/webanno/webanno/pulls/642","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/webanno/webanno/pulls/comments/141020222"},"html":{"href":"https://github.com/webanno/webanno/pull/642#discussion_r141020222"},"pull_request":{"href":"https://api.github.com/repos/webanno/webanno/pulls/642"}},"in_reply_to_id":138586420},"pull_request":{"url":"https://api.github.com/repos/webanno/webanno/pulls/642","id":140424995,"html_url":"https://github.com/webanno/webanno/pull/642","diff_url":"https://github.com/webanno/webanno/pull/642.diff","patch_url":"https://github.com/webanno/webanno/pull/642.patch","issue_url":"https://api.github.com/repos/webanno/webanno/issues/642","number":642,"state":"open","locked":false,"title":"#587 Customize mouse hover text - patch","user":{"login":"remstef","id":5611665,"avatar_url":"https://avatars0.githubusercontent.com/u/5611665?v=4","gravatar_id":"","url":"https://api.github.com/users/remstef","html_url":"https://github.com/remstef","followers_url":"https://api.github.com/users/remstef/followers","following_url":"https://api.github.com/users/remstef/following{/other_user}","gists_url":"https://api.github.com/users/remstef/gists{/gist_id}","starred_url":"https://api.github.com/users/remstef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remstef/subscriptions","organizations_url":"https://api.github.com/users/remstef/orgs","repos_url":"https://api.github.com/users/remstef/repos","events_url":"https://api.github.com/users/remstef/events{/privacy}","received_events_url":"https://api.github.com/users/remstef/received_events","type":"User","site_admin":false},"body":"Customize text shown in the hoverboxes for span annotations similar to the labeltext.","created_at":"2017-09-11T20:14:18Z","updated_at":"2017-09-26T10:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44c9445e598d011066275e724524a5be8c3f4ddf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/webanno/webanno/pulls/642/commits","review_comments_url":"https://api.github.com/repos/webanno/webanno/pulls/642/comments","review_comment_url":"https://api.github.com/repos/webanno/webanno/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webanno/webanno/issues/642/comments","statuses_url":"https://api.github.com/repos/webanno/webanno/statuses/f6cd6da9136c15dde92496a0dacdf57ad6ef7e1c","head":{"label":"remstef:patch-587","ref":"patch-587","sha":"f6cd6da9136c15dde92496a0dacdf57ad6ef7e1c","user":{"login":"remstef","id":5611665,"avatar_url":"https://avatars0.githubusercontent.com/u/5611665?v=4","gravatar_id":"","url":"https://api.github.com/users/remstef","html_url":"https://github.com/remstef","followers_url":"https://api.github.com/users/remstef/followers","following_url":"https://api.github.com/users/remstef/following{/other_user}","gists_url":"https://api.github.com/users/remstef/gists{/gist_id}","starred_url":"https://api.github.com/users/remstef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remstef/subscriptions","organizations_url":"https://api.github.com/users/remstef/orgs","repos_url":"https://api.github.com/users/remstef/repos","events_url":"https://api.github.com/users/remstef/events{/privacy}","received_events_url":"https://api.github.com/users/remstef/received_events","type":"User","site_admin":false},"repo":{"id":93639367,"name":"webanno","full_name":"remstef/webanno","owner":{"login":"remstef","id":5611665,"avatar_url":"https://avatars0.githubusercontent.com/u/5611665?v=4","gravatar_id":"","url":"https://api.github.com/users/remstef","html_url":"https://github.com/remstef","followers_url":"https://api.github.com/users/remstef/followers","following_url":"https://api.github.com/users/remstef/following{/other_user}","gists_url":"https://api.github.com/users/remstef/gists{/gist_id}","starred_url":"https://api.github.com/users/remstef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remstef/subscriptions","organizations_url":"https://api.github.com/users/remstef/orgs","repos_url":"https://api.github.com/users/remstef/repos","events_url":"https://api.github.com/users/remstef/events{/privacy}","received_events_url":"https://api.github.com/users/remstef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remstef/webanno","description":"The Official WebAnno Repository","fork":true,"url":"https://api.github.com/repos/remstef/webanno","forks_url":"https://api.github.com/repos/remstef/webanno/forks","keys_url":"https://api.github.com/repos/remstef/webanno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remstef/webanno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remstef/webanno/teams","hooks_url":"https://api.github.com/repos/remstef/webanno/hooks","issue_events_url":"https://api.github.com/repos/remstef/webanno/issues/events{/number}","events_url":"https://api.github.com/repos/remstef/webanno/events","assignees_url":"https://api.github.com/repos/remstef/webanno/assignees{/user}","branches_url":"https://api.github.com/repos/remstef/webanno/branches{/branch}","tags_url":"https://api.github.com/repos/remstef/webanno/tags","blobs_url":"https://api.github.com/repos/remstef/webanno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remstef/webanno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remstef/webanno/git/refs{/sha}","trees_url":"https://api.github.com/repos/remstef/webanno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remstef/webanno/statuses/{sha}","languages_url":"https://api.github.com/repos/remstef/webanno/languages","stargazers_url":"https://api.github.com/repos/remstef/webanno/stargazers","contributors_url":"https://api.github.com/repos/remstef/webanno/contributors","subscribers_url":"https://api.github.com/repos/remstef/webanno/subscribers","subscription_url":"https://api.github.com/repos/remstef/webanno/subscription","commits_url":"https://api.github.com/repos/remstef/webanno/commits{/sha}","git_commits_url":"https://api.github.com/repos/remstef/webanno/git/commits{/sha}","comments_url":"https://api.github.com/repos/remstef/webanno/comments{/number}","issue_comment_url":"https://api.github.com/repos/remstef/webanno/issues/comments{/number}","contents_url":"https://api.github.com/repos/remstef/webanno/contents/{+path}","compare_url":"https://api.github.com/repos/remstef/webanno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remstef/webanno/merges","archive_url":"https://api.github.com/repos/remstef/webanno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remstef/webanno/downloads","issues_url":"https://api.github.com/repos/remstef/webanno/issues{/number}","pulls_url":"https://api.github.com/repos/remstef/webanno/pulls{/number}","milestones_url":"https://api.github.com/repos/remstef/webanno/milestones{/number}","notifications_url":"https://api.github.com/repos/remstef/webanno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remstef/webanno/labels{/name}","releases_url":"https://api.github.com/repos/remstef/webanno/releases{/id}","deployments_url":"https://api.github.com/repos/remstef/webanno/deployments","created_at":"2017-06-07T13:38:45Z","updated_at":"2017-06-07T13:38:49Z","pushed_at":"2017-09-14T16:30:17Z","git_url":"git://github.com/remstef/webanno.git","ssh_url":"git@github.com:remstef/webanno.git","clone_url":"https://github.com/remstef/webanno.git","svn_url":"https://github.com/remstef/webanno","homepage":"https://webanno.github.io/webanno","size":32570,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webanno:master","ref":"master","sha":"86135a38fa24c1ff35236277d8e9a47086ab1bb2","user":{"login":"webanno","id":12224000,"avatar_url":"https://avatars3.githubusercontent.com/u/12224000?v=4","gravatar_id":"","url":"https://api.github.com/users/webanno","html_url":"https://github.com/webanno","followers_url":"https://api.github.com/users/webanno/followers","following_url":"https://api.github.com/users/webanno/following{/other_user}","gists_url":"https://api.github.com/users/webanno/gists{/gist_id}","starred_url":"https://api.github.com/users/webanno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webanno/subscriptions","organizations_url":"https://api.github.com/users/webanno/orgs","repos_url":"https://api.github.com/users/webanno/repos","events_url":"https://api.github.com/users/webanno/events{/privacy}","received_events_url":"https://api.github.com/users/webanno/received_events","type":"Organization","site_admin":false},"repo":{"id":35550196,"name":"webanno","full_name":"webanno/webanno","owner":{"login":"webanno","id":12224000,"avatar_url":"https://avatars3.githubusercontent.com/u/12224000?v=4","gravatar_id":"","url":"https://api.github.com/users/webanno","html_url":"https://github.com/webanno","followers_url":"https://api.github.com/users/webanno/followers","following_url":"https://api.github.com/users/webanno/following{/other_user}","gists_url":"https://api.github.com/users/webanno/gists{/gist_id}","starred_url":"https://api.github.com/users/webanno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webanno/subscriptions","organizations_url":"https://api.github.com/users/webanno/orgs","repos_url":"https://api.github.com/users/webanno/repos","events_url":"https://api.github.com/users/webanno/events{/privacy}","received_events_url":"https://api.github.com/users/webanno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webanno/webanno","description":"The Official WebAnno Repository","fork":false,"url":"https://api.github.com/repos/webanno/webanno","forks_url":"https://api.github.com/repos/webanno/webanno/forks","keys_url":"https://api.github.com/repos/webanno/webanno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webanno/webanno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webanno/webanno/teams","hooks_url":"https://api.github.com/repos/webanno/webanno/hooks","issue_events_url":"https://api.github.com/repos/webanno/webanno/issues/events{/number}","events_url":"https://api.github.com/repos/webanno/webanno/events","assignees_url":"https://api.github.com/repos/webanno/webanno/assignees{/user}","branches_url":"https://api.github.com/repos/webanno/webanno/branches{/branch}","tags_url":"https://api.github.com/repos/webanno/webanno/tags","blobs_url":"https://api.github.com/repos/webanno/webanno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webanno/webanno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webanno/webanno/git/refs{/sha}","trees_url":"https://api.github.com/repos/webanno/webanno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webanno/webanno/statuses/{sha}","languages_url":"https://api.github.com/repos/webanno/webanno/languages","stargazers_url":"https://api.github.com/repos/webanno/webanno/stargazers","contributors_url":"https://api.github.com/repos/webanno/webanno/contributors","subscribers_url":"https://api.github.com/repos/webanno/webanno/subscribers","subscription_url":"https://api.github.com/repos/webanno/webanno/subscription","commits_url":"https://api.github.com/repos/webanno/webanno/commits{/sha}","git_commits_url":"https://api.github.com/repos/webanno/webanno/git/commits{/sha}","comments_url":"https://api.github.com/repos/webanno/webanno/comments{/number}","issue_comment_url":"https://api.github.com/repos/webanno/webanno/issues/comments{/number}","contents_url":"https://api.github.com/repos/webanno/webanno/contents/{+path}","compare_url":"https://api.github.com/repos/webanno/webanno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webanno/webanno/merges","archive_url":"https://api.github.com/repos/webanno/webanno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webanno/webanno/downloads","issues_url":"https://api.github.com/repos/webanno/webanno/issues{/number}","pulls_url":"https://api.github.com/repos/webanno/webanno/pulls{/number}","milestones_url":"https://api.github.com/repos/webanno/webanno/milestones{/number}","notifications_url":"https://api.github.com/repos/webanno/webanno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webanno/webanno/labels{/name}","releases_url":"https://api.github.com/repos/webanno/webanno/releases{/id}","deployments_url":"https://api.github.com/repos/webanno/webanno/deployments","created_at":"2015-05-13T13:20:49Z","updated_at":"2017-09-18T12:39:32Z","pushed_at":"2017-09-14T16:30:19Z","git_url":"git://github.com/webanno/webanno.git","ssh_url":"git@github.com:webanno/webanno.git","clone_url":"https://github.com/webanno/webanno.git","svn_url":"https://github.com/webanno/webanno","homepage":"https://webanno.github.io/webanno","size":91540,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":122,"forks":26,"open_issues":122,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webanno/webanno/pulls/642"},"html":{"href":"https://github.com/webanno/webanno/pull/642"},"issue":{"href":"https://api.github.com/repos/webanno/webanno/issues/642"},"comments":{"href":"https://api.github.com/repos/webanno/webanno/issues/642/comments"},"review_comments":{"href":"https://api.github.com/repos/webanno/webanno/pulls/642/comments"},"review_comment":{"href":"https://api.github.com/repos/webanno/webanno/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webanno/webanno/pulls/642/commits"},"statuses":{"href":"https://api.github.com/repos/webanno/webanno/statuses/f6cd6da9136c15dde92496a0dacdf57ad6ef7e1c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"reckart"}}