{"action":"created","issue":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6952","repository_url":"https://api.github.com/repos/swagger-api/swagger-codegen","labels_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6952/labels{/name}","comments_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6952/comments","events_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6952/events","html_url":"https://github.com/swagger-api/swagger-codegen/pull/6952","id":273631771,"number":6952,"title":"[Swift4] Add throw to reserved words","user":{"login":"atanasbozhkov","id":1144752,"avatar_url":"https://avatars2.githubusercontent.com/u/1144752?v=4","gravatar_id":"","url":"https://api.github.com/users/atanasbozhkov","html_url":"https://github.com/atanasbozhkov","followers_url":"https://api.github.com/users/atanasbozhkov/followers","following_url":"https://api.github.com/users/atanasbozhkov/following{/other_user}","gists_url":"https://api.github.com/users/atanasbozhkov/gists{/gist_id}","starred_url":"https://api.github.com/users/atanasbozhkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atanasbozhkov/subscriptions","organizations_url":"https://api.github.com/users/atanasbozhkov/orgs","repos_url":"https://api.github.com/users/atanasbozhkov/repos","events_url":"https://api.github.com/users/atanasbozhkov/events{/privacy}","received_events_url":"https://api.github.com/users/atanasbozhkov/received_events","type":"User","site_admin":false},"labels":[{"id":165466244,"url":"https://api.github.com/repos/swagger-api/swagger-codegen/labels/Client:%20Swift","name":"Client: Swift","color":"fad8c7","default":false},{"id":64180581,"url":"https://api.github.com/repos/swagger-api/swagger-codegen/labels/Issue:%20Bug","name":"Issue: Bug","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/milestones/12","html_url":"https://github.com/swagger-api/swagger-codegen/milestone/12","labels_url":"https://api.github.com/repos/swagger-api/swagger-codegen/milestones/12/labels","id":1892261,"number":12,"title":"v2.3.0","description":"","creator":{"login":"wing328","id":934260,"avatar_url":"https://avatars2.githubusercontent.com/u/934260?v=4","gravatar_id":"","url":"https://api.github.com/users/wing328","html_url":"https://github.com/wing328","followers_url":"https://api.github.com/users/wing328/followers","following_url":"https://api.github.com/users/wing328/following{/other_user}","gists_url":"https://api.github.com/users/wing328/gists{/gist_id}","starred_url":"https://api.github.com/users/wing328/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing328/subscriptions","organizations_url":"https://api.github.com/users/wing328/orgs","repos_url":"https://api.github.com/users/wing328/repos","events_url":"https://api.github.com/users/wing328/events{/privacy}","received_events_url":"https://api.github.com/users/wing328/received_events","type":"User","site_admin":false},"open_issues":267,"closed_issues":663,"state":"open","created_at":"2016-07-19T15:23:39Z","updated_at":"2017-11-15T13:45:57Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-11-14T00:58:25Z","updated_at":"2017-11-15T14:01:04Z","closed_at":"2017-11-15T13:45:31Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/6952","html_url":"https://github.com/swagger-api/swagger-codegen/pull/6952","diff_url":"https://github.com/swagger-api/swagger-codegen/pull/6952.diff","patch_url":"https://github.com/swagger-api/swagger-codegen/pull/6952.patch"},"body":"### PR checklist\r\n\r\n- [X] Read the [contribution guidelines](https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md).\r\n- [X] Ran the shell script under `./bin/` to update Petstore sample so that CIs can verify the change. (For instance, only need to run `./bin/{LANG}-petstore.sh` and `./bin/security/{LANG}-petstore.sh` if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in `.\\bin\\windows\\`.\r\n- [X] Filed the PR against the correct branch: `3.0.0` branch for changes related to OpenAPI spec 3.0. Default: `master`.\r\n- [X] Copied the [technical committee](https://github.com/swagger-api/swagger-codegen/#swagger-codegen-technical-committee) to review the pull request if your PR is targeting a particular programming language.\r\n\r\n### Description of the PR\r\nAdding `throw` in the list of Swift 4 reserved words. This is to address #6919 \r\n(details of the change, additional tests that have been done, reference to the issue for tracking, etc)\r\n\r\nI have simply added the word to the hash-set and regenerated the Petstore samples.\r\nI haven't added any changes to the Swift4 tests - currently they seem to only test a single word as a pass condition. Should there be some integration tests that iterate through the set values to see if all reserved words are escaped properly?\r\n Lastly - it's my first time contributing to the project - please let me know if I've skipped a step in the PR process - I'll do my best to fix it.\r\n"},"comment":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/comments/344600627","html_url":"https://github.com/swagger-api/swagger-codegen/pull/6952#issuecomment-344600627","issue_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/6952","id":344600627,"user":{"login":"wing328","id":934260,"avatar_url":"https://avatars2.githubusercontent.com/u/934260?v=4","gravatar_id":"","url":"https://api.github.com/users/wing328","html_url":"https://github.com/wing328","followers_url":"https://api.github.com/users/wing328/followers","following_url":"https://api.github.com/users/wing328/following{/other_user}","gists_url":"https://api.github.com/users/wing328/gists{/gist_id}","starred_url":"https://api.github.com/users/wing328/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing328/subscriptions","organizations_url":"https://api.github.com/users/wing328/orgs","repos_url":"https://api.github.com/users/wing328/repos","events_url":"https://api.github.com/users/wing328/events{/privacy}","received_events_url":"https://api.github.com/users/wing328/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T14:01:04Z","updated_at":"2017-11-15T14:01:04Z","author_association":"MEMBER","body":"@atanasbozhkov if you've time, I wonder if you can do the same to Swift3Codegen.java. "}}
{"actor":{"display_login":"wing328"}}