{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/confluence/pulls/comments/139780893","pull_request_review_id":63761916,"id":139780893,"diff_hunk":"@@ -0,0 +1,46 @@\n+#!/bin/zsh\n+\n+WD=$(readlink -f $(dirname \"$0\"))\n+\n+GREEN='\\033[0;32m'\n+YELLOW='\\033[1;33m'\n+RED='\\033[0;31m'\n+NC='\\033[0m'\n+\n+function win() {\n+    printf \"\\n${GREEN}$1${NC}\\n\"\n+}\n+\n+function warn() {\n+    printf \"\\n${YELLOW}$1${NC}\\n\"\n+}\n+\n+function error() {\n+    printf \"\\n${RED}$1${NC}\\n\"\n+}\n+\n+\n+pushd \"${WD}/..\"\n+CONFLUENCE_VERSION=$(git rev-parse HEAD)\n+popd\n+\n+pushd \"${WD}/../node_modules/foam2\"\n+FOAM2_VERSION=$(git rev-parse HEAD)\n+popd\n+\n+if [ \"${CONFLUENCE_VERSION}\" == \"${FOAM2_VERSION}\" ]; then","path":"scripts/deploy.sh","position":null,"original_position":31,"commit_id":"62fb5784a031b7aa949269fe67a26abc7884b2aa","original_commit_id":"a8f29a759c4f18b2e7e06f3fb5572a6ea67abf23","user":{"login":"arobins","id":7801314,"avatar_url":"https://avatars2.githubusercontent.com/u/7801314?v=4","gravatar_id":"","url":"https://api.github.com/users/arobins","html_url":"https://github.com/arobins","followers_url":"https://api.github.com/users/arobins/followers","following_url":"https://api.github.com/users/arobins/following{/other_user}","gists_url":"https://api.github.com/users/arobins/gists{/gist_id}","starred_url":"https://api.github.com/users/arobins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arobins/subscriptions","organizations_url":"https://api.github.com/users/arobins/orgs","repos_url":"https://api.github.com/users/arobins/repos","events_url":"https://api.github.com/users/arobins/events{/privacy}","received_events_url":"https://api.github.com/users/arobins/received_events","type":"User","site_admin":false},"body":"This check fails to fail if the script is not executed from a git repo because empty strings are equal.","created_at":"2017-09-19T18:42:13Z","updated_at":"2017-09-19T18:56:28Z","html_url":"https://github.com/GoogleChrome/confluence/pull/151#discussion_r139780893","pull_request_url":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/confluence/pulls/comments/139780893"},"html":{"href":"https://github.com/GoogleChrome/confluence/pull/151#discussion_r139780893"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151","id":141922644,"html_url":"https://github.com/GoogleChrome/confluence/pull/151","diff_url":"https://github.com/GoogleChrome/confluence/pull/151.diff","patch_url":"https://github.com/GoogleChrome/confluence/pull/151.patch","issue_url":"https://api.github.com/repos/GoogleChrome/confluence/issues/151","number":151,"state":"open","locked":false,"title":"Rework build process","user":{"login":"mdittmer","id":1775176,"avatar_url":"https://avatars3.githubusercontent.com/u/1775176?v=4","gravatar_id":"","url":"https://api.github.com/users/mdittmer","html_url":"https://github.com/mdittmer","followers_url":"https://api.github.com/users/mdittmer/followers","following_url":"https://api.github.com/users/mdittmer/following{/other_user}","gists_url":"https://api.github.com/users/mdittmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mdittmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdittmer/subscriptions","organizations_url":"https://api.github.com/users/mdittmer/orgs","repos_url":"https://api.github.com/users/mdittmer/repos","events_url":"https://api.github.com/users/mdittmer/events{/privacy}","received_events_url":"https://api.github.com/users/mdittmer/received_events","type":"User","site_admin":false},"body":"New process allows:\r\n\r\n- Separate `dev` and `prod` webpack build configurations\r\n- Minification (to degrees)\r\n- Chunking of vendor code (for now, just one big chunk)\r\n- Worker loading that is compatible with chunking\r\n- Deployment script that captures git hash of Confluence and FOAM2 in version","created_at":"2017-09-19T18:29:40Z","updated_at":"2017-09-19T18:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220d729b77209c4ee21e46a0158849bb6ab78947","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/confluence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/confluence/issues/151/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/confluence/statuses/62fb5784a031b7aa949269fe67a26abc7884b2aa","head":{"label":"GoogleChrome:build","ref":"build","sha":"62fb5784a031b7aa949269fe67a26abc7884b2aa","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":82467989,"name":"confluence","full_name":"GoogleChrome/confluence","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/confluence","description":"Service and API for Web API Confluence: Metrics for web platform health","fork":false,"url":"https://api.github.com/repos/GoogleChrome/confluence","forks_url":"https://api.github.com/repos/GoogleChrome/confluence/forks","keys_url":"https://api.github.com/repos/GoogleChrome/confluence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/confluence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/confluence/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/confluence/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/confluence/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/confluence/events","assignees_url":"https://api.github.com/repos/GoogleChrome/confluence/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/confluence/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/confluence/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/confluence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/confluence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/confluence/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/confluence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/confluence/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/confluence/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/confluence/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/confluence/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/confluence/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/confluence/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/confluence/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/confluence/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/confluence/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/confluence/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/confluence/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/confluence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/confluence/merges","archive_url":"https://api.github.com/repos/GoogleChrome/confluence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/confluence/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/confluence/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/confluence/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/confluence/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/confluence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/confluence/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/confluence/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/confluence/deployments","created_at":"2017-02-19T15:16:33Z","updated_at":"2017-09-18T17:54:55Z","pushed_at":"2017-09-19T18:44:31Z","git_url":"git://github.com/GoogleChrome/confluence.git","ssh_url":"git@github.com:GoogleChrome/confluence.git","clone_url":"https://github.com/GoogleChrome/confluence.git","svn_url":"https://github.com/GoogleChrome/confluence","homepage":"","size":29815,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":29,"forks":7,"open_issues":29,"watchers":10,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"f0894aad93bdfe59389829a379f4eefb49c6caf8","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":82467989,"name":"confluence","full_name":"GoogleChrome/confluence","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/confluence","description":"Service and API for Web API Confluence: Metrics for web platform health","fork":false,"url":"https://api.github.com/repos/GoogleChrome/confluence","forks_url":"https://api.github.com/repos/GoogleChrome/confluence/forks","keys_url":"https://api.github.com/repos/GoogleChrome/confluence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/confluence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/confluence/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/confluence/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/confluence/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/confluence/events","assignees_url":"https://api.github.com/repos/GoogleChrome/confluence/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/confluence/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/confluence/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/confluence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/confluence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/confluence/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/confluence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/confluence/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/confluence/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/confluence/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/confluence/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/confluence/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/confluence/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/confluence/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/confluence/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/confluence/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/confluence/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/confluence/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/confluence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/confluence/merges","archive_url":"https://api.github.com/repos/GoogleChrome/confluence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/confluence/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/confluence/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/confluence/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/confluence/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/confluence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/confluence/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/confluence/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/confluence/deployments","created_at":"2017-02-19T15:16:33Z","updated_at":"2017-09-18T17:54:55Z","pushed_at":"2017-09-19T18:44:31Z","git_url":"git://github.com/GoogleChrome/confluence.git","ssh_url":"git@github.com:GoogleChrome/confluence.git","clone_url":"https://github.com/GoogleChrome/confluence.git","svn_url":"https://github.com/GoogleChrome/confluence","homepage":"","size":29815,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":29,"forks":7,"open_issues":29,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151"},"html":{"href":"https://github.com/GoogleChrome/confluence/pull/151"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/confluence/issues/151"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/confluence/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/confluence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/confluence/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/confluence/statuses/62fb5784a031b7aa949269fe67a26abc7884b2aa"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"arobins"}}