{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/100667148","pull_request_review_id":21385635,"id":100667148,"diff_hunk":"@@ -37,6 +56,13 @@ elseif(CORE_SYSTEM_NAME STREQUAL osx)\n                           --disable-decoder=mpeg_xvmc --disable-vda --disable-crystalhd --enable-videotoolbox\n                           --target-os=darwin\n                           --disable-securetransport)\n+elseif(CORE_SYSTEM_NAME STREQUAL rbpi)\n+  if(CPU STREQUAL \"cortex-a7\" OR CPU STREQUAL \"cortex-a53\")\n+    list(APPEND ffmpeg_conf --cpu=${CPU} --enable-pic --disable-armv5te --disable-armv6t2)\n+  endif()\n+  list(APPEND ffmpeg_conf --enable-hardcoded-tables --disable-vaapi --disable-vdpau --enable-mmal\n+                          --enable-omx-rpi)\n+","path":"tools/depends/target/ffmpeg/CMakeLists.txt","position":41,"original_position":41,"commit_id":"c046d8bdf349198b8bd52e6f9a1b3e3b0c1635d4","original_commit_id":"c046d8bdf349198b8bd52e6f9a1b3e3b0c1635d4","user":{"login":"nsenica","id":1453471,"avatar_url":"https://avatars.githubusercontent.com/u/1453471?v=3","gravatar_id":"","url":"https://api.github.com/users/nsenica","html_url":"https://github.com/nsenica","followers_url":"https://api.github.com/users/nsenica/followers","following_url":"https://api.github.com/users/nsenica/following{/other_user}","gists_url":"https://api.github.com/users/nsenica/gists{/gist_id}","starred_url":"https://api.github.com/users/nsenica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsenica/subscriptions","organizations_url":"https://api.github.com/users/nsenica/orgs","repos_url":"https://api.github.com/users/nsenica/repos","events_url":"https://api.github.com/users/nsenica/events{/privacy}","received_events_url":"https://api.github.com/users/nsenica/received_events","type":"User","site_admin":false},"body":"FFT is widely used on decompressing, so there might be a benefit there. If it is noticeable, I also have some doubts. \r\nI'll do the following, I'll edit this PR and remove the hardcoded-tables (along with the others you mentioned previously), and I'll do some testing. If it proves to be noticeable I'll open a new PR to add that option.\r\n\r\nThanks for taking the time to review this PR.","created_at":"2017-02-11T13:06:20Z","updated_at":"2017-02-11T13:06:20Z","html_url":"https://github.com/xbmc/xbmc/pull/11585#discussion_r100667148","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11585","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/100667148"},"html":{"href":"https://github.com/xbmc/xbmc/pull/11585#discussion_r100667148"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11585"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/11585","id":103821996,"html_url":"https://github.com/xbmc/xbmc/pull/11585","diff_url":"https://github.com/xbmc/xbmc/pull/11585.diff","patch_url":"https://github.com/xbmc/xbmc/pull/11585.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/11585","number":11585,"state":"open","locked":false,"title":"[cmake] Tidy up ffmpeg in order to be more flexible and versatile. Also includes switches for Raspberry Pi.","user":{"login":"nsenica","id":1453471,"avatar_url":"https://avatars.githubusercontent.com/u/1453471?v=3","gravatar_id":"","url":"https://api.github.com/users/nsenica","html_url":"https://github.com/nsenica","followers_url":"https://api.github.com/users/nsenica/followers","following_url":"https://api.github.com/users/nsenica/following{/other_user}","gists_url":"https://api.github.com/users/nsenica/gists{/gist_id}","starred_url":"https://api.github.com/users/nsenica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsenica/subscriptions","organizations_url":"https://api.github.com/users/nsenica/orgs","repos_url":"https://api.github.com/users/nsenica/repos","events_url":"https://api.github.com/users/nsenica/events{/privacy}","received_events_url":"https://api.github.com/users/nsenica/received_events","type":"User","site_admin":false},"body":"## Description\r\nffmpeg options were not totally correct, in my point of view, some settings like compiler flags are useful even when not cross compiling. Also there were choices made based on the CPU which was not passed on to the project thus being useless. Also Raspberry Pi didn't have any switches on its own, which are also needed.\r\nI believe this provides more flexibility and the output is more inline with kodi's configuration.\r\n\r\nThis is my first approach to the problem, so feedback is welcome :)\r\n\r\n## Motivation and Context\r\nSee above.\r\n\r\n## How Has This Been Tested?\r\nBy building kodi.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n","created_at":"2017-01-30T21:19:29Z","updated_at":"2017-02-11T13:06:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1d8cd32aa907fa9a18563ad9dab3703c70fec7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11585/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11585/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/11585/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/c046d8bdf349198b8bd52e6f9a1b3e3b0c1635d4","head":{"label":"nsenica:ffmpeg_options_leia","ref":"ffmpeg_options_leia","sha":"c046d8bdf349198b8bd52e6f9a1b3e3b0c1635d4","user":{"login":"nsenica","id":1453471,"avatar_url":"https://avatars.githubusercontent.com/u/1453471?v=3","gravatar_id":"","url":"https://api.github.com/users/nsenica","html_url":"https://github.com/nsenica","followers_url":"https://api.github.com/users/nsenica/followers","following_url":"https://api.github.com/users/nsenica/following{/other_user}","gists_url":"https://api.github.com/users/nsenica/gists{/gist_id}","starred_url":"https://api.github.com/users/nsenica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsenica/subscriptions","organizations_url":"https://api.github.com/users/nsenica/orgs","repos_url":"https://api.github.com/users/nsenica/repos","events_url":"https://api.github.com/users/nsenica/events{/privacy}","received_events_url":"https://api.github.com/users/nsenica/received_events","type":"User","site_admin":false},"repo":{"id":76139053,"name":"xbmc","full_name":"nsenica/xbmc","owner":{"login":"nsenica","id":1453471,"avatar_url":"https://avatars.githubusercontent.com/u/1453471?v=3","gravatar_id":"","url":"https://api.github.com/users/nsenica","html_url":"https://github.com/nsenica","followers_url":"https://api.github.com/users/nsenica/followers","following_url":"https://api.github.com/users/nsenica/following{/other_user}","gists_url":"https://api.github.com/users/nsenica/gists{/gist_id}","starred_url":"https://api.github.com/users/nsenica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsenica/subscriptions","organizations_url":"https://api.github.com/users/nsenica/orgs","repos_url":"https://api.github.com/users/nsenica/repos","events_url":"https://api.github.com/users/nsenica/events{/privacy}","received_events_url":"https://api.github.com/users/nsenica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsenica/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/nsenica/xbmc","forks_url":"https://api.github.com/repos/nsenica/xbmc/forks","keys_url":"https://api.github.com/repos/nsenica/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsenica/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsenica/xbmc/teams","hooks_url":"https://api.github.com/repos/nsenica/xbmc/hooks","issue_events_url":"https://api.github.com/repos/nsenica/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/nsenica/xbmc/events","assignees_url":"https://api.github.com/repos/nsenica/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/nsenica/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/nsenica/xbmc/tags","blobs_url":"https://api.github.com/repos/nsenica/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsenica/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsenica/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsenica/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsenica/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/nsenica/xbmc/languages","stargazers_url":"https://api.github.com/repos/nsenica/xbmc/stargazers","contributors_url":"https://api.github.com/repos/nsenica/xbmc/contributors","subscribers_url":"https://api.github.com/repos/nsenica/xbmc/subscribers","subscription_url":"https://api.github.com/repos/nsenica/xbmc/subscription","commits_url":"https://api.github.com/repos/nsenica/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsenica/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsenica/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsenica/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsenica/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/nsenica/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsenica/xbmc/merges","archive_url":"https://api.github.com/repos/nsenica/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsenica/xbmc/downloads","issues_url":"https://api.github.com/repos/nsenica/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/nsenica/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/nsenica/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/nsenica/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsenica/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/nsenica/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/nsenica/xbmc/deployments","created_at":"2016-12-10T21:37:26Z","updated_at":"2016-12-10T21:37:50Z","pushed_at":"2017-02-07T16:52:37Z","git_url":"git://github.com/nsenica/xbmc.git","ssh_url":"git@github.com:nsenica/xbmc.git","clone_url":"https://github.com/nsenica/xbmc.git","svn_url":"https://github.com/nsenica/xbmc","homepage":"http://xbmc.org","size":639269,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"b6d4856bef550c60cef54eb7a6ae428ec9d05cfd","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2017-02-11T12:44:47Z","pushed_at":"2017-02-11T12:25:15Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1403285,"stargazers_count":5527,"watchers_count":5527,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3941,"mirror_url":null,"open_issues_count":217,"forks":3941,"open_issues":217,"watchers":5527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11585"},"html":{"href":"https://github.com/xbmc/xbmc/pull/11585"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/11585"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/11585/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11585/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11585/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/c046d8bdf349198b8bd52e6f9a1b3e3b0c1635d4"}}}}
{"actor":{"display_login":"nsenica"}}