{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/148426784","pull_request_review_id":73667185,"id":148426784,"diff_hunk":"@@ -1811,6 +1834,29 @@ write_files:\n \treturn fmt.Sprintf(clusterYamlFile, filelines)\n }\n \n+// Identifies a distro to use for master parameters\n+func getDistro(properties *api.Properties) api.Distro {\n+\t// Set a default distro\n+\tdistro := api.Ubuntu\n+\n+\tif properties.MasterProfile == nil {\n+\t\t// Check if AgentPoolProfiles have an assigned distro\n+\t\t// Use distro defined by first agent profile\n+\t\tif len(properties.AgentPoolProfiles) > 0 {","path":"pkg/acsengine/engine.go","position":79,"original_position":79,"commit_id":"4147a644674ffe17d7173fbfd83add827b570161","original_commit_id":"4147a644674ffe17d7173fbfd83add827b570161","user":{"login":"richardjortega","id":1143885,"avatar_url":"https://avatars0.githubusercontent.com/u/1143885?v=4","gravatar_id":"","url":"https://api.github.com/users/richardjortega","html_url":"https://github.com/richardjortega","followers_url":"https://api.github.com/users/richardjortega/followers","following_url":"https://api.github.com/users/richardjortega/following{/other_user}","gists_url":"https://api.github.com/users/richardjortega/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjortega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjortega/subscriptions","organizations_url":"https://api.github.com/users/richardjortega/orgs","repos_url":"https://api.github.com/users/richardjortega/repos","events_url":"https://api.github.com/users/richardjortega/events{/privacy}","received_events_url":"https://api.github.com/users/richardjortega/received_events","type":"User","site_admin":false},"body":"Maybe I don't understand the use case of agents only -- is it a special use case, what if a Master was CoreOS? I would assume, we'd want to match agents with the Master's OS?","created_at":"2017-11-02T01:44:28Z","updated_at":"2017-11-02T01:44:28Z","html_url":"https://github.com/Azure/acs-engine/pull/1632#discussion_r148426784","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/1632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/148426784"},"html":{"href":"https://github.com/Azure/acs-engine/pull/1632#discussion_r148426784"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1632"}},"in_reply_to_id":148412293},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/1632","id":147899041,"html_url":"https://github.com/Azure/acs-engine/pull/1632","diff_url":"https://github.com/Azure/acs-engine/pull/1632.diff","patch_url":"https://github.com/Azure/acs-engine/pull/1632.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/1632","number":1632,"state":"open","locked":false,"title":"Support for CoreOS as a distro for master and agent nodes","user":{"login":"richardjortega","id":1143885,"avatar_url":"https://avatars0.githubusercontent.com/u/1143885?v=4","gravatar_id":"","url":"https://api.github.com/users/richardjortega","html_url":"https://github.com/richardjortega","followers_url":"https://api.github.com/users/richardjortega/followers","following_url":"https://api.github.com/users/richardjortega/following{/other_user}","gists_url":"https://api.github.com/users/richardjortega/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjortega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjortega/subscriptions","organizations_url":"https://api.github.com/users/richardjortega/orgs","repos_url":"https://api.github.com/users/richardjortega/repos","events_url":"https://api.github.com/users/richardjortega/events{/privacy}","received_events_url":"https://api.github.com/users/richardjortega/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**: This PR enables using CoreOS as a supported distro using the `distro` field within the `masterProfile` and `agentPoolProfiles` api-model sections. An example usage is provided at: `examples/kubernetes-coreos.json` . CoreOS custom files are within: `parts/kubernetesmastercustomdataforcoreos.yml` and `parts/kubernetesagentcustomerdataforcoreos.yml`. \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n@anhowe @lachie83 @jackfrancis @uday31in \r\n\r\nThings this commit does NOT have:\r\n- An automated test (would need help with that), right now I've tested it against a rebase of most recent master of acs-engine on Azure.\r\n- acs-engine seems predominantly coupled to Ubuntu distro (e.g. `runcmd` on `cloud-init` isn't supported on CoreOS implementation of cloud-init. This may lead to difficulty of new edits/merges where tests should go across distros (or there may not be feature parity). Right now, I used a pattern I saw in #1408 where another file for custom data was used.  \r\n- This initial implementation uses `cloud-init`/`cloud-config` (specifically CoreOS' implementation of coreos-cloudinit) but CoreOS has stopped supporting coreos-cloudint usage in favor of [Ignition](https://coreos.com/ignition/docs/latest/what-is-ignition.html). \r\n\r\n**Why**: CoreOS was not previously supported (on both Master and Agent nodes).\r\n","created_at":"2017-10-20T21:27:15Z","updated_at":"2017-11-02T01:44:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f715516fd3894a719997d0d300e3c0dfb0d168d","assignee":{"login":"CecileRobertMichon","id":8650424,"avatar_url":"https://avatars2.githubusercontent.com/u/8650424?v=4","gravatar_id":"","url":"https://api.github.com/users/CecileRobertMichon","html_url":"https://github.com/CecileRobertMichon","followers_url":"https://api.github.com/users/CecileRobertMichon/followers","following_url":"https://api.github.com/users/CecileRobertMichon/following{/other_user}","gists_url":"https://api.github.com/users/CecileRobertMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/CecileRobertMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CecileRobertMichon/subscriptions","organizations_url":"https://api.github.com/users/CecileRobertMichon/orgs","repos_url":"https://api.github.com/users/CecileRobertMichon/repos","events_url":"https://api.github.com/users/CecileRobertMichon/events{/privacy}","received_events_url":"https://api.github.com/users/CecileRobertMichon/received_events","type":"User","site_admin":false},"assignees":[{"login":"CecileRobertMichon","id":8650424,"avatar_url":"https://avatars2.githubusercontent.com/u/8650424?v=4","gravatar_id":"","url":"https://api.github.com/users/CecileRobertMichon","html_url":"https://github.com/CecileRobertMichon","followers_url":"https://api.github.com/users/CecileRobertMichon/followers","following_url":"https://api.github.com/users/CecileRobertMichon/following{/other_user}","gists_url":"https://api.github.com/users/CecileRobertMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/CecileRobertMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CecileRobertMichon/subscriptions","organizations_url":"https://api.github.com/users/CecileRobertMichon/orgs","repos_url":"https://api.github.com/users/CecileRobertMichon/repos","events_url":"https://api.github.com/users/CecileRobertMichon/events{/privacy}","received_events_url":"https://api.github.com/users/CecileRobertMichon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/1632/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/1632/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/1632/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/4147a644674ffe17d7173fbfd83add827b570161","head":{"label":"richardjortega:coreos-support","ref":"coreos-support","sha":"4147a644674ffe17d7173fbfd83add827b570161","user":{"login":"richardjortega","id":1143885,"avatar_url":"https://avatars0.githubusercontent.com/u/1143885?v=4","gravatar_id":"","url":"https://api.github.com/users/richardjortega","html_url":"https://github.com/richardjortega","followers_url":"https://api.github.com/users/richardjortega/followers","following_url":"https://api.github.com/users/richardjortega/following{/other_user}","gists_url":"https://api.github.com/users/richardjortega/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjortega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjortega/subscriptions","organizations_url":"https://api.github.com/users/richardjortega/orgs","repos_url":"https://api.github.com/users/richardjortega/repos","events_url":"https://api.github.com/users/richardjortega/events{/privacy}","received_events_url":"https://api.github.com/users/richardjortega/received_events","type":"User","site_admin":false},"repo":{"id":107217760,"name":"acs-engine","full_name":"richardjortega/acs-engine","owner":{"login":"richardjortega","id":1143885,"avatar_url":"https://avatars0.githubusercontent.com/u/1143885?v=4","gravatar_id":"","url":"https://api.github.com/users/richardjortega","html_url":"https://github.com/richardjortega","followers_url":"https://api.github.com/users/richardjortega/followers","following_url":"https://api.github.com/users/richardjortega/following{/other_user}","gists_url":"https://api.github.com/users/richardjortega/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjortega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjortega/subscriptions","organizations_url":"https://api.github.com/users/richardjortega/orgs","repos_url":"https://api.github.com/users/richardjortega/repos","events_url":"https://api.github.com/users/richardjortega/events{/privacy}","received_events_url":"https://api.github.com/users/richardjortega/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardjortega/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/richardjortega/acs-engine","forks_url":"https://api.github.com/repos/richardjortega/acs-engine/forks","keys_url":"https://api.github.com/repos/richardjortega/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardjortega/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardjortega/acs-engine/teams","hooks_url":"https://api.github.com/repos/richardjortega/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/richardjortega/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/richardjortega/acs-engine/events","assignees_url":"https://api.github.com/repos/richardjortega/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/richardjortega/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/richardjortega/acs-engine/tags","blobs_url":"https://api.github.com/repos/richardjortega/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardjortega/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardjortega/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardjortega/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardjortega/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/richardjortega/acs-engine/languages","stargazers_url":"https://api.github.com/repos/richardjortega/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/richardjortega/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/richardjortega/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/richardjortega/acs-engine/subscription","commits_url":"https://api.github.com/repos/richardjortega/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardjortega/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardjortega/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardjortega/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardjortega/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/richardjortega/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardjortega/acs-engine/merges","archive_url":"https://api.github.com/repos/richardjortega/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardjortega/acs-engine/downloads","issues_url":"https://api.github.com/repos/richardjortega/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/richardjortega/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/richardjortega/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/richardjortega/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardjortega/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/richardjortega/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/richardjortega/acs-engine/deployments","created_at":"2017-10-17T04:25:50Z","updated_at":"2017-10-17T04:25:54Z","pushed_at":"2017-10-31T04:38:23Z","git_url":"git://github.com/richardjortega/acs-engine.git","ssh_url":"git@github.com:richardjortega/acs-engine.git","clone_url":"https://github.com/richardjortega/acs-engine.git","svn_url":"https://github.com/richardjortega/acs-engine","homepage":"","size":44687,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"806c91082d8448c063f45b263db7a24b5c2dfbc9","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2017-11-01T20:09:43Z","pushed_at":"2017-11-02T01:34:58Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":55957,"stargazers_count":516,"watchers_count":516,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":304,"mirror_url":null,"archived":false,"open_issues_count":281,"forks":304,"open_issues":281,"watchers":516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1632"},"html":{"href":"https://github.com/Azure/acs-engine/pull/1632"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/1632"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/1632/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1632/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1632/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/4147a644674ffe17d7173fbfd83add827b570161"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"richardjortega"}}