{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/122391438","pull_request_review_id":44503147,"id":122391438,"diff_hunk":"@@ -1234,6 +1234,9 @@ gpvars_assign_gp_resource_manager_policy(const char *newval, bool doit, GucSourc\n \tif (doit)\n \t{\n \t\tGp_resource_manager_policy = newtype;\n+\n+\t\tif (newtype == RESOURCE_MANAGER_POLICY_GROUP)\n+\t\t\tgp_enable_resqueue_priority = false;","path":"src/backend/cdb/cdbvars.c","position":6,"original_position":6,"commit_id":"003db58057783172a377616d9fe8f10f3a74876d","original_commit_id":"003db58057783172a377616d9fe8f10f3a74876d","user":{"login":"eurekaka","id":6261973,"avatar_url":"https://avatars1.githubusercontent.com/u/6261973?v=3","gravatar_id":"","url":"https://api.github.com/users/eurekaka","html_url":"https://github.com/eurekaka","followers_url":"https://api.github.com/users/eurekaka/followers","following_url":"https://api.github.com/users/eurekaka/following{/other_user}","gists_url":"https://api.github.com/users/eurekaka/gists{/gist_id}","starred_url":"https://api.github.com/users/eurekaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurekaka/subscriptions","organizations_url":"https://api.github.com/users/eurekaka/orgs","repos_url":"https://api.github.com/users/eurekaka/repos","events_url":"https://api.github.com/users/eurekaka/events{/privacy}","received_events_url":"https://api.github.com/users/eurekaka/received_events","type":"User","site_admin":false},"body":"Sure, I will add some comments here. The warning is only available in the log, I think it may not help much, so I prefer comments.","created_at":"2017-06-16T08:34:50Z","updated_at":"2017-06-16T08:34:50Z","html_url":"https://github.com/greenplum-db/gpdb/pull/2631#discussion_r122391438","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/122391438"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2631#discussion_r122391438"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631","id":125951093,"html_url":"https://github.com/greenplum-db/gpdb/pull/2631","diff_url":"https://github.com/greenplum-db/gpdb/pull/2631.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/2631.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2631","number":2631,"state":"open","locked":false,"title":"2 small fixes for resource manager","user":{"login":"eurekaka","id":6261973,"avatar_url":"https://avatars1.githubusercontent.com/u/6261973?v=3","gravatar_id":"","url":"https://api.github.com/users/eurekaka","html_url":"https://github.com/eurekaka","followers_url":"https://api.github.com/users/eurekaka/followers","following_url":"https://api.github.com/users/eurekaka/following{/other_user}","gists_url":"https://api.github.com/users/eurekaka/gists{/gist_id}","starred_url":"https://api.github.com/users/eurekaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurekaka/subscriptions","organizations_url":"https://api.github.com/users/eurekaka/orgs","repos_url":"https://api.github.com/users/eurekaka/repos","events_url":"https://api.github.com/users/eurekaka/events{/privacy}","received_events_url":"https://api.github.com/users/eurekaka/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-16T03:04:48Z","updated_at":"2017-06-16T08:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acbb793e5b7b76f3c8a13d2dde1213d1dc9b2fec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xiong-gang","id":14144434,"avatar_url":"https://avatars3.githubusercontent.com/u/14144434?v=3","gravatar_id":"","url":"https://api.github.com/users/xiong-gang","html_url":"https://github.com/xiong-gang","followers_url":"https://api.github.com/users/xiong-gang/followers","following_url":"https://api.github.com/users/xiong-gang/following{/other_user}","gists_url":"https://api.github.com/users/xiong-gang/gists{/gist_id}","starred_url":"https://api.github.com/users/xiong-gang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiong-gang/subscriptions","organizations_url":"https://api.github.com/users/xiong-gang/orgs","repos_url":"https://api.github.com/users/xiong-gang/repos","events_url":"https://api.github.com/users/xiong-gang/events{/privacy}","received_events_url":"https://api.github.com/users/xiong-gang/received_events","type":"User","site_admin":false},{"login":"pengzhout","id":14901939,"avatar_url":"https://avatars2.githubusercontent.com/u/14901939?v=3","gravatar_id":"","url":"https://api.github.com/users/pengzhout","html_url":"https://github.com/pengzhout","followers_url":"https://api.github.com/users/pengzhout/followers","following_url":"https://api.github.com/users/pengzhout/following{/other_user}","gists_url":"https://api.github.com/users/pengzhout/gists{/gist_id}","starred_url":"https://api.github.com/users/pengzhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengzhout/subscriptions","organizations_url":"https://api.github.com/users/pengzhout/orgs","repos_url":"https://api.github.com/users/pengzhout/repos","events_url":"https://api.github.com/users/pengzhout/events{/privacy}","received_events_url":"https://api.github.com/users/pengzhout/received_events","type":"User","site_admin":false},{"login":"guofengrichard","id":24584062,"avatar_url":"https://avatars1.githubusercontent.com/u/24584062?v=3","gravatar_id":"","url":"https://api.github.com/users/guofengrichard","html_url":"https://github.com/guofengrichard","followers_url":"https://api.github.com/users/guofengrichard/followers","following_url":"https://api.github.com/users/guofengrichard/following{/other_user}","gists_url":"https://api.github.com/users/guofengrichard/gists{/gist_id}","starred_url":"https://api.github.com/users/guofengrichard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guofengrichard/subscriptions","organizations_url":"https://api.github.com/users/guofengrichard/orgs","repos_url":"https://api.github.com/users/guofengrichard/repos","events_url":"https://api.github.com/users/guofengrichard/events{/privacy}","received_events_url":"https://api.github.com/users/guofengrichard/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2631/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/003db58057783172a377616d9fe8f10f3a74876d","head":{"label":"eurekaka:queue_view","ref":"queue_view","sha":"003db58057783172a377616d9fe8f10f3a74876d","user":{"login":"eurekaka","id":6261973,"avatar_url":"https://avatars1.githubusercontent.com/u/6261973?v=3","gravatar_id":"","url":"https://api.github.com/users/eurekaka","html_url":"https://github.com/eurekaka","followers_url":"https://api.github.com/users/eurekaka/followers","following_url":"https://api.github.com/users/eurekaka/following{/other_user}","gists_url":"https://api.github.com/users/eurekaka/gists{/gist_id}","starred_url":"https://api.github.com/users/eurekaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurekaka/subscriptions","organizations_url":"https://api.github.com/users/eurekaka/orgs","repos_url":"https://api.github.com/users/eurekaka/repos","events_url":"https://api.github.com/users/eurekaka/events{/privacy}","received_events_url":"https://api.github.com/users/eurekaka/received_events","type":"User","site_admin":false},"repo":{"id":45974087,"name":"gpdb","full_name":"eurekaka/gpdb","owner":{"login":"eurekaka","id":6261973,"avatar_url":"https://avatars1.githubusercontent.com/u/6261973?v=3","gravatar_id":"","url":"https://api.github.com/users/eurekaka","html_url":"https://github.com/eurekaka","followers_url":"https://api.github.com/users/eurekaka/followers","following_url":"https://api.github.com/users/eurekaka/following{/other_user}","gists_url":"https://api.github.com/users/eurekaka/gists{/gist_id}","starred_url":"https://api.github.com/users/eurekaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurekaka/subscriptions","organizations_url":"https://api.github.com/users/eurekaka/orgs","repos_url":"https://api.github.com/users/eurekaka/repos","events_url":"https://api.github.com/users/eurekaka/events{/privacy}","received_events_url":"https://api.github.com/users/eurekaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eurekaka/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/eurekaka/gpdb","forks_url":"https://api.github.com/repos/eurekaka/gpdb/forks","keys_url":"https://api.github.com/repos/eurekaka/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eurekaka/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eurekaka/gpdb/teams","hooks_url":"https://api.github.com/repos/eurekaka/gpdb/hooks","issue_events_url":"https://api.github.com/repos/eurekaka/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/eurekaka/gpdb/events","assignees_url":"https://api.github.com/repos/eurekaka/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/eurekaka/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/eurekaka/gpdb/tags","blobs_url":"https://api.github.com/repos/eurekaka/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eurekaka/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eurekaka/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/eurekaka/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eurekaka/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/eurekaka/gpdb/languages","stargazers_url":"https://api.github.com/repos/eurekaka/gpdb/stargazers","contributors_url":"https://api.github.com/repos/eurekaka/gpdb/contributors","subscribers_url":"https://api.github.com/repos/eurekaka/gpdb/subscribers","subscription_url":"https://api.github.com/repos/eurekaka/gpdb/subscription","commits_url":"https://api.github.com/repos/eurekaka/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/eurekaka/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/eurekaka/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/eurekaka/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/eurekaka/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/eurekaka/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eurekaka/gpdb/merges","archive_url":"https://api.github.com/repos/eurekaka/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eurekaka/gpdb/downloads","issues_url":"https://api.github.com/repos/eurekaka/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/eurekaka/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/eurekaka/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/eurekaka/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eurekaka/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/eurekaka/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/eurekaka/gpdb/deployments","created_at":"2015-11-11T10:06:46Z","updated_at":"2017-03-29T08:26:08Z","pushed_at":"2017-06-15T08:24:55Z","git_url":"git://github.com/eurekaka/gpdb.git","ssh_url":"git@github.com:eurekaka/gpdb.git","clone_url":"https://github.com/eurekaka/gpdb.git","svn_url":"https://github.com/eurekaka/gpdb","homepage":"http://greenplum.org","size":213500,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"df591270aaedeed7dd91e3d6052e1d55a8712203","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2017-06-16T07:32:36Z","pushed_at":"2017-06-16T04:48:50Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":213158,"stargazers_count":1972,"watchers_count":1972,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":604,"mirror_url":null,"open_issues_count":143,"forks":604,"open_issues":143,"watchers":1972,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2631"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2631"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2631/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2631/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/003db58057783172a377616d9fe8f10f3a74876d"}}}}
{"actor":{"display_login":"eurekaka"}}