{"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/34","id":119098077,"html_url":"https://github.com/signalfx/signalfx-nodejs/pull/34","diff_url":"https://github.com/signalfx/signalfx-nodejs/pull/34.diff","patch_url":"https://github.com/signalfx/signalfx-nodejs/pull/34.patch","issue_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/34","number":34,"state":"closed","locked":false,"title":"Fix unit tests for decoding compressed socket messages","user":{"login":"mpetazzoni","id":879507,"avatar_url":"https://avatars1.githubusercontent.com/u/879507?v=3","gravatar_id":"","url":"https://api.github.com/users/mpetazzoni","html_url":"https://github.com/mpetazzoni","followers_url":"https://api.github.com/users/mpetazzoni/followers","following_url":"https://api.github.com/users/mpetazzoni/following{/other_user}","gists_url":"https://api.github.com/users/mpetazzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mpetazzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpetazzoni/subscriptions","organizations_url":"https://api.github.com/users/mpetazzoni/orgs","repos_url":"https://api.github.com/users/mpetazzoni/repos","events_url":"https://api.github.com/users/mpetazzoni/events{/privacy}","received_events_url":"https://api.github.com/users/mpetazzoni/received_events","type":"User","site_admin":false},"body":"The binary data in the test case was incorrect leading to a decoding\r\nerror that was silently swallowed.\r\n\r\nAlso fix the test of the decoding a non-data compressed message, as the\r\nheader fields of the message should be included in the returned object,\r\nnot just the body fields.","created_at":"2017-05-05T01:41:50Z","updated_at":"2017-05-05T02:00:15Z","closed_at":"2017-05-05T02:00:15Z","merged_at":"2017-05-05T02:00:15Z","merge_commit_sha":"2cdc099fef00ff41fd92a12c43c5ea4425409036","assignee":{"login":"kchengsf","id":5263731,"avatar_url":"https://avatars2.githubusercontent.com/u/5263731?v=3","gravatar_id":"","url":"https://api.github.com/users/kchengsf","html_url":"https://github.com/kchengsf","followers_url":"https://api.github.com/users/kchengsf/followers","following_url":"https://api.github.com/users/kchengsf/following{/other_user}","gists_url":"https://api.github.com/users/kchengsf/gists{/gist_id}","starred_url":"https://api.github.com/users/kchengsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchengsf/subscriptions","organizations_url":"https://api.github.com/users/kchengsf/orgs","repos_url":"https://api.github.com/users/kchengsf/repos","events_url":"https://api.github.com/users/kchengsf/events{/privacy}","received_events_url":"https://api.github.com/users/kchengsf/received_events","type":"User","site_admin":false},"assignees":[{"login":"kchengsf","id":5263731,"avatar_url":"https://avatars2.githubusercontent.com/u/5263731?v=3","gravatar_id":"","url":"https://api.github.com/users/kchengsf","html_url":"https://github.com/kchengsf","followers_url":"https://api.github.com/users/kchengsf/followers","following_url":"https://api.github.com/users/kchengsf/following{/other_user}","gists_url":"https://api.github.com/users/kchengsf/gists{/gist_id}","starred_url":"https://api.github.com/users/kchengsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchengsf/subscriptions","organizations_url":"https://api.github.com/users/kchengsf/orgs","repos_url":"https://api.github.com/users/kchengsf/repos","events_url":"https://api.github.com/users/kchengsf/events{/privacy}","received_events_url":"https://api.github.com/users/kchengsf/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/34/commits","review_comments_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/34/comments","review_comment_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/34/comments","statuses_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/statuses/fa8eb230e222f0cb300fc84c550e8a94be328785","head":{"label":"signalfx:wip/fix-tests","ref":"wip/fix-tests","sha":"fa8eb230e222f0cb300fc84c550e8a94be328785","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":41708865,"name":"signalfx-nodejs","full_name":"signalfx/signalfx-nodejs","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-nodejs","description":"Node.js client library for SignalFx","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-nodejs","forks_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/deployments","created_at":"2015-09-01T01:02:14Z","updated_at":"2017-03-21T20:28:26Z","pushed_at":"2017-05-05T02:00:15Z","git_url":"git://github.com/signalfx/signalfx-nodejs.git","ssh_url":"git@github.com:signalfx/signalfx-nodejs.git","clone_url":"https://github.com/signalfx/signalfx-nodejs.git","svn_url":"https://github.com/signalfx/signalfx-nodejs","homepage":null,"size":110,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"signalfx:master","ref":"master","sha":"4d7a24f405f61706d330dfdc7b753feda0b03879","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":41708865,"name":"signalfx-nodejs","full_name":"signalfx/signalfx-nodejs","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-nodejs","description":"Node.js client library for SignalFx","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-nodejs","forks_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-nodejs/deployments","created_at":"2015-09-01T01:02:14Z","updated_at":"2017-03-21T20:28:26Z","pushed_at":"2017-05-05T02:00:15Z","git_url":"git://github.com/signalfx/signalfx-nodejs.git","ssh_url":"git@github.com:signalfx/signalfx-nodejs.git","clone_url":"https://github.com/signalfx/signalfx-nodejs.git","svn_url":"https://github.com/signalfx/signalfx-nodejs","homepage":null,"size":110,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/34"},"html":{"href":"https://github.com/signalfx/signalfx-nodejs/pull/34"},"issue":{"href":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/34"},"comments":{"href":"https://api.github.com/repos/signalfx/signalfx-nodejs/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalfx/signalfx-nodejs/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/signalfx/signalfx-nodejs/statuses/fa8eb230e222f0cb300fc84c550e8a94be328785"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kchengsf","id":5263731,"avatar_url":"https://avatars2.githubusercontent.com/u/5263731?v=3","gravatar_id":"","url":"https://api.github.com/users/kchengsf","html_url":"https://github.com/kchengsf","followers_url":"https://api.github.com/users/kchengsf/followers","following_url":"https://api.github.com/users/kchengsf/following{/other_user}","gists_url":"https://api.github.com/users/kchengsf/gists{/gist_id}","starred_url":"https://api.github.com/users/kchengsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchengsf/subscriptions","organizations_url":"https://api.github.com/users/kchengsf/orgs","repos_url":"https://api.github.com/users/kchengsf/repos","events_url":"https://api.github.com/users/kchengsf/events{/privacy}","received_events_url":"https://api.github.com/users/kchengsf/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":69,"deletions":42,"changed_files":2}}
{"actor":{"display_login":"kchengsf"}}