{"action":"created","issue":{"url":"https://api.github.com/repos/davidtheclark/cosmiconfig/issues/101","repository_url":"https://api.github.com/repos/davidtheclark/cosmiconfig","labels_url":"https://api.github.com/repos/davidtheclark/cosmiconfig/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/davidtheclark/cosmiconfig/issues/101/comments","events_url":"https://api.github.com/repos/davidtheclark/cosmiconfig/issues/101/events","html_url":"https://github.com/davidtheclark/cosmiconfig/pull/101","id":280697020,"number":101,"title":"Bump parse-json from 3.0.0 to 4.0.0","user":{"login":"sudo-suhas","id":22251956,"avatar_url":"https://avatars2.githubusercontent.com/u/22251956?v=4","gravatar_id":"","url":"https://api.github.com/users/sudo-suhas","html_url":"https://github.com/sudo-suhas","followers_url":"https://api.github.com/users/sudo-suhas/followers","following_url":"https://api.github.com/users/sudo-suhas/following{/other_user}","gists_url":"https://api.github.com/users/sudo-suhas/gists{/gist_id}","starred_url":"https://api.github.com/users/sudo-suhas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudo-suhas/subscriptions","organizations_url":"https://api.github.com/users/sudo-suhas/orgs","repos_url":"https://api.github.com/users/sudo-suhas/repos","events_url":"https://api.github.com/users/sudo-suhas/events{/privacy}","received_events_url":"https://api.github.com/users/sudo-suhas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-12-09T07:38:41Z","updated_at":"2017-12-21T03:13:42Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/davidtheclark/cosmiconfig/pulls/101","html_url":"https://github.com/davidtheclark/cosmiconfig/pull/101","diff_url":"https://github.com/davidtheclark/cosmiconfig/pull/101.diff","patch_url":"https://github.com/davidtheclark/cosmiconfig/pull/101.patch"},"body":"This bumps the version for package `parse-json` from `3.0.0` to `4.0.0`. Due to the difference in error messages generated by `parse-json`, it was a major version change(relevant PR - sindresorhus/parse-json#12). Here are some sample error messages before and after the version change:\r\n\r\n***Before:***\r\n``` \r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\fixtures\\foo-invalid.json:\r\nUnexpected token '\\n' at 2:15\r\n  \"foo\": true:\r\n              ^\r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\a\\b\\.foorc:\r\nTrailing comma in object at 1:18\r\n{ \"found\": true, }\r\n                 ^\r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\a\\b\\package.json:\r\nTrailing comma in object at 1:17\r\n{ \"foo\": \"bar\", }\r\n                ^\r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\a\\b\\c\\d\\e\\f\\.foorc.json:\r\nUnexpected token ',' at 1:17\r\n{ \"found\": true,, }\r\n                ^\r\n```\r\n\r\n***After:***\r\n```\r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\fixtures\\foo-invalid.json:\r\nUnexpected token : in JSON at position 15 while parsing near '{  \"foo\": true:}'\r\n\r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\a\\b\\.foorc:\r\nUnexpected token } in JSON at position 17 while parsing near '{ \"found\": true, }'\r\n\r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\a\\b\\package.json:\r\nUnexpected token } in JSON at position 16 while parsing near '{ \"foo\": \"bar\", }'\r\n\r\nJSON Error in E:\\Projects\\repos\\cosmiconfig\\test\\a\\b\\c\\d\\e\\f\\.foorc.json:\r\nUnexpected token , in JSON at position 16 while parsing near '{ \"found\": true,, }'\r\n```\r\n\r\n**NOTE:** It should be possible to derive the line and column position from the new format using something like [`string-pos`](https://www.npmjs.com/package/string-pos)\r\n\r\n<details>\r\n<summary>no longer relevant</summary>\r\n\r\nI have a couple of questions:\r\n- Is there any reason we should not update to this version of the package?\r\n- Will this be a major version change for `cosmiconfig` as well?\r\n\r\n</details>\r\n<br>\r\ncc @azz"},"comment":{"url":"https://api.github.com/repos/davidtheclark/cosmiconfig/issues/comments/353247052","html_url":"https://github.com/davidtheclark/cosmiconfig/pull/101#issuecomment-353247052","issue_url":"https://api.github.com/repos/davidtheclark/cosmiconfig/issues/101","id":353247052,"user":{"login":"sudo-suhas","id":22251956,"avatar_url":"https://avatars2.githubusercontent.com/u/22251956?v=4","gravatar_id":"","url":"https://api.github.com/users/sudo-suhas","html_url":"https://github.com/sudo-suhas","followers_url":"https://api.github.com/users/sudo-suhas/followers","following_url":"https://api.github.com/users/sudo-suhas/following{/other_user}","gists_url":"https://api.github.com/users/sudo-suhas/gists{/gist_id}","starred_url":"https://api.github.com/users/sudo-suhas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudo-suhas/subscriptions","organizations_url":"https://api.github.com/users/sudo-suhas/orgs","repos_url":"https://api.github.com/users/sudo-suhas/repos","events_url":"https://api.github.com/users/sudo-suhas/events{/privacy}","received_events_url":"https://api.github.com/users/sudo-suhas/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T03:13:42Z","updated_at":"2017-12-21T03:13:42Z","author_association":"COLLABORATOR","body":"@davidtheclark Please take a look at the changelog and let me know if you think it is sufficient. Will merge and release with a major version change after that."}}
{"actor":{"display_login":"sudo-suhas"}}