{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/comments/149811984","pull_request_review_id":75267233,"id":149811984,"diff_hunk":"@@ -10,6 +10,12 @@ RUN mkdir -p /run/docker/plugins /etc/openvswitch /var/run/contiv/log \\\n  && wget https://github.com/andyshinn/alpine-pkg-glibc/releases/download/2.23-r1/glibc-2.23-r1.apk \\\n  && apk --no-cache add glibc-2.23-r1.apk\n \n-COPY netplugin netmaster netctl startcontiv.sh /\n+# copy in binaries and scripts\n+ARG TAR_FILE\n+ADD ${TAR_FILE} /","path":"install/v2plugin/Dockerfile","position":7,"original_position":7,"commit_id":"be82f8c4e1d8b2205e6a68daefd48358b2c09916","original_commit_id":"be82f8c4e1d8b2205e6a68daefd48358b2c09916","user":{"login":"dseevr","id":97581,"avatar_url":"https://avatars2.githubusercontent.com/u/97581?v=4","gravatar_id":"","url":"https://api.github.com/users/dseevr","html_url":"https://github.com/dseevr","followers_url":"https://api.github.com/users/dseevr/followers","following_url":"https://api.github.com/users/dseevr/following{/other_user}","gists_url":"https://api.github.com/users/dseevr/gists{/gist_id}","starred_url":"https://api.github.com/users/dseevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dseevr/subscriptions","organizations_url":"https://api.github.com/users/dseevr/orgs","repos_url":"https://api.github.com/users/dseevr/repos","events_url":"https://api.github.com/users/dseevr/events{/privacy}","received_events_url":"https://api.github.com/users/dseevr/received_events","type":"User","site_admin":false},"body":"If you're copying local files, use `COPY` instead of `ADD` ... generally you will not want to use `ADD` for anything, and all of Docker's official Dockerfiles have moved from `ADD` to `COPY` now","created_at":"2017-11-08T22:10:24Z","updated_at":"2017-11-08T22:10:55Z","html_url":"https://github.com/contiv/netplugin/pull/1040#discussion_r149811984","pull_request_url":"https://api.github.com/repos/contiv/netplugin/pulls/1040","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments/149811984"},"html":{"href":"https://github.com/contiv/netplugin/pull/1040#discussion_r149811984"},"pull_request":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/1040"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/1040","id":149890486,"html_url":"https://github.com/contiv/netplugin/pull/1040","diff_url":"https://github.com/contiv/netplugin/pull/1040.diff","patch_url":"https://github.com/contiv/netplugin/pull/1040.patch","issue_url":"https://api.github.com/repos/contiv/netplugin/issues/1040","number":1040,"state":"open","locked":false,"title":"Build versioned v2plugin from versioned binaries","user":{"login":"chrisplo","id":13784493,"avatar_url":"https://avatars2.githubusercontent.com/u/13784493?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisplo","html_url":"https://github.com/chrisplo","followers_url":"https://api.github.com/users/chrisplo/followers","following_url":"https://api.github.com/users/chrisplo/following{/other_user}","gists_url":"https://api.github.com/users/chrisplo/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisplo/subscriptions","organizations_url":"https://api.github.com/users/chrisplo/orgs","repos_url":"https://api.github.com/users/chrisplo/repos","events_url":"https://api.github.com/users/chrisplo/events{/privacy}","received_events_url":"https://api.github.com/users/chrisplo/received_events","type":"User","site_admin":false},"body":"This enables build and caching locally or in a build machine the\r\nv2plugin before creating test environment VMs and failing much faster\r\non any PR issues, which is good for CI turnaround.\r\n\r\nv2plugin_rootfs (called by host-pluginfs-create) builds a docker\r\ncontainer runtime with a versioned archive of netplugin binaries, then\r\nextracts the entire filesystem from the container, which is now left as\r\na versioned tarball.\r\n\r\nThe versioned archive of netplugin binaries used for v2plugin can now be\r\ncreated in two ways:\r\n* run-build (dependency for demo-v2plugin) will compile then version an\r\n  archive with built assets (runs only on the VM)\r\n* tar target (locally or in VM)\r\n\r\nhost-pluginfs-create can be run in the VM or locally\r\n\r\nLeaving the plugin rootfs as a tarball has a few advantages reasons:\r\n* docker in a VM had internal issues when creating the plugin when the\r\n  rootfs was unarchived on the host and exposed though a virtualbox\r\n  mount, at least on OS X\r\n* the rootfs is versioned\r\n\r\nThis adjusted host-plugin-release and demo-v2plugin to both use a new\r\ntarget 'host-pluginfs-unpack'\r\n\r\nDrive-by:\r\n* Fix Dockerfile by adding objdb which is needed by vendored packages\r\n* Fix config.template for the CONTIV_V2PLUGIN_NAME replacement","created_at":"2017-10-31T19:47:47Z","updated_at":"2017-11-08T22:10:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"847094b6af6a61b1b05e10f60449a31910b6c976","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/contiv/netplugin/pulls/1040/commits","review_comments_url":"https://api.github.com/repos/contiv/netplugin/pulls/1040/comments","review_comment_url":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/netplugin/issues/1040/comments","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/be82f8c4e1d8b2205e6a68daefd48358b2c09916","head":{"label":"chrisplo:v2plugin_local_versioned","ref":"v2plugin_local_versioned","sha":"be82f8c4e1d8b2205e6a68daefd48358b2c09916","user":{"login":"chrisplo","id":13784493,"avatar_url":"https://avatars2.githubusercontent.com/u/13784493?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisplo","html_url":"https://github.com/chrisplo","followers_url":"https://api.github.com/users/chrisplo/followers","following_url":"https://api.github.com/users/chrisplo/following{/other_user}","gists_url":"https://api.github.com/users/chrisplo/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisplo/subscriptions","organizations_url":"https://api.github.com/users/chrisplo/orgs","repos_url":"https://api.github.com/users/chrisplo/repos","events_url":"https://api.github.com/users/chrisplo/events{/privacy}","received_events_url":"https://api.github.com/users/chrisplo/received_events","type":"User","site_admin":false},"repo":{"id":105818726,"name":"netplugin","full_name":"chrisplo/netplugin","owner":{"login":"chrisplo","id":13784493,"avatar_url":"https://avatars2.githubusercontent.com/u/13784493?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisplo","html_url":"https://github.com/chrisplo","followers_url":"https://api.github.com/users/chrisplo/followers","following_url":"https://api.github.com/users/chrisplo/following{/other_user}","gists_url":"https://api.github.com/users/chrisplo/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisplo/subscriptions","organizations_url":"https://api.github.com/users/chrisplo/orgs","repos_url":"https://api.github.com/users/chrisplo/repos","events_url":"https://api.github.com/users/chrisplo/events{/privacy}","received_events_url":"https://api.github.com/users/chrisplo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisplo/netplugin","description":"Container networking for various use cases","fork":true,"url":"https://api.github.com/repos/chrisplo/netplugin","forks_url":"https://api.github.com/repos/chrisplo/netplugin/forks","keys_url":"https://api.github.com/repos/chrisplo/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisplo/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisplo/netplugin/teams","hooks_url":"https://api.github.com/repos/chrisplo/netplugin/hooks","issue_events_url":"https://api.github.com/repos/chrisplo/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/chrisplo/netplugin/events","assignees_url":"https://api.github.com/repos/chrisplo/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/chrisplo/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/chrisplo/netplugin/tags","blobs_url":"https://api.github.com/repos/chrisplo/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisplo/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisplo/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisplo/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisplo/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisplo/netplugin/languages","stargazers_url":"https://api.github.com/repos/chrisplo/netplugin/stargazers","contributors_url":"https://api.github.com/repos/chrisplo/netplugin/contributors","subscribers_url":"https://api.github.com/repos/chrisplo/netplugin/subscribers","subscription_url":"https://api.github.com/repos/chrisplo/netplugin/subscription","commits_url":"https://api.github.com/repos/chrisplo/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisplo/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisplo/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisplo/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisplo/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/chrisplo/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisplo/netplugin/merges","archive_url":"https://api.github.com/repos/chrisplo/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisplo/netplugin/downloads","issues_url":"https://api.github.com/repos/chrisplo/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/chrisplo/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisplo/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisplo/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisplo/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/chrisplo/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/chrisplo/netplugin/deployments","created_at":"2017-10-04T21:10:12Z","updated_at":"2017-10-04T21:10:14Z","pushed_at":"2017-11-07T21:57:04Z","git_url":"git://github.com/chrisplo/netplugin.git","ssh_url":"git@github.com:chrisplo/netplugin.git","clone_url":"https://github.com/chrisplo/netplugin.git","svn_url":"https://github.com/chrisplo/netplugin","homepage":"","size":33270,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"cbc71c4689ded8cc41743c7cd533765d5b104347","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars3.githubusercontent.com/u/10272443?v=4","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":28353322,"name":"netplugin","full_name":"contiv/netplugin","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars3.githubusercontent.com/u/10272443?v=4","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/netplugin","description":"Container networking for various use cases","fork":false,"url":"https://api.github.com/repos/contiv/netplugin","forks_url":"https://api.github.com/repos/contiv/netplugin/forks","keys_url":"https://api.github.com/repos/contiv/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/netplugin/teams","hooks_url":"https://api.github.com/repos/contiv/netplugin/hooks","issue_events_url":"https://api.github.com/repos/contiv/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/netplugin/events","assignees_url":"https://api.github.com/repos/contiv/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/netplugin/tags","blobs_url":"https://api.github.com/repos/contiv/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/netplugin/languages","stargazers_url":"https://api.github.com/repos/contiv/netplugin/stargazers","contributors_url":"https://api.github.com/repos/contiv/netplugin/contributors","subscribers_url":"https://api.github.com/repos/contiv/netplugin/subscribers","subscription_url":"https://api.github.com/repos/contiv/netplugin/subscription","commits_url":"https://api.github.com/repos/contiv/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/netplugin/merges","archive_url":"https://api.github.com/repos/contiv/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/netplugin/downloads","issues_url":"https://api.github.com/repos/contiv/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/contiv/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/netplugin/deployments","created_at":"2014-12-22T18:45:21Z","updated_at":"2017-10-31T13:02:40Z","pushed_at":"2017-11-08T18:17:02Z","git_url":"git://github.com/contiv/netplugin.git","ssh_url":"git@github.com:contiv/netplugin.git","clone_url":"https://github.com/contiv/netplugin.git","svn_url":"https://github.com/contiv/netplugin","homepage":"","size":33254,"stargazers_count":309,"watchers_count":309,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"open_issues_count":128,"forks":126,"open_issues":128,"watchers":309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/1040"},"html":{"href":"https://github.com/contiv/netplugin/pull/1040"},"issue":{"href":"https://api.github.com/repos/contiv/netplugin/issues/1040"},"comments":{"href":"https://api.github.com/repos/contiv/netplugin/issues/1040/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/1040/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/1040/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/netplugin/statuses/be82f8c4e1d8b2205e6a68daefd48358b2c09916"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dseevr"}}