{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments/142150606","pull_request_review_id":66469636,"id":142150606,"diff_hunk":"@@ -79,21 +80,18 @@ - (void)sdl_parseViewHierarchy:(UIView *)currentView {\n     }]];\n     \n     BOOL isButton = [currentView isKindOfClass:[UIButton class]];\n-    //if current view is focusable and it doesn't have any focusable sub views then add the cuurent view and return\n     if ((currentView.canBecomeFocused || isButton) && focusableSubviews.count == 0) {\n+        //if current view is focusable and it doesn't have any focusable sub views then add the cuurent view and return","path":"SmartDeviceLink/SDLHapticManager.m","position":23,"original_position":23,"commit_id":"abb4304cb16dd009b36002f2e5065901474e7cc7","original_commit_id":"abb4304cb16dd009b36002f2e5065901474e7cc7","user":{"login":"NicoleYarroch","id":19915981,"avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false},"body":"Spelling","created_at":"2017-10-02T14:16:07Z","updated_at":"2017-10-02T14:16:07Z","html_url":"https://github.com/smartdevicelink/sdl_ios/pull/753#discussion_r142150606","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments/142150606"},"html":{"href":"https://github.com/smartdevicelink/sdl_ios/pull/753#discussion_r142150606"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753","id":143720976,"html_url":"https://github.com/smartdevicelink/sdl_ios/pull/753","diff_url":"https://github.com/smartdevicelink/sdl_ios/pull/753.diff","patch_url":"https://github.com/smartdevicelink/sdl_ios/pull/753.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/753","number":753,"state":"open","locked":false,"title":"Integration for haptic manager into the SMM","user":{"login":"joeljfischer","id":1767063,"avatar_url":"https://avatars0.githubusercontent.com/u/1767063?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljfischer","html_url":"https://github.com/joeljfischer","followers_url":"https://api.github.com/users/joeljfischer/followers","following_url":"https://api.github.com/users/joeljfischer/following{/other_user}","gists_url":"https://api.github.com/users/joeljfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljfischer/subscriptions","organizations_url":"https://api.github.com/users/joeljfischer/orgs","repos_url":"https://api.github.com/users/joeljfischer/repos","events_url":"https://api.github.com/users/joeljfischer/events{/privacy}","received_events_url":"https://api.github.com/users/joeljfischer/received_events","type":"User","site_admin":false},"body":"Fixes #698, #728\r\n\r\nThis PR is **ready** for review.\r\n\r\n### Risk\r\nThis PR makes **major** API changes.\r\n\r\n### Testing Plan\r\nTests must still be developed\r\n\r\n### Summary\r\nThis PR integrates the haptic manager (PR #751) into the streaming media manager (SMM) and the associated touch manager (TM). The flow now looks like this:\r\n\r\n1. Developer sets `UIWindow` on `SDLStreamingMediaConfiguration`, or not.\r\n2. If set, an `SDLHapticManager` is created on the `SDLStreamingMediaManager`. It is started with sending haptic RPCs disabled.\r\n3. If the video capability comes back with haptics enabled, sending haptic RPCs will be enabled on the haptic manager.\r\n4. The streaming media manager creates an `SDLTouchManager` with the haptic manager if it exists (depending on whether the window was set on the configuration).\r\n5. When the haptic manager is updated, if it is enabled, it will send a haptic RPC.\r\n6. If a touch comes through and the haptic manager exists, it will request a view for the touch location from the haptic manager and return it if it exists.\r\n\r\n### Changelog\r\n##### Breaking Changes\r\n* `SDLTouchManagerDelegate` now has view passthrough on many delegate methods\r\n\r\n##### Enhancements\r\n* Interface tweaks to `SDLHapticHitTester`, now just takes a point instead of a touch\r\n* SMM configuration has a window property that, if set, will create the haptic manager in the SMM\r\n* When the SMM receives video capabilities, it will check the `hapticSpatialDataSupported` property and enable / disable the haptic manager’s sending of RPCs based on it\r\n* TM now takes an optional haptic hit tester dependency to check view locations\r\n\r\n### Tasks Remaining:\r\n- [x] Unit tests\r\n\r\n### CLA\r\n- [x] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)","created_at":"2017-09-28T18:24:02Z","updated_at":"2017-10-02T14:16:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"030a8853b70497262a45c3dce333d4995b868516","assignee":{"login":"joeljfischer","id":1767063,"avatar_url":"https://avatars0.githubusercontent.com/u/1767063?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljfischer","html_url":"https://github.com/joeljfischer","followers_url":"https://api.github.com/users/joeljfischer/followers","following_url":"https://api.github.com/users/joeljfischer/following{/other_user}","gists_url":"https://api.github.com/users/joeljfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljfischer/subscriptions","organizations_url":"https://api.github.com/users/joeljfischer/orgs","repos_url":"https://api.github.com/users/joeljfischer/repos","events_url":"https://api.github.com/users/joeljfischer/events{/privacy}","received_events_url":"https://api.github.com/users/joeljfischer/received_events","type":"User","site_admin":false},"assignees":[{"login":"joeljfischer","id":1767063,"avatar_url":"https://avatars0.githubusercontent.com/u/1767063?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljfischer","html_url":"https://github.com/joeljfischer","followers_url":"https://api.github.com/users/joeljfischer/followers","following_url":"https://api.github.com/users/joeljfischer/following{/other_user}","gists_url":"https://api.github.com/users/joeljfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljfischer/subscriptions","organizations_url":"https://api.github.com/users/joeljfischer/orgs","repos_url":"https://api.github.com/users/joeljfischer/repos","events_url":"https://api.github.com/users/joeljfischer/events{/privacy}","received_events_url":"https://api.github.com/users/joeljfischer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones/4","html_url":"https://github.com/smartdevicelink/sdl_ios/milestone/4","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones/4/labels","id":987072,"number":4,"title":"5.0.0","description":"","creator":{"login":"joeljfischer","id":1767063,"avatar_url":"https://avatars0.githubusercontent.com/u/1767063?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljfischer","html_url":"https://github.com/joeljfischer","followers_url":"https://api.github.com/users/joeljfischer/followers","following_url":"https://api.github.com/users/joeljfischer/following{/other_user}","gists_url":"https://api.github.com/users/joeljfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljfischer/subscriptions","organizations_url":"https://api.github.com/users/joeljfischer/orgs","repos_url":"https://api.github.com/users/joeljfischer/repos","events_url":"https://api.github.com/users/joeljfischer/events{/privacy}","received_events_url":"https://api.github.com/users/joeljfischer/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":115,"state":"open","created_at":"2015-02-19T17:22:23Z","updated_at":"2017-10-02T13:53:53Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/753/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/abb4304cb16dd009b36002f2e5065901474e7cc7","head":{"label":"smartdevicelink:feature/haptic_integration","ref":"feature/haptic_integration","sha":"abb4304cb16dd009b36002f2e5065901474e7cc7","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24940582,"name":"sdl_ios","full_name":"smartdevicelink/sdl_ios","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/deployments","created_at":"2014-10-08T12:57:22Z","updated_at":"2017-09-30T05:10:52Z","pushed_at":"2017-10-02T05:07:21Z","git_url":"git://github.com/smartdevicelink/sdl_ios.git","ssh_url":"git@github.com:smartdevicelink/sdl_ios.git","clone_url":"https://github.com/smartdevicelink/sdl_ios.git","svn_url":"https://github.com/smartdevicelink/sdl_ios","homepage":"www.smartdevicelink.com","size":26897,"stargazers_count":87,"watchers_count":87,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":57,"forks":57,"open_issues":57,"watchers":87,"default_branch":"master"}},"base":{"label":"smartdevicelink:release/5.0.0","ref":"release/5.0.0","sha":"eca3589a66ef012919871865c1c9139e25454891","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24940582,"name":"sdl_ios","full_name":"smartdevicelink/sdl_ios","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/deployments","created_at":"2014-10-08T12:57:22Z","updated_at":"2017-09-30T05:10:52Z","pushed_at":"2017-10-02T05:07:21Z","git_url":"git://github.com/smartdevicelink/sdl_ios.git","ssh_url":"git@github.com:smartdevicelink/sdl_ios.git","clone_url":"https://github.com/smartdevicelink/sdl_ios.git","svn_url":"https://github.com/smartdevicelink/sdl_ios","homepage":"www.smartdevicelink.com","size":26897,"stargazers_count":87,"watchers_count":87,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":57,"forks":57,"open_issues":57,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753"},"html":{"href":"https://github.com/smartdevicelink/sdl_ios/pull/753"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/753"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/753/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/753/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/abb4304cb16dd009b36002f2e5065901474e7cc7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"NicoleYarroch"}}