{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/comments/134259630","pull_request_review_id":57530776,"id":134259630,"diff_hunk":"@@ -205,9 +205,15 @@ def _get(row):\n             elif len(edge_names) > 1:\n                 domain_names = [\"d\" + text_type(edge_index) + \"c\" + text_type(i) for i, _ in enumerate(edge_names)]\n                 query_edge.allowNulls = False\n+                domain_columns = [c for c in self.sf.columns if quote_table(c.es_column) in vals]\n+                if domain_columns and path==domain_columns[0].nested_path[0]:\n+                    domain_table = quote_table(frum)\n+                else:\n+                    domain_table = quote_table(self.sf.fact)\n+","path":"jx_sqlite/aggs_table.py","position":9,"original_position":9,"commit_id":"2f588f242175ccb0c4597d774efa4782cdf61ea8","original_commit_id":"2f588f242175ccb0c4597d774efa4782cdf61ea8","user":{"login":"klahnakoski","id":2334429,"avatar_url":"https://avatars3.githubusercontent.com/u/2334429?v=4","gravatar_id":"","url":"https://api.github.com/users/klahnakoski","html_url":"https://github.com/klahnakoski","followers_url":"https://api.github.com/users/klahnakoski/followers","following_url":"https://api.github.com/users/klahnakoski/following{/other_user}","gists_url":"https://api.github.com/users/klahnakoski/gists{/gist_id}","starred_url":"https://api.github.com/users/klahnakoski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klahnakoski/subscriptions","organizations_url":"https://api.github.com/users/klahnakoski/orgs","repos_url":"https://api.github.com/users/klahnakoski/repos","events_url":"https://api.github.com/users/klahnakoski/events{/privacy}","received_events_url":"https://api.github.com/users/klahnakoski/received_events","type":"User","site_admin":false},"body":"I have not run this yet, but I am lost as to what this is doing.  Specifically, why would `quote_table(self.sf.fact)` ever be preferred over `quote_table(frum)`?  It seems odd to override `frum`. It looks like another special case (and it is duplicated in another hunk below).  If this special case is important (and it is not indicating a problem in some other part of the code), should this be a function?  \r\n\r\nI understand the old code; `quote_table(self.sf.fact)` it was wrong for the sake of simplicity.\r\n","created_at":"2017-08-21T15:19:55Z","updated_at":"2017-08-21T15:19:55Z","html_url":"https://github.com/mozilla/jx-sqlite/pull/71#discussion_r134259630","pull_request_url":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/comments/134259630"},"html":{"href":"https://github.com/mozilla/jx-sqlite/pull/71#discussion_r134259630"},"pull_request":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71","id":136541863,"html_url":"https://github.com/mozilla/jx-sqlite/pull/71","diff_url":"https://github.com/mozilla/jx-sqlite/pull/71.diff","patch_url":"https://github.com/mozilla/jx-sqlite/pull/71.patch","issue_url":"https://api.github.com/repos/mozilla/jx-sqlite/issues/71","number":71,"state":"open","locked":false,"title":"test_aggs_on_parent","user":{"login":"rohit-rk","id":25060395,"avatar_url":"https://avatars2.githubusercontent.com/u/25060395?v=4","gravatar_id":"","url":"https://api.github.com/users/rohit-rk","html_url":"https://github.com/rohit-rk","followers_url":"https://api.github.com/users/rohit-rk/followers","following_url":"https://api.github.com/users/rohit-rk/following{/other_user}","gists_url":"https://api.github.com/users/rohit-rk/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-rk/subscriptions","organizations_url":"https://api.github.com/users/rohit-rk/orgs","repos_url":"https://api.github.com/users/rohit-rk/repos","events_url":"https://api.github.com/users/rohit-rk/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-rk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-18T18:48:15Z","updated_at":"2017-08-21T15:19:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"227d9f89dc94591e6a8b7781825bb58eb795894f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71/commits","review_comments_url":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71/comments","review_comment_url":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/jx-sqlite/issues/71/comments","statuses_url":"https://api.github.com/repos/mozilla/jx-sqlite/statuses/2f588f242175ccb0c4597d774efa4782cdf61ea8","head":{"label":"rohit-rk:deepop","ref":"deepop","sha":"2f588f242175ccb0c4597d774efa4782cdf61ea8","user":{"login":"rohit-rk","id":25060395,"avatar_url":"https://avatars2.githubusercontent.com/u/25060395?v=4","gravatar_id":"","url":"https://api.github.com/users/rohit-rk","html_url":"https://github.com/rohit-rk","followers_url":"https://api.github.com/users/rohit-rk/followers","following_url":"https://api.github.com/users/rohit-rk/following{/other_user}","gists_url":"https://api.github.com/users/rohit-rk/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-rk/subscriptions","organizations_url":"https://api.github.com/users/rohit-rk/orgs","repos_url":"https://api.github.com/users/rohit-rk/repos","events_url":"https://api.github.com/users/rohit-rk/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-rk/received_events","type":"User","site_admin":false},"repo":{"id":83707888,"name":"jx-sqlite","full_name":"rohit-rk/jx-sqlite","owner":{"login":"rohit-rk","id":25060395,"avatar_url":"https://avatars2.githubusercontent.com/u/25060395?v=4","gravatar_id":"","url":"https://api.github.com/users/rohit-rk","html_url":"https://github.com/rohit-rk","followers_url":"https://api.github.com/users/rohit-rk/followers","following_url":"https://api.github.com/users/rohit-rk/following{/other_user}","gists_url":"https://api.github.com/users/rohit-rk/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-rk/subscriptions","organizations_url":"https://api.github.com/users/rohit-rk/orgs","repos_url":"https://api.github.com/users/rohit-rk/repos","events_url":"https://api.github.com/users/rohit-rk/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-rk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohit-rk/jx-sqlite","description":"JSON query expressions using SQLite","fork":true,"url":"https://api.github.com/repos/rohit-rk/jx-sqlite","forks_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/forks","keys_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/teams","hooks_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/hooks","issue_events_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/issues/events{/number}","events_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/events","assignees_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/assignees{/user}","branches_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/branches{/branch}","tags_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/tags","blobs_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/languages","stargazers_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/stargazers","contributors_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/contributors","subscribers_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/subscribers","subscription_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/subscription","commits_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/contents/{+path}","compare_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/merges","archive_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/downloads","issues_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/issues{/number}","pulls_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/labels{/name}","releases_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/releases{/id}","deployments_url":"https://api.github.com/repos/rohit-rk/jx-sqlite/deployments","created_at":"2017-03-02T17:51:34Z","updated_at":"2017-03-02T17:51:37Z","pushed_at":"2017-08-21T12:53:03Z","git_url":"git://github.com/rohit-rk/jx-sqlite.git","ssh_url":"git@github.com:rohit-rk/jx-sqlite.git","clone_url":"https://github.com/rohit-rk/jx-sqlite.git","svn_url":"https://github.com/rohit-rk/jx-sqlite","homepage":null,"size":1832,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"344fcf9060e7c8938200bd88869eea5c1a3b5aa1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":82931327,"name":"jx-sqlite","full_name":"mozilla/jx-sqlite","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/jx-sqlite","description":"JSON query expressions using SQLite","fork":false,"url":"https://api.github.com/repos/mozilla/jx-sqlite","forks_url":"https://api.github.com/repos/mozilla/jx-sqlite/forks","keys_url":"https://api.github.com/repos/mozilla/jx-sqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/jx-sqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/jx-sqlite/teams","hooks_url":"https://api.github.com/repos/mozilla/jx-sqlite/hooks","issue_events_url":"https://api.github.com/repos/mozilla/jx-sqlite/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/jx-sqlite/events","assignees_url":"https://api.github.com/repos/mozilla/jx-sqlite/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/jx-sqlite/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/jx-sqlite/tags","blobs_url":"https://api.github.com/repos/mozilla/jx-sqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/jx-sqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/jx-sqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/jx-sqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/jx-sqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/jx-sqlite/languages","stargazers_url":"https://api.github.com/repos/mozilla/jx-sqlite/stargazers","contributors_url":"https://api.github.com/repos/mozilla/jx-sqlite/contributors","subscribers_url":"https://api.github.com/repos/mozilla/jx-sqlite/subscribers","subscription_url":"https://api.github.com/repos/mozilla/jx-sqlite/subscription","commits_url":"https://api.github.com/repos/mozilla/jx-sqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/jx-sqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/jx-sqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/jx-sqlite/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/jx-sqlite/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/jx-sqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/jx-sqlite/merges","archive_url":"https://api.github.com/repos/mozilla/jx-sqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/jx-sqlite/downloads","issues_url":"https://api.github.com/repos/mozilla/jx-sqlite/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/jx-sqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/jx-sqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/jx-sqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/jx-sqlite/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/jx-sqlite/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/jx-sqlite/deployments","created_at":"2017-02-23T13:46:03Z","updated_at":"2017-08-06T11:18:31Z","pushed_at":"2017-08-21T15:12:45Z","git_url":"git://github.com/mozilla/jx-sqlite.git","ssh_url":"git@github.com:mozilla/jx-sqlite.git","clone_url":"https://github.com/mozilla/jx-sqlite.git","svn_url":"https://github.com/mozilla/jx-sqlite","homepage":null,"size":1820,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71"},"html":{"href":"https://github.com/mozilla/jx-sqlite/pull/71"},"issue":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/issues/71"},"comments":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/jx-sqlite/statuses/2f588f242175ccb0c4597d774efa4782cdf61ea8"}}}}
{"actor":{"display_login":"klahnakoski"}}