{"action":"created","comment":{"url":"https://api.github.com/repos/alimanfoo/petl/pulls/comments/96263421","pull_request_review_id":16840358,"id":96263421,"diff_hunk":"@@ -70,7 +71,7 @@ def __init__(self, source, mappings=None, failonerror=False,\n             self.mappings = OrderedDict()\n         else:\n             self.mappings = mappings\n-        self.failonerror = failonerror\n+        self.failonerror = failonerror or config.failonerror","path":"petl/transform/maps.py","position":13,"original_position":13,"commit_id":"fd05a003996b607b9a156b1d4572abe2ea450b66","original_commit_id":"fd05a003996b607b9a156b1d4572abe2ea450b66","user":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars.githubusercontent.com/u/703554?v=3","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"body":"Same comment as above, need to consider how user can override the config value, regardless of what the config value is.","created_at":"2017-01-16T16:23:39Z","updated_at":"2017-01-16T16:26:10Z","html_url":"https://github.com/alimanfoo/petl/pull/406#discussion_r96263421","pull_request_url":"https://api.github.com/repos/alimanfoo/petl/pulls/406","_links":{"self":{"href":"https://api.github.com/repos/alimanfoo/petl/pulls/comments/96263421"},"html":{"href":"https://github.com/alimanfoo/petl/pull/406#discussion_r96263421"},"pull_request":{"href":"https://api.github.com/repos/alimanfoo/petl/pulls/406"}}},"pull_request":{"url":"https://api.github.com/repos/alimanfoo/petl/pulls/406","id":101571809,"html_url":"https://github.com/alimanfoo/petl/pull/406","diff_url":"https://github.com/alimanfoo/petl/pull/406.diff","patch_url":"https://github.com/alimanfoo/petl/pull/406.patch","issue_url":"https://api.github.com/repos/alimanfoo/petl/issues/406","number":406,"state":"open","locked":false,"title":"Resolves #365 without waiting for 2.0","user":{"login":"bmaggard","id":490050,"avatar_url":"https://avatars.githubusercontent.com/u/490050?v=3","gravatar_id":"","url":"https://api.github.com/users/bmaggard","html_url":"https://github.com/bmaggard","followers_url":"https://api.github.com/users/bmaggard/followers","following_url":"https://api.github.com/users/bmaggard/following{/other_user}","gists_url":"https://api.github.com/users/bmaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/bmaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmaggard/subscriptions","organizations_url":"https://api.github.com/users/bmaggard/orgs","repos_url":"https://api.github.com/users/bmaggard/repos","events_url":"https://api.github.com/users/bmaggard/events{/privacy}","received_events_url":"https://api.github.com/users/bmaggard/received_events","type":"User","site_admin":false},"body":"Resolves #365 without waiting for 2.0","created_at":"2017-01-14T19:34:08Z","updated_at":"2017-01-16T16:26:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f4de2820f2d63d1f80d100d8cba8e218bdd74db","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alimanfoo/petl/pulls/406/commits","review_comments_url":"https://api.github.com/repos/alimanfoo/petl/pulls/406/comments","review_comment_url":"https://api.github.com/repos/alimanfoo/petl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alimanfoo/petl/issues/406/comments","statuses_url":"https://api.github.com/repos/alimanfoo/petl/statuses/fd05a003996b607b9a156b1d4572abe2ea450b66","head":{"label":"HighwindsDWBI:failonerror","ref":"failonerror","sha":"fd05a003996b607b9a156b1d4572abe2ea450b66","user":{"login":"HighwindsDWBI","id":22303911,"avatar_url":"https://avatars.githubusercontent.com/u/22303911?v=3","gravatar_id":"","url":"https://api.github.com/users/HighwindsDWBI","html_url":"https://github.com/HighwindsDWBI","followers_url":"https://api.github.com/users/HighwindsDWBI/followers","following_url":"https://api.github.com/users/HighwindsDWBI/following{/other_user}","gists_url":"https://api.github.com/users/HighwindsDWBI/gists{/gist_id}","starred_url":"https://api.github.com/users/HighwindsDWBI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HighwindsDWBI/subscriptions","organizations_url":"https://api.github.com/users/HighwindsDWBI/orgs","repos_url":"https://api.github.com/users/HighwindsDWBI/repos","events_url":"https://api.github.com/users/HighwindsDWBI/events{/privacy}","received_events_url":"https://api.github.com/users/HighwindsDWBI/received_events","type":"Organization","site_admin":false},"repo":{"id":68668127,"name":"petl","full_name":"HighwindsDWBI/petl","owner":{"login":"HighwindsDWBI","id":22303911,"avatar_url":"https://avatars.githubusercontent.com/u/22303911?v=3","gravatar_id":"","url":"https://api.github.com/users/HighwindsDWBI","html_url":"https://github.com/HighwindsDWBI","followers_url":"https://api.github.com/users/HighwindsDWBI/followers","following_url":"https://api.github.com/users/HighwindsDWBI/following{/other_user}","gists_url":"https://api.github.com/users/HighwindsDWBI/gists{/gist_id}","starred_url":"https://api.github.com/users/HighwindsDWBI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HighwindsDWBI/subscriptions","organizations_url":"https://api.github.com/users/HighwindsDWBI/orgs","repos_url":"https://api.github.com/users/HighwindsDWBI/repos","events_url":"https://api.github.com/users/HighwindsDWBI/events{/privacy}","received_events_url":"https://api.github.com/users/HighwindsDWBI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HighwindsDWBI/petl","description":"Python Extract Transform and Load Tables of Data","fork":true,"url":"https://api.github.com/repos/HighwindsDWBI/petl","forks_url":"https://api.github.com/repos/HighwindsDWBI/petl/forks","keys_url":"https://api.github.com/repos/HighwindsDWBI/petl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HighwindsDWBI/petl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HighwindsDWBI/petl/teams","hooks_url":"https://api.github.com/repos/HighwindsDWBI/petl/hooks","issue_events_url":"https://api.github.com/repos/HighwindsDWBI/petl/issues/events{/number}","events_url":"https://api.github.com/repos/HighwindsDWBI/petl/events","assignees_url":"https://api.github.com/repos/HighwindsDWBI/petl/assignees{/user}","branches_url":"https://api.github.com/repos/HighwindsDWBI/petl/branches{/branch}","tags_url":"https://api.github.com/repos/HighwindsDWBI/petl/tags","blobs_url":"https://api.github.com/repos/HighwindsDWBI/petl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HighwindsDWBI/petl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HighwindsDWBI/petl/git/refs{/sha}","trees_url":"https://api.github.com/repos/HighwindsDWBI/petl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HighwindsDWBI/petl/statuses/{sha}","languages_url":"https://api.github.com/repos/HighwindsDWBI/petl/languages","stargazers_url":"https://api.github.com/repos/HighwindsDWBI/petl/stargazers","contributors_url":"https://api.github.com/repos/HighwindsDWBI/petl/contributors","subscribers_url":"https://api.github.com/repos/HighwindsDWBI/petl/subscribers","subscription_url":"https://api.github.com/repos/HighwindsDWBI/petl/subscription","commits_url":"https://api.github.com/repos/HighwindsDWBI/petl/commits{/sha}","git_commits_url":"https://api.github.com/repos/HighwindsDWBI/petl/git/commits{/sha}","comments_url":"https://api.github.com/repos/HighwindsDWBI/petl/comments{/number}","issue_comment_url":"https://api.github.com/repos/HighwindsDWBI/petl/issues/comments{/number}","contents_url":"https://api.github.com/repos/HighwindsDWBI/petl/contents/{+path}","compare_url":"https://api.github.com/repos/HighwindsDWBI/petl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HighwindsDWBI/petl/merges","archive_url":"https://api.github.com/repos/HighwindsDWBI/petl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HighwindsDWBI/petl/downloads","issues_url":"https://api.github.com/repos/HighwindsDWBI/petl/issues{/number}","pulls_url":"https://api.github.com/repos/HighwindsDWBI/petl/pulls{/number}","milestones_url":"https://api.github.com/repos/HighwindsDWBI/petl/milestones{/number}","notifications_url":"https://api.github.com/repos/HighwindsDWBI/petl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HighwindsDWBI/petl/labels{/name}","releases_url":"https://api.github.com/repos/HighwindsDWBI/petl/releases{/id}","deployments_url":"https://api.github.com/repos/HighwindsDWBI/petl/deployments","created_at":"2016-09-20T02:59:22Z","updated_at":"2016-09-20T02:59:23Z","pushed_at":"2017-01-14T20:01:13Z","git_url":"git://github.com/HighwindsDWBI/petl.git","ssh_url":"git@github.com:HighwindsDWBI/petl.git","clone_url":"https://github.com/HighwindsDWBI/petl.git","svn_url":"https://github.com/HighwindsDWBI/petl","homepage":"","size":3231,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alimanfoo:master","ref":"master","sha":"3928e19d5aa990626b7a92f8ecb3f1af6b6e76c6","user":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars.githubusercontent.com/u/703554?v=3","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"repo":{"id":2233194,"name":"petl","full_name":"alimanfoo/petl","owner":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars.githubusercontent.com/u/703554?v=3","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alimanfoo/petl","description":"Python Extract Transform and Load Tables of Data","fork":false,"url":"https://api.github.com/repos/alimanfoo/petl","forks_url":"https://api.github.com/repos/alimanfoo/petl/forks","keys_url":"https://api.github.com/repos/alimanfoo/petl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alimanfoo/petl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alimanfoo/petl/teams","hooks_url":"https://api.github.com/repos/alimanfoo/petl/hooks","issue_events_url":"https://api.github.com/repos/alimanfoo/petl/issues/events{/number}","events_url":"https://api.github.com/repos/alimanfoo/petl/events","assignees_url":"https://api.github.com/repos/alimanfoo/petl/assignees{/user}","branches_url":"https://api.github.com/repos/alimanfoo/petl/branches{/branch}","tags_url":"https://api.github.com/repos/alimanfoo/petl/tags","blobs_url":"https://api.github.com/repos/alimanfoo/petl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alimanfoo/petl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alimanfoo/petl/git/refs{/sha}","trees_url":"https://api.github.com/repos/alimanfoo/petl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alimanfoo/petl/statuses/{sha}","languages_url":"https://api.github.com/repos/alimanfoo/petl/languages","stargazers_url":"https://api.github.com/repos/alimanfoo/petl/stargazers","contributors_url":"https://api.github.com/repos/alimanfoo/petl/contributors","subscribers_url":"https://api.github.com/repos/alimanfoo/petl/subscribers","subscription_url":"https://api.github.com/repos/alimanfoo/petl/subscription","commits_url":"https://api.github.com/repos/alimanfoo/petl/commits{/sha}","git_commits_url":"https://api.github.com/repos/alimanfoo/petl/git/commits{/sha}","comments_url":"https://api.github.com/repos/alimanfoo/petl/comments{/number}","issue_comment_url":"https://api.github.com/repos/alimanfoo/petl/issues/comments{/number}","contents_url":"https://api.github.com/repos/alimanfoo/petl/contents/{+path}","compare_url":"https://api.github.com/repos/alimanfoo/petl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alimanfoo/petl/merges","archive_url":"https://api.github.com/repos/alimanfoo/petl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alimanfoo/petl/downloads","issues_url":"https://api.github.com/repos/alimanfoo/petl/issues{/number}","pulls_url":"https://api.github.com/repos/alimanfoo/petl/pulls{/number}","milestones_url":"https://api.github.com/repos/alimanfoo/petl/milestones{/number}","notifications_url":"https://api.github.com/repos/alimanfoo/petl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alimanfoo/petl/labels{/name}","releases_url":"https://api.github.com/repos/alimanfoo/petl/releases{/id}","deployments_url":"https://api.github.com/repos/alimanfoo/petl/deployments","created_at":"2011-08-19T09:51:03Z","updated_at":"2017-01-16T05:33:16Z","pushed_at":"2017-01-14T20:01:14Z","git_url":"git://github.com/alimanfoo/petl.git","ssh_url":"git@github.com:alimanfoo/petl.git","clone_url":"https://github.com/alimanfoo/petl.git","svn_url":"https://github.com/alimanfoo/petl","homepage":"","size":3211,"stargazers_count":356,"watchers_count":356,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":49,"forks":80,"open_issues":49,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alimanfoo/petl/pulls/406"},"html":{"href":"https://github.com/alimanfoo/petl/pull/406"},"issue":{"href":"https://api.github.com/repos/alimanfoo/petl/issues/406"},"comments":{"href":"https://api.github.com/repos/alimanfoo/petl/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/alimanfoo/petl/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/alimanfoo/petl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alimanfoo/petl/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/alimanfoo/petl/statuses/fd05a003996b607b9a156b1d4572abe2ea450b66"}}}}
{"actor":{"display_login":"alimanfoo"}}