{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/libgpuarray/pulls/comments/98548971","pull_request_review_id":19194336,"id":98548971,"diff_hunk":"@@ -256,113 +801,492 @@ static int   maxandargmaxCheckargs              (maxandargmax_ctx*  ctx){\n \tctx->nds = ctx->src->nd;\n \tctx->ndr = ctx->reduxLen;\n \tctx->ndd = ctx->nds - ctx->ndr;\n+\tstrb_ensure(&ctx->s, 5*1024);\n+\n \n-\treturn ctx->ret;\n+\n+\treturn reduxSelectModel(ctx);","path":"src/gpuarray_reduction.c","position":933,"original_position":851,"commit_id":"6e3e96c59055977012ba42a68381907da027f0ce","original_commit_id":"d80fc0ea0df7ed34ba1fbaef72fcae29a7634fe9","user":{"login":"abergeron","id":1002504,"avatar_url":"https://avatars.githubusercontent.com/u/1002504?v=3","gravatar_id":"","url":"https://api.github.com/users/abergeron","html_url":"https://github.com/abergeron","followers_url":"https://api.github.com/users/abergeron/followers","following_url":"https://api.github.com/users/abergeron/following{/other_user}","gists_url":"https://api.github.com/users/abergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/abergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergeron/subscriptions","organizations_url":"https://api.github.com/users/abergeron/orgs","repos_url":"https://api.github.com/users/abergeron/repos","events_url":"https://api.github.com/users/abergeron/events{/privacy}","received_events_url":"https://api.github.com/users/abergeron/received_events","type":"User","site_admin":false},"body":"I'm not sure.  Something like `reduxCheckArgsAndRest()`?  I don't like it very much ...","created_at":"2017-01-30T21:47:47Z","updated_at":"2017-01-30T21:47:47Z","html_url":"https://github.com/Theano/libgpuarray/pull/334#discussion_r98548971","pull_request_url":"https://api.github.com/repos/Theano/libgpuarray/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/Theano/libgpuarray/pulls/comments/98548971"},"html":{"href":"https://github.com/Theano/libgpuarray/pull/334#discussion_r98548971"},"pull_request":{"href":"https://api.github.com/repos/Theano/libgpuarray/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/libgpuarray/pulls/334","id":103052873,"html_url":"https://github.com/Theano/libgpuarray/pull/334","diff_url":"https://github.com/Theano/libgpuarray/pull/334.diff","patch_url":"https://github.com/Theano/libgpuarray/pull/334.patch","issue_url":"https://api.github.com/repos/Theano/libgpuarray/issues/334","number":334,"state":"open","locked":false,"title":"Generalize MaxAndArgmax to multiple ops and prepare groundwork for small-destination reductions","user":{"login":"obilaniu","id":3268344,"avatar_url":"https://avatars.githubusercontent.com/u/3268344?v=3","gravatar_id":"","url":"https://api.github.com/users/obilaniu","html_url":"https://github.com/obilaniu","followers_url":"https://api.github.com/users/obilaniu/followers","following_url":"https://api.github.com/users/obilaniu/following{/other_user}","gists_url":"https://api.github.com/users/obilaniu/gists{/gist_id}","starred_url":"https://api.github.com/users/obilaniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilaniu/subscriptions","organizations_url":"https://api.github.com/users/obilaniu/orgs","repos_url":"https://api.github.com/users/obilaniu/repos","events_url":"https://api.github.com/users/obilaniu/events{/privacy}","received_events_url":"https://api.github.com/users/obilaniu/received_events","type":"User","site_admin":false},"body":"Added multiple new reduction ops, enumerated in `enum ga_reduce_op`, and also heavily refactored internally in preparation to add a generator for \"small code model\" kernels, which will be used for reductions with a small destination.\r\n\r\n``` c\r\ntypedef enum _ga_reduce_op {\r\n\tGA_REDUCE_SUM,             /*        +        */\r\n\tGA_REDUCE_PROD,            /*        *        */\r\n\tGA_REDUCE_PRODNZ,          /*        * (!=0)  */\r\n\tGA_REDUCE_MIN,             /*      min()      */\r\n\tGA_REDUCE_MAX,             /*      max()      */\r\n\tGA_REDUCE_ARGMIN,          /*     argmin()    */\r\n\tGA_REDUCE_ARGMAX,          /*     argmax()    */\r\n\tGA_REDUCE_MINANDARGMIN,    /* min(), argmin() */\r\n\tGA_REDUCE_MAXANDARGMAX,    /* max(), argmax() */\r\n\tGA_REDUCE_AND,             /*        &        */\r\n\tGA_REDUCE_OR,              /*        |        */\r\n\tGA_REDUCE_XOR,             /*        ^        */\r\n\tGA_REDUCE_ALL,             /*     &&/all()    */\r\n\tGA_REDUCE_ANY,             /*     ||/any()    */\r\n} ga_reduce_op;\r\n```\r\n\r\n***DO NOT MERGE YET:*** Tests now passing for MaxAndArgmax/MinAndArgmin, but no tests yet for any other op.\r\n","created_at":"2017-01-25T04:19:45Z","updated_at":"2017-01-30T21:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"068b2fa797467ab7c072589017b5829bffdd2c05","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/libgpuarray/pulls/334/commits","review_comments_url":"https://api.github.com/repos/Theano/libgpuarray/pulls/334/comments","review_comment_url":"https://api.github.com/repos/Theano/libgpuarray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/libgpuarray/issues/334/comments","statuses_url":"https://api.github.com/repos/Theano/libgpuarray/statuses/6e3e96c59055977012ba42a68381907da027f0ce","head":{"label":"obilaniu:smallredux","ref":"smallredux","sha":"6e3e96c59055977012ba42a68381907da027f0ce","user":{"login":"obilaniu","id":3268344,"avatar_url":"https://avatars.githubusercontent.com/u/3268344?v=3","gravatar_id":"","url":"https://api.github.com/users/obilaniu","html_url":"https://github.com/obilaniu","followers_url":"https://api.github.com/users/obilaniu/followers","following_url":"https://api.github.com/users/obilaniu/following{/other_user}","gists_url":"https://api.github.com/users/obilaniu/gists{/gist_id}","starred_url":"https://api.github.com/users/obilaniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilaniu/subscriptions","organizations_url":"https://api.github.com/users/obilaniu/orgs","repos_url":"https://api.github.com/users/obilaniu/repos","events_url":"https://api.github.com/users/obilaniu/events{/privacy}","received_events_url":"https://api.github.com/users/obilaniu/received_events","type":"User","site_admin":false},"repo":{"id":60393896,"name":"libgpuarray","full_name":"obilaniu/libgpuarray","owner":{"login":"obilaniu","id":3268344,"avatar_url":"https://avatars.githubusercontent.com/u/3268344?v=3","gravatar_id":"","url":"https://api.github.com/users/obilaniu","html_url":"https://github.com/obilaniu","followers_url":"https://api.github.com/users/obilaniu/followers","following_url":"https://api.github.com/users/obilaniu/following{/other_user}","gists_url":"https://api.github.com/users/obilaniu/gists{/gist_id}","starred_url":"https://api.github.com/users/obilaniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obilaniu/subscriptions","organizations_url":"https://api.github.com/users/obilaniu/orgs","repos_url":"https://api.github.com/users/obilaniu/repos","events_url":"https://api.github.com/users/obilaniu/events{/privacy}","received_events_url":"https://api.github.com/users/obilaniu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obilaniu/libgpuarray","description":"Library to manipulate tensors on the GPU.","fork":true,"url":"https://api.github.com/repos/obilaniu/libgpuarray","forks_url":"https://api.github.com/repos/obilaniu/libgpuarray/forks","keys_url":"https://api.github.com/repos/obilaniu/libgpuarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obilaniu/libgpuarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obilaniu/libgpuarray/teams","hooks_url":"https://api.github.com/repos/obilaniu/libgpuarray/hooks","issue_events_url":"https://api.github.com/repos/obilaniu/libgpuarray/issues/events{/number}","events_url":"https://api.github.com/repos/obilaniu/libgpuarray/events","assignees_url":"https://api.github.com/repos/obilaniu/libgpuarray/assignees{/user}","branches_url":"https://api.github.com/repos/obilaniu/libgpuarray/branches{/branch}","tags_url":"https://api.github.com/repos/obilaniu/libgpuarray/tags","blobs_url":"https://api.github.com/repos/obilaniu/libgpuarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obilaniu/libgpuarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obilaniu/libgpuarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/obilaniu/libgpuarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obilaniu/libgpuarray/statuses/{sha}","languages_url":"https://api.github.com/repos/obilaniu/libgpuarray/languages","stargazers_url":"https://api.github.com/repos/obilaniu/libgpuarray/stargazers","contributors_url":"https://api.github.com/repos/obilaniu/libgpuarray/contributors","subscribers_url":"https://api.github.com/repos/obilaniu/libgpuarray/subscribers","subscription_url":"https://api.github.com/repos/obilaniu/libgpuarray/subscription","commits_url":"https://api.github.com/repos/obilaniu/libgpuarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/obilaniu/libgpuarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/obilaniu/libgpuarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/obilaniu/libgpuarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/obilaniu/libgpuarray/contents/{+path}","compare_url":"https://api.github.com/repos/obilaniu/libgpuarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obilaniu/libgpuarray/merges","archive_url":"https://api.github.com/repos/obilaniu/libgpuarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obilaniu/libgpuarray/downloads","issues_url":"https://api.github.com/repos/obilaniu/libgpuarray/issues{/number}","pulls_url":"https://api.github.com/repos/obilaniu/libgpuarray/pulls{/number}","milestones_url":"https://api.github.com/repos/obilaniu/libgpuarray/milestones{/number}","notifications_url":"https://api.github.com/repos/obilaniu/libgpuarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obilaniu/libgpuarray/labels{/name}","releases_url":"https://api.github.com/repos/obilaniu/libgpuarray/releases{/id}","deployments_url":"https://api.github.com/repos/obilaniu/libgpuarray/deployments","created_at":"2016-06-04T04:54:54Z","updated_at":"2016-06-04T04:54:55Z","pushed_at":"2017-01-26T01:30:45Z","git_url":"git://github.com/obilaniu/libgpuarray.git","ssh_url":"git@github.com:obilaniu/libgpuarray.git","clone_url":"https://github.com/obilaniu/libgpuarray.git","svn_url":"https://github.com/obilaniu/libgpuarray","homepage":null,"size":2249,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"d838f6a43bcc56fb280a8b40fdbc03276b3eb7fd","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":19312996,"name":"libgpuarray","full_name":"Theano/libgpuarray","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/libgpuarray","description":"Library to manipulate tensors on the GPU.","fork":false,"url":"https://api.github.com/repos/Theano/libgpuarray","forks_url":"https://api.github.com/repos/Theano/libgpuarray/forks","keys_url":"https://api.github.com/repos/Theano/libgpuarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/libgpuarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/libgpuarray/teams","hooks_url":"https://api.github.com/repos/Theano/libgpuarray/hooks","issue_events_url":"https://api.github.com/repos/Theano/libgpuarray/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/libgpuarray/events","assignees_url":"https://api.github.com/repos/Theano/libgpuarray/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/libgpuarray/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/libgpuarray/tags","blobs_url":"https://api.github.com/repos/Theano/libgpuarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/libgpuarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/libgpuarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/libgpuarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/libgpuarray/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/libgpuarray/languages","stargazers_url":"https://api.github.com/repos/Theano/libgpuarray/stargazers","contributors_url":"https://api.github.com/repos/Theano/libgpuarray/contributors","subscribers_url":"https://api.github.com/repos/Theano/libgpuarray/subscribers","subscription_url":"https://api.github.com/repos/Theano/libgpuarray/subscription","commits_url":"https://api.github.com/repos/Theano/libgpuarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/libgpuarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/libgpuarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/libgpuarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/libgpuarray/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/libgpuarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/libgpuarray/merges","archive_url":"https://api.github.com/repos/Theano/libgpuarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/libgpuarray/downloads","issues_url":"https://api.github.com/repos/Theano/libgpuarray/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/libgpuarray/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/libgpuarray/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/libgpuarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/libgpuarray/labels{/name}","releases_url":"https://api.github.com/repos/Theano/libgpuarray/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/libgpuarray/deployments","created_at":"2014-04-30T12:33:14Z","updated_at":"2017-01-28T14:58:09Z","pushed_at":"2017-01-30T19:24:25Z","git_url":"git://github.com/Theano/libgpuarray.git","ssh_url":"git@github.com:Theano/libgpuarray.git","clone_url":"https://github.com/Theano/libgpuarray.git","svn_url":"https://github.com/Theano/libgpuarray","homepage":null,"size":2219,"stargazers_count":93,"watchers_count":93,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":55,"forks":57,"open_issues":55,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/libgpuarray/pulls/334"},"html":{"href":"https://github.com/Theano/libgpuarray/pull/334"},"issue":{"href":"https://api.github.com/repos/Theano/libgpuarray/issues/334"},"comments":{"href":"https://api.github.com/repos/Theano/libgpuarray/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/libgpuarray/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/libgpuarray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/libgpuarray/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/libgpuarray/statuses/6e3e96c59055977012ba42a68381907da027f0ce"}}}}
{"actor":{"display_login":"abergeron"}}