{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/17794","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17794/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17794/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17794/events","html_url":"https://github.com/cms-sw/cmssw/pull/17794","id":212136353,"number":17794,"title":"ECAL offline selective readout","user":{"login":"emanueledimarco","id":4517974,"avatar_url":"https://avatars3.githubusercontent.com/u/4517974?v=3","gravatar_id":"","url":"https://api.github.com/users/emanueledimarco","html_url":"https://github.com/emanueledimarco","followers_url":"https://api.github.com/users/emanueledimarco/followers","following_url":"https://api.github.com/users/emanueledimarco/following{/other_user}","gists_url":"https://api.github.com/users/emanueledimarco/gists{/gist_id}","starred_url":"https://api.github.com/users/emanueledimarco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanueledimarco/subscriptions","organizations_url":"https://api.github.com/users/emanueledimarco/orgs","repos_url":"https://api.github.com/users/emanueledimarco/repos","events_url":"https://api.github.com/users/emanueledimarco/events{/privacy}","received_events_url":"https://api.github.com/users/emanueledimarco/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52822551,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65","html_url":"https://github.com/cms-sw/cmssw/milestone/65","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65/labels","id":2358370,"number":65,"title":"Next CMSSW_9_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":158,"state":"open","created_at":"2017-03-02T09:15:47Z","updated_at":"2017-03-21T13:36:16Z","due_on":null,"closed_at":null},"comments":49,"created_at":"2017-03-06T14:22:29Z","updated_at":"2017-03-21T14:08:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/17794","html_url":"https://github.com/cms-sw/cmssw/pull/17794","diff_url":"https://github.com/cms-sw/cmssw/pull/17794.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/17794.patch"},"body":"This change is to implement a match of the online selective readout algorithm, basically:\r\n\r\n- when the hit belongs to a region which the trigger flagged as \"high-interest\"(\"medium interest\"), read in full-readout a set of (one) readout units\r\n- when the hit belongs to a \"low-interest region\", apply the zero-suppression\r\n\r\nRight now the offline ZS was done in two places:\r\n\r\n1. ECAL -> PF rechit translation (including offline zero-suppression)\r\n2. gathering threholds of hits in a PFCluster\r\n\r\nin 2016 thresholds in 1. and 2. coincided and were lower than online zero-suppression. Since online ZS is on uncalibrated amplitude, this possibly produced time- and eta-dependent effects (radiation / transparency loss). In 2017 the online ZS will be much harder, so worsening these effects. \r\n\r\nThis allows to decouple what happens in a high-interest region (online = full-readout ; offline = stay with low cluster gathering thresholds) to what happens in low-interest region (online = zs ; offline = raise the ZS in PFRecHit QTest to a value higher than online, but done on calibrated energy).\r\n\r\nFew details more in this [presentation at the ECAL DPG](https://indico.cern.ch/event/600314/contributions/2423735/).\r\n\r\nWith this PR, which puts in the algorithm of the match of online-offline decisions, but NOT changes thresholds neither in 1. nor in 2., should just abuse of the technical checks of the release integration, and should not introduce changes. Also something to check is the increase in the memory of the job at the beginning of the job, since it creates the mapping between crystals and trigger towers.\r\n\r\nThe second change will be just a change in the thresholds in 2., matching the ones decided for the online running in 2017.\r\n\r\nThis PR is the equivalent in 91X of #17776 in 90X, but also includes the changes suggested there by @slava77 . I will close then the one in 90X.\r\n\r\n@bendavid @amassiro @shervin86 @argiro @crovelli @fcouderc @paramatti @gzevi  please also follow this"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/288089100","html_url":"https://github.com/cms-sw/cmssw/pull/17794#issuecomment-288089100","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17794","id":288089100,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars1.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2017-03-21T14:08:12Z","updated_at":"2017-03-21T14:08:12Z","body":"@cmsbuild please test\r\n"}}
{"actor":{"display_login":"slava77"}}