{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/1734","repository_url":"https://api.github.com/repos/facebook/rocksdb","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/1734/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/1734/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/1734/events","html_url":"https://github.com/facebook/rocksdb/pull/1734","id":198053613,"number":1734,"title":"Enable fifo compaction benchmark to db_bench","user":{"login":"shuzhang1989","id":15947888,"avatar_url":"https://avatars2.githubusercontent.com/u/15947888?v=3","gravatar_id":"","url":"https://api.github.com/users/shuzhang1989","html_url":"https://github.com/shuzhang1989","followers_url":"https://api.github.com/users/shuzhang1989/followers","following_url":"https://api.github.com/users/shuzhang1989/following{/other_user}","gists_url":"https://api.github.com/users/shuzhang1989/gists{/gist_id}","starred_url":"https://api.github.com/users/shuzhang1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuzhang1989/subscriptions","organizations_url":"https://api.github.com/users/shuzhang1989/orgs","repos_url":"https://api.github.com/users/shuzhang1989/repos","events_url":"https://api.github.com/users/shuzhang1989/events{/privacy}","received_events_url":"https://api.github.com/users/shuzhang1989/received_events","type":"User","site_admin":false},"labels":[{"id":196859108,"url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-29T19:04:49Z","updated_at":"2017-03-24T18:15:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/1734","html_url":"https://github.com/facebook/rocksdb/pull/1734","diff_url":"https://github.com/facebook/rocksdb/pull/1734.diff","patch_url":"https://github.com/facebook/rocksdb/pull/1734.patch"},"body":"Added fifo benchmark to db_bench.\r\nOne thing i am not sure is that i am using CompactRange() instead of CompactFiles(). (may cause performance skew because CompactionRange() is not happening in current thread?)  For CompactFiles(), for some reason FIFO compaction doesn't work as expected. More insight is welcomed. I guess FIFO compaction doesn't work with file names? @igorcanadi \r\n\r\ntest cmd:\r\n./db_bench --compaction_style=2 --benchmarks=fillseqdeterministic --disable_auto_compactions --num_levels=1 --fifo_compaction_max_table_files_size_mb=10\r\n\r\n---------------------- DB 0 LSM --------------------- \r\nLevel[0]: /000014.sst(size: 4211014 bytes)\r\nfillseqdeterministic :       4.731 micros/op 211381 ops/sec;   23.4 MB/s\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/289104029","html_url":"https://github.com/facebook/rocksdb/pull/1734#issuecomment-289104029","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/1734","id":289104029,"user":{"login":"shuzhang1989","id":15947888,"avatar_url":"https://avatars2.githubusercontent.com/u/15947888?v=3","gravatar_id":"","url":"https://api.github.com/users/shuzhang1989","html_url":"https://github.com/shuzhang1989","followers_url":"https://api.github.com/users/shuzhang1989/followers","following_url":"https://api.github.com/users/shuzhang1989/following{/other_user}","gists_url":"https://api.github.com/users/shuzhang1989/gists{/gist_id}","starred_url":"https://api.github.com/users/shuzhang1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuzhang1989/subscriptions","organizations_url":"https://api.github.com/users/shuzhang1989/orgs","repos_url":"https://api.github.com/users/shuzhang1989/repos","events_url":"https://api.github.com/users/shuzhang1989/events{/privacy}","received_events_url":"https://api.github.com/users/shuzhang1989/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T18:15:11Z","updated_at":"2017-03-24T18:15:11Z","body":"ping for review :)"}}
{"actor":{"display_login":"shuzhang1989"}}