{"action":"created","comment":{"url":"https://api.github.com/repos/rucio/rucio/pulls/comments/149986461","pull_request_review_id":75467474,"id":149986461,"diff_hunk":"@@ -0,0 +1,76 @@\n+Contributor Guide\n+=================\n+\n+* Thank you for participating!\n+* A contribution(pull request) requires to have one `issue <https://github.com/rucio/rucio/issues/new>`_ created.\n+* The issue should contain the motivation, modification and expected results (discussions usually happen there).\n+* No pull request will be merged without an associated issue (release notes are generated from issues).\n+* You should make sure to add your name (and the organisation) to `AUTHORS`_.\n+\n+A contribution can be either be an **patch**, **feature**, or **hotfix**:\n+ * **Patch** include bugfixes and minor changes to the code and goes in Patch releases (usually made on a bi-weekly schedule).\n+ * **Feature** include major developments or potentially disruptive changes and goes in Feature release (made multiple times a year).\n+ * **Hotfix** are specific patch happening due to the necessity of important fixes and goes in postfix release (made when needed).\n+\n+Accordingly, the `repository <https://github.com/rucio/rucio/>`_  consists of three different branches:\n+ * the **master** branch includes the patch/minor development of the current major version.\n+ * the **next** branch includes the development for the next major version.\n+ * the **hotfix** branch includes the patch for postfix releases.\n+\n+Thus, on release day of a feature release both master and next are the same,\n+afterwards they diverge until the next feature release.\n+Pull requests for **features** are only made against the **next** branch.\n+Pull requests for **patches** are made against the **next** and **master** branch.\n+Simultaneously, as these bugfixes need to be represented in both branches. Thus two\n+pull requests are needed for patches, and the helper scripts do it\n+automatically for you.\n+\n+Setting up the repository\n+=========================\n+\n+**Step 1**: Fork the `repository <https://github.com/rucio/rucio/>`_ on Github\n+\n+**Step 2**: Clone the repository to your development machine and configure it::\n+\n+  $ git clone https://github.com/<YOUR_USER>/rucio/\n+  $ git remote add YOUR_USER https://github.com/YOUR_USER/rucio.git\n+  $ git remote add upstream https://github.com/rucio/rucio.git\n+  $ git branch --track next\n+\n+We can either establishing a virtualenv_. to run rucio within. A docker image is also\n+doable (cf. developing notes)\n+\n+.. _virtualenv: http://www.virtualenv.org/\n+\n+\n+Contributing\n+============\n+\n+**Step 1**: Create an `issue <https://github.com/rucio/rucio/issues/new>`_ with the description\n+of the contribution (motivation, modification and expected results) with the\n+label **Patch**, **Feature** or **Hotfix** and a milestone. Every issue will\n+get a **unique issue number**.\n+\n+**Step 2**: Create a local branch that corresponds to the issue. There are utility scripts to help you with this::\n+\n+  $ ./tools/create-patch-branch <unique issue number> '<component> #<issue number>: <short_change_message>'\n+  $ ./tools/create-feature-branch <unique issue number> '<component> #<issue number>: <short_change_message>'\n+\n+**Step 3**: Commit your change. The format of the commit message must be::\n+\n+<component>: <change_message> Fix #<issue number>\n+\n+Valid component names are listed in the `label list <https://github.com/rucio/rucio/labels>`_\n+\n+**Step 4**: Push the commit to your forked repository and create the pull request(s). There is a helper script to assist you::\n+\n+  $ ./tools/submit-pull-request\n+\n+**Step 5**: Watch the pull request for comments\n+","path":"CONTRIBUTING.rst","position":null,"original_position":70,"commit_id":"35702dbd48802539add3a626a5d49648d234c5dc","original_commit_id":"b000d442853272b5c9ae178e48facc06cca43d0b","user":{"login":"vingar","id":9110689,"avatar_url":"https://avatars1.githubusercontent.com/u/9110689?v=4","gravatar_id":"","url":"https://api.github.com/users/vingar","html_url":"https://github.com/vingar","followers_url":"https://api.github.com/users/vingar/followers","following_url":"https://api.github.com/users/vingar/following{/other_user}","gists_url":"https://api.github.com/users/vingar/gists{/gist_id}","starred_url":"https://api.github.com/users/vingar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vingar/subscriptions","organizations_url":"https://api.github.com/users/vingar/orgs","repos_url":"https://api.github.com/users/vingar/repos","events_url":"https://api.github.com/users/vingar/events{/privacy}","received_events_url":"https://api.github.com/users/vingar/received_events","type":"User","site_admin":false},"body":"more something among the collaborators/rucio core dev. It's not for the contributors guides (short and concise). This can go in the dev. section of the docs (imo)","created_at":"2017-11-09T15:05:03Z","updated_at":"2017-11-09T15:05:03Z","html_url":"https://github.com/rucio/rucio/pull/20#discussion_r149986461","pull_request_url":"https://api.github.com/repos/rucio/rucio/pulls/20","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rucio/rucio/pulls/comments/149986461"},"html":{"href":"https://github.com/rucio/rucio/pull/20#discussion_r149986461"},"pull_request":{"href":"https://api.github.com/repos/rucio/rucio/pulls/20"}},"in_reply_to_id":149978439},"pull_request":{"url":"https://api.github.com/repos/rucio/rucio/pulls/20","id":151156895,"html_url":"https://github.com/rucio/rucio/pull/20","diff_url":"https://github.com/rucio/rucio/pull/20.diff","patch_url":"https://github.com/rucio/rucio/pull/20.patch","issue_url":"https://api.github.com/repos/rucio/rucio/issues/20","number":20,"state":"open","locked":false,"title":"documentation: Added CONTRIBUTING notes Fix #85","user":{"login":"vingar","id":9110689,"avatar_url":"https://avatars1.githubusercontent.com/u/9110689?v=4","gravatar_id":"","url":"https://api.github.com/users/vingar","html_url":"https://github.com/vingar","followers_url":"https://api.github.com/users/vingar/followers","following_url":"https://api.github.com/users/vingar/following{/other_user}","gists_url":"https://api.github.com/users/vingar/gists{/gist_id}","starred_url":"https://api.github.com/users/vingar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vingar/subscriptions","organizations_url":"https://api.github.com/users/vingar/orgs","repos_url":"https://api.github.com/users/vingar/repos","events_url":"https://api.github.com/users/vingar/events{/privacy}","received_events_url":"https://api.github.com/users/vingar/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-11-07T16:09:06Z","updated_at":"2017-11-09T15:05:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27ef279087c49c27a20d5c758dbcbd5a48cc3c98","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rucio/rucio/pulls/20/commits","review_comments_url":"https://api.github.com/repos/rucio/rucio/pulls/20/comments","review_comment_url":"https://api.github.com/repos/rucio/rucio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rucio/rucio/issues/20/comments","statuses_url":"https://api.github.com/repos/rucio/rucio/statuses/35702dbd48802539add3a626a5d49648d234c5dc","head":{"label":"vingar:patch-2859-Added_CONTRIBUTING_notes","ref":"patch-2859-Added_CONTRIBUTING_notes","sha":"35702dbd48802539add3a626a5d49648d234c5dc","user":{"login":"vingar","id":9110689,"avatar_url":"https://avatars1.githubusercontent.com/u/9110689?v=4","gravatar_id":"","url":"https://api.github.com/users/vingar","html_url":"https://github.com/vingar","followers_url":"https://api.github.com/users/vingar/followers","following_url":"https://api.github.com/users/vingar/following{/other_user}","gists_url":"https://api.github.com/users/vingar/gists{/gist_id}","starred_url":"https://api.github.com/users/vingar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vingar/subscriptions","organizations_url":"https://api.github.com/users/vingar/orgs","repos_url":"https://api.github.com/users/vingar/repos","events_url":"https://api.github.com/users/vingar/events{/privacy}","received_events_url":"https://api.github.com/users/vingar/received_events","type":"User","site_admin":false},"repo":{"id":109830151,"name":"rucio","full_name":"vingar/rucio","owner":{"login":"vingar","id":9110689,"avatar_url":"https://avatars1.githubusercontent.com/u/9110689?v=4","gravatar_id":"","url":"https://api.github.com/users/vingar","html_url":"https://github.com/vingar","followers_url":"https://api.github.com/users/vingar/followers","following_url":"https://api.github.com/users/vingar/following{/other_user}","gists_url":"https://api.github.com/users/vingar/gists{/gist_id}","starred_url":"https://api.github.com/users/vingar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vingar/subscriptions","organizations_url":"https://api.github.com/users/vingar/orgs","repos_url":"https://api.github.com/users/vingar/repos","events_url":"https://api.github.com/users/vingar/events{/privacy}","received_events_url":"https://api.github.com/users/vingar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vingar/rucio","description":"Rucio - Scientific Data Management","fork":true,"url":"https://api.github.com/repos/vingar/rucio","forks_url":"https://api.github.com/repos/vingar/rucio/forks","keys_url":"https://api.github.com/repos/vingar/rucio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vingar/rucio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vingar/rucio/teams","hooks_url":"https://api.github.com/repos/vingar/rucio/hooks","issue_events_url":"https://api.github.com/repos/vingar/rucio/issues/events{/number}","events_url":"https://api.github.com/repos/vingar/rucio/events","assignees_url":"https://api.github.com/repos/vingar/rucio/assignees{/user}","branches_url":"https://api.github.com/repos/vingar/rucio/branches{/branch}","tags_url":"https://api.github.com/repos/vingar/rucio/tags","blobs_url":"https://api.github.com/repos/vingar/rucio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vingar/rucio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vingar/rucio/git/refs{/sha}","trees_url":"https://api.github.com/repos/vingar/rucio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vingar/rucio/statuses/{sha}","languages_url":"https://api.github.com/repos/vingar/rucio/languages","stargazers_url":"https://api.github.com/repos/vingar/rucio/stargazers","contributors_url":"https://api.github.com/repos/vingar/rucio/contributors","subscribers_url":"https://api.github.com/repos/vingar/rucio/subscribers","subscription_url":"https://api.github.com/repos/vingar/rucio/subscription","commits_url":"https://api.github.com/repos/vingar/rucio/commits{/sha}","git_commits_url":"https://api.github.com/repos/vingar/rucio/git/commits{/sha}","comments_url":"https://api.github.com/repos/vingar/rucio/comments{/number}","issue_comment_url":"https://api.github.com/repos/vingar/rucio/issues/comments{/number}","contents_url":"https://api.github.com/repos/vingar/rucio/contents/{+path}","compare_url":"https://api.github.com/repos/vingar/rucio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vingar/rucio/merges","archive_url":"https://api.github.com/repos/vingar/rucio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vingar/rucio/downloads","issues_url":"https://api.github.com/repos/vingar/rucio/issues{/number}","pulls_url":"https://api.github.com/repos/vingar/rucio/pulls{/number}","milestones_url":"https://api.github.com/repos/vingar/rucio/milestones{/number}","notifications_url":"https://api.github.com/repos/vingar/rucio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vingar/rucio/labels{/name}","releases_url":"https://api.github.com/repos/vingar/rucio/releases{/id}","deployments_url":"https://api.github.com/repos/vingar/rucio/deployments","created_at":"2017-11-07T12:03:06Z","updated_at":"2017-11-07T12:03:09Z","pushed_at":"2017-11-09T15:01:41Z","git_url":"git://github.com/vingar/rucio.git","ssh_url":"git@github.com:vingar/rucio.git","clone_url":"https://github.com/vingar/rucio.git","svn_url":"https://github.com/vingar/rucio","homepage":"http://rucio.cern.ch/","size":15828,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rucio:next","ref":"next","sha":"4f9f9d85d57a5c3aa619c407b78a2821389b1a57","user":{"login":"rucio","id":32394753,"avatar_url":"https://avatars2.githubusercontent.com/u/32394753?v=4","gravatar_id":"","url":"https://api.github.com/users/rucio","html_url":"https://github.com/rucio","followers_url":"https://api.github.com/users/rucio/followers","following_url":"https://api.github.com/users/rucio/following{/other_user}","gists_url":"https://api.github.com/users/rucio/gists{/gist_id}","starred_url":"https://api.github.com/users/rucio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rucio/subscriptions","organizations_url":"https://api.github.com/users/rucio/orgs","repos_url":"https://api.github.com/users/rucio/repos","events_url":"https://api.github.com/users/rucio/events{/privacy}","received_events_url":"https://api.github.com/users/rucio/received_events","type":"User","site_admin":false},"repo":{"id":109819364,"name":"rucio","full_name":"rucio/rucio","owner":{"login":"rucio","id":32394753,"avatar_url":"https://avatars2.githubusercontent.com/u/32394753?v=4","gravatar_id":"","url":"https://api.github.com/users/rucio","html_url":"https://github.com/rucio","followers_url":"https://api.github.com/users/rucio/followers","following_url":"https://api.github.com/users/rucio/following{/other_user}","gists_url":"https://api.github.com/users/rucio/gists{/gist_id}","starred_url":"https://api.github.com/users/rucio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rucio/subscriptions","organizations_url":"https://api.github.com/users/rucio/orgs","repos_url":"https://api.github.com/users/rucio/repos","events_url":"https://api.github.com/users/rucio/events{/privacy}","received_events_url":"https://api.github.com/users/rucio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rucio/rucio","description":"Rucio - Scientific Data Management","fork":false,"url":"https://api.github.com/repos/rucio/rucio","forks_url":"https://api.github.com/repos/rucio/rucio/forks","keys_url":"https://api.github.com/repos/rucio/rucio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rucio/rucio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rucio/rucio/teams","hooks_url":"https://api.github.com/repos/rucio/rucio/hooks","issue_events_url":"https://api.github.com/repos/rucio/rucio/issues/events{/number}","events_url":"https://api.github.com/repos/rucio/rucio/events","assignees_url":"https://api.github.com/repos/rucio/rucio/assignees{/user}","branches_url":"https://api.github.com/repos/rucio/rucio/branches{/branch}","tags_url":"https://api.github.com/repos/rucio/rucio/tags","blobs_url":"https://api.github.com/repos/rucio/rucio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rucio/rucio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rucio/rucio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rucio/rucio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rucio/rucio/statuses/{sha}","languages_url":"https://api.github.com/repos/rucio/rucio/languages","stargazers_url":"https://api.github.com/repos/rucio/rucio/stargazers","contributors_url":"https://api.github.com/repos/rucio/rucio/contributors","subscribers_url":"https://api.github.com/repos/rucio/rucio/subscribers","subscription_url":"https://api.github.com/repos/rucio/rucio/subscription","commits_url":"https://api.github.com/repos/rucio/rucio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rucio/rucio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rucio/rucio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rucio/rucio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rucio/rucio/contents/{+path}","compare_url":"https://api.github.com/repos/rucio/rucio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rucio/rucio/merges","archive_url":"https://api.github.com/repos/rucio/rucio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rucio/rucio/downloads","issues_url":"https://api.github.com/repos/rucio/rucio/issues{/number}","pulls_url":"https://api.github.com/repos/rucio/rucio/pulls{/number}","milestones_url":"https://api.github.com/repos/rucio/rucio/milestones{/number}","notifications_url":"https://api.github.com/repos/rucio/rucio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rucio/rucio/labels{/name}","releases_url":"https://api.github.com/repos/rucio/rucio/releases{/id}","deployments_url":"https://api.github.com/repos/rucio/rucio/deployments","created_at":"2017-11-07T10:15:12Z","updated_at":"2017-11-09T12:59:39Z","pushed_at":"2017-11-09T15:01:42Z","git_url":"git://github.com/rucio/rucio.git","ssh_url":"git@github.com:rucio/rucio.git","clone_url":"https://github.com/rucio/rucio.git","svn_url":"https://github.com/rucio/rucio","homepage":"http://rucio.cern.ch","size":41939,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":69,"forks":8,"open_issues":69,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rucio/rucio/pulls/20"},"html":{"href":"https://github.com/rucio/rucio/pull/20"},"issue":{"href":"https://api.github.com/repos/rucio/rucio/issues/20"},"comments":{"href":"https://api.github.com/repos/rucio/rucio/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/rucio/rucio/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/rucio/rucio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rucio/rucio/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/rucio/rucio/statuses/35702dbd48802539add3a626a5d49648d234c5dc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vingar"}}