{"action":"closed","number":204,"pull_request":{"url":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/204","id":150719076,"html_url":"https://github.com/fphilipe/premailer-rails/pull/204","diff_url":"https://github.com/fphilipe/premailer-rails/pull/204.diff","patch_url":"https://github.com/fphilipe/premailer-rails/pull/204.patch","issue_url":"https://api.github.com/repos/fphilipe/premailer-rails/issues/204","number":204,"state":"closed","locked":false,"title":"Fix failing test (sort content types)","user":{"login":"kirs","id":522155,"avatar_url":"https://avatars3.githubusercontent.com/u/522155?v=4","gravatar_id":"","url":"https://api.github.com/users/kirs","html_url":"https://github.com/kirs","followers_url":"https://api.github.com/users/kirs/followers","following_url":"https://api.github.com/users/kirs/following{/other_user}","gists_url":"https://api.github.com/users/kirs/gists{/gist_id}","starred_url":"https://api.github.com/users/kirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirs/subscriptions","organizations_url":"https://api.github.com/users/kirs/orgs","repos_url":"https://api.github.com/users/kirs/repos","events_url":"https://api.github.com/users/kirs/events{/privacy}","received_events_url":"https://api.github.com/users/kirs/received_events","type":"User","site_admin":false},"body":"There is a test that started failing on master:\r\n\r\n```\r\n$ premailer-rails (master|…) $ env ACTION_MAILER_VERSION=4 bundle exec rspec spec/integration/hook_spec.rb:95\r\nRun options: include {:locations=>{\"./spec/integration/hook_spec.rb\"=>[95]}}\r\n\r\nPremailer::Rails::Hook\r\n  when message also contains a text part\r\n    does not replace any message part (FAILED - 1)\r\n\r\nFailures:\r\n\r\n  1) Premailer::Rails::Hook when message also contains a text part does not replace any message part\r\n     Failure/Error:\r\n       expect { run_hook(message) }.to_not \\\r\n         change { message.all_parts.map(&:content_type) }\r\n\r\n       expected `message.all_parts.map(&:content_type)` not to have changed, but did change from [\"multipart/alternative; boundary=\\\"--==_mimepart_59fefc1f62087_b113fe7bb43f93096866\\\"; charset=UTF-8\", \"text/html; charset=UTF-8\", \"text/plain; charset=UTF-8\"] to [\"multipart/alternative; boundary=\\\"--==_mimepart_59fefc1f62087_b113fe7bb43f93096866\\\"; charset=UTF-8\", \"text/plain; charset=UTF-8\", \"text/html; charset=UTF-8\"]\r\n     # ./spec/integration/hook_spec.rb:93:in `block (3 levels) in <top (required)>'\r\n\r\nFinished in 0.25537 seconds (files took 0.55858 seconds to load)\r\n1 example, 1 failure\r\n\r\nFailed examples:\r\n\r\nrspec ./spec/integration/hook_spec.rb:92 # Premailer::Rails::Hook when message also contains a text part does not replace any message part\r\n```\r\n\r\nThis PR tries to fix that test by sorting content types before comparing them.","created_at":"2017-11-05T11:56:34Z","updated_at":"2017-11-09T05:49:23Z","closed_at":"2017-11-09T05:49:23Z","merged_at":"2017-11-09T05:49:23Z","merge_commit_sha":"229e65d98999e3947e20d3cf37bfb62f67793a1f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/204/commits","review_comments_url":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/204/comments","review_comment_url":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fphilipe/premailer-rails/issues/204/comments","statuses_url":"https://api.github.com/repos/fphilipe/premailer-rails/statuses/229e65d98999e3947e20d3cf37bfb62f67793a1f","head":{"label":"kirs:fix-failing-test","ref":"fix-failing-test","sha":"229e65d98999e3947e20d3cf37bfb62f67793a1f","user":{"login":"kirs","id":522155,"avatar_url":"https://avatars3.githubusercontent.com/u/522155?v=4","gravatar_id":"","url":"https://api.github.com/users/kirs","html_url":"https://github.com/kirs","followers_url":"https://api.github.com/users/kirs/followers","following_url":"https://api.github.com/users/kirs/following{/other_user}","gists_url":"https://api.github.com/users/kirs/gists{/gist_id}","starred_url":"https://api.github.com/users/kirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirs/subscriptions","organizations_url":"https://api.github.com/users/kirs/orgs","repos_url":"https://api.github.com/users/kirs/repos","events_url":"https://api.github.com/users/kirs/events{/privacy}","received_events_url":"https://api.github.com/users/kirs/received_events","type":"User","site_admin":false},"repo":{"id":107855228,"name":"premailer-rails","full_name":"kirs/premailer-rails","owner":{"login":"kirs","id":522155,"avatar_url":"https://avatars3.githubusercontent.com/u/522155?v=4","gravatar_id":"","url":"https://api.github.com/users/kirs","html_url":"https://github.com/kirs","followers_url":"https://api.github.com/users/kirs/followers","following_url":"https://api.github.com/users/kirs/following{/other_user}","gists_url":"https://api.github.com/users/kirs/gists{/gist_id}","starred_url":"https://api.github.com/users/kirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirs/subscriptions","organizations_url":"https://api.github.com/users/kirs/orgs","repos_url":"https://api.github.com/users/kirs/repos","events_url":"https://api.github.com/users/kirs/events{/privacy}","received_events_url":"https://api.github.com/users/kirs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirs/premailer-rails","description":"CSS styled emails without the hassle.","fork":true,"url":"https://api.github.com/repos/kirs/premailer-rails","forks_url":"https://api.github.com/repos/kirs/premailer-rails/forks","keys_url":"https://api.github.com/repos/kirs/premailer-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirs/premailer-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirs/premailer-rails/teams","hooks_url":"https://api.github.com/repos/kirs/premailer-rails/hooks","issue_events_url":"https://api.github.com/repos/kirs/premailer-rails/issues/events{/number}","events_url":"https://api.github.com/repos/kirs/premailer-rails/events","assignees_url":"https://api.github.com/repos/kirs/premailer-rails/assignees{/user}","branches_url":"https://api.github.com/repos/kirs/premailer-rails/branches{/branch}","tags_url":"https://api.github.com/repos/kirs/premailer-rails/tags","blobs_url":"https://api.github.com/repos/kirs/premailer-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirs/premailer-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirs/premailer-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirs/premailer-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirs/premailer-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/kirs/premailer-rails/languages","stargazers_url":"https://api.github.com/repos/kirs/premailer-rails/stargazers","contributors_url":"https://api.github.com/repos/kirs/premailer-rails/contributors","subscribers_url":"https://api.github.com/repos/kirs/premailer-rails/subscribers","subscription_url":"https://api.github.com/repos/kirs/premailer-rails/subscription","commits_url":"https://api.github.com/repos/kirs/premailer-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirs/premailer-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirs/premailer-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirs/premailer-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirs/premailer-rails/contents/{+path}","compare_url":"https://api.github.com/repos/kirs/premailer-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirs/premailer-rails/merges","archive_url":"https://api.github.com/repos/kirs/premailer-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirs/premailer-rails/downloads","issues_url":"https://api.github.com/repos/kirs/premailer-rails/issues{/number}","pulls_url":"https://api.github.com/repos/kirs/premailer-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/kirs/premailer-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/kirs/premailer-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirs/premailer-rails/labels{/name}","releases_url":"https://api.github.com/repos/kirs/premailer-rails/releases{/id}","deployments_url":"https://api.github.com/repos/kirs/premailer-rails/deployments","created_at":"2017-10-22T10:09:31Z","updated_at":"2017-10-22T10:09:32Z","pushed_at":"2017-11-05T11:54:54Z","git_url":"git://github.com/kirs/premailer-rails.git","ssh_url":"git@github.com:kirs/premailer-rails.git","clone_url":"https://github.com/kirs/premailer-rails.git","svn_url":"https://github.com/kirs/premailer-rails","homepage":"","size":254,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fphilipe:master","ref":"master","sha":"bdba2041b9da892cea69927340ef8da9b34f5b34","user":{"login":"fphilipe","id":128151,"avatar_url":"https://avatars1.githubusercontent.com/u/128151?v=4","gravatar_id":"","url":"https://api.github.com/users/fphilipe","html_url":"https://github.com/fphilipe","followers_url":"https://api.github.com/users/fphilipe/followers","following_url":"https://api.github.com/users/fphilipe/following{/other_user}","gists_url":"https://api.github.com/users/fphilipe/gists{/gist_id}","starred_url":"https://api.github.com/users/fphilipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fphilipe/subscriptions","organizations_url":"https://api.github.com/users/fphilipe/orgs","repos_url":"https://api.github.com/users/fphilipe/repos","events_url":"https://api.github.com/users/fphilipe/events{/privacy}","received_events_url":"https://api.github.com/users/fphilipe/received_events","type":"User","site_admin":false},"repo":{"id":1561299,"name":"premailer-rails","full_name":"fphilipe/premailer-rails","owner":{"login":"fphilipe","id":128151,"avatar_url":"https://avatars1.githubusercontent.com/u/128151?v=4","gravatar_id":"","url":"https://api.github.com/users/fphilipe","html_url":"https://github.com/fphilipe","followers_url":"https://api.github.com/users/fphilipe/followers","following_url":"https://api.github.com/users/fphilipe/following{/other_user}","gists_url":"https://api.github.com/users/fphilipe/gists{/gist_id}","starred_url":"https://api.github.com/users/fphilipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fphilipe/subscriptions","organizations_url":"https://api.github.com/users/fphilipe/orgs","repos_url":"https://api.github.com/users/fphilipe/repos","events_url":"https://api.github.com/users/fphilipe/events{/privacy}","received_events_url":"https://api.github.com/users/fphilipe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fphilipe/premailer-rails","description":"CSS styled emails without the hassle.","fork":false,"url":"https://api.github.com/repos/fphilipe/premailer-rails","forks_url":"https://api.github.com/repos/fphilipe/premailer-rails/forks","keys_url":"https://api.github.com/repos/fphilipe/premailer-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fphilipe/premailer-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fphilipe/premailer-rails/teams","hooks_url":"https://api.github.com/repos/fphilipe/premailer-rails/hooks","issue_events_url":"https://api.github.com/repos/fphilipe/premailer-rails/issues/events{/number}","events_url":"https://api.github.com/repos/fphilipe/premailer-rails/events","assignees_url":"https://api.github.com/repos/fphilipe/premailer-rails/assignees{/user}","branches_url":"https://api.github.com/repos/fphilipe/premailer-rails/branches{/branch}","tags_url":"https://api.github.com/repos/fphilipe/premailer-rails/tags","blobs_url":"https://api.github.com/repos/fphilipe/premailer-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fphilipe/premailer-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fphilipe/premailer-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/fphilipe/premailer-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fphilipe/premailer-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/fphilipe/premailer-rails/languages","stargazers_url":"https://api.github.com/repos/fphilipe/premailer-rails/stargazers","contributors_url":"https://api.github.com/repos/fphilipe/premailer-rails/contributors","subscribers_url":"https://api.github.com/repos/fphilipe/premailer-rails/subscribers","subscription_url":"https://api.github.com/repos/fphilipe/premailer-rails/subscription","commits_url":"https://api.github.com/repos/fphilipe/premailer-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/fphilipe/premailer-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/fphilipe/premailer-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/fphilipe/premailer-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/fphilipe/premailer-rails/contents/{+path}","compare_url":"https://api.github.com/repos/fphilipe/premailer-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fphilipe/premailer-rails/merges","archive_url":"https://api.github.com/repos/fphilipe/premailer-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fphilipe/premailer-rails/downloads","issues_url":"https://api.github.com/repos/fphilipe/premailer-rails/issues{/number}","pulls_url":"https://api.github.com/repos/fphilipe/premailer-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/fphilipe/premailer-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/fphilipe/premailer-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fphilipe/premailer-rails/labels{/name}","releases_url":"https://api.github.com/repos/fphilipe/premailer-rails/releases{/id}","deployments_url":"https://api.github.com/repos/fphilipe/premailer-rails/deployments","created_at":"2011-04-03T00:05:17Z","updated_at":"2017-11-08T14:47:38Z","pushed_at":"2017-11-09T05:49:22Z","git_url":"git://github.com/fphilipe/premailer-rails.git","ssh_url":"git@github.com:fphilipe/premailer-rails.git","clone_url":"https://github.com/fphilipe/premailer-rails.git","svn_url":"https://github.com/fphilipe/premailer-rails","homepage":"","size":242,"stargazers_count":1052,"watchers_count":1052,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":185,"open_issues":7,"watchers":1052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/204"},"html":{"href":"https://github.com/fphilipe/premailer-rails/pull/204"},"issue":{"href":"https://api.github.com/repos/fphilipe/premailer-rails/issues/204"},"comments":{"href":"https://api.github.com/repos/fphilipe/premailer-rails/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fphilipe/premailer-rails/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/fphilipe/premailer-rails/statuses/229e65d98999e3947e20d3cf37bfb62f67793a1f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fphilipe","id":128151,"avatar_url":"https://avatars1.githubusercontent.com/u/128151?v=4","gravatar_id":"","url":"https://api.github.com/users/fphilipe","html_url":"https://github.com/fphilipe","followers_url":"https://api.github.com/users/fphilipe/followers","following_url":"https://api.github.com/users/fphilipe/following{/other_user}","gists_url":"https://api.github.com/users/fphilipe/gists{/gist_id}","starred_url":"https://api.github.com/users/fphilipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fphilipe/subscriptions","organizations_url":"https://api.github.com/users/fphilipe/orgs","repos_url":"https://api.github.com/users/fphilipe/repos","events_url":"https://api.github.com/users/fphilipe/events{/privacy}","received_events_url":"https://api.github.com/users/fphilipe/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"fphilipe"}}