{"action":"created","issue":{"url":"https://api.github.com/repos/pimcore/pimcore/issues/1638","repository_url":"https://api.github.com/repos/pimcore/pimcore","labels_url":"https://api.github.com/repos/pimcore/pimcore/issues/1638/labels{/name}","comments_url":"https://api.github.com/repos/pimcore/pimcore/issues/1638/comments","events_url":"https://api.github.com/repos/pimcore/pimcore/issues/1638/events","html_url":"https://github.com/pimcore/pimcore/pull/1638","id":238116496,"number":1638,"title":"[PIMCORE4] New feature: define di configs inside plugins.","user":{"login":"kkarkus","id":17312072,"avatar_url":"https://avatars2.githubusercontent.com/u/17312072?v=3","gravatar_id":"","url":"https://api.github.com/users/kkarkus","html_url":"https://github.com/kkarkus","followers_url":"https://api.github.com/users/kkarkus/followers","following_url":"https://api.github.com/users/kkarkus/following{/other_user}","gists_url":"https://api.github.com/users/kkarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/kkarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkarkus/subscriptions","organizations_url":"https://api.github.com/users/kkarkus/orgs","repos_url":"https://api.github.com/users/kkarkus/repos","events_url":"https://api.github.com/users/kkarkus/events{/privacy}","received_events_url":"https://api.github.com/users/kkarkus/received_events","type":"User","site_admin":false},"labels":[{"id":247700394,"url":"https://api.github.com/repos/pimcore/pimcore/labels/Pending","name":"Pending","color":"bfdadc","default":false},{"id":593892291,"url":"https://api.github.com/repos/pimcore/pimcore/labels/Pimcore%204","name":"Pimcore 4","color":"999999","default":false},{"id":272440750,"url":"https://api.github.com/repos/pimcore/pimcore/labels/Proposal","name":"Proposal","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-23T11:30:31Z","updated_at":"2017-07-03T07:20:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pimcore/pimcore/pulls/1638","html_url":"https://github.com/pimcore/pimcore/pull/1638","diff_url":"https://github.com/pimcore/pimcore/pull/1638.diff","patch_url":"https://github.com/pimcore/pimcore/pull/1638.patch"},"body":"From now you can define custom di configs inside plugins.\r\n\r\n`Pimcore::initPluginsDi` runs before any `Plugin::init` because if you need there di container it must be completely built.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pimcore/pimcore/issues/comments/312568543","html_url":"https://github.com/pimcore/pimcore/pull/1638#issuecomment-312568543","issue_url":"https://api.github.com/repos/pimcore/pimcore/issues/1638","id":312568543,"user":{"login":"brusch","id":142037,"avatar_url":"https://avatars1.githubusercontent.com/u/142037?v=3","gravatar_id":"","url":"https://api.github.com/users/brusch","html_url":"https://github.com/brusch","followers_url":"https://api.github.com/users/brusch/followers","following_url":"https://api.github.com/users/brusch/following{/other_user}","gists_url":"https://api.github.com/users/brusch/gists{/gist_id}","starred_url":"https://api.github.com/users/brusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brusch/subscriptions","organizations_url":"https://api.github.com/users/brusch/orgs","repos_url":"https://api.github.com/users/brusch/repos","events_url":"https://api.github.com/users/brusch/events{/privacy}","received_events_url":"https://api.github.com/users/brusch/received_events","type":"User","site_admin":false},"created_at":"2017-07-03T07:20:39Z","updated_at":"2017-07-03T07:20:39Z","body":"I'm not really happy with the architecture since you're mixing plugin specific code into the `Pimcore` class. \r\nI think moving `initPluginsDi()` to `\\Pimcore\\ExtensionManager` makes more sense, and then call it when building the container: `foreach (ExtensionManager::getDiPaths() as $diPath) { ...`\r\n\r\nIn general: Any other opinions on that? \r\nImho this is quite a special use case, which is obsolete with v5 anyway. "}}
{"actor":{"display_login":"brusch"}}