{"action":"created","issue":{"url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/issues/8","repository_url":"https://api.github.com/repos/AnimeScreen/AnimeScreen","labels_url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/issues/8/comments","events_url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/issues/8/events","html_url":"https://github.com/AnimeScreen/AnimeScreen/pull/8","id":236744994,"number":8,"title":"WIP: CSS classes for the landing page","user":{"login":"yumiris","id":10241434,"avatar_url":"https://avatars2.githubusercontent.com/u/10241434?v=3","gravatar_id":"","url":"https://api.github.com/users/yumiris","html_url":"https://github.com/yumiris","followers_url":"https://api.github.com/users/yumiris/followers","following_url":"https://api.github.com/users/yumiris/following{/other_user}","gists_url":"https://api.github.com/users/yumiris/gists{/gist_id}","starred_url":"https://api.github.com/users/yumiris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumiris/subscriptions","organizations_url":"https://api.github.com/users/yumiris/orgs","repos_url":"https://api.github.com/users/yumiris/repos","events_url":"https://api.github.com/users/yumiris/events{/privacy}","received_events_url":"https://api.github.com/users/yumiris/received_events","type":"User","site_admin":false},"labels":[{"id":583692772,"url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"yumiris","id":10241434,"avatar_url":"https://avatars2.githubusercontent.com/u/10241434?v=3","gravatar_id":"","url":"https://api.github.com/users/yumiris","html_url":"https://github.com/yumiris","followers_url":"https://api.github.com/users/yumiris/followers","following_url":"https://api.github.com/users/yumiris/following{/other_user}","gists_url":"https://api.github.com/users/yumiris/gists{/gist_id}","starred_url":"https://api.github.com/users/yumiris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumiris/subscriptions","organizations_url":"https://api.github.com/users/yumiris/orgs","repos_url":"https://api.github.com/users/yumiris/repos","events_url":"https://api.github.com/users/yumiris/events{/privacy}","received_events_url":"https://api.github.com/users/yumiris/received_events","type":"User","site_admin":false},"assignees":[{"login":"yumiris","id":10241434,"avatar_url":"https://avatars2.githubusercontent.com/u/10241434?v=3","gravatar_id":"","url":"https://api.github.com/users/yumiris","html_url":"https://github.com/yumiris","followers_url":"https://api.github.com/users/yumiris/followers","following_url":"https://api.github.com/users/yumiris/following{/other_user}","gists_url":"https://api.github.com/users/yumiris/gists{/gist_id}","starred_url":"https://api.github.com/users/yumiris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumiris/subscriptions","organizations_url":"https://api.github.com/users/yumiris/orgs","repos_url":"https://api.github.com/users/yumiris/repos","events_url":"https://api.github.com/users/yumiris/events{/privacy}","received_events_url":"https://api.github.com/users/yumiris/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-06-18T20:56:00Z","updated_at":"2017-06-19T06:35:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/pulls/8","html_url":"https://github.com/AnimeScreen/AnimeScreen/pull/8","diff_url":"https://github.com/AnimeScreen/AnimeScreen/pull/8.diff","patch_url":"https://github.com/AnimeScreen/AnimeScreen/pull/8.patch"},"body":"<!-- PULL REQUEST TEMPLATE -->\r\n<!-- (Update \"[ ]\" to \"[x]\" to check a box) -->\r\n\r\n**Describe this PR:**\r\nThis PR introduces CSS classes to the landing page markup. The BEM convention is followed to ensure modularity, readability and maintainability. One of the styling developers should develop the CSS classes to represent the concept UIs and follow the naming convention. If that can't be done, I will take care of directly developing the Sass without any CSS prototypes.\r\n\r\n**What kind of change does this PR introduce?** (check at least one)\r\n\r\n- [ ] Bugfix\r\n- [ ] Feature\r\n- [ ] Documentation\r\n- [ ] Refactor\r\n- [ ] Style\r\n- [ ] Build-related changes\r\n- [x] Other, please describe: Markup\r\n\r\n**Other information:**\r\nThe following list shows the introduced classes and their descriptions and serves as a guideline for the stylesheets.\r\n\r\n**Header**\r\n- `header` - Container for page header elements, particularly the navigation bar.\r\n  - `header--landing` - Modifier: Small in height, transparent.\r\n- `header__nav` - Container for navigational items. Left side is for page links, right is for user links such as authentication and registration.\r\n- `nav__items` - Items list container for the links on the navigation bar.\r\n  - `nav__items--left` - Modifier: Positioned on the left side of the navbar.\r\n  - `nav__items--right` - Modifier: Positioned on the right side of the navbar.\r\n- `nav__item` - Container for the `<a>` element. This should define the spacing between the links.\r\n- `link` - Generic class for `<a>` elements. The main property should be `text decoration: none;`\r\n  - `link--white` - Modifier: White foreground colour for the link.\r\n  - `link--button` - Modifier: Border around the link.\r\n  - `link--filled` - Modifier: Link has background colour.\r\n\r\n**Landing section**\r\n- `section` - Generic container for non-header/footer data.\r\n- `section__landing` - Container which occupies the screen. Its height should be: screenHeight - (headerHeight + footerHeight)\r\n- `landing__introduction` - Container for the introductory text.\r\n- `landing__invitation` - Container for the invitation button.\r\n- `title` - Generic attribute for titles. Should probably have a margin & padding of 0.\r\n  - `title--big` - Modifier: Bigger title; maybe 36-48pt?\r\n  - `title--bold` - Modifier: Bold title.\r\n\r\n**Social media section**\r\n- `landing__social_links` - Container for the social media links text & group.\r\n- `text` - Generic text element.\r\n  - `text--grey` - Modifier: Colour of the text is grey.\r\n- `social_links__items` - Container group for the social media links.\r\n- `social_item` - Container for the `<a>` element. Again, this should define the spacing between the links.\r\n- `icon` - Class which defines the size and border radius of an icon. Might want to use the `content` CSS attribute to define the respective social media website's icon."},"comment":{"url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/issues/comments/309351130","html_url":"https://github.com/AnimeScreen/AnimeScreen/pull/8#issuecomment-309351130","issue_url":"https://api.github.com/repos/AnimeScreen/AnimeScreen/issues/8","id":309351130,"user":{"login":"WEBhicham","id":27362642,"avatar_url":"https://avatars3.githubusercontent.com/u/27362642?v=3","gravatar_id":"","url":"https://api.github.com/users/WEBhicham","html_url":"https://github.com/WEBhicham","followers_url":"https://api.github.com/users/WEBhicham/followers","following_url":"https://api.github.com/users/WEBhicham/following{/other_user}","gists_url":"https://api.github.com/users/WEBhicham/gists{/gist_id}","starred_url":"https://api.github.com/users/WEBhicham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WEBhicham/subscriptions","organizations_url":"https://api.github.com/users/WEBhicham/orgs","repos_url":"https://api.github.com/users/WEBhicham/repos","events_url":"https://api.github.com/users/WEBhicham/events{/privacy}","received_events_url":"https://api.github.com/users/WEBhicham/received_events","type":"User","site_admin":false},"created_at":"2017-06-19T06:35:46Z","updated_at":"2017-06-19T06:35:46Z","body":"social_links.\r\nsometimes php or js wil take - als actuel minus."}}
{"actor":{"display_login":"WEBhicham"}}