{"action":"created","comment":{"url":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments/147152541","pull_request_review_id":72205831,"id":147152541,"diff_hunk":"@@ -114,6 +114,30 @@ function () {\n     }\n \n     /**\n+     * Tests hasHeader\n+     *\n+     * @author limx <715557344@qq.com>\n+     * @since  2017-10-26\n+     */\n+    public function testHttpRequestCustomHeaderHas()\n+    {\n+        $this->specify(\n+            \"hasHeader does not returns correct result\",\n+            function () {\n+                $_SERVER['HTTP_FOO'] = 'Bar';\n+                $_SERVER['HTTP_AUTH'] = true;\n+\n+                $request = $this->getRequestObject();\n+\n+                expect($request->hasHeader('HTTP_FOO'))->true();\n+                expect($request->hasHeader('AUTH'))->true();\n+                expect($request->hasHeader('HTTP_FOO'))->true();\n+\n+            }","path":"tests/unit/Http/RequestTest.php","position":23,"original_position":23,"commit_id":"5f4cc6847fa7fd4c5943b3cfbc1487ae185d95a0","original_commit_id":"5f4cc6847fa7fd4c5943b3cfbc1487ae185d95a0","user":{"login":"sergeyklay","id":1256298,"avatar_url":"https://avatars2.githubusercontent.com/u/1256298?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyklay","html_url":"https://github.com/sergeyklay","followers_url":"https://api.github.com/users/sergeyklay/followers","following_url":"https://api.github.com/users/sergeyklay/following{/other_user}","gists_url":"https://api.github.com/users/sergeyklay/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyklay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyklay/subscriptions","organizations_url":"https://api.github.com/users/sergeyklay/orgs","repos_url":"https://api.github.com/users/sergeyklay/repos","events_url":"https://api.github.com/users/sergeyklay/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyklay/received_events","type":"User","site_admin":false},"body":"```\r\n----------------------------------------------------------------------\r\nFOUND 1 ERROR AFFECTING 1 LINE\r\n----------------------------------------------------------------------\r\n 136 | ERROR | [x] Function closing brace must go on the next line\r\n     |       |     following the body; found 1 blank lines before brace\r\n     |       |     (PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose)\r\n----------------------------------------------------------------------\r\nPHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY\r\n----------------------------------------------------------------------\r\n```","created_at":"2017-10-26T14:09:40Z","updated_at":"2017-10-26T14:10:05Z","html_url":"https://github.com/phalcon/cphalcon/pull/13136#discussion_r147152541","pull_request_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments/147152541"},"html":{"href":"https://github.com/phalcon/cphalcon/pull/13136#discussion_r147152541"},"pull_request":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136"}}},"pull_request":{"url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136","id":148929208,"html_url":"https://github.com/phalcon/cphalcon/pull/13136","diff_url":"https://github.com/phalcon/cphalcon/pull/13136.diff","patch_url":"https://github.com/phalcon/cphalcon/pull/13136.patch","issue_url":"https://api.github.com/repos/phalcon/cphalcon/issues/13136","number":13136,"state":"open","locked":false,"title":"* add function hasHeader to request","user":{"login":"limingxinleo","id":16648551,"avatar_url":"https://avatars2.githubusercontent.com/u/16648551?v=4","gravatar_id":"","url":"https://api.github.com/users/limingxinleo","html_url":"https://github.com/limingxinleo","followers_url":"https://api.github.com/users/limingxinleo/followers","following_url":"https://api.github.com/users/limingxinleo/following{/other_user}","gists_url":"https://api.github.com/users/limingxinleo/gists{/gist_id}","starred_url":"https://api.github.com/users/limingxinleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limingxinleo/subscriptions","organizations_url":"https://api.github.com/users/limingxinleo/orgs","repos_url":"https://api.github.com/users/limingxinleo/repos","events_url":"https://api.github.com/users/limingxinleo/events{/privacy}","received_events_url":"https://api.github.com/users/limingxinleo/received_events","type":"User","site_admin":false},"body":"Hello!\r\n\r\n* Type: new feature\r\n\r\n**In raising this pull request, I confirm the following (please check boxes):**\r\n\r\n- [x] I have read and understood the [Contributing Guidelines](https://github.com/phalcon/cphalcon/blob/master/CONTRIBUTING.md)?\r\n- [x] I have checked that another pull request for this purpose does not exist.\r\n- [x] I wrote some tests for this PR.\r\n\r\nSmall description of change:\r\n\r\nWhen I use getHeader to take some value out of headers, those the value don't exist,I will get empty string. But I expect it is null. So I add a function, called hasHeader to solve the problem.\r\n\r\nThanks\r\n\r\n","created_at":"2017-10-26T13:07:12Z","updated_at":"2017-10-26T14:10:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f21939f27d5825c9a4dbdd5b2e966d5837a1f75","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136/commits","review_comments_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136/comments","review_comment_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/issues/13136/comments","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/5f4cc6847fa7fd4c5943b3cfbc1487ae185d95a0","head":{"label":"limingxinleo:3.3.x.dev","ref":"3.3.x.dev","sha":"5f4cc6847fa7fd4c5943b3cfbc1487ae185d95a0","user":{"login":"limingxinleo","id":16648551,"avatar_url":"https://avatars2.githubusercontent.com/u/16648551?v=4","gravatar_id":"","url":"https://api.github.com/users/limingxinleo","html_url":"https://github.com/limingxinleo","followers_url":"https://api.github.com/users/limingxinleo/followers","following_url":"https://api.github.com/users/limingxinleo/following{/other_user}","gists_url":"https://api.github.com/users/limingxinleo/gists{/gist_id}","starred_url":"https://api.github.com/users/limingxinleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limingxinleo/subscriptions","organizations_url":"https://api.github.com/users/limingxinleo/orgs","repos_url":"https://api.github.com/users/limingxinleo/repos","events_url":"https://api.github.com/users/limingxinleo/events{/privacy}","received_events_url":"https://api.github.com/users/limingxinleo/received_events","type":"User","site_admin":false},"repo":{"id":84718489,"name":"cphalcon","full_name":"limingxinleo/cphalcon","owner":{"login":"limingxinleo","id":16648551,"avatar_url":"https://avatars2.githubusercontent.com/u/16648551?v=4","gravatar_id":"","url":"https://api.github.com/users/limingxinleo","html_url":"https://github.com/limingxinleo","followers_url":"https://api.github.com/users/limingxinleo/followers","following_url":"https://api.github.com/users/limingxinleo/following{/other_user}","gists_url":"https://api.github.com/users/limingxinleo/gists{/gist_id}","starred_url":"https://api.github.com/users/limingxinleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limingxinleo/subscriptions","organizations_url":"https://api.github.com/users/limingxinleo/orgs","repos_url":"https://api.github.com/users/limingxinleo/repos","events_url":"https://api.github.com/users/limingxinleo/events{/privacy}","received_events_url":"https://api.github.com/users/limingxinleo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/limingxinleo/cphalcon","description":"Web framework delivered as a C-extension for PHP","fork":true,"url":"https://api.github.com/repos/limingxinleo/cphalcon","forks_url":"https://api.github.com/repos/limingxinleo/cphalcon/forks","keys_url":"https://api.github.com/repos/limingxinleo/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/limingxinleo/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/limingxinleo/cphalcon/teams","hooks_url":"https://api.github.com/repos/limingxinleo/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/limingxinleo/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/limingxinleo/cphalcon/events","assignees_url":"https://api.github.com/repos/limingxinleo/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/limingxinleo/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/limingxinleo/cphalcon/tags","blobs_url":"https://api.github.com/repos/limingxinleo/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/limingxinleo/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/limingxinleo/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/limingxinleo/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/limingxinleo/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/limingxinleo/cphalcon/languages","stargazers_url":"https://api.github.com/repos/limingxinleo/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/limingxinleo/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/limingxinleo/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/limingxinleo/cphalcon/subscription","commits_url":"https://api.github.com/repos/limingxinleo/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/limingxinleo/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/limingxinleo/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/limingxinleo/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/limingxinleo/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/limingxinleo/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/limingxinleo/cphalcon/merges","archive_url":"https://api.github.com/repos/limingxinleo/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/limingxinleo/cphalcon/downloads","issues_url":"https://api.github.com/repos/limingxinleo/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/limingxinleo/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/limingxinleo/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/limingxinleo/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/limingxinleo/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/limingxinleo/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/limingxinleo/cphalcon/deployments","created_at":"2017-03-12T10:52:13Z","updated_at":"2017-10-10T08:11:31Z","pushed_at":"2017-10-26T12:47:33Z","git_url":"git://github.com/limingxinleo/cphalcon.git","ssh_url":"git@github.com:limingxinleo/cphalcon.git","clone_url":"https://github.com/limingxinleo/cphalcon.git","svn_url":"https://github.com/limingxinleo/cphalcon","homepage":"https://phalconphp.com","size":140086,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"phalcon:3.3.x","ref":"3.3.x","sha":"6ac6cfeaa9175d33dcffddd1319355dc8f16645e","user":{"login":"phalcon","id":1221505,"avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"repo":{"id":2854337,"name":"cphalcon","full_name":"phalcon/cphalcon","owner":{"login":"phalcon","id":1221505,"avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phalcon/cphalcon","description":"High performance, full-stack PHP framework delivered as a C extension.","fork":false,"url":"https://api.github.com/repos/phalcon/cphalcon","forks_url":"https://api.github.com/repos/phalcon/cphalcon/forks","keys_url":"https://api.github.com/repos/phalcon/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phalcon/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phalcon/cphalcon/teams","hooks_url":"https://api.github.com/repos/phalcon/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/phalcon/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/phalcon/cphalcon/events","assignees_url":"https://api.github.com/repos/phalcon/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/phalcon/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/phalcon/cphalcon/tags","blobs_url":"https://api.github.com/repos/phalcon/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phalcon/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phalcon/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/phalcon/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/phalcon/cphalcon/languages","stargazers_url":"https://api.github.com/repos/phalcon/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/phalcon/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/phalcon/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/phalcon/cphalcon/subscription","commits_url":"https://api.github.com/repos/phalcon/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/phalcon/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/phalcon/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/phalcon/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/phalcon/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phalcon/cphalcon/merges","archive_url":"https://api.github.com/repos/phalcon/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phalcon/cphalcon/downloads","issues_url":"https://api.github.com/repos/phalcon/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/phalcon/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/phalcon/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/phalcon/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phalcon/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/phalcon/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/phalcon/cphalcon/deployments","created_at":"2011-11-26T05:52:50Z","updated_at":"2017-10-26T08:08:34Z","pushed_at":"2017-10-26T13:07:12Z","git_url":"git://github.com/phalcon/cphalcon.git","ssh_url":"git@github.com:phalcon/cphalcon.git","clone_url":"https://github.com/phalcon/cphalcon.git","svn_url":"https://github.com/phalcon/cphalcon","homepage":"https://phalconphp.com","size":141589,"stargazers_count":8457,"watchers_count":8457,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1584,"mirror_url":null,"archived":false,"open_issues_count":620,"forks":1584,"open_issues":620,"watchers":8457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136"},"html":{"href":"https://github.com/phalcon/cphalcon/pull/13136"},"issue":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/13136"},"comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/13136/comments"},"review_comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136/comments"},"review_comment":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13136/commits"},"statuses":{"href":"https://api.github.com/repos/phalcon/cphalcon/statuses/5f4cc6847fa7fd4c5943b3cfbc1487ae185d95a0"}},"author_association":"NONE"}}
{"actor":{"display_login":"sergeyklay"}}