{"action":"closed","number":2868,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2868","id":125395212,"html_url":"https://github.com/openmicroscopy/bioformats/pull/2868","diff_url":"https://github.com/openmicroscopy/bioformats/pull/2868.diff","patch_url":"https://github.com/openmicroscopy/bioformats/pull/2868.patch","issue_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2868","number":2868,"state":"closed","locked":false,"title":"ND2 scanline pad fix","user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars2.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"body":"See https://trello.com/c/TaqXNGco/152-nd2-pixel-offset.\r\n\r\nFrom the Nikon ND2 samples in our repository, it seems like having an odd size both alongside the X dimension and the C dimension is necessary and sufficient to have the scanline padded.\r\n\r\nThis PR simplifies the `NativeND2Reader.getScanlinePad()` method to use this simpler calculation. To test this PR, check the automated tests keep passing against all ND2 samples. Additionally, test the sample file provided in the [Fiji forum thread](http://forum.imagej.net/t/importing-nd2-files-results-in-horizontal-lines-for-channels/5607) and check that without this PR, the image display with some horizontal lines while with this PR, it matches the expectation from NIS Elements.","created_at":"2017-06-13T15:35:24Z","updated_at":"2017-06-23T08:11:09Z","closed_at":"2017-06-23T08:11:09Z","merged_at":"2017-06-23T08:11:09Z","merge_commit_sha":"e86b42d210525ce81f0d162b08f7b599429142d5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2868/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2868/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2868/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/5203c7e515b283833f2ff7ef5841d8980c0e30d4","head":{"label":"sbesson:nd2_scanline","ref":"nd2_scanline","sha":"5203c7e515b283833f2ff7ef5841d8980c0e30d4","user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars2.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"repo":{"id":3541327,"name":"bioformats","full_name":"sbesson/bioformats","owner":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars2.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbesson/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment (particularly  UW-Madison LOCI and  Glencoe Software). Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":true,"url":"https://api.github.com/repos/sbesson/bioformats","forks_url":"https://api.github.com/repos/sbesson/bioformats/forks","keys_url":"https://api.github.com/repos/sbesson/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbesson/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbesson/bioformats/teams","hooks_url":"https://api.github.com/repos/sbesson/bioformats/hooks","issue_events_url":"https://api.github.com/repos/sbesson/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/sbesson/bioformats/events","assignees_url":"https://api.github.com/repos/sbesson/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/sbesson/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/sbesson/bioformats/tags","blobs_url":"https://api.github.com/repos/sbesson/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbesson/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbesson/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbesson/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbesson/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/sbesson/bioformats/languages","stargazers_url":"https://api.github.com/repos/sbesson/bioformats/stargazers","contributors_url":"https://api.github.com/repos/sbesson/bioformats/contributors","subscribers_url":"https://api.github.com/repos/sbesson/bioformats/subscribers","subscription_url":"https://api.github.com/repos/sbesson/bioformats/subscription","commits_url":"https://api.github.com/repos/sbesson/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbesson/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbesson/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbesson/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbesson/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/sbesson/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbesson/bioformats/merges","archive_url":"https://api.github.com/repos/sbesson/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbesson/bioformats/downloads","issues_url":"https://api.github.com/repos/sbesson/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/sbesson/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/sbesson/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/sbesson/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbesson/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/sbesson/bioformats/releases{/id}","deployments_url":"https://api.github.com/repos/sbesson/bioformats/deployments","created_at":"2012-02-25T00:50:54Z","updated_at":"2016-09-20T04:54:46Z","pushed_at":"2017-06-17T20:39:11Z","git_url":"git://github.com/sbesson/bioformats.git","ssh_url":"git@github.com:sbesson/bioformats.git","clone_url":"https://github.com/sbesson/bioformats.git","svn_url":"https://github.com/sbesson/bioformats","homepage":"http://trac.openmicroscopy.org.uk/ome/wiki/BioFormats","size":266489,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"openmicroscopy:develop","ref":"develop","sha":"5fc1625a7d6a313dbc4dc41f0b3981af766554db","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars1.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":2510503,"name":"bioformats","full_name":"openmicroscopy/bioformats","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars1.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment. Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":false,"url":"https://api.github.com/repos/openmicroscopy/bioformats","forks_url":"https://api.github.com/repos/openmicroscopy/bioformats/forks","keys_url":"https://api.github.com/repos/openmicroscopy/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/bioformats/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/bioformats/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/bioformats/events","assignees_url":"https://api.github.com/repos/openmicroscopy/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/bioformats/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/bioformats/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/bioformats/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmicroscopy/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/bioformats/merges","archive_url":"https://api.github.com/repos/openmicroscopy/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/bioformats/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/bioformats/releases{/id}","deployments_url":"https://api.github.com/repos/openmicroscopy/bioformats/deployments","created_at":"2011-10-04T08:06:14Z","updated_at":"2017-06-16T01:19:19Z","pushed_at":"2017-06-23T08:11:09Z","git_url":"git://github.com/openmicroscopy/bioformats.git","ssh_url":"git@github.com:openmicroscopy/bioformats.git","clone_url":"https://github.com/openmicroscopy/bioformats.git","svn_url":"https://github.com/openmicroscopy/bioformats","homepage":"http://www.openmicroscopy.org/site/products/bio-formats","size":267350,"stargazers_count":121,"watchers_count":121,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":23,"forks":143,"open_issues":23,"watchers":121,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2868"},"html":{"href":"https://github.com/openmicroscopy/bioformats/pull/2868"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2868"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2868/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2868/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2868/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/5203c7e515b283833f2ff7ef5841d8980c0e30d4"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars2.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"sbesson"}}