{"action":"created","comment":{"url":"https://api.github.com/repos/thredded/thredded/pulls/comments/133509187","pull_request_review_id":56698626,"id":133509187,"diff_hunk":"@@ -143,7 +143,7 @@ def self.user_class=(user_class_name)\n     unless user_class_name.is_a?(String)\n       fail \"Thredded.user_class must be set to a String, got #{user_class_name.inspect}\"\n     end\n-    @@user_class_name = user_class_name # rubocop:disable Style/ClassVars\n+    @@user_class_name = user_class_name.demodulize # rubocop:disable Style/ClassVars","path":"lib/thredded.rb","position":5,"original_position":5,"commit_id":"52346bb5db8bdfc803edd254f89d1eca6c20322b","original_commit_id":"52346bb5db8bdfc803edd254f89d1eca6c20322b","user":{"login":"glebm","id":216339,"avatar_url":"https://avatars0.githubusercontent.com/u/216339?v=4","gravatar_id":"","url":"https://api.github.com/users/glebm","html_url":"https://github.com/glebm","followers_url":"https://api.github.com/users/glebm/followers","following_url":"https://api.github.com/users/glebm/following{/other_user}","gists_url":"https://api.github.com/users/glebm/gists{/gist_id}","starred_url":"https://api.github.com/users/glebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebm/subscriptions","organizations_url":"https://api.github.com/users/glebm/orgs","repos_url":"https://api.github.com/users/glebm/repos","events_url":"https://api.github.com/users/glebm/events{/privacy}","received_events_url":"https://api.github.com/users/glebm/received_events","type":"User","site_admin":false},"body":"This is incorrect as it may no longer refers to the same class. E.g. `\"Spree::User\".demodulize` is \"User\" (which could be `::User` etc).","created_at":"2017-08-16T17:06:31Z","updated_at":"2017-08-16T17:06:31Z","html_url":"https://github.com/thredded/thredded/pull/612#discussion_r133509187","pull_request_url":"https://api.github.com/repos/thredded/thredded/pulls/612","_links":{"self":{"href":"https://api.github.com/repos/thredded/thredded/pulls/comments/133509187"},"html":{"href":"https://github.com/thredded/thredded/pull/612#discussion_r133509187"},"pull_request":{"href":"https://api.github.com/repos/thredded/thredded/pulls/612"}}},"pull_request":{"url":"https://api.github.com/repos/thredded/thredded/pulls/612","id":136064820,"html_url":"https://github.com/thredded/thredded/pull/612","diff_url":"https://github.com/thredded/thredded/pull/612.diff","patch_url":"https://github.com/thredded/thredded/pull/612.patch","issue_url":"https://api.github.com/repos/thredded/thredded/issues/612","number":612,"state":"open","locked":false,"title":"Fix for module qualified user class","user":{"login":"embmicro","id":5651612,"avatar_url":"https://avatars0.githubusercontent.com/u/5651612?v=4","gravatar_id":"","url":"https://api.github.com/users/embmicro","html_url":"https://github.com/embmicro","followers_url":"https://api.github.com/users/embmicro/followers","following_url":"https://api.github.com/users/embmicro/following{/other_user}","gists_url":"https://api.github.com/users/embmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/embmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embmicro/subscriptions","organizations_url":"https://api.github.com/users/embmicro/orgs","repos_url":"https://api.github.com/users/embmicro/repos","events_url":"https://api.github.com/users/embmicro/events{/privacy}","received_events_url":"https://api.github.com/users/embmicro/received_events","type":"User","site_admin":false},"body":"While trying to integrate Thredded with Spree I set Thredded.user_class to \"Spree::User\" which caused Thredded.user_class_name to be \"spree/user\" instead of \"user\" breaking most methods. This was the fix that seems to be working for me. I'm pretty new to Ruby/Rails so not sure if this is the best way to fix it.","created_at":"2017-08-16T16:11:52Z","updated_at":"2017-08-16T17:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65232f1ed66e64a74ca0bd3e458b4f26fd2a4880","assignee":{"login":"glebm","id":216339,"avatar_url":"https://avatars0.githubusercontent.com/u/216339?v=4","gravatar_id":"","url":"https://api.github.com/users/glebm","html_url":"https://github.com/glebm","followers_url":"https://api.github.com/users/glebm/followers","following_url":"https://api.github.com/users/glebm/following{/other_user}","gists_url":"https://api.github.com/users/glebm/gists{/gist_id}","starred_url":"https://api.github.com/users/glebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebm/subscriptions","organizations_url":"https://api.github.com/users/glebm/orgs","repos_url":"https://api.github.com/users/glebm/repos","events_url":"https://api.github.com/users/glebm/events{/privacy}","received_events_url":"https://api.github.com/users/glebm/received_events","type":"User","site_admin":false},"assignees":[{"login":"glebm","id":216339,"avatar_url":"https://avatars0.githubusercontent.com/u/216339?v=4","gravatar_id":"","url":"https://api.github.com/users/glebm","html_url":"https://github.com/glebm","followers_url":"https://api.github.com/users/glebm/followers","following_url":"https://api.github.com/users/glebm/following{/other_user}","gists_url":"https://api.github.com/users/glebm/gists{/gist_id}","starred_url":"https://api.github.com/users/glebm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glebm/subscriptions","organizations_url":"https://api.github.com/users/glebm/orgs","repos_url":"https://api.github.com/users/glebm/repos","events_url":"https://api.github.com/users/glebm/events{/privacy}","received_events_url":"https://api.github.com/users/glebm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/thredded/thredded/pulls/612/commits","review_comments_url":"https://api.github.com/repos/thredded/thredded/pulls/612/comments","review_comment_url":"https://api.github.com/repos/thredded/thredded/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thredded/thredded/issues/612/comments","statuses_url":"https://api.github.com/repos/thredded/thredded/statuses/52346bb5db8bdfc803edd254f89d1eca6c20322b","head":{"label":"embmicro:patch-1","ref":"patch-1","sha":"52346bb5db8bdfc803edd254f89d1eca6c20322b","user":{"login":"embmicro","id":5651612,"avatar_url":"https://avatars0.githubusercontent.com/u/5651612?v=4","gravatar_id":"","url":"https://api.github.com/users/embmicro","html_url":"https://github.com/embmicro","followers_url":"https://api.github.com/users/embmicro/followers","following_url":"https://api.github.com/users/embmicro/following{/other_user}","gists_url":"https://api.github.com/users/embmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/embmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embmicro/subscriptions","organizations_url":"https://api.github.com/users/embmicro/orgs","repos_url":"https://api.github.com/users/embmicro/repos","events_url":"https://api.github.com/users/embmicro/events{/privacy}","received_events_url":"https://api.github.com/users/embmicro/received_events","type":"User","site_admin":false},"repo":{"id":100508357,"name":"thredded","full_name":"embmicro/thredded","owner":{"login":"embmicro","id":5651612,"avatar_url":"https://avatars0.githubusercontent.com/u/5651612?v=4","gravatar_id":"","url":"https://api.github.com/users/embmicro","html_url":"https://github.com/embmicro","followers_url":"https://api.github.com/users/embmicro/followers","following_url":"https://api.github.com/users/embmicro/following{/other_user}","gists_url":"https://api.github.com/users/embmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/embmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embmicro/subscriptions","organizations_url":"https://api.github.com/users/embmicro/orgs","repos_url":"https://api.github.com/users/embmicro/repos","events_url":"https://api.github.com/users/embmicro/events{/privacy}","received_events_url":"https://api.github.com/users/embmicro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/embmicro/thredded","description":"The best Rails forums engine ever.","fork":true,"url":"https://api.github.com/repos/embmicro/thredded","forks_url":"https://api.github.com/repos/embmicro/thredded/forks","keys_url":"https://api.github.com/repos/embmicro/thredded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embmicro/thredded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embmicro/thredded/teams","hooks_url":"https://api.github.com/repos/embmicro/thredded/hooks","issue_events_url":"https://api.github.com/repos/embmicro/thredded/issues/events{/number}","events_url":"https://api.github.com/repos/embmicro/thredded/events","assignees_url":"https://api.github.com/repos/embmicro/thredded/assignees{/user}","branches_url":"https://api.github.com/repos/embmicro/thredded/branches{/branch}","tags_url":"https://api.github.com/repos/embmicro/thredded/tags","blobs_url":"https://api.github.com/repos/embmicro/thredded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embmicro/thredded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embmicro/thredded/git/refs{/sha}","trees_url":"https://api.github.com/repos/embmicro/thredded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embmicro/thredded/statuses/{sha}","languages_url":"https://api.github.com/repos/embmicro/thredded/languages","stargazers_url":"https://api.github.com/repos/embmicro/thredded/stargazers","contributors_url":"https://api.github.com/repos/embmicro/thredded/contributors","subscribers_url":"https://api.github.com/repos/embmicro/thredded/subscribers","subscription_url":"https://api.github.com/repos/embmicro/thredded/subscription","commits_url":"https://api.github.com/repos/embmicro/thredded/commits{/sha}","git_commits_url":"https://api.github.com/repos/embmicro/thredded/git/commits{/sha}","comments_url":"https://api.github.com/repos/embmicro/thredded/comments{/number}","issue_comment_url":"https://api.github.com/repos/embmicro/thredded/issues/comments{/number}","contents_url":"https://api.github.com/repos/embmicro/thredded/contents/{+path}","compare_url":"https://api.github.com/repos/embmicro/thredded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embmicro/thredded/merges","archive_url":"https://api.github.com/repos/embmicro/thredded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embmicro/thredded/downloads","issues_url":"https://api.github.com/repos/embmicro/thredded/issues{/number}","pulls_url":"https://api.github.com/repos/embmicro/thredded/pulls{/number}","milestones_url":"https://api.github.com/repos/embmicro/thredded/milestones{/number}","notifications_url":"https://api.github.com/repos/embmicro/thredded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embmicro/thredded/labels{/name}","releases_url":"https://api.github.com/repos/embmicro/thredded/releases{/id}","deployments_url":"https://api.github.com/repos/embmicro/thredded/deployments","created_at":"2017-08-16T16:09:02Z","updated_at":"2017-08-16T16:09:04Z","pushed_at":"2017-08-16T16:11:19Z","git_url":"git://github.com/embmicro/thredded.git","ssh_url":"git@github.com:embmicro/thredded.git","clone_url":"https://github.com/embmicro/thredded.git","svn_url":"https://github.com/embmicro/thredded","homepage":"https://thredded.org","size":2719,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thredded:master","ref":"master","sha":"f70097ec0a736da0c3ba12d48cb39f8d8f663ec8","user":{"login":"thredded","id":14218084,"avatar_url":"https://avatars3.githubusercontent.com/u/14218084?v=4","gravatar_id":"","url":"https://api.github.com/users/thredded","html_url":"https://github.com/thredded","followers_url":"https://api.github.com/users/thredded/followers","following_url":"https://api.github.com/users/thredded/following{/other_user}","gists_url":"https://api.github.com/users/thredded/gists{/gist_id}","starred_url":"https://api.github.com/users/thredded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thredded/subscriptions","organizations_url":"https://api.github.com/users/thredded/orgs","repos_url":"https://api.github.com/users/thredded/repos","events_url":"https://api.github.com/users/thredded/events{/privacy}","received_events_url":"https://api.github.com/users/thredded/received_events","type":"Organization","site_admin":false},"repo":{"id":9949492,"name":"thredded","full_name":"thredded/thredded","owner":{"login":"thredded","id":14218084,"avatar_url":"https://avatars3.githubusercontent.com/u/14218084?v=4","gravatar_id":"","url":"https://api.github.com/users/thredded","html_url":"https://github.com/thredded","followers_url":"https://api.github.com/users/thredded/followers","following_url":"https://api.github.com/users/thredded/following{/other_user}","gists_url":"https://api.github.com/users/thredded/gists{/gist_id}","starred_url":"https://api.github.com/users/thredded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thredded/subscriptions","organizations_url":"https://api.github.com/users/thredded/orgs","repos_url":"https://api.github.com/users/thredded/repos","events_url":"https://api.github.com/users/thredded/events{/privacy}","received_events_url":"https://api.github.com/users/thredded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thredded/thredded","description":"The best Rails forums engine ever.","fork":false,"url":"https://api.github.com/repos/thredded/thredded","forks_url":"https://api.github.com/repos/thredded/thredded/forks","keys_url":"https://api.github.com/repos/thredded/thredded/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thredded/thredded/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thredded/thredded/teams","hooks_url":"https://api.github.com/repos/thredded/thredded/hooks","issue_events_url":"https://api.github.com/repos/thredded/thredded/issues/events{/number}","events_url":"https://api.github.com/repos/thredded/thredded/events","assignees_url":"https://api.github.com/repos/thredded/thredded/assignees{/user}","branches_url":"https://api.github.com/repos/thredded/thredded/branches{/branch}","tags_url":"https://api.github.com/repos/thredded/thredded/tags","blobs_url":"https://api.github.com/repos/thredded/thredded/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thredded/thredded/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thredded/thredded/git/refs{/sha}","trees_url":"https://api.github.com/repos/thredded/thredded/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thredded/thredded/statuses/{sha}","languages_url":"https://api.github.com/repos/thredded/thredded/languages","stargazers_url":"https://api.github.com/repos/thredded/thredded/stargazers","contributors_url":"https://api.github.com/repos/thredded/thredded/contributors","subscribers_url":"https://api.github.com/repos/thredded/thredded/subscribers","subscription_url":"https://api.github.com/repos/thredded/thredded/subscription","commits_url":"https://api.github.com/repos/thredded/thredded/commits{/sha}","git_commits_url":"https://api.github.com/repos/thredded/thredded/git/commits{/sha}","comments_url":"https://api.github.com/repos/thredded/thredded/comments{/number}","issue_comment_url":"https://api.github.com/repos/thredded/thredded/issues/comments{/number}","contents_url":"https://api.github.com/repos/thredded/thredded/contents/{+path}","compare_url":"https://api.github.com/repos/thredded/thredded/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thredded/thredded/merges","archive_url":"https://api.github.com/repos/thredded/thredded/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thredded/thredded/downloads","issues_url":"https://api.github.com/repos/thredded/thredded/issues{/number}","pulls_url":"https://api.github.com/repos/thredded/thredded/pulls{/number}","milestones_url":"https://api.github.com/repos/thredded/thredded/milestones{/number}","notifications_url":"https://api.github.com/repos/thredded/thredded/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thredded/thredded/labels{/name}","releases_url":"https://api.github.com/repos/thredded/thredded/releases{/id}","deployments_url":"https://api.github.com/repos/thredded/thredded/deployments","created_at":"2013-05-09T01:17:41Z","updated_at":"2017-08-16T16:27:18Z","pushed_at":"2017-08-16T16:11:53Z","git_url":"git://github.com/thredded/thredded.git","ssh_url":"git@github.com:thredded/thredded.git","clone_url":"https://github.com/thredded/thredded.git","svn_url":"https://github.com/thredded/thredded","homepage":"https://thredded.org","size":2719,"stargazers_count":767,"watchers_count":767,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":39,"forks":114,"open_issues":39,"watchers":767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thredded/thredded/pulls/612"},"html":{"href":"https://github.com/thredded/thredded/pull/612"},"issue":{"href":"https://api.github.com/repos/thredded/thredded/issues/612"},"comments":{"href":"https://api.github.com/repos/thredded/thredded/issues/612/comments"},"review_comments":{"href":"https://api.github.com/repos/thredded/thredded/pulls/612/comments"},"review_comment":{"href":"https://api.github.com/repos/thredded/thredded/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thredded/thredded/pulls/612/commits"},"statuses":{"href":"https://api.github.com/repos/thredded/thredded/statuses/52346bb5db8bdfc803edd254f89d1eca6c20322b"}}}}
{"actor":{"display_login":"glebm"}}