{"action":"created","issue":{"url":"https://api.github.com/repos/moby/moby/issues/33845","repository_url":"https://api.github.com/repos/moby/moby","labels_url":"https://api.github.com/repos/moby/moby/issues/33845/labels{/name}","comments_url":"https://api.github.com/repos/moby/moby/issues/33845/comments","events_url":"https://api.github.com/repos/moby/moby/issues/33845/events","html_url":"https://github.com/moby/moby/pull/33845","id":238884132,"number":33845,"title":"devicemapper: rework logging and add --storage-opt dm.log_debug","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars2.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[{"id":175375407,"url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-06-27T15:07:34Z","updated_at":"2017-06-28T03:27:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/33845","html_url":"https://github.com/moby/moby/pull/33845","diff_url":"https://github.com/moby/moby/pull/33845.diff","patch_url":"https://github.com/moby/moby/pull/33845.patch"},"body":"Because libdm doesn't log anything if we have a logging callback\r\nregistered, we have to forward our logs to logrus. While this was done\r\npreviously in e2f8fbfbc (\"devicemapper: split out devicemapper bindings\"),\r\nit was modified in e07d3cd9a (\"devmapper: Fix libdm logging\") to remove\r\nthe debugging information because it was too voluminous.\r\n\r\nHowever, this has caused us several issues in debugging production\r\nsystems because libdm _LOG_{NOTICE,INFO,DEBUG} logs contain information\r\nthat cannot be obtained without recompiling the source.\r\n\r\nIn order to aid debugging while avoiding large amounts of logs, forward\r\n_LOG_{NOTICE,INFO} into our debug logs and only output _LOG_DEBUG if an\r\nadditional storage-driver specific flag is specified. This respects the\r\nfact that most users aren't going to be debugging devicemapper issues,\r\nwhile also avoiding the source recompilation burden when debugging.\r\n\r\n[![kitteh](https://c1.staticflickr.com/3/2640/4107269864_12ba5b8367_b.jpg)](https://flic.kr/p/7fWQeE)\r\n\r\n###### [Cosy cat](https://flic.kr/p/7fWQeE) by [David O&#x27;Hare](https://www.flickr.com/photos/30884177@N08/), on Flickr.\r\n\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>\r\n\r\n/cc @vbatts @rhvgoyal "},"comment":{"url":"https://api.github.com/repos/moby/moby/issues/comments/311546624","html_url":"https://github.com/moby/moby/pull/33845#issuecomment-311546624","issue_url":"https://api.github.com/repos/moby/moby/issues/33845","id":311546624,"user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars2.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"created_at":"2017-06-28T03:27:24Z","updated_at":"2017-06-28T03:27:24Z","body":"Alright, I'll match a PR there once this is merged."}}
{"actor":{"display_login":"cyphar"}}