{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/127595464","pull_request_review_id":50199809,"id":127595464,"diff_hunk":"@@ -4946,6 +4948,50 @@ def resample(self, rule, how=None, axis=0, fill_method=None, closed=None,\n         2000-01-01 00:06:00    26\n         Freq: 3T, dtype: int64\n \n+        For a Series with a PeriodIndex, the keyword ``convention`` can be\n+        used to control whether to use the start or end of ``rule``.\n+\n+        >>> series_p = pd.Series([1, 2],\n+                                 index=pd.period_range('2012-01-01',\n+                                                       freq='A',\n+                                                       periods=2\n+                                                       )\n+                                 )\n+        >>> series_p\n+        2012    1\n+        2013    2\n+        Freq: A-DEC, dtype: int64\n+\n+        Resample by month using 'start' ``convention``. Values are assigned to","path":"pandas/core/generic.py","position":27,"original_position":27,"commit_id":"42b8c8f407d8477518e271efb1a201b39ab02dd1","original_commit_id":"42b8c8f407d8477518e271efb1a201b39ab02dd1","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars6.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"you don't need convertion to be in double-backticks here","created_at":"2017-07-15T23:51:25Z","updated_at":"2017-07-15T23:51:48Z","html_url":"https://github.com/pandas-dev/pandas/pull/16965#discussion_r127595464","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/127595464"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/16965#discussion_r127595464"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965","id":130730950,"html_url":"https://github.com/pandas-dev/pandas/pull/16965","diff_url":"https://github.com/pandas-dev/pandas/pull/16965.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/16965.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/16965","number":16965,"state":"open","locked":false,"title":"DOC: document convention argument for resample()","user":{"login":"fding253","id":4405221,"avatar_url":"https://avatars5.githubusercontent.com/u/4405221?v=4","gravatar_id":"","url":"https://api.github.com/users/fding253","html_url":"https://github.com/fding253","followers_url":"https://api.github.com/users/fding253/followers","following_url":"https://api.github.com/users/fding253/following{/other_user}","gists_url":"https://api.github.com/users/fding253/gists{/gist_id}","starred_url":"https://api.github.com/users/fding253/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fding253/subscriptions","organizations_url":"https://api.github.com/users/fding253/orgs","repos_url":"https://api.github.com/users/fding253/repos","events_url":"https://api.github.com/users/fding253/events{/privacy}","received_events_url":"https://api.github.com/users/fding253/received_events","type":"User","site_admin":false},"body":" - [ ] closes #5023 \r\n - [ ] tests added / passed\r\n - [ ] passes ``git diff upstream/master -u -- \"*.py\" | flake8 --diff``\r\n - [ ] whatsnew entry\r\n","created_at":"2017-07-15T21:51:46Z","updated_at":"2017-07-15T23:51:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d094c5ef1a7651d5932315ac458378d5a86cc90","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/16965/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/42b8c8f407d8477518e271efb1a201b39ab02dd1","head":{"label":"fding253:doc/resample","ref":"doc/resample","sha":"42b8c8f407d8477518e271efb1a201b39ab02dd1","user":{"login":"fding253","id":4405221,"avatar_url":"https://avatars5.githubusercontent.com/u/4405221?v=4","gravatar_id":"","url":"https://api.github.com/users/fding253","html_url":"https://github.com/fding253","followers_url":"https://api.github.com/users/fding253/followers","following_url":"https://api.github.com/users/fding253/following{/other_user}","gists_url":"https://api.github.com/users/fding253/gists{/gist_id}","starred_url":"https://api.github.com/users/fding253/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fding253/subscriptions","organizations_url":"https://api.github.com/users/fding253/orgs","repos_url":"https://api.github.com/users/fding253/repos","events_url":"https://api.github.com/users/fding253/events{/privacy}","received_events_url":"https://api.github.com/users/fding253/received_events","type":"User","site_admin":false},"repo":{"id":97335315,"name":"pandas","full_name":"fding253/pandas","owner":{"login":"fding253","id":4405221,"avatar_url":"https://avatars5.githubusercontent.com/u/4405221?v=4","gravatar_id":"","url":"https://api.github.com/users/fding253","html_url":"https://github.com/fding253","followers_url":"https://api.github.com/users/fding253/followers","following_url":"https://api.github.com/users/fding253/following{/other_user}","gists_url":"https://api.github.com/users/fding253/gists{/gist_id}","starred_url":"https://api.github.com/users/fding253/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fding253/subscriptions","organizations_url":"https://api.github.com/users/fding253/orgs","repos_url":"https://api.github.com/users/fding253/repos","events_url":"https://api.github.com/users/fding253/events{/privacy}","received_events_url":"https://api.github.com/users/fding253/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fding253/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/fding253/pandas","forks_url":"https://api.github.com/repos/fding253/pandas/forks","keys_url":"https://api.github.com/repos/fding253/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fding253/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fding253/pandas/teams","hooks_url":"https://api.github.com/repos/fding253/pandas/hooks","issue_events_url":"https://api.github.com/repos/fding253/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/fding253/pandas/events","assignees_url":"https://api.github.com/repos/fding253/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/fding253/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/fding253/pandas/tags","blobs_url":"https://api.github.com/repos/fding253/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fding253/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fding253/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/fding253/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fding253/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/fding253/pandas/languages","stargazers_url":"https://api.github.com/repos/fding253/pandas/stargazers","contributors_url":"https://api.github.com/repos/fding253/pandas/contributors","subscribers_url":"https://api.github.com/repos/fding253/pandas/subscribers","subscription_url":"https://api.github.com/repos/fding253/pandas/subscription","commits_url":"https://api.github.com/repos/fding253/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/fding253/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/fding253/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/fding253/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/fding253/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/fding253/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fding253/pandas/merges","archive_url":"https://api.github.com/repos/fding253/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fding253/pandas/downloads","issues_url":"https://api.github.com/repos/fding253/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/fding253/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/fding253/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/fding253/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fding253/pandas/labels{/name}","releases_url":"https://api.github.com/repos/fding253/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/fding253/pandas/deployments","created_at":"2017-07-15T18:39:21Z","updated_at":"2017-07-15T18:39:28Z","pushed_at":"2017-07-15T21:50:23Z","git_url":"git://github.com/fding253/pandas.git","ssh_url":"git@github.com:fding253/pandas.git","clone_url":"https://github.com/fding253/pandas.git","svn_url":"https://github.com/fding253/pandas","homepage":"http://pandas.pydata.org","size":101621,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"2cd85ca748f62d7430b30e2d9ddd036e972cc64e","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars6.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars6.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-07-15T20:47:40Z","pushed_at":"2017-07-15T23:49:09Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":101771,"stargazers_count":10238,"watchers_count":10238,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4063,"mirror_url":null,"open_issues_count":2037,"forks":4063,"open_issues":2037,"watchers":10238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/16965"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/16965"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/16965/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16965/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/42b8c8f407d8477518e271efb1a201b39ab02dd1"}}}}
{"actor":{"display_login":"jreback"}}