{"action":"created","comment":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/149809432","pull_request_review_id":75264687,"id":149809432,"diff_hunk":"@@ -172,4 +173,20 @@ pub trait Engine: Debug {\n \n     /// Get all pools belonging to this engine.\n     fn pools(&self) -> Vec<&Pool>;\n+\n+    /// If the engine would like to include an event in the message loop, it\n+    /// may return an Eventable from this method.\n+    fn get_eventable(&mut self) -> EngineResult<Option<Box<Eventable>>>;","path":"src/engine/engine.rs","position":15,"original_position":15,"commit_id":"ba73b548fceba7eaf8410017aad26a04643e2d25","original_commit_id":"ba73b548fceba7eaf8410017aad26a04643e2d25","user":{"login":"agrover","id":2305,"avatar_url":"https://avatars1.githubusercontent.com/u/2305?v=4","gravatar_id":"","url":"https://api.github.com/users/agrover","html_url":"https://github.com/agrover","followers_url":"https://api.github.com/users/agrover/followers","following_url":"https://api.github.com/users/agrover/following{/other_user}","gists_url":"https://api.github.com/users/agrover/gists{/gist_id}","starred_url":"https://api.github.com/users/agrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrover/subscriptions","organizations_url":"https://api.github.com/users/agrover/orgs","repos_url":"https://api.github.com/users/agrover/repos","events_url":"https://api.github.com/users/agrover/events{/privacy}","received_events_url":"https://api.github.com/users/agrover/received_events","type":"User","site_admin":false},"body":"We can do this when such a thing becomes necessary.","created_at":"2017-11-08T22:00:02Z","updated_at":"2017-11-08T22:00:02Z","html_url":"https://github.com/stratis-storage/stratisd/pull/598#discussion_r149809432","pull_request_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/149809432"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/598#discussion_r149809432"},"pull_request":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598"}},"in_reply_to_id":148906638},"pull_request":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598","id":145009585,"html_url":"https://github.com/stratis-storage/stratisd/pull/598","diff_url":"https://github.com/stratis-storage/stratisd/pull/598.diff","patch_url":"https://github.com/stratis-storage/stratisd/pull/598.patch","issue_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/598","number":598,"state":"open","locked":false,"title":"Dm events","user":{"login":"agrover","id":2305,"avatar_url":"https://avatars1.githubusercontent.com/u/2305?v=4","gravatar_id":"","url":"https://api.github.com/users/agrover","html_url":"https://github.com/agrover","followers_url":"https://api.github.com/users/agrover/followers","following_url":"https://api.github.com/users/agrover/following{/other_user}","gists_url":"https://api.github.com/users/agrover/gists{/gist_id}","starred_url":"https://api.github.com/users/agrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrover/subscriptions","organizations_url":"https://api.github.com/users/agrover/orgs","repos_url":"https://api.github.com/users/agrover/repos","events_url":"https://api.github.com/users/agrover/events{/privacy}","received_events_url":"https://api.github.com/users/agrover/received_events","type":"User","site_admin":false},"body":"pending dm-rs changes. WIP.","created_at":"2017-10-05T20:12:05Z","updated_at":"2017-11-08T22:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7804f5a193e42ed22699fc504d109eaee308f7fe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"trgill","id":13203542,"avatar_url":"https://avatars1.githubusercontent.com/u/13203542?v=4","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598/commits","review_comments_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598/comments","review_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/598/comments","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/ba73b548fceba7eaf8410017aad26a04643e2d25","head":{"label":"agrover:dm-events","ref":"dm-events","sha":"ba73b548fceba7eaf8410017aad26a04643e2d25","user":{"login":"agrover","id":2305,"avatar_url":"https://avatars1.githubusercontent.com/u/2305?v=4","gravatar_id":"","url":"https://api.github.com/users/agrover","html_url":"https://github.com/agrover","followers_url":"https://api.github.com/users/agrover/followers","following_url":"https://api.github.com/users/agrover/following{/other_user}","gists_url":"https://api.github.com/users/agrover/gists{/gist_id}","starred_url":"https://api.github.com/users/agrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrover/subscriptions","organizations_url":"https://api.github.com/users/agrover/orgs","repos_url":"https://api.github.com/users/agrover/repos","events_url":"https://api.github.com/users/agrover/events{/privacy}","received_events_url":"https://api.github.com/users/agrover/received_events","type":"User","site_admin":false},"repo":{"id":68636276,"name":"stratisd","full_name":"agrover/stratisd","owner":{"login":"agrover","id":2305,"avatar_url":"https://avatars1.githubusercontent.com/u/2305?v=4","gravatar_id":"","url":"https://api.github.com/users/agrover","html_url":"https://github.com/agrover","followers_url":"https://api.github.com/users/agrover/followers","following_url":"https://api.github.com/users/agrover/following{/other_user}","gists_url":"https://api.github.com/users/agrover/gists{/gist_id}","starred_url":"https://api.github.com/users/agrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrover/subscriptions","organizations_url":"https://api.github.com/users/agrover/orgs","repos_url":"https://api.github.com/users/agrover/repos","events_url":"https://api.github.com/users/agrover/events{/privacy}","received_events_url":"https://api.github.com/users/agrover/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agrover/stratisd","description":null,"fork":true,"url":"https://api.github.com/repos/agrover/stratisd","forks_url":"https://api.github.com/repos/agrover/stratisd/forks","keys_url":"https://api.github.com/repos/agrover/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agrover/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agrover/stratisd/teams","hooks_url":"https://api.github.com/repos/agrover/stratisd/hooks","issue_events_url":"https://api.github.com/repos/agrover/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/agrover/stratisd/events","assignees_url":"https://api.github.com/repos/agrover/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/agrover/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/agrover/stratisd/tags","blobs_url":"https://api.github.com/repos/agrover/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agrover/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agrover/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/agrover/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agrover/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/agrover/stratisd/languages","stargazers_url":"https://api.github.com/repos/agrover/stratisd/stargazers","contributors_url":"https://api.github.com/repos/agrover/stratisd/contributors","subscribers_url":"https://api.github.com/repos/agrover/stratisd/subscribers","subscription_url":"https://api.github.com/repos/agrover/stratisd/subscription","commits_url":"https://api.github.com/repos/agrover/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/agrover/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/agrover/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/agrover/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/agrover/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/agrover/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agrover/stratisd/merges","archive_url":"https://api.github.com/repos/agrover/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agrover/stratisd/downloads","issues_url":"https://api.github.com/repos/agrover/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/agrover/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/agrover/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/agrover/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agrover/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/agrover/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/agrover/stratisd/deployments","created_at":"2016-09-19T18:55:49Z","updated_at":"2016-09-19T18:55:51Z","pushed_at":"2017-11-01T22:56:32Z","git_url":"git://github.com/agrover/stratisd.git","ssh_url":"git@github.com:agrover/stratisd.git","clone_url":"https://github.com/agrover/stratisd.git","svn_url":"https://github.com/agrover/stratisd","homepage":null,"size":1513,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratis-storage:master","ref":"master","sha":"2ffcf73f33e2d473c9877497cd4dbac99b96cd5b","user":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"repo":{"id":66564704,"name":"stratisd","full_name":"stratis-storage/stratisd","owner":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratis-storage/stratisd","description":null,"fork":false,"url":"https://api.github.com/repos/stratis-storage/stratisd","forks_url":"https://api.github.com/repos/stratis-storage/stratisd/forks","keys_url":"https://api.github.com/repos/stratis-storage/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratis-storage/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratis-storage/stratisd/teams","hooks_url":"https://api.github.com/repos/stratis-storage/stratisd/hooks","issue_events_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/stratis-storage/stratisd/events","assignees_url":"https://api.github.com/repos/stratis-storage/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/stratis-storage/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/stratis-storage/stratisd/tags","blobs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratis-storage/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratis-storage/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/stratis-storage/stratisd/languages","stargazers_url":"https://api.github.com/repos/stratis-storage/stratisd/stargazers","contributors_url":"https://api.github.com/repos/stratis-storage/stratisd/contributors","subscribers_url":"https://api.github.com/repos/stratis-storage/stratisd/subscribers","subscription_url":"https://api.github.com/repos/stratis-storage/stratisd/subscription","commits_url":"https://api.github.com/repos/stratis-storage/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratis-storage/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratis-storage/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/stratis-storage/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratis-storage/stratisd/merges","archive_url":"https://api.github.com/repos/stratis-storage/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratis-storage/stratisd/downloads","issues_url":"https://api.github.com/repos/stratis-storage/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/stratis-storage/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/stratis-storage/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratis-storage/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/stratis-storage/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/stratis-storage/stratisd/deployments","created_at":"2016-08-25T14:24:19Z","updated_at":"2017-11-03T18:22:05Z","pushed_at":"2017-11-08T18:40:01Z","git_url":"git://github.com/stratis-storage/stratisd.git","ssh_url":"git@github.com:stratis-storage/stratisd.git","clone_url":"https://github.com/stratis-storage/stratisd.git","svn_url":"https://github.com/stratis-storage/stratisd","homepage":null,"size":1489,"stargazers_count":126,"watchers_count":126,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":95,"forks":13,"open_issues":95,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/598"},"issue":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/598"},"comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/stratis-storage/stratisd/statuses/ba73b548fceba7eaf8410017aad26a04643e2d25"}},"author_association":"OWNER"}}
{"actor":{"display_login":"agrover"}}