{"action":"opened","number":21277,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/21277","id":101457129,"html_url":"https://github.com/symfony/symfony/pull/21277","diff_url":"https://github.com/symfony/symfony/pull/21277.diff","patch_url":"https://github.com/symfony/symfony/pull/21277.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/21277","number":21277,"state":"open","locked":false,"title":"[DX][Cache] Set right cacheItem type hint on AdapterInterface getters","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.1\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets |\r\n| License       | MIT\r\n| Doc PR        |\r\n\r\nFixes missing cache item type hint on pool getters so methods on Symfony CacheItem\r\nis correctly suggested when using IDE's or api documentation.\r\n\r\nAs proposed here: https://github.com/symfony/symfony/issues/19728#issuecomment-269615921\r\n\r\n_Note: Specifically sets array of CacheItems as return type of getItems as phpdoc and IDEs supports\r\nthis by now, and since this is specifically what is being returned. If Sami does not still support this we can adjust to what was originally suggested._\r\n","created_at":"2017-01-13T14:36:53Z","updated_at":"2017-01-13T14:36:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/21277/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/21277/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/21277/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/5f7baa5a42e6447f56f3a8ffaab1cb488f2d09c4","head":{"label":"andrerom:cache-item_typehint","ref":"cache-item_typehint","sha":"5f7baa5a42e6447f56f3a8ffaab1cb488f2d09c4","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"repo":{"id":6834118,"name":"symfony","full_name":"andrerom/symfony","owner":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrerom/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/andrerom/symfony","forks_url":"https://api.github.com/repos/andrerom/symfony/forks","keys_url":"https://api.github.com/repos/andrerom/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrerom/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrerom/symfony/teams","hooks_url":"https://api.github.com/repos/andrerom/symfony/hooks","issue_events_url":"https://api.github.com/repos/andrerom/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/andrerom/symfony/events","assignees_url":"https://api.github.com/repos/andrerom/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/andrerom/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/andrerom/symfony/tags","blobs_url":"https://api.github.com/repos/andrerom/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrerom/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrerom/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrerom/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrerom/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/andrerom/symfony/languages","stargazers_url":"https://api.github.com/repos/andrerom/symfony/stargazers","contributors_url":"https://api.github.com/repos/andrerom/symfony/contributors","subscribers_url":"https://api.github.com/repos/andrerom/symfony/subscribers","subscription_url":"https://api.github.com/repos/andrerom/symfony/subscription","commits_url":"https://api.github.com/repos/andrerom/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrerom/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrerom/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrerom/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrerom/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/andrerom/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrerom/symfony/merges","archive_url":"https://api.github.com/repos/andrerom/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrerom/symfony/downloads","issues_url":"https://api.github.com/repos/andrerom/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/andrerom/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/andrerom/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/andrerom/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrerom/symfony/labels{/name}","releases_url":"https://api.github.com/repos/andrerom/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/andrerom/symfony/deployments","created_at":"2012-11-23T22:56:58Z","updated_at":"2013-01-13T07:23:49Z","pushed_at":"2017-01-13T14:34:28Z","git_url":"git://github.com/andrerom/symfony.git","ssh_url":"git@github.com:andrerom/symfony.git","clone_url":"https://github.com/andrerom/symfony.git","svn_url":"https://github.com/andrerom/symfony","homepage":"symfony.com","size":54579,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:3.1","ref":"3.1","sha":"cbb5332b56251303c090899cfa86ab5cd3bafcd4","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-01-13T13:24:57Z","pushed_at":"2017-01-13T14:28:10Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":83350,"stargazers_count":13636,"watchers_count":13636,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5285,"mirror_url":null,"open_issues_count":861,"forks":5285,"open_issues":861,"watchers":13636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21277"},"html":{"href":"https://github.com/symfony/symfony/pull/21277"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/21277"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/21277/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21277/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21277/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/5f7baa5a42e6447f56f3a8ffaab1cb488f2d09c4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":13,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"andrerom"}}