{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/114031490","pull_request_review_id":35474481,"id":114031490,"diff_hunk":"@@ -21,6 +21,8 @@ spec:\n   kubernetesVersion: v1.4.6\n   masterInternalName: api.internal.minimal.example.com\n   masterPublicName: api.minimal.example.com\n+  additionalSans:\n+   - proxy.api.minimal.example.com","path":"nodeup/pkg/model/tests/dockerbuilder/simple/cluster.yaml","position":5,"original_position":5,"commit_id":"ac917a785441345e612364e280f35658fd481d6a","original_commit_id":"ac917a785441345e612364e280f35658fd481d6a","user":{"login":"pdh","id":1621357,"avatar_url":"https://avatars1.githubusercontent.com/u/1621357?v=3","gravatar_id":"","url":"https://api.github.com/users/pdh","html_url":"https://github.com/pdh","followers_url":"https://api.github.com/users/pdh/followers","following_url":"https://api.github.com/users/pdh/following{/other_user}","gists_url":"https://api.github.com/users/pdh/gists{/gist_id}","starred_url":"https://api.github.com/users/pdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdh/subscriptions","organizations_url":"https://api.github.com/users/pdh/orgs","repos_url":"https://api.github.com/users/pdh/repos","events_url":"https://api.github.com/users/pdh/events{/privacy}","received_events_url":"https://api.github.com/users/pdh/received_events","type":"User","site_admin":false},"body":"I'll remove this.","created_at":"2017-04-28T22:34:18Z","updated_at":"2017-04-28T22:34:18Z","html_url":"https://github.com/kubernetes/kops/pull/2063#discussion_r114031490","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/2063","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/114031490"},"html":{"href":"https://github.com/kubernetes/kops/pull/2063#discussion_r114031490"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2063"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/2063","id":109537737,"html_url":"https://github.com/kubernetes/kops/pull/2063","diff_url":"https://github.com/kubernetes/kops/pull/2063.diff","patch_url":"https://github.com/kubernetes/kops/pull/2063.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/2063","number":2063,"state":"open","locked":false,"title":"Allows additional Subject Alternate Names","user":{"login":"pdh","id":1621357,"avatar_url":"https://avatars1.githubusercontent.com/u/1621357?v=3","gravatar_id":"","url":"https://api.github.com/users/pdh","html_url":"https://github.com/pdh","followers_url":"https://api.github.com/users/pdh/followers","following_url":"https://api.github.com/users/pdh/following{/other_user}","gists_url":"https://api.github.com/users/pdh/gists{/gist_id}","starred_url":"https://api.github.com/users/pdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdh/subscriptions","organizations_url":"https://api.github.com/users/pdh/orgs","repos_url":"https://api.github.com/users/pdh/repos","events_url":"https://api.github.com/users/pdh/events{/privacy}","received_events_url":"https://api.github.com/users/pdh/received_events","type":"User","site_admin":false},"body":"Adds support for specifying additional SANs for issue #1922\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/2063)\n<!-- Reviewable:end -->\n","created_at":"2017-03-07T18:06:45Z","updated_at":"2017-04-28T22:34:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f80ac6b736c7d2b4ca42e0af7d74b87126568e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/2063/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/2063/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/2063/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/ac917a785441345e612364e280f35658fd481d6a","head":{"label":"pdh:additional-sans","ref":"additional-sans","sha":"ac917a785441345e612364e280f35658fd481d6a","user":{"login":"pdh","id":1621357,"avatar_url":"https://avatars1.githubusercontent.com/u/1621357?v=3","gravatar_id":"","url":"https://api.github.com/users/pdh","html_url":"https://github.com/pdh","followers_url":"https://api.github.com/users/pdh/followers","following_url":"https://api.github.com/users/pdh/following{/other_user}","gists_url":"https://api.github.com/users/pdh/gists{/gist_id}","starred_url":"https://api.github.com/users/pdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdh/subscriptions","organizations_url":"https://api.github.com/users/pdh/orgs","repos_url":"https://api.github.com/users/pdh/repos","events_url":"https://api.github.com/users/pdh/events{/privacy}","received_events_url":"https://api.github.com/users/pdh/received_events","type":"User","site_admin":false},"repo":{"id":83842534,"name":"kops","full_name":"pdh/kops","owner":{"login":"pdh","id":1621357,"avatar_url":"https://avatars1.githubusercontent.com/u/1621357?v=3","gravatar_id":"","url":"https://api.github.com/users/pdh","html_url":"https://github.com/pdh","followers_url":"https://api.github.com/users/pdh/followers","following_url":"https://api.github.com/users/pdh/following{/other_user}","gists_url":"https://api.github.com/users/pdh/gists{/gist_id}","starred_url":"https://api.github.com/users/pdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdh/subscriptions","organizations_url":"https://api.github.com/users/pdh/orgs","repos_url":"https://api.github.com/users/pdh/repos","events_url":"https://api.github.com/users/pdh/events{/privacy}","received_events_url":"https://api.github.com/users/pdh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdh/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/pdh/kops","forks_url":"https://api.github.com/repos/pdh/kops/forks","keys_url":"https://api.github.com/repos/pdh/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdh/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdh/kops/teams","hooks_url":"https://api.github.com/repos/pdh/kops/hooks","issue_events_url":"https://api.github.com/repos/pdh/kops/issues/events{/number}","events_url":"https://api.github.com/repos/pdh/kops/events","assignees_url":"https://api.github.com/repos/pdh/kops/assignees{/user}","branches_url":"https://api.github.com/repos/pdh/kops/branches{/branch}","tags_url":"https://api.github.com/repos/pdh/kops/tags","blobs_url":"https://api.github.com/repos/pdh/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdh/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdh/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdh/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdh/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/pdh/kops/languages","stargazers_url":"https://api.github.com/repos/pdh/kops/stargazers","contributors_url":"https://api.github.com/repos/pdh/kops/contributors","subscribers_url":"https://api.github.com/repos/pdh/kops/subscribers","subscription_url":"https://api.github.com/repos/pdh/kops/subscription","commits_url":"https://api.github.com/repos/pdh/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdh/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdh/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdh/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdh/kops/contents/{+path}","compare_url":"https://api.github.com/repos/pdh/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdh/kops/merges","archive_url":"https://api.github.com/repos/pdh/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdh/kops/downloads","issues_url":"https://api.github.com/repos/pdh/kops/issues{/number}","pulls_url":"https://api.github.com/repos/pdh/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/pdh/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/pdh/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdh/kops/labels{/name}","releases_url":"https://api.github.com/repos/pdh/kops/releases{/id}","deployments_url":"https://api.github.com/repos/pdh/kops/deployments","created_at":"2017-03-03T21:23:37Z","updated_at":"2017-03-03T21:23:41Z","pushed_at":"2017-03-03T23:15:03Z","git_url":"git://github.com/pdh/kops.git","ssh_url":"git@github.com:pdh/kops.git","clone_url":"https://github.com/pdh/kops.git","svn_url":"https://github.com/pdh/kops","homepage":"","size":111010,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3fb6f04afa972acd4ce92b7553a09bb407a47340","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-04-28T13:44:54Z","pushed_at":"2017-04-28T21:10:55Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":134723,"stargazers_count":1644,"watchers_count":1644,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":414,"mirror_url":null,"open_issues_count":631,"forks":414,"open_issues":631,"watchers":1644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2063"},"html":{"href":"https://github.com/kubernetes/kops/pull/2063"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/2063"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/2063/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2063/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2063/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/ac917a785441345e612364e280f35658fd481d6a"}}}}
{"actor":{"display_login":"pdh"}}