{"action":"created","comment":{"url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/comments/128484745","pull_request_review_id":51167645,"id":128484745,"diff_hunk":"@@ -18,8 +18,10 @@ $dialog-height-large: 500px;\n }\n \n .dialog-container {\n-    width: $dialog-width;\n-    height: $dialog-height;\n+    height: 100%;\n+    width: 100%;\n+    max-width: $dialog-width;","path":"HJ.Library/HJ.Library.Client/Components/Modal/_modal.scss","position":8,"original_position":8,"commit_id":"8d4592ec9a3757d4ec1332397aa26ec9651287dc","original_commit_id":"8d4592ec9a3757d4ec1332397aa26ec9651287dc","user":{"login":"Frank-Shanghai","id":13045680,"avatar_url":"https://avatars1.githubusercontent.com/u/13045680?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-Shanghai","html_url":"https://github.com/Frank-Shanghai","followers_url":"https://api.github.com/users/Frank-Shanghai/followers","following_url":"https://api.github.com/users/Frank-Shanghai/following{/other_user}","gists_url":"https://api.github.com/users/Frank-Shanghai/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-Shanghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-Shanghai/subscriptions","organizations_url":"https://api.github.com/users/Frank-Shanghai/orgs","repos_url":"https://api.github.com/users/Frank-Shanghai/repos","events_url":"https://api.github.com/users/Frank-Shanghai/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-Shanghai/received_events","type":"User","site_admin":false},"body":"By specifying max width and height and set height and width to 100%, instead of specifying fixed values for width and height, the dialog will take all the window space if the window is smaller than the max width and height.","created_at":"2017-07-20T10:59:02Z","updated_at":"2017-07-20T10:59:02Z","html_url":"https://github.com/Frank-Shanghai/HJ.Library/pull/74#discussion_r128484745","pull_request_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/comments/128484745"},"html":{"href":"https://github.com/Frank-Shanghai/HJ.Library/pull/74#discussion_r128484745"},"pull_request":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74","id":131525066,"html_url":"https://github.com/Frank-Shanghai/HJ.Library/pull/74","diff_url":"https://github.com/Frank-Shanghai/HJ.Library/pull/74.diff","patch_url":"https://github.com/Frank-Shanghai/HJ.Library/pull/74.patch","issue_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/74","number":74,"state":"open","locked":false,"title":"Feature/56 html dialog component","user":{"login":"Frank-Shanghai","id":13045680,"avatar_url":"https://avatars1.githubusercontent.com/u/13045680?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-Shanghai","html_url":"https://github.com/Frank-Shanghai","followers_url":"https://api.github.com/users/Frank-Shanghai/followers","following_url":"https://api.github.com/users/Frank-Shanghai/following{/other_user}","gists_url":"https://api.github.com/users/Frank-Shanghai/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-Shanghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-Shanghai/subscriptions","organizations_url":"https://api.github.com/users/Frank-Shanghai/orgs","repos_url":"https://api.github.com/users/Frank-Shanghai/repos","events_url":"https://api.github.com/users/Frank-Shanghai/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-Shanghai/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-20T10:52:54Z","updated_at":"2017-07-20T10:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b206d3f9c9c2d82e5aa632172012e3e452a726d7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74/commits","review_comments_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74/comments","review_comment_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/74/comments","statuses_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/statuses/8d4592ec9a3757d4ec1332397aa26ec9651287dc","head":{"label":"Frank-Shanghai:feature/56_HTML_dialog_component","ref":"feature/56_HTML_dialog_component","sha":"8d4592ec9a3757d4ec1332397aa26ec9651287dc","user":{"login":"Frank-Shanghai","id":13045680,"avatar_url":"https://avatars1.githubusercontent.com/u/13045680?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-Shanghai","html_url":"https://github.com/Frank-Shanghai","followers_url":"https://api.github.com/users/Frank-Shanghai/followers","following_url":"https://api.github.com/users/Frank-Shanghai/following{/other_user}","gists_url":"https://api.github.com/users/Frank-Shanghai/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-Shanghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-Shanghai/subscriptions","organizations_url":"https://api.github.com/users/Frank-Shanghai/orgs","repos_url":"https://api.github.com/users/Frank-Shanghai/repos","events_url":"https://api.github.com/users/Frank-Shanghai/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-Shanghai/received_events","type":"User","site_admin":false},"repo":{"id":56445232,"name":"HJ.Library","full_name":"Frank-Shanghai/HJ.Library","owner":{"login":"Frank-Shanghai","id":13045680,"avatar_url":"https://avatars1.githubusercontent.com/u/13045680?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-Shanghai","html_url":"https://github.com/Frank-Shanghai","followers_url":"https://api.github.com/users/Frank-Shanghai/followers","following_url":"https://api.github.com/users/Frank-Shanghai/following{/other_user}","gists_url":"https://api.github.com/users/Frank-Shanghai/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-Shanghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-Shanghai/subscriptions","organizations_url":"https://api.github.com/users/Frank-Shanghai/orgs","repos_url":"https://api.github.com/users/Frank-Shanghai/repos","events_url":"https://api.github.com/users/Frank-Shanghai/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-Shanghai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Frank-Shanghai/HJ.Library","description":null,"fork":false,"url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library","forks_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/forks","keys_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/teams","hooks_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/hooks","issue_events_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/events{/number}","events_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/events","assignees_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/assignees{/user}","branches_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/branches{/branch}","tags_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/tags","blobs_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/statuses/{sha}","languages_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/languages","stargazers_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/stargazers","contributors_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/contributors","subscribers_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/subscribers","subscription_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/subscription","commits_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/contents/{+path}","compare_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/merges","archive_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/downloads","issues_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues{/number}","pulls_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls{/number}","milestones_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/milestones{/number}","notifications_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/labels{/name}","releases_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/releases{/id}","deployments_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/deployments","created_at":"2016-04-17T15:59:03Z","updated_at":"2017-06-25T05:35:25Z","pushed_at":"2017-07-20T10:54:57Z","git_url":"git://github.com/Frank-Shanghai/HJ.Library.git","ssh_url":"git@github.com:Frank-Shanghai/HJ.Library.git","clone_url":"https://github.com/Frank-Shanghai/HJ.Library.git","svn_url":"https://github.com/Frank-Shanghai/HJ.Library","homepage":null,"size":33455,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"Frank-Shanghai:master","ref":"master","sha":"fb753cfc87aa5f05342ac84db0e1ed1acfbfcc5c","user":{"login":"Frank-Shanghai","id":13045680,"avatar_url":"https://avatars1.githubusercontent.com/u/13045680?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-Shanghai","html_url":"https://github.com/Frank-Shanghai","followers_url":"https://api.github.com/users/Frank-Shanghai/followers","following_url":"https://api.github.com/users/Frank-Shanghai/following{/other_user}","gists_url":"https://api.github.com/users/Frank-Shanghai/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-Shanghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-Shanghai/subscriptions","organizations_url":"https://api.github.com/users/Frank-Shanghai/orgs","repos_url":"https://api.github.com/users/Frank-Shanghai/repos","events_url":"https://api.github.com/users/Frank-Shanghai/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-Shanghai/received_events","type":"User","site_admin":false},"repo":{"id":56445232,"name":"HJ.Library","full_name":"Frank-Shanghai/HJ.Library","owner":{"login":"Frank-Shanghai","id":13045680,"avatar_url":"https://avatars1.githubusercontent.com/u/13045680?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-Shanghai","html_url":"https://github.com/Frank-Shanghai","followers_url":"https://api.github.com/users/Frank-Shanghai/followers","following_url":"https://api.github.com/users/Frank-Shanghai/following{/other_user}","gists_url":"https://api.github.com/users/Frank-Shanghai/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-Shanghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-Shanghai/subscriptions","organizations_url":"https://api.github.com/users/Frank-Shanghai/orgs","repos_url":"https://api.github.com/users/Frank-Shanghai/repos","events_url":"https://api.github.com/users/Frank-Shanghai/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-Shanghai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Frank-Shanghai/HJ.Library","description":null,"fork":false,"url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library","forks_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/forks","keys_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/teams","hooks_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/hooks","issue_events_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/events{/number}","events_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/events","assignees_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/assignees{/user}","branches_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/branches{/branch}","tags_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/tags","blobs_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/statuses/{sha}","languages_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/languages","stargazers_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/stargazers","contributors_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/contributors","subscribers_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/subscribers","subscription_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/subscription","commits_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/contents/{+path}","compare_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/merges","archive_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/downloads","issues_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues{/number}","pulls_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls{/number}","milestones_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/milestones{/number}","notifications_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/labels{/name}","releases_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/releases{/id}","deployments_url":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/deployments","created_at":"2016-04-17T15:59:03Z","updated_at":"2017-06-25T05:35:25Z","pushed_at":"2017-07-20T10:54:57Z","git_url":"git://github.com/Frank-Shanghai/HJ.Library.git","ssh_url":"git@github.com:Frank-Shanghai/HJ.Library.git","clone_url":"https://github.com/Frank-Shanghai/HJ.Library.git","svn_url":"https://github.com/Frank-Shanghai/HJ.Library","homepage":null,"size":33455,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74"},"html":{"href":"https://github.com/Frank-Shanghai/HJ.Library/pull/74"},"issue":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/74"},"comments":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/Frank-Shanghai/HJ.Library/statuses/8d4592ec9a3757d4ec1332397aa26ec9651287dc"}}}}
{"actor":{"display_login":"Frank-Shanghai"}}