{"action":"created","comment":{"url":"https://api.github.com/repos/openthread/openthread/pulls/comments/123508012","pull_request_review_id":45717471,"id":123508012,"diff_hunk":"@@ -1091,6 +1092,7 @@ void NcpBase::LinkRawReceiveDone(otRadioFrame *aFrame, otError aError)\n     SuccessOrExit(error = OutboundFrameSend());\n \n exit:\n+    OT_UNUSED_VARIABLE(error);","path":"src/ncp/ncp_base.cpp","position":13,"original_position":21,"commit_id":"1401218bcf4493af82d39e4c4969e47d50f39bf6","original_commit_id":"1401218bcf4493af82d39e4c4969e47d50f39bf6","user":{"login":"rlubos","id":22167799,"avatar_url":"https://avatars3.githubusercontent.com/u/22167799?v=3","gravatar_id":"","url":"https://api.github.com/users/rlubos","html_url":"https://github.com/rlubos","followers_url":"https://api.github.com/users/rlubos/followers","following_url":"https://api.github.com/users/rlubos/following{/other_user}","gists_url":"https://api.github.com/users/rlubos/gists{/gist_id}","starred_url":"https://api.github.com/users/rlubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlubos/subscriptions","organizations_url":"https://api.github.com/users/rlubos/orgs","repos_url":"https://api.github.com/users/rlubos/repos","events_url":"https://api.github.com/users/rlubos/events{/privacy}","received_events_url":"https://api.github.com/users/rlubos/received_events","type":"User","site_admin":false},"body":"Logging errors sounds reasonable to me. As for blacklistEntry, it already seems to print some information in case of error, so I'll remove this variable.","created_at":"2017-06-22T13:23:41Z","updated_at":"2017-06-22T13:23:41Z","html_url":"https://github.com/openthread/openthread/pull/1918#discussion_r123508012","pull_request_url":"https://api.github.com/repos/openthread/openthread/pulls/1918","_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments/123508012"},"html":{"href":"https://github.com/openthread/openthread/pull/1918#discussion_r123508012"},"pull_request":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1918"}}},"pull_request":{"url":"https://api.github.com/repos/openthread/openthread/pulls/1918","id":126541958,"html_url":"https://github.com/openthread/openthread/pull/1918","diff_url":"https://github.com/openthread/openthread/pull/1918.diff","patch_url":"https://github.com/openthread/openthread/pull/1918.patch","issue_url":"https://api.github.com/repos/openthread/openthread/issues/1918","number":1918,"state":"open","locked":false,"title":"OpenThread IAR warning fixes","user":{"login":"rlubos","id":22167799,"avatar_url":"https://avatars3.githubusercontent.com/u/22167799?v=3","gravatar_id":"","url":"https://api.github.com/users/rlubos","html_url":"https://github.com/rlubos","followers_url":"https://api.github.com/users/rlubos/followers","following_url":"https://api.github.com/users/rlubos/following{/other_user}","gists_url":"https://api.github.com/users/rlubos/gists{/gist_id}","starred_url":"https://api.github.com/users/rlubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlubos/subscriptions","organizations_url":"https://api.github.com/users/rlubos/orgs","repos_url":"https://api.github.com/users/rlubos/repos","events_url":"https://api.github.com/users/rlubos/events{/privacy}","received_events_url":"https://api.github.com/users/rlubos/received_events","type":"User","site_admin":false},"body":"This PR introduces some minor changes that fix warnings thrown by IAR when compiling OpenThread source.\r\n\r\nWarnings that IAR produced were:\r\n- Mixed enum types in single statements,\r\n- Variable assigned but not used (IAR does not seem to honor void casting in that case),\r\n- Unreachable code after assert.\r\n\r\nThe code was compiled with IAR 8.11.\r\n","created_at":"2017-06-20T14:07:33Z","updated_at":"2017-06-22T13:23:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77acb06a86affdf2838e1710cf00b14c594d57ad","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openthread/openthread/pulls/1918/commits","review_comments_url":"https://api.github.com/repos/openthread/openthread/pulls/1918/comments","review_comment_url":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openthread/openthread/issues/1918/comments","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/1401218bcf4493af82d39e4c4969e47d50f39bf6","head":{"label":"NordicSemiconductor:pr/fix-iar-compilation-warnings","ref":"pr/fix-iar-compilation-warnings","sha":"1401218bcf4493af82d39e4c4969e47d50f39bf6","user":{"login":"NordicSemiconductor","id":5527425,"avatar_url":"https://avatars1.githubusercontent.com/u/5527425?v=3","gravatar_id":"","url":"https://api.github.com/users/NordicSemiconductor","html_url":"https://github.com/NordicSemiconductor","followers_url":"https://api.github.com/users/NordicSemiconductor/followers","following_url":"https://api.github.com/users/NordicSemiconductor/following{/other_user}","gists_url":"https://api.github.com/users/NordicSemiconductor/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicSemiconductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicSemiconductor/subscriptions","organizations_url":"https://api.github.com/users/NordicSemiconductor/orgs","repos_url":"https://api.github.com/users/NordicSemiconductor/repos","events_url":"https://api.github.com/users/NordicSemiconductor/events{/privacy}","received_events_url":"https://api.github.com/users/NordicSemiconductor/received_events","type":"Organization","site_admin":false},"repo":{"id":68360680,"name":"openthread","full_name":"NordicSemiconductor/openthread","owner":{"login":"NordicSemiconductor","id":5527425,"avatar_url":"https://avatars1.githubusercontent.com/u/5527425?v=3","gravatar_id":"","url":"https://api.github.com/users/NordicSemiconductor","html_url":"https://github.com/NordicSemiconductor","followers_url":"https://api.github.com/users/NordicSemiconductor/followers","following_url":"https://api.github.com/users/NordicSemiconductor/following{/other_user}","gists_url":"https://api.github.com/users/NordicSemiconductor/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicSemiconductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicSemiconductor/subscriptions","organizations_url":"https://api.github.com/users/NordicSemiconductor/orgs","repos_url":"https://api.github.com/users/NordicSemiconductor/repos","events_url":"https://api.github.com/users/NordicSemiconductor/events{/privacy}","received_events_url":"https://api.github.com/users/NordicSemiconductor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NordicSemiconductor/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":true,"url":"https://api.github.com/repos/NordicSemiconductor/openthread","forks_url":"https://api.github.com/repos/NordicSemiconductor/openthread/forks","keys_url":"https://api.github.com/repos/NordicSemiconductor/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NordicSemiconductor/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NordicSemiconductor/openthread/teams","hooks_url":"https://api.github.com/repos/NordicSemiconductor/openthread/hooks","issue_events_url":"https://api.github.com/repos/NordicSemiconductor/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/NordicSemiconductor/openthread/events","assignees_url":"https://api.github.com/repos/NordicSemiconductor/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/NordicSemiconductor/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/NordicSemiconductor/openthread/tags","blobs_url":"https://api.github.com/repos/NordicSemiconductor/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NordicSemiconductor/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NordicSemiconductor/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/NordicSemiconductor/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NordicSemiconductor/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/NordicSemiconductor/openthread/languages","stargazers_url":"https://api.github.com/repos/NordicSemiconductor/openthread/stargazers","contributors_url":"https://api.github.com/repos/NordicSemiconductor/openthread/contributors","subscribers_url":"https://api.github.com/repos/NordicSemiconductor/openthread/subscribers","subscription_url":"https://api.github.com/repos/NordicSemiconductor/openthread/subscription","commits_url":"https://api.github.com/repos/NordicSemiconductor/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/NordicSemiconductor/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/NordicSemiconductor/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/NordicSemiconductor/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/NordicSemiconductor/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/NordicSemiconductor/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NordicSemiconductor/openthread/merges","archive_url":"https://api.github.com/repos/NordicSemiconductor/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NordicSemiconductor/openthread/downloads","issues_url":"https://api.github.com/repos/NordicSemiconductor/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/NordicSemiconductor/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/NordicSemiconductor/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/NordicSemiconductor/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NordicSemiconductor/openthread/labels{/name}","releases_url":"https://api.github.com/repos/NordicSemiconductor/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/NordicSemiconductor/openthread/deployments","created_at":"2016-09-16T07:28:32Z","updated_at":"2017-05-19T21:42:30Z","pushed_at":"2017-06-22T10:36:31Z","git_url":"git://github.com/NordicSemiconductor/openthread.git","ssh_url":"git@github.com:NordicSemiconductor/openthread.git","clone_url":"https://github.com/NordicSemiconductor/openthread.git","svn_url":"https://github.com/NordicSemiconductor/openthread","homepage":"","size":281941,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"openthread:master","ref":"master","sha":"9905c3fee138a7aa756ca544252186cad80decd3","user":{"login":"openthread","id":16142269,"avatar_url":"https://avatars1.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"repo":{"id":55808787,"name":"openthread","full_name":"openthread/openthread","owner":{"login":"openthread","id":16142269,"avatar_url":"https://avatars1.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openthread/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":false,"url":"https://api.github.com/repos/openthread/openthread","forks_url":"https://api.github.com/repos/openthread/openthread/forks","keys_url":"https://api.github.com/repos/openthread/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openthread/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openthread/openthread/teams","hooks_url":"https://api.github.com/repos/openthread/openthread/hooks","issue_events_url":"https://api.github.com/repos/openthread/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/openthread/openthread/events","assignees_url":"https://api.github.com/repos/openthread/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/openthread/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/openthread/openthread/tags","blobs_url":"https://api.github.com/repos/openthread/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openthread/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openthread/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/openthread/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/openthread/openthread/languages","stargazers_url":"https://api.github.com/repos/openthread/openthread/stargazers","contributors_url":"https://api.github.com/repos/openthread/openthread/contributors","subscribers_url":"https://api.github.com/repos/openthread/openthread/subscribers","subscription_url":"https://api.github.com/repos/openthread/openthread/subscription","commits_url":"https://api.github.com/repos/openthread/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/openthread/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/openthread/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/openthread/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/openthread/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/openthread/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openthread/openthread/merges","archive_url":"https://api.github.com/repos/openthread/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openthread/openthread/downloads","issues_url":"https://api.github.com/repos/openthread/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/openthread/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/openthread/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/openthread/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openthread/openthread/labels{/name}","releases_url":"https://api.github.com/repos/openthread/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/openthread/openthread/deployments","created_at":"2016-04-08T20:47:41Z","updated_at":"2017-06-20T18:37:10Z","pushed_at":"2017-06-22T10:57:38Z","git_url":"git://github.com/openthread/openthread.git","ssh_url":"git@github.com:openthread/openthread.git","clone_url":"https://github.com/openthread/openthread.git","svn_url":"https://github.com/openthread/openthread","homepage":"","size":38190,"stargazers_count":1268,"watchers_count":1268,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":45,"forks":330,"open_issues":45,"watchers":1268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1918"},"html":{"href":"https://github.com/openthread/openthread/pull/1918"},"issue":{"href":"https://api.github.com/repos/openthread/openthread/issues/1918"},"comments":{"href":"https://api.github.com/repos/openthread/openthread/issues/1918/comments"},"review_comments":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1918/comments"},"review_comment":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1918/commits"},"statuses":{"href":"https://api.github.com/repos/openthread/openthread/statuses/1401218bcf4493af82d39e4c4969e47d50f39bf6"}}}}
{"actor":{"display_login":"rlubos"}}