{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/140064170","pull_request_review_id":64072516,"id":140064170,"diff_hunk":"@@ -57,6 +57,15 @@ type IAMRoleCredentials struct {\n type TaskIAMRoleCredentials struct {\n \tARN                string\n \tIAMRoleCredentials IAMRoleCredentials\n+\tlock               sync.RWMutex\n+}\n+\n+// GetIAMRoleCredentials returns the iamrole credentials in the task iam role struct","path":"agent/credentials/manager.go","position":7,"original_position":7,"commit_id":"bf39b9effc147aaaf5757d3ff076d3a4dd0aa62b","original_commit_id":"bf39b9effc147aaaf5757d3ff076d3a4dd0aa62b","user":{"login":"nrdlngr","id":6174642,"avatar_url":"https://avatars1.githubusercontent.com/u/6174642?v=4","gravatar_id":"","url":"https://api.github.com/users/nrdlngr","html_url":"https://github.com/nrdlngr","followers_url":"https://api.github.com/users/nrdlngr/followers","following_url":"https://api.github.com/users/nrdlngr/following{/other_user}","gists_url":"https://api.github.com/users/nrdlngr/gists{/gist_id}","starred_url":"https://api.github.com/users/nrdlngr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrdlngr/subscriptions","organizations_url":"https://api.github.com/users/nrdlngr/orgs","repos_url":"https://api.github.com/users/nrdlngr/repos","events_url":"https://api.github.com/users/nrdlngr/events{/privacy}","received_events_url":"https://api.github.com/users/nrdlngr/received_events","type":"User","site_admin":false},"body":"GetIAMRoleCredentials returns the IAM role credentials in the task IAM role struct.","created_at":"2017-09-20T19:07:40Z","updated_at":"2017-09-20T19:22:18Z","html_url":"https://github.com/aws/amazon-ecs-agent/pull/906#discussion_r140064170","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/140064170"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/906#discussion_r140064170"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906","id":132844908,"html_url":"https://github.com/aws/amazon-ecs-agent/pull/906","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/906.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/906.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/906","number":906,"state":"open","locked":false,"title":"Handle the new field ecrpullcredentials in the task definition","user":{"login":"richardpen","id":17835576,"avatar_url":"https://avatars2.githubusercontent.com/u/17835576?v=4","gravatar_id":"","url":"https://api.github.com/users/richardpen","html_url":"https://github.com/richardpen","followers_url":"https://api.github.com/users/richardpen/followers","following_url":"https://api.github.com/users/richardpen/following{/other_user}","gists_url":"https://api.github.com/users/richardpen/gists{/gist_id}","starred_url":"https://api.github.com/users/richardpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardpen/subscriptions","organizations_url":"https://api.github.com/users/richardpen/orgs","repos_url":"https://api.github.com/users/richardpen/repos","events_url":"https://api.github.com/users/richardpen/events{/privacy}","received_events_url":"https://api.github.com/users/richardpen/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/aws/amazon-ecs-agent/blob/master/CONTRIBUTING.md\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n### Summary\r\n<!-- What does this pull request do? -->\r\nHandle the new field \"ecrpullcredentials\" in task definition.\r\n\r\n### Implementation details\r\n<!-- How are the changes implemented? -->\r\nCheck for the pullcredentials stored in container struct when pulling the image, if it exists, then use the credentials provided to get the docker auth from ecr.\r\n\r\n### Testing\r\n<!-- How was this tested? -->\r\n<!--\r\nNote for external contributors:\r\n`make test` and `make run-integ-tests` can run in a Linux development\r\nenvironment like your laptop.  `go test -timeout=25s ./agent/...` and\r\n`.\\scripts\\run-integ.tests.ps1` can run in a Windows development environment\r\nlike your laptop.  Please ensure unit and integration tests pass (on at least\r\none platform) before opening the pull request.  `make run-functional-tests` and\r\n`.\\scripts\\run-functional-tests.ps1` must be run on an EC2 instance with an\r\ninstance profile allowing it access to AWS resources.  Running\r\n`make run-functional-tests` and `.\\scripts\\run-functional-tests.ps1` may incur\r\ncharges to your AWS account; if you're unable or unwilling to run these tests\r\nin your own account, we can run the tests and provide test results.\r\n-->\r\n- [x] Builds on Linux (`make release`)\r\n- [x] Builds on Windows (`go build -out amazon-ecs-agent.exe ./agent`)\r\n- [x] Unit tests on Linux (`make test`) pass\r\n- [x] Unit tests on Windows (`go test -timeout=25s ./agent/...`) pass\r\n- [x] Integration tests on Linux (`make run-integ-tests`) pass\r\n- [x] Integration tests on Windows (`.\\scripts\\run-integ-tests.ps1`) pass\r\n- [x] Functional tests on Linux (`make run-functional-tests`) pass\r\n- [x] Functional tests on Windows (`.\\scripts\\run-functional-tests.ps1`) pass\r\n\r\nNew tests cover the changes: <!-- yes|no -->\r\nyes\r\n### Description for the changelog\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog.\r\nYou can see our changelog entry style here:\r\nhttps://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f\r\n-->\r\nAdd support for ECRPullCredentials for container.\r\n### Licensing\r\n<!--\r\nPlease confirm that this contribution is under the terms of the Apache 2.0\r\nLicense.\r\n-->\r\nThis contribution is under the terms of the Apache 2.0 License: <!-- yes -->\r\nyes","created_at":"2017-07-27T21:01:33Z","updated_at":"2017-09-20T19:22:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26617f8ec3b8b9abaea0bbed57aa4148ea548770","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samuelkarp","id":737750,"avatar_url":"https://avatars3.githubusercontent.com/u/737750?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelkarp","html_url":"https://github.com/samuelkarp","followers_url":"https://api.github.com/users/samuelkarp/followers","following_url":"https://api.github.com/users/samuelkarp/following{/other_user}","gists_url":"https://api.github.com/users/samuelkarp/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkarp/subscriptions","organizations_url":"https://api.github.com/users/samuelkarp/orgs","repos_url":"https://api.github.com/users/samuelkarp/repos","events_url":"https://api.github.com/users/samuelkarp/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkarp/received_events","type":"User","site_admin":false},{"login":"petderek","id":1487156,"avatar_url":"https://avatars3.githubusercontent.com/u/1487156?v=4","gravatar_id":"","url":"https://api.github.com/users/petderek","html_url":"https://github.com/petderek","followers_url":"https://api.github.com/users/petderek/followers","following_url":"https://api.github.com/users/petderek/following{/other_user}","gists_url":"https://api.github.com/users/petderek/gists{/gist_id}","starred_url":"https://api.github.com/users/petderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petderek/subscriptions","organizations_url":"https://api.github.com/users/petderek/orgs","repos_url":"https://api.github.com/users/petderek/repos","events_url":"https://api.github.com/users/petderek/events{/privacy}","received_events_url":"https://api.github.com/users/petderek/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/906/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/bf39b9effc147aaaf5757d3ff076d3a4dd0aa62b","head":{"label":"richardpen:ecr-credentials-test","ref":"ecr-credentials-test","sha":"bf39b9effc147aaaf5757d3ff076d3a4dd0aa62b","user":{"login":"richardpen","id":17835576,"avatar_url":"https://avatars2.githubusercontent.com/u/17835576?v=4","gravatar_id":"","url":"https://api.github.com/users/richardpen","html_url":"https://github.com/richardpen","followers_url":"https://api.github.com/users/richardpen/followers","following_url":"https://api.github.com/users/richardpen/following{/other_user}","gists_url":"https://api.github.com/users/richardpen/gists{/gist_id}","starred_url":"https://api.github.com/users/richardpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardpen/subscriptions","organizations_url":"https://api.github.com/users/richardpen/orgs","repos_url":"https://api.github.com/users/richardpen/repos","events_url":"https://api.github.com/users/richardpen/events{/privacy}","received_events_url":"https://api.github.com/users/richardpen/received_events","type":"User","site_admin":false},"repo":{"id":55100421,"name":"amazon-ecs-agent","full_name":"richardpen/amazon-ecs-agent","owner":{"login":"richardpen","id":17835576,"avatar_url":"https://avatars2.githubusercontent.com/u/17835576?v=4","gravatar_id":"","url":"https://api.github.com/users/richardpen","html_url":"https://github.com/richardpen","followers_url":"https://api.github.com/users/richardpen/followers","following_url":"https://api.github.com/users/richardpen/following{/other_user}","gists_url":"https://api.github.com/users/richardpen/gists{/gist_id}","starred_url":"https://api.github.com/users/richardpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardpen/subscriptions","organizations_url":"https://api.github.com/users/richardpen/orgs","repos_url":"https://api.github.com/users/richardpen/repos","events_url":"https://api.github.com/users/richardpen/events{/privacy}","received_events_url":"https://api.github.com/users/richardpen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardpen/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":true,"url":"https://api.github.com/repos/richardpen/amazon-ecs-agent","forks_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/richardpen/amazon-ecs-agent/deployments","created_at":"2016-03-30T21:52:59Z","updated_at":"2016-03-30T21:53:00Z","pushed_at":"2017-09-20T18:09:17Z","git_url":"git://github.com/richardpen/amazon-ecs-agent.git","ssh_url":"git@github.com:richardpen/amazon-ecs-agent.git","clone_url":"https://github.com/richardpen/amazon-ecs-agent.git","svn_url":"https://github.com/richardpen/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":6722,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:dev","ref":"dev","sha":"4ecdc98b02e0af09f715962e042c2b70664742cb","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2017-09-20T04:01:06Z","pushed_at":"2017-09-20T18:09:18Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"git@github.com:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":6724,"stargazers_count":995,"watchers_count":995,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":135,"forks":262,"open_issues":135,"watchers":995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/906"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/906"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/bf39b9effc147aaaf5757d3ff076d3a4dd0aa62b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nrdlngr"}}