{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/workbox/issues/1143","repository_url":"https://api.github.com/repos/GoogleChrome/workbox","labels_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/1143/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/1143/comments","events_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/1143/events","html_url":"https://github.com/GoogleChrome/workbox/pull/1143","id":284005216,"number":1143,"title":"Explicit GenerateSW or InjectManifest webpack modes","user":{"login":"jeffposnick","id":1749548,"avatar_url":"https://avatars1.githubusercontent.com/u/1749548?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffposnick","html_url":"https://github.com/jeffposnick","followers_url":"https://api.github.com/users/jeffposnick/followers","following_url":"https://api.github.com/users/jeffposnick/following{/other_user}","gists_url":"https://api.github.com/users/jeffposnick/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffposnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffposnick/subscriptions","organizations_url":"https://api.github.com/users/jeffposnick/orgs","repos_url":"https://api.github.com/users/jeffposnick/repos","events_url":"https://api.github.com/users/jeffposnick/events{/privacy}","received_events_url":"https://api.github.com/users/jeffposnick/received_events","type":"User","site_admin":false},"labels":[{"id":657087612,"url":"https://api.github.com/repos/GoogleChrome/workbox/labels/breaking-change","name":"breaking-change","color":"ee0701","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-21T21:09:49Z","updated_at":"2017-12-22T19:49:49Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/GoogleChrome/workbox/pulls/1143","html_url":"https://github.com/GoogleChrome/workbox/pull/1143","diff_url":"https://github.com/GoogleChrome/workbox/pull/1143.diff","patch_url":"https://github.com/GoogleChrome/workbox/pull/1143.patch"},"body":"R: @goldhand @prateekbh @gauntface\r\n\r\nFixes #1136\r\nFixes #1144\r\n\r\nThere's a lot of refactoring in this PR to move some of the internal methods in `workbox-webpack-plugin` around, and share logic between the two plugins.\r\n\r\nAs part of this PR it also made sense for me to change the global default value for `globPatterns` (defined in `workbox-build`) from `['**/*.{js,css,html}']` to `[]`. We had introduced a number of overrides to that global default previously, and would have to introduce additional ones here, and it got to the point that defaulting everything to `[]` seemed cleaner. (Developers going through the `workbox wizard` onboarding flow won't be affected by this change, since they're explicitly asked which file extensions to precache.)\r\n\r\nAssuming this PR is merged, I will put together a follow-up PR to reflect the changes that are needed to the relevant sections of the docs:\r\n\r\nhttps://github.com/google/WebFundamentals/tree/master/src/content/en/tools/workbox/guides/_shared\r\nhttps://github.com/google/WebFundamentals/blob/master/src/content/en/tools/workbox/modules/workbox-webpack-plugin.md"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/workbox/issues/comments/353664381","html_url":"https://github.com/GoogleChrome/workbox/pull/1143#issuecomment-353664381","issue_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/1143","id":353664381,"user":{"login":"jeffposnick","id":1749548,"avatar_url":"https://avatars1.githubusercontent.com/u/1749548?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffposnick","html_url":"https://github.com/jeffposnick","followers_url":"https://api.github.com/users/jeffposnick/followers","following_url":"https://api.github.com/users/jeffposnick/following{/other_user}","gists_url":"https://api.github.com/users/jeffposnick/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffposnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffposnick/subscriptions","organizations_url":"https://api.github.com/users/jeffposnick/orgs","repos_url":"https://api.github.com/users/jeffposnick/repos","events_url":"https://api.github.com/users/jeffposnick/events{/privacy}","received_events_url":"https://api.github.com/users/jeffposnick/received_events","type":"User","site_admin":false},"created_at":"2017-12-22T19:49:49Z","updated_at":"2017-12-22T19:49:49Z","author_association":"COLLABORATOR","body":"I've filed https://github.com/google/WebFundamentals/issues/5567 as a reminder to update the module docs to reflect this new interface and config options."}}
{"actor":{"display_login":"jeffposnick"}}