{"action":"created","comment":{"url":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/comments/130242393","pull_request_review_id":53096898,"id":130242393,"diff_hunk":"@@ -22,56 +29,78 @@\n \t\t\tthrow new Error('Must be implemented in derived object');\n \t\t},\n \n-\t\tgetPath: function (node) {\n+\t\tgetPathNodes: function (node) {\n \t\t\tthrow new Error('Must be implemented in derived object');\n \t\t},\n \n-\t\tgetPathByProperty: function (propertyName, propertyValue) {\n+\t\tgetPathString: function (node) {\n \t\t\tthrow new Error('Must be implemented in derived object');\n \t\t},\n \n-\t\tgetChildren: function (node) {\n+\t\tgetChildren: function (node, asList) {\n \t\t\tthrow new Error('Must be implemented in derived object');\n \t\t},\n \n \t\tgetProperty: function (node, propertyName) {\n \t\t\tthrow new Error('Must be implemented in derived object');\n \t\t},\n \n-\t\tgetPathString: function (node, textPropertyName, separator) {\n-\t\t\tvar path = this.getPath(node);\n-\t\t\treturn path.map(function (n) {\n-\t\t\t\treturn this.getProperty(n, textPropertyName);\n-\t\t\t}, this).join(separator);\n-\t\t},\n+\t\t/**\n+\t\t * Returns True if a node fullfills the search criteria.\n+\t\t */\n+\t\tnodeConformsSearch: function (node, propertyName, propertyValue, exact) {\n+\t\t\tvar property = this.getProperty(node, propertyName);\n \n-\t\tgetPathStringByProperty: function (propertyName, propertyValue, textPropertyName, separator) {\n-\t\t\tvar node = this.getNodeByProperty(propertyName, propertyValue);\n-\t\t\tif (node !== undefined) {\n-\t\t\t\treturn this.getPathString(node, textPropertyName, separator);\n+\t\t\tswitch (exact) {\n+\t\t\t\tcase true:\n+\t\t\t\t\tif (property === propertyValue) {","path":"cosmoz-tree.html","position":55,"original_position":55,"commit_id":"d8e9ffdb2ddb32daab4e5ed844f1062dd497ef35","original_commit_id":"d8e9ffdb2ddb32daab4e5ed844f1062dd497ef35","user":{"login":"JaySunSyn","id":5872432,"avatar_url":"https://avatars0.githubusercontent.com/u/5872432?v=4","gravatar_id":"","url":"https://api.github.com/users/JaySunSyn","html_url":"https://github.com/JaySunSyn","followers_url":"https://api.github.com/users/JaySunSyn/followers","following_url":"https://api.github.com/users/JaySunSyn/following{/other_user}","gists_url":"https://api.github.com/users/JaySunSyn/gists{/gist_id}","starred_url":"https://api.github.com/users/JaySunSyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaySunSyn/subscriptions","organizations_url":"https://api.github.com/users/JaySunSyn/orgs","repos_url":"https://api.github.com/users/JaySunSyn/repos","events_url":"https://api.github.com/users/JaySunSyn/events{/privacy}","received_events_url":"https://api.github.com/users/JaySunSyn/received_events","type":"User","site_admin":false},"body":"@nomego what about this instead?\r\n\r\n```\r\nif (exact) {\r\n\treturn property === propertyValue;\r\n}\r\n\r\nreturn property.toLowerCase().indexOf(propertyValue.toLowerCase()) > -1;\r\n```","created_at":"2017-07-30T13:19:36Z","updated_at":"2017-07-30T13:19:36Z","html_url":"https://github.com/Neovici/cosmoz-tree/pull/1#discussion_r130242393","pull_request_url":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/comments/130242393"},"html":{"href":"https://github.com/Neovici/cosmoz-tree/pull/1#discussion_r130242393"},"pull_request":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1","id":131795591,"html_url":"https://github.com/Neovici/cosmoz-tree/pull/1","diff_url":"https://github.com/Neovici/cosmoz-tree/pull/1.diff","patch_url":"https://github.com/Neovici/cosmoz-tree/pull/1.patch","issue_url":"https://api.github.com/repos/Neovici/cosmoz-tree/issues/1","number":1,"state":"open","locked":false,"title":"Issue 4 of cosmoz-treenode-navigator","user":{"login":"JaySunSyn","id":5872432,"avatar_url":"https://avatars0.githubusercontent.com/u/5872432?v=4","gravatar_id":"","url":"https://api.github.com/users/JaySunSyn","html_url":"https://github.com/JaySunSyn","followers_url":"https://api.github.com/users/JaySunSyn/followers","following_url":"https://api.github.com/users/JaySunSyn/following{/other_user}","gists_url":"https://api.github.com/users/JaySunSyn/gists{/gist_id}","starred_url":"https://api.github.com/users/JaySunSyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaySunSyn/subscriptions","organizations_url":"https://api.github.com/users/JaySunSyn/orgs","repos_url":"https://api.github.com/users/JaySunSyn/repos","events_url":"https://api.github.com/users/JaySunSyn/events{/privacy}","received_events_url":"https://api.github.com/users/JaySunSyn/received_events","type":"User","site_admin":false},"body":"In Progress.\r\n\r\nsee https://github.com/Neovici/cosmoz-treenode-navigator/issues/4\r\n\r\nRename of API methods:\r\n- getPath() => getPathNodes()\r\n\r\nNew API methods:\r\n- searchNodes()\r\n\r\nRemoved API methods:\r\n- getNodeByProperty()\r\n- getPathByProperty()\r\n","created_at":"2017-07-21T15:07:44Z","updated_at":"2017-07-30T13:19:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74296544bb52b23e1df739cce4f211252d90ea73","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neovici/cosmoz-tree/issues/1/comments","statuses_url":"https://api.github.com/repos/Neovici/cosmoz-tree/statuses/d8e9ffdb2ddb32daab4e5ed844f1062dd497ef35","head":{"label":"JaySunSyn:issue-4","ref":"issue-4","sha":"d8e9ffdb2ddb32daab4e5ed844f1062dd497ef35","user":{"login":"JaySunSyn","id":5872432,"avatar_url":"https://avatars0.githubusercontent.com/u/5872432?v=4","gravatar_id":"","url":"https://api.github.com/users/JaySunSyn","html_url":"https://github.com/JaySunSyn","followers_url":"https://api.github.com/users/JaySunSyn/followers","following_url":"https://api.github.com/users/JaySunSyn/following{/other_user}","gists_url":"https://api.github.com/users/JaySunSyn/gists{/gist_id}","starred_url":"https://api.github.com/users/JaySunSyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaySunSyn/subscriptions","organizations_url":"https://api.github.com/users/JaySunSyn/orgs","repos_url":"https://api.github.com/users/JaySunSyn/repos","events_url":"https://api.github.com/users/JaySunSyn/events{/privacy}","received_events_url":"https://api.github.com/users/JaySunSyn/received_events","type":"User","site_admin":false},"repo":{"id":97957374,"name":"cosmoz-tree","full_name":"JaySunSyn/cosmoz-tree","owner":{"login":"JaySunSyn","id":5872432,"avatar_url":"https://avatars0.githubusercontent.com/u/5872432?v=4","gravatar_id":"","url":"https://api.github.com/users/JaySunSyn","html_url":"https://github.com/JaySunSyn","followers_url":"https://api.github.com/users/JaySunSyn/followers","following_url":"https://api.github.com/users/JaySunSyn/following{/other_user}","gists_url":"https://api.github.com/users/JaySunSyn/gists{/gist_id}","starred_url":"https://api.github.com/users/JaySunSyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaySunSyn/subscriptions","organizations_url":"https://api.github.com/users/JaySunSyn/orgs","repos_url":"https://api.github.com/users/JaySunSyn/repos","events_url":"https://api.github.com/users/JaySunSyn/events{/privacy}","received_events_url":"https://api.github.com/users/JaySunSyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JaySunSyn/cosmoz-tree","description":"Utility class to manipulate a tree data structure","fork":true,"url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree","forks_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/forks","keys_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/teams","hooks_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/hooks","issue_events_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/issues/events{/number}","events_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/events","assignees_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/assignees{/user}","branches_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/branches{/branch}","tags_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/tags","blobs_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/git/refs{/sha}","trees_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/statuses/{sha}","languages_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/languages","stargazers_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/stargazers","contributors_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/contributors","subscribers_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/subscribers","subscription_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/subscription","commits_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/commits{/sha}","git_commits_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/git/commits{/sha}","comments_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/comments{/number}","issue_comment_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/issues/comments{/number}","contents_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/contents/{+path}","compare_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/merges","archive_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/downloads","issues_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/issues{/number}","pulls_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/pulls{/number}","milestones_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/milestones{/number}","notifications_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/labels{/name}","releases_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/releases{/id}","deployments_url":"https://api.github.com/repos/JaySunSyn/cosmoz-tree/deployments","created_at":"2017-07-21T14:37:15Z","updated_at":"2017-07-21T14:37:17Z","pushed_at":"2017-07-29T14:19:31Z","git_url":"git://github.com/JaySunSyn/cosmoz-tree.git","ssh_url":"git@github.com:JaySunSyn/cosmoz-tree.git","clone_url":"https://github.com/JaySunSyn/cosmoz-tree.git","svn_url":"https://github.com/JaySunSyn/cosmoz-tree","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Neovici:master","ref":"master","sha":"e1709ae1181327bc81e5b32e2dce5f6dac276b25","user":{"login":"Neovici","id":10965763,"avatar_url":"https://avatars0.githubusercontent.com/u/10965763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neovici","html_url":"https://github.com/Neovici","followers_url":"https://api.github.com/users/Neovici/followers","following_url":"https://api.github.com/users/Neovici/following{/other_user}","gists_url":"https://api.github.com/users/Neovici/gists{/gist_id}","starred_url":"https://api.github.com/users/Neovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neovici/subscriptions","organizations_url":"https://api.github.com/users/Neovici/orgs","repos_url":"https://api.github.com/users/Neovici/repos","events_url":"https://api.github.com/users/Neovici/events{/privacy}","received_events_url":"https://api.github.com/users/Neovici/received_events","type":"Organization","site_admin":false},"repo":{"id":89463307,"name":"cosmoz-tree","full_name":"Neovici/cosmoz-tree","owner":{"login":"Neovici","id":10965763,"avatar_url":"https://avatars0.githubusercontent.com/u/10965763?v=4","gravatar_id":"","url":"https://api.github.com/users/Neovici","html_url":"https://github.com/Neovici","followers_url":"https://api.github.com/users/Neovici/followers","following_url":"https://api.github.com/users/Neovici/following{/other_user}","gists_url":"https://api.github.com/users/Neovici/gists{/gist_id}","starred_url":"https://api.github.com/users/Neovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neovici/subscriptions","organizations_url":"https://api.github.com/users/Neovici/orgs","repos_url":"https://api.github.com/users/Neovici/repos","events_url":"https://api.github.com/users/Neovici/events{/privacy}","received_events_url":"https://api.github.com/users/Neovici/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Neovici/cosmoz-tree","description":"Utility class to manipulate a tree data structure","fork":false,"url":"https://api.github.com/repos/Neovici/cosmoz-tree","forks_url":"https://api.github.com/repos/Neovici/cosmoz-tree/forks","keys_url":"https://api.github.com/repos/Neovici/cosmoz-tree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neovici/cosmoz-tree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neovici/cosmoz-tree/teams","hooks_url":"https://api.github.com/repos/Neovici/cosmoz-tree/hooks","issue_events_url":"https://api.github.com/repos/Neovici/cosmoz-tree/issues/events{/number}","events_url":"https://api.github.com/repos/Neovici/cosmoz-tree/events","assignees_url":"https://api.github.com/repos/Neovici/cosmoz-tree/assignees{/user}","branches_url":"https://api.github.com/repos/Neovici/cosmoz-tree/branches{/branch}","tags_url":"https://api.github.com/repos/Neovici/cosmoz-tree/tags","blobs_url":"https://api.github.com/repos/Neovici/cosmoz-tree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neovici/cosmoz-tree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neovici/cosmoz-tree/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neovici/cosmoz-tree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neovici/cosmoz-tree/statuses/{sha}","languages_url":"https://api.github.com/repos/Neovici/cosmoz-tree/languages","stargazers_url":"https://api.github.com/repos/Neovici/cosmoz-tree/stargazers","contributors_url":"https://api.github.com/repos/Neovici/cosmoz-tree/contributors","subscribers_url":"https://api.github.com/repos/Neovici/cosmoz-tree/subscribers","subscription_url":"https://api.github.com/repos/Neovici/cosmoz-tree/subscription","commits_url":"https://api.github.com/repos/Neovici/cosmoz-tree/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neovici/cosmoz-tree/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neovici/cosmoz-tree/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neovici/cosmoz-tree/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neovici/cosmoz-tree/contents/{+path}","compare_url":"https://api.github.com/repos/Neovici/cosmoz-tree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neovici/cosmoz-tree/merges","archive_url":"https://api.github.com/repos/Neovici/cosmoz-tree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neovici/cosmoz-tree/downloads","issues_url":"https://api.github.com/repos/Neovici/cosmoz-tree/issues{/number}","pulls_url":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls{/number}","milestones_url":"https://api.github.com/repos/Neovici/cosmoz-tree/milestones{/number}","notifications_url":"https://api.github.com/repos/Neovici/cosmoz-tree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neovici/cosmoz-tree/labels{/name}","releases_url":"https://api.github.com/repos/Neovici/cosmoz-tree/releases{/id}","deployments_url":"https://api.github.com/repos/Neovici/cosmoz-tree/deployments","created_at":"2017-04-26T09:30:24Z","updated_at":"2017-04-26T09:32:55Z","pushed_at":"2017-07-29T14:19:32Z","git_url":"git://github.com/Neovici/cosmoz-tree.git","ssh_url":"git@github.com:Neovici/cosmoz-tree.git","clone_url":"https://github.com/Neovici/cosmoz-tree.git","svn_url":"https://github.com/Neovici/cosmoz-tree","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1"},"html":{"href":"https://github.com/Neovici/cosmoz-tree/pull/1"},"issue":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/issues/1"},"comments":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Neovici/cosmoz-tree/statuses/d8e9ffdb2ddb32daab4e5ed844f1062dd497ef35"}}}}
{"actor":{"display_login":"JaySunSyn"}}