{"action":"created","comment":{"url":"https://api.github.com/repos/Rajawali/Rajawali/pulls/comments/143897338","pull_request_review_id":68476091,"id":143897338,"diff_hunk":"@@ -1,30 +1,35 @@\n package c.org.rajawali3d.surface.gles;\n \n+import c.org.rajawali3d.control.CoreControl;\n+import c.org.rajawali3d.control.RenderContextType;\n+import c.org.rajawali3d.control.RenderControlClient;\n+import c.org.rajawali3d.control.RenderSurfaceView;\n+import c.org.rajawali3d.control.gles.GlesRenderControl;\n+import c.org.rajawali3d.gl.Capabilities;\n+import c.org.rajawali3d.surface.SurfaceRenderer;\n+\n import android.content.Context;\n import android.opengl.GLES20;\n-import c.org.rajawali3d.core.ARenderControl;\n-import c.org.rajawali3d.core.RenderContextType;\n-import c.org.rajawali3d.core.RenderControlClient;\n-import c.org.rajawali3d.core.RenderSurfaceView;\n-import c.org.rajawali3d.gl.Capabilities;\n+\n import org.rajawali3d.util.RajLog;\n \n import java.util.Locale;\n \n /**\n- * Shared implementation for GL ES extensions of {@link ARenderControl}\n+ * Shared implementation for GLES {@link SurfaceRenderer} extensions of {@link CoreControl}\n  *\n  * @author Randy Picolet\n  */\n-abstract class GLESRenderer extends ARenderControl {\n \n-    GLESRenderer(Context context, RenderSurfaceView renderSurfaceView,\n-                 RenderControlClient renderControlClient, double initialFrameRate) {\n+abstract class BaseGlesSurfaceRenderer extends CoreControl implements GlesRenderControl {\n+\n+    BaseGlesSurfaceRenderer(Context context, RenderSurfaceView renderSurfaceView,\n+                            RenderControlClient renderControlClient, double initialFrameRate) {\n         super(context, renderSurfaceView, renderControlClient, initialFrameRate);\n     }\n \n     /**\n-     * Callback to notify that the EGL context has been acquired and a valid GL thread with EGL surface now exists.\n+     *\n      */\n     protected void onRenderContextAcquired() {","path":"core/src/main/java/c/org/rajawali3d/surface/gles/BaseGlesSurfaceRenderer.java","position":44,"original_position":44,"commit_id":"3a16dab2127ab96255ca3e04166cdc0d921e5fe7","original_commit_id":"3a16dab2127ab96255ca3e04166cdc0d921e5fe7","user":{"login":"jwoolston","id":2993125,"avatar_url":"https://avatars3.githubusercontent.com/u/2993125?v=4","gravatar_id":"","url":"https://api.github.com/users/jwoolston","html_url":"https://github.com/jwoolston","followers_url":"https://api.github.com/users/jwoolston/followers","following_url":"https://api.github.com/users/jwoolston/following{/other_user}","gists_url":"https://api.github.com/users/jwoolston/gists{/gist_id}","starred_url":"https://api.github.com/users/jwoolston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwoolston/subscriptions","organizations_url":"https://api.github.com/users/jwoolston/orgs","repos_url":"https://api.github.com/users/jwoolston/repos","events_url":"https://api.github.com/users/jwoolston/events{/privacy}","received_events_url":"https://api.github.com/users/jwoolston/received_events","type":"User","site_admin":false},"body":"Then I would argue one of them needs a different name.","created_at":"2017-10-11T02:11:04Z","updated_at":"2017-10-11T02:11:04Z","html_url":"https://github.com/Rajawali/Rajawali/pull/1995#discussion_r143897338","pull_request_url":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Rajawali/Rajawali/pulls/comments/143897338"},"html":{"href":"https://github.com/Rajawali/Rajawali/pull/1995#discussion_r143897338"},"pull_request":{"href":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995"}},"in_reply_to_id":143846669},"pull_request":{"url":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995","id":145443583,"html_url":"https://github.com/Rajawali/Rajawali/pull/1995","diff_url":"https://github.com/Rajawali/Rajawali/pull/1995.diff","patch_url":"https://github.com/Rajawali/Rajawali/pull/1995.patch","issue_url":"https://api.github.com/repos/Rajawali/Rajawali/issues/1995","number":1995,"state":"open","locked":false,"title":"V2.0 core dev","user":{"login":"rpicolet","id":616858,"avatar_url":"https://avatars1.githubusercontent.com/u/616858?v=4","gravatar_id":"","url":"https://api.github.com/users/rpicolet","html_url":"https://github.com/rpicolet","followers_url":"https://api.github.com/users/rpicolet/followers","following_url":"https://api.github.com/users/rpicolet/following{/other_user}","gists_url":"https://api.github.com/users/rpicolet/gists{/gist_id}","starred_url":"https://api.github.com/users/rpicolet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpicolet/subscriptions","organizations_url":"https://api.github.com/users/rpicolet/orgs","repos_url":"https://api.github.com/users/rpicolet/repos","events_url":"https://api.github.com/users/rpicolet/events{/privacy}","received_events_url":"https://api.github.com/users/rpicolet/received_events","type":"User","site_admin":false},"body":"WIP for render control architecture and logging/debugging utiliies","created_at":"2017-10-09T12:45:11Z","updated_at":"2017-10-11T02:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f7e6b1985f16440f1da46c1b6f3a99ae0b89c0c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995/commits","review_comments_url":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995/comments","review_comment_url":"https://api.github.com/repos/Rajawali/Rajawali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rajawali/Rajawali/issues/1995/comments","statuses_url":"https://api.github.com/repos/Rajawali/Rajawali/statuses/3a16dab2127ab96255ca3e04166cdc0d921e5fe7","head":{"label":"rpicolet:v2.0-core-dev","ref":"v2.0-core-dev","sha":"3a16dab2127ab96255ca3e04166cdc0d921e5fe7","user":{"login":"rpicolet","id":616858,"avatar_url":"https://avatars1.githubusercontent.com/u/616858?v=4","gravatar_id":"","url":"https://api.github.com/users/rpicolet","html_url":"https://github.com/rpicolet","followers_url":"https://api.github.com/users/rpicolet/followers","following_url":"https://api.github.com/users/rpicolet/following{/other_user}","gists_url":"https://api.github.com/users/rpicolet/gists{/gist_id}","starred_url":"https://api.github.com/users/rpicolet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpicolet/subscriptions","organizations_url":"https://api.github.com/users/rpicolet/orgs","repos_url":"https://api.github.com/users/rpicolet/repos","events_url":"https://api.github.com/users/rpicolet/events{/privacy}","received_events_url":"https://api.github.com/users/rpicolet/received_events","type":"User","site_admin":false},"repo":{"id":53214723,"name":"Rajawali","full_name":"rpicolet/Rajawali","owner":{"login":"rpicolet","id":616858,"avatar_url":"https://avatars1.githubusercontent.com/u/616858?v=4","gravatar_id":"","url":"https://api.github.com/users/rpicolet","html_url":"https://github.com/rpicolet","followers_url":"https://api.github.com/users/rpicolet/followers","following_url":"https://api.github.com/users/rpicolet/following{/other_user}","gists_url":"https://api.github.com/users/rpicolet/gists{/gist_id}","starred_url":"https://api.github.com/users/rpicolet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpicolet/subscriptions","organizations_url":"https://api.github.com/users/rpicolet/orgs","repos_url":"https://api.github.com/users/rpicolet/repos","events_url":"https://api.github.com/users/rpicolet/events{/privacy}","received_events_url":"https://api.github.com/users/rpicolet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpicolet/Rajawali","description":"Android OpenGL ES 2.0/3.0 Engine","fork":true,"url":"https://api.github.com/repos/rpicolet/Rajawali","forks_url":"https://api.github.com/repos/rpicolet/Rajawali/forks","keys_url":"https://api.github.com/repos/rpicolet/Rajawali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpicolet/Rajawali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpicolet/Rajawali/teams","hooks_url":"https://api.github.com/repos/rpicolet/Rajawali/hooks","issue_events_url":"https://api.github.com/repos/rpicolet/Rajawali/issues/events{/number}","events_url":"https://api.github.com/repos/rpicolet/Rajawali/events","assignees_url":"https://api.github.com/repos/rpicolet/Rajawali/assignees{/user}","branches_url":"https://api.github.com/repos/rpicolet/Rajawali/branches{/branch}","tags_url":"https://api.github.com/repos/rpicolet/Rajawali/tags","blobs_url":"https://api.github.com/repos/rpicolet/Rajawali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpicolet/Rajawali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpicolet/Rajawali/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpicolet/Rajawali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpicolet/Rajawali/statuses/{sha}","languages_url":"https://api.github.com/repos/rpicolet/Rajawali/languages","stargazers_url":"https://api.github.com/repos/rpicolet/Rajawali/stargazers","contributors_url":"https://api.github.com/repos/rpicolet/Rajawali/contributors","subscribers_url":"https://api.github.com/repos/rpicolet/Rajawali/subscribers","subscription_url":"https://api.github.com/repos/rpicolet/Rajawali/subscription","commits_url":"https://api.github.com/repos/rpicolet/Rajawali/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpicolet/Rajawali/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpicolet/Rajawali/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpicolet/Rajawali/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpicolet/Rajawali/contents/{+path}","compare_url":"https://api.github.com/repos/rpicolet/Rajawali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpicolet/Rajawali/merges","archive_url":"https://api.github.com/repos/rpicolet/Rajawali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpicolet/Rajawali/downloads","issues_url":"https://api.github.com/repos/rpicolet/Rajawali/issues{/number}","pulls_url":"https://api.github.com/repos/rpicolet/Rajawali/pulls{/number}","milestones_url":"https://api.github.com/repos/rpicolet/Rajawali/milestones{/number}","notifications_url":"https://api.github.com/repos/rpicolet/Rajawali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpicolet/Rajawali/labels{/name}","releases_url":"https://api.github.com/repos/rpicolet/Rajawali/releases{/id}","deployments_url":"https://api.github.com/repos/rpicolet/Rajawali/deployments","created_at":"2016-03-05T17:49:32Z","updated_at":"2016-03-05T17:49:34Z","pushed_at":"2017-10-09T12:43:23Z","git_url":"git://github.com/rpicolet/Rajawali.git","ssh_url":"git@github.com:rpicolet/Rajawali.git","clone_url":"https://github.com/rpicolet/Rajawali.git","svn_url":"https://github.com/rpicolet/Rajawali","homepage":"https://plus.google.com/u/0/communities/116529974266844528013","size":48099,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Rajawali:v2.0-development","ref":"v2.0-development","sha":"a3cdde2b168727745d43f48919a9e942fa160db3","user":{"login":"Rajawali","id":3820125,"avatar_url":"https://avatars3.githubusercontent.com/u/3820125?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajawali","html_url":"https://github.com/Rajawali","followers_url":"https://api.github.com/users/Rajawali/followers","following_url":"https://api.github.com/users/Rajawali/following{/other_user}","gists_url":"https://api.github.com/users/Rajawali/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajawali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajawali/subscriptions","organizations_url":"https://api.github.com/users/Rajawali/orgs","repos_url":"https://api.github.com/users/Rajawali/repos","events_url":"https://api.github.com/users/Rajawali/events{/privacy}","received_events_url":"https://api.github.com/users/Rajawali/received_events","type":"Organization","site_admin":false},"repo":{"id":2011647,"name":"Rajawali","full_name":"Rajawali/Rajawali","owner":{"login":"Rajawali","id":3820125,"avatar_url":"https://avatars3.githubusercontent.com/u/3820125?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajawali","html_url":"https://github.com/Rajawali","followers_url":"https://api.github.com/users/Rajawali/followers","following_url":"https://api.github.com/users/Rajawali/following{/other_user}","gists_url":"https://api.github.com/users/Rajawali/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajawali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajawali/subscriptions","organizations_url":"https://api.github.com/users/Rajawali/orgs","repos_url":"https://api.github.com/users/Rajawali/repos","events_url":"https://api.github.com/users/Rajawali/events{/privacy}","received_events_url":"https://api.github.com/users/Rajawali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rajawali/Rajawali","description":"Android OpenGL ES 2.0/3.0 Engine","fork":false,"url":"https://api.github.com/repos/Rajawali/Rajawali","forks_url":"https://api.github.com/repos/Rajawali/Rajawali/forks","keys_url":"https://api.github.com/repos/Rajawali/Rajawali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rajawali/Rajawali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rajawali/Rajawali/teams","hooks_url":"https://api.github.com/repos/Rajawali/Rajawali/hooks","issue_events_url":"https://api.github.com/repos/Rajawali/Rajawali/issues/events{/number}","events_url":"https://api.github.com/repos/Rajawali/Rajawali/events","assignees_url":"https://api.github.com/repos/Rajawali/Rajawali/assignees{/user}","branches_url":"https://api.github.com/repos/Rajawali/Rajawali/branches{/branch}","tags_url":"https://api.github.com/repos/Rajawali/Rajawali/tags","blobs_url":"https://api.github.com/repos/Rajawali/Rajawali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rajawali/Rajawali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rajawali/Rajawali/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rajawali/Rajawali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rajawali/Rajawali/statuses/{sha}","languages_url":"https://api.github.com/repos/Rajawali/Rajawali/languages","stargazers_url":"https://api.github.com/repos/Rajawali/Rajawali/stargazers","contributors_url":"https://api.github.com/repos/Rajawali/Rajawali/contributors","subscribers_url":"https://api.github.com/repos/Rajawali/Rajawali/subscribers","subscription_url":"https://api.github.com/repos/Rajawali/Rajawali/subscription","commits_url":"https://api.github.com/repos/Rajawali/Rajawali/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rajawali/Rajawali/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rajawali/Rajawali/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rajawali/Rajawali/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rajawali/Rajawali/contents/{+path}","compare_url":"https://api.github.com/repos/Rajawali/Rajawali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rajawali/Rajawali/merges","archive_url":"https://api.github.com/repos/Rajawali/Rajawali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rajawali/Rajawali/downloads","issues_url":"https://api.github.com/repos/Rajawali/Rajawali/issues{/number}","pulls_url":"https://api.github.com/repos/Rajawali/Rajawali/pulls{/number}","milestones_url":"https://api.github.com/repos/Rajawali/Rajawali/milestones{/number}","notifications_url":"https://api.github.com/repos/Rajawali/Rajawali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rajawali/Rajawali/labels{/name}","releases_url":"https://api.github.com/repos/Rajawali/Rajawali/releases{/id}","deployments_url":"https://api.github.com/repos/Rajawali/Rajawali/deployments","created_at":"2011-07-07T10:29:45Z","updated_at":"2017-10-10T16:16:12Z","pushed_at":"2017-10-10T13:16:03Z","git_url":"git://github.com/Rajawali/Rajawali.git","ssh_url":"git@github.com:Rajawali/Rajawali.git","clone_url":"https://github.com/Rajawali/Rajawali.git","svn_url":"https://github.com/Rajawali/Rajawali","homepage":"https://plus.google.com/u/0/communities/116529974266844528013","size":47724,"stargazers_count":1526,"watchers_count":1526,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":587,"mirror_url":null,"open_issues_count":119,"forks":587,"open_issues":119,"watchers":1526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995"},"html":{"href":"https://github.com/Rajawali/Rajawali/pull/1995"},"issue":{"href":"https://api.github.com/repos/Rajawali/Rajawali/issues/1995"},"comments":{"href":"https://api.github.com/repos/Rajawali/Rajawali/issues/1995/comments"},"review_comments":{"href":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995/comments"},"review_comment":{"href":"https://api.github.com/repos/Rajawali/Rajawali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rajawali/Rajawali/pulls/1995/commits"},"statuses":{"href":"https://api.github.com/repos/Rajawali/Rajawali/statuses/3a16dab2127ab96255ca3e04166cdc0d921e5fe7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jwoolston"}}