{"action":"created","comment":{"url":"https://api.github.com/repos/heketi/heketi/pulls/comments/107826340","pull_request_review_id":28821203,"id":107826340,"diff_hunk":"@@ -56,8 +58,47 @@ var (\n \t}\n )\n \n+func setWithEnvVariables(config *SshConfig) {\n+\tvar env string\n+\n+\t// Ssh Private Key File Path\n+\tenv = os.Getenv(\"HEKETI_SSH_KEYFILE\")\n+\tif \"\" != env {\n+\t\tconfig.PrivateKeyFile = env\n+\t}\n+\n+\t// Ssh User\n+\tenv = os.Getenv(\"HEKETI_SSH_USER\")\n+\tif \"\" != env {\n+\t\tconfig.User = env\n+\t}\n+\n+\t// Ssh Port\n+\tenv = os.Getenv(\"HEKETI_SSH_PORT\")\n+\tif \"\" != env {\n+\t\tconfig.Port = env\n+\t}\n+\n+\t// FSTAB","path":"executors/sshexec/sshexec.go","position":34,"original_position":34,"commit_id":"0130b210b18284a0c1ca6b633860e44b3e5e0011","original_commit_id":"0130b210b18284a0c1ca6b633860e44b3e5e0011","user":{"login":"obnoxxx","id":8081179,"avatar_url":"https://avatars2.githubusercontent.com/u/8081179?v=3","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"body":"redundant","created_at":"2017-03-24T02:51:00Z","updated_at":"2017-03-24T02:52:40Z","html_url":"https://github.com/heketi/heketi/pull/724#discussion_r107826340","pull_request_url":"https://api.github.com/repos/heketi/heketi/pulls/724","_links":{"self":{"href":"https://api.github.com/repos/heketi/heketi/pulls/comments/107826340"},"html":{"href":"https://github.com/heketi/heketi/pull/724#discussion_r107826340"},"pull_request":{"href":"https://api.github.com/repos/heketi/heketi/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/heketi/heketi/pulls/724","id":111999586,"html_url":"https://github.com/heketi/heketi/pull/724","diff_url":"https://github.com/heketi/heketi/pull/724.diff","patch_url":"https://github.com/heketi/heketi/pull/724.patch","issue_url":"https://api.github.com/repos/heketi/heketi/issues/724","number":724,"state":"open","locked":false,"title":"sshexec: Environmental variable support for config","user":{"login":"MohamedAshiqrh","id":11404465,"avatar_url":"https://avatars2.githubusercontent.com/u/11404465?v=3","gravatar_id":"","url":"https://api.github.com/users/MohamedAshiqrh","html_url":"https://github.com/MohamedAshiqrh","followers_url":"https://api.github.com/users/MohamedAshiqrh/followers","following_url":"https://api.github.com/users/MohamedAshiqrh/following{/other_user}","gists_url":"https://api.github.com/users/MohamedAshiqrh/gists{/gist_id}","starred_url":"https://api.github.com/users/MohamedAshiqrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MohamedAshiqrh/subscriptions","organizations_url":"https://api.github.com/users/MohamedAshiqrh/orgs","repos_url":"https://api.github.com/users/MohamedAshiqrh/repos","events_url":"https://api.github.com/users/MohamedAshiqrh/events{/privacy}","received_events_url":"https://api.github.com/users/MohamedAshiqrh/received_events","type":"User","site_admin":false},"body":"sshexec config values to support environmental variable inputs.\r\nWe have the same for Kubeexec. This patch will enable to same for sshexec. \r\n\r\nSigned-off-by: Mohamed Ashiq Liyazudeen <mliyazud@redhat.com>","created_at":"2017-03-22T12:43:26Z","updated_at":"2017-03-24T02:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eea3532ae25fa12fb4cc2472d10c2743f3e4c68a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/heketi/heketi/pulls/724/commits","review_comments_url":"https://api.github.com/repos/heketi/heketi/pulls/724/comments","review_comment_url":"https://api.github.com/repos/heketi/heketi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heketi/heketi/issues/724/comments","statuses_url":"https://api.github.com/repos/heketi/heketi/statuses/0130b210b18284a0c1ca6b633860e44b3e5e0011","head":{"label":"MohamedAshiqrh:sshconfig","ref":"sshconfig","sha":"0130b210b18284a0c1ca6b633860e44b3e5e0011","user":{"login":"MohamedAshiqrh","id":11404465,"avatar_url":"https://avatars2.githubusercontent.com/u/11404465?v=3","gravatar_id":"","url":"https://api.github.com/users/MohamedAshiqrh","html_url":"https://github.com/MohamedAshiqrh","followers_url":"https://api.github.com/users/MohamedAshiqrh/followers","following_url":"https://api.github.com/users/MohamedAshiqrh/following{/other_user}","gists_url":"https://api.github.com/users/MohamedAshiqrh/gists{/gist_id}","starred_url":"https://api.github.com/users/MohamedAshiqrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MohamedAshiqrh/subscriptions","organizations_url":"https://api.github.com/users/MohamedAshiqrh/orgs","repos_url":"https://api.github.com/users/MohamedAshiqrh/repos","events_url":"https://api.github.com/users/MohamedAshiqrh/events{/privacy}","received_events_url":"https://api.github.com/users/MohamedAshiqrh/received_events","type":"User","site_admin":false},"repo":{"id":55206914,"name":"heketi","full_name":"MohamedAshiqrh/heketi","owner":{"login":"MohamedAshiqrh","id":11404465,"avatar_url":"https://avatars2.githubusercontent.com/u/11404465?v=3","gravatar_id":"","url":"https://api.github.com/users/MohamedAshiqrh","html_url":"https://github.com/MohamedAshiqrh","followers_url":"https://api.github.com/users/MohamedAshiqrh/followers","following_url":"https://api.github.com/users/MohamedAshiqrh/following{/other_user}","gists_url":"https://api.github.com/users/MohamedAshiqrh/gists{/gist_id}","starred_url":"https://api.github.com/users/MohamedAshiqrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MohamedAshiqrh/subscriptions","organizations_url":"https://api.github.com/users/MohamedAshiqrh/orgs","repos_url":"https://api.github.com/users/MohamedAshiqrh/repos","events_url":"https://api.github.com/users/MohamedAshiqrh/events{/privacy}","received_events_url":"https://api.github.com/users/MohamedAshiqrh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MohamedAshiqrh/heketi","description":"RESTful based volume management framework for GlusterFS","fork":true,"url":"https://api.github.com/repos/MohamedAshiqrh/heketi","forks_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/forks","keys_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/teams","hooks_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/hooks","issue_events_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/issues/events{/number}","events_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/events","assignees_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/assignees{/user}","branches_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/branches{/branch}","tags_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/tags","blobs_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/git/refs{/sha}","trees_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/statuses/{sha}","languages_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/languages","stargazers_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/stargazers","contributors_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/contributors","subscribers_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/subscribers","subscription_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/subscription","commits_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/commits{/sha}","git_commits_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/git/commits{/sha}","comments_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/comments{/number}","issue_comment_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/issues/comments{/number}","contents_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/contents/{+path}","compare_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/merges","archive_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/downloads","issues_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/issues{/number}","pulls_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/pulls{/number}","milestones_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/milestones{/number}","notifications_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/labels{/name}","releases_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/releases{/id}","deployments_url":"https://api.github.com/repos/MohamedAshiqrh/heketi/deployments","created_at":"2016-04-01T05:47:06Z","updated_at":"2016-04-01T05:47:07Z","pushed_at":"2017-03-22T12:41:50Z","git_url":"git://github.com/MohamedAshiqrh/heketi.git","ssh_url":"git@github.com:MohamedAshiqrh/heketi.git","clone_url":"https://github.com/MohamedAshiqrh/heketi.git","svn_url":"https://github.com/MohamedAshiqrh/heketi","homepage":"","size":10413,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"heketi:master","ref":"master","sha":"8e587614d95094c83b7b9e67f89aba9de0f4bd8c","user":{"login":"heketi","id":12890374,"avatar_url":"https://avatars3.githubusercontent.com/u/12890374?v=3","gravatar_id":"","url":"https://api.github.com/users/heketi","html_url":"https://github.com/heketi","followers_url":"https://api.github.com/users/heketi/followers","following_url":"https://api.github.com/users/heketi/following{/other_user}","gists_url":"https://api.github.com/users/heketi/gists{/gist_id}","starred_url":"https://api.github.com/users/heketi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heketi/subscriptions","organizations_url":"https://api.github.com/users/heketi/orgs","repos_url":"https://api.github.com/users/heketi/repos","events_url":"https://api.github.com/users/heketi/events{/privacy}","received_events_url":"https://api.github.com/users/heketi/received_events","type":"Organization","site_admin":false},"repo":{"id":37446835,"name":"heketi","full_name":"heketi/heketi","owner":{"login":"heketi","id":12890374,"avatar_url":"https://avatars3.githubusercontent.com/u/12890374?v=3","gravatar_id":"","url":"https://api.github.com/users/heketi","html_url":"https://github.com/heketi","followers_url":"https://api.github.com/users/heketi/followers","following_url":"https://api.github.com/users/heketi/following{/other_user}","gists_url":"https://api.github.com/users/heketi/gists{/gist_id}","starred_url":"https://api.github.com/users/heketi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heketi/subscriptions","organizations_url":"https://api.github.com/users/heketi/orgs","repos_url":"https://api.github.com/users/heketi/repos","events_url":"https://api.github.com/users/heketi/events{/privacy}","received_events_url":"https://api.github.com/users/heketi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heketi/heketi","description":"RESTful based volume management framework for GlusterFS","fork":false,"url":"https://api.github.com/repos/heketi/heketi","forks_url":"https://api.github.com/repos/heketi/heketi/forks","keys_url":"https://api.github.com/repos/heketi/heketi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heketi/heketi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heketi/heketi/teams","hooks_url":"https://api.github.com/repos/heketi/heketi/hooks","issue_events_url":"https://api.github.com/repos/heketi/heketi/issues/events{/number}","events_url":"https://api.github.com/repos/heketi/heketi/events","assignees_url":"https://api.github.com/repos/heketi/heketi/assignees{/user}","branches_url":"https://api.github.com/repos/heketi/heketi/branches{/branch}","tags_url":"https://api.github.com/repos/heketi/heketi/tags","blobs_url":"https://api.github.com/repos/heketi/heketi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heketi/heketi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heketi/heketi/git/refs{/sha}","trees_url":"https://api.github.com/repos/heketi/heketi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heketi/heketi/statuses/{sha}","languages_url":"https://api.github.com/repos/heketi/heketi/languages","stargazers_url":"https://api.github.com/repos/heketi/heketi/stargazers","contributors_url":"https://api.github.com/repos/heketi/heketi/contributors","subscribers_url":"https://api.github.com/repos/heketi/heketi/subscribers","subscription_url":"https://api.github.com/repos/heketi/heketi/subscription","commits_url":"https://api.github.com/repos/heketi/heketi/commits{/sha}","git_commits_url":"https://api.github.com/repos/heketi/heketi/git/commits{/sha}","comments_url":"https://api.github.com/repos/heketi/heketi/comments{/number}","issue_comment_url":"https://api.github.com/repos/heketi/heketi/issues/comments{/number}","contents_url":"https://api.github.com/repos/heketi/heketi/contents/{+path}","compare_url":"https://api.github.com/repos/heketi/heketi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heketi/heketi/merges","archive_url":"https://api.github.com/repos/heketi/heketi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heketi/heketi/downloads","issues_url":"https://api.github.com/repos/heketi/heketi/issues{/number}","pulls_url":"https://api.github.com/repos/heketi/heketi/pulls{/number}","milestones_url":"https://api.github.com/repos/heketi/heketi/milestones{/number}","notifications_url":"https://api.github.com/repos/heketi/heketi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heketi/heketi/labels{/name}","releases_url":"https://api.github.com/repos/heketi/heketi/releases{/id}","deployments_url":"https://api.github.com/repos/heketi/heketi/deployments","created_at":"2015-06-15T06:10:11Z","updated_at":"2017-03-24T02:43:40Z","pushed_at":"2017-03-23T13:32:50Z","git_url":"git://github.com/heketi/heketi.git","ssh_url":"git@github.com:heketi/heketi.git","clone_url":"https://github.com/heketi/heketi.git","svn_url":"https://github.com/heketi/heketi","homepage":"","size":10369,"stargazers_count":174,"watchers_count":174,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":101,"forks":59,"open_issues":101,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heketi/heketi/pulls/724"},"html":{"href":"https://github.com/heketi/heketi/pull/724"},"issue":{"href":"https://api.github.com/repos/heketi/heketi/issues/724"},"comments":{"href":"https://api.github.com/repos/heketi/heketi/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/heketi/heketi/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/heketi/heketi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heketi/heketi/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/heketi/heketi/statuses/0130b210b18284a0c1ca6b633860e44b3e5e0011"}}}}
{"actor":{"display_login":"obnoxxx"}}