{"action":"created","comment":{"url":"https://api.github.com/repos/dash-project/dash/pulls/comments/133952921","pull_request_review_id":57193991,"id":133952921,"diff_hunk":"@@ -193,19 +215,45 @@ dart_ret_t dart_get(\n                    nelem, (unsigned long)win, team_unit_id.id, offset, dest);\n   }\n \n-\n-  DART_LOG_TRACE(\"dart_get:  MPI_Get\");\n-  if (MPI_Get(dest,\n-              nelem,\n-              mpi_dtype,\n-              team_unit_id.id,\n-              offset,\n-              nelem,\n-              mpi_dtype,\n-              win)\n-      != MPI_SUCCESS) {\n-    DART_LOG_ERROR(\"dart_get ! MPI_Rget failed\");\n-    return DART_ERR_INVAL;\n+  /*\n+   * MPI uses offset type int, do not copy more than INT_MAX elements:\n+   */\n+  // chunk up the get\n+  const size_t nchunks   = nelem / INT_MAX;","path":"dart-impl/mpi/src/dart_communication.c","position":null,"original_position":88,"commit_id":"3af9d81dba7c5fa2ebe0418a5e6e11629921edc7","original_commit_id":"fa880dd3db9fe41e59888b0b0bcab37e2adfaf03","user":{"login":"rkowalewski","id":2558154,"avatar_url":"https://avatars3.githubusercontent.com/u/2558154?v=4","gravatar_id":"","url":"https://api.github.com/users/rkowalewski","html_url":"https://github.com/rkowalewski","followers_url":"https://api.github.com/users/rkowalewski/followers","following_url":"https://api.github.com/users/rkowalewski/following{/other_user}","gists_url":"https://api.github.com/users/rkowalewski/gists{/gist_id}","starred_url":"https://api.github.com/users/rkowalewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkowalewski/subscriptions","organizations_url":"https://api.github.com/users/rkowalewski/orgs","repos_url":"https://api.github.com/users/rkowalewski/repos","events_url":"https://api.github.com/users/rkowalewski/events{/privacy}","received_events_url":"https://api.github.com/users/rkowalewski/received_events","type":"User","site_admin":false},"body":"It has actually arrived in modern age since MPI-3, see the official [Ticket](https://github.com/mpi-forum/mpi-forum-historic/issues/117). The problem are the legacy applications needing backward compatibility.","created_at":"2017-08-18T13:02:04Z","updated_at":"2017-08-18T13:02:04Z","html_url":"https://github.com/dash-project/dash/pull/434#discussion_r133952921","pull_request_url":"https://api.github.com/repos/dash-project/dash/pulls/434","_links":{"self":{"href":"https://api.github.com/repos/dash-project/dash/pulls/comments/133952921"},"html":{"href":"https://github.com/dash-project/dash/pull/434#discussion_r133952921"},"pull_request":{"href":"https://api.github.com/repos/dash-project/dash/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/dash-project/dash/pulls/434","id":135846711,"html_url":"https://github.com/dash-project/dash/pull/434","diff_url":"https://github.com/dash-project/dash/pull/434.diff","patch_url":"https://github.com/dash-project/dash/pull/434.patch","issue_url":"https://api.github.com/repos/dash-project/dash/issues/434","number":434,"state":"open","locked":false,"title":"Chunk up puts/gets to cover large transfers","user":{"login":"devreal","id":10974502,"avatar_url":"https://avatars1.githubusercontent.com/u/10974502?v=4","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false},"body":"Chunk up puts/gets in `dart_put`, `dart_put_blocking`, `dart_get`, and `dart_get_blocking`.\r\n\r\nThis change is required because MPI does not expect users to copy more than 2GB of data.\r\n\r\nThis PR is incomplete as `dart_put_handle` and `dart_get_handle` are not covered. There is a host of changes to the way handles are handled in DART waiting for review in #419 so this would only create unnecessary conflicts. I will adjust them accordingly as soon as #419 is merged.\r\n\r\nThis PR does not include a test case because such large allocations won't work on small systems and thus render the test suite unusable.\r\n\r\n@BenjaProg Your test case should be covered, IIRC the problem for you was in `dart_get_blocking`. Please test whether this works now.\r\n\r\nRelated to #432.","created_at":"2017-08-15T17:11:52Z","updated_at":"2017-08-18T13:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0852a721abeae39b203c1b60a868d2e7ae22ea05","assignee":{"login":"devreal","id":10974502,"avatar_url":"https://avatars1.githubusercontent.com/u/10974502?v=4","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false},"assignees":[{"login":"devreal","id":10974502,"avatar_url":"https://avatars1.githubusercontent.com/u/10974502?v=4","gravatar_id":"","url":"https://api.github.com/users/devreal","html_url":"https://github.com/devreal","followers_url":"https://api.github.com/users/devreal/followers","following_url":"https://api.github.com/users/devreal/following{/other_user}","gists_url":"https://api.github.com/users/devreal/gists{/gist_id}","starred_url":"https://api.github.com/users/devreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devreal/subscriptions","organizations_url":"https://api.github.com/users/devreal/orgs","repos_url":"https://api.github.com/users/devreal/repos","events_url":"https://api.github.com/users/devreal/events{/privacy}","received_events_url":"https://api.github.com/users/devreal/received_events","type":"User","site_admin":false},{"login":"BenjaProg","id":20214726,"avatar_url":"https://avatars2.githubusercontent.com/u/20214726?v=4","gravatar_id":"","url":"https://api.github.com/users/BenjaProg","html_url":"https://github.com/BenjaProg","followers_url":"https://api.github.com/users/BenjaProg/followers","following_url":"https://api.github.com/users/BenjaProg/following{/other_user}","gists_url":"https://api.github.com/users/BenjaProg/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaProg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaProg/subscriptions","organizations_url":"https://api.github.com/users/BenjaProg/orgs","repos_url":"https://api.github.com/users/BenjaProg/repos","events_url":"https://api.github.com/users/BenjaProg/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaProg/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fuchsto","id":37075,"avatar_url":"https://avatars2.githubusercontent.com/u/37075?v=4","gravatar_id":"","url":"https://api.github.com/users/fuchsto","html_url":"https://github.com/fuchsto","followers_url":"https://api.github.com/users/fuchsto/followers","following_url":"https://api.github.com/users/fuchsto/following{/other_user}","gists_url":"https://api.github.com/users/fuchsto/gists{/gist_id}","starred_url":"https://api.github.com/users/fuchsto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuchsto/subscriptions","organizations_url":"https://api.github.com/users/fuchsto/orgs","repos_url":"https://api.github.com/users/fuchsto/repos","events_url":"https://api.github.com/users/fuchsto/events{/privacy}","received_events_url":"https://api.github.com/users/fuchsto/received_events","type":"User","site_admin":false},{"login":"fmoessbauer","id":9655545,"avatar_url":"https://avatars3.githubusercontent.com/u/9655545?v=4","gravatar_id":"","url":"https://api.github.com/users/fmoessbauer","html_url":"https://github.com/fmoessbauer","followers_url":"https://api.github.com/users/fmoessbauer/followers","following_url":"https://api.github.com/users/fmoessbauer/following{/other_user}","gists_url":"https://api.github.com/users/fmoessbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/fmoessbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmoessbauer/subscriptions","organizations_url":"https://api.github.com/users/fmoessbauer/orgs","repos_url":"https://api.github.com/users/fmoessbauer/repos","events_url":"https://api.github.com/users/fmoessbauer/events{/privacy}","received_events_url":"https://api.github.com/users/fmoessbauer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dash-project/dash/milestones/1","html_url":"https://github.com/dash-project/dash/milestone/1","labels_url":"https://api.github.com/repos/dash-project/dash/milestones/1/labels","id":2066410,"number":1,"title":"dash-0.3.0","description":null,"creator":{"login":"fuchsto","id":37075,"avatar_url":"https://avatars2.githubusercontent.com/u/37075?v=4","gravatar_id":"","url":"https://api.github.com/users/fuchsto","html_url":"https://github.com/fuchsto","followers_url":"https://api.github.com/users/fuchsto/followers","following_url":"https://api.github.com/users/fuchsto/following{/other_user}","gists_url":"https://api.github.com/users/fuchsto/gists{/gist_id}","starred_url":"https://api.github.com/users/fuchsto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuchsto/subscriptions","organizations_url":"https://api.github.com/users/fuchsto/orgs","repos_url":"https://api.github.com/users/fuchsto/repos","events_url":"https://api.github.com/users/fuchsto/events{/privacy}","received_events_url":"https://api.github.com/users/fuchsto/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":162,"state":"open","created_at":"2016-10-12T22:19:16Z","updated_at":"2017-08-15T17:11:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dash-project/dash/pulls/434/commits","review_comments_url":"https://api.github.com/repos/dash-project/dash/pulls/434/comments","review_comment_url":"https://api.github.com/repos/dash-project/dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dash-project/dash/issues/434/comments","statuses_url":"https://api.github.com/repos/dash-project/dash/statuses/3af9d81dba7c5fa2ebe0418a5e6e11629921edc7","head":{"label":"dash-project:bug-432-largecopy","ref":"bug-432-largecopy","sha":"3af9d81dba7c5fa2ebe0418a5e6e11629921edc7","user":{"login":"dash-project","id":14168660,"avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"repo":{"id":45930061,"name":"dash","full_name":"dash-project/dash","owner":{"login":"dash-project","id":14168660,"avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dash-project/dash","description":"DASH, the C++ Template Library for Distributed Data Structures with Support for Hierarchical Locality for HPC and Data-Driven Science","fork":false,"url":"https://api.github.com/repos/dash-project/dash","forks_url":"https://api.github.com/repos/dash-project/dash/forks","keys_url":"https://api.github.com/repos/dash-project/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dash-project/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dash-project/dash/teams","hooks_url":"https://api.github.com/repos/dash-project/dash/hooks","issue_events_url":"https://api.github.com/repos/dash-project/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dash-project/dash/events","assignees_url":"https://api.github.com/repos/dash-project/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dash-project/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dash-project/dash/tags","blobs_url":"https://api.github.com/repos/dash-project/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dash-project/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dash-project/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dash-project/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dash-project/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dash-project/dash/languages","stargazers_url":"https://api.github.com/repos/dash-project/dash/stargazers","contributors_url":"https://api.github.com/repos/dash-project/dash/contributors","subscribers_url":"https://api.github.com/repos/dash-project/dash/subscribers","subscription_url":"https://api.github.com/repos/dash-project/dash/subscription","commits_url":"https://api.github.com/repos/dash-project/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dash-project/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dash-project/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dash-project/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dash-project/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dash-project/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dash-project/dash/merges","archive_url":"https://api.github.com/repos/dash-project/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dash-project/dash/downloads","issues_url":"https://api.github.com/repos/dash-project/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dash-project/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dash-project/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dash-project/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dash-project/dash/labels{/name}","releases_url":"https://api.github.com/repos/dash-project/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dash-project/dash/deployments","created_at":"2015-11-10T17:56:37Z","updated_at":"2017-08-13T06:54:07Z","pushed_at":"2017-08-17T09:27:39Z","git_url":"git://github.com/dash-project/dash.git","ssh_url":"git@github.com:dash-project/dash.git","clone_url":"https://github.com/dash-project/dash.git","svn_url":"https://github.com/dash-project/dash","homepage":"http://www.dash-project.org/","size":10674,"stargazers_count":36,"watchers_count":36,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":68,"forks":15,"open_issues":68,"watchers":36,"default_branch":"development"}},"base":{"label":"dash-project:development","ref":"development","sha":"8627bbfb08477bbac288f61ac7530ec31fc22cf2","user":{"login":"dash-project","id":14168660,"avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"repo":{"id":45930061,"name":"dash","full_name":"dash-project/dash","owner":{"login":"dash-project","id":14168660,"avatar_url":"https://avatars3.githubusercontent.com/u/14168660?v=4","gravatar_id":"","url":"https://api.github.com/users/dash-project","html_url":"https://github.com/dash-project","followers_url":"https://api.github.com/users/dash-project/followers","following_url":"https://api.github.com/users/dash-project/following{/other_user}","gists_url":"https://api.github.com/users/dash-project/gists{/gist_id}","starred_url":"https://api.github.com/users/dash-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dash-project/subscriptions","organizations_url":"https://api.github.com/users/dash-project/orgs","repos_url":"https://api.github.com/users/dash-project/repos","events_url":"https://api.github.com/users/dash-project/events{/privacy}","received_events_url":"https://api.github.com/users/dash-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dash-project/dash","description":"DASH, the C++ Template Library for Distributed Data Structures with Support for Hierarchical Locality for HPC and Data-Driven Science","fork":false,"url":"https://api.github.com/repos/dash-project/dash","forks_url":"https://api.github.com/repos/dash-project/dash/forks","keys_url":"https://api.github.com/repos/dash-project/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dash-project/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dash-project/dash/teams","hooks_url":"https://api.github.com/repos/dash-project/dash/hooks","issue_events_url":"https://api.github.com/repos/dash-project/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dash-project/dash/events","assignees_url":"https://api.github.com/repos/dash-project/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dash-project/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dash-project/dash/tags","blobs_url":"https://api.github.com/repos/dash-project/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dash-project/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dash-project/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dash-project/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dash-project/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dash-project/dash/languages","stargazers_url":"https://api.github.com/repos/dash-project/dash/stargazers","contributors_url":"https://api.github.com/repos/dash-project/dash/contributors","subscribers_url":"https://api.github.com/repos/dash-project/dash/subscribers","subscription_url":"https://api.github.com/repos/dash-project/dash/subscription","commits_url":"https://api.github.com/repos/dash-project/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dash-project/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dash-project/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dash-project/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dash-project/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dash-project/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dash-project/dash/merges","archive_url":"https://api.github.com/repos/dash-project/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dash-project/dash/downloads","issues_url":"https://api.github.com/repos/dash-project/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dash-project/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dash-project/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dash-project/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dash-project/dash/labels{/name}","releases_url":"https://api.github.com/repos/dash-project/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dash-project/dash/deployments","created_at":"2015-11-10T17:56:37Z","updated_at":"2017-08-13T06:54:07Z","pushed_at":"2017-08-17T09:27:39Z","git_url":"git://github.com/dash-project/dash.git","ssh_url":"git@github.com:dash-project/dash.git","clone_url":"https://github.com/dash-project/dash.git","svn_url":"https://github.com/dash-project/dash","homepage":"http://www.dash-project.org/","size":10674,"stargazers_count":36,"watchers_count":36,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":68,"forks":15,"open_issues":68,"watchers":36,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/dash-project/dash/pulls/434"},"html":{"href":"https://github.com/dash-project/dash/pull/434"},"issue":{"href":"https://api.github.com/repos/dash-project/dash/issues/434"},"comments":{"href":"https://api.github.com/repos/dash-project/dash/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/dash-project/dash/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/dash-project/dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dash-project/dash/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/dash-project/dash/statuses/3af9d81dba7c5fa2ebe0418a5e6e11629921edc7"}}}}
{"actor":{"display_login":"rkowalewski"}}