{"action":"closed","number":5118,"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5118","id":148815427,"html_url":"https://github.com/minio/minio/pull/5118","diff_url":"https://github.com/minio/minio/pull/5118.diff","patch_url":"https://github.com/minio/minio/pull/5118.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/5118","number":5118,"state":"closed","locked":false,"title":"\"0\" offset is ignored in  GetObject method in Azure Gateway code","user":{"login":"kannappanr","id":30541348,"avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"body":"## Description\r\nIn GetObject method, Check if startoffset is a non-negative value.\r\nIgnore check for startOffset > and check for only length > 0.\r\n\r\nFixes minio/mint#191\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\nRan functional tests for minio-js against Minio server and Azure S3, and GCS gateways.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.","created_at":"2017-10-26T00:59:41Z","updated_at":"2017-10-27T01:01:47Z","closed_at":"2017-10-27T01:01:47Z","merged_at":"2017-10-27T01:01:47Z","merge_commit_sha":"a011fe84503b2af9d4ba637441adc4c9a95fa787","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/5118/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/5118/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/5118/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/9c1d70f9a61f3cba274d3ec0bd1a816531485991","head":{"label":"kannappanr:azure_related_fix","ref":"azure_related_fix","sha":"9c1d70f9a61f3cba274d3ec0bd1a816531485991","user":{"login":"kannappanr","id":30541348,"avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"repo":{"id":100306434,"name":"minio","full_name":"kannappanr/minio","owner":{"login":"kannappanr","id":30541348,"avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kannappanr/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/kannappanr/minio","forks_url":"https://api.github.com/repos/kannappanr/minio/forks","keys_url":"https://api.github.com/repos/kannappanr/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kannappanr/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kannappanr/minio/teams","hooks_url":"https://api.github.com/repos/kannappanr/minio/hooks","issue_events_url":"https://api.github.com/repos/kannappanr/minio/issues/events{/number}","events_url":"https://api.github.com/repos/kannappanr/minio/events","assignees_url":"https://api.github.com/repos/kannappanr/minio/assignees{/user}","branches_url":"https://api.github.com/repos/kannappanr/minio/branches{/branch}","tags_url":"https://api.github.com/repos/kannappanr/minio/tags","blobs_url":"https://api.github.com/repos/kannappanr/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kannappanr/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kannappanr/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/kannappanr/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kannappanr/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/kannappanr/minio/languages","stargazers_url":"https://api.github.com/repos/kannappanr/minio/stargazers","contributors_url":"https://api.github.com/repos/kannappanr/minio/contributors","subscribers_url":"https://api.github.com/repos/kannappanr/minio/subscribers","subscription_url":"https://api.github.com/repos/kannappanr/minio/subscription","commits_url":"https://api.github.com/repos/kannappanr/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/kannappanr/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/kannappanr/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/kannappanr/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/kannappanr/minio/contents/{+path}","compare_url":"https://api.github.com/repos/kannappanr/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kannappanr/minio/merges","archive_url":"https://api.github.com/repos/kannappanr/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kannappanr/minio/downloads","issues_url":"https://api.github.com/repos/kannappanr/minio/issues{/number}","pulls_url":"https://api.github.com/repos/kannappanr/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/kannappanr/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/kannappanr/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kannappanr/minio/labels{/name}","releases_url":"https://api.github.com/repos/kannappanr/minio/releases{/id}","deployments_url":"https://api.github.com/repos/kannappanr/minio/deployments","created_at":"2017-08-14T20:23:09Z","updated_at":"2017-08-14T20:23:12Z","pushed_at":"2017-10-26T23:39:52Z","git_url":"git://github.com/kannappanr/minio.git","ssh_url":"git@github.com:kannappanr/minio.git","clone_url":"https://github.com/kannappanr/minio.git","svn_url":"https://github.com/kannappanr/minio","homepage":"https://minio.io","size":28365,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"bc8b936d4bf0fb7c6cfdd9e777e3c5fa467844d1","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2017-10-26T21:10:23Z","pushed_at":"2017-10-27T01:01:47Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":28429,"stargazers_count":8823,"watchers_count":8823,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":705,"mirror_url":null,"archived":false,"open_issues_count":184,"forks":705,"open_issues":184,"watchers":8823,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/5118"},"html":{"href":"https://github.com/minio/minio/pull/5118"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/5118"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/5118/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/5118/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/5118/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/9c1d70f9a61f3cba274d3ec0bd1a816531485991"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"deekoder","id":1700901,"avatar_url":"https://avatars1.githubusercontent.com/u/1700901?v=4","gravatar_id":"","url":"https://api.github.com/users/deekoder","html_url":"https://github.com/deekoder","followers_url":"https://api.github.com/users/deekoder/followers","following_url":"https://api.github.com/users/deekoder/following{/other_user}","gists_url":"https://api.github.com/users/deekoder/gists{/gist_id}","starred_url":"https://api.github.com/users/deekoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deekoder/subscriptions","organizations_url":"https://api.github.com/users/deekoder/orgs","repos_url":"https://api.github.com/users/deekoder/repos","events_url":"https://api.github.com/users/deekoder/events{/privacy}","received_events_url":"https://api.github.com/users/deekoder/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"deekoder"}}