{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/126994017","pull_request_review_id":49532082,"id":126994017,"diff_hunk":"@@ -40,17 +40,18 @@ type ReasonCache struct {\n \tcache *lru.Cache\n }\n \n-// reasonInfo is the cached item in ReasonCache\n-type reasonInfo struct {\n-\treason  error\n-\tmessage string\n+// Reason is the cached item in ReasonCache\n+type Reason struct {","path":"pkg/kubelet/reason_cache.go","position":9,"original_position":9,"commit_id":"b55045098cb4e130b1fbeda66dfade12fc403863","original_commit_id":"e319c14122c7798ade81f2176e6ca22a8581a188","user":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars2.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"body":"You still don't need to export `Reason` since it's only used in this package, right?","created_at":"2017-07-12T15:49:15Z","updated_at":"2017-07-12T15:49:57Z","html_url":"https://github.com/kubernetes/kubernetes/pull/47316#discussion_r126994017","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/126994017"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47316#discussion_r126994017"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316","id":125050622,"html_url":"https://github.com/kubernetes/kubernetes/pull/47316","diff_url":"https://github.com/kubernetes/kubernetes/pull/47316.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/47316.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47316","number":47316,"state":"open","locked":false,"title":"Added golint check for pkg/kubelet.","user":{"login":"k82cn","id":18107181,"avatar_url":"https://avatars3.githubusercontent.com/u/18107181?v=3","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nAdded golint check for pkg/kubelet, and make golint happy.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47315 \r\n\r\n**Release note**:\r\n```release-note-none\r\n```\r\n","created_at":"2017-06-12T02:05:36Z","updated_at":"2017-07-12T15:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57b64902093af04e109a2a56b2e7036304cf7ced","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars1.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmorie","id":366488,"avatar_url":"https://avatars1.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},{"login":"dashpole","id":3262098,"avatar_url":"https://avatars2.githubusercontent.com/u/3262098?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},{"login":"shyamjvs","id":4333971,"avatar_url":"https://avatars0.githubusercontent.com/u/4333971?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars1.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36","html_url":"https://github.com/kubernetes/kubernetes/milestone/36","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36/labels","id":2545392,"number":36,"title":"v1.8","description":"Kubernetes 1.8 release milestone, date is TBD.","creator":{"login":"timothysc","id":169553,"avatar_url":"https://avatars3.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"open_issues":196,"closed_issues":66,"state":"open","created_at":"2017-05-26T17:18:43Z","updated_at":"2017-07-12T15:05:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47316/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b55045098cb4e130b1fbeda66dfade12fc403863","head":{"label":"k82cn:k8s_47315","ref":"k8s_47315","sha":"b55045098cb4e130b1fbeda66dfade12fc403863","user":{"login":"k82cn","id":18107181,"avatar_url":"https://avatars3.githubusercontent.com/u/18107181?v=3","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"repo":{"id":54859017,"name":"kubernetes","full_name":"k82cn/kubernetes","owner":{"login":"k82cn","id":18107181,"avatar_url":"https://avatars3.githubusercontent.com/u/18107181?v=3","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k82cn/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/k82cn/kubernetes","forks_url":"https://api.github.com/repos/k82cn/kubernetes/forks","keys_url":"https://api.github.com/repos/k82cn/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k82cn/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k82cn/kubernetes/teams","hooks_url":"https://api.github.com/repos/k82cn/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/k82cn/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/k82cn/kubernetes/events","assignees_url":"https://api.github.com/repos/k82cn/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/k82cn/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/k82cn/kubernetes/tags","blobs_url":"https://api.github.com/repos/k82cn/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k82cn/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k82cn/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/k82cn/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k82cn/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/k82cn/kubernetes/languages","stargazers_url":"https://api.github.com/repos/k82cn/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/k82cn/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/k82cn/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/k82cn/kubernetes/subscription","commits_url":"https://api.github.com/repos/k82cn/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/k82cn/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/k82cn/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/k82cn/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/k82cn/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/k82cn/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k82cn/kubernetes/merges","archive_url":"https://api.github.com/repos/k82cn/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k82cn/kubernetes/downloads","issues_url":"https://api.github.com/repos/k82cn/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/k82cn/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/k82cn/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/k82cn/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k82cn/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/k82cn/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/k82cn/kubernetes/deployments","created_at":"2016-03-28T02:16:04Z","updated_at":"2016-03-28T02:16:17Z","pushed_at":"2017-07-12T12:26:16Z","git_url":"git://github.com/k82cn/kubernetes.git","ssh_url":"git@github.com:k82cn/kubernetes.git","clone_url":"https://github.com/k82cn/kubernetes.git","svn_url":"https://github.com/k82cn/kubernetes","homepage":"http://kubernetes.io","size":452786,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5ca03d674e1495a1ced1f695a8e6620cd673b9dc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-07-12T15:47:59Z","pushed_at":"2017-07-12T15:49:22Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":673208,"stargazers_count":24844,"watchers_count":24844,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8830,"mirror_url":null,"open_issues_count":5020,"forks":8830,"open_issues":5020,"watchers":24844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47316"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47316"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47316/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47316/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b55045098cb4e130b1fbeda66dfade12fc403863"}}}}
{"actor":{"display_login":"yujuhong"}}