{"action":"created","comment":{"url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments/151978227","pull_request_review_id":77768501,"id":151978227,"diff_hunk":"@@ -27,9 +27,9 @@ public class SpecificEnergyTests : SpecificEnergyTestsBase\n     {\n         protected override double JoulesPerKilogramInOneJoulePerKilogram => 1.0;\n \n-        protected override double CaloriesPerGramInOneJoulePerKilogram => 1.0/4.184E3;\n+        protected override double CaloriesPerGramInOneJoulePerKilogram => 2.410800386e-4;","path":"UnitsNet.Tests/CustomCode/SpecificEnergyTests.cs","position":5,"original_position":5,"commit_id":"19cffacd5cc6e6134c6c6b562e73a4766c7000e3","original_commit_id":"19cffacd5cc6e6134c6c6b562e73a4766c7000e3","user":{"login":"ferittuncer","id":3106907,"avatar_url":"https://avatars0.githubusercontent.com/u/3106907?v=4","gravatar_id":"","url":"https://api.github.com/users/ferittuncer","html_url":"https://github.com/ferittuncer","followers_url":"https://api.github.com/users/ferittuncer/followers","following_url":"https://api.github.com/users/ferittuncer/following{/other_user}","gists_url":"https://api.github.com/users/ferittuncer/gists{/gist_id}","starred_url":"https://api.github.com/users/ferittuncer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferittuncer/subscriptions","organizations_url":"https://api.github.com/users/ferittuncer/orgs","repos_url":"https://api.github.com/users/ferittuncer/repos","events_url":"https://api.github.com/users/ferittuncer/events{/privacy}","received_events_url":"https://api.github.com/users/ferittuncer/received_events","type":"User","site_admin":false},"body":"Looks like he divided with 41**48** instead of 41**84**. I'm fixing this now.\r\n\r\nAnd perhaps we should either say in README that we don't support IT's but only TH's, or we should name them as you said.","created_at":"2017-11-20T12:32:18Z","updated_at":"2017-11-20T12:32:18Z","html_url":"https://github.com/angularsen/UnitsNet/pull/323#discussion_r151978227","pull_request_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments/151978227"},"html":{"href":"https://github.com/angularsen/UnitsNet/pull/323#discussion_r151978227"},"pull_request":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323"}},"in_reply_to_id":151859435},"pull_request":{"url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323","id":153294136,"html_url":"https://github.com/angularsen/UnitsNet/pull/323","diff_url":"https://github.com/angularsen/UnitsNet/pull/323.diff","patch_url":"https://github.com/angularsen/UnitsNet/pull/323.patch","issue_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/323","number":323,"state":"open","locked":false,"title":"changed expressions in term of algebraic operations with corresponding numeric results","user":{"login":"gratestas","id":25683638,"avatar_url":"https://avatars0.githubusercontent.com/u/25683638?v=4","gravatar_id":"","url":"https://api.github.com/users/gratestas","html_url":"https://github.com/gratestas","followers_url":"https://api.github.com/users/gratestas/followers","following_url":"https://api.github.com/users/gratestas/following{/other_user}","gists_url":"https://api.github.com/users/gratestas/gists{/gist_id}","starred_url":"https://api.github.com/users/gratestas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gratestas/subscriptions","organizations_url":"https://api.github.com/users/gratestas/orgs","repos_url":"https://api.github.com/users/gratestas/repos","events_url":"https://api.github.com/users/gratestas/events{/privacy}","received_events_url":"https://api.github.com/users/gratestas/received_events","type":"User","site_admin":false},"body":"as it is on demand, conversion values of a property in `UnitDefinition/*.json` files and those in `CustomCode/*.cs` files must be expressed differently in order to lead tests to reasonable execution. in case of specific energy, I noticed that there is no such consistency. on both side conversion factors from/to base unit are expressed identically. For instance,\r\n\r\nin UnitDefinition : ` \"FromBaseToUnitFunc\": \"x/4.184e3\" `\r\nin CustomCode : ` \"CaloriesPerGramInOneJoulePerKilogram\": \"x/4.184e3\",`","created_at":"2017-11-17T13:09:35Z","updated_at":"2017-11-20T12:32:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65e3c18ec95249069fdf40ca54d17cc52c19e952","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323/commits","review_comments_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323/comments","review_comment_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/323/comments","statuses_url":"https://api.github.com/repos/angularsen/UnitsNet/statuses/19cffacd5cc6e6134c6c6b562e73a4766c7000e3","head":{"label":"ferittuncer:origin/fix/fix-specific-energy-unit","ref":"origin/fix/fix-specific-energy-unit","sha":"19cffacd5cc6e6134c6c6b562e73a4766c7000e3","user":{"login":"ferittuncer","id":3106907,"avatar_url":"https://avatars0.githubusercontent.com/u/3106907?v=4","gravatar_id":"","url":"https://api.github.com/users/ferittuncer","html_url":"https://github.com/ferittuncer","followers_url":"https://api.github.com/users/ferittuncer/followers","following_url":"https://api.github.com/users/ferittuncer/following{/other_user}","gists_url":"https://api.github.com/users/ferittuncer/gists{/gist_id}","starred_url":"https://api.github.com/users/ferittuncer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferittuncer/subscriptions","organizations_url":"https://api.github.com/users/ferittuncer/orgs","repos_url":"https://api.github.com/users/ferittuncer/repos","events_url":"https://api.github.com/users/ferittuncer/events{/privacy}","received_events_url":"https://api.github.com/users/ferittuncer/received_events","type":"User","site_admin":false},"repo":{"id":103631432,"name":"UnitsNet","full_name":"ferittuncer/UnitsNet","owner":{"login":"ferittuncer","id":3106907,"avatar_url":"https://avatars0.githubusercontent.com/u/3106907?v=4","gravatar_id":"","url":"https://api.github.com/users/ferittuncer","html_url":"https://github.com/ferittuncer","followers_url":"https://api.github.com/users/ferittuncer/followers","following_url":"https://api.github.com/users/ferittuncer/following{/other_user}","gists_url":"https://api.github.com/users/ferittuncer/gists{/gist_id}","starred_url":"https://api.github.com/users/ferittuncer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferittuncer/subscriptions","organizations_url":"https://api.github.com/users/ferittuncer/orgs","repos_url":"https://api.github.com/users/ferittuncer/repos","events_url":"https://api.github.com/users/ferittuncer/events{/privacy}","received_events_url":"https://api.github.com/users/ferittuncer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferittuncer/UnitsNet","description":"Makes life working with units of measurement just a little bit better.","fork":true,"url":"https://api.github.com/repos/ferittuncer/UnitsNet","forks_url":"https://api.github.com/repos/ferittuncer/UnitsNet/forks","keys_url":"https://api.github.com/repos/ferittuncer/UnitsNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferittuncer/UnitsNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferittuncer/UnitsNet/teams","hooks_url":"https://api.github.com/repos/ferittuncer/UnitsNet/hooks","issue_events_url":"https://api.github.com/repos/ferittuncer/UnitsNet/issues/events{/number}","events_url":"https://api.github.com/repos/ferittuncer/UnitsNet/events","assignees_url":"https://api.github.com/repos/ferittuncer/UnitsNet/assignees{/user}","branches_url":"https://api.github.com/repos/ferittuncer/UnitsNet/branches{/branch}","tags_url":"https://api.github.com/repos/ferittuncer/UnitsNet/tags","blobs_url":"https://api.github.com/repos/ferittuncer/UnitsNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferittuncer/UnitsNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferittuncer/UnitsNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferittuncer/UnitsNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferittuncer/UnitsNet/statuses/{sha}","languages_url":"https://api.github.com/repos/ferittuncer/UnitsNet/languages","stargazers_url":"https://api.github.com/repos/ferittuncer/UnitsNet/stargazers","contributors_url":"https://api.github.com/repos/ferittuncer/UnitsNet/contributors","subscribers_url":"https://api.github.com/repos/ferittuncer/UnitsNet/subscribers","subscription_url":"https://api.github.com/repos/ferittuncer/UnitsNet/subscription","commits_url":"https://api.github.com/repos/ferittuncer/UnitsNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferittuncer/UnitsNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferittuncer/UnitsNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferittuncer/UnitsNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferittuncer/UnitsNet/contents/{+path}","compare_url":"https://api.github.com/repos/ferittuncer/UnitsNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferittuncer/UnitsNet/merges","archive_url":"https://api.github.com/repos/ferittuncer/UnitsNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferittuncer/UnitsNet/downloads","issues_url":"https://api.github.com/repos/ferittuncer/UnitsNet/issues{/number}","pulls_url":"https://api.github.com/repos/ferittuncer/UnitsNet/pulls{/number}","milestones_url":"https://api.github.com/repos/ferittuncer/UnitsNet/milestones{/number}","notifications_url":"https://api.github.com/repos/ferittuncer/UnitsNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferittuncer/UnitsNet/labels{/name}","releases_url":"https://api.github.com/repos/ferittuncer/UnitsNet/releases{/id}","deployments_url":"https://api.github.com/repos/ferittuncer/UnitsNet/deployments","created_at":"2017-09-15T08:06:02Z","updated_at":"2017-09-15T08:06:06Z","pushed_at":"2017-11-20T12:23:51Z","git_url":"git://github.com/ferittuncer/UnitsNet.git","ssh_url":"git@github.com:ferittuncer/UnitsNet.git","clone_url":"https://github.com/ferittuncer/UnitsNet.git","svn_url":"https://github.com/ferittuncer/UnitsNet","homepage":"https://www.nuget.org/packages/UnitsNet/","size":15949,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angularsen:master","ref":"master","sha":"420c2e3c3aecf3c7915e7e119fbee595072489fb","user":{"login":"angularsen","id":787816,"avatar_url":"https://avatars1.githubusercontent.com/u/787816?v=4","gravatar_id":"","url":"https://api.github.com/users/angularsen","html_url":"https://github.com/angularsen","followers_url":"https://api.github.com/users/angularsen/followers","following_url":"https://api.github.com/users/angularsen/following{/other_user}","gists_url":"https://api.github.com/users/angularsen/gists{/gist_id}","starred_url":"https://api.github.com/users/angularsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angularsen/subscriptions","organizations_url":"https://api.github.com/users/angularsen/orgs","repos_url":"https://api.github.com/users/angularsen/repos","events_url":"https://api.github.com/users/angularsen/events{/privacy}","received_events_url":"https://api.github.com/users/angularsen/received_events","type":"User","site_admin":false},"repo":{"id":11521218,"name":"UnitsNet","full_name":"angularsen/UnitsNet","owner":{"login":"angularsen","id":787816,"avatar_url":"https://avatars1.githubusercontent.com/u/787816?v=4","gravatar_id":"","url":"https://api.github.com/users/angularsen","html_url":"https://github.com/angularsen","followers_url":"https://api.github.com/users/angularsen/followers","following_url":"https://api.github.com/users/angularsen/following{/other_user}","gists_url":"https://api.github.com/users/angularsen/gists{/gist_id}","starred_url":"https://api.github.com/users/angularsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angularsen/subscriptions","organizations_url":"https://api.github.com/users/angularsen/orgs","repos_url":"https://api.github.com/users/angularsen/repos","events_url":"https://api.github.com/users/angularsen/events{/privacy}","received_events_url":"https://api.github.com/users/angularsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/angularsen/UnitsNet","description":"Makes life working with units of measurement just a little bit better.","fork":false,"url":"https://api.github.com/repos/angularsen/UnitsNet","forks_url":"https://api.github.com/repos/angularsen/UnitsNet/forks","keys_url":"https://api.github.com/repos/angularsen/UnitsNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angularsen/UnitsNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angularsen/UnitsNet/teams","hooks_url":"https://api.github.com/repos/angularsen/UnitsNet/hooks","issue_events_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/events{/number}","events_url":"https://api.github.com/repos/angularsen/UnitsNet/events","assignees_url":"https://api.github.com/repos/angularsen/UnitsNet/assignees{/user}","branches_url":"https://api.github.com/repos/angularsen/UnitsNet/branches{/branch}","tags_url":"https://api.github.com/repos/angularsen/UnitsNet/tags","blobs_url":"https://api.github.com/repos/angularsen/UnitsNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angularsen/UnitsNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angularsen/UnitsNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/angularsen/UnitsNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angularsen/UnitsNet/statuses/{sha}","languages_url":"https://api.github.com/repos/angularsen/UnitsNet/languages","stargazers_url":"https://api.github.com/repos/angularsen/UnitsNet/stargazers","contributors_url":"https://api.github.com/repos/angularsen/UnitsNet/contributors","subscribers_url":"https://api.github.com/repos/angularsen/UnitsNet/subscribers","subscription_url":"https://api.github.com/repos/angularsen/UnitsNet/subscription","commits_url":"https://api.github.com/repos/angularsen/UnitsNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/angularsen/UnitsNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/angularsen/UnitsNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/angularsen/UnitsNet/contents/{+path}","compare_url":"https://api.github.com/repos/angularsen/UnitsNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angularsen/UnitsNet/merges","archive_url":"https://api.github.com/repos/angularsen/UnitsNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angularsen/UnitsNet/downloads","issues_url":"https://api.github.com/repos/angularsen/UnitsNet/issues{/number}","pulls_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls{/number}","milestones_url":"https://api.github.com/repos/angularsen/UnitsNet/milestones{/number}","notifications_url":"https://api.github.com/repos/angularsen/UnitsNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angularsen/UnitsNet/labels{/name}","releases_url":"https://api.github.com/repos/angularsen/UnitsNet/releases{/id}","deployments_url":"https://api.github.com/repos/angularsen/UnitsNet/deployments","created_at":"2013-07-19T06:00:54Z","updated_at":"2017-11-20T07:12:11Z","pushed_at":"2017-11-20T12:23:54Z","git_url":"git://github.com/angularsen/UnitsNet.git","ssh_url":"git@github.com:angularsen/UnitsNet.git","clone_url":"https://github.com/angularsen/UnitsNet.git","svn_url":"https://github.com/angularsen/UnitsNet","homepage":"https://www.nuget.org/packages/UnitsNet/","size":15953,"stargazers_count":216,"watchers_count":216,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":11,"forks":92,"open_issues":11,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323"},"html":{"href":"https://github.com/angularsen/UnitsNet/pull/323"},"issue":{"href":"https://api.github.com/repos/angularsen/UnitsNet/issues/323"},"comments":{"href":"https://api.github.com/repos/angularsen/UnitsNet/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/angularsen/UnitsNet/statuses/19cffacd5cc6e6134c6c6b562e73a4766c7000e3"}},"author_association":"NONE"}}
{"actor":{"display_login":"ferittuncer"}}