{"action":"created","issue":{"url":"https://api.github.com/repos/qiime2/q2-feature-classifier/issues/48","repository_url":"https://api.github.com/repos/qiime2/q2-feature-classifier","labels_url":"https://api.github.com/repos/qiime2/q2-feature-classifier/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/qiime2/q2-feature-classifier/issues/48/comments","events_url":"https://api.github.com/repos/qiime2/q2-feature-classifier/issues/48/events","html_url":"https://github.com/qiime2/q2-feature-classifier/issues/48","id":203671327,"number":48,"title":"Warn users about scikit-learn version mismatch at runtime","user":{"login":"thermokarst","id":274668,"avatar_url":"https://avatars.githubusercontent.com/u/274668?v=3","gravatar_id":"","url":"https://api.github.com/users/thermokarst","html_url":"https://github.com/thermokarst","followers_url":"https://api.github.com/users/thermokarst/followers","following_url":"https://api.github.com/users/thermokarst/following{/other_user}","gists_url":"https://api.github.com/users/thermokarst/gists{/gist_id}","starred_url":"https://api.github.com/users/thermokarst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thermokarst/subscriptions","organizations_url":"https://api.github.com/users/thermokarst/orgs","repos_url":"https://api.github.com/users/thermokarst/repos","events_url":"https://api.github.com/users/thermokarst/events{/privacy}","received_events_url":"https://api.github.com/users/thermokarst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-01-27T15:58:13Z","updated_at":"2017-01-27T21:09:23Z","closed_at":null,"body":"For trained DBs, it would be really nice to warn users that they are using a version of scikit-learn that is incompatible with the version used to create the DB. We could do this by updating the DirFmt to encode scikit-learn version, then validate version at runtime."},"comment":{"url":"https://api.github.com/repos/qiime2/q2-feature-classifier/issues/comments/275775163","html_url":"https://github.com/qiime2/q2-feature-classifier/issues/48#issuecomment-275775163","issue_url":"https://api.github.com/repos/qiime2/q2-feature-classifier/issues/48","id":275775163,"user":{"login":"thermokarst","id":274668,"avatar_url":"https://avatars.githubusercontent.com/u/274668?v=3","gravatar_id":"","url":"https://api.github.com/users/thermokarst","html_url":"https://github.com/thermokarst","followers_url":"https://api.github.com/users/thermokarst/followers","following_url":"https://api.github.com/users/thermokarst/following{/other_user}","gists_url":"https://api.github.com/users/thermokarst/gists{/gist_id}","starred_url":"https://api.github.com/users/thermokarst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thermokarst/subscriptions","organizations_url":"https://api.github.com/users/thermokarst/orgs","repos_url":"https://api.github.com/users/thermokarst/repos","events_url":"https://api.github.com/users/thermokarst/events{/privacy}","received_events_url":"https://api.github.com/users/thermokarst/received_events","type":"User","site_admin":false},"created_at":"2017-01-27T21:09:23Z","updated_at":"2017-01-27T21:09:23Z","body":"Thanks @BenKaehler: you don't have to implement this, I think I have a clear idea of what we need to do (but you are more than welcome to!).\r\n\r\n> Which version of the classifier are you using? 2.0.6 classifier Artifacts won't work with the 2.0.7 plugin.\r\n\r\nThat is essentially the point of this issue --- we want to make it more clear to end users when they attempt to use classifiers across versions. By storing the scikit-learn version, we can do a quick compare and bomb out early and let folks know what is wrong and why.\r\n\r\n> You won't see the warning without setting --verbose.\r\n\r\nI think this new error should be shown without --verbose activated. Basically users would be using the wrong version of an artifact --- we want to make sure they know that."}}
{"actor":{"display_login":"thermokarst"}}