{"action":"created","comment":{"url":"https://api.github.com/repos/concordion/cubano/pulls/comments/153062795","pull_request_review_id":79019438,"id":153062795,"diff_hunk":"@@ -103,6 +111,30 @@ public Browser getBrowser(String key, BrowserProvider browserProvider) {\n         return browsers.get(key);\n     }\n \n+    private void incrementBrowserTestCount() {\n+        if (browserCloseAfterXTests <= 0 || browserTestRunCounted) {\n+            return;\n+        }\n+\n+        browserTestRunCounted = true;\n+        Integer count = testCount.get();\n+\n+        if (count >= browserCloseAfterXTests) {\n+            Map<String, Browser> browsers = threadBrowsers.get();\n+\n+            for (Iterator<String> iterator = browsers.keySet().iterator(); iterator.hasNext();) {\n+                Browser browser = browsers.get(iterator.next());\n+\n+                browser.close();","path":"cubano-concordion/src/main/java/org/concordion/cubano/framework/ConcordionBase.java","position":91,"original_position":91,"commit_id":"8e3ce6a5f8769c430e41d3b75a3d56cd9f5e6fdb","original_commit_id":"8e3ce6a5f8769c430e41d3b75a3d56cd9f5e6fdb","user":{"login":"nigelcharman","id":144202,"avatar_url":"https://avatars2.githubusercontent.com/u/144202?v=4","gravatar_id":"","url":"https://api.github.com/users/nigelcharman","html_url":"https://github.com/nigelcharman","followers_url":"https://api.github.com/users/nigelcharman/followers","following_url":"https://api.github.com/users/nigelcharman/following{/other_user}","gists_url":"https://api.github.com/users/nigelcharman/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelcharman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelcharman/subscriptions","organizations_url":"https://api.github.com/users/nigelcharman/orgs","repos_url":"https://api.github.com/users/nigelcharman/repos","events_url":"https://api.github.com/users/nigelcharman/events{/privacy}","received_events_url":"https://api.github.com/users/nigelcharman/received_events","type":"User","site_admin":false},"body":"This could close the other thread's browsers while they are in use. Is suggest only closing this thread's browser if possible. ","created_at":"2017-11-26T08:07:02Z","updated_at":"2017-11-26T08:07:02Z","html_url":"https://github.com/concordion/cubano/pull/36#discussion_r153062795","pull_request_url":"https://api.github.com/repos/concordion/cubano/pulls/36","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/concordion/cubano/pulls/comments/153062795"},"html":{"href":"https://github.com/concordion/cubano/pull/36#discussion_r153062795"},"pull_request":{"href":"https://api.github.com/repos/concordion/cubano/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/concordion/cubano/pulls/36","id":154653683,"html_url":"https://github.com/concordion/cubano/pull/36","diff_url":"https://github.com/concordion/cubano/pull/36.diff","patch_url":"https://github.com/concordion/cubano/pull/36.patch","issue_url":"https://api.github.com/repos/concordion/cubano/issues/36","number":36,"state":"open","locked":false,"title":"Firefox Fixes","user":{"login":"andrew-sumner","id":8650280,"avatar_url":"https://avatars2.githubusercontent.com/u/8650280?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-sumner","html_url":"https://github.com/andrew-sumner","followers_url":"https://api.github.com/users/andrew-sumner/followers","following_url":"https://api.github.com/users/andrew-sumner/following{/other_user}","gists_url":"https://api.github.com/users/andrew-sumner/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-sumner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-sumner/subscriptions","organizations_url":"https://api.github.com/users/andrew-sumner/orgs","repos_url":"https://api.github.com/users/andrew-sumner/repos","events_url":"https://api.github.com/users/andrew-sumner/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-sumner/received_events","type":"User","site_admin":false},"body":"Various workarounds to get FireFox 48+ (ie using gecko driver) working, the two main ones are:\r\n\r\n- Close browser every X tests to avoid memory leak\r\n- SiwtchToMainDocument had some work done to avoid hanging bug, and dead object bug","created_at":"2017-11-25T21:31:33Z","updated_at":"2017-11-26T08:07:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13d3ebc2f4d62c89b2487546ac35c2355b90649f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/concordion/cubano/pulls/36/commits","review_comments_url":"https://api.github.com/repos/concordion/cubano/pulls/36/comments","review_comment_url":"https://api.github.com/repos/concordion/cubano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concordion/cubano/issues/36/comments","statuses_url":"https://api.github.com/repos/concordion/cubano/statuses/8e3ce6a5f8769c430e41d3b75a3d56cd9f5e6fdb","head":{"label":"concordion:firefoxFrames","ref":"firefoxFrames","sha":"8e3ce6a5f8769c430e41d3b75a3d56cd9f5e6fdb","user":{"login":"concordion","id":3747047,"avatar_url":"https://avatars0.githubusercontent.com/u/3747047?v=4","gravatar_id":"","url":"https://api.github.com/users/concordion","html_url":"https://github.com/concordion","followers_url":"https://api.github.com/users/concordion/followers","following_url":"https://api.github.com/users/concordion/following{/other_user}","gists_url":"https://api.github.com/users/concordion/gists{/gist_id}","starred_url":"https://api.github.com/users/concordion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concordion/subscriptions","organizations_url":"https://api.github.com/users/concordion/orgs","repos_url":"https://api.github.com/users/concordion/repos","events_url":"https://api.github.com/users/concordion/events{/privacy}","received_events_url":"https://api.github.com/users/concordion/received_events","type":"Organization","site_admin":false},"repo":{"id":94165107,"name":"cubano","full_name":"concordion/cubano","owner":{"login":"concordion","id":3747047,"avatar_url":"https://avatars0.githubusercontent.com/u/3747047?v=4","gravatar_id":"","url":"https://api.github.com/users/concordion","html_url":"https://github.com/concordion","followers_url":"https://api.github.com/users/concordion/followers","following_url":"https://api.github.com/users/concordion/following{/other_user}","gists_url":"https://api.github.com/users/concordion/gists{/gist_id}","starred_url":"https://api.github.com/users/concordion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concordion/subscriptions","organizations_url":"https://api.github.com/users/concordion/orgs","repos_url":"https://api.github.com/users/concordion/repos","events_url":"https://api.github.com/users/concordion/events{/privacy}","received_events_url":"https://api.github.com/users/concordion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concordion/cubano","description":null,"fork":false,"url":"https://api.github.com/repos/concordion/cubano","forks_url":"https://api.github.com/repos/concordion/cubano/forks","keys_url":"https://api.github.com/repos/concordion/cubano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concordion/cubano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concordion/cubano/teams","hooks_url":"https://api.github.com/repos/concordion/cubano/hooks","issue_events_url":"https://api.github.com/repos/concordion/cubano/issues/events{/number}","events_url":"https://api.github.com/repos/concordion/cubano/events","assignees_url":"https://api.github.com/repos/concordion/cubano/assignees{/user}","branches_url":"https://api.github.com/repos/concordion/cubano/branches{/branch}","tags_url":"https://api.github.com/repos/concordion/cubano/tags","blobs_url":"https://api.github.com/repos/concordion/cubano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concordion/cubano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concordion/cubano/git/refs{/sha}","trees_url":"https://api.github.com/repos/concordion/cubano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concordion/cubano/statuses/{sha}","languages_url":"https://api.github.com/repos/concordion/cubano/languages","stargazers_url":"https://api.github.com/repos/concordion/cubano/stargazers","contributors_url":"https://api.github.com/repos/concordion/cubano/contributors","subscribers_url":"https://api.github.com/repos/concordion/cubano/subscribers","subscription_url":"https://api.github.com/repos/concordion/cubano/subscription","commits_url":"https://api.github.com/repos/concordion/cubano/commits{/sha}","git_commits_url":"https://api.github.com/repos/concordion/cubano/git/commits{/sha}","comments_url":"https://api.github.com/repos/concordion/cubano/comments{/number}","issue_comment_url":"https://api.github.com/repos/concordion/cubano/issues/comments{/number}","contents_url":"https://api.github.com/repos/concordion/cubano/contents/{+path}","compare_url":"https://api.github.com/repos/concordion/cubano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concordion/cubano/merges","archive_url":"https://api.github.com/repos/concordion/cubano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concordion/cubano/downloads","issues_url":"https://api.github.com/repos/concordion/cubano/issues{/number}","pulls_url":"https://api.github.com/repos/concordion/cubano/pulls{/number}","milestones_url":"https://api.github.com/repos/concordion/cubano/milestones{/number}","notifications_url":"https://api.github.com/repos/concordion/cubano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concordion/cubano/labels{/name}","releases_url":"https://api.github.com/repos/concordion/cubano/releases{/id}","deployments_url":"https://api.github.com/repos/concordion/cubano/deployments","created_at":"2017-06-13T03:30:42Z","updated_at":"2017-11-09T03:42:25Z","pushed_at":"2017-11-25T21:31:34Z","git_url":"git://github.com/concordion/cubano.git","ssh_url":"git@github.com:concordion/cubano.git","clone_url":"https://github.com/concordion/cubano.git","svn_url":"https://github.com/concordion/cubano","homepage":null,"size":1606,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"concordion:master","ref":"master","sha":"bb783c33096ea57c65b5e1da86c696d4782c8308","user":{"login":"concordion","id":3747047,"avatar_url":"https://avatars0.githubusercontent.com/u/3747047?v=4","gravatar_id":"","url":"https://api.github.com/users/concordion","html_url":"https://github.com/concordion","followers_url":"https://api.github.com/users/concordion/followers","following_url":"https://api.github.com/users/concordion/following{/other_user}","gists_url":"https://api.github.com/users/concordion/gists{/gist_id}","starred_url":"https://api.github.com/users/concordion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concordion/subscriptions","organizations_url":"https://api.github.com/users/concordion/orgs","repos_url":"https://api.github.com/users/concordion/repos","events_url":"https://api.github.com/users/concordion/events{/privacy}","received_events_url":"https://api.github.com/users/concordion/received_events","type":"Organization","site_admin":false},"repo":{"id":94165107,"name":"cubano","full_name":"concordion/cubano","owner":{"login":"concordion","id":3747047,"avatar_url":"https://avatars0.githubusercontent.com/u/3747047?v=4","gravatar_id":"","url":"https://api.github.com/users/concordion","html_url":"https://github.com/concordion","followers_url":"https://api.github.com/users/concordion/followers","following_url":"https://api.github.com/users/concordion/following{/other_user}","gists_url":"https://api.github.com/users/concordion/gists{/gist_id}","starred_url":"https://api.github.com/users/concordion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concordion/subscriptions","organizations_url":"https://api.github.com/users/concordion/orgs","repos_url":"https://api.github.com/users/concordion/repos","events_url":"https://api.github.com/users/concordion/events{/privacy}","received_events_url":"https://api.github.com/users/concordion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concordion/cubano","description":null,"fork":false,"url":"https://api.github.com/repos/concordion/cubano","forks_url":"https://api.github.com/repos/concordion/cubano/forks","keys_url":"https://api.github.com/repos/concordion/cubano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concordion/cubano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concordion/cubano/teams","hooks_url":"https://api.github.com/repos/concordion/cubano/hooks","issue_events_url":"https://api.github.com/repos/concordion/cubano/issues/events{/number}","events_url":"https://api.github.com/repos/concordion/cubano/events","assignees_url":"https://api.github.com/repos/concordion/cubano/assignees{/user}","branches_url":"https://api.github.com/repos/concordion/cubano/branches{/branch}","tags_url":"https://api.github.com/repos/concordion/cubano/tags","blobs_url":"https://api.github.com/repos/concordion/cubano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concordion/cubano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concordion/cubano/git/refs{/sha}","trees_url":"https://api.github.com/repos/concordion/cubano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concordion/cubano/statuses/{sha}","languages_url":"https://api.github.com/repos/concordion/cubano/languages","stargazers_url":"https://api.github.com/repos/concordion/cubano/stargazers","contributors_url":"https://api.github.com/repos/concordion/cubano/contributors","subscribers_url":"https://api.github.com/repos/concordion/cubano/subscribers","subscription_url":"https://api.github.com/repos/concordion/cubano/subscription","commits_url":"https://api.github.com/repos/concordion/cubano/commits{/sha}","git_commits_url":"https://api.github.com/repos/concordion/cubano/git/commits{/sha}","comments_url":"https://api.github.com/repos/concordion/cubano/comments{/number}","issue_comment_url":"https://api.github.com/repos/concordion/cubano/issues/comments{/number}","contents_url":"https://api.github.com/repos/concordion/cubano/contents/{+path}","compare_url":"https://api.github.com/repos/concordion/cubano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concordion/cubano/merges","archive_url":"https://api.github.com/repos/concordion/cubano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concordion/cubano/downloads","issues_url":"https://api.github.com/repos/concordion/cubano/issues{/number}","pulls_url":"https://api.github.com/repos/concordion/cubano/pulls{/number}","milestones_url":"https://api.github.com/repos/concordion/cubano/milestones{/number}","notifications_url":"https://api.github.com/repos/concordion/cubano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concordion/cubano/labels{/name}","releases_url":"https://api.github.com/repos/concordion/cubano/releases{/id}","deployments_url":"https://api.github.com/repos/concordion/cubano/deployments","created_at":"2017-06-13T03:30:42Z","updated_at":"2017-11-09T03:42:25Z","pushed_at":"2017-11-25T21:31:34Z","git_url":"git://github.com/concordion/cubano.git","ssh_url":"git@github.com:concordion/cubano.git","clone_url":"https://github.com/concordion/cubano.git","svn_url":"https://github.com/concordion/cubano","homepage":null,"size":1606,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concordion/cubano/pulls/36"},"html":{"href":"https://github.com/concordion/cubano/pull/36"},"issue":{"href":"https://api.github.com/repos/concordion/cubano/issues/36"},"comments":{"href":"https://api.github.com/repos/concordion/cubano/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/concordion/cubano/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/concordion/cubano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concordion/cubano/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/concordion/cubano/statuses/8e3ce6a5f8769c430e41d3b75a3d56cd9f5e6fdb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nigelcharman"}}