{"action":"created","issue":{"url":"https://api.github.com/repos/hyperoslo/Spots/issues/607","repository_url":"https://api.github.com/repos/hyperoslo/Spots","labels_url":"https://api.github.com/repos/hyperoslo/Spots/issues/607/labels{/name}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/issues/607/comments","events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/607/events","html_url":"https://github.com/hyperoslo/Spots/pull/607","id":226880790,"number":607,"title":"Fix collection view layout warnings on macOS","user":{"login":"zenangst","id":57446,"avatar_url":"https://avatars2.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-07T18:06:36Z","updated_at":"2017-05-07T18:11:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/607","html_url":"https://github.com/hyperoslo/Spots/pull/607","diff_url":"https://github.com/hyperoslo/Spots/pull/607.diff","patch_url":"https://github.com/hyperoslo/Spots/pull/607.patch"},"body":"When resizing a window that contains collection view based components,\r\nthe layouts were outputting warnings as the item could exceed the\r\nmaximum size allowed in the layout.\r\n\r\nTo fix silence and fix these warnings, we now call `invalidateLayout()`\r\nin `resizeVerticalCollectionView`.\r\nWe also prepare the items before calling layout, this way the items get\r\ntheir new size before the collection view receives a new size.\r\n\r\nFor vertical layouts, we now set size before calling prepare and\r\ninvalidateLayout in Component+macOS+Grid.\r\n\r\nThe referenced warnings are these:\r\n\r\n```The behavior of the UICollectionViewFlowLayout is not defined because:\r\nThe item height must be less than the height of the UICollectionView\r\nminus the section insets top and bottom values.\r\n\r\nThe behavior of the UICollectionViewFlowLayout is not defined because:\r\nThe item width must be less than the width of the UICollectionView\r\nminus the section insets left and right values.```"},"comment":{"url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments/299723856","html_url":"https://github.com/hyperoslo/Spots/pull/607#issuecomment-299723856","issue_url":"https://api.github.com/repos/hyperoslo/Spots/issues/607","id":299723856,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars3.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-05-07T18:11:33Z","updated_at":"2017-05-07T18:11:33Z","body":"# [Codecov](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=h1) Report\n> Merging [#607](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=desc) into [master](https://codecov.io/gh/hyperoslo/Spots/commit/6b88577c9de7057a431c105d68908e77f863126e?src=pr&el=desc) will **increase** coverage by `0.07%`.\n> The diff coverage is `68%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/hyperoslo/Spots/pull/607/graphs/tree.svg?src=pr&token=JXw2bogreq&width=650&height=150)](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #607      +/-   ##\n==========================================\n+ Coverage   87.49%   87.56%   +0.07%     \n==========================================\n  Files         120      120              \n  Lines        9830     9847      +17     \n==========================================\n+ Hits         8601     8623      +22     \n+ Misses       1229     1224       -5\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #ios | `89.57% <ø> (ø)` | :arrow_up: |\n| #osx | `89.94% <68%> (+0.09%)` | :arrow_up: |\n| #tvos | `81.58% <ø> (ø)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...macOS/Extensions/DataSource+macOS+Extensions.swift](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=tree#diff-U291cmNlcy9tYWNPUy9FeHRlbnNpb25zL0RhdGFTb3VyY2UrbWFjT1MrRXh0ZW5zaW9ucy5zd2lmdA==) | `53.33% <ø> (-1.51%)` | :arrow_down: |\n| [Sources/macOS/Classes/GridableLayout.swift](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=tree#diff-U291cmNlcy9tYWNPUy9DbGFzc2VzL0dyaWRhYmxlTGF5b3V0LnN3aWZ0) | `84.61% <0%> (+8.52%)` | :arrow_up: |\n| [...es/macOS/Extensions/Component+macOS+Carousel.swift](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=tree#diff-U291cmNlcy9tYWNPUy9FeHRlbnNpb25zL0NvbXBvbmVudCttYWNPUytDYXJvdXNlbC5zd2lmdA==) | `77.77% <100%> (+1.3%)` | :arrow_up: |\n| [...ources/macOS/Extensions/Component+macOS+Grid.swift](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=tree#diff-U291cmNlcy9tYWNPUy9FeHRlbnNpb25zL0NvbXBvbmVudCttYWNPUytHcmlkLnN3aWZ0) | `60% <20%> (-5.39%)` | :arrow_down: |\n| [Sources/macOS/Classes/Component.swift](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=tree#diff-U291cmNlcy9tYWNPUy9DbGFzc2VzL0NvbXBvbmVudC5zd2lmdA==) | `74.4% <86.66%> (+1.54%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=footer). Last update [6b88577...bd50eff](https://codecov.io/gh/hyperoslo/Spots/pull/607?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}