{"action":"created","issue":{"url":"https://api.github.com/repos/kokkos/kokkos/issues/978","repository_url":"https://api.github.com/repos/kokkos/kokkos","labels_url":"https://api.github.com/repos/kokkos/kokkos/issues/978/labels{/name}","comments_url":"https://api.github.com/repos/kokkos/kokkos/issues/978/comments","events_url":"https://api.github.com/repos/kokkos/kokkos/issues/978/events","html_url":"https://github.com/kokkos/kokkos/issues/978","id":245459792,"number":978,"title":"Preprocessor check at top of KokkosCore_config.h breaks internal customer's build process","user":{"login":"mhoemmen","id":926747,"avatar_url":"https://avatars0.githubusercontent.com/u/926747?v=4","gravatar_id":"","url":"https://api.github.com/users/mhoemmen","html_url":"https://github.com/mhoemmen","followers_url":"https://api.github.com/users/mhoemmen/followers","following_url":"https://api.github.com/users/mhoemmen/following{/other_user}","gists_url":"https://api.github.com/users/mhoemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoemmen/subscriptions","organizations_url":"https://api.github.com/users/mhoemmen/orgs","repos_url":"https://api.github.com/users/mhoemmen/repos","events_url":"https://api.github.com/users/mhoemmen/events{/privacy}","received_events_url":"https://api.github.com/users/mhoemmen/received_events","type":"User","site_admin":false},"labels":[{"id":197378046,"url":"https://api.github.com/repos/kokkos/kokkos/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false},"assignees":[{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2017-07-25T16:28:13Z","updated_at":"2017-07-26T12:34:49Z","closed_at":null,"body":"`$ git blame core/cmake/KokkosCore_config.h`\r\n```\r\n82a0d275 (Dan Ibanez     2017-05-11 12:30:53 -0600   1) #if !defined(KOKKOS_MACROS_HPP) || defined(KOKKOS_CORE_CONFIG_H)\r\n82a0d275 (Dan Ibanez     2017-05-11 12:30:53 -0600   2) #error \"Don't include KokkosCore_config.h directly; include Kokkos_Macros.hpp instead.\"\r\n82a0d275 (Dan Ibanez     2017-05-11 12:30:53 -0600   3) #else\r\n^d0932b0 (Carter Edwards 2015-04-09 09:28:05 -0600   4) #define KOKKOS_CORE_CONFIG_H\r\n82a0d275 (Dan Ibanez     2017-05-11 12:30:53 -0600   5) #endif\r\n```\r\nSorry @ibaned :(  I know it's horrible, but could we please not do this error check here?  It makes Rich Drake's life hard and it's making my life hard now too.  I'll submit a PR if it's OK.\r\n\r\nObligatory xkcd: https://xkcd.com/1172/"},"comment":{"url":"https://api.github.com/repos/kokkos/kokkos/issues/comments/318039748","html_url":"https://github.com/kokkos/kokkos/issues/978#issuecomment-318039748","issue_url":"https://api.github.com/repos/kokkos/kokkos/issues/978","id":318039748,"user":{"login":"rrdrake","id":10149802,"avatar_url":"https://avatars1.githubusercontent.com/u/10149802?v=4","gravatar_id":"","url":"https://api.github.com/users/rrdrake","html_url":"https://github.com/rrdrake","followers_url":"https://api.github.com/users/rrdrake/followers","following_url":"https://api.github.com/users/rrdrake/following{/other_user}","gists_url":"https://api.github.com/users/rrdrake/gists{/gist_id}","starred_url":"https://api.github.com/users/rrdrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrdrake/subscriptions","organizations_url":"https://api.github.com/users/rrdrake/orgs","repos_url":"https://api.github.com/users/rrdrake/repos","events_url":"https://api.github.com/users/rrdrake/events{/privacy}","received_events_url":"https://api.github.com/users/rrdrake/received_events","type":"User","site_admin":false},"created_at":"2017-07-26T12:34:49Z","updated_at":"2017-07-26T12:34:49Z","body":"In any case, I would be receptive to a solution that uses KOKKOS_FOR_SIERRA as separate logic to work around this issue for the time being."}}
{"actor":{"display_login":"rrdrake"}}