{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/113121539","pull_request_review_id":34483850,"id":113121539,"diff_hunk":"@@ -31,3 +31,15 @@ NOTE: rolling-update does not yet perform a real rolling update - it just shuts\n  there will be downtime [Issue #37](https://github.com/kubernetes/kops/issues/37)\n We have implemented a new feature that does drain and validate nodes.  This feature is experimental, and you can use the new feature by setting `export KOPS_FEATURE_FLAGS=\"+DrainAndValidateRollingUpdate\"`.\n \n+### Terraform Users\n+\n+* `kops edit cluster $NAME`\n+* set the KubernetesVersion to the target version (e.g. `v1.3.5`)\n+* NOTE: The next 3 steps must all be ran in the same directory\n+* `kops update cluster $NAME --target=terraform`\n+* `terraform plan`","path":"docs/upgrade.md","position":10,"original_position":10,"commit_id":"84629b19adf7c17240142823552d18d83c442e17","original_commit_id":"84629b19adf7c17240142823552d18d83c442e17","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars1.githubusercontent.com/u/335402?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"body":"@justinsb this file should not be in the PR either ~  @robertojrojas was having some git challenges today.  Oh I remember some rebase hell ...","created_at":"2017-04-25T07:16:02Z","updated_at":"2017-04-25T07:16:13Z","html_url":"https://github.com/kubernetes/kops/pull/2411#discussion_r113121539","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/2411","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/113121539"},"html":{"href":"https://github.com/kubernetes/kops/pull/2411#discussion_r113121539"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2411"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/2411","id":117156944,"html_url":"https://github.com/kubernetes/kops/pull/2411","diff_url":"https://github.com/kubernetes/kops/pull/2411.diff","patch_url":"https://github.com/kubernetes/kops/pull/2411.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/2411","number":2411,"state":"open","locked":false,"title":"Improved cli command line help - fixes #1005","user":{"login":"robertojrojas","id":2787728,"avatar_url":"https://avatars1.githubusercontent.com/u/2787728?v=3","gravatar_id":"","url":"https://api.github.com/users/robertojrojas","html_url":"https://github.com/robertojrojas","followers_url":"https://api.github.com/users/robertojrojas/followers","following_url":"https://api.github.com/users/robertojrojas/following{/other_user}","gists_url":"https://api.github.com/users/robertojrojas/gists{/gist_id}","starred_url":"https://api.github.com/users/robertojrojas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertojrojas/subscriptions","organizations_url":"https://api.github.com/users/robertojrojas/orgs","repos_url":"https://api.github.com/users/robertojrojas/repos","events_url":"https://api.github.com/users/robertojrojas/events{/privacy}","received_events_url":"https://api.github.com/users/robertojrojas/received_events","type":"User","site_admin":false},"body":"Improved cli command line help by adding k8s templates, i18n, and examples. Fixes #1005\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/2411)\n<!-- Reviewable:end -->\n","created_at":"2017-04-23T16:54:52Z","updated_at":"2017-04-25T07:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26cda8ab23a0ad06cfd6da76d1b73a279dbcdf7","assignee":{"login":"justinsb","id":100893,"avatar_url":"https://avatars1.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinsb","id":100893,"avatar_url":"https://avatars1.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/2411/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/2411/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/2411/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/84629b19adf7c17240142823552d18d83c442e17","head":{"label":"robertojrojas:issue_1005","ref":"issue_1005","sha":"84629b19adf7c17240142823552d18d83c442e17","user":{"login":"robertojrojas","id":2787728,"avatar_url":"https://avatars1.githubusercontent.com/u/2787728?v=3","gravatar_id":"","url":"https://api.github.com/users/robertojrojas","html_url":"https://github.com/robertojrojas","followers_url":"https://api.github.com/users/robertojrojas/followers","following_url":"https://api.github.com/users/robertojrojas/following{/other_user}","gists_url":"https://api.github.com/users/robertojrojas/gists{/gist_id}","starred_url":"https://api.github.com/users/robertojrojas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertojrojas/subscriptions","organizations_url":"https://api.github.com/users/robertojrojas/orgs","repos_url":"https://api.github.com/users/robertojrojas/repos","events_url":"https://api.github.com/users/robertojrojas/events{/privacy}","received_events_url":"https://api.github.com/users/robertojrojas/received_events","type":"User","site_admin":false},"repo":{"id":76305077,"name":"kops","full_name":"robertojrojas/kops","owner":{"login":"robertojrojas","id":2787728,"avatar_url":"https://avatars1.githubusercontent.com/u/2787728?v=3","gravatar_id":"","url":"https://api.github.com/users/robertojrojas","html_url":"https://github.com/robertojrojas","followers_url":"https://api.github.com/users/robertojrojas/followers","following_url":"https://api.github.com/users/robertojrojas/following{/other_user}","gists_url":"https://api.github.com/users/robertojrojas/gists{/gist_id}","starred_url":"https://api.github.com/users/robertojrojas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertojrojas/subscriptions","organizations_url":"https://api.github.com/users/robertojrojas/orgs","repos_url":"https://api.github.com/users/robertojrojas/repos","events_url":"https://api.github.com/users/robertojrojas/events{/privacy}","received_events_url":"https://api.github.com/users/robertojrojas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertojrojas/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/robertojrojas/kops","forks_url":"https://api.github.com/repos/robertojrojas/kops/forks","keys_url":"https://api.github.com/repos/robertojrojas/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertojrojas/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertojrojas/kops/teams","hooks_url":"https://api.github.com/repos/robertojrojas/kops/hooks","issue_events_url":"https://api.github.com/repos/robertojrojas/kops/issues/events{/number}","events_url":"https://api.github.com/repos/robertojrojas/kops/events","assignees_url":"https://api.github.com/repos/robertojrojas/kops/assignees{/user}","branches_url":"https://api.github.com/repos/robertojrojas/kops/branches{/branch}","tags_url":"https://api.github.com/repos/robertojrojas/kops/tags","blobs_url":"https://api.github.com/repos/robertojrojas/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertojrojas/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertojrojas/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertojrojas/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertojrojas/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/robertojrojas/kops/languages","stargazers_url":"https://api.github.com/repos/robertojrojas/kops/stargazers","contributors_url":"https://api.github.com/repos/robertojrojas/kops/contributors","subscribers_url":"https://api.github.com/repos/robertojrojas/kops/subscribers","subscription_url":"https://api.github.com/repos/robertojrojas/kops/subscription","commits_url":"https://api.github.com/repos/robertojrojas/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertojrojas/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertojrojas/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertojrojas/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertojrojas/kops/contents/{+path}","compare_url":"https://api.github.com/repos/robertojrojas/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertojrojas/kops/merges","archive_url":"https://api.github.com/repos/robertojrojas/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertojrojas/kops/downloads","issues_url":"https://api.github.com/repos/robertojrojas/kops/issues{/number}","pulls_url":"https://api.github.com/repos/robertojrojas/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/robertojrojas/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/robertojrojas/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertojrojas/kops/labels{/name}","releases_url":"https://api.github.com/repos/robertojrojas/kops/releases{/id}","deployments_url":"https://api.github.com/repos/robertojrojas/kops/deployments","created_at":"2016-12-12T23:38:56Z","updated_at":"2016-12-12T23:38:59Z","pushed_at":"2017-04-24T23:04:56Z","git_url":"git://github.com/robertojrojas/kops.git","ssh_url":"git@github.com:robertojrojas/kops.git","clone_url":"https://github.com/robertojrojas/kops.git","svn_url":"https://github.com/robertojrojas/kops","homepage":"","size":122093,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1b2266dd406f6fea93ce90b0828bdf756db942a8","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-04-25T06:16:05Z","pushed_at":"2017-04-25T05:32:40Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":134632,"stargazers_count":1611,"watchers_count":1611,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":617,"forks":408,"open_issues":617,"watchers":1611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2411"},"html":{"href":"https://github.com/kubernetes/kops/pull/2411"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/2411"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/2411/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2411/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2411/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/84629b19adf7c17240142823552d18d83c442e17"}}}}
{"actor":{"display_login":"chrislovecnm"}}