{"action":"created","comment":{"url":"https://api.github.com/repos/tsuru/tsuru/pulls/comments/104003970","pull_request_review_id":24815753,"id":104003970,"diff_hunk":"@@ -115,8 +115,11 @@ var (\n \tPermPoolCreate                       = PermissionRegistry.get(\"pool.create\")                         // [global]\n \tPermPoolDelete                       = PermissionRegistry.get(\"pool.delete\")                         // [global pool]\n \tPermPoolRead                         = PermissionRegistry.get(\"pool.read\")                           // [global pool]\n+\tPermPoolReadConstraints              = PermissionRegistry.get(\"pool.read.constraints\")               // [global pool]\n \tPermPoolReadEvents                   = PermissionRegistry.get(\"pool.read.events\")                    // [global pool]\n \tPermPoolUpdate                       = PermissionRegistry.get(\"pool.update\")                         // [global pool]\n+\tPermPoolUpdateConstraint             = PermissionRegistry.get(\"pool.update.constraint\")              // [global pool]","path":"permission/permitems.go","position":7,"original_position":7,"commit_id":"43536884177e05e2ebd2f6829c48dd9288be1a9f","original_commit_id":"43536884177e05e2ebd2f6829c48dd9288be1a9f","user":{"login":"cezarsa","id":11041,"avatar_url":"https://avatars2.githubusercontent.com/u/11041?v=3","gravatar_id":"","url":"https://api.github.com/users/cezarsa","html_url":"https://github.com/cezarsa","followers_url":"https://api.github.com/users/cezarsa/followers","following_url":"https://api.github.com/users/cezarsa/following{/other_user}","gists_url":"https://api.github.com/users/cezarsa/gists{/gist_id}","starred_url":"https://api.github.com/users/cezarsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cezarsa/subscriptions","organizations_url":"https://api.github.com/users/cezarsa/orgs","repos_url":"https://api.github.com/users/cezarsa/repos","events_url":"https://api.github.com/users/cezarsa/events{/privacy}","received_events_url":"https://api.github.com/users/cezarsa/received_events","type":"User","site_admin":false},"body":"Should this be `pool.update.constraint(s)` to match the read permission?","created_at":"2017-03-02T19:09:01Z","updated_at":"2017-03-02T19:09:01Z","html_url":"https://github.com/tsuru/tsuru/pull/1546#discussion_r104003970","pull_request_url":"https://api.github.com/repos/tsuru/tsuru/pulls/1546","_links":{"self":{"href":"https://api.github.com/repos/tsuru/tsuru/pulls/comments/104003970"},"html":{"href":"https://github.com/tsuru/tsuru/pull/1546#discussion_r104003970"},"pull_request":{"href":"https://api.github.com/repos/tsuru/tsuru/pulls/1546"}}},"pull_request":{"url":"https://api.github.com/repos/tsuru/tsuru/pulls/1546","id":108825385,"html_url":"https://github.com/tsuru/tsuru/pull/1546","diff_url":"https://github.com/tsuru/tsuru/pull/1546.diff","patch_url":"https://github.com/tsuru/tsuru/pull/1546.patch","issue_url":"https://api.github.com/repos/tsuru/tsuru/issues/1546","number":1546,"state":"open","locked":false,"title":"Adds generic Pool constraints","user":{"login":"andrestc","id":2944739,"avatar_url":"https://avatars0.githubusercontent.com/u/2944739?v=3","gravatar_id":"","url":"https://api.github.com/users/andrestc","html_url":"https://github.com/andrestc","followers_url":"https://api.github.com/users/andrestc/followers","following_url":"https://api.github.com/users/andrestc/following{/other_user}","gists_url":"https://api.github.com/users/andrestc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrestc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrestc/subscriptions","organizations_url":"https://api.github.com/users/andrestc/orgs","repos_url":"https://api.github.com/users/andrestc/repos","events_url":"https://api.github.com/users/andrestc/events{/privacy}","received_events_url":"https://api.github.com/users/andrestc/received_events","type":"User","site_admin":false},"body":"This refactors pool teams into pool constraints and prepares the ground for adding other types of contraints, such as routers (#1528). \r\n\r\nTwo new endpoints are added one for setting pool constraints and one for listing them. It's not possible to append a value to a constraint at the moment, perhaps this can be supported by adding a parameter on the setting endpoint.","created_at":"2017-03-02T18:49:22Z","updated_at":"2017-03-02T19:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"748df40cee32efe26ca6271622ce1c2e27f1f10d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tsuru/tsuru/pulls/1546/commits","review_comments_url":"https://api.github.com/repos/tsuru/tsuru/pulls/1546/comments","review_comment_url":"https://api.github.com/repos/tsuru/tsuru/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tsuru/tsuru/issues/1546/comments","statuses_url":"https://api.github.com/repos/tsuru/tsuru/statuses/43536884177e05e2ebd2f6829c48dd9288be1a9f","head":{"label":"tsuru:pool-constraint","ref":"pool-constraint","sha":"43536884177e05e2ebd2f6829c48dd9288be1a9f","user":{"login":"tsuru","id":6999787,"avatar_url":"https://avatars2.githubusercontent.com/u/6999787?v=3","gravatar_id":"","url":"https://api.github.com/users/tsuru","html_url":"https://github.com/tsuru","followers_url":"https://api.github.com/users/tsuru/followers","following_url":"https://api.github.com/users/tsuru/following{/other_user}","gists_url":"https://api.github.com/users/tsuru/gists{/gist_id}","starred_url":"https://api.github.com/users/tsuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsuru/subscriptions","organizations_url":"https://api.github.com/users/tsuru/orgs","repos_url":"https://api.github.com/users/tsuru/repos","events_url":"https://api.github.com/users/tsuru/events{/privacy}","received_events_url":"https://api.github.com/users/tsuru/received_events","type":"Organization","site_admin":false},"repo":{"id":3631697,"name":"tsuru","full_name":"tsuru/tsuru","owner":{"login":"tsuru","id":6999787,"avatar_url":"https://avatars2.githubusercontent.com/u/6999787?v=3","gravatar_id":"","url":"https://api.github.com/users/tsuru","html_url":"https://github.com/tsuru","followers_url":"https://api.github.com/users/tsuru/followers","following_url":"https://api.github.com/users/tsuru/following{/other_user}","gists_url":"https://api.github.com/users/tsuru/gists{/gist_id}","starred_url":"https://api.github.com/users/tsuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsuru/subscriptions","organizations_url":"https://api.github.com/users/tsuru/orgs","repos_url":"https://api.github.com/users/tsuru/repos","events_url":"https://api.github.com/users/tsuru/events{/privacy}","received_events_url":"https://api.github.com/users/tsuru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tsuru/tsuru","description":"Open source, extensible and Docker-based Platform as a Service (PaaS).","fork":false,"url":"https://api.github.com/repos/tsuru/tsuru","forks_url":"https://api.github.com/repos/tsuru/tsuru/forks","keys_url":"https://api.github.com/repos/tsuru/tsuru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsuru/tsuru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsuru/tsuru/teams","hooks_url":"https://api.github.com/repos/tsuru/tsuru/hooks","issue_events_url":"https://api.github.com/repos/tsuru/tsuru/issues/events{/number}","events_url":"https://api.github.com/repos/tsuru/tsuru/events","assignees_url":"https://api.github.com/repos/tsuru/tsuru/assignees{/user}","branches_url":"https://api.github.com/repos/tsuru/tsuru/branches{/branch}","tags_url":"https://api.github.com/repos/tsuru/tsuru/tags","blobs_url":"https://api.github.com/repos/tsuru/tsuru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsuru/tsuru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsuru/tsuru/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsuru/tsuru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsuru/tsuru/statuses/{sha}","languages_url":"https://api.github.com/repos/tsuru/tsuru/languages","stargazers_url":"https://api.github.com/repos/tsuru/tsuru/stargazers","contributors_url":"https://api.github.com/repos/tsuru/tsuru/contributors","subscribers_url":"https://api.github.com/repos/tsuru/tsuru/subscribers","subscription_url":"https://api.github.com/repos/tsuru/tsuru/subscription","commits_url":"https://api.github.com/repos/tsuru/tsuru/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsuru/tsuru/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsuru/tsuru/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsuru/tsuru/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsuru/tsuru/contents/{+path}","compare_url":"https://api.github.com/repos/tsuru/tsuru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsuru/tsuru/merges","archive_url":"https://api.github.com/repos/tsuru/tsuru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsuru/tsuru/downloads","issues_url":"https://api.github.com/repos/tsuru/tsuru/issues{/number}","pulls_url":"https://api.github.com/repos/tsuru/tsuru/pulls{/number}","milestones_url":"https://api.github.com/repos/tsuru/tsuru/milestones{/number}","notifications_url":"https://api.github.com/repos/tsuru/tsuru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsuru/tsuru/labels{/name}","releases_url":"https://api.github.com/repos/tsuru/tsuru/releases{/id}","deployments_url":"https://api.github.com/repos/tsuru/tsuru/deployments","created_at":"2012-03-05T21:41:08Z","updated_at":"2017-03-01T13:47:49Z","pushed_at":"2017-03-02T18:51:57Z","git_url":"git://github.com/tsuru/tsuru.git","ssh_url":"git@github.com:tsuru/tsuru.git","clone_url":"https://github.com/tsuru/tsuru.git","svn_url":"https://github.com/tsuru/tsuru","homepage":"https://tsuru.io","size":42759,"stargazers_count":2238,"watchers_count":2238,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":294,"mirror_url":null,"open_issues_count":180,"forks":294,"open_issues":180,"watchers":2238,"default_branch":"master"}},"base":{"label":"tsuru:master","ref":"master","sha":"ee386ddebd91bbf3333dd7673b5f127b88bdf6bc","user":{"login":"tsuru","id":6999787,"avatar_url":"https://avatars2.githubusercontent.com/u/6999787?v=3","gravatar_id":"","url":"https://api.github.com/users/tsuru","html_url":"https://github.com/tsuru","followers_url":"https://api.github.com/users/tsuru/followers","following_url":"https://api.github.com/users/tsuru/following{/other_user}","gists_url":"https://api.github.com/users/tsuru/gists{/gist_id}","starred_url":"https://api.github.com/users/tsuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsuru/subscriptions","organizations_url":"https://api.github.com/users/tsuru/orgs","repos_url":"https://api.github.com/users/tsuru/repos","events_url":"https://api.github.com/users/tsuru/events{/privacy}","received_events_url":"https://api.github.com/users/tsuru/received_events","type":"Organization","site_admin":false},"repo":{"id":3631697,"name":"tsuru","full_name":"tsuru/tsuru","owner":{"login":"tsuru","id":6999787,"avatar_url":"https://avatars2.githubusercontent.com/u/6999787?v=3","gravatar_id":"","url":"https://api.github.com/users/tsuru","html_url":"https://github.com/tsuru","followers_url":"https://api.github.com/users/tsuru/followers","following_url":"https://api.github.com/users/tsuru/following{/other_user}","gists_url":"https://api.github.com/users/tsuru/gists{/gist_id}","starred_url":"https://api.github.com/users/tsuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsuru/subscriptions","organizations_url":"https://api.github.com/users/tsuru/orgs","repos_url":"https://api.github.com/users/tsuru/repos","events_url":"https://api.github.com/users/tsuru/events{/privacy}","received_events_url":"https://api.github.com/users/tsuru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tsuru/tsuru","description":"Open source, extensible and Docker-based Platform as a Service (PaaS).","fork":false,"url":"https://api.github.com/repos/tsuru/tsuru","forks_url":"https://api.github.com/repos/tsuru/tsuru/forks","keys_url":"https://api.github.com/repos/tsuru/tsuru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsuru/tsuru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsuru/tsuru/teams","hooks_url":"https://api.github.com/repos/tsuru/tsuru/hooks","issue_events_url":"https://api.github.com/repos/tsuru/tsuru/issues/events{/number}","events_url":"https://api.github.com/repos/tsuru/tsuru/events","assignees_url":"https://api.github.com/repos/tsuru/tsuru/assignees{/user}","branches_url":"https://api.github.com/repos/tsuru/tsuru/branches{/branch}","tags_url":"https://api.github.com/repos/tsuru/tsuru/tags","blobs_url":"https://api.github.com/repos/tsuru/tsuru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsuru/tsuru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsuru/tsuru/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsuru/tsuru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsuru/tsuru/statuses/{sha}","languages_url":"https://api.github.com/repos/tsuru/tsuru/languages","stargazers_url":"https://api.github.com/repos/tsuru/tsuru/stargazers","contributors_url":"https://api.github.com/repos/tsuru/tsuru/contributors","subscribers_url":"https://api.github.com/repos/tsuru/tsuru/subscribers","subscription_url":"https://api.github.com/repos/tsuru/tsuru/subscription","commits_url":"https://api.github.com/repos/tsuru/tsuru/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsuru/tsuru/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsuru/tsuru/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsuru/tsuru/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsuru/tsuru/contents/{+path}","compare_url":"https://api.github.com/repos/tsuru/tsuru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsuru/tsuru/merges","archive_url":"https://api.github.com/repos/tsuru/tsuru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsuru/tsuru/downloads","issues_url":"https://api.github.com/repos/tsuru/tsuru/issues{/number}","pulls_url":"https://api.github.com/repos/tsuru/tsuru/pulls{/number}","milestones_url":"https://api.github.com/repos/tsuru/tsuru/milestones{/number}","notifications_url":"https://api.github.com/repos/tsuru/tsuru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsuru/tsuru/labels{/name}","releases_url":"https://api.github.com/repos/tsuru/tsuru/releases{/id}","deployments_url":"https://api.github.com/repos/tsuru/tsuru/deployments","created_at":"2012-03-05T21:41:08Z","updated_at":"2017-03-01T13:47:49Z","pushed_at":"2017-03-02T18:51:57Z","git_url":"git://github.com/tsuru/tsuru.git","ssh_url":"git@github.com:tsuru/tsuru.git","clone_url":"https://github.com/tsuru/tsuru.git","svn_url":"https://github.com/tsuru/tsuru","homepage":"https://tsuru.io","size":42759,"stargazers_count":2238,"watchers_count":2238,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":294,"mirror_url":null,"open_issues_count":180,"forks":294,"open_issues":180,"watchers":2238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tsuru/tsuru/pulls/1546"},"html":{"href":"https://github.com/tsuru/tsuru/pull/1546"},"issue":{"href":"https://api.github.com/repos/tsuru/tsuru/issues/1546"},"comments":{"href":"https://api.github.com/repos/tsuru/tsuru/issues/1546/comments"},"review_comments":{"href":"https://api.github.com/repos/tsuru/tsuru/pulls/1546/comments"},"review_comment":{"href":"https://api.github.com/repos/tsuru/tsuru/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tsuru/tsuru/pulls/1546/commits"},"statuses":{"href":"https://api.github.com/repos/tsuru/tsuru/statuses/43536884177e05e2ebd2f6829c48dd9288be1a9f"}}}}
{"actor":{"display_login":"cezarsa"}}