{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/94714764","pull_request_review_id":15248305,"id":94714764,"diff_hunk":"@@ -0,0 +1,71 @@\n+﻿// Copyright (c) .NET Foundation and contributors. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Globalization;\n+using System.IO;\n+using System.Linq;\n+using System.Runtime.CompilerServices;\n+using Microsoft.TemplateEngine.Abstractions;\n+using Microsoft.TemplateEngine.Cli;\n+using Microsoft.TemplateEngine.Edge;\n+using Microsoft.TemplateEngine.Orchestrator.RunnableProjects;\n+using Microsoft.TemplateEngine.Orchestrator.RunnableProjects.Config;\n+using Microsoft.TemplateEngine.Orchestrator.RunnableProjects.Macros;\n+using Microsoft.TemplateEngine.Utils;\n+\n+namespace Microsoft.DotNet.Tools.New3\n+{\n+    internal class New3CommandShim\n+    {\n+        private const string HostIdentifier = \"dotnetcli\";\n+        private const string HostVersion = \"1.0.0\";\n+        private const string CommandName = \"new3\";\n+\n+        public static int Run(string[] args)\n+        {\n+            return New3Command.Run(CommandName, CreateHost(), FirstRun, args);\n+        }\n+\n+        private static ITemplateEngineHost CreateHost()\n+        {\n+            var builtIns = new Dictionary<Guid, Func<Type>>\n+            {\n+                { new Guid(\"0C434DF7-E2CB-4DEE-B216-D7C58C8EB4B3\"), () => typeof(RunnableProjectGenerator) },","path":"src/dotnet/commands/dotnet-new3/New3CommandShim.cs","position":35,"original_position":35,"commit_id":"45cb6e9949afceecd806ba11c740494a3130441b","original_commit_id":"45cb6e9949afceecd806ba11c740494a3130441b","user":{"login":"piotrpMSFT","id":2379589,"avatar_url":"https://avatars.githubusercontent.com/u/2379589?v=3","gravatar_id":"","url":"https://api.github.com/users/piotrpMSFT","html_url":"https://github.com/piotrpMSFT","followers_url":"https://api.github.com/users/piotrpMSFT/followers","following_url":"https://api.github.com/users/piotrpMSFT/following{/other_user}","gists_url":"https://api.github.com/users/piotrpMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrpMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrpMSFT/subscriptions","organizations_url":"https://api.github.com/users/piotrpMSFT/orgs","repos_url":"https://api.github.com/users/piotrpMSFT/repos","events_url":"https://api.github.com/users/piotrpMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/piotrpMSFT/received_events","type":"User","site_admin":false},"body":"Can we make the default set defined here the defaults in DefaultTemplateEngineHost and just pass null from CLI? I think that the concern is that these GUIDs don't really mean anything to CLI and there is not a present desire for changing the default behavior of the host...\r\n\r\nAlternatively, we would want to add a meaningful test for these configurations to ensure we're not accidentally breaking some desirable behavior. I'd personally prefer having the defaults built in, but we can do this instead...","created_at":"2017-01-05T05:11:52Z","updated_at":"2017-01-05T05:12:18Z","html_url":"https://github.com/dotnet/cli/pull/5065#discussion_r94714764","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/5065","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/94714764"},"html":{"href":"https://github.com/dotnet/cli/pull/5065#discussion_r94714764"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/5065"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/5065","id":98418834,"html_url":"https://github.com/dotnet/cli/pull/5065","diff_url":"https://github.com/dotnet/cli/pull/5065.diff","patch_url":"https://github.com/dotnet/cli/pull/5065.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/5065","number":5065,"state":"open","locked":false,"title":"First step to ingest template engine","user":{"login":"mlorbetske","id":1414993,"avatar_url":"https://avatars.githubusercontent.com/u/1414993?v=3","gravatar_id":"","url":"https://api.github.com/users/mlorbetske","html_url":"https://github.com/mlorbetske","followers_url":"https://api.github.com/users/mlorbetske/followers","following_url":"https://api.github.com/users/mlorbetske/following{/other_user}","gists_url":"https://api.github.com/users/mlorbetske/gists{/gist_id}","starred_url":"https://api.github.com/users/mlorbetske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlorbetske/subscriptions","organizations_url":"https://api.github.com/users/mlorbetske/orgs","repos_url":"https://api.github.com/users/mlorbetske/repos","events_url":"https://api.github.com/users/mlorbetske/events{/privacy}","received_events_url":"https://api.github.com/users/mlorbetske/received_events","type":"User","site_admin":false},"body":"Please do not merge yet. Templates, tests and more initialization logic are on their way.\r\nFixes https://github.com/dotnet/templating/issues/66\r\n\r\n/cc @piotrp @seancpeters @livarcocc ","created_at":"2016-12-16T23:17:54Z","updated_at":"2017-01-05T05:12:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f41a2e4b64c05a9438fd9e384435e2390b054ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/5065/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/5065/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/5065/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/45cb6e9949afceecd806ba11c740494a3130441b","head":{"label":"mlorbetske:IngestTemplateEngine","ref":"IngestTemplateEngine","sha":"45cb6e9949afceecd806ba11c740494a3130441b","user":{"login":"mlorbetske","id":1414993,"avatar_url":"https://avatars.githubusercontent.com/u/1414993?v=3","gravatar_id":"","url":"https://api.github.com/users/mlorbetske","html_url":"https://github.com/mlorbetske","followers_url":"https://api.github.com/users/mlorbetske/followers","following_url":"https://api.github.com/users/mlorbetske/following{/other_user}","gists_url":"https://api.github.com/users/mlorbetske/gists{/gist_id}","starred_url":"https://api.github.com/users/mlorbetske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlorbetske/subscriptions","organizations_url":"https://api.github.com/users/mlorbetske/orgs","repos_url":"https://api.github.com/users/mlorbetske/repos","events_url":"https://api.github.com/users/mlorbetske/events{/privacy}","received_events_url":"https://api.github.com/users/mlorbetske/received_events","type":"User","site_admin":false},"repo":{"id":59168003,"name":"cli","full_name":"mlorbetske/cli","owner":{"login":"mlorbetske","id":1414993,"avatar_url":"https://avatars.githubusercontent.com/u/1414993?v=3","gravatar_id":"","url":"https://api.github.com/users/mlorbetske","html_url":"https://github.com/mlorbetske","followers_url":"https://api.github.com/users/mlorbetske/followers","following_url":"https://api.github.com/users/mlorbetske/following{/other_user}","gists_url":"https://api.github.com/users/mlorbetske/gists{/gist_id}","starred_url":"https://api.github.com/users/mlorbetske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlorbetske/subscriptions","organizations_url":"https://api.github.com/users/mlorbetske/orgs","repos_url":"https://api.github.com/users/mlorbetske/repos","events_url":"https://api.github.com/users/mlorbetske/events{/privacy}","received_events_url":"https://api.github.com/users/mlorbetske/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlorbetske/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/mlorbetske/cli","forks_url":"https://api.github.com/repos/mlorbetske/cli/forks","keys_url":"https://api.github.com/repos/mlorbetske/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlorbetske/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlorbetske/cli/teams","hooks_url":"https://api.github.com/repos/mlorbetske/cli/hooks","issue_events_url":"https://api.github.com/repos/mlorbetske/cli/issues/events{/number}","events_url":"https://api.github.com/repos/mlorbetske/cli/events","assignees_url":"https://api.github.com/repos/mlorbetske/cli/assignees{/user}","branches_url":"https://api.github.com/repos/mlorbetske/cli/branches{/branch}","tags_url":"https://api.github.com/repos/mlorbetske/cli/tags","blobs_url":"https://api.github.com/repos/mlorbetske/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlorbetske/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlorbetske/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlorbetske/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlorbetske/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/mlorbetske/cli/languages","stargazers_url":"https://api.github.com/repos/mlorbetske/cli/stargazers","contributors_url":"https://api.github.com/repos/mlorbetske/cli/contributors","subscribers_url":"https://api.github.com/repos/mlorbetske/cli/subscribers","subscription_url":"https://api.github.com/repos/mlorbetske/cli/subscription","commits_url":"https://api.github.com/repos/mlorbetske/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlorbetske/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlorbetske/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlorbetske/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlorbetske/cli/contents/{+path}","compare_url":"https://api.github.com/repos/mlorbetske/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlorbetske/cli/merges","archive_url":"https://api.github.com/repos/mlorbetske/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlorbetske/cli/downloads","issues_url":"https://api.github.com/repos/mlorbetske/cli/issues{/number}","pulls_url":"https://api.github.com/repos/mlorbetske/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/mlorbetske/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/mlorbetske/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlorbetske/cli/labels{/name}","releases_url":"https://api.github.com/repos/mlorbetske/cli/releases{/id}","deployments_url":"https://api.github.com/repos/mlorbetske/cli/deployments","created_at":"2016-05-19T02:41:14Z","updated_at":"2016-05-19T02:41:17Z","pushed_at":"2017-01-04T11:27:57Z","git_url":"git://github.com/mlorbetske/cli.git","ssh_url":"git@github.com:mlorbetske/cli.git","clone_url":"https://github.com/mlorbetske/cli.git","svn_url":"https://github.com/mlorbetske/cli","homepage":"http://dotnet.github.io/","size":26859,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"rel/1.0.0"}},"base":{"label":"dotnet:rel/1.0.0","ref":"rel/1.0.0","sha":"84730e31a6d84c1494d00f131b7a98e9c7936018","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2017-01-04T23:06:19Z","pushed_at":"2017-01-05T04:55:55Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://docs.microsoft.com/dotnet/","size":30379,"stargazers_count":1704,"watchers_count":1704,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":507,"mirror_url":null,"open_issues_count":554,"forks":507,"open_issues":554,"watchers":1704,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/5065"},"html":{"href":"https://github.com/dotnet/cli/pull/5065"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/5065"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/5065/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/5065/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/5065/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/45cb6e9949afceecd806ba11c740494a3130441b"}}}}
{"actor":{"display_login":"piotrpMSFT"}}