{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/112479119","pull_request_review_id":33797753,"id":112479119,"diff_hunk":"@@ -3131,6 +3084,10 @@ def __eq__(self, other):\n         if isinstance(other, Cube):\n             result = self.metadata == other.metadata\n \n+            # check the cube fill-value.\n+            if result:\n+                result = self.fill_value == other.fill_value","path":"lib/iris/cube.py","position":375,"original_position":375,"commit_id":"fb811f853735745daa508182aa1b7ad14ef6e231","original_commit_id":"3d6241eb22ff0e7af549050cc0fdca9ece4576be","user":{"login":"dkillick","id":3473068,"avatar_url":"https://avatars1.githubusercontent.com/u/3473068?v=3","gravatar_id":"","url":"https://api.github.com/users/dkillick","html_url":"https://github.com/dkillick","followers_url":"https://api.github.com/users/dkillick/followers","following_url":"https://api.github.com/users/dkillick/following{/other_user}","gists_url":"https://api.github.com/users/dkillick/gists{/gist_id}","starred_url":"https://api.github.com/users/dkillick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkillick/subscriptions","organizations_url":"https://api.github.com/users/dkillick/orgs","repos_url":"https://api.github.com/users/dkillick/repos","events_url":"https://api.github.com/users/dkillick/events{/privacy}","received_events_url":"https://api.github.com/users/dkillick/received_events","type":"User","site_admin":false},"body":"> so is this a general issue that should be raised beyond this PR?\r\n\r\nYeah, it probably is (we should probably make it very clear somewhere what factors determine cube equality!).\r\n\r\nI sort of hate this:\r\n\r\n```python\r\n>>> np.array(1) == np.array(1.0)\r\nTrue\r\n```","created_at":"2017-04-20T15:10:35Z","updated_at":"2017-04-20T15:10:35Z","html_url":"https://github.com/SciTools/iris/pull/2492#discussion_r112479119","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/2492","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/112479119"},"html":{"href":"https://github.com/SciTools/iris/pull/2492#discussion_r112479119"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2492"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/2492","id":116653126,"html_url":"https://github.com/SciTools/iris/pull/2492","diff_url":"https://github.com/SciTools/iris/pull/2492.diff","patch_url":"https://github.com/SciTools/iris/pull/2492.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/2492","number":2492,"state":"open","locked":false,"title":"Dask cube and data manager integration","user":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars1.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"body":"This PR integrates the `DataManager` into the `Cube`.\r\n\r\nThis PR closes #2444, closes #2442, closes #2437, closes #2429, closes #2439, closes #2489.","created_at":"2017-04-19T22:12:57Z","updated_at":"2017-04-20T15:10:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a90daf16bac55ce2a2fed457e39596a3fe85d5f5","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/SciTools/iris/milestones/30","html_url":"https://github.com/SciTools/iris/milestone/30","labels_url":"https://api.github.com/repos/SciTools/iris/milestones/30/labels","id":2320122,"number":30,"title":"dask","description":"","creator":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars1.githubusercontent.com/u/302469?v=3","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":54,"state":"open","created_at":"2017-02-13T21:29:54Z","updated_at":"2017-04-20T13:32:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/2492/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/2492/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/2492/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/fb811f853735745daa508182aa1b7ad14ef6e231","head":{"label":"bjlittle:dask-cube-and-data-manager-integration","ref":"dask-cube-and-data-manager-integration","sha":"fb811f853735745daa508182aa1b7ad14ef6e231","user":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars1.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"repo":{"id":5312966,"name":"iris","full_name":"bjlittle/iris","owner":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars1.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjlittle/iris","description":null,"fork":true,"url":"https://api.github.com/repos/bjlittle/iris","forks_url":"https://api.github.com/repos/bjlittle/iris/forks","keys_url":"https://api.github.com/repos/bjlittle/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjlittle/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjlittle/iris/teams","hooks_url":"https://api.github.com/repos/bjlittle/iris/hooks","issue_events_url":"https://api.github.com/repos/bjlittle/iris/issues/events{/number}","events_url":"https://api.github.com/repos/bjlittle/iris/events","assignees_url":"https://api.github.com/repos/bjlittle/iris/assignees{/user}","branches_url":"https://api.github.com/repos/bjlittle/iris/branches{/branch}","tags_url":"https://api.github.com/repos/bjlittle/iris/tags","blobs_url":"https://api.github.com/repos/bjlittle/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjlittle/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjlittle/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjlittle/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjlittle/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/bjlittle/iris/languages","stargazers_url":"https://api.github.com/repos/bjlittle/iris/stargazers","contributors_url":"https://api.github.com/repos/bjlittle/iris/contributors","subscribers_url":"https://api.github.com/repos/bjlittle/iris/subscribers","subscription_url":"https://api.github.com/repos/bjlittle/iris/subscription","commits_url":"https://api.github.com/repos/bjlittle/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjlittle/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjlittle/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjlittle/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjlittle/iris/contents/{+path}","compare_url":"https://api.github.com/repos/bjlittle/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjlittle/iris/merges","archive_url":"https://api.github.com/repos/bjlittle/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjlittle/iris/downloads","issues_url":"https://api.github.com/repos/bjlittle/iris/issues{/number}","pulls_url":"https://api.github.com/repos/bjlittle/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/bjlittle/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/bjlittle/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjlittle/iris/labels{/name}","releases_url":"https://api.github.com/repos/bjlittle/iris/releases{/id}","deployments_url":"https://api.github.com/repos/bjlittle/iris/deployments","created_at":"2012-08-06T10:45:19Z","updated_at":"2014-09-23T09:42:09Z","pushed_at":"2017-04-20T15:03:12Z","git_url":"git://github.com/bjlittle/iris.git","ssh_url":"git@github.com:bjlittle/iris.git","clone_url":"https://github.com/bjlittle/iris.git","svn_url":"https://github.com/bjlittle/iris","homepage":"","size":103951,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"SciTools:dask","ref":"dask","sha":"88db1d2236a0eec0478ced178cb651eedd1db0f9","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars0.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars0.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/iris/deployments","created_at":"2012-08-06T10:09:14Z","updated_at":"2017-04-12T18:00:09Z","pushed_at":"2017-04-20T15:03:14Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":103253,"stargazers_count":161,"watchers_count":161,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":346,"forks":113,"open_issues":346,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2492"},"html":{"href":"https://github.com/SciTools/iris/pull/2492"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/2492"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/2492/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2492/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/2492/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/fb811f853735745daa508182aa1b7ad14ef6e231"}}}}
{"actor":{"display_login":"dkillick"}}