{"push_id":1911030108,"size":1,"distinct_size":1,"ref":"refs/heads/stats_micrometer","head":"91b07b0663620b7b256823f89d906b7e1525fbeb","before":"205889b64c0c5481039a9a896f2bb532c556bdec","commits":[{"sha":"91b07b0663620b7b256823f89d906b7e1525fbeb","author":{"name":"Trustin Lee","email":"213c4738cc35c04f021cb47d03c4226bdf330636@motd.kr"},"message":"Switch to micrometer-metrics\n\nMotivation:\n\nThere are two major matric collection libraries in Java: Dropwizard and\nPrometheus. They both have their own advantages and disadvantages so we\ncannot simply chose one over the other.\n\nSo far, we provided a dedicated decorator implementation for each\nlibrary, but this approach is not scalable. Also, it gives us hard time\nfor adding session-level metrics because the core API has to remain\ndetached from both libraries' API.\n\nModifications:\n\n- Use micrometer-metrics as our standard metric collection API.\n- Replace (Dropwizard|Prometheus)MetricCollecting(Client|Service) with\n  MetricCollecting(Client|Service)\n- Replace DropwizardMetricsCircuitBreakerListener with\n  MetricCollectingCircuitBreakerListener\n- Add Server.meterRegistry() and ClientFactory.meterRegistry()\n- Add RequestContext.meterRegistry()\n- Add CaffeineMetricSupport and migrate RouterCache to the new API\n\nResult:\n\n- We can support third-party metric collection libraries easily.\n- We can add metrics everywhere easily.","distinct":true,"url":"https://api.github.com/repos/trustin/armeria/commits/91b07b0663620b7b256823f89d906b7e1525fbeb"}]}
{"actor":{"display_login":"trustin"}}