{"action":"created","issue":{"url":"https://api.github.com/repos/dahlbyk/posh-git/issues/370","repository_url":"https://api.github.com/repos/dahlbyk/posh-git","labels_url":"https://api.github.com/repos/dahlbyk/posh-git/issues/370/labels{/name}","comments_url":"https://api.github.com/repos/dahlbyk/posh-git/issues/370/comments","events_url":"https://api.github.com/repos/dahlbyk/posh-git/issues/370/events","html_url":"https://github.com/dahlbyk/posh-git/pull/370","id":201094159,"number":370,"title":"Fix Get-GitDirectory to work in bare repo.","user":{"login":"rkeithhill","id":5177512,"avatar_url":"https://avatars.githubusercontent.com/u/5177512?v=3","gravatar_id":"","url":"https://api.github.com/users/rkeithhill","html_url":"https://github.com/rkeithhill","followers_url":"https://api.github.com/users/rkeithhill/followers","following_url":"https://api.github.com/users/rkeithhill/following{/other_user}","gists_url":"https://api.github.com/users/rkeithhill/gists{/gist_id}","starred_url":"https://api.github.com/users/rkeithhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkeithhill/subscriptions","organizations_url":"https://api.github.com/users/rkeithhill/orgs","repos_url":"https://api.github.com/users/rkeithhill/repos","events_url":"https://api.github.com/users/rkeithhill/events{/privacy}","received_events_url":"https://api.github.com/users/rkeithhill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-01-16T18:49:15Z","updated_at":"2017-01-25T18:34:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dahlbyk/posh-git/pulls/370","html_url":"https://github.com/dahlbyk/posh-git/pull/370","diff_url":"https://github.com/dahlbyk/posh-git/pull/370.diff","patch_url":"https://github.com/dahlbyk/posh-git/pull/370.patch"},"body":"Fix #291.  Also added Pester tests for this command."},"comment":{"url":"https://api.github.com/repos/dahlbyk/posh-git/issues/comments/275192926","html_url":"https://github.com/dahlbyk/posh-git/pull/370#issuecomment-275192926","issue_url":"https://api.github.com/repos/dahlbyk/posh-git/issues/370","id":275192926,"user":{"login":"dahlbyk","id":133987,"avatar_url":"https://avatars.githubusercontent.com/u/133987?v=3","gravatar_id":"","url":"https://api.github.com/users/dahlbyk","html_url":"https://github.com/dahlbyk","followers_url":"https://api.github.com/users/dahlbyk/followers","following_url":"https://api.github.com/users/dahlbyk/following{/other_user}","gists_url":"https://api.github.com/users/dahlbyk/gists{/gist_id}","starred_url":"https://api.github.com/users/dahlbyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahlbyk/subscriptions","organizations_url":"https://api.github.com/users/dahlbyk/orgs","repos_url":"https://api.github.com/users/dahlbyk/repos","events_url":"https://api.github.com/users/dahlbyk/events{/privacy}","received_events_url":"https://api.github.com/users/dahlbyk/received_events","type":"User","site_admin":false},"created_at":"2017-01-25T18:34:38Z","updated_at":"2017-01-25T18:34:38Z","body":"> BTW I thought with Git you weren't supposed to rebase anything that is public i.e. pushed to a public Git repo?\r\n\r\nThis is where things get philosophical. Some people have a firm \"never `push --force`\" rule. I'm not one of those people. (Actually, I am, but only because Git added [`push --force-with-lease`](https://developer.atlassian.com/blog/2015/04/force-with-lease/)). When people say \"don't rebase anything that's public\" what they really mean is \"don't rebase anything people are depending on because things can get scary.\" Note \"scary\" and not \"broken\" - I have never encountered an upstream `rebase` that I couldn't handle locally.\r\n\r\nIf this branch had been around for months and we had referred people here to test something out (e.g. #208), it might be reasonable to treat as history that shouldn't be rewritten. And if you and I were working together on the same branch, we would want to communicate carefully if a `rebase` was necessary. But once a feature is ready to ship, I'm firmly in the \"clean history is best history\" camp. I used to consider a linear history cleanest (`git log --graph --oneline c481e5b`) but have since come to prefer rebased PRs with a merge commit.\r\n\r\n>  Also, you are not talking about an interactive rebase (with squashing), right?\r\n\r\nCorrect, I'm talking about the GitHub merge-via-rebase button. Since \"clean history is best history\", a `rebase --interactive` with selective squashing (e.g. combining a1bb28f into its parent) would be acceptable (preferred, actually, for my private work). A year from now there's zero value in the implementation detail of knowing that CI failed because tests needed to be adjusted - the test changes logically belong with the change in functionality.\r\n\r\nThat being said, I have come to terms with posh-git history being a mess, so this type of clean-up is strictly optional.\r\n\r\n> You are talking about rebasing the branch onto master.\r\n\r\nYeah, this is what the GitHub merge-via-rebase button does. Where `master` is whatever branch the PR targets, of course."}}
{"actor":{"display_login":"dahlbyk"}}