{"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/9","id":151881958,"html_url":"https://github.com/dvsa/vehicle-recalls-api/pull/9","diff_url":"https://github.com/dvsa/vehicle-recalls-api/pull/9.diff","patch_url":"https://github.com/dvsa/vehicle-recalls-api/pull/9.patch","issue_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/9","number":9,"state":"open","locked":false,"title":"BL-6139-Enable-Disable-KMS","user":{"login":"Marcin-Duszynski","id":12165279,"avatar_url":"https://avatars2.githubusercontent.com/u/12165279?v=4","gravatar_id":"","url":"https://api.github.com/users/Marcin-Duszynski","html_url":"https://github.com/Marcin-Duszynski","followers_url":"https://api.github.com/users/Marcin-Duszynski/followers","following_url":"https://api.github.com/users/Marcin-Duszynski/following{/other_user}","gists_url":"https://api.github.com/users/Marcin-Duszynski/gists{/gist_id}","starred_url":"https://api.github.com/users/Marcin-Duszynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marcin-Duszynski/subscriptions","organizations_url":"https://api.github.com/users/Marcin-Duszynski/orgs","repos_url":"https://api.github.com/users/Marcin-Duszynski/repos","events_url":"https://api.github.com/users/Marcin-Duszynski/events{/privacy}","received_events_url":"https://api.github.com/users/Marcin-Duszynski/received_events","type":"User","site_admin":false},"body":"### What are the relevant Jira tickets?\r\nBL-6139\r\n\r\n### Where should the reviewer start?\r\nsrc/config/service.js -> isKmsEnabled variable\r\n\r\n## Dev checklist:\r\n- Is proper destination **branch** selected?\r\n- Are proper **label** and **reviewers** selected?\r\n- Has code been tested manually?\r\n- Has code been covered by unit tests?\r\n- Are unit test executed on Jenkins during pull request build?\r\n- Do all unit tests pass?\r\n- Is Jira ticket state updated?\r\n\r\n## Code review checklist (for reviewers -> Copy to your comment)\r\n- Is proper destination **branch** selected?\r\n- Are proper **label** and **reviewers** selected?\r\n- Do you understand task goal and business context?\r\n- Is documentation updated and understandable?\r\n- Has code been covered by unit tests?\r\n- Did you identify technical issues/debt and reported it to TA? \r\n- Does code meet SOLID principles?\r\n- Does code meet DRY principle?\r\n- Is code in better state than before (scout rule)?","created_at":"2017-11-10T11:10:38Z","updated_at":"2017-11-10T11:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/9/commits","review_comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/9/comments","review_comment_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/9/comments","statuses_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/f4d25a104d0621485a2957d73043de8be401beb1","head":{"label":"dvsa:BL-6139-Enable-Disable-KMS","ref":"BL-6139-Enable-Disable-KMS","sha":"f4d25a104d0621485a2957d73043de8be401beb1","user":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":105773325,"name":"vehicle-recalls-api","full_name":"dvsa/vehicle-recalls-api","owner":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dvsa/vehicle-recalls-api","description":"Repository for Vehicle Recalls API","fork":false,"url":"https://api.github.com/repos/dvsa/vehicle-recalls-api","forks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/forks","keys_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/teams","hooks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/hooks","issue_events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/events","assignees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/tags","blobs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/languages","stargazers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/stargazers","contributors_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contributors","subscribers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscribers","subscription_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscription","commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/merges","archive_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/downloads","issues_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/deployments","created_at":"2017-10-04T13:42:19Z","updated_at":"2017-10-27T10:47:22Z","pushed_at":"2017-11-10T11:10:24Z","git_url":"git://github.com/dvsa/vehicle-recalls-api.git","ssh_url":"git@github.com:dvsa/vehicle-recalls-api.git","clone_url":"https://github.com/dvsa/vehicle-recalls-api.git","svn_url":"https://github.com/dvsa/vehicle-recalls-api","homepage":null,"size":190,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dvsa:master","ref":"master","sha":"0559b89ef40ab27e4ac42e8abcbc6f941b372ace","user":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":105773325,"name":"vehicle-recalls-api","full_name":"dvsa/vehicle-recalls-api","owner":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dvsa/vehicle-recalls-api","description":"Repository for Vehicle Recalls API","fork":false,"url":"https://api.github.com/repos/dvsa/vehicle-recalls-api","forks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/forks","keys_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/teams","hooks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/hooks","issue_events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/events","assignees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/tags","blobs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/languages","stargazers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/stargazers","contributors_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contributors","subscribers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscribers","subscription_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscription","commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/merges","archive_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/downloads","issues_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/deployments","created_at":"2017-10-04T13:42:19Z","updated_at":"2017-10-27T10:47:22Z","pushed_at":"2017-11-10T11:10:24Z","git_url":"git://github.com/dvsa/vehicle-recalls-api.git","ssh_url":"git@github.com:dvsa/vehicle-recalls-api.git","clone_url":"https://github.com/dvsa/vehicle-recalls-api.git","svn_url":"https://github.com/dvsa/vehicle-recalls-api","homepage":null,"size":190,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/9"},"html":{"href":"https://github.com/dvsa/vehicle-recalls-api/pull/9"},"issue":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/9"},"comments":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/f4d25a104d0621485a2957d73043de8be401beb1"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":115,"deletions":8,"changed_files":4}}
{"actor":{"display_login":"Marcin-Duszynski"}}