{"action":"closed","number":66,"pull_request":{"url":"https://api.github.com/repos/antirez/linenoise/pulls/66","id":15683972,"html_url":"https://github.com/antirez/linenoise/pull/66","diff_url":"https://github.com/antirez/linenoise/pull/66.diff","patch_url":"https://github.com/antirez/linenoise/pull/66.patch","issue_url":"https://api.github.com/repos/antirez/linenoise/issues/66","number":66,"state":"closed","locked":false,"title":"Fix compiler warnings when in C99 standards mode","user":{"login":"voithos","id":744228,"avatar_url":"https://avatars0.githubusercontent.com/u/744228?v=3","gravatar_id":"","url":"https://api.github.com/users/voithos","html_url":"https://github.com/voithos","followers_url":"https://api.github.com/users/voithos/followers","following_url":"https://api.github.com/users/voithos/following{/other_user}","gists_url":"https://api.github.com/users/voithos/gists{/gist_id}","starred_url":"https://api.github.com/users/voithos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voithos/subscriptions","organizations_url":"https://api.github.com/users/voithos/orgs","repos_url":"https://api.github.com/users/voithos/repos","events_url":"https://api.github.com/users/voithos/events{/privacy}","received_events_url":"https://api.github.com/users/voithos/received_events","type":"User","site_admin":false},"body":"Output when compiling (with `clang -Wall -std=c99`):\n\n```\nsrc/linenoise.c:201:14: warning: implicit declaration of function 'strcasecmp' is invalid\n      in C99 [-Wimplicit-function-declaration]\n        if (!strcasecmp(term,unsupported_term[j])) return 1;\n             ^\nsrc/linenoise.c:647:55: warning: implicitly declaring C library function 'strdup' with\n      type 'char *(const char *)'\n        history[history_len - 1 - l->history_index] = strdup(l->buf);\n                                                      ^\nsrc/linenoise.c:647:55: note: please include the header <string.h> or explicitly provide a\n      declaration for 'strdup'\n```\n\n`strcasecmp` just required a include of `strings.h`, but it turns out `strdup` isn't standard C - [it's a POSIX thing](http://stackoverflow.com/a/252802/716118).\n","created_at":"2014-05-09T02:16:52Z","updated_at":"2017-05-17T23:43:32Z","closed_at":"2017-05-17T23:43:32Z","merged_at":null,"merge_commit_sha":"f826ff3744a544ae20e52d78090f9b37b73d14d8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/antirez/linenoise/pulls/66/commits","review_comments_url":"https://api.github.com/repos/antirez/linenoise/pulls/66/comments","review_comment_url":"https://api.github.com/repos/antirez/linenoise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/antirez/linenoise/issues/66/comments","statuses_url":"https://api.github.com/repos/antirez/linenoise/statuses/4063b7c8a8c71aa20571cad94f0bac37a42057c6","head":{"label":"voithos:master","ref":"master","sha":"4063b7c8a8c71aa20571cad94f0bac37a42057c6","user":{"login":"voithos","id":744228,"avatar_url":"https://avatars0.githubusercontent.com/u/744228?v=3","gravatar_id":"","url":"https://api.github.com/users/voithos","html_url":"https://github.com/voithos","followers_url":"https://api.github.com/users/voithos/followers","following_url":"https://api.github.com/users/voithos/following{/other_user}","gists_url":"https://api.github.com/users/voithos/gists{/gist_id}","starred_url":"https://api.github.com/users/voithos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voithos/subscriptions","organizations_url":"https://api.github.com/users/voithos/orgs","repos_url":"https://api.github.com/users/voithos/repos","events_url":"https://api.github.com/users/voithos/events{/privacy}","received_events_url":"https://api.github.com/users/voithos/received_events","type":"User","site_admin":false},"repo":{"id":19595758,"name":"linenoise","full_name":"voithos/linenoise","owner":{"login":"voithos","id":744228,"avatar_url":"https://avatars0.githubusercontent.com/u/744228?v=3","gravatar_id":"","url":"https://api.github.com/users/voithos","html_url":"https://github.com/voithos","followers_url":"https://api.github.com/users/voithos/followers","following_url":"https://api.github.com/users/voithos/following{/other_user}","gists_url":"https://api.github.com/users/voithos/gists{/gist_id}","starred_url":"https://api.github.com/users/voithos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voithos/subscriptions","organizations_url":"https://api.github.com/users/voithos/orgs","repos_url":"https://api.github.com/users/voithos/repos","events_url":"https://api.github.com/users/voithos/events{/privacy}","received_events_url":"https://api.github.com/users/voithos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/voithos/linenoise","description":"A small self-contained alternative to readline and libedit","fork":true,"url":"https://api.github.com/repos/voithos/linenoise","forks_url":"https://api.github.com/repos/voithos/linenoise/forks","keys_url":"https://api.github.com/repos/voithos/linenoise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voithos/linenoise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voithos/linenoise/teams","hooks_url":"https://api.github.com/repos/voithos/linenoise/hooks","issue_events_url":"https://api.github.com/repos/voithos/linenoise/issues/events{/number}","events_url":"https://api.github.com/repos/voithos/linenoise/events","assignees_url":"https://api.github.com/repos/voithos/linenoise/assignees{/user}","branches_url":"https://api.github.com/repos/voithos/linenoise/branches{/branch}","tags_url":"https://api.github.com/repos/voithos/linenoise/tags","blobs_url":"https://api.github.com/repos/voithos/linenoise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voithos/linenoise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voithos/linenoise/git/refs{/sha}","trees_url":"https://api.github.com/repos/voithos/linenoise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voithos/linenoise/statuses/{sha}","languages_url":"https://api.github.com/repos/voithos/linenoise/languages","stargazers_url":"https://api.github.com/repos/voithos/linenoise/stargazers","contributors_url":"https://api.github.com/repos/voithos/linenoise/contributors","subscribers_url":"https://api.github.com/repos/voithos/linenoise/subscribers","subscription_url":"https://api.github.com/repos/voithos/linenoise/subscription","commits_url":"https://api.github.com/repos/voithos/linenoise/commits{/sha}","git_commits_url":"https://api.github.com/repos/voithos/linenoise/git/commits{/sha}","comments_url":"https://api.github.com/repos/voithos/linenoise/comments{/number}","issue_comment_url":"https://api.github.com/repos/voithos/linenoise/issues/comments{/number}","contents_url":"https://api.github.com/repos/voithos/linenoise/contents/{+path}","compare_url":"https://api.github.com/repos/voithos/linenoise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voithos/linenoise/merges","archive_url":"https://api.github.com/repos/voithos/linenoise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voithos/linenoise/downloads","issues_url":"https://api.github.com/repos/voithos/linenoise/issues{/number}","pulls_url":"https://api.github.com/repos/voithos/linenoise/pulls{/number}","milestones_url":"https://api.github.com/repos/voithos/linenoise/milestones{/number}","notifications_url":"https://api.github.com/repos/voithos/linenoise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voithos/linenoise/labels{/name}","releases_url":"https://api.github.com/repos/voithos/linenoise/releases{/id}","deployments_url":"https://api.github.com/repos/voithos/linenoise/deployments","created_at":"2014-05-09T02:08:15Z","updated_at":"2014-05-09T02:16:52Z","pushed_at":"2014-05-09T02:10:25Z","git_url":"git://github.com/voithos/linenoise.git","ssh_url":"git@github.com:voithos/linenoise.git","clone_url":"https://github.com/voithos/linenoise.git","svn_url":"https://github.com/voithos/linenoise","homepage":"","size":226,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"antirez:master","ref":"master","sha":"828b9dacc52d4ad5a15c89be8fb8691d224f9a4f","user":{"login":"antirez","id":65632,"avatar_url":"https://avatars3.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"repo":{"id":571929,"name":"linenoise","full_name":"antirez/linenoise","owner":{"login":"antirez","id":65632,"avatar_url":"https://avatars3.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antirez/linenoise","description":"A small self-contained alternative to readline and libedit","fork":false,"url":"https://api.github.com/repos/antirez/linenoise","forks_url":"https://api.github.com/repos/antirez/linenoise/forks","keys_url":"https://api.github.com/repos/antirez/linenoise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antirez/linenoise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antirez/linenoise/teams","hooks_url":"https://api.github.com/repos/antirez/linenoise/hooks","issue_events_url":"https://api.github.com/repos/antirez/linenoise/issues/events{/number}","events_url":"https://api.github.com/repos/antirez/linenoise/events","assignees_url":"https://api.github.com/repos/antirez/linenoise/assignees{/user}","branches_url":"https://api.github.com/repos/antirez/linenoise/branches{/branch}","tags_url":"https://api.github.com/repos/antirez/linenoise/tags","blobs_url":"https://api.github.com/repos/antirez/linenoise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antirez/linenoise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antirez/linenoise/git/refs{/sha}","trees_url":"https://api.github.com/repos/antirez/linenoise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antirez/linenoise/statuses/{sha}","languages_url":"https://api.github.com/repos/antirez/linenoise/languages","stargazers_url":"https://api.github.com/repos/antirez/linenoise/stargazers","contributors_url":"https://api.github.com/repos/antirez/linenoise/contributors","subscribers_url":"https://api.github.com/repos/antirez/linenoise/subscribers","subscription_url":"https://api.github.com/repos/antirez/linenoise/subscription","commits_url":"https://api.github.com/repos/antirez/linenoise/commits{/sha}","git_commits_url":"https://api.github.com/repos/antirez/linenoise/git/commits{/sha}","comments_url":"https://api.github.com/repos/antirez/linenoise/comments{/number}","issue_comment_url":"https://api.github.com/repos/antirez/linenoise/issues/comments{/number}","contents_url":"https://api.github.com/repos/antirez/linenoise/contents/{+path}","compare_url":"https://api.github.com/repos/antirez/linenoise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antirez/linenoise/merges","archive_url":"https://api.github.com/repos/antirez/linenoise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antirez/linenoise/downloads","issues_url":"https://api.github.com/repos/antirez/linenoise/issues{/number}","pulls_url":"https://api.github.com/repos/antirez/linenoise/pulls{/number}","milestones_url":"https://api.github.com/repos/antirez/linenoise/milestones{/number}","notifications_url":"https://api.github.com/repos/antirez/linenoise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antirez/linenoise/labels{/name}","releases_url":"https://api.github.com/repos/antirez/linenoise/releases{/id}","deployments_url":"https://api.github.com/repos/antirez/linenoise/deployments","created_at":"2010-03-20T23:01:29Z","updated_at":"2017-05-17T15:51:59Z","pushed_at":"2017-05-05T17:49:18Z","git_url":"git://github.com/antirez/linenoise.git","ssh_url":"git@github.com:antirez/linenoise.git","clone_url":"https://github.com/antirez/linenoise.git","svn_url":"https://github.com/antirez/linenoise","homepage":"","size":529,"stargazers_count":1661,"watchers_count":1661,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":84,"forks":317,"open_issues":84,"watchers":1661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/antirez/linenoise/pulls/66"},"html":{"href":"https://github.com/antirez/linenoise/pull/66"},"issue":{"href":"https://api.github.com/repos/antirez/linenoise/issues/66"},"comments":{"href":"https://api.github.com/repos/antirez/linenoise/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/antirez/linenoise/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/antirez/linenoise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/antirez/linenoise/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/antirez/linenoise/statuses/4063b7c8a8c71aa20571cad94f0bac37a42057c6"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"voithos"}}