{"action":"created","comment":{"url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/comments/141194164","pull_request_review_id":65372668,"id":141194164,"diff_hunk":"@@ -111,6 +111,14 @@ function sendNotification(message, callback) {\n         message.timestamp = Math.round(message.timestamp / 1000);\r\n     }\r\n \r\n+    // mandatory parameters if priority is high (2)\r\n+    if (message.priority && message.priority === 2) {\r\n+        if (!message.expire || !message.retry) {\r\n+            message.retry = 60;\r","path":"pushover.js","position":7,"original_position":7,"commit_id":"0cb3db56292b1e9cbc52bf300fc326e364204a37","original_commit_id":"0cb3db56292b1e9cbc52bf300fc326e364204a37","user":{"login":"GermanBluefox","id":4582016,"avatar_url":"https://avatars1.githubusercontent.com/u/4582016?v=4","gravatar_id":"","url":"https://api.github.com/users/GermanBluefox","html_url":"https://github.com/GermanBluefox","followers_url":"https://api.github.com/users/GermanBluefox/followers","following_url":"https://api.github.com/users/GermanBluefox/following{/other_user}","gists_url":"https://api.github.com/users/GermanBluefox/gists{/gist_id}","starred_url":"https://api.github.com/users/GermanBluefox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GermanBluefox/subscriptions","organizations_url":"https://api.github.com/users/GermanBluefox/orgs","repos_url":"https://api.github.com/users/GermanBluefox/repos","events_url":"https://api.github.com/users/GermanBluefox/events{/privacy}","received_events_url":"https://api.github.com/users/GermanBluefox/received_events","type":"User","site_admin":false},"body":"I would write so: message.retry = message.retry || 60;","created_at":"2017-09-26T21:48:18Z","updated_at":"2017-09-26T21:50:50Z","html_url":"https://github.com/ioBroker/ioBroker.pushover/pull/2#discussion_r141194164","pull_request_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/comments/141194164"},"html":{"href":"https://github.com/ioBroker/ioBroker.pushover/pull/2#discussion_r141194164"},"pull_request":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2","id":143225645,"html_url":"https://github.com/ioBroker/ioBroker.pushover/pull/2","diff_url":"https://github.com/ioBroker/ioBroker.pushover/pull/2.diff","patch_url":"https://github.com/ioBroker/ioBroker.pushover/pull/2.patch","issue_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/issues/2","number":2,"state":"open","locked":false,"title":"check for mandatory parameters if priority is high","user":{"login":"Tan-DE","id":6084242,"avatar_url":"https://avatars1.githubusercontent.com/u/6084242?v=4","gravatar_id":"","url":"https://api.github.com/users/Tan-DE","html_url":"https://github.com/Tan-DE","followers_url":"https://api.github.com/users/Tan-DE/followers","following_url":"https://api.github.com/users/Tan-DE/following{/other_user}","gists_url":"https://api.github.com/users/Tan-DE/gists{/gist_id}","starred_url":"https://api.github.com/users/Tan-DE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tan-DE/subscriptions","organizations_url":"https://api.github.com/users/Tan-DE/orgs","repos_url":"https://api.github.com/users/Tan-DE/repos","events_url":"https://api.github.com/users/Tan-DE/events{/privacy}","received_events_url":"https://api.github.com/users/Tan-DE/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-26T19:44:40Z","updated_at":"2017-09-26T21:50:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c1085d3544049bbfc28c343354dac869e684c3f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/issues/2/comments","statuses_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/statuses/0cb3db56292b1e9cbc52bf300fc326e364204a37","head":{"label":"Tan-DE:master","ref":"master","sha":"0cb3db56292b1e9cbc52bf300fc326e364204a37","user":{"login":"Tan-DE","id":6084242,"avatar_url":"https://avatars1.githubusercontent.com/u/6084242?v=4","gravatar_id":"","url":"https://api.github.com/users/Tan-DE","html_url":"https://github.com/Tan-DE","followers_url":"https://api.github.com/users/Tan-DE/followers","following_url":"https://api.github.com/users/Tan-DE/following{/other_user}","gists_url":"https://api.github.com/users/Tan-DE/gists{/gist_id}","starred_url":"https://api.github.com/users/Tan-DE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tan-DE/subscriptions","organizations_url":"https://api.github.com/users/Tan-DE/orgs","repos_url":"https://api.github.com/users/Tan-DE/repos","events_url":"https://api.github.com/users/Tan-DE/events{/privacy}","received_events_url":"https://api.github.com/users/Tan-DE/received_events","type":"User","site_admin":false},"repo":{"id":104586167,"name":"ioBroker.pushover","full_name":"Tan-DE/ioBroker.pushover","owner":{"login":"Tan-DE","id":6084242,"avatar_url":"https://avatars1.githubusercontent.com/u/6084242?v=4","gravatar_id":"","url":"https://api.github.com/users/Tan-DE","html_url":"https://github.com/Tan-DE","followers_url":"https://api.github.com/users/Tan-DE/followers","following_url":"https://api.github.com/users/Tan-DE/following{/other_user}","gists_url":"https://api.github.com/users/Tan-DE/gists{/gist_id}","starred_url":"https://api.github.com/users/Tan-DE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tan-DE/subscriptions","organizations_url":"https://api.github.com/users/Tan-DE/orgs","repos_url":"https://api.github.com/users/Tan-DE/repos","events_url":"https://api.github.com/users/Tan-DE/events{/privacy}","received_events_url":"https://api.github.com/users/Tan-DE/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tan-DE/ioBroker.pushover","description":"Send Pushover notifications","fork":true,"url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover","forks_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/forks","keys_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/teams","hooks_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/hooks","issue_events_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/issues/events{/number}","events_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/events","assignees_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/assignees{/user}","branches_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/branches{/branch}","tags_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/tags","blobs_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/statuses/{sha}","languages_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/languages","stargazers_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/stargazers","contributors_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/contributors","subscribers_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/subscribers","subscription_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/subscription","commits_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/contents/{+path}","compare_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/merges","archive_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/downloads","issues_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/issues{/number}","pulls_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/pulls{/number}","milestones_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/milestones{/number}","notifications_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/labels{/name}","releases_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/releases{/id}","deployments_url":"https://api.github.com/repos/Tan-DE/ioBroker.pushover/deployments","created_at":"2017-09-23T17:31:51Z","updated_at":"2017-09-23T17:31:52Z","pushed_at":"2017-09-24T07:42:03Z","git_url":"git://github.com/Tan-DE/ioBroker.pushover.git","ssh_url":"git@github.com:Tan-DE/ioBroker.pushover.git","clone_url":"https://github.com/Tan-DE/ioBroker.pushover.git","svn_url":"https://github.com/Tan-DE/ioBroker.pushover","homepage":"http://www.iobroker.org","size":217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ioBroker:master","ref":"master","sha":"98ab01123fbf83b18fb33de180253cb00373664a","user":{"login":"ioBroker","id":7231148,"avatar_url":"https://avatars1.githubusercontent.com/u/7231148?v=4","gravatar_id":"","url":"https://api.github.com/users/ioBroker","html_url":"https://github.com/ioBroker","followers_url":"https://api.github.com/users/ioBroker/followers","following_url":"https://api.github.com/users/ioBroker/following{/other_user}","gists_url":"https://api.github.com/users/ioBroker/gists{/gist_id}","starred_url":"https://api.github.com/users/ioBroker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioBroker/subscriptions","organizations_url":"https://api.github.com/users/ioBroker/orgs","repos_url":"https://api.github.com/users/ioBroker/repos","events_url":"https://api.github.com/users/ioBroker/events{/privacy}","received_events_url":"https://api.github.com/users/ioBroker/received_events","type":"Organization","site_admin":false},"repo":{"id":22218600,"name":"ioBroker.pushover","full_name":"ioBroker/ioBroker.pushover","owner":{"login":"ioBroker","id":7231148,"avatar_url":"https://avatars1.githubusercontent.com/u/7231148?v=4","gravatar_id":"","url":"https://api.github.com/users/ioBroker","html_url":"https://github.com/ioBroker","followers_url":"https://api.github.com/users/ioBroker/followers","following_url":"https://api.github.com/users/ioBroker/following{/other_user}","gists_url":"https://api.github.com/users/ioBroker/gists{/gist_id}","starred_url":"https://api.github.com/users/ioBroker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioBroker/subscriptions","organizations_url":"https://api.github.com/users/ioBroker/orgs","repos_url":"https://api.github.com/users/ioBroker/repos","events_url":"https://api.github.com/users/ioBroker/events{/privacy}","received_events_url":"https://api.github.com/users/ioBroker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioBroker/ioBroker.pushover","description":"Send Pushover notifications","fork":false,"url":"https://api.github.com/repos/ioBroker/ioBroker.pushover","forks_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/forks","keys_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/teams","hooks_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/hooks","issue_events_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/issues/events{/number}","events_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/events","assignees_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/assignees{/user}","branches_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/branches{/branch}","tags_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/tags","blobs_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/statuses/{sha}","languages_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/languages","stargazers_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/stargazers","contributors_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/contributors","subscribers_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/subscribers","subscription_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/subscription","commits_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/contents/{+path}","compare_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/merges","archive_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/downloads","issues_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/issues{/number}","pulls_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls{/number}","milestones_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/milestones{/number}","notifications_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/labels{/name}","releases_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/releases{/id}","deployments_url":"https://api.github.com/repos/ioBroker/ioBroker.pushover/deployments","created_at":"2014-07-24T15:36:59Z","updated_at":"2017-05-22T04:28:18Z","pushed_at":"2017-09-26T19:44:41Z","git_url":"git://github.com/ioBroker/ioBroker.pushover.git","ssh_url":"git@github.com:ioBroker/ioBroker.pushover.git","clone_url":"https://github.com/ioBroker/ioBroker.pushover.git","svn_url":"https://github.com/ioBroker/ioBroker.pushover","homepage":"http://www.iobroker.org","size":217,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2"},"html":{"href":"https://github.com/ioBroker/ioBroker.pushover/pull/2"},"issue":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/issues/2"},"comments":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ioBroker/ioBroker.pushover/statuses/0cb3db56292b1e9cbc52bf300fc326e364204a37"}},"author_association":"NONE"}}
{"actor":{"display_login":"GermanBluefox"}}