{"push_id":2198825401,"size":1,"distinct_size":1,"ref":"refs/heads/restart-container","head":"737c4f8cdbb1cd51bf981ee2b4facd857f50be81","before":"ce4252207cfa5427d329596ba5daa49ca38d4d66","commits":[{"sha":"737c4f8cdbb1cd51bf981ee2b4facd857f50be81","author":{"name":"Sébastien Han","email":"e2ba7250dc5f94b9401213481ffb2f00f50cc5ee@redhat.com"},"message":"container: restart container when there is a new image\n\nThis wasn't any good choice to implement this.\nWe had several options and none of them were ideal since handlers can\nnot be triggered cross-roles.\nWe could have achieved that by doing:\n\n* option 1 was to add a dependancy in the meta of the ceph-docker-common\nrole. We had that long ago and we decided to stop so everything is\nmanaged via site.yml\n\n* option 2 was to import files from another role. This is messy and we\ndon't that anywhere in the current code base. We will continue to do so.\n\nThere is option 3 where we pull the image from the ceph-config role.\nThis is not suitable as well since the docker command won't be available\nunless you run Atomic distro. This would also mean that you're trying to\npull twice. First time in ceph-config, second time in ceph-docker-common\n\nThe only option I came up with was to duplicate a bit of the ceph-config\nhandlers code.\n\nSigned-off-by: Sébastien Han <seb@redhat.com>","distinct":true,"url":"https://api.github.com/repos/ceph/ceph-ansible/commits/737c4f8cdbb1cd51bf981ee2b4facd857f50be81"}]}
{"actor":{"display_login":"leseb"}}