{"action":"created","issue":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/2460","repository_url":"https://api.github.com/repos/phoenixframework/phoenix","labels_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/2460/labels{/name}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/2460/comments","events_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/2460/events","html_url":"https://github.com/phoenixframework/phoenix/issues/2460","id":252747526,"number":2460,"title":"mix phx.routes no longer reports route collisions","user":{"login":"RobertDeRose","id":388745,"avatar_url":"https://avatars1.githubusercontent.com/u/388745?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertDeRose","html_url":"https://github.com/RobertDeRose","followers_url":"https://api.github.com/users/RobertDeRose/followers","following_url":"https://api.github.com/users/RobertDeRose/following{/other_user}","gists_url":"https://api.github.com/users/RobertDeRose/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertDeRose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertDeRose/subscriptions","organizations_url":"https://api.github.com/users/RobertDeRose/orgs","repos_url":"https://api.github.com/users/RobertDeRose/repos","events_url":"https://api.github.com/users/RobertDeRose/events{/privacy}","received_events_url":"https://api.github.com/users/RobertDeRose/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"Gazler","id":477511,"avatar_url":"https://avatars3.githubusercontent.com/u/477511?v=4","gravatar_id":"","url":"https://api.github.com/users/Gazler","html_url":"https://github.com/Gazler","followers_url":"https://api.github.com/users/Gazler/followers","following_url":"https://api.github.com/users/Gazler/following{/other_user}","gists_url":"https://api.github.com/users/Gazler/gists{/gist_id}","starred_url":"https://api.github.com/users/Gazler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gazler/subscriptions","organizations_url":"https://api.github.com/users/Gazler/orgs","repos_url":"https://api.github.com/users/Gazler/repos","events_url":"https://api.github.com/users/Gazler/events{/privacy}","received_events_url":"https://api.github.com/users/Gazler/received_events","type":"User","site_admin":false},"assignees":[{"login":"Gazler","id":477511,"avatar_url":"https://avatars3.githubusercontent.com/u/477511?v=4","gravatar_id":"","url":"https://api.github.com/users/Gazler","html_url":"https://github.com/Gazler","followers_url":"https://api.github.com/users/Gazler/followers","following_url":"https://api.github.com/users/Gazler/following{/other_user}","gists_url":"https://api.github.com/users/Gazler/gists{/gist_id}","starred_url":"https://api.github.com/users/Gazler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gazler/subscriptions","organizations_url":"https://api.github.com/users/Gazler/orgs","repos_url":"https://api.github.com/users/Gazler/repos","events_url":"https://api.github.com/users/Gazler/events{/privacy}","received_events_url":"https://api.github.com/users/Gazler/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-08-24T22:19:56Z","updated_at":"2017-11-11T15:57:43Z","closed_at":"2017-08-25T18:52:22Z","author_association":"NONE","body":"<!--\r\n### Precheck\r\n\r\n* For help and support, use Stack Overflow or the Phoenix Talk mailing list\r\n* For proposing a new feature, start a discussion on the Phoenix Core mailing list\r\n* For bugs, do a quick search and make sure the bug has not yet been reported\r\n* Ensure that this issue is related to the Phoenix library and not one of the dependencies listed in mix.exs (Ecto, Plug, etc.)\r\n* All checked? Be nice and have fun!\r\n-->\r\n\r\n### Environment\r\n\r\n* Elixir version (elixir -v): \r\n   ```\r\n   elixir -v\r\n   Erlang/OTP 20 [erts-9.0] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:10] [hipe] [kernel-poll:false] [dtrace]\r\n  \r\n   Elixir 1.5.1\r\n   ```\r\n* Phoenix version (mix deps):\r\n   ```\r\n    file_system 0.1.5\r\n    connection 1.0.4\r\n    gettext 0.13.1\r\n    ranch 1.3.2\r\n    poolboy 1.5.1\r\n    decimal 1.4.0\r\n    poison 3.1.0\r\n    db_connection 1.1.2\r\n    phoenix_pubsub 1.0.2\r\n    cowlib 1.0.2\r\n    cowboy 1.1.2\r\n    mime 1.1.0\r\n    plug 1.4.3\r\n    phoenix_html 2.10.4\r\n    phoenix 1.3.0\r\n    phoenix_live_reload 1.1.0\r\n    mariaex 0.8.3\r\n    ecto 2.2.0\r\n    phoenix_ecto 3.2.3\r\n    ```\r\n* NodeJS version (node -v): `v8.4.0`\r\n* NPM version (npm -v): `5.3.0`\r\n* Operating system: macOS 10.12.6\r\n\r\n### Expected behavior\r\nTo get a warning similar to this\r\n\r\n```\r\nwarning: this clause cannot match because a previous clause at line 16 always matches\r\n```\r\n\r\n### Actual behavior\r\n\r\nNo Warning is produced when defining conflicting routes:\r\n\r\n```elixir\r\n  scope \"/admin\", HelloWeb.Admin, as: :admin do\r\n    pipe_through :browser\r\n\r\n    resources \"/reviews\", ReviewController\r\n  end\r\n\r\n  scope \"/admin\", Something, as: :something do\r\n    resources \"/reviews\", ReviewController\r\n  end\r\n```\r\n\r\n`mix phx.routes` produces:\r\n\r\n```bash\r\nmix phx.routes\r\nCompiling 8 files (.ex)\r\n    admin_review_path  GET     /admin/reviews                  HelloWeb.Admin.ReviewController :index\r\n    admin_review_path  GET     /admin/reviews/:id/edit         HelloWeb.Admin.ReviewController :edit\r\n    admin_review_path  GET     /admin/reviews/new              HelloWeb.Admin.ReviewController :new\r\n    admin_review_path  GET     /admin/reviews/:id              HelloWeb.Admin.ReviewController :show\r\n    admin_review_path  POST    /admin/reviews                  HelloWeb.Admin.ReviewController :create\r\n    admin_review_path  PATCH   /admin/reviews/:id              HelloWeb.Admin.ReviewController :update\r\n                       PUT     /admin/reviews/:id              HelloWeb.Admin.ReviewController :update\r\n    admin_review_path  DELETE  /admin/reviews/:id              HelloWeb.Admin.ReviewController :delete\r\nsomething_review_path  GET     /admin/reviews                  Something.ReviewController :index\r\nsomething_review_path  GET     /admin/reviews/:id/edit         Something.ReviewController :edit\r\nsomething_review_path  GET     /admin/reviews/new              Something.ReviewController :new\r\nsomething_review_path  GET     /admin/reviews/:id              Something.ReviewController :show\r\nsomething_review_path  POST    /admin/reviews                  Something.ReviewController :create\r\nsomething_review_path  PATCH   /admin/reviews/:id              Something.ReviewController :update\r\n                       PUT     /admin/reviews/:id              Something.ReviewController :update\r\nsomething_review_path  DELETE  /admin/reviews/:id              Something.ReviewController :delete\r\n```\r\n\r\nno error or warning are produced"},"comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/comments/343674567","html_url":"https://github.com/phoenixframework/phoenix/issues/2460#issuecomment-343674567","issue_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/2460","id":343674567,"user":{"login":"getschomp","id":5835824,"avatar_url":"https://avatars0.githubusercontent.com/u/5835824?v=4","gravatar_id":"","url":"https://api.github.com/users/getschomp","html_url":"https://github.com/getschomp","followers_url":"https://api.github.com/users/getschomp/followers","following_url":"https://api.github.com/users/getschomp/following{/other_user}","gists_url":"https://api.github.com/users/getschomp/gists{/gist_id}","starred_url":"https://api.github.com/users/getschomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getschomp/subscriptions","organizations_url":"https://api.github.com/users/getschomp/orgs","repos_url":"https://api.github.com/users/getschomp/repos","events_url":"https://api.github.com/users/getschomp/events{/privacy}","received_events_url":"https://api.github.com/users/getschomp/received_events","type":"User","site_admin":false},"created_at":"2017-11-11T15:57:43Z","updated_at":"2017-11-11T15:57:43Z","author_association":"NONE","body":"Hitting this issue:\r\n\r\n~/hello\r\n❯ mix compile\r\nCompiling 1 file (.ex)\r\n\r\n~/hello\r\n❯ mix phx.routes\r\nCompiling 8 files (.ex)\r\n page_path  GET  /                  HelloWeb.PageController :index\r\n root_path  GET  /                  HelloWeb.RootController :index\r\nhello_path  GET  /hello             HelloWeb.HelloController :index\r\nhello_path  GET  /hello/:messenger  HelloWeb.HelloController :show\r\n\r\n~/hello\r\n❯ mix phoenix.new -v\r\nPhoenix v1.3.0\r\n\r\n~/hello\r\n❯ elixir -v\r\nErlang/OTP 20 [erts-9.1.3] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:10] [hipe] [kernel-poll:false] [dtrace]\r\n\r\nElixir 1.5.1\r\n"}}
{"actor":{"display_login":"getschomp"}}