{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/28","id":105701135,"html_url":"https://github.com/saltstack-formulas/elasticsearch-formula/pull/28","diff_url":"https://github.com/saltstack-formulas/elasticsearch-formula/pull/28.diff","patch_url":"https://github.com/saltstack-formulas/elasticsearch-formula/pull/28.patch","issue_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/issues/28","number":28,"state":"closed","locked":false,"title":"Manage /etc/elasticsearch/jvm.options for ES5","user":{"login":"cmclaughlin","id":1061109,"avatar_url":"https://avatars.githubusercontent.com/u/1061109?v=3","gravatar_id":"","url":"https://api.github.com/users/cmclaughlin","html_url":"https://github.com/cmclaughlin","followers_url":"https://api.github.com/users/cmclaughlin/followers","following_url":"https://api.github.com/users/cmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/cmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/cmclaughlin/orgs","repos_url":"https://api.github.com/users/cmclaughlin/repos","events_url":"https://api.github.com/users/cmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/cmclaughlin/received_events","type":"User","site_admin":false},"body":"I'm using a combination of /etc/sysconfig/elasticsearch which is managed\r\nby this formula and /etc/elasticsearch/jvm.options which is not.\r\nI think it's best to give users the option to use all the config files,\r\nso this simply populates jvm.options from Pillar. I've added the\r\ndefaults from jvm.options on a fresh installation to the example Pillar\r\ntoo.\r\n\r\nCloses issue #20.","created_at":"2017-02-10T20:36:25Z","updated_at":"2017-02-14T14:38:54Z","closed_at":"2017-02-14T14:38:53Z","merged_at":"2017-02-14T14:38:53Z","merge_commit_sha":"8b1d071bc0987d4b013764bedd25f55cf15e6f22","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/28/commits","review_comments_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/28/comments","review_comment_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/issues/28/comments","statuses_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/statuses/33aae9d4dda275339c7917c320b3a5a6e36fd2f5","head":{"label":"cmclaughlin:charles-jvmopts","ref":"charles-jvmopts","sha":"33aae9d4dda275339c7917c320b3a5a6e36fd2f5","user":{"login":"cmclaughlin","id":1061109,"avatar_url":"https://avatars.githubusercontent.com/u/1061109?v=3","gravatar_id":"","url":"https://api.github.com/users/cmclaughlin","html_url":"https://github.com/cmclaughlin","followers_url":"https://api.github.com/users/cmclaughlin/followers","following_url":"https://api.github.com/users/cmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/cmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/cmclaughlin/orgs","repos_url":"https://api.github.com/users/cmclaughlin/repos","events_url":"https://api.github.com/users/cmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/cmclaughlin/received_events","type":"User","site_admin":false},"repo":{"id":78156316,"name":"elasticsearch-formula","full_name":"cmclaughlin/elasticsearch-formula","owner":{"login":"cmclaughlin","id":1061109,"avatar_url":"https://avatars.githubusercontent.com/u/1061109?v=3","gravatar_id":"","url":"https://api.github.com/users/cmclaughlin","html_url":"https://github.com/cmclaughlin","followers_url":"https://api.github.com/users/cmclaughlin/followers","following_url":"https://api.github.com/users/cmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/cmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/cmclaughlin/orgs","repos_url":"https://api.github.com/users/cmclaughlin/repos","events_url":"https://api.github.com/users/cmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/cmclaughlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmclaughlin/elasticsearch-formula","description":null,"fork":true,"url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula","forks_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/forks","keys_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/teams","hooks_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/hooks","issue_events_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/issues/events{/number}","events_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/events","assignees_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/assignees{/user}","branches_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/branches{/branch}","tags_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/tags","blobs_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/languages","stargazers_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/stargazers","contributors_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/contributors","subscribers_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/subscribers","subscription_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/subscription","commits_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/contents/{+path}","compare_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/merges","archive_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/downloads","issues_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/issues{/number}","pulls_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/labels{/name}","releases_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/releases{/id}","deployments_url":"https://api.github.com/repos/cmclaughlin/elasticsearch-formula/deployments","created_at":"2017-01-05T23:19:48Z","updated_at":"2017-01-05T23:19:51Z","pushed_at":"2017-02-13T05:04:23Z","git_url":"git://github.com/cmclaughlin/elasticsearch-formula.git","ssh_url":"git@github.com:cmclaughlin/elasticsearch-formula.git","clone_url":"https://github.com/cmclaughlin/elasticsearch-formula.git","svn_url":"https://github.com/cmclaughlin/elasticsearch-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":26,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack-formulas:master","ref":"master","sha":"6aefa5434f264bfbef2535f40479611ef295d17b","user":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":63407962,"name":"elasticsearch-formula","full_name":"saltstack-formulas/elasticsearch-formula","owner":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack-formulas/elasticsearch-formula","description":null,"fork":false,"url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula","forks_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/forks","keys_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/teams","hooks_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/hooks","issue_events_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/events","assignees_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/tags","blobs_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/languages","stargazers_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/stargazers","contributors_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/contributors","subscribers_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/subscribers","subscription_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/subscription","commits_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/merges","archive_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/downloads","issues_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/labels{/name}","releases_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/deployments","created_at":"2016-07-15T09:06:01Z","updated_at":"2016-12-15T02:05:09Z","pushed_at":"2017-02-14T14:38:53Z","git_url":"git://github.com/saltstack-formulas/elasticsearch-formula.git","ssh_url":"git@github.com:saltstack-formulas/elasticsearch-formula.git","clone_url":"https://github.com/saltstack-formulas/elasticsearch-formula.git","svn_url":"https://github.com/saltstack-formulas/elasticsearch-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":21,"stargazers_count":5,"watchers_count":5,"language":"SaltStack","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":10,"forks":36,"open_issues":10,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/28"},"html":{"href":"https://github.com/saltstack-formulas/elasticsearch-formula/pull/28"},"issue":{"href":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/issues/28"},"comments":{"href":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack-formulas/elasticsearch-formula/statuses/33aae9d4dda275339c7917c320b3a5a6e36fd2f5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"blbradley","id":1435085,"avatar_url":"https://avatars.githubusercontent.com/u/1435085?v=3","gravatar_id":"","url":"https://api.github.com/users/blbradley","html_url":"https://github.com/blbradley","followers_url":"https://api.github.com/users/blbradley/followers","following_url":"https://api.github.com/users/blbradley/following{/other_user}","gists_url":"https://api.github.com/users/blbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/blbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blbradley/subscriptions","organizations_url":"https://api.github.com/users/blbradley/orgs","repos_url":"https://api.github.com/users/blbradley/repos","events_url":"https://api.github.com/users/blbradley/events{/privacy}","received_events_url":"https://api.github.com/users/blbradley/received_events","type":"User","site_admin":false},"comments":7,"review_comments":6,"maintainer_can_modify":false,"commits":4,"additions":24,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"blbradley"}}