{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/oauth-proxy/pulls/comments/113093561","pull_request_review_id":34455531,"id":113093561,"diff_hunk":"@@ -160,6 +160,19 @@ func (p *OpenShiftProvider) Configure(groups, reviews string, caPaths []string)\n \treturn nil\n }\n \n+func (p *OpenShiftProvider) ClientCertVerification(cn string) func(cert *x509.Certificate) (*SessionState, error) {\n+\tif len(cn) == 0 {\n+\t\treturn nil\n+\t}\n+\treturn func(cert *x509.Certificate) (*SessionState, error) {\n+\t\tif cn == cert.Subject.CommonName {\n+\t\t\treturn &SessionState{User: cert.Subject.CommonName, Email: cert.Subject.CommonName + \"@cluster.local\"}, nil","path":"providers/openshift.go","position":10,"original_position":10,"commit_id":"4d1264da9015913e3d9d7ea2fbdde5d57b6d4fd9","original_commit_id":"4d1264da9015913e3d9d7ea2fbdde5d57b6d4fd9","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars3.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"is email required? this is a really really weird way to make one up","created_at":"2017-04-25T01:57:09Z","updated_at":"2017-04-25T01:57:09Z","html_url":"https://github.com/openshift/oauth-proxy/pull/1#discussion_r113093561","pull_request_url":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/openshift/oauth-proxy/pulls/comments/113093561"},"html":{"href":"https://github.com/openshift/oauth-proxy/pull/1#discussion_r113093561"},"pull_request":{"href":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1","id":117384907,"html_url":"https://github.com/openshift/oauth-proxy/pull/1","diff_url":"https://github.com/openshift/oauth-proxy/pull/1.diff","patch_url":"https://github.com/openshift/oauth-proxy/pull/1.patch","issue_url":"https://api.github.com/repos/openshift/oauth-proxy/issues/1","number":1,"state":"open","locked":false,"title":"Enable client cert authentication for clients","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Allow clients to specify:\n\n```\n-tls-client-ca FILE to define client CA roots\n-openshift-client-cert-cn NAME to define a common name granted access\n```\n\nThe server will allow any NAME that verifies against any FILE via SSL to bypass normal authorization.","created_at":"2017-04-25T00:44:12Z","updated_at":"2017-04-25T01:57:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75eb59e63e943b490344a18bf425a80eaf168f13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1/commits","review_comments_url":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1/comments","review_comment_url":"https://api.github.com/repos/openshift/oauth-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/oauth-proxy/issues/1/comments","statuses_url":"https://api.github.com/repos/openshift/oauth-proxy/statuses/4d1264da9015913e3d9d7ea2fbdde5d57b6d4fd9","head":{"label":"smarterclayton:cert","ref":"cert","sha":"4d1264da9015913e3d9d7ea2fbdde5d57b6d4fd9","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"repo":{"id":87869923,"name":"oauth2_proxy","full_name":"smarterclayton/oauth2_proxy","owner":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smarterclayton/oauth2_proxy","description":"A reverse proxy that provides authentication with Google, Github or other provider","fork":true,"url":"https://api.github.com/repos/smarterclayton/oauth2_proxy","forks_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/forks","keys_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/teams","hooks_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/hooks","issue_events_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/issues/events{/number}","events_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/events","assignees_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/assignees{/user}","branches_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/branches{/branch}","tags_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/tags","blobs_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/languages","stargazers_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/stargazers","contributors_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/contributors","subscribers_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/subscribers","subscription_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/subscription","commits_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/contents/{+path}","compare_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/merges","archive_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/downloads","issues_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/issues{/number}","pulls_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/labels{/name}","releases_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/releases{/id}","deployments_url":"https://api.github.com/repos/smarterclayton/oauth2_proxy/deployments","created_at":"2017-04-11T00:23:38Z","updated_at":"2017-04-11T00:23:40Z","pushed_at":"2017-04-25T00:38:40Z","git_url":"git://github.com/smarterclayton/oauth2_proxy.git","ssh_url":"git@github.com:smarterclayton/oauth2_proxy.git","clone_url":"https://github.com/smarterclayton/oauth2_proxy.git","svn_url":"https://github.com/smarterclayton/oauth2_proxy","homepage":"","size":403,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"423edf1fb7374a981c613ae639ebbc2c88430859","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":88303453,"name":"oauth-proxy","full_name":"openshift/oauth-proxy","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/oauth-proxy","description":"A reverse proxy that provides authentication with OpenShift and other OAuth providers","fork":true,"url":"https://api.github.com/repos/openshift/oauth-proxy","forks_url":"https://api.github.com/repos/openshift/oauth-proxy/forks","keys_url":"https://api.github.com/repos/openshift/oauth-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/oauth-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/oauth-proxy/teams","hooks_url":"https://api.github.com/repos/openshift/oauth-proxy/hooks","issue_events_url":"https://api.github.com/repos/openshift/oauth-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/oauth-proxy/events","assignees_url":"https://api.github.com/repos/openshift/oauth-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/oauth-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/oauth-proxy/tags","blobs_url":"https://api.github.com/repos/openshift/oauth-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/oauth-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/oauth-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/oauth-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/oauth-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/oauth-proxy/languages","stargazers_url":"https://api.github.com/repos/openshift/oauth-proxy/stargazers","contributors_url":"https://api.github.com/repos/openshift/oauth-proxy/contributors","subscribers_url":"https://api.github.com/repos/openshift/oauth-proxy/subscribers","subscription_url":"https://api.github.com/repos/openshift/oauth-proxy/subscription","commits_url":"https://api.github.com/repos/openshift/oauth-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/oauth-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/oauth-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/oauth-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/oauth-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/oauth-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/oauth-proxy/merges","archive_url":"https://api.github.com/repos/openshift/oauth-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/oauth-proxy/downloads","issues_url":"https://api.github.com/repos/openshift/oauth-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/oauth-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/oauth-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/oauth-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/oauth-proxy/labels{/name}","releases_url":"https://api.github.com/repos/openshift/oauth-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/oauth-proxy/deployments","created_at":"2017-04-14T21:07:35Z","updated_at":"2017-04-18T23:44:00Z","pushed_at":"2017-04-25T00:44:12Z","git_url":"git://github.com/openshift/oauth-proxy.git","ssh_url":"git@github.com:openshift/oauth-proxy.git","clone_url":"https://github.com/openshift/oauth-proxy.git","svn_url":"https://github.com/openshift/oauth-proxy","homepage":"","size":399,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1"},"html":{"href":"https://github.com/openshift/oauth-proxy/pull/1"},"issue":{"href":"https://api.github.com/repos/openshift/oauth-proxy/issues/1"},"comments":{"href":"https://api.github.com/repos/openshift/oauth-proxy/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/oauth-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/oauth-proxy/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/oauth-proxy/statuses/4d1264da9015913e3d9d7ea2fbdde5d57b6d4fd9"}}}}
{"actor":{"display_login":"liggitt"}}