{"action":"created","comment":{"url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments/111567287","pull_request_review_id":32822387,"id":111567287,"diff_hunk":"@@ -22,12 +22,28 @@ static int dev_uart_write(vnode_t *t, uio_t *uio) {\n }\n \n static int dev_uart_read(vnode_t *t, uio_t *uio) {\n+  char buffer[UART_BUF_MAX];\n+  unsigned curr = 0;\n+  while (curr < UART_BUF_MAX && curr < uio->uio_resid) {\n+    buffer[curr] = uart_getchar();","path":"sys/dev_uart.c","position":7,"original_position":7,"commit_id":"bf8616a81e9688402a6175c4eb34046f87522f81","original_commit_id":"bf8616a81e9688402a6175c4eb34046f87522f81","user":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars0.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"body":"This should not busy-loop but rather use `sleepq_wait`, while interrupt handler should call `sleepq_signal`. ","created_at":"2017-04-14T12:22:26Z","updated_at":"2017-04-14T12:22:26Z","html_url":"https://github.com/cahirwpz/mimiker/pull/257#discussion_r111567287","pull_request_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments/111567287"},"html":{"href":"https://github.com/cahirwpz/mimiker/pull/257#discussion_r111567287"},"pull_request":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257","id":115766771,"html_url":"https://github.com/cahirwpz/mimiker/pull/257","diff_url":"https://github.com/cahirwpz/mimiker/pull/257.diff","patch_url":"https://github.com/cahirwpz/mimiker/pull/257.patch","issue_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/257","number":257,"state":"open","locked":false,"title":"Implemented dev_uart_read","user":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars2.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"body":"This is just filling in the missing glue between `uart_cbus` and `dev_uart`, so that user programs can get some bytes from uart input. \r\n\r\nA proper solution will require device infrastructure and terminal support - but we're far away from that.","created_at":"2017-04-13T14:17:21Z","updated_at":"2017-04-14T12:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"835e0167216ba1a6c35024a5efa595921cd7e5b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257/commits","review_comments_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257/comments","review_comment_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/257/comments","statuses_url":"https://api.github.com/repos/cahirwpz/mimiker/statuses/bf8616a81e9688402a6175c4eb34046f87522f81","head":{"label":"rafalcieslak:uart_support","ref":"uart_support","sha":"bf8616a81e9688402a6175c4eb34046f87522f81","user":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars2.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"repo":{"id":47133877,"name":"mimiker","full_name":"rafalcieslak/mimiker","owner":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars2.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafalcieslak/mimiker","description":" An experiment with implementation of very simple operating system for Malta board ","fork":true,"url":"https://api.github.com/repos/rafalcieslak/mimiker","forks_url":"https://api.github.com/repos/rafalcieslak/mimiker/forks","keys_url":"https://api.github.com/repos/rafalcieslak/mimiker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafalcieslak/mimiker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafalcieslak/mimiker/teams","hooks_url":"https://api.github.com/repos/rafalcieslak/mimiker/hooks","issue_events_url":"https://api.github.com/repos/rafalcieslak/mimiker/issues/events{/number}","events_url":"https://api.github.com/repos/rafalcieslak/mimiker/events","assignees_url":"https://api.github.com/repos/rafalcieslak/mimiker/assignees{/user}","branches_url":"https://api.github.com/repos/rafalcieslak/mimiker/branches{/branch}","tags_url":"https://api.github.com/repos/rafalcieslak/mimiker/tags","blobs_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafalcieslak/mimiker/statuses/{sha}","languages_url":"https://api.github.com/repos/rafalcieslak/mimiker/languages","stargazers_url":"https://api.github.com/repos/rafalcieslak/mimiker/stargazers","contributors_url":"https://api.github.com/repos/rafalcieslak/mimiker/contributors","subscribers_url":"https://api.github.com/repos/rafalcieslak/mimiker/subscribers","subscription_url":"https://api.github.com/repos/rafalcieslak/mimiker/subscription","commits_url":"https://api.github.com/repos/rafalcieslak/mimiker/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafalcieslak/mimiker/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafalcieslak/mimiker/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafalcieslak/mimiker/contents/{+path}","compare_url":"https://api.github.com/repos/rafalcieslak/mimiker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafalcieslak/mimiker/merges","archive_url":"https://api.github.com/repos/rafalcieslak/mimiker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafalcieslak/mimiker/downloads","issues_url":"https://api.github.com/repos/rafalcieslak/mimiker/issues{/number}","pulls_url":"https://api.github.com/repos/rafalcieslak/mimiker/pulls{/number}","milestones_url":"https://api.github.com/repos/rafalcieslak/mimiker/milestones{/number}","notifications_url":"https://api.github.com/repos/rafalcieslak/mimiker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafalcieslak/mimiker/labels{/name}","releases_url":"https://api.github.com/repos/rafalcieslak/mimiker/releases{/id}","deployments_url":"https://api.github.com/repos/rafalcieslak/mimiker/deployments","created_at":"2015-11-30T17:12:17Z","updated_at":"2016-11-05T15:34:25Z","pushed_at":"2017-04-13T18:42:27Z","git_url":"git://github.com/rafalcieslak/mimiker.git","ssh_url":"git@github.com:rafalcieslak/mimiker.git","clone_url":"https://github.com/rafalcieslak/mimiker.git","svn_url":"https://github.com/rafalcieslak/mimiker","homepage":"","size":2079,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cahirwpz:master","ref":"master","sha":"e5e8d3c86e283844f3decf6189ec981a5e648365","user":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars0.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"repo":{"id":46346617,"name":"mimiker","full_name":"cahirwpz/mimiker","owner":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars0.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cahirwpz/mimiker","description":"An experiment with implementation of very simple operating system for Malta board","fork":false,"url":"https://api.github.com/repos/cahirwpz/mimiker","forks_url":"https://api.github.com/repos/cahirwpz/mimiker/forks","keys_url":"https://api.github.com/repos/cahirwpz/mimiker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cahirwpz/mimiker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cahirwpz/mimiker/teams","hooks_url":"https://api.github.com/repos/cahirwpz/mimiker/hooks","issue_events_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/events{/number}","events_url":"https://api.github.com/repos/cahirwpz/mimiker/events","assignees_url":"https://api.github.com/repos/cahirwpz/mimiker/assignees{/user}","branches_url":"https://api.github.com/repos/cahirwpz/mimiker/branches{/branch}","tags_url":"https://api.github.com/repos/cahirwpz/mimiker/tags","blobs_url":"https://api.github.com/repos/cahirwpz/mimiker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cahirwpz/mimiker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cahirwpz/mimiker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cahirwpz/mimiker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cahirwpz/mimiker/statuses/{sha}","languages_url":"https://api.github.com/repos/cahirwpz/mimiker/languages","stargazers_url":"https://api.github.com/repos/cahirwpz/mimiker/stargazers","contributors_url":"https://api.github.com/repos/cahirwpz/mimiker/contributors","subscribers_url":"https://api.github.com/repos/cahirwpz/mimiker/subscribers","subscription_url":"https://api.github.com/repos/cahirwpz/mimiker/subscription","commits_url":"https://api.github.com/repos/cahirwpz/mimiker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cahirwpz/mimiker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cahirwpz/mimiker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cahirwpz/mimiker/contents/{+path}","compare_url":"https://api.github.com/repos/cahirwpz/mimiker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cahirwpz/mimiker/merges","archive_url":"https://api.github.com/repos/cahirwpz/mimiker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cahirwpz/mimiker/downloads","issues_url":"https://api.github.com/repos/cahirwpz/mimiker/issues{/number}","pulls_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls{/number}","milestones_url":"https://api.github.com/repos/cahirwpz/mimiker/milestones{/number}","notifications_url":"https://api.github.com/repos/cahirwpz/mimiker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cahirwpz/mimiker/labels{/name}","releases_url":"https://api.github.com/repos/cahirwpz/mimiker/releases{/id}","deployments_url":"https://api.github.com/repos/cahirwpz/mimiker/deployments","created_at":"2015-11-17T12:46:47Z","updated_at":"2016-10-23T17:00:09Z","pushed_at":"2017-04-13T18:55:30Z","git_url":"git://github.com/cahirwpz/mimiker.git","ssh_url":"git@github.com:cahirwpz/mimiker.git","clone_url":"https://github.com/cahirwpz/mimiker.git","svn_url":"https://github.com/cahirwpz/mimiker","homepage":"","size":1594,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":30,"forks":16,"open_issues":30,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257"},"html":{"href":"https://github.com/cahirwpz/mimiker/pull/257"},"issue":{"href":"https://api.github.com/repos/cahirwpz/mimiker/issues/257"},"comments":{"href":"https://api.github.com/repos/cahirwpz/mimiker/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/cahirwpz/mimiker/statuses/bf8616a81e9688402a6175c4eb34046f87522f81"}}}}
{"actor":{"display_login":"cahirwpz"}}