{"action":"created","issue":{"url":"https://api.github.com/repos/jetstack-experimental/cert-manager/issues/51","repository_url":"https://api.github.com/repos/jetstack-experimental/cert-manager","labels_url":"https://api.github.com/repos/jetstack-experimental/cert-manager/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/jetstack-experimental/cert-manager/issues/51/comments","events_url":"https://api.github.com/repos/jetstack-experimental/cert-manager/issues/51/events","html_url":"https://github.com/jetstack-experimental/cert-manager/issues/51","id":248745964,"number":51,"title":"Review of API schema","user":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"labels":[{"id":612348828,"url":"https://api.github.com/repos/jetstack-experimental/cert-manager/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true},{"id":612348830,"url":"https://api.github.com/repos/jetstack-experimental/cert-manager/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jetstack-experimental/cert-manager/milestones/1","html_url":"https://github.com/jetstack-experimental/cert-manager/milestone/1","labels_url":"https://api.github.com/repos/jetstack-experimental/cert-manager/milestones/1/labels","id":2683387,"number":1,"title":"Initial alpha","description":"Initial alpha milestone, with a minimum of feature parity with kube-lego (ie. full ACME HTTP01 challenge support) and minimum one ACME DNS01 challenge provider.","creator":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":10,"state":"open","created_at":"2017-08-06T12:05:51Z","updated_at":"2017-09-11T10:08:26Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2017-08-08T15:02:26Z","updated_at":"2017-09-19T10:19:24Z","closed_at":null,"author_association":"MEMBER","body":"Right now our API schema is relatively flexible. We only define a single external version, v1alpha1, and we give no guarantees on the stability of this API.\r\n\r\nNow that we're at a point where the project does function, we should review our schema to make sure it's consistent and makes sense. This specifically relates to the 'Issuer' and 'Certificate' resource type.\r\n\r\nAn example for ACME can be found here: https://github.com/jetstack-experimental/cert-manager/blob/master/docs/acme-cert.yaml and here: https://github.com/jetstack-experimental/cert-manager/blob/master/docs/acme-issuer.yaml. The full type definitions can be found in [types.go](https://github.com/jetstack-experimental/cert-manager/blob/master/pkg/apis/certmanager/v1alpha1/types.go).\r\n"},"comment":{"url":"https://api.github.com/repos/jetstack-experimental/cert-manager/issues/comments/330495841","html_url":"https://github.com/jetstack-experimental/cert-manager/issues/51#issuecomment-330495841","issue_url":"https://api.github.com/repos/jetstack-experimental/cert-manager/issues/51","id":330495841,"user":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T10:19:24Z","updated_at":"2017-09-19T10:19:24Z","author_association":"MEMBER","body":"@mikebryant I've created #97 to track adding a default annotation to Issuers (and supporting Initializer for Certificate resources).\r\n\r\nI like the idea of a simple solution regarding picking a challenge provider - I think it'd be great if we didn't require all the extra config, especially in single-Issuer, single-config scenarios. The only edge-case I can see here, is that right now, *all* ACME issuers are 'configured' for solving HTTP01 challenges (as there's no configuration required). This means it'd be impossible to create a default issuer that always uses DNS01.\r\n\r\nIf we *require* a user specify `http-01: {}` in their Issuer spec, we could then observe the lack of `http-01: {}` to mean that http01 support is disabled, but once again, this *may* be confusing for first-time users that only want http-01 challenge support! Any thoughts here? Is this an acceptable requirement that we put on users?\r\n\r\n+1 for leaving policy stuff out for now. Perhaps in future we can provide a some built in initializers for policy that can be enabled by advanced users.\r\n"}}
{"actor":{"display_login":"munnerz"}}