{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/1393","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/1393/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1393/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/1393/events","html_url":"https://github.com/ocaml/ocaml/pull/1393","id":262464650,"number":1393,"title":"Restore support for native_c_compiler and bytecomp_c_compiler","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars3.githubusercontent.com/u/1736496?v=4","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-03T15:04:46Z","updated_at":"2017-10-03T17:55:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1393","html_url":"https://github.com/ocaml/ocaml/pull/1393","diff_url":"https://github.com/ocaml/ocaml/pull/1393.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1393.patch"},"body":"Alongside several improvements to the build system, PR #1114 introduced a couple of breaking changes in the output of `ocamlc -config`: the variables `bytecomp_c_compiler` and `native_c_compiler` were removed, perhaps inadvertently.\r\n\r\nThe removed variables have been [part of the interface since OCaml 3.09 (2005)](https://github.com/ocaml/ocaml/commit/6c9bac39d4), and several packages rely on them.\r\n\r\nThis PR reconstructs the values of `bytecomp_c_compiler` and `native_c_compiler` from the new variables `c_compiler`, `ocamlc_cflags`, `ocamlc_cppflags`, etc.,  restoring backwards compatibility.\r\n\r\nThere's some discussion of the change under [Mantis PR 7650](https://caml.inria.fr/mantis/view.php?id=7650).\r\n"},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/333926413","html_url":"https://github.com/ocaml/ocaml/pull/1393#issuecomment-333926413","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1393","id":333926413,"user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars0.githubusercontent.com/u/5250680?v=4","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"created_at":"2017-10-03T17:55:58Z","updated_at":"2017-10-03T17:55:58Z","author_association":"CONTRIBUTOR","body":"I'd been under the mistaken impression earlier that this change had been made in 4.05.0 (it's easy, for me at least, to forget which build system improvements have been in which particular branch).\r\n\r\nThat we haven't released it yet changes my view on whether we should do it (i.e. I agree we should). One other thing I noticed is that the new ocamlc_cppflags and ocamlopt_cppflags are not included in the Config.print_config, and I think that must be an omission too (@shindere?)"}}
{"actor":{"display_login":"dra27"}}