{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/media-atom-maker/pulls/comments/131893982","pull_request_review_id":54336265,"id":131893982,"diff_hunk":"@@ -1,19 +1,28 @@\n import React from 'react';\n import ContentApi from '../../services/capi';\n import { tagsFromStringList, tagsToStringList } from '../../util/tagParsers';\n-import removeStringTagDuplicates from '../../util/removeStringTagDuplicates';\n import { keyCodes } from '../../constants/keyCodes';\n import UserActions from '../../constants/UserActions';\n import TagTypes from '../../constants/TagTypes';\n+import getTagDisplayNames from '../../util/getTagDisplayNames';\n+import TextInputTagPicker from './TextInputTagPicker';\n+import PureTagPicker from './PureTagPicker';\n+import TagFieldValue from '../Tags/TagFieldValue';\n+import CapiUnavailable from '../CapiSearch/CapiUnavailable';\n import DragSortableList from 'react-drag-sortable';\n+import removeTagDuplicates from '../../util/removeTagDuplicates';\n+import removeStringTagDuplicates from '../../util/removeStringTagDuplicates';\n \n export default class TagPicker extends React.Component {\n+\n   state = {\n     capiTags: [],\n-    inputString: '',\n-    lastAction: UserActions.other,\n     tagValue: [],\n-    capiUnavailable: false\n+    capiUnavailable: false,\n+    showTags: true,\n+    tagsVisible: false,","path":"public/video-ui/src/components/FormFields/TagPicker.js","position":27,"original_position":27,"commit_id":"3c71bd6684b05a55234fd259fb683cf3623cb7f2","original_commit_id":"3c71bd6684b05a55234fd259fb683cf3623cb7f2","user":{"login":"akash1810","id":836140,"avatar_url":"https://avatars3.githubusercontent.com/u/836140?v=4","gravatar_id":"","url":"https://api.github.com/users/akash1810","html_url":"https://github.com/akash1810","followers_url":"https://api.github.com/users/akash1810/followers","following_url":"https://api.github.com/users/akash1810/following{/other_user}","gists_url":"https://api.github.com/users/akash1810/gists{/gist_id}","starred_url":"https://api.github.com/users/akash1810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash1810/subscriptions","organizations_url":"https://api.github.com/users/akash1810/orgs","repos_url":"https://api.github.com/users/akash1810/repos","events_url":"https://api.github.com/users/akash1810/events{/privacy}","received_events_url":"https://api.github.com/users/akash1810/received_events","type":"User","site_admin":false},"body":"it looks like `showTags` and `tagsVisible` are related and can be merged into a single property","created_at":"2017-08-08T12:09:52Z","updated_at":"2017-08-08T12:49:17Z","html_url":"https://github.com/guardian/media-atom-maker/pull/546#discussion_r131893982","pull_request_url":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546","_links":{"self":{"href":"https://api.github.com/repos/guardian/media-atom-maker/pulls/comments/131893982"},"html":{"href":"https://github.com/guardian/media-atom-maker/pull/546#discussion_r131893982"},"pull_request":{"href":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546","id":134127980,"html_url":"https://github.com/guardian/media-atom-maker/pull/546","diff_url":"https://github.com/guardian/media-atom-maker/pull/546.diff","patch_url":"https://github.com/guardian/media-atom-maker/pull/546.patch","issue_url":"https://api.github.com/repos/guardian/media-atom-maker/issues/546","number":546,"state":"open","locked":false,"title":"Tag picker fixes","user":{"login":"Reettaphant","id":3066534,"avatar_url":"https://avatars2.githubusercontent.com/u/3066534?v=4","gravatar_id":"","url":"https://api.github.com/users/Reettaphant","html_url":"https://github.com/Reettaphant","followers_url":"https://api.github.com/users/Reettaphant/followers","following_url":"https://api.github.com/users/Reettaphant/following{/other_user}","gists_url":"https://api.github.com/users/Reettaphant/gists{/gist_id}","starred_url":"https://api.github.com/users/Reettaphant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reettaphant/subscriptions","organizations_url":"https://api.github.com/users/Reettaphant/orgs","repos_url":"https://api.github.com/users/Reettaphant/repos","events_url":"https://api.github.com/users/Reettaphant/events{/privacy}","received_events_url":"https://api.github.com/users/Reettaphant/received_events","type":"User","site_admin":false},"body":"\r\n![out](https://user-images.githubusercontent.com/3066534/28963720-0e12a51c-7902-11e7-8f49-bf404d237766.gif)\r\n- Apologies for the long PR: by the time I realised I needed to rearrange the tag picker for this, I had already started on many of the improvements. \r\n\r\n- This PR makes many improvements to the usability of the tag pickers\r\n- It hides tag search results when user is no longer focuses on the input\r\n- It allows for navigating up and down search results using arrow keys\r\n- It fixes padding issues in the byline picker\r\n- It changes the commissioning and keyword tag picker presentation to be more in line with what is on composer (showing selected tag as a vertical list, not on the input element itself)\r\n- It also breaks the tag picker into multiple components to make it more usable and to allow for more customisation.\r\n\r\n","created_at":"2017-08-04T09:39:42Z","updated_at":"2017-08-08T12:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56c31864bdbf18eb0734b8955ebdc8ddec5ff2a9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546/commits","review_comments_url":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546/comments","review_comment_url":"https://api.github.com/repos/guardian/media-atom-maker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/media-atom-maker/issues/546/comments","statuses_url":"https://api.github.com/repos/guardian/media-atom-maker/statuses/3c71bd6684b05a55234fd259fb683cf3623cb7f2","head":{"label":"guardian:rv-tag-picker-fixes","ref":"rv-tag-picker-fixes","sha":"3c71bd6684b05a55234fd259fb683cf3623cb7f2","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":60180856,"name":"media-atom-maker","full_name":"guardian/media-atom-maker","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/media-atom-maker","description":"A tool for creating media atoms, including a UI specifically for managing video","fork":false,"url":"https://api.github.com/repos/guardian/media-atom-maker","forks_url":"https://api.github.com/repos/guardian/media-atom-maker/forks","keys_url":"https://api.github.com/repos/guardian/media-atom-maker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/media-atom-maker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/media-atom-maker/teams","hooks_url":"https://api.github.com/repos/guardian/media-atom-maker/hooks","issue_events_url":"https://api.github.com/repos/guardian/media-atom-maker/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/media-atom-maker/events","assignees_url":"https://api.github.com/repos/guardian/media-atom-maker/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/media-atom-maker/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/media-atom-maker/tags","blobs_url":"https://api.github.com/repos/guardian/media-atom-maker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/media-atom-maker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/media-atom-maker/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/media-atom-maker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/media-atom-maker/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/media-atom-maker/languages","stargazers_url":"https://api.github.com/repos/guardian/media-atom-maker/stargazers","contributors_url":"https://api.github.com/repos/guardian/media-atom-maker/contributors","subscribers_url":"https://api.github.com/repos/guardian/media-atom-maker/subscribers","subscription_url":"https://api.github.com/repos/guardian/media-atom-maker/subscription","commits_url":"https://api.github.com/repos/guardian/media-atom-maker/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/media-atom-maker/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/media-atom-maker/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/media-atom-maker/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/media-atom-maker/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/media-atom-maker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/media-atom-maker/merges","archive_url":"https://api.github.com/repos/guardian/media-atom-maker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/media-atom-maker/downloads","issues_url":"https://api.github.com/repos/guardian/media-atom-maker/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/media-atom-maker/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/media-atom-maker/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/media-atom-maker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/media-atom-maker/labels{/name}","releases_url":"https://api.github.com/repos/guardian/media-atom-maker/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/media-atom-maker/deployments","created_at":"2016-06-01T13:49:33Z","updated_at":"2017-03-07T14:23:41Z","pushed_at":"2017-08-07T16:14:48Z","git_url":"git://github.com/guardian/media-atom-maker.git","ssh_url":"git@github.com:guardian/media-atom-maker.git","clone_url":"https://github.com/guardian/media-atom-maker.git","svn_url":"https://github.com/guardian/media-atom-maker","homepage":"","size":4144,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":1,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"e051016b9dfb982dfd2cc217400de3619d9ffeb6","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":60180856,"name":"media-atom-maker","full_name":"guardian/media-atom-maker","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/media-atom-maker","description":"A tool for creating media atoms, including a UI specifically for managing video","fork":false,"url":"https://api.github.com/repos/guardian/media-atom-maker","forks_url":"https://api.github.com/repos/guardian/media-atom-maker/forks","keys_url":"https://api.github.com/repos/guardian/media-atom-maker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/media-atom-maker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/media-atom-maker/teams","hooks_url":"https://api.github.com/repos/guardian/media-atom-maker/hooks","issue_events_url":"https://api.github.com/repos/guardian/media-atom-maker/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/media-atom-maker/events","assignees_url":"https://api.github.com/repos/guardian/media-atom-maker/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/media-atom-maker/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/media-atom-maker/tags","blobs_url":"https://api.github.com/repos/guardian/media-atom-maker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/media-atom-maker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/media-atom-maker/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/media-atom-maker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/media-atom-maker/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/media-atom-maker/languages","stargazers_url":"https://api.github.com/repos/guardian/media-atom-maker/stargazers","contributors_url":"https://api.github.com/repos/guardian/media-atom-maker/contributors","subscribers_url":"https://api.github.com/repos/guardian/media-atom-maker/subscribers","subscription_url":"https://api.github.com/repos/guardian/media-atom-maker/subscription","commits_url":"https://api.github.com/repos/guardian/media-atom-maker/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/media-atom-maker/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/media-atom-maker/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/media-atom-maker/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/media-atom-maker/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/media-atom-maker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/media-atom-maker/merges","archive_url":"https://api.github.com/repos/guardian/media-atom-maker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/media-atom-maker/downloads","issues_url":"https://api.github.com/repos/guardian/media-atom-maker/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/media-atom-maker/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/media-atom-maker/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/media-atom-maker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/media-atom-maker/labels{/name}","releases_url":"https://api.github.com/repos/guardian/media-atom-maker/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/media-atom-maker/deployments","created_at":"2016-06-01T13:49:33Z","updated_at":"2017-03-07T14:23:41Z","pushed_at":"2017-08-07T16:14:48Z","git_url":"git://github.com/guardian/media-atom-maker.git","ssh_url":"git@github.com:guardian/media-atom-maker.git","clone_url":"https://github.com/guardian/media-atom-maker.git","svn_url":"https://github.com/guardian/media-atom-maker","homepage":"","size":4144,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546"},"html":{"href":"https://github.com/guardian/media-atom-maker/pull/546"},"issue":{"href":"https://api.github.com/repos/guardian/media-atom-maker/issues/546"},"comments":{"href":"https://api.github.com/repos/guardian/media-atom-maker/issues/546/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/media-atom-maker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/media-atom-maker/pulls/546/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/media-atom-maker/statuses/3c71bd6684b05a55234fd259fb683cf3623cb7f2"}}}}
{"actor":{"display_login":"akash1810"}}