{"action":"created","issue":{"url":"https://api.github.com/repos/vega/vega/issues/952","repository_url":"https://api.github.com/repos/vega/vega","labels_url":"https://api.github.com/repos/vega/vega/issues/952/labels{/name}","comments_url":"https://api.github.com/repos/vega/vega/issues/952/comments","events_url":"https://api.github.com/repos/vega/vega/issues/952/events","html_url":"https://github.com/vega/vega/issues/952","id":247282415,"number":952,"title":"Nested facet column cannot refer to nested data source for cardinality","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars1.githubusercontent.com/u/111269?v=4","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jheer","id":202799,"avatar_url":"https://avatars0.githubusercontent.com/u/202799?v=4","gravatar_id":"","url":"https://api.github.com/users/jheer","html_url":"https://github.com/jheer","followers_url":"https://api.github.com/users/jheer/followers","following_url":"https://api.github.com/users/jheer/following{/other_user}","gists_url":"https://api.github.com/users/jheer/gists{/gist_id}","starred_url":"https://api.github.com/users/jheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheer/subscriptions","organizations_url":"https://api.github.com/users/jheer/orgs","repos_url":"https://api.github.com/users/jheer/repos","events_url":"https://api.github.com/users/jheer/events{/privacy}","received_events_url":"https://api.github.com/users/jheer/received_events","type":"User","site_admin":false},"assignees":[{"login":"jheer","id":202799,"avatar_url":"https://avatars0.githubusercontent.com/u/202799?v=4","gravatar_id":"","url":"https://api.github.com/users/jheer","html_url":"https://github.com/jheer","followers_url":"https://api.github.com/users/jheer/followers","following_url":"https://api.github.com/users/jheer/following{/other_user}","gists_url":"https://api.github.com/users/jheer/gists{/gist_id}","starred_url":"https://api.github.com/users/jheer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheer/subscriptions","organizations_url":"https://api.github.com/users/jheer/orgs","repos_url":"https://api.github.com/users/jheer/repos","events_url":"https://api.github.com/users/jheer/events{/privacy}","received_events_url":"https://api.github.com/users/jheer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-08-02T06:06:18Z","updated_at":"2017-08-02T18:51:05Z","closed_at":null,"body":"In [this spec](https://pastebin.com/Znth2HEM), we get `Undefined data set name: \"child_column_layout\"` although we have properly defined `child_column_layout` as a nested data source.\r\n\r\nThis is an output for the following VL spec:\r\n\r\n```\r\n{\r\n  \"$schema\": \"https://vega.github.io/schema/vega-lite/v2.json\",\r\n  \"data\": {\"url\": \"data/cars.json\"},\r\n  \"facet\": {\"column\": {\"field\": \"Origin\",\"type\": \"ordinal\"}},\r\n  \"spec\": {\r\n    \"facet\": {\"column\": {\"field\": \"Cylinders\",\"type\": \"ordinal\"}},\r\n    \"spec\": {\r\n      \"mark\": \"point\", \r\n      \"encoding\": {\r\n        \"x\": {\"field\": \"Horsepower\",\"type\": \"quantitative\"},\r\n        \"y\": {\"field\": \"Acceleration\",\"type\": \"quantitative\"}\r\n      }\r\n    }\r\n  }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/vega/vega/issues/comments/319763967","html_url":"https://github.com/vega/vega/issues/952#issuecomment-319763967","issue_url":"https://api.github.com/repos/vega/vega/issues/952","id":319763967,"user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars1.githubusercontent.com/u/111269?v=4","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"created_at":"2017-08-02T18:51:05Z","updated_at":"2017-08-02T18:51:05Z","body":"I see.  If u want to use this hack, adding aggregate distinct calculation in facet is easy as I already have a code path to do it for calculating size signal with range step .\r\n\r\nIf this (or any other solution you prefer) isn't too hacky and not too difficult it would be great to include it in 3.0 too. Otherwise we will have to do some temporary restructure to calculate number of column in the global scope, which is quite complicated to do and may not worth it if we will have to revert it soon after we have support for nesting case"}}
{"actor":{"display_login":"kanitw"}}