{"action":"opened","number":38,"pull_request":{"url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/38","id":159038857,"html_url":"https://github.com/bazelbuild/bazel-gazelle/pull/38","diff_url":"https://github.com/bazelbuild/bazel-gazelle/pull/38.diff","patch_url":"https://github.com/bazelbuild/bazel-gazelle/pull/38.patch","issue_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/issues/38","number":38,"state":"open","locked":false,"title":"Rewrite packages.PlatformStrings (again)","user":{"login":"jayconrod","id":164791,"avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"body":"PackageStrings needed a new invariant: strings must not be duplicated\r\nacross sets. For example, the same string cannot be OS-specific and\r\nplatform-specific. Bazel rejects build files where this is the case\r\nfor deps.\r\n\r\nThis change introduces platformStringsBuilder. Strings are added to\r\nsets, and information is stored about which set each string belongs\r\nto. The Map and Clean methods are removed; when PlatformStrings is\r\nbuilt, it is already clean.\r\n\r\nThis affects option strings somewhat. Unprocessed groups of options\r\nare stored as strings with OptSeparator between each option. rules is\r\nnow responsible for splitting and quoting these.\r\n\r\nThis means order is no longer preserved for option strings (they will\r\nbe sorted when PlatformStrings is built). We couldn't actually\r\nguarantee order before: for example, if a file contained an\r\narch-specific #cgo directive, followed by an OS-specific #cgo\r\ndirective, they would already appear in the wrong order.\r\n\r\nFixes #28","created_at":"2017-12-18T22:57:45Z","updated_at":"2017-12-18T22:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/38/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/38/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/issues/38/comments","statuses_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/statuses/10079e60c615f373de6cb4f9312c1efa729ff6a4","head":{"label":"jayconrod:fix-dup-deps","ref":"fix-dup-deps","sha":"10079e60c615f373de6cb4f9312c1efa729ff6a4","user":{"login":"jayconrod","id":164791,"avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"repo":{"id":112659940,"name":"bazel-gazelle","full_name":"jayconrod/bazel-gazelle","owner":{"login":"jayconrod","id":164791,"avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayconrod/bazel-gazelle","description":null,"fork":true,"url":"https://api.github.com/repos/jayconrod/bazel-gazelle","forks_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/forks","keys_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/teams","hooks_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/hooks","issue_events_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/issues/events{/number}","events_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/events","assignees_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/assignees{/user}","branches_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/branches{/branch}","tags_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/tags","blobs_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/statuses/{sha}","languages_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/languages","stargazers_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/stargazers","contributors_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/contributors","subscribers_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/subscribers","subscription_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/subscription","commits_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/contents/{+path}","compare_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/merges","archive_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/downloads","issues_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/issues{/number}","pulls_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/pulls{/number}","milestones_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/milestones{/number}","notifications_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/labels{/name}","releases_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/releases{/id}","deployments_url":"https://api.github.com/repos/jayconrod/bazel-gazelle/deployments","created_at":"2017-11-30T20:59:53Z","updated_at":"2017-11-30T20:59:55Z","pushed_at":"2017-12-18T22:38:43Z","git_url":"git://github.com/jayconrod/bazel-gazelle.git","ssh_url":"git@github.com:jayconrod/bazel-gazelle.git","clone_url":"https://github.com/jayconrod/bazel-gazelle.git","svn_url":"https://github.com/jayconrod/bazel-gazelle","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"d2f30eb6d33e1a1dbd03be52ca4ad5b54e95573a","user":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":112655189,"name":"bazel-gazelle","full_name":"bazelbuild/bazel-gazelle","owner":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/bazel-gazelle","description":"Gazelle is a Bazel build file generator for Go projects.","fork":false,"url":"https://api.github.com/repos/bazelbuild/bazel-gazelle","forks_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/forks","keys_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/teams","hooks_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/events","assignees_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/tags","blobs_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/subscription","commits_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/merges","archive_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/downloads","issues_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/bazel-gazelle/deployments","created_at":"2017-11-30T20:08:09Z","updated_at":"2017-12-18T03:50:05Z","pushed_at":"2017-12-18T21:36:41Z","git_url":"git://github.com/bazelbuild/bazel-gazelle.git","ssh_url":"git@github.com:bazelbuild/bazel-gazelle.git","clone_url":"https://github.com/bazelbuild/bazel-gazelle.git","svn_url":"https://github.com/bazelbuild/bazel-gazelle","homepage":"","size":169,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":25,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/38"},"html":{"href":"https://github.com/bazelbuild/bazel-gazelle/pull/38"},"issue":{"href":"https://api.github.com/repos/bazelbuild/bazel-gazelle/issues/38"},"comments":{"href":"https://api.github.com/repos/bazelbuild/bazel-gazelle/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/bazel-gazelle/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/bazel-gazelle/statuses/10079e60c615f373de6cb4f9312c1efa729ff6a4"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":394,"deletions":407,"changed_files":11}}
{"actor":{"display_login":"jayconrod"}}