{"action":"closed","number":2629,"pull_request":{"url":"https://api.github.com/repos/react-community/react-navigation/pulls/2629","id":142236917,"html_url":"https://github.com/react-community/react-navigation/pull/2629","diff_url":"https://github.com/react-community/react-navigation/pull/2629.diff","patch_url":"https://github.com/react-community/react-navigation/pull/2629.patch","issue_url":"https://api.github.com/repos/react-community/react-navigation/issues/2629","number":2629,"state":"closed","locked":false,"title":"Improve StatusBar/Header Behavior ","user":{"login":"spencercarli","id":1105429,"avatar_url":"https://avatars0.githubusercontent.com/u/1105429?v=4","gravatar_id":"","url":"https://api.github.com/users/spencercarli","html_url":"https://github.com/spencercarli","followers_url":"https://api.github.com/users/spencercarli/followers","following_url":"https://api.github.com/users/spencercarli/following{/other_user}","gists_url":"https://api.github.com/users/spencercarli/gists{/gist_id}","starred_url":"https://api.github.com/users/spencercarli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencercarli/subscriptions","organizations_url":"https://api.github.com/users/spencercarli/orgs","repos_url":"https://api.github.com/users/spencercarli/repos","events_url":"https://api.github.com/users/spencercarli/events{/privacy}","received_events_url":"https://api.github.com/users/spencercarli/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nWhile working on adding support for iPhoneX/iOS11 I saw incorrect behavior with the header. Currently, when a device goes to landscape mode the status bar is hidden (as expected) but the header component height stays the same. This can be seen in the following GIF.\r\n\r\n![current-status-bar-behaviour](https://user-images.githubusercontent.com/1105429/30674533-8d950e7a-9e40-11e7-8127-a8bcb34a0d71.gif)\r\n\r\n## Test Plan\r\n\r\nInstall `react-navigation` from `spencercarli/react-navigation#improve-status-bar-behavior` into the NavigationPlayground example and spin your device around. You should see the following behavior.\r\n\r\n![new-status-bar-behaviour](https://user-images.githubusercontent.com/1105429/30674575-c9d035d6-9e40-11e7-8b0c-047d8f148ef3.gif)\r\n\r\n","created_at":"2017-09-21T01:19:23Z","updated_at":"2017-09-29T02:11:53Z","closed_at":"2017-09-29T02:11:53Z","merged_at":null,"merge_commit_sha":"e72840e7038a80d0daae16af0d365527e79579f5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-community/react-navigation/pulls/2629/commits","review_comments_url":"https://api.github.com/repos/react-community/react-navigation/pulls/2629/comments","review_comment_url":"https://api.github.com/repos/react-community/react-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-community/react-navigation/issues/2629/comments","statuses_url":"https://api.github.com/repos/react-community/react-navigation/statuses/20396a4659596a669f793fb9b98e8a4cf378fc7c","head":{"label":"spencercarli:improve-status-bar-behavior","ref":"improve-status-bar-behavior","sha":"20396a4659596a669f793fb9b98e8a4cf378fc7c","user":{"login":"spencercarli","id":1105429,"avatar_url":"https://avatars0.githubusercontent.com/u/1105429?v=4","gravatar_id":"","url":"https://api.github.com/users/spencercarli","html_url":"https://github.com/spencercarli","followers_url":"https://api.github.com/users/spencercarli/followers","following_url":"https://api.github.com/users/spencercarli/following{/other_user}","gists_url":"https://api.github.com/users/spencercarli/gists{/gist_id}","starred_url":"https://api.github.com/users/spencercarli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencercarli/subscriptions","organizations_url":"https://api.github.com/users/spencercarli/orgs","repos_url":"https://api.github.com/users/spencercarli/repos","events_url":"https://api.github.com/users/spencercarli/events{/privacy}","received_events_url":"https://api.github.com/users/spencercarli/received_events","type":"User","site_admin":false},"repo":{"id":100809395,"name":"react-navigation","full_name":"spencercarli/react-navigation","owner":{"login":"spencercarli","id":1105429,"avatar_url":"https://avatars0.githubusercontent.com/u/1105429?v=4","gravatar_id":"","url":"https://api.github.com/users/spencercarli","html_url":"https://github.com/spencercarli","followers_url":"https://api.github.com/users/spencercarli/followers","following_url":"https://api.github.com/users/spencercarli/following{/other_user}","gists_url":"https://api.github.com/users/spencercarli/gists{/gist_id}","starred_url":"https://api.github.com/users/spencercarli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencercarli/subscriptions","organizations_url":"https://api.github.com/users/spencercarli/orgs","repos_url":"https://api.github.com/users/spencercarli/repos","events_url":"https://api.github.com/users/spencercarli/events{/privacy}","received_events_url":"https://api.github.com/users/spencercarli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spencercarli/react-navigation","description":"Learn once, navigate anywhere","fork":true,"url":"https://api.github.com/repos/spencercarli/react-navigation","forks_url":"https://api.github.com/repos/spencercarli/react-navigation/forks","keys_url":"https://api.github.com/repos/spencercarli/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spencercarli/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spencercarli/react-navigation/teams","hooks_url":"https://api.github.com/repos/spencercarli/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/spencercarli/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/spencercarli/react-navigation/events","assignees_url":"https://api.github.com/repos/spencercarli/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/spencercarli/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/spencercarli/react-navigation/tags","blobs_url":"https://api.github.com/repos/spencercarli/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spencercarli/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spencercarli/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/spencercarli/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spencercarli/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/spencercarli/react-navigation/languages","stargazers_url":"https://api.github.com/repos/spencercarli/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/spencercarli/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/spencercarli/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/spencercarli/react-navigation/subscription","commits_url":"https://api.github.com/repos/spencercarli/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/spencercarli/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/spencercarli/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/spencercarli/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/spencercarli/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/spencercarli/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spencercarli/react-navigation/merges","archive_url":"https://api.github.com/repos/spencercarli/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spencercarli/react-navigation/downloads","issues_url":"https://api.github.com/repos/spencercarli/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/spencercarli/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/spencercarli/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/spencercarli/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spencercarli/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/spencercarli/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/spencercarli/react-navigation/deployments","created_at":"2017-08-19T17:12:56Z","updated_at":"2017-09-01T12:12:26Z","pushed_at":"2017-09-29T01:42:21Z","git_url":"git://github.com/spencercarli/react-navigation.git","ssh_url":"git@github.com:spencercarli/react-navigation.git","clone_url":"https://github.com/spencercarli/react-navigation.git","svn_url":"https://github.com/spencercarli/react-navigation","homepage":"https://reactnavigation.org","size":8150,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"react-community:master","ref":"master","sha":"17c910fb5d69e02ef4015dfbf6a83d07019f4d03","user":{"login":"react-community","id":24483500,"avatar_url":"https://avatars3.githubusercontent.com/u/24483500?v=4","gravatar_id":"","url":"https://api.github.com/users/react-community","html_url":"https://github.com/react-community","followers_url":"https://api.github.com/users/react-community/followers","following_url":"https://api.github.com/users/react-community/following{/other_user}","gists_url":"https://api.github.com/users/react-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-community/subscriptions","organizations_url":"https://api.github.com/users/react-community/orgs","repos_url":"https://api.github.com/users/react-community/repos","events_url":"https://api.github.com/users/react-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-community/received_events","type":"Organization","site_admin":false},"repo":{"id":80149262,"name":"react-navigation","full_name":"react-community/react-navigation","owner":{"login":"react-community","id":24483500,"avatar_url":"https://avatars3.githubusercontent.com/u/24483500?v=4","gravatar_id":"","url":"https://api.github.com/users/react-community","html_url":"https://github.com/react-community","followers_url":"https://api.github.com/users/react-community/followers","following_url":"https://api.github.com/users/react-community/following{/other_user}","gists_url":"https://api.github.com/users/react-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-community/subscriptions","organizations_url":"https://api.github.com/users/react-community/orgs","repos_url":"https://api.github.com/users/react-community/repos","events_url":"https://api.github.com/users/react-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-community/react-navigation","description":"Learn once, navigate anywhere","fork":false,"url":"https://api.github.com/repos/react-community/react-navigation","forks_url":"https://api.github.com/repos/react-community/react-navigation/forks","keys_url":"https://api.github.com/repos/react-community/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-community/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-community/react-navigation/teams","hooks_url":"https://api.github.com/repos/react-community/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/react-community/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/react-community/react-navigation/events","assignees_url":"https://api.github.com/repos/react-community/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/react-community/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/react-community/react-navigation/tags","blobs_url":"https://api.github.com/repos/react-community/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-community/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-community/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-community/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-community/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/react-community/react-navigation/languages","stargazers_url":"https://api.github.com/repos/react-community/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/react-community/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/react-community/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/react-community/react-navigation/subscription","commits_url":"https://api.github.com/repos/react-community/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-community/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-community/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-community/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-community/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/react-community/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-community/react-navigation/merges","archive_url":"https://api.github.com/repos/react-community/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-community/react-navigation/downloads","issues_url":"https://api.github.com/repos/react-community/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/react-community/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/react-community/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/react-community/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-community/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/react-community/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/react-community/react-navigation/deployments","created_at":"2017-01-26T19:51:40Z","updated_at":"2017-09-28T20:06:08Z","pushed_at":"2017-09-29T02:11:35Z","git_url":"git://github.com/react-community/react-navigation.git","ssh_url":"git@github.com:react-community/react-navigation.git","clone_url":"https://github.com/react-community/react-navigation.git","svn_url":"https://github.com/react-community/react-navigation","homepage":"https://reactnavigation.org","size":8100,"stargazers_count":7007,"watchers_count":7007,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1516,"mirror_url":null,"open_issues_count":590,"forks":1516,"open_issues":590,"watchers":7007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/2629"},"html":{"href":"https://github.com/react-community/react-navigation/pull/2629"},"issue":{"href":"https://api.github.com/repos/react-community/react-navigation/issues/2629"},"comments":{"href":"https://api.github.com/repos/react-community/react-navigation/issues/2629/comments"},"review_comments":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/2629/comments"},"review_comment":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/2629/commits"},"statuses":{"href":"https://api.github.com/repos/react-community/react-navigation/statuses/20396a4659596a669f793fb9b98e8a4cf378fc7c"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":11,"additions":9792,"deletions":86,"changed_files":27}}
{"actor":{"display_login":"spencercarli"}}