{"action":"created","issue":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1468","repository_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1468/labels{/name}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1468/comments","events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1468/events","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1468","id":221056632,"number":1468,"title":"JBIDE-24216 - validate minishift location","user":{"login":"robstryker","id":630383,"avatar_url":"https://avatars2.githubusercontent.com/u/630383?v=3","gravatar_id":"","url":"https://api.github.com/users/robstryker","html_url":"https://github.com/robstryker","followers_url":"https://api.github.com/users/robstryker/followers","following_url":"https://api.github.com/users/robstryker/following{/other_user}","gists_url":"https://api.github.com/users/robstryker/gists{/gist_id}","starred_url":"https://api.github.com/users/robstryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstryker/subscriptions","organizations_url":"https://api.github.com/users/robstryker/orgs","repos_url":"https://api.github.com/users/robstryker/repos","events_url":"https://api.github.com/users/robstryker/events{/privacy}","received_events_url":"https://api.github.com/users/robstryker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-11T19:32:22Z","updated_at":"2017-04-11T20:19:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1468","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1468","diff_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1468.diff","patch_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1468.patch"},"body":"# Pull Request Checklist\r\n## General\r\n* Is this a blocking issue or new feature? If yes, QE needs to +1 this PR\r\n\r\n## Code\r\n* Are method-/class-/variable-names meaningful?\r\n* Are methods concise, not too long?\r\n* Are catch blocks catching precise Exceptions only (no catch all)?\r\n\r\n## Testing\r\n* Are there unit-tests?\r\n* Are there integration tests (or at least a jira to tackle these)?\r\n* Is the non-happy path working, too?\r\n* Are other parts that use the same component still working fine?\r\n\r\n## Function\r\n* Does it work?\r\n"},"comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/comments/293387989","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1468#issuecomment-293387989","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1468","id":293387989,"user":{"login":"rhdevelopers-ci","id":18214726,"avatar_url":"https://avatars0.githubusercontent.com/u/18214726?v=3","gravatar_id":"","url":"https://api.github.com/users/rhdevelopers-ci","html_url":"https://github.com/rhdevelopers-ci","followers_url":"https://api.github.com/users/rhdevelopers-ci/followers","following_url":"https://api.github.com/users/rhdevelopers-ci/following{/other_user}","gists_url":"https://api.github.com/users/rhdevelopers-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/rhdevelopers-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhdevelopers-ci/subscriptions","organizations_url":"https://api.github.com/users/rhdevelopers-ci/orgs","repos_url":"https://api.github.com/users/rhdevelopers-ci/repos","events_url":"https://api.github.com/users/rhdevelopers-ci/events{/privacy}","received_events_url":"https://api.github.com/users/rhdevelopers-ci/received_events","type":"User","site_admin":false},"created_at":"2017-04-11T20:19:07Z","updated_at":"2017-04-11T20:19:07Z","body":"SonarQube analysis reported 12 issues\n* ![MAJOR][MAJOR] 3 major\n* ![MINOR][MINOR] 9 minor\n\n#### Top 10 issues\n\n1. ![MAJOR][MAJOR] [CDK3ServerWizardFragment.java#L186](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/CDK3ServerWizardFragment.java#L186): Either log or rethrow this exception. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1166)\n1. ![MAJOR][MAJOR] [MinishiftLocationSection.java#L55](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/MinishiftLocationSection.java#L55): Remove this unused \"VERSION_KEY\" private field. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1068)\n1. ![MAJOR][MAJOR] [MinishiftLocationSection.java#L149](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/MinishiftLocationSection.java#L149): Either log or rethrow this exception. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1166)\n1. ![MINOR][MINOR] [CDK3ServerWizardFragment.java#L42](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/CDK3ServerWizardFragment.java#L42): Rename this field \"ERROR_KEY\" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS3008)\n1. ![MINOR][MINOR] [CDK3ServerWizardFragment.java#L42](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/CDK3ServerWizardFragment.java#L42): Make this \"public static ERROR_KEY\" field final [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1444)\n1. ![MINOR][MINOR] [CDK3ServerWizardFragment.java#L42](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/CDK3ServerWizardFragment.java#L42): Make ERROR_KEY a static final constant or non-public and provide accessors if needed. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AClassVariableVisibilityCheck)\n1. ![MINOR][MINOR] [CDK3ServerWizardFragment.java#L43](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/CDK3ServerWizardFragment.java#L43): Rename this field \"VERSION_KEY\" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS3008)\n1. ![MINOR][MINOR] [CDK3ServerWizardFragment.java#L43](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/CDK3ServerWizardFragment.java#L43): Make this \"public static VERSION_KEY\" field final [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1444)\n1. ![MINOR][MINOR] [CDK3ServerWizardFragment.java#L43](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/CDK3ServerWizardFragment.java#L43): Make VERSION_KEY a static final constant or non-public and provide accessors if needed. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AClassVariableVisibilityCheck)\n1. ![MINOR][MINOR] [MinishiftLocationSection.java#L24](https://github.com/jbosstools/jbosstools-openshift/blob/e9bbc00679a277a9babdf53957afd3f743585afe/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/ui/internal/MinishiftLocationSection.java#L24): Remove this unused import 'org.eclipse.jface.dialogs.IMessageProvider'. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AUselessImportCheck)\n\n[MAJOR]: https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"rhdevelopers-ci"}}