{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/154407491","pull_request_review_id":80572200,"id":154407491,"diff_hunk":"@@ -141,6 +142,12 @@ func runCA() {\n \tstopCh := make(chan struct{})\n \tsc.Run(stopCh)\n \n+\tserviceController := controller.NewServiceController(cs.CoreV1(), opts.namespace,\n+\t\tfunc(*v1.Service) {},","path":"security/cmd/istio_ca/main.go","position":13,"original_position":13,"commit_id":"f536c255500c2e5684020e3d1f837cfdd5645179","original_commit_id":"f536c255500c2e5684020e3d1f837cfdd5645179","user":{"login":"crazytan","id":9136175,"avatar_url":"https://avatars2.githubusercontent.com/u/9136175?v=4","gravatar_id":"","url":"https://api.github.com/users/crazytan","html_url":"https://github.com/crazytan","followers_url":"https://api.github.com/users/crazytan/followers","following_url":"https://api.github.com/users/crazytan/following{/other_user}","gists_url":"https://api.github.com/users/crazytan/gists{/gist_id}","starred_url":"https://api.github.com/users/crazytan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazytan/subscriptions","organizations_url":"https://api.github.com/users/crazytan/orgs","repos_url":"https://api.github.com/users/crazytan/repos","events_url":"https://api.github.com/users/crazytan/events{/privacy}","received_events_url":"https://api.github.com/users/crazytan/received_events","type":"User","site_admin":false},"body":"I want to submit controller and registry in two PRs so I added an empty controller here.\r\n\r\nYes it is. In next PR registry will be created in its own package and the handlers are defined there.","created_at":"2017-12-01T17:56:55Z","updated_at":"2017-12-01T17:56:55Z","html_url":"https://github.com/istio/istio/pull/1951#discussion_r154407491","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/1951","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/154407491"},"html":{"href":"https://github.com/istio/istio/pull/1951#discussion_r154407491"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/1951"}},"in_reply_to_id":154274640},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/1951","id":155776781,"html_url":"https://github.com/istio/istio/pull/1951","diff_url":"https://github.com/istio/istio/pull/1951.diff","patch_url":"https://github.com/istio/istio/pull/1951.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/1951","number":1951,"state":"open","locked":false,"title":"add service controller for identity registry support","user":{"login":"crazytan","id":9136175,"avatar_url":"https://avatars2.githubusercontent.com/u/9136175?v=4","gravatar_id":"","url":"https://api.github.com/users/crazytan","html_url":"https://github.com/crazytan","followers_url":"https://api.github.com/users/crazytan/followers","following_url":"https://api.github.com/users/crazytan/following{/other_user}","gists_url":"https://api.github.com/users/crazytan/gists{/gist_id}","starred_url":"https://api.github.com/users/crazytan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazytan/subscriptions","organizations_url":"https://api.github.com/users/crazytan/orgs","repos_url":"https://api.github.com/users/crazytan/repos","events_url":"https://api.github.com/users/crazytan/events{/privacy}","received_events_url":"https://api.github.com/users/crazytan/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nIt adds a service controller, that is similar to secret controller and listens for events related to Service objects. Therefore another goroutine is started in CA which does nothing currently. `service_test.go` demonstrates how a very simple registry should work with the controller.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/istio/old_auth_repo/issues/293\r\n\r\n**Special notes for your reviewer**:\r\nI also removed unreachable code at the end of `main()`.\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2017-12-01T03:44:46Z","updated_at":"2017-12-01T17:56:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5224a7ec624ac5612110a2bdb40e4d6ee82a16b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"myidpt","id":102881,"avatar_url":"https://avatars2.githubusercontent.com/u/102881?v=4","gravatar_id":"","url":"https://api.github.com/users/myidpt","html_url":"https://github.com/myidpt","followers_url":"https://api.github.com/users/myidpt/followers","following_url":"https://api.github.com/users/myidpt/following{/other_user}","gists_url":"https://api.github.com/users/myidpt/gists{/gist_id}","starred_url":"https://api.github.com/users/myidpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myidpt/subscriptions","organizations_url":"https://api.github.com/users/myidpt/orgs","repos_url":"https://api.github.com/users/myidpt/repos","events_url":"https://api.github.com/users/myidpt/events{/privacy}","received_events_url":"https://api.github.com/users/myidpt/received_events","type":"User","site_admin":false},{"login":"wattli","id":24381542,"avatar_url":"https://avatars1.githubusercontent.com/u/24381542?v=4","gravatar_id":"","url":"https://api.github.com/users/wattli","html_url":"https://github.com/wattli","followers_url":"https://api.github.com/users/wattli/followers","following_url":"https://api.github.com/users/wattli/following{/other_user}","gists_url":"https://api.github.com/users/wattli/gists{/gist_id}","starred_url":"https://api.github.com/users/wattli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wattli/subscriptions","organizations_url":"https://api.github.com/users/wattli/orgs","repos_url":"https://api.github.com/users/wattli/repos","events_url":"https://api.github.com/users/wattli/events{/privacy}","received_events_url":"https://api.github.com/users/wattli/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/1951/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/1951/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/1951/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/f536c255500c2e5684020e3d1f837cfdd5645179","head":{"label":"crazytan:registry","ref":"registry","sha":"f536c255500c2e5684020e3d1f837cfdd5645179","user":{"login":"crazytan","id":9136175,"avatar_url":"https://avatars2.githubusercontent.com/u/9136175?v=4","gravatar_id":"","url":"https://api.github.com/users/crazytan","html_url":"https://github.com/crazytan","followers_url":"https://api.github.com/users/crazytan/followers","following_url":"https://api.github.com/users/crazytan/following{/other_user}","gists_url":"https://api.github.com/users/crazytan/gists{/gist_id}","starred_url":"https://api.github.com/users/crazytan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazytan/subscriptions","organizations_url":"https://api.github.com/users/crazytan/orgs","repos_url":"https://api.github.com/users/crazytan/repos","events_url":"https://api.github.com/users/crazytan/events{/privacy}","received_events_url":"https://api.github.com/users/crazytan/received_events","type":"User","site_admin":false},"repo":{"id":109423893,"name":"istio","full_name":"crazytan/istio","owner":{"login":"crazytan","id":9136175,"avatar_url":"https://avatars2.githubusercontent.com/u/9136175?v=4","gravatar_id":"","url":"https://api.github.com/users/crazytan","html_url":"https://github.com/crazytan","followers_url":"https://api.github.com/users/crazytan/followers","following_url":"https://api.github.com/users/crazytan/following{/other_user}","gists_url":"https://api.github.com/users/crazytan/gists{/gist_id}","starred_url":"https://api.github.com/users/crazytan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazytan/subscriptions","organizations_url":"https://api.github.com/users/crazytan/orgs","repos_url":"https://api.github.com/users/crazytan/repos","events_url":"https://api.github.com/users/crazytan/events{/privacy}","received_events_url":"https://api.github.com/users/crazytan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crazytan/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/crazytan/istio","forks_url":"https://api.github.com/repos/crazytan/istio/forks","keys_url":"https://api.github.com/repos/crazytan/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crazytan/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crazytan/istio/teams","hooks_url":"https://api.github.com/repos/crazytan/istio/hooks","issue_events_url":"https://api.github.com/repos/crazytan/istio/issues/events{/number}","events_url":"https://api.github.com/repos/crazytan/istio/events","assignees_url":"https://api.github.com/repos/crazytan/istio/assignees{/user}","branches_url":"https://api.github.com/repos/crazytan/istio/branches{/branch}","tags_url":"https://api.github.com/repos/crazytan/istio/tags","blobs_url":"https://api.github.com/repos/crazytan/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crazytan/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crazytan/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/crazytan/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crazytan/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/crazytan/istio/languages","stargazers_url":"https://api.github.com/repos/crazytan/istio/stargazers","contributors_url":"https://api.github.com/repos/crazytan/istio/contributors","subscribers_url":"https://api.github.com/repos/crazytan/istio/subscribers","subscription_url":"https://api.github.com/repos/crazytan/istio/subscription","commits_url":"https://api.github.com/repos/crazytan/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/crazytan/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/crazytan/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/crazytan/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/crazytan/istio/contents/{+path}","compare_url":"https://api.github.com/repos/crazytan/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crazytan/istio/merges","archive_url":"https://api.github.com/repos/crazytan/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crazytan/istio/downloads","issues_url":"https://api.github.com/repos/crazytan/istio/issues{/number}","pulls_url":"https://api.github.com/repos/crazytan/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/crazytan/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/crazytan/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crazytan/istio/labels{/name}","releases_url":"https://api.github.com/repos/crazytan/istio/releases{/id}","deployments_url":"https://api.github.com/repos/crazytan/istio/deployments","created_at":"2017-11-03T17:25:45Z","updated_at":"2017-11-03T17:25:49Z","pushed_at":"2017-12-01T03:39:08Z","git_url":"git://github.com/crazytan/istio.git","ssh_url":"git@github.com:crazytan/istio.git","clone_url":"https://github.com/crazytan/istio.git","svn_url":"https://github.com/crazytan/istio","homepage":"https://istio.io","size":10469,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"f22fba577cc5907c0af2814610f80823caa552f5","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2017-12-01T17:17:26Z","pushed_at":"2017-12-01T16:53:22Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":10669,"stargazers_count":4152,"watchers_count":4152,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":494,"open_issues":382,"watchers":4152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/1951"},"html":{"href":"https://github.com/istio/istio/pull/1951"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/1951"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/1951/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/1951/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/1951/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/f536c255500c2e5684020e3d1f837cfdd5645179"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"crazytan"}}