{"action":"closed","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/2967","repository_url":"https://api.github.com/repos/catapult-project/catapult","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/2967/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/2967/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/2967/events","html_url":"https://github.com/catapult-project/catapult/issues/2967","id":186822054,"number":2967,"title":"Perf dashboard incorrectly populates bisect fields for complicated story names","user":{"login":"zeptonaut","id":1407397,"avatar_url":"https://avatars.githubusercontent.com/u/1407397?v=3","gravatar_id":"","url":"https://api.github.com/users/zeptonaut","html_url":"https://github.com/zeptonaut","followers_url":"https://api.github.com/users/zeptonaut/followers","following_url":"https://api.github.com/users/zeptonaut/following{/other_user}","gists_url":"https://api.github.com/users/zeptonaut/gists{/gist_id}","starred_url":"https://api.github.com/users/zeptonaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeptonaut/subscriptions","organizations_url":"https://api.github.com/users/zeptonaut/orgs","repos_url":"https://api.github.com/users/zeptonaut/repos","events_url":"https://api.github.com/users/zeptonaut/events{/privacy}","received_events_url":"https://api.github.com/users/zeptonaut/received_events","type":"User","site_admin":false},"labels":[{"id":242943695,"url":"https://api.github.com/repos/catapult-project/catapult/labels/Bug","name":"Bug","color":"fc2929","default":false},{"id":250159481,"url":"https://api.github.com/repos/catapult-project/catapult/labels/Perf%20Dashboard","name":"Perf Dashboard","color":"207de5","default":false}],"state":"closed","locked":false,"assignee":{"login":"perezju","id":16922344,"avatar_url":"https://avatars.githubusercontent.com/u/16922344?v=3","gravatar_id":"","url":"https://api.github.com/users/perezju","html_url":"https://github.com/perezju","followers_url":"https://api.github.com/users/perezju/followers","following_url":"https://api.github.com/users/perezju/following{/other_user}","gists_url":"https://api.github.com/users/perezju/gists{/gist_id}","starred_url":"https://api.github.com/users/perezju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perezju/subscriptions","organizations_url":"https://api.github.com/users/perezju/orgs","repos_url":"https://api.github.com/users/perezju/repos","events_url":"https://api.github.com/users/perezju/events{/privacy}","received_events_url":"https://api.github.com/users/perezju/received_events","type":"User","site_admin":false},"assignees":[{"login":"perezju","id":16922344,"avatar_url":"https://avatars.githubusercontent.com/u/16922344?v=3","gravatar_id":"","url":"https://api.github.com/users/perezju","html_url":"https://github.com/perezju","followers_url":"https://api.github.com/users/perezju/followers","following_url":"https://api.github.com/users/perezju/following{/other_user}","gists_url":"https://api.github.com/users/perezju/gists{/gist_id}","starred_url":"https://api.github.com/users/perezju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perezju/subscriptions","organizations_url":"https://api.github.com/users/perezju/orgs","repos_url":"https://api.github.com/users/perezju/repos","events_url":"https://api.github.com/users/perezju/events{/privacy}","received_events_url":"https://api.github.com/users/perezju/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/catapult-project/catapult/milestones/11","html_url":"https://github.com/catapult-project/catapult/milestone/11","labels_url":"https://api.github.com/repos/catapult-project/catapult/milestones/11/labels","id":1884183,"number":11,"title":"M56","description":"","creator":{"login":"zeptonaut","id":1407397,"avatar_url":"https://avatars.githubusercontent.com/u/1407397?v=3","gravatar_id":"","url":"https://api.github.com/users/zeptonaut","html_url":"https://github.com/zeptonaut","followers_url":"https://api.github.com/users/zeptonaut/followers","following_url":"https://api.github.com/users/zeptonaut/following{/other_user}","gists_url":"https://api.github.com/users/zeptonaut/gists{/gist_id}","starred_url":"https://api.github.com/users/zeptonaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeptonaut/subscriptions","organizations_url":"https://api.github.com/users/zeptonaut/orgs","repos_url":"https://api.github.com/users/zeptonaut/repos","events_url":"https://api.github.com/users/zeptonaut/events{/privacy}","received_events_url":"https://api.github.com/users/zeptonaut/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":20,"state":"closed","created_at":"2016-07-14T19:30:58Z","updated_at":"2017-01-11T16:21:10Z","due_on":"2016-11-17T08:00:00Z","closed_at":"2016-11-23T20:24:20Z"},"comments":10,"created_at":"2016-11-02T14:49:27Z","updated_at":"2017-01-11T16:21:10Z","closed_at":"2017-01-11T16:21:10Z","body":"A brief story ([crbug.com/658840](https://bugs.chromium.org/p/chromium/issues/detail?id=658840)):\r\n\r\n- I started a bisect from the dashboard on the `idle:power_avg` metric of our story, named [`https://www.youtube.com/watch?v=3KANI2dpXLw?autoplay=1`](https://chromeperf.appspot.com/report?sid=74674c766cf8eac5d768508b048ab06395e3277f1e8a1bfcc54610353ec0f260&rev=426756)\r\n- When I click \"bisect\" on the graph, the story filter gets prepopulated as `https...www\\.youtube\\.com.watch\\?v.3KANI2dpXLw\\?autoplay.1`. This is incorrect - when I started a bisect with this story filter, it filtered out *all* stories, including YouTube.\r\n- As a workaround, I modified the story filter to \"youtube\". This caused the correct story to pass through the story filter and actually be run.\r\n- This [new bisect](https://chromeperf.appspot.com/buildbucket_job_status/8997159303725899680) failed with error codes `[B4T_MISSING_METRIC, B4T_REF_RANGE_FAIL]`. `B4T_MISSING_METRIC` indicates that the failure was due to the fact that, when Telemetry was run, the metric on which the bisect was based could not be found. `B4T_REF_RANGE_FAIL` indicates that this failure happened on either the \"good\" or the \"bad\" revisions (or, in our case, both).\r\n- Digging into the [buildbot STDIO](https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1782/steps/steps/logs/stdio) for the failed run, you can see that the `idle:power_avg` metric *does indeed* exist in this run (search for `idle:power_avg` and scroll down to the bottom). However, the story name is slightly different in the test output (`https://www.youtube.com/watch?v=3KANI2dpXLw?autoplay=1`) than in the bisect job (`https___www.youtube.com_watch?v_3KANI2dpXLw?autoplay_1`).\r\n\r\n*Next steps*\r\n- Fix the improper escaping of the story name\r\n- Kick off another bisect where the metric name matches the metric name actually spit out by the benchmark rather than using the default metric name prepopulated by the perf dashboard.\r\n\r\nFYI @nedn @ro-berto @dave-2 "}}
{"actor":{"display_login":"perezju"}}