{"action":"closed","number":1393,"pull_request":{"url":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/1393","id":155388862,"html_url":"https://github.com/thorsten/phpMyFAQ/pull/1393","diff_url":"https://github.com/thorsten/phpMyFAQ/pull/1393.diff","patch_url":"https://github.com/thorsten/phpMyFAQ/pull/1393.patch","issue_url":"https://api.github.com/repos/thorsten/phpMyFAQ/issues/1393","number":1393,"state":"closed","locked":false,"title":"FIX: $lockoutTime should be used only once","user":{"login":"nighknight","id":29982026,"avatar_url":"https://avatars2.githubusercontent.com/u/29982026?v=4","gravatar_id":"","url":"https://api.github.com/users/nighknight","html_url":"https://github.com/nighknight","followers_url":"https://api.github.com/users/nighknight/followers","following_url":"https://api.github.com/users/nighknight/following{/other_user}","gists_url":"https://api.github.com/users/nighknight/gists{/gist_id}","starred_url":"https://api.github.com/users/nighknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nighknight/subscriptions","organizations_url":"https://api.github.com/users/nighknight/orgs","repos_url":"https://api.github.com/users/nighknight/repos","events_url":"https://api.github.com/users/nighknight/events{/privacy}","received_events_url":"https://api.github.com/users/nighknight/received_events","type":"User","site_admin":false},"body":"The $logoutTime should not be used in the calculation of the session timestamp and in the check of the last login, but only in the login check function isFailedLastLoginAttempt (). \r\n\r\nReasons:\r\n1. It is more intuitive if the session timestamp represents the time of the actual login attempt.\r\n2. If it is taken into account in both functions, the time has to elapse twice. This is not obvious to see.\r\n","created_at":"2017-11-29T16:30:06Z","updated_at":"2017-11-29T17:17:39Z","closed_at":"2017-11-29T17:17:39Z","merged_at":"2017-11-29T17:17:39Z","merge_commit_sha":"0e2f6610c3a7df13a9c75c5453b14cc2ca12b92b","assignee":{"login":"thorsten","id":45284,"avatar_url":"https://avatars2.githubusercontent.com/u/45284?v=4","gravatar_id":"","url":"https://api.github.com/users/thorsten","html_url":"https://github.com/thorsten","followers_url":"https://api.github.com/users/thorsten/followers","following_url":"https://api.github.com/users/thorsten/following{/other_user}","gists_url":"https://api.github.com/users/thorsten/gists{/gist_id}","starred_url":"https://api.github.com/users/thorsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorsten/subscriptions","organizations_url":"https://api.github.com/users/thorsten/orgs","repos_url":"https://api.github.com/users/thorsten/repos","events_url":"https://api.github.com/users/thorsten/events{/privacy}","received_events_url":"https://api.github.com/users/thorsten/received_events","type":"User","site_admin":false},"assignees":[{"login":"thorsten","id":45284,"avatar_url":"https://avatars2.githubusercontent.com/u/45284?v=4","gravatar_id":"","url":"https://api.github.com/users/thorsten","html_url":"https://github.com/thorsten","followers_url":"https://api.github.com/users/thorsten/followers","following_url":"https://api.github.com/users/thorsten/following{/other_user}","gists_url":"https://api.github.com/users/thorsten/gists{/gist_id}","starred_url":"https://api.github.com/users/thorsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorsten/subscriptions","organizations_url":"https://api.github.com/users/thorsten/orgs","repos_url":"https://api.github.com/users/thorsten/repos","events_url":"https://api.github.com/users/thorsten/events{/privacy}","received_events_url":"https://api.github.com/users/thorsten/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/1393/commits","review_comments_url":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/1393/comments","review_comment_url":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thorsten/phpMyFAQ/issues/1393/comments","statuses_url":"https://api.github.com/repos/thorsten/phpMyFAQ/statuses/34271603f87a044084f164a0ef254780f033d894","head":{"label":"nighknight:2.9","ref":"2.9","sha":"34271603f87a044084f164a0ef254780f033d894","user":{"login":"nighknight","id":29982026,"avatar_url":"https://avatars2.githubusercontent.com/u/29982026?v=4","gravatar_id":"","url":"https://api.github.com/users/nighknight","html_url":"https://github.com/nighknight","followers_url":"https://api.github.com/users/nighknight/followers","following_url":"https://api.github.com/users/nighknight/following{/other_user}","gists_url":"https://api.github.com/users/nighknight/gists{/gist_id}","starred_url":"https://api.github.com/users/nighknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nighknight/subscriptions","organizations_url":"https://api.github.com/users/nighknight/orgs","repos_url":"https://api.github.com/users/nighknight/repos","events_url":"https://api.github.com/users/nighknight/events{/privacy}","received_events_url":"https://api.github.com/users/nighknight/received_events","type":"User","site_admin":false},"repo":{"id":96549086,"name":"phpMyFAQ","full_name":"nighknight/phpMyFAQ","owner":{"login":"nighknight","id":29982026,"avatar_url":"https://avatars2.githubusercontent.com/u/29982026?v=4","gravatar_id":"","url":"https://api.github.com/users/nighknight","html_url":"https://github.com/nighknight","followers_url":"https://api.github.com/users/nighknight/followers","following_url":"https://api.github.com/users/nighknight/following{/other_user}","gists_url":"https://api.github.com/users/nighknight/gists{/gist_id}","starred_url":"https://api.github.com/users/nighknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nighknight/subscriptions","organizations_url":"https://api.github.com/users/nighknight/orgs","repos_url":"https://api.github.com/users/nighknight/repos","events_url":"https://api.github.com/users/nighknight/events{/privacy}","received_events_url":"https://api.github.com/users/nighknight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nighknight/phpMyFAQ","description":"phpMyFAQ - Open Source FAQ system for PHP and HHVM with MySQL, PostgreSQL and other databases","fork":true,"url":"https://api.github.com/repos/nighknight/phpMyFAQ","forks_url":"https://api.github.com/repos/nighknight/phpMyFAQ/forks","keys_url":"https://api.github.com/repos/nighknight/phpMyFAQ/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nighknight/phpMyFAQ/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nighknight/phpMyFAQ/teams","hooks_url":"https://api.github.com/repos/nighknight/phpMyFAQ/hooks","issue_events_url":"https://api.github.com/repos/nighknight/phpMyFAQ/issues/events{/number}","events_url":"https://api.github.com/repos/nighknight/phpMyFAQ/events","assignees_url":"https://api.github.com/repos/nighknight/phpMyFAQ/assignees{/user}","branches_url":"https://api.github.com/repos/nighknight/phpMyFAQ/branches{/branch}","tags_url":"https://api.github.com/repos/nighknight/phpMyFAQ/tags","blobs_url":"https://api.github.com/repos/nighknight/phpMyFAQ/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nighknight/phpMyFAQ/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nighknight/phpMyFAQ/git/refs{/sha}","trees_url":"https://api.github.com/repos/nighknight/phpMyFAQ/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nighknight/phpMyFAQ/statuses/{sha}","languages_url":"https://api.github.com/repos/nighknight/phpMyFAQ/languages","stargazers_url":"https://api.github.com/repos/nighknight/phpMyFAQ/stargazers","contributors_url":"https://api.github.com/repos/nighknight/phpMyFAQ/contributors","subscribers_url":"https://api.github.com/repos/nighknight/phpMyFAQ/subscribers","subscription_url":"https://api.github.com/repos/nighknight/phpMyFAQ/subscription","commits_url":"https://api.github.com/repos/nighknight/phpMyFAQ/commits{/sha}","git_commits_url":"https://api.github.com/repos/nighknight/phpMyFAQ/git/commits{/sha}","comments_url":"https://api.github.com/repos/nighknight/phpMyFAQ/comments{/number}","issue_comment_url":"https://api.github.com/repos/nighknight/phpMyFAQ/issues/comments{/number}","contents_url":"https://api.github.com/repos/nighknight/phpMyFAQ/contents/{+path}","compare_url":"https://api.github.com/repos/nighknight/phpMyFAQ/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nighknight/phpMyFAQ/merges","archive_url":"https://api.github.com/repos/nighknight/phpMyFAQ/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nighknight/phpMyFAQ/downloads","issues_url":"https://api.github.com/repos/nighknight/phpMyFAQ/issues{/number}","pulls_url":"https://api.github.com/repos/nighknight/phpMyFAQ/pulls{/number}","milestones_url":"https://api.github.com/repos/nighknight/phpMyFAQ/milestones{/number}","notifications_url":"https://api.github.com/repos/nighknight/phpMyFAQ/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nighknight/phpMyFAQ/labels{/name}","releases_url":"https://api.github.com/repos/nighknight/phpMyFAQ/releases{/id}","deployments_url":"https://api.github.com/repos/nighknight/phpMyFAQ/deployments","created_at":"2017-07-07T14:57:48Z","updated_at":"2017-07-07T14:57:52Z","pushed_at":"2017-11-29T16:23:47Z","git_url":"git://github.com/nighknight/phpMyFAQ.git","ssh_url":"git@github.com:nighknight/phpMyFAQ.git","clone_url":"https://github.com/nighknight/phpMyFAQ.git","svn_url":"https://github.com/nighknight/phpMyFAQ","homepage":"http://www.phpmyfaq.de","size":31514,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thorsten:2.9","ref":"2.9","sha":"1c269975b83b2df2f0a10770397878127d0a9374","user":{"login":"thorsten","id":45284,"avatar_url":"https://avatars2.githubusercontent.com/u/45284?v=4","gravatar_id":"","url":"https://api.github.com/users/thorsten","html_url":"https://github.com/thorsten","followers_url":"https://api.github.com/users/thorsten/followers","following_url":"https://api.github.com/users/thorsten/following{/other_user}","gists_url":"https://api.github.com/users/thorsten/gists{/gist_id}","starred_url":"https://api.github.com/users/thorsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorsten/subscriptions","organizations_url":"https://api.github.com/users/thorsten/orgs","repos_url":"https://api.github.com/users/thorsten/repos","events_url":"https://api.github.com/users/thorsten/events{/privacy}","received_events_url":"https://api.github.com/users/thorsten/received_events","type":"User","site_admin":false},"repo":{"id":269027,"name":"phpMyFAQ","full_name":"thorsten/phpMyFAQ","owner":{"login":"thorsten","id":45284,"avatar_url":"https://avatars2.githubusercontent.com/u/45284?v=4","gravatar_id":"","url":"https://api.github.com/users/thorsten","html_url":"https://github.com/thorsten","followers_url":"https://api.github.com/users/thorsten/followers","following_url":"https://api.github.com/users/thorsten/following{/other_user}","gists_url":"https://api.github.com/users/thorsten/gists{/gist_id}","starred_url":"https://api.github.com/users/thorsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorsten/subscriptions","organizations_url":"https://api.github.com/users/thorsten/orgs","repos_url":"https://api.github.com/users/thorsten/repos","events_url":"https://api.github.com/users/thorsten/events{/privacy}","received_events_url":"https://api.github.com/users/thorsten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thorsten/phpMyFAQ","description":"phpMyFAQ - Open Source FAQ system for PHP and HHVM with MySQL, PostgreSQL and other databases","fork":false,"url":"https://api.github.com/repos/thorsten/phpMyFAQ","forks_url":"https://api.github.com/repos/thorsten/phpMyFAQ/forks","keys_url":"https://api.github.com/repos/thorsten/phpMyFAQ/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thorsten/phpMyFAQ/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thorsten/phpMyFAQ/teams","hooks_url":"https://api.github.com/repos/thorsten/phpMyFAQ/hooks","issue_events_url":"https://api.github.com/repos/thorsten/phpMyFAQ/issues/events{/number}","events_url":"https://api.github.com/repos/thorsten/phpMyFAQ/events","assignees_url":"https://api.github.com/repos/thorsten/phpMyFAQ/assignees{/user}","branches_url":"https://api.github.com/repos/thorsten/phpMyFAQ/branches{/branch}","tags_url":"https://api.github.com/repos/thorsten/phpMyFAQ/tags","blobs_url":"https://api.github.com/repos/thorsten/phpMyFAQ/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thorsten/phpMyFAQ/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thorsten/phpMyFAQ/git/refs{/sha}","trees_url":"https://api.github.com/repos/thorsten/phpMyFAQ/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thorsten/phpMyFAQ/statuses/{sha}","languages_url":"https://api.github.com/repos/thorsten/phpMyFAQ/languages","stargazers_url":"https://api.github.com/repos/thorsten/phpMyFAQ/stargazers","contributors_url":"https://api.github.com/repos/thorsten/phpMyFAQ/contributors","subscribers_url":"https://api.github.com/repos/thorsten/phpMyFAQ/subscribers","subscription_url":"https://api.github.com/repos/thorsten/phpMyFAQ/subscription","commits_url":"https://api.github.com/repos/thorsten/phpMyFAQ/commits{/sha}","git_commits_url":"https://api.github.com/repos/thorsten/phpMyFAQ/git/commits{/sha}","comments_url":"https://api.github.com/repos/thorsten/phpMyFAQ/comments{/number}","issue_comment_url":"https://api.github.com/repos/thorsten/phpMyFAQ/issues/comments{/number}","contents_url":"https://api.github.com/repos/thorsten/phpMyFAQ/contents/{+path}","compare_url":"https://api.github.com/repos/thorsten/phpMyFAQ/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thorsten/phpMyFAQ/merges","archive_url":"https://api.github.com/repos/thorsten/phpMyFAQ/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thorsten/phpMyFAQ/downloads","issues_url":"https://api.github.com/repos/thorsten/phpMyFAQ/issues{/number}","pulls_url":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls{/number}","milestones_url":"https://api.github.com/repos/thorsten/phpMyFAQ/milestones{/number}","notifications_url":"https://api.github.com/repos/thorsten/phpMyFAQ/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thorsten/phpMyFAQ/labels{/name}","releases_url":"https://api.github.com/repos/thorsten/phpMyFAQ/releases{/id}","deployments_url":"https://api.github.com/repos/thorsten/phpMyFAQ/deployments","created_at":"2009-08-04T19:26:15Z","updated_at":"2017-11-28T18:33:23Z","pushed_at":"2017-11-29T17:17:39Z","git_url":"git://github.com/thorsten/phpMyFAQ.git","ssh_url":"git@github.com:thorsten/phpMyFAQ.git","clone_url":"https://github.com/thorsten/phpMyFAQ.git","svn_url":"https://github.com/thorsten/phpMyFAQ","homepage":"http://www.phpmyfaq.de","size":32527,"stargazers_count":362,"watchers_count":362,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":169,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":169,"open_issues":188,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/1393"},"html":{"href":"https://github.com/thorsten/phpMyFAQ/pull/1393"},"issue":{"href":"https://api.github.com/repos/thorsten/phpMyFAQ/issues/1393"},"comments":{"href":"https://api.github.com/repos/thorsten/phpMyFAQ/issues/1393/comments"},"review_comments":{"href":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/1393/comments"},"review_comment":{"href":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thorsten/phpMyFAQ/pulls/1393/commits"},"statuses":{"href":"https://api.github.com/repos/thorsten/phpMyFAQ/statuses/34271603f87a044084f164a0ef254780f033d894"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"thorsten","id":45284,"avatar_url":"https://avatars2.githubusercontent.com/u/45284?v=4","gravatar_id":"","url":"https://api.github.com/users/thorsten","html_url":"https://github.com/thorsten","followers_url":"https://api.github.com/users/thorsten/followers","following_url":"https://api.github.com/users/thorsten/following{/other_user}","gists_url":"https://api.github.com/users/thorsten/gists{/gist_id}","starred_url":"https://api.github.com/users/thorsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorsten/subscriptions","organizations_url":"https://api.github.com/users/thorsten/orgs","repos_url":"https://api.github.com/users/thorsten/repos","events_url":"https://api.github.com/users/thorsten/events{/privacy}","received_events_url":"https://api.github.com/users/thorsten/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"thorsten"}}