{"action":"created","comment":{"url":"https://api.github.com/repos/http4s/http4s/pulls/comments/141419851","pull_request_review_id":65627595,"id":141419851,"diff_hunk":"@@ -21,28 +22,24 @@ package object server {\n     * @tparam C the request type of the resulting service\n     * @tparam D the response type of the resulting service\n     */\n-  type Middleware[F[_], A, B, C, D] = Service[F, A, B] => Service[F, C, D]\n+  type Middleware[F[_], A, B, C, D] = Kleisli[F, A, B] => Kleisli[F, C, D]\n \n   object Middleware {\n-    def apply[F[_], A, B, C, D](f: (C, Service[F, A, B]) => F[D]): Middleware[F, A, B, C, D] = {\n-      service =>\n-        Service.lift { req =>\n-          f(req, service)\n-        }\n-    }\n+    def apply[F[_], A, B, C, D](f: (C, Kleisli[F, A, B]) => F[D]): Middleware[F, A, B, C, D] =","path":"server/src/main/scala/org/http4s/server/package.scala","position":26,"original_position":26,"commit_id":"eef3194964b7b1aedf65a51a68bdadb5b904da7d","original_commit_id":"eef3194964b7b1aedf65a51a68bdadb5b904da7d","user":{"login":"rossabaker","id":142698,"avatar_url":"https://avatars3.githubusercontent.com/u/142698?v=4","gravatar_id":"","url":"https://api.github.com/users/rossabaker","html_url":"https://github.com/rossabaker","followers_url":"https://api.github.com/users/rossabaker/followers","following_url":"https://api.github.com/users/rossabaker/following{/other_user}","gists_url":"https://api.github.com/users/rossabaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossabaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossabaker/subscriptions","organizations_url":"https://api.github.com/users/rossabaker/orgs","repos_url":"https://api.github.com/users/rossabaker/repos","events_url":"https://api.github.com/users/rossabaker/events{/privacy}","received_events_url":"https://api.github.com/users/rossabaker/received_events","type":"User","site_admin":false},"body":"Does anybody even use these?  They're kind of Finagle-like.  I have to stare at it every time I remember it's here to understand how it works.","created_at":"2017-09-27T17:54:10Z","updated_at":"2017-09-27T17:55:42Z","html_url":"https://github.com/http4s/http4s/pull/1424#discussion_r141419851","pull_request_url":"https://api.github.com/repos/http4s/http4s/pulls/1424","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments/141419851"},"html":{"href":"https://github.com/http4s/http4s/pull/1424#discussion_r141419851"},"pull_request":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1424"}}},"pull_request":{"url":"https://api.github.com/repos/http4s/http4s/pulls/1424","id":143213434,"html_url":"https://github.com/http4s/http4s/pull/1424","diff_url":"https://github.com/http4s/http4s/pull/1424.diff","patch_url":"https://github.com/http4s/http4s/pull/1424.patch","issue_url":"https://api.github.com/repos/http4s/http4s/issues/1424","number":1424,"state":"open","locked":false,"title":"Deprecate Service and remove MaybeResponse","user":{"login":"aeons","id":1432894,"avatar_url":"https://avatars2.githubusercontent.com/u/1432894?v=4","gravatar_id":"","url":"https://api.github.com/users/aeons","html_url":"https://github.com/aeons","followers_url":"https://api.github.com/users/aeons/followers","following_url":"https://api.github.com/users/aeons/following{/other_user}","gists_url":"https://api.github.com/users/aeons/gists{/gist_id}","starred_url":"https://api.github.com/users/aeons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeons/subscriptions","organizations_url":"https://api.github.com/users/aeons/orgs","repos_url":"https://api.github.com/users/aeons/repos","events_url":"https://api.github.com/users/aeons/events{/privacy}","received_events_url":"https://api.github.com/users/aeons/received_events","type":"User","site_admin":false},"body":"Following discussion on Gittter, this is an experiment to \r\n\r\n1. deprecate the `Service[F, A, B]` type alias and object of the same name in favour of the raw `Kleisli[F, A, B]` type\r\n2. remove the `MaybeResponse[F]` and `Pass[F]` types and changing the `HttpService[F]` type to be `Kleisli[OptionT[F, ?], Request[F], Response[F]]`","created_at":"2017-09-26T18:47:34Z","updated_at":"2017-09-27T17:55:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2aeba6b2b124602cf39d72dcd90677a22f5a0a7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/http4s/http4s/pulls/1424/commits","review_comments_url":"https://api.github.com/repos/http4s/http4s/pulls/1424/comments","review_comment_url":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/http4s/http4s/issues/1424/comments","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/eef3194964b7b1aedf65a51a68bdadb5b904da7d","head":{"label":"aeons:kleislis-all-over","ref":"kleislis-all-over","sha":"eef3194964b7b1aedf65a51a68bdadb5b904da7d","user":{"login":"aeons","id":1432894,"avatar_url":"https://avatars2.githubusercontent.com/u/1432894?v=4","gravatar_id":"","url":"https://api.github.com/users/aeons","html_url":"https://github.com/aeons","followers_url":"https://api.github.com/users/aeons/followers","following_url":"https://api.github.com/users/aeons/following{/other_user}","gists_url":"https://api.github.com/users/aeons/gists{/gist_id}","starred_url":"https://api.github.com/users/aeons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeons/subscriptions","organizations_url":"https://api.github.com/users/aeons/orgs","repos_url":"https://api.github.com/users/aeons/repos","events_url":"https://api.github.com/users/aeons/events{/privacy}","received_events_url":"https://api.github.com/users/aeons/received_events","type":"User","site_admin":false},"repo":{"id":71454217,"name":"http4s","full_name":"aeons/http4s","owner":{"login":"aeons","id":1432894,"avatar_url":"https://avatars2.githubusercontent.com/u/1432894?v=4","gravatar_id":"","url":"https://api.github.com/users/aeons","html_url":"https://github.com/aeons","followers_url":"https://api.github.com/users/aeons/followers","following_url":"https://api.github.com/users/aeons/following{/other_user}","gists_url":"https://api.github.com/users/aeons/gists{/gist_id}","starred_url":"https://api.github.com/users/aeons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeons/subscriptions","organizations_url":"https://api.github.com/users/aeons/orgs","repos_url":"https://api.github.com/users/aeons/repos","events_url":"https://api.github.com/users/aeons/events{/privacy}","received_events_url":"https://api.github.com/users/aeons/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aeons/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":true,"url":"https://api.github.com/repos/aeons/http4s","forks_url":"https://api.github.com/repos/aeons/http4s/forks","keys_url":"https://api.github.com/repos/aeons/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeons/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeons/http4s/teams","hooks_url":"https://api.github.com/repos/aeons/http4s/hooks","issue_events_url":"https://api.github.com/repos/aeons/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/aeons/http4s/events","assignees_url":"https://api.github.com/repos/aeons/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/aeons/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/aeons/http4s/tags","blobs_url":"https://api.github.com/repos/aeons/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeons/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeons/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeons/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeons/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/aeons/http4s/languages","stargazers_url":"https://api.github.com/repos/aeons/http4s/stargazers","contributors_url":"https://api.github.com/repos/aeons/http4s/contributors","subscribers_url":"https://api.github.com/repos/aeons/http4s/subscribers","subscription_url":"https://api.github.com/repos/aeons/http4s/subscription","commits_url":"https://api.github.com/repos/aeons/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeons/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeons/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeons/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeons/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/aeons/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeons/http4s/merges","archive_url":"https://api.github.com/repos/aeons/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeons/http4s/downloads","issues_url":"https://api.github.com/repos/aeons/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/aeons/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/aeons/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/aeons/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeons/http4s/labels{/name}","releases_url":"https://api.github.com/repos/aeons/http4s/releases{/id}","deployments_url":"https://api.github.com/repos/aeons/http4s/deployments","created_at":"2016-10-20T10:57:24Z","updated_at":"2016-10-20T10:57:26Z","pushed_at":"2017-09-27T17:25:31Z","git_url":"git://github.com/aeons/http4s.git","ssh_url":"git@github.com:aeons/http4s.git","clone_url":"https://github.com/aeons/http4s.git","svn_url":"https://github.com/aeons/http4s","homepage":"http://http4s.org/","size":10440,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"http4s:master","ref":"master","sha":"c3c3ef7c4cb2cba0a7379a81a6de8fa369541123","user":{"login":"http4s","id":1527492,"avatar_url":"https://avatars3.githubusercontent.com/u/1527492?v=4","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":3692188,"name":"http4s","full_name":"http4s/http4s","owner":{"login":"http4s","id":1527492,"avatar_url":"https://avatars3.githubusercontent.com/u/1527492?v=4","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http4s/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":false,"url":"https://api.github.com/repos/http4s/http4s","forks_url":"https://api.github.com/repos/http4s/http4s/forks","keys_url":"https://api.github.com/repos/http4s/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/http4s/teams","hooks_url":"https://api.github.com/repos/http4s/http4s/hooks","issue_events_url":"https://api.github.com/repos/http4s/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/http4s/events","assignees_url":"https://api.github.com/repos/http4s/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/http4s/tags","blobs_url":"https://api.github.com/repos/http4s/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/http4s/languages","stargazers_url":"https://api.github.com/repos/http4s/http4s/stargazers","contributors_url":"https://api.github.com/repos/http4s/http4s/contributors","subscribers_url":"https://api.github.com/repos/http4s/http4s/subscribers","subscription_url":"https://api.github.com/repos/http4s/http4s/subscription","commits_url":"https://api.github.com/repos/http4s/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/http4s/merges","archive_url":"https://api.github.com/repos/http4s/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/http4s/downloads","issues_url":"https://api.github.com/repos/http4s/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/http4s/labels{/name}","releases_url":"https://api.github.com/repos/http4s/http4s/releases{/id}","deployments_url":"https://api.github.com/repos/http4s/http4s/deployments","created_at":"2012-03-12T04:41:20Z","updated_at":"2017-09-26T11:18:42Z","pushed_at":"2017-09-27T17:25:33Z","git_url":"git://github.com/http4s/http4s.git","ssh_url":"git@github.com:http4s/http4s.git","clone_url":"https://github.com/http4s/http4s.git","svn_url":"https://github.com/http4s/http4s","homepage":"http://http4s.org/","size":78370,"stargazers_count":852,"watchers_count":852,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":226,"mirror_url":null,"open_issues_count":120,"forks":226,"open_issues":120,"watchers":852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1424"},"html":{"href":"https://github.com/http4s/http4s/pull/1424"},"issue":{"href":"https://api.github.com/repos/http4s/http4s/issues/1424"},"comments":{"href":"https://api.github.com/repos/http4s/http4s/issues/1424/comments"},"review_comments":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1424/comments"},"review_comment":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/http4s/http4s/pulls/1424/commits"},"statuses":{"href":"https://api.github.com/repos/http4s/http4s/statuses/eef3194964b7b1aedf65a51a68bdadb5b904da7d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rossabaker"}}