{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/n4js/pulls/comments/145132582","pull_request_review_id":69886599,"id":145132582,"diff_hunk":"@@ -86,8 +99,19 @@ static private void createComplexNodes(Script script, TreeSet<ControlFlowElement\n \n \tstatic private void connectComplexNodes(ComplexNodeMapper cnMapper) {\n \t\tfor (ComplexNode cn : cnMapper.getAll()) {\n-\t\t\tfor (Node mNode : cn.getAllButExitNodes()) {\n-\t\t\t\tconnectNode(cnMapper, mNode);\n+\t\t\tList<Node> removeNodes = new LinkedList<>();","path":"plugins/org.eclipse.n4js.flowgraphs/src/org/eclipse/n4js/flowgraphs/factories/ControlFlowGraphFactory.java","position":63,"original_position":63,"commit_id":"4ef930f920cba54d092a8d2925c201a71ee07d89","original_commit_id":"4ef930f920cba54d092a8d2925c201a71ee07d89","user":{"login":"mmews-n4","id":20560257,"avatar_url":"https://avatars3.githubusercontent.com/u/20560257?v=4","gravatar_id":"","url":"https://api.github.com/users/mmews-n4","html_url":"https://github.com/mmews-n4","followers_url":"https://api.github.com/users/mmews-n4/followers","following_url":"https://api.github.com/users/mmews-n4/following{/other_user}","gists_url":"https://api.github.com/users/mmews-n4/gists{/gist_id}","starred_url":"https://api.github.com/users/mmews-n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmews-n4/subscriptions","organizations_url":"https://api.github.com/users/mmews-n4/orgs","repos_url":"https://api.github.com/users/mmews-n4/repos","events_url":"https://api.github.com/users/mmews-n4/events{/privacy}","received_events_url":"https://api.github.com/users/mmews-n4/received_events","type":"User","site_admin":false},"body":"as discussed","created_at":"2017-10-17T13:39:22Z","updated_at":"2017-10-17T13:39:23Z","html_url":"https://github.com/eclipse/n4js/pull/286#discussion_r145132582","pull_request_url":"https://api.github.com/repos/eclipse/n4js/pulls/286","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/comments/145132582"},"html":{"href":"https://github.com/eclipse/n4js/pull/286#discussion_r145132582"},"pull_request":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/286"}},"in_reply_to_id":145108527},"pull_request":{"url":"https://api.github.com/repos/eclipse/n4js/pulls/286","id":147007242,"html_url":"https://github.com/eclipse/n4js/pull/286","diff_url":"https://github.com/eclipse/n4js/pull/286.diff","patch_url":"https://github.com/eclipse/n4js/pull/286.patch","issue_url":"https://api.github.com/repos/eclipse/n4js/issues/286","number":286,"state":"open","locked":false,"title":"GH-235 Part 1: As a developer I want a def-use analysis (and as a smith a data flow analysis)","user":{"login":"mmews-n4","id":20560257,"avatar_url":"https://avatars3.githubusercontent.com/u/20560257?v=4","gravatar_id":"","url":"https://api.github.com/users/mmews-n4","html_url":"https://github.com/mmews-n4","followers_url":"https://api.github.com/users/mmews-n4/followers","following_url":"https://api.github.com/users/mmews-n4/following{/other_user}","gists_url":"https://api.github.com/users/mmews-n4/gists{/gist_id}","starred_url":"https://api.github.com/users/mmews-n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmews-n4/subscriptions","organizations_url":"https://api.github.com/users/mmews-n4/orgs","repos_url":"https://api.github.com/users/mmews-n4/repos","events_url":"https://api.github.com/users/mmews-n4/events{/privacy}","received_events_url":"https://api.github.com/users/mmews-n4/received_events","type":"User","site_admin":false},"body":"see #235 \r\n\r\nchanges:\r\n- Reduce the flow graph size to increase performance\r\n- Care about cancellation events\r\n- Integrate open changes from previous user story 2827 / #120\r\n- other minor fixes\r\n- first changes to make PathWalkers joinable\r\n\r\n\r\n","created_at":"2017-10-17T11:02:33Z","updated_at":"2017-10-17T13:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b48cc0d1bba1071d1717e8de883dbd54587eb3a6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/n4js/pulls/286/commits","review_comments_url":"https://api.github.com/repos/eclipse/n4js/pulls/286/comments","review_comment_url":"https://api.github.com/repos/eclipse/n4js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/n4js/issues/286/comments","statuses_url":"https://api.github.com/repos/eclipse/n4js/statuses/4ef930f920cba54d092a8d2925c201a71ee07d89","head":{"label":"eclipse:GH-235","ref":"GH-235","sha":"4ef930f920cba54d092a8d2925c201a71ee07d89","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":87847606,"name":"n4js","full_name":"eclipse/n4js","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/n4js","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/n4js","forks_url":"https://api.github.com/repos/eclipse/n4js/forks","keys_url":"https://api.github.com/repos/eclipse/n4js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/n4js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/n4js/teams","hooks_url":"https://api.github.com/repos/eclipse/n4js/hooks","issue_events_url":"https://api.github.com/repos/eclipse/n4js/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/n4js/events","assignees_url":"https://api.github.com/repos/eclipse/n4js/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/n4js/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/n4js/tags","blobs_url":"https://api.github.com/repos/eclipse/n4js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/n4js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/n4js/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/n4js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/n4js/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/n4js/languages","stargazers_url":"https://api.github.com/repos/eclipse/n4js/stargazers","contributors_url":"https://api.github.com/repos/eclipse/n4js/contributors","subscribers_url":"https://api.github.com/repos/eclipse/n4js/subscribers","subscription_url":"https://api.github.com/repos/eclipse/n4js/subscription","commits_url":"https://api.github.com/repos/eclipse/n4js/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/n4js/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/n4js/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/n4js/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/n4js/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/n4js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/n4js/merges","archive_url":"https://api.github.com/repos/eclipse/n4js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/n4js/downloads","issues_url":"https://api.github.com/repos/eclipse/n4js/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/n4js/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/n4js/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/n4js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/n4js/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/n4js/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/n4js/deployments","created_at":"2017-04-10T19:05:37Z","updated_at":"2017-09-17T11:33:38Z","pushed_at":"2017-10-17T12:46:59Z","git_url":"git://github.com/eclipse/n4js.git","ssh_url":"git@github.com:eclipse/n4js.git","clone_url":"https://github.com/eclipse/n4js.git","svn_url":"https://github.com/eclipse/n4js","homepage":null,"size":40005,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":82,"forks":5,"open_issues":82,"watchers":6,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"7b5eab21ba769c116ca844a6ddf7cc50a8ae030e","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":87847606,"name":"n4js","full_name":"eclipse/n4js","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/n4js","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/n4js","forks_url":"https://api.github.com/repos/eclipse/n4js/forks","keys_url":"https://api.github.com/repos/eclipse/n4js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/n4js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/n4js/teams","hooks_url":"https://api.github.com/repos/eclipse/n4js/hooks","issue_events_url":"https://api.github.com/repos/eclipse/n4js/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/n4js/events","assignees_url":"https://api.github.com/repos/eclipse/n4js/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/n4js/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/n4js/tags","blobs_url":"https://api.github.com/repos/eclipse/n4js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/n4js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/n4js/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/n4js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/n4js/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/n4js/languages","stargazers_url":"https://api.github.com/repos/eclipse/n4js/stargazers","contributors_url":"https://api.github.com/repos/eclipse/n4js/contributors","subscribers_url":"https://api.github.com/repos/eclipse/n4js/subscribers","subscription_url":"https://api.github.com/repos/eclipse/n4js/subscription","commits_url":"https://api.github.com/repos/eclipse/n4js/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/n4js/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/n4js/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/n4js/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/n4js/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/n4js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/n4js/merges","archive_url":"https://api.github.com/repos/eclipse/n4js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/n4js/downloads","issues_url":"https://api.github.com/repos/eclipse/n4js/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/n4js/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/n4js/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/n4js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/n4js/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/n4js/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/n4js/deployments","created_at":"2017-04-10T19:05:37Z","updated_at":"2017-09-17T11:33:38Z","pushed_at":"2017-10-17T12:46:59Z","git_url":"git://github.com/eclipse/n4js.git","ssh_url":"git@github.com:eclipse/n4js.git","clone_url":"https://github.com/eclipse/n4js.git","svn_url":"https://github.com/eclipse/n4js","homepage":null,"size":40005,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":82,"forks":5,"open_issues":82,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/286"},"html":{"href":"https://github.com/eclipse/n4js/pull/286"},"issue":{"href":"https://api.github.com/repos/eclipse/n4js/issues/286"},"comments":{"href":"https://api.github.com/repos/eclipse/n4js/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/n4js/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/n4js/statuses/4ef930f920cba54d092a8d2925c201a71ee07d89"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mmews-n4"}}