{"action":"created","comment":{"url":"https://api.github.com/repos/amber-crystal/amber/pulls/comments/134856338","pull_request_review_id":58198992,"id":134856338,"diff_hunk":"@@ -18,8 +44,8 @@ module Amber\n       instance.all_routes\n     end\n \n-    def self.settings\n-      instance\n+    def self.config(&block)","path":"src/amber.cr","position":39,"original_position":39,"commit_id":"140c2371b0044ba073dfa63fa3829a616111925a","original_commit_id":"140c2371b0044ba073dfa63fa3829a616111925a","user":{"login":"drujensen","id":18718,"avatar_url":"https://avatars2.githubusercontent.com/u/18718?v=4","gravatar_id":"","url":"https://api.github.com/users/drujensen","html_url":"https://github.com/drujensen","followers_url":"https://api.github.com/users/drujensen/followers","following_url":"https://api.github.com/users/drujensen/following{/other_user}","gists_url":"https://api.github.com/users/drujensen/gists{/gist_id}","starred_url":"https://api.github.com/users/drujensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drujensen/subscriptions","organizations_url":"https://api.github.com/users/drujensen/orgs","repos_url":"https://api.github.com/users/drujensen/repos","events_url":"https://api.github.com/users/drujensen/events{/privacy}","received_events_url":"https://api.github.com/users/drujensen/received_events","type":"User","site_admin":false},"body":"🥇 I really like this.  Should we should consider this pattern for the pipes as well?  I had something similar in Kemalyst.","created_at":"2017-08-23T20:05:53Z","updated_at":"2017-08-23T20:08:27Z","html_url":"https://github.com/amber-crystal/amber/pull/183#discussion_r134856338","pull_request_url":"https://api.github.com/repos/amber-crystal/amber/pulls/183","_links":{"self":{"href":"https://api.github.com/repos/amber-crystal/amber/pulls/comments/134856338"},"html":{"href":"https://github.com/amber-crystal/amber/pull/183#discussion_r134856338"},"pull_request":{"href":"https://api.github.com/repos/amber-crystal/amber/pulls/183"}}},"pull_request":{"url":"https://api.github.com/repos/amber-crystal/amber/pulls/183","id":136767531,"html_url":"https://github.com/amber-crystal/amber/pull/183","diff_url":"https://github.com/amber-crystal/amber/pull/183.diff","patch_url":"https://github.com/amber-crystal/amber/pull/183.patch","issue_url":"https://api.github.com/repos/amber-crystal/amber/issues/183","number":183,"state":"open","locked":false,"title":"Clean Up and Removed Code from amber.cr","user":{"login":"eliasjpr","id":1685772,"avatar_url":"https://avatars2.githubusercontent.com/u/1685772?v=4","gravatar_id":"","url":"https://api.github.com/users/eliasjpr","html_url":"https://github.com/eliasjpr","followers_url":"https://api.github.com/users/eliasjpr/followers","following_url":"https://api.github.com/users/eliasjpr/following{/other_user}","gists_url":"https://api.github.com/users/eliasjpr/gists{/gist_id}","starred_url":"https://api.github.com/users/eliasjpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliasjpr/subscriptions","organizations_url":"https://api.github.com/users/eliasjpr/orgs","repos_url":"https://api.github.com/users/eliasjpr/repos","events_url":"https://api.github.com/users/eliasjpr/events{/privacy}","received_events_url":"https://api.github.com/users/eliasjpr/received_events","type":"User","site_admin":false},"body":"Amber.cr needed tlc and for that reason proceeded to do some cleanup\r\nand removed unused code from the file.\r\n\r\nAfter the changes now the initializer methods is 1 line small,\r\nproperties are set with their corresponding default value and added\r\nsome ENV variables by default.\r\n\r\nAdded `Amber::Server.config` witch takes a block. Removes the need for `Amber::Server.instance.config`\r\n```crystal\r\n\r\nAmber::Server.config  do |amber|\r\n  amber.name = \"ProjectName\"\r\n  amber.port = 8080\r\n  amber.host = \"localhost\"\r\nend\r\n```\r\n","created_at":"2017-08-21T14:11:57Z","updated_at":"2017-08-23T20:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c561eb1adcae1b94b216c51b6ad72e0a03765937","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/amber-crystal/amber/pulls/183/commits","review_comments_url":"https://api.github.com/repos/amber-crystal/amber/pulls/183/comments","review_comment_url":"https://api.github.com/repos/amber-crystal/amber/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amber-crystal/amber/issues/183/comments","statuses_url":"https://api.github.com/repos/amber-crystal/amber/statuses/140c2371b0044ba073dfa63fa3829a616111925a","head":{"label":"amber-crystal:ep/clean-amber-server","ref":"ep/clean-amber-server","sha":"140c2371b0044ba073dfa63fa3829a616111925a","user":{"login":"amber-crystal","id":27691024,"avatar_url":"https://avatars1.githubusercontent.com/u/27691024?v=4","gravatar_id":"","url":"https://api.github.com/users/amber-crystal","html_url":"https://github.com/amber-crystal","followers_url":"https://api.github.com/users/amber-crystal/followers","following_url":"https://api.github.com/users/amber-crystal/following{/other_user}","gists_url":"https://api.github.com/users/amber-crystal/gists{/gist_id}","starred_url":"https://api.github.com/users/amber-crystal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amber-crystal/subscriptions","organizations_url":"https://api.github.com/users/amber-crystal/orgs","repos_url":"https://api.github.com/users/amber-crystal/repos","events_url":"https://api.github.com/users/amber-crystal/events{/privacy}","received_events_url":"https://api.github.com/users/amber-crystal/received_events","type":"Organization","site_admin":false},"repo":{"id":88535378,"name":"amber","full_name":"amber-crystal/amber","owner":{"login":"amber-crystal","id":27691024,"avatar_url":"https://avatars1.githubusercontent.com/u/27691024?v=4","gravatar_id":"","url":"https://api.github.com/users/amber-crystal","html_url":"https://github.com/amber-crystal","followers_url":"https://api.github.com/users/amber-crystal/followers","following_url":"https://api.github.com/users/amber-crystal/following{/other_user}","gists_url":"https://api.github.com/users/amber-crystal/gists{/gist_id}","starred_url":"https://api.github.com/users/amber-crystal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amber-crystal/subscriptions","organizations_url":"https://api.github.com/users/amber-crystal/orgs","repos_url":"https://api.github.com/users/amber-crystal/repos","events_url":"https://api.github.com/users/amber-crystal/events{/privacy}","received_events_url":"https://api.github.com/users/amber-crystal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amber-crystal/amber","description":"Amber is an open source efficient  and cohesive web application framework developed for the Crystal language","fork":false,"url":"https://api.github.com/repos/amber-crystal/amber","forks_url":"https://api.github.com/repos/amber-crystal/amber/forks","keys_url":"https://api.github.com/repos/amber-crystal/amber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amber-crystal/amber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amber-crystal/amber/teams","hooks_url":"https://api.github.com/repos/amber-crystal/amber/hooks","issue_events_url":"https://api.github.com/repos/amber-crystal/amber/issues/events{/number}","events_url":"https://api.github.com/repos/amber-crystal/amber/events","assignees_url":"https://api.github.com/repos/amber-crystal/amber/assignees{/user}","branches_url":"https://api.github.com/repos/amber-crystal/amber/branches{/branch}","tags_url":"https://api.github.com/repos/amber-crystal/amber/tags","blobs_url":"https://api.github.com/repos/amber-crystal/amber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amber-crystal/amber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amber-crystal/amber/git/refs{/sha}","trees_url":"https://api.github.com/repos/amber-crystal/amber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amber-crystal/amber/statuses/{sha}","languages_url":"https://api.github.com/repos/amber-crystal/amber/languages","stargazers_url":"https://api.github.com/repos/amber-crystal/amber/stargazers","contributors_url":"https://api.github.com/repos/amber-crystal/amber/contributors","subscribers_url":"https://api.github.com/repos/amber-crystal/amber/subscribers","subscription_url":"https://api.github.com/repos/amber-crystal/amber/subscription","commits_url":"https://api.github.com/repos/amber-crystal/amber/commits{/sha}","git_commits_url":"https://api.github.com/repos/amber-crystal/amber/git/commits{/sha}","comments_url":"https://api.github.com/repos/amber-crystal/amber/comments{/number}","issue_comment_url":"https://api.github.com/repos/amber-crystal/amber/issues/comments{/number}","contents_url":"https://api.github.com/repos/amber-crystal/amber/contents/{+path}","compare_url":"https://api.github.com/repos/amber-crystal/amber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amber-crystal/amber/merges","archive_url":"https://api.github.com/repos/amber-crystal/amber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amber-crystal/amber/downloads","issues_url":"https://api.github.com/repos/amber-crystal/amber/issues{/number}","pulls_url":"https://api.github.com/repos/amber-crystal/amber/pulls{/number}","milestones_url":"https://api.github.com/repos/amber-crystal/amber/milestones{/number}","notifications_url":"https://api.github.com/repos/amber-crystal/amber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amber-crystal/amber/labels{/name}","releases_url":"https://api.github.com/repos/amber-crystal/amber/releases{/id}","deployments_url":"https://api.github.com/repos/amber-crystal/amber/deployments","created_at":"2017-04-17T18:02:35Z","updated_at":"2017-08-23T02:26:27Z","pushed_at":"2017-08-23T16:46:13Z","git_url":"git://github.com/amber-crystal/amber.git","ssh_url":"git@github.com:amber-crystal/amber.git","clone_url":"https://github.com/amber-crystal/amber.git","svn_url":"https://github.com/amber-crystal/amber","homepage":"http://www.ambercr.io/","size":6567,"stargazers_count":181,"watchers_count":181,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":181,"default_branch":"master"}},"base":{"label":"amber-crystal:master","ref":"master","sha":"32f35a19f2b1efa14df60cdf51a605f683c2682f","user":{"login":"amber-crystal","id":27691024,"avatar_url":"https://avatars1.githubusercontent.com/u/27691024?v=4","gravatar_id":"","url":"https://api.github.com/users/amber-crystal","html_url":"https://github.com/amber-crystal","followers_url":"https://api.github.com/users/amber-crystal/followers","following_url":"https://api.github.com/users/amber-crystal/following{/other_user}","gists_url":"https://api.github.com/users/amber-crystal/gists{/gist_id}","starred_url":"https://api.github.com/users/amber-crystal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amber-crystal/subscriptions","organizations_url":"https://api.github.com/users/amber-crystal/orgs","repos_url":"https://api.github.com/users/amber-crystal/repos","events_url":"https://api.github.com/users/amber-crystal/events{/privacy}","received_events_url":"https://api.github.com/users/amber-crystal/received_events","type":"Organization","site_admin":false},"repo":{"id":88535378,"name":"amber","full_name":"amber-crystal/amber","owner":{"login":"amber-crystal","id":27691024,"avatar_url":"https://avatars1.githubusercontent.com/u/27691024?v=4","gravatar_id":"","url":"https://api.github.com/users/amber-crystal","html_url":"https://github.com/amber-crystal","followers_url":"https://api.github.com/users/amber-crystal/followers","following_url":"https://api.github.com/users/amber-crystal/following{/other_user}","gists_url":"https://api.github.com/users/amber-crystal/gists{/gist_id}","starred_url":"https://api.github.com/users/amber-crystal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amber-crystal/subscriptions","organizations_url":"https://api.github.com/users/amber-crystal/orgs","repos_url":"https://api.github.com/users/amber-crystal/repos","events_url":"https://api.github.com/users/amber-crystal/events{/privacy}","received_events_url":"https://api.github.com/users/amber-crystal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amber-crystal/amber","description":"Amber is an open source efficient  and cohesive web application framework developed for the Crystal language","fork":false,"url":"https://api.github.com/repos/amber-crystal/amber","forks_url":"https://api.github.com/repos/amber-crystal/amber/forks","keys_url":"https://api.github.com/repos/amber-crystal/amber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amber-crystal/amber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amber-crystal/amber/teams","hooks_url":"https://api.github.com/repos/amber-crystal/amber/hooks","issue_events_url":"https://api.github.com/repos/amber-crystal/amber/issues/events{/number}","events_url":"https://api.github.com/repos/amber-crystal/amber/events","assignees_url":"https://api.github.com/repos/amber-crystal/amber/assignees{/user}","branches_url":"https://api.github.com/repos/amber-crystal/amber/branches{/branch}","tags_url":"https://api.github.com/repos/amber-crystal/amber/tags","blobs_url":"https://api.github.com/repos/amber-crystal/amber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amber-crystal/amber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amber-crystal/amber/git/refs{/sha}","trees_url":"https://api.github.com/repos/amber-crystal/amber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amber-crystal/amber/statuses/{sha}","languages_url":"https://api.github.com/repos/amber-crystal/amber/languages","stargazers_url":"https://api.github.com/repos/amber-crystal/amber/stargazers","contributors_url":"https://api.github.com/repos/amber-crystal/amber/contributors","subscribers_url":"https://api.github.com/repos/amber-crystal/amber/subscribers","subscription_url":"https://api.github.com/repos/amber-crystal/amber/subscription","commits_url":"https://api.github.com/repos/amber-crystal/amber/commits{/sha}","git_commits_url":"https://api.github.com/repos/amber-crystal/amber/git/commits{/sha}","comments_url":"https://api.github.com/repos/amber-crystal/amber/comments{/number}","issue_comment_url":"https://api.github.com/repos/amber-crystal/amber/issues/comments{/number}","contents_url":"https://api.github.com/repos/amber-crystal/amber/contents/{+path}","compare_url":"https://api.github.com/repos/amber-crystal/amber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amber-crystal/amber/merges","archive_url":"https://api.github.com/repos/amber-crystal/amber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amber-crystal/amber/downloads","issues_url":"https://api.github.com/repos/amber-crystal/amber/issues{/number}","pulls_url":"https://api.github.com/repos/amber-crystal/amber/pulls{/number}","milestones_url":"https://api.github.com/repos/amber-crystal/amber/milestones{/number}","notifications_url":"https://api.github.com/repos/amber-crystal/amber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amber-crystal/amber/labels{/name}","releases_url":"https://api.github.com/repos/amber-crystal/amber/releases{/id}","deployments_url":"https://api.github.com/repos/amber-crystal/amber/deployments","created_at":"2017-04-17T18:02:35Z","updated_at":"2017-08-23T02:26:27Z","pushed_at":"2017-08-23T16:46:13Z","git_url":"git://github.com/amber-crystal/amber.git","ssh_url":"git@github.com:amber-crystal/amber.git","clone_url":"https://github.com/amber-crystal/amber.git","svn_url":"https://github.com/amber-crystal/amber","homepage":"http://www.ambercr.io/","size":6567,"stargazers_count":181,"watchers_count":181,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amber-crystal/amber/pulls/183"},"html":{"href":"https://github.com/amber-crystal/amber/pull/183"},"issue":{"href":"https://api.github.com/repos/amber-crystal/amber/issues/183"},"comments":{"href":"https://api.github.com/repos/amber-crystal/amber/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/amber-crystal/amber/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/amber-crystal/amber/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amber-crystal/amber/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/amber-crystal/amber/statuses/140c2371b0044ba073dfa63fa3829a616111925a"}}}}
{"actor":{"display_login":"drujensen"}}