{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/113153583","pull_request_review_id":34517602,"id":113153583,"diff_hunk":"@@ -0,0 +1,211 @@\n+﻿// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System.IO;\n+using System.Text;\n+using System.Xml;\n+\n+namespace System.Runtime.Serialization.Xml.Canonicalization.Tests\n+{\n+    public class ReaderWriterFactory\n+    {\n+        public enum ReaderWriterType\n+        {\n+            Binary,\n+            Text,\n+            MTOM,\n+            WebData,\n+            WrappedWebData\n+        };\n+\n+        public static ReaderWriterType Binary = ReaderWriterType.Binary;\n+        public static ReaderWriterType Text = ReaderWriterType.Text;\n+        public static ReaderWriterType MTOM = ReaderWriterType.MTOM;\n+        public static ReaderWriterType WebData = ReaderWriterType.WebData;\n+        public static ReaderWriterType WrappedWebData = ReaderWriterType.WrappedWebData;\n+\n+        public static XmlReader CreateXmlReader(ReaderWriterType rwType, byte[] buffer, Encoding encoding, XmlDictionaryReaderQuotas quotas, IXmlDictionary dictionary, OnXmlDictionaryReaderClose onClose)\n+        {\n+            XmlReader result = null;\n+            switch (rwType)\n+            {\n+                case ReaderWriterType.Binary:\n+                    result = XmlDictionaryReader.CreateBinaryReader(buffer, 0, buffer.Length, dictionary, quotas, null, onClose);\n+                    break;\n+                case ReaderWriterType.Text:\n+                    result = XmlDictionaryReader.CreateTextReader(buffer, 0, buffer.Length, encoding, quotas, onClose);\n+                    break;\n+                case ReaderWriterType.WebData:\n+                    if (quotas != XmlDictionaryReaderQuotas.Max)","path":"src/System.Runtime.Serialization.Xml/tests/CanonicalizationTestHelper.cs","position":40,"original_position":40,"commit_id":"e7ded62157d90ac16b0764d3196f3401e50bf77c","original_commit_id":"cbb8cb202317f7ef627d9cfb59d96b86a928435e","user":{"login":"v-yanbgu","id":26989337,"avatar_url":"https://avatars1.githubusercontent.com/u/26989337?v=3","gravatar_id":"","url":"https://api.github.com/users/v-yanbgu","html_url":"https://github.com/v-yanbgu","followers_url":"https://api.github.com/users/v-yanbgu/followers","following_url":"https://api.github.com/users/v-yanbgu/following{/other_user}","gists_url":"https://api.github.com/users/v-yanbgu/gists{/gist_id}","starred_url":"https://api.github.com/users/v-yanbgu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-yanbgu/subscriptions","organizations_url":"https://api.github.com/users/v-yanbgu/orgs","repos_url":"https://api.github.com/users/v-yanbgu/repos","events_url":"https://api.github.com/users/v-yanbgu/events{/privacy}","received_events_url":"https://api.github.com/users/v-yanbgu/received_events","type":"User","site_admin":false},"body":"Maybe should use Assert.","created_at":"2017-04-25T09:56:21Z","updated_at":"2017-04-25T09:56:21Z","html_url":"https://github.com/dotnet/corefx/pull/18911#discussion_r113153583","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/18911","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/113153583"},"html":{"href":"https://github.com/dotnet/corefx/pull/18911#discussion_r113153583"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18911"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/18911","id":117434650,"html_url":"https://github.com/dotnet/corefx/pull/18911","diff_url":"https://github.com/dotnet/corefx/pull/18911.diff","patch_url":"https://github.com/dotnet/corefx/pull/18911.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/18911","number":18911,"state":"open","locked":false,"title":"Xml canonicalization test","user":{"login":"imcarolwang","id":14886586,"avatar_url":"https://avatars3.githubusercontent.com/u/14886586?v=3","gravatar_id":"","url":"https://api.github.com/users/imcarolwang","html_url":"https://github.com/imcarolwang","followers_url":"https://api.github.com/users/imcarolwang/followers","following_url":"https://api.github.com/users/imcarolwang/following{/other_user}","gists_url":"https://api.github.com/users/imcarolwang/gists{/gist_id}","starred_url":"https://api.github.com/users/imcarolwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcarolwang/subscriptions","organizations_url":"https://api.github.com/users/imcarolwang/orgs","repos_url":"https://api.github.com/users/imcarolwang/repos","events_url":"https://api.github.com/users/imcarolwang/events{/privacy}","received_events_url":"https://api.github.com/users/imcarolwang/received_events","type":"User","site_admin":false},"body":"Add NetCore test for to-be-supported canonicalization feature, active issue #18910.","created_at":"2017-04-25T09:00:03Z","updated_at":"2017-04-25T09:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28a5609c05faf37860a54a9e0f1fe896290802b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/18911/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/18911/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/18911/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/e7ded62157d90ac16b0764d3196f3401e50bf77c","head":{"label":"imcarolwang:XmlCanonicalizationTest","ref":"XmlCanonicalizationTest","sha":"e7ded62157d90ac16b0764d3196f3401e50bf77c","user":{"login":"imcarolwang","id":14886586,"avatar_url":"https://avatars3.githubusercontent.com/u/14886586?v=3","gravatar_id":"","url":"https://api.github.com/users/imcarolwang","html_url":"https://github.com/imcarolwang","followers_url":"https://api.github.com/users/imcarolwang/followers","following_url":"https://api.github.com/users/imcarolwang/following{/other_user}","gists_url":"https://api.github.com/users/imcarolwang/gists{/gist_id}","starred_url":"https://api.github.com/users/imcarolwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcarolwang/subscriptions","organizations_url":"https://api.github.com/users/imcarolwang/orgs","repos_url":"https://api.github.com/users/imcarolwang/repos","events_url":"https://api.github.com/users/imcarolwang/events{/privacy}","received_events_url":"https://api.github.com/users/imcarolwang/received_events","type":"User","site_admin":false},"repo":{"id":81184442,"name":"corefx","full_name":"imcarolwang/corefx","owner":{"login":"imcarolwang","id":14886586,"avatar_url":"https://avatars3.githubusercontent.com/u/14886586?v=3","gravatar_id":"","url":"https://api.github.com/users/imcarolwang","html_url":"https://github.com/imcarolwang","followers_url":"https://api.github.com/users/imcarolwang/followers","following_url":"https://api.github.com/users/imcarolwang/following{/other_user}","gists_url":"https://api.github.com/users/imcarolwang/gists{/gist_id}","starred_url":"https://api.github.com/users/imcarolwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imcarolwang/subscriptions","organizations_url":"https://api.github.com/users/imcarolwang/orgs","repos_url":"https://api.github.com/users/imcarolwang/repos","events_url":"https://api.github.com/users/imcarolwang/events{/privacy}","received_events_url":"https://api.github.com/users/imcarolwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imcarolwang/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/imcarolwang/corefx","forks_url":"https://api.github.com/repos/imcarolwang/corefx/forks","keys_url":"https://api.github.com/repos/imcarolwang/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imcarolwang/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imcarolwang/corefx/teams","hooks_url":"https://api.github.com/repos/imcarolwang/corefx/hooks","issue_events_url":"https://api.github.com/repos/imcarolwang/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/imcarolwang/corefx/events","assignees_url":"https://api.github.com/repos/imcarolwang/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/imcarolwang/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/imcarolwang/corefx/tags","blobs_url":"https://api.github.com/repos/imcarolwang/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imcarolwang/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imcarolwang/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/imcarolwang/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imcarolwang/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/imcarolwang/corefx/languages","stargazers_url":"https://api.github.com/repos/imcarolwang/corefx/stargazers","contributors_url":"https://api.github.com/repos/imcarolwang/corefx/contributors","subscribers_url":"https://api.github.com/repos/imcarolwang/corefx/subscribers","subscription_url":"https://api.github.com/repos/imcarolwang/corefx/subscription","commits_url":"https://api.github.com/repos/imcarolwang/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/imcarolwang/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/imcarolwang/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/imcarolwang/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/imcarolwang/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/imcarolwang/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imcarolwang/corefx/merges","archive_url":"https://api.github.com/repos/imcarolwang/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imcarolwang/corefx/downloads","issues_url":"https://api.github.com/repos/imcarolwang/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/imcarolwang/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/imcarolwang/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/imcarolwang/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imcarolwang/corefx/labels{/name}","releases_url":"https://api.github.com/repos/imcarolwang/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/imcarolwang/corefx/deployments","created_at":"2017-02-07T08:22:46Z","updated_at":"2017-02-07T08:23:25Z","pushed_at":"2017-04-25T09:56:18Z","git_url":"git://github.com/imcarolwang/corefx.git","ssh_url":"git@github.com:imcarolwang/corefx.git","clone_url":"https://github.com/imcarolwang/corefx.git","svn_url":"https://github.com/imcarolwang/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":141601,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1a2eae3f06a78ff82e417efe19398b5c63b1b063","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-04-25T09:36:13Z","pushed_at":"2017-04-25T09:56:20Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":141816,"stargazers_count":11635,"watchers_count":11635,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3072,"mirror_url":null,"open_issues_count":1474,"forks":3072,"open_issues":1474,"watchers":11635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18911"},"html":{"href":"https://github.com/dotnet/corefx/pull/18911"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18911"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18911/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18911/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18911/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/e7ded62157d90ac16b0764d3196f3401e50bf77c"}}}}
{"actor":{"display_login":"v-yanbgu"}}