{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/comments/154975825","pull_request_review_id":81217862,"id":154975825,"diff_hunk":"@@ -39,14 +39,16 @@ if [ -z \"${ENABLE_OAUTH}\" ]; then\n fi\n \n oc new-project $PROJECT_NAME\n-for SLAVE in java-ubuntu jenkins-tools nodejs-ubuntu nodejs6-ubuntu ruby ruby-fhcap ansible go-centos7 python2-centos7 prod-centos7\n+for SLAVE in java-ubuntu jenkins-tools nodejs-ubuntu nodejs6-ubuntu ruby ruby-fhcap ansible go-centos7 python2-centos7 prod-centos7 nodejs6-centos7\n do\n     SLAVE_LABELS=\"$SLAVE ${SLAVE/-/ } openshift\"\n \n     if [ \"$SLAVE\" = \"nodejs-ubuntu\" ] ; then\n-        # TODO: Remove 'nodejs4' from here when we've got el7 nodejs\n-        # slave images (and add it to one of those)\n-        SLAVE_LABELS=\"$SLAVE_LABELS nodejs4-ubuntu nodejs4\"\n+        SLAVE_LABELS=\"ubuntu nodejs4-ubuntu\"\n+    fi\n+\n+    if [ \"$SLAVE\" = \"nodejs6-ubuntu\" ] ; then\n+        SLAVE_LABELS=\"ubuntu nodejs6-ubuntu\"\n     fi","path":"scripts/deploy_jenkins.sh","position":18,"original_position":18,"commit_id":"6f43d540a9fd6be9d42ef7f0e77d1f4adea153b0","original_commit_id":"6f43d540a9fd6be9d42ef7f0e77d1f4adea153b0","user":{"login":"grdryn","id":442386,"avatar_url":"https://avatars0.githubusercontent.com/u/442386?v=4","gravatar_id":"","url":"https://api.github.com/users/grdryn","html_url":"https://github.com/grdryn","followers_url":"https://api.github.com/users/grdryn/followers","following_url":"https://api.github.com/users/grdryn/following{/other_user}","gists_url":"https://api.github.com/users/grdryn/gists{/gist_id}","starred_url":"https://api.github.com/users/grdryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grdryn/subscriptions","organizations_url":"https://api.github.com/users/grdryn/orgs","repos_url":"https://api.github.com/users/grdryn/repos","events_url":"https://api.github.com/users/grdryn/events{/privacy}","received_events_url":"https://api.github.com/users/grdryn/received_events","type":"User","site_admin":false},"body":"Yeah, and avoid them having the 'openshift' label (less of a big deal).","created_at":"2017-12-05T15:15:29Z","updated_at":"2017-12-05T15:15:29Z","html_url":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration/pull/69#discussion_r154975825","pull_request_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/comments/154975825"},"html":{"href":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration/pull/69#discussion_r154975825"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69"}},"in_reply_to_id":154973042},"pull_request":{"url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69","id":156485712,"html_url":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration/pull/69","diff_url":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration/pull/69.diff","patch_url":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration/pull/69.patch","issue_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/issues/69","number":69,"state":"open","locked":false,"title":"🐳 Add new nodejs6-centos7 slave image","user":{"login":"grdryn","id":442386,"avatar_url":"https://avatars0.githubusercontent.com/u/442386?v=4","gravatar_id":"","url":"https://api.github.com/users/grdryn","html_url":"https://github.com/grdryn","followers_url":"https://api.github.com/users/grdryn/followers","following_url":"https://api.github.com/users/grdryn/following{/other_user}","gists_url":"https://api.github.com/users/grdryn/gists{/gist_id}","starred_url":"https://api.github.com/users/grdryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grdryn/subscriptions","organizations_url":"https://api.github.com/users/grdryn/orgs","repos_url":"https://api.github.com/users/grdryn/repos","events_url":"https://api.github.com/users/grdryn/events{/privacy}","received_events_url":"https://api.github.com/users/grdryn/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-12-05T15:01:20Z","updated_at":"2017-12-05T15:15:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f0e15ebd2aacd85ff0669b641807d5bdfd8bc4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69/commits","review_comments_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69/comments","review_comment_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/issues/69/comments","statuses_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/statuses/6f43d540a9fd6be9d42ef7f0e77d1f4adea153b0","head":{"label":"grdryn:FH-4217","ref":"FH-4217","sha":"6f43d540a9fd6be9d42ef7f0e77d1f4adea153b0","user":{"login":"grdryn","id":442386,"avatar_url":"https://avatars0.githubusercontent.com/u/442386?v=4","gravatar_id":"","url":"https://api.github.com/users/grdryn","html_url":"https://github.com/grdryn","followers_url":"https://api.github.com/users/grdryn/followers","following_url":"https://api.github.com/users/grdryn/following{/other_user}","gists_url":"https://api.github.com/users/grdryn/gists{/gist_id}","starred_url":"https://api.github.com/users/grdryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grdryn/subscriptions","organizations_url":"https://api.github.com/users/grdryn/orgs","repos_url":"https://api.github.com/users/grdryn/repos","events_url":"https://api.github.com/users/grdryn/events{/privacy}","received_events_url":"https://api.github.com/users/grdryn/received_events","type":"User","site_admin":false},"repo":{"id":96207521,"name":"wendy-jenkins-s2i-configuration","full_name":"grdryn/wendy-jenkins-s2i-configuration","owner":{"login":"grdryn","id":442386,"avatar_url":"https://avatars0.githubusercontent.com/u/442386?v=4","gravatar_id":"","url":"https://api.github.com/users/grdryn","html_url":"https://github.com/grdryn","followers_url":"https://api.github.com/users/grdryn/followers","following_url":"https://api.github.com/users/grdryn/following{/other_user}","gists_url":"https://api.github.com/users/grdryn/gists{/gist_id}","starred_url":"https://api.github.com/users/grdryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grdryn/subscriptions","organizations_url":"https://api.github.com/users/grdryn/orgs","repos_url":"https://api.github.com/users/grdryn/repos","events_url":"https://api.github.com/users/grdryn/events{/privacy}","received_events_url":"https://api.github.com/users/grdryn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grdryn/wendy-jenkins-s2i-configuration","description":"The s2i configuration based on top of openshift/jenkins","fork":true,"url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration","forks_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/forks","keys_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/teams","hooks_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/hooks","issue_events_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/issues/events{/number}","events_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/events","assignees_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/assignees{/user}","branches_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/branches{/branch}","tags_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/tags","blobs_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/languages","stargazers_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/stargazers","contributors_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/contributors","subscribers_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/subscribers","subscription_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/subscription","commits_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/contents/{+path}","compare_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/merges","archive_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/downloads","issues_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/issues{/number}","pulls_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/labels{/name}","releases_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/releases{/id}","deployments_url":"https://api.github.com/repos/grdryn/wendy-jenkins-s2i-configuration/deployments","created_at":"2017-07-04T10:45:18Z","updated_at":"2017-07-04T10:45:19Z","pushed_at":"2017-12-05T15:01:13Z","git_url":"git://github.com/grdryn/wendy-jenkins-s2i-configuration.git","ssh_url":"git@github.com:grdryn/wendy-jenkins-s2i-configuration.git","clone_url":"https://github.com/grdryn/wendy-jenkins-s2i-configuration.git","svn_url":"https://github.com/grdryn/wendy-jenkins-s2i-configuration","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"21fd0d48e1ce0d3894d441b9ea439ff1f9657e75","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars0.githubusercontent.com/u/772226?v=4","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":76462028,"name":"wendy-jenkins-s2i-configuration","full_name":"feedhenry/wendy-jenkins-s2i-configuration","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars0.githubusercontent.com/u/772226?v=4","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration","description":"The s2i configuration based on top of openshift/jenkins","fork":false,"url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration","forks_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/forks","keys_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/teams","hooks_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/events","assignees_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/tags","blobs_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/languages","stargazers_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/subscription","commits_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/merges","archive_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/downloads","issues_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/deployments","created_at":"2016-12-14T13:29:04Z","updated_at":"2017-11-02T13:26:54Z","pushed_at":"2017-12-05T15:01:21Z","git_url":"git://github.com/feedhenry/wendy-jenkins-s2i-configuration.git","ssh_url":"git@github.com:feedhenry/wendy-jenkins-s2i-configuration.git","clone_url":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration.git","svn_url":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration","homepage":null,"size":136,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":9,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69"},"html":{"href":"https://github.com/feedhenry/wendy-jenkins-s2i-configuration/pull/69"},"issue":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/issues/69"},"comments":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/wendy-jenkins-s2i-configuration/statuses/6f43d540a9fd6be9d42ef7f0e77d1f4adea153b0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"grdryn"}}