{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/server/issues/3001","repository_url":"https://api.github.com/repos/nextcloud/server","labels_url":"https://api.github.com/repos/nextcloud/server/issues/3001/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/3001/comments","events_url":"https://api.github.com/repos/nextcloud/server/issues/3001/events","html_url":"https://github.com/nextcloud/server/issues/3001","id":199681294,"number":3001,"title":"Bug after Update from NC10 to NC11: Sharing with users breaks ","user":{"login":"FelixOliverLange","id":15322607,"avatar_url":"https://avatars0.githubusercontent.com/u/15322607?v=3","gravatar_id":"","url":"https://api.github.com/users/FelixOliverLange","html_url":"https://github.com/FelixOliverLange","followers_url":"https://api.github.com/users/FelixOliverLange/followers","following_url":"https://api.github.com/users/FelixOliverLange/following{/other_user}","gists_url":"https://api.github.com/users/FelixOliverLange/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixOliverLange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixOliverLange/subscriptions","organizations_url":"https://api.github.com/users/FelixOliverLange/orgs","repos_url":"https://api.github.com/users/FelixOliverLange/repos","events_url":"https://api.github.com/users/FelixOliverLange/events{/privacy}","received_events_url":"https://api.github.com/users/FelixOliverLange/received_events","type":"User","site_admin":false},"labels":[{"id":386379231,"url":"https://api.github.com/repos/nextcloud/server/labels/bug","name":"bug","color":"ee0701","default":true},{"id":389031994,"url":"https://api.github.com/repos/nextcloud/server/labels/feature:%20sharing","name":"feature: sharing","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2017-01-09T22:33:18Z","updated_at":"2017-04-05T10:23:06Z","closed_at":null,"body":"Hello Community & Developers,\r\n\r\nI found a potential Bug in NC11. It appears after an update from NC10, but is not directly linked to the update process itself. \r\n\r\nThe Problem is that if Avatars are disabled in the Config \r\n(see https://docs.nextcloud.com/server/9/admin_manual/configuration_server/config_sample_php_parameters.html) , the sharing function, that relies on the function Avatar.avatar or avatars.avatar( not sure), breaks. This leads to two effects:\r\n\r\n1. If any files in the root directory of user A where shared to user B, login in the UI will fail (redirect loop of infinity) but the client will sync.\r\n\r\n2. If no files where shared up to now, the feature will simply not work. When trying to share files to another local user, no drop down of the available users appears, and even a manual entry is not accepted. \r\n\r\nthe Webconsole of both Firefox and Chrome gives the following error messages:\r\n1. Scenario: to many redirects (304)\r\n2. Scenario: JS-error: avatar.avatar is not a function (or avatars.avatar, not sure)\r\n\r\nThe error was first encountered on a NC11 instance with over 110.000 files of one user. As this user had shared files in his root folder, scenario 1 appeared.\r\nLater it was confirmed on a second instance (running on the same web server), but as no files had been shared, scenario 2 appeared.\r\n\r\nAfter debugging the issue of the Major instance on a separate  server, the issue was found. As the first instance had been deleted by then for rebuild reasons, we could only verify it in the second instance. (it worked there).\r\n\r\nFurther things i noticed:\r\nNC11 copied all the shared Files to all the users that the files had been shared to. As the number of maximum files in the filesystem was reached during this process, eventually NC11 terminated the copy process. It is unknown if the first instance would have been able to resolve the infinite 304 loop if it had been allowed to copy all files. But I do not know if NC11 copies files from user to user on share by default for I/O reasons, so not sure if this is bug related or not - if NC11 does copy on share, then forget this part - as then NC11 did not even copy files during the 304 loop.\r\n\r\nFIX:\r\nFor Instances with scenario 2: enable Avatars again and everything is fine, no Data lost!\r\nFor Instances with Scenario 1: unknown, potential damage to Filesystem or DB integrity or Data lost, as we where not able to test that.\r\n\r\n### Steps to reproduce\r\n1. disable Avatars on NC10\r\n2. share files from local user 1 to local user 2\r\n3. upgrade to NC11\r\n\r\nHope that helps. Thanks for working on this awesome project and you dudes rock! keep it up!\r\n\r\nAdditional stuff:\r\n### Expected behaviour\r\nUsually, there should be either no problem in disabling avatars (possibly updater should simply check this before updating, as it was no problem in NC10) or a warning should be displayed.\r\n\r\n### Actual behaviour\r\nSee the description above \r\n\r\n### Server configuration\r\n**Operating system**: unknown, whatever 1and1 uses - probably a Ubuntu Server\r\n\r\n**Web server:**Apache 2, Version number unknown\r\n\r\n**Database:** MySQL 5.something, unknown as 1and1 does this for us\r\n\r\n**PHP version:** php7.something, don't know that either\r\n\r\n**Nextcloud version:** \r\nNC10 to NC11 transition\r\n\r\n**Updated from an older Nextcloud/ownCloud or fresh install:** \r\nUpdated\r\n\r\n**Where did you install Nextcloud from:** \r\nArchived file from project page, via ssh\r\n\r\n**Signing status:**\r\nSorry, not available as the instance had to be deleted.\r\n\r\n**List of activated apps:**\r\nStandard + Calendar + Activities, that's it (no detailed list, as instance deleted).\r\n\r\n\r\n**The content of config/config.php:**\r\nStandard config.php + disabled Avatars\r\n\r\n**Are you using external storage, if yes which one:** \r\nno external Storage or Users!\r\n\r\n**Are you using encryption:** \r\nyes, standard encryption module\r\n\r\n**Are you using an external user-backend, if yes which one:** \r\nno.\r\n\r\n### Client configuration\r\n**Browser:**\r\nCurrent FF and Chrome\r\n\r\n**Operating system:**\r\nOpensuse 42.2, Windows 10, Windows 7\r\n\r\n#### Nextcloud log (data/nextcloud.log)\r\nNot available, as instance deleted. No Webserver log either, as i do not have access.\r\n\r\n#### Browser log\r\nNope, that is gone as well, sorry Guys!"},"comment":{"url":"https://api.github.com/repos/nextcloud/server/issues/comments/291819266","html_url":"https://github.com/nextcloud/server/issues/3001#issuecomment-291819266","issue_url":"https://api.github.com/repos/nextcloud/server/issues/3001","id":291819266,"user":{"login":"faichelbaum","id":3140835,"avatar_url":"https://avatars2.githubusercontent.com/u/3140835?v=3","gravatar_id":"","url":"https://api.github.com/users/faichelbaum","html_url":"https://github.com/faichelbaum","followers_url":"https://api.github.com/users/faichelbaum/followers","following_url":"https://api.github.com/users/faichelbaum/following{/other_user}","gists_url":"https://api.github.com/users/faichelbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/faichelbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faichelbaum/subscriptions","organizations_url":"https://api.github.com/users/faichelbaum/orgs","repos_url":"https://api.github.com/users/faichelbaum/repos","events_url":"https://api.github.com/users/faichelbaum/events{/privacy}","received_events_url":"https://api.github.com/users/faichelbaum/received_events","type":"User","site_admin":false},"created_at":"2017-04-05T10:23:06Z","updated_at":"2017-04-05T10:23:06Z","body":"the CSRF error on the sharing script does not seem to be related to the avatar feature"}}
{"actor":{"display_login":"faichelbaum"}}