{"action":"created","issue":{"url":"https://api.github.com/repos/aimacode/aima-python/issues/460","repository_url":"https://api.github.com/repos/aimacode/aima-python","labels_url":"https://api.github.com/repos/aimacode/aima-python/issues/460/labels{/name}","comments_url":"https://api.github.com/repos/aimacode/aima-python/issues/460/comments","events_url":"https://api.github.com/repos/aimacode/aima-python/issues/460/events","html_url":"https://github.com/aimacode/aima-python/pull/460","id":218618711,"number":460,"title":"Distance Functions (Euclidean+ Notebook)","user":{"login":"MrDupin","id":17463361,"avatar_url":"https://avatars0.githubusercontent.com/u/17463361?v=3","gravatar_id":"","url":"https://api.github.com/users/MrDupin","html_url":"https://github.com/MrDupin","followers_url":"https://api.github.com/users/MrDupin/followers","following_url":"https://api.github.com/users/MrDupin/following{/other_user}","gists_url":"https://api.github.com/users/MrDupin/gists{/gist_id}","starred_url":"https://api.github.com/users/MrDupin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrDupin/subscriptions","organizations_url":"https://api.github.com/users/MrDupin/orgs","repos_url":"https://api.github.com/users/MrDupin/repos","events_url":"https://api.github.com/users/MrDupin/events{/privacy}","received_events_url":"https://api.github.com/users/MrDupin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-31T21:12:32Z","updated_at":"2017-04-01T08:31:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aimacode/aima-python/pulls/460","html_url":"https://github.com/aimacode/aima-python/pull/460","diff_url":"https://github.com/aimacode/aima-python/pull/460.diff","patch_url":"https://github.com/aimacode/aima-python/pull/460.patch"},"body":"I added the distance functions to the Notebook + I implemented the Euclidean Distance.\r\n\r\nAlso, I renamed the arguments in the functions. Previously they were \"prediction\" and \"targets\", but I believe the more general \"X\" and \"Y\" are better. Especially considering that in some cases the two items compared are technically not a prediction and a target. Like in the *k-Nearest Neighbors* algorithm, where we are simply calculating the distance between two items.\r\n\r\nNote: Since #458 implements tests for the remaining distances, I will wait till that PR is merged before creating a test for the Euclidean Distance."},"comment":{"url":"https://api.github.com/repos/aimacode/aima-python/issues/comments/290905630","html_url":"https://github.com/aimacode/aima-python/pull/460#issuecomment-290905630","issue_url":"https://api.github.com/repos/aimacode/aima-python/issues/460","id":290905630,"user":{"login":"MrDupin","id":17463361,"avatar_url":"https://avatars0.githubusercontent.com/u/17463361?v=3","gravatar_id":"","url":"https://api.github.com/users/MrDupin","html_url":"https://github.com/MrDupin","followers_url":"https://api.github.com/users/MrDupin/followers","following_url":"https://api.github.com/users/MrDupin/following{/other_user}","gists_url":"https://api.github.com/users/MrDupin/gists{/gist_id}","starred_url":"https://api.github.com/users/MrDupin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrDupin/subscriptions","organizations_url":"https://api.github.com/users/MrDupin/orgs","repos_url":"https://api.github.com/users/MrDupin/repos","events_url":"https://api.github.com/users/MrDupin/events{/privacy}","received_events_url":"https://api.github.com/users/MrDupin/received_events","type":"User","site_admin":false},"created_at":"2017-04-01T08:31:08Z","updated_at":"2017-04-01T08:31:08Z","body":"I believe the conflict won't be in the test itself, but in the imports of the file. I will write the tests either way, and I will resolve any conflict afterwards since it's not going to be too much work.\r\n\r\nThanks."}}
{"actor":{"display_login":"MrDupin"}}