{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments/113062298","pull_request_review_id":34413460,"id":113062298,"diff_hunk":"@@ -70,7 +68,12 @@ use_DynamoRIO_extension(drltracelib drwrap_static)\n use_DynamoRIO_extension(drltracelib drx_static)\n use_DynamoRIO_extension(drltracelib drsyscall_static)\n use_DynamoRIO_extension(drltracelib drcovlib_static)\n+use_DynamoRIO_extension(drltracelib droption)\n \n+if (UNIX)\n+  # to avoid conflicts with new declaration with \"C\" linkage in utils.h","path":"drltrace/CMakeLists.txt","position":27,"original_position":27,"commit_id":"0c99b3c2140f1736df4f87fb612cffa8ac157eca","original_commit_id":"89ddf8b09bb041a78eb9ca97d0fbd8181c8e9478","user":{"login":"derekbruening","id":6509618,"avatar_url":"https://avatars2.githubusercontent.com/u/6509618?v=3","gravatar_id":"","url":"https://api.github.com/users/derekbruening","html_url":"https://github.com/derekbruening","followers_url":"https://api.github.com/users/derekbruening/followers","following_url":"https://api.github.com/users/derekbruening/following{/other_user}","gists_url":"https://api.github.com/users/derekbruening/gists{/gist_id}","starred_url":"https://api.github.com/users/derekbruening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekbruening/subscriptions","organizations_url":"https://api.github.com/users/derekbruening/orgs","repos_url":"https://api.github.com/users/derekbruening/repos","events_url":"https://api.github.com/users/derekbruening/events{/privacy}","received_events_url":"https://api.github.com/users/derekbruening/received_events","type":"User","site_admin":false},"body":"So droption.h includes both `<string>` and `<string.h>`?  We should remove the `<string.h>` (and replace the strcmp or whatever is in there with a std::string comparison).","created_at":"2017-04-24T21:34:11Z","updated_at":"2017-04-24T21:43:24Z","html_url":"https://github.com/DynamoRIO/drmemory/pull/1982#discussion_r113062298","pull_request_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982","_links":{"self":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments/113062298"},"html":{"href":"https://github.com/DynamoRIO/drmemory/pull/1982#discussion_r113062298"},"pull_request":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982","id":116069824,"html_url":"https://github.com/DynamoRIO/drmemory/pull/1982","diff_url":"https://github.com/DynamoRIO/drmemory/pull/1982.diff","patch_url":"https://github.com/DynamoRIO/drmemory/pull/1982.patch","issue_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/1982","number":1982,"state":"open","locked":false,"title":"droption usage in the drltrace client","user":{"login":"mxmssh","id":6836706,"avatar_url":"https://avatars3.githubusercontent.com/u/6836706?v=3","gravatar_id":"","url":"https://api.github.com/users/mxmssh","html_url":"https://github.com/mxmssh","followers_url":"https://api.github.com/users/mxmssh/followers","following_url":"https://api.github.com/users/mxmssh/following{/other_user}","gists_url":"https://api.github.com/users/mxmssh/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmssh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmssh/subscriptions","organizations_url":"https://api.github.com/users/mxmssh/orgs","repos_url":"https://api.github.com/users/mxmssh/repos","events_url":"https://api.github.com/users/mxmssh/events{/privacy}","received_events_url":"https://api.github.com/users/mxmssh/received_events","type":"User","site_admin":false},"body":"Added droption usage instead of manual parsing in the drltrace client.\r\nAdded only_to_lib argument support in the drltrace_frontend.\r\nMade only_to_lib case insensitive.\r\nDrltrace is changed to be C++.","created_at":"2017-04-16T20:12:40Z","updated_at":"2017-04-24T21:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df26d3088a242651eec82bd564dc114bed42507f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982/commits","review_comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982/comments","review_comment_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/1982/comments","statuses_url":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/0c99b3c2140f1736df4f87fb612cffa8ac157eca","head":{"label":"DynamoRIO:iX-drpoption-for-drltracelib","ref":"iX-drpoption-for-drltracelib","sha":"0c99b3c2140f1736df4f87fb612cffa8ac157eca","user":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"repo":{"id":27244181,"name":"drmemory","full_name":"DynamoRIO/drmemory","owner":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoRIO/drmemory","description":"Memory Debugger for Windows, Linux, Mac, and Android","fork":false,"url":"https://api.github.com/repos/DynamoRIO/drmemory","forks_url":"https://api.github.com/repos/DynamoRIO/drmemory/forks","keys_url":"https://api.github.com/repos/DynamoRIO/drmemory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoRIO/drmemory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoRIO/drmemory/teams","hooks_url":"https://api.github.com/repos/DynamoRIO/drmemory/hooks","issue_events_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoRIO/drmemory/events","assignees_url":"https://api.github.com/repos/DynamoRIO/drmemory/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoRIO/drmemory/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/tags","blobs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoRIO/drmemory/languages","stargazers_url":"https://api.github.com/repos/DynamoRIO/drmemory/stargazers","contributors_url":"https://api.github.com/repos/DynamoRIO/drmemory/contributors","subscribers_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscribers","subscription_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscription","commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoRIO/drmemory/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoRIO/drmemory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoRIO/drmemory/merges","archive_url":"https://api.github.com/repos/DynamoRIO/drmemory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoRIO/drmemory/downloads","issues_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoRIO/drmemory/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoRIO/drmemory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoRIO/drmemory/labels{/name}","releases_url":"https://api.github.com/repos/DynamoRIO/drmemory/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoRIO/drmemory/deployments","created_at":"2014-11-27T23:02:28Z","updated_at":"2017-04-20T02:52:33Z","pushed_at":"2017-04-21T14:34:06Z","git_url":"git://github.com/DynamoRIO/drmemory.git","ssh_url":"git@github.com:DynamoRIO/drmemory.git","clone_url":"https://github.com/DynamoRIO/drmemory.git","svn_url":"https://github.com/DynamoRIO/drmemory","homepage":"","size":5901,"stargazers_count":715,"watchers_count":715,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":849,"forks":91,"open_issues":849,"watchers":715,"default_branch":"master"}},"base":{"label":"DynamoRIO:master","ref":"master","sha":"ab110da5ce5d74533d5da1577493229e0fcc873d","user":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"repo":{"id":27244181,"name":"drmemory","full_name":"DynamoRIO/drmemory","owner":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoRIO/drmemory","description":"Memory Debugger for Windows, Linux, Mac, and Android","fork":false,"url":"https://api.github.com/repos/DynamoRIO/drmemory","forks_url":"https://api.github.com/repos/DynamoRIO/drmemory/forks","keys_url":"https://api.github.com/repos/DynamoRIO/drmemory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoRIO/drmemory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoRIO/drmemory/teams","hooks_url":"https://api.github.com/repos/DynamoRIO/drmemory/hooks","issue_events_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoRIO/drmemory/events","assignees_url":"https://api.github.com/repos/DynamoRIO/drmemory/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoRIO/drmemory/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/tags","blobs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoRIO/drmemory/languages","stargazers_url":"https://api.github.com/repos/DynamoRIO/drmemory/stargazers","contributors_url":"https://api.github.com/repos/DynamoRIO/drmemory/contributors","subscribers_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscribers","subscription_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscription","commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoRIO/drmemory/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoRIO/drmemory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoRIO/drmemory/merges","archive_url":"https://api.github.com/repos/DynamoRIO/drmemory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoRIO/drmemory/downloads","issues_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoRIO/drmemory/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoRIO/drmemory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoRIO/drmemory/labels{/name}","releases_url":"https://api.github.com/repos/DynamoRIO/drmemory/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoRIO/drmemory/deployments","created_at":"2014-11-27T23:02:28Z","updated_at":"2017-04-20T02:52:33Z","pushed_at":"2017-04-21T14:34:06Z","git_url":"git://github.com/DynamoRIO/drmemory.git","ssh_url":"git@github.com:DynamoRIO/drmemory.git","clone_url":"https://github.com/DynamoRIO/drmemory.git","svn_url":"https://github.com/DynamoRIO/drmemory","homepage":"","size":5901,"stargazers_count":715,"watchers_count":715,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":849,"forks":91,"open_issues":849,"watchers":715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982"},"html":{"href":"https://github.com/DynamoRIO/drmemory/pull/1982"},"issue":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/issues/1982"},"comments":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/issues/1982/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/1982/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/0c99b3c2140f1736df4f87fb612cffa8ac157eca"}}}}
{"actor":{"display_login":"derekbruening"}}