{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/15838","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/15838/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/15838/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/15838/events","html_url":"https://github.com/openshift/origin/pull/15838","id":251023360,"number":15838,"title":"Only build pkg/sdn/plugin on linux","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars0.githubusercontent.com/u/96040?v=4","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"labels":[{"id":640548662,"url":"https://api.github.com/repos/openshift/origin/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars1.githubusercontent.com/u/5834976?v=4","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"csrwng","id":5834976,"avatar_url":"https://avatars1.githubusercontent.com/u/5834976?v=4","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-08-17T17:56:26Z","updated_at":"2017-08-23T13:36:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/15838","html_url":"https://github.com/openshift/origin/pull/15838","diff_url":"https://github.com/openshift/origin/pull/15838.diff","patch_url":"https://github.com/openshift/origin/pull/15838.patch"},"body":"We are currently building (most of) the SDN code on Darwin and Windows, even though it is totally linux-specific.\r\n\r\nI ran into this when trying to make more use of the \"netlink\" library in the sdn code (#15834). The library only builds on linux, so any file that imports it has to also be only built on linux.\r\n\r\nSo this tries to fix the main openshift binary to only include the SDN code when building on Linux. I don't know if it's correct stylistically. I'm happy to rewrite it however.\r\n\r\n@openshift/networking FYI"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/324333617","html_url":"https://github.com/openshift/origin/pull/15838#issuecomment-324333617","issue_url":"https://api.github.com/repos/openshift/origin/issues/15838","id":324333617,"user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars0.githubusercontent.com/u/96040?v=4","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T13:36:27Z","updated_at":"2017-08-23T13:36:27Z","body":"All tests pass now\r\n@smarterclayton ok now? I moved the OpenShift-internal SDN interfaces to the top level of pkg/sdn to get rid of the extra imports in pkg/sdn/apis/network"}}
{"actor":{"display_login":"danwinship"}}