{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/134123544","pull_request_review_id":57379826,"id":134123544,"diff_hunk":"@@ -175,22 +214,71 @@ def _verify_column_info(column_info, global_info):\n             column_info['scale'] = global_info['scale']\n             column_info['format'] = global_info.get('format', None)\n \n-        # Non-linear coordinate types have \"4-3\" form and are not time coordinates\n-        if TCTYP_RE_TYPE.match(scale[:5]) and TCTYP_RE_ALGO.match(scale[5:]):\n+        else:\n+            # Coordinate type is either an unrecognized local time scale\n+            # or a linear coordinate type\n             return False\n \n-        # Coordinate type is either an unrecognized local time scale\n-        # or a linear coordinate type\n-        return False\n+    elif (unit is not None and unit in FITS_TIME_UNIT) or location is not None:","path":"astropy/io/fits/fitstime.py","position":145,"original_position":139,"commit_id":"82681d85d334ea6a5118865561944e263055b30e","original_commit_id":"df262ba7b3f41b72f3e3be7074b12cb38ec069ab","user":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"body":"OK, after some looking through the documentation, I understand now that `TCUNI` is specifically for coordinate units, so if that is a time unit, it is fine to assume the column is a time.","created_at":"2017-08-20T18:55:34Z","updated_at":"2017-08-20T18:55:34Z","html_url":"https://github.com/astropy/astropy/pull/6442#discussion_r134123544","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/6442","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/134123544"},"html":{"href":"https://github.com/astropy/astropy/pull/6442#discussion_r134123544"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6442"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/6442","id":135685077,"html_url":"https://github.com/astropy/astropy/pull/6442","diff_url":"https://github.com/astropy/astropy/pull/6442.diff","patch_url":"https://github.com/astropy/astropy/pull/6442.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/6442","number":6442,"state":"open","locked":false,"title":"Allow FITS tables with time columns (not written by Astropy) to be read by io.fits","user":{"login":"AustereCuriosity","id":15609154,"avatar_url":"https://avatars2.githubusercontent.com/u/15609154?v=4","gravatar_id":"","url":"https://api.github.com/users/AustereCuriosity","html_url":"https://github.com/AustereCuriosity","followers_url":"https://api.github.com/users/AustereCuriosity/followers","following_url":"https://api.github.com/users/AustereCuriosity/following{/other_user}","gists_url":"https://api.github.com/users/AustereCuriosity/gists{/gist_id}","starred_url":"https://api.github.com/users/AustereCuriosity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AustereCuriosity/subscriptions","organizations_url":"https://api.github.com/users/AustereCuriosity/orgs","repos_url":"https://api.github.com/users/AustereCuriosity/repos","events_url":"https://api.github.com/users/AustereCuriosity/events{/privacy}","received_events_url":"https://api.github.com/users/AustereCuriosity/received_events","type":"User","site_admin":false},"body":"This works for Chandra files and XMM files. I have added a test for reading Chandra files. The test needs to be more detailed and will be modified soon.\r\n\r\nNOTE: The chandra file is huge, so I'll probably use another file or reduce it.","created_at":"2017-08-14T20:54:34Z","updated_at":"2017-08-20T18:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2058647845e363f9ea92c8c0b70ac0f0337d2f6c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/45","html_url":"https://github.com/astropy/astropy/milestone/45","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/45/labels","id":2300822,"number":45,"title":"v3.0.0","description":null,"creator":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars2.githubusercontent.com/u/314716?v=4","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":12,"state":"open","created_at":"2017-02-05T19:05:19Z","updated_at":"2017-08-18T17:27:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/6442/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/6442/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/6442/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/82681d85d334ea6a5118865561944e263055b30e","head":{"label":"AustereCuriosity:Time_read_fits","ref":"Time_read_fits","sha":"82681d85d334ea6a5118865561944e263055b30e","user":{"login":"AustereCuriosity","id":15609154,"avatar_url":"https://avatars2.githubusercontent.com/u/15609154?v=4","gravatar_id":"","url":"https://api.github.com/users/AustereCuriosity","html_url":"https://github.com/AustereCuriosity","followers_url":"https://api.github.com/users/AustereCuriosity/followers","following_url":"https://api.github.com/users/AustereCuriosity/following{/other_user}","gists_url":"https://api.github.com/users/AustereCuriosity/gists{/gist_id}","starred_url":"https://api.github.com/users/AustereCuriosity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AustereCuriosity/subscriptions","organizations_url":"https://api.github.com/users/AustereCuriosity/orgs","repos_url":"https://api.github.com/users/AustereCuriosity/repos","events_url":"https://api.github.com/users/AustereCuriosity/events{/privacy}","received_events_url":"https://api.github.com/users/AustereCuriosity/received_events","type":"User","site_admin":false},"repo":{"id":64051371,"name":"astropy","full_name":"AustereCuriosity/astropy","owner":{"login":"AustereCuriosity","id":15609154,"avatar_url":"https://avatars2.githubusercontent.com/u/15609154?v=4","gravatar_id":"","url":"https://api.github.com/users/AustereCuriosity","html_url":"https://github.com/AustereCuriosity","followers_url":"https://api.github.com/users/AustereCuriosity/followers","following_url":"https://api.github.com/users/AustereCuriosity/following{/other_user}","gists_url":"https://api.github.com/users/AustereCuriosity/gists{/gist_id}","starred_url":"https://api.github.com/users/AustereCuriosity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AustereCuriosity/subscriptions","organizations_url":"https://api.github.com/users/AustereCuriosity/orgs","repos_url":"https://api.github.com/users/AustereCuriosity/repos","events_url":"https://api.github.com/users/AustereCuriosity/events{/privacy}","received_events_url":"https://api.github.com/users/AustereCuriosity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AustereCuriosity/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/AustereCuriosity/astropy","forks_url":"https://api.github.com/repos/AustereCuriosity/astropy/forks","keys_url":"https://api.github.com/repos/AustereCuriosity/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AustereCuriosity/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AustereCuriosity/astropy/teams","hooks_url":"https://api.github.com/repos/AustereCuriosity/astropy/hooks","issue_events_url":"https://api.github.com/repos/AustereCuriosity/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/AustereCuriosity/astropy/events","assignees_url":"https://api.github.com/repos/AustereCuriosity/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/AustereCuriosity/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/AustereCuriosity/astropy/tags","blobs_url":"https://api.github.com/repos/AustereCuriosity/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AustereCuriosity/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AustereCuriosity/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/AustereCuriosity/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AustereCuriosity/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/AustereCuriosity/astropy/languages","stargazers_url":"https://api.github.com/repos/AustereCuriosity/astropy/stargazers","contributors_url":"https://api.github.com/repos/AustereCuriosity/astropy/contributors","subscribers_url":"https://api.github.com/repos/AustereCuriosity/astropy/subscribers","subscription_url":"https://api.github.com/repos/AustereCuriosity/astropy/subscription","commits_url":"https://api.github.com/repos/AustereCuriosity/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/AustereCuriosity/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/AustereCuriosity/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/AustereCuriosity/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/AustereCuriosity/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/AustereCuriosity/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AustereCuriosity/astropy/merges","archive_url":"https://api.github.com/repos/AustereCuriosity/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AustereCuriosity/astropy/downloads","issues_url":"https://api.github.com/repos/AustereCuriosity/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/AustereCuriosity/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/AustereCuriosity/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/AustereCuriosity/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AustereCuriosity/astropy/labels{/name}","releases_url":"https://api.github.com/repos/AustereCuriosity/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/AustereCuriosity/astropy/deployments","created_at":"2016-07-24T06:06:24Z","updated_at":"2016-07-24T06:06:30Z","pushed_at":"2017-08-20T16:44:12Z","git_url":"git://github.com/AustereCuriosity/astropy.git","ssh_url":"git@github.com:AustereCuriosity/astropy.git","clone_url":"https://github.com/AustereCuriosity/astropy.git","svn_url":"https://github.com/AustereCuriosity/astropy","homepage":"www.astropy.org","size":58520,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"70ff18eb95ba732ea7b93dd328816fb207405a87","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2017-08-18T20:04:18Z","pushed_at":"2017-08-20T16:44:14Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":58367,"stargazers_count":1346,"watchers_count":1346,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":741,"mirror_url":null,"open_issues_count":776,"forks":741,"open_issues":776,"watchers":1346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6442"},"html":{"href":"https://github.com/astropy/astropy/pull/6442"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/6442"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/6442/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6442/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6442/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/82681d85d334ea6a5118865561944e263055b30e"}}}}
{"actor":{"display_login":"mhvk"}}