{"action":"created","comment":{"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments/138205539","pull_request_review_id":61971203,"id":138205539,"diff_hunk":"@@ -428,22 +511,26 @@ Example Configuration Files\n - `sample-passthrough-route.yaml <./_static/config_examples/sample-passthrough-route.yaml>`_\n - `sample-reencrypt-route.yaml <./_static/config_examples/sample-reencrypt-route.yaml>`_\n \n-\n-.. [#objectpartition]  The |kctlr-long| creates and manages objects in the BIG-IP partition defined in the `F5 resource </containers/v1/kubernetes/index.html#f5-resource-properties>`_ ConfigMap.\n-.. [#nodeport]  The |kctlr-long| forwards traffic to the NodePort assigned to the service by Kubernetes; see the Kubernetes `Services <http://kubernetes.io/docs/user-guide/services/>`_ documentation for more information.\n-.. [#secrets]  You can store sensitive information as a `Kubernetes Secret <http://kubernetes.io/docs/user-guide/secrets/>`_. See the `user documentation <#>`_ for instructions.\n-\n-\n+.. rubric:: Footnotes\n+.. [#objectpartition] The |kctlr| creates and manages objects in the BIG-IP partition defined in the `F5 resource </containers/latest/kubernetes/index.html#f5-resource-properties>`_ ConfigMap. **It cannot manage objects in the** ``/Common`` **partition**.\n+.. [#nodeport] The |kctlr| forwards traffic to the NodePort assigned to the Service by Kubernetes. See the Kubernetes `Services <http://kubernetes.io/docs/user-guide/Services/>`_ documentation for more information.\n+.. [#secrets] You can `secure your BIG-IP credentials </containers/latest/kubernetes/kctlr-secrets.html#secure-your-BIG-IP-credentials>`_ using a Kubernetes Secret.\n+.. [#hm1] Required if defining the ``virtual-server.f5.com/health`` Ingress annotation.\n+.. [#hm2] See the **HTTP monitor settings** section of the `BIG-IP LTM Monitors Reference Guide <https://support.f5.com/kb/en-us/products/big-ip_ltm/manuals/product/bigip-local-traffic-manager-monitors-reference-13-0-0/3.html>`_ for more information about defining send strings.\n \n \n .. _Kubernetes: https://kubernetes.io/\n-.. _Kubernetes Service: https://kubernetes.io/docs/user-guide/services/\n+.. _Kubernetes Service: https://kubernetes.io/docs/user-guide/Services/","path":"docs/README.rst","position":551,"original_position":551,"commit_id":"234fdadb51905d25d1579b591caa086fad3e4ab7","original_commit_id":"234fdadb51905d25d1579b591caa086fad3e4ab7","user":{"login":"amudukutore","id":1004624,"avatar_url":"https://avatars0.githubusercontent.com/u/1004624?v=4","gravatar_id":"","url":"https://api.github.com/users/amudukutore","html_url":"https://github.com/amudukutore","followers_url":"https://api.github.com/users/amudukutore/followers","following_url":"https://api.github.com/users/amudukutore/following{/other_user}","gists_url":"https://api.github.com/users/amudukutore/gists{/gist_id}","starred_url":"https://api.github.com/users/amudukutore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amudukutore/subscriptions","organizations_url":"https://api.github.com/users/amudukutore/orgs","repos_url":"https://api.github.com/users/amudukutore/repos","events_url":"https://api.github.com/users/amudukutore/events{/privacy}","received_events_url":"https://api.github.com/users/amudukutore/received_events","type":"User","site_admin":false},"body":"smae comment as above.","created_at":"2017-09-11T22:09:28Z","updated_at":"2017-09-11T22:09:28Z","html_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/314#discussion_r138205539","pull_request_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments/138205539"},"html":{"href":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/314#discussion_r138205539"},"pull_request":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314","id":139923284,"html_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/314","diff_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/314.diff","patch_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/314.patch","issue_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/314","number":314,"state":"open","locked":false,"title":"openshift feature parity docs ","user":{"login":"jputrino","id":12143793,"avatar_url":"https://avatars1.githubusercontent.com/u/12143793?v=4","gravatar_id":"","url":"https://api.github.com/users/jputrino","html_url":"https://github.com/jputrino","followers_url":"https://api.github.com/users/jputrino/followers","following_url":"https://api.github.com/users/jputrino/following{/other_user}","gists_url":"https://api.github.com/users/jputrino/gists{/gist_id}","starred_url":"https://api.github.com/users/jputrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jputrino/subscriptions","organizations_url":"https://api.github.com/users/jputrino/orgs","repos_url":"https://api.github.com/users/jputrino/repos","events_url":"https://api.github.com/users/jputrino/events{/privacy}","received_events_url":"https://api.github.com/users/jputrino/received_events","type":"User","site_admin":false},"body":"### Fixes #313\r\n\r\n### Problem\r\nWe need to document the existing and upcoming functionality the controller provides in OpenShift environments.\r\n\r\n### Solution\r\nThe documentation has been updated and edited as needed to support the new functionality.\r\nStaged docs are online at staging site (/products/connectors/k8s-bigip-ctlr/elbert/index.html).","created_at":"2017-09-07T23:02:11Z","updated_at":"2017-09-11T22:09:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"735730b910b37c1551112354de219d48d37a2070","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314/commits","review_comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314/comments","review_comment_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/314/comments","statuses_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/234fdadb51905d25d1579b591caa086fad3e4ab7","head":{"label":"jputrino:feature.openshift","ref":"feature.openshift","sha":"234fdadb51905d25d1579b591caa086fad3e4ab7","user":{"login":"jputrino","id":12143793,"avatar_url":"https://avatars1.githubusercontent.com/u/12143793?v=4","gravatar_id":"","url":"https://api.github.com/users/jputrino","html_url":"https://github.com/jputrino","followers_url":"https://api.github.com/users/jputrino/followers","following_url":"https://api.github.com/users/jputrino/following{/other_user}","gists_url":"https://api.github.com/users/jputrino/gists{/gist_id}","starred_url":"https://api.github.com/users/jputrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jputrino/subscriptions","organizations_url":"https://api.github.com/users/jputrino/orgs","repos_url":"https://api.github.com/users/jputrino/repos","events_url":"https://api.github.com/users/jputrino/events{/privacy}","received_events_url":"https://api.github.com/users/jputrino/received_events","type":"User","site_admin":false},"repo":{"id":97525234,"name":"k8s-bigip-ctlr","full_name":"jputrino/k8s-bigip-ctlr","owner":{"login":"jputrino","id":12143793,"avatar_url":"https://avatars1.githubusercontent.com/u/12143793?v=4","gravatar_id":"","url":"https://api.github.com/users/jputrino","html_url":"https://github.com/jputrino","followers_url":"https://api.github.com/users/jputrino/followers","following_url":"https://api.github.com/users/jputrino/following{/other_user}","gists_url":"https://api.github.com/users/jputrino/gists{/gist_id}","starred_url":"https://api.github.com/users/jputrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jputrino/subscriptions","organizations_url":"https://api.github.com/users/jputrino/orgs","repos_url":"https://api.github.com/users/jputrino/repos","events_url":"https://api.github.com/users/jputrino/events{/privacy}","received_events_url":"https://api.github.com/users/jputrino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jputrino/k8s-bigip-ctlr","description":"Repository for F5 Kubernetes BIG-IP Controller.","fork":true,"url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr","forks_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/jputrino/k8s-bigip-ctlr/deployments","created_at":"2017-07-17T21:48:12Z","updated_at":"2017-07-17T21:48:14Z","pushed_at":"2017-09-08T21:50:31Z","git_url":"git://github.com/jputrino/k8s-bigip-ctlr.git","ssh_url":"git@github.com:jputrino/k8s-bigip-ctlr.git","clone_url":"https://github.com/jputrino/k8s-bigip-ctlr.git","svn_url":"https://github.com/jputrino/k8s-bigip-ctlr","homepage":null,"size":5606,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F5Networks:master","ref":"master","sha":"3d360cca6f52f0e9d1e24c9b0f41f0d85c0506b3","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":84464014,"name":"k8s-bigip-ctlr","full_name":"F5Networks/k8s-bigip-ctlr","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/k8s-bigip-ctlr","description":"Repository for F5 BIG-IP Controller for Kubernetes.","fork":false,"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr","forks_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/deployments","created_at":"2017-03-09T16:24:02Z","updated_at":"2017-08-21T18:40:26Z","pushed_at":"2017-09-11T21:49:15Z","git_url":"git://github.com/F5Networks/k8s-bigip-ctlr.git","ssh_url":"git@github.com:F5Networks/k8s-bigip-ctlr.git","clone_url":"https://github.com/F5Networks/k8s-bigip-ctlr.git","svn_url":"https://github.com/F5Networks/k8s-bigip-ctlr","homepage":"","size":5593,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":10,"forks":20,"open_issues":10,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314"},"html":{"href":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/314"},"issue":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/314"},"comments":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/234fdadb51905d25d1579b591caa086fad3e4ab7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amudukutore"}}