{"action":"created","comment":{"url":"https://api.github.com/repos/saz/puppet-timezone/pulls/comments/157343414","pull_request_review_id":83976079,"id":157343414,"diff_hunk":"@@ -74,17 +74,22 @@\n       $_tz = split($timezone, '/')\n       $area = $_tz[0]\n       $zone = $_tz[1]\n-      exec { 'update_debconf area':\n-        command => \"echo tzdata tzdata/Areas select ${area} | debconf-set-selections\",\n-        unless  => \"debconf-get-selections |grep -q -E \\\"^tzdata\\\\s+tzdata/Areas\\\\s+select\\\\s+${area}\\\"\",\n-        path    => $facts['path'],\n-      }\n-      exec { 'update_debconf zone':\n-        command => \"echo tzdata tzdata/Zones/${area} select ${timezone} | debconf-set-selections\",\n-        unless  => \"debconf-get-selections |grep -E \\\"^tzdata\\\\s+tzdata/Zones/${area}\\\\s+select\\\\s+${zone}\\\"\",\n-        path    => $facts['path'],\n+\n+      debconf {\n+        'tzdata/Areas':\n+          package => 'tzdata',\n+          item    => 'tzdata/Areas',\n+          type    => 'select',\n+          value   => $area;\n+        \"tzdata/Zones/${area}\":\n+          package => 'tzdata',\n+          item    => \"tzdata/Zones/${area}\",\n+          type    => 'select',\n+          value   => $timezone;","path":"manifests/init.pp","position":null,"original_position":24,"commit_id":"5607e8d1cd1846b090bc012677fb85a74408b79b","original_commit_id":"c5979b6e50129338f6c4bb375e9d566f072442d5","user":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars3.githubusercontent.com/u/1560587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"body":"Thanks.","created_at":"2017-12-16T14:42:17Z","updated_at":"2017-12-16T14:42:17Z","html_url":"https://github.com/saz/puppet-timezone/pull/53#discussion_r157343414","pull_request_url":"https://api.github.com/repos/saz/puppet-timezone/pulls/53","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/saz/puppet-timezone/pulls/comments/157343414"},"html":{"href":"https://github.com/saz/puppet-timezone/pull/53#discussion_r157343414"},"pull_request":{"href":"https://api.github.com/repos/saz/puppet-timezone/pulls/53"}},"in_reply_to_id":156686433},"pull_request":{"url":"https://api.github.com/repos/saz/puppet-timezone/pulls/53","id":154633066,"html_url":"https://github.com/saz/puppet-timezone/pull/53","diff_url":"https://github.com/saz/puppet-timezone/pull/53.diff","patch_url":"https://github.com/saz/puppet-timezone/pull/53.patch","issue_url":"https://api.github.com/repos/saz/puppet-timezone/issues/53","number":53,"state":"open","locked":false,"title":"Use debconf instead exec","user":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars3.githubusercontent.com/u/1560587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"body":"Since version v4, the package `debconf-utils` was required.\r\n\r\nUsing the already required module `stm/debconf` to mange the debconf paramter should be IHMO better instead using hackish exec.\r\n\r\nI also bump the max puppet version, because the module runs fine under puppet 5.3.3.","created_at":"2017-11-25T10:39:37Z","updated_at":"2017-12-16T14:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"309ba818f7f68f585728a7daa1550253af4c09b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/saz/puppet-timezone/pulls/53/commits","review_comments_url":"https://api.github.com/repos/saz/puppet-timezone/pulls/53/comments","review_comment_url":"https://api.github.com/repos/saz/puppet-timezone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saz/puppet-timezone/issues/53/comments","statuses_url":"https://api.github.com/repos/saz/puppet-timezone/statuses/5607e8d1cd1846b090bc012677fb85a74408b79b","head":{"label":"jkroepke:debconf","ref":"debconf","sha":"5607e8d1cd1846b090bc012677fb85a74408b79b","user":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars3.githubusercontent.com/u/1560587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"repo":{"id":111995249,"name":"puppet-timezone","full_name":"jkroepke/puppet-timezone","owner":{"login":"jkroepke","id":1560587,"avatar_url":"https://avatars3.githubusercontent.com/u/1560587?v=4","gravatar_id":"","url":"https://api.github.com/users/jkroepke","html_url":"https://github.com/jkroepke","followers_url":"https://api.github.com/users/jkroepke/followers","following_url":"https://api.github.com/users/jkroepke/following{/other_user}","gists_url":"https://api.github.com/users/jkroepke/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroepke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroepke/subscriptions","organizations_url":"https://api.github.com/users/jkroepke/orgs","repos_url":"https://api.github.com/users/jkroepke/repos","events_url":"https://api.github.com/users/jkroepke/events{/privacy}","received_events_url":"https://api.github.com/users/jkroepke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkroepke/puppet-timezone","description":"Configure timezone settings through puppet","fork":true,"url":"https://api.github.com/repos/jkroepke/puppet-timezone","forks_url":"https://api.github.com/repos/jkroepke/puppet-timezone/forks","keys_url":"https://api.github.com/repos/jkroepke/puppet-timezone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkroepke/puppet-timezone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkroepke/puppet-timezone/teams","hooks_url":"https://api.github.com/repos/jkroepke/puppet-timezone/hooks","issue_events_url":"https://api.github.com/repos/jkroepke/puppet-timezone/issues/events{/number}","events_url":"https://api.github.com/repos/jkroepke/puppet-timezone/events","assignees_url":"https://api.github.com/repos/jkroepke/puppet-timezone/assignees{/user}","branches_url":"https://api.github.com/repos/jkroepke/puppet-timezone/branches{/branch}","tags_url":"https://api.github.com/repos/jkroepke/puppet-timezone/tags","blobs_url":"https://api.github.com/repos/jkroepke/puppet-timezone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkroepke/puppet-timezone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkroepke/puppet-timezone/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkroepke/puppet-timezone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkroepke/puppet-timezone/statuses/{sha}","languages_url":"https://api.github.com/repos/jkroepke/puppet-timezone/languages","stargazers_url":"https://api.github.com/repos/jkroepke/puppet-timezone/stargazers","contributors_url":"https://api.github.com/repos/jkroepke/puppet-timezone/contributors","subscribers_url":"https://api.github.com/repos/jkroepke/puppet-timezone/subscribers","subscription_url":"https://api.github.com/repos/jkroepke/puppet-timezone/subscription","commits_url":"https://api.github.com/repos/jkroepke/puppet-timezone/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkroepke/puppet-timezone/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkroepke/puppet-timezone/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkroepke/puppet-timezone/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkroepke/puppet-timezone/contents/{+path}","compare_url":"https://api.github.com/repos/jkroepke/puppet-timezone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkroepke/puppet-timezone/merges","archive_url":"https://api.github.com/repos/jkroepke/puppet-timezone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkroepke/puppet-timezone/downloads","issues_url":"https://api.github.com/repos/jkroepke/puppet-timezone/issues{/number}","pulls_url":"https://api.github.com/repos/jkroepke/puppet-timezone/pulls{/number}","milestones_url":"https://api.github.com/repos/jkroepke/puppet-timezone/milestones{/number}","notifications_url":"https://api.github.com/repos/jkroepke/puppet-timezone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkroepke/puppet-timezone/labels{/name}","releases_url":"https://api.github.com/repos/jkroepke/puppet-timezone/releases{/id}","deployments_url":"https://api.github.com/repos/jkroepke/puppet-timezone/deployments","created_at":"2017-11-25T10:30:20Z","updated_at":"2017-11-25T10:30:22Z","pushed_at":"2017-12-16T14:42:05Z","git_url":"git://github.com/jkroepke/puppet-timezone.git","ssh_url":"git@github.com:jkroepke/puppet-timezone.git","clone_url":"https://github.com/jkroepke/puppet-timezone.git","svn_url":"https://github.com/jkroepke/puppet-timezone","homepage":"","size":91,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saz:master","ref":"master","sha":"69178c764f6b911a22777f951a71b6bbc8d33cb9","user":{"login":"saz","id":402629,"avatar_url":"https://avatars0.githubusercontent.com/u/402629?v=4","gravatar_id":"","url":"https://api.github.com/users/saz","html_url":"https://github.com/saz","followers_url":"https://api.github.com/users/saz/followers","following_url":"https://api.github.com/users/saz/following{/other_user}","gists_url":"https://api.github.com/users/saz/gists{/gist_id}","starred_url":"https://api.github.com/users/saz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saz/subscriptions","organizations_url":"https://api.github.com/users/saz/orgs","repos_url":"https://api.github.com/users/saz/repos","events_url":"https://api.github.com/users/saz/events{/privacy}","received_events_url":"https://api.github.com/users/saz/received_events","type":"User","site_admin":false},"repo":{"id":2100349,"name":"puppet-timezone","full_name":"saz/puppet-timezone","owner":{"login":"saz","id":402629,"avatar_url":"https://avatars0.githubusercontent.com/u/402629?v=4","gravatar_id":"","url":"https://api.github.com/users/saz","html_url":"https://github.com/saz","followers_url":"https://api.github.com/users/saz/followers","following_url":"https://api.github.com/users/saz/following{/other_user}","gists_url":"https://api.github.com/users/saz/gists{/gist_id}","starred_url":"https://api.github.com/users/saz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saz/subscriptions","organizations_url":"https://api.github.com/users/saz/orgs","repos_url":"https://api.github.com/users/saz/repos","events_url":"https://api.github.com/users/saz/events{/privacy}","received_events_url":"https://api.github.com/users/saz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saz/puppet-timezone","description":"Configure timezone settings through puppet","fork":false,"url":"https://api.github.com/repos/saz/puppet-timezone","forks_url":"https://api.github.com/repos/saz/puppet-timezone/forks","keys_url":"https://api.github.com/repos/saz/puppet-timezone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saz/puppet-timezone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saz/puppet-timezone/teams","hooks_url":"https://api.github.com/repos/saz/puppet-timezone/hooks","issue_events_url":"https://api.github.com/repos/saz/puppet-timezone/issues/events{/number}","events_url":"https://api.github.com/repos/saz/puppet-timezone/events","assignees_url":"https://api.github.com/repos/saz/puppet-timezone/assignees{/user}","branches_url":"https://api.github.com/repos/saz/puppet-timezone/branches{/branch}","tags_url":"https://api.github.com/repos/saz/puppet-timezone/tags","blobs_url":"https://api.github.com/repos/saz/puppet-timezone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saz/puppet-timezone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saz/puppet-timezone/git/refs{/sha}","trees_url":"https://api.github.com/repos/saz/puppet-timezone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saz/puppet-timezone/statuses/{sha}","languages_url":"https://api.github.com/repos/saz/puppet-timezone/languages","stargazers_url":"https://api.github.com/repos/saz/puppet-timezone/stargazers","contributors_url":"https://api.github.com/repos/saz/puppet-timezone/contributors","subscribers_url":"https://api.github.com/repos/saz/puppet-timezone/subscribers","subscription_url":"https://api.github.com/repos/saz/puppet-timezone/subscription","commits_url":"https://api.github.com/repos/saz/puppet-timezone/commits{/sha}","git_commits_url":"https://api.github.com/repos/saz/puppet-timezone/git/commits{/sha}","comments_url":"https://api.github.com/repos/saz/puppet-timezone/comments{/number}","issue_comment_url":"https://api.github.com/repos/saz/puppet-timezone/issues/comments{/number}","contents_url":"https://api.github.com/repos/saz/puppet-timezone/contents/{+path}","compare_url":"https://api.github.com/repos/saz/puppet-timezone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saz/puppet-timezone/merges","archive_url":"https://api.github.com/repos/saz/puppet-timezone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saz/puppet-timezone/downloads","issues_url":"https://api.github.com/repos/saz/puppet-timezone/issues{/number}","pulls_url":"https://api.github.com/repos/saz/puppet-timezone/pulls{/number}","milestones_url":"https://api.github.com/repos/saz/puppet-timezone/milestones{/number}","notifications_url":"https://api.github.com/repos/saz/puppet-timezone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saz/puppet-timezone/labels{/name}","releases_url":"https://api.github.com/repos/saz/puppet-timezone/releases{/id}","deployments_url":"https://api.github.com/repos/saz/puppet-timezone/deployments","created_at":"2011-07-25T10:25:29Z","updated_at":"2017-11-24T11:38:58Z","pushed_at":"2017-12-16T14:42:06Z","git_url":"git://github.com/saz/puppet-timezone.git","ssh_url":"git@github.com:saz/puppet-timezone.git","clone_url":"https://github.com/saz/puppet-timezone.git","svn_url":"https://github.com/saz/puppet-timezone","homepage":"","size":89,"stargazers_count":38,"watchers_count":38,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":67,"open_issues":6,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saz/puppet-timezone/pulls/53"},"html":{"href":"https://github.com/saz/puppet-timezone/pull/53"},"issue":{"href":"https://api.github.com/repos/saz/puppet-timezone/issues/53"},"comments":{"href":"https://api.github.com/repos/saz/puppet-timezone/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/saz/puppet-timezone/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/saz/puppet-timezone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saz/puppet-timezone/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/saz/puppet-timezone/statuses/5607e8d1cd1846b090bc012677fb85a74408b79b"}},"author_association":"NONE"}}
{"actor":{"display_login":"jkroepke"}}