{"action":"created","issue":{"url":"https://api.github.com/repos/payara/Payara/issues/2151","repository_url":"https://api.github.com/repos/payara/Payara","labels_url":"https://api.github.com/repos/payara/Payara/issues/2151/labels{/name}","comments_url":"https://api.github.com/repos/payara/Payara/issues/2151/comments","events_url":"https://api.github.com/repos/payara/Payara/issues/2151/events","html_url":"https://github.com/payara/Payara/pull/2151","id":273254033,"number":2151,"title":"Improvement for high number of JAR scanning threads.","user":{"login":"lreimer","id":3668212,"avatar_url":"https://avatars2.githubusercontent.com/u/3668212?v=4","gravatar_id":"","url":"https://api.github.com/users/lreimer","html_url":"https://github.com/lreimer","followers_url":"https://api.github.com/users/lreimer/followers","following_url":"https://api.github.com/users/lreimer/following{/other_user}","gists_url":"https://api.github.com/users/lreimer/gists{/gist_id}","starred_url":"https://api.github.com/users/lreimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lreimer/subscriptions","organizations_url":"https://api.github.com/users/lreimer/orgs","repos_url":"https://api.github.com/users/lreimer/repos","events_url":"https://api.github.com/users/lreimer/events{/privacy}","received_events_url":"https://api.github.com/users/lreimer/received_events","type":"User","site_admin":false},"labels":[{"id":256777432,"url":"https://api.github.com/repos/payara/Payara/labels/CLA","name":"CLA","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"lprimak","id":1002484,"avatar_url":"https://avatars0.githubusercontent.com/u/1002484?v=4","gravatar_id":"","url":"https://api.github.com/users/lprimak","html_url":"https://github.com/lprimak","followers_url":"https://api.github.com/users/lprimak/followers","following_url":"https://api.github.com/users/lprimak/following{/other_user}","gists_url":"https://api.github.com/users/lprimak/gists{/gist_id}","starred_url":"https://api.github.com/users/lprimak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lprimak/subscriptions","organizations_url":"https://api.github.com/users/lprimak/orgs","repos_url":"https://api.github.com/users/lprimak/repos","events_url":"https://api.github.com/users/lprimak/events{/privacy}","received_events_url":"https://api.github.com/users/lprimak/received_events","type":"User","site_admin":false},"assignees":[{"login":"lprimak","id":1002484,"avatar_url":"https://avatars0.githubusercontent.com/u/1002484?v=4","gravatar_id":"","url":"https://api.github.com/users/lprimak","html_url":"https://github.com/lprimak","followers_url":"https://api.github.com/users/lprimak/followers","following_url":"https://api.github.com/users/lprimak/following{/other_user}","gists_url":"https://api.github.com/users/lprimak/gists{/gist_id}","starred_url":"https://api.github.com/users/lprimak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lprimak/subscriptions","organizations_url":"https://api.github.com/users/lprimak/orgs","repos_url":"https://api.github.com/users/lprimak/repos","events_url":"https://api.github.com/users/lprimak/events{/privacy}","received_events_url":"https://api.github.com/users/lprimak/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2017-11-12T18:40:17Z","updated_at":"2017-11-23T12:50:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/payara/Payara/pulls/2151","html_url":"https://github.com/payara/Payara/pull/2151","diff_url":"https://github.com/payara/Payara/pull/2151.diff","patch_url":"https://github.com/payara/Payara/pull/2151.patch"},"body":"This fixes and improves #2150. It uses `Executors.newCachedThreadPool(..)` instead of a fixed thread pool with the number of available processors as size instead."},"comment":{"url":"https://api.github.com/repos/payara/Payara/issues/comments/346610333","html_url":"https://github.com/payara/Payara/pull/2151#issuecomment-346610333","issue_url":"https://api.github.com/repos/payara/Payara/issues/2151","id":346610333,"user":{"login":"lreimer","id":3668212,"avatar_url":"https://avatars2.githubusercontent.com/u/3668212?v=4","gravatar_id":"","url":"https://api.github.com/users/lreimer","html_url":"https://github.com/lreimer","followers_url":"https://api.github.com/users/lreimer/followers","following_url":"https://api.github.com/users/lreimer/following{/other_user}","gists_url":"https://api.github.com/users/lreimer/gists{/gist_id}","starred_url":"https://api.github.com/users/lreimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lreimer/subscriptions","organizations_url":"https://api.github.com/users/lreimer/orgs","repos_url":"https://api.github.com/users/lreimer/repos","events_url":"https://api.github.com/users/lreimer/events{/privacy}","received_events_url":"https://api.github.com/users/lreimer/received_events","type":"User","site_admin":false},"created_at":"2017-11-23T12:50:40Z","updated_at":"2017-11-23T12:50:40Z","author_association":"NONE","body":"Hard to tell. I did some testing. Here is the setup:\r\n1) Unmodified Payara Server Full 174\r\n2) Payara Server Full (Master) with modified Thread Pool Core Size 0\r\n3) Payara Server Full (Master) with modified Thread Pool Core Size 2\r\n\r\nThen, for all 3 server variants I did the following iterations and steps:\r\n- Iteration 1\r\n  - Fresh start of domain1\r\n  - Access the admingui so it gets deployed\r\n  - Check deployment thread count using `jstack`\r\n  - Stop domain1\r\n- Iteration 2\r\n  - Start domain1 again\r\n  - Check deployment thread count using `jstack`\r\n  - Stop domain1\r\n- Iteration 3\r\n  - Start domain1 again\r\n  - Check deployment thread count using `jstack`\r\n  - Stop domain1\r\n\r\nThe results are attached. [timings.txt](https://github.com/payara/Payara/files/1499065/timings.txt)\r\n\r\nFor 2) iteration 3 I would say it is about 300ms slower, but threads are left after deployment is done."}}
{"actor":{"display_login":"lreimer"}}