{"action":"opened","number":4035,"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/4035","id":130584048,"html_url":"https://github.com/facebook/jest/pull/4035","diff_url":"https://github.com/facebook/jest/pull/4035.diff","patch_url":"https://github.com/facebook/jest/pull/4035.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/4035","number":4035,"state":"open","locked":false,"title":"Wrap `Error.captureStackTrace` in a try","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars6.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->\r\n\r\n**Summary**\r\nRef #4027\r\n\r\nThis is a poor-man's version, but it works OK. Not sure we really need to fix it more?\r\n\r\nCould put the logic to remove `JestAssertionError` along with the rest of the stack trace cleanup and avoid `Error.captureStackTrace` all together?\r\n\r\n/cc @skovhus \r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n\r\n**Test plan**\r\nTests running in browsers should show assertion errors.\r\n\r\n<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->\r\n","created_at":"2017-07-14T12:59:32Z","updated_at":"2017-07-14T12:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/4035/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/4035/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/4035/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/fc941b1da16b0e3d8240f3ff18b009d2ab302d06","head":{"label":"SimenB:stack-trace-no-capture","ref":"stack-trace-no-capture","sha":"fc941b1da16b0e3d8240f3ff18b009d2ab302d06","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars6.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"repo":{"id":75474674,"name":"jest","full_name":"SimenB/jest","owner":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars6.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimenB/jest","description":"🃏 Painless JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/SimenB/jest","forks_url":"https://api.github.com/repos/SimenB/jest/forks","keys_url":"https://api.github.com/repos/SimenB/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimenB/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimenB/jest/teams","hooks_url":"https://api.github.com/repos/SimenB/jest/hooks","issue_events_url":"https://api.github.com/repos/SimenB/jest/issues/events{/number}","events_url":"https://api.github.com/repos/SimenB/jest/events","assignees_url":"https://api.github.com/repos/SimenB/jest/assignees{/user}","branches_url":"https://api.github.com/repos/SimenB/jest/branches{/branch}","tags_url":"https://api.github.com/repos/SimenB/jest/tags","blobs_url":"https://api.github.com/repos/SimenB/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimenB/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimenB/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimenB/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimenB/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/SimenB/jest/languages","stargazers_url":"https://api.github.com/repos/SimenB/jest/stargazers","contributors_url":"https://api.github.com/repos/SimenB/jest/contributors","subscribers_url":"https://api.github.com/repos/SimenB/jest/subscribers","subscription_url":"https://api.github.com/repos/SimenB/jest/subscription","commits_url":"https://api.github.com/repos/SimenB/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimenB/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimenB/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimenB/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimenB/jest/contents/{+path}","compare_url":"https://api.github.com/repos/SimenB/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimenB/jest/merges","archive_url":"https://api.github.com/repos/SimenB/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimenB/jest/downloads","issues_url":"https://api.github.com/repos/SimenB/jest/issues{/number}","pulls_url":"https://api.github.com/repos/SimenB/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/SimenB/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/SimenB/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimenB/jest/labels{/name}","releases_url":"https://api.github.com/repos/SimenB/jest/releases{/id}","deployments_url":"https://api.github.com/repos/SimenB/jest/deployments","created_at":"2016-12-03T13:18:04Z","updated_at":"2016-12-03T13:18:07Z","pushed_at":"2017-07-14T12:56:55Z","git_url":"git://github.com/SimenB/jest.git","ssh_url":"git@github.com:SimenB/jest.git","clone_url":"https://github.com/SimenB/jest.git","svn_url":"https://github.com/SimenB/jest","homepage":"http://facebook.github.io/jest/","size":16430,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"cf7f7fdde110a15a52cd9ade4115b2104ec9aab7","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars7.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"name":"jest","full_name":"facebook/jest","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars7.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2017-07-14T07:59:00Z","pushed_at":"2017-07-14T10:20:08Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"http://facebook.github.io/jest/","size":19324,"stargazers_count":11133,"watchers_count":11133,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1387,"mirror_url":null,"open_issues_count":210,"forks":1387,"open_issues":210,"watchers":11133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/4035"},"html":{"href":"https://github.com/facebook/jest/pull/4035"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/4035"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/4035/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/4035/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/4035/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/fc941b1da16b0e3d8240f3ff18b009d2ab302d06"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":48,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"SimenB"}}