{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/49850","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/49850/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/49850/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/49850/events","html_url":"https://github.com/kubernetes/kubernetes/pull/49850","id":246586167,"number":49850,"title":"Paramaterize `stickyMaxAgeMinutes` for service in API","user":{"login":"m1093782566","id":4953962,"avatar_url":"https://avatars1.githubusercontent.com/u/4953962?v=4","gravatar_id":"","url":"https://api.github.com/users/m1093782566","html_url":"https://github.com/m1093782566","followers_url":"https://api.github.com/users/m1093782566/followers","following_url":"https://api.github.com/users/m1093782566/following{/other_user}","gists_url":"https://api.github.com/users/m1093782566/gists{/gist_id}","starred_url":"https://api.github.com/users/m1093782566/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m1093782566/subscriptions","organizations_url":"https://api.github.com/users/m1093782566/orgs","repos_url":"https://api.github.com/users/m1093782566/repos","events_url":"https://api.github.com/users/m1093782566/events{/privacy}","received_events_url":"https://api.github.com/users/m1093782566/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36","html_url":"https://github.com/kubernetes/kubernetes/milestone/36","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36/labels","id":2545392,"number":36,"title":"v1.8","description":"Kubernetes 1.8 release milestone, date is TBD.","creator":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"open_issues":224,"closed_issues":192,"state":"open","created_at":"2017-05-26T17:18:43Z","updated_at":"2017-08-18T23:26:13Z","due_on":null,"closed_at":null},"comments":26,"created_at":"2017-07-30T14:11:19Z","updated_at":"2017-08-19T07:09:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/49850","html_url":"https://github.com/kubernetes/kubernetes/pull/49850","diff_url":"https://github.com/kubernetes/kubernetes/pull/49850.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/49850.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nCurrently I find `stickyMaxAgeMinutes` for a session affinity type service is hard code to 180min. There is a TODO comment, see\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/iptables/proxier.go#L205\r\n\r\nI think the seesion sticky max time varies from service to service and users may not aware of it since it's hard coded in all proxier.go - iptables, userspace and winuserspace.\r\n\r\nOnce we parameterize it in API, users can set/get the values for their different services.\r\n\r\nPerhaps, we can introduce a new field `api.ClientIPAffinityConfig` in `api.ServiceSpec`.\r\n\r\nThere is an initial discussion about it in sig-network group. See,\r\n\r\nhttps://groups.google.com/forum/#!topic/kubernetes-sig-network/i-LkeHrjs80\r\n\r\n**Which issue this PR fixes**: \r\n\r\nfixes #49831\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nParamaterize session affinity timeout seconds in service API for Client IP based session affinity.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/323506086","html_url":"https://github.com/kubernetes/kubernetes/pull/49850#issuecomment-323506086","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/49850","id":323506086,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-08-19T07:09:58Z","updated_at":"2017-08-19T07:09:58Z","body":"@m1093782566: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-verify | 449867e2a20c42695e83258c57c75729fd48a560 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-verify/46297/) | `/test pull-kubernetes-verify`\npull-kubernetes-unit | 47436b24fccf404a17d85da5a557ed59203fcdb2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-unit/47844/) | `/test pull-kubernetes-unit`\npull-kubernetes-bazel | 72f3acd642f1374194babf6ed0fbf9b1b50b66e5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-bazel/36877/) | `/test pull-kubernetes-bazel`\npull-kubernetes-e2e-gce-etcd3 | 72f3acd642f1374194babf6ed0fbf9b1b50b66e5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-e2e-gce-etcd3/48363/) | `/test pull-kubernetes-e2e-gce-etcd3`\npull-kubernetes-e2e-kops-aws | 72f3acd642f1374194babf6ed0fbf9b1b50b66e5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-e2e-kops-aws/42269/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-kubemark-e2e-gce | 72f3acd642f1374194babf6ed0fbf9b1b50b66e5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-kubemark-e2e-gce/46494/) | `/test pull-kubernetes-kubemark-e2e-gce`\npull-kubernetes-federation-e2e-gce | 72f3acd642f1374194babf6ed0fbf9b1b50b66e5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-federation-e2e-gce/21832/) | `/test pull-kubernetes-federation-e2e-gce`\npull-kubernetes-node-e2e | 72f3acd642f1374194babf6ed0fbf9b1b50b66e5 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/49850/pull-kubernetes-node-e2e/46171/) | `/test pull-kubernetes-node-e2e`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/49850). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/m1093782566). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}