{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/141644583","pull_request_review_id":65891200,"id":141644583,"diff_hunk":"@@ -178,6 +181,9 @@\n     {\n       \"type\": \"Microsoft.Compute/virtualMachines\",\n       \"name\": \"[concat(parameters('vmNamePrefix'), '-ucpdtrnode')]\",\n+\n+      \"apiVersion\": \"[parameters('apiVersionCompute')]\",","path":"cloudbeesjenkins-dockerdatacenter/nested/ucpdtrnode.json","position":15,"original_position":15,"commit_id":"cc5a0b4cc73585025b8bc85f153d974a6316d27e","original_commit_id":"cc5a0b4cc73585025b8bc85f153d974a6316d27e","user":{"login":"bmoore-msft","id":10090014,"avatar_url":"https://avatars1.githubusercontent.com/u/10090014?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoore-msft","html_url":"https://github.com/bmoore-msft","followers_url":"https://api.github.com/users/bmoore-msft/followers","following_url":"https://api.github.com/users/bmoore-msft/following{/other_user}","gists_url":"https://api.github.com/users/bmoore-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoore-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoore-msft/subscriptions","organizations_url":"https://api.github.com/users/bmoore-msft/orgs","repos_url":"https://api.github.com/users/bmoore-msft/repos","events_url":"https://api.github.com/users/bmoore-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bmoore-msft/received_events","type":"User","site_admin":false},"body":"Use a literal apiVersion so schema validation can be done.","created_at":"2017-09-28T15:03:20Z","updated_at":"2017-09-28T15:04:17Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3949#discussion_r141644583","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/141644583"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3949#discussion_r141644583"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949","id":143588256,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3949","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/3949.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/3949.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3949","number":3949,"state":"open","locked":false,"title":"Cloudbeesjenkins-dockerdatacenter missing api-verion error fixed","user":{"login":"ashwinse","id":20834128,"avatar_url":"https://avatars2.githubusercontent.com/u/20834128?v=4","gravatar_id":"","url":"https://api.github.com/users/ashwinse","html_url":"https://github.com/ashwinse","followers_url":"https://api.github.com/users/ashwinse/followers","following_url":"https://api.github.com/users/ashwinse/following{/other_user}","gists_url":"https://api.github.com/users/ashwinse/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinse/subscriptions","organizations_url":"https://api.github.com/users/ashwinse/orgs","repos_url":"https://api.github.com/users/ashwinse/repos","events_url":"https://api.github.com/users/ashwinse/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinse/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources.  While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n*\r\n*\r\n*\r\n\r\n","created_at":"2017-09-28T08:44:58Z","updated_at":"2017-09-28T15:04:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc68e91a42ec2c47b5617e70d905b490453bfab8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3949/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/cc5a0b4cc73585025b8bc85f153d974a6316d27e","head":{"label":"sysgain:master","ref":"master","sha":"cc5a0b4cc73585025b8bc85f153d974a6316d27e","user":{"login":"sysgain","id":10661877,"avatar_url":"https://avatars3.githubusercontent.com/u/10661877?v=4","gravatar_id":"","url":"https://api.github.com/users/sysgain","html_url":"https://github.com/sysgain","followers_url":"https://api.github.com/users/sysgain/followers","following_url":"https://api.github.com/users/sysgain/following{/other_user}","gists_url":"https://api.github.com/users/sysgain/gists{/gist_id}","starred_url":"https://api.github.com/users/sysgain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysgain/subscriptions","organizations_url":"https://api.github.com/users/sysgain/orgs","repos_url":"https://api.github.com/users/sysgain/repos","events_url":"https://api.github.com/users/sysgain/events{/privacy}","received_events_url":"https://api.github.com/users/sysgain/received_events","type":"Organization","site_admin":false},"repo":{"id":68785013,"name":"azure-quickstart-templates","full_name":"sysgain/azure-quickstart-templates","owner":{"login":"sysgain","id":10661877,"avatar_url":"https://avatars3.githubusercontent.com/u/10661877?v=4","gravatar_id":"","url":"https://api.github.com/users/sysgain","html_url":"https://github.com/sysgain","followers_url":"https://api.github.com/users/sysgain/followers","following_url":"https://api.github.com/users/sysgain/following{/other_user}","gists_url":"https://api.github.com/users/sysgain/gists{/gist_id}","starred_url":"https://api.github.com/users/sysgain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysgain/subscriptions","organizations_url":"https://api.github.com/users/sysgain/orgs","repos_url":"https://api.github.com/users/sysgain/repos","events_url":"https://api.github.com/users/sysgain/events{/privacy}","received_events_url":"https://api.github.com/users/sysgain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sysgain/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/sysgain/azure-quickstart-templates","forks_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/sysgain/azure-quickstart-templates/deployments","created_at":"2016-09-21T05:59:58Z","updated_at":"2017-09-28T08:37:26Z","pushed_at":"2017-09-28T08:42:32Z","git_url":"git://github.com/sysgain/azure-quickstart-templates.git","ssh_url":"git@github.com:sysgain/azure-quickstart-templates.git","clone_url":"https://github.com/sysgain/azure-quickstart-templates.git","svn_url":"https://github.com/sysgain/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":219885,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"15a868c7cbb9a49aa429e63ae8029da57e523fc5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2017-09-28T13:53:27Z","pushed_at":"2017-09-28T15:00:24Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":219784,"stargazers_count":2781,"watchers_count":2781,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3963,"mirror_url":null,"open_issues_count":341,"forks":3963,"open_issues":341,"watchers":2781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3949"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3949"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3949/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3949/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/cc5a0b4cc73585025b8bc85f153d974a6316d27e"}},"author_association":"NONE"}}
{"actor":{"display_login":"bmoore-msft"}}