{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/29109","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/29109/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/29109/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/29109/events","html_url":"https://github.com/owncloud/core/pull/29109","id":260976105,"number":29109,"title":"Allow 0 byte quota to be entered on UI","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"labels":[{"id":17709846,"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":289357759,"url":"https://api.github.com/repos/owncloud/core/labels/comp:core-js","name":"comp:core-js","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"assignees":[{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/117","html_url":"https://github.com/owncloud/core/milestone/117","labels_url":"https://api.github.com/repos/owncloud/core/milestones/117/labels","id":2619154,"number":117,"title":"development","description":"10.0.4","creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":45,"state":"open","created_at":"2017-07-03T15:30:42Z","updated_at":"2017-09-27T17:42:50Z","due_on":"2017-10-09T07:00:00Z","closed_at":null},"comments":3,"created_at":"2017-09-27T13:34:15Z","updated_at":"2017-09-27T17:43:59Z","closed_at":"2017-09-27T17:42:50Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/29109","html_url":"https://github.com/owncloud/core/pull/29109","diff_url":"https://github.com/owncloud/core/pull/29109.diff","patch_url":"https://github.com/owncloud/core/pull/29109.patch"},"body":"## Description\r\n1) Add a test for entering 0 byte quota (note: 0 can be entered as \"0\" \"0 B\" \"0 KB\" etc)\r\n2) While we are here, add a test to make sure entering a quota of \"-1\" fails.\r\n3) Improve the check of the return value from ``computerFileSize()``\r\n\r\n## Related Issue\r\n#29105 \r\nalso improves on old closed issue #25358\r\n\r\n## Motivation and Context\r\nIt be broke.\r\n\r\n## How Has This Been Tested?\r\nRun automated UI tests in a local dev VM. Watch it work.\r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/332600937","html_url":"https://github.com/owncloud/core/pull/29109#issuecomment-332600937","issue_url":"https://api.github.com/repos/owncloud/core/issues/29109","id":332600937,"user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"created_at":"2017-09-27T17:43:59Z","updated_at":"2017-09-27T17:43:59Z","author_association":"CONTRIBUTOR","body":"Now that zero quota can be entered, there will need to be followup to test exactly what can and cannot be done by a user with 0 bytes quota. Then decide if that is the desired behavior or not."}}
{"actor":{"display_login":"phil-davis"}}