{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/118869678","pull_request_review_id":40701469,"id":118869678,"diff_hunk":"@@ -141,6 +138,20 @@ func (api *BaseAPI) applicationOffersFromModel(\n \treturn results, nil\n }\n \n+// checkOfferAccess returns the level of access the authenticated user has to the offer,\n+// so long as it is greater than the requested perm.\n+func (api *BaseAPI) checkOfferAccess(backend Backend, offerName string, perm permission.Access) (permission.Access, error) {","path":"apiserver/applicationoffers/base.go","position":24,"original_position":24,"commit_id":"558d41aa5dedd69b3530dbef6ed540776f8b009a","original_commit_id":"4fee15ae468b9f980cfda2303a748237923eac08","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars0.githubusercontent.com/u/5808968?v=3","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"permission.NoAccess is a legitimate enum value for a permission. It's not the same as getting a string value back and no knowing if empty string means something concrete or just missing, which is where we tend to require the use of the additional bool. I'll land now to progress and we can discuss further - easy to add it in the next PR if needed.","created_at":"2017-05-29T05:56:24Z","updated_at":"2017-05-29T05:56:25Z","html_url":"https://github.com/juju/juju/pull/7336#discussion_r118869678","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/7336","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/118869678"},"html":{"href":"https://github.com/juju/juju/pull/7336#discussion_r118869678"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/7336"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/7336","id":120251720,"html_url":"https://github.com/juju/juju/pull/7336","diff_url":"https://github.com/juju/juju/pull/7336.diff","patch_url":"https://github.com/juju/juju/pull/7336.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/7336","number":7336,"state":"open","locked":false,"title":"Move consume api off application model facade to applicationoffers controller facade","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars0.githubusercontent.com/u/5808968?v=3","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"\r\n## Description of change\r\n\r\nThe Consume() API is on the Application facade. The implementation assumes both source and target models are in the same controller. This won't always be the case. The API needs to be split in two:\r\na. get the details from the source model\r\nb. save the details to the target model\r\n\r\nThis PR is one of many - it moves the Consume() API to the ApplicationOffers controller facade and implements the part to save the details to the target mode. Stuff that is now broken is commented out.\r\n\r\n","created_at":"2017-05-12T05:36:19Z","updated_at":"2017-05-29T05:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77793861397a29aaa021b0326b7ddcd49ce3a88e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/7336/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/7336/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/7336/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/558d41aa5dedd69b3530dbef6ed540776f8b009a","head":{"label":"wallyworld:move-consume-to-controller","ref":"move-consume-to-controller","sha":"558d41aa5dedd69b3530dbef6ed540776f8b009a","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars0.githubusercontent.com/u/5808968?v=3","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"repo":{"id":20465218,"name":"juju","full_name":"wallyworld/juju","owner":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars0.githubusercontent.com/u/5808968?v=3","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wallyworld/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/wallyworld/juju","forks_url":"https://api.github.com/repos/wallyworld/juju/forks","keys_url":"https://api.github.com/repos/wallyworld/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wallyworld/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wallyworld/juju/teams","hooks_url":"https://api.github.com/repos/wallyworld/juju/hooks","issue_events_url":"https://api.github.com/repos/wallyworld/juju/issues/events{/number}","events_url":"https://api.github.com/repos/wallyworld/juju/events","assignees_url":"https://api.github.com/repos/wallyworld/juju/assignees{/user}","branches_url":"https://api.github.com/repos/wallyworld/juju/branches{/branch}","tags_url":"https://api.github.com/repos/wallyworld/juju/tags","blobs_url":"https://api.github.com/repos/wallyworld/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wallyworld/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wallyworld/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/wallyworld/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wallyworld/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/wallyworld/juju/languages","stargazers_url":"https://api.github.com/repos/wallyworld/juju/stargazers","contributors_url":"https://api.github.com/repos/wallyworld/juju/contributors","subscribers_url":"https://api.github.com/repos/wallyworld/juju/subscribers","subscription_url":"https://api.github.com/repos/wallyworld/juju/subscription","commits_url":"https://api.github.com/repos/wallyworld/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/wallyworld/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/wallyworld/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/wallyworld/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/wallyworld/juju/contents/{+path}","compare_url":"https://api.github.com/repos/wallyworld/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wallyworld/juju/merges","archive_url":"https://api.github.com/repos/wallyworld/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wallyworld/juju/downloads","issues_url":"https://api.github.com/repos/wallyworld/juju/issues{/number}","pulls_url":"https://api.github.com/repos/wallyworld/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/wallyworld/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/wallyworld/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wallyworld/juju/labels{/name}","releases_url":"https://api.github.com/repos/wallyworld/juju/releases{/id}","deployments_url":"https://api.github.com/repos/wallyworld/juju/deployments","created_at":"2014-06-04T00:56:12Z","updated_at":"2016-01-11T16:57:01Z","pushed_at":"2017-05-29T03:40:22Z","git_url":"git://github.com/wallyworld/juju.git","ssh_url":"git@github.com:wallyworld/juju.git","clone_url":"https://github.com/wallyworld/juju.git","svn_url":"https://github.com/wallyworld/juju","homepage":null,"size":195829,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:feature-cmr-consume","ref":"feature-cmr-consume","sha":"67513bff466cf2196918ec1c16e39f23340929fb","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars3.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars3.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2017-05-28T18:36:54Z","pushed_at":"2017-05-29T04:45:10Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":196131,"stargazers_count":935,"watchers_count":935,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":13,"forks":211,"open_issues":13,"watchers":935,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/7336"},"html":{"href":"https://github.com/juju/juju/pull/7336"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/7336"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/7336/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/7336/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/7336/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/558d41aa5dedd69b3530dbef6ed540776f8b009a"}}}}
{"actor":{"display_login":"wallyworld"}}