{"action":"closed","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/821","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/821/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/821/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/821/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/issues/821","id":68200987,"number":821,"title":"Remove datastore.key._dataset_ids_equal and just use string equality check","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"labels":[{"id":77676109,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels/api:%20datastore","name":"api: datastore","color":"d4af37","default":false},{"id":544604243,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels/priority:%20p2+","name":"priority: p2+","color":"ffee58","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones/5","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/milestone/5","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones/5/labels","id":958842,"number":5,"title":"Datastore Future","description":"","creator":{"login":"jgeewax","id":112928,"avatar_url":"https://avatars2.githubusercontent.com/u/112928?v=4","gravatar_id":"","url":"https://api.github.com/users/jgeewax","html_url":"https://github.com/jgeewax","followers_url":"https://api.github.com/users/jgeewax/followers","following_url":"https://api.github.com/users/jgeewax/following{/other_user}","gists_url":"https://api.github.com/users/jgeewax/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeewax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeewax/subscriptions","organizations_url":"https://api.github.com/users/jgeewax/orgs","repos_url":"https://api.github.com/users/jgeewax/repos","events_url":"https://api.github.com/users/jgeewax/events{/privacy}","received_events_url":"https://api.github.com/users/jgeewax/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"closed","created_at":"2015-01-30T20:34:15Z","updated_at":"2017-08-11T23:03:51Z","due_on":null,"closed_at":"2017-03-09T16:29:20Z"},"comments":2,"created_at":"2015-04-13T21:39:55Z","updated_at":"2017-08-11T23:03:51Z","closed_at":"2017-08-11T23:03:50Z","body":"See #528 for some history here.\n\nThe issue is that requests made using `foo` instead of `s~foo` fail in [strange ways](https://github.com/GoogleCloudPlatform/google-cloud-datastore/issues/59).\n\nSo as a result we have to use `datastore.helpers._prepare_key_for_request` to strip dataset IDs from keys that get sent to the server. This has accidental caused bugs in the past (e.g. allowing keys from a different dataset `bar` to be inserted into dataset `foo`)\n"}}
{"actor":{"display_login":"dhermes"}}