{"action":"created","comment":{"url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/comments/109018247","pull_request_review_id":30092597,"id":109018247,"diff_hunk":"@@ -235,6 +261,7 @@ type dynamicField struct {\n //\n // Make sure to call Close() to flush buffers.\n func Init(config Config) error {\n+\trand.Seed(time.Now().UnixNano())","path":"libhoney.go","position":65,"original_position":77,"commit_id":"f9f1902ee1e8ca8fc6a0b4d6d97decb1699174c7","original_commit_id":"f5f7f5cfcfee0a7755129000d3007e6256ccb3f0","user":{"login":"christineyen","id":188595,"avatar_url":"https://avatars0.githubusercontent.com/u/188595?v=3","gravatar_id":"","url":"https://api.github.com/users/christineyen","html_url":"https://github.com/christineyen","followers_url":"https://api.github.com/users/christineyen/followers","following_url":"https://api.github.com/users/christineyen/following{/other_user}","gists_url":"https://api.github.com/users/christineyen/gists{/gist_id}","starred_url":"https://api.github.com/users/christineyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christineyen/subscriptions","organizations_url":"https://api.github.com/users/christineyen/orgs","repos_url":"https://api.github.com/users/christineyen/repos","events_url":"https://api.github.com/users/christineyen/events{/privacy}","received_events_url":"https://api.github.com/users/christineyen/received_events","type":"User","site_admin":false},"body":"(Tests that expect a deterministic `rand` have an explicit `Seed` called inside them immediately before that expected behavior is verified.)","created_at":"2017-03-30T19:40:36Z","updated_at":"2017-03-30T19:40:36Z","html_url":"https://github.com/honeycombio/libhoney-go/pull/3#discussion_r109018247","pull_request_url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/comments/109018247"},"html":{"href":"https://github.com/honeycombio/libhoney-go/pull/3#discussion_r109018247"},"pull_request":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3","id":89153498,"html_url":"https://github.com/honeycombio/libhoney-go/pull/3","diff_url":"https://github.com/honeycombio/libhoney-go/pull/3.diff","patch_url":"https://github.com/honeycombio/libhoney-go/pull/3.patch","issue_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues/3","number":3,"state":"open","locked":false,"title":"Send batches to new batch endpoint, deserialize batched responses","user":{"login":"christineyen","id":188595,"avatar_url":"https://avatars0.githubusercontent.com/u/188595?v=3","gravatar_id":"","url":"https://api.github.com/users/christineyen","html_url":"https://github.com/christineyen","followers_url":"https://api.github.com/users/christineyen/followers","following_url":"https://api.github.com/users/christineyen/following{/other_user}","gists_url":"https://api.github.com/users/christineyen/gists{/gist_id}","starred_url":"https://api.github.com/users/christineyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christineyen/subscriptions","organizations_url":"https://api.github.com/users/christineyen/orgs","repos_url":"https://api.github.com/users/christineyen/repos","events_url":"https://api.github.com/users/christineyen/events{/privacy}","received_events_url":"https://api.github.com/users/christineyen/received_events","type":"User","site_admin":false},"body":"Depends on support coming to api.honeycomb.io for `/1/batch`, rather than queueing up and firing off individual events.\n\nWe don't do anything intelligent here yet around aligning batch size with API default rate limits, or constraining the size of a batch (and probably should). Feedback is totally welcome there (and there are some comments scattered throughout that are explicitly inviting feedback/comment.)\n\nWe do:\n- gzip JSON payloads if possible\n- Take [`facebookgo/muster`](github.com/facebookgo/muster)'s batches (which we were already using) and fire them off in batches to our API.\n- Receive a batched set of responses (per patterns set forth by Google[1], Parse[2], and Dropbox[3]) and hand them down the `responses` channel individually\n- Handle individual JSON errors separately (rather than a single unmarshallable field poisoning the whole batch)\n\n1: https://developers.google.com/gmail/api/guides/batch#example\n2: https://www.dropbox.com/developers/documentation/http/documentation#files-upload_session-finish_batch-check\n3: https://parseplatform.github.io/docs/rest/guide/#batch-operations\n","created_at":"2016-10-13T08:05:26Z","updated_at":"2017-03-30T19:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ea7724b41757fc88834ad07adc2f62ef144d5c6","assignee":{"login":"christineyen","id":188595,"avatar_url":"https://avatars0.githubusercontent.com/u/188595?v=3","gravatar_id":"","url":"https://api.github.com/users/christineyen","html_url":"https://github.com/christineyen","followers_url":"https://api.github.com/users/christineyen/followers","following_url":"https://api.github.com/users/christineyen/following{/other_user}","gists_url":"https://api.github.com/users/christineyen/gists{/gist_id}","starred_url":"https://api.github.com/users/christineyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christineyen/subscriptions","organizations_url":"https://api.github.com/users/christineyen/orgs","repos_url":"https://api.github.com/users/christineyen/repos","events_url":"https://api.github.com/users/christineyen/events{/privacy}","received_events_url":"https://api.github.com/users/christineyen/received_events","type":"User","site_admin":false},"assignees":[{"login":"christineyen","id":188595,"avatar_url":"https://avatars0.githubusercontent.com/u/188595?v=3","gravatar_id":"","url":"https://api.github.com/users/christineyen","html_url":"https://github.com/christineyen","followers_url":"https://api.github.com/users/christineyen/followers","following_url":"https://api.github.com/users/christineyen/following{/other_user}","gists_url":"https://api.github.com/users/christineyen/gists{/gist_id}","starred_url":"https://api.github.com/users/christineyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christineyen/subscriptions","organizations_url":"https://api.github.com/users/christineyen/orgs","repos_url":"https://api.github.com/users/christineyen/repos","events_url":"https://api.github.com/users/christineyen/events{/privacy}","received_events_url":"https://api.github.com/users/christineyen/received_events","type":"User","site_admin":false},{"login":"maplebed","id":361454,"avatar_url":"https://avatars3.githubusercontent.com/u/361454?v=3","gravatar_id":"","url":"https://api.github.com/users/maplebed","html_url":"https://github.com/maplebed","followers_url":"https://api.github.com/users/maplebed/followers","following_url":"https://api.github.com/users/maplebed/following{/other_user}","gists_url":"https://api.github.com/users/maplebed/gists{/gist_id}","starred_url":"https://api.github.com/users/maplebed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maplebed/subscriptions","organizations_url":"https://api.github.com/users/maplebed/orgs","repos_url":"https://api.github.com/users/maplebed/repos","events_url":"https://api.github.com/users/maplebed/events{/privacy}","received_events_url":"https://api.github.com/users/maplebed/received_events","type":"User","site_admin":false},{"login":"emfree","id":1868186,"avatar_url":"https://avatars2.githubusercontent.com/u/1868186?v=3","gravatar_id":"","url":"https://api.github.com/users/emfree","html_url":"https://github.com/emfree","followers_url":"https://api.github.com/users/emfree/followers","following_url":"https://api.github.com/users/emfree/following{/other_user}","gists_url":"https://api.github.com/users/emfree/gists{/gist_id}","starred_url":"https://api.github.com/users/emfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emfree/subscriptions","organizations_url":"https://api.github.com/users/emfree/orgs","repos_url":"https://api.github.com/users/emfree/repos","events_url":"https://api.github.com/users/emfree/events{/privacy}","received_events_url":"https://api.github.com/users/emfree/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3/commits","review_comments_url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3/comments","review_comment_url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues/3/comments","statuses_url":"https://api.github.com/repos/honeycombio/libhoney-go/statuses/f9f1902ee1e8ca8fc6a0b4d6d97decb1699174c7","head":{"label":"honeycombio:christine.use-batch-endpoint","ref":"christine.use-batch-endpoint","sha":"f9f1902ee1e8ca8fc6a0b4d6d97decb1699174c7","user":{"login":"honeycombio","id":15988027,"avatar_url":"https://avatars2.githubusercontent.com/u/15988027?v=3","gravatar_id":"","url":"https://api.github.com/users/honeycombio","html_url":"https://github.com/honeycombio","followers_url":"https://api.github.com/users/honeycombio/followers","following_url":"https://api.github.com/users/honeycombio/following{/other_user}","gists_url":"https://api.github.com/users/honeycombio/gists{/gist_id}","starred_url":"https://api.github.com/users/honeycombio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honeycombio/subscriptions","organizations_url":"https://api.github.com/users/honeycombio/orgs","repos_url":"https://api.github.com/users/honeycombio/repos","events_url":"https://api.github.com/users/honeycombio/events{/privacy}","received_events_url":"https://api.github.com/users/honeycombio/received_events","type":"Organization","site_admin":false},"repo":{"id":65243472,"name":"libhoney-go","full_name":"honeycombio/libhoney-go","owner":{"login":"honeycombio","id":15988027,"avatar_url":"https://avatars2.githubusercontent.com/u/15988027?v=3","gravatar_id":"","url":"https://api.github.com/users/honeycombio","html_url":"https://github.com/honeycombio","followers_url":"https://api.github.com/users/honeycombio/followers","following_url":"https://api.github.com/users/honeycombio/following{/other_user}","gists_url":"https://api.github.com/users/honeycombio/gists{/gist_id}","starred_url":"https://api.github.com/users/honeycombio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honeycombio/subscriptions","organizations_url":"https://api.github.com/users/honeycombio/orgs","repos_url":"https://api.github.com/users/honeycombio/repos","events_url":"https://api.github.com/users/honeycombio/events{/privacy}","received_events_url":"https://api.github.com/users/honeycombio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/honeycombio/libhoney-go","description":"Go library for sending data to Honeycomb","fork":false,"url":"https://api.github.com/repos/honeycombio/libhoney-go","forks_url":"https://api.github.com/repos/honeycombio/libhoney-go/forks","keys_url":"https://api.github.com/repos/honeycombio/libhoney-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honeycombio/libhoney-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honeycombio/libhoney-go/teams","hooks_url":"https://api.github.com/repos/honeycombio/libhoney-go/hooks","issue_events_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues/events{/number}","events_url":"https://api.github.com/repos/honeycombio/libhoney-go/events","assignees_url":"https://api.github.com/repos/honeycombio/libhoney-go/assignees{/user}","branches_url":"https://api.github.com/repos/honeycombio/libhoney-go/branches{/branch}","tags_url":"https://api.github.com/repos/honeycombio/libhoney-go/tags","blobs_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honeycombio/libhoney-go/statuses/{sha}","languages_url":"https://api.github.com/repos/honeycombio/libhoney-go/languages","stargazers_url":"https://api.github.com/repos/honeycombio/libhoney-go/stargazers","contributors_url":"https://api.github.com/repos/honeycombio/libhoney-go/contributors","subscribers_url":"https://api.github.com/repos/honeycombio/libhoney-go/subscribers","subscription_url":"https://api.github.com/repos/honeycombio/libhoney-go/subscription","commits_url":"https://api.github.com/repos/honeycombio/libhoney-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/honeycombio/libhoney-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/honeycombio/libhoney-go/contents/{+path}","compare_url":"https://api.github.com/repos/honeycombio/libhoney-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honeycombio/libhoney-go/merges","archive_url":"https://api.github.com/repos/honeycombio/libhoney-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honeycombio/libhoney-go/downloads","issues_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues{/number}","pulls_url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls{/number}","milestones_url":"https://api.github.com/repos/honeycombio/libhoney-go/milestones{/number}","notifications_url":"https://api.github.com/repos/honeycombio/libhoney-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honeycombio/libhoney-go/labels{/name}","releases_url":"https://api.github.com/repos/honeycombio/libhoney-go/releases{/id}","deployments_url":"https://api.github.com/repos/honeycombio/libhoney-go/deployments","created_at":"2016-08-08T22:18:35Z","updated_at":"2017-03-23T21:25:58Z","pushed_at":"2017-03-30T19:28:01Z","git_url":"git://github.com/honeycombio/libhoney-go.git","ssh_url":"git@github.com:honeycombio/libhoney-go.git","clone_url":"https://github.com/honeycombio/libhoney-go.git","svn_url":"https://github.com/honeycombio/libhoney-go","homepage":null,"size":65,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"honeycombio:master","ref":"master","sha":"2bc2d64810e5690fe138353a43114c1da1974998","user":{"login":"honeycombio","id":15988027,"avatar_url":"https://avatars2.githubusercontent.com/u/15988027?v=3","gravatar_id":"","url":"https://api.github.com/users/honeycombio","html_url":"https://github.com/honeycombio","followers_url":"https://api.github.com/users/honeycombio/followers","following_url":"https://api.github.com/users/honeycombio/following{/other_user}","gists_url":"https://api.github.com/users/honeycombio/gists{/gist_id}","starred_url":"https://api.github.com/users/honeycombio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honeycombio/subscriptions","organizations_url":"https://api.github.com/users/honeycombio/orgs","repos_url":"https://api.github.com/users/honeycombio/repos","events_url":"https://api.github.com/users/honeycombio/events{/privacy}","received_events_url":"https://api.github.com/users/honeycombio/received_events","type":"Organization","site_admin":false},"repo":{"id":65243472,"name":"libhoney-go","full_name":"honeycombio/libhoney-go","owner":{"login":"honeycombio","id":15988027,"avatar_url":"https://avatars2.githubusercontent.com/u/15988027?v=3","gravatar_id":"","url":"https://api.github.com/users/honeycombio","html_url":"https://github.com/honeycombio","followers_url":"https://api.github.com/users/honeycombio/followers","following_url":"https://api.github.com/users/honeycombio/following{/other_user}","gists_url":"https://api.github.com/users/honeycombio/gists{/gist_id}","starred_url":"https://api.github.com/users/honeycombio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honeycombio/subscriptions","organizations_url":"https://api.github.com/users/honeycombio/orgs","repos_url":"https://api.github.com/users/honeycombio/repos","events_url":"https://api.github.com/users/honeycombio/events{/privacy}","received_events_url":"https://api.github.com/users/honeycombio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/honeycombio/libhoney-go","description":"Go library for sending data to Honeycomb","fork":false,"url":"https://api.github.com/repos/honeycombio/libhoney-go","forks_url":"https://api.github.com/repos/honeycombio/libhoney-go/forks","keys_url":"https://api.github.com/repos/honeycombio/libhoney-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honeycombio/libhoney-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honeycombio/libhoney-go/teams","hooks_url":"https://api.github.com/repos/honeycombio/libhoney-go/hooks","issue_events_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues/events{/number}","events_url":"https://api.github.com/repos/honeycombio/libhoney-go/events","assignees_url":"https://api.github.com/repos/honeycombio/libhoney-go/assignees{/user}","branches_url":"https://api.github.com/repos/honeycombio/libhoney-go/branches{/branch}","tags_url":"https://api.github.com/repos/honeycombio/libhoney-go/tags","blobs_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honeycombio/libhoney-go/statuses/{sha}","languages_url":"https://api.github.com/repos/honeycombio/libhoney-go/languages","stargazers_url":"https://api.github.com/repos/honeycombio/libhoney-go/stargazers","contributors_url":"https://api.github.com/repos/honeycombio/libhoney-go/contributors","subscribers_url":"https://api.github.com/repos/honeycombio/libhoney-go/subscribers","subscription_url":"https://api.github.com/repos/honeycombio/libhoney-go/subscription","commits_url":"https://api.github.com/repos/honeycombio/libhoney-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/honeycombio/libhoney-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/honeycombio/libhoney-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/honeycombio/libhoney-go/contents/{+path}","compare_url":"https://api.github.com/repos/honeycombio/libhoney-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honeycombio/libhoney-go/merges","archive_url":"https://api.github.com/repos/honeycombio/libhoney-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honeycombio/libhoney-go/downloads","issues_url":"https://api.github.com/repos/honeycombio/libhoney-go/issues{/number}","pulls_url":"https://api.github.com/repos/honeycombio/libhoney-go/pulls{/number}","milestones_url":"https://api.github.com/repos/honeycombio/libhoney-go/milestones{/number}","notifications_url":"https://api.github.com/repos/honeycombio/libhoney-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honeycombio/libhoney-go/labels{/name}","releases_url":"https://api.github.com/repos/honeycombio/libhoney-go/releases{/id}","deployments_url":"https://api.github.com/repos/honeycombio/libhoney-go/deployments","created_at":"2016-08-08T22:18:35Z","updated_at":"2017-03-23T21:25:58Z","pushed_at":"2017-03-30T19:28:01Z","git_url":"git://github.com/honeycombio/libhoney-go.git","ssh_url":"git@github.com:honeycombio/libhoney-go.git","clone_url":"https://github.com/honeycombio/libhoney-go.git","svn_url":"https://github.com/honeycombio/libhoney-go","homepage":null,"size":65,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3"},"html":{"href":"https://github.com/honeycombio/libhoney-go/pull/3"},"issue":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/issues/3"},"comments":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/honeycombio/libhoney-go/statuses/f9f1902ee1e8ca8fc6a0b4d6d97decb1699174c7"}}}}
{"actor":{"display_login":"christineyen"}}