{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/15272","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/15272/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/15272/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/15272/events","html_url":"https://github.com/nodejs/node/pull/15272","id":256245699,"number":15272,"title":"build: replace references to jslint with eslint","user":{"login":"seishun","id":988441,"avatar_url":"https://avatars1.githubusercontent.com/u/988441?v=4","gravatar_id":"","url":"https://api.github.com/users/seishun","html_url":"https://github.com/seishun","followers_url":"https://api.github.com/users/seishun/followers","following_url":"https://api.github.com/users/seishun/following{/other_user}","gists_url":"https://api.github.com/users/seishun/gists{/gist_id}","starred_url":"https://api.github.com/users/seishun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seishun/subscriptions","organizations_url":"https://api.github.com/users/seishun/orgs","repos_url":"https://api.github.com/users/seishun/repos","events_url":"https://api.github.com/users/seishun/events{/privacy}","received_events_url":"https://api.github.com/users/seishun/received_events","type":"User","site_admin":false},"labels":[{"id":171787391,"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":237979054,"url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9","default":false},{"id":166236401,"url":"https://api.github.com/repos/nodejs/node/labels/windows","name":"windows","color":"9944dd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-08T12:57:08Z","updated_at":"2017-09-09T19:17:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/15272","html_url":"https://github.com/nodejs/node/pull/15272","diff_url":"https://github.com/nodejs/node/pull/15272.diff","patch_url":"https://github.com/nodejs/node/pull/15272.patch"},"body":"\"jslint\" is the name of a different tool, which can cause confusion.\r\n\r\n(I installed the jslint extension in VSCode and it took me a while to figure out why it's not working)\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nbuild"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/328297991","html_url":"https://github.com/nodejs/node/pull/15272#issuecomment-328297991","issue_url":"https://api.github.com/repos/nodejs/node/issues/15272","id":328297991,"user":{"login":"Trott","id":718899,"avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2017-09-09T19:17:42Z","updated_at":"2017-09-09T19:17:42Z","author_association":"OWNER","body":"@seishun How about we leave the underlying tool out of the naming entirely? Maybe something like this?:\r\n\r\nGiven that: \r\n\r\n* `make test` tests (nearly) everything.\r\n* `make test-addons` and similar variants only test addons, etc.\r\n* `make lint` lints everything.\r\n\r\nPerhaps instead of `make jslint` and `make cpplint`, we should reformat like the `test-*` stuff?:\r\n\r\n* `make lint-js` will do what `make jslint` currently does.\r\n* `make lint-cpp` will do what `make cpplint` currently does.\r\n\r\nWe can have a period of time where `jslint` is an undocumented alias for `lint-js`. After a period of time, `jslint` emits a warning pointing at the new name but is still an effective alias. At some point after that, it emits the warning and does nothing else.  And maybe it stays that way forever or maybe we remove the alias at some point after that. \r\n\r\n"}}
{"actor":{"display_login":"Trott"}}