{"action":"created","issue":{"url":"https://api.github.com/repos/UKHomeOffice/so-acceptance/issues/26","repository_url":"https://api.github.com/repos/UKHomeOffice/so-acceptance","labels_url":"https://api.github.com/repos/UKHomeOffice/so-acceptance/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/UKHomeOffice/so-acceptance/issues/26/comments","events_url":"https://api.github.com/repos/UKHomeOffice/so-acceptance/issues/26/events","html_url":"https://github.com/UKHomeOffice/so-acceptance/pull/26","id":271065666,"number":26,"title":"Refactor configuration file API","user":{"login":"lennym","id":117398,"avatar_url":"https://avatars3.githubusercontent.com/u/117398?v=4","gravatar_id":"","url":"https://api.github.com/users/lennym","html_url":"https://github.com/lennym","followers_url":"https://api.github.com/users/lennym/followers","following_url":"https://api.github.com/users/lennym/following{/other_user}","gists_url":"https://api.github.com/users/lennym/gists{/gist_id}","starred_url":"https://api.github.com/users/lennym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennym/subscriptions","organizations_url":"https://api.github.com/users/lennym/orgs","repos_url":"https://api.github.com/users/lennym/repos","events_url":"https://api.github.com/users/lennym/events{/privacy}","received_events_url":"https://api.github.com/users/lennym/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-03T17:56:35Z","updated_at":"2017-11-07T15:18:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/so-acceptance/pulls/26","html_url":"https://github.com/UKHomeOffice/so-acceptance/pull/26","diff_url":"https://github.com/UKHomeOffice/so-acceptance/pull/26.diff","patch_url":"https://github.com/UKHomeOffice/so-acceptance/pull/26.patch"},"body":"Codecept since 0.6.0 will no longer default to `process.cwd()` when running tests, and instead infers the test root from the config file location - which is not configurable.\r\n\r\nThis means that the config file in the project root directory *must* be passed to codecept, and so the extension of the common config in this module must be explicitly extended."},"comment":{"url":"https://api.github.com/repos/UKHomeOffice/so-acceptance/issues/comments/342514698","html_url":"https://github.com/UKHomeOffice/so-acceptance/pull/26#issuecomment-342514698","issue_url":"https://api.github.com/repos/UKHomeOffice/so-acceptance/issues/26","id":342514698,"user":{"login":"lennym","id":117398,"avatar_url":"https://avatars3.githubusercontent.com/u/117398?v=4","gravatar_id":"","url":"https://api.github.com/users/lennym","html_url":"https://github.com/lennym","followers_url":"https://api.github.com/users/lennym/followers","following_url":"https://api.github.com/users/lennym/following{/other_user}","gists_url":"https://api.github.com/users/lennym/gists{/gist_id}","starred_url":"https://api.github.com/users/lennym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennym/subscriptions","organizations_url":"https://api.github.com/users/lennym/orgs","repos_url":"https://api.github.com/users/lennym/repos","events_url":"https://api.github.com/users/lennym/events{/privacy}","received_events_url":"https://api.github.com/users/lennym/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T15:18:30Z","updated_at":"2017-11-07T15:18:30Z","author_association":"COLLABORATOR","body":"So...\r\n\r\nThere's a bug in codeceptjs@0.5 - this was fixed in 0.6 that caused failing test runs to show as passed - this is bad.\r\n\r\n_However_ between 0.5 and 0.6 codecept changed so that it no longer defaulted its working directory to `process.cwd()` (which is what we want) and instead used the directory where it found the config file.\r\n\r\nSo, because we always said the config was in `./node_modules/so-acceptance` it used that as the test root, which broke our test run because there are no tests there.\r\n\r\nCodecept doesn't allow separate configuration of test root and config file location (see https://github.com/Codeception/CodeceptJS/issues/767) which is also pretty bad.\r\n\r\nThe solution is to refactor the way we build our codecept config files, so that the resolved file lives in the project root, and not in `so-acceptance`. However this will require a little scaffolding to be done in projects to get the defaults from so-acceptance, which I've tried to keep to a minimum, but is non-zero.\r\n\r\nIf/when codecept fix the issue linked above, then we can revert to the seamless methods used before."}}
{"actor":{"display_login":"lennym"}}