{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/no-player/pulls/comments/123715754","pull_request_review_id":45947494,"id":123715754,"diff_hunk":"@@ -18,7 +18,7 @@ public DrmSessionCreator createFor(DrmType drmType, DrmHandler drmHandler) {\n                 );\n                 return StreamingDrmSessionCreator.newInstance(mediaDrmCallback, new FrameworkMediaDrmCreator());","path":"core/src/main/java/com/novoda/noplayer/drm/DrmSessionCreatorFactory.java","position":2,"original_position":2,"commit_id":"8bf8bf425c76b4935ed1e6b1bc98a3e3b546a3fe","original_commit_id":"8bf8bf425c76b4935ed1e6b1bc98a3e3b546a3fe","user":{"login":"joetimmins","id":10560214,"avatar_url":"https://avatars2.githubusercontent.com/u/10560214?v=3","gravatar_id":"","url":"https://api.github.com/users/joetimmins","html_url":"https://github.com/joetimmins","followers_url":"https://api.github.com/users/joetimmins/followers","following_url":"https://api.github.com/users/joetimmins/following{/other_user}","gists_url":"https://api.github.com/users/joetimmins/gists{/gist_id}","starred_url":"https://api.github.com/users/joetimmins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joetimmins/subscriptions","organizations_url":"https://api.github.com/users/joetimmins/orgs","repos_url":"https://api.github.com/users/joetimmins/repos","events_url":"https://api.github.com/users/joetimmins/events{/privacy}","received_events_url":"https://api.github.com/users/joetimmins/received_events","type":"User","site_admin":false},"body":"This guy can be / should be package-private too","created_at":"2017-06-23T10:10:26Z","updated_at":"2017-06-23T10:10:26Z","html_url":"https://github.com/novoda/no-player/pull/50#discussion_r123715754","pull_request_url":"https://api.github.com/repos/novoda/no-player/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/novoda/no-player/pulls/comments/123715754"},"html":{"href":"https://github.com/novoda/no-player/pull/50#discussion_r123715754"},"pull_request":{"href":"https://api.github.com/repos/novoda/no-player/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/no-player/pulls/50","id":127169116,"html_url":"https://github.com/novoda/no-player/pull/50","diff_url":"https://github.com/novoda/no-player/pull/50.diff","patch_url":"https://github.com/novoda/no-player/pull/50.patch","issue_url":"https://api.github.com/repos/novoda/no-player/issues/50","number":50,"state":"open","locked":false,"title":"ALL-3936/Downloaded DRM","user":{"login":"Mecharyry","id":3380092,"avatar_url":"https://avatars2.githubusercontent.com/u/3380092?v=3","gravatar_id":"","url":"https://api.github.com/users/Mecharyry","html_url":"https://github.com/Mecharyry","followers_url":"https://api.github.com/users/Mecharyry/followers","following_url":"https://api.github.com/users/Mecharyry/following{/other_user}","gists_url":"https://api.github.com/users/Mecharyry/gists{/gist_id}","starred_url":"https://api.github.com/users/Mecharyry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mecharyry/subscriptions","organizations_url":"https://api.github.com/users/Mecharyry/orgs","repos_url":"https://api.github.com/users/Mecharyry/repos","events_url":"https://api.github.com/users/Mecharyry/events{/privacy}","received_events_url":"https://api.github.com/users/Mecharyry/received_events","type":"User","site_admin":false},"body":"## Problem\r\nWe've added capability to play a DRM protected streaming video, now we need to do the same for a Downloaded one!\r\n\r\n## Solution\r\n- `LocalDrmSessionManager` is responsible for acquiring and releasing `DRM` sessions.\r\n- We are representing the states of the `LocalDrmSessionManager` through two `DrmSession`s which can be either `LocalDrmSession` (valid) or `InvalidDrmSession` (invalid/error).\r\n- `DrmSessionStates`are either valid or not, we aren't handling lots of states.\r\n- We wrapped some `byte[]` representing `SessionId`s and `KeySetId` for type safety.\r\n\r\n### Test(s) added \r\nNot just yet. We would need to wrap further the `ExoPlayer` specific classes to do this. We want to have something working and then we will go back and write these. Sorry! \r\n\r\n### Screenshots\r\nNo UI changes. We can't test downloads directly on `no-player`, we can't find a local asset that includes the keys 😢 \r\n\r\n### Paired with \r\n@ouchadam \r\n","created_at":"2017-06-23T09:35:22Z","updated_at":"2017-06-23T10:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e466f1cca074226024d72111ff12cbe55c4e6fa","assignee":{"login":"jackSzm","id":6136159,"avatar_url":"https://avatars1.githubusercontent.com/u/6136159?v=3","gravatar_id":"","url":"https://api.github.com/users/jackSzm","html_url":"https://github.com/jackSzm","followers_url":"https://api.github.com/users/jackSzm/followers","following_url":"https://api.github.com/users/jackSzm/following{/other_user}","gists_url":"https://api.github.com/users/jackSzm/gists{/gist_id}","starred_url":"https://api.github.com/users/jackSzm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackSzm/subscriptions","organizations_url":"https://api.github.com/users/jackSzm/orgs","repos_url":"https://api.github.com/users/jackSzm/repos","events_url":"https://api.github.com/users/jackSzm/events{/privacy}","received_events_url":"https://api.github.com/users/jackSzm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackSzm","id":6136159,"avatar_url":"https://avatars1.githubusercontent.com/u/6136159?v=3","gravatar_id":"","url":"https://api.github.com/users/jackSzm","html_url":"https://github.com/jackSzm","followers_url":"https://api.github.com/users/jackSzm/followers","following_url":"https://api.github.com/users/jackSzm/following{/other_user}","gists_url":"https://api.github.com/users/jackSzm/gists{/gist_id}","starred_url":"https://api.github.com/users/jackSzm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackSzm/subscriptions","organizations_url":"https://api.github.com/users/jackSzm/orgs","repos_url":"https://api.github.com/users/jackSzm/repos","events_url":"https://api.github.com/users/jackSzm/events{/privacy}","received_events_url":"https://api.github.com/users/jackSzm/received_events","type":"User","site_admin":false},{"login":"joetimmins","id":10560214,"avatar_url":"https://avatars2.githubusercontent.com/u/10560214?v=3","gravatar_id":"","url":"https://api.github.com/users/joetimmins","html_url":"https://github.com/joetimmins","followers_url":"https://api.github.com/users/joetimmins/followers","following_url":"https://api.github.com/users/joetimmins/following{/other_user}","gists_url":"https://api.github.com/users/joetimmins/gists{/gist_id}","starred_url":"https://api.github.com/users/joetimmins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joetimmins/subscriptions","organizations_url":"https://api.github.com/users/joetimmins/orgs","repos_url":"https://api.github.com/users/joetimmins/repos","events_url":"https://api.github.com/users/joetimmins/events{/privacy}","received_events_url":"https://api.github.com/users/joetimmins/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/novoda/no-player/pulls/50/commits","review_comments_url":"https://api.github.com/repos/novoda/no-player/pulls/50/comments","review_comment_url":"https://api.github.com/repos/novoda/no-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/no-player/issues/50/comments","statuses_url":"https://api.github.com/repos/novoda/no-player/statuses/8bf8bf425c76b4935ed1e6b1bc98a3e3b546a3fe","head":{"label":"novoda:ALL-3936/downloads","ref":"ALL-3936/downloads","sha":"8bf8bf425c76b4935ed1e6b1bc98a3e3b546a3fe","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":71840572,"name":"no-player","full_name":"novoda/no-player","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/no-player","description":" Simplified Player wrapper for MediaPlayer and ExoPlayer","fork":false,"url":"https://api.github.com/repos/novoda/no-player","forks_url":"https://api.github.com/repos/novoda/no-player/forks","keys_url":"https://api.github.com/repos/novoda/no-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/no-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/no-player/teams","hooks_url":"https://api.github.com/repos/novoda/no-player/hooks","issue_events_url":"https://api.github.com/repos/novoda/no-player/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/no-player/events","assignees_url":"https://api.github.com/repos/novoda/no-player/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/no-player/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/no-player/tags","blobs_url":"https://api.github.com/repos/novoda/no-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/no-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/no-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/no-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/no-player/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/no-player/languages","stargazers_url":"https://api.github.com/repos/novoda/no-player/stargazers","contributors_url":"https://api.github.com/repos/novoda/no-player/contributors","subscribers_url":"https://api.github.com/repos/novoda/no-player/subscribers","subscription_url":"https://api.github.com/repos/novoda/no-player/subscription","commits_url":"https://api.github.com/repos/novoda/no-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/no-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/no-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/no-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/no-player/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/no-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/no-player/merges","archive_url":"https://api.github.com/repos/novoda/no-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/no-player/downloads","issues_url":"https://api.github.com/repos/novoda/no-player/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/no-player/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/no-player/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/no-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/no-player/labels{/name}","releases_url":"https://api.github.com/repos/novoda/no-player/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/no-player/deployments","created_at":"2016-10-24T23:27:42Z","updated_at":"2017-06-12T12:35:24Z","pushed_at":"2017-06-23T09:43:49Z","git_url":"git://github.com/novoda/no-player.git","ssh_url":"git@github.com:novoda/no-player.git","clone_url":"https://github.com/novoda/no-player.git","svn_url":"https://github.com/novoda/no-player","homepage":"","size":698,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":22,"default_branch":"master"}},"base":{"label":"novoda:exo-player-2","ref":"exo-player-2","sha":"9b820982d0487f5661d5f9bdbfb8d025c44b858b","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":71840572,"name":"no-player","full_name":"novoda/no-player","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/no-player","description":" Simplified Player wrapper for MediaPlayer and ExoPlayer","fork":false,"url":"https://api.github.com/repos/novoda/no-player","forks_url":"https://api.github.com/repos/novoda/no-player/forks","keys_url":"https://api.github.com/repos/novoda/no-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/no-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/no-player/teams","hooks_url":"https://api.github.com/repos/novoda/no-player/hooks","issue_events_url":"https://api.github.com/repos/novoda/no-player/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/no-player/events","assignees_url":"https://api.github.com/repos/novoda/no-player/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/no-player/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/no-player/tags","blobs_url":"https://api.github.com/repos/novoda/no-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/no-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/no-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/no-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/no-player/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/no-player/languages","stargazers_url":"https://api.github.com/repos/novoda/no-player/stargazers","contributors_url":"https://api.github.com/repos/novoda/no-player/contributors","subscribers_url":"https://api.github.com/repos/novoda/no-player/subscribers","subscription_url":"https://api.github.com/repos/novoda/no-player/subscription","commits_url":"https://api.github.com/repos/novoda/no-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/no-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/no-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/no-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/no-player/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/no-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/no-player/merges","archive_url":"https://api.github.com/repos/novoda/no-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/no-player/downloads","issues_url":"https://api.github.com/repos/novoda/no-player/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/no-player/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/no-player/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/no-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/no-player/labels{/name}","releases_url":"https://api.github.com/repos/novoda/no-player/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/no-player/deployments","created_at":"2016-10-24T23:27:42Z","updated_at":"2017-06-12T12:35:24Z","pushed_at":"2017-06-23T09:43:49Z","git_url":"git://github.com/novoda/no-player.git","ssh_url":"git@github.com:novoda/no-player.git","clone_url":"https://github.com/novoda/no-player.git","svn_url":"https://github.com/novoda/no-player","homepage":"","size":698,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/no-player/pulls/50"},"html":{"href":"https://github.com/novoda/no-player/pull/50"},"issue":{"href":"https://api.github.com/repos/novoda/no-player/issues/50"},"comments":{"href":"https://api.github.com/repos/novoda/no-player/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/no-player/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/no-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/no-player/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/no-player/statuses/8bf8bf425c76b4935ed1e6b1bc98a3e3b546a3fe"}}}}
{"actor":{"display_login":"joetimmins"}}