{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/community/pulls/comments/110206643","pull_request_review_id":31362478,"id":110206643,"diff_hunk":"@@ -11,10 +11,93 @@ This document is intended to be relative to the branch in which it is found.\n It is guaranteed that requirements will change over time for the development\n branch, but release branches of Kubernetes should not change.\n \n+## Pre submit flight checks\n+\n+Make sure you decide whether your issue and/or pull request is improving kubernetes architecture or whehter its simply fixing a bug.\n+\n+Make sure there are no typos, if you need a diagram, add it.  Make sure you SEPARATE the description of the problem","path":"contributors/devel/development.md","position":8,"original_position":8,"commit_id":"472127884e1f4eab8153012e5e2b5de9fe7b3db5","original_commit_id":"472127884e1f4eab8153012e5e2b5de9fe7b3db5","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars3.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"Make sure there are no typos, and if you need a diagram, add it.","created_at":"2017-04-06T16:22:28Z","updated_at":"2017-04-06T16:23:58Z","html_url":"https://github.com/kubernetes/community/pull/497#discussion_r110206643","pull_request_url":"https://api.github.com/repos/kubernetes/community/pulls/497","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments/110206643"},"html":{"href":"https://github.com/kubernetes/community/pull/497#discussion_r110206643"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/community/pulls/497"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/community/pulls/497","id":113720406,"html_url":"https://github.com/kubernetes/community/pull/497","diff_url":"https://github.com/kubernetes/community/pull/497.diff","patch_url":"https://github.com/kubernetes/community/pull/497.patch","issue_url":"https://api.github.com/repos/kubernetes/community/issues/497","number":497,"state":"closed","locked":false,"title":"architecture vs performance improvements guidelines","user":{"login":"jayunit100","id":826111,"avatar_url":"https://avatars0.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},"body":"We have a lot of upstream PRs that have optimization goals which can turn into bikeshedding, because they are submitted without data , graphs, etc.  \r\n\r\nSo I think we should do our contributors a favor and make it easy for them to self review the quality of their performance or architecture improvements before they submit them.\r\n\r\nExamples where new contributors need a little more guidance in terms of how to submit a performance optimization:\r\n\r\n- https://github.com/kubernetes/kubernetes/issues/43843\r\n- https://github.com/kubernetes/kubernetes/issues/43912\r\n\r\nI think we can just point folks to this doc, or something similar, for performance or architecture improvements to make sure they've dont the basic calisthenics necessary for submitting those sorts of patches.","created_at":"2017-03-31T19:51:13Z","updated_at":"2017-04-06T16:23:58Z","closed_at":"2017-04-04T00:48:43Z","merged_at":"2017-04-04T00:48:43Z","merge_commit_sha":"712dd6e91bb250f84ad8773a6154ffa5e996a713","assignee":{"login":"timothysc","id":169553,"avatar_url":"https://avatars3.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"assignees":[{"login":"timothysc","id":169553,"avatar_url":"https://avatars3.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},{"login":"jayunit100","id":826111,"avatar_url":"https://avatars0.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},{"login":"gmarek","id":1703842,"avatar_url":"https://avatars3.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars3.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/community/pulls/497/commits","review_comments_url":"https://api.github.com/repos/kubernetes/community/pulls/497/comments","review_comment_url":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/community/issues/497/comments","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/472127884e1f4eab8153012e5e2b5de9fe7b3db5","head":{"label":"jayunit100:perf_guidelines","ref":"perf_guidelines","sha":"472127884e1f4eab8153012e5e2b5de9fe7b3db5","user":{"login":"jayunit100","id":826111,"avatar_url":"https://avatars0.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},"repo":{"id":79286709,"name":"community","full_name":"jayunit100/community","owner":{"login":"jayunit100","id":826111,"avatar_url":"https://avatars0.githubusercontent.com/u/826111?v=3","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayunit100/community","description":"Kubernetes community content","fork":true,"url":"https://api.github.com/repos/jayunit100/community","forks_url":"https://api.github.com/repos/jayunit100/community/forks","keys_url":"https://api.github.com/repos/jayunit100/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayunit100/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayunit100/community/teams","hooks_url":"https://api.github.com/repos/jayunit100/community/hooks","issue_events_url":"https://api.github.com/repos/jayunit100/community/issues/events{/number}","events_url":"https://api.github.com/repos/jayunit100/community/events","assignees_url":"https://api.github.com/repos/jayunit100/community/assignees{/user}","branches_url":"https://api.github.com/repos/jayunit100/community/branches{/branch}","tags_url":"https://api.github.com/repos/jayunit100/community/tags","blobs_url":"https://api.github.com/repos/jayunit100/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayunit100/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayunit100/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayunit100/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayunit100/community/statuses/{sha}","languages_url":"https://api.github.com/repos/jayunit100/community/languages","stargazers_url":"https://api.github.com/repos/jayunit100/community/stargazers","contributors_url":"https://api.github.com/repos/jayunit100/community/contributors","subscribers_url":"https://api.github.com/repos/jayunit100/community/subscribers","subscription_url":"https://api.github.com/repos/jayunit100/community/subscription","commits_url":"https://api.github.com/repos/jayunit100/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayunit100/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayunit100/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayunit100/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayunit100/community/contents/{+path}","compare_url":"https://api.github.com/repos/jayunit100/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayunit100/community/merges","archive_url":"https://api.github.com/repos/jayunit100/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayunit100/community/downloads","issues_url":"https://api.github.com/repos/jayunit100/community/issues{/number}","pulls_url":"https://api.github.com/repos/jayunit100/community/pulls{/number}","milestones_url":"https://api.github.com/repos/jayunit100/community/milestones{/number}","notifications_url":"https://api.github.com/repos/jayunit100/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayunit100/community/labels{/name}","releases_url":"https://api.github.com/repos/jayunit100/community/releases{/id}","deployments_url":"https://api.github.com/repos/jayunit100/community/deployments","created_at":"2017-01-18T00:25:58Z","updated_at":"2017-01-18T00:26:02Z","pushed_at":"2017-04-01T21:00:33Z","git_url":"git://github.com/jayunit100/community.git","ssh_url":"git@github.com:jayunit100/community.git","clone_url":"https://github.com/jayunit100/community.git","svn_url":"https://github.com/jayunit100/community","homepage":"","size":6979,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4052513581bb98037309abed3151475965fcddb8","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57939112,"name":"community","full_name":"kubernetes/community","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/community","description":"Kubernetes community content","fork":false,"url":"https://api.github.com/repos/kubernetes/community","forks_url":"https://api.github.com/repos/kubernetes/community/forks","keys_url":"https://api.github.com/repos/kubernetes/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/community/teams","hooks_url":"https://api.github.com/repos/kubernetes/community/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/community/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/community/events","assignees_url":"https://api.github.com/repos/kubernetes/community/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/community/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/community/tags","blobs_url":"https://api.github.com/repos/kubernetes/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/community/languages","stargazers_url":"https://api.github.com/repos/kubernetes/community/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/community/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/community/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/community/subscription","commits_url":"https://api.github.com/repos/kubernetes/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/community/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/community/merges","archive_url":"https://api.github.com/repos/kubernetes/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/community/downloads","issues_url":"https://api.github.com/repos/kubernetes/community/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/community/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/community/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/community/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/community/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/community/deployments","created_at":"2016-05-03T03:36:05Z","updated_at":"2017-04-06T05:45:56Z","pushed_at":"2017-04-06T14:54:30Z","git_url":"git://github.com/kubernetes/community.git","ssh_url":"git@github.com:kubernetes/community.git","clone_url":"https://github.com/kubernetes/community.git","svn_url":"https://github.com/kubernetes/community","homepage":"","size":8042,"stargazers_count":311,"watchers_count":311,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":303,"mirror_url":null,"open_issues_count":115,"forks":303,"open_issues":115,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/497"},"html":{"href":"https://github.com/kubernetes/community/pull/497"},"issue":{"href":"https://api.github.com/repos/kubernetes/community/issues/497"},"comments":{"href":"https://api.github.com/repos/kubernetes/community/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/community/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/community/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/community/statuses/472127884e1f4eab8153012e5e2b5de9fe7b3db5"}}}}
{"actor":{"display_login":"timothysc"}}