{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/104829524","pull_request_review_id":25682838,"id":104829524,"diff_hunk":"@@ -93,7 +98,7 @@ class BootstrappingChooser(\n   /**\n    * Store all the systemStreamPartitions registered\n    */\n-  var registeredSystemStreamPartitions = Set[SystemStreamPartition]()\n+  var registeredSystemStreamPartitions: mutable.Map[SystemStreamPartition, String] = mutable.Map[SystemStreamPartition, String]()","path":"samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala","position":45,"original_position":45,"commit_id":"1aea4a2bacc5fc8496048b8e52963ff5f3a91b18","original_commit_id":"1aea4a2bacc5fc8496048b8e52963ff5f3a91b18","user":{"login":"shanthoosh","id":483745,"avatar_url":"https://avatars1.githubusercontent.com/u/483745?v=3","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"body":"Removed the type annotation.","created_at":"2017-03-08T02:08:40Z","updated_at":"2017-03-08T02:08:40Z","html_url":"https://github.com/apache/samza/pull/68#discussion_r104829524","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/104829524"},"html":{"href":"https://github.com/apache/samza/pull/68#discussion_r104829524"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/68","id":108191994,"html_url":"https://github.com/apache/samza/pull/68","diff_url":"https://github.com/apache/samza/pull/68.diff","patch_url":"https://github.com/apache/samza/pull/68.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/68","number":68,"state":"open","locked":false,"title":"SAMZA-1100: Exception when using a stream as both bootstrap and broadcast.","user":{"login":"shanthoosh","id":483745,"avatar_url":"https://avatars1.githubusercontent.com/u/483745?v=3","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"body":"When a task input stream is used as both broadcast and bootstrap stream in a samza job, Bootstrappingchooser marks the stream as bootstrapped when a single task finishes consuming all the SystemStreamPartitions(This happens when all the starting offset for each partition in the input stream is of type upcoming). This patch fixes this, by marking a stream as bootstrapped, only when all the systemStreamPartitions in a input stream is consumed by all the expected tasks.\r\n\r\nMore details here : https://issues.apache.org/jira/browse/SAMZA-1100 ","created_at":"2017-02-27T20:13:20Z","updated_at":"2017-03-08T02:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b87d469b7ac1c5076d462031551ff3ad097488c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/68/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/68/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/68/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/1aea4a2bacc5fc8496048b8e52963ff5f3a91b18","head":{"label":"shanthoosh:master","ref":"master","sha":"1aea4a2bacc5fc8496048b8e52963ff5f3a91b18","user":{"login":"shanthoosh","id":483745,"avatar_url":"https://avatars1.githubusercontent.com/u/483745?v=3","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"repo":{"id":69699342,"name":"samza","full_name":"shanthoosh/samza","owner":{"login":"shanthoosh","id":483745,"avatar_url":"https://avatars1.githubusercontent.com/u/483745?v=3","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shanthoosh/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/shanthoosh/samza","forks_url":"https://api.github.com/repos/shanthoosh/samza/forks","keys_url":"https://api.github.com/repos/shanthoosh/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shanthoosh/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shanthoosh/samza/teams","hooks_url":"https://api.github.com/repos/shanthoosh/samza/hooks","issue_events_url":"https://api.github.com/repos/shanthoosh/samza/issues/events{/number}","events_url":"https://api.github.com/repos/shanthoosh/samza/events","assignees_url":"https://api.github.com/repos/shanthoosh/samza/assignees{/user}","branches_url":"https://api.github.com/repos/shanthoosh/samza/branches{/branch}","tags_url":"https://api.github.com/repos/shanthoosh/samza/tags","blobs_url":"https://api.github.com/repos/shanthoosh/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shanthoosh/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shanthoosh/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/shanthoosh/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shanthoosh/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/shanthoosh/samza/languages","stargazers_url":"https://api.github.com/repos/shanthoosh/samza/stargazers","contributors_url":"https://api.github.com/repos/shanthoosh/samza/contributors","subscribers_url":"https://api.github.com/repos/shanthoosh/samza/subscribers","subscription_url":"https://api.github.com/repos/shanthoosh/samza/subscription","commits_url":"https://api.github.com/repos/shanthoosh/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/shanthoosh/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/shanthoosh/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/shanthoosh/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/shanthoosh/samza/contents/{+path}","compare_url":"https://api.github.com/repos/shanthoosh/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shanthoosh/samza/merges","archive_url":"https://api.github.com/repos/shanthoosh/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shanthoosh/samza/downloads","issues_url":"https://api.github.com/repos/shanthoosh/samza/issues{/number}","pulls_url":"https://api.github.com/repos/shanthoosh/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/shanthoosh/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/shanthoosh/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shanthoosh/samza/labels{/name}","releases_url":"https://api.github.com/repos/shanthoosh/samza/releases{/id}","deployments_url":"https://api.github.com/repos/shanthoosh/samza/deployments","created_at":"2016-09-30T20:20:29Z","updated_at":"2016-09-30T20:20:32Z","pushed_at":"2017-03-07T00:10:18Z","git_url":"git://github.com/shanthoosh/samza.git","ssh_url":"git@github.com:shanthoosh/samza.git","clone_url":"https://github.com/shanthoosh/samza.git","svn_url":"https://github.com/shanthoosh/samza","homepage":null,"size":15072,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d104013ef16ffd959916a52e9e3f6e67a6e486b3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"name":"samza","full_name":"apache/samza","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2017-03-06T07:29:50Z","pushed_at":"2017-03-07T23:34:46Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":15332,"stargazers_count":301,"watchers_count":301,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":"git://git.apache.org/samza.git","open_issues_count":24,"forks":137,"open_issues":24,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/68"},"html":{"href":"https://github.com/apache/samza/pull/68"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/68"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/1aea4a2bacc5fc8496048b8e52963ff5f3a91b18"}}}}
{"actor":{"display_login":"shanthoosh"}}