{"action":"created","comment":{"url":"https://api.github.com/repos/serverless/serverless/pulls/comments/116217180","pull_request_review_id":37824114,"id":116217180,"diff_hunk":"@@ -0,0 +1,132 @@\n+'use strict';\n+\n+const BbPromise = require('bluebird');\n+const crypto = require('crypto');\n+const readline = require('readline');\n+const opn = require('opn');\n+const fetch = require('node-fetch');\n+const jwtDecode = require('jwt-decode');\n+const chalk = require('chalk');\n+const getFrameworkId = require('../../utils/getFrameworkId');\n+const updateConfig = require('../../utils/config/update');\n+\n+const config = {","path":"lib/plugins/login/login.js","position":13,"original_position":13,"commit_id":"50532758712df2f8af1891ede0b3b490cfd53a38","original_commit_id":"cb0d097774b4ca57c8f6ebe44090d7bb768900b4","user":{"login":"eahefnawy","id":2312463,"avatar_url":"https://avatars2.githubusercontent.com/u/2312463?v=3","gravatar_id":"","url":"https://api.github.com/users/eahefnawy","html_url":"https://github.com/eahefnawy","followers_url":"https://api.github.com/users/eahefnawy/followers","following_url":"https://api.github.com/users/eahefnawy/following{/other_user}","gists_url":"https://api.github.com/users/eahefnawy/gists{/gist_id}","starred_url":"https://api.github.com/users/eahefnawy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eahefnawy/subscriptions","organizations_url":"https://api.github.com/users/eahefnawy/orgs","repos_url":"https://api.github.com/users/eahefnawy/repos","events_url":"https://api.github.com/users/eahefnawy/events{/privacy}","received_events_url":"https://api.github.com/users/eahefnawy/received_events","type":"User","site_admin":false},"body":"hmmm I'm super curious about that. Would anyone be able to just copy that into their code and implement their own login? Do we want people logged in outside of the context of the framework?","created_at":"2017-05-12T12:36:15Z","updated_at":"2017-05-12T12:40:58Z","html_url":"https://github.com/serverless/serverless/pull/3558#discussion_r116217180","pull_request_url":"https://api.github.com/repos/serverless/serverless/pulls/3558","_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments/116217180"},"html":{"href":"https://github.com/serverless/serverless/pull/3558#discussion_r116217180"},"pull_request":{"href":"https://api.github.com/repos/serverless/serverless/pulls/3558"}}},"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/3558","id":119087137,"html_url":"https://github.com/serverless/serverless/pull/3558","diff_url":"https://github.com/serverless/serverless/pull/3558.diff","patch_url":"https://github.com/serverless/serverless/pull/3558.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/3558","number":3558,"state":"open","locked":false,"title":"Add login command","user":{"login":"DavidWells","id":532272,"avatar_url":"https://avatars1.githubusercontent.com/u/532272?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidWells","html_url":"https://github.com/DavidWells","followers_url":"https://api.github.com/users/DavidWells/followers","following_url":"https://api.github.com/users/DavidWells/following{/other_user}","gists_url":"https://api.github.com/users/DavidWells/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidWells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidWells/subscriptions","organizations_url":"https://api.github.com/users/DavidWells/orgs","repos_url":"https://api.github.com/users/DavidWells/repos","events_url":"https://api.github.com/users/DavidWells/events{/privacy}","received_events_url":"https://api.github.com/users/DavidWells/received_events","type":"User","site_admin":false},"body":"\r\n## What did you implement:\r\n\r\nAdds `serverless login` to the CLI.\r\n\r\nRunning this command optional & is prep work for the upcoming release of the serverless platform.\r\n\r\nAdditionally, this is part of an ongoing effort to improve the developer experience of the CLI. The `login` command will help us help new developers adopt & use the framework.\r\n\r\n## How did you implement it:\r\n\r\nAdded `login` command\r\n\r\n## How can we verify it:\r\n\r\nRun `sls login`, login, grab your token, & insert back into the CLI.\r\n\r\n## Todos:\r\n\r\n- [x] Write tests\r\n- [ ] Write documentation\r\n- [x] Fix linting errors\r\n- [x] Make sure code coverage hasn't dropped\r\n- [x] Provide verification config / commands / resources\r\n\r\n***Is this ready for review?:*** No\r\n***Is it a breaking change?:*** No\r\n","created_at":"2017-05-04T23:28:20Z","updated_at":"2017-05-12T12:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efaee11ba88f6c4ed2cd7f2db0fb59fef345ec80","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/serverless/serverless/milestones/29","html_url":"https://github.com/serverless/serverless/milestone/29","labels_url":"https://api.github.com/repos/serverless/serverless/milestones/29/labels","id":2501665,"number":29,"title":"1.14","description":"","creator":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars0.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":15,"state":"open","created_at":"2017-05-05T05:31:55Z","updated_at":"2017-05-12T12:31:08Z","due_on":"2017-05-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/3558/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/3558/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/3558/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/50532758712df2f8af1891ede0b3b490cfd53a38","head":{"label":"serverless:addLogin","ref":"addLogin","sha":"50532758712df2f8af1891ede0b3b490cfd53a38","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars3.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars3.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2017-05-12T12:08:25Z","pushed_at":"2017-05-12T12:38:54Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":74178,"stargazers_count":16392,"watchers_count":16392,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1527,"mirror_url":null,"open_issues_count":290,"forks":1527,"open_issues":290,"watchers":16392,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"358ea69647e94b5d42c9360c3c1dcc2f2e169a1f","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars3.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars3.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2017-05-12T12:08:25Z","pushed_at":"2017-05-12T12:38:54Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":74178,"stargazers_count":16392,"watchers_count":16392,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1527,"mirror_url":null,"open_issues_count":290,"forks":1527,"open_issues":290,"watchers":16392,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/3558"},"html":{"href":"https://github.com/serverless/serverless/pull/3558"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/3558"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/3558/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/3558/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/3558/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/50532758712df2f8af1891ede0b3b490cfd53a38"}}}}
{"actor":{"display_login":"eahefnawy"}}