{"action":"created","issue":{"url":"https://api.github.com/repos/leonjia0112/ec601_passenger_screening/issues/4","repository_url":"https://api.github.com/repos/leonjia0112/ec601_passenger_screening","labels_url":"https://api.github.com/repos/leonjia0112/ec601_passenger_screening/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/leonjia0112/ec601_passenger_screening/issues/4/comments","events_url":"https://api.github.com/repos/leonjia0112/ec601_passenger_screening/issues/4/events","html_url":"https://github.com/leonjia0112/ec601_passenger_screening/issues/4","id":273261447,"number":4,"title":"Code Review of Shengye Li","user":{"login":"ShengyeLi","id":31777027,"avatar_url":"https://avatars2.githubusercontent.com/u/31777027?v=4","gravatar_id":"","url":"https://api.github.com/users/ShengyeLi","html_url":"https://github.com/ShengyeLi","followers_url":"https://api.github.com/users/ShengyeLi/followers","following_url":"https://api.github.com/users/ShengyeLi/following{/other_user}","gists_url":"https://api.github.com/users/ShengyeLi/gists{/gist_id}","starred_url":"https://api.github.com/users/ShengyeLi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShengyeLi/subscriptions","organizations_url":"https://api.github.com/users/ShengyeLi/orgs","repos_url":"https://api.github.com/users/ShengyeLi/repos","events_url":"https://api.github.com/users/ShengyeLi/events{/privacy}","received_events_url":"https://api.github.com/users/ShengyeLi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-12T20:20:55Z","updated_at":"2017-12-15T00:42:13Z","closed_at":"2017-12-15T00:42:13Z","author_association":"NONE","body":"All the comments in this review are based on the instruction in \r\nhttp://web.mit.edu/6.005/www/fa15/classes/04-code-review/\r\n\r\nTo begin with, their file structure is simple and well-organized. All the members have their own branches, which are also allocated according to their tasks.  In contrast, their are only limited number of  code files in their master. However, these code are explicit and useful. This structure represents well the core idea of “master branch”, the final and functional code.\r\n\r\nThe following part is respective review on their files in master branch  and some comments. \r\n\r\nREADME.md\r\nTheir readme file is really function. It explains clearly about their file structure and provides links of their different part of work. Meanwhile, as the core of readme file, they explains their idea and principal design about the project they are working on. Furthermore, they also list the source of data used in their project. This gives tester a better and easier way to evaluate their work precisely and sufficiently. \r\n\r\nSCC.log\r\nIt worths our mimic that they provide this file on mater branch, because this file could give an overall picture on what is working and what is not to every team member, and thus they can modify the corresponding module soon.\r\n\r\ndatadownload.py\r\nThey are really good at commenting. For every variable they use and every lines of code that is might be strange to others, they provide specific comments to explain the purpose and function of their code very well. And they use space very well so that their code are divided into parts. In a word, their work makes code readable and explicit.\r\n\r\nIn my scope of knowledge, every attempts involving input and output stream are supposed to code in a try-and-except structure for all the unexpected problem in file reading and writing, which is unfortunately missed in their data download. \r\n\r\nprocess.py\r\nOn the one hand, they are good at the following items. They completely avoid the problem of “bad names\", because all the names of variables can clearly explain the purpose and meaning of them. Due to the reason that their codes are written in python, they utilize whitespace very well to establish their code structure, which makes code easy to understand. Last but not the least, they are also really good at commenting, they not only make comments on some lines of code, they also explain the propose and potential output of the functions they defines.\r\n\r\nOn the other hand, however, they sometimes failed to avoid the “magic number” problems, and thus some number they use are hard to understand. And they all use print( ) to output results. However, I think they can use other stdout method to output their result to error log and other log so that they can review they work of their code better.\r\n\r\ntrainsample.py\r\nIt’s another great presentation of their wonderful habit in  making comments for commands, variables, and also functions they define. \r\n\r\nHowever, they used some global variables in this file, which is supposed to avoid in the instruction.\r\n"},"comment":{"url":"https://api.github.com/repos/leonjia0112/ec601_passenger_screening/issues/comments/351879679","html_url":"https://github.com/leonjia0112/ec601_passenger_screening/issues/4#issuecomment-351879679","issue_url":"https://api.github.com/repos/leonjia0112/ec601_passenger_screening/issues/4","id":351879679,"user":{"login":"gvikram31","id":31747838,"avatar_url":"https://avatars0.githubusercontent.com/u/31747838?v=4","gravatar_id":"","url":"https://api.github.com/users/gvikram31","html_url":"https://github.com/gvikram31","followers_url":"https://api.github.com/users/gvikram31/followers","following_url":"https://api.github.com/users/gvikram31/following{/other_user}","gists_url":"https://api.github.com/users/gvikram31/gists{/gist_id}","starred_url":"https://api.github.com/users/gvikram31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvikram31/subscriptions","organizations_url":"https://api.github.com/users/gvikram31/orgs","repos_url":"https://api.github.com/users/gvikram31/repos","events_url":"https://api.github.com/users/gvikram31/events{/privacy}","received_events_url":"https://api.github.com/users/gvikram31/received_events","type":"User","site_admin":false},"created_at":"2017-12-15T00:42:13Z","updated_at":"2017-12-15T00:42:13Z","author_association":"COLLABORATOR","body":"Hi Shengye,\r\n\r\nThank you so much for the detailed feedback. The team really appreciated it. "}}
{"actor":{"display_login":"gvikram31"}}