{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/124476461","pull_request_review_id":46766373,"id":124476461,"diff_hunk":"@@ -10,11 +10,33 @@ Finder\n ------\n \n  * The `Symfony\\Component\\Finder\\Iterator\\FilterIterator` class has been\n-   deprecated and will be removed in 4.0 as it used to fix a bug which existed \n+   deprecated and will be removed in 4.0 as it used to fix a bug which existed\n    before version 5.5.23/5.6.7.\n \n Validator\n ---------\n \n  * Not setting the `strict` option of the `Choice` constraint to `true` is\n    deprecated and will throw an exception in Symfony 4.0.\n+\n+Yaml\n+----\n+\n+ * using the `!php/object:` tag is deprecated and won't be supported in 4.0. Use\n+   the `!php/object` tag (without the colon) instead.\n+\n+ * using the `!php/const:` tag is deprecated and won't be supported in 4.0. Use\n+   the `!php/const` tag (without the colon) instead.\n+\n+   Before:\n+\n+   ```yml\n+   !php/const:PHP_INT_MAX\n+   ```\n+\n+   After:\n+\n+   ```yml\n+   !php/const PHP_INT_MAX\n+   ```\n+>>>>>>> [Yaml] Deprecate tags using colon","path":"UPGRADE-3.4.md","position":34,"original_position":34,"commit_id":"592eb389d1c10f37546536a37eefa955b062e242","original_commit_id":"592eb389d1c10f37546536a37eefa955b062e242","user":{"login":"stof","id":439401,"avatar_url":"https://avatars3.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"this line must be removed. You messed some conflict resolution","created_at":"2017-06-28T08:06:04Z","updated_at":"2017-06-28T08:09:38Z","html_url":"https://github.com/symfony/symfony/pull/22913#discussion_r124476461","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/22913","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/124476461"},"html":{"href":"https://github.com/symfony/symfony/pull/22913#discussion_r124476461"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22913"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/22913","id":122411991,"html_url":"https://github.com/symfony/symfony/pull/22913","diff_url":"https://github.com/symfony/symfony/pull/22913.diff","patch_url":"https://github.com/symfony/symfony/pull/22913.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/22913","number":22913,"state":"open","locked":false,"title":"[WIP][Yaml] Deprecate tags using colon","user":{"login":"GuilhemN","id":6871899,"avatar_url":"https://avatars2.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/GuilhemN","html_url":"https://github.com/GuilhemN","followers_url":"https://api.github.com/users/GuilhemN/followers","following_url":"https://api.github.com/users/GuilhemN/following{/other_user}","gists_url":"https://api.github.com/users/GuilhemN/gists{/gist_id}","starred_url":"https://api.github.com/users/GuilhemN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuilhemN/subscriptions","organizations_url":"https://api.github.com/users/GuilhemN/orgs","repos_url":"https://api.github.com/users/GuilhemN/repos","events_url":"https://api.github.com/users/GuilhemN/events{/privacy}","received_events_url":"https://api.github.com/users/GuilhemN/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.4\r\n| Bug fix?      | no\r\n| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | \r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nUsing a colon in a tag doesn't look like yaml and causes trouble (see https://github.com/symfony/symfony/pull/22878), so I propose to just deprecate these tags in favor of more consistent tags.\r\n\r\n```yml\r\n- !php/const:PHP_INT_MAX\r\n- !php/object:O:30:\"Symfony\\Component\\Yaml\\Tests\\A\":1:{s:1:\"a\";s:3:\"foo\";}\r\n```\r\nwould become\r\n```yml\r\n- !php/const PHP_INT_MAX\r\n- !php/object O:30:\"Symfony\\Component\\Yaml\\Tests\\A\":1:{s:1:\"a\";s:3:\"foo\";}\r\n```","created_at":"2017-05-25T10:23:18Z","updated_at":"2017-06-28T08:09:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f049822a344140028b8d3a0614fff76d584e368e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.4","description":"https://symfony.com/roadmap?version=3.4#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars0.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":151,"closed_issues":73,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2017-06-24T14:11:24Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/22913/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/22913/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/22913/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/592eb389d1c10f37546536a37eefa955b062e242","head":{"label":"GuilhemN:tagswithcomma","ref":"tagswithcomma","sha":"592eb389d1c10f37546536a37eefa955b062e242","user":{"login":"GuilhemN","id":6871899,"avatar_url":"https://avatars2.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/GuilhemN","html_url":"https://github.com/GuilhemN","followers_url":"https://api.github.com/users/GuilhemN/followers","following_url":"https://api.github.com/users/GuilhemN/following{/other_user}","gists_url":"https://api.github.com/users/GuilhemN/gists{/gist_id}","starred_url":"https://api.github.com/users/GuilhemN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuilhemN/subscriptions","organizations_url":"https://api.github.com/users/GuilhemN/orgs","repos_url":"https://api.github.com/users/GuilhemN/repos","events_url":"https://api.github.com/users/GuilhemN/events{/privacy}","received_events_url":"https://api.github.com/users/GuilhemN/received_events","type":"User","site_admin":false},"repo":{"id":47275948,"name":"symfony","full_name":"GuilhemN/symfony","owner":{"login":"GuilhemN","id":6871899,"avatar_url":"https://avatars2.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/GuilhemN","html_url":"https://github.com/GuilhemN","followers_url":"https://api.github.com/users/GuilhemN/followers","following_url":"https://api.github.com/users/GuilhemN/following{/other_user}","gists_url":"https://api.github.com/users/GuilhemN/gists{/gist_id}","starred_url":"https://api.github.com/users/GuilhemN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuilhemN/subscriptions","organizations_url":"https://api.github.com/users/GuilhemN/orgs","repos_url":"https://api.github.com/users/GuilhemN/repos","events_url":"https://api.github.com/users/GuilhemN/events{/privacy}","received_events_url":"https://api.github.com/users/GuilhemN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GuilhemN/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/GuilhemN/symfony","forks_url":"https://api.github.com/repos/GuilhemN/symfony/forks","keys_url":"https://api.github.com/repos/GuilhemN/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GuilhemN/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GuilhemN/symfony/teams","hooks_url":"https://api.github.com/repos/GuilhemN/symfony/hooks","issue_events_url":"https://api.github.com/repos/GuilhemN/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/GuilhemN/symfony/events","assignees_url":"https://api.github.com/repos/GuilhemN/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/GuilhemN/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/GuilhemN/symfony/tags","blobs_url":"https://api.github.com/repos/GuilhemN/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GuilhemN/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GuilhemN/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/GuilhemN/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GuilhemN/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/GuilhemN/symfony/languages","stargazers_url":"https://api.github.com/repos/GuilhemN/symfony/stargazers","contributors_url":"https://api.github.com/repos/GuilhemN/symfony/contributors","subscribers_url":"https://api.github.com/repos/GuilhemN/symfony/subscribers","subscription_url":"https://api.github.com/repos/GuilhemN/symfony/subscription","commits_url":"https://api.github.com/repos/GuilhemN/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/GuilhemN/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/GuilhemN/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/GuilhemN/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/GuilhemN/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/GuilhemN/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GuilhemN/symfony/merges","archive_url":"https://api.github.com/repos/GuilhemN/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GuilhemN/symfony/downloads","issues_url":"https://api.github.com/repos/GuilhemN/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/GuilhemN/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/GuilhemN/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/GuilhemN/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GuilhemN/symfony/labels{/name}","releases_url":"https://api.github.com/repos/GuilhemN/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/GuilhemN/symfony/deployments","created_at":"2015-12-02T17:11:04Z","updated_at":"2016-12-15T17:41:02Z","pushed_at":"2017-06-25T06:22:40Z","git_url":"git://github.com/GuilhemN/symfony.git","ssh_url":"git@github.com:GuilhemN/symfony.git","clone_url":"https://github.com/GuilhemN/symfony.git","svn_url":"https://github.com/GuilhemN/symfony","homepage":"symfony.com","size":94507,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"FQCN"}},"base":{"label":"symfony:3.4","ref":"3.4","sha":"0cfb574291c76d6c17b804c2bbd051a84a066cb1","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-06-28T05:52:58Z","pushed_at":"2017-06-28T07:24:11Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":98281,"stargazers_count":14727,"watchers_count":14727,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5576,"mirror_url":null,"open_issues_count":884,"forks":5576,"open_issues":884,"watchers":14727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22913"},"html":{"href":"https://github.com/symfony/symfony/pull/22913"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/22913"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/22913/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22913/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22913/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/592eb389d1c10f37546536a37eefa955b062e242"}}}}
{"actor":{"display_login":"stof"}}