{"action":"created","comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments/119984841","pull_request_review_id":41918474,"id":119984841,"diff_hunk":"@@ -15,7 +15,7 @@ defmodule Mix.Tasks.Phx.New.EctoTest do\n   test \"new without args\" do\n     in_tmp_umbrella_project \"new without args\", fn ->\n       assert capture_io(fn -> Mix.Tasks.Phx.New.Ecto.run([]) end) =~\n-             \"Creates a new Ecto project within an umbrella application.\"\n+             \"Creates a new Ecto project within an umbrella project.\"","path":"installer/test/phx_new_ecto_test.exs","position":5,"original_position":5,"commit_id":"bb827f8dbff2d061cc68519485119bdab80dfc9b","original_commit_id":"bb827f8dbff2d061cc68519485119bdab80dfc9b","user":{"login":"webdeb","id":14992140,"avatar_url":"https://avatars0.githubusercontent.com/u/14992140?v=3","gravatar_id":"","url":"https://api.github.com/users/webdeb","html_url":"https://github.com/webdeb","followers_url":"https://api.github.com/users/webdeb/followers","following_url":"https://api.github.com/users/webdeb/following{/other_user}","gists_url":"https://api.github.com/users/webdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/webdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdeb/subscriptions","organizations_url":"https://api.github.com/users/webdeb/orgs","repos_url":"https://api.github.com/users/webdeb/repos","events_url":"https://api.github.com/users/webdeb/events{/privacy}","received_events_url":"https://api.github.com/users/webdeb/received_events","type":"User","site_admin":false},"body":"-> Creates a new Ecto application within an umbrella project.","created_at":"2017-06-03T11:19:38Z","updated_at":"2017-06-03T11:19:39Z","html_url":"https://github.com/phoenixframework/phoenix/pull/2336#discussion_r119984841","pull_request_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336","_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments/119984841"},"html":{"href":"https://github.com/phoenixframework/phoenix/pull/2336#discussion_r119984841"},"pull_request":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336"}}},"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336","id":123752250,"html_url":"https://github.com/phoenixframework/phoenix/pull/2336","diff_url":"https://github.com/phoenixframework/phoenix/pull/2336.diff","patch_url":"https://github.com/phoenixframework/phoenix/pull/2336.patch","issue_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/2336","number":2336,"state":"open","locked":false,"title":"Replace 'umbrella application(s)' with 'umbrella project(s)'","user":{"login":"webdeb","id":14992140,"avatar_url":"https://avatars0.githubusercontent.com/u/14992140?v=3","gravatar_id":"","url":"https://api.github.com/users/webdeb","html_url":"https://github.com/webdeb","followers_url":"https://api.github.com/users/webdeb/followers","following_url":"https://api.github.com/users/webdeb/following{/other_user}","gists_url":"https://api.github.com/users/webdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/webdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdeb/subscriptions","organizations_url":"https://api.github.com/users/webdeb/orgs","repos_url":"https://api.github.com/users/webdeb/repos","events_url":"https://api.github.com/users/webdeb/events{/privacy}","received_events_url":"https://api.github.com/users/webdeb/received_events","type":"User","site_admin":false},"body":"Sometimes it's called `umbrella application`, sometimes `umbrella project`.\r\n\r\nIMHO, it doesn't really matter how its called, but it also makes sense to call umbrellas as projects, cause it feels natural for a project to have multiple apps, docs, marketing department other sub-projects.\r\n\r\nHowever, the main purpose of this PR is to avoid such fails ;)\r\n\r\nhttps://travis-ci.org/phoenixframework/phoenix/jobs/237944489#L344\r\n","created_at":"2017-06-02T16:16:56Z","updated_at":"2017-06-03T11:19:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f16323a40d990517a83a74e9e6f7c91736f439a7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336/commits","review_comments_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336/comments","review_comment_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/2336/comments","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix/statuses/bb827f8dbff2d061cc68519485119bdab80dfc9b","head":{"label":"webdeb:consolidate_umbrella_terms","ref":"consolidate_umbrella_terms","sha":"bb827f8dbff2d061cc68519485119bdab80dfc9b","user":{"login":"webdeb","id":14992140,"avatar_url":"https://avatars0.githubusercontent.com/u/14992140?v=3","gravatar_id":"","url":"https://api.github.com/users/webdeb","html_url":"https://github.com/webdeb","followers_url":"https://api.github.com/users/webdeb/followers","following_url":"https://api.github.com/users/webdeb/following{/other_user}","gists_url":"https://api.github.com/users/webdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/webdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdeb/subscriptions","organizations_url":"https://api.github.com/users/webdeb/orgs","repos_url":"https://api.github.com/users/webdeb/repos","events_url":"https://api.github.com/users/webdeb/events{/privacy}","received_events_url":"https://api.github.com/users/webdeb/received_events","type":"User","site_admin":false},"repo":{"id":89707440,"name":"phoenix","full_name":"webdeb/phoenix","owner":{"login":"webdeb","id":14992140,"avatar_url":"https://avatars0.githubusercontent.com/u/14992140?v=3","gravatar_id":"","url":"https://api.github.com/users/webdeb","html_url":"https://github.com/webdeb","followers_url":"https://api.github.com/users/webdeb/followers","following_url":"https://api.github.com/users/webdeb/following{/other_user}","gists_url":"https://api.github.com/users/webdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/webdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdeb/subscriptions","organizations_url":"https://api.github.com/users/webdeb/orgs","repos_url":"https://api.github.com/users/webdeb/repos","events_url":"https://api.github.com/users/webdeb/events{/privacy}","received_events_url":"https://api.github.com/users/webdeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/webdeb/phoenix","description":"Productive. Reliable. Fast.","fork":true,"url":"https://api.github.com/repos/webdeb/phoenix","forks_url":"https://api.github.com/repos/webdeb/phoenix/forks","keys_url":"https://api.github.com/repos/webdeb/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdeb/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdeb/phoenix/teams","hooks_url":"https://api.github.com/repos/webdeb/phoenix/hooks","issue_events_url":"https://api.github.com/repos/webdeb/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/webdeb/phoenix/events","assignees_url":"https://api.github.com/repos/webdeb/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/webdeb/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/webdeb/phoenix/tags","blobs_url":"https://api.github.com/repos/webdeb/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdeb/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdeb/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdeb/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdeb/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/webdeb/phoenix/languages","stargazers_url":"https://api.github.com/repos/webdeb/phoenix/stargazers","contributors_url":"https://api.github.com/repos/webdeb/phoenix/contributors","subscribers_url":"https://api.github.com/repos/webdeb/phoenix/subscribers","subscription_url":"https://api.github.com/repos/webdeb/phoenix/subscription","commits_url":"https://api.github.com/repos/webdeb/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdeb/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdeb/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdeb/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdeb/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/webdeb/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdeb/phoenix/merges","archive_url":"https://api.github.com/repos/webdeb/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdeb/phoenix/downloads","issues_url":"https://api.github.com/repos/webdeb/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/webdeb/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/webdeb/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/webdeb/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdeb/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/webdeb/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/webdeb/phoenix/deployments","created_at":"2017-04-28T13:14:08Z","updated_at":"2017-04-28T13:14:11Z","pushed_at":"2017-06-02T15:59:59Z","git_url":"git://github.com/webdeb/phoenix.git","ssh_url":"git@github.com:webdeb/phoenix.git","clone_url":"https://github.com/webdeb/phoenix.git","svn_url":"https://github.com/webdeb/phoenix","homepage":"http://www.phoenixframework.org","size":6276,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phoenixframework:master","ref":"master","sha":"98e3d80244ed69cc7144995031d6ed1414e2adda","user":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars1.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"repo":{"id":16072585,"name":"phoenix","full_name":"phoenixframework/phoenix","owner":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars1.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phoenixframework/phoenix","description":"Productive. Reliable. Fast.","fork":false,"url":"https://api.github.com/repos/phoenixframework/phoenix","forks_url":"https://api.github.com/repos/phoenixframework/phoenix/forks","keys_url":"https://api.github.com/repos/phoenixframework/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoenixframework/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoenixframework/phoenix/teams","hooks_url":"https://api.github.com/repos/phoenixframework/phoenix/hooks","issue_events_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/phoenixframework/phoenix/events","assignees_url":"https://api.github.com/repos/phoenixframework/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/phoenixframework/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/phoenixframework/phoenix/tags","blobs_url":"https://api.github.com/repos/phoenixframework/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoenixframework/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoenixframework/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoenixframework/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/phoenixframework/phoenix/languages","stargazers_url":"https://api.github.com/repos/phoenixframework/phoenix/stargazers","contributors_url":"https://api.github.com/repos/phoenixframework/phoenix/contributors","subscribers_url":"https://api.github.com/repos/phoenixframework/phoenix/subscribers","subscription_url":"https://api.github.com/repos/phoenixframework/phoenix/subscription","commits_url":"https://api.github.com/repos/phoenixframework/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoenixframework/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/phoenixframework/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/phoenixframework/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoenixframework/phoenix/merges","archive_url":"https://api.github.com/repos/phoenixframework/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoenixframework/phoenix/downloads","issues_url":"https://api.github.com/repos/phoenixframework/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/phoenixframework/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/phoenixframework/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoenixframework/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/phoenixframework/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/phoenixframework/phoenix/deployments","created_at":"2014-01-20T14:14:11Z","updated_at":"2017-06-03T03:56:48Z","pushed_at":"2017-06-02T16:16:57Z","git_url":"git://github.com/phoenixframework/phoenix.git","ssh_url":"git@github.com:phoenixframework/phoenix.git","clone_url":"https://github.com/phoenixframework/phoenix.git","svn_url":"https://github.com/phoenixframework/phoenix","homepage":"http://www.phoenixframework.org","size":6278,"stargazers_count":9655,"watchers_count":9655,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1146,"mirror_url":null,"open_issues_count":25,"forks":1146,"open_issues":25,"watchers":9655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336"},"html":{"href":"https://github.com/phoenixframework/phoenix/pull/2336"},"issue":{"href":"https://api.github.com/repos/phoenixframework/phoenix/issues/2336"},"comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix/issues/2336/comments"},"review_comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336/comments"},"review_comment":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/2336/commits"},"statuses":{"href":"https://api.github.com/repos/phoenixframework/phoenix/statuses/bb827f8dbff2d061cc68519485119bdab80dfc9b"}}}}
{"actor":{"display_login":"webdeb"}}