{"action":"closed","number":2547,"pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2547","id":154936476,"html_url":"https://github.com/jwplayer/jwplayer/pull/2547","diff_url":"https://github.com/jwplayer/jwplayer/pull/2547.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/2547.patch","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2547","number":2547,"state":"closed","locked":false,"title":"Synchronously reuse provider","user":{"login":"johnBartos","id":5042276,"avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"body":"### This PR will...\r\nSynchronously reuse a provider when able\r\n\r\n### Why is this Pull Request needed?\r\nTo avoid a race condition in Hlsjs and Shaka when initializing a provider after the first time. These providers may destroy and recreate their own video tag via the `remove()` method in the `video-actions-mixin`. This remove calls `stop()`, which sets the provider state to `IDLE`, which causes the `thenPlayPromise` to be cancelled. This cancellation results in subsequent items not autostarting when going to the next video.\r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\nDo you think this is a bandaid or a proper solution? We must have listeners attached before calling `init()`, which was my first solution. I'm not sure what side effects removing `stop()` from `remove()` would have. \r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\nNo\r\n\r\n#### Addresses Issue(s):\r\nJW8-893\r\n","created_at":"2017-11-27T22:46:48Z","updated_at":"2017-11-28T01:47:09Z","closed_at":"2017-11-28T01:47:09Z","merged_at":"2017-11-28T01:47:09Z","merge_commit_sha":"69bcd84fc3735994c4b9bb4ff31aa21815b564d8","assignee":{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"assignees":[{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/69","html_url":"https://github.com/jwplayer/jwplayer/milestone/69","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/69/labels","id":2862819,"number":69,"title":"v8.1.0","description":null,"creator":{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":9,"state":"open","created_at":"2017-10-24T17:00:28Z","updated_at":"2017-11-28T01:47:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2547/commits","review_comments_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2547/comments","review_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2547/comments","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/79cfc7a6f0345f9bd5cd206f904ab3c20c32e18e","head":{"label":"jwplayer:bugfix/synchronous-provider-reuse","ref":"bugfix/synchronous-provider-reuse","sha":"79cfc7a6f0345f9bd5cd206f904ab3c20c32e18e","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2017-11-28T00:52:31Z","pushed_at":"2017-11-28T01:47:08Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":83975,"stargazers_count":1462,"watchers_count":1462,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":634,"mirror_url":null,"archived":false,"open_issues_count":64,"forks":634,"open_issues":64,"watchers":1462,"default_branch":"master"}},"base":{"label":"jwplayer:master","ref":"master","sha":"3aa67b33788c37f2697e90c1f3f4fd71f0d8a5f1","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2017-11-28T00:52:31Z","pushed_at":"2017-11-28T01:47:08Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":83975,"stargazers_count":1462,"watchers_count":1462,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":634,"mirror_url":null,"archived":false,"open_issues_count":64,"forks":634,"open_issues":64,"watchers":1462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2547"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/2547"},"issue":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2547"},"comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2547/comments"},"review_comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2547/comments"},"review_comment":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2547/commits"},"statuses":{"href":"https://api.github.com/repos/jwplayer/jwplayer/statuses/79cfc7a6f0345f9bd5cd206f904ab3c20c32e18e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":10,"deletions":18,"changed_files":2}}
{"actor":{"display_login":"robwalch"}}