{"action":"created","issue":{"url":"https://api.github.com/repos/Yelp/paasta/issues/1246","repository_url":"https://api.github.com/repos/Yelp/paasta","labels_url":"https://api.github.com/repos/Yelp/paasta/issues/1246/labels{/name}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/1246/comments","events_url":"https://api.github.com/repos/Yelp/paasta/issues/1246/events","html_url":"https://github.com/Yelp/paasta/pull/1246","id":230497958,"number":1246,"title":"Add firewall-related keys to schema validation for Marathon and Chronos","user":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars0.githubusercontent.com/u/665269?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"labels":[{"id":295506239,"url":"https://api.github.com/repos/Yelp/paasta/labels/in%20review","name":"in review","color":"eac04b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-22T19:41:57Z","updated_at":"2017-05-22T20:19:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/1246","html_url":"https://github.com/Yelp/paasta/pull/1246","diff_url":"https://github.com/Yelp/paasta/pull/1246.diff","patch_url":"https://github.com/Yelp/paasta/pull/1246.patch"},"body":"Before:\r\n```\r\n$ /nail/sys/bin/paasta validate -y ~/proj/yelpsoa-configs -s example_happyhour\r\n✓ Successfully validated schema: marathon-STAGE.yaml\r\n✗ Failed to validate schema. More info: http://paasta.readthedocs.io/en/latest/yelpsoa_configs.html: /nail/home/ckuehl/proj/yelpsoa-configs/example_happyhour/marathon-mesosstage.yaml\r\n  Validation Message: Additional properties are not allowed ('security', 'dependencies_reference' were unexpected)\r\n✓ Successfully validated schema: marathon-DEV.yaml\r\n✓ Successfully validated schema: chronos-PROD.yaml\r\n✓ Successfully validated schema: adhoc-norcal-prod.yaml\r\n✓ Successfully validated schema: marathon-pnw-devc.yaml\r\n✓ Successfully validated schema: marathon-PROD.yaml\r\n✓ chronos-mesosstage.yaml has a valid instance: example_child_job.\r\n✓ chronos-mesosstage.yaml has a valid instance: example_chronos_job.\r\n\r\n```\r\n\r\nAfter:\r\n```\r\n$ .tox/py27/bin/paasta validate -y ~/proj/yelpsoa-configs -s example_happyhour\r\n✓ Successfully validated schema: marathon-STAGE.yaml\r\n✓ Successfully validated schema: marathon-mesosstage.yaml\r\n✓ Successfully validated schema: marathon-DEV.yaml\r\n✓ Successfully validated schema: chronos-PROD.yaml\r\n✓ Successfully validated schema: adhoc-norcal-prod.yaml\r\n✓ Successfully validated schema: marathon-pnw-devc.yaml\r\n✓ Successfully validated schema: marathon-PROD.yaml\r\n✓ chronos-mesosstage.yaml has a valid instance: example_child_job.\r\n✓ chronos-mesosstage.yaml has a valid instance: example_chronos_job.\r\n```"},"comment":{"url":"https://api.github.com/repos/Yelp/paasta/issues/comments/303209044","html_url":"https://github.com/Yelp/paasta/pull/1246#issuecomment-303209044","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/1246","id":303209044,"user":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars0.githubusercontent.com/u/665269?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"created_at":"2017-05-22T20:19:42Z","updated_at":"2017-05-22T20:19:42Z","body":"One thing -- I wasn't sure whether the key for dependencies was supposed to be `dependencies` (like in the CEP), or `dependencies_reference` (found elsewhere in the code)."}}
{"actor":{"display_login":"chriskuehl"}}