{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/link-hijacker/pulls/comments/135324655","pull_request_review_id":58729520,"id":135324655,"diff_hunk":"@@ -104,6 +104,13 @@ Type: `boolean`. Default: `false`.\n By default, links pointing to other origins (protocol + domain) are not hijacked.\n If this option is `true`, these links will still be hijacked.\n \n+##### skipFragment\n+\n+Type: `boolean`. Default: `false`.\n+\n+By default, links starting with fragments (e.g. `href=\"#foo\"`) are not hijacked.\n+If this option is `true`, these links will still be hijacked.","path":"README.md","position":9,"original_position":9,"commit_id":"1deaa0011c2a953b444d50058cc983c35daaf5be","original_commit_id":"1deaa0011c2a953b444d50058cc983c35daaf5be","user":{"login":"jfurrow","id":1134755,"avatar_url":"https://avatars3.githubusercontent.com/u/1134755?v=4","gravatar_id":"","url":"https://api.github.com/users/jfurrow","html_url":"https://github.com/jfurrow","followers_url":"https://api.github.com/users/jfurrow/followers","following_url":"https://api.github.com/users/jfurrow/following{/other_user}","gists_url":"https://api.github.com/users/jfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/jfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfurrow/subscriptions","organizations_url":"https://api.github.com/users/jfurrow/orgs","repos_url":"https://api.github.com/users/jfurrow/repos","events_url":"https://api.github.com/users/jfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/jfurrow/received_events","type":"User","site_admin":false},"body":"Oh I think the default is actually `true`, right?","created_at":"2017-08-25T18:28:55Z","updated_at":"2017-08-25T18:29:01Z","html_url":"https://github.com/mapbox/link-hijacker/pull/6#discussion_r135324655","pull_request_url":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/mapbox/link-hijacker/pulls/comments/135324655"},"html":{"href":"https://github.com/mapbox/link-hijacker/pull/6#discussion_r135324655"},"pull_request":{"href":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6"}},"in_reply_to_id":135324134},"pull_request":{"url":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6","id":137725332,"html_url":"https://github.com/mapbox/link-hijacker/pull/6","diff_url":"https://github.com/mapbox/link-hijacker/pull/6.diff","patch_url":"https://github.com/mapbox/link-hijacker/pull/6.patch","issue_url":"https://api.github.com/repos/mapbox/link-hijacker/issues/6","number":6,"state":"open","locked":false,"title":"Add skipFragment option","user":{"login":"davidtheclark","id":628431,"avatar_url":"https://avatars2.githubusercontent.com/u/628431?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtheclark","html_url":"https://github.com/davidtheclark","followers_url":"https://api.github.com/users/davidtheclark/followers","following_url":"https://api.github.com/users/davidtheclark/following{/other_user}","gists_url":"https://api.github.com/users/davidtheclark/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtheclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtheclark/subscriptions","organizations_url":"https://api.github.com/users/davidtheclark/orgs","repos_url":"https://api.github.com/users/davidtheclark/repos","events_url":"https://api.github.com/users/davidtheclark/events{/privacy}","received_events_url":"https://api.github.com/users/davidtheclark/received_events","type":"User","site_admin":false},"body":"This is a breaking change, because fragments are no longer hijacked by default.\r\n\r\nRelates to https://github.com/mapbox/batfish/issues/144\r\n\r\n@jfurrow for review.","created_at":"2017-08-25T17:54:50Z","updated_at":"2017-08-25T18:29:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9220d36ee33ce2a2b9fc19ebcc9d7d5c3c42078d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6/commits","review_comments_url":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6/comments","review_comment_url":"https://api.github.com/repos/mapbox/link-hijacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/link-hijacker/issues/6/comments","statuses_url":"https://api.github.com/repos/mapbox/link-hijacker/statuses/1deaa0011c2a953b444d50058cc983c35daaf5be","head":{"label":"mapbox:skip-fragments","ref":"skip-fragments","sha":"1deaa0011c2a953b444d50058cc983c35daaf5be","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":95389112,"name":"link-hijacker","full_name":"mapbox/link-hijacker","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/link-hijacker","description":"Hijack clicks on and within links, probably for client-side routing","fork":false,"url":"https://api.github.com/repos/mapbox/link-hijacker","forks_url":"https://api.github.com/repos/mapbox/link-hijacker/forks","keys_url":"https://api.github.com/repos/mapbox/link-hijacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/link-hijacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/link-hijacker/teams","hooks_url":"https://api.github.com/repos/mapbox/link-hijacker/hooks","issue_events_url":"https://api.github.com/repos/mapbox/link-hijacker/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/link-hijacker/events","assignees_url":"https://api.github.com/repos/mapbox/link-hijacker/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/link-hijacker/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/link-hijacker/tags","blobs_url":"https://api.github.com/repos/mapbox/link-hijacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/link-hijacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/link-hijacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/link-hijacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/link-hijacker/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/link-hijacker/languages","stargazers_url":"https://api.github.com/repos/mapbox/link-hijacker/stargazers","contributors_url":"https://api.github.com/repos/mapbox/link-hijacker/contributors","subscribers_url":"https://api.github.com/repos/mapbox/link-hijacker/subscribers","subscription_url":"https://api.github.com/repos/mapbox/link-hijacker/subscription","commits_url":"https://api.github.com/repos/mapbox/link-hijacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/link-hijacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/link-hijacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/link-hijacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/link-hijacker/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/link-hijacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/link-hijacker/merges","archive_url":"https://api.github.com/repos/mapbox/link-hijacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/link-hijacker/downloads","issues_url":"https://api.github.com/repos/mapbox/link-hijacker/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/link-hijacker/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/link-hijacker/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/link-hijacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/link-hijacker/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/link-hijacker/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/link-hijacker/deployments","created_at":"2017-06-25T22:25:30Z","updated_at":"2017-08-25T12:00:03Z","pushed_at":"2017-08-25T17:54:51Z","git_url":"git://github.com/mapbox/link-hijacker.git","ssh_url":"git@github.com:mapbox/link-hijacker.git","clone_url":"https://github.com/mapbox/link-hijacker.git","svn_url":"https://github.com/mapbox/link-hijacker","homepage":null,"size":103,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":26,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"770a5a08892a93d2cf1dd005bb19762a5b5632e8","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":95389112,"name":"link-hijacker","full_name":"mapbox/link-hijacker","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/link-hijacker","description":"Hijack clicks on and within links, probably for client-side routing","fork":false,"url":"https://api.github.com/repos/mapbox/link-hijacker","forks_url":"https://api.github.com/repos/mapbox/link-hijacker/forks","keys_url":"https://api.github.com/repos/mapbox/link-hijacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/link-hijacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/link-hijacker/teams","hooks_url":"https://api.github.com/repos/mapbox/link-hijacker/hooks","issue_events_url":"https://api.github.com/repos/mapbox/link-hijacker/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/link-hijacker/events","assignees_url":"https://api.github.com/repos/mapbox/link-hijacker/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/link-hijacker/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/link-hijacker/tags","blobs_url":"https://api.github.com/repos/mapbox/link-hijacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/link-hijacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/link-hijacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/link-hijacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/link-hijacker/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/link-hijacker/languages","stargazers_url":"https://api.github.com/repos/mapbox/link-hijacker/stargazers","contributors_url":"https://api.github.com/repos/mapbox/link-hijacker/contributors","subscribers_url":"https://api.github.com/repos/mapbox/link-hijacker/subscribers","subscription_url":"https://api.github.com/repos/mapbox/link-hijacker/subscription","commits_url":"https://api.github.com/repos/mapbox/link-hijacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/link-hijacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/link-hijacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/link-hijacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/link-hijacker/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/link-hijacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/link-hijacker/merges","archive_url":"https://api.github.com/repos/mapbox/link-hijacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/link-hijacker/downloads","issues_url":"https://api.github.com/repos/mapbox/link-hijacker/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/link-hijacker/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/link-hijacker/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/link-hijacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/link-hijacker/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/link-hijacker/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/link-hijacker/deployments","created_at":"2017-06-25T22:25:30Z","updated_at":"2017-08-25T12:00:03Z","pushed_at":"2017-08-25T17:54:51Z","git_url":"git://github.com/mapbox/link-hijacker.git","ssh_url":"git@github.com:mapbox/link-hijacker.git","clone_url":"https://github.com/mapbox/link-hijacker.git","svn_url":"https://github.com/mapbox/link-hijacker","homepage":null,"size":103,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6"},"html":{"href":"https://github.com/mapbox/link-hijacker/pull/6"},"issue":{"href":"https://api.github.com/repos/mapbox/link-hijacker/issues/6"},"comments":{"href":"https://api.github.com/repos/mapbox/link-hijacker/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/link-hijacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/link-hijacker/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/link-hijacker/statuses/1deaa0011c2a953b444d50058cc983c35daaf5be"}}}}
{"actor":{"display_login":"jfurrow"}}