{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20639","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20639/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20639/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20639/events","html_url":"https://github.com/Automattic/wp-calypso/pull/20639","id":280516535,"number":20639,"title":"Signup: Update DesignTypeWithAtomicStoreStep to use TileGrid","user":{"login":"tyxla","id":8436925,"avatar_url":"https://avatars2.githubusercontent.com/u/8436925?v=4","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"labels":[{"id":285010049,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Signup","name":"Signup","color":"006b75","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":285010109,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Janitorial","name":"[Type] Janitorial","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":{"login":"tyxla","id":8436925,"avatar_url":"https://avatars2.githubusercontent.com/u/8436925?v=4","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false},"assignees":[{"login":"tyxla","id":8436925,"avatar_url":"https://avatars2.githubusercontent.com/u/8436925?v=4","gravatar_id":"","url":"https://api.github.com/users/tyxla","html_url":"https://github.com/tyxla","followers_url":"https://api.github.com/users/tyxla/followers","following_url":"https://api.github.com/users/tyxla/following{/other_user}","gists_url":"https://api.github.com/users/tyxla/gists{/gist_id}","starred_url":"https://api.github.com/users/tyxla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyxla/subscriptions","organizations_url":"https://api.github.com/users/tyxla/orgs","repos_url":"https://api.github.com/users/tyxla/repos","events_url":"https://api.github.com/users/tyxla/events{/privacy}","received_events_url":"https://api.github.com/users/tyxla/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-12-08T15:02:10Z","updated_at":"2017-12-13T21:18:15Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20639","html_url":"https://github.com/Automattic/wp-calypso/pull/20639","diff_url":"https://github.com/Automattic/wp-calypso/pull/20639.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/20639.patch"},"body":"This PR updates `DesignTypeWithAtomicStoreStep` to use the `TileGrid` component family for displaying all the tiles. It also reuses some classes from `DesignTypeWithStoreStep` - we can later move these to a more common location, so they can be reused. \r\n\r\nA change that's worth mentioning is that it will now rely on `this.state.showStore` directly for showing/hiding the atomic store, vs. unnecessarily using a className for that.\r\n\r\nThis allows to save a bunch of CSS and markup that we're reusing in other design type steps in Signup and Jetpack Onboarding. Can be followed by a couple more cleanup PRs after merging.\r\n\r\nContains #20640, which fixes a small visual bug with card link indicators on mobile devices.\r\n\r\nTo test:\r\n* Checkout this branch\r\n* Go to http://calypso.localhost:3000/start/design-type-with-store-nux\r\n* Try both different variants of the `signupAtomicStoreVsPressable` AB test.\r\n* Verify there are no visual/functional differences when comparing to production.\r\n* Verify the step works like it did before."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/351527874","html_url":"https://github.com/Automattic/wp-calypso/pull/20639#issuecomment-351527874","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20639","id":351527874,"user":{"login":"sirreal","id":841763,"avatar_url":"https://avatars2.githubusercontent.com/u/841763?v=4","gravatar_id":"","url":"https://api.github.com/users/sirreal","html_url":"https://github.com/sirreal","followers_url":"https://api.github.com/users/sirreal/followers","following_url":"https://api.github.com/users/sirreal/following{/other_user}","gists_url":"https://api.github.com/users/sirreal/gists{/gist_id}","starred_url":"https://api.github.com/users/sirreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirreal/subscriptions","organizations_url":"https://api.github.com/users/sirreal/orgs","repos_url":"https://api.github.com/users/sirreal/repos","events_url":"https://api.github.com/users/sirreal/events{/privacy}","received_events_url":"https://api.github.com/users/sirreal/received_events","type":"User","site_admin":false},"created_at":"2017-12-13T21:18:15Z","updated_at":"2017-12-13T21:18:15Z","author_association":"CONTRIBUTOR","body":"I tested this and it seems to work well now. I'll give it a thorough review and look the code over tomorrow."}}
{"actor":{"display_login":"sirreal"}}