{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/95545574","pull_request_review_id":16102235,"id":95545574,"diff_hunk":"@@ -296,6 +296,30 @@ public function testBuildsNewNamespacedCacheInstancePerRegionInstance()\n         $this->assertSame('bar', $barRegion->getCache()->getNamespace());\n     }\n \n+    public function testAppendsNamespacedCacheInstancePerRegionInstanceWhenItsAlreadySet()\n+    {\n+        $cache = clone $this->getSharedSecondLevelCacheDriverImpl();\n+        $cache->setNamespace('testing');\n+\n+        $factory = new DefaultCacheFactory($this->regionsConfig, $cache);\n+\n+        $fooRegion = $factory->getRegion(\n+            [\n+            'region' => 'foo',\n+            'usage'  => ClassMetadata::CACHE_USAGE_READ_ONLY,\n+            ]\n+        );\n+        $barRegion = $factory->getRegion(\n+            [\n+            'region' => 'bar',\n+            'usage'  => ClassMetadata::CACHE_USAGE_READ_ONLY,\n+            ]\n+        );\n+\n+        $this->assertSame('testing:foo', $fooRegion->getCache()->getNamespace());\n+        $this->assertSame('testing:bar', $barRegion->getCache()->getNamespace());","path":"tests/Doctrine/Tests/ORM/Cache/DefaultCacheFactoryTest.php","position":25,"original_position":25,"commit_id":"a72278506a126cc9aa76b7ccaa2e9d07eba477ac","original_commit_id":"a72278506a126cc9aa76b7ccaa2e9d07eba477ac","user":{"login":"lcobucci","id":201963,"avatar_url":"https://avatars.githubusercontent.com/u/201963?v=3","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"body":"Yes, on `DefaultCacheFactoryTest#testBuildsNewNamespacedCacheInstancePerRegionInstance`","created_at":"2017-01-11T09:59:03Z","updated_at":"2017-01-11T09:59:03Z","html_url":"https://github.com/doctrine/doctrine2/pull/6223#discussion_r95545574","pull_request_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223","_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/95545574"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/6223#discussion_r95545574"},"pull_request":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223","id":101032199,"html_url":"https://github.com/doctrine/doctrine2/pull/6223","diff_url":"https://github.com/doctrine/doctrine2/pull/6223.diff","patch_url":"https://github.com/doctrine/doctrine2/pull/6223.patch","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/6223","number":6223,"state":"open","locked":false,"title":"Appends cache namespace when it exists (for L2C regions)","user":{"login":"lcobucci","id":201963,"avatar_url":"https://avatars.githubusercontent.com/u/201963?v=3","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"body":"We're overriding the namespace without even checking if it was previously set, what causes problems when people uses that feature :wink:","created_at":"2017-01-11T09:43:39Z","updated_at":"2017-01-11T09:59:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f95fb60b9fe9af36fd4396f83fe36431dbef482","assignee":{"login":"lcobucci","id":201963,"avatar_url":"https://avatars.githubusercontent.com/u/201963?v=3","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"assignees":[{"login":"lcobucci","id":201963,"avatar_url":"https://avatars.githubusercontent.com/u/201963?v=3","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/doctrine/doctrine2/milestones/2","html_url":"https://github.com/doctrine/doctrine2/milestone/2","labels_url":"https://api.github.com/repos/doctrine/doctrine2/milestones/2/labels","id":1446273,"number":2,"title":"2.6.0","description":null,"creator":{"login":"beberlei","id":26936,"avatar_url":"https://avatars.githubusercontent.com/u/26936?v=3","gravatar_id":"","url":"https://api.github.com/users/beberlei","html_url":"https://github.com/beberlei","followers_url":"https://api.github.com/users/beberlei/followers","following_url":"https://api.github.com/users/beberlei/following{/other_user}","gists_url":"https://api.github.com/users/beberlei/gists{/gist_id}","starred_url":"https://api.github.com/users/beberlei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beberlei/subscriptions","organizations_url":"https://api.github.com/users/beberlei/orgs","repos_url":"https://api.github.com/users/beberlei/repos","events_url":"https://api.github.com/users/beberlei/events{/privacy}","received_events_url":"https://api.github.com/users/beberlei/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":202,"state":"open","created_at":"2015-12-06T13:20:23Z","updated_at":"2017-01-11T09:44:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223/commits","review_comments_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223/comments","review_comment_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/6223/comments","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/a72278506a126cc9aa76b7ccaa2e9d07eba477ac","head":{"label":"lcobucci:fix-l2c-region-namespace","ref":"fix-l2c-region-namespace","sha":"a72278506a126cc9aa76b7ccaa2e9d07eba477ac","user":{"login":"lcobucci","id":201963,"avatar_url":"https://avatars.githubusercontent.com/u/201963?v=3","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"repo":{"id":15046868,"name":"doctrine2","full_name":"lcobucci/doctrine2","owner":{"login":"lcobucci","id":201963,"avatar_url":"https://avatars.githubusercontent.com/u/201963?v=3","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lcobucci/doctrine2","description":"Doctrine 2 Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/lcobucci/doctrine2","forks_url":"https://api.github.com/repos/lcobucci/doctrine2/forks","keys_url":"https://api.github.com/repos/lcobucci/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcobucci/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcobucci/doctrine2/teams","hooks_url":"https://api.github.com/repos/lcobucci/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/lcobucci/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/lcobucci/doctrine2/events","assignees_url":"https://api.github.com/repos/lcobucci/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/lcobucci/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/lcobucci/doctrine2/tags","blobs_url":"https://api.github.com/repos/lcobucci/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcobucci/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcobucci/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcobucci/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcobucci/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/lcobucci/doctrine2/languages","stargazers_url":"https://api.github.com/repos/lcobucci/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/lcobucci/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/lcobucci/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/lcobucci/doctrine2/subscription","commits_url":"https://api.github.com/repos/lcobucci/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcobucci/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcobucci/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcobucci/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcobucci/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/lcobucci/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcobucci/doctrine2/merges","archive_url":"https://api.github.com/repos/lcobucci/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcobucci/doctrine2/downloads","issues_url":"https://api.github.com/repos/lcobucci/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/lcobucci/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/lcobucci/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/lcobucci/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcobucci/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/lcobucci/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/lcobucci/doctrine2/deployments","created_at":"2013-12-09T12:37:41Z","updated_at":"2015-02-04T18:45:26Z","pushed_at":"2017-01-11T09:45:38Z","git_url":"git://github.com/lcobucci/doctrine2.git","ssh_url":"git@github.com:lcobucci/doctrine2.git","clone_url":"https://github.com/lcobucci/doctrine2.git","svn_url":"https://github.com/lcobucci/doctrine2","homepage":"http://www.doctrine-project.org","size":28216,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"4e573038be1ab697ce9e8ec03dc221a0a8b9f0c8","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":597887,"name":"doctrine2","full_name":"doctrine/doctrine2","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":false,"url":"https://api.github.com/repos/doctrine/doctrine2","forks_url":"https://api.github.com/repos/doctrine/doctrine2/forks","keys_url":"https://api.github.com/repos/doctrine/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/doctrine2/teams","hooks_url":"https://api.github.com/repos/doctrine/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/doctrine2/events","assignees_url":"https://api.github.com/repos/doctrine/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/doctrine2/tags","blobs_url":"https://api.github.com/repos/doctrine/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/doctrine2/languages","stargazers_url":"https://api.github.com/repos/doctrine/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/doctrine/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/doctrine/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/doctrine/doctrine2/subscription","commits_url":"https://api.github.com/repos/doctrine/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/doctrine2/merges","archive_url":"https://api.github.com/repos/doctrine/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/doctrine2/downloads","issues_url":"https://api.github.com/repos/doctrine/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/doctrine2/deployments","created_at":"2010-04-06T21:42:59Z","updated_at":"2017-01-10T16:31:24Z","pushed_at":"2017-01-11T09:45:40Z","git_url":"git://github.com/doctrine/doctrine2.git","ssh_url":"git@github.com:doctrine/doctrine2.git","clone_url":"https://github.com/doctrine/doctrine2.git","svn_url":"https://github.com/doctrine/doctrine2","homepage":"http://www.doctrine-project.org","size":30159,"stargazers_count":3409,"watchers_count":3409,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1647,"mirror_url":null,"open_issues_count":1113,"forks":1647,"open_issues":1113,"watchers":3409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/6223"},"issue":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/6223"},"comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/6223/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6223/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/doctrine2/statuses/a72278506a126cc9aa76b7ccaa2e9d07eba477ac"}}}}
{"actor":{"display_login":"lcobucci"}}