{"action":"created","comment":{"url":"https://api.github.com/repos/coala/coala-quickstart/pulls/comments/130213674","pull_request_review_id":53069249,"id":130213674,"diff_hunk":"@@ -61,7 +61,7 @@ def generate_ignore_field(project_dir, languages, extset, ignore_globs):\n     for glob in ignore_globs:\n         gitignore_files = {file\n                            for file in collect_files([glob], null_printer)}\n-        if not all_files.isdisjoint(gitignore_files):\n+        if all_files.isdisjoint(gitignore_files):","path":"coala_quickstart/generation/Settings.py","position":5,"original_position":5,"commit_id":"614598959e007d659454025cc22ccf03f4b85714","original_commit_id":"614598959e007d659454025cc22ccf03f4b85714","user":{"login":"hemangsk","id":13018570,"avatar_url":"https://avatars3.githubusercontent.com/u/13018570?v=4","gravatar_id":"","url":"https://api.github.com/users/hemangsk","html_url":"https://github.com/hemangsk","followers_url":"https://api.github.com/users/hemangsk/followers","following_url":"https://api.github.com/users/hemangsk/following{/other_user}","gists_url":"https://api.github.com/users/hemangsk/gists{/gist_id}","starred_url":"https://api.github.com/users/hemangsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemangsk/subscriptions","organizations_url":"https://api.github.com/users/hemangsk/orgs","repos_url":"https://api.github.com/users/hemangsk/repos","events_url":"https://api.github.com/users/hemangsk/events{/privacy}","received_events_url":"https://api.github.com/users/hemangsk/received_events","type":"User","site_admin":false},"body":"Yeah, that's really confusing to me as well. But won't all_files will always be disjoint from gitignore_files due to this https://github.com/hemangsk/coala-quickstart/blob/614598959e007d659454025cc22ccf03f4b85714/coala_quickstart/generation/Settings.py#L58","created_at":"2017-07-29T04:57:38Z","updated_at":"2017-07-29T04:57:38Z","html_url":"https://github.com/coala/coala-quickstart/pull/156#discussion_r130213674","pull_request_url":"https://api.github.com/repos/coala/coala-quickstart/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/coala/coala-quickstart/pulls/comments/130213674"},"html":{"href":"https://github.com/coala/coala-quickstart/pull/156#discussion_r130213674"},"pull_request":{"href":"https://api.github.com/repos/coala/coala-quickstart/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/coala/coala-quickstart/pulls/156","id":133039127,"html_url":"https://github.com/coala/coala-quickstart/pull/156","diff_url":"https://github.com/coala/coala-quickstart/pull/156.diff","patch_url":"https://github.com/coala/coala-quickstart/pull/156.patch","issue_url":"https://api.github.com/repos/coala/coala-quickstart/issues/156","number":156,"state":"open","locked":false,"title":"Settings.py: Use all instead of default section","user":{"login":"hemangsk","id":13018570,"avatar_url":"https://avatars3.githubusercontent.com/u/13018570?v=4","gravatar_id":"","url":"https://api.github.com/users/hemangsk","html_url":"https://github.com/hemangsk","followers_url":"https://api.github.com/users/hemangsk/followers","following_url":"https://api.github.com/users/hemangsk/following{/other_user}","gists_url":"https://api.github.com/users/hemangsk/gists{/gist_id}","starred_url":"https://api.github.com/users/hemangsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemangsk/subscriptions","organizations_url":"https://api.github.com/users/hemangsk/orgs","repos_url":"https://api.github.com/users/hemangsk/repos","events_url":"https://api.github.com/users/hemangsk/events{/privacy}","received_events_url":"https://api.github.com/users/hemangsk/received_events","type":"User","site_admin":false},"body":"Commit authored by Lasse Schuirmann (sils)\r\n\r\nCloses https://github.com/coala/coala-quickstart/issues/127\r\n\r\n(Continues https://github.com/coala/coala-quickstart/pull/142)","created_at":"2017-07-28T19:45:00Z","updated_at":"2017-07-29T04:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca607525f862ca8629c85d23a608f8922167197e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coala/coala-quickstart/pulls/156/commits","review_comments_url":"https://api.github.com/repos/coala/coala-quickstart/pulls/156/comments","review_comment_url":"https://api.github.com/repos/coala/coala-quickstart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/coala-quickstart/issues/156/comments","statuses_url":"https://api.github.com/repos/coala/coala-quickstart/statuses/614598959e007d659454025cc22ccf03f4b85714","head":{"label":"hemangsk:hemangsk/cq","ref":"hemangsk/cq","sha":"614598959e007d659454025cc22ccf03f4b85714","user":{"login":"hemangsk","id":13018570,"avatar_url":"https://avatars3.githubusercontent.com/u/13018570?v=4","gravatar_id":"","url":"https://api.github.com/users/hemangsk","html_url":"https://github.com/hemangsk","followers_url":"https://api.github.com/users/hemangsk/followers","following_url":"https://api.github.com/users/hemangsk/following{/other_user}","gists_url":"https://api.github.com/users/hemangsk/gists{/gist_id}","starred_url":"https://api.github.com/users/hemangsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemangsk/subscriptions","organizations_url":"https://api.github.com/users/hemangsk/orgs","repos_url":"https://api.github.com/users/hemangsk/repos","events_url":"https://api.github.com/users/hemangsk/events{/privacy}","received_events_url":"https://api.github.com/users/hemangsk/received_events","type":"User","site_admin":false},"repo":{"id":76172597,"name":"coala-quickstart","full_name":"hemangsk/coala-quickstart","owner":{"login":"hemangsk","id":13018570,"avatar_url":"https://avatars3.githubusercontent.com/u/13018570?v=4","gravatar_id":"","url":"https://api.github.com/users/hemangsk","html_url":"https://github.com/hemangsk","followers_url":"https://api.github.com/users/hemangsk/followers","following_url":"https://api.github.com/users/hemangsk/following{/other_user}","gists_url":"https://api.github.com/users/hemangsk/gists{/gist_id}","starred_url":"https://api.github.com/users/hemangsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemangsk/subscriptions","organizations_url":"https://api.github.com/users/hemangsk/orgs","repos_url":"https://api.github.com/users/hemangsk/repos","events_url":"https://api.github.com/users/hemangsk/events{/privacy}","received_events_url":"https://api.github.com/users/hemangsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hemangsk/coala-quickstart","description":"A binary that generates an initial coala config lightning fast for you!","fork":true,"url":"https://api.github.com/repos/hemangsk/coala-quickstart","forks_url":"https://api.github.com/repos/hemangsk/coala-quickstart/forks","keys_url":"https://api.github.com/repos/hemangsk/coala-quickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hemangsk/coala-quickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hemangsk/coala-quickstart/teams","hooks_url":"https://api.github.com/repos/hemangsk/coala-quickstart/hooks","issue_events_url":"https://api.github.com/repos/hemangsk/coala-quickstart/issues/events{/number}","events_url":"https://api.github.com/repos/hemangsk/coala-quickstart/events","assignees_url":"https://api.github.com/repos/hemangsk/coala-quickstart/assignees{/user}","branches_url":"https://api.github.com/repos/hemangsk/coala-quickstart/branches{/branch}","tags_url":"https://api.github.com/repos/hemangsk/coala-quickstart/tags","blobs_url":"https://api.github.com/repos/hemangsk/coala-quickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hemangsk/coala-quickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hemangsk/coala-quickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/hemangsk/coala-quickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hemangsk/coala-quickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/hemangsk/coala-quickstart/languages","stargazers_url":"https://api.github.com/repos/hemangsk/coala-quickstart/stargazers","contributors_url":"https://api.github.com/repos/hemangsk/coala-quickstart/contributors","subscribers_url":"https://api.github.com/repos/hemangsk/coala-quickstart/subscribers","subscription_url":"https://api.github.com/repos/hemangsk/coala-quickstart/subscription","commits_url":"https://api.github.com/repos/hemangsk/coala-quickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/hemangsk/coala-quickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/hemangsk/coala-quickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/hemangsk/coala-quickstart/issues/comments{/number}","contents_url":"https://api.github.com/repos/hemangsk/coala-quickstart/contents/{+path}","compare_url":"https://api.github.com/repos/hemangsk/coala-quickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hemangsk/coala-quickstart/merges","archive_url":"https://api.github.com/repos/hemangsk/coala-quickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hemangsk/coala-quickstart/downloads","issues_url":"https://api.github.com/repos/hemangsk/coala-quickstart/issues{/number}","pulls_url":"https://api.github.com/repos/hemangsk/coala-quickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/hemangsk/coala-quickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/hemangsk/coala-quickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hemangsk/coala-quickstart/labels{/name}","releases_url":"https://api.github.com/repos/hemangsk/coala-quickstart/releases{/id}","deployments_url":"https://api.github.com/repos/hemangsk/coala-quickstart/deployments","created_at":"2016-12-11T12:20:44Z","updated_at":"2016-12-11T12:20:45Z","pushed_at":"2017-07-29T02:37:26Z","git_url":"git://github.com/hemangsk/coala-quickstart.git","ssh_url":"git@github.com:hemangsk/coala-quickstart.git","clone_url":"https://github.com/hemangsk/coala-quickstart.git","svn_url":"https://github.com/hemangsk/coala-quickstart","homepage":"","size":129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"02369a9c5e387f480564e765a917cc56815c7a52","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":52889504,"name":"coala-quickstart","full_name":"coala/coala-quickstart","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/coala-quickstart","description":"A tool that generates an initial coala config lightning fast for you!","fork":false,"url":"https://api.github.com/repos/coala/coala-quickstart","forks_url":"https://api.github.com/repos/coala/coala-quickstart/forks","keys_url":"https://api.github.com/repos/coala/coala-quickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala-quickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala-quickstart/teams","hooks_url":"https://api.github.com/repos/coala/coala-quickstart/hooks","issue_events_url":"https://api.github.com/repos/coala/coala-quickstart/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala-quickstart/events","assignees_url":"https://api.github.com/repos/coala/coala-quickstart/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala-quickstart/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala-quickstart/tags","blobs_url":"https://api.github.com/repos/coala/coala-quickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala-quickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala-quickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala-quickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala-quickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala-quickstart/languages","stargazers_url":"https://api.github.com/repos/coala/coala-quickstart/stargazers","contributors_url":"https://api.github.com/repos/coala/coala-quickstart/contributors","subscribers_url":"https://api.github.com/repos/coala/coala-quickstart/subscribers","subscription_url":"https://api.github.com/repos/coala/coala-quickstart/subscription","commits_url":"https://api.github.com/repos/coala/coala-quickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala-quickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala-quickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala-quickstart/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala-quickstart/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala-quickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala-quickstart/merges","archive_url":"https://api.github.com/repos/coala/coala-quickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala-quickstart/downloads","issues_url":"https://api.github.com/repos/coala/coala-quickstart/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala-quickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala-quickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala-quickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala-quickstart/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala-quickstart/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala-quickstart/deployments","created_at":"2016-03-01T15:55:10Z","updated_at":"2017-07-04T12:54:37Z","pushed_at":"2017-07-29T02:37:28Z","git_url":"git://github.com/coala/coala-quickstart.git","ssh_url":"git@github.com:coala/coala-quickstart.git","clone_url":"https://github.com/coala/coala-quickstart.git","svn_url":"https://github.com/coala/coala-quickstart","homepage":"","size":131,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":60,"forks":24,"open_issues":60,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/coala-quickstart/pulls/156"},"html":{"href":"https://github.com/coala/coala-quickstart/pull/156"},"issue":{"href":"https://api.github.com/repos/coala/coala-quickstart/issues/156"},"comments":{"href":"https://api.github.com/repos/coala/coala-quickstart/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/coala-quickstart/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/coala-quickstart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/coala-quickstart/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/coala/coala-quickstart/statuses/614598959e007d659454025cc22ccf03f4b85714"}}}}
{"actor":{"display_login":"hemangsk"}}