{"action":"created","issue":{"url":"https://api.github.com/repos/baaraban/ZimbaBoom/issues/4","repository_url":"https://api.github.com/repos/baaraban/ZimbaBoom","labels_url":"https://api.github.com/repos/baaraban/ZimbaBoom/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/baaraban/ZimbaBoom/issues/4/comments","events_url":"https://api.github.com/repos/baaraban/ZimbaBoom/issues/4/events","html_url":"https://github.com/baaraban/ZimbaBoom/pull/4","id":267482026,"number":4,"title":"Add basic stuff for farmscaling","user":{"login":"baaraban","id":32392094,"avatar_url":"https://avatars0.githubusercontent.com/u/32392094?v=4","gravatar_id":"","url":"https://api.github.com/users/baaraban","html_url":"https://github.com/baaraban","followers_url":"https://api.github.com/users/baaraban/followers","following_url":"https://api.github.com/users/baaraban/following{/other_user}","gists_url":"https://api.github.com/users/baaraban/gists{/gist_id}","starred_url":"https://api.github.com/users/baaraban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baaraban/subscriptions","organizations_url":"https://api.github.com/users/baaraban/orgs","repos_url":"https://api.github.com/users/baaraban/repos","events_url":"https://api.github.com/users/baaraban/events{/privacy}","received_events_url":"https://api.github.com/users/baaraban/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-22T17:17:19Z","updated_at":"2017-10-23T08:23:17Z","closed_at":"2017-10-22T17:40:15Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/baaraban/ZimbaBoom/pulls/4","html_url":"https://github.com/baaraban/ZimbaBoom/pull/4","diff_url":"https://github.com/baaraban/ZimbaBoom/pull/4.diff","patch_url":"https://github.com/baaraban/ZimbaBoom/pull/4.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/baaraban/ZimbaBoom/issues/comments/338583703","html_url":"https://github.com/baaraban/ZimbaBoom/pull/4#issuecomment-338583703","issue_url":"https://api.github.com/repos/baaraban/ZimbaBoom/issues/4","id":338583703,"user":{"login":"mykhaly","id":13147752,"avatar_url":"https://avatars0.githubusercontent.com/u/13147752?v=4","gravatar_id":"","url":"https://api.github.com/users/mykhaly","html_url":"https://github.com/mykhaly","followers_url":"https://api.github.com/users/mykhaly/followers","following_url":"https://api.github.com/users/mykhaly/following{/other_user}","gists_url":"https://api.github.com/users/mykhaly/gists{/gist_id}","starred_url":"https://api.github.com/users/mykhaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykhaly/subscriptions","organizations_url":"https://api.github.com/users/mykhaly/orgs","repos_url":"https://api.github.com/users/mykhaly/repos","events_url":"https://api.github.com/users/mykhaly/events{/privacy}","received_events_url":"https://api.github.com/users/mykhaly/received_events","type":"User","site_admin":false},"created_at":"2017-10-23T08:23:17Z","updated_at":"2017-10-23T08:23:17Z","author_association":"COLLABORATOR","body":"\n\n\n\n\n\n\n\n*[farmscaling.py, line 41 at r1](https://reviewable.io:443/reviews/baaraban/zimbaboom/4#-Kx7JTJJOGcSWX2-f6ZZ:-Kx7JTJKGyFQI_CsBmtN:b-zfz191) ([raw file](https://github.com/baaraban/zimbaboom/blob/0c2c0cbf995089f840a2606fab970e7157f8dc85/farmscaling.py#L41)):*\n> ```Python\n> farms_dataset = pd.read_csv(farms_dataset_path, low_memory=False, usecols=headers)\n> \n> zambia_farms = get_country_farms(farms_dataset, \"zambia\")\n> ```\n\nМожна винести в окрему функцію.\n```\ndef get_farms_by_size_for_country(farms_dataset, country):\n    farms_for_country = get_country_farms(farms_dataset, country)\n    small_farms_for_country = get_farms_of_specific_size(farms_for_country, FARMS_TYPE_S)\n    medium_farms_for_country = get_farms_of_specific_size(farms_for_country, FARMS_TYPE_M)\n    large_farms_for_country = get_farms_of_specific_size(farms_for_country, FARMS_TYPE_L)\n    return small_farms_for_country, medium_farms_for_country, large_farms_for_country \n```\nНу і ці константи винести на верхній рівень.\nНапевно сам зараз це все зроблю.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/baaraban/zimbaboom/4)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mykhaly"}}