{"action":"created","issue":{"url":"https://api.github.com/repos/stlab/libraries/issues/103","repository_url":"https://api.github.com/repos/stlab/libraries","labels_url":"https://api.github.com/repos/stlab/libraries/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/stlab/libraries/issues/103/comments","events_url":"https://api.github.com/repos/stlab/libraries/issues/103/events","html_url":"https://github.com/stlab/libraries/pull/103","id":273738972,"number":103,"title":"Improve build system","user":{"login":"teonnik","id":8088032,"avatar_url":"https://avatars1.githubusercontent.com/u/8088032?v=4","gravatar_id":"","url":"https://api.github.com/users/teonnik","html_url":"https://github.com/teonnik","followers_url":"https://api.github.com/users/teonnik/followers","following_url":"https://api.github.com/users/teonnik/following{/other_user}","gists_url":"https://api.github.com/users/teonnik/gists{/gist_id}","starred_url":"https://api.github.com/users/teonnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teonnik/subscriptions","organizations_url":"https://api.github.com/users/teonnik/orgs","repos_url":"https://api.github.com/users/teonnik/repos","events_url":"https://api.github.com/users/teonnik/events{/privacy}","received_events_url":"https://api.github.com/users/teonnik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-11-14T10:24:38Z","updated_at":"2017-11-17T19:53:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/stlab/libraries/pulls/103","html_url":"https://github.com/stlab/libraries/pull/103","diff_url":"https://github.com/stlab/libraries/pull/103.diff","patch_url":"https://github.com/stlab/libraries/pull/103.patch"},"body":"I've made quite a few changes and extensions to the build script. I implemented an install target which provides an easy way of integrating the project in other CMake projects. Most of the changes are inspired by [Daniel Pfeifer's talk on Effective CMake][1]. I have tried to document what I have done in my commit messages. There are certain issues with some of the tests that still need to be resolved though. \r\n\r\n\r\n[1]: https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=0ahUKEwi21Y3q673XAhXHZCYKHWXpCAUQtwIIKDAA&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DbsXLMQ6WgIk&usg=AOvVaw0RtjvfdZFL46eWd5uwzsmw "},"comment":{"url":"https://api.github.com/repos/stlab/libraries/issues/comments/345349406","html_url":"https://github.com/stlab/libraries/pull/103#issuecomment-345349406","issue_url":"https://api.github.com/repos/stlab/libraries/issues/103","id":345349406,"user":{"login":"FelixPetriconi","id":612377,"avatar_url":"https://avatars3.githubusercontent.com/u/612377?v=4","gravatar_id":"","url":"https://api.github.com/users/FelixPetriconi","html_url":"https://github.com/FelixPetriconi","followers_url":"https://api.github.com/users/FelixPetriconi/followers","following_url":"https://api.github.com/users/FelixPetriconi/following{/other_user}","gists_url":"https://api.github.com/users/FelixPetriconi/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixPetriconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixPetriconi/subscriptions","organizations_url":"https://api.github.com/users/FelixPetriconi/orgs","repos_url":"https://api.github.com/users/FelixPetriconi/repos","events_url":"https://api.github.com/users/FelixPetriconi/events{/privacy}","received_events_url":"https://api.github.com/users/FelixPetriconi/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T19:53:43Z","updated_at":"2017-11-17T19:53:43Z","author_association":"MEMBER","body":"At least there is a define for NOMINMAX that is not resolved correctly on the Windows platform which results in a huge amount of compiler errors.\r\n\r\nCan you build the current stlab/develop correctly without any problem? If no, then I assume something in your general setup is different to Travis, AppVeyour and our own systems."}}
{"actor":{"display_login":"FelixPetriconi"}}