{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9551","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9551/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9551/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9551/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9551","id":250111631,"number":9551,"title":"[MRG] Raise exception on providing complex data to estimators","user":{"login":"pravarmahajan","id":22108888,"avatar_url":"https://avatars2.githubusercontent.com/u/22108888?v=4","gravatar_id":"","url":"https://api.github.com/users/pravarmahajan","html_url":"https://github.com/pravarmahajan","followers_url":"https://api.github.com/users/pravarmahajan/followers","following_url":"https://api.github.com/users/pravarmahajan/following{/other_user}","gists_url":"https://api.github.com/users/pravarmahajan/gists{/gist_id}","starred_url":"https://api.github.com/users/pravarmahajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravarmahajan/subscriptions","organizations_url":"https://api.github.com/users/pravarmahajan/orgs","repos_url":"https://api.github.com/users/pravarmahajan/repos","events_url":"https://api.github.com/users/pravarmahajan/events{/privacy}","received_events_url":"https://api.github.com/users/pravarmahajan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-08-14T18:20:25Z","updated_at":"2017-08-16T19:27:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9551","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9551","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/9551.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/9551.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\nFixes #9528 \r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nAn exception should be raised on giving complex data as input to the estimators. The changed code\r\ndoes the same, via the function check_array. A new test function has been added to test_validation.py\r\ncorresponding to the code changes.\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/322874347","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9551#issuecomment-322874347","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9551","id":322874347,"user":{"login":"amueller","id":449558,"avatar_url":"https://avatars3.githubusercontent.com/u/449558?v=4","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"created_at":"2017-08-16T19:27:31Z","updated_at":"2017-08-16T19:27:31Z","body":"Answering 2):\r\nLines 382-387 only work if an array was passed. If a list was passed, we can't know what the dtype is until after we converted to an array."}}
{"actor":{"display_login":"amueller"}}