{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/16128","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/16128/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16128/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/16128/events","html_url":"https://github.com/nodejs/node/pull/16128","id":264341471,"number":16128,"title":"module: allow loading files with % in the name","user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"labels":[{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"bfdadc","default":false},{"id":512071972,"url":"https://api.github.com/repos/nodejs/node/labels/url-whatwg","name":"url-whatwg","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-10T19:06:10Z","updated_at":"2017-10-10T19:23:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16128","html_url":"https://github.com/nodejs/node/pull/16128","diff_url":"https://github.com/nodejs/node/pull/16128.diff","patch_url":"https://github.com/nodejs/node/pull/16128.patch"},"body":"Because the module resolver applies percent decoding due to being URL-based for browser alignment, files with % characters in them cannot be loaded. For example a file at an actual path \"x%20.js\" gets decoded to the incorrect path \"x .js\".\r\n\r\nWe can support this if we carefully ensure that double encoding is supported of the form \"x%2520.js\" (just as is supported in browser module specifiers).\r\n\r\nIn order to make this work, a small fix to the URL filepath -> URL conversion code is needed, which is included here.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nurl, esmodules"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/335580531","html_url":"https://github.com/nodejs/node/pull/16128#issuecomment-335580531","issue_url":"https://api.github.com/repos/nodejs/node/issues/16128","id":335580531,"user":{"login":"refack","id":96947,"avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2017-10-10T19:23:55Z","updated_at":"2017-10-10T19:23:55Z","author_association":"MEMBER","body":"@guybedford Looks good in general, IMHO needs some minor tweaks."}}
{"actor":{"display_login":"refack"}}