{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/117993361","pull_request_review_id":39744243,"id":117993361,"diff_hunk":"@@ -36,23 +37,23 @@\n public class PrometheusExporterHttpService extends AbstractHttpService {\n     private static final MediaType CONTENT_TYPE_004 = MediaType.parse(TextFormat.CONTENT_TYPE_004);\n \n-    private final CollectorRegistry prometheusRegistry;\n+    private final CollectorRegistry collectorRegistry;\n \n     /**\n      * Create a {@link PrometheusExporterHttpService} instance.\n-     * @param prometheusRegistry Prometheus registry\n+     * @param collectorRegistry Prometheus registry\n      */\n-    public PrometheusExporterHttpService(CollectorRegistry prometheusRegistry) {\n-        Objects.requireNonNull(prometheusRegistry, \"prometheusRegistry\");\n-        this.prometheusRegistry = prometheusRegistry;\n+    public PrometheusExporterHttpService(CollectorRegistry collectorRegistry) {\n+        requireNonNull(collectorRegistry, \"collectorRegistry\");\n+        this.collectorRegistry = collectorRegistry;\n     }\n \n     @Override\n     protected void doGet(ServiceRequestContext ctx, HttpRequest req,\n                          HttpResponseWriter res) throws Exception {\n         ByteArrayOutputStream stream = new ByteArrayOutputStream();\n         try (OutputStreamWriter writer = new OutputStreamWriter(stream)) {\n-            TextFormat.write004(writer, prometheusRegistry.metricFamilySamples());\n+            TextFormat.write004(writer, collectorRegistry.metricFamilySamples());","path":"core/src/main/java/com/linecorp/armeria/server/http/metric/PrometheusExporterHttpService.java","position":38,"original_position":38,"commit_id":"e1a7b67426f1415ed98ae4d087900f65f09eb227","original_commit_id":"61402a2246820cf5e52e1c47fa2547c987be3bb6","user":{"login":"kojilin","id":863983,"avatar_url":"https://avatars3.githubusercontent.com/u/863983?v=3","gravatar_id":"","url":"https://api.github.com/users/kojilin","html_url":"https://github.com/kojilin","followers_url":"https://api.github.com/users/kojilin/followers","following_url":"https://api.github.com/users/kojilin/following{/other_user}","gists_url":"https://api.github.com/users/kojilin/gists{/gist_id}","starred_url":"https://api.github.com/users/kojilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kojilin/subscriptions","organizations_url":"https://api.github.com/users/kojilin/orgs","repos_url":"https://api.github.com/users/kojilin/repos","events_url":"https://api.github.com/users/kojilin/events{/privacy}","received_events_url":"https://api.github.com/users/kojilin/received_events","type":"User","site_admin":false},"body":"No u don't need to sort if u don't export multiple `registry` in one response.","created_at":"2017-05-23T13:39:49Z","updated_at":"2017-05-23T13:39:49Z","html_url":"https://github.com/line/armeria/pull/557#discussion_r117993361","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/557","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/117993361"},"html":{"href":"https://github.com/line/armeria/pull/557#discussion_r117993361"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/557"}}},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/557","id":121917107,"html_url":"https://github.com/line/armeria/pull/557","diff_url":"https://github.com/line/armeria/pull/557.diff","patch_url":"https://github.com/line/armeria/pull/557.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/557","number":557,"state":"open","locked":false,"title":"Clean up Prometheus metric collection code","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars3.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"- Rename PrometheusMetricCollection(Client|Service) to\r\n  PrometheusMetricCollecting(Client|Service) for consistency\r\n- Remove unnecessary U+2028 unicode character in Javadoc comments\r\n- Fix indentation and markup in MetricLabel example in its Javadoc\r\n- Add `@FunctionalInterface` to MetricLabel\r\n- Use more strict type parameter for MetricLabel\r\n- Move PrometheusRegistry to the internal.metric package\r\n- Revamp PrometheusRegistry so that a user doesn't have to know about it\r\n- Overall clean-up of the integration test\r\n  - Move the integration test from the internal.metrics to internal.metric\r\n    (Note the 's')\r\n  - Simplify the regular expressions\r\n  - Reorder the members for readability\r\n- Do not use Javadoc block (/** .. */) for license headers\r\n","created_at":"2017-05-23T05:39:34Z","updated_at":"2017-05-23T13:39:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa148a1406e5ae213eb2920a9d196baaaa533d7e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/line/armeria/milestones/73","html_url":"https://github.com/line/armeria/milestone/73","labels_url":"https://api.github.com/repos/line/armeria/milestones/73/labels","id":2520719,"number":73,"title":"0.46.0","description":null,"creator":{"login":"trustin","id":173918,"avatar_url":"https://avatars3.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":14,"state":"open","created_at":"2017-05-15T09:19:06Z","updated_at":"2017-05-23T10:44:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/line/armeria/pulls/557/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/557/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/557/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/e1a7b67426f1415ed98ae4d087900f65f09eb227","head":{"label":"trustin:prometheus_registry","ref":"prometheus_registry","sha":"e1a7b67426f1415ed98ae4d087900f65f09eb227","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars3.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"repo":{"id":46322160,"name":"armeria","full_name":"trustin/armeria","owner":{"login":"trustin","id":173918,"avatar_url":"https://avatars3.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trustin/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/trustin/armeria","forks_url":"https://api.github.com/repos/trustin/armeria/forks","keys_url":"https://api.github.com/repos/trustin/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustin/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustin/armeria/teams","hooks_url":"https://api.github.com/repos/trustin/armeria/hooks","issue_events_url":"https://api.github.com/repos/trustin/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/trustin/armeria/events","assignees_url":"https://api.github.com/repos/trustin/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/trustin/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/trustin/armeria/tags","blobs_url":"https://api.github.com/repos/trustin/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustin/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustin/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustin/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustin/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/trustin/armeria/languages","stargazers_url":"https://api.github.com/repos/trustin/armeria/stargazers","contributors_url":"https://api.github.com/repos/trustin/armeria/contributors","subscribers_url":"https://api.github.com/repos/trustin/armeria/subscribers","subscription_url":"https://api.github.com/repos/trustin/armeria/subscription","commits_url":"https://api.github.com/repos/trustin/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustin/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustin/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustin/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustin/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/trustin/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustin/armeria/merges","archive_url":"https://api.github.com/repos/trustin/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustin/armeria/downloads","issues_url":"https://api.github.com/repos/trustin/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/trustin/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/trustin/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/trustin/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustin/armeria/labels{/name}","releases_url":"https://api.github.com/repos/trustin/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/trustin/armeria/deployments","created_at":"2015-11-17T03:59:08Z","updated_at":"2017-01-10T02:20:41Z","pushed_at":"2017-05-23T10:39:43Z","git_url":"git://github.com/trustin/armeria.git","ssh_url":"git@github.com:trustin/armeria.git","clone_url":"https://github.com/trustin/armeria.git","svn_url":"https://github.com/trustin/armeria","homepage":"http://line.github.io/armeria/","size":20977,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"7e8f67704141304061abba282de042b8cc1c172c","user":{"login":"line","id":13128444,"avatar_url":"https://avatars1.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars1.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2017-05-23T09:13:01Z","pushed_at":"2017-05-23T10:39:44Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"http://line.github.io/armeria/","size":23449,"stargazers_count":778,"watchers_count":778,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":207,"mirror_url":null,"open_issues_count":52,"forks":207,"open_issues":52,"watchers":778,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/557"},"html":{"href":"https://github.com/line/armeria/pull/557"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/557"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/e1a7b67426f1415ed98ae4d087900f65f09eb227"}}}}
{"actor":{"display_login":"kojilin"}}