{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/94568910","pull_request_review_id":15095953,"id":94568910,"diff_hunk":"@@ -50,6 +50,13 @@ const (\n \tScaleDownNodeDeleted ScaleDownResult = iota\n )\n \n+const (\n+\t// MaxKubernetesNodeDeletiontime is the maximum time needed by Kubernetes to delete an empty node.\n+\tMaxKubernetesEmptyNodeDeletiontime = 3 * time.Minute","path":"cluster-autoscaler/scale_down.go","position":6,"original_position":6,"commit_id":"542506c05c0df74e2b0a4efc56c824174ac1e2de","original_commit_id":"7a69560816ee24f692bf32e57e19e08d494e8e2a","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"Yes","created_at":"2017-01-04T11:38:48Z","updated_at":"2017-01-04T11:38:48Z","html_url":"https://github.com/kubernetes/contrib/pull/2246#discussion_r94568910","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2246","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/94568910"},"html":{"href":"https://github.com/kubernetes/contrib/pull/2246#discussion_r94568910"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2246"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/2246","id":100016837,"html_url":"https://github.com/kubernetes/contrib/pull/2246","diff_url":"https://github.com/kubernetes/contrib/pull/2246.diff","patch_url":"https://github.com/kubernetes/contrib/pull/2246.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/2246","number":2246,"state":"open","locked":false,"title":"Cluster-autoscaler: introduce ClusterStateRegistry to main","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"Ref: #2228 #2229 \r\n\r\ncc: @jszczepkowski @fgrzadkowski @piosz  ","created_at":"2017-01-03T20:36:59Z","updated_at":"2017-01-04T11:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"519766252f55a355b96e3995213494271140a559","assignee":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2246/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2246/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/2246/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/542506c05c0df74e2b0a4efc56c824174ac1e2de","head":{"label":"mwielgus:add-registry","ref":"add-registry","sha":"542506c05c0df74e2b0a4efc56c824174ac1e2de","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"repo":{"id":56583152,"name":"contrib","full_name":"mwielgus/contrib","owner":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwielgus/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/mwielgus/contrib","forks_url":"https://api.github.com/repos/mwielgus/contrib/forks","keys_url":"https://api.github.com/repos/mwielgus/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwielgus/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwielgus/contrib/teams","hooks_url":"https://api.github.com/repos/mwielgus/contrib/hooks","issue_events_url":"https://api.github.com/repos/mwielgus/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/mwielgus/contrib/events","assignees_url":"https://api.github.com/repos/mwielgus/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/mwielgus/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/mwielgus/contrib/tags","blobs_url":"https://api.github.com/repos/mwielgus/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwielgus/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwielgus/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwielgus/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwielgus/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/mwielgus/contrib/languages","stargazers_url":"https://api.github.com/repos/mwielgus/contrib/stargazers","contributors_url":"https://api.github.com/repos/mwielgus/contrib/contributors","subscribers_url":"https://api.github.com/repos/mwielgus/contrib/subscribers","subscription_url":"https://api.github.com/repos/mwielgus/contrib/subscription","commits_url":"https://api.github.com/repos/mwielgus/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwielgus/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwielgus/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwielgus/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwielgus/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/mwielgus/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwielgus/contrib/merges","archive_url":"https://api.github.com/repos/mwielgus/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwielgus/contrib/downloads","issues_url":"https://api.github.com/repos/mwielgus/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/mwielgus/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/mwielgus/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/mwielgus/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwielgus/contrib/labels{/name}","releases_url":"https://api.github.com/repos/mwielgus/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/mwielgus/contrib/deployments","created_at":"2016-04-19T09:23:15Z","updated_at":"2016-04-19T09:23:18Z","pushed_at":"2017-01-04T11:21:06Z","git_url":"git://github.com/mwielgus/contrib.git","ssh_url":"git@github.com:mwielgus/contrib.git","clone_url":"https://github.com/mwielgus/contrib.git","svn_url":"https://github.com/mwielgus/contrib","homepage":"","size":41485,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a163e5d880f473ce29754237bc41db686772da6a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2017-01-04T10:12:57Z","pushed_at":"2017-01-04T11:21:13Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":62336,"stargazers_count":738,"watchers_count":738,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":738,"mirror_url":null,"open_issues_count":413,"forks":738,"open_issues":413,"watchers":738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2246"},"html":{"href":"https://github.com/kubernetes/contrib/pull/2246"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/2246"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/2246/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2246/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2246/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/542506c05c0df74e2b0a4efc56c824174ac1e2de"}}}}
{"actor":{"display_login":"mwielgus"}}