{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/131314993","pull_request_review_id":54283288,"id":131314993,"diff_hunk":"@@ -1640,7 +1640,9 @@ Read data from the file specified by `fd`.\n `length` is an integer specifying the number of bytes to read.\n \n `position` is an integer specifying where to begin reading from in the file.","path":"doc/api/fs.md","position":3,"original_position":3,"commit_id":"ad9134f6895c8ae6b28e9abeeb17d5209d00fcf5","original_commit_id":"ad9134f6895c8ae6b28e9abeeb17d5209d00fcf5","user":{"login":"dcharbonnier","id":6220422,"avatar_url":"https://avatars3.githubusercontent.com/u/6220422?v=4","gravatar_id":"","url":"https://api.github.com/users/dcharbonnier","html_url":"https://github.com/dcharbonnier","followers_url":"https://api.github.com/users/dcharbonnier/followers","following_url":"https://api.github.com/users/dcharbonnier/following{/other_user}","gists_url":"https://api.github.com/users/dcharbonnier/gists{/gist_id}","starred_url":"https://api.github.com/users/dcharbonnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcharbonnier/subscriptions","organizations_url":"https://api.github.com/users/dcharbonnier/orgs","repos_url":"https://api.github.com/users/dcharbonnier/repos","events_url":"https://api.github.com/users/dcharbonnier/events{/privacy}","received_events_url":"https://api.github.com/users/dcharbonnier/received_events","type":"User","site_admin":false},"body":"https://github.com/nodejs/node/issues/14621","created_at":"2017-08-04T05:37:58Z","updated_at":"2017-08-04T05:37:58Z","html_url":"https://github.com/nodejs/node/pull/14612#discussion_r131314993","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/14612","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/131314993"},"html":{"href":"https://github.com/nodejs/node/pull/14612#discussion_r131314993"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/14612"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14612","id":134001183,"html_url":"https://github.com/nodejs/node/pull/14612","diff_url":"https://github.com/nodejs/node/pull/14612.diff","patch_url":"https://github.com/nodejs/node/pull/14612.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/14612","number":14612,"state":"open","locked":false,"title":"clarify the position argument for fs.read","user":{"login":"dcharbonnier","id":6220422,"avatar_url":"https://avatars3.githubusercontent.com/u/6220422?v=4","gravatar_id":"","url":"https://api.github.com/users/dcharbonnier","html_url":"https://github.com/dcharbonnier","followers_url":"https://api.github.com/users/dcharbonnier/followers","following_url":"https://api.github.com/users/dcharbonnier/following{/other_user}","gists_url":"https://api.github.com/users/dcharbonnier/gists{/gist_id}","starred_url":"https://api.github.com/users/dcharbonnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcharbonnier/subscriptions","organizations_url":"https://api.github.com/users/dcharbonnier/orgs","repos_url":"https://api.github.com/users/dcharbonnier/repos","events_url":"https://api.github.com/users/dcharbonnier/events{/privacy}","received_events_url":"https://api.github.com/users/dcharbonnier/received_events","type":"User","site_admin":false},"body":"What happen to the file position after a read using a position null or integer was not clear and you can assume that the cursor of the file descriptor is updated even if position is an integer. \r\nclose #8397\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n","created_at":"2017-08-03T17:37:36Z","updated_at":"2017-08-04T05:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d463127c774a6d77b5db5e9376a2a0d9ccf68b5","assignee":{"login":"refack","id":96947,"avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"assignees":[{"login":"refack","id":96947,"avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/14612/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/14612/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14612/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ad9134f6895c8ae6b28e9abeeb17d5209d00fcf5","head":{"label":"dcharbonnier:patch-4","ref":"patch-4","sha":"ad9134f6895c8ae6b28e9abeeb17d5209d00fcf5","user":{"login":"dcharbonnier","id":6220422,"avatar_url":"https://avatars3.githubusercontent.com/u/6220422?v=4","gravatar_id":"","url":"https://api.github.com/users/dcharbonnier","html_url":"https://github.com/dcharbonnier","followers_url":"https://api.github.com/users/dcharbonnier/followers","following_url":"https://api.github.com/users/dcharbonnier/following{/other_user}","gists_url":"https://api.github.com/users/dcharbonnier/gists{/gist_id}","starred_url":"https://api.github.com/users/dcharbonnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcharbonnier/subscriptions","organizations_url":"https://api.github.com/users/dcharbonnier/orgs","repos_url":"https://api.github.com/users/dcharbonnier/repos","events_url":"https://api.github.com/users/dcharbonnier/events{/privacy}","received_events_url":"https://api.github.com/users/dcharbonnier/received_events","type":"User","site_admin":false},"repo":{"id":81825645,"name":"node","full_name":"dcharbonnier/node","owner":{"login":"dcharbonnier","id":6220422,"avatar_url":"https://avatars3.githubusercontent.com/u/6220422?v=4","gravatar_id":"","url":"https://api.github.com/users/dcharbonnier","html_url":"https://github.com/dcharbonnier","followers_url":"https://api.github.com/users/dcharbonnier/followers","following_url":"https://api.github.com/users/dcharbonnier/following{/other_user}","gists_url":"https://api.github.com/users/dcharbonnier/gists{/gist_id}","starred_url":"https://api.github.com/users/dcharbonnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcharbonnier/subscriptions","organizations_url":"https://api.github.com/users/dcharbonnier/orgs","repos_url":"https://api.github.com/users/dcharbonnier/repos","events_url":"https://api.github.com/users/dcharbonnier/events{/privacy}","received_events_url":"https://api.github.com/users/dcharbonnier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcharbonnier/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/dcharbonnier/node","forks_url":"https://api.github.com/repos/dcharbonnier/node/forks","keys_url":"https://api.github.com/repos/dcharbonnier/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcharbonnier/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcharbonnier/node/teams","hooks_url":"https://api.github.com/repos/dcharbonnier/node/hooks","issue_events_url":"https://api.github.com/repos/dcharbonnier/node/issues/events{/number}","events_url":"https://api.github.com/repos/dcharbonnier/node/events","assignees_url":"https://api.github.com/repos/dcharbonnier/node/assignees{/user}","branches_url":"https://api.github.com/repos/dcharbonnier/node/branches{/branch}","tags_url":"https://api.github.com/repos/dcharbonnier/node/tags","blobs_url":"https://api.github.com/repos/dcharbonnier/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcharbonnier/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcharbonnier/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcharbonnier/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcharbonnier/node/statuses/{sha}","languages_url":"https://api.github.com/repos/dcharbonnier/node/languages","stargazers_url":"https://api.github.com/repos/dcharbonnier/node/stargazers","contributors_url":"https://api.github.com/repos/dcharbonnier/node/contributors","subscribers_url":"https://api.github.com/repos/dcharbonnier/node/subscribers","subscription_url":"https://api.github.com/repos/dcharbonnier/node/subscription","commits_url":"https://api.github.com/repos/dcharbonnier/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcharbonnier/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcharbonnier/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcharbonnier/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcharbonnier/node/contents/{+path}","compare_url":"https://api.github.com/repos/dcharbonnier/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcharbonnier/node/merges","archive_url":"https://api.github.com/repos/dcharbonnier/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcharbonnier/node/downloads","issues_url":"https://api.github.com/repos/dcharbonnier/node/issues{/number}","pulls_url":"https://api.github.com/repos/dcharbonnier/node/pulls{/number}","milestones_url":"https://api.github.com/repos/dcharbonnier/node/milestones{/number}","notifications_url":"https://api.github.com/repos/dcharbonnier/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcharbonnier/node/labels{/name}","releases_url":"https://api.github.com/repos/dcharbonnier/node/releases{/id}","deployments_url":"https://api.github.com/repos/dcharbonnier/node/deployments","created_at":"2017-02-13T13:02:15Z","updated_at":"2017-02-13T13:02:40Z","pushed_at":"2017-08-03T17:50:39Z","git_url":"git://github.com/dcharbonnier/node.git","ssh_url":"git@github.com:dcharbonnier/node.git","clone_url":"https://github.com/dcharbonnier/node.git","svn_url":"https://github.com/dcharbonnier/node","homepage":"https://nodejs.org","size":295010,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"a92a5c17eb4439ecdb06e2a373ab1fe756a045cc","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-08-04T04:43:48Z","pushed_at":"2017-08-04T05:14:05Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":304402,"stargazers_count":37717,"watchers_count":37717,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7438,"mirror_url":null,"open_issues_count":867,"forks":7438,"open_issues":867,"watchers":37717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/14612"},"html":{"href":"https://github.com/nodejs/node/pull/14612"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/14612"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/14612/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/14612/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/14612/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ad9134f6895c8ae6b28e9abeeb17d5209d00fcf5"}}}}
{"actor":{"display_login":"dcharbonnier"}}