{"action":"created","comment":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/comments/137138030","pull_request_review_id":60766219,"id":137138030,"diff_hunk":"@@ -0,0 +1,13 @@\n+<resources>\n+    <string name=\"app_name\">Generate Geodatabase</string>\n+    <string name=\"world_street_map\">https://sampleserver6.arcgisonline.com/arcgis/rest/services/World_Street_Map/MapServer</string>","path":"generate-geodatabase/src/main/res/values/strings.xml","position":3,"original_position":3,"commit_id":"6af3ef804e79fe180e83b3bb52d99624ab7367b6","original_commit_id":"4cb562eb02945b69c8629c6972017d1091b439cb","user":{"login":"doneill","id":1308001,"avatar_url":"https://avatars1.githubusercontent.com/u/1308001?v=4","gravatar_id":"","url":"https://api.github.com/users/doneill","html_url":"https://github.com/doneill","followers_url":"https://api.github.com/users/doneill/followers","following_url":"https://api.github.com/users/doneill/following{/other_user}","gists_url":"https://api.github.com/users/doneill/gists{/gist_id}","starred_url":"https://api.github.com/users/doneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doneill/subscriptions","organizations_url":"https://api.github.com/users/doneill/orgs","repos_url":"https://api.github.com/users/doneill/repos","events_url":"https://api.github.com/users/doneill/events{/privacy}","received_events_url":"https://api.github.com/users/doneill/received_events","type":"User","site_admin":false},"body":"`world_street_map` string resource is unused.","created_at":"2017-09-05T23:14:26Z","updated_at":"2017-09-05T23:33:06Z","html_url":"https://github.com/Esri/arcgis-runtime-samples-android/pull/375#discussion_r137138030","pull_request_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/comments/137138030"},"html":{"href":"https://github.com/Esri/arcgis-runtime-samples-android/pull/375#discussion_r137138030"},"pull_request":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375","id":138475458,"html_url":"https://github.com/Esri/arcgis-runtime-samples-android/pull/375","diff_url":"https://github.com/Esri/arcgis-runtime-samples-android/pull/375.diff","patch_url":"https://github.com/Esri/arcgis-runtime-samples-android/pull/375.patch","issue_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/375","number":375,"state":"open","locked":false,"title":"Trev8939/generateGeodatabase","user":{"login":"TADraeseke","id":8885446,"avatar_url":"https://avatars3.githubusercontent.com/u/8885446?v=4","gravatar_id":"","url":"https://api.github.com/users/TADraeseke","html_url":"https://github.com/TADraeseke","followers_url":"https://api.github.com/users/TADraeseke/followers","following_url":"https://api.github.com/users/TADraeseke/following{/other_user}","gists_url":"https://api.github.com/users/TADraeseke/gists{/gist_id}","starred_url":"https://api.github.com/users/TADraeseke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TADraeseke/subscriptions","organizations_url":"https://api.github.com/users/TADraeseke/orgs","repos_url":"https://api.github.com/users/TADraeseke/repos","events_url":"https://api.github.com/users/TADraeseke/events{/privacy}","received_events_url":"https://api.github.com/users/TADraeseke/received_events","type":"User","site_admin":false},"body":"@doneill available to review this?\r\n\r\nIssues which would require your attention:\r\n\r\n- Provide link for SanFrancisco.tpk from AGOL (as per provision your device in README)\r\n\r\n- Design decision of what to do with the local Geodatabase file (should it persist on closing?, be deleted? be stored in temp cache?)\r\n\r\n- Should the sample allow for multiple downloads of geodatabase, like in the [TileCache sample](https://github.com/Esri/arcgis-runtime-samples-android/tree/master/export-tiles) or is once enough? At the moment the app removes the generate button once a local geodatabase has loaded.","created_at":"2017-08-30T16:45:17Z","updated_at":"2017-09-05T23:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aab569f755b6f6012783a8cf529f17ece5e01ae8","assignee":{"login":"doneill","id":1308001,"avatar_url":"https://avatars1.githubusercontent.com/u/1308001?v=4","gravatar_id":"","url":"https://api.github.com/users/doneill","html_url":"https://github.com/doneill","followers_url":"https://api.github.com/users/doneill/followers","following_url":"https://api.github.com/users/doneill/following{/other_user}","gists_url":"https://api.github.com/users/doneill/gists{/gist_id}","starred_url":"https://api.github.com/users/doneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doneill/subscriptions","organizations_url":"https://api.github.com/users/doneill/orgs","repos_url":"https://api.github.com/users/doneill/repos","events_url":"https://api.github.com/users/doneill/events{/privacy}","received_events_url":"https://api.github.com/users/doneill/received_events","type":"User","site_admin":false},"assignees":[{"login":"doneill","id":1308001,"avatar_url":"https://avatars1.githubusercontent.com/u/1308001?v=4","gravatar_id":"","url":"https://api.github.com/users/doneill","html_url":"https://github.com/doneill","followers_url":"https://api.github.com/users/doneill/followers","following_url":"https://api.github.com/users/doneill/following{/other_user}","gists_url":"https://api.github.com/users/doneill/gists{/gist_id}","starred_url":"https://api.github.com/users/doneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doneill/subscriptions","organizations_url":"https://api.github.com/users/doneill/orgs","repos_url":"https://api.github.com/users/doneill/repos","events_url":"https://api.github.com/users/doneill/events{/privacy}","received_events_url":"https://api.github.com/users/doneill/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375/commits","review_comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375/comments","review_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/375/comments","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/statuses/6af3ef804e79fe180e83b3bb52d99624ab7367b6","head":{"label":"Esri:trev8939/generateGeodatabase","ref":"trev8939/generateGeodatabase","sha":"6af3ef804e79fe180e83b3bb52d99624ab7367b6","user":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":19836746,"name":"arcgis-runtime-samples-android","full_name":"Esri/arcgis-runtime-samples-android","owner":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/arcgis-runtime-samples-android","description":"ArcGIS Runtime SDK for Android Samples","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/deployments","created_at":"2014-05-15T22:02:10Z","updated_at":"2017-09-01T16:21:37Z","pushed_at":"2017-09-05T23:32:35Z","git_url":"git://github.com/Esri/arcgis-runtime-samples-android.git","ssh_url":"git@github.com:Esri/arcgis-runtime-samples-android.git","clone_url":"https://github.com/Esri/arcgis-runtime-samples-android.git","svn_url":"https://github.com/Esri/arcgis-runtime-samples-android","homepage":"https://developers.arcgis.com/android/","size":74705,"stargazers_count":232,"watchers_count":232,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":752,"mirror_url":null,"open_issues_count":23,"forks":752,"open_issues":23,"watchers":232,"default_branch":"master"}},"base":{"label":"Esri:master","ref":"master","sha":"55a2c4b0ef5ca6afafe057199538aeb66c9bcfe4","user":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":19836746,"name":"arcgis-runtime-samples-android","full_name":"Esri/arcgis-runtime-samples-android","owner":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/arcgis-runtime-samples-android","description":"ArcGIS Runtime SDK for Android Samples","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/deployments","created_at":"2014-05-15T22:02:10Z","updated_at":"2017-09-01T16:21:37Z","pushed_at":"2017-09-05T23:32:35Z","git_url":"git://github.com/Esri/arcgis-runtime-samples-android.git","ssh_url":"git@github.com:Esri/arcgis-runtime-samples-android.git","clone_url":"https://github.com/Esri/arcgis-runtime-samples-android.git","svn_url":"https://github.com/Esri/arcgis-runtime-samples-android","homepage":"https://developers.arcgis.com/android/","size":74705,"stargazers_count":232,"watchers_count":232,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":752,"mirror_url":null,"open_issues_count":23,"forks":752,"open_issues":23,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375"},"html":{"href":"https://github.com/Esri/arcgis-runtime-samples-android/pull/375"},"issue":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/375"},"comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-android/statuses/6af3ef804e79fe180e83b3bb52d99624ab7367b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"doneill"}}