{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/138751373","pull_request_review_id":62590452,"id":138751373,"diff_hunk":"@@ -110,6 +107,19 @@ struct VariableImpl : public at::TensorImpl {\n   friend struct VariableType;\n };\n \n+inline Variable make_variable(at::Tensor data) {\n+  return Variable(new VariableImpl(data), false);\n+}\n+\n+inline Variable make_variable(at::Tensor data, std::shared_ptr<Function> grad_fn) {\n+  return Variable(new VariableImpl(data, grad_fn), false);","path":"torch/csrc/autograd/variable.h","position":19,"original_position":19,"commit_id":"d81b5cd7b9da5e7863abd10964f3d47def3da091","original_commit_id":"d81b5cd7b9da5e7863abd10964f3d47def3da091","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"OK, I guess then we would also need the move version... I'll make a value constructor then.","created_at":"2017-09-13T22:00:55Z","updated_at":"2017-09-13T22:00:55Z","html_url":"https://github.com/pytorch/pytorch/pull/2712#discussion_r138751373","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/2712","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/138751373"},"html":{"href":"https://github.com/pytorch/pytorch/pull/2712#discussion_r138751373"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2712"}},"in_reply_to_id":138486917},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/2712","id":140694873,"html_url":"https://github.com/pytorch/pytorch/pull/2712","diff_url":"https://github.com/pytorch/pytorch/pull/2712.diff","patch_url":"https://github.com/pytorch/pytorch/pull/2712.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/2712","number":2712,"state":"open","locked":false,"title":"imap to six / replace Variable(new VariableImpl) with make_variable","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"CC @apaszke @colesbury ","created_at":"2017-09-12T22:13:09Z","updated_at":"2017-09-13T22:00:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"182bb16405ee63c537128fbc45875d4fb4a762ac","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/2712/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/2712/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/2712/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/d81b5cd7b9da5e7863abd10964f3d47def3da091","head":{"label":"ezyang:pr/fixups","ref":"pr/fixups","sha":"d81b5cd7b9da5e7863abd10964f3d47def3da091","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"repo":{"id":101798885,"name":"pytorch-1","full_name":"ezyang/pytorch-1","owner":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezyang/pytorch-1","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/ezyang/pytorch-1","forks_url":"https://api.github.com/repos/ezyang/pytorch-1/forks","keys_url":"https://api.github.com/repos/ezyang/pytorch-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezyang/pytorch-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezyang/pytorch-1/teams","hooks_url":"https://api.github.com/repos/ezyang/pytorch-1/hooks","issue_events_url":"https://api.github.com/repos/ezyang/pytorch-1/issues/events{/number}","events_url":"https://api.github.com/repos/ezyang/pytorch-1/events","assignees_url":"https://api.github.com/repos/ezyang/pytorch-1/assignees{/user}","branches_url":"https://api.github.com/repos/ezyang/pytorch-1/branches{/branch}","tags_url":"https://api.github.com/repos/ezyang/pytorch-1/tags","blobs_url":"https://api.github.com/repos/ezyang/pytorch-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezyang/pytorch-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezyang/pytorch-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezyang/pytorch-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezyang/pytorch-1/statuses/{sha}","languages_url":"https://api.github.com/repos/ezyang/pytorch-1/languages","stargazers_url":"https://api.github.com/repos/ezyang/pytorch-1/stargazers","contributors_url":"https://api.github.com/repos/ezyang/pytorch-1/contributors","subscribers_url":"https://api.github.com/repos/ezyang/pytorch-1/subscribers","subscription_url":"https://api.github.com/repos/ezyang/pytorch-1/subscription","commits_url":"https://api.github.com/repos/ezyang/pytorch-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezyang/pytorch-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezyang/pytorch-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezyang/pytorch-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezyang/pytorch-1/contents/{+path}","compare_url":"https://api.github.com/repos/ezyang/pytorch-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezyang/pytorch-1/merges","archive_url":"https://api.github.com/repos/ezyang/pytorch-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezyang/pytorch-1/downloads","issues_url":"https://api.github.com/repos/ezyang/pytorch-1/issues{/number}","pulls_url":"https://api.github.com/repos/ezyang/pytorch-1/pulls{/number}","milestones_url":"https://api.github.com/repos/ezyang/pytorch-1/milestones{/number}","notifications_url":"https://api.github.com/repos/ezyang/pytorch-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezyang/pytorch-1/labels{/name}","releases_url":"https://api.github.com/repos/ezyang/pytorch-1/releases{/id}","deployments_url":"https://api.github.com/repos/ezyang/pytorch-1/deployments","created_at":"2017-08-29T19:28:39Z","updated_at":"2017-08-29T19:28:45Z","pushed_at":"2017-09-12T22:12:43Z","git_url":"git://github.com/ezyang/pytorch-1.git","ssh_url":"git@github.com:ezyang/pytorch-1.git","clone_url":"https://github.com/ezyang/pytorch-1.git","svn_url":"https://github.com/ezyang/pytorch-1","homepage":"http://pytorch.org","size":14918,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"1290e586fbc3d6266423f3417723d6620267054b","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2017-09-13T17:56:45Z","pushed_at":"2017-09-13T21:51:33Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":14970,"stargazers_count":7346,"watchers_count":7346,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1453,"mirror_url":null,"open_issues_count":386,"forks":1453,"open_issues":386,"watchers":7346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2712"},"html":{"href":"https://github.com/pytorch/pytorch/pull/2712"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/2712"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/2712/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2712/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/2712/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/d81b5cd7b9da5e7863abd10964f3d47def3da091"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ezyang"}}