{"action":"created","comment":{"url":"https://api.github.com/repos/datastax/java-driver/pulls/comments/106384977","pull_request_review_id":27302589,"id":106384977,"diff_hunk":"@@ -40,7 +40,7 @@\n     static class User {\n \n         @PartitionKey\n-        @Column(caseSensitive = true)\n+        @Column(name = \"userId\", caseSensitive = true)","path":"driver-mapping/src/test/java/com/datastax/driver/mapping/MapperCaseSensitivityTest.java","position":5,"original_position":5,"commit_id":"dedb90e5110869dc43c3e17d96b2aa8411966bd8","original_commit_id":"86e23253b184ce1dc605b9f344faef0add3d56f8","user":{"login":"adutra","id":463876,"avatar_url":"https://avatars0.githubusercontent.com/u/463876?v=3","gravatar_id":"","url":"https://api.github.com/users/adutra","html_url":"https://github.com/adutra","followers_url":"https://api.github.com/users/adutra/followers","following_url":"https://api.github.com/users/adutra/following{/other_user}","gists_url":"https://api.github.com/users/adutra/gists{/gist_id}","starred_url":"https://api.github.com/users/adutra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adutra/subscriptions","organizations_url":"https://api.github.com/users/adutra/orgs","repos_url":"https://api.github.com/users/adutra/repos","events_url":"https://api.github.com/users/adutra/events{/privacy}","received_events_url":"https://api.github.com/users/adutra/received_events","type":"User","site_admin":false},"body":"Yes this is a behavioral change but it solves the problem elegantly, so 👍 ","created_at":"2017-03-16T10:38:15Z","updated_at":"2017-03-16T10:38:15Z","html_url":"https://github.com/datastax/java-driver/pull/814#discussion_r106384977","pull_request_url":"https://api.github.com/repos/datastax/java-driver/pulls/814","_links":{"self":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/comments/106384977"},"html":{"href":"https://github.com/datastax/java-driver/pull/814#discussion_r106384977"},"pull_request":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/814"}}},"pull_request":{"url":"https://api.github.com/repos/datastax/java-driver/pulls/814","id":107725642,"html_url":"https://github.com/datastax/java-driver/pull/814","diff_url":"https://github.com/datastax/java-driver/pull/814.diff","patch_url":"https://github.com/datastax/java-driver/pull/814.patch","issue_url":"https://api.github.com/repos/datastax/java-driver/issues/814","number":814,"state":"open","locked":false,"title":"JAVA-1310: Make mapper's ignored properties configurable","user":{"login":"olim7t","id":259423,"avatar_url":"https://avatars1.githubusercontent.com/u/259423?v=3","gravatar_id":"","url":"https://api.github.com/users/olim7t","html_url":"https://github.com/olim7t","followers_url":"https://api.github.com/users/olim7t/followers","following_url":"https://api.github.com/users/olim7t/following{/other_user}","gists_url":"https://api.github.com/users/olim7t/gists{/gist_id}","starred_url":"https://api.github.com/users/olim7t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olim7t/subscriptions","organizations_url":"https://api.github.com/users/olim7t/orgs","repos_url":"https://api.github.com/users/olim7t/repos","events_url":"https://api.github.com/users/olim7t/events{/privacy}","received_events_url":"https://api.github.com/users/olim7t/received_events","type":"User","site_admin":false},"body":"Reboot of @avivcarmis original pull request:\r\n- target 3.x branch\r\n- rebase on top of current 3.x\r\n- get rid of my initial implementation\r\n\r\nReminder of the remaining tasks:\r\n\r\n1. `PropertyScanScope` class will be changed to an enum containing `{GETTERS_AND_SETTERS, FIELDS, BOTH}`.\r\n2. `HierarchyScanStrategy` class will be migrated to a single field of type Class<?> indicating the deepest ancestor to scan.\r\n    => I think it would also be useful to indicate if the bound is inclusive or not. In some cases you may have a common parent and you'll want to say \"up to this parent included\", but in others you may have multiple independent trees, and it will be \"up to `Object` excluded\".\r\n3. ~~Add [this change](https://github.com/datastax/java-driver/pull/771#discussion-diff-101653251R175).~~\r\n4. ~~Document the fact that `MappingManager` [getters](https://github.com/datastax/java-driver/blob/fbcd7d50e57845adfaf8bca7fb938943fb86c955/driver-mapping/src/main/java/com/datastax/driver/mapping/MappingManager.java#L236) will account for configuration object only for the first time, then they'll be ignored [as discussed here](https://github.com/datastax/java-driver/pull/771#discussion-diff-101658604R312).~~\r\n5. Make configuration immutable (maybe switch to builders) and remove duplication on mapper creation [as discussed here](https://github.com/datastax/java-driver/pull/771#discussion-diff-101656586R46).\r\n6. [Move class docs to getter methods](https://github.com/datastax/java-driver/pull/771#discussion-diff-101656317R36).\r\n7. [Move nested classes to top level ones](https://github.com/datastax/java-driver/pull/771#discussion-diff-101656811R76).\r\n8. ~~Rename transient config properties and document transient hierarchy (config transient props vs. class annotation transient properties vs. transient annotation) [as discussed here](https://github.com/datastax/java-driver/pull/771#discussion-diff-101765523R101).~~ => I've removed the annotation-level config property\r\n9. ~~Rename `PropertyMappingStrategy` values to `{OPT_IN, OPT_OUT}` [as discussed here](https://github.com/datastax/java-driver/pull/771#discussion-diff-101766284R334).~~\r\n10. ~~Reuse `AnnotationParser.VALID_COLUMN_ANNOTATIONS` [as discussed here](https://github.com/datastax/java-driver/pull/771#discussion-diff-101769396R44).~~\r\n11. ~~Account for java `transient` modifier [as discussed here](https://github.com/datastax/java-driver/pull/771#discussion-diff-101766808R138) (i'm actually +1 on that, fell for it myself when i started using the mapper).~~\r\n12. ~~Rename `MapperConfiguration` to `MappingConfiguration`.~~\r\n13. ~~Last thing left open is whether we want to remove [`PropertyScanConfiguration`](https://github.com/datastax/java-driver/blob/fbcd7d50e57845adfaf8bca7fb938943fb86c955/driver-mapping/src/main/java/com/datastax/driver/mapping/MapperConfiguration.java#L46) field and move it's props to `MappingConfiguration` top level.~~ => no, let's keep it separate","created_at":"2017-02-23T22:17:13Z","updated_at":"2017-03-16T10:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"999900c8d338ccdd03df622868224da041754ad9","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/datastax/java-driver/milestones/17","html_url":"https://github.com/datastax/java-driver/milestone/17","labels_url":"https://api.github.com/repos/datastax/java-driver/milestones/17/labels","id":1917679,"number":17,"title":"3.2.0","description":null,"creator":{"login":"adutra","id":463876,"avatar_url":"https://avatars0.githubusercontent.com/u/463876?v=3","gravatar_id":"","url":"https://api.github.com/users/adutra","html_url":"https://github.com/adutra","followers_url":"https://api.github.com/users/adutra/followers","following_url":"https://api.github.com/users/adutra/following{/other_user}","gists_url":"https://api.github.com/users/adutra/gists{/gist_id}","starred_url":"https://api.github.com/users/adutra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adutra/subscriptions","organizations_url":"https://api.github.com/users/adutra/orgs","repos_url":"https://api.github.com/users/adutra/repos","events_url":"https://api.github.com/users/adutra/events{/privacy}","received_events_url":"https://api.github.com/users/adutra/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":37,"state":"open","created_at":"2016-08-02T08:38:19Z","updated_at":"2017-03-15T21:06:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/datastax/java-driver/pulls/814/commits","review_comments_url":"https://api.github.com/repos/datastax/java-driver/pulls/814/comments","review_comment_url":"https://api.github.com/repos/datastax/java-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datastax/java-driver/issues/814/comments","statuses_url":"https://api.github.com/repos/datastax/java-driver/statuses/dedb90e5110869dc43c3e17d96b2aa8411966bd8","head":{"label":"datastax:java1310","ref":"java1310","sha":"dedb90e5110869dc43c3e17d96b2aa8411966bd8","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars3.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":6765281,"name":"java-driver","full_name":"datastax/java-driver","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars3.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/java-driver","description":"DataStax Java Driver for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/datastax/java-driver","forks_url":"https://api.github.com/repos/datastax/java-driver/forks","keys_url":"https://api.github.com/repos/datastax/java-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/java-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/java-driver/teams","hooks_url":"https://api.github.com/repos/datastax/java-driver/hooks","issue_events_url":"https://api.github.com/repos/datastax/java-driver/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/java-driver/events","assignees_url":"https://api.github.com/repos/datastax/java-driver/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/java-driver/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/java-driver/tags","blobs_url":"https://api.github.com/repos/datastax/java-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/java-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/java-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/java-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/java-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/java-driver/languages","stargazers_url":"https://api.github.com/repos/datastax/java-driver/stargazers","contributors_url":"https://api.github.com/repos/datastax/java-driver/contributors","subscribers_url":"https://api.github.com/repos/datastax/java-driver/subscribers","subscription_url":"https://api.github.com/repos/datastax/java-driver/subscription","commits_url":"https://api.github.com/repos/datastax/java-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/java-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/java-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/java-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/java-driver/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/java-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/java-driver/merges","archive_url":"https://api.github.com/repos/datastax/java-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/java-driver/downloads","issues_url":"https://api.github.com/repos/datastax/java-driver/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/java-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/java-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/java-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/java-driver/labels{/name}","releases_url":"https://api.github.com/repos/datastax/java-driver/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/java-driver/deployments","created_at":"2012-11-19T18:44:41Z","updated_at":"2017-03-12T06:45:43Z","pushed_at":"2017-03-15T23:44:22Z","git_url":"git://github.com/datastax/java-driver.git","ssh_url":"git@github.com:datastax/java-driver.git","clone_url":"https://github.com/datastax/java-driver.git","svn_url":"https://github.com/datastax/java-driver","homepage":null,"size":23693,"stargazers_count":765,"watchers_count":765,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":559,"mirror_url":null,"open_issues_count":13,"forks":559,"open_issues":13,"watchers":765,"default_branch":"3.1.x"}},"base":{"label":"datastax:3.x","ref":"3.x","sha":"f1932151ab9b0244c24c7b58c899ef58fc06f5ee","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars3.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":6765281,"name":"java-driver","full_name":"datastax/java-driver","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars3.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/java-driver","description":"DataStax Java Driver for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/datastax/java-driver","forks_url":"https://api.github.com/repos/datastax/java-driver/forks","keys_url":"https://api.github.com/repos/datastax/java-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/java-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/java-driver/teams","hooks_url":"https://api.github.com/repos/datastax/java-driver/hooks","issue_events_url":"https://api.github.com/repos/datastax/java-driver/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/java-driver/events","assignees_url":"https://api.github.com/repos/datastax/java-driver/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/java-driver/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/java-driver/tags","blobs_url":"https://api.github.com/repos/datastax/java-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/java-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/java-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/java-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/java-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/java-driver/languages","stargazers_url":"https://api.github.com/repos/datastax/java-driver/stargazers","contributors_url":"https://api.github.com/repos/datastax/java-driver/contributors","subscribers_url":"https://api.github.com/repos/datastax/java-driver/subscribers","subscription_url":"https://api.github.com/repos/datastax/java-driver/subscription","commits_url":"https://api.github.com/repos/datastax/java-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/java-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/java-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/java-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/java-driver/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/java-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/java-driver/merges","archive_url":"https://api.github.com/repos/datastax/java-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/java-driver/downloads","issues_url":"https://api.github.com/repos/datastax/java-driver/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/java-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/java-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/java-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/java-driver/labels{/name}","releases_url":"https://api.github.com/repos/datastax/java-driver/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/java-driver/deployments","created_at":"2012-11-19T18:44:41Z","updated_at":"2017-03-12T06:45:43Z","pushed_at":"2017-03-15T23:44:22Z","git_url":"git://github.com/datastax/java-driver.git","ssh_url":"git@github.com:datastax/java-driver.git","clone_url":"https://github.com/datastax/java-driver.git","svn_url":"https://github.com/datastax/java-driver","homepage":null,"size":23693,"stargazers_count":765,"watchers_count":765,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":559,"mirror_url":null,"open_issues_count":13,"forks":559,"open_issues":13,"watchers":765,"default_branch":"3.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/814"},"html":{"href":"https://github.com/datastax/java-driver/pull/814"},"issue":{"href":"https://api.github.com/repos/datastax/java-driver/issues/814"},"comments":{"href":"https://api.github.com/repos/datastax/java-driver/issues/814/comments"},"review_comments":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/814/comments"},"review_comment":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/814/commits"},"statuses":{"href":"https://api.github.com/repos/datastax/java-driver/statuses/dedb90e5110869dc43c3e17d96b2aa8411966bd8"}}}}
{"actor":{"display_login":"adutra"}}