{"action":"created","issue":{"url":"https://api.github.com/repos/njh/twolame/issues/1","repository_url":"https://api.github.com/repos/njh/twolame","labels_url":"https://api.github.com/repos/njh/twolame/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/njh/twolame/issues/1/comments","events_url":"https://api.github.com/repos/njh/twolame/issues/1/events","html_url":"https://github.com/njh/twolame/issues/1","id":501828,"number":1,"title":"Apply and test patch to convert internal buffers to floats","user":{"login":"njh","id":38734,"avatar_url":"https://avatars.githubusercontent.com/u/38734?v=3","gravatar_id":"","url":"https://api.github.com/users/njh","html_url":"https://github.com/njh","followers_url":"https://api.github.com/users/njh/followers","following_url":"https://api.github.com/users/njh/following{/other_user}","gists_url":"https://api.github.com/users/njh/gists{/gist_id}","starred_url":"https://api.github.com/users/njh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njh/subscriptions","organizations_url":"https://api.github.com/users/njh/orgs","repos_url":"https://api.github.com/users/njh/repos","events_url":"https://api.github.com/users/njh/events{/privacy}","received_events_url":"https://api.github.com/users/njh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2011-01-02T13:06:57Z","updated_at":"2017-02-13T10:59:20Z","closed_at":null,"body":"Original tracker ticket:\nhttps://sourceforge.net/tracker/?func=detail&aid=1760298&group_id=136040&atid=735435\n\nPatch here:\nhttps://gist.github.com/762513\n\nI've attached a patch, that enables internal FLOAT buffer support. All internal 16 bit code has been replaced.\n\nShould be compatible with existing interface.\n\nIt also replaces:\n\n---\n\n```\nif ((filter[i][k] = 1e9 * cos ((FLOAT) ((2 * i + 1) * k * PI64))) >= 0)\n  modf (filter[i][k] + 0.5, &filter[i][k]);\nelse\n  modf (filter[i][k] - 0.5, &filter[i][k]);\n```\n\n---\n## With: \n\n```\nif ((filter[i][k] = 1e9 * cos ((FLOAT) ((2 * i + 1) * k * PI64))) >= 0) {\n  filter[i][k] = (int)(filter[i][k] + 0.5);\n} else {\n  filter[i][k] = (int)(filter[i][k] - 0.5);\n}\n```\n\n---\n\nSince the former triggers a compiler error on MSVC++ 8, making it overwrite values in global_opt->smem->off[0].\n\nRight now the internal buffer is the same as FLOAT is defined as in common.h - changing it from double to float results in a significant slowdown on windows - probably because there are a lot of float <-> double conversions needed. Functions would need to be replaced by float ones.\n\nThere are still some places that should be investigated:\n\npsycho_1.c - Line 533 & psycho_1.c - Line 128:\nmax = 20 \\* log10 (scale[i] \\* 32768) - 10;   /\\* level for each subband */\n\nath.c, line 98 - guess that one is for general confusion.\n\nRegards, Klaus Post.\n"},"comment":{"url":"https://api.github.com/repos/njh/twolame/issues/comments/279355281","html_url":"https://github.com/njh/twolame/issues/1#issuecomment-279355281","issue_url":"https://api.github.com/repos/njh/twolame/issues/1","id":279355281,"user":{"login":"eblanca","id":1640886,"avatar_url":"https://avatars.githubusercontent.com/u/1640886?v=3","gravatar_id":"","url":"https://api.github.com/users/eblanca","html_url":"https://github.com/eblanca","followers_url":"https://api.github.com/users/eblanca/followers","following_url":"https://api.github.com/users/eblanca/following{/other_user}","gists_url":"https://api.github.com/users/eblanca/gists{/gist_id}","starred_url":"https://api.github.com/users/eblanca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eblanca/subscriptions","organizations_url":"https://api.github.com/users/eblanca/orgs","repos_url":"https://api.github.com/users/eblanca/repos","events_url":"https://api.github.com/users/eblanca/events{/privacy}","received_events_url":"https://api.github.com/users/eblanca/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T10:59:20Z","updated_at":"2017-02-13T10:59:20Z","body":"I cannot reach the page\r\nhttps://sourceforge.net/tracker/?func=detail&aid=1760298&group_id=136040&atid=735435\r\ncan you ?"}}
{"actor":{"display_login":"eblanca"}}