{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc-java/issues/2938","repository_url":"https://api.github.com/repos/grpc/grpc-java","labels_url":"https://api.github.com/repos/grpc/grpc-java/issues/2938/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/2938/comments","events_url":"https://api.github.com/repos/grpc/grpc-java/issues/2938/events","html_url":"https://github.com/grpc/grpc-java/pull/2938","id":223517365,"number":2938,"title":"core: integrate instrumentation-java (Census) tracing","user":{"login":"zhangkun83","id":9053690,"avatar_url":"https://avatars3.githubusercontent.com/u/9053690?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangkun83","html_url":"https://github.com/zhangkun83","followers_url":"https://api.github.com/users/zhangkun83/followers","following_url":"https://api.github.com/users/zhangkun83/following{/other_user}","gists_url":"https://api.github.com/users/zhangkun83/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangkun83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangkun83/subscriptions","organizations_url":"https://api.github.com/users/zhangkun83/orgs","repos_url":"https://api.github.com/users/zhangkun83/repos","events_url":"https://api.github.com/users/zhangkun83/events{/privacy}","received_events_url":"https://api.github.com/users/zhangkun83/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bogdandrutu","id":1373887,"avatar_url":"https://avatars3.githubusercontent.com/u/1373887?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},"assignees":[{"login":"bogdandrutu","id":1373887,"avatar_url":"https://avatars3.githubusercontent.com/u/1373887?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},{"login":"ejona86","id":2811396,"avatar_url":"https://avatars1.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-04-21T22:53:47Z","updated_at":"2017-04-22T17:37:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/2938","html_url":"https://github.com/grpc/grpc-java/pull/2938","diff_url":"https://github.com/grpc/grpc-java/pull/2938.diff","patch_url":"https://github.com/grpc/grpc-java/pull/2938.patch"},"body":"Main implementation is in `CensusTracingModule`.\r\n\r\nAlso a few fix-ups in the stats implementation `CensusStatsModule`:\r\n- Change header key name from `grpc-census-bin` to `grpc-tags-bin`\r\n- Server does not fail on header parse errors. Uses the default instead.\r\n\r\nDO NOT SUBMIT: currently using snapshot version of Census. Must switch to a release version before submitting."},"comment":{"url":"https://api.github.com/repos/grpc/grpc-java/issues/comments/296389243","html_url":"https://github.com/grpc/grpc-java/pull/2938#issuecomment-296389243","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/2938","id":296389243,"user":{"login":"zhangkun83","id":9053690,"avatar_url":"https://avatars3.githubusercontent.com/u/9053690?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangkun83","html_url":"https://github.com/zhangkun83","followers_url":"https://api.github.com/users/zhangkun83/followers","following_url":"https://api.github.com/users/zhangkun83/following{/other_user}","gists_url":"https://api.github.com/users/zhangkun83/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangkun83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangkun83/subscriptions","organizations_url":"https://api.github.com/users/zhangkun83/orgs","repos_url":"https://api.github.com/users/zhangkun83/repos","events_url":"https://api.github.com/users/zhangkun83/events{/privacy}","received_events_url":"https://api.github.com/users/zhangkun83/received_events","type":"User","site_admin":false},"created_at":"2017-04-22T17:37:21Z","updated_at":"2017-04-22T17:37:21Z","body":"> Does \"grpc-tags-bin\" imply propagated tags are shared between metrics and tracing? Fine if so, but it is notable\r\n\r\nNo. Tracing has its own header: `grpc-trace-bin`.\r\n\r\n> Is it intentional that static references to grpc context are implied? Ex we get the current parent using a static constant. This may be fine, but also could use explanation (even if it is that everything gRPC uses static / classloader configuration)\r\n\r\nYou mean `CONTEXT_SPAN_KEY`? We intend to standardize the keys for accessing the tags and span in the gRPC Context as constants from the instrumentation API. Do you have a reason to consider not doing that way?"}}
{"actor":{"display_login":"zhangkun83"}}