{"action":"closed","number":463,"pull_request":{"url":"https://api.github.com/repos/ex-aws/ex_aws/pulls/463","id":133588864,"html_url":"https://github.com/ex-aws/ex_aws/pull/463","diff_url":"https://github.com/ex-aws/ex_aws/pull/463.diff","patch_url":"https://github.com/ex-aws/ex_aws/pull/463.patch","issue_url":"https://api.github.com/repos/ex-aws/ex_aws/issues/463","number":463,"state":"closed","locked":false,"title":"fixed CustomUserData if it’s nil","user":{"login":"iwarshak","id":471,"avatar_url":"https://avatars3.githubusercontent.com/u/471?v=4","gravatar_id":"","url":"https://api.github.com/users/iwarshak","html_url":"https://github.com/iwarshak","followers_url":"https://api.github.com/users/iwarshak/followers","following_url":"https://api.github.com/users/iwarshak/following{/other_user}","gists_url":"https://api.github.com/users/iwarshak/gists{/gist_id}","starred_url":"https://api.github.com/users/iwarshak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwarshak/subscriptions","organizations_url":"https://api.github.com/users/iwarshak/orgs","repos_url":"https://api.github.com/users/iwarshak/repos","events_url":"https://api.github.com/users/iwarshak/events{/privacy}","received_events_url":"https://api.github.com/users/iwarshak/received_events","type":"User","site_admin":false},"body":"I have run into a strange and confusing situation with SNS and ex_aws. Specifically when registering a device with `SNS.create_platform_endpoint`. Before this PR, a nil value for `custom_user_data` gets converted to an empty string `””` on AWS side.\r\n\r\nAdditionally, a device registered with another client (aws cli for example) that truly does have no custom user data incorrectly shows up with the custom_user_data as `””` with ex_aws.\r\n\r\nThis causes a problem because when re-registering a device (which you are allowed to do), and the custom user data does not match you will get an AWS error.\r\n\r\nThis PR prevents a nil `custom_user_data` param from getting sent to AWS (which causes the empty string to be set). It also removes the custom_user_data param when parsing a `GetEndpointAttributesResponse` response if there is no custom_user_data (instead of setting it to an empty string).","created_at":"2017-08-01T22:47:03Z","updated_at":"2017-10-19T00:31:53Z","closed_at":"2017-10-19T00:31:53Z","merged_at":null,"merge_commit_sha":"8a82c864923f4c3e5131a9ac304decc35786c18d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ex-aws/ex_aws/pulls/463/commits","review_comments_url":"https://api.github.com/repos/ex-aws/ex_aws/pulls/463/comments","review_comment_url":"https://api.github.com/repos/ex-aws/ex_aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ex-aws/ex_aws/issues/463/comments","statuses_url":"https://api.github.com/repos/ex-aws/ex_aws/statuses/273c1a3faa842da0958754a99c8f7e7d05e973be","head":{"label":"iwarshak:custom-user-data-optional","ref":"custom-user-data-optional","sha":"273c1a3faa842da0958754a99c8f7e7d05e973be","user":{"login":"iwarshak","id":471,"avatar_url":"https://avatars3.githubusercontent.com/u/471?v=4","gravatar_id":"","url":"https://api.github.com/users/iwarshak","html_url":"https://github.com/iwarshak","followers_url":"https://api.github.com/users/iwarshak/followers","following_url":"https://api.github.com/users/iwarshak/following{/other_user}","gists_url":"https://api.github.com/users/iwarshak/gists{/gist_id}","starred_url":"https://api.github.com/users/iwarshak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwarshak/subscriptions","organizations_url":"https://api.github.com/users/iwarshak/orgs","repos_url":"https://api.github.com/users/iwarshak/repos","events_url":"https://api.github.com/users/iwarshak/events{/privacy}","received_events_url":"https://api.github.com/users/iwarshak/received_events","type":"User","site_admin":false},"repo":{"id":99048199,"name":"ex_aws","full_name":"iwarshak/ex_aws","owner":{"login":"iwarshak","id":471,"avatar_url":"https://avatars3.githubusercontent.com/u/471?v=4","gravatar_id":"","url":"https://api.github.com/users/iwarshak","html_url":"https://github.com/iwarshak","followers_url":"https://api.github.com/users/iwarshak/followers","following_url":"https://api.github.com/users/iwarshak/following{/other_user}","gists_url":"https://api.github.com/users/iwarshak/gists{/gist_id}","starred_url":"https://api.github.com/users/iwarshak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwarshak/subscriptions","organizations_url":"https://api.github.com/users/iwarshak/orgs","repos_url":"https://api.github.com/users/iwarshak/repos","events_url":"https://api.github.com/users/iwarshak/events{/privacy}","received_events_url":"https://api.github.com/users/iwarshak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iwarshak/ex_aws","description":"A flexible, easy to use set of clients AWS APIs for Elixir","fork":true,"url":"https://api.github.com/repos/iwarshak/ex_aws","forks_url":"https://api.github.com/repos/iwarshak/ex_aws/forks","keys_url":"https://api.github.com/repos/iwarshak/ex_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iwarshak/ex_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iwarshak/ex_aws/teams","hooks_url":"https://api.github.com/repos/iwarshak/ex_aws/hooks","issue_events_url":"https://api.github.com/repos/iwarshak/ex_aws/issues/events{/number}","events_url":"https://api.github.com/repos/iwarshak/ex_aws/events","assignees_url":"https://api.github.com/repos/iwarshak/ex_aws/assignees{/user}","branches_url":"https://api.github.com/repos/iwarshak/ex_aws/branches{/branch}","tags_url":"https://api.github.com/repos/iwarshak/ex_aws/tags","blobs_url":"https://api.github.com/repos/iwarshak/ex_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iwarshak/ex_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iwarshak/ex_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/iwarshak/ex_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iwarshak/ex_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/iwarshak/ex_aws/languages","stargazers_url":"https://api.github.com/repos/iwarshak/ex_aws/stargazers","contributors_url":"https://api.github.com/repos/iwarshak/ex_aws/contributors","subscribers_url":"https://api.github.com/repos/iwarshak/ex_aws/subscribers","subscription_url":"https://api.github.com/repos/iwarshak/ex_aws/subscription","commits_url":"https://api.github.com/repos/iwarshak/ex_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/iwarshak/ex_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/iwarshak/ex_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/iwarshak/ex_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/iwarshak/ex_aws/contents/{+path}","compare_url":"https://api.github.com/repos/iwarshak/ex_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iwarshak/ex_aws/merges","archive_url":"https://api.github.com/repos/iwarshak/ex_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iwarshak/ex_aws/downloads","issues_url":"https://api.github.com/repos/iwarshak/ex_aws/issues{/number}","pulls_url":"https://api.github.com/repos/iwarshak/ex_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/iwarshak/ex_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/iwarshak/ex_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iwarshak/ex_aws/labels{/name}","releases_url":"https://api.github.com/repos/iwarshak/ex_aws/releases{/id}","deployments_url":"https://api.github.com/repos/iwarshak/ex_aws/deployments","created_at":"2017-08-01T22:27:42Z","updated_at":"2017-08-01T22:27:43Z","pushed_at":"2017-08-01T22:46:42Z","git_url":"git://github.com/iwarshak/ex_aws.git","ssh_url":"git@github.com:iwarshak/ex_aws.git","clone_url":"https://github.com/iwarshak/ex_aws.git","svn_url":"https://github.com/iwarshak/ex_aws","homepage":"https://hex.pm/packages/ex_aws","size":1264,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ex-aws:master","ref":"master","sha":"e231b2a46e13662accb15f512151bab2e2f523cc","user":{"login":"ex-aws","id":32853421,"avatar_url":"https://avatars1.githubusercontent.com/u/32853421?v=4","gravatar_id":"","url":"https://api.github.com/users/ex-aws","html_url":"https://github.com/ex-aws","followers_url":"https://api.github.com/users/ex-aws/followers","following_url":"https://api.github.com/users/ex-aws/following{/other_user}","gists_url":"https://api.github.com/users/ex-aws/gists{/gist_id}","starred_url":"https://api.github.com/users/ex-aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex-aws/subscriptions","organizations_url":"https://api.github.com/users/ex-aws/orgs","repos_url":"https://api.github.com/users/ex-aws/repos","events_url":"https://api.github.com/users/ex-aws/events{/privacy}","received_events_url":"https://api.github.com/users/ex-aws/received_events","type":"Organization","site_admin":false},"repo":{"id":24062989,"name":"ex_aws","full_name":"ex-aws/ex_aws","owner":{"login":"ex-aws","id":32853421,"avatar_url":"https://avatars1.githubusercontent.com/u/32853421?v=4","gravatar_id":"","url":"https://api.github.com/users/ex-aws","html_url":"https://github.com/ex-aws","followers_url":"https://api.github.com/users/ex-aws/followers","following_url":"https://api.github.com/users/ex-aws/following{/other_user}","gists_url":"https://api.github.com/users/ex-aws/gists{/gist_id}","starred_url":"https://api.github.com/users/ex-aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex-aws/subscriptions","organizations_url":"https://api.github.com/users/ex-aws/orgs","repos_url":"https://api.github.com/users/ex-aws/repos","events_url":"https://api.github.com/users/ex-aws/events{/privacy}","received_events_url":"https://api.github.com/users/ex-aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ex-aws/ex_aws","description":"A flexible, easy to use set of clients AWS APIs for Elixir","fork":false,"url":"https://api.github.com/repos/ex-aws/ex_aws","forks_url":"https://api.github.com/repos/ex-aws/ex_aws/forks","keys_url":"https://api.github.com/repos/ex-aws/ex_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ex-aws/ex_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ex-aws/ex_aws/teams","hooks_url":"https://api.github.com/repos/ex-aws/ex_aws/hooks","issue_events_url":"https://api.github.com/repos/ex-aws/ex_aws/issues/events{/number}","events_url":"https://api.github.com/repos/ex-aws/ex_aws/events","assignees_url":"https://api.github.com/repos/ex-aws/ex_aws/assignees{/user}","branches_url":"https://api.github.com/repos/ex-aws/ex_aws/branches{/branch}","tags_url":"https://api.github.com/repos/ex-aws/ex_aws/tags","blobs_url":"https://api.github.com/repos/ex-aws/ex_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ex-aws/ex_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ex-aws/ex_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/ex-aws/ex_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ex-aws/ex_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/ex-aws/ex_aws/languages","stargazers_url":"https://api.github.com/repos/ex-aws/ex_aws/stargazers","contributors_url":"https://api.github.com/repos/ex-aws/ex_aws/contributors","subscribers_url":"https://api.github.com/repos/ex-aws/ex_aws/subscribers","subscription_url":"https://api.github.com/repos/ex-aws/ex_aws/subscription","commits_url":"https://api.github.com/repos/ex-aws/ex_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/ex-aws/ex_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/ex-aws/ex_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/ex-aws/ex_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/ex-aws/ex_aws/contents/{+path}","compare_url":"https://api.github.com/repos/ex-aws/ex_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ex-aws/ex_aws/merges","archive_url":"https://api.github.com/repos/ex-aws/ex_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ex-aws/ex_aws/downloads","issues_url":"https://api.github.com/repos/ex-aws/ex_aws/issues{/number}","pulls_url":"https://api.github.com/repos/ex-aws/ex_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/ex-aws/ex_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/ex-aws/ex_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ex-aws/ex_aws/labels{/name}","releases_url":"https://api.github.com/repos/ex-aws/ex_aws/releases{/id}","deployments_url":"https://api.github.com/repos/ex-aws/ex_aws/deployments","created_at":"2014-09-15T16:02:48Z","updated_at":"2017-10-18T07:45:44Z","pushed_at":"2017-10-18T23:44:11Z","git_url":"git://github.com/ex-aws/ex_aws.git","ssh_url":"git@github.com:ex-aws/ex_aws.git","clone_url":"https://github.com/ex-aws/ex_aws.git","svn_url":"https://github.com/ex-aws/ex_aws","homepage":"https://hex.pm/packages/ex_aws","size":1290,"stargazers_count":512,"watchers_count":512,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":22,"forks":222,"open_issues":22,"watchers":512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ex-aws/ex_aws/pulls/463"},"html":{"href":"https://github.com/ex-aws/ex_aws/pull/463"},"issue":{"href":"https://api.github.com/repos/ex-aws/ex_aws/issues/463"},"comments":{"href":"https://api.github.com/repos/ex-aws/ex_aws/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/ex-aws/ex_aws/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/ex-aws/ex_aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ex-aws/ex_aws/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/ex-aws/ex_aws/statuses/273c1a3faa842da0958754a99c8f7e7d05e973be"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":56,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"benwilson512"}}