{"action":"opened","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/10717","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/10717/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/10717/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/10717/events","html_url":"https://github.com/spring-projects/spring-boot/issues/10717","id":267219611,"number":10717,"title":"The Maven Assembly plugin should handle aop.xml in a better way","user":{"login":"Gilead","id":656816,"avatar_url":"https://avatars2.githubusercontent.com/u/656816?v=4","gravatar_id":"","url":"https://api.github.com/users/Gilead","html_url":"https://github.com/Gilead","followers_url":"https://api.github.com/users/Gilead/followers","following_url":"https://api.github.com/users/Gilead/following{/other_user}","gists_url":"https://api.github.com/users/Gilead/gists{/gist_id}","starred_url":"https://api.github.com/users/Gilead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gilead/subscriptions","organizations_url":"https://api.github.com/users/Gilead/orgs","repos_url":"https://api.github.com/users/Gilead/repos","events_url":"https://api.github.com/users/Gilead/events{/privacy}","received_events_url":"https://api.github.com/users/Gilead/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-20T15:47:30Z","updated_at":"2017-10-20T15:47:30Z","closed_at":null,"author_association":"NONE","body":"It seems that as a result of #7587 aop.xml is being moved out of the META-INF package by the Spring Boot Maven Assembly plugin. I'm sure it was causing issues but the result is that, from what I see, AspectJ doesn't recognise it under the BOOT-INF/... at all.\r\n\r\nI just spent an entire day fighting with the plugin to put it in a place visible to AspectJ. I finally found out that using Maven resource plugin to manually copy aop.xml to org.aspectj package works and the file is finally seen by AspectJ.\r\n\r\nIf leaving aop.xml in META-INF is not viable for some reason then perhaps the assembly plugin should move META-INF/aop.xml to BOOT-INF/classes/org/aspectj/aop.xml where it is actually seen by AspectJ.\r\n\r\nAs a test case please consider this simple configuration file:\r\n<aspectj>\r\n    <weaver options=\"-verbose\">\r\n        <dump within=\"com.example..*\" />\r\n    </weaver>\r\n</aspectj>\r\n\r\nIf you put that file into META-INF it'll be moved to BOOT-INF where it does nothing. If you include it manually in the org.aspectj package then AspectJ does see the file and acts accordingly."}}
{"actor":{"display_login":"Gilead"}}