{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/13576","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/13576/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/13576/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/13576/events","html_url":"https://github.com/Automattic/wp-calypso/pull/13576","id":225791596,"number":13576,"title":"Add grouping by territory to LanguagePickerModal","user":{"login":"jsnajdr","id":664258,"avatar_url":"https://avatars0.githubusercontent.com/u/664258?v=3","gravatar_id":"","url":"https://api.github.com/users/jsnajdr","html_url":"https://github.com/jsnajdr","followers_url":"https://api.github.com/users/jsnajdr/followers","following_url":"https://api.github.com/users/jsnajdr/following{/other_user}","gists_url":"https://api.github.com/users/jsnajdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnajdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnajdr/subscriptions","organizations_url":"https://api.github.com/users/jsnajdr/orgs","repos_url":"https://api.github.com/users/jsnajdr/repos","events_url":"https://api.github.com/users/jsnajdr/events{/privacy}","received_events_url":"https://api.github.com/users/jsnajdr/received_events","type":"User","site_admin":false},"labels":[{"id":301697869,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/OSS%20Citizen","name":"OSS Citizen","color":"5319e7","default":false},{"id":285010037,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Translator","name":"Translator","color":"006b75","default":false},{"id":542883719,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Size]%20XL","name":"[Size] XL","color":"390036","default":false},{"id":285010023,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Design%20Review","name":"[Status] Needs Design Review","color":"009800","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":285009976,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"jsnajdr","id":664258,"avatar_url":"https://avatars0.githubusercontent.com/u/664258?v=3","gravatar_id":"","url":"https://api.github.com/users/jsnajdr","html_url":"https://github.com/jsnajdr","followers_url":"https://api.github.com/users/jsnajdr/followers","following_url":"https://api.github.com/users/jsnajdr/following{/other_user}","gists_url":"https://api.github.com/users/jsnajdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnajdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnajdr/subscriptions","organizations_url":"https://api.github.com/users/jsnajdr/orgs","repos_url":"https://api.github.com/users/jsnajdr/repos","events_url":"https://api.github.com/users/jsnajdr/events{/privacy}","received_events_url":"https://api.github.com/users/jsnajdr/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsnajdr","id":664258,"avatar_url":"https://avatars0.githubusercontent.com/u/664258?v=3","gravatar_id":"","url":"https://api.github.com/users/jsnajdr","html_url":"https://github.com/jsnajdr","followers_url":"https://api.github.com/users/jsnajdr/followers","following_url":"https://api.github.com/users/jsnajdr/following{/other_user}","gists_url":"https://api.github.com/users/jsnajdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnajdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnajdr/subscriptions","organizations_url":"https://api.github.com/users/jsnajdr/orgs","repos_url":"https://api.github.com/users/jsnajdr/repos","events_url":"https://api.github.com/users/jsnajdr/events{/privacy}","received_events_url":"https://api.github.com/users/jsnajdr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2017-05-02T19:09:13Z","updated_at":"2017-05-03T13:50:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/13576","html_url":"https://github.com/Automattic/wp-calypso/pull/13576","diff_url":"https://github.com/Automattic/wp-calypso/pull/13576.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/13576.patch"},"body":"Groups the languages by territory where the language is spoken (Africa, America, Europe, ...) and shows tabs in the `LanguagePickerModal`:\r\n\r\n![language-territories](https://cloud.githubusercontent.com/assets/664258/25634404/cea37936-2f7a-11e7-9c3b-bbfb71ff5dc5.gif)\r\n\r\nVery similar to the Facebook language selection dialog.\r\n\r\n@folletto The original design doesn't have the 'Popular languages' and 'All languages' tabs, but they seem to be pretty useful nevertheless. What do you think? A little trouble with so many tabs is that the dialog needs to be at least 1000px wide to accomodate them all. Otherwise, they collapse into a dropdown menu (a standard behavior of `SectionNavTabs`):\r\n\r\n<img width=\"483\" alt=\"language-territories-collapsed\" src=\"https://cloud.githubusercontent.com/assets/664258/25634562/61bb6576-2f7b-11e7-8817-88cc0ccc9a3d.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/298916545","html_url":"https://github.com/Automattic/wp-calypso/pull/13576#issuecomment-298916545","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/13576","id":298916545,"user":{"login":"folletto","id":4389,"avatar_url":"https://avatars1.githubusercontent.com/u/4389?v=3","gravatar_id":"","url":"https://api.github.com/users/folletto","html_url":"https://github.com/folletto","followers_url":"https://api.github.com/users/folletto/followers","following_url":"https://api.github.com/users/folletto/following{/other_user}","gists_url":"https://api.github.com/users/folletto/gists{/gist_id}","starred_url":"https://api.github.com/users/folletto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folletto/subscriptions","organizations_url":"https://api.github.com/users/folletto/orgs","repos_url":"https://api.github.com/users/folletto/repos","events_url":"https://api.github.com/users/folletto/events{/privacy}","received_events_url":"https://api.github.com/users/folletto/received_events","type":"User","site_admin":false},"created_at":"2017-05-03T13:50:37Z","updated_at":"2017-05-03T13:50:37Z","body":"Ok, thanks for the clarification! Let's duplicate them in all locales where it makes sense then. \r\n\r\nI'd suggest do do a taxonomy review for these in a separate PR maybe?"}}
{"actor":{"display_login":"folletto"}}