{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/11939","repository_url":"https://api.github.com/repos/CartoDB/cartodb","labels_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11939/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11939/comments","events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11939/events","html_url":"https://github.com/CartoDB/cartodb/pull/11939","id":220175857,"number":11939,"title":"advance georefence street address","user":{"login":"matallo","id":36676,"avatar_url":"https://avatars1.githubusercontent.com/u/36676?v=3","gravatar_id":"","url":"https://api.github.com/users/matallo","html_url":"https://github.com/matallo","followers_url":"https://api.github.com/users/matallo/followers","following_url":"https://api.github.com/users/matallo/following{/other_user}","gists_url":"https://api.github.com/users/matallo/gists{/gist_id}","starred_url":"https://api.github.com/users/matallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matallo/subscriptions","organizations_url":"https://api.github.com/users/matallo/orgs","repos_url":"https://api.github.com/users/matallo/repos","events_url":"https://api.github.com/users/matallo/events{/privacy}","received_events_url":"https://api.github.com/users/matallo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2017-04-07T10:33:15Z","updated_at":"2017-04-21T15:46:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/11939","html_url":"https://github.com/CartoDB/cartodb/pull/11939","diff_url":"https://github.com/CartoDB/cartodb/pull/11939.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/11939.patch"},"body":"re: #11662 https://github.com/CartoDB/cartodb/issues/11812\r\n\r\nmany changes here:\r\n\r\n- added Toggle editor (based in Radius)\r\n- added Placeholder add-on to Codemirror\r\n- added `autocompleteChars`, `autocompleteSuffix`, `autocompletePrefix `, `autocompleteTriggers` (these two come usually together) options to Codemirror\r\n- added mustache mode to Codemirror\r\n- extend custom Textarea editor from custom Text editor\r\n- added `editor` option to custom Textarea editor, which will turn it into a Codemirror editor passing the option `editor: true` this won't have any effect for current Textarea editors\r\n- added placeholder option to Textarea custom editor\r\n- made `querySchemaModel`, and `layerDefinitionModel` optional for hints\r\n- added and extended the necessary tests for the changes above\r\n\r\n**acceptance**\r\n\r\n- current codemirror hints should keep working as usual\r\n- new textarea codemirror should appear when selecting advance in the toggle of georeference analysis\r\n- new textarea codemirror hints should appear\r\n- normal georeference analysis should work (d'oh!)\r\n- advance georeference analysis should work (d'oh!)\r\n\r\nhow to test the codemirror hints:\r\n\r\nafter writing \"{{\", or first two characters of columns, it should suggest column names, and autocomplete \"}}\" suffix, as well as \"{{\" prefix if it has not been typed\r\n\r\ncodemirror hints should work on demand with \"Ctrl + Space\" shortcut, with the same behaviour\r\n\r\nthey should work normally in previous codemirror hints such sql in data tab\r\n\r\n**STAGING**: rui servers"},"comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments/296227642","html_url":"https://github.com/CartoDB/cartodb/pull/11939#issuecomment-296227642","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11939","id":296227642,"user":{"login":"xavijam","id":132146,"avatar_url":"https://avatars0.githubusercontent.com/u/132146?v=3","gravatar_id":"","url":"https://api.github.com/users/xavijam","html_url":"https://github.com/xavijam","followers_url":"https://api.github.com/users/xavijam/followers","following_url":"https://api.github.com/users/xavijam/following{/other_user}","gists_url":"https://api.github.com/users/xavijam/gists{/gist_id}","starred_url":"https://api.github.com/users/xavijam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavijam/subscriptions","organizations_url":"https://api.github.com/users/xavijam/orgs","repos_url":"https://api.github.com/users/xavijam/repos","events_url":"https://api.github.com/users/xavijam/events{/privacy}","received_events_url":"https://api.github.com/users/xavijam/received_events","type":"User","site_admin":false},"created_at":"2017-04-21T15:46:31Z","updated_at":"2017-04-21T15:46:31Z","body":"How come? I mean, how is that possible? JS error? take into account node states come from CARTO.js."}}
{"actor":{"display_login":"xavijam"}}