{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3db/pulls/comments/124847483","pull_request_review_id":47177892,"id":124847483,"diff_hunk":"@@ -1,12 +1,15 @@\n language: go\n go:\n   - 1.7\n-install: make install-ci\n-env:\n- # Set higher timeouts for Travis\n- - TEST_TIMEOUT_SCALE=20 PACKAGE=github.com/m3db/m3db\n sudo: required\n dist: trusty\n-script:\n- - make all\n-\n+install: make install-ci\n+env:\n+  global:\n+    - TEST_TIMEOUT_SCALE=20\n+    - PACKAGE=github.com/m3db/m3db\n+  matrix:\n+    - MAKE_TARGET=\"lint test-ci-unit\"\n+    - MAKE_TARGET=\"test-ci-integration\"\n+    - MAKE_TARGET=\"services tools\"\n+script: \"make $MAKE_TARGET\"","path":".travis.yml","position":22,"original_position":22,"commit_id":"1f311067affa65eb99a363363e9398da58cdb563","original_commit_id":"9c21805cae4e129f7d171745ebd472496eaff385","user":{"login":"prateek","id":199982,"avatar_url":"https://avatars0.githubusercontent.com/u/199982?v=3","gravatar_id":"","url":"https://api.github.com/users/prateek","html_url":"https://github.com/prateek","followers_url":"https://api.github.com/users/prateek/followers","following_url":"https://api.github.com/users/prateek/following{/other_user}","gists_url":"https://api.github.com/users/prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateek/subscriptions","organizations_url":"https://api.github.com/users/prateek/orgs","repos_url":"https://api.github.com/users/prateek/repos","events_url":"https://api.github.com/users/prateek/events{/privacy}","received_events_url":"https://api.github.com/users/prateek/received_events","type":"User","site_admin":false},"body":"will do","created_at":"2017-06-29T16:20:54Z","updated_at":"2017-06-29T16:20:55Z","html_url":"https://github.com/m3db/m3db/pull/306#discussion_r124847483","pull_request_url":"https://api.github.com/repos/m3db/m3db/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3db/pulls/comments/124847483"},"html":{"href":"https://github.com/m3db/m3db/pull/306#discussion_r124847483"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3db/pulls/306","id":126335249,"html_url":"https://github.com/m3db/m3db/pull/306","diff_url":"https://github.com/m3db/m3db/pull/306.diff","patch_url":"https://github.com/m3db/m3db/pull/306.patch","issue_url":"https://api.github.com/repos/m3db/m3db/issues/306","number":306,"state":"open","locked":false,"title":"Improve Namespace Isolation","user":{"login":"prateek","id":199982,"avatar_url":"https://avatars0.githubusercontent.com/u/199982?v=3","gravatar_id":"","url":"https://api.github.com/users/prateek","html_url":"https://github.com/prateek","followers_url":"https://api.github.com/users/prateek/followers","following_url":"https://api.github.com/users/prateek/following{/other_user}","gists_url":"https://api.github.com/users/prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateek/subscriptions","organizations_url":"https://api.github.com/users/prateek/orgs","repos_url":"https://api.github.com/users/prateek/repos","events_url":"https://api.github.com/users/prateek/events{/privacy}","received_events_url":"https://api.github.com/users/prateek/received_events","type":"User","site_admin":false},"body":"Prior to this PR, RetentionOptions were global across namespaces and the commit log. This PR changes that to allow every namespace, and the database commit log to have independent retention options. \r\n\r\nMajor changes:\r\n- `namespace.Options` has a new field: `RetentionOptions`\r\n- New construct: `namespace.NamespaceRegistry` (maps namespace ID -> namespace Metadata)\r\n- Replace RetentionOptions with NamespaceRegistry in all Options\r\n- Corresponding changes to retrieve retentionOpts based on Namespace everywhere (e.g. a couple of `client.AdminClient` method, `databaseFlushManager`, `databaseCleanupManager`, etc).\r\n    - this induced a lot of interface changes, especially in tests, to pass the ns id parameter.\r\n\r\nMinor changes:\r\n- Lots more validation in various packages `Options`\r\n- Remove redundant RetentionOptions from a few places (e.g. `result.Options`)\r\n\r\nNote: we make a couple of assumptions about the retention options to simplify implementation, these are tested in `storage/Options.go:Validate`\r\n\r\n/cc @robskillington @xichen2020 @martin-mao @cw9 \r\n\r\nPending chunks:\r\n- [x] builds are :(\r\n- [x] rethink persistManager, `persist/fs/Options` usage of `RetentionOptions`\r\n- [x] cleanup manager handling of commit log cleanup \r\n- [x] repairer needs to track state per namespace\r\n- [x] commit log bootstrapper handling of multiple retentions\r\n- [x] more unit tests\r\n- [x] cleanup multiple ns integration test\r\n- [x] flush multiple ns integration test\r\n- [x] bootstrap from commit log integration test\r\n- [x] bootstrap multiple ns from commit log integration test\r\n- [ ] instrumentation for multiple namespaces\r\n","created_at":"2017-06-19T15:44:52Z","updated_at":"2017-06-29T16:20:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"805f56c8d68840475a44ef533eac4a1d0b678668","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3db/pulls/306/commits","review_comments_url":"https://api.github.com/repos/m3db/m3db/pulls/306/comments","review_comment_url":"https://api.github.com/repos/m3db/m3db/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3db/issues/306/comments","statuses_url":"https://api.github.com/repos/m3db/m3db/statuses/1f311067affa65eb99a363363e9398da58cdb563","head":{"label":"m3db:prateek/ns-isolation","ref":"prateek/ns-isolation","sha":"1f311067affa65eb99a363363e9398da58cdb563","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars3.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"name":"m3db","full_name":"m3db/m3db","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars3.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3db","description":"A distributed time series database using M3TSZ compression ","fork":false,"url":"https://api.github.com/repos/m3db/m3db","forks_url":"https://api.github.com/repos/m3db/m3db/forks","keys_url":"https://api.github.com/repos/m3db/m3db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3db/teams","hooks_url":"https://api.github.com/repos/m3db/m3db/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3db/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3db/events","assignees_url":"https://api.github.com/repos/m3db/m3db/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3db/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3db/tags","blobs_url":"https://api.github.com/repos/m3db/m3db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3db/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3db/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3db/languages","stargazers_url":"https://api.github.com/repos/m3db/m3db/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3db/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3db/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3db/subscription","commits_url":"https://api.github.com/repos/m3db/m3db/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3db/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3db/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3db/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3db/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3db/merges","archive_url":"https://api.github.com/repos/m3db/m3db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3db/downloads","issues_url":"https://api.github.com/repos/m3db/m3db/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3db/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3db/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3db/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3db/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3db/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2017-06-17T17:35:41Z","pushed_at":"2017-06-28T20:53:13Z","git_url":"git://github.com/m3db/m3db.git","ssh_url":"git@github.com:m3db/m3db.git","clone_url":"https://github.com/m3db/m3db.git","svn_url":"https://github.com/m3db/m3db","homepage":"http://uber.github.io/","size":4202,"stargazers_count":107,"watchers_count":107,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":107,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"786293a2fc5164dba1609472533f15f49916e4a6","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars3.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"name":"m3db","full_name":"m3db/m3db","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars3.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3db","description":"A distributed time series database using M3TSZ compression ","fork":false,"url":"https://api.github.com/repos/m3db/m3db","forks_url":"https://api.github.com/repos/m3db/m3db/forks","keys_url":"https://api.github.com/repos/m3db/m3db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3db/teams","hooks_url":"https://api.github.com/repos/m3db/m3db/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3db/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3db/events","assignees_url":"https://api.github.com/repos/m3db/m3db/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3db/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3db/tags","blobs_url":"https://api.github.com/repos/m3db/m3db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3db/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3db/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3db/languages","stargazers_url":"https://api.github.com/repos/m3db/m3db/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3db/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3db/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3db/subscription","commits_url":"https://api.github.com/repos/m3db/m3db/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3db/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3db/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3db/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3db/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3db/merges","archive_url":"https://api.github.com/repos/m3db/m3db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3db/downloads","issues_url":"https://api.github.com/repos/m3db/m3db/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3db/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3db/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3db/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3db/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3db/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2017-06-17T17:35:41Z","pushed_at":"2017-06-28T20:53:13Z","git_url":"git://github.com/m3db/m3db.git","ssh_url":"git@github.com:m3db/m3db.git","clone_url":"https://github.com/m3db/m3db.git","svn_url":"https://github.com/m3db/m3db","homepage":"http://uber.github.io/","size":4202,"stargazers_count":107,"watchers_count":107,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306"},"html":{"href":"https://github.com/m3db/m3db/pull/306"},"issue":{"href":"https://api.github.com/repos/m3db/m3db/issues/306"},"comments":{"href":"https://api.github.com/repos/m3db/m3db/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3db/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3db/statuses/1f311067affa65eb99a363363e9398da58cdb563"}}}}
{"actor":{"display_login":"prateek"}}