{"action":"created","comment":{"url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/comments/139420857","pull_request_review_id":63344787,"id":139420857,"diff_hunk":"@@ -0,0 +1,175 @@\n+/// @file common/src/XmlSignalFactory.cpp\n+///\n+/// The user defined signal factory class.\n+///\n+/// @par Full Description\n+/// The signal factory object to create the appropriate signal objects upon\n+/// the XML description.\n+///\n+/// @ingroup Parser\n+///\n+/// @par Copyright (c) 2017 vcdMaker team\n+///\n+/// Permission is hereby granted, free of charge, to any person obtaining a\n+/// copy of this software and associated documentation files (the \"Software\"),\n+/// to deal in the Software without restriction, including without limitation\n+/// the rights to use, copy, modify, merge, publish, distribute, sublicense,\n+/// and/or sell copies of the Software, and to permit persons to whom the\n+/// Software is furnished to do so, subject to the following conditions:\n+///\n+/// The above copyright notice and this permission notice shall be included\n+/// in all copies or substantial portions of the Software.\n+///\n+/// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS\n+/// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+/// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL\n+/// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+/// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+/// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS\n+/// IN THE SOFTWARE.\n+\n+#include \"XmlSignalFactory.h\"\n+#include \"XmlEventSignalCreator.h\"\n+#include \"XmlFSignalCreator.h\"\n+#include \"XmlISignalCreator.h\"\n+#include \"VcdException.h\"\n+\n+PARSER::XmlDescription::XmlDescription(const pugi::xml_node &rNode) :\n+        m_RegexLine(),\n+        m_Timestamp(),\n+        m_Name(),\n+        m_Value(),\n+        m_Size()\n+{\n+    for (pugi::xml_node tag : rNode.children())\n+    {\n+        if (!std::strcmp(\"line\", tag.name()))\n+        {\n+            m_RegexLine = tag.child_value();\n+        }\n+\n+        if (!std::strcmp(\"timestamp\", tag.name()))\n+        {\n+            m_Timestamp = tag.child_value();\n+        }\n+\n+        if (!std::strcmp(\"name\", tag.name()))\n+        {\n+            m_Name = tag.child_value();\n+        }\n+\n+        if (!std::strcmp(\"value\", tag.name()))\n+        {\n+            m_Value = tag.child_value();\n+        }\n+\n+        if (!std::strcmp(\"size\", tag.name()))\n+        {\n+            m_Size = tag.child_value();\n+        }\n+    }\n+}\n+\n+const std::string & PARSER::XmlDescription::GetRegex() const\n+{\n+    if (m_RegexLine.length())","path":"sources/common/src/XmlSignalFactory.cpp","position":75,"original_position":75,"commit_id":"07cf5720471c4e37edc2340194f625efd880cb11","original_commit_id":"07cf5720471c4e37edc2340194f625efd880cb11","user":{"login":"endrjux","id":688476,"avatar_url":"https://avatars2.githubusercontent.com/u/688476?v=4","gravatar_id":"","url":"https://api.github.com/users/endrjux","html_url":"https://github.com/endrjux","followers_url":"https://api.github.com/users/endrjux/followers","following_url":"https://api.github.com/users/endrjux/following{/other_user}","gists_url":"https://api.github.com/users/endrjux/gists{/gist_id}","starred_url":"https://api.github.com/users/endrjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endrjux/subscriptions","organizations_url":"https://api.github.com/users/endrjux/orgs","repos_url":"https://api.github.com/users/endrjux/repos","events_url":"https://api.github.com/users/endrjux/events{/privacy}","received_events_url":"https://api.github.com/users/endrjux/received_events","type":"User","site_admin":false},"body":"`if (!m_RegexLine.empty())`","created_at":"2017-09-18T13:26:39Z","updated_at":"2017-09-18T13:52:36Z","html_url":"https://github.com/WojciechRynczuk/vcdMaker/pull/34#discussion_r139420857","pull_request_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/comments/139420857"},"html":{"href":"https://github.com/WojciechRynczuk/vcdMaker/pull/34#discussion_r139420857"},"pull_request":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34","id":138507488,"html_url":"https://github.com/WojciechRynczuk/vcdMaker/pull/34","diff_url":"https://github.com/WojciechRynczuk/vcdMaker/pull/34.diff","patch_url":"https://github.com/WojciechRynczuk/vcdMaker/pull/34.patch","issue_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/34","number":34,"state":"open","locked":false,"title":"025 parsing user logs","user":{"login":"WojciechRynczuk","id":15857391,"avatar_url":"https://avatars2.githubusercontent.com/u/15857391?v=4","gravatar_id":"","url":"https://api.github.com/users/WojciechRynczuk","html_url":"https://github.com/WojciechRynczuk","followers_url":"https://api.github.com/users/WojciechRynczuk/followers","following_url":"https://api.github.com/users/WojciechRynczuk/following{/other_user}","gists_url":"https://api.github.com/users/WojciechRynczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechRynczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechRynczuk/subscriptions","organizations_url":"https://api.github.com/users/WojciechRynczuk/orgs","repos_url":"https://api.github.com/users/WojciechRynczuk/repos","events_url":"https://api.github.com/users/WojciechRynczuk/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechRynczuk/received_events","type":"User","site_admin":false},"body":"User log parsing. The basic functionality has been provided. @endrjux please pay attention to the cmake. I have updated it and it works. However I'm not sure if everything has been done correctly.\r\n\r\nIt also seems that we could live with one kind of the signal factory - the XML based. But once it will evolve and use more computing power I would leave the original version just for the performance reasons. If we decide to remove the original signal factory later in the future it will be an easy change.\r\n\r\nWe will add the additional functionality to this feature in the next step. Like Hex2Dec() function or arithmetic operations to create the signal's time stamp, value or name.","created_at":"2017-08-30T19:23:23Z","updated_at":"2017-09-18T13:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b31e9c2b0a5fa5d5755ab9d58a1898d401f28a16","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/milestones/2","html_url":"https://github.com/WojciechRynczuk/vcdMaker/milestone/2","labels_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/milestones/2/labels","id":2218038,"number":2,"title":"v3.0.1","description":"New features: parsing user logs, OS distribution. Enhanced: parsing VCD files.","creator":{"login":"WojciechRynczuk","id":15857391,"avatar_url":"https://avatars2.githubusercontent.com/u/15857391?v=4","gravatar_id":"","url":"https://api.github.com/users/WojciechRynczuk","html_url":"https://github.com/WojciechRynczuk","followers_url":"https://api.github.com/users/WojciechRynczuk/followers","following_url":"https://api.github.com/users/WojciechRynczuk/following{/other_user}","gists_url":"https://api.github.com/users/WojciechRynczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechRynczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechRynczuk/subscriptions","organizations_url":"https://api.github.com/users/WojciechRynczuk/orgs","repos_url":"https://api.github.com/users/WojciechRynczuk/repos","events_url":"https://api.github.com/users/WojciechRynczuk/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechRynczuk/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":18,"state":"open","created_at":"2016-12-27T21:22:12Z","updated_at":"2017-08-30T19:23:23Z","due_on":"2018-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34/commits","review_comments_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34/comments","review_comment_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/34/comments","statuses_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/statuses/07cf5720471c4e37edc2340194f625efd880cb11","head":{"label":"WojciechRynczuk:025_Parsing_user_logs","ref":"025_Parsing_user_logs","sha":"07cf5720471c4e37edc2340194f625efd880cb11","user":{"login":"WojciechRynczuk","id":15857391,"avatar_url":"https://avatars2.githubusercontent.com/u/15857391?v=4","gravatar_id":"","url":"https://api.github.com/users/WojciechRynczuk","html_url":"https://github.com/WojciechRynczuk","followers_url":"https://api.github.com/users/WojciechRynczuk/followers","following_url":"https://api.github.com/users/WojciechRynczuk/following{/other_user}","gists_url":"https://api.github.com/users/WojciechRynczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechRynczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechRynczuk/subscriptions","organizations_url":"https://api.github.com/users/WojciechRynczuk/orgs","repos_url":"https://api.github.com/users/WojciechRynczuk/repos","events_url":"https://api.github.com/users/WojciechRynczuk/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechRynczuk/received_events","type":"User","site_admin":false},"repo":{"id":46375377,"name":"vcdMaker","full_name":"WojciechRynczuk/vcdMaker","owner":{"login":"WojciechRynczuk","id":15857391,"avatar_url":"https://avatars2.githubusercontent.com/u/15857391?v=4","gravatar_id":"","url":"https://api.github.com/users/WojciechRynczuk","html_url":"https://github.com/WojciechRynczuk","followers_url":"https://api.github.com/users/WojciechRynczuk/followers","following_url":"https://api.github.com/users/WojciechRynczuk/following{/other_user}","gists_url":"https://api.github.com/users/WojciechRynczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechRynczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechRynczuk/subscriptions","organizations_url":"https://api.github.com/users/WojciechRynczuk/orgs","repos_url":"https://api.github.com/users/WojciechRynczuk/repos","events_url":"https://api.github.com/users/WojciechRynczuk/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechRynczuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WojciechRynczuk/vcdMaker","description":null,"fork":false,"url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker","forks_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/forks","keys_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/teams","hooks_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/hooks","issue_events_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/events{/number}","events_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/events","assignees_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/assignees{/user}","branches_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/branches{/branch}","tags_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/tags","blobs_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/statuses/{sha}","languages_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/languages","stargazers_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/stargazers","contributors_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/contributors","subscribers_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/subscribers","subscription_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/subscription","commits_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/contents/{+path}","compare_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/merges","archive_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/downloads","issues_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues{/number}","pulls_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls{/number}","milestones_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/milestones{/number}","notifications_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/labels{/name}","releases_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/releases{/id}","deployments_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/deployments","created_at":"2015-11-17T21:04:52Z","updated_at":"2017-06-05T22:29:05Z","pushed_at":"2017-09-17T20:54:00Z","git_url":"git://github.com/WojciechRynczuk/vcdMaker.git","ssh_url":"git@github.com:WojciechRynczuk/vcdMaker.git","clone_url":"https://github.com/WojciechRynczuk/vcdMaker.git","svn_url":"https://github.com/WojciechRynczuk/vcdMaker","homepage":null,"size":6047,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":6,"default_branch":"v3_release"}},"base":{"label":"WojciechRynczuk:v3_release","ref":"v3_release","sha":"0421f73fceea5926e8cb55585da3fadedd3e775d","user":{"login":"WojciechRynczuk","id":15857391,"avatar_url":"https://avatars2.githubusercontent.com/u/15857391?v=4","gravatar_id":"","url":"https://api.github.com/users/WojciechRynczuk","html_url":"https://github.com/WojciechRynczuk","followers_url":"https://api.github.com/users/WojciechRynczuk/followers","following_url":"https://api.github.com/users/WojciechRynczuk/following{/other_user}","gists_url":"https://api.github.com/users/WojciechRynczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechRynczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechRynczuk/subscriptions","organizations_url":"https://api.github.com/users/WojciechRynczuk/orgs","repos_url":"https://api.github.com/users/WojciechRynczuk/repos","events_url":"https://api.github.com/users/WojciechRynczuk/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechRynczuk/received_events","type":"User","site_admin":false},"repo":{"id":46375377,"name":"vcdMaker","full_name":"WojciechRynczuk/vcdMaker","owner":{"login":"WojciechRynczuk","id":15857391,"avatar_url":"https://avatars2.githubusercontent.com/u/15857391?v=4","gravatar_id":"","url":"https://api.github.com/users/WojciechRynczuk","html_url":"https://github.com/WojciechRynczuk","followers_url":"https://api.github.com/users/WojciechRynczuk/followers","following_url":"https://api.github.com/users/WojciechRynczuk/following{/other_user}","gists_url":"https://api.github.com/users/WojciechRynczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechRynczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechRynczuk/subscriptions","organizations_url":"https://api.github.com/users/WojciechRynczuk/orgs","repos_url":"https://api.github.com/users/WojciechRynczuk/repos","events_url":"https://api.github.com/users/WojciechRynczuk/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechRynczuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WojciechRynczuk/vcdMaker","description":null,"fork":false,"url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker","forks_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/forks","keys_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/teams","hooks_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/hooks","issue_events_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/events{/number}","events_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/events","assignees_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/assignees{/user}","branches_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/branches{/branch}","tags_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/tags","blobs_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/statuses/{sha}","languages_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/languages","stargazers_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/stargazers","contributors_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/contributors","subscribers_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/subscribers","subscription_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/subscription","commits_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/contents/{+path}","compare_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/merges","archive_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/downloads","issues_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues{/number}","pulls_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls{/number}","milestones_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/milestones{/number}","notifications_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/labels{/name}","releases_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/releases{/id}","deployments_url":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/deployments","created_at":"2015-11-17T21:04:52Z","updated_at":"2017-06-05T22:29:05Z","pushed_at":"2017-09-17T20:54:00Z","git_url":"git://github.com/WojciechRynczuk/vcdMaker.git","ssh_url":"git@github.com:WojciechRynczuk/vcdMaker.git","clone_url":"https://github.com/WojciechRynczuk/vcdMaker.git","svn_url":"https://github.com/WojciechRynczuk/vcdMaker","homepage":null,"size":6047,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":6,"default_branch":"v3_release"}},"_links":{"self":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34"},"html":{"href":"https://github.com/WojciechRynczuk/vcdMaker/pull/34"},"issue":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/34"},"comments":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/WojciechRynczuk/vcdMaker/statuses/07cf5720471c4e37edc2340194f625efd880cb11"}},"author_association":"OWNER"}}
{"actor":{"display_login":"endrjux"}}