{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/scope/issues/2225","repository_url":"https://api.github.com/repos/weaveworks/scope","labels_url":"https://api.github.com/repos/weaveworks/scope/issues/2225/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/scope/issues/2225/comments","events_url":"https://api.github.com/repos/weaveworks/scope/issues/2225/events","html_url":"https://github.com/weaveworks/scope/pull/2225","id":206766016,"number":2225,"title":"[WIP] integration tests: fix scripts","user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-02-10T10:54:39Z","updated_at":"2017-02-13T12:15:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/2225","html_url":"https://github.com/weaveworks/scope/pull/2225","diff_url":"https://github.com/weaveworks/scope/pull/2225.diff","patch_url":"https://github.com/weaveworks/scope/pull/2225.patch"},"body":"bin/setup-circleci-secrets: fix shell \"unbound variable\"\r\n\r\nSince this shell script uses \"set -u\", we must not use unset variables directly.\r\n\r\nSymptoms:\r\n> https://circleci.com/gh/weaveworks/scope/6384\r\n> bin/setup-circleci-secrets: line 10: SECRET_SCRIPT: unbound variable\r\n\r\nInstead, we should use the parameter expansion \"+\" to test if the variable is set. See:\r\nhttp://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02\r\n\r\n-----\r\n\r\nAlso, fix GCE --zones parameter\r\n\r\n-----\r\n\r\n@2opremio Sorry I broke the CircleCI build on master. I am marking this PR as WIP because I want to do more tests.\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/scope/issues/comments/279371636","html_url":"https://github.com/weaveworks/scope/pull/2225#issuecomment-279371636","issue_url":"https://api.github.com/repos/weaveworks/scope/issues/2225","id":279371636,"user":{"login":"2opremio","id":2362916,"avatar_url":"https://avatars.githubusercontent.com/u/2362916?v=3","gravatar_id":"","url":"https://api.github.com/users/2opremio","html_url":"https://github.com/2opremio","followers_url":"https://api.github.com/users/2opremio/followers","following_url":"https://api.github.com/users/2opremio/following{/other_user}","gists_url":"https://api.github.com/users/2opremio/gists{/gist_id}","starred_url":"https://api.github.com/users/2opremio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2opremio/subscriptions","organizations_url":"https://api.github.com/users/2opremio/orgs","repos_url":"https://api.github.com/users/2opremio/repos","events_url":"https://api.github.com/users/2opremio/events{/privacy}","received_events_url":"https://api.github.com/users/2opremio/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T12:15:59Z","updated_at":"2017-02-13T12:15:59Z","body":"> Could you try this branch on weaveworks CircleCI config?\r\n\r\nhttps://circleci.com/gh/weaveworks/scope/6416"}}
{"actor":{"display_login":"2opremio"}}