{"action":"created","issue":{"url":"https://api.github.com/repos/epurdom/clusterExperiment/issues/165","repository_url":"https://api.github.com/repos/epurdom/clusterExperiment","labels_url":"https://api.github.com/repos/epurdom/clusterExperiment/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/epurdom/clusterExperiment/issues/165/comments","events_url":"https://api.github.com/repos/epurdom/clusterExperiment/issues/165/events","html_url":"https://github.com/epurdom/clusterExperiment/issues/165","id":161099272,"number":165,"title":"plotHeatmap: support ordered factors in sampleData in the legend?","user":{"login":"allonw","id":13837252,"avatar_url":"https://avatars3.githubusercontent.com/u/13837252?v=3","gravatar_id":"","url":"https://api.github.com/users/allonw","html_url":"https://github.com/allonw","followers_url":"https://api.github.com/users/allonw/followers","following_url":"https://api.github.com/users/allonw/following{/other_user}","gists_url":"https://api.github.com/users/allonw/gists{/gist_id}","starred_url":"https://api.github.com/users/allonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allonw/subscriptions","organizations_url":"https://api.github.com/users/allonw/orgs","repos_url":"https://api.github.com/users/allonw/repos","events_url":"https://api.github.com/users/allonw/events{/privacy}","received_events_url":"https://api.github.com/users/allonw/received_events","type":"User","site_admin":false},"labels":[{"id":293503393,"url":"https://api.github.com/repos/epurdom/clusterExperiment/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":603248130,"url":"https://api.github.com/repos/epurdom/clusterExperiment/labels/Error%20that%20depends%20on%20another%20package","name":"Error that depends on another package","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-20T00:11:54Z","updated_at":"2017-06-03T22:39:39Z","closed_at":null,"body":"1. Can plotHeatmap take account of the order of ordered factors when plotting them in the legend?\n2. When one of the sampleData metadata has spaces, plotHeatmap breaks with an error that doesn't report what's wrong\n\n```\nlibrary(clusterExperiment)\n\naaa = matrix(runif(100), nrow = 10)\nanno = factor(sample.int(3, size = 10, replace = TRUE), ordered = TRUE)\nlevels(anno) = c(\"low activity\", \"medium activity\", \"high activity\")\n\n#Error in cut.default(a, breaks = 100) : 'x' must be numeric\nplotHeatmap(data = aaa, sampleData = as.data.frame(anno))\n\n#works, but ignores the order of the factor\nplotHeatmap(data = aaa, sampleData = as.data.frame(make.names(anno)))\n```\n"},"comment":{"url":"https://api.github.com/repos/epurdom/clusterExperiment/issues/comments/306005634","html_url":"https://github.com/epurdom/clusterExperiment/issues/165#issuecomment-306005634","issue_url":"https://api.github.com/repos/epurdom/clusterExperiment/issues/165","id":306005634,"user":{"login":"epurdom","id":7718485,"avatar_url":"https://avatars2.githubusercontent.com/u/7718485?v=3","gravatar_id":"","url":"https://api.github.com/users/epurdom","html_url":"https://github.com/epurdom","followers_url":"https://api.github.com/users/epurdom/followers","following_url":"https://api.github.com/users/epurdom/following{/other_user}","gists_url":"https://api.github.com/users/epurdom/gists{/gist_id}","starred_url":"https://api.github.com/users/epurdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epurdom/subscriptions","organizations_url":"https://api.github.com/users/epurdom/orgs","repos_url":"https://api.github.com/users/epurdom/repos","events_url":"https://api.github.com/users/epurdom/events{/privacy}","received_events_url":"https://api.github.com/users/epurdom/received_events","type":"User","site_admin":false},"created_at":"2017-06-03T22:39:39Z","updated_at":"2017-06-03T22:39:39Z","body":"Because problem with ordered factors in aheatmap (#184) have not added this yet as enhancement. "}}
{"actor":{"display_login":"epurdom"}}