{"action":"closed","number":4810,"pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/4810","id":115958444,"html_url":"https://github.com/discourse/discourse/pull/4810","diff_url":"https://github.com/discourse/discourse/pull/4810.diff","patch_url":"https://github.com/discourse/discourse/pull/4810.patch","issue_url":"https://api.github.com/repos/discourse/discourse/issues/4810","number":4810,"state":"closed","locked":false,"title":"Fix bench script ","user":{"login":"yjukaku","id":908365,"avatar_url":"https://avatars3.githubusercontent.com/u/908365?v=3","gravatar_id":"","url":"https://api.github.com/users/yjukaku","html_url":"https://github.com/yjukaku","followers_url":"https://api.github.com/users/yjukaku/followers","following_url":"https://api.github.com/users/yjukaku/following{/other_user}","gists_url":"https://api.github.com/users/yjukaku/gists{/gist_id}","starred_url":"https://api.github.com/users/yjukaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjukaku/subscriptions","organizations_url":"https://api.github.com/users/yjukaku/orgs","repos_url":"https://api.github.com/users/yjukaku/repos","events_url":"https://api.github.com/users/yjukaku/events{/privacy}","received_events_url":"https://api.github.com/users/yjukaku/received_events","type":"User","site_admin":false},"body":"I tried to clone Discourse so that I could work on some perf patches, but I couldn't get the bench script to work without a few tiny fixes. \r\n\r\n- 'facter' gem requires 'CFPropertyList` gem, but it's not installed automatically\r\n- the `run` method called `Kernel::exit`, which silently exits instead of telling you why. Changed to `Kernel::abort`\r\n- Email addresses created in profile_db_generator were invalid according to the User email validation regex. (Didn't allow `admin@localhost1` as a valid email)","created_at":"2017-04-14T17:02:12Z","updated_at":"2017-04-27T02:41:57Z","closed_at":"2017-04-27T02:41:57Z","merged_at":"2017-04-27T02:41:57Z","merge_commit_sha":"5404fb31f813350c61fc2c00edd0e95c7fa6d210","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse/pulls/4810/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse/pulls/4810/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/4810/comments","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/a940f727cbc63f4c67147e1b174dec9cc99858ae","head":{"label":"yjukaku:fix-minor-bench-script-bugs","ref":"fix-minor-bench-script-bugs","sha":"a940f727cbc63f4c67147e1b174dec9cc99858ae","user":{"login":"yjukaku","id":908365,"avatar_url":"https://avatars3.githubusercontent.com/u/908365?v=3","gravatar_id":"","url":"https://api.github.com/users/yjukaku","html_url":"https://github.com/yjukaku","followers_url":"https://api.github.com/users/yjukaku/followers","following_url":"https://api.github.com/users/yjukaku/following{/other_user}","gists_url":"https://api.github.com/users/yjukaku/gists{/gist_id}","starred_url":"https://api.github.com/users/yjukaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjukaku/subscriptions","organizations_url":"https://api.github.com/users/yjukaku/orgs","repos_url":"https://api.github.com/users/yjukaku/repos","events_url":"https://api.github.com/users/yjukaku/events{/privacy}","received_events_url":"https://api.github.com/users/yjukaku/received_events","type":"User","site_admin":false},"repo":{"id":88286210,"name":"discourse","full_name":"yjukaku/discourse","owner":{"login":"yjukaku","id":908365,"avatar_url":"https://avatars3.githubusercontent.com/u/908365?v=3","gravatar_id":"","url":"https://api.github.com/users/yjukaku","html_url":"https://github.com/yjukaku","followers_url":"https://api.github.com/users/yjukaku/followers","following_url":"https://api.github.com/users/yjukaku/following{/other_user}","gists_url":"https://api.github.com/users/yjukaku/gists{/gist_id}","starred_url":"https://api.github.com/users/yjukaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjukaku/subscriptions","organizations_url":"https://api.github.com/users/yjukaku/orgs","repos_url":"https://api.github.com/users/yjukaku/repos","events_url":"https://api.github.com/users/yjukaku/events{/privacy}","received_events_url":"https://api.github.com/users/yjukaku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjukaku/discourse","description":"A platform for community discussion. Free, open, simple.","fork":true,"url":"https://api.github.com/repos/yjukaku/discourse","forks_url":"https://api.github.com/repos/yjukaku/discourse/forks","keys_url":"https://api.github.com/repos/yjukaku/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjukaku/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjukaku/discourse/teams","hooks_url":"https://api.github.com/repos/yjukaku/discourse/hooks","issue_events_url":"https://api.github.com/repos/yjukaku/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/yjukaku/discourse/events","assignees_url":"https://api.github.com/repos/yjukaku/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/yjukaku/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/yjukaku/discourse/tags","blobs_url":"https://api.github.com/repos/yjukaku/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjukaku/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjukaku/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjukaku/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjukaku/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/yjukaku/discourse/languages","stargazers_url":"https://api.github.com/repos/yjukaku/discourse/stargazers","contributors_url":"https://api.github.com/repos/yjukaku/discourse/contributors","subscribers_url":"https://api.github.com/repos/yjukaku/discourse/subscribers","subscription_url":"https://api.github.com/repos/yjukaku/discourse/subscription","commits_url":"https://api.github.com/repos/yjukaku/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjukaku/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjukaku/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjukaku/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjukaku/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/yjukaku/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjukaku/discourse/merges","archive_url":"https://api.github.com/repos/yjukaku/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjukaku/discourse/downloads","issues_url":"https://api.github.com/repos/yjukaku/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/yjukaku/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/yjukaku/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/yjukaku/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjukaku/discourse/labels{/name}","releases_url":"https://api.github.com/repos/yjukaku/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/yjukaku/discourse/deployments","created_at":"2017-04-14T16:57:10Z","updated_at":"2017-04-14T16:57:25Z","pushed_at":"2017-04-14T16:58:43Z","git_url":"git://github.com/yjukaku/discourse.git","ssh_url":"git@github.com:yjukaku/discourse.git","clone_url":"https://github.com/yjukaku/discourse.git","svn_url":"https://github.com/yjukaku/discourse","homepage":"http://www.discourse.org","size":155833,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"8370b4b1b720f4bab5820a30fb0866980e4868db","user":{"login":"discourse","id":3220138,"avatar_url":"https://avatars1.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"name":"discourse","full_name":"discourse/discourse","owner":{"login":"discourse","id":3220138,"avatar_url":"https://avatars1.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2017-04-26T21:39:55Z","pushed_at":"2017-04-27T02:41:57Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"http://www.discourse.org","size":157053,"stargazers_count":21353,"watchers_count":21353,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5589,"mirror_url":null,"open_issues_count":13,"forks":5589,"open_issues":13,"watchers":21353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/4810"},"html":{"href":"https://github.com/discourse/discourse/pull/4810"},"issue":{"href":"https://api.github.com/repos/discourse/discourse/issues/4810"},"comments":{"href":"https://api.github.com/repos/discourse/discourse/issues/4810/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse/pulls/4810/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse/pulls/4810/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse/statuses/a940f727cbc63f4c67147e1b174dec9cc99858ae"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tgxworld","id":4335742,"avatar_url":"https://avatars0.githubusercontent.com/u/4335742?v=3","gravatar_id":"","url":"https://api.github.com/users/tgxworld","html_url":"https://github.com/tgxworld","followers_url":"https://api.github.com/users/tgxworld/followers","following_url":"https://api.github.com/users/tgxworld/following{/other_user}","gists_url":"https://api.github.com/users/tgxworld/gists{/gist_id}","starred_url":"https://api.github.com/users/tgxworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgxworld/subscriptions","organizations_url":"https://api.github.com/users/tgxworld/orgs","repos_url":"https://api.github.com/users/tgxworld/repos","events_url":"https://api.github.com/users/tgxworld/events{/privacy}","received_events_url":"https://api.github.com/users/tgxworld/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"tgxworld"}}