{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/156163212","pull_request_review_id":82596631,"id":156163212,"diff_hunk":"@@ -8,9 +8,22 @@\n const Linter = require(\"./linter\");\n \n module.exports = {\n-    linter: new Linter(),\n     Linter,\n     CLIEngine: require(\"./cli-engine\"),\n     RuleTester: require(\"./testers/rule-tester\"),\n     SourceCode: require(\"./util/source-code\")\n };\n+\n+let deprecatedLinterInstance = null;\n+\n+Object.defineProperty(module.exports, \"linter\", {\n+    enumerable: false,\n+    configurable: false, // Don't let people bypass the warning","path":"lib/api.js","position":15,"original_position":15,"commit_id":"1e66730419f39b17048be8c043a2a3880e4cb2f9","original_commit_id":"1e66730419f39b17048be8c043a2a3880e4cb2f9","user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars2.githubusercontent.com/u/11638619?v=4","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"body":"There is no longer a warning, so I think this comment is a bit misleading now.","created_at":"2017-12-11T18:47:27Z","updated_at":"2017-12-11T18:47:27Z","html_url":"https://github.com/eslint/eslint/pull/9692#discussion_r156163212","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/9692","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/156163212"},"html":{"href":"https://github.com/eslint/eslint/pull/9692#discussion_r156163212"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9692"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/9692","id":156865327,"html_url":"https://github.com/eslint/eslint/pull/9692","diff_url":"https://github.com/eslint/eslint/pull/9692.diff","patch_url":"https://github.com/eslint/eslint/pull/9692.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/9692","number":9692,"state":"open","locked":false,"title":"Breaking: Make require('eslint').linter non-enumerable (fixes #9270)","user":{"login":"j-f1","id":25517624,"avatar_url":"https://avatars2.githubusercontent.com/u/25517624?v=4","gravatar_id":"","url":"https://api.github.com/users/j-f1","html_url":"https://github.com/j-f1","followers_url":"https://api.github.com/users/j-f1/followers","following_url":"https://api.github.com/users/j-f1/following{/other_user}","gists_url":"https://api.github.com/users/j-f1/gists{/gist_id}","starred_url":"https://api.github.com/users/j-f1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-f1/subscriptions","organizations_url":"https://api.github.com/users/j-f1/orgs","repos_url":"https://api.github.com/users/j-f1/repos","events_url":"https://api.github.com/users/j-f1/events{/privacy}","received_events_url":"https://api.github.com/users/j-f1/received_events","type":"User","site_admin":false},"body":"<!--\r\n    ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).\r\n-->\r\n\r\n**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[ ] Documentation update\r\n[ ] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\r\n[ ] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[x] Add something to the core\r\n[ ] Other, please explain:\r\n\r\n<!--\r\n    If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\r\n-->\r\n\r\n#9270\r\n\r\n<!--\r\n    Please ensure your pull request is ready:\r\n\r\n    - Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)\r\n    - Include tests for this change\r\n    - Update documentation for this change (if appropriate)\r\n-->\r\n\r\n<!--\r\n    The following is required for all pull requests:\r\n-->\r\n\r\n**What changes did you make? (Give an overview)**\r\nI  made `require('eslint').linter` non-enumerable so people aren’t tempted to use it.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nIs this actually a breaking change? The ESLint API is small enough that I doubt anyone uses `Object.keys` on it, and it would be unfortunate to make this wait until v5, which would probably push the deprecation date back another major version.\r\n\r\n","created_at":"2017-12-06T23:15:57Z","updated_at":"2017-12-11T18:47:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0709398866e43fa55cb3ce99da0f6a800eb307d7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/9692/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/9692/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/9692/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/1e66730419f39b17048be8c043a2a3880e4cb2f9","head":{"label":"j-f1:hide-eslint.linter","ref":"hide-eslint.linter","sha":"1e66730419f39b17048be8c043a2a3880e4cb2f9","user":{"login":"j-f1","id":25517624,"avatar_url":"https://avatars2.githubusercontent.com/u/25517624?v=4","gravatar_id":"","url":"https://api.github.com/users/j-f1","html_url":"https://github.com/j-f1","followers_url":"https://api.github.com/users/j-f1/followers","following_url":"https://api.github.com/users/j-f1/following{/other_user}","gists_url":"https://api.github.com/users/j-f1/gists{/gist_id}","starred_url":"https://api.github.com/users/j-f1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-f1/subscriptions","organizations_url":"https://api.github.com/users/j-f1/orgs","repos_url":"https://api.github.com/users/j-f1/repos","events_url":"https://api.github.com/users/j-f1/events{/privacy}","received_events_url":"https://api.github.com/users/j-f1/received_events","type":"User","site_admin":false},"repo":{"id":90163461,"name":"forked-eslint","full_name":"j-f1/forked-eslint","owner":{"login":"j-f1","id":25517624,"avatar_url":"https://avatars2.githubusercontent.com/u/25517624?v=4","gravatar_id":"","url":"https://api.github.com/users/j-f1","html_url":"https://github.com/j-f1","followers_url":"https://api.github.com/users/j-f1/followers","following_url":"https://api.github.com/users/j-f1/following{/other_user}","gists_url":"https://api.github.com/users/j-f1/gists{/gist_id}","starred_url":"https://api.github.com/users/j-f1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-f1/subscriptions","organizations_url":"https://api.github.com/users/j-f1/orgs","repos_url":"https://api.github.com/users/j-f1/repos","events_url":"https://api.github.com/users/j-f1/events{/privacy}","received_events_url":"https://api.github.com/users/j-f1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j-f1/forked-eslint","description":":fork: A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/j-f1/forked-eslint","forks_url":"https://api.github.com/repos/j-f1/forked-eslint/forks","keys_url":"https://api.github.com/repos/j-f1/forked-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j-f1/forked-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j-f1/forked-eslint/teams","hooks_url":"https://api.github.com/repos/j-f1/forked-eslint/hooks","issue_events_url":"https://api.github.com/repos/j-f1/forked-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/j-f1/forked-eslint/events","assignees_url":"https://api.github.com/repos/j-f1/forked-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/j-f1/forked-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/j-f1/forked-eslint/tags","blobs_url":"https://api.github.com/repos/j-f1/forked-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j-f1/forked-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j-f1/forked-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/j-f1/forked-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j-f1/forked-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/j-f1/forked-eslint/languages","stargazers_url":"https://api.github.com/repos/j-f1/forked-eslint/stargazers","contributors_url":"https://api.github.com/repos/j-f1/forked-eslint/contributors","subscribers_url":"https://api.github.com/repos/j-f1/forked-eslint/subscribers","subscription_url":"https://api.github.com/repos/j-f1/forked-eslint/subscription","commits_url":"https://api.github.com/repos/j-f1/forked-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/j-f1/forked-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/j-f1/forked-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/j-f1/forked-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/j-f1/forked-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/j-f1/forked-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j-f1/forked-eslint/merges","archive_url":"https://api.github.com/repos/j-f1/forked-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j-f1/forked-eslint/downloads","issues_url":"https://api.github.com/repos/j-f1/forked-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/j-f1/forked-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/j-f1/forked-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/j-f1/forked-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j-f1/forked-eslint/labels{/name}","releases_url":"https://api.github.com/repos/j-f1/forked-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/j-f1/forked-eslint/deployments","created_at":"2017-05-03T15:17:47Z","updated_at":"2017-05-03T15:37:13Z","pushed_at":"2017-12-11T15:33:39Z","git_url":"git://github.com/j-f1/forked-eslint.git","ssh_url":"git@github.com:j-f1/forked-eslint.git","clone_url":"https://github.com/j-f1/forked-eslint.git","svn_url":"https://github.com/j-f1/forked-eslint","homepage":"http://eslint.org","size":17288,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"d49d9d003579d0b11feab54ddac788b9526b3eec","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars3.githubusercontent.com/u/6019716?v=4","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars3.githubusercontent.com/u/6019716?v=4","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2017-12-11T18:14:03Z","pushed_at":"2017-12-11T15:33:44Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"https://eslint.org","size":17001,"stargazers_count":9558,"watchers_count":9558,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1756,"mirror_url":null,"archived":false,"open_issues_count":255,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1756,"open_issues":255,"watchers":9558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9692"},"html":{"href":"https://github.com/eslint/eslint/pull/9692"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/9692"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/9692/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9692/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9692/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/1e66730419f39b17048be8c043a2a3880e4cb2f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"not-an-aardvark"}}