{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/150884769","pull_request_review_id":76502237,"id":150884769,"diff_hunk":"@@ -261,7 +262,7 @@ export class MatTooltip implements OnDestroy {\n     this._tooltipInstance = overlayRef.attach(portal).instance;\n \n     // Dispose of the tooltip when the overlay is detached.\n-    overlayRef.detachments().subscribe(() => {\n+    merge(this._tooltipInstance!.afterHidden(), overlayRef.detachments()).subscribe(() => {","path":"src/lib/tooltip/tooltip.ts","position":13,"original_position":13,"commit_id":"223c49b0d62cab322f99728540533d0756f578f3","original_commit_id":"95b4ea344c9ae9e4bd95476292b6ddd825c40023","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"body":"TS isn't smart enough to figure it out when it's being assigned to a property, it only works for variables.","created_at":"2017-11-14T16:23:45Z","updated_at":"2017-11-14T16:23:45Z","html_url":"https://github.com/angular/material2/pull/8385#discussion_r150884769","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/8385","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/150884769"},"html":{"href":"https://github.com/angular/material2/pull/8385#discussion_r150884769"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/8385"}},"in_reply_to_id":150720690},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/8385","id":152103657,"html_url":"https://github.com/angular/material2/pull/8385","diff_url":"https://github.com/angular/material2/pull/8385.diff","patch_url":"https://github.com/angular/material2/pull/8385.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/8385","number":8385,"state":"open","locked":false,"title":"chore(tooltip): unit test failures","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"body":"* Fixes a regression in the tooltip that was introduced by 0719c3866225874c2d900ece2554612675ce4d0b which caused the tests to fail.\r\n* Avoids issues in the future where failures in some tooltip tests can cause Jasmine to throw the browser into an infinite loop by trying to stringify a circular object.","created_at":"2017-11-12T13:15:21Z","updated_at":"2017-11-14T16:23:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96a02598b8c5e46148a303adde79321ebc2a722c","assignee":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},{"login":"andrewseguin","id":22898577,"avatar_url":"https://avatars3.githubusercontent.com/u/22898577?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewseguin","html_url":"https://github.com/andrewseguin","followers_url":"https://api.github.com/users/andrewseguin/followers","following_url":"https://api.github.com/users/andrewseguin/following{/other_user}","gists_url":"https://api.github.com/users/andrewseguin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewseguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewseguin/subscriptions","organizations_url":"https://api.github.com/users/andrewseguin/orgs","repos_url":"https://api.github.com/users/andrewseguin/repos","events_url":"https://api.github.com/users/andrewseguin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewseguin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"andrewseguin","id":22898577,"avatar_url":"https://avatars3.githubusercontent.com/u/22898577?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewseguin","html_url":"https://github.com/andrewseguin","followers_url":"https://api.github.com/users/andrewseguin/followers","following_url":"https://api.github.com/users/andrewseguin/following{/other_user}","gists_url":"https://api.github.com/users/andrewseguin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewseguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewseguin/subscriptions","organizations_url":"https://api.github.com/users/andrewseguin/orgs","repos_url":"https://api.github.com/users/andrewseguin/repos","events_url":"https://api.github.com/users/andrewseguin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewseguin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/8385/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/8385/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/8385/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/223c49b0d62cab322f99728540533d0756f578f3","head":{"label":"crisbeto:tooltip-detach-regression","ref":"tooltip-detach-regression","sha":"223c49b0d62cab322f99728540533d0756f578f3","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"repo":{"id":60285287,"name":"material2","full_name":"crisbeto/material2","owner":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crisbeto/material2","description":"Material Design components for Angular 2","fork":true,"url":"https://api.github.com/repos/crisbeto/material2","forks_url":"https://api.github.com/repos/crisbeto/material2/forks","keys_url":"https://api.github.com/repos/crisbeto/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crisbeto/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crisbeto/material2/teams","hooks_url":"https://api.github.com/repos/crisbeto/material2/hooks","issue_events_url":"https://api.github.com/repos/crisbeto/material2/issues/events{/number}","events_url":"https://api.github.com/repos/crisbeto/material2/events","assignees_url":"https://api.github.com/repos/crisbeto/material2/assignees{/user}","branches_url":"https://api.github.com/repos/crisbeto/material2/branches{/branch}","tags_url":"https://api.github.com/repos/crisbeto/material2/tags","blobs_url":"https://api.github.com/repos/crisbeto/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crisbeto/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crisbeto/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/crisbeto/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crisbeto/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/crisbeto/material2/languages","stargazers_url":"https://api.github.com/repos/crisbeto/material2/stargazers","contributors_url":"https://api.github.com/repos/crisbeto/material2/contributors","subscribers_url":"https://api.github.com/repos/crisbeto/material2/subscribers","subscription_url":"https://api.github.com/repos/crisbeto/material2/subscription","commits_url":"https://api.github.com/repos/crisbeto/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/crisbeto/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/crisbeto/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/crisbeto/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/crisbeto/material2/contents/{+path}","compare_url":"https://api.github.com/repos/crisbeto/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crisbeto/material2/merges","archive_url":"https://api.github.com/repos/crisbeto/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crisbeto/material2/downloads","issues_url":"https://api.github.com/repos/crisbeto/material2/issues{/number}","pulls_url":"https://api.github.com/repos/crisbeto/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/crisbeto/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/crisbeto/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crisbeto/material2/labels{/name}","releases_url":"https://api.github.com/repos/crisbeto/material2/releases{/id}","deployments_url":"https://api.github.com/repos/crisbeto/material2/deployments","created_at":"2016-06-02T17:50:34Z","updated_at":"2017-09-20T05:06:25Z","pushed_at":"2017-11-14T16:23:19Z","git_url":"git://github.com/crisbeto/material2.git","ssh_url":"git@github.com:crisbeto/material2.git","clone_url":"https://github.com/crisbeto/material2.git","svn_url":"https://github.com/crisbeto/material2","homepage":"https://material.angular.io/","size":11235,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"33edff5f14394c740e7c5633bb2e7ba6505cff45","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2017-11-14T14:52:02Z","pushed_at":"2017-11-14T16:23:25Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io","size":10391,"stargazers_count":11830,"watchers_count":11830,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2807,"mirror_url":null,"archived":false,"open_issues_count":903,"forks":2807,"open_issues":903,"watchers":11830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/8385"},"html":{"href":"https://github.com/angular/material2/pull/8385"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/8385"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/8385/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/8385/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/8385/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/223c49b0d62cab322f99728540533d0756f578f3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"crisbeto"}}