{"action":"created","issue":{"url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/issues/6","repository_url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint","labels_url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/issues/6/comments","events_url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/issues/6/events","html_url":"https://github.com/XenHat/SublimeLinter-contrib-lslint/issues/6","id":263734486,"number":6,"title":"Enhancement request for preprocessors support","user":{"login":"Winterwolf","id":405685,"avatar_url":"https://avatars2.githubusercontent.com/u/405685?v=4","gravatar_id":"","url":"https://api.github.com/users/Winterwolf","html_url":"https://github.com/Winterwolf","followers_url":"https://api.github.com/users/Winterwolf/followers","following_url":"https://api.github.com/users/Winterwolf/following{/other_user}","gists_url":"https://api.github.com/users/Winterwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/Winterwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Winterwolf/subscriptions","organizations_url":"https://api.github.com/users/Winterwolf/orgs","repos_url":"https://api.github.com/users/Winterwolf/repos","events_url":"https://api.github.com/users/Winterwolf/events{/privacy}","received_events_url":"https://api.github.com/users/Winterwolf/received_events","type":"User","site_admin":false},"labels":[{"id":361103993,"url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":361103994,"url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"open","locked":false,"assignee":{"login":"XenHat","id":980408,"avatar_url":"https://avatars3.githubusercontent.com/u/980408?v=4","gravatar_id":"","url":"https://api.github.com/users/XenHat","html_url":"https://github.com/XenHat","followers_url":"https://api.github.com/users/XenHat/followers","following_url":"https://api.github.com/users/XenHat/following{/other_user}","gists_url":"https://api.github.com/users/XenHat/gists{/gist_id}","starred_url":"https://api.github.com/users/XenHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XenHat/subscriptions","organizations_url":"https://api.github.com/users/XenHat/orgs","repos_url":"https://api.github.com/users/XenHat/repos","events_url":"https://api.github.com/users/XenHat/events{/privacy}","received_events_url":"https://api.github.com/users/XenHat/received_events","type":"User","site_admin":false},"assignees":[{"login":"XenHat","id":980408,"avatar_url":"https://avatars3.githubusercontent.com/u/980408?v=4","gravatar_id":"","url":"https://api.github.com/users/XenHat","html_url":"https://github.com/XenHat","followers_url":"https://api.github.com/users/XenHat/followers","following_url":"https://api.github.com/users/XenHat/following{/other_user}","gists_url":"https://api.github.com/users/XenHat/gists{/gist_id}","starred_url":"https://api.github.com/users/XenHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XenHat/subscriptions","organizations_url":"https://api.github.com/users/XenHat/orgs","repos_url":"https://api.github.com/users/XenHat/repos","events_url":"https://api.github.com/users/XenHat/events{/privacy}","received_events_url":"https://api.github.com/users/XenHat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":89,"created_at":"2017-10-08T17:27:41Z","updated_at":"2017-10-14T21:17:21Z","closed_at":null,"author_association":"NONE","body":"Here is issue that I've posted on lslint repo few days ago: https://github.com/Makopo/lslint/issues/47.\r\nMy problem is that your plugin ignores files icluded by preprocessor and produces errors about undeclared variables."},"comment":{"url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/issues/comments/336668082","html_url":"https://github.com/XenHat/SublimeLinter-contrib-lslint/issues/6#issuecomment-336668082","issue_url":"https://api.github.com/repos/XenHat/SublimeLinter-contrib-lslint/issues/6","id":336668082,"user":{"login":"buildersbrewery","id":13032004,"avatar_url":"https://avatars2.githubusercontent.com/u/13032004?v=4","gravatar_id":"","url":"https://api.github.com/users/buildersbrewery","html_url":"https://github.com/buildersbrewery","followers_url":"https://api.github.com/users/buildersbrewery/followers","following_url":"https://api.github.com/users/buildersbrewery/following{/other_user}","gists_url":"https://api.github.com/users/buildersbrewery/gists{/gist_id}","starred_url":"https://api.github.com/users/buildersbrewery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildersbrewery/subscriptions","organizations_url":"https://api.github.com/users/buildersbrewery/orgs","repos_url":"https://api.github.com/users/buildersbrewery/repos","events_url":"https://api.github.com/users/buildersbrewery/events{/privacy}","received_events_url":"https://api.github.com/users/buildersbrewery/received_events","type":"User","site_admin":false},"created_at":"2017-10-14T21:17:21Z","updated_at":"2017-10-14T21:17:21Z","author_association":"CONTRIBUTOR","body":"### Reading through `linter.py` at f01e33f thinking out loud:\r\n\r\n* https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L109-L112\r\n  > currently not used\r\n* https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L150-L152\r\n  > You can require `v1.0.6` and use `--version` now...\r\n* https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L189-L191\r\n  > The preference here changed comparing to a few days ago. Maybe eventually it would make sense to compare the version for each and decide based upon that?\r\n* Some weird chars at EOL when viewing the file via Github online, perhaps some copied Windows line-endings?\r\n  * https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L213\r\n  * https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L215\r\n* https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L55\r\n  > no need to `.strip()`\r\n* Afaik using `'...%s' % ...` or `'...%s...%s' % (..., ...)` will format the output to string as well `'...{}...{}'.format(..., ...)`. Haven't found a place where usages are compared in a way that would give a reason for either of these. Currently Sublime Text uses Python 3.3, would be nice to be able to use [formatted string literals](https://docs.python.org/3/reference/lexical_analysis.html#f-strings) from Python 3.6.\r\n* Not sure why you're casting to an int?\r\n  * https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L253-L255\r\n  * https://github.com/XenHat/SublimeLinter-contrib-lslint/blob/f01e33facaaa132eb532c19de4cf537fc7b5691f/linter.py#L115-L128"}}
{"actor":{"display_login":"buildersbrewery"}}