{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/5559","repository_url":"https://api.github.com/repos/w3c/web-platform-tests","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/5559/labels{/name}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/5559/comments","events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/5559/events","html_url":"https://github.com/w3c/web-platform-tests/pull/5559","id":221678397,"number":5559,"title":"Cleanup testharness-related code","user":{"login":"miguelao","id":2168198,"avatar_url":"https://avatars1.githubusercontent.com/u/2168198?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelao","html_url":"https://github.com/miguelao","followers_url":"https://api.github.com/users/miguelao/followers","following_url":"https://api.github.com/users/miguelao/following{/other_user}","gists_url":"https://api.github.com/users/miguelao/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelao/subscriptions","organizations_url":"https://api.github.com/users/miguelao/orgs","repos_url":"https://api.github.com/users/miguelao/repos","events_url":"https://api.github.com/users/miguelao/events{/privacy}","received_events_url":"https://api.github.com/users/miguelao/received_events","type":"User","site_admin":false},"labels":[{"id":57615399,"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/geolocation-API","name":"geolocation-API","color":"ededed","default":false},{"id":80344608,"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/wg-geolocation","name":"wg-geolocation","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-13T20:50:14Z","updated_at":"2017-04-13T20:50:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/5559","html_url":"https://github.com/w3c/web-platform-tests/pull/5559","diff_url":"https://github.com/w3c/web-platform-tests/pull/5559.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/5559.patch"},"body":"Couple of testharness-related changes to make it run correctly in Chromium: \r\n\r\n- removed usage of global `done()` function, relying instead on individual test cases (`step_func_done()` etc); this is because certain tests called the global `done()` but forgot to call the specific `this.done()`, which caused the test to timeout. Moreover, at least in `PositionOptions.https.html`, calling this global done() in a\r\n single test essentially made it race the other test cases that didn't\r\n call it.\r\n- using `step_func_done()`, `unreached_func()`, etc to simplify the  text.\r\n\r\n(This PR is related to https://crbug.com/711032)"},"comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments/294017928","html_url":"https://github.com/w3c/web-platform-tests/pull/5559#issuecomment-294017928","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/5559","id":294017928,"user":{"login":"wpt-pr-bot","id":16780864,"avatar_url":"https://avatars0.githubusercontent.com/u/16780864?v=3","gravatar_id":"","url":"https://api.github.com/users/wpt-pr-bot","html_url":"https://github.com/wpt-pr-bot","followers_url":"https://api.github.com/users/wpt-pr-bot/followers","following_url":"https://api.github.com/users/wpt-pr-bot/following{/other_user}","gists_url":"https://api.github.com/users/wpt-pr-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/wpt-pr-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpt-pr-bot/subscriptions","organizations_url":"https://api.github.com/users/wpt-pr-bot/orgs","repos_url":"https://api.github.com/users/wpt-pr-bot/repos","events_url":"https://api.github.com/users/wpt-pr-bot/events{/privacy}","received_events_url":"https://api.github.com/users/wpt-pr-bot/received_events","type":"User","site_admin":false},"created_at":"2017-04-13T20:50:16Z","updated_at":"2017-04-13T20:50:16Z","body":"Notifying @jdm and @zqzhang. *([Learn how reviewing works](https://github.com/w3c/web-platform-tests/blob/master/README.md#test-review).)*"}}
{"actor":{"display_login":"wpt-pr-bot"}}