{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/7984","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/7984/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/7984/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/7984/events","html_url":"https://github.com/Automattic/jetpack/pull/7984","id":265065251,"number":7984,"title":"Sync: Add protocol to raw urls","user":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars2.githubusercontent.com/u/1126811?v=4","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"labels":[{"id":387292582,"url":"https://api.github.com/repos/Automattic/jetpack/labels/Sync","name":"Sync","color":"006b75","default":false},{"id":199076921,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":70896532,"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Type]%20Bug","name":"[Type] Bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars2.githubusercontent.com/u/1126811?v=4","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"assignees":[{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars2.githubusercontent.com/u/1126811?v=4","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/87","html_url":"https://github.com/Automattic/jetpack/milestone/87","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/87/labels","id":2786125,"number":87,"title":"5.5","description":null,"creator":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars2.githubusercontent.com/u/1126811?v=4","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":2,"state":"open","created_at":"2017-09-22T19:52:03Z","updated_at":"2017-10-12T19:54:35Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-10-12T19:54:35Z","updated_at":"2017-10-12T20:56:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/7984","html_url":"https://github.com/Automattic/jetpack/pull/7984","diff_url":"https://github.com/Automattic/jetpack/pull/7984.diff","patch_url":"https://github.com/Automattic/jetpack/pull/7984.patch"},"body":"There's been an uptick in support tickets where connections are breaking after the site switches to https. This seems to have started with 5.2 or 5.3, likely when we deployed this PR:\r\n\r\n#5852\r\n\r\nIn that PR, we began syncing the raw home/siteurl values from the DB or from the `WP_HOME` and `WP_SITEURL` constants. As part of that work, since we were no longer calling functions like `get_home_url()` which will set the protocol to `https` when `is_ssl()` is true, the `https` change wasn't getting picked up.\r\n\r\nThis PR should fix that by adding the `is_ssl()` check and setting the protocol to `https` if so.\r\n\r\nTo test:\r\n\r\n- Run tests\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/336264478","html_url":"https://github.com/Automattic/jetpack/pull/7984#issuecomment-336264478","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/7984","id":336264478,"user":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars2.githubusercontent.com/u/1126811?v=4","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"created_at":"2017-10-12T20:56:48Z","updated_at":"2017-10-12T20:56:48Z","author_association":"CONTRIBUTOR","body":"We sync those values when we sync callables, which happens when the user visits wp-admin I believe. \r\n\r\nThe issue here isn't the protocol normalization, or that the value flip-flops. The issue is that the site isn't swapping from http to https at all. Likely because users are using methods such as htaccess or a redirect plugin, as opposed to updating the `home`/`siteurl` values in the database.\r\n\r\nWe could tell users to update the values in the db or the constant to have `https`, but I'm not sure that's practical since it still results in the user getting in touch with support and support then walking them through that."}}
{"actor":{"display_login":"ebinnion"}}