{"action":"created","comment":{"url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/comments/124335611","pull_request_review_id":46615314,"id":124335611,"diff_hunk":"@@ -27,18 +30,20 @@\n   },\n   \"homepage\": \"https://github.com/ciena-frost/frost-standard#readme\",\n   \"devDependencies\": {\n-    \"chai\": \"^3.4.1\",\n-    \"eslint\": \"^3.0.1\",\n+    \"chai\": \"^4.0.0\",\n+    \"eslint\": \"^4.1.0\",\n     \"istanbul\": \"^0.4.2\",\n-    \"mocha\": \"^2.4.2\"\n+    \"mocha\": \"^3.4.2\"\n   },\n   \"dependencies\": {\n-    \"babel-eslint\": \"^6.1.2\",\n-    \"eslint-config-standard\": \"^5.3.5\",\n+    \"babel-eslint\": \"^7.2.3\",\n+    \"eslint-config-standard\": \"^10.2.1\",\n     \"eslint-plugin-ember-standard\": \"0.0.23\",\n-    \"eslint-plugin-mocha\": \"^4.7.0\",\n+    \"eslint-plugin-import\": \"^2.2.0\",\n+    \"eslint-plugin-mocha\": \"^4.11.0\",\n+    \"eslint-plugin-node\": \"^4.2.2\",\n     \"eslint-plugin-ocd\": \"0.0.6\",\n-    \"eslint-plugin-promise\": \"^2.0.0\",\n-    \"eslint-plugin-standard\": \"^2.0.0\"\n+    \"eslint-plugin-promise\": \"^3.5.0\",\n+    \"eslint-plugin-standard\": \"^3.0.0\"","path":"package.json","position":44,"original_position":44,"commit_id":"db328c0ce83077d683536862b4b9b5de6beacd27","original_commit_id":"db328c0ce83077d683536862b4b9b5de6beacd27","user":{"login":"job13er","id":411788,"avatar_url":"https://avatars1.githubusercontent.com/u/411788?v=3","gravatar_id":"","url":"https://api.github.com/users/job13er","html_url":"https://github.com/job13er","followers_url":"https://api.github.com/users/job13er/followers","following_url":"https://api.github.com/users/job13er/following{/other_user}","gists_url":"https://api.github.com/users/job13er/gists{/gist_id}","starred_url":"https://api.github.com/users/job13er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job13er/subscriptions","organizations_url":"https://api.github.com/users/job13er/orgs","repos_url":"https://api.github.com/users/job13er/repos","events_url":"https://api.github.com/users/job13er/events{/privacy}","received_events_url":"https://api.github.com/users/job13er/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2017-06-27T17:04:10Z","updated_at":"2017-06-27T17:04:10Z","html_url":"https://github.com/ciena-frost/eslint-config-frost-standard/pull/42#discussion_r124335611","pull_request_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/comments/124335611"},"html":{"href":"https://github.com/ciena-frost/eslint-config-frost-standard/pull/42#discussion_r124335611"},"pull_request":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42","id":127734160,"html_url":"https://github.com/ciena-frost/eslint-config-frost-standard/pull/42","diff_url":"https://github.com/ciena-frost/eslint-config-frost-standard/pull/42.diff","patch_url":"https://github.com/ciena-frost/eslint-config-frost-standard/pull/42.patch","issue_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/issues/42","number":42,"state":"open","locked":false,"title":"Upgrade deps, add rules, switch to yarn","user":{"login":"job13er","id":411788,"avatar_url":"https://avatars1.githubusercontent.com/u/411788?v=3","gravatar_id":"","url":"https://api.github.com/users/job13er","html_url":"https://github.com/job13er","followers_url":"https://api.github.com/users/job13er/followers","following_url":"https://api.github.com/users/job13er/following{/other_user}","gists_url":"https://api.github.com/users/job13er/gists{/gist_id}","starred_url":"https://api.github.com/users/job13er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job13er/subscriptions","organizations_url":"https://api.github.com/users/job13er/orgs","repos_url":"https://api.github.com/users/job13er/repos","events_url":"https://api.github.com/users/job13er/events{/privacy}","received_events_url":"https://api.github.com/users/job13er/received_events","type":"User","site_admin":false},"body":"### This project uses [semver](semver.org), please check the scope of this pr:\r\n - [ ] #none# - documentation fixes and/or test additions\r\n - [ ] #patch# - backwards-compatible bug fix\r\n - [ ] #minor# - adding functionality in a backwards-compatible manner\r\n - [x] #major# - incompatible API change\r\n\r\n# CHANGELOG\r\n* **Upgraded** `eslint-config-standard` from `5.x` to `10.x`\r\n* **Added** explicit disabling of `import/first` rule to allow us to destructure `Ember` directly below import\r\n* **Added** `mocha/valid-test-descriptions` (Resolves [#38](https://github.com/ciena-frost/eslint-config-frost-standard/issues/38))\r\n* **Added** `mocha/no-mocha-arrows` (Resolves [#37](https://github.com/ciena-frost/eslint-config-frost-standard/issues/37))\r\n* **Added** `no-var` rule to enforce using `let` or `const` instead of `var`, b/c who the heck wants to use `var` anyway ;)\r\n* **Updated** documentation in `README.md` for additional rules we've added. \r\n* **Upgraded** `pr-bumper` to `3.x`\r\n* **Switched** from `npm` to `yarn` for installing dependencies. \r\n* **Added** `node@8` to build matrix. \r\n* **Added** the ability to detect consuming project name and add it to `localPrefixes` automatically, and tested it by locally installing in an app. ","created_at":"2017-06-27T16:10:00Z","updated_at":"2017-06-27T17:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"751ebf1ceb868f17787241938dd67395878a0a22","assignee":{"login":"juwara0","id":8236686,"avatar_url":"https://avatars1.githubusercontent.com/u/8236686?v=3","gravatar_id":"","url":"https://api.github.com/users/juwara0","html_url":"https://github.com/juwara0","followers_url":"https://api.github.com/users/juwara0/followers","following_url":"https://api.github.com/users/juwara0/following{/other_user}","gists_url":"https://api.github.com/users/juwara0/gists{/gist_id}","starred_url":"https://api.github.com/users/juwara0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juwara0/subscriptions","organizations_url":"https://api.github.com/users/juwara0/orgs","repos_url":"https://api.github.com/users/juwara0/repos","events_url":"https://api.github.com/users/juwara0/events{/privacy}","received_events_url":"https://api.github.com/users/juwara0/received_events","type":"User","site_admin":false},"assignees":[{"login":"juwara0","id":8236686,"avatar_url":"https://avatars1.githubusercontent.com/u/8236686?v=3","gravatar_id":"","url":"https://api.github.com/users/juwara0","html_url":"https://github.com/juwara0","followers_url":"https://api.github.com/users/juwara0/followers","following_url":"https://api.github.com/users/juwara0/following{/other_user}","gists_url":"https://api.github.com/users/juwara0/gists{/gist_id}","starred_url":"https://api.github.com/users/juwara0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juwara0/subscriptions","organizations_url":"https://api.github.com/users/juwara0/orgs","repos_url":"https://api.github.com/users/juwara0/repos","events_url":"https://api.github.com/users/juwara0/events{/privacy}","received_events_url":"https://api.github.com/users/juwara0/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42/commits","review_comments_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42/comments","review_comment_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/issues/42/comments","statuses_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/statuses/db328c0ce83077d683536862b4b9b5de6beacd27","head":{"label":"job13er:upgrade-pr-bumper","ref":"upgrade-pr-bumper","sha":"db328c0ce83077d683536862b4b9b5de6beacd27","user":{"login":"job13er","id":411788,"avatar_url":"https://avatars1.githubusercontent.com/u/411788?v=3","gravatar_id":"","url":"https://api.github.com/users/job13er","html_url":"https://github.com/job13er","followers_url":"https://api.github.com/users/job13er/followers","following_url":"https://api.github.com/users/job13er/following{/other_user}","gists_url":"https://api.github.com/users/job13er/gists{/gist_id}","starred_url":"https://api.github.com/users/job13er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job13er/subscriptions","organizations_url":"https://api.github.com/users/job13er/orgs","repos_url":"https://api.github.com/users/job13er/repos","events_url":"https://api.github.com/users/job13er/events{/privacy}","received_events_url":"https://api.github.com/users/job13er/received_events","type":"User","site_admin":false},"repo":{"id":50521634,"name":"eslint-config-frost-standard","full_name":"job13er/eslint-config-frost-standard","owner":{"login":"job13er","id":411788,"avatar_url":"https://avatars1.githubusercontent.com/u/411788?v=3","gravatar_id":"","url":"https://api.github.com/users/job13er","html_url":"https://github.com/job13er","followers_url":"https://api.github.com/users/job13er/followers","following_url":"https://api.github.com/users/job13er/following{/other_user}","gists_url":"https://api.github.com/users/job13er/gists{/gist_id}","starred_url":"https://api.github.com/users/job13er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job13er/subscriptions","organizations_url":"https://api.github.com/users/job13er/orgs","repos_url":"https://api.github.com/users/job13er/repos","events_url":"https://api.github.com/users/job13er/events{/privacy}","received_events_url":"https://api.github.com/users/job13er/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/job13er/eslint-config-frost-standard","description":"Standard ESLint rules for Frost projects","fork":true,"url":"https://api.github.com/repos/job13er/eslint-config-frost-standard","forks_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/forks","keys_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/teams","hooks_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/hooks","issue_events_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/issues/events{/number}","events_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/events","assignees_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/assignees{/user}","branches_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/branches{/branch}","tags_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/tags","blobs_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/languages","stargazers_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/stargazers","contributors_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/contributors","subscribers_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/subscribers","subscription_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/subscription","commits_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/contents/{+path}","compare_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/merges","archive_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/downloads","issues_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/issues{/number}","pulls_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/labels{/name}","releases_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/releases{/id}","deployments_url":"https://api.github.com/repos/job13er/eslint-config-frost-standard/deployments","created_at":"2016-01-27T16:41:34Z","updated_at":"2016-12-02T18:09:23Z","pushed_at":"2017-06-27T16:52:08Z","git_url":"git://github.com/job13er/eslint-config-frost-standard.git","ssh_url":"git@github.com:job13er/eslint-config-frost-standard.git","clone_url":"https://github.com/job13er/eslint-config-frost-standard.git","svn_url":"https://github.com/job13er/eslint-config-frost-standard","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciena-frost:master","ref":"master","sha":"eb5fe0d7cce0f2e1ebe461641986aac3d5993036","user":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars1.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"repo":{"id":50521616,"name":"eslint-config-frost-standard","full_name":"ciena-frost/eslint-config-frost-standard","owner":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars1.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciena-frost/eslint-config-frost-standard","description":"Standard ESLint rules for Frost projects","fork":false,"url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard","forks_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/forks","keys_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/teams","hooks_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/hooks","issue_events_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/issues/events{/number}","events_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/events","assignees_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/assignees{/user}","branches_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/branches{/branch}","tags_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/tags","blobs_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/languages","stargazers_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/stargazers","contributors_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/contributors","subscribers_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/subscribers","subscription_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/subscription","commits_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/contents/{+path}","compare_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/merges","archive_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/downloads","issues_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/issues{/number}","pulls_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/labels{/name}","releases_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/releases{/id}","deployments_url":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/deployments","created_at":"2016-01-27T16:41:17Z","updated_at":"2016-11-16T21:57:10Z","pushed_at":"2017-06-27T16:10:01Z","git_url":"git://github.com/ciena-frost/eslint-config-frost-standard.git","ssh_url":"git@github.com:ciena-frost/eslint-config-frost-standard.git","clone_url":"https://github.com/ciena-frost/eslint-config-frost-standard.git","svn_url":"https://github.com/ciena-frost/eslint-config-frost-standard","homepage":null,"size":59,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42"},"html":{"href":"https://github.com/ciena-frost/eslint-config-frost-standard/pull/42"},"issue":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/issues/42"},"comments":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/ciena-frost/eslint-config-frost-standard/statuses/db328c0ce83077d683536862b4b9b5de6beacd27"}}}}
{"actor":{"display_login":"job13er"}}