{"action":"created","issue":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1091","repository_url":"https://api.github.com/repos/graphhopper/graphhopper","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1091/labels{/name}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1091/comments","events_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1091/events","html_url":"https://github.com/graphhopper/graphhopper/pull/1091","id":236660347,"number":1091,"title":"Add Average Speed as PathDetails to Response","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"labels":[{"id":32202724,"url":"https://api.github.com/repos/graphhopper/graphhopper/labels/improvement","name":"improvement","color":"d7e102","default":false}],"state":"open","locked":false,"assignee":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"assignees":[{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2017-06-17T13:23:00Z","updated_at":"2017-08-01T01:11:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1091","html_url":"https://github.com/graphhopper/graphhopper/pull/1091","diff_url":"https://github.com/graphhopper/graphhopper/pull/1091.diff","patch_url":"https://github.com/graphhopper/graphhopper/pull/1091.patch"},"body":"Fixes #439.\r\n\r\nI added the possibility to view details of the calculated as proposed in #439. It should be very easy to extend so we can add different details. \r\n\r\nThe calculation of the PathDetails is a bit similar to Instructions and maybe in the future we might find that it makes sense to merge them, but not now.\r\n\r\nI haven't measured the performance yet, but I can do this if you like the general approach.\r\n\r\nSimplification is disabled when adding PathDetails right now.\r\n\r\nRight now I don't like two things:\r\n- The data structure, not an issue right now, but maybe if we output osm ids for continental requests? Also see the conversion in the SimpleRouteSerializer. I think, wrapping the PathDetails in a Map again, might be more efficient. Overall it is a bit too much map usage IMHO, but it seems like the right data structure ;).\r\n- The initialization happens in the GraphHopper class, right now not an issue, but once we have more details, we might want to move this somewhere else. \r\n\r\nFuture improvements:\r\nChange the way the Instructions are generated so that we generate the intervals for the instructions in the PathMerger. Then we could try to simplify points between PathDetails/Instructions without simplifying over the bounds of any of the two.\r\n"},"comment":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/comments/319239292","html_url":"https://github.com/graphhopper/graphhopper/pull/1091#issuecomment-319239292","issue_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1091","id":319239292,"user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"created_at":"2017-08-01T01:11:09Z","updated_at":"2017-08-01T01:11:09Z","body":"> What exactly do you mean with 'this'? Some elevation approximization?\r\n\r\nOh sorry, I should have clarified this a bit more :). I was talking about `PathMerger.calcAscendDescend`. This was called after we simplified the route. Now it's called before we simplify the route."}}
{"actor":{"display_login":"boldtrn"}}