{"action":"closed","number":1370,"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/1370","id":148976576,"html_url":"https://github.com/FRRouting/frr/pull/1370","diff_url":"https://github.com/FRRouting/frr/pull/1370.diff","patch_url":"https://github.com/FRRouting/frr/pull/1370.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/1370","number":1370,"state":"closed","locked":false,"title":"bgpd: fix various problems with hold/keepalive timers","user":{"login":"dslicenc","id":8268789,"avatar_url":"https://avatars2.githubusercontent.com/u/8268789?v=4","gravatar_id":"","url":"https://api.github.com/users/dslicenc","html_url":"https://github.com/dslicenc","followers_url":"https://api.github.com/users/dslicenc/followers","following_url":"https://api.github.com/users/dslicenc/following{/other_user}","gists_url":"https://api.github.com/users/dslicenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dslicenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dslicenc/subscriptions","organizations_url":"https://api.github.com/users/dslicenc/orgs","repos_url":"https://api.github.com/users/dslicenc/repos","events_url":"https://api.github.com/users/dslicenc/events{/privacy}","received_events_url":"https://api.github.com/users/dslicenc/received_events","type":"User","site_admin":false},"body":"Problem reported that we weren't adjusting the keepalive timer\r\ncorrectly when we negotiated a lower hold time learned from a\r\npeer.  While working on this, found we didn't do inheritance\r\ncorrectly at all.  This fix solves the first problem and also\r\nensures that the timers are configured correctly based on this\r\npriority order - peer defined > peer-group defined > global config.\r\nThis fix also displays the timers as \"configured\" regardless of\r\nwhich of the three locations above is used.\r\n\r\nSigned-off-by: Don Slice <dslice@cumulusnetworks.com>\r\nTesting-performed:  Manual testing successful, fix tested by\r\nsubmitter, bgp-smoke completed successfully","created_at":"2017-10-26T15:57:36Z","updated_at":"2017-11-06T16:06:13Z","closed_at":"2017-11-06T16:06:13Z","merged_at":"2017-11-06T16:06:13Z","merge_commit_sha":"f498ca82bd3a306d30bbf0a5f190772db78bc572","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mwinter-osr","id":1490788,"avatar_url":"https://avatars0.githubusercontent.com/u/1490788?v=4","gravatar_id":"","url":"https://api.github.com/users/mwinter-osr","html_url":"https://github.com/mwinter-osr","followers_url":"https://api.github.com/users/mwinter-osr/followers","following_url":"https://api.github.com/users/mwinter-osr/following{/other_user}","gists_url":"https://api.github.com/users/mwinter-osr/gists{/gist_id}","starred_url":"https://api.github.com/users/mwinter-osr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwinter-osr/subscriptions","organizations_url":"https://api.github.com/users/mwinter-osr/orgs","repos_url":"https://api.github.com/users/mwinter-osr/repos","events_url":"https://api.github.com/users/mwinter-osr/events{/privacy}","received_events_url":"https://api.github.com/users/mwinter-osr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/1370/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/1370/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/1370/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/d25e4efc52eb5e4c71f43c02991e3c9bba2388c1","head":{"label":"dslicenc:cm18408-bgp-timers","ref":"cm18408-bgp-timers","sha":"d25e4efc52eb5e4c71f43c02991e3c9bba2388c1","user":{"login":"dslicenc","id":8268789,"avatar_url":"https://avatars2.githubusercontent.com/u/8268789?v=4","gravatar_id":"","url":"https://api.github.com/users/dslicenc","html_url":"https://github.com/dslicenc","followers_url":"https://api.github.com/users/dslicenc/followers","following_url":"https://api.github.com/users/dslicenc/following{/other_user}","gists_url":"https://api.github.com/users/dslicenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dslicenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dslicenc/subscriptions","organizations_url":"https://api.github.com/users/dslicenc/orgs","repos_url":"https://api.github.com/users/dslicenc/repos","events_url":"https://api.github.com/users/dslicenc/events{/privacy}","received_events_url":"https://api.github.com/users/dslicenc/received_events","type":"User","site_admin":false},"repo":{"id":84452574,"name":"frr","full_name":"dslicenc/frr","owner":{"login":"dslicenc","id":8268789,"avatar_url":"https://avatars2.githubusercontent.com/u/8268789?v=4","gravatar_id":"","url":"https://api.github.com/users/dslicenc","html_url":"https://github.com/dslicenc","followers_url":"https://api.github.com/users/dslicenc/followers","following_url":"https://api.github.com/users/dslicenc/following{/other_user}","gists_url":"https://api.github.com/users/dslicenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dslicenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dslicenc/subscriptions","organizations_url":"https://api.github.com/users/dslicenc/orgs","repos_url":"https://api.github.com/users/dslicenc/repos","events_url":"https://api.github.com/users/dslicenc/events{/privacy}","received_events_url":"https://api.github.com/users/dslicenc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dslicenc/frr","description":"FRR - The Free Range Routing Protocol Suite, forked from Quagga","fork":true,"url":"https://api.github.com/repos/dslicenc/frr","forks_url":"https://api.github.com/repos/dslicenc/frr/forks","keys_url":"https://api.github.com/repos/dslicenc/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dslicenc/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dslicenc/frr/teams","hooks_url":"https://api.github.com/repos/dslicenc/frr/hooks","issue_events_url":"https://api.github.com/repos/dslicenc/frr/issues/events{/number}","events_url":"https://api.github.com/repos/dslicenc/frr/events","assignees_url":"https://api.github.com/repos/dslicenc/frr/assignees{/user}","branches_url":"https://api.github.com/repos/dslicenc/frr/branches{/branch}","tags_url":"https://api.github.com/repos/dslicenc/frr/tags","blobs_url":"https://api.github.com/repos/dslicenc/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dslicenc/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dslicenc/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dslicenc/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dslicenc/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/dslicenc/frr/languages","stargazers_url":"https://api.github.com/repos/dslicenc/frr/stargazers","contributors_url":"https://api.github.com/repos/dslicenc/frr/contributors","subscribers_url":"https://api.github.com/repos/dslicenc/frr/subscribers","subscription_url":"https://api.github.com/repos/dslicenc/frr/subscription","commits_url":"https://api.github.com/repos/dslicenc/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dslicenc/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dslicenc/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dslicenc/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dslicenc/frr/contents/{+path}","compare_url":"https://api.github.com/repos/dslicenc/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dslicenc/frr/merges","archive_url":"https://api.github.com/repos/dslicenc/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dslicenc/frr/downloads","issues_url":"https://api.github.com/repos/dslicenc/frr/issues{/number}","pulls_url":"https://api.github.com/repos/dslicenc/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/dslicenc/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/dslicenc/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dslicenc/frr/labels{/name}","releases_url":"https://api.github.com/repos/dslicenc/frr/releases{/id}","deployments_url":"https://api.github.com/repos/dslicenc/frr/deployments","created_at":"2017-03-09T14:42:19Z","updated_at":"2017-03-09T14:42:25Z","pushed_at":"2017-11-03T16:59:55Z","git_url":"git://github.com/dslicenc/frr.git","ssh_url":"git@github.com:dslicenc/frr.git","clone_url":"https://github.com/dslicenc/frr.git","svn_url":"https://github.com/dslicenc/frr","homepage":"","size":30907,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"6d774763d6698bf36b98e2ff26c1f27a492b8cb3","user":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"name":"frr","full_name":"FRRouting/frr","owner":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2017-11-06T03:42:10Z","pushed_at":"2017-11-06T16:06:13Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":31141,"stargazers_count":327,"watchers_count":327,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":116,"forks":121,"open_issues":116,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/1370"},"html":{"href":"https://github.com/FRRouting/frr/pull/1370"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/1370"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/1370/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/1370/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/1370/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/d25e4efc52eb5e4c71f43c02991e3c9bba2388c1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rwestphal","id":931662,"avatar_url":"https://avatars1.githubusercontent.com/u/931662?v=4","gravatar_id":"","url":"https://api.github.com/users/rwestphal","html_url":"https://github.com/rwestphal","followers_url":"https://api.github.com/users/rwestphal/followers","following_url":"https://api.github.com/users/rwestphal/following{/other_user}","gists_url":"https://api.github.com/users/rwestphal/gists{/gist_id}","starred_url":"https://api.github.com/users/rwestphal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwestphal/subscriptions","organizations_url":"https://api.github.com/users/rwestphal/orgs","repos_url":"https://api.github.com/users/rwestphal/repos","events_url":"https://api.github.com/users/rwestphal/events{/privacy}","received_events_url":"https://api.github.com/users/rwestphal/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":76,"deletions":30,"changed_files":6}}
{"actor":{"display_login":"rwestphal"}}