{"action":"created","comment":{"url":"https://api.github.com/repos/opentable/oc/pulls/comments/105218795","pull_request_review_id":26083455,"id":105218795,"diff_hunk":"@@ -2,92 +2,108 @@\n 'use strict';\n \n module.exports = {\n-  oc: {\n+  usage: 'Usage: $0 <command> [options]',\n+  commands: {\n \n     dev: {\n-      help: 'Runs a local oc test registry in order to develop and test components',\n+      cmd: 'dev <dirPath> [port] [baseUrl]',\n+      example: {\n+        cmd: '$0 dev ../all-components 3001 127.0.0.1:3001 --fallbackRegistryUrl=http://anotherhost:anotherport/'\n+      },\n+      description: 'Runs a local oc test registry in order to develop and test components',\n       options: {\n-        dirName: {\n-          help: 'The name of the directory to watch, where the components are stored'\n-        },\n-        port: {\n-          help: 'The port where to start a local oc instance. Default 3000',\n-          required: false\n-        },\n-        baseUrl:{\n-          help: 'The base url the component is hosted from. Default http://localhost:port/',\n-          required: false\n-        },\n         fallbackRegistryUrl: {\n-          help: 'Url to another registry which will be used by dev registry when component cannot be found in local registry. Example: --fallbackRegistryUrl=http://anotherhost:anotherport/',\n-          required: false\n+          description: 'Url to another registry which will be used by dev registry when component cannot be found in local registry',\n+        },\n+        hotReloading: {\n+          boolean: true,\n+          description: 'Enables hot reloading. Note: when hot reloading is set to true, each request to the component will make the registry to create a new instance for the javascript closures to be loaded, while when false the instance will be recycled between components executions',\n+          default: true\n         }\n-      }\n+      },\n+      usage: 'Usage: $0 dev <dirName> [port] [baseUrl] [options]'\n     },\n \n     init: {\n-      help: 'Creates a new empty component in the current folder',\n+      cmd: 'init <componentName>',","path":"src/cli/commands.js","position":44,"original_position":44,"commit_id":"24f003fc8a77e697e4809ed1d1c566609abdd33d","original_commit_id":"24f003fc8a77e697e4809ed1d1c566609abdd33d","user":{"login":"matteofigus","id":1789893,"avatar_url":"https://avatars1.githubusercontent.com/u/1789893?v=3","gravatar_id":"","url":"https://api.github.com/users/matteofigus","html_url":"https://github.com/matteofigus","followers_url":"https://api.github.com/users/matteofigus/followers","following_url":"https://api.github.com/users/matteofigus/following{/other_user}","gists_url":"https://api.github.com/users/matteofigus/gists{/gist_id}","starred_url":"https://api.github.com/users/matteofigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteofigus/subscriptions","organizations_url":"https://api.github.com/users/matteofigus/orgs","repos_url":"https://api.github.com/users/matteofigus/repos","events_url":"https://api.github.com/users/matteofigus/events{/privacy}","received_events_url":"https://api.github.com/users/matteofigus/received_events","type":"User","site_admin":false},"body":"shouldn't this be `init <componentName> [templateType]` ?","created_at":"2017-03-09T17:13:54Z","updated_at":"2017-03-09T17:20:20Z","html_url":"https://github.com/opentable/oc/pull/399#discussion_r105218795","pull_request_url":"https://api.github.com/repos/opentable/oc/pulls/399","_links":{"self":{"href":"https://api.github.com/repos/opentable/oc/pulls/comments/105218795"},"html":{"href":"https://github.com/opentable/oc/pull/399#discussion_r105218795"},"pull_request":{"href":"https://api.github.com/repos/opentable/oc/pulls/399"}}},"pull_request":{"url":"https://api.github.com/repos/opentable/oc/pulls/399","id":109867697,"html_url":"https://github.com/opentable/oc/pull/399","diff_url":"https://github.com/opentable/oc/pull/399.diff","patch_url":"https://github.com/opentable/oc/pull/399.patch","issue_url":"https://api.github.com/repos/opentable/oc/issues/399","number":399,"state":"open","locked":false,"title":"Changed option parser for cli","user":{"login":"jankowiakmaria","id":6817645,"avatar_url":"https://avatars1.githubusercontent.com/u/6817645?v=3","gravatar_id":"","url":"https://api.github.com/users/jankowiakmaria","html_url":"https://github.com/jankowiakmaria","followers_url":"https://api.github.com/users/jankowiakmaria/followers","following_url":"https://api.github.com/users/jankowiakmaria/following{/other_user}","gists_url":"https://api.github.com/users/jankowiakmaria/gists{/gist_id}","starred_url":"https://api.github.com/users/jankowiakmaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jankowiakmaria/subscriptions","organizations_url":"https://api.github.com/users/jankowiakmaria/orgs","repos_url":"https://api.github.com/users/jankowiakmaria/repos","events_url":"https://api.github.com/users/jankowiakmaria/events{/privacy}","received_events_url":"https://api.github.com/users/jankowiakmaria/received_events","type":"User","site_admin":false},"body":"resolves #135 \r\n\r\nDifferences:\r\n- removed `version` command (it has `version` option instead)\r\n- no description of positional arguments\r\n- added examples for each command (which should mitigate ^^)\r\n- positional argument !== option (in nomnom both types could be used interchangeably)\r\n- producing completion script is done differently (don't need additional dependencies - yargs provides completion script out of the box) - so wiki needs to be updated\r\n\r\nQuestion - should I shrinkwrap or is it done during publishing/at some other point of the process?","created_at":"2017-03-09T09:06:53Z","updated_at":"2017-03-09T17:20:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af3d3c6223c5f5457d99052cc748cfd2a7e2b30e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentable/oc/pulls/399/commits","review_comments_url":"https://api.github.com/repos/opentable/oc/pulls/399/comments","review_comment_url":"https://api.github.com/repos/opentable/oc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentable/oc/issues/399/comments","statuses_url":"https://api.github.com/repos/opentable/oc/statuses/24f003fc8a77e697e4809ed1d1c566609abdd33d","head":{"label":"opentable:cli","ref":"cli","sha":"24f003fc8a77e697e4809ed1d1c566609abdd33d","user":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"repo":{"id":29561741,"name":"oc","full_name":"opentable/oc","owner":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentable/oc","description":"OpenComponents, a framework for developing and distributing html components","fork":false,"url":"https://api.github.com/repos/opentable/oc","forks_url":"https://api.github.com/repos/opentable/oc/forks","keys_url":"https://api.github.com/repos/opentable/oc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentable/oc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentable/oc/teams","hooks_url":"https://api.github.com/repos/opentable/oc/hooks","issue_events_url":"https://api.github.com/repos/opentable/oc/issues/events{/number}","events_url":"https://api.github.com/repos/opentable/oc/events","assignees_url":"https://api.github.com/repos/opentable/oc/assignees{/user}","branches_url":"https://api.github.com/repos/opentable/oc/branches{/branch}","tags_url":"https://api.github.com/repos/opentable/oc/tags","blobs_url":"https://api.github.com/repos/opentable/oc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentable/oc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentable/oc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentable/oc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentable/oc/statuses/{sha}","languages_url":"https://api.github.com/repos/opentable/oc/languages","stargazers_url":"https://api.github.com/repos/opentable/oc/stargazers","contributors_url":"https://api.github.com/repos/opentable/oc/contributors","subscribers_url":"https://api.github.com/repos/opentable/oc/subscribers","subscription_url":"https://api.github.com/repos/opentable/oc/subscription","commits_url":"https://api.github.com/repos/opentable/oc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentable/oc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentable/oc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentable/oc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentable/oc/contents/{+path}","compare_url":"https://api.github.com/repos/opentable/oc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentable/oc/merges","archive_url":"https://api.github.com/repos/opentable/oc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentable/oc/downloads","issues_url":"https://api.github.com/repos/opentable/oc/issues{/number}","pulls_url":"https://api.github.com/repos/opentable/oc/pulls{/number}","milestones_url":"https://api.github.com/repos/opentable/oc/milestones{/number}","notifications_url":"https://api.github.com/repos/opentable/oc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentable/oc/labels{/name}","releases_url":"https://api.github.com/repos/opentable/oc/releases{/id}","deployments_url":"https://api.github.com/repos/opentable/oc/deployments","created_at":"2015-01-20T23:56:08Z","updated_at":"2017-03-09T14:03:56Z","pushed_at":"2017-03-09T14:46:58Z","git_url":"git://github.com/opentable/oc.git","ssh_url":"git@github.com:opentable/oc.git","clone_url":"https://github.com/opentable/oc.git","svn_url":"https://github.com/opentable/oc","homepage":"","size":2527,"stargazers_count":198,"watchers_count":198,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":18,"forks":43,"open_issues":18,"watchers":198,"default_branch":"master"}},"base":{"label":"opentable:master","ref":"master","sha":"f8d28fbbd67b2d185027e4d064750662df9c2261","user":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"repo":{"id":29561741,"name":"oc","full_name":"opentable/oc","owner":{"login":"opentable","id":2653541,"avatar_url":"https://avatars3.githubusercontent.com/u/2653541?v=3","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentable/oc","description":"OpenComponents, a framework for developing and distributing html components","fork":false,"url":"https://api.github.com/repos/opentable/oc","forks_url":"https://api.github.com/repos/opentable/oc/forks","keys_url":"https://api.github.com/repos/opentable/oc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentable/oc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentable/oc/teams","hooks_url":"https://api.github.com/repos/opentable/oc/hooks","issue_events_url":"https://api.github.com/repos/opentable/oc/issues/events{/number}","events_url":"https://api.github.com/repos/opentable/oc/events","assignees_url":"https://api.github.com/repos/opentable/oc/assignees{/user}","branches_url":"https://api.github.com/repos/opentable/oc/branches{/branch}","tags_url":"https://api.github.com/repos/opentable/oc/tags","blobs_url":"https://api.github.com/repos/opentable/oc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentable/oc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentable/oc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentable/oc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentable/oc/statuses/{sha}","languages_url":"https://api.github.com/repos/opentable/oc/languages","stargazers_url":"https://api.github.com/repos/opentable/oc/stargazers","contributors_url":"https://api.github.com/repos/opentable/oc/contributors","subscribers_url":"https://api.github.com/repos/opentable/oc/subscribers","subscription_url":"https://api.github.com/repos/opentable/oc/subscription","commits_url":"https://api.github.com/repos/opentable/oc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentable/oc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentable/oc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentable/oc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentable/oc/contents/{+path}","compare_url":"https://api.github.com/repos/opentable/oc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentable/oc/merges","archive_url":"https://api.github.com/repos/opentable/oc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentable/oc/downloads","issues_url":"https://api.github.com/repos/opentable/oc/issues{/number}","pulls_url":"https://api.github.com/repos/opentable/oc/pulls{/number}","milestones_url":"https://api.github.com/repos/opentable/oc/milestones{/number}","notifications_url":"https://api.github.com/repos/opentable/oc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentable/oc/labels{/name}","releases_url":"https://api.github.com/repos/opentable/oc/releases{/id}","deployments_url":"https://api.github.com/repos/opentable/oc/deployments","created_at":"2015-01-20T23:56:08Z","updated_at":"2017-03-09T14:03:56Z","pushed_at":"2017-03-09T14:46:58Z","git_url":"git://github.com/opentable/oc.git","ssh_url":"git@github.com:opentable/oc.git","clone_url":"https://github.com/opentable/oc.git","svn_url":"https://github.com/opentable/oc","homepage":"","size":2527,"stargazers_count":198,"watchers_count":198,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":18,"forks":43,"open_issues":18,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentable/oc/pulls/399"},"html":{"href":"https://github.com/opentable/oc/pull/399"},"issue":{"href":"https://api.github.com/repos/opentable/oc/issues/399"},"comments":{"href":"https://api.github.com/repos/opentable/oc/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/opentable/oc/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/opentable/oc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentable/oc/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/opentable/oc/statuses/24f003fc8a77e697e4809ed1d1c566609abdd33d"}}}}
{"actor":{"display_login":"matteofigus"}}