{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/123502164","pull_request_review_id":45710589,"id":123502164,"diff_hunk":"@@ -236,9 +236,12 @@ protected override void OnLayout(bool changed, int l, int t, int r, int b)\n \t\t\t\t\tif (child == null)\n \t\t\t\t\t\tcontinue;\n \t\t\t\t\tIVisualElementRenderer renderer = Android.Platform.GetRenderer(child);\n-\t\t\t\t\tvar navigationRenderer = renderer as NavigationPageRenderer;\n-\t\t\t\t\tif (navigationRenderer != null)\n+\t\t\t\t\tif (renderer is NavigationPageRenderer navigationRenderer)","path":"Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs","position":6,"original_position":6,"commit_id":"9ece46020777df938afdcb49caac769a73cdf73a","original_commit_id":"9ece46020777df938afdcb49caac769a73cdf73a","user":{"login":"rmarinho","id":1235097,"avatar_url":"https://avatars0.githubusercontent.com/u/1235097?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarinho","html_url":"https://github.com/rmarinho","followers_url":"https://api.github.com/users/rmarinho/followers","following_url":"https://api.github.com/users/rmarinho/following{/other_user}","gists_url":"https://api.github.com/users/rmarinho/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarinho/subscriptions","organizations_url":"https://api.github.com/users/rmarinho/orgs","repos_url":"https://api.github.com/users/rmarinho/repos","events_url":"https://api.github.com/users/rmarinho/events{/privacy}","received_events_url":"https://api.github.com/users/rmarinho/received_events","type":"User","site_admin":false},"body":"can't use c#7 yet","created_at":"2017-06-22T12:58:08Z","updated_at":"2017-06-22T12:58:08Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/999#discussion_r123502164","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/123502164"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/999#discussion_r123502164"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999","id":126164205,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/999","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/999.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/999.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/999","number":999,"state":"open","locked":false,"title":"[Android] Redraw NavigationPage upon TabbedPage's tab visibility change","user":{"login":"adrianknight89","id":16855542,"avatar_url":"https://avatars1.githubusercontent.com/u/16855542?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianknight89","html_url":"https://github.com/adrianknight89","followers_url":"https://api.github.com/users/adrianknight89/followers","following_url":"https://api.github.com/users/adrianknight89/following{/other_user}","gists_url":"https://api.github.com/users/adrianknight89/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianknight89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianknight89/subscriptions","organizations_url":"https://api.github.com/users/adrianknight89/orgs","repos_url":"https://api.github.com/users/adrianknight89/repos","events_url":"https://api.github.com/users/adrianknight89/events{/privacy}","received_events_url":"https://api.github.com/users/adrianknight89/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\n#365 accounted for the visibility state of `TabLayout` in a `TabbedPage` during initialization, but setting `tabsHeight` to 0 during runtime does not seem to trigger re-draw of a `NavigationPage`.\r\n\r\n`OnLayout` seems to be measuring and laying out `TabLayout` and `ViewPager` fields. For `NavigationPage`, it was setting `ContainerPadding` to the appropriate number. By invalidating and requesting layout, `NavigationPage` can be redrawn based on the new container padding.\r\n\r\nPlease see user sample in the bug description.\r\n\r\n### Bugs Fixed ###\r\n\r\n- https://bugzilla.xamarin.com/show_bug.cgi?id=56305\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n","created_at":"2017-06-17T18:41:49Z","updated_at":"2017-06-22T12:58:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"323c11bac08db4987251bc44054b33f888e2a7ea","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/999/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/9ece46020777df938afdcb49caac769a73cdf73a","head":{"label":"adrianknight89:b1","ref":"b1","sha":"9ece46020777df938afdcb49caac769a73cdf73a","user":{"login":"adrianknight89","id":16855542,"avatar_url":"https://avatars1.githubusercontent.com/u/16855542?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianknight89","html_url":"https://github.com/adrianknight89","followers_url":"https://api.github.com/users/adrianknight89/followers","following_url":"https://api.github.com/users/adrianknight89/following{/other_user}","gists_url":"https://api.github.com/users/adrianknight89/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianknight89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianknight89/subscriptions","organizations_url":"https://api.github.com/users/adrianknight89/orgs","repos_url":"https://api.github.com/users/adrianknight89/repos","events_url":"https://api.github.com/users/adrianknight89/events{/privacy}","received_events_url":"https://api.github.com/users/adrianknight89/received_events","type":"User","site_admin":false},"repo":{"id":67881694,"name":"Xamarin.Forms","full_name":"adrianknight89/Xamarin.Forms","owner":{"login":"adrianknight89","id":16855542,"avatar_url":"https://avatars1.githubusercontent.com/u/16855542?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianknight89","html_url":"https://github.com/adrianknight89","followers_url":"https://api.github.com/users/adrianknight89/followers","following_url":"https://api.github.com/users/adrianknight89/following{/other_user}","gists_url":"https://api.github.com/users/adrianknight89/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianknight89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianknight89/subscriptions","organizations_url":"https://api.github.com/users/adrianknight89/orgs","repos_url":"https://api.github.com/users/adrianknight89/repos","events_url":"https://api.github.com/users/adrianknight89/events{/privacy}","received_events_url":"https://api.github.com/users/adrianknight89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrianknight89/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms","forks_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/adrianknight89/Xamarin.Forms/deployments","created_at":"2016-09-10T16:25:42Z","updated_at":"2016-09-10T16:25:46Z","pushed_at":"2017-06-19T13:19:06Z","git_url":"git://github.com/adrianknight89/Xamarin.Forms.git","ssh_url":"git@github.com:adrianknight89/Xamarin.Forms.git","clone_url":"https://github.com/adrianknight89/Xamarin.Forms.git","svn_url":"https://github.com/adrianknight89/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":21006,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"c0a55911ac66caff70dfbefb83a3dcb69c991025","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars3.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars3.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2017-06-21T19:49:11Z","pushed_at":"2017-06-22T12:11:09Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":23725,"stargazers_count":1431,"watchers_count":1431,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":582,"mirror_url":null,"open_issues_count":53,"forks":582,"open_issues":53,"watchers":1431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/999"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/999"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/999/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/999/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/9ece46020777df938afdcb49caac769a73cdf73a"}}}}
{"actor":{"display_login":"rmarinho"}}