{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/147214959","pull_request_review_id":72280135,"id":147214959,"diff_hunk":"@@ -274,7 +274,10 @@ func (p *parser) recvMsg(maxReceiveMessageSize int) (pf payloadFormat, msg []byt\n \tif length == 0 {\n \t\treturn pf, nil, nil\n \t}\n-\tif length > uint32(maxReceiveMessageSize) {\n+\tif int64(length) > int64(maxInt) {\n+\t\treturn 0, nil, Errorf(codes.ResourceExhausted, \"grpc: received message larger than max length allowed on current machine(%d vs. %d)\", length, maxInt)","path":"rpc_util.go","position":6,"original_position":6,"commit_id":"e5087716fcb103fe5ad780fcbbf9710dc111ceae","original_commit_id":"e5087716fcb103fe5ad780fcbbf9710dc111ceae","user":{"login":"dfawley","id":26072277,"avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"body":"Nit: missing space before open paren in string.","created_at":"2017-10-26T17:39:34Z","updated_at":"2017-10-26T17:43:59Z","html_url":"https://github.com/grpc/grpc-go/pull/1623#discussion_r147214959","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1623","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/147214959"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1623#discussion_r147214959"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1623"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/1623","id":148769825,"html_url":"https://github.com/grpc/grpc-go/pull/1623","diff_url":"https://github.com/grpc/grpc-go/pull/1623.diff","patch_url":"https://github.com/grpc/grpc-go/pull/1623.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/1623","number":1623,"state":"open","locked":false,"title":"fix max msg size type issues on different arch","user":{"login":"lyuxuan","id":426013,"avatar_url":"https://avatars1.githubusercontent.com/u/426013?v=4","gravatar_id":"","url":"https://api.github.com/users/lyuxuan","html_url":"https://github.com/lyuxuan","followers_url":"https://api.github.com/users/lyuxuan/followers","following_url":"https://api.github.com/users/lyuxuan/following{/other_user}","gists_url":"https://api.github.com/users/lyuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/lyuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyuxuan/subscriptions","organizations_url":"https://api.github.com/users/lyuxuan/orgs","repos_url":"https://api.github.com/users/lyuxuan/repos","events_url":"https://api.github.com/users/lyuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/lyuxuan/received_events","type":"User","site_admin":false},"body":"* Allow service config msg size field to be in range int64.\r\n * On 32-bit machine, it will then be capped to int32\r\n\r\nValue range:\r\n32-bit system: User API: int32, Service Config: int32, Max allowed slice length: int32, Max by spec: uint32\r\n64-bit system: User API: int64, Service Config: int64, Max allowed slice length: int64, Max by spec: uint32\r\n\r\n\r\n","created_at":"2017-10-25T20:16:18Z","updated_at":"2017-10-26T17:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09de4ac80e91227084b340fa473a06baad4f461b","assignee":{"login":"dfawley","id":26072277,"avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"assignees":[{"login":"dfawley","id":26072277,"avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1623/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1623/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/1623/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/e5087716fcb103fe5ad780fcbbf9710dc111ceae","head":{"label":"lyuxuan:fix_cap_size","ref":"fix_cap_size","sha":"e5087716fcb103fe5ad780fcbbf9710dc111ceae","user":{"login":"lyuxuan","id":426013,"avatar_url":"https://avatars1.githubusercontent.com/u/426013?v=4","gravatar_id":"","url":"https://api.github.com/users/lyuxuan","html_url":"https://github.com/lyuxuan","followers_url":"https://api.github.com/users/lyuxuan/followers","following_url":"https://api.github.com/users/lyuxuan/following{/other_user}","gists_url":"https://api.github.com/users/lyuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/lyuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyuxuan/subscriptions","organizations_url":"https://api.github.com/users/lyuxuan/orgs","repos_url":"https://api.github.com/users/lyuxuan/repos","events_url":"https://api.github.com/users/lyuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/lyuxuan/received_events","type":"User","site_admin":false},"repo":{"id":80772337,"name":"grpc-go","full_name":"lyuxuan/grpc-go","owner":{"login":"lyuxuan","id":426013,"avatar_url":"https://avatars1.githubusercontent.com/u/426013?v=4","gravatar_id":"","url":"https://api.github.com/users/lyuxuan","html_url":"https://github.com/lyuxuan","followers_url":"https://api.github.com/users/lyuxuan/followers","following_url":"https://api.github.com/users/lyuxuan/following{/other_user}","gists_url":"https://api.github.com/users/lyuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/lyuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyuxuan/subscriptions","organizations_url":"https://api.github.com/users/lyuxuan/orgs","repos_url":"https://api.github.com/users/lyuxuan/repos","events_url":"https://api.github.com/users/lyuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/lyuxuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lyuxuan/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/lyuxuan/grpc-go","forks_url":"https://api.github.com/repos/lyuxuan/grpc-go/forks","keys_url":"https://api.github.com/repos/lyuxuan/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyuxuan/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyuxuan/grpc-go/teams","hooks_url":"https://api.github.com/repos/lyuxuan/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/lyuxuan/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/lyuxuan/grpc-go/events","assignees_url":"https://api.github.com/repos/lyuxuan/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/lyuxuan/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/lyuxuan/grpc-go/tags","blobs_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyuxuan/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/lyuxuan/grpc-go/languages","stargazers_url":"https://api.github.com/repos/lyuxuan/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/lyuxuan/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/lyuxuan/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/lyuxuan/grpc-go/subscription","commits_url":"https://api.github.com/repos/lyuxuan/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyuxuan/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyuxuan/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyuxuan/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/lyuxuan/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyuxuan/grpc-go/merges","archive_url":"https://api.github.com/repos/lyuxuan/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyuxuan/grpc-go/downloads","issues_url":"https://api.github.com/repos/lyuxuan/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/lyuxuan/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/lyuxuan/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/lyuxuan/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyuxuan/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/lyuxuan/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/lyuxuan/grpc-go/deployments","created_at":"2017-02-02T21:53:58Z","updated_at":"2017-02-02T21:54:00Z","pushed_at":"2017-10-26T01:07:22Z","git_url":"git://github.com/lyuxuan/grpc-go.git","ssh_url":"git@github.com:lyuxuan/grpc-go.git","clone_url":"https://github.com/lyuxuan/grpc-go.git","svn_url":"https://github.com/lyuxuan/grpc-go","homepage":"","size":5184,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"33ee217d11ef7aaab6ea2d9b2530ad6c57199243","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2017-10-26T01:16:50Z","pushed_at":"2017-10-26T17:05:18Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":4311,"stargazers_count":4130,"watchers_count":4130,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":772,"mirror_url":null,"archived":false,"open_issues_count":108,"forks":772,"open_issues":108,"watchers":4130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1623"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1623"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1623"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1623/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1623/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1623/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/e5087716fcb103fe5ad780fcbbf9710dc111ceae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dfawley"}}