{"action":"created","comment":{"url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/comments/146665900","pull_request_review_id":71641220,"id":146665900,"diff_hunk":"@@ -1218,6 +1238,10 @@ static int mongo_cursor_op_query( mongo_cursor *cursor ) {\n \n     if( cursor->reply->fields.num == 1 ) {\n         bson_init_finished_data( &temp, &cursor->reply->objs, 0 );\n+\n+        if( mongo_check_bson_overflow( temp.dataSize, cursor ) == MONGO_ERROR )","path":"src/mongo.c","position":32,"original_position":32,"commit_id":"16f3f0757a60ba9dd85fe3b1ffe693d9d7977208","original_commit_id":"16f3f0757a60ba9dd85fe3b1ffe693d9d7977208","user":{"login":"adeelamin15","id":16396026,"avatar_url":"https://avatars0.githubusercontent.com/u/16396026?v=4","gravatar_id":"","url":"https://api.github.com/users/adeelamin15","html_url":"https://github.com/adeelamin15","followers_url":"https://api.github.com/users/adeelamin15/followers","following_url":"https://api.github.com/users/adeelamin15/following{/other_user}","gists_url":"https://api.github.com/users/adeelamin15/gists{/gist_id}","starred_url":"https://api.github.com/users/adeelamin15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeelamin15/subscriptions","organizations_url":"https://api.github.com/users/adeelamin15/orgs","repos_url":"https://api.github.com/users/adeelamin15/repos","events_url":"https://api.github.com/users/adeelamin15/events{/privacy}","received_events_url":"https://api.github.com/users/adeelamin15/received_events","type":"User","site_admin":false},"body":"@arsaha-elastica Please note that we cannot switch this function towards end when we are returning MONGO_OK since that is failing gridfs UT case. Also we cannot add this sanity check with `mongo_cursor_get_more` with additional check for NULL cursor->data since it would have no effect as curosr->data is set to NULL just before returning MONGO_OK\r\n```\r\n1311 \r\n1312         cursor->current.data = NULL;\r\n1313         cursor->seen += cursor->reply->fields.num;\r\n1314 \r\n```","created_at":"2017-10-24T19:21:18Z","updated_at":"2017-10-24T19:21:18Z","html_url":"https://github.com/Elastica/mongo-c-driver-legacy/pull/2#discussion_r146665900","pull_request_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/comments/146665900"},"html":{"href":"https://github.com/Elastica/mongo-c-driver-legacy/pull/2#discussion_r146665900"},"pull_request":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2","id":148212589,"html_url":"https://github.com/Elastica/mongo-c-driver-legacy/pull/2","diff_url":"https://github.com/Elastica/mongo-c-driver-legacy/pull/2.diff","patch_url":"https://github.com/Elastica/mongo-c-driver-legacy/pull/2.patch","issue_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/2","number":2,"state":"open","locked":false,"title":"Refs #68814 sanitizing mongo response length","user":{"login":"adeelamin15","id":16396026,"avatar_url":"https://avatars0.githubusercontent.com/u/16396026?v=4","gravatar_id":"","url":"https://api.github.com/users/adeelamin15","html_url":"https://github.com/adeelamin15","followers_url":"https://api.github.com/users/adeelamin15/followers","following_url":"https://api.github.com/users/adeelamin15/following{/other_user}","gists_url":"https://api.github.com/users/adeelamin15/gists{/gist_id}","starred_url":"https://api.github.com/users/adeelamin15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeelamin15/subscriptions","organizations_url":"https://api.github.com/users/adeelamin15/orgs","repos_url":"https://api.github.com/users/adeelamin15/repos","events_url":"https://api.github.com/users/adeelamin15/events{/privacy}","received_events_url":"https://api.github.com/users/adeelamin15/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-23T18:58:13Z","updated_at":"2017-10-24T19:21:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ea167ca9f12151bea5f599176a25d6d03b2ca30","assignee":{"login":"arsaha-elastica","id":18272682,"avatar_url":"https://avatars0.githubusercontent.com/u/18272682?v=4","gravatar_id":"","url":"https://api.github.com/users/arsaha-elastica","html_url":"https://github.com/arsaha-elastica","followers_url":"https://api.github.com/users/arsaha-elastica/followers","following_url":"https://api.github.com/users/arsaha-elastica/following{/other_user}","gists_url":"https://api.github.com/users/arsaha-elastica/gists{/gist_id}","starred_url":"https://api.github.com/users/arsaha-elastica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsaha-elastica/subscriptions","organizations_url":"https://api.github.com/users/arsaha-elastica/orgs","repos_url":"https://api.github.com/users/arsaha-elastica/repos","events_url":"https://api.github.com/users/arsaha-elastica/events{/privacy}","received_events_url":"https://api.github.com/users/arsaha-elastica/received_events","type":"User","site_admin":false},"assignees":[{"login":"arsaha-elastica","id":18272682,"avatar_url":"https://avatars0.githubusercontent.com/u/18272682?v=4","gravatar_id":"","url":"https://api.github.com/users/arsaha-elastica","html_url":"https://github.com/arsaha-elastica","followers_url":"https://api.github.com/users/arsaha-elastica/followers","following_url":"https://api.github.com/users/arsaha-elastica/following{/other_user}","gists_url":"https://api.github.com/users/arsaha-elastica/gists{/gist_id}","starred_url":"https://api.github.com/users/arsaha-elastica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsaha-elastica/subscriptions","organizations_url":"https://api.github.com/users/arsaha-elastica/orgs","repos_url":"https://api.github.com/users/arsaha-elastica/repos","events_url":"https://api.github.com/users/arsaha-elastica/events{/privacy}","received_events_url":"https://api.github.com/users/arsaha-elastica/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/2/comments","statuses_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/statuses/16f3f0757a60ba9dd85fe3b1ffe693d9d7977208","head":{"label":"Elastica:private-adeelamin-68814","ref":"private-adeelamin-68814","sha":"16f3f0757a60ba9dd85fe3b1ffe693d9d7977208","user":{"login":"Elastica","id":1830374,"avatar_url":"https://avatars3.githubusercontent.com/u/1830374?v=4","gravatar_id":"","url":"https://api.github.com/users/Elastica","html_url":"https://github.com/Elastica","followers_url":"https://api.github.com/users/Elastica/followers","following_url":"https://api.github.com/users/Elastica/following{/other_user}","gists_url":"https://api.github.com/users/Elastica/gists{/gist_id}","starred_url":"https://api.github.com/users/Elastica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elastica/subscriptions","organizations_url":"https://api.github.com/users/Elastica/orgs","repos_url":"https://api.github.com/users/Elastica/repos","events_url":"https://api.github.com/users/Elastica/events{/privacy}","received_events_url":"https://api.github.com/users/Elastica/received_events","type":"Organization","site_admin":false},"repo":{"id":15458550,"name":"mongo-c-driver-legacy","full_name":"Elastica/mongo-c-driver-legacy","owner":{"login":"Elastica","id":1830374,"avatar_url":"https://avatars3.githubusercontent.com/u/1830374?v=4","gravatar_id":"","url":"https://api.github.com/users/Elastica","html_url":"https://github.com/Elastica","followers_url":"https://api.github.com/users/Elastica/followers","following_url":"https://api.github.com/users/Elastica/following{/other_user}","gists_url":"https://api.github.com/users/Elastica/gists{/gist_id}","starred_url":"https://api.github.com/users/Elastica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elastica/subscriptions","organizations_url":"https://api.github.com/users/Elastica/orgs","repos_url":"https://api.github.com/users/Elastica/repos","events_url":"https://api.github.com/users/Elastica/events{/privacy}","received_events_url":"https://api.github.com/users/Elastica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elastica/mongo-c-driver-legacy","description":"C Driver for MongoDB","fork":true,"url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy","forks_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/forks","keys_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/teams","hooks_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/hooks","issue_events_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/events","assignees_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/tags","blobs_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/languages","stargazers_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/stargazers","contributors_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/contributors","subscribers_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/subscribers","subscription_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/subscription","commits_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/merges","archive_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/downloads","issues_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/labels{/name}","releases_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/releases{/id}","deployments_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/deployments","created_at":"2013-12-26T19:02:06Z","updated_at":"2016-05-24T20:15:33Z","pushed_at":"2017-10-24T19:13:40Z","git_url":"git://github.com/Elastica/mongo-c-driver-legacy.git","ssh_url":"git@github.com:Elastica/mongo-c-driver-legacy.git","clone_url":"https://github.com/Elastica/mongo-c-driver-legacy.git","svn_url":"https://github.com/Elastica/mongo-c-driver-legacy","homepage":"http://www.mongodb.org/","size":4695,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Elastica:master","ref":"master","sha":"a63671b342f2295c397907848beb040ddce525ec","user":{"login":"Elastica","id":1830374,"avatar_url":"https://avatars3.githubusercontent.com/u/1830374?v=4","gravatar_id":"","url":"https://api.github.com/users/Elastica","html_url":"https://github.com/Elastica","followers_url":"https://api.github.com/users/Elastica/followers","following_url":"https://api.github.com/users/Elastica/following{/other_user}","gists_url":"https://api.github.com/users/Elastica/gists{/gist_id}","starred_url":"https://api.github.com/users/Elastica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elastica/subscriptions","organizations_url":"https://api.github.com/users/Elastica/orgs","repos_url":"https://api.github.com/users/Elastica/repos","events_url":"https://api.github.com/users/Elastica/events{/privacy}","received_events_url":"https://api.github.com/users/Elastica/received_events","type":"Organization","site_admin":false},"repo":{"id":15458550,"name":"mongo-c-driver-legacy","full_name":"Elastica/mongo-c-driver-legacy","owner":{"login":"Elastica","id":1830374,"avatar_url":"https://avatars3.githubusercontent.com/u/1830374?v=4","gravatar_id":"","url":"https://api.github.com/users/Elastica","html_url":"https://github.com/Elastica","followers_url":"https://api.github.com/users/Elastica/followers","following_url":"https://api.github.com/users/Elastica/following{/other_user}","gists_url":"https://api.github.com/users/Elastica/gists{/gist_id}","starred_url":"https://api.github.com/users/Elastica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elastica/subscriptions","organizations_url":"https://api.github.com/users/Elastica/orgs","repos_url":"https://api.github.com/users/Elastica/repos","events_url":"https://api.github.com/users/Elastica/events{/privacy}","received_events_url":"https://api.github.com/users/Elastica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elastica/mongo-c-driver-legacy","description":"C Driver for MongoDB","fork":true,"url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy","forks_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/forks","keys_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/teams","hooks_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/hooks","issue_events_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/events","assignees_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/tags","blobs_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/languages","stargazers_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/stargazers","contributors_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/contributors","subscribers_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/subscribers","subscription_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/subscription","commits_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/merges","archive_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/downloads","issues_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/labels{/name}","releases_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/releases{/id}","deployments_url":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/deployments","created_at":"2013-12-26T19:02:06Z","updated_at":"2016-05-24T20:15:33Z","pushed_at":"2017-10-24T19:13:40Z","git_url":"git://github.com/Elastica/mongo-c-driver-legacy.git","ssh_url":"git@github.com:Elastica/mongo-c-driver-legacy.git","clone_url":"https://github.com/Elastica/mongo-c-driver-legacy.git","svn_url":"https://github.com/Elastica/mongo-c-driver-legacy","homepage":"http://www.mongodb.org/","size":4695,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2"},"html":{"href":"https://github.com/Elastica/mongo-c-driver-legacy/pull/2"},"issue":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/2"},"comments":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Elastica/mongo-c-driver-legacy/statuses/16f3f0757a60ba9dd85fe3b1ffe693d9d7977208"}},"author_association":"NONE"}}
{"actor":{"display_login":"adeelamin15"}}