{"action":"created","issue":{"url":"https://api.github.com/repos/modelica/Modelica/issues/1899","repository_url":"https://api.github.com/repos/modelica/Modelica","labels_url":"https://api.github.com/repos/modelica/Modelica/issues/1899/labels{/name}","comments_url":"https://api.github.com/repos/modelica/Modelica/issues/1899/comments","events_url":"https://api.github.com/repos/modelica/Modelica/issues/1899/events","html_url":"https://github.com/modelica/Modelica/issues/1899","id":200855269,"number":1899,"title":"ModelicaStandardTables_*_read handling is fragile","user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":34290269,"url":"https://api.github.com/repos/modelica/Modelica/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"MartinOtter","id":7248038,"avatar_url":"https://avatars.githubusercontent.com/u/7248038?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinOtter","html_url":"https://github.com/MartinOtter","followers_url":"https://api.github.com/users/MartinOtter/followers","following_url":"https://api.github.com/users/MartinOtter/following{/other_user}","gists_url":"https://api.github.com/users/MartinOtter/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinOtter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinOtter/subscriptions","organizations_url":"https://api.github.com/users/MartinOtter/orgs","repos_url":"https://api.github.com/users/MartinOtter/repos","events_url":"https://api.github.com/users/MartinOtter/events{/privacy}","received_events_url":"https://api.github.com/users/MartinOtter/received_events","type":"User","site_admin":false},"assignees":[{"login":"MartinOtter","id":7248038,"avatar_url":"https://avatars.githubusercontent.com/u/7248038?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinOtter","html_url":"https://github.com/MartinOtter","followers_url":"https://api.github.com/users/MartinOtter/followers","following_url":"https://api.github.com/users/MartinOtter/following{/other_user}","gists_url":"https://api.github.com/users/MartinOtter/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinOtter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinOtter/subscriptions","organizations_url":"https://api.github.com/users/MartinOtter/orgs","repos_url":"https://api.github.com/users/MartinOtter/repos","events_url":"https://api.github.com/users/MartinOtter/events{/privacy}","received_events_url":"https://api.github.com/users/MartinOtter/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/modelica/Modelica/milestones/58","html_url":"https://github.com/modelica/Modelica/milestone/58","labels_url":"https://api.github.com/repos/modelica/Modelica/milestones/58/labels","id":2251023,"number":58,"title":"MSL3.2.2","description":"","creator":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":142,"state":"closed","created_at":"2017-01-13T19:32:33Z","updated_at":"2017-01-15T08:02:28Z","due_on":"2016-03-11T08:00:00Z","closed_at":"2017-01-14T19:27:32Z"},"comments":38,"created_at":"2017-01-15T08:02:28Z","updated_at":"2017-01-15T08:09:43Z","closed_at":null,"body":"**Reported by hansolsson on 29 Jan 2016 16:05 UTC**\nThe functions ModelicaStandardTables_\\*_read are somewhat fragile in some scenarios. If they are not called for the specific table after the constructor and before the \\*_getValue calls it will just silently return 0.0.\n\nIt would suggest calling \\*_read (with force=false) at the start of \\*_getValue, or possibly inline the test to make it more efficient.\nI could add it myself if agreed on (would just be a few lines).\n\nAnother possibility would just be to generate an error message for this case. I find that less good, but still better than the current variant of silent failure is problematic.\n\nI'm aware of #1103, and I agree that the possibility of re-reading the table is an argument for having it as two functions - but I don't like the implications in terms of error handling.\n\n----\n\nMigrated-From: https://trac.modelica.org/Modelica/ticket/1899"},"comment":{"url":"https://api.github.com/repos/modelica/Modelica/issues/comments/272680507","html_url":"https://github.com/modelica/Modelica/issues/1899#issuecomment-272680507","issue_url":"https://api.github.com/repos/modelica/Modelica/issues/1899","id":272680507,"user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"created_at":"2017-01-15T08:09:43Z","updated_at":"2017-01-15T08:09:43Z","body":"**Changelog modified by otter on 26 Feb 2016 12:06 UTC**\nInitialization of Blocks.Tables.XXX and Blocks.Sources.CombiTimeTable changed, so that the tables are read from file in the constructor. It is then possible to stop a simulation and continue simulation also if tables are contained in the model"}}
{"actor":{"display_login":"modelica-trac-importer"}}