{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14888","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14888/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14888/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14888/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14888","id":210423394,"number":14888,"title":"ExtensionMessageEvent has return type of boolean","user":{"login":"NN---","id":580536,"avatar_url":"https://avatars1.githubusercontent.com/u/580536?v=3","gravatar_id":"","url":"https://api.github.com/users/NN---","html_url":"https://github.com/NN---","followers_url":"https://api.github.com/users/NN---/followers","following_url":"https://api.github.com/users/NN---/following{/other_user}","gists_url":"https://api.github.com/users/NN---/gists{/gist_id}","starred_url":"https://api.github.com/users/NN---/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NN---/subscriptions","organizations_url":"https://api.github.com/users/NN---/orgs","repos_url":"https://api.github.com/users/NN---/repos","events_url":"https://api.github.com/users/NN---/events{/privacy}","received_events_url":"https://api.github.com/users/NN---/received_events","type":"User","site_admin":false},"labels":[{"id":395679059,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-27T09:00:06Z","updated_at":"2017-03-21T00:35:46Z","closed_at":"2017-03-21T00:35:46Z","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14888","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14888","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14888.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14888.patch"},"body":"According to documentation function may return boolean.\r\nhttps://developer.chrome.com/extensions/runtime#event-onMessage\r\n\r\n```\r\nThis function becomes invalid when the event listener returns, unless you return **true** from the event listener to indicate you wish to send a response asynchronously (this will keep the message channel open to the other end until sendResponse is called). \r\n```\r\n\r\nPlease fill in this template.\r\n\r\n- [X] Make your PR against the `master` branch.\r\n- [X] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [X] Test the change in your own code. (Compile and run.)\r\n- [X] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [X] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [X] Run `tsc` without errors.\r\n- [X] Run `npm run lint package-name` if a `tslint.json` is present.\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [X] Provide a URL to documentation or source code which provides context for the suggested changes: https://developer.chrome.com/extensions/runtime#event-onMessage\r\n- [X] Increase the version number in the header if appropriate."},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/287940975","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14888#issuecomment-287940975","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14888","id":287940975,"user":{"login":"paulvanbrenk","id":5273975,"avatar_url":"https://avatars2.githubusercontent.com/u/5273975?v=3","gravatar_id":"","url":"https://api.github.com/users/paulvanbrenk","html_url":"https://github.com/paulvanbrenk","followers_url":"https://api.github.com/users/paulvanbrenk/followers","following_url":"https://api.github.com/users/paulvanbrenk/following{/other_user}","gists_url":"https://api.github.com/users/paulvanbrenk/gists{/gist_id}","starred_url":"https://api.github.com/users/paulvanbrenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulvanbrenk/subscriptions","organizations_url":"https://api.github.com/users/paulvanbrenk/orgs","repos_url":"https://api.github.com/users/paulvanbrenk/repos","events_url":"https://api.github.com/users/paulvanbrenk/events{/privacy}","received_events_url":"https://api.github.com/users/paulvanbrenk/received_events","type":"User","site_admin":false},"created_at":"2017-03-21T00:35:46Z","updated_at":"2017-03-21T00:35:46Z","body":"Closing, please re-open when you've made the requested changes."}}
{"actor":{"display_login":"paulvanbrenk"}}