{"action":"created","issue":{"url":"https://api.github.com/repos/cncjs/cncjs/issues/133","repository_url":"https://api.github.com/repos/cncjs/cncjs","labels_url":"https://api.github.com/repos/cncjs/cncjs/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/cncjs/cncjs/issues/133/comments","events_url":"https://api.github.com/repos/cncjs/cncjs/issues/133/events","html_url":"https://github.com/cncjs/cncjs/issues/133","id":208587325,"number":133,"title":"Buffer Overflow / Unexpected Responses","user":{"login":"andrewismoody","id":25835568,"avatar_url":"https://avatars.githubusercontent.com/u/25835568?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewismoody","html_url":"https://github.com/andrewismoody","followers_url":"https://api.github.com/users/andrewismoody/followers","following_url":"https://api.github.com/users/andrewismoody/following{/other_user}","gists_url":"https://api.github.com/users/andrewismoody/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewismoody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewismoody/subscriptions","organizations_url":"https://api.github.com/users/andrewismoody/orgs","repos_url":"https://api.github.com/users/andrewismoody/repos","events_url":"https://api.github.com/users/andrewismoody/events{/privacy}","received_events_url":"https://api.github.com/users/andrewismoody/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-02-17T23:45:55Z","updated_at":"2017-02-18T05:00:19Z","closed_at":null,"body":"I'm not 100% sure on this, but I've been troubleshooting an issue with my gcode files being sent to GRBL incorrectly.  I get weird responses back about missing words and incorrect number fomats, which leads me to believe the buffer is overflowing.\r\nI poked around quite a bit today trying to understand what's going on, and the best I can tell, the issue is with the periodic status queries that are sent on a timer outside of the sender queue, written directly to the serial port.  I'm looking at GrblContoller.js, line 319 and 324.  I don't think, the way it's written, that these commands are being counted toward the buffer count.  I think it would be better to inject them into the sender queue and allow the buffer counter to include those bytes to prevent buffer overflow.\r\nBut I might not be reading it correctly.\r\nAfter thinking about this for a few minutes, I thought that maybe the status queries should be injected at regular intervals into the sender queue as part of the file parser.  This would eliminate race conditions and the hypothesized buffer overflows as well.  Or maybe once every time the sender queue while loop is entered so it doesn't get called too frequently for many very small commands."},"comment":{"url":"https://api.github.com/repos/cncjs/cncjs/issues/comments/280822281","html_url":"https://github.com/cncjs/cncjs/issues/133#issuecomment-280822281","issue_url":"https://api.github.com/repos/cncjs/cncjs/issues/133","id":280822281,"user":{"login":"cheton","id":447801,"avatar_url":"https://avatars.githubusercontent.com/u/447801?v=3","gravatar_id":"","url":"https://api.github.com/users/cheton","html_url":"https://github.com/cheton","followers_url":"https://api.github.com/users/cheton/followers","following_url":"https://api.github.com/users/cheton/following{/other_user}","gists_url":"https://api.github.com/users/cheton/gists{/gist_id}","starred_url":"https://api.github.com/users/cheton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheton/subscriptions","organizations_url":"https://api.github.com/users/cheton/orgs","repos_url":"https://api.github.com/users/cheton/repos","events_url":"https://api.github.com/users/cheton/events{/privacy}","received_events_url":"https://api.github.com/users/cheton/received_events","type":"User","site_admin":false},"created_at":"2017-02-18T05:00:19Z","updated_at":"2017-02-18T05:00:19Z","body":"I will provide a hot fix update later today for both 1.8.x release and 1.9.x pre-release."}}
{"actor":{"display_login":"cheton"}}