{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/4","id":141098332,"html_url":"https://github.com/tsugehara/akashic-atsumaru-template/pull/4","diff_url":"https://github.com/tsugehara/akashic-atsumaru-template/pull/4.diff","patch_url":"https://github.com/tsugehara/akashic-atsumaru-template/pull/4.patch","issue_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/issues/4","number":4,"state":"open","locked":false,"title":"PoC: シークバーの挙動を実装","user":{"login":"xnv","id":16988148,"avatar_url":"https://avatars0.githubusercontent.com/u/16988148?v=4","gravatar_id":"","url":"https://api.github.com/users/xnv","html_url":"https://github.com/xnv","followers_url":"https://api.github.com/users/xnv/followers","following_url":"https://api.github.com/users/xnv/following{/other_user}","gists_url":"https://api.github.com/users/xnv/gists{/gist_id}","starred_url":"https://api.github.com/users/xnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnv/subscriptions","organizations_url":"https://api.github.com/users/xnv/orgs","repos_url":"https://api.github.com/users/xnv/repos","events_url":"https://api.github.com/users/xnv/events{/privacy}","received_events_url":"https://api.github.com/users/xnv/received_events","type":"User","site_admin":false},"body":"シークバーの挙動に試験的な実装を加えました。\r\n\r\n## 主な機能的変更\r\n\r\n- シークバーの再生・ポーズボタンの挙動を実装しました\r\n- シークバーの余白クリック時のシーク動作を実装しました\r\n- 再生速度倍率ボタンをクリックした時の挙動を実装しました\r\n- プレイ完了時点で暗黙かつ自動的にプレイ状態に復帰するようにしました\r\n\r\n## 主なソースコードの変更\r\n\r\n- lib/TimeKeeper.js と lib/PlaybackController.js を追加\r\n  - ビュー非依存の時間管理と内部モジュール制御を集約しています\r\n- init.js で PlaybackController を利用してシークバーの挙動を実装\r\n  - ビューへの依存はここに(暫定的に？)まとまっているようなのでここで処理します\r\n- 一部ビューの操作はやむなく animation.js に加えました\r\n\r\n## 補足\r\n\r\n- Proof of Concept です。必ずしもマージすべき品質でないかもしれません。\r\n  - akashic-atsumaru-plugin というパッケージと一部処理が重複しています。\r\n- 特に animation.js に深入りせずにおいたため、必ずしも理想的な挙動でないであろう部分があります。\r\n  - 高速リプレイでリプレイ完了すると高速なままプレイに復帰します。\r\n    - animation.js が倍率の表示を独自に管理しているので、その構造を変えないと速度表示を戻せません。\r\n  - シークバーのつまみをドラッグする操作は実装していません。\r\n    - やることは本質的にはシークバークリック時と同じだと思います。\r\n    - 感覚的には、過去方向へのドラッグをリアルタイムに再現するとジャンプしまくることになるので、過去方向に限ってはドロップ時に初めてジャンプするような制限が必要かもしれません。\r\n- `window.RPGAtsumaru` がない場合には、オンメモリにセーブする処理を加えました。\r\n- アツマール投稿時の動作は確認していません。","created_at":"2017-09-14T14:59:25Z","updated_at":"2017-09-14T14:59:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/4/commits","review_comments_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/4/comments","review_comment_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/issues/4/comments","statuses_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/statuses/e2b5aebe07bfd990d36b772145438735224b3967","head":{"label":"xnv:features/seekbar-impl","ref":"features/seekbar-impl","sha":"e2b5aebe07bfd990d36b772145438735224b3967","user":{"login":"xnv","id":16988148,"avatar_url":"https://avatars0.githubusercontent.com/u/16988148?v=4","gravatar_id":"","url":"https://api.github.com/users/xnv","html_url":"https://github.com/xnv","followers_url":"https://api.github.com/users/xnv/followers","following_url":"https://api.github.com/users/xnv/following{/other_user}","gists_url":"https://api.github.com/users/xnv/gists{/gist_id}","starred_url":"https://api.github.com/users/xnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnv/subscriptions","organizations_url":"https://api.github.com/users/xnv/orgs","repos_url":"https://api.github.com/users/xnv/repos","events_url":"https://api.github.com/users/xnv/events{/privacy}","received_events_url":"https://api.github.com/users/xnv/received_events","type":"User","site_admin":false},"repo":{"id":103543050,"name":"akashic-atsumaru-template","full_name":"xnv/akashic-atsumaru-template","owner":{"login":"xnv","id":16988148,"avatar_url":"https://avatars0.githubusercontent.com/u/16988148?v=4","gravatar_id":"","url":"https://api.github.com/users/xnv","html_url":"https://github.com/xnv","followers_url":"https://api.github.com/users/xnv/followers","following_url":"https://api.github.com/users/xnv/following{/other_user}","gists_url":"https://api.github.com/users/xnv/gists{/gist_id}","starred_url":"https://api.github.com/users/xnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnv/subscriptions","organizations_url":"https://api.github.com/users/xnv/orgs","repos_url":"https://api.github.com/users/xnv/repos","events_url":"https://api.github.com/users/xnv/events{/privacy}","received_events_url":"https://api.github.com/users/xnv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xnv/akashic-atsumaru-template","description":null,"fork":true,"url":"https://api.github.com/repos/xnv/akashic-atsumaru-template","forks_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/forks","keys_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/teams","hooks_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/hooks","issue_events_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/issues/events{/number}","events_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/events","assignees_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/assignees{/user}","branches_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/branches{/branch}","tags_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/tags","blobs_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/statuses/{sha}","languages_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/languages","stargazers_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/stargazers","contributors_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/contributors","subscribers_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/subscribers","subscription_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/subscription","commits_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/contents/{+path}","compare_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/merges","archive_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/downloads","issues_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/issues{/number}","pulls_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/pulls{/number}","milestones_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/milestones{/number}","notifications_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/labels{/name}","releases_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/releases{/id}","deployments_url":"https://api.github.com/repos/xnv/akashic-atsumaru-template/deployments","created_at":"2017-09-14T14:32:25Z","updated_at":"2017-09-14T14:32:26Z","pushed_at":"2017-09-14T14:46:25Z","git_url":"git://github.com/xnv/akashic-atsumaru-template.git","ssh_url":"git@github.com:xnv/akashic-atsumaru-template.git","clone_url":"https://github.com/xnv/akashic-atsumaru-template.git","svn_url":"https://github.com/xnv/akashic-atsumaru-template","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tsugehara:features/seekbar","ref":"features/seekbar","sha":"b73241223f8b519766da77ce5d86f59e0083ad7d","user":{"login":"tsugehara","id":3073429,"avatar_url":"https://avatars1.githubusercontent.com/u/3073429?v=4","gravatar_id":"","url":"https://api.github.com/users/tsugehara","html_url":"https://github.com/tsugehara","followers_url":"https://api.github.com/users/tsugehara/followers","following_url":"https://api.github.com/users/tsugehara/following{/other_user}","gists_url":"https://api.github.com/users/tsugehara/gists{/gist_id}","starred_url":"https://api.github.com/users/tsugehara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsugehara/subscriptions","organizations_url":"https://api.github.com/users/tsugehara/orgs","repos_url":"https://api.github.com/users/tsugehara/repos","events_url":"https://api.github.com/users/tsugehara/events{/privacy}","received_events_url":"https://api.github.com/users/tsugehara/received_events","type":"User","site_admin":false},"repo":{"id":96099723,"name":"akashic-atsumaru-template","full_name":"tsugehara/akashic-atsumaru-template","owner":{"login":"tsugehara","id":3073429,"avatar_url":"https://avatars1.githubusercontent.com/u/3073429?v=4","gravatar_id":"","url":"https://api.github.com/users/tsugehara","html_url":"https://github.com/tsugehara","followers_url":"https://api.github.com/users/tsugehara/followers","following_url":"https://api.github.com/users/tsugehara/following{/other_user}","gists_url":"https://api.github.com/users/tsugehara/gists{/gist_id}","starred_url":"https://api.github.com/users/tsugehara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsugehara/subscriptions","organizations_url":"https://api.github.com/users/tsugehara/orgs","repos_url":"https://api.github.com/users/tsugehara/repos","events_url":"https://api.github.com/users/tsugehara/events{/privacy}","received_events_url":"https://api.github.com/users/tsugehara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsugehara/akashic-atsumaru-template","description":null,"fork":false,"url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template","forks_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/forks","keys_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/teams","hooks_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/hooks","issue_events_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/issues/events{/number}","events_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/events","assignees_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/assignees{/user}","branches_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/branches{/branch}","tags_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/tags","blobs_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/statuses/{sha}","languages_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/languages","stargazers_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/stargazers","contributors_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/contributors","subscribers_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/subscribers","subscription_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/subscription","commits_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/contents/{+path}","compare_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/merges","archive_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/downloads","issues_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/issues{/number}","pulls_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls{/number}","milestones_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/milestones{/number}","notifications_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/labels{/name}","releases_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/releases{/id}","deployments_url":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/deployments","created_at":"2017-07-03T10:32:50Z","updated_at":"2017-07-03T11:52:14Z","pushed_at":"2017-08-14T11:19:36Z","git_url":"git://github.com/tsugehara/akashic-atsumaru-template.git","ssh_url":"git@github.com:tsugehara/akashic-atsumaru-template.git","clone_url":"https://github.com/tsugehara/akashic-atsumaru-template.git","svn_url":"https://github.com/tsugehara/akashic-atsumaru-template","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/4"},"html":{"href":"https://github.com/tsugehara/akashic-atsumaru-template/pull/4"},"issue":{"href":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/issues/4"},"comments":{"href":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/tsugehara/akashic-atsumaru-template/statuses/e2b5aebe07bfd990d36b772145438735224b3967"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":616,"deletions":30,"changed_files":9}}
{"actor":{"display_login":"xnv"}}