{"action":"created","comment":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments/153946808","pull_request_review_id":80034376,"id":153946808,"diff_hunk":"@@ -366,12 +365,10 @@ - (void)timerDidFire\n {\n     OWSAssert([NSThread isMainThread]);\n \n-    // FIXME SHARINGEXTENSION\n-    //    if ([UIApplication sharedApplication].applicationState != UIApplicationStateActive) {\n-    //        // Don't run when inactive.\n-    //        OWSFail(@\"%@ Disappearing messages job timer fired while app inactive.\", self.logTag);\n-    //        return;\n-    //    }\n+    if (!CurrentAppContext().isMainAppAndActive) {","path":"SignalServiceKit/src/Messages/OWSDisappearingMessagesJob.m","position":35,"original_position":35,"commit_id":"16cf1ab2b7242c56bd9aecf88b75e3ba01f93e74","original_commit_id":"16cf1ab2b7242c56bd9aecf88b75e3ba01f93e74","user":{"login":"michaelkirk","id":217057,"avatar_url":"https://avatars3.githubusercontent.com/u/217057?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkirk","html_url":"https://github.com/michaelkirk","followers_url":"https://api.github.com/users/michaelkirk/followers","following_url":"https://api.github.com/users/michaelkirk/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk/orgs","repos_url":"https://api.github.com/users/michaelkirk/repos","events_url":"https://api.github.com/users/michaelkirk/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk/received_events","type":"User","site_admin":false},"body":"Did you intend to lose this assert?, or do we want something more like:\r\n\r\n```\r\nif (CurrentAppContext().isMainApp) {\r\n    OWSAssert(CurrentAppContext().isMainAppAndActive);\r\n}\r\n```\r\n\r\n","created_at":"2017-11-29T23:31:49Z","updated_at":"2017-11-29T23:44:47Z","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2828#discussion_r153946808","pull_request_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments/153946808"},"html":{"href":"https://github.com/WhisperSystems/Signal-iOS/pull/2828#discussion_r153946808"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828"}}},"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828","id":155458472,"html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2828","diff_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2828.diff","patch_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2828.patch","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2828","number":2828,"state":"open","locked":false,"title":"Charlesmchen/address sharing extension tod os","user":{"login":"charlesmchen","id":625803,"avatar_url":"https://avatars1.githubusercontent.com/u/625803?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen","html_url":"https://github.com/charlesmchen","followers_url":"https://api.github.com/users/charlesmchen/followers","following_url":"https://api.github.com/users/charlesmchen/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen/orgs","repos_url":"https://api.github.com/users/charlesmchen/repos","events_url":"https://api.github.com/users/charlesmchen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen/received_events","type":"User","site_admin":false},"body":"### This PR will need to be rebased after the spike PR is merged.\r\n\r\nPTAL @michaelkirk ","created_at":"2017-11-29T21:33:58Z","updated_at":"2017-11-29T23:44:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"515a61352369460d06e614b78f22501beeb9659b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828/commits","review_comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828/comments","review_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2828/comments","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/16cf1ab2b7242c56bd9aecf88b75e3ba01f93e74","head":{"label":"WhisperSystems:charlesmchen/addressSharingExtensionTODOs","ref":"charlesmchen/addressSharingExtensionTODOs","sha":"16cf1ab2b7242c56bd9aecf88b75e3ba01f93e74","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"WhisperSystems/Signal-iOS","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-iOS","description":"A private messenger for iOS","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2017-11-29T13:39:12Z","pushed_at":"2017-11-29T23:01:04Z","git_url":"git://github.com/WhisperSystems/Signal-iOS.git","ssh_url":"git@github.com:WhisperSystems/Signal-iOS.git","clone_url":"https://github.com/WhisperSystems/Signal-iOS.git","svn_url":"https://github.com/WhisperSystems/Signal-iOS","homepage":"https://whispersystems.org/","size":87418,"stargazers_count":3020,"watchers_count":3020,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":715,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":715,"open_issues":324,"watchers":3020,"default_branch":"master"}},"base":{"label":"WhisperSystems:charlesmchen/sharingExtension","ref":"charlesmchen/sharingExtension","sha":"364ba35065040eba8b08478d488e9087accfe395","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"WhisperSystems/Signal-iOS","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-iOS","description":"A private messenger for iOS","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2017-11-29T13:39:12Z","pushed_at":"2017-11-29T23:01:04Z","git_url":"git://github.com/WhisperSystems/Signal-iOS.git","ssh_url":"git@github.com:WhisperSystems/Signal-iOS.git","clone_url":"https://github.com/WhisperSystems/Signal-iOS.git","svn_url":"https://github.com/WhisperSystems/Signal-iOS","homepage":"https://whispersystems.org/","size":87418,"stargazers_count":3020,"watchers_count":3020,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":715,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":715,"open_issues":324,"watchers":3020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828"},"html":{"href":"https://github.com/WhisperSystems/Signal-iOS/pull/2828"},"issue":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2828"},"comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2828/comments"},"review_comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828/comments"},"review_comment":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2828/commits"},"statuses":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/16cf1ab2b7242c56bd9aecf88b75e3ba01f93e74"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"michaelkirk"}}