{"action":"closed","number":1105,"pull_request":{"url":"https://api.github.com/repos/facebook/immutable-js/pulls/1105","id":109595252,"html_url":"https://github.com/facebook/immutable-js/pull/1105","diff_url":"https://github.com/facebook/immutable-js/pull/1105.diff","patch_url":"https://github.com/facebook/immutable-js/pull/1105.patch","issue_url":"https://api.github.com/repos/facebook/immutable-js/issues/1105","number":1105,"state":"closed","locked":false,"title":"Enforces keyPath is Ordered/Array and not string + error clarity.","user":{"login":"leebyron","id":50130,"avatar_url":"https://avatars0.githubusercontent.com/u/50130?v=3","gravatar_id":"","url":"https://api.github.com/users/leebyron","html_url":"https://github.com/leebyron","followers_url":"https://api.github.com/users/leebyron/followers","following_url":"https://api.github.com/users/leebyron/following{/other_user}","gists_url":"https://api.github.com/users/leebyron/gists{/gist_id}","starred_url":"https://api.github.com/users/leebyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leebyron/subscriptions","organizations_url":"https://api.github.com/users/leebyron/orgs","repos_url":"https://api.github.com/users/leebyron/repos","events_url":"https://api.github.com/users/leebyron/events{/privacy}","received_events_url":"https://api.github.com/users/leebyron/received_events","type":"User","site_admin":false},"body":"This makes a few important changes:\r\n\r\n* Existing errors for bad key paths have been improved to explain why and where the issue is.\r\n* Previously strings were converted into an array of characters key path, a constant source of confusion. After this PR providing strings will throw an error.\r\n* Previously anything iterable was allowed, but now only Arrays and Ordered Iterables, otherwise an error is thrown. This avoids a rare pitfall where Sets are used as a path, which have undefined iteration order.\r\n* Adds a new thrown error for getIn()/hasIn() if a key path encounters a value which cannot be read with get(). Previously notSetValue was returned.\r\n\r\nFixes #635\r\nFixes #940\r\nFixes #451","created_at":"2017-03-07T23:25:02Z","updated_at":"2017-03-08T06:55:46Z","closed_at":"2017-03-08T06:55:46Z","merged_at":"2017-03-08T06:55:45Z","merge_commit_sha":"18c9f6d26af247c185c2b763ba5ac6072bb8bc38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/immutable-js/pulls/1105/commits","review_comments_url":"https://api.github.com/repos/facebook/immutable-js/pulls/1105/comments","review_comment_url":"https://api.github.com/repos/facebook/immutable-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/immutable-js/issues/1105/comments","statuses_url":"https://api.github.com/repos/facebook/immutable-js/statuses/336259c6b9de9434f113c97bf6fa1960254690ba","head":{"label":"facebook:keypath-error","ref":"keypath-error","sha":"336259c6b9de9434f113c97bf6fa1960254690ba","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21413198,"name":"immutable-js","full_name":"facebook/immutable-js","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/immutable-js","description":"Immutable persistent data collections for Javascript which increase efficiency and simplicity.","fork":false,"url":"https://api.github.com/repos/facebook/immutable-js","forks_url":"https://api.github.com/repos/facebook/immutable-js/forks","keys_url":"https://api.github.com/repos/facebook/immutable-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/immutable-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/immutable-js/teams","hooks_url":"https://api.github.com/repos/facebook/immutable-js/hooks","issue_events_url":"https://api.github.com/repos/facebook/immutable-js/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/immutable-js/events","assignees_url":"https://api.github.com/repos/facebook/immutable-js/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/immutable-js/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/immutable-js/tags","blobs_url":"https://api.github.com/repos/facebook/immutable-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/immutable-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/immutable-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/immutable-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/immutable-js/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/immutable-js/languages","stargazers_url":"https://api.github.com/repos/facebook/immutable-js/stargazers","contributors_url":"https://api.github.com/repos/facebook/immutable-js/contributors","subscribers_url":"https://api.github.com/repos/facebook/immutable-js/subscribers","subscription_url":"https://api.github.com/repos/facebook/immutable-js/subscription","commits_url":"https://api.github.com/repos/facebook/immutable-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/immutable-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/immutable-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/immutable-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/immutable-js/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/immutable-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/immutable-js/merges","archive_url":"https://api.github.com/repos/facebook/immutable-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/immutable-js/downloads","issues_url":"https://api.github.com/repos/facebook/immutable-js/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/immutable-js/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/immutable-js/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/immutable-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/immutable-js/labels{/name}","releases_url":"https://api.github.com/repos/facebook/immutable-js/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/immutable-js/deployments","created_at":"2014-07-02T06:02:29Z","updated_at":"2017-03-08T06:48:46Z","pushed_at":"2017-03-08T06:55:45Z","git_url":"git://github.com/facebook/immutable-js.git","ssh_url":"git@github.com:facebook/immutable-js.git","clone_url":"https://github.com/facebook/immutable-js.git","svn_url":"https://github.com/facebook/immutable-js","homepage":"http://facebook.github.io/immutable-js/","size":18300,"stargazers_count":17516,"watchers_count":17516,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":930,"mirror_url":null,"open_issues_count":91,"forks":930,"open_issues":91,"watchers":17516,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"7da5cbdd02967218e274e1b0f1f59b7f8334d448","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21413198,"name":"immutable-js","full_name":"facebook/immutable-js","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/immutable-js","description":"Immutable persistent data collections for Javascript which increase efficiency and simplicity.","fork":false,"url":"https://api.github.com/repos/facebook/immutable-js","forks_url":"https://api.github.com/repos/facebook/immutable-js/forks","keys_url":"https://api.github.com/repos/facebook/immutable-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/immutable-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/immutable-js/teams","hooks_url":"https://api.github.com/repos/facebook/immutable-js/hooks","issue_events_url":"https://api.github.com/repos/facebook/immutable-js/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/immutable-js/events","assignees_url":"https://api.github.com/repos/facebook/immutable-js/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/immutable-js/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/immutable-js/tags","blobs_url":"https://api.github.com/repos/facebook/immutable-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/immutable-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/immutable-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/immutable-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/immutable-js/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/immutable-js/languages","stargazers_url":"https://api.github.com/repos/facebook/immutable-js/stargazers","contributors_url":"https://api.github.com/repos/facebook/immutable-js/contributors","subscribers_url":"https://api.github.com/repos/facebook/immutable-js/subscribers","subscription_url":"https://api.github.com/repos/facebook/immutable-js/subscription","commits_url":"https://api.github.com/repos/facebook/immutable-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/immutable-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/immutable-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/immutable-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/immutable-js/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/immutable-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/immutable-js/merges","archive_url":"https://api.github.com/repos/facebook/immutable-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/immutable-js/downloads","issues_url":"https://api.github.com/repos/facebook/immutable-js/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/immutable-js/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/immutable-js/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/immutable-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/immutable-js/labels{/name}","releases_url":"https://api.github.com/repos/facebook/immutable-js/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/immutable-js/deployments","created_at":"2014-07-02T06:02:29Z","updated_at":"2017-03-08T06:48:46Z","pushed_at":"2017-03-08T06:55:45Z","git_url":"git://github.com/facebook/immutable-js.git","ssh_url":"git@github.com:facebook/immutable-js.git","clone_url":"https://github.com/facebook/immutable-js.git","svn_url":"https://github.com/facebook/immutable-js","homepage":"http://facebook.github.io/immutable-js/","size":18300,"stargazers_count":17516,"watchers_count":17516,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":930,"mirror_url":null,"open_issues_count":91,"forks":930,"open_issues":91,"watchers":17516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/1105"},"html":{"href":"https://github.com/facebook/immutable-js/pull/1105"},"issue":{"href":"https://api.github.com/repos/facebook/immutable-js/issues/1105"},"comments":{"href":"https://api.github.com/repos/facebook/immutable-js/issues/1105/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/1105/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/immutable-js/pulls/1105/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/immutable-js/statuses/336259c6b9de9434f113c97bf6fa1960254690ba"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leebyron","id":50130,"avatar_url":"https://avatars0.githubusercontent.com/u/50130?v=3","gravatar_id":"","url":"https://api.github.com/users/leebyron","html_url":"https://github.com/leebyron","followers_url":"https://api.github.com/users/leebyron/followers","following_url":"https://api.github.com/users/leebyron/following{/other_user}","gists_url":"https://api.github.com/users/leebyron/gists{/gist_id}","starred_url":"https://api.github.com/users/leebyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leebyron/subscriptions","organizations_url":"https://api.github.com/users/leebyron/orgs","repos_url":"https://api.github.com/users/leebyron/repos","events_url":"https://api.github.com/users/leebyron/events{/privacy}","received_events_url":"https://api.github.com/users/leebyron/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":207,"deletions":122,"changed_files":12}}
{"actor":{"display_login":"leebyron"}}