{"action":"closed","number":18996,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18996","id":122923538,"html_url":"https://github.com/cms-sw/cmssw/pull/18996","diff_url":"https://github.com/cms-sw/cmssw/pull/18996.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/18996.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18996","number":18996,"state":"closed","locked":false,"title":"Adding anode DB suppression status to the rechits","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars1.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"body":"This change ensures that the status of \"anode\" in the HF reco will be reflected in the combined PMT rechit whenever that anode is flagged bad in the relevant DB calibration table. In the previous version of the code, this was done only if the anode was actually present in the digis. With this update, the status will be propagated to the rechit even if that anode is not in the data stream (but its neighbor anode is). This will make a difference for \"dead\" channels flagged in DB.\r\n\r\nSince, at the moment, there are no bad channels flagged in the DB for HF, this PR will not change any relval results.\r\n","created_at":"2017-05-29T16:47:13Z","updated_at":"2017-06-01T18:22:58Z","closed_at":"2017-06-01T18:22:58Z","merged_at":"2017-06-01T18:22:58Z","merge_commit_sha":"f059e5d540285b3cf3ed3096ea27ef7b5f71630b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66","html_url":"https://github.com/cms-sw/cmssw/milestone/66","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66/labels","id":2497352,"number":66,"title":"CMSSW_9_2_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":331,"state":"open","created_at":"2017-05-03T13:18:43Z","updated_at":"2017-06-01T18:22:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18996/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18996/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18996/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/24eca6c84c2dd666116c21c3af69a7635630fc7e","head":{"label":"igv4321:hf-db-anode-status","ref":"hf-db-anode-status","sha":"24eca6c84c2dd666116c21c3af69a7635630fc7e","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars1.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"repo":{"id":18013692,"name":"cmssw","full_name":"igv4321/cmssw","owner":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars1.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igv4321/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/igv4321/cmssw","forks_url":"https://api.github.com/repos/igv4321/cmssw/forks","keys_url":"https://api.github.com/repos/igv4321/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igv4321/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igv4321/cmssw/teams","hooks_url":"https://api.github.com/repos/igv4321/cmssw/hooks","issue_events_url":"https://api.github.com/repos/igv4321/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/igv4321/cmssw/events","assignees_url":"https://api.github.com/repos/igv4321/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/igv4321/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/igv4321/cmssw/tags","blobs_url":"https://api.github.com/repos/igv4321/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igv4321/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igv4321/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/igv4321/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igv4321/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/igv4321/cmssw/languages","stargazers_url":"https://api.github.com/repos/igv4321/cmssw/stargazers","contributors_url":"https://api.github.com/repos/igv4321/cmssw/contributors","subscribers_url":"https://api.github.com/repos/igv4321/cmssw/subscribers","subscription_url":"https://api.github.com/repos/igv4321/cmssw/subscription","commits_url":"https://api.github.com/repos/igv4321/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/igv4321/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/igv4321/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/igv4321/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/igv4321/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/igv4321/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igv4321/cmssw/merges","archive_url":"https://api.github.com/repos/igv4321/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igv4321/cmssw/downloads","issues_url":"https://api.github.com/repos/igv4321/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/igv4321/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/igv4321/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/igv4321/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igv4321/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/igv4321/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/igv4321/cmssw/deployments","created_at":"2014-03-22T16:11:12Z","updated_at":"2014-05-20T07:41:30Z","pushed_at":"2017-05-29T16:06:14Z","git_url":"git://github.com/igv4321/cmssw.git","ssh_url":"git@github.com:igv4321/cmssw.git","clone_url":"https://github.com/igv4321/cmssw.git","svn_url":"https://github.com/igv4321/cmssw","homepage":"cms-sw.github.io/cmssw","size":903222,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"726aad3a012619d38771642302f0b42aafe675c4","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-05-31T18:13:09Z","pushed_at":"2017-06-01T18:22:58Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":946135,"stargazers_count":420,"watchers_count":420,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2206,"mirror_url":null,"open_issues_count":360,"forks":2206,"open_issues":360,"watchers":420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18996"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/18996"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/18996"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/18996/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18996/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18996/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/24eca6c84c2dd666116c21c3af69a7635630fc7e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars2.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"cmsbuild"}}