{"action":"created","comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/99468430","pull_request_review_id":20150150,"id":99468430,"diff_hunk":"@@ -861,6 +861,10 @@ static void save_settings(git_repository *repo, struct dir *tree)\n \tcall_for_each_dc(&b, save_one_device, false);\n \tcond_put_format(autogroup, &b, \"autogroup\\n\");\n \tsave_units(&b);\n+\tif (prefs.tankbar)\n+\t\tput_string(&b, \"prefs TANKBAR\\n\");\n+\tif (prefs.dcceiling)\n+\t\tput_string(&b, \"prefs DCCEILING\\n\");\n ","path":"core/save-git.c","position":8,"original_position":8,"commit_id":"4e3b12f03a7f5d8f9c0c24468dd1549e672597bc","original_commit_id":"7e3f281edc6260171b35e0a1938860e39b506115","user":{"login":"dirkhh","id":237471,"avatar_url":"https://avatars.githubusercontent.com/u/237471?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkhh","html_url":"https://github.com/dirkhh","followers_url":"https://api.github.com/users/dirkhh/followers","following_url":"https://api.github.com/users/dirkhh/following{/other_user}","gists_url":"https://api.github.com/users/dirkhh/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkhh/subscriptions","organizations_url":"https://api.github.com/users/dirkhh/orgs","repos_url":"https://api.github.com/users/dirkhh/repos","events_url":"https://api.github.com/users/dirkhh/events{/privacy}","received_events_url":"https://api.github.com/users/dirkhh/received_events","type":"User","site_admin":false},"body":"haven't tried the code, but this makes me think that since the main prefs don't get set in the code above, if I modify things in Subsurface-mobile and then save them again to git, the tankbar / dcceiling setting will get lost, correct?","created_at":"2017-02-04T15:17:06Z","updated_at":"2017-02-04T15:17:45Z","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/190#discussion_r99468430","pull_request_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/99468430"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/190#discussion_r99468430"},"pull_request":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190","id":104656631,"html_url":"https://github.com/Subsurface-divelog/subsurface/pull/190","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/190.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/190.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/190","number":190,"state":"open","locked":false,"title":"Mobile","user":{"login":"jbygdell","id":24942439,"avatar_url":"https://avatars.githubusercontent.com/u/24942439?v=3","gravatar_id":"","url":"https://api.github.com/users/jbygdell","html_url":"https://github.com/jbygdell","followers_url":"https://api.github.com/users/jbygdell/followers","following_url":"https://api.github.com/users/jbygdell/following{/other_user}","gists_url":"https://api.github.com/users/jbygdell/gists{/gist_id}","starred_url":"https://api.github.com/users/jbygdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbygdell/subscriptions","organizations_url":"https://api.github.com/users/jbygdell/orgs","repos_url":"https://api.github.com/users/jbygdell/repos","events_url":"https://api.github.com/users/jbygdell/events{/privacy}","received_events_url":"https://api.github.com/users/jbygdell/received_events","type":"User","site_admin":false},"body":"In order to unify the look between desktop profile and mobile profile some settings needs to be saved to git. Some changes to the profile where needed in order to prevent overlap of the visible objects.","created_at":"2017-02-04T10:09:25Z","updated_at":"2017-02-04T15:17:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137046cfe8ae27165fdc2a7c525a22352c1d8ab6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/190/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/4e3b12f03a7f5d8f9c0c24468dd1549e672597bc","head":{"label":"jbygdell:Mobile","ref":"Mobile","sha":"4e3b12f03a7f5d8f9c0c24468dd1549e672597bc","user":{"login":"jbygdell","id":24942439,"avatar_url":"https://avatars.githubusercontent.com/u/24942439?v=3","gravatar_id":"","url":"https://api.github.com/users/jbygdell","html_url":"https://github.com/jbygdell","followers_url":"https://api.github.com/users/jbygdell/followers","following_url":"https://api.github.com/users/jbygdell/following{/other_user}","gists_url":"https://api.github.com/users/jbygdell/gists{/gist_id}","starred_url":"https://api.github.com/users/jbygdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbygdell/subscriptions","organizations_url":"https://api.github.com/users/jbygdell/orgs","repos_url":"https://api.github.com/users/jbygdell/repos","events_url":"https://api.github.com/users/jbygdell/events{/privacy}","received_events_url":"https://api.github.com/users/jbygdell/received_events","type":"User","site_admin":false},"repo":{"id":78135432,"name":"subsurface","full_name":"jbygdell/subsurface","owner":{"login":"jbygdell","id":24942439,"avatar_url":"https://avatars.githubusercontent.com/u/24942439?v=3","gravatar_id":"","url":"https://api.github.com/users/jbygdell","html_url":"https://github.com/jbygdell","followers_url":"https://api.github.com/users/jbygdell/followers","following_url":"https://api.github.com/users/jbygdell/following{/other_user}","gists_url":"https://api.github.com/users/jbygdell/gists{/gist_id}","starred_url":"https://api.github.com/users/jbygdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbygdell/subscriptions","organizations_url":"https://api.github.com/users/jbygdell/orgs","repos_url":"https://api.github.com/users/jbygdell/repos","events_url":"https://api.github.com/users/jbygdell/events{/privacy}","received_events_url":"https://api.github.com/users/jbygdell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbygdell/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":true,"url":"https://api.github.com/repos/jbygdell/subsurface","forks_url":"https://api.github.com/repos/jbygdell/subsurface/forks","keys_url":"https://api.github.com/repos/jbygdell/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbygdell/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbygdell/subsurface/teams","hooks_url":"https://api.github.com/repos/jbygdell/subsurface/hooks","issue_events_url":"https://api.github.com/repos/jbygdell/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/jbygdell/subsurface/events","assignees_url":"https://api.github.com/repos/jbygdell/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/jbygdell/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/jbygdell/subsurface/tags","blobs_url":"https://api.github.com/repos/jbygdell/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbygdell/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbygdell/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbygdell/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbygdell/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/jbygdell/subsurface/languages","stargazers_url":"https://api.github.com/repos/jbygdell/subsurface/stargazers","contributors_url":"https://api.github.com/repos/jbygdell/subsurface/contributors","subscribers_url":"https://api.github.com/repos/jbygdell/subsurface/subscribers","subscription_url":"https://api.github.com/repos/jbygdell/subsurface/subscription","commits_url":"https://api.github.com/repos/jbygdell/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbygdell/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbygdell/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbygdell/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbygdell/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/jbygdell/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbygdell/subsurface/merges","archive_url":"https://api.github.com/repos/jbygdell/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbygdell/subsurface/downloads","issues_url":"https://api.github.com/repos/jbygdell/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/jbygdell/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/jbygdell/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/jbygdell/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbygdell/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/jbygdell/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/jbygdell/subsurface/deployments","created_at":"2017-01-05T17:54:43Z","updated_at":"2017-01-05T17:54:49Z","pushed_at":"2017-02-04T10:06:00Z","git_url":"git://github.com/jbygdell/subsurface.git","ssh_url":"git@github.com:jbygdell/subsurface.git","clone_url":"https://github.com/jbygdell/subsurface.git","svn_url":"https://github.com/jbygdell/subsurface","homepage":"https://subsurface-divelog.org","size":69953,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"9a754b663a2751f2ca86c636d6a1c55f0cf23912","user":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars.githubusercontent.com/u/24829199?v=3","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"name":"subsurface","full_name":"Subsurface-divelog/subsurface","owner":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars.githubusercontent.com/u/24829199?v=3","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2017-02-04T01:02:00Z","pushed_at":"2017-02-04T15:09:37Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":69952,"stargazers_count":1199,"watchers_count":1199,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":302,"mirror_url":null,"open_issues_count":7,"forks":302,"open_issues":7,"watchers":1199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/190"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/190"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/4e3b12f03a7f5d8f9c0c24468dd1549e672597bc"}}}}
{"actor":{"display_login":"dirkhh"}}