{"action":"created","comment":{"url":"https://api.github.com/repos/avajs/ava/pulls/comments/143130389","pull_request_review_id":67596751,"id":143130389,"diff_hunk":"@@ -182,16 +182,11 @@ exports.run = () => {\n \tif (conf.watch) {\n \t\ttry {\n \t\t\tconst watcher = new Watcher(logger, api, files, arrify(conf.source));\n-\t\t\twatcher.observeStdin(process.stdin);\n+\t\t\twatcher.observeStdin(process.stdin).then(() => {\n+\t\t\t\tlogger.exit(0);\n+\t\t\t}).catch(handleWatchError);","path":"lib/cli.js","position":7,"original_position":7,"commit_id":"1341a3a667be5ba716a81b483908828c8d7981d9","original_commit_id":"1341a3a667be5ba716a81b483908828c8d7981d9","user":{"login":"unional","id":3254987,"avatar_url":"https://avatars0.githubusercontent.com/u/3254987?v=4","gravatar_id":"","url":"https://api.github.com/users/unional","html_url":"https://github.com/unional","followers_url":"https://api.github.com/users/unional/followers","following_url":"https://api.github.com/users/unional/following{/other_user}","gists_url":"https://api.github.com/users/unional/gists{/gist_id}","starred_url":"https://api.github.com/users/unional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unional/subscriptions","organizations_url":"https://api.github.com/users/unional/orgs","repos_url":"https://api.github.com/users/unional/repos","events_url":"https://api.github.com/users/unional/events{/privacy}","received_events_url":"https://api.github.com/users/unional/received_events","type":"User","site_admin":false},"body":"Yes. The code still needs some love. `observeStdin` is returning a promise that is not rejecting.\r\nWill fix that.","created_at":"2017-10-06T08:07:50Z","updated_at":"2017-10-06T08:07:50Z","html_url":"https://github.com/avajs/ava/pull/1533#discussion_r143130389","pull_request_url":"https://api.github.com/repos/avajs/ava/pulls/1533","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/avajs/ava/pulls/comments/143130389"},"html":{"href":"https://github.com/avajs/ava/pull/1533#discussion_r143130389"},"pull_request":{"href":"https://api.github.com/repos/avajs/ava/pulls/1533"}},"in_reply_to_id":142031975},"pull_request":{"url":"https://api.github.com/repos/avajs/ava/pulls/1533","id":142748925,"html_url":"https://github.com/avajs/ava/pull/1533","diff_url":"https://github.com/avajs/ava/pull/1533.diff","patch_url":"https://github.com/avajs/ava/pull/1533.patch","issue_url":"https://api.github.com/repos/avajs/ava/issues/1533","number":1533,"state":"open","locked":false,"title":"Add support of tty raw mode","user":{"login":"unional","id":3254987,"avatar_url":"https://avatars0.githubusercontent.com/u/3254987?v=4","gravatar_id":"","url":"https://api.github.com/users/unional","html_url":"https://github.com/unional","followers_url":"https://api.github.com/users/unional/followers","following_url":"https://api.github.com/users/unional/following{/other_user}","gists_url":"https://api.github.com/users/unional/gists{/gist_id}","starred_url":"https://api.github.com/users/unional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unional/subscriptions","organizations_url":"https://api.github.com/users/unional/orgs","repos_url":"https://api.github.com/users/unional/repos","events_url":"https://api.github.com/users/unional/events{/privacy}","received_events_url":"https://api.github.com/users/unional/received_events","type":"User","site_admin":false},"body":"Fixes #1531 \r\n\r\nThis PR mostly works except killing the process requires hitting [Ctrl+C] twice, which guess is related to the test is running in a different process.\r\n\r\nLet me know what is the right way to fix it and I'll adjust the PR. 🌷 ","created_at":"2017-09-24T10:42:48Z","updated_at":"2017-10-06T08:07:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fe210783fe299431a66fa4aac7d947154edec20","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/avajs/ava/pulls/1533/commits","review_comments_url":"https://api.github.com/repos/avajs/ava/pulls/1533/comments","review_comment_url":"https://api.github.com/repos/avajs/ava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avajs/ava/issues/1533/comments","statuses_url":"https://api.github.com/repos/avajs/ava/statuses/1341a3a667be5ba716a81b483908828c8d7981d9","head":{"label":"unional:enable-raw","ref":"enable-raw","sha":"1341a3a667be5ba716a81b483908828c8d7981d9","user":{"login":"unional","id":3254987,"avatar_url":"https://avatars0.githubusercontent.com/u/3254987?v=4","gravatar_id":"","url":"https://api.github.com/users/unional","html_url":"https://github.com/unional","followers_url":"https://api.github.com/users/unional/followers","following_url":"https://api.github.com/users/unional/following{/other_user}","gists_url":"https://api.github.com/users/unional/gists{/gist_id}","starred_url":"https://api.github.com/users/unional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unional/subscriptions","organizations_url":"https://api.github.com/users/unional/orgs","repos_url":"https://api.github.com/users/unional/repos","events_url":"https://api.github.com/users/unional/events{/privacy}","received_events_url":"https://api.github.com/users/unional/received_events","type":"User","site_admin":false},"repo":{"id":104608101,"name":"ava","full_name":"unional/ava","owner":{"login":"unional","id":3254987,"avatar_url":"https://avatars0.githubusercontent.com/u/3254987?v=4","gravatar_id":"","url":"https://api.github.com/users/unional","html_url":"https://github.com/unional","followers_url":"https://api.github.com/users/unional/followers","following_url":"https://api.github.com/users/unional/following{/other_user}","gists_url":"https://api.github.com/users/unional/gists{/gist_id}","starred_url":"https://api.github.com/users/unional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unional/subscriptions","organizations_url":"https://api.github.com/users/unional/orgs","repos_url":"https://api.github.com/users/unional/repos","events_url":"https://api.github.com/users/unional/events{/privacy}","received_events_url":"https://api.github.com/users/unional/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unional/ava","description":":rocket: Futuristic JavaScript test runner","fork":true,"url":"https://api.github.com/repos/unional/ava","forks_url":"https://api.github.com/repos/unional/ava/forks","keys_url":"https://api.github.com/repos/unional/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unional/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unional/ava/teams","hooks_url":"https://api.github.com/repos/unional/ava/hooks","issue_events_url":"https://api.github.com/repos/unional/ava/issues/events{/number}","events_url":"https://api.github.com/repos/unional/ava/events","assignees_url":"https://api.github.com/repos/unional/ava/assignees{/user}","branches_url":"https://api.github.com/repos/unional/ava/branches{/branch}","tags_url":"https://api.github.com/repos/unional/ava/tags","blobs_url":"https://api.github.com/repos/unional/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unional/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unional/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/unional/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unional/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/unional/ava/languages","stargazers_url":"https://api.github.com/repos/unional/ava/stargazers","contributors_url":"https://api.github.com/repos/unional/ava/contributors","subscribers_url":"https://api.github.com/repos/unional/ava/subscribers","subscription_url":"https://api.github.com/repos/unional/ava/subscription","commits_url":"https://api.github.com/repos/unional/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/unional/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/unional/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/unional/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/unional/ava/contents/{+path}","compare_url":"https://api.github.com/repos/unional/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unional/ava/merges","archive_url":"https://api.github.com/repos/unional/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unional/ava/downloads","issues_url":"https://api.github.com/repos/unional/ava/issues{/number}","pulls_url":"https://api.github.com/repos/unional/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/unional/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/unional/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unional/ava/labels{/name}","releases_url":"https://api.github.com/repos/unional/ava/releases{/id}","deployments_url":"https://api.github.com/repos/unional/ava/deployments","created_at":"2017-09-24T00:37:21Z","updated_at":"2017-09-24T00:37:23Z","pushed_at":"2017-09-24T19:08:55Z","git_url":"git://github.com/unional/ava.git","ssh_url":"git@github.com:unional/ava.git","clone_url":"https://github.com/unional/ava.git","svn_url":"https://github.com/unional/ava","homepage":"","size":5971,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avajs:master","ref":"master","sha":"3c8b1bed83368fba3f807dc6d2d47c3682b3c4d9","user":{"login":"avajs","id":8527916,"avatar_url":"https://avatars3.githubusercontent.com/u/8527916?v=4","gravatar_id":"","url":"https://api.github.com/users/avajs","html_url":"https://github.com/avajs","followers_url":"https://api.github.com/users/avajs/followers","following_url":"https://api.github.com/users/avajs/following{/other_user}","gists_url":"https://api.github.com/users/avajs/gists{/gist_id}","starred_url":"https://api.github.com/users/avajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avajs/subscriptions","organizations_url":"https://api.github.com/users/avajs/orgs","repos_url":"https://api.github.com/users/avajs/repos","events_url":"https://api.github.com/users/avajs/events{/privacy}","received_events_url":"https://api.github.com/users/avajs/received_events","type":"Organization","site_admin":false},"repo":{"id":26820798,"name":"ava","full_name":"avajs/ava","owner":{"login":"avajs","id":8527916,"avatar_url":"https://avatars3.githubusercontent.com/u/8527916?v=4","gravatar_id":"","url":"https://api.github.com/users/avajs","html_url":"https://github.com/avajs","followers_url":"https://api.github.com/users/avajs/followers","following_url":"https://api.github.com/users/avajs/following{/other_user}","gists_url":"https://api.github.com/users/avajs/gists{/gist_id}","starred_url":"https://api.github.com/users/avajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avajs/subscriptions","organizations_url":"https://api.github.com/users/avajs/orgs","repos_url":"https://api.github.com/users/avajs/repos","events_url":"https://api.github.com/users/avajs/events{/privacy}","received_events_url":"https://api.github.com/users/avajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avajs/ava","description":":rocket: Futuristic JavaScript test runner","fork":false,"url":"https://api.github.com/repos/avajs/ava","forks_url":"https://api.github.com/repos/avajs/ava/forks","keys_url":"https://api.github.com/repos/avajs/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avajs/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avajs/ava/teams","hooks_url":"https://api.github.com/repos/avajs/ava/hooks","issue_events_url":"https://api.github.com/repos/avajs/ava/issues/events{/number}","events_url":"https://api.github.com/repos/avajs/ava/events","assignees_url":"https://api.github.com/repos/avajs/ava/assignees{/user}","branches_url":"https://api.github.com/repos/avajs/ava/branches{/branch}","tags_url":"https://api.github.com/repos/avajs/ava/tags","blobs_url":"https://api.github.com/repos/avajs/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avajs/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avajs/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/avajs/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avajs/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/avajs/ava/languages","stargazers_url":"https://api.github.com/repos/avajs/ava/stargazers","contributors_url":"https://api.github.com/repos/avajs/ava/contributors","subscribers_url":"https://api.github.com/repos/avajs/ava/subscribers","subscription_url":"https://api.github.com/repos/avajs/ava/subscription","commits_url":"https://api.github.com/repos/avajs/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/avajs/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/avajs/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/avajs/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/avajs/ava/contents/{+path}","compare_url":"https://api.github.com/repos/avajs/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avajs/ava/merges","archive_url":"https://api.github.com/repos/avajs/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avajs/ava/downloads","issues_url":"https://api.github.com/repos/avajs/ava/issues{/number}","pulls_url":"https://api.github.com/repos/avajs/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/avajs/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/avajs/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avajs/ava/labels{/name}","releases_url":"https://api.github.com/repos/avajs/ava/releases{/id}","deployments_url":"https://api.github.com/repos/avajs/ava/deployments","created_at":"2014-11-18T17:20:26Z","updated_at":"2017-10-06T06:38:43Z","pushed_at":"2017-10-05T07:47:48Z","git_url":"git://github.com/avajs/ava.git","ssh_url":"git@github.com:avajs/ava.git","clone_url":"https://github.com/avajs/ava.git","svn_url":"https://github.com/avajs/ava","homepage":"","size":5999,"stargazers_count":11522,"watchers_count":11522,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":638,"mirror_url":null,"open_issues_count":146,"forks":638,"open_issues":146,"watchers":11522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avajs/ava/pulls/1533"},"html":{"href":"https://github.com/avajs/ava/pull/1533"},"issue":{"href":"https://api.github.com/repos/avajs/ava/issues/1533"},"comments":{"href":"https://api.github.com/repos/avajs/ava/issues/1533/comments"},"review_comments":{"href":"https://api.github.com/repos/avajs/ava/pulls/1533/comments"},"review_comment":{"href":"https://api.github.com/repos/avajs/ava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avajs/ava/pulls/1533/commits"},"statuses":{"href":"https://api.github.com/repos/avajs/ava/statuses/1341a3a667be5ba716a81b483908828c8d7981d9"}},"author_association":"NONE"}}
{"actor":{"display_login":"unional"}}