{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/dojo/issues/274","repository_url":"https://api.github.com/repos/dojo/dojo","labels_url":"https://api.github.com/repos/dojo/dojo/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/dojo/dojo/issues/274/comments","events_url":"https://api.github.com/repos/dojo/dojo/issues/274/events","html_url":"https://github.com/dojo/dojo/pull/274","id":263260311,"number":274,"title":"Add upload progress support to dojo/request/xhr","user":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars1.githubusercontent.com/u/334586?v=4","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dojo/dojo/milestones/11","html_url":"https://github.com/dojo/dojo/milestone/11","labels_url":"https://api.github.com/repos/dojo/dojo/milestones/11/labels","id":2870770,"number":11,"title":"1.14.0","description":null,"creator":{"login":"dylans","id":97291,"avatar_url":"https://avatars1.githubusercontent.com/u/97291?v=4","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2017-10-27T20:14:43Z","updated_at":"2017-10-27T20:14:43Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-10-05T20:44:43Z","updated_at":"2017-10-30T19:37:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dojo/dojo/pulls/274","html_url":"https://github.com/dojo/dojo/pull/274","diff_url":"https://github.com/dojo/dojo/pull/274.diff","patch_url":"https://github.com/dojo/dojo/pull/274.patch"},"body":"The current implementation of `dojo/request/xhr` didn't support upload progress events. Unlike downloads, a listener for the `progress` event has to be added to the `XMLHttpRequest#upload` property for uploads, not the request itself. We [never actually add any events](https://github.com/dojo/dojo/blob/master/request/xhr.js#L142-L144) to the `upload` object. Unfortunately, if we just modify `dojo/request/xhr` to check for an `upload` property on the `XMLHttpRequest` to add event listeners to, this [causes all requests to be preflighted](https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Preflighted_requests).\r\n\r\nThis PR adds support for a new property on the `options` object passed to `dojo/request/xhr` that's called `uploadProgress`. Setting this property to `true` allows upload progress events to fire as expected, while also requiring the developer to consciously opt-in to preflighted requests if upload progress functionality is required."},"comment":{"url":"https://api.github.com/repos/dojo/dojo/issues/comments/340559952","html_url":"https://github.com/dojo/dojo/pull/274#issuecomment-340559952","issue_url":"https://api.github.com/repos/dojo/dojo/issues/274","id":340559952,"user":{"login":"bitpshr","id":334586,"avatar_url":"https://avatars1.githubusercontent.com/u/334586?v=4","gravatar_id":"","url":"https://api.github.com/users/bitpshr","html_url":"https://github.com/bitpshr","followers_url":"https://api.github.com/users/bitpshr/followers","following_url":"https://api.github.com/users/bitpshr/following{/other_user}","gists_url":"https://api.github.com/users/bitpshr/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpshr/subscriptions","organizations_url":"https://api.github.com/users/bitpshr/orgs","repos_url":"https://api.github.com/users/bitpshr/repos","events_url":"https://api.github.com/users/bitpshr/events{/privacy}","received_events_url":"https://api.github.com/users/bitpshr/received_events","type":"User","site_admin":false},"created_at":"2017-10-30T19:37:22Z","updated_at":"2017-10-30T19:37:22Z","author_association":"MEMBER","body":"@bryanforbes documentation added. @dylans test added. Ready for another review. Thanks!"}}
{"actor":{"display_login":"bitpshr"}}