{"action":"opened","number":570,"pull_request":{"url":"https://api.github.com/repos/cloud-elements/churros/pulls/570","id":103663754,"html_url":"https://github.com/cloud-elements/churros/pull/570","diff_url":"https://github.com/cloud-elements/churros/pull/570.diff","patch_url":"https://github.com/cloud-elements/churros/pull/570.patch","issue_url":"https://api.github.com/repos/cloud-elements/churros/issues/570","number":570,"state":"open","locked":false,"title":"Add missing returns","user":{"login":"rrothenb","id":821496,"avatar_url":"https://avatars.githubusercontent.com/u/821496?v=3","gravatar_id":"","url":"https://api.github.com/users/rrothenb","html_url":"https://github.com/rrothenb","followers_url":"https://api.github.com/users/rrothenb/followers","following_url":"https://api.github.com/users/rrothenb/following{/other_user}","gists_url":"https://api.github.com/users/rrothenb/gists{/gist_id}","starred_url":"https://api.github.com/users/rrothenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrothenb/subscriptions","organizations_url":"https://api.github.com/users/rrothenb/orgs","repos_url":"https://api.github.com/users/rrothenb/repos","events_url":"https://api.github.com/users/rrothenb/events{/privacy}","received_events_url":"https://api.github.com/users/rrothenb/received_events","type":"User","site_admin":false},"body":"## Highlights\r\n* I noticed (because I had the same problem in some tests I wrote), that these tests lack a return of the promise, which causes the framework to assume that the code is synchronous and that it can immediately return which results in none of the assertions being run and making it look like it's been successful when it may not have been.\r\n","created_at":"2017-01-29T22:45:14Z","updated_at":"2017-01-29T22:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"laurawyse","id":7445993,"avatar_url":"https://avatars.githubusercontent.com/u/7445993?v=3","gravatar_id":"","url":"https://api.github.com/users/laurawyse","html_url":"https://github.com/laurawyse","followers_url":"https://api.github.com/users/laurawyse/followers","following_url":"https://api.github.com/users/laurawyse/following{/other_user}","gists_url":"https://api.github.com/users/laurawyse/gists{/gist_id}","starred_url":"https://api.github.com/users/laurawyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurawyse/subscriptions","organizations_url":"https://api.github.com/users/laurawyse/orgs","repos_url":"https://api.github.com/users/laurawyse/repos","events_url":"https://api.github.com/users/laurawyse/events{/privacy}","received_events_url":"https://api.github.com/users/laurawyse/received_events","type":"User","site_admin":false},"assignees":[{"login":"laurawyse","id":7445993,"avatar_url":"https://avatars.githubusercontent.com/u/7445993?v=3","gravatar_id":"","url":"https://api.github.com/users/laurawyse","html_url":"https://github.com/laurawyse","followers_url":"https://api.github.com/users/laurawyse/followers","following_url":"https://api.github.com/users/laurawyse/following{/other_user}","gists_url":"https://api.github.com/users/laurawyse/gists{/gist_id}","starred_url":"https://api.github.com/users/laurawyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurawyse/subscriptions","organizations_url":"https://api.github.com/users/laurawyse/orgs","repos_url":"https://api.github.com/users/laurawyse/repos","events_url":"https://api.github.com/users/laurawyse/events{/privacy}","received_events_url":"https://api.github.com/users/laurawyse/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cloud-elements/churros/pulls/570/commits","review_comments_url":"https://api.github.com/repos/cloud-elements/churros/pulls/570/comments","review_comment_url":"https://api.github.com/repos/cloud-elements/churros/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloud-elements/churros/issues/570/comments","statuses_url":"https://api.github.com/repos/cloud-elements/churros/statuses/4972ba07512bc3af95864b065764f1ec1f38d7ed","head":{"label":"cloud-elements:master-add-missing-returns","ref":"master-add-missing-returns","sha":"4972ba07512bc3af95864b065764f1ec1f38d7ed","user":{"login":"cloud-elements","id":4693153,"avatar_url":"https://avatars.githubusercontent.com/u/4693153?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-elements","html_url":"https://github.com/cloud-elements","followers_url":"https://api.github.com/users/cloud-elements/followers","following_url":"https://api.github.com/users/cloud-elements/following{/other_user}","gists_url":"https://api.github.com/users/cloud-elements/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-elements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-elements/subscriptions","organizations_url":"https://api.github.com/users/cloud-elements/orgs","repos_url":"https://api.github.com/users/cloud-elements/repos","events_url":"https://api.github.com/users/cloud-elements/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-elements/received_events","type":"Organization","site_admin":false},"repo":{"id":46356335,"name":"churros","full_name":"cloud-elements/churros","owner":{"login":"cloud-elements","id":4693153,"avatar_url":"https://avatars.githubusercontent.com/u/4693153?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-elements","html_url":"https://github.com/cloud-elements","followers_url":"https://api.github.com/users/cloud-elements/followers","following_url":"https://api.github.com/users/cloud-elements/following{/other_user}","gists_url":"https://api.github.com/users/cloud-elements/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-elements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-elements/subscriptions","organizations_url":"https://api.github.com/users/cloud-elements/orgs","repos_url":"https://api.github.com/users/cloud-elements/repos","events_url":"https://api.github.com/users/cloud-elements/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-elements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloud-elements/churros","description":":cop: Cloud Elements API testing framework","fork":false,"url":"https://api.github.com/repos/cloud-elements/churros","forks_url":"https://api.github.com/repos/cloud-elements/churros/forks","keys_url":"https://api.github.com/repos/cloud-elements/churros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloud-elements/churros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloud-elements/churros/teams","hooks_url":"https://api.github.com/repos/cloud-elements/churros/hooks","issue_events_url":"https://api.github.com/repos/cloud-elements/churros/issues/events{/number}","events_url":"https://api.github.com/repos/cloud-elements/churros/events","assignees_url":"https://api.github.com/repos/cloud-elements/churros/assignees{/user}","branches_url":"https://api.github.com/repos/cloud-elements/churros/branches{/branch}","tags_url":"https://api.github.com/repos/cloud-elements/churros/tags","blobs_url":"https://api.github.com/repos/cloud-elements/churros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloud-elements/churros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloud-elements/churros/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloud-elements/churros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloud-elements/churros/statuses/{sha}","languages_url":"https://api.github.com/repos/cloud-elements/churros/languages","stargazers_url":"https://api.github.com/repos/cloud-elements/churros/stargazers","contributors_url":"https://api.github.com/repos/cloud-elements/churros/contributors","subscribers_url":"https://api.github.com/repos/cloud-elements/churros/subscribers","subscription_url":"https://api.github.com/repos/cloud-elements/churros/subscription","commits_url":"https://api.github.com/repos/cloud-elements/churros/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloud-elements/churros/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloud-elements/churros/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloud-elements/churros/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloud-elements/churros/contents/{+path}","compare_url":"https://api.github.com/repos/cloud-elements/churros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloud-elements/churros/merges","archive_url":"https://api.github.com/repos/cloud-elements/churros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloud-elements/churros/downloads","issues_url":"https://api.github.com/repos/cloud-elements/churros/issues{/number}","pulls_url":"https://api.github.com/repos/cloud-elements/churros/pulls{/number}","milestones_url":"https://api.github.com/repos/cloud-elements/churros/milestones{/number}","notifications_url":"https://api.github.com/repos/cloud-elements/churros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloud-elements/churros/labels{/name}","releases_url":"https://api.github.com/repos/cloud-elements/churros/releases{/id}","deployments_url":"https://api.github.com/repos/cloud-elements/churros/deployments","created_at":"2015-11-17T15:32:22Z","updated_at":"2016-10-25T19:11:17Z","pushed_at":"2017-01-29T22:40:40Z","git_url":"git://github.com/cloud-elements/churros.git","ssh_url":"git@github.com:cloud-elements/churros.git","clone_url":"https://github.com/cloud-elements/churros.git","svn_url":"https://github.com/cloud-elements/churros","homepage":"","size":5620,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":26,"forks":0,"open_issues":26,"watchers":4,"default_branch":"master"}},"base":{"label":"cloud-elements:master","ref":"master","sha":"18beca42951cbe865e1f585c4c57d426983946d7","user":{"login":"cloud-elements","id":4693153,"avatar_url":"https://avatars.githubusercontent.com/u/4693153?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-elements","html_url":"https://github.com/cloud-elements","followers_url":"https://api.github.com/users/cloud-elements/followers","following_url":"https://api.github.com/users/cloud-elements/following{/other_user}","gists_url":"https://api.github.com/users/cloud-elements/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-elements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-elements/subscriptions","organizations_url":"https://api.github.com/users/cloud-elements/orgs","repos_url":"https://api.github.com/users/cloud-elements/repos","events_url":"https://api.github.com/users/cloud-elements/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-elements/received_events","type":"Organization","site_admin":false},"repo":{"id":46356335,"name":"churros","full_name":"cloud-elements/churros","owner":{"login":"cloud-elements","id":4693153,"avatar_url":"https://avatars.githubusercontent.com/u/4693153?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-elements","html_url":"https://github.com/cloud-elements","followers_url":"https://api.github.com/users/cloud-elements/followers","following_url":"https://api.github.com/users/cloud-elements/following{/other_user}","gists_url":"https://api.github.com/users/cloud-elements/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-elements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-elements/subscriptions","organizations_url":"https://api.github.com/users/cloud-elements/orgs","repos_url":"https://api.github.com/users/cloud-elements/repos","events_url":"https://api.github.com/users/cloud-elements/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-elements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloud-elements/churros","description":":cop: Cloud Elements API testing framework","fork":false,"url":"https://api.github.com/repos/cloud-elements/churros","forks_url":"https://api.github.com/repos/cloud-elements/churros/forks","keys_url":"https://api.github.com/repos/cloud-elements/churros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloud-elements/churros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloud-elements/churros/teams","hooks_url":"https://api.github.com/repos/cloud-elements/churros/hooks","issue_events_url":"https://api.github.com/repos/cloud-elements/churros/issues/events{/number}","events_url":"https://api.github.com/repos/cloud-elements/churros/events","assignees_url":"https://api.github.com/repos/cloud-elements/churros/assignees{/user}","branches_url":"https://api.github.com/repos/cloud-elements/churros/branches{/branch}","tags_url":"https://api.github.com/repos/cloud-elements/churros/tags","blobs_url":"https://api.github.com/repos/cloud-elements/churros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloud-elements/churros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloud-elements/churros/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloud-elements/churros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloud-elements/churros/statuses/{sha}","languages_url":"https://api.github.com/repos/cloud-elements/churros/languages","stargazers_url":"https://api.github.com/repos/cloud-elements/churros/stargazers","contributors_url":"https://api.github.com/repos/cloud-elements/churros/contributors","subscribers_url":"https://api.github.com/repos/cloud-elements/churros/subscribers","subscription_url":"https://api.github.com/repos/cloud-elements/churros/subscription","commits_url":"https://api.github.com/repos/cloud-elements/churros/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloud-elements/churros/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloud-elements/churros/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloud-elements/churros/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloud-elements/churros/contents/{+path}","compare_url":"https://api.github.com/repos/cloud-elements/churros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloud-elements/churros/merges","archive_url":"https://api.github.com/repos/cloud-elements/churros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloud-elements/churros/downloads","issues_url":"https://api.github.com/repos/cloud-elements/churros/issues{/number}","pulls_url":"https://api.github.com/repos/cloud-elements/churros/pulls{/number}","milestones_url":"https://api.github.com/repos/cloud-elements/churros/milestones{/number}","notifications_url":"https://api.github.com/repos/cloud-elements/churros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloud-elements/churros/labels{/name}","releases_url":"https://api.github.com/repos/cloud-elements/churros/releases{/id}","deployments_url":"https://api.github.com/repos/cloud-elements/churros/deployments","created_at":"2015-11-17T15:32:22Z","updated_at":"2016-10-25T19:11:17Z","pushed_at":"2017-01-29T22:40:40Z","git_url":"git://github.com/cloud-elements/churros.git","ssh_url":"git@github.com:cloud-elements/churros.git","clone_url":"https://github.com/cloud-elements/churros.git","svn_url":"https://github.com/cloud-elements/churros","homepage":"","size":5620,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":26,"forks":0,"open_issues":26,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloud-elements/churros/pulls/570"},"html":{"href":"https://github.com/cloud-elements/churros/pull/570"},"issue":{"href":"https://api.github.com/repos/cloud-elements/churros/issues/570"},"comments":{"href":"https://api.github.com/repos/cloud-elements/churros/issues/570/comments"},"review_comments":{"href":"https://api.github.com/repos/cloud-elements/churros/pulls/570/comments"},"review_comment":{"href":"https://api.github.com/repos/cloud-elements/churros/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloud-elements/churros/pulls/570/commits"},"statuses":{"href":"https://api.github.com/repos/cloud-elements/churros/statuses/4972ba07512bc3af95864b065764f1ec1f38d7ed"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":5}}
{"actor":{"display_login":"rrothenb"}}