{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/104186576","pull_request_review_id":25009517,"id":104186576,"diff_hunk":"@@ -135,6 +135,9 @@ module.exports = angular.module('spinnaker.core.help.contents', [])\n       incoming traffic is directed through a named port (for Spinnaker, the named port is <b>http</b>).\n       The mapping from named port to port number is specified per server group\n       and can be configured within the server group creation dialogue under <b>Port Name Mapping</b>.`,\n+    'gce.securityGroup.sourceCIDRs': 'Traffic is only allowed from sources that match one of these CIDR ranges, or one of the source tags above.',\n+    'gce.securityGroup.sourceTags': 'Traffic is only allowed from sources that match one of these tags, or one of the source CIDR ranges below.',\n+    'gce.securityGroup.targetTags': 'Traffic is only allowed only if the target instance has one of these tags. If no tags are provided, all targets are allowed.',","path":"app/scripts/modules/core/help/helpContents.js","position":6,"original_position":6,"commit_id":"787bf13d526e7b1c5cb020cb9a1c91303a420edc","original_commit_id":"787bf13d526e7b1c5cb020cb9a1c91303a420edc","user":{"login":"duftler","id":8437718,"avatar_url":"https://avatars1.githubusercontent.com/u/8437718?v=3","gravatar_id":"","url":"https://api.github.com/users/duftler","html_url":"https://github.com/duftler","followers_url":"https://api.github.com/users/duftler/followers","following_url":"https://api.github.com/users/duftler/following{/other_user}","gists_url":"https://api.github.com/users/duftler/gists{/gist_id}","starred_url":"https://api.github.com/users/duftler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duftler/subscriptions","organizations_url":"https://api.github.com/users/duftler/orgs","repos_url":"https://api.github.com/users/duftler/repos","events_url":"https://api.github.com/users/duftler/events{/privacy}","received_events_url":"https://api.github.com/users/duftler/received_events","type":"User","site_admin":false},"body":"Reads a bit funny with 'only' on each side of 'allowed'.","created_at":"2017-03-03T16:15:14Z","updated_at":"2017-03-03T16:15:14Z","html_url":"https://github.com/spinnaker/deck/pull/3352#discussion_r104186576","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/3352","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/104186576"},"html":{"href":"https://github.com/spinnaker/deck/pull/3352#discussion_r104186576"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3352"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/3352","id":108863313,"html_url":"https://github.com/spinnaker/deck/pull/3352","diff_url":"https://github.com/spinnaker/deck/pull/3352.diff","patch_url":"https://github.com/spinnaker/deck/pull/3352.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/3352","number":3352,"state":"open","locked":false,"title":"feat(gce) adds support for firewall rule source and target tags","user":{"login":"danielpeach","id":13868700,"avatar_url":"https://avatars0.githubusercontent.com/u/13868700?v=3","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"body":"@duftler please review.\r\n\r\nCloses https://github.com/spinnaker/spinnaker/issues/1448\r\n\r\n![tooltip](https://cloud.githubusercontent.com/assets/13868700/23529372/5abcf248-ff6b-11e6-9c95-4a209e09d36a.png)\r\n![details_view](https://cloud.githubusercontent.com/assets/13868700/23529378/5e4172d6-ff6b-11e6-91d6-9eb85a09b43f.png)\r\n![security_group_wizard](https://cloud.githubusercontent.com/assets/13868700/23529381/62de2730-ff6b-11e6-90d5-b224fed964ef.png)\r\n","created_at":"2017-03-02T22:13:23Z","updated_at":"2017-03-03T16:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bf6b8e2b93ca4129f1743c7a3a6e1c1828e632a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/3352/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/3352/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/3352/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/787bf13d526e7b1c5cb020cb9a1c91303a420edc","head":{"label":"danielpeach:gce-firewall-rule-tags","ref":"gce-firewall-rule-tags","sha":"787bf13d526e7b1c5cb020cb9a1c91303a420edc","user":{"login":"danielpeach","id":13868700,"avatar_url":"https://avatars0.githubusercontent.com/u/13868700?v=3","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"repo":{"id":59520395,"name":"deck","full_name":"danielpeach/deck","owner":{"login":"danielpeach","id":13868700,"avatar_url":"https://avatars0.githubusercontent.com/u/13868700?v=3","gravatar_id":"","url":"https://api.github.com/users/danielpeach","html_url":"https://github.com/danielpeach","followers_url":"https://api.github.com/users/danielpeach/followers","following_url":"https://api.github.com/users/danielpeach/following{/other_user}","gists_url":"https://api.github.com/users/danielpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpeach/subscriptions","organizations_url":"https://api.github.com/users/danielpeach/orgs","repos_url":"https://api.github.com/users/danielpeach/repos","events_url":"https://api.github.com/users/danielpeach/events{/privacy}","received_events_url":"https://api.github.com/users/danielpeach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielpeach/deck","description":"Management UI for Spinnaker","fork":true,"url":"https://api.github.com/repos/danielpeach/deck","forks_url":"https://api.github.com/repos/danielpeach/deck/forks","keys_url":"https://api.github.com/repos/danielpeach/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpeach/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpeach/deck/teams","hooks_url":"https://api.github.com/repos/danielpeach/deck/hooks","issue_events_url":"https://api.github.com/repos/danielpeach/deck/issues/events{/number}","events_url":"https://api.github.com/repos/danielpeach/deck/events","assignees_url":"https://api.github.com/repos/danielpeach/deck/assignees{/user}","branches_url":"https://api.github.com/repos/danielpeach/deck/branches{/branch}","tags_url":"https://api.github.com/repos/danielpeach/deck/tags","blobs_url":"https://api.github.com/repos/danielpeach/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpeach/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpeach/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpeach/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpeach/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpeach/deck/languages","stargazers_url":"https://api.github.com/repos/danielpeach/deck/stargazers","contributors_url":"https://api.github.com/repos/danielpeach/deck/contributors","subscribers_url":"https://api.github.com/repos/danielpeach/deck/subscribers","subscription_url":"https://api.github.com/repos/danielpeach/deck/subscription","commits_url":"https://api.github.com/repos/danielpeach/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpeach/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpeach/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpeach/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpeach/deck/contents/{+path}","compare_url":"https://api.github.com/repos/danielpeach/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpeach/deck/merges","archive_url":"https://api.github.com/repos/danielpeach/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpeach/deck/downloads","issues_url":"https://api.github.com/repos/danielpeach/deck/issues{/number}","pulls_url":"https://api.github.com/repos/danielpeach/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpeach/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpeach/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpeach/deck/labels{/name}","releases_url":"https://api.github.com/repos/danielpeach/deck/releases{/id}","deployments_url":"https://api.github.com/repos/danielpeach/deck/deployments","created_at":"2016-05-23T21:43:32Z","updated_at":"2016-05-23T21:43:37Z","pushed_at":"2017-03-02T22:04:38Z","git_url":"git://github.com/danielpeach/deck.git","ssh_url":"git@github.com:danielpeach/deck.git","clone_url":"https://github.com/danielpeach/deck.git","svn_url":"https://github.com/danielpeach/deck","homepage":"","size":23078,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"ade3f19b459362277da5ed75c6990bf2012445e5","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars2.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars2.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/deck/deployments","created_at":"2014-07-17T18:51:00Z","updated_at":"2017-02-17T20:22:36Z","pushed_at":"2017-03-03T14:57:04Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":22922,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":5,"forks":113,"open_issues":5,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3352"},"html":{"href":"https://github.com/spinnaker/deck/pull/3352"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/3352"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/3352/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3352/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3352/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/787bf13d526e7b1c5cb020cb9a1c91303a420edc"}}}}
{"actor":{"display_login":"duftler"}}