{"action":"created","issue":{"url":"https://api.github.com/repos/zanata/zanata-platform/issues/408","repository_url":"https://api.github.com/repos/zanata/zanata-platform","labels_url":"https://api.github.com/repos/zanata/zanata-platform/issues/408/labels{/name}","comments_url":"https://api.github.com/repos/zanata/zanata-platform/issues/408/comments","events_url":"https://api.github.com/repos/zanata/zanata-platform/issues/408/events","html_url":"https://github.com/zanata/zanata-platform/pull/408","id":239046204,"number":408,"title":"feat(ZNTA-2070) editor settings options ","user":{"login":"kathryngo","id":18179401,"avatar_url":"https://avatars2.githubusercontent.com/u/18179401?v=3","gravatar_id":"","url":"https://api.github.com/users/kathryngo","html_url":"https://github.com/kathryngo","followers_url":"https://api.github.com/users/kathryngo/followers","following_url":"https://api.github.com/users/kathryngo/following{/other_user}","gists_url":"https://api.github.com/users/kathryngo/gists{/gist_id}","starred_url":"https://api.github.com/users/kathryngo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kathryngo/subscriptions","organizations_url":"https://api.github.com/users/kathryngo/orgs","repos_url":"https://api.github.com/users/kathryngo/repos","events_url":"https://api.github.com/users/kathryngo/events{/privacy}","received_events_url":"https://api.github.com/users/kathryngo/received_events","type":"User","site_admin":false},"labels":[{"id":465778273,"url":"https://api.github.com/repos/zanata/zanata-platform/labels/Work%20in%20progress","name":"Work in progress","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"kathryngo","id":18179401,"avatar_url":"https://avatars2.githubusercontent.com/u/18179401?v=3","gravatar_id":"","url":"https://api.github.com/users/kathryngo","html_url":"https://github.com/kathryngo","followers_url":"https://api.github.com/users/kathryngo/followers","following_url":"https://api.github.com/users/kathryngo/following{/other_user}","gists_url":"https://api.github.com/users/kathryngo/gists{/gist_id}","starred_url":"https://api.github.com/users/kathryngo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kathryngo/subscriptions","organizations_url":"https://api.github.com/users/kathryngo/orgs","repos_url":"https://api.github.com/users/kathryngo/repos","events_url":"https://api.github.com/users/kathryngo/events{/privacy}","received_events_url":"https://api.github.com/users/kathryngo/received_events","type":"User","site_admin":false},"assignees":[{"login":"kathryngo","id":18179401,"avatar_url":"https://avatars2.githubusercontent.com/u/18179401?v=3","gravatar_id":"","url":"https://api.github.com/users/kathryngo","html_url":"https://github.com/kathryngo","followers_url":"https://api.github.com/users/kathryngo/followers","following_url":"https://api.github.com/users/kathryngo/following{/other_user}","gists_url":"https://api.github.com/users/kathryngo/gists{/gist_id}","starred_url":"https://api.github.com/users/kathryngo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kathryngo/subscriptions","organizations_url":"https://api.github.com/users/kathryngo/orgs","repos_url":"https://api.github.com/users/kathryngo/repos","events_url":"https://api.github.com/users/kathryngo/events{/privacy}","received_events_url":"https://api.github.com/users/kathryngo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2017-06-28T03:56:46Z","updated_at":"2017-07-03T03:04:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-platform/pulls/408","html_url":"https://github.com/zanata/zanata-platform/pull/408","diff_url":"https://github.com/zanata/zanata-platform/pull/408.diff","patch_url":"https://github.com/zanata/zanata-platform/pull/408.patch"},"body":"JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-2070\r\n\r\nCreate stories for the editor settings and validation settings using the SettingsOptions and SettingOption components.\r\n\r\n\r\n## Reviewer tasks\r\n\r\nThe following is based on the\r\n[Zanata Development Guidelines](https://github.com/zanata/zanata-platform/wiki/Development-Guidelines).\r\nAs a reviewer, you should check the guidelines regularly for updates, and just\r\nto refresh your memory.\r\n\r\n\r\nThe reviewer can use this list for reference to make sure\r\nthey have considered all the important points.\r\n\r\nUse the checkboxes or not, whatever works best for you.\r\n\r\n - Code quality\r\n   - [ ] Code passes style check (checkstyle/eslint)\r\n   - [ ] Code is clear and concise\r\n   - [ ] UI code is internationalised\r\n   - [ ] Code has adequate comments where appropriate\r\n   - Code is in an appropriate place\r\n     - [ ] Classes are in appropriate packages\r\n     - [ ] Code fits with class's responsibilities (SRP)\r\n   - [ ] Configuration files are documented enough\r\n   - If code is removed\r\n     - [ ] No remaining code references the removed code\r\n       - [ ] No orphaned rewrite rules\r\n       - [ ] No orphaned config settings\r\n     - [ ] No remaining comments refer to the removed code\r\n     - [ ] Unused imports and libraries are removed\r\n - Testing\r\n   - [ ] New code has tests\r\n   - [ ] Changed code has tests\r\n   - [ ] All tests pass\r\n   - [ ] Test coverage stable or increased\r\n - Documentation\r\n   - [ ] New features are documented\r\n   - [ ] Docs removed for deleted features\r\n   - [ ] Docs updated for all changed features\r\n   - [ ] Developer/sysadmin docs updated if appropriate\r\n - If there are new dependencies\r\n   - [ ] Does each new dependency pass all the\r\n         [Considerations for new dependencies](https://github.com/zanata/zanata-platform/wiki/Development-Guidelines#new-technologies-and-dependencies)?\r\n\r\n\r\n----\r\n*This template can be updated in .github/PULL_REQUEST_TEMPLATE.md*\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/zanata/zanata-platform/408)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/zanata/zanata-platform/issues/comments/312539501","html_url":"https://github.com/zanata/zanata-platform/pull/408#issuecomment-312539501","issue_url":"https://api.github.com/repos/zanata/zanata-platform/issues/408","id":312539501,"user":{"login":"kathryngo","id":18179401,"avatar_url":"https://avatars2.githubusercontent.com/u/18179401?v=3","gravatar_id":"","url":"https://api.github.com/users/kathryngo","html_url":"https://github.com/kathryngo","followers_url":"https://api.github.com/users/kathryngo/followers","following_url":"https://api.github.com/users/kathryngo/following{/other_user}","gists_url":"https://api.github.com/users/kathryngo/gists{/gist_id}","starred_url":"https://api.github.com/users/kathryngo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kathryngo/subscriptions","organizations_url":"https://api.github.com/users/kathryngo/orgs","repos_url":"https://api.github.com/users/kathryngo/repos","events_url":"https://api.github.com/users/kathryngo/events{/privacy}","received_events_url":"https://api.github.com/users/kathryngo/received_events","type":"User","site_admin":false},"created_at":"2017-07-03T03:04:12Z","updated_at":"2017-07-03T03:04:12Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[server/zanata-frontend/src/frontend/app/editor/components/SettingOption/SettingOption.story.js, line 27 at r4](https://reviewable.io:443/reviews/zanata/zanata-platform/408#-Ko5M18T9wP_3IlSWyJw:-Ko5OaHJZ_7m-6wrzlfo:buz22mh) ([raw file](https://github.com/zanata/zanata-platform/blob/fe2d165fa81a5783e818b274efb74597f9c8bef3/server/zanata-frontend/src/frontend/app/editor/components/SettingOption/SettingOption.story.js#L27)):*\n<details><summary><i>Previously, davidmason (David Mason) wrote…</i></summary><blockquote>\n\nThis line looks like it is here by accident. Delete it.\n</blockquote></details>\n\nThis PR is still labelled work in progress. I have not finished it yet so please wait before continuing your review. \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/zanata/zanata-platform/408)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"kathryngo"}}