{"action":"created","comment":{"url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments/147945285","pull_request_review_id":73110877,"id":147945285,"diff_hunk":"@@ -71,7 +71,7 @@ _p._ctor = function(start, end, v, colorStops) {\n _p = cc.Sprite.prototype;\n _p._ctor = function(fileName, rect) {\n     if (fileName === undefined) {\n-        cc.Sprite.prototype.init.call(this);\n+        this.init();","path":"cocos/scripting/js-bindings/script/jsb_create_apis.js","position":23,"original_position":23,"commit_id":"72c5027b2be6d66e4cb500c304d5ea5ad2c4519a","original_commit_id":"72c5027b2be6d66e4cb500c304d5ea5ad2c4519a","user":{"login":"dumganhar","id":493372,"avatar_url":"https://avatars0.githubusercontent.com/u/493372?v=4","gravatar_id":"","url":"https://api.github.com/users/dumganhar","html_url":"https://github.com/dumganhar","followers_url":"https://api.github.com/users/dumganhar/followers","following_url":"https://api.github.com/users/dumganhar/following{/other_user}","gists_url":"https://api.github.com/users/dumganhar/gists{/gist_id}","starred_url":"https://api.github.com/users/dumganhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumganhar/subscriptions","organizations_url":"https://api.github.com/users/dumganhar/orgs","repos_url":"https://api.github.com/users/dumganhar/repos","events_url":"https://api.github.com/users/dumganhar/events{/privacy}","received_events_url":"https://api.github.com/users/dumganhar/received_events","type":"User","site_admin":false},"body":"因为engine层的cc.Sprite已经覆盖了lite里面的cc.Sprite，这里会导致找不到init接口。因为cc.Sprite.prototype是engine里面的了。","created_at":"2017-10-31T10:18:48Z","updated_at":"2017-10-31T10:18:48Z","html_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/947#discussion_r147945285","pull_request_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments/147945285"},"html":{"href":"https://github.com/cocos-creator/cocos2d-x-lite/pull/947#discussion_r147945285"},"pull_request":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947"}}},"pull_request":{"url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947","id":149744466,"html_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/947","diff_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/947.diff","patch_url":"https://github.com/cocos-creator/cocos2d-x-lite/pull/947.patch","issue_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/947","number":947,"state":"open","locked":false,"title":"Don't uses cc.XXX.prototype.init.call(this) since cc.XXX is probably overrode in engine.","user":{"login":"dumganhar","id":493372,"avatar_url":"https://avatars0.githubusercontent.com/u/493372?v=4","gravatar_id":"","url":"https://api.github.com/users/dumganhar","html_url":"https://github.com/dumganhar","followers_url":"https://api.github.com/users/dumganhar/followers","following_url":"https://api.github.com/users/dumganhar/following{/other_user}","gists_url":"https://api.github.com/users/dumganhar/gists{/gist_id}","starred_url":"https://api.github.com/users/dumganhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumganhar/subscriptions","organizations_url":"https://api.github.com/users/dumganhar/orgs","repos_url":"https://api.github.com/users/dumganhar/repos","events_url":"https://api.github.com/users/dumganhar/events{/privacy}","received_events_url":"https://api.github.com/users/dumganhar/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-31T10:17:40Z","updated_at":"2017-10-31T10:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20569b314e519c7dc59165873fd5e56097eef0f9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pandamicro","id":632460,"avatar_url":"https://avatars2.githubusercontent.com/u/632460?v=4","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947/commits","review_comments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947/comments","review_comment_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/947/comments","statuses_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/statuses/72c5027b2be6d66e4cb500c304d5ea5ad2c4519a","head":{"label":"dumganhar:fix/prototype_init","ref":"fix/prototype_init","sha":"72c5027b2be6d66e4cb500c304d5ea5ad2c4519a","user":{"login":"dumganhar","id":493372,"avatar_url":"https://avatars0.githubusercontent.com/u/493372?v=4","gravatar_id":"","url":"https://api.github.com/users/dumganhar","html_url":"https://github.com/dumganhar","followers_url":"https://api.github.com/users/dumganhar/followers","following_url":"https://api.github.com/users/dumganhar/following{/other_user}","gists_url":"https://api.github.com/users/dumganhar/gists{/gist_id}","starred_url":"https://api.github.com/users/dumganhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumganhar/subscriptions","organizations_url":"https://api.github.com/users/dumganhar/orgs","repos_url":"https://api.github.com/users/dumganhar/repos","events_url":"https://api.github.com/users/dumganhar/events{/privacy}","received_events_url":"https://api.github.com/users/dumganhar/received_events","type":"User","site_admin":false},"repo":{"id":59649579,"name":"cocos2d-x-lite","full_name":"dumganhar/cocos2d-x-lite","owner":{"login":"dumganhar","id":493372,"avatar_url":"https://avatars0.githubusercontent.com/u/493372?v=4","gravatar_id":"","url":"https://api.github.com/users/dumganhar","html_url":"https://github.com/dumganhar","followers_url":"https://api.github.com/users/dumganhar/followers","following_url":"https://api.github.com/users/dumganhar/following{/other_user}","gists_url":"https://api.github.com/users/dumganhar/gists{/gist_id}","starred_url":"https://api.github.com/users/dumganhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumganhar/subscriptions","organizations_url":"https://api.github.com/users/dumganhar/orgs","repos_url":"https://api.github.com/users/dumganhar/repos","events_url":"https://api.github.com/users/dumganhar/events{/privacy}","received_events_url":"https://api.github.com/users/dumganhar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dumganhar/cocos2d-x-lite","description":"Lite version cocos2d-x based on Cocos Runtime","fork":true,"url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite","forks_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/forks","keys_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/teams","hooks_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/hooks","issue_events_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/issues/events{/number}","events_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/events","assignees_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/assignees{/user}","branches_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/branches{/branch}","tags_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/tags","blobs_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/languages","stargazers_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/stargazers","contributors_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/contributors","subscribers_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/subscribers","subscription_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/subscription","commits_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/contents/{+path}","compare_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/merges","archive_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/downloads","issues_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/issues{/number}","pulls_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/labels{/name}","releases_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/releases{/id}","deployments_url":"https://api.github.com/repos/dumganhar/cocos2d-x-lite/deployments","created_at":"2016-05-25T09:23:18Z","updated_at":"2017-01-11T07:34:58Z","pushed_at":"2017-10-31T10:16:50Z","git_url":"git://github.com/dumganhar/cocos2d-x-lite.git","ssh_url":"git@github.com:dumganhar/cocos2d-x-lite.git","clone_url":"https://github.com/dumganhar/cocos2d-x-lite.git","svn_url":"https://github.com/dumganhar/cocos2d-x-lite","homepage":null,"size":26252,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"jsb2.0"}},"base":{"label":"cocos-creator:v1.7","ref":"v1.7","sha":"ea3a79c05a2e40dcd1399a2f8aa29e0a6e5d0f8b","user":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"repo":{"id":53839527,"name":"cocos2d-x-lite","full_name":"cocos-creator/cocos2d-x-lite","owner":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos-creator/cocos2d-x-lite","description":"Lite version cocos2d-x based on Cocos Runtime","fork":false,"url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite","forks_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/forks","keys_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/teams","hooks_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/hooks","issue_events_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/events{/number}","events_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/events","assignees_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/assignees{/user}","branches_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/branches{/branch}","tags_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/tags","blobs_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/languages","stargazers_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/stargazers","contributors_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/contributors","subscribers_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/subscribers","subscription_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/subscription","commits_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/contents/{+path}","compare_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/merges","archive_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/downloads","issues_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues{/number}","pulls_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/labels{/name}","releases_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/releases{/id}","deployments_url":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/deployments","created_at":"2016-03-14T08:35:33Z","updated_at":"2017-10-30T18:23:16Z","pushed_at":"2017-10-31T10:17:40Z","git_url":"git://github.com/cocos-creator/cocos2d-x-lite.git","ssh_url":"git@github.com:cocos-creator/cocos2d-x-lite.git","clone_url":"https://github.com/cocos-creator/cocos2d-x-lite.git","svn_url":"https://github.com/cocos-creator/cocos2d-x-lite","homepage":null,"size":26362,"stargazers_count":154,"watchers_count":154,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":171,"mirror_url":null,"archived":false,"open_issues_count":19,"forks":171,"open_issues":19,"watchers":154,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947"},"html":{"href":"https://github.com/cocos-creator/cocos2d-x-lite/pull/947"},"issue":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/947"},"comments":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/cocos-creator/cocos2d-x-lite/statuses/72c5027b2be6d66e4cb500c304d5ea5ad2c4519a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dumganhar"}}