{"action":"created","comment":{"url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/comments/114357193","pull_request_review_id":35816519,"id":114357193,"diff_hunk":"@@ -176,7 +177,7 @@ function FilterStream( blockMap, options ) {\n     var buffer = Buffer.concat( this._buffers )\n     var offset = 0\n \n-    while( offset < buffer.length ) {\n+    while( buffer.length - offset >= this.blockSize ) {\n       this._pushBlock( buffer.slice( offset, offset + this.blockSize ) )\n       offset = offset + this.blockSize","path":"lib/filter-stream.js","position":15,"original_position":15,"commit_id":"feee48cc71c89ab3888bfd85f4f63923ca9fad08","original_commit_id":"feee48cc71c89ab3888bfd85f4f63923ca9fad08","user":{"login":"lurch","id":476186,"avatar_url":"https://avatars1.githubusercontent.com/u/476186?v=3","gravatar_id":"","url":"https://api.github.com/users/lurch","html_url":"https://github.com/lurch","followers_url":"https://api.github.com/users/lurch/followers","following_url":"https://api.github.com/users/lurch/following{/other_user}","gists_url":"https://api.github.com/users/lurch/gists{/gist_id}","starred_url":"https://api.github.com/users/lurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lurch/subscriptions","organizations_url":"https://api.github.com/users/lurch/orgs","repos_url":"https://api.github.com/users/lurch/repos","events_url":"https://api.github.com/users/lurch/events{/privacy}","received_events_url":"https://api.github.com/users/lurch/received_events","type":"User","site_admin":false},"body":"Doesn't matter. I find `+=` more readable, but that's probably just a personal preference.","created_at":"2017-05-02T16:07:48Z","updated_at":"2017-05-02T16:07:48Z","html_url":"https://github.com/resin-io-modules/blockmap/pull/22#discussion_r114357193","pull_request_url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/comments/114357193"},"html":{"href":"https://github.com/resin-io-modules/blockmap/pull/22#discussion_r114357193"},"pull_request":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22","id":117749935,"html_url":"https://github.com/resin-io-modules/blockmap/pull/22","diff_url":"https://github.com/resin-io-modules/blockmap/pull/22.diff","patch_url":"https://github.com/resin-io-modules/blockmap/pull/22.patch","issue_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues/22","number":22,"state":"closed","locked":false,"title":"fix(filter-stream): Prevent emitting too small blocks","user":{"login":"jhermsmeier","id":244907,"avatar_url":"https://avatars0.githubusercontent.com/u/244907?v=3","gravatar_id":"","url":"https://api.github.com/users/jhermsmeier","html_url":"https://github.com/jhermsmeier","followers_url":"https://api.github.com/users/jhermsmeier/followers","following_url":"https://api.github.com/users/jhermsmeier/following{/other_user}","gists_url":"https://api.github.com/users/jhermsmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/jhermsmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhermsmeier/subscriptions","organizations_url":"https://api.github.com/users/jhermsmeier/orgs","repos_url":"https://api.github.com/users/jhermsmeier/repos","events_url":"https://api.github.com/users/jhermsmeier/events{/privacy}","received_events_url":"https://api.github.com/users/jhermsmeier/received_events","type":"User","site_admin":false},"body":"Due to an error in how blocks were chunked, it was possible to emit too small or improperly sized blocks when encountering backpressure buffering.\r\n\r\nThis fixes that behavior, and ensures that all read buffers are consumed.","created_at":"2017-04-26T15:55:35Z","updated_at":"2017-05-02T16:07:48Z","closed_at":"2017-05-01T10:16:00Z","merged_at":"2017-05-01T10:16:00Z","merge_commit_sha":"9711a52e1406eb6bf2e0c0a55f17c7b8df867579","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22/commits","review_comments_url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22/comments","review_comment_url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues/22/comments","statuses_url":"https://api.github.com/repos/resin-io-modules/blockmap/statuses/feee48cc71c89ab3888bfd85f4f63923ca9fad08","head":{"label":"resin-io-modules:fix-filter-stream","ref":"fix-filter-stream","sha":"feee48cc71c89ab3888bfd85f4f63923ca9fad08","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars3.githubusercontent.com/u/17724750?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":80110056,"name":"blockmap","full_name":"resin-io-modules/blockmap","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars3.githubusercontent.com/u/17724750?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/blockmap","description":"Tizen's block map format","fork":false,"url":"https://api.github.com/repos/resin-io-modules/blockmap","forks_url":"https://api.github.com/repos/resin-io-modules/blockmap/forks","keys_url":"https://api.github.com/repos/resin-io-modules/blockmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/blockmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/blockmap/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/blockmap/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/blockmap/events","assignees_url":"https://api.github.com/repos/resin-io-modules/blockmap/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/blockmap/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/blockmap/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/blockmap/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/blockmap/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/blockmap/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/blockmap/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/blockmap/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/blockmap/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/blockmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/blockmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/blockmap/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/blockmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/blockmap/merges","archive_url":"https://api.github.com/repos/resin-io-modules/blockmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/blockmap/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/blockmap/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/blockmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/blockmap/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/blockmap/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/blockmap/deployments","created_at":"2017-01-26T11:46:02Z","updated_at":"2017-03-31T07:10:27Z","pushed_at":"2017-05-01T10:16:02Z","git_url":"git://github.com/resin-io-modules/blockmap.git","ssh_url":"git@github.com:resin-io-modules/blockmap.git","clone_url":"https://github.com/resin-io-modules/blockmap.git","svn_url":"https://github.com/resin-io-modules/blockmap","homepage":"","size":101,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"resin-io-modules:master","ref":"master","sha":"b733c900707784c9fbd66ba9f85b2ad8ef015bc6","user":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars3.githubusercontent.com/u/17724750?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":80110056,"name":"blockmap","full_name":"resin-io-modules/blockmap","owner":{"login":"resin-io-modules","id":17724750,"avatar_url":"https://avatars3.githubusercontent.com/u/17724750?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-io-modules","html_url":"https://github.com/resin-io-modules","followers_url":"https://api.github.com/users/resin-io-modules/followers","following_url":"https://api.github.com/users/resin-io-modules/following{/other_user}","gists_url":"https://api.github.com/users/resin-io-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io-modules/subscriptions","organizations_url":"https://api.github.com/users/resin-io-modules/orgs","repos_url":"https://api.github.com/users/resin-io-modules/repos","events_url":"https://api.github.com/users/resin-io-modules/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io-modules/blockmap","description":"Tizen's block map format","fork":false,"url":"https://api.github.com/repos/resin-io-modules/blockmap","forks_url":"https://api.github.com/repos/resin-io-modules/blockmap/forks","keys_url":"https://api.github.com/repos/resin-io-modules/blockmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io-modules/blockmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io-modules/blockmap/teams","hooks_url":"https://api.github.com/repos/resin-io-modules/blockmap/hooks","issue_events_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io-modules/blockmap/events","assignees_url":"https://api.github.com/repos/resin-io-modules/blockmap/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io-modules/blockmap/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io-modules/blockmap/tags","blobs_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io-modules/blockmap/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io-modules/blockmap/languages","stargazers_url":"https://api.github.com/repos/resin-io-modules/blockmap/stargazers","contributors_url":"https://api.github.com/repos/resin-io-modules/blockmap/contributors","subscribers_url":"https://api.github.com/repos/resin-io-modules/blockmap/subscribers","subscription_url":"https://api.github.com/repos/resin-io-modules/blockmap/subscription","commits_url":"https://api.github.com/repos/resin-io-modules/blockmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io-modules/blockmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io-modules/blockmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io-modules/blockmap/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io-modules/blockmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io-modules/blockmap/merges","archive_url":"https://api.github.com/repos/resin-io-modules/blockmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io-modules/blockmap/downloads","issues_url":"https://api.github.com/repos/resin-io-modules/blockmap/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io-modules/blockmap/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io-modules/blockmap/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io-modules/blockmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io-modules/blockmap/labels{/name}","releases_url":"https://api.github.com/repos/resin-io-modules/blockmap/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io-modules/blockmap/deployments","created_at":"2017-01-26T11:46:02Z","updated_at":"2017-03-31T07:10:27Z","pushed_at":"2017-05-01T10:16:02Z","git_url":"git://github.com/resin-io-modules/blockmap.git","ssh_url":"git@github.com:resin-io-modules/blockmap.git","clone_url":"https://github.com/resin-io-modules/blockmap.git","svn_url":"https://github.com/resin-io-modules/blockmap","homepage":"","size":101,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22"},"html":{"href":"https://github.com/resin-io-modules/blockmap/pull/22"},"issue":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/issues/22"},"comments":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io-modules/blockmap/statuses/feee48cc71c89ab3888bfd85f4f63923ca9fad08"}}}}
{"actor":{"display_login":"lurch"}}