{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/122126466","pull_request_review_id":44212655,"id":122126466,"diff_hunk":"@@ -16,20 +16,34 @@ and the \\f$ k\\f$-dimensional faces of the triangulation.\n Note that this class is at the same time used for <I>basic</I> and \n for <I>weighted</I> Alpha Shapes. \n \n+The modifying functions `Alpha_shape_2::insert()` and `Alpha_shape_2::remove()` will overwrite\n+the one inherited from the underlying triangulation class `Dt`.\n+At the moment, only the static version is implemented.\n+\n \\tparam Dt must be either `Delaunay_triangulation_2` or `Regular_triangulation_2`. \n-Note that `Dt::Geom_traits`, `Dt::Vertex` and `Dt::Face` must be model the concepts `AlphaShapeTraits_2`, \n+Note that `Dt::Geom_traits`, `Dt::Vertex`, and `Dt::Face` must be model the concepts `AlphaShapeTraits_2`,\n `AlphaShapeVertex_2` and `AlphaShapeFace_2`, respectively. \n \n \\tparam ExactAlphaComparisonTag is a tag that, when set to \n \\link Tag_true `Tag_true`\\endlink, triggers exact comparisons between alpha values. This is useful \n when the underlying triangulation is instantiated with an exact predicates inexact constructions \n kernel. By default the `ExactAlphaComparisonTag` is set to \\link Tag_false `Tag_false`\\endlink as it induces a small \n-overhead. Note that since such a strategy does not make sense if used together with a traits class with exact constructions, \n-the tag `ExactAlphaComparisonTag` is not taken into account if `Dt::Geom_traits::FT` is not a floating point number type. \n-\n-The modifying functions `Alpha_shape_2::insert()` and `Alpha_shape_2::remove()` will overwrite\n-the one inherited from the underlying triangulation class `Dt`.\n-At the moment, only the static version is implemented.\n+overhead. Note that the tag `ExactAlphaComparisonTag` is currently ignored (meaning that the code will\n+ behave as if `ExactAlphaComparisonTag` were set to \\link Tag_false `Tag_false`\\endlink)\n+if `Dt::Geom_traits::FT` is not a floating point number type as this strategy\n+does not make sense if the traits class already provides exact constructions.\n+\n+\\warning When the tag `ExactAlphaComparisonTag` is set to \\link Tag_true `Tag_true`\\endlink,\n+the class `Cartesian_converter` is used internally to switch between the traits class\n+and exact CGAL kernels. `Cartesian_converter` must thus provide the necessary functor","path":"Alpha_shapes_2/doc/Alpha_shapes_2/CGAL/Alpha_shape_2.h","position":30,"original_position":30,"commit_id":"3cb72f5ca1745ee2bc9f3b4f9067f5e95118efa3","original_commit_id":"3cb72f5ca1745ee2bc9f3b4f9067f5e95118efa3","user":{"login":"sloriot","id":1224632,"avatar_url":"https://avatars1.githubusercontent.com/u/1224632?v=3","gravatar_id":"","url":"https://api.github.com/users/sloriot","html_url":"https://github.com/sloriot","followers_url":"https://api.github.com/users/sloriot/followers","following_url":"https://api.github.com/users/sloriot/following{/other_user}","gists_url":"https://api.github.com/users/sloriot/gists{/gist_id}","starred_url":"https://api.github.com/users/sloriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloriot/subscriptions","organizations_url":"https://api.github.com/users/sloriot/orgs","repos_url":"https://api.github.com/users/sloriot/repos","events_url":"https://api.github.com/users/sloriot/events{/privacy}","received_events_url":"https://api.github.com/users/sloriot/received_events","type":"User","site_admin":false},"body":"... and `CGAL::Simple_cartesian<NT>` where NT can be either `CGAL::Interval_nt` or `CGAL::Exact_rational`","created_at":"2017-06-15T06:13:05Z","updated_at":"2017-06-15T06:23:19Z","html_url":"https://github.com/CGAL/cgal/pull/2102#discussion_r122126466","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/2102","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/122126466"},"html":{"href":"https://github.com/CGAL/cgal/pull/2102#discussion_r122126466"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2102"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/2102","id":119857301,"html_url":"https://github.com/CGAL/cgal/pull/2102","diff_url":"https://github.com/CGAL/cgal/pull/2102.diff","patch_url":"https://github.com/CGAL/cgal/pull/2102.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/2102","number":2102,"state":"open","locked":false,"title":"Remove implicit conversions between points and weighted points","user":{"login":"MaelRL","id":5074170,"avatar_url":"https://avatars1.githubusercontent.com/u/5074170?v=3","gravatar_id":"","url":"https://api.github.com/users/MaelRL","html_url":"https://github.com/MaelRL","followers_url":"https://api.github.com/users/MaelRL/followers","following_url":"https://api.github.com/users/MaelRL/following{/other_user}","gists_url":"https://api.github.com/users/MaelRL/gists{/gist_id}","starred_url":"https://api.github.com/users/MaelRL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaelRL/subscriptions","organizations_url":"https://api.github.com/users/MaelRL/orgs","repos_url":"https://api.github.com/users/MaelRL/repos","events_url":"https://api.github.com/users/MaelRL/events{/privacy}","received_events_url":"https://api.github.com/users/MaelRL/received_events","type":"User","site_admin":false},"body":"## Summary of Changes\r\nThe current implementation of weighted points in the CGAL kernel allows for implicit conversions between points and weighted points, meaning that the compiler can convert a `Weighted_point_23` into a `Point_23` (and reversely) if it allows to match a function. This is dangerous because we can accidentally drop weights or call the wrong function unintentionally.\r\n\r\nThis small feature does not remove these conversions but makes them explicit, meaning that the constructor must be called explicitly to be used (and thus the compiler is not allowed to use them on its own). \r\n\r\n## Release Management\r\n\r\n* Affected package(s): Main changes in kernel packages, incident changes  a bit everywhere (mostly `Alpha_shapes_23`, `Interpolation`, `Kinetic_data_structures`, `Mesh_3`, `Skin_surface_3`, and `Triangulation_23`). \r\n* Issue(s) solved (if any): fix #2144, fix #1878\r\n* Feature/Small Feature (if any): [Remove Point -- Weighted point implicit conversions](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Remove_Point_--_Weighted_point_implicit_conversions)\r\n\r\n","created_at":"2017-05-10T11:09:20Z","updated_at":"2017-06-15T06:23:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5da2595876aa43ae13b74f93e22f57666c33e608","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/2102/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/2102/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/2102/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/3cb72f5ca1745ee2bc9f3b4f9067f5e95118efa3","head":{"label":"afabri:Kernel_Weighted_point_without_conversion-GF","ref":"Kernel_Weighted_point_without_conversion-GF","sha":"3cb72f5ca1745ee2bc9f3b4f9067f5e95118efa3","user":{"login":"afabri","id":3263539,"avatar_url":"https://avatars1.githubusercontent.com/u/3263539?v=3","gravatar_id":"","url":"https://api.github.com/users/afabri","html_url":"https://github.com/afabri","followers_url":"https://api.github.com/users/afabri/followers","following_url":"https://api.github.com/users/afabri/following{/other_user}","gists_url":"https://api.github.com/users/afabri/gists{/gist_id}","starred_url":"https://api.github.com/users/afabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afabri/subscriptions","organizations_url":"https://api.github.com/users/afabri/orgs","repos_url":"https://api.github.com/users/afabri/repos","events_url":"https://api.github.com/users/afabri/events{/privacy}","received_events_url":"https://api.github.com/users/afabri/received_events","type":"User","site_admin":false},"repo":{"id":32070833,"name":"cgal","full_name":"afabri/cgal","owner":{"login":"afabri","id":3263539,"avatar_url":"https://avatars1.githubusercontent.com/u/3263539?v=3","gravatar_id":"","url":"https://api.github.com/users/afabri","html_url":"https://github.com/afabri","followers_url":"https://api.github.com/users/afabri/followers","following_url":"https://api.github.com/users/afabri/following{/other_user}","gists_url":"https://api.github.com/users/afabri/gists{/gist_id}","starred_url":"https://api.github.com/users/afabri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afabri/subscriptions","organizations_url":"https://api.github.com/users/afabri/orgs","repos_url":"https://api.github.com/users/afabri/repos","events_url":"https://api.github.com/users/afabri/events{/privacy}","received_events_url":"https://api.github.com/users/afabri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afabri/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/afabri/cgal","forks_url":"https://api.github.com/repos/afabri/cgal/forks","keys_url":"https://api.github.com/repos/afabri/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afabri/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afabri/cgal/teams","hooks_url":"https://api.github.com/repos/afabri/cgal/hooks","issue_events_url":"https://api.github.com/repos/afabri/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/afabri/cgal/events","assignees_url":"https://api.github.com/repos/afabri/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/afabri/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/afabri/cgal/tags","blobs_url":"https://api.github.com/repos/afabri/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afabri/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afabri/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/afabri/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afabri/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/afabri/cgal/languages","stargazers_url":"https://api.github.com/repos/afabri/cgal/stargazers","contributors_url":"https://api.github.com/repos/afabri/cgal/contributors","subscribers_url":"https://api.github.com/repos/afabri/cgal/subscribers","subscription_url":"https://api.github.com/repos/afabri/cgal/subscription","commits_url":"https://api.github.com/repos/afabri/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/afabri/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/afabri/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/afabri/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/afabri/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/afabri/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afabri/cgal/merges","archive_url":"https://api.github.com/repos/afabri/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afabri/cgal/downloads","issues_url":"https://api.github.com/repos/afabri/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/afabri/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/afabri/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/afabri/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afabri/cgal/labels{/name}","releases_url":"https://api.github.com/repos/afabri/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/afabri/cgal/deployments","created_at":"2015-03-12T10:23:10Z","updated_at":"2017-03-29T12:29:46Z","pushed_at":"2017-06-14T15:37:17Z","git_url":"git://github.com/afabri/cgal.git","ssh_url":"git@github.com:afabri/cgal.git","clone_url":"https://github.com/afabri/cgal.git","svn_url":"https://github.com/afabri/cgal","homepage":"http://www.cgal.org","size":537180,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"62f3a857974581cb1254c38b9e4c04cc143bbf3b","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars3.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars3.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository, see the README below","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2017-06-14T16:08:23Z","pushed_at":"2017-06-15T05:41:34Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"https://github.com/CGAL/cgal#readme","size":535329,"stargazers_count":545,"watchers_count":545,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"open_issues_count":240,"forks":255,"open_issues":240,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2102"},"html":{"href":"https://github.com/CGAL/cgal/pull/2102"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/2102"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/2102/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2102/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2102/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/3cb72f5ca1745ee2bc9f3b4f9067f5e95118efa3"}}}}
{"actor":{"display_login":"sloriot"}}