{"action":"created","comment":{"url":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/comments/97880801","pull_request_review_id":18505223,"id":97880801,"diff_hunk":"@@ -0,0 +1,36 @@\n+#ifndef INCLUDED_TRACING_H\n+#define INCLUDED_TRACING_H\n+\n+#include <opentracing/tracer.h>\n+#include <opentracing/noop.h>\n+\n+#include <hot.h>\n+\n+using namespace opentracing;\n+\n+// Defining two \"different\" tracer implementations\n+typedef NoopTracer ZipkinV1;\n+typedef NoopTracer ZipkinV2;\n+\n+// Setting up stuff... Would be nice if they weren't that many...","path":"app_tracing.h","position":15,"original_position":15,"commit_id":"787d80accf06d21b5d95b4febf01fbb67e25eceb","original_commit_id":"787d80accf06d21b5d95b4febf01fbb67e25eceb","user":{"login":"lookfwd","id":789359,"avatar_url":"https://avatars.githubusercontent.com/u/789359?v=3","gravatar_id":"","url":"https://api.github.com/users/lookfwd","html_url":"https://github.com/lookfwd","followers_url":"https://api.github.com/users/lookfwd/followers","following_url":"https://api.github.com/users/lookfwd/following{/other_user}","gists_url":"https://api.github.com/users/lookfwd/gists{/gist_id}","starred_url":"https://api.github.com/users/lookfwd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookfwd/subscriptions","organizations_url":"https://api.github.com/users/lookfwd/orgs","repos_url":"https://api.github.com/users/lookfwd/repos","events_url":"https://api.github.com/users/lookfwd/events{/privacy}","received_events_url":"https://api.github.com/users/lookfwd/received_events","type":"User","site_admin":false},"body":"quoting the comment\r\n\r\n> Would be nice if they weren't that many... is there any way `GenericTracer` to deduce those from just MyHotTracer?","created_at":"2017-01-25T21:20:36Z","updated_at":"2017-01-25T21:38:23Z","html_url":"https://github.com/jquinn47/opentracing-cpp/pull/1#discussion_r97880801","pull_request_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/comments/97880801"},"html":{"href":"https://github.com/jquinn47/opentracing-cpp/pull/1#discussion_r97880801"},"pull_request":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1","id":103203380,"html_url":"https://github.com/jquinn47/opentracing-cpp/pull/1","diff_url":"https://github.com/jquinn47/opentracing-cpp/pull/1.diff","patch_url":"https://github.com/jquinn47/opentracing-cpp/pull/1.patch","issue_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/issues/1","number":1,"state":"open","locked":false,"title":"[Not to Pull. Just discussion] adding some C++11 aspects and a HOT tracer","user":{"login":"lookfwd","id":789359,"avatar_url":"https://avatars.githubusercontent.com/u/789359?v=3","gravatar_id":"","url":"https://api.github.com/users/lookfwd","html_url":"https://github.com/lookfwd","followers_url":"https://api.github.com/users/lookfwd/followers","following_url":"https://api.github.com/users/lookfwd/following{/other_user}","gists_url":"https://api.github.com/users/lookfwd/gists{/gist_id}","starred_url":"https://api.github.com/users/lookfwd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookfwd/subscriptions","organizations_url":"https://api.github.com/users/lookfwd/orgs","repos_url":"https://api.github.com/users/lookfwd/repos","events_url":"https://api.github.com/users/lookfwd/events{/privacy}","received_events_url":"https://api.github.com/users/lookfwd/received_events","type":"User","site_admin":false},"body":"This adds some draft implementations of a Higher Order Tracer and demonstrate how you can do a C++11 wrapper (that should be provided by OT / shouldn't be app-specific).","created_at":"2017-01-25T21:03:52Z","updated_at":"2017-01-25T21:38:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70091bd11084b1fdc906a09b761bc762c74872a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/issues/1/comments","statuses_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/statuses/787d80accf06d21b5d95b4febf01fbb67e25eceb","head":{"label":"lookfwd:cpp11_and_hot","ref":"cpp11_and_hot","sha":"787d80accf06d21b5d95b4febf01fbb67e25eceb","user":{"login":"lookfwd","id":789359,"avatar_url":"https://avatars.githubusercontent.com/u/789359?v=3","gravatar_id":"","url":"https://api.github.com/users/lookfwd","html_url":"https://github.com/lookfwd","followers_url":"https://api.github.com/users/lookfwd/followers","following_url":"https://api.github.com/users/lookfwd/following{/other_user}","gists_url":"https://api.github.com/users/lookfwd/gists{/gist_id}","starred_url":"https://api.github.com/users/lookfwd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookfwd/subscriptions","organizations_url":"https://api.github.com/users/lookfwd/orgs","repos_url":"https://api.github.com/users/lookfwd/repos","events_url":"https://api.github.com/users/lookfwd/events{/privacy}","received_events_url":"https://api.github.com/users/lookfwd/received_events","type":"User","site_admin":false},"repo":{"id":75386768,"name":"opentracing-cpp","full_name":"lookfwd/opentracing-cpp","owner":{"login":"lookfwd","id":789359,"avatar_url":"https://avatars.githubusercontent.com/u/789359?v=3","gravatar_id":"","url":"https://api.github.com/users/lookfwd","html_url":"https://github.com/lookfwd","followers_url":"https://api.github.com/users/lookfwd/followers","following_url":"https://api.github.com/users/lookfwd/following{/other_user}","gists_url":"https://api.github.com/users/lookfwd/gists{/gist_id}","starred_url":"https://api.github.com/users/lookfwd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookfwd/subscriptions","organizations_url":"https://api.github.com/users/lookfwd/orgs","repos_url":"https://api.github.com/users/lookfwd/repos","events_url":"https://api.github.com/users/lookfwd/events{/privacy}","received_events_url":"https://api.github.com/users/lookfwd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lookfwd/opentracing-cpp","description":null,"fork":true,"url":"https://api.github.com/repos/lookfwd/opentracing-cpp","forks_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/forks","keys_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/teams","hooks_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/hooks","issue_events_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/events","assignees_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/tags","blobs_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/languages","stargazers_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/stargazers","contributors_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/contributors","subscribers_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/subscribers","subscription_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/subscription","commits_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/merges","archive_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/downloads","issues_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/labels{/name}","releases_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/lookfwd/opentracing-cpp/deployments","created_at":"2016-12-02T10:41:39Z","updated_at":"2017-01-25T18:56:06Z","pushed_at":"2017-01-25T21:14:04Z","git_url":"git://github.com/lookfwd/opentracing-cpp.git","ssh_url":"git@github.com:lookfwd/opentracing-cpp.git","clone_url":"https://github.com/lookfwd/opentracing-cpp.git","svn_url":"https://github.com/lookfwd/opentracing-cpp","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquinn47:master","ref":"master","sha":"3e8d73c8e09abab92d09f91baba71e7da30a9c76","user":{"login":"jquinn47","id":5684681,"avatar_url":"https://avatars.githubusercontent.com/u/5684681?v=3","gravatar_id":"","url":"https://api.github.com/users/jquinn47","html_url":"https://github.com/jquinn47","followers_url":"https://api.github.com/users/jquinn47/followers","following_url":"https://api.github.com/users/jquinn47/following{/other_user}","gists_url":"https://api.github.com/users/jquinn47/gists{/gist_id}","starred_url":"https://api.github.com/users/jquinn47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquinn47/subscriptions","organizations_url":"https://api.github.com/users/jquinn47/orgs","repos_url":"https://api.github.com/users/jquinn47/repos","events_url":"https://api.github.com/users/jquinn47/events{/privacy}","received_events_url":"https://api.github.com/users/jquinn47/received_events","type":"User","site_admin":false},"repo":{"id":78659030,"name":"opentracing-cpp","full_name":"jquinn47/opentracing-cpp","owner":{"login":"jquinn47","id":5684681,"avatar_url":"https://avatars.githubusercontent.com/u/5684681?v=3","gravatar_id":"","url":"https://api.github.com/users/jquinn47","html_url":"https://github.com/jquinn47","followers_url":"https://api.github.com/users/jquinn47/followers","following_url":"https://api.github.com/users/jquinn47/following{/other_user}","gists_url":"https://api.github.com/users/jquinn47/gists{/gist_id}","starred_url":"https://api.github.com/users/jquinn47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquinn47/subscriptions","organizations_url":"https://api.github.com/users/jquinn47/orgs","repos_url":"https://api.github.com/users/jquinn47/repos","events_url":"https://api.github.com/users/jquinn47/events{/privacy}","received_events_url":"https://api.github.com/users/jquinn47/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jquinn47/opentracing-cpp","description":"OpenTracing API for C++","fork":true,"url":"https://api.github.com/repos/jquinn47/opentracing-cpp","forks_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/forks","keys_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/teams","hooks_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/hooks","issue_events_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/events","assignees_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/tags","blobs_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/languages","stargazers_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/stargazers","contributors_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/contributors","subscribers_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/subscribers","subscription_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/subscription","commits_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/merges","archive_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/downloads","issues_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/labels{/name}","releases_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/jquinn47/opentracing-cpp/deployments","created_at":"2017-01-11T16:47:50Z","updated_at":"2017-01-11T16:47:52Z","pushed_at":"2017-01-25T21:14:05Z","git_url":"git://github.com/jquinn47/opentracing-cpp.git","ssh_url":"git@github.com:jquinn47/opentracing-cpp.git","clone_url":"https://github.com/jquinn47/opentracing-cpp.git","svn_url":"https://github.com/jquinn47/opentracing-cpp","homepage":"http://opentracing.io","size":184,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1"},"html":{"href":"https://github.com/jquinn47/opentracing-cpp/pull/1"},"issue":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/issues/1"},"comments":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jquinn47/opentracing-cpp/statuses/787d80accf06d21b5d95b4febf01fbb67e25eceb"}}}}
{"actor":{"display_login":"lookfwd"}}