{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/27738","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/27738/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/27738/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/27738/events","html_url":"https://github.com/ansible/ansible/pull/27738","id":247892928,"number":27738,"title":"get_url, uri: urls docs fragments","user":{"login":"dagwieers","id":388198,"avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"labels":[{"id":562292166,"url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.4","name":"affects_2.4","color":"ededed","default":false},{"id":512406029,"url":"https://api.github.com/repos/ansible/ansible/labels/c:module_utils/urls","name":"c:module_utils/urls","color":"b60205","default":false},{"id":48464763,"url":"https://api.github.com/repos/ansible/ansible/labels/docs_pull_request","name":"docs_pull_request","color":"0052cc","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":593252542,"url":"https://api.github.com/repos/ansible/ansible/labels/net_tools","name":"net_tools","color":"fbca04","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-08-04T03:24:38Z","updated_at":"2017-08-04T08:04:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/27738","html_url":"https://github.com/ansible/ansible/pull/27738","diff_url":"https://github.com/ansible/ansible/pull/27738.diff","patch_url":"https://github.com/ansible/ansible/pull/27738.patch"},"body":"##### SUMMARY\r\nThis PR includes:\r\n- Module docs fragments for the urls module_utils library\r\n- Modifications to get_url and uri to reuse these docs fragments\r\n\r\nI opted to remove `url` and `force` from the docs fragments and\r\n`url_argument_spec` simply because they are not used by fetch_url or\r\nopen_url, or because they depend on a `dest` parameter that is uncommon\r\nfor other modules.\r\n\r\nI have fixes for the following modules too, but unsure if they want to\r\ninclude all fetch_url or open_url supported parameters in their module\r\ndocumentation (I am sure some would be useful though):\r\n\r\n- lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py\r\n- lib/ansible/modules/network/a10/a10_server.py\r\n- lib/ansible/modules/network/a10/a10_server_axapi3.py\r\n- lib/ansible/modules/network/a10/a10_service_group.py\r\n- lib/ansible/modules/network/a10/a10_virtual_server.py\r\n- lib/ansible/modules/notification/nexmo.py\r\n- lib/ansible/modules/packaging/os/pulp_repo.py\r\n- lib/ansible/modules/web_infrastructure/jenkins_plugin.py\r\n\r\n##### ISSUE TYPE\r\n - Docs Pull Request\r\n\r\n##### COMPONENT NAME\r\nget_url\r\nuri\r\n\r\n##### ANSIBLE VERSION\r\nv2.4"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/320185074","html_url":"https://github.com/ansible/ansible/pull/27738#issuecomment-320185074","issue_url":"https://api.github.com/repos/ansible/ansible/issues/27738","id":320185074,"user":{"login":"dagwieers","id":388198,"avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"created_at":"2017-08-04T08:04:25Z","updated_at":"2017-08-04T08:04:25Z","body":"Ready to be merged (despite Shippable failure, which is OK)."}}
{"actor":{"display_login":"dagwieers"}}