{"action":"created","issue":{"url":"https://api.github.com/repos/gap-system/gap/issues/1207","repository_url":"https://api.github.com/repos/gap-system/gap","labels_url":"https://api.github.com/repos/gap-system/gap/issues/1207/labels{/name}","comments_url":"https://api.github.com/repos/gap-system/gap/issues/1207/comments","events_url":"https://api.github.com/repos/gap-system/gap/issues/1207/events","html_url":"https://github.com/gap-system/gap/pull/1207","id":218460572,"number":1207,"title":"Improve Test and TestDirectory, sync more HPC-GAP test files","user":{"login":"fingolfin","id":241512,"avatar_url":"https://avatars1.githubusercontent.com/u/241512?v=3","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"labels":[{"id":186140274,"url":"https://api.github.com/repos/gap-system/gap/labels/HPC-GAP","name":"HPC-GAP","color":"0052cc","default":false},{"id":314624714,"url":"https://api.github.com/repos/gap-system/gap/labels/HPC-GAP%20unification","name":"HPC-GAP unification","color":"009800","default":false},{"id":300498843,"url":"https://api.github.com/repos/gap-system/gap/labels/tests","name":"tests","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-31T10:21:05Z","updated_at":"2017-04-01T07:06:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gap-system/gap/pulls/1207","html_url":"https://github.com/gap-system/gap/pull/1207","diff_url":"https://github.com/gap-system/gap/pull/1207.diff","patch_url":"https://github.com/gap-system/gap/pull/1207.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/gap-system/gap/issues/comments/290901645","html_url":"https://github.com/gap-system/gap/pull/1207#issuecomment-290901645","issue_url":"https://api.github.com/repos/gap-system/gap/issues/1207","id":290901645,"user":{"login":"fingolfin","id":241512,"avatar_url":"https://avatars1.githubusercontent.com/u/241512?v=3","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"created_at":"2017-04-01T07:06:47Z","updated_at":"2017-04-01T07:06:47Z","body":"Problem is with the tests for `Test()`. The diffs look as if there was no actual diff. Problem is that while this is true visually, it isn't true on the byte level: one of the things I added is code which shows where in the test we currently are at. I made this the new default. Some ways to fix this issue:\r\n* turn the new code off by default\r\n* as above, but turn it on only within `TestDirectory`\r\n* modify the problematic test(s) to explicitly set `showProgress:=false`\r\n* teach the diff code some basics about matching things based on their visual appearance, e.g. about \\c and \\r (I am not fond of this idea, but it is a possibility, so I list it)\r\n* .... ?"}}
{"actor":{"display_login":"fingolfin"}}