{"action":"created","issue":{"url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify/issues/16","repository_url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify","labels_url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify/issues/16/comments","events_url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify/issues/16/events","html_url":"https://github.com/jkarsrud/ember-cli-defeatureify/pull/16","id":123780426,"number":16,"title":"Move to modules.","user":{"login":"nathanhammond","id":20542,"avatar_url":"https://avatars2.githubusercontent.com/u/20542?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhammond","html_url":"https://github.com/nathanhammond","followers_url":"https://api.github.com/users/nathanhammond/followers","following_url":"https://api.github.com/users/nathanhammond/following{/other_user}","gists_url":"https://api.github.com/users/nathanhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhammond/subscriptions","organizations_url":"https://api.github.com/users/nathanhammond/orgs","repos_url":"https://api.github.com/users/nathanhammond/repos","events_url":"https://api.github.com/users/nathanhammond/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhammond/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-12-24T09:23:13Z","updated_at":"2017-05-17T11:43:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify/pulls/16","html_url":"https://github.com/jkarsrud/ember-cli-defeatureify/pull/16","diff_url":"https://github.com/jkarsrud/ember-cli-defeatureify/pull/16.diff","patch_url":"https://github.com/jkarsrud/ember-cli-defeatureify/pull/16.patch"},"body":"`ember-cli-defeatureify` presently requires globals since the processing for feature stripping does a string comparison on the variable path. This PR implements a solution that allows for importing of the feature configuration as a module and removes globals. As a consequence there is no longer any need to specify `namespace` as that will consistently be the module name.\n\nThis also dramatically reduces the complexity of the addon. I've also ported it to an up-to-date blueprint.\n\nDepends on https://github.com/ember-cli/ember-cli/pull/5233/ landing in order to support configuration in a meta tag.\n\nCloses #15.\n"},"comment":{"url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify/issues/comments/302065154","html_url":"https://github.com/jkarsrud/ember-cli-defeatureify/pull/16#issuecomment-302065154","issue_url":"https://api.github.com/repos/jkarsrud/ember-cli-defeatureify/issues/16","id":302065154,"user":{"login":"erkie","id":21059,"avatar_url":"https://avatars3.githubusercontent.com/u/21059?v=3","gravatar_id":"","url":"https://api.github.com/users/erkie","html_url":"https://github.com/erkie","followers_url":"https://api.github.com/users/erkie/followers","following_url":"https://api.github.com/users/erkie/following{/other_user}","gists_url":"https://api.github.com/users/erkie/gists{/gist_id}","starred_url":"https://api.github.com/users/erkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erkie/subscriptions","organizations_url":"https://api.github.com/users/erkie/orgs","repos_url":"https://api.github.com/users/erkie/repos","events_url":"https://api.github.com/users/erkie/events{/privacy}","received_events_url":"https://api.github.com/users/erkie/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T11:43:13Z","updated_at":"2017-05-17T11:43:13Z","body":"Any chance of getting this merged? Looking forward to getting rid of the deprecation:\r\n\r\n```\r\nDEPRECATION: The `app-prefix` hook used in ember-cli-defeatureify is deprecated. The addon should generate a module and have consumers `require` it.\r\n```\r\n\r\n:D"}}
{"actor":{"display_login":"erkie"}}