{"action":"opened","number":46,"pull_request":{"url":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/46","id":148914266,"html_url":"https://github.com/LanternPowered/LanternServer/pull/46","diff_url":"https://github.com/LanternPowered/LanternServer/pull/46.diff","patch_url":"https://github.com/LanternPowered/LanternServer/pull/46.patch","issue_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues/46","number":46,"state":"open","locked":false,"title":"Inventory refactor part 2 - inventory and archetype builders","user":{"login":"Cybermaxke","id":1364375,"avatar_url":"https://avatars1.githubusercontent.com/u/1364375?v=4","gravatar_id":"","url":"https://api.github.com/users/Cybermaxke","html_url":"https://github.com/Cybermaxke","followers_url":"https://api.github.com/users/Cybermaxke/followers","following_url":"https://api.github.com/users/Cybermaxke/following{/other_user}","gists_url":"https://api.github.com/users/Cybermaxke/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybermaxke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybermaxke/subscriptions","organizations_url":"https://api.github.com/users/Cybermaxke/orgs","repos_url":"https://api.github.com/users/Cybermaxke/repos","events_url":"https://api.github.com/users/Cybermaxke/events{/privacy}","received_events_url":"https://api.github.com/users/Cybermaxke/received_events","type":"User","site_admin":false},"body":"The big inventory refactor is reaching it's end, so testing can get started. Testing should also target possible inventory plugins.\r\n\r\nChanges:\r\n- Inventories are no longer populated inside a inventory, but through builders.\r\n- Every inventory (except views) are have also a archetype assigned to them.\r\n- Implemented the SpongeAPI archetype and inventory builders.\r\n- Containers no longer contain the inventory structure, but just slots (ContainerSlots). You can use the transform methods on slots to get the original ones.\r\n- All the inventories that are generated with a carrier will also implement CarriedInventory (through class generation)\r\n- A client container bug fix. Long clicking a slot (without dragging) was also considered a dragging mode and is now handled like a normal click. This was causing items to disappear.\r\n\r\nTODO:\r\n- Figure out how to properly handle all the property operations? (When comparing two properties and have the DELEGATE operation, fallback to EQUAL?)\r\n- Testing\r\n- Bugs?\r\n- Anything missing?","created_at":"2017-10-26T11:59:51Z","updated_at":"2017-10-26T11:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"Cybermaxke","id":1364375,"avatar_url":"https://avatars1.githubusercontent.com/u/1364375?v=4","gravatar_id":"","url":"https://api.github.com/users/Cybermaxke","html_url":"https://github.com/Cybermaxke","followers_url":"https://api.github.com/users/Cybermaxke/followers","following_url":"https://api.github.com/users/Cybermaxke/following{/other_user}","gists_url":"https://api.github.com/users/Cybermaxke/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybermaxke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybermaxke/subscriptions","organizations_url":"https://api.github.com/users/Cybermaxke/orgs","repos_url":"https://api.github.com/users/Cybermaxke/repos","events_url":"https://api.github.com/users/Cybermaxke/events{/privacy}","received_events_url":"https://api.github.com/users/Cybermaxke/received_events","type":"User","site_admin":false},"assignees":[{"login":"Cybermaxke","id":1364375,"avatar_url":"https://avatars1.githubusercontent.com/u/1364375?v=4","gravatar_id":"","url":"https://api.github.com/users/Cybermaxke","html_url":"https://github.com/Cybermaxke","followers_url":"https://api.github.com/users/Cybermaxke/followers","following_url":"https://api.github.com/users/Cybermaxke/following{/other_user}","gists_url":"https://api.github.com/users/Cybermaxke/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybermaxke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybermaxke/subscriptions","organizations_url":"https://api.github.com/users/Cybermaxke/orgs","repos_url":"https://api.github.com/users/Cybermaxke/repos","events_url":"https://api.github.com/users/Cybermaxke/events{/privacy}","received_events_url":"https://api.github.com/users/Cybermaxke/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/46/commits","review_comments_url":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/46/comments","review_comment_url":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues/46/comments","statuses_url":"https://api.github.com/repos/LanternPowered/LanternServer/statuses/b2f2e165bb11ccdb85ad0fad1ea7b64c96f18df5","head":{"label":"LanternPowered:inventory-refactor-part-2-rebase","ref":"inventory-refactor-part-2-rebase","sha":"b2f2e165bb11ccdb85ad0fad1ea7b64c96f18df5","user":{"login":"LanternPowered","id":12448476,"avatar_url":"https://avatars2.githubusercontent.com/u/12448476?v=4","gravatar_id":"","url":"https://api.github.com/users/LanternPowered","html_url":"https://github.com/LanternPowered","followers_url":"https://api.github.com/users/LanternPowered/followers","following_url":"https://api.github.com/users/LanternPowered/following{/other_user}","gists_url":"https://api.github.com/users/LanternPowered/gists{/gist_id}","starred_url":"https://api.github.com/users/LanternPowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LanternPowered/subscriptions","organizations_url":"https://api.github.com/users/LanternPowered/orgs","repos_url":"https://api.github.com/users/LanternPowered/repos","events_url":"https://api.github.com/users/LanternPowered/events{/privacy}","received_events_url":"https://api.github.com/users/LanternPowered/received_events","type":"Organization","site_admin":false},"repo":{"id":35904382,"name":"LanternServer","full_name":"LanternPowered/LanternServer","owner":{"login":"LanternPowered","id":12448476,"avatar_url":"https://avatars2.githubusercontent.com/u/12448476?v=4","gravatar_id":"","url":"https://api.github.com/users/LanternPowered","html_url":"https://github.com/LanternPowered","followers_url":"https://api.github.com/users/LanternPowered/followers","following_url":"https://api.github.com/users/LanternPowered/following{/other_user}","gists_url":"https://api.github.com/users/LanternPowered/gists{/gist_id}","starred_url":"https://api.github.com/users/LanternPowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LanternPowered/subscriptions","organizations_url":"https://api.github.com/users/LanternPowered/orgs","repos_url":"https://api.github.com/users/LanternPowered/repos","events_url":"https://api.github.com/users/LanternPowered/events{/privacy}","received_events_url":"https://api.github.com/users/LanternPowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LanternPowered/LanternServer","description":"A open-source Minecraft server that implements the SpongeAPI.","fork":false,"url":"https://api.github.com/repos/LanternPowered/LanternServer","forks_url":"https://api.github.com/repos/LanternPowered/LanternServer/forks","keys_url":"https://api.github.com/repos/LanternPowered/LanternServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LanternPowered/LanternServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LanternPowered/LanternServer/teams","hooks_url":"https://api.github.com/repos/LanternPowered/LanternServer/hooks","issue_events_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues/events{/number}","events_url":"https://api.github.com/repos/LanternPowered/LanternServer/events","assignees_url":"https://api.github.com/repos/LanternPowered/LanternServer/assignees{/user}","branches_url":"https://api.github.com/repos/LanternPowered/LanternServer/branches{/branch}","tags_url":"https://api.github.com/repos/LanternPowered/LanternServer/tags","blobs_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LanternPowered/LanternServer/statuses/{sha}","languages_url":"https://api.github.com/repos/LanternPowered/LanternServer/languages","stargazers_url":"https://api.github.com/repos/LanternPowered/LanternServer/stargazers","contributors_url":"https://api.github.com/repos/LanternPowered/LanternServer/contributors","subscribers_url":"https://api.github.com/repos/LanternPowered/LanternServer/subscribers","subscription_url":"https://api.github.com/repos/LanternPowered/LanternServer/subscription","commits_url":"https://api.github.com/repos/LanternPowered/LanternServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/LanternPowered/LanternServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/LanternPowered/LanternServer/contents/{+path}","compare_url":"https://api.github.com/repos/LanternPowered/LanternServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LanternPowered/LanternServer/merges","archive_url":"https://api.github.com/repos/LanternPowered/LanternServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LanternPowered/LanternServer/downloads","issues_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues{/number}","pulls_url":"https://api.github.com/repos/LanternPowered/LanternServer/pulls{/number}","milestones_url":"https://api.github.com/repos/LanternPowered/LanternServer/milestones{/number}","notifications_url":"https://api.github.com/repos/LanternPowered/LanternServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LanternPowered/LanternServer/labels{/name}","releases_url":"https://api.github.com/repos/LanternPowered/LanternServer/releases{/id}","deployments_url":"https://api.github.com/repos/LanternPowered/LanternServer/deployments","created_at":"2015-05-19T19:41:11Z","updated_at":"2017-10-21T17:30:05Z","pushed_at":"2017-10-25T22:22:13Z","git_url":"git://github.com/LanternPowered/LanternServer.git","ssh_url":"git@github.com:LanternPowered/LanternServer.git","clone_url":"https://github.com/LanternPowered/LanternServer.git","svn_url":"https://github.com/LanternPowered/LanternServer","homepage":"","size":8397,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":25,"default_branch":"master"}},"base":{"label":"LanternPowered:master","ref":"master","sha":"3950bbdb8504a4472c7e4e3a49231c66af7ab712","user":{"login":"LanternPowered","id":12448476,"avatar_url":"https://avatars2.githubusercontent.com/u/12448476?v=4","gravatar_id":"","url":"https://api.github.com/users/LanternPowered","html_url":"https://github.com/LanternPowered","followers_url":"https://api.github.com/users/LanternPowered/followers","following_url":"https://api.github.com/users/LanternPowered/following{/other_user}","gists_url":"https://api.github.com/users/LanternPowered/gists{/gist_id}","starred_url":"https://api.github.com/users/LanternPowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LanternPowered/subscriptions","organizations_url":"https://api.github.com/users/LanternPowered/orgs","repos_url":"https://api.github.com/users/LanternPowered/repos","events_url":"https://api.github.com/users/LanternPowered/events{/privacy}","received_events_url":"https://api.github.com/users/LanternPowered/received_events","type":"Organization","site_admin":false},"repo":{"id":35904382,"name":"LanternServer","full_name":"LanternPowered/LanternServer","owner":{"login":"LanternPowered","id":12448476,"avatar_url":"https://avatars2.githubusercontent.com/u/12448476?v=4","gravatar_id":"","url":"https://api.github.com/users/LanternPowered","html_url":"https://github.com/LanternPowered","followers_url":"https://api.github.com/users/LanternPowered/followers","following_url":"https://api.github.com/users/LanternPowered/following{/other_user}","gists_url":"https://api.github.com/users/LanternPowered/gists{/gist_id}","starred_url":"https://api.github.com/users/LanternPowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LanternPowered/subscriptions","organizations_url":"https://api.github.com/users/LanternPowered/orgs","repos_url":"https://api.github.com/users/LanternPowered/repos","events_url":"https://api.github.com/users/LanternPowered/events{/privacy}","received_events_url":"https://api.github.com/users/LanternPowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LanternPowered/LanternServer","description":"A open-source Minecraft server that implements the SpongeAPI.","fork":false,"url":"https://api.github.com/repos/LanternPowered/LanternServer","forks_url":"https://api.github.com/repos/LanternPowered/LanternServer/forks","keys_url":"https://api.github.com/repos/LanternPowered/LanternServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LanternPowered/LanternServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LanternPowered/LanternServer/teams","hooks_url":"https://api.github.com/repos/LanternPowered/LanternServer/hooks","issue_events_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues/events{/number}","events_url":"https://api.github.com/repos/LanternPowered/LanternServer/events","assignees_url":"https://api.github.com/repos/LanternPowered/LanternServer/assignees{/user}","branches_url":"https://api.github.com/repos/LanternPowered/LanternServer/branches{/branch}","tags_url":"https://api.github.com/repos/LanternPowered/LanternServer/tags","blobs_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LanternPowered/LanternServer/statuses/{sha}","languages_url":"https://api.github.com/repos/LanternPowered/LanternServer/languages","stargazers_url":"https://api.github.com/repos/LanternPowered/LanternServer/stargazers","contributors_url":"https://api.github.com/repos/LanternPowered/LanternServer/contributors","subscribers_url":"https://api.github.com/repos/LanternPowered/LanternServer/subscribers","subscription_url":"https://api.github.com/repos/LanternPowered/LanternServer/subscription","commits_url":"https://api.github.com/repos/LanternPowered/LanternServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/LanternPowered/LanternServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/LanternPowered/LanternServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/LanternPowered/LanternServer/contents/{+path}","compare_url":"https://api.github.com/repos/LanternPowered/LanternServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LanternPowered/LanternServer/merges","archive_url":"https://api.github.com/repos/LanternPowered/LanternServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LanternPowered/LanternServer/downloads","issues_url":"https://api.github.com/repos/LanternPowered/LanternServer/issues{/number}","pulls_url":"https://api.github.com/repos/LanternPowered/LanternServer/pulls{/number}","milestones_url":"https://api.github.com/repos/LanternPowered/LanternServer/milestones{/number}","notifications_url":"https://api.github.com/repos/LanternPowered/LanternServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LanternPowered/LanternServer/labels{/name}","releases_url":"https://api.github.com/repos/LanternPowered/LanternServer/releases{/id}","deployments_url":"https://api.github.com/repos/LanternPowered/LanternServer/deployments","created_at":"2015-05-19T19:41:11Z","updated_at":"2017-10-21T17:30:05Z","pushed_at":"2017-10-25T22:22:13Z","git_url":"git://github.com/LanternPowered/LanternServer.git","ssh_url":"git@github.com:LanternPowered/LanternServer.git","clone_url":"https://github.com/LanternPowered/LanternServer.git","svn_url":"https://github.com/LanternPowered/LanternServer","homepage":"","size":8397,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/46"},"html":{"href":"https://github.com/LanternPowered/LanternServer/pull/46"},"issue":{"href":"https://api.github.com/repos/LanternPowered/LanternServer/issues/46"},"comments":{"href":"https://api.github.com/repos/LanternPowered/LanternServer/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LanternPowered/LanternServer/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/LanternPowered/LanternServer/statuses/b2f2e165bb11ccdb85ad0fad1ea7b64c96f18df5"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":30,"additions":9261,"deletions":5434,"changed_files":172}}
{"actor":{"display_login":"Cybermaxke"}}