{"action":"created","issue":{"url":"https://api.github.com/repos/CelticMinstrel/wesnoth/issues/286","repository_url":"https://api.github.com/repos/CelticMinstrel/wesnoth","labels_url":"https://api.github.com/repos/CelticMinstrel/wesnoth/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/CelticMinstrel/wesnoth/issues/286/comments","events_url":"https://api.github.com/repos/CelticMinstrel/wesnoth/issues/286/events","html_url":"https://github.com/CelticMinstrel/wesnoth/issues/286","id":226740751,"number":286,"title":"Screenshot indexer bug on Windows (and translation of it's filenames)","user":{"login":"CelticMinstrel","id":578731,"avatar_url":"https://avatars0.githubusercontent.com/u/578731?v=3","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"labels":[{"id":597427713,"url":"https://api.github.com/repos/CelticMinstrel/wesnoth/labels/bug","name":"bug","color":"ee0701","default":true},{"id":597436143,"url":"https://api.github.com/repos/CelticMinstrel/wesnoth/labels/Translations","name":"Translations","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-06T05:28:06Z","updated_at":"2017-05-06T05:28:10Z","closed_at":null,"body":"**[Original submission](https://gna.org/bugs/index.php?19665)** by fphoenix on 2012-04-26\n\nThere was bug with incorrect encoding until 1.10.2 version (#19425). In 1.10.2 encoding was normalized, but now game can't set normal index to Cyrillic filenames and always overwrite zero-screenshot (000). Only under Windows, and only when using translation.\n\n\n\nBy the way, it's too bad that string \"Screenshot\" is shared in translation, i.e. used for both - hotkey list and part of filename:\n\n|| WESNOTH-LIB.POT\n\n|| #: src/hotkeys.cpp:67 src/hotkeys.cpp:1179\n\n|| msgid \"Screenshot\"\n\n|| msgstr \"\"\n\nIn Russian language it's normally translating with 2 words (like \"screen shot\"; we use an Anglicism too, but it's just a jargon), but translators can't choice a splitting character between this words and index, and summary name seems like \"screen shot_000.bmp\".\n\nSo I think, it will be much better, if you change this lines in hotkeys.cpp (for example):\n\n|| std::string name = map_screenshot ? _(\"Map-Screenshot\") : _(\"Screenshot\");\n\n|| std::string filename = get_screenshot_dir() + \"/\" + name + \"_\";\n\nto\n\n|| std::string name = map_screenshot ? _(\"Map-Screenshot_\") : _(\"Screenshot_\");\n\n|| std::string filename = get_screenshot_dir() + \"/\" + name;"},"comment":{"url":"https://api.github.com/repos/CelticMinstrel/wesnoth/issues/comments/299617162","html_url":"https://github.com/CelticMinstrel/wesnoth/issues/286#issuecomment-299617162","issue_url":"https://api.github.com/repos/CelticMinstrel/wesnoth/issues/286","id":299617162,"user":{"login":"CelticMinstrel","id":578731,"avatar_url":"https://avatars0.githubusercontent.com/u/578731?v=3","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"created_at":"2017-05-06T05:28:10Z","updated_at":"2017-05-06T05:28:10Z","body":"**Modified on 2012-04-26**\n\n**shadowmaster wrote:**\n\n> The second part of this report should really have been a feature request in a new tracker issue instead; regardless, I'll address it here for now.\n> \n> \n> \n> What you suggest is that we let translators choose an appropriate filename component separator for their language? Because it seems to me like a better approach would be for them to be able to translate a proper format string like the following:\n> \n> \n> \n> &quot;Screenshot_$number&quot;\n> \n> &quot;Map-Screenshot_$number&quot;\n> \n> \n> \n> This way they could also choose whether $number (which is replaced at runtime by the actual screenshot number) should go in front or at the end of the label.\n> \n> \n> \n> By the way, when citing source code it's better that you don't change it in the post. For example, (&quot;Foo&quot;) (a non-translatable string) is not the same as _(&quot;Foo&quot;) (a translatable string)."}}
{"actor":{"display_login":"CelticMinstrel"}}