{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/docs/pulls/comments/135594989","pull_request_review_id":59023481,"id":135594989,"diff_hunk":"@@ -33,10 +33,10 @@ Metapackages are implicitly referenced based on the target framework(s) specifie\n ### Recommendations\n Since `Microsoft.NETCore.App` or `NetStandard.Library` metapackages are implicitly referenced, the following are our recommended best practices:\n \n-* Never have an explicit reference to the `Microsoft.NETCore.App` or `NetStandard.Library` metapackages via a `<PackageReference>` item in your project file.\n-* If you need a specific version of the runtime, you should use the `<RuntimeFrameworkVersion>` property in your project (for example, `1.0.4`) instead of referencing the metapackage.\n+* Never have an explicit reference to the `Microsoft.NETCore.App` or `NetStandard.Library` metapackages via a `<PackageReference>` item in your project file when trageting .NET Core or .NET Standard.","path":"docs/core/tools/csproj.md","position":6,"original_position":6,"commit_id":"7c64f44b3c643225937f8940810ce9d6376a7b13","original_commit_id":"7c64f44b3c643225937f8940810ce9d6376a7b13","user":{"login":"mairaw","id":12971179,"avatar_url":"https://avatars2.githubusercontent.com/u/12971179?v=4","gravatar_id":"","url":"https://api.github.com/users/mairaw","html_url":"https://github.com/mairaw","followers_url":"https://api.github.com/users/mairaw/followers","following_url":"https://api.github.com/users/mairaw/following{/other_user}","gists_url":"https://api.github.com/users/mairaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mairaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairaw/subscriptions","organizations_url":"https://api.github.com/users/mairaw/orgs","repos_url":"https://api.github.com/users/mairaw/repos","events_url":"https://api.github.com/users/mairaw/events{/privacy}","received_events_url":"https://api.github.com/users/mairaw/received_events","type":"User","site_admin":false},"body":"typo: tagreting\r\nI'd also start with the condition: When targeting ..., never have ...\r\n\r\nAlso wondering if we want to be more explicit about the .NET Framework case here too?","created_at":"2017-08-28T18:17:44Z","updated_at":"2017-08-28T18:25:52Z","html_url":"https://github.com/dotnet/docs/pull/3006#discussion_r135594989","pull_request_url":"https://api.github.com/repos/dotnet/docs/pulls/3006","_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments/135594989"},"html":{"href":"https://github.com/dotnet/docs/pull/3006#discussion_r135594989"},"pull_request":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3006"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/3006","id":137836408,"html_url":"https://github.com/dotnet/docs/pull/3006","diff_url":"https://github.com/dotnet/docs/pull/3006.diff","patch_url":"https://github.com/dotnet/docs/pull/3006.patch","issue_url":"https://api.github.com/repos/dotnet/docs/issues/3006","number":3006,"state":"open","locked":false,"title":"csproj.md: Emphasise implicit version context","user":{"login":"dasMulli","id":6129250,"avatar_url":"https://avatars1.githubusercontent.com/u/6129250?v=4","gravatar_id":"","url":"https://api.github.com/users/dasMulli","html_url":"https://github.com/dasMulli","followers_url":"https://api.github.com/users/dasMulli/followers","following_url":"https://api.github.com/users/dasMulli/following{/other_user}","gists_url":"https://api.github.com/users/dasMulli/gists{/gist_id}","starred_url":"https://api.github.com/users/dasMulli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasMulli/subscriptions","organizations_url":"https://api.github.com/users/dasMulli/orgs","repos_url":"https://api.github.com/users/dasMulli/repos","events_url":"https://api.github.com/users/dasMulli/events{/privacy}","received_events_url":"https://api.github.com/users/dasMulli/received_events","type":"User","site_admin":false},"body":"Emphasises that `RuntimeFrameworkVersion` and `NetStandardImplicitPackageVersion` only apply to .NET Core and .NET Standard projects respectively.\r\n\r\nContext: https://github.com/NuGet/Home/issues/5809 - User expected `NetStandardImplicitPackageVersion` to work for a .NET Framework project.","created_at":"2017-08-27T14:57:28Z","updated_at":"2017-08-28T18:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e75399b91ee2f6272b340c78a899dc8459613a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/docs/pulls/3006/commits","review_comments_url":"https://api.github.com/repos/dotnet/docs/pulls/3006/comments","review_comment_url":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/3006/comments","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/7c64f44b3c643225937f8940810ce9d6376a7b13","head":{"label":"dasMulli:patch-3","ref":"patch-3","sha":"7c64f44b3c643225937f8940810ce9d6376a7b13","user":{"login":"dasMulli","id":6129250,"avatar_url":"https://avatars1.githubusercontent.com/u/6129250?v=4","gravatar_id":"","url":"https://api.github.com/users/dasMulli","html_url":"https://github.com/dasMulli","followers_url":"https://api.github.com/users/dasMulli/followers","following_url":"https://api.github.com/users/dasMulli/following{/other_user}","gists_url":"https://api.github.com/users/dasMulli/gists{/gist_id}","starred_url":"https://api.github.com/users/dasMulli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasMulli/subscriptions","organizations_url":"https://api.github.com/users/dasMulli/orgs","repos_url":"https://api.github.com/users/dasMulli/repos","events_url":"https://api.github.com/users/dasMulli/events{/privacy}","received_events_url":"https://api.github.com/users/dasMulli/received_events","type":"User","site_admin":false},"repo":{"id":95527897,"name":"docs","full_name":"dasMulli/docs","owner":{"login":"dasMulli","id":6129250,"avatar_url":"https://avatars1.githubusercontent.com/u/6129250?v=4","gravatar_id":"","url":"https://api.github.com/users/dasMulli","html_url":"https://github.com/dasMulli","followers_url":"https://api.github.com/users/dasMulli/followers","following_url":"https://api.github.com/users/dasMulli/following{/other_user}","gists_url":"https://api.github.com/users/dasMulli/gists{/gist_id}","starred_url":"https://api.github.com/users/dasMulli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasMulli/subscriptions","organizations_url":"https://api.github.com/users/dasMulli/orgs","repos_url":"https://api.github.com/users/dasMulli/repos","events_url":"https://api.github.com/users/dasMulli/events{/privacy}","received_events_url":"https://api.github.com/users/dasMulli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dasMulli/docs","description":"This repository contains .NET Documentation.","fork":true,"url":"https://api.github.com/repos/dasMulli/docs","forks_url":"https://api.github.com/repos/dasMulli/docs/forks","keys_url":"https://api.github.com/repos/dasMulli/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dasMulli/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dasMulli/docs/teams","hooks_url":"https://api.github.com/repos/dasMulli/docs/hooks","issue_events_url":"https://api.github.com/repos/dasMulli/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dasMulli/docs/events","assignees_url":"https://api.github.com/repos/dasMulli/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dasMulli/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dasMulli/docs/tags","blobs_url":"https://api.github.com/repos/dasMulli/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dasMulli/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dasMulli/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dasMulli/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dasMulli/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dasMulli/docs/languages","stargazers_url":"https://api.github.com/repos/dasMulli/docs/stargazers","contributors_url":"https://api.github.com/repos/dasMulli/docs/contributors","subscribers_url":"https://api.github.com/repos/dasMulli/docs/subscribers","subscription_url":"https://api.github.com/repos/dasMulli/docs/subscription","commits_url":"https://api.github.com/repos/dasMulli/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dasMulli/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dasMulli/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dasMulli/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dasMulli/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dasMulli/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dasMulli/docs/merges","archive_url":"https://api.github.com/repos/dasMulli/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dasMulli/docs/downloads","issues_url":"https://api.github.com/repos/dasMulli/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dasMulli/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dasMulli/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dasMulli/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dasMulli/docs/labels{/name}","releases_url":"https://api.github.com/repos/dasMulli/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dasMulli/docs/deployments","created_at":"2017-06-27T07:02:12Z","updated_at":"2017-06-27T04:13:44Z","pushed_at":"2017-08-27T14:55:56Z","git_url":"git://github.com/dasMulli/docs.git","ssh_url":"git@github.com:dasMulli/docs.git","clone_url":"https://github.com/dasMulli/docs.git","svn_url":"https://github.com/dasMulli/docs","homepage":"https://docs.microsoft.com/dotnet","size":392022,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c4a9ddd32802e30969b481dad0ffaf55aab44b5c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35890081,"name":"docs","full_name":"dotnet/docs","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/docs","description":"This repository contains .NET Documentation.","fork":false,"url":"https://api.github.com/repos/dotnet/docs","forks_url":"https://api.github.com/repos/dotnet/docs/forks","keys_url":"https://api.github.com/repos/dotnet/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docs/teams","hooks_url":"https://api.github.com/repos/dotnet/docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docs/events","assignees_url":"https://api.github.com/repos/dotnet/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docs/tags","blobs_url":"https://api.github.com/repos/dotnet/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docs/languages","stargazers_url":"https://api.github.com/repos/dotnet/docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docs/subscription","commits_url":"https://api.github.com/repos/dotnet/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docs/merges","archive_url":"https://api.github.com/repos/dotnet/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docs/downloads","issues_url":"https://api.github.com/repos/dotnet/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docs/deployments","created_at":"2015-05-19T15:13:32Z","updated_at":"2017-08-28T08:48:49Z","pushed_at":"2017-08-28T18:16:30Z","git_url":"git://github.com/dotnet/docs.git","ssh_url":"git@github.com:dotnet/docs.git","clone_url":"https://github.com/dotnet/docs.git","svn_url":"https://github.com/dotnet/docs","homepage":"https://docs.microsoft.com/dotnet","size":422431,"stargazers_count":613,"watchers_count":613,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1179,"mirror_url":null,"open_issues_count":334,"forks":1179,"open_issues":334,"watchers":613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3006"},"html":{"href":"https://github.com/dotnet/docs/pull/3006"},"issue":{"href":"https://api.github.com/repos/dotnet/docs/issues/3006"},"comments":{"href":"https://api.github.com/repos/dotnet/docs/issues/3006/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3006/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3006/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docs/statuses/7c64f44b3c643225937f8940810ce9d6376a7b13"}}}}
{"actor":{"display_login":"mairaw"}}