{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/3692","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/3692/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/3692/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/3692/events","html_url":"https://github.com/oppia/oppia/pull/3692","id":247325427,"number":3692,"title":"Add editor for audio translations","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tjiang11","id":11807091,"avatar_url":"https://avatars2.githubusercontent.com/u/11807091?v=4","gravatar_id":"","url":"https://api.github.com/users/tjiang11","html_url":"https://github.com/tjiang11","followers_url":"https://api.github.com/users/tjiang11/followers","following_url":"https://api.github.com/users/tjiang11/following{/other_user}","gists_url":"https://api.github.com/users/tjiang11/gists{/gist_id}","starred_url":"https://api.github.com/users/tjiang11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjiang11/subscriptions","organizations_url":"https://api.github.com/users/tjiang11/orgs","repos_url":"https://api.github.com/users/tjiang11/repos","events_url":"https://api.github.com/users/tjiang11/events{/privacy}","received_events_url":"https://api.github.com/users/tjiang11/received_events","type":"User","site_admin":false},"assignees":[{"login":"tjiang11","id":11807091,"avatar_url":"https://avatars2.githubusercontent.com/u/11807091?v=4","gravatar_id":"","url":"https://api.github.com/users/tjiang11","html_url":"https://github.com/tjiang11","followers_url":"https://api.github.com/users/tjiang11/followers","following_url":"https://api.github.com/users/tjiang11/following{/other_user}","gists_url":"https://api.github.com/users/tjiang11/gists{/gist_id}","starred_url":"https://api.github.com/users/tjiang11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjiang11/subscriptions","organizations_url":"https://api.github.com/users/tjiang11/orgs","repos_url":"https://api.github.com/users/tjiang11/repos","events_url":"https://api.github.com/users/tjiang11/events{/privacy}","received_events_url":"https://api.github.com/users/tjiang11/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-08-02T09:23:16Z","updated_at":"2017-08-02T09:28:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/3692","html_url":"https://github.com/oppia/oppia/pull/3692","diff_url":"https://github.com/oppia/oppia/pull/3692.diff","patch_url":"https://github.com/oppia/oppia/pull/3692.patch"},"body":"Hi @tjiang11 -- unfortunately, this is all I was able to do tonight, but I think it's not bad :) Could you please take it for a spin and also do a preliminary code review? Note that this has quite a few dependencies on #3681 (which you'll notice when reviewing) -- so if you could get that into develop asap, that would be great, since there's a fair bit of merge work needed!\r\n\r\nI haven't yet written tests. I'll do that tomorrow, though I'd appreciate a first pass first (both code and UI) to make sure things aren't too amiss.\r\n\r\n- [ ] Tests for newly-added functionality\r\n\r\nAlso, the following stuff has not been done. I'd welcome advice on whether you think either or both of them are necessary for v1?\r\n\r\n- [ ] \"Deprecate audio\" functionality\r\n- [ ] \"Edit audio\" modal\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/319619766","html_url":"https://github.com/oppia/oppia/pull/3692#issuecomment-319619766","issue_url":"https://api.github.com/repos/oppia/oppia/issues/3692","id":319619766,"user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"created_at":"2017-08-02T09:28:35Z","updated_at":"2017-08-02T09:28:35Z","body":"Btw, I'm slightly worried about the GCS part of this, since I wasn't able to test it when working on this PR. We should make sure to do some robust tests of the end-to-end audio upload/play functionality during the release prep week."}}
{"actor":{"display_login":"seanlip"}}