{"action":"created","issue":{"url":"https://api.github.com/repos/BrianHicks/elm-benchmark/issues/16","repository_url":"https://api.github.com/repos/BrianHicks/elm-benchmark","labels_url":"https://api.github.com/repos/BrianHicks/elm-benchmark/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/BrianHicks/elm-benchmark/issues/16/comments","events_url":"https://api.github.com/repos/BrianHicks/elm-benchmark/issues/16/events","html_url":"https://github.com/BrianHicks/elm-benchmark/pull/16","id":235850827,"number":16,"title":"WIP: Add support for comparing more than two benchmarks.","user":{"login":"Skinney","id":854889,"avatar_url":"https://avatars2.githubusercontent.com/u/854889?v=3","gravatar_id":"","url":"https://api.github.com/users/Skinney","html_url":"https://github.com/Skinney","followers_url":"https://api.github.com/users/Skinney/followers","following_url":"https://api.github.com/users/Skinney/following{/other_user}","gists_url":"https://api.github.com/users/Skinney/gists{/gist_id}","starred_url":"https://api.github.com/users/Skinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skinney/subscriptions","organizations_url":"https://api.github.com/users/Skinney/orgs","repos_url":"https://api.github.com/users/Skinney/repos","events_url":"https://api.github.com/users/Skinney/events{/privacy}","received_events_url":"https://api.github.com/users/Skinney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-14T11:40:07Z","updated_at":"2017-07-13T14:14:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BrianHicks/elm-benchmark/pulls/16","html_url":"https://github.com/BrianHicks/elm-benchmark/pull/16","diff_url":"https://github.com/BrianHicks/elm-benchmark/pull/16.diff","patch_url":"https://github.com/BrianHicks/elm-benchmark/pull/16.patch"},"body":"Every now and again, I've had the need to compare more than two benchmarks. For instance, what is faster of the Core list implementation, my new list implementation, and this altered version of my new list implementation.\r\n\r\nThis PR adds support for comparing as many benchmarks as the user sees fit.\r\n\r\nThis PR might need some more work, so I hope the all wise Brian can give me some pointers.\r\n\r\n* I'm not sure of the UI. It takes a lot of (horizontal) space.\r\n* Instead of a `compare` fn taking a list, maybe it would be better to have `compare2`, `compare3`, `compare4`... This way, a comparison has to be made with at least two benchmarks.\r\n* The code can probably be cleaned up a little.\r\n\r\nI'm thinking of adding `elm-plot` diagrams to this, but it's nice to agree on the base implementation first."},"comment":{"url":"https://api.github.com/repos/BrianHicks/elm-benchmark/issues/comments/315090422","html_url":"https://github.com/BrianHicks/elm-benchmark/pull/16#issuecomment-315090422","issue_url":"https://api.github.com/repos/BrianHicks/elm-benchmark/issues/16","id":315090422,"user":{"login":"BrianHicks","id":355401,"avatar_url":"https://avatars3.githubusercontent.com/u/355401?v=3","gravatar_id":"","url":"https://api.github.com/users/BrianHicks","html_url":"https://github.com/BrianHicks","followers_url":"https://api.github.com/users/BrianHicks/followers","following_url":"https://api.github.com/users/BrianHicks/following{/other_user}","gists_url":"https://api.github.com/users/BrianHicks/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianHicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianHicks/subscriptions","organizations_url":"https://api.github.com/users/BrianHicks/orgs","repos_url":"https://api.github.com/users/BrianHicks/repos","events_url":"https://api.github.com/users/BrianHicks/events{/privacy}","received_events_url":"https://api.github.com/users/BrianHicks/received_events","type":"User","site_admin":false},"created_at":"2017-07-13T14:14:13Z","updated_at":"2017-07-13T14:14:13Z","body":"Following up on scheduling in the Elm Slack."}}
{"actor":{"display_login":"BrianHicks"}}