{"action":"created","comment":{"url":"https://api.github.com/repos/tajo/react-portal/pulls/comments/153922397","pull_request_review_id":80006036,"id":153922397,"diff_hunk":"@@ -27,7 +27,8 @@\n     \"prepublish\": \"cross-env NODE_ENV=production npm run build\",\n     \"lint\": \"eslint webpack.config.js src/**/*.js\",\n     \"format\": \"prettier --write \\\"**/*.js\\\"\",\n-    \"test\": \"cross-env BABEL_ENV=commonjs jest --no-cache\"\n+    \"test\": \"cross-env BABEL_ENV=commonjs jest --no-cache\",\n+    \"react\": \"enzyme-adapter-react-install 16.2.0\"","path":"package.json","position":6,"original_position":6,"commit_id":"b2dd858e7b33d814a6e0db72fb799a2ae06e17cb","original_commit_id":"b2dd858e7b33d814a6e0db72fb799a2ae06e17cb","user":{"login":"brucewpaul","id":17549440,"avatar_url":"https://avatars2.githubusercontent.com/u/17549440?v=4","gravatar_id":"","url":"https://api.github.com/users/brucewpaul","html_url":"https://github.com/brucewpaul","followers_url":"https://api.github.com/users/brucewpaul/followers","following_url":"https://api.github.com/users/brucewpaul/following{/other_user}","gists_url":"https://api.github.com/users/brucewpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/brucewpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucewpaul/subscriptions","organizations_url":"https://api.github.com/users/brucewpaul/orgs","repos_url":"https://api.github.com/users/brucewpaul/repos","events_url":"https://api.github.com/users/brucewpaul/events{/privacy}","received_events_url":"https://api.github.com/users/brucewpaul/received_events","type":"User","site_admin":false},"body":"there is a bug in semver.intersect that enzyme-adapter-react-helper uses. Once that is resolved, we will be able to use a wider semver as opposed to locking it down a specific version","created_at":"2017-11-29T21:38:07Z","updated_at":"2017-11-29T21:38:07Z","html_url":"https://github.com/tajo/react-portal/pull/182#discussion_r153922397","pull_request_url":"https://api.github.com/repos/tajo/react-portal/pulls/182","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/comments/153922397"},"html":{"href":"https://github.com/tajo/react-portal/pull/182#discussion_r153922397"},"pull_request":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/tajo/react-portal/pulls/182","id":155210241,"html_url":"https://github.com/tajo/react-portal/pull/182","diff_url":"https://github.com/tajo/react-portal/pull/182.diff","patch_url":"https://github.com/tajo/react-portal/pull/182.patch","issue_url":"https://api.github.com/repos/tajo/react-portal/issues/182","number":182,"state":"open","locked":false,"title":"implement fallback portal","user":{"login":"brucewpaul","id":17549440,"avatar_url":"https://avatars2.githubusercontent.com/u/17549440?v=4","gravatar_id":"","url":"https://api.github.com/users/brucewpaul","html_url":"https://github.com/brucewpaul","followers_url":"https://api.github.com/users/brucewpaul/followers","following_url":"https://api.github.com/users/brucewpaul/following{/other_user}","gists_url":"https://api.github.com/users/brucewpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/brucewpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucewpaul/subscriptions","organizations_url":"https://api.github.com/users/brucewpaul/orgs","repos_url":"https://api.github.com/users/brucewpaul/repos","events_url":"https://api.github.com/users/brucewpaul/events{/privacy}","received_events_url":"https://api.github.com/users/brucewpaul/received_events","type":"User","site_admin":false},"body":"the point of this pr is to create a fallback protal that uses the\r\ncustom portal if we are not on react16 (by checking to see if\r\nReactDOM.createPortal is present), and the new Portal if we are on\r\nReact16.\r\n\r\nthis pr addresses https://github.com/tajo/react-portal/issues/180\r\n\r\n@majapw @lencioni @tajo @ranneyd @ljharb","created_at":"2017-11-28T23:22:30Z","updated_at":"2017-11-29T21:38:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16bf9dfd00c4daaf72cd17d486c16908dea89403","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tajo/react-portal/pulls/182/commits","review_comments_url":"https://api.github.com/repos/tajo/react-portal/pulls/182/comments","review_comment_url":"https://api.github.com/repos/tajo/react-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tajo/react-portal/issues/182/comments","statuses_url":"https://api.github.com/repos/tajo/react-portal/statuses/b2dd858e7b33d814a6e0db72fb799a2ae06e17cb","head":{"label":"brucewpaul:bwp--create-fallback","ref":"bwp--create-fallback","sha":"b2dd858e7b33d814a6e0db72fb799a2ae06e17cb","user":{"login":"brucewpaul","id":17549440,"avatar_url":"https://avatars2.githubusercontent.com/u/17549440?v=4","gravatar_id":"","url":"https://api.github.com/users/brucewpaul","html_url":"https://github.com/brucewpaul","followers_url":"https://api.github.com/users/brucewpaul/followers","following_url":"https://api.github.com/users/brucewpaul/following{/other_user}","gists_url":"https://api.github.com/users/brucewpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/brucewpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucewpaul/subscriptions","organizations_url":"https://api.github.com/users/brucewpaul/orgs","repos_url":"https://api.github.com/users/brucewpaul/repos","events_url":"https://api.github.com/users/brucewpaul/events{/privacy}","received_events_url":"https://api.github.com/users/brucewpaul/received_events","type":"User","site_admin":false},"repo":{"id":112398330,"name":"react-portal","full_name":"brucewpaul/react-portal","owner":{"login":"brucewpaul","id":17549440,"avatar_url":"https://avatars2.githubusercontent.com/u/17549440?v=4","gravatar_id":"","url":"https://api.github.com/users/brucewpaul","html_url":"https://github.com/brucewpaul","followers_url":"https://api.github.com/users/brucewpaul/followers","following_url":"https://api.github.com/users/brucewpaul/following{/other_user}","gists_url":"https://api.github.com/users/brucewpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/brucewpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucewpaul/subscriptions","organizations_url":"https://api.github.com/users/brucewpaul/orgs","repos_url":"https://api.github.com/users/brucewpaul/repos","events_url":"https://api.github.com/users/brucewpaul/events{/privacy}","received_events_url":"https://api.github.com/users/brucewpaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brucewpaul/react-portal","description":"React component for transportation of modals, lightboxes, loading bars... to document.body","fork":true,"url":"https://api.github.com/repos/brucewpaul/react-portal","forks_url":"https://api.github.com/repos/brucewpaul/react-portal/forks","keys_url":"https://api.github.com/repos/brucewpaul/react-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brucewpaul/react-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brucewpaul/react-portal/teams","hooks_url":"https://api.github.com/repos/brucewpaul/react-portal/hooks","issue_events_url":"https://api.github.com/repos/brucewpaul/react-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brucewpaul/react-portal/events","assignees_url":"https://api.github.com/repos/brucewpaul/react-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brucewpaul/react-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brucewpaul/react-portal/tags","blobs_url":"https://api.github.com/repos/brucewpaul/react-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brucewpaul/react-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brucewpaul/react-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brucewpaul/react-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brucewpaul/react-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brucewpaul/react-portal/languages","stargazers_url":"https://api.github.com/repos/brucewpaul/react-portal/stargazers","contributors_url":"https://api.github.com/repos/brucewpaul/react-portal/contributors","subscribers_url":"https://api.github.com/repos/brucewpaul/react-portal/subscribers","subscription_url":"https://api.github.com/repos/brucewpaul/react-portal/subscription","commits_url":"https://api.github.com/repos/brucewpaul/react-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brucewpaul/react-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brucewpaul/react-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brucewpaul/react-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/brucewpaul/react-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brucewpaul/react-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brucewpaul/react-portal/merges","archive_url":"https://api.github.com/repos/brucewpaul/react-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brucewpaul/react-portal/downloads","issues_url":"https://api.github.com/repos/brucewpaul/react-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brucewpaul/react-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brucewpaul/react-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brucewpaul/react-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brucewpaul/react-portal/labels{/name}","releases_url":"https://api.github.com/repos/brucewpaul/react-portal/releases{/id}","deployments_url":"https://api.github.com/repos/brucewpaul/react-portal/deployments","created_at":"2017-11-28T22:49:53Z","updated_at":"2017-11-28T22:49:55Z","pushed_at":"2017-11-29T21:36:11Z","git_url":"git://github.com/brucewpaul/react-portal.git","ssh_url":"git@github.com:brucewpaul/react-portal.git","clone_url":"https://github.com/brucewpaul/react-portal.git","svn_url":"https://github.com/brucewpaul/react-portal","homepage":"","size":3717,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tajo:master","ref":"master","sha":"11c6a3953fe1f8569e9c4cc79d051eeae429d41a","user":{"login":"tajo","id":1387913,"avatar_url":"https://avatars3.githubusercontent.com/u/1387913?v=4","gravatar_id":"","url":"https://api.github.com/users/tajo","html_url":"https://github.com/tajo","followers_url":"https://api.github.com/users/tajo/followers","following_url":"https://api.github.com/users/tajo/following{/other_user}","gists_url":"https://api.github.com/users/tajo/gists{/gist_id}","starred_url":"https://api.github.com/users/tajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tajo/subscriptions","organizations_url":"https://api.github.com/users/tajo/orgs","repos_url":"https://api.github.com/users/tajo/repos","events_url":"https://api.github.com/users/tajo/events{/privacy}","received_events_url":"https://api.github.com/users/tajo/received_events","type":"User","site_admin":false},"repo":{"id":32820926,"name":"react-portal","full_name":"tajo/react-portal","owner":{"login":"tajo","id":1387913,"avatar_url":"https://avatars3.githubusercontent.com/u/1387913?v=4","gravatar_id":"","url":"https://api.github.com/users/tajo","html_url":"https://github.com/tajo","followers_url":"https://api.github.com/users/tajo/followers","following_url":"https://api.github.com/users/tajo/following{/other_user}","gists_url":"https://api.github.com/users/tajo/gists{/gist_id}","starred_url":"https://api.github.com/users/tajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tajo/subscriptions","organizations_url":"https://api.github.com/users/tajo/orgs","repos_url":"https://api.github.com/users/tajo/repos","events_url":"https://api.github.com/users/tajo/events{/privacy}","received_events_url":"https://api.github.com/users/tajo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tajo/react-portal","description":"React component for transportation of modals, lightboxes, loading bars... to document.body","fork":false,"url":"https://api.github.com/repos/tajo/react-portal","forks_url":"https://api.github.com/repos/tajo/react-portal/forks","keys_url":"https://api.github.com/repos/tajo/react-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tajo/react-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tajo/react-portal/teams","hooks_url":"https://api.github.com/repos/tajo/react-portal/hooks","issue_events_url":"https://api.github.com/repos/tajo/react-portal/issues/events{/number}","events_url":"https://api.github.com/repos/tajo/react-portal/events","assignees_url":"https://api.github.com/repos/tajo/react-portal/assignees{/user}","branches_url":"https://api.github.com/repos/tajo/react-portal/branches{/branch}","tags_url":"https://api.github.com/repos/tajo/react-portal/tags","blobs_url":"https://api.github.com/repos/tajo/react-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tajo/react-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tajo/react-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/tajo/react-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tajo/react-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/tajo/react-portal/languages","stargazers_url":"https://api.github.com/repos/tajo/react-portal/stargazers","contributors_url":"https://api.github.com/repos/tajo/react-portal/contributors","subscribers_url":"https://api.github.com/repos/tajo/react-portal/subscribers","subscription_url":"https://api.github.com/repos/tajo/react-portal/subscription","commits_url":"https://api.github.com/repos/tajo/react-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/tajo/react-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/tajo/react-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/tajo/react-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/tajo/react-portal/contents/{+path}","compare_url":"https://api.github.com/repos/tajo/react-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tajo/react-portal/merges","archive_url":"https://api.github.com/repos/tajo/react-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tajo/react-portal/downloads","issues_url":"https://api.github.com/repos/tajo/react-portal/issues{/number}","pulls_url":"https://api.github.com/repos/tajo/react-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/tajo/react-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/tajo/react-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tajo/react-portal/labels{/name}","releases_url":"https://api.github.com/repos/tajo/react-portal/releases{/id}","deployments_url":"https://api.github.com/repos/tajo/react-portal/deployments","created_at":"2015-03-24T19:42:56Z","updated_at":"2017-11-29T18:27:23Z","pushed_at":"2017-11-29T21:36:12Z","git_url":"git://github.com/tajo/react-portal.git","ssh_url":"git@github.com:tajo/react-portal.git","clone_url":"https://github.com/tajo/react-portal.git","svn_url":"https://github.com/tajo/react-portal","homepage":"","size":3799,"stargazers_count":1305,"watchers_count":1305,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":142,"open_issues":6,"watchers":1305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/182"},"html":{"href":"https://github.com/tajo/react-portal/pull/182"},"issue":{"href":"https://api.github.com/repos/tajo/react-portal/issues/182"},"comments":{"href":"https://api.github.com/repos/tajo/react-portal/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/tajo/react-portal/statuses/b2dd858e7b33d814a6e0db72fb799a2ae06e17cb"}},"author_association":"NONE"}}
{"actor":{"display_login":"brucewpaul"}}