{"action":"created","comment":{"url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/comments/112810554","pull_request_review_id":34158291,"id":112810554,"diff_hunk":"@@ -85,12 +85,15 @@ def _make_relative(self, path):\n             path = canonicalPath(path)\n             if path.startswith(self.pp):\n                 path = path[self.pplen:]\n-                while path.startswith(\"/\"): # pragma: no cover\n-                    # We should not be able to get here. canonicalPath\n-                    # doesn't allow trailing / in a path segment, and we\n-                    # already cut off the whole length of the parent, which\n-                    # we guaranteed to begin and end with a /\n-                    path = path[1:]\n+                # Now, the path should not actually begin with a /.\n+                # canonicalPath doesn't allow trailing / in a path\n+                # segment, and we already cut off the whole length of\n+                # the parent, which we guaranteed to begin and end\n+                # with a /. But it's possible that older dependencies\n+                # than we test with could produce this scenario, so we\n+                # leave it for BWC.","path":"src/zope/app/dependable/__init__.py","position":52,"original_position":16,"commit_id":"a3fbc9c951b448c85f37529619a3f6e4d9b70402","original_commit_id":"a3fbc9c951b448c85f37529619a3f6e4d9b70402","user":{"login":"mgedmin","id":159967,"avatar_url":"https://avatars0.githubusercontent.com/u/159967?v=3","gravatar_id":"","url":"https://api.github.com/users/mgedmin","html_url":"https://github.com/mgedmin","followers_url":"https://api.github.com/users/mgedmin/followers","following_url":"https://api.github.com/users/mgedmin/following{/other_user}","gists_url":"https://api.github.com/users/mgedmin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgedmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgedmin/subscriptions","organizations_url":"https://api.github.com/users/mgedmin/orgs","repos_url":"https://api.github.com/users/mgedmin/repos","events_url":"https://api.github.com/users/mgedmin/events{/privacy}","received_events_url":"https://api.github.com/users/mgedmin/received_events","type":"User","site_admin":false},"body":"BWC = backwards compatibility?  First time I see this acronym.\r\n\r\n(We used to use BBB in Zope-land, which doesn't stand for anything, and I guess was just a version of XXX, but for backwards compatibility support code.)","created_at":"2017-04-22T14:12:24Z","updated_at":"2017-04-22T14:12:33Z","html_url":"https://github.com/zopefoundation/zope.app.dependable/pull/1#discussion_r112810554","pull_request_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/comments/112810554"},"html":{"href":"https://github.com/zopefoundation/zope.app.dependable/pull/1#discussion_r112810554"},"pull_request":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1","id":116844913,"html_url":"https://github.com/zopefoundation/zope.app.dependable/pull/1","diff_url":"https://github.com/zopefoundation/zope.app.dependable/pull/1.diff","patch_url":"https://github.com/zopefoundation/zope.app.dependable/pull/1.patch","issue_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/1","number":1,"state":"open","locked":false,"title":"Python 3 port","user":{"login":"jamadden","id":1256082,"avatar_url":"https://avatars0.githubusercontent.com/u/1256082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamadden","html_url":"https://github.com/jamadden","followers_url":"https://api.github.com/users/jamadden/followers","following_url":"https://api.github.com/users/jamadden/following{/other_user}","gists_url":"https://api.github.com/users/jamadden/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadden/subscriptions","organizations_url":"https://api.github.com/users/jamadden/orgs","repos_url":"https://api.github.com/users/jamadden/repos","events_url":"https://api.github.com/users/jamadden/events{/privacy}","received_events_url":"https://api.github.com/users/jamadden/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-20T19:18:43Z","updated_at":"2017-04-22T14:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8444666acd6d28940946e757df5ee1017e3d33a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1/commits","review_comments_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1/comments","review_comment_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/1/comments","statuses_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/statuses/a3fbc9c951b448c85f37529619a3f6e4d9b70402","head":{"label":"zopefoundation:py3","ref":"py3","sha":"a3fbc9c951b448c85f37529619a3f6e4d9b70402","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars2.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":8727810,"name":"zope.app.dependable","full_name":"zopefoundation/zope.app.dependable","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars2.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/zope.app.dependable","description":"Simple Dependency API","fork":false,"url":"https://api.github.com/repos/zopefoundation/zope.app.dependable","forks_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/forks","keys_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/teams","hooks_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/events","assignees_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/tags","blobs_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/subscription","commits_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/merges","archive_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/downloads","issues_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/deployments","created_at":"2013-03-12T12:59:51Z","updated_at":"2016-04-20T12:42:33Z","pushed_at":"2017-04-22T14:03:47Z","git_url":"git://github.com/zopefoundation/zope.app.dependable.git","ssh_url":"git@github.com:zopefoundation/zope.app.dependable.git","clone_url":"https://github.com/zopefoundation/zope.app.dependable.git","svn_url":"https://github.com/zopefoundation/zope.app.dependable","homepage":"","size":102,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zopefoundation:master","ref":"master","sha":"a5f907e3b66221e1b85f0ff3bb846f6147b61f38","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars2.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":8727810,"name":"zope.app.dependable","full_name":"zopefoundation/zope.app.dependable","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars2.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/zope.app.dependable","description":"Simple Dependency API","fork":false,"url":"https://api.github.com/repos/zopefoundation/zope.app.dependable","forks_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/forks","keys_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/teams","hooks_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/events","assignees_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/tags","blobs_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/subscription","commits_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/merges","archive_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/downloads","issues_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/zope.app.dependable/deployments","created_at":"2013-03-12T12:59:51Z","updated_at":"2016-04-20T12:42:33Z","pushed_at":"2017-04-22T14:03:47Z","git_url":"git://github.com/zopefoundation/zope.app.dependable.git","ssh_url":"git@github.com:zopefoundation/zope.app.dependable.git","clone_url":"https://github.com/zopefoundation/zope.app.dependable.git","svn_url":"https://github.com/zopefoundation/zope.app.dependable","homepage":"","size":102,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1"},"html":{"href":"https://github.com/zopefoundation/zope.app.dependable/pull/1"},"issue":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/1"},"comments":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/zopefoundation/zope.app.dependable/statuses/a3fbc9c951b448c85f37529619a3f6e4d9b70402"}}}}
{"actor":{"display_login":"mgedmin"}}