{"action":"opened","number":70,"pull_request":{"url":"https://api.github.com/repos/topsframework/tops/pulls/70","id":113544700,"html_url":"https://github.com/topsframework/tops/pull/70","diff_url":"https://github.com/topsframework/tops/pull/70.diff","patch_url":"https://github.com/topsframework/tops/pull/70.patch","issue_url":"https://api.github.com/repos/topsframework/tops/issues/70","number":70,"state":"open","locked":false,"title":"Use purely virtual methods for secretaries","user":{"login":"renatocf","id":1621752,"avatar_url":"https://avatars2.githubusercontent.com/u/1621752?v=3","gravatar_id":"","url":"https://api.github.com/users/renatocf","html_url":"https://github.com/renatocf","followers_url":"https://api.github.com/users/renatocf/followers","following_url":"https://api.github.com/users/renatocf/following{/other_user}","gists_url":"https://api.github.com/users/renatocf/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocf/subscriptions","organizations_url":"https://api.github.com/users/renatocf/orgs","repos_url":"https://api.github.com/users/renatocf/repos","events_url":"https://api.github.com/users/renatocf/events{/privacy}","received_events_url":"https://api.github.com/users/renatocf/received_events","type":"User","site_admin":false},"body":"@igorbonadio,\r\n\r\nI'm working again on ToPS and, in order to start, I made some changes I've been wanting to do for some time. I changed `ProbabilisticModelCrtp` and `DecodableModelCrtp` to declare the methods for which Secretaries delegate to as [pure virtual methods with implementation](http://stackoverflow.com/questions/2089083/pure-virtual-function-with-implementation). This way, all subclasses must override those methods, but they still can reuse the superclasses' implementations by **explicitly** calling their methods. I believe this makes our implementations more clear: now there is no doubt that a new class have to declare one of these methods.\r\n\r\nLastly, I made some improvements in the documentation (moving the Doxygen comments from IID to the interfaces) and removed the class `ProbabilisticModelDecoratorCrtp`, which was not adding much to our architecture.\r\n\r\n","created_at":"2017-03-30T23:17:15Z","updated_at":"2017-03-30T23:17:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/topsframework/tops/pulls/70/commits","review_comments_url":"https://api.github.com/repos/topsframework/tops/pulls/70/comments","review_comment_url":"https://api.github.com/repos/topsframework/tops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/topsframework/tops/issues/70/comments","statuses_url":"https://api.github.com/repos/topsframework/tops/statuses/d3796415b5d5e2fca855a9749bbd9cfe9000c55f","head":{"label":"topsframework:refactoring/purely_virtual_methods","ref":"refactoring/purely_virtual_methods","sha":"d3796415b5d5e2fca855a9749bbd9cfe9000c55f","user":{"login":"topsframework","id":10686225,"avatar_url":"https://avatars2.githubusercontent.com/u/10686225?v=3","gravatar_id":"","url":"https://api.github.com/users/topsframework","html_url":"https://github.com/topsframework","followers_url":"https://api.github.com/users/topsframework/followers","following_url":"https://api.github.com/users/topsframework/following{/other_user}","gists_url":"https://api.github.com/users/topsframework/gists{/gist_id}","starred_url":"https://api.github.com/users/topsframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topsframework/subscriptions","organizations_url":"https://api.github.com/users/topsframework/orgs","repos_url":"https://api.github.com/users/topsframework/repos","events_url":"https://api.github.com/users/topsframework/events{/privacy}","received_events_url":"https://api.github.com/users/topsframework/received_events","type":"Organization","site_admin":false},"repo":{"id":29786362,"name":"tops","full_name":"topsframework/tops","owner":{"login":"topsframework","id":10686225,"avatar_url":"https://avatars2.githubusercontent.com/u/10686225?v=3","gravatar_id":"","url":"https://api.github.com/users/topsframework","html_url":"https://github.com/topsframework","followers_url":"https://api.github.com/users/topsframework/followers","following_url":"https://api.github.com/users/topsframework/following{/other_user}","gists_url":"https://api.github.com/users/topsframework/gists{/gist_id}","starred_url":"https://api.github.com/users/topsframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topsframework/subscriptions","organizations_url":"https://api.github.com/users/topsframework/orgs","repos_url":"https://api.github.com/users/topsframework/repos","events_url":"https://api.github.com/users/topsframework/events{/privacy}","received_events_url":"https://api.github.com/users/topsframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/topsframework/tops","description":"ToPS Framework -","fork":false,"url":"https://api.github.com/repos/topsframework/tops","forks_url":"https://api.github.com/repos/topsframework/tops/forks","keys_url":"https://api.github.com/repos/topsframework/tops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topsframework/tops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topsframework/tops/teams","hooks_url":"https://api.github.com/repos/topsframework/tops/hooks","issue_events_url":"https://api.github.com/repos/topsframework/tops/issues/events{/number}","events_url":"https://api.github.com/repos/topsframework/tops/events","assignees_url":"https://api.github.com/repos/topsframework/tops/assignees{/user}","branches_url":"https://api.github.com/repos/topsframework/tops/branches{/branch}","tags_url":"https://api.github.com/repos/topsframework/tops/tags","blobs_url":"https://api.github.com/repos/topsframework/tops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topsframework/tops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topsframework/tops/git/refs{/sha}","trees_url":"https://api.github.com/repos/topsframework/tops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topsframework/tops/statuses/{sha}","languages_url":"https://api.github.com/repos/topsframework/tops/languages","stargazers_url":"https://api.github.com/repos/topsframework/tops/stargazers","contributors_url":"https://api.github.com/repos/topsframework/tops/contributors","subscribers_url":"https://api.github.com/repos/topsframework/tops/subscribers","subscription_url":"https://api.github.com/repos/topsframework/tops/subscription","commits_url":"https://api.github.com/repos/topsframework/tops/commits{/sha}","git_commits_url":"https://api.github.com/repos/topsframework/tops/git/commits{/sha}","comments_url":"https://api.github.com/repos/topsframework/tops/comments{/number}","issue_comment_url":"https://api.github.com/repos/topsframework/tops/issues/comments{/number}","contents_url":"https://api.github.com/repos/topsframework/tops/contents/{+path}","compare_url":"https://api.github.com/repos/topsframework/tops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topsframework/tops/merges","archive_url":"https://api.github.com/repos/topsframework/tops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topsframework/tops/downloads","issues_url":"https://api.github.com/repos/topsframework/tops/issues{/number}","pulls_url":"https://api.github.com/repos/topsframework/tops/pulls{/number}","milestones_url":"https://api.github.com/repos/topsframework/tops/milestones{/number}","notifications_url":"https://api.github.com/repos/topsframework/tops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topsframework/tops/labels{/name}","releases_url":"https://api.github.com/repos/topsframework/tops/releases{/id}","deployments_url":"https://api.github.com/repos/topsframework/tops/deployments","created_at":"2015-01-24T18:14:09Z","updated_at":"2016-01-26T17:09:10Z","pushed_at":"2017-03-30T22:47:27Z","git_url":"git://github.com/topsframework/tops.git","ssh_url":"git@github.com:topsframework/tops.git","clone_url":"https://github.com/topsframework/tops.git","svn_url":"https://github.com/topsframework/tops","homepage":"http://topsframework.github.io/tops/doc/api/","size":2762,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":23,"forks":1,"open_issues":23,"watchers":4,"default_branch":"master"}},"base":{"label":"topsframework:master","ref":"master","sha":"955f43ea83a19c6c5741424e589c0c20b24161b1","user":{"login":"topsframework","id":10686225,"avatar_url":"https://avatars2.githubusercontent.com/u/10686225?v=3","gravatar_id":"","url":"https://api.github.com/users/topsframework","html_url":"https://github.com/topsframework","followers_url":"https://api.github.com/users/topsframework/followers","following_url":"https://api.github.com/users/topsframework/following{/other_user}","gists_url":"https://api.github.com/users/topsframework/gists{/gist_id}","starred_url":"https://api.github.com/users/topsframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topsframework/subscriptions","organizations_url":"https://api.github.com/users/topsframework/orgs","repos_url":"https://api.github.com/users/topsframework/repos","events_url":"https://api.github.com/users/topsframework/events{/privacy}","received_events_url":"https://api.github.com/users/topsframework/received_events","type":"Organization","site_admin":false},"repo":{"id":29786362,"name":"tops","full_name":"topsframework/tops","owner":{"login":"topsframework","id":10686225,"avatar_url":"https://avatars2.githubusercontent.com/u/10686225?v=3","gravatar_id":"","url":"https://api.github.com/users/topsframework","html_url":"https://github.com/topsframework","followers_url":"https://api.github.com/users/topsframework/followers","following_url":"https://api.github.com/users/topsframework/following{/other_user}","gists_url":"https://api.github.com/users/topsframework/gists{/gist_id}","starred_url":"https://api.github.com/users/topsframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topsframework/subscriptions","organizations_url":"https://api.github.com/users/topsframework/orgs","repos_url":"https://api.github.com/users/topsframework/repos","events_url":"https://api.github.com/users/topsframework/events{/privacy}","received_events_url":"https://api.github.com/users/topsframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/topsframework/tops","description":"ToPS Framework -","fork":false,"url":"https://api.github.com/repos/topsframework/tops","forks_url":"https://api.github.com/repos/topsframework/tops/forks","keys_url":"https://api.github.com/repos/topsframework/tops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topsframework/tops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topsframework/tops/teams","hooks_url":"https://api.github.com/repos/topsframework/tops/hooks","issue_events_url":"https://api.github.com/repos/topsframework/tops/issues/events{/number}","events_url":"https://api.github.com/repos/topsframework/tops/events","assignees_url":"https://api.github.com/repos/topsframework/tops/assignees{/user}","branches_url":"https://api.github.com/repos/topsframework/tops/branches{/branch}","tags_url":"https://api.github.com/repos/topsframework/tops/tags","blobs_url":"https://api.github.com/repos/topsframework/tops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topsframework/tops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topsframework/tops/git/refs{/sha}","trees_url":"https://api.github.com/repos/topsframework/tops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topsframework/tops/statuses/{sha}","languages_url":"https://api.github.com/repos/topsframework/tops/languages","stargazers_url":"https://api.github.com/repos/topsframework/tops/stargazers","contributors_url":"https://api.github.com/repos/topsframework/tops/contributors","subscribers_url":"https://api.github.com/repos/topsframework/tops/subscribers","subscription_url":"https://api.github.com/repos/topsframework/tops/subscription","commits_url":"https://api.github.com/repos/topsframework/tops/commits{/sha}","git_commits_url":"https://api.github.com/repos/topsframework/tops/git/commits{/sha}","comments_url":"https://api.github.com/repos/topsframework/tops/comments{/number}","issue_comment_url":"https://api.github.com/repos/topsframework/tops/issues/comments{/number}","contents_url":"https://api.github.com/repos/topsframework/tops/contents/{+path}","compare_url":"https://api.github.com/repos/topsframework/tops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topsframework/tops/merges","archive_url":"https://api.github.com/repos/topsframework/tops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topsframework/tops/downloads","issues_url":"https://api.github.com/repos/topsframework/tops/issues{/number}","pulls_url":"https://api.github.com/repos/topsframework/tops/pulls{/number}","milestones_url":"https://api.github.com/repos/topsframework/tops/milestones{/number}","notifications_url":"https://api.github.com/repos/topsframework/tops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topsframework/tops/labels{/name}","releases_url":"https://api.github.com/repos/topsframework/tops/releases{/id}","deployments_url":"https://api.github.com/repos/topsframework/tops/deployments","created_at":"2015-01-24T18:14:09Z","updated_at":"2016-01-26T17:09:10Z","pushed_at":"2017-03-30T22:47:27Z","git_url":"git://github.com/topsframework/tops.git","ssh_url":"git@github.com:topsframework/tops.git","clone_url":"https://github.com/topsframework/tops.git","svn_url":"https://github.com/topsframework/tops","homepage":"http://topsframework.github.io/tops/doc/api/","size":2762,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":23,"forks":1,"open_issues":23,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/topsframework/tops/pulls/70"},"html":{"href":"https://github.com/topsframework/tops/pull/70"},"issue":{"href":"https://api.github.com/repos/topsframework/tops/issues/70"},"comments":{"href":"https://api.github.com/repos/topsframework/tops/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/topsframework/tops/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/topsframework/tops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/topsframework/tops/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/topsframework/tops/statuses/d3796415b5d5e2fca855a9749bbd9cfe9000c55f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":17,"additions":1332,"deletions":720,"changed_files":35}}
{"actor":{"display_login":"renatocf"}}