{"action":"created","comment":{"url":"https://api.github.com/repos/bolt/bolt/pulls/comments/115304638","pull_request_review_id":36832933,"id":115304638,"diff_hunk":"@@ -59,10 +60,19 @@ public function getLogin(Request $request, $resetCookies = false)\n         }\n \n         $response = $this->render('@bolt/login/login.twig', ['randomquote' => true]);\n-        $response->setVary('Cookies', false)->setMaxAge(0)->setPrivate();\n-\n-        if ($resetCookies) {\n-            $response->headers->clearCookie($this->app['token.authentication.name']);\n+        if ($response instanceof TemplateView) {\n+            $this->app->after(function (Request $request, Response $response) use ($resetCookies) {\n+                $response->setVary('Cookies', false)->setMaxAge(0)->setPrivate();\n+                if ($resetCookies) {\n+                    $response->headers->clearCookie($this->app['token.authentication.name']);\n+                }\n+            });\n+        } else {\n+            /** @deprecated Deprecated since 3.3, to be removed in 4.0. */\n+            $response->setVary('Cookies', false)->setMaxAge(0)->setPrivate();\n+            if ($resetCookies) {\n+                $response->headers->clearCookie($this->app['token.authentication.name']);\n+            }","path":"src/Controller/Backend/Authentication.php","position":28,"original_position":28,"commit_id":"99a06cdb99d827fc47d30229734c39ba20de11cc","original_commit_id":"99a06cdb99d827fc47d30229734c39ba20de11cc","user":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars0.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"body":"Please tell me I didn't miss that whole block :confused: \r\n\r\nUpdated, and working beautifully","created_at":"2017-05-08T17:27:15Z","updated_at":"2017-05-08T17:27:15Z","html_url":"https://github.com/bolt/bolt/pull/6624#discussion_r115304638","pull_request_url":"https://api.github.com/repos/bolt/bolt/pulls/6624","_links":{"self":{"href":"https://api.github.com/repos/bolt/bolt/pulls/comments/115304638"},"html":{"href":"https://github.com/bolt/bolt/pull/6624#discussion_r115304638"},"pull_request":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6624"}}},"pull_request":{"url":"https://api.github.com/repos/bolt/bolt/pulls/6624","id":119164132,"html_url":"https://github.com/bolt/bolt/pull/6624","diff_url":"https://github.com/bolt/bolt/pull/6624.diff","patch_url":"https://github.com/bolt/bolt/pull/6624.patch","issue_url":"https://api.github.com/repos/bolt/bolt/issues/6624","number":6624,"state":"open","locked":false,"title":"[3.3] Fix TemplateView handling","user":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars0.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"body":"* Don't crash when TwmplateView is really enabled\r\n  * Fix config lookup of \"compatibility\" config values\r\n  * TemplateView BC for routes accessing a rendered response, assuming a Response object\r\n* Render email with Twig, as Swiftmailer messages need strings\r\n* Controller helper to add a middleware that sets the response caching parameters\r\n* Render maintenance mode template directly, as before() is before other listeners\r\n* Dispatch view events for stack add() renders, as they are returned inside JSON\r\n* [Tests] Update for template view, and test legacy on front-end\r\n","created_at":"2017-05-05T12:22:01Z","updated_at":"2017-05-08T17:27:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db02c3afbd7ef785a881ecdde56488440a8a114b","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bolt/bolt/milestones/21","html_url":"https://github.com/bolt/bolt/milestone/21","labels_url":"https://api.github.com/repos/bolt/bolt/milestones/21/labels","id":1940200,"number":21,"title":"Bolt 3.3 - Feature release","description":"","creator":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars0.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":158,"state":"open","created_at":"2016-08-13T11:30:41Z","updated_at":"2017-05-06T07:17:19Z","due_on":"2017-03-06T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bolt/bolt/pulls/6624/commits","review_comments_url":"https://api.github.com/repos/bolt/bolt/pulls/6624/comments","review_comment_url":"https://api.github.com/repos/bolt/bolt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bolt/bolt/issues/6624/comments","statuses_url":"https://api.github.com/repos/bolt/bolt/statuses/99a06cdb99d827fc47d30229734c39ba20de11cc","head":{"label":"bolt:hotfix/config-path-names","ref":"hotfix/config-path-names","sha":"99a06cdb99d827fc47d30229734c39ba20de11cc","user":{"login":"bolt","id":3869752,"avatar_url":"https://avatars1.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"repo":{"id":4665416,"name":"bolt","full_name":"bolt/bolt","owner":{"login":"bolt","id":3869752,"avatar_url":"https://avatars1.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bolt/bolt","description":"Bolt is a simple CMS written in PHP. It is based on Silex and Symfony components, uses Twig and either SQLite, MySQL or PostgreSQL.","fork":false,"url":"https://api.github.com/repos/bolt/bolt","forks_url":"https://api.github.com/repos/bolt/bolt/forks","keys_url":"https://api.github.com/repos/bolt/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bolt/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bolt/bolt/teams","hooks_url":"https://api.github.com/repos/bolt/bolt/hooks","issue_events_url":"https://api.github.com/repos/bolt/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/bolt/bolt/events","assignees_url":"https://api.github.com/repos/bolt/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/bolt/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/bolt/bolt/tags","blobs_url":"https://api.github.com/repos/bolt/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bolt/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bolt/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bolt/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bolt/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/bolt/bolt/languages","stargazers_url":"https://api.github.com/repos/bolt/bolt/stargazers","contributors_url":"https://api.github.com/repos/bolt/bolt/contributors","subscribers_url":"https://api.github.com/repos/bolt/bolt/subscribers","subscription_url":"https://api.github.com/repos/bolt/bolt/subscription","commits_url":"https://api.github.com/repos/bolt/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bolt/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bolt/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bolt/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bolt/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/bolt/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bolt/bolt/merges","archive_url":"https://api.github.com/repos/bolt/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bolt/bolt/downloads","issues_url":"https://api.github.com/repos/bolt/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/bolt/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/bolt/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/bolt/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bolt/bolt/labels{/name}","releases_url":"https://api.github.com/repos/bolt/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/bolt/bolt/deployments","created_at":"2012-06-14T16:07:54Z","updated_at":"2017-05-08T16:52:13Z","pushed_at":"2017-05-08T15:55:04Z","git_url":"git://github.com/bolt/bolt.git","ssh_url":"git@github.com:bolt/bolt.git","clone_url":"https://github.com/bolt/bolt.git","svn_url":"https://github.com/bolt/bolt","homepage":"","size":71116,"stargazers_count":3266,"watchers_count":3266,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":714,"mirror_url":null,"open_issues_count":83,"forks":714,"open_issues":83,"watchers":3266,"default_branch":"release/3.2"}},"base":{"label":"bolt:release/3.3","ref":"release/3.3","sha":"789221e616d00426cd9a23e080bae111b14614a8","user":{"login":"bolt","id":3869752,"avatar_url":"https://avatars1.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"repo":{"id":4665416,"name":"bolt","full_name":"bolt/bolt","owner":{"login":"bolt","id":3869752,"avatar_url":"https://avatars1.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bolt/bolt","description":"Bolt is a simple CMS written in PHP. It is based on Silex and Symfony components, uses Twig and either SQLite, MySQL or PostgreSQL.","fork":false,"url":"https://api.github.com/repos/bolt/bolt","forks_url":"https://api.github.com/repos/bolt/bolt/forks","keys_url":"https://api.github.com/repos/bolt/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bolt/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bolt/bolt/teams","hooks_url":"https://api.github.com/repos/bolt/bolt/hooks","issue_events_url":"https://api.github.com/repos/bolt/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/bolt/bolt/events","assignees_url":"https://api.github.com/repos/bolt/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/bolt/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/bolt/bolt/tags","blobs_url":"https://api.github.com/repos/bolt/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bolt/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bolt/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bolt/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bolt/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/bolt/bolt/languages","stargazers_url":"https://api.github.com/repos/bolt/bolt/stargazers","contributors_url":"https://api.github.com/repos/bolt/bolt/contributors","subscribers_url":"https://api.github.com/repos/bolt/bolt/subscribers","subscription_url":"https://api.github.com/repos/bolt/bolt/subscription","commits_url":"https://api.github.com/repos/bolt/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bolt/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bolt/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bolt/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bolt/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/bolt/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bolt/bolt/merges","archive_url":"https://api.github.com/repos/bolt/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bolt/bolt/downloads","issues_url":"https://api.github.com/repos/bolt/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/bolt/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/bolt/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/bolt/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bolt/bolt/labels{/name}","releases_url":"https://api.github.com/repos/bolt/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/bolt/bolt/deployments","created_at":"2012-06-14T16:07:54Z","updated_at":"2017-05-08T16:52:13Z","pushed_at":"2017-05-08T15:55:04Z","git_url":"git://github.com/bolt/bolt.git","ssh_url":"git@github.com:bolt/bolt.git","clone_url":"https://github.com/bolt/bolt.git","svn_url":"https://github.com/bolt/bolt","homepage":"","size":71116,"stargazers_count":3266,"watchers_count":3266,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":714,"mirror_url":null,"open_issues_count":83,"forks":714,"open_issues":83,"watchers":3266,"default_branch":"release/3.2"}},"_links":{"self":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6624"},"html":{"href":"https://github.com/bolt/bolt/pull/6624"},"issue":{"href":"https://api.github.com/repos/bolt/bolt/issues/6624"},"comments":{"href":"https://api.github.com/repos/bolt/bolt/issues/6624/comments"},"review_comments":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6624/comments"},"review_comment":{"href":"https://api.github.com/repos/bolt/bolt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6624/commits"},"statuses":{"href":"https://api.github.com/repos/bolt/bolt/statuses/99a06cdb99d827fc47d30229734c39ba20de11cc"}}}}
{"actor":{"display_login":"GawainLynch"}}