{"action":"created","comment":{"url":"https://api.github.com/repos/kube-node/nodeset/pulls/comments/116262683","pull_request_review_id":37875535,"id":116262683,"diff_hunk":"@@ -0,0 +1,172 @@\n+/*\n+Copyright 2017 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package v1alpha1\n+\n+import (\n+\tv1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+\ttypes \"k8s.io/apimachinery/pkg/types\"\n+\twatch \"k8s.io/apimachinery/pkg/watch\"\n+\trest \"k8s.io/client-go/rest\"\n+\tscheme \"kube-node/nodeset/pkg/client/clientset_v1alpha1/scheme\"\n+\tv1alpha1 \"kube-node/nodeset/pkg/nodeset/v1alpha1\"\n+)\n+\n+// NodeSetsGetter has a method to return a NodeSetInterface.\n+// A group's client should implement this interface.\n+type NodeSetsGetter interface {\n+\tNodeSets(namespace string) NodeSetInterface","path":"pkg/client/clientset_v1alpha1/typed/nodeset/v1alpha1/nodeset.go","position":31,"original_position":31,"commit_id":"2dbd1d7563e270b6af403164ff74e7a233e3645a","original_commit_id":"2dbd1d7563e270b6af403164ff74e7a233e3645a","user":{"login":"ledzep2","id":1814214,"avatar_url":"https://avatars1.githubusercontent.com/u/1814214?v=3","gravatar_id":"","url":"https://api.github.com/users/ledzep2","html_url":"https://github.com/ledzep2","followers_url":"https://api.github.com/users/ledzep2/followers","following_url":"https://api.github.com/users/ledzep2/following{/other_user}","gists_url":"https://api.github.com/users/ledzep2/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzep2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzep2/subscriptions","organizations_url":"https://api.github.com/users/ledzep2/orgs","repos_url":"https://api.github.com/users/ledzep2/repos","events_url":"https://api.github.com/users/ledzep2/events{/privacy}","received_events_url":"https://api.github.com/users/ledzep2/received_events","type":"User","site_admin":false},"body":"Agree as in another comment.","created_at":"2017-05-12T15:47:38Z","updated_at":"2017-05-12T15:47:38Z","html_url":"https://github.com/kube-node/nodeset/pull/2#discussion_r116262683","pull_request_url":"https://api.github.com/repos/kube-node/nodeset/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/kube-node/nodeset/pulls/comments/116262683"},"html":{"href":"https://github.com/kube-node/nodeset/pull/2#discussion_r116262683"},"pull_request":{"href":"https://api.github.com/repos/kube-node/nodeset/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/kube-node/nodeset/pulls/2","id":120342542,"html_url":"https://github.com/kube-node/nodeset/pull/2","diff_url":"https://github.com/kube-node/nodeset/pull/2.diff","patch_url":"https://github.com/kube-node/nodeset/pull/2.patch","issue_url":"https://api.github.com/repos/kube-node/nodeset/issues/2","number":2,"state":"open","locked":false,"title":"Added generated clientset and defaulters","user":{"login":"ledzep2","id":1814214,"avatar_url":"https://avatars1.githubusercontent.com/u/1814214?v=3","gravatar_id":"","url":"https://api.github.com/users/ledzep2","html_url":"https://github.com/ledzep2","followers_url":"https://api.github.com/users/ledzep2/followers","following_url":"https://api.github.com/users/ledzep2/following{/other_user}","gists_url":"https://api.github.com/users/ledzep2/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzep2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzep2/subscriptions","organizations_url":"https://api.github.com/users/ledzep2/orgs","repos_url":"https://api.github.com/users/ledzep2/repos","events_url":"https://api.github.com/users/ledzep2/events{/privacy}","received_events_url":"https://api.github.com/users/ledzep2/received_events","type":"User","site_admin":false},"body":"Clientset is generated with client-gen. Defaults are currently empty. But the scripts are there.\r\n\r\nLet me know if we need tests in this PR or later ones.","created_at":"2017-05-12T15:00:34Z","updated_at":"2017-05-12T15:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02ce58011565bab5853b543aebef84fef460cdbd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kube-node/nodeset/pulls/2/commits","review_comments_url":"https://api.github.com/repos/kube-node/nodeset/pulls/2/comments","review_comment_url":"https://api.github.com/repos/kube-node/nodeset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kube-node/nodeset/issues/2/comments","statuses_url":"https://api.github.com/repos/kube-node/nodeset/statuses/2dbd1d7563e270b6af403164ff74e7a233e3645a","head":{"label":"ledzep2:clientset","ref":"clientset","sha":"2dbd1d7563e270b6af403164ff74e7a233e3645a","user":{"login":"ledzep2","id":1814214,"avatar_url":"https://avatars1.githubusercontent.com/u/1814214?v=3","gravatar_id":"","url":"https://api.github.com/users/ledzep2","html_url":"https://github.com/ledzep2","followers_url":"https://api.github.com/users/ledzep2/followers","following_url":"https://api.github.com/users/ledzep2/following{/other_user}","gists_url":"https://api.github.com/users/ledzep2/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzep2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzep2/subscriptions","organizations_url":"https://api.github.com/users/ledzep2/orgs","repos_url":"https://api.github.com/users/ledzep2/repos","events_url":"https://api.github.com/users/ledzep2/events{/privacy}","received_events_url":"https://api.github.com/users/ledzep2/received_events","type":"User","site_admin":false},"repo":{"id":90575176,"name":"nodeset","full_name":"ledzep2/nodeset","owner":{"login":"ledzep2","id":1814214,"avatar_url":"https://avatars1.githubusercontent.com/u/1814214?v=3","gravatar_id":"","url":"https://api.github.com/users/ledzep2","html_url":"https://github.com/ledzep2","followers_url":"https://api.github.com/users/ledzep2/followers","following_url":"https://api.github.com/users/ledzep2/following{/other_user}","gists_url":"https://api.github.com/users/ledzep2/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzep2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzep2/subscriptions","organizations_url":"https://api.github.com/users/ledzep2/orgs","repos_url":"https://api.github.com/users/ledzep2/repos","events_url":"https://api.github.com/users/ledzep2/events{/privacy}","received_events_url":"https://api.github.com/users/ledzep2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ledzep2/nodeset","description":"Generic nodeset for kubernetes","fork":true,"url":"https://api.github.com/repos/ledzep2/nodeset","forks_url":"https://api.github.com/repos/ledzep2/nodeset/forks","keys_url":"https://api.github.com/repos/ledzep2/nodeset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ledzep2/nodeset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ledzep2/nodeset/teams","hooks_url":"https://api.github.com/repos/ledzep2/nodeset/hooks","issue_events_url":"https://api.github.com/repos/ledzep2/nodeset/issues/events{/number}","events_url":"https://api.github.com/repos/ledzep2/nodeset/events","assignees_url":"https://api.github.com/repos/ledzep2/nodeset/assignees{/user}","branches_url":"https://api.github.com/repos/ledzep2/nodeset/branches{/branch}","tags_url":"https://api.github.com/repos/ledzep2/nodeset/tags","blobs_url":"https://api.github.com/repos/ledzep2/nodeset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ledzep2/nodeset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ledzep2/nodeset/git/refs{/sha}","trees_url":"https://api.github.com/repos/ledzep2/nodeset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ledzep2/nodeset/statuses/{sha}","languages_url":"https://api.github.com/repos/ledzep2/nodeset/languages","stargazers_url":"https://api.github.com/repos/ledzep2/nodeset/stargazers","contributors_url":"https://api.github.com/repos/ledzep2/nodeset/contributors","subscribers_url":"https://api.github.com/repos/ledzep2/nodeset/subscribers","subscription_url":"https://api.github.com/repos/ledzep2/nodeset/subscription","commits_url":"https://api.github.com/repos/ledzep2/nodeset/commits{/sha}","git_commits_url":"https://api.github.com/repos/ledzep2/nodeset/git/commits{/sha}","comments_url":"https://api.github.com/repos/ledzep2/nodeset/comments{/number}","issue_comment_url":"https://api.github.com/repos/ledzep2/nodeset/issues/comments{/number}","contents_url":"https://api.github.com/repos/ledzep2/nodeset/contents/{+path}","compare_url":"https://api.github.com/repos/ledzep2/nodeset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ledzep2/nodeset/merges","archive_url":"https://api.github.com/repos/ledzep2/nodeset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ledzep2/nodeset/downloads","issues_url":"https://api.github.com/repos/ledzep2/nodeset/issues{/number}","pulls_url":"https://api.github.com/repos/ledzep2/nodeset/pulls{/number}","milestones_url":"https://api.github.com/repos/ledzep2/nodeset/milestones{/number}","notifications_url":"https://api.github.com/repos/ledzep2/nodeset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ledzep2/nodeset/labels{/name}","releases_url":"https://api.github.com/repos/ledzep2/nodeset/releases{/id}","deployments_url":"https://api.github.com/repos/ledzep2/nodeset/deployments","created_at":"2017-05-08T01:43:27Z","updated_at":"2017-05-08T07:48:24Z","pushed_at":"2017-05-12T14:56:08Z","git_url":"git://github.com/ledzep2/nodeset.git","ssh_url":"git@github.com:ledzep2/nodeset.git","clone_url":"https://github.com/ledzep2/nodeset.git","svn_url":"https://github.com/ledzep2/nodeset","homepage":"","size":16,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kube-node:master","ref":"master","sha":"47f7de7cc1ddb55e617f0f3874a605a31d663e99","user":{"login":"kube-node","id":28439526,"avatar_url":"https://avatars1.githubusercontent.com/u/28439526?v=3","gravatar_id":"","url":"https://api.github.com/users/kube-node","html_url":"https://github.com/kube-node","followers_url":"https://api.github.com/users/kube-node/followers","following_url":"https://api.github.com/users/kube-node/following{/other_user}","gists_url":"https://api.github.com/users/kube-node/gists{/gist_id}","starred_url":"https://api.github.com/users/kube-node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kube-node/subscriptions","organizations_url":"https://api.github.com/users/kube-node/orgs","repos_url":"https://api.github.com/users/kube-node/repos","events_url":"https://api.github.com/users/kube-node/events{/privacy}","received_events_url":"https://api.github.com/users/kube-node/received_events","type":"Organization","site_admin":false},"repo":{"id":90373693,"name":"nodeset","full_name":"kube-node/nodeset","owner":{"login":"kube-node","id":28439526,"avatar_url":"https://avatars1.githubusercontent.com/u/28439526?v=3","gravatar_id":"","url":"https://api.github.com/users/kube-node","html_url":"https://github.com/kube-node","followers_url":"https://api.github.com/users/kube-node/followers","following_url":"https://api.github.com/users/kube-node/following{/other_user}","gists_url":"https://api.github.com/users/kube-node/gists{/gist_id}","starred_url":"https://api.github.com/users/kube-node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kube-node/subscriptions","organizations_url":"https://api.github.com/users/kube-node/orgs","repos_url":"https://api.github.com/users/kube-node/repos","events_url":"https://api.github.com/users/kube-node/events{/privacy}","received_events_url":"https://api.github.com/users/kube-node/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kube-node/nodeset","description":"Generic nodeset for kubernetes","fork":false,"url":"https://api.github.com/repos/kube-node/nodeset","forks_url":"https://api.github.com/repos/kube-node/nodeset/forks","keys_url":"https://api.github.com/repos/kube-node/nodeset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kube-node/nodeset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kube-node/nodeset/teams","hooks_url":"https://api.github.com/repos/kube-node/nodeset/hooks","issue_events_url":"https://api.github.com/repos/kube-node/nodeset/issues/events{/number}","events_url":"https://api.github.com/repos/kube-node/nodeset/events","assignees_url":"https://api.github.com/repos/kube-node/nodeset/assignees{/user}","branches_url":"https://api.github.com/repos/kube-node/nodeset/branches{/branch}","tags_url":"https://api.github.com/repos/kube-node/nodeset/tags","blobs_url":"https://api.github.com/repos/kube-node/nodeset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kube-node/nodeset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kube-node/nodeset/git/refs{/sha}","trees_url":"https://api.github.com/repos/kube-node/nodeset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kube-node/nodeset/statuses/{sha}","languages_url":"https://api.github.com/repos/kube-node/nodeset/languages","stargazers_url":"https://api.github.com/repos/kube-node/nodeset/stargazers","contributors_url":"https://api.github.com/repos/kube-node/nodeset/contributors","subscribers_url":"https://api.github.com/repos/kube-node/nodeset/subscribers","subscription_url":"https://api.github.com/repos/kube-node/nodeset/subscription","commits_url":"https://api.github.com/repos/kube-node/nodeset/commits{/sha}","git_commits_url":"https://api.github.com/repos/kube-node/nodeset/git/commits{/sha}","comments_url":"https://api.github.com/repos/kube-node/nodeset/comments{/number}","issue_comment_url":"https://api.github.com/repos/kube-node/nodeset/issues/comments{/number}","contents_url":"https://api.github.com/repos/kube-node/nodeset/contents/{+path}","compare_url":"https://api.github.com/repos/kube-node/nodeset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kube-node/nodeset/merges","archive_url":"https://api.github.com/repos/kube-node/nodeset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kube-node/nodeset/downloads","issues_url":"https://api.github.com/repos/kube-node/nodeset/issues{/number}","pulls_url":"https://api.github.com/repos/kube-node/nodeset/pulls{/number}","milestones_url":"https://api.github.com/repos/kube-node/nodeset/milestones{/number}","notifications_url":"https://api.github.com/repos/kube-node/nodeset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kube-node/nodeset/labels{/name}","releases_url":"https://api.github.com/repos/kube-node/nodeset/releases{/id}","deployments_url":"https://api.github.com/repos/kube-node/nodeset/deployments","created_at":"2017-05-05T12:31:52Z","updated_at":"2017-05-11T12:41:17Z","pushed_at":"2017-05-12T15:00:35Z","git_url":"git://github.com/kube-node/nodeset.git","ssh_url":"git@github.com:kube-node/nodeset.git","clone_url":"https://github.com/kube-node/nodeset.git","svn_url":"https://github.com/kube-node/nodeset","homepage":"","size":16,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kube-node/nodeset/pulls/2"},"html":{"href":"https://github.com/kube-node/nodeset/pull/2"},"issue":{"href":"https://api.github.com/repos/kube-node/nodeset/issues/2"},"comments":{"href":"https://api.github.com/repos/kube-node/nodeset/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/kube-node/nodeset/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/kube-node/nodeset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kube-node/nodeset/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/kube-node/nodeset/statuses/2dbd1d7563e270b6af403164ff74e7a233e3645a"}}}}
{"actor":{"display_login":"ledzep2"}}