{"action":"created","comment":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/107816788","pull_request_review_id":28811716,"id":107816788,"diff_hunk":"@@ -118,6 +120,15 @@ def test_pep_0420_disabled_top_level_verify(make_app, apidoc):\n     print(app._status.getvalue())\n     print(app._warning.getvalue())\n \n+@pytest.mark.apidoc(coderoot=(rootdir / 'root' / 'trailing_underscore'))","path":"tests/test_apidoc.py","position":29,"original_position":29,"commit_id":"3e7bee583604e3422c05f807a69d0a73afedfa59","original_commit_id":"3e7bee583604e3422c05f807a69d0a73afedfa59","user":{"login":"tk0miya","id":748828,"avatar_url":"https://avatars1.githubusercontent.com/u/748828?v=3","gravatar_id":"","url":"https://api.github.com/users/tk0miya","html_url":"https://github.com/tk0miya","followers_url":"https://api.github.com/users/tk0miya/followers","following_url":"https://api.github.com/users/tk0miya/following{/other_user}","gists_url":"https://api.github.com/users/tk0miya/gists{/gist_id}","starred_url":"https://api.github.com/users/tk0miya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk0miya/subscriptions","organizations_url":"https://api.github.com/users/tk0miya/orgs","repos_url":"https://api.github.com/users/tk0miya/repos","events_url":"https://api.github.com/users/tk0miya/events{/privacy}","received_events_url":"https://api.github.com/users/tk0miya/received_events","type":"User","site_admin":false},"body":"Yes, test for `pep_0420` should be also separated.\r\nHistorically, we had added some mark-up examples to `tests/root`. As a result, testing time had became very slow. Because it was built as 20+ times in our testcase.\r\n\r\n>Also, isn't this a case that everything should be testing?\r\n\r\nShould we test this with all builders? Is this case needed to be built?\r\nSphinx has already many builders and extensions. so we need to add new testdata to `tests/root` carefully to prevent combination-explosion.","created_at":"2017-03-24T00:54:06Z","updated_at":"2017-03-24T00:54:06Z","html_url":"https://github.com/sphinx-doc/sphinx/pull/3581#discussion_r107816788","pull_request_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581","_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/107816788"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/3581#discussion_r107816788"},"pull_request":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581"}}},"pull_request":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581","id":112139176,"html_url":"https://github.com/sphinx-doc/sphinx/pull/3581","diff_url":"https://github.com/sphinx-doc/sphinx/pull/3581.diff","patch_url":"https://github.com/sphinx-doc/sphinx/pull/3581.patch","issue_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3581","number":3581,"state":"open","locked":false,"title":"Fix issues with trailing underscores in heading names","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars0.githubusercontent.com/u/425260?v=3","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"Fixes #1451, using the approach in #1462 of 8d96c90fc6ca7805ba7a8e8fd80cc74da7caf46c\r\n","created_at":"2017-03-23T00:22:37Z","updated_at":"2017-03-24T00:54:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"123b0181efa01eeefd91dadb0433c189281a0fd2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581/commits","review_comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581/comments","review_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3581/comments","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/3e7bee583604e3422c05f807a69d0a73afedfa59","head":{"label":"eric-wieser:patch-1","ref":"patch-1","sha":"3e7bee583604e3422c05f807a69d0a73afedfa59","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars0.githubusercontent.com/u/425260?v=3","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"repo":{"id":77734807,"name":"sphinx","full_name":"eric-wieser/sphinx","owner":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars0.githubusercontent.com/u/425260?v=3","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eric-wieser/sphinx","description":"Main repository for the Sphinx documentation builder","fork":true,"url":"https://api.github.com/repos/eric-wieser/sphinx","forks_url":"https://api.github.com/repos/eric-wieser/sphinx/forks","keys_url":"https://api.github.com/repos/eric-wieser/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eric-wieser/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eric-wieser/sphinx/teams","hooks_url":"https://api.github.com/repos/eric-wieser/sphinx/hooks","issue_events_url":"https://api.github.com/repos/eric-wieser/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/eric-wieser/sphinx/events","assignees_url":"https://api.github.com/repos/eric-wieser/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/eric-wieser/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/eric-wieser/sphinx/tags","blobs_url":"https://api.github.com/repos/eric-wieser/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eric-wieser/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eric-wieser/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/eric-wieser/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eric-wieser/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/eric-wieser/sphinx/languages","stargazers_url":"https://api.github.com/repos/eric-wieser/sphinx/stargazers","contributors_url":"https://api.github.com/repos/eric-wieser/sphinx/contributors","subscribers_url":"https://api.github.com/repos/eric-wieser/sphinx/subscribers","subscription_url":"https://api.github.com/repos/eric-wieser/sphinx/subscription","commits_url":"https://api.github.com/repos/eric-wieser/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/eric-wieser/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/eric-wieser/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/eric-wieser/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/eric-wieser/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/eric-wieser/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eric-wieser/sphinx/merges","archive_url":"https://api.github.com/repos/eric-wieser/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eric-wieser/sphinx/downloads","issues_url":"https://api.github.com/repos/eric-wieser/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/eric-wieser/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/eric-wieser/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/eric-wieser/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eric-wieser/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/eric-wieser/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/eric-wieser/sphinx/deployments","created_at":"2016-12-31T09:56:18Z","updated_at":"2016-12-31T09:56:23Z","pushed_at":"2017-03-23T12:40:38Z","git_url":"git://github.com/eric-wieser/sphinx.git","ssh_url":"git@github.com:eric-wieser/sphinx.git","clone_url":"https://github.com/eric-wieser/sphinx.git","svn_url":"https://github.com/eric-wieser/sphinx","homepage":"http://sphinx-doc.org","size":20200,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sphinx-doc:stable","ref":"stable","sha":"895014cd7168fdef9c3552c4a3bb818615a39fce","user":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars1.githubusercontent.com/u/9928167?v=3","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"repo":{"id":28710753,"name":"sphinx","full_name":"sphinx-doc/sphinx","owner":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars1.githubusercontent.com/u/9928167?v=3","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphinx-doc/sphinx","description":"Main repository for the Sphinx documentation builder","fork":false,"url":"https://api.github.com/repos/sphinx-doc/sphinx","forks_url":"https://api.github.com/repos/sphinx-doc/sphinx/forks","keys_url":"https://api.github.com/repos/sphinx-doc/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphinx-doc/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphinx-doc/sphinx/teams","hooks_url":"https://api.github.com/repos/sphinx-doc/sphinx/hooks","issue_events_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/sphinx-doc/sphinx/events","assignees_url":"https://api.github.com/repos/sphinx-doc/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/sphinx-doc/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/tags","blobs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/sphinx-doc/sphinx/languages","stargazers_url":"https://api.github.com/repos/sphinx-doc/sphinx/stargazers","contributors_url":"https://api.github.com/repos/sphinx-doc/sphinx/contributors","subscribers_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscribers","subscription_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscription","commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphinx-doc/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/sphinx-doc/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphinx-doc/sphinx/merges","archive_url":"https://api.github.com/repos/sphinx-doc/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphinx-doc/sphinx/downloads","issues_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/sphinx-doc/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/sphinx-doc/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphinx-doc/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/sphinx-doc/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/sphinx-doc/sphinx/deployments","created_at":"2015-01-02T10:53:28Z","updated_at":"2017-03-23T18:53:11Z","pushed_at":"2017-03-23T13:50:29Z","git_url":"git://github.com/sphinx-doc/sphinx.git","ssh_url":"git@github.com:sphinx-doc/sphinx.git","clone_url":"https://github.com/sphinx-doc/sphinx.git","svn_url":"https://github.com/sphinx-doc/sphinx","homepage":"http://sphinx-doc.org","size":23586,"stargazers_count":1060,"watchers_count":1060,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":487,"mirror_url":null,"open_issues_count":591,"forks":487,"open_issues":591,"watchers":1060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/3581"},"issue":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3581"},"comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/3581/comments"},"review_comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581/comments"},"review_comment":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/3581/commits"},"statuses":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/3e7bee583604e3422c05f807a69d0a73afedfa59"}}}}
{"actor":{"display_login":"tk0miya"}}