{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/108061909","pull_request_review_id":29071064,"id":108061909,"diff_hunk":"@@ -19,8 +19,8 @@ MAC       := \"Darwin\"\n PACKAGES  := $$(go list ./...| grep -vE 'vendor')\n FILES     := $$(find . -name '*.go' | grep -vE 'vendor')\n \n-LDFLAGS += -X \"github.com/pingcap/tidb/util/printer.TiDBBuildTS=$(shell date -u '+%Y-%m-%d %I:%M:%S')\"\n-LDFLAGS += -X \"github.com/pingcap/tidb/util/printer.TiDBGitHash=$(shell git rev-parse HEAD)\"\n+LDFLAGS += -X \"github.com/alston111111/tidb/util/printer.TiDBBuildTS=$(shell date -u '+%Y-%m-%d %I:%M:%S')\"","path":"Makefile","position":null,"original_position":6,"commit_id":"000d59c03e3996a5c1488c0a9abc673b519e0890","original_commit_id":"861fbdc50548d53cb056dfba67eb26f323e14f84","user":{"login":"alston111111","id":7358378,"avatar_url":"https://avatars2.githubusercontent.com/u/7358378?v=3","gravatar_id":"","url":"https://api.github.com/users/alston111111","html_url":"https://github.com/alston111111","followers_url":"https://api.github.com/users/alston111111/followers","following_url":"https://api.github.com/users/alston111111/following{/other_user}","gists_url":"https://api.github.com/users/alston111111/gists{/gist_id}","starred_url":"https://api.github.com/users/alston111111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alston111111/subscriptions","organizations_url":"https://api.github.com/users/alston111111/orgs","repos_url":"https://api.github.com/users/alston111111/repos","events_url":"https://api.github.com/users/alston111111/events{/privacy}","received_events_url":"https://api.github.com/users/alston111111/received_events","type":"User","site_admin":false},"body":"Oh. Sorry about that.  Makefile has been changed back.\r\n\r\nI was supposed to change it back before the push, but I forgot to.\r\nI had already put my work in ${some_path}/github.com/pingcap.\r\nAnd I will not do this again and I will pay attention to it.\r\n\r\nThank you.","created_at":"2017-03-26T14:26:30Z","updated_at":"2017-03-26T14:26:30Z","html_url":"https://github.com/pingcap/tidb/pull/2885#discussion_r108061909","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/2885","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/108061909"},"html":{"href":"https://github.com/pingcap/tidb/pull/2885#discussion_r108061909"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2885"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/2885","id":111437493,"html_url":"https://github.com/pingcap/tidb/pull/2885","diff_url":"https://github.com/pingcap/tidb/pull/2885.diff","patch_url":"https://github.com/pingcap/tidb/pull/2885.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/2885","number":2885,"state":"open","locked":false,"title":"* built-in: add \"Sin(x)\" function","user":{"login":"alston111111","id":7358378,"avatar_url":"https://avatars2.githubusercontent.com/u/7358378?v=3","gravatar_id":"","url":"https://api.github.com/users/alston111111","html_url":"https://github.com/alston111111","followers_url":"https://api.github.com/users/alston111111/followers","following_url":"https://api.github.com/users/alston111111/following{/other_user}","gists_url":"https://api.github.com/users/alston111111/gists{/gist_id}","starred_url":"https://api.github.com/users/alston111111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alston111111/subscriptions","organizations_url":"https://api.github.com/users/alston111111/orgs","repos_url":"https://api.github.com/users/alston111111/repos","events_url":"https://api.github.com/users/alston111111/events{/privacy}","received_events_url":"https://api.github.com/users/alston111111/received_events","type":"User","site_admin":false},"body":"* built-in: add \"Sin(x)\" function\r\nTake a first try...","created_at":"2017-03-19T05:07:54Z","updated_at":"2017-03-26T14:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cd2d367348fe60a480158fbf0a156bb871a61f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/2885/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/2885/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/2885/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/000d59c03e3996a5c1488c0a9abc673b519e0890","head":{"label":"alston111111:master","ref":"master","sha":"000d59c03e3996a5c1488c0a9abc673b519e0890","user":{"login":"alston111111","id":7358378,"avatar_url":"https://avatars2.githubusercontent.com/u/7358378?v=3","gravatar_id":"","url":"https://api.github.com/users/alston111111","html_url":"https://github.com/alston111111","followers_url":"https://api.github.com/users/alston111111/followers","following_url":"https://api.github.com/users/alston111111/following{/other_user}","gists_url":"https://api.github.com/users/alston111111/gists{/gist_id}","starred_url":"https://api.github.com/users/alston111111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alston111111/subscriptions","organizations_url":"https://api.github.com/users/alston111111/orgs","repos_url":"https://api.github.com/users/alston111111/repos","events_url":"https://api.github.com/users/alston111111/events{/privacy}","received_events_url":"https://api.github.com/users/alston111111/received_events","type":"User","site_admin":false},"repo":{"id":85042078,"name":"tidb","full_name":"alston111111/tidb","owner":{"login":"alston111111","id":7358378,"avatar_url":"https://avatars2.githubusercontent.com/u/7358378?v=3","gravatar_id":"","url":"https://api.github.com/users/alston111111","html_url":"https://github.com/alston111111","followers_url":"https://api.github.com/users/alston111111/followers","following_url":"https://api.github.com/users/alston111111/following{/other_user}","gists_url":"https://api.github.com/users/alston111111/gists{/gist_id}","starred_url":"https://api.github.com/users/alston111111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alston111111/subscriptions","organizations_url":"https://api.github.com/users/alston111111/orgs","repos_url":"https://api.github.com/users/alston111111/repos","events_url":"https://api.github.com/users/alston111111/events{/privacy}","received_events_url":"https://api.github.com/users/alston111111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alston111111/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/alston111111/tidb","forks_url":"https://api.github.com/repos/alston111111/tidb/forks","keys_url":"https://api.github.com/repos/alston111111/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alston111111/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alston111111/tidb/teams","hooks_url":"https://api.github.com/repos/alston111111/tidb/hooks","issue_events_url":"https://api.github.com/repos/alston111111/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/alston111111/tidb/events","assignees_url":"https://api.github.com/repos/alston111111/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/alston111111/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/alston111111/tidb/tags","blobs_url":"https://api.github.com/repos/alston111111/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alston111111/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alston111111/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/alston111111/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alston111111/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/alston111111/tidb/languages","stargazers_url":"https://api.github.com/repos/alston111111/tidb/stargazers","contributors_url":"https://api.github.com/repos/alston111111/tidb/contributors","subscribers_url":"https://api.github.com/repos/alston111111/tidb/subscribers","subscription_url":"https://api.github.com/repos/alston111111/tidb/subscription","commits_url":"https://api.github.com/repos/alston111111/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/alston111111/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/alston111111/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/alston111111/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/alston111111/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/alston111111/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alston111111/tidb/merges","archive_url":"https://api.github.com/repos/alston111111/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alston111111/tidb/downloads","issues_url":"https://api.github.com/repos/alston111111/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/alston111111/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/alston111111/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/alston111111/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alston111111/tidb/labels{/name}","releases_url":"https://api.github.com/repos/alston111111/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/alston111111/tidb/deployments","created_at":"2017-03-15T07:27:23Z","updated_at":"2017-03-15T07:27:27Z","pushed_at":"2017-03-26T14:20:18Z","git_url":"git://github.com/alston111111/tidb.git","ssh_url":"git@github.com:alston111111/tidb.git","clone_url":"https://github.com/alston111111/tidb.git","svn_url":"https://github.com/alston111111/tidb","homepage":"","size":22650,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"e95ff609b7d91593657eff200c9a1bf53ca897da","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-03-26T14:11:29Z","pushed_at":"2017-03-26T14:20:19Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":22702,"stargazers_count":7424,"watchers_count":7424,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":968,"mirror_url":null,"open_issues_count":191,"forks":968,"open_issues":191,"watchers":7424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2885"},"html":{"href":"https://github.com/pingcap/tidb/pull/2885"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/2885"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/2885/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2885/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2885/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/000d59c03e3996a5c1488c0a9abc673b519e0890"}}}}
{"actor":{"display_login":"alston111111"}}