{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/8283","repository_url":"https://api.github.com/repos/Yoast/wordpress-seo","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/8283/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/8283/comments","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/8283/events","html_url":"https://github.com/Yoast/wordpress-seo/pull/8283","id":274742024,"number":8283,"title":"CS/QA: improve validation of `$_SERVER['HTTPS']`","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars1.githubusercontent.com/u/663378?v=4","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"labels":[{"id":200344831,"url":"https://api.github.com/repos/Yoast/wordpress-seo/labels/code-review","name":"code-review","color":"78BDF2","default":false}],"state":"open","locked":false,"assignee":{"login":"andizer","id":325040,"avatar_url":"https://avatars0.githubusercontent.com/u/325040?v=4","gravatar_id":"","url":"https://api.github.com/users/andizer","html_url":"https://github.com/andizer","followers_url":"https://api.github.com/users/andizer/followers","following_url":"https://api.github.com/users/andizer/following{/other_user}","gists_url":"https://api.github.com/users/andizer/gists{/gist_id}","starred_url":"https://api.github.com/users/andizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andizer/subscriptions","organizations_url":"https://api.github.com/users/andizer/orgs","repos_url":"https://api.github.com/users/andizer/repos","events_url":"https://api.github.com/users/andizer/events{/privacy}","received_events_url":"https://api.github.com/users/andizer/received_events","type":"User","site_admin":false},"assignees":[{"login":"andizer","id":325040,"avatar_url":"https://avatars0.githubusercontent.com/u/325040?v=4","gravatar_id":"","url":"https://api.github.com/users/andizer","html_url":"https://github.com/andizer","followers_url":"https://api.github.com/users/andizer/followers","following_url":"https://api.github.com/users/andizer/following{/other_user}","gists_url":"https://api.github.com/users/andizer/gists{/gist_id}","starred_url":"https://api.github.com/users/andizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andizer/subscriptions","organizations_url":"https://api.github.com/users/andizer/orgs","repos_url":"https://api.github.com/users/andizer/repos","events_url":"https://api.github.com/users/andizer/events{/privacy}","received_events_url":"https://api.github.com/users/andizer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-11-17T03:37:56Z","updated_at":"2017-11-17T09:15:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/8283","html_url":"https://github.com/Yoast/wordpress-seo/pull/8283","diff_url":"https://github.com/Yoast/wordpress-seo/pull/8283.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/8283.patch"},"body":"## Summary\r\nThis PR can be summarized in the following changelog entry:\r\n_N/A_\r\n\r\n## Relevant technical choices:\r\n* No functional changes.\r\n\r\nAccording to the documentation, the value will be _non-empty_ when queried through the HTTPS protocol, not necessarily the string `on`.\r\nHowever, when used with IIS, an `off` value can be encountered.\r\n\r\nThe change made here should deal with this properly.\r\n\r\nAll the same, I wonder if it may be more appropriate to change over to using the WP native `is_ssl()` function.\r\n\r\nRefs:\r\n* http://php.net/manual/en/reserved.variables.server.php\r\n* https://developer.wordpress.org/reference/functions/is_ssl/\r\n\r\n## Test instructions\r\n_N/A_"},"comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments/345187812","html_url":"https://github.com/Yoast/wordpress-seo/pull/8283#issuecomment-345187812","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/8283","id":345187812,"user":{"login":"andizer","id":325040,"avatar_url":"https://avatars0.githubusercontent.com/u/325040?v=4","gravatar_id":"","url":"https://api.github.com/users/andizer","html_url":"https://github.com/andizer","followers_url":"https://api.github.com/users/andizer/followers","following_url":"https://api.github.com/users/andizer/following{/other_user}","gists_url":"https://api.github.com/users/andizer/gists{/gist_id}","starred_url":"https://api.github.com/users/andizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andizer/subscriptions","organizations_url":"https://api.github.com/users/andizer/orgs","repos_url":"https://api.github.com/users/andizer/repos","events_url":"https://api.github.com/users/andizer/events{/privacy}","received_events_url":"https://api.github.com/users/andizer/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T09:15:35Z","updated_at":"2017-11-17T09:15:35Z","author_association":"CONTRIBUTOR","body":"CR done"}}
{"actor":{"display_login":"andizer"}}