{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio.github.io/pulls/comments/116892533","pull_request_review_id":38550965,"id":116892533,"diff_hunk":"@@ -20,7 +20,45 @@ Make sure you are not introducing html errors or bad links:\n ```bash\n docker run --rm --label=jekyll --volume=$(pwd):/srv/jekyll  -it  jekyll/jekyll sh -c \"bundle install && rake test\"\n ```\n+Should output:\n ```\n HTML-Proofer finished successfully.\n ```\n+#### Side note for those on non-linux machines\n+ \n+If you're developing locally but not on a Linux machine, you have a couple options. \n+You can opt to use [Docker for Mac](https://docs.docker.com/docker-for-mac/) / [Docker for Windows](https://docs.docker.com/docker-for-windows/). This will give you a docker environment from which to run the above docker container (which has all the of the correct Jekyll dependencies and Ruby versions installed). \n \n+\n+If doing Istio development on Kubernetes and doing so locally with  [minikube](https://kubernetes.io/docs/getting-started-guides/minikube/)we highly recommend you use your OS's native virtualization. For example, to start minikube with native virtualization for Mac OSX try:\n+\n+```bash\n+minikube start --vm-driver=xhyve\n+```\n+\n+You can see more about this command and how to install the [xhyve](https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#xhyve-driver) drivers by [taking a look at the xhyve driver documentation](https://github.com/zchee/docker-machine-driver-xhyve#install)\n+\n+We've had some difficulties getting virtualbox to configure shared folder permissions correctly when using minikube+virtualbox. \n+\n+To build and run the website with minikube, bind to your `minikube ip` like this:\n+\n+```bash\n+docker run --rm --label=jekyll  --volume=$(pwd):/srv/jekyll  -it -p $(minikube ip):4000:4000 jekyll/jekyll jekyll serve ","path":"README.md","position":27,"original_position":27,"commit_id":"16c7b43cb6e08d6c9aacdb2dabe5ce418146f275","original_commit_id":"16c7b43cb6e08d6c9aacdb2dabe5ce418146f275","user":{"login":"ldemailly","id":3664595,"avatar_url":"https://avatars1.githubusercontent.com/u/3664595?v=3","gravatar_id":"","url":"https://api.github.com/users/ldemailly","html_url":"https://github.com/ldemailly","followers_url":"https://api.github.com/users/ldemailly/followers","following_url":"https://api.github.com/users/ldemailly/following{/other_user}","gists_url":"https://api.github.com/users/ldemailly/gists{/gist_id}","starred_url":"https://api.github.com/users/ldemailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldemailly/subscriptions","organizations_url":"https://api.github.com/users/ldemailly/orgs","repos_url":"https://api.github.com/users/ldemailly/repos","events_url":"https://api.github.com/users/ldemailly/events{/privacy}","received_events_url":"https://api.github.com/users/ldemailly/received_events","type":"User","site_admin":false},"body":"this is very similar to the above (with $(minikube ip) replacing localhost)","created_at":"2017-05-17T01:19:58Z","updated_at":"2017-05-17T01:19:58Z","html_url":"https://github.com/istio/istio.github.io/pull/206#discussion_r116892533","pull_request_url":"https://api.github.com/repos/istio/istio.github.io/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/comments/116892533"},"html":{"href":"https://github.com/istio/istio.github.io/pull/206#discussion_r116892533"},"pull_request":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio.github.io/pulls/206","id":120362701,"html_url":"https://github.com/istio/istio.github.io/pull/206","diff_url":"https://github.com/istio/istio.github.io/pull/206.diff","patch_url":"https://github.com/istio/istio.github.io/pull/206.patch","issue_url":"https://api.github.com/repos/istio/istio.github.io/issues/206","number":206,"state":"open","locked":false,"title":"added guidance for non-linux users using minikube","user":{"login":"christian-posta","id":53201,"avatar_url":"https://avatars0.githubusercontent.com/u/53201?v=3","gravatar_id":"","url":"https://api.github.com/users/christian-posta","html_url":"https://github.com/christian-posta","followers_url":"https://api.github.com/users/christian-posta/followers","following_url":"https://api.github.com/users/christian-posta/following{/other_user}","gists_url":"https://api.github.com/users/christian-posta/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-posta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-posta/subscriptions","organizations_url":"https://api.github.com/users/christian-posta/orgs","repos_url":"https://api.github.com/users/christian-posta/repos","events_url":"https://api.github.com/users/christian-posta/events{/privacy}","received_events_url":"https://api.github.com/users/christian-posta/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-12T16:45:13Z","updated_at":"2017-05-17T01:19:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c59ebfdbd6793bb2b08457d813e7b9602afee62","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio.github.io/pulls/206/commits","review_comments_url":"https://api.github.com/repos/istio/istio.github.io/pulls/206/comments","review_comment_url":"https://api.github.com/repos/istio/istio.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio.github.io/issues/206/comments","statuses_url":"https://api.github.com/repos/istio/istio.github.io/statuses/16c7b43cb6e08d6c9aacdb2dabe5ce418146f275","head":{"label":"christian-posta:ceposta-doco","ref":"ceposta-doco","sha":"16c7b43cb6e08d6c9aacdb2dabe5ce418146f275","user":{"login":"christian-posta","id":53201,"avatar_url":"https://avatars0.githubusercontent.com/u/53201?v=3","gravatar_id":"","url":"https://api.github.com/users/christian-posta","html_url":"https://github.com/christian-posta","followers_url":"https://api.github.com/users/christian-posta/followers","following_url":"https://api.github.com/users/christian-posta/following{/other_user}","gists_url":"https://api.github.com/users/christian-posta/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-posta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-posta/subscriptions","organizations_url":"https://api.github.com/users/christian-posta/orgs","repos_url":"https://api.github.com/users/christian-posta/repos","events_url":"https://api.github.com/users/christian-posta/events{/privacy}","received_events_url":"https://api.github.com/users/christian-posta/received_events","type":"User","site_admin":false},"repo":{"id":91023539,"name":"istio.github.io","full_name":"christian-posta/istio.github.io","owner":{"login":"christian-posta","id":53201,"avatar_url":"https://avatars0.githubusercontent.com/u/53201?v=3","gravatar_id":"","url":"https://api.github.com/users/christian-posta","html_url":"https://github.com/christian-posta","followers_url":"https://api.github.com/users/christian-posta/followers","following_url":"https://api.github.com/users/christian-posta/following{/other_user}","gists_url":"https://api.github.com/users/christian-posta/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-posta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-posta/subscriptions","organizations_url":"https://api.github.com/users/christian-posta/orgs","repos_url":"https://api.github.com/users/christian-posta/repos","events_url":"https://api.github.com/users/christian-posta/events{/privacy}","received_events_url":"https://api.github.com/users/christian-posta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christian-posta/istio.github.io","description":"Source for the istio.io site","fork":true,"url":"https://api.github.com/repos/christian-posta/istio.github.io","forks_url":"https://api.github.com/repos/christian-posta/istio.github.io/forks","keys_url":"https://api.github.com/repos/christian-posta/istio.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christian-posta/istio.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christian-posta/istio.github.io/teams","hooks_url":"https://api.github.com/repos/christian-posta/istio.github.io/hooks","issue_events_url":"https://api.github.com/repos/christian-posta/istio.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/christian-posta/istio.github.io/events","assignees_url":"https://api.github.com/repos/christian-posta/istio.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/christian-posta/istio.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/christian-posta/istio.github.io/tags","blobs_url":"https://api.github.com/repos/christian-posta/istio.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christian-posta/istio.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christian-posta/istio.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/christian-posta/istio.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christian-posta/istio.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/christian-posta/istio.github.io/languages","stargazers_url":"https://api.github.com/repos/christian-posta/istio.github.io/stargazers","contributors_url":"https://api.github.com/repos/christian-posta/istio.github.io/contributors","subscribers_url":"https://api.github.com/repos/christian-posta/istio.github.io/subscribers","subscription_url":"https://api.github.com/repos/christian-posta/istio.github.io/subscription","commits_url":"https://api.github.com/repos/christian-posta/istio.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/christian-posta/istio.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/christian-posta/istio.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/christian-posta/istio.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/christian-posta/istio.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/christian-posta/istio.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christian-posta/istio.github.io/merges","archive_url":"https://api.github.com/repos/christian-posta/istio.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christian-posta/istio.github.io/downloads","issues_url":"https://api.github.com/repos/christian-posta/istio.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/christian-posta/istio.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/christian-posta/istio.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/christian-posta/istio.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christian-posta/istio.github.io/labels{/name}","releases_url":"https://api.github.com/repos/christian-posta/istio.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/christian-posta/istio.github.io/deployments","created_at":"2017-05-11T21:06:25Z","updated_at":"2017-05-11T21:06:27Z","pushed_at":"2017-05-16T23:36:03Z","git_url":"git://github.com/christian-posta/istio.github.io.git","ssh_url":"git@github.com:christian-posta/istio.github.io.git","clone_url":"https://github.com/christian-posta/istio.github.io.git","svn_url":"https://github.com/christian-posta/istio.github.io","homepage":"http://istio.io","size":4795,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"182554aac3921cc6a156638910b6cd523af5dd8b","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"name":"istio.github.io","full_name":"istio/istio.github.io","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio.github.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.github.io","forks_url":"https://api.github.com/repos/istio/istio.github.io/forks","keys_url":"https://api.github.com/repos/istio/istio.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.github.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.github.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.github.io/events","assignees_url":"https://api.github.com/repos/istio/istio.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.github.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.github.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.github.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.github.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.github.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.github.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.github.io/merges","archive_url":"https://api.github.com/repos/istio/istio.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.github.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.github.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.github.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2017-05-16T20:20:35Z","pushed_at":"2017-05-16T23:42:18Z","git_url":"git://github.com/istio/istio.github.io.git","ssh_url":"git@github.com:istio/istio.github.io.git","clone_url":"https://github.com/istio/istio.github.io.git","svn_url":"https://github.com/istio/istio.github.io","homepage":"http://istio.io","size":4762,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":35,"forks":31,"open_issues":35,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/206"},"html":{"href":"https://github.com/istio/istio.github.io/pull/206"},"issue":{"href":"https://api.github.com/repos/istio/istio.github.io/issues/206"},"comments":{"href":"https://api.github.com/repos/istio/istio.github.io/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio.github.io/statuses/16c7b43cb6e08d6c9aacdb2dabe5ce418146f275"}}}}
{"actor":{"display_login":"ldemailly"}}