{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1544","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1544/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1544/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1544/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1544","id":236019209,"number":1544,"title":"[WIP] Convert Tenant Controller to Component","user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars0.githubusercontent.com/u/1538216?v=3","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"labels":[{"id":535030500,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/angular%20dialogs","name":"angular dialogs","color":"d4c5f9","default":false},{"id":571047353,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/fine/no","name":"fine/no","color":"000000","default":false},{"id":512311643,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/refactoring","name":"refactoring","color":"fbca04","default":false},{"id":505531653,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":{"login":"himdel","id":289743,"avatar_url":"https://avatars2.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"assignees":[{"login":"himdel","id":289743,"avatar_url":"https://avatars2.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-06-14T21:47:11Z","updated_at":"2017-06-29T00:26:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1544","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1544","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1544.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1544.patch"},"body":"Keeping Angular 2 (or 4) in mind, the PR attempts to re-architect the angular form in order to move to a component based architecture.\r\n\r\n- Converts Tenant Controller to Component\r\n(Note that it even removes `controllerAs` and makes it 100% component-based)\r\n\r\n- Generic buttons Save/Reset/Cancel are now part of a component\r\nThe idea here is to address `Similar code found in 'n' other locations` CodeClimate error that we usually see when we repeat code for `Save`, `Reset` and `Cancel` in every controller.\r\n(In the long run, this change may get our CodeClimate GPA up)\r\n\r\n\r\n@himdel Before I proceed further on the PR, would like to know what you think of getting rid of `controllerAs` altogether.\r\nAlso note that, the `form-changed` directive might need to be reworked to support this design.\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/311828284","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1544#issuecomment-311828284","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1544","id":311828284,"user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars0.githubusercontent.com/u/1538216?v=3","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"created_at":"2017-06-29T00:26:12Z","updated_at":"2017-06-29T00:26:12Z","body":"> `manageiq-ui-classic/app/assets/javascripts/angular_modules/module_helpers.js`\r\n\r\nA Module helper or a helper service like `miqService`.\r\nLooks like we are leaning towards `miqService`"}}
{"actor":{"display_login":"AparnaKarve"}}