{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/147470769","pull_request_review_id":72576403,"id":147470769,"diff_hunk":"@@ -242,16 +242,16 @@ public int compareTo(final byte[] that) {\n \n   @Override\n   public boolean equals(Object right_obj) {\n-    // compare with byte[] for backwards compatibility, but this is generally a pretty bad practice\n-    if (right_obj instanceof byte[]) {\n-      return compareTo((byte[]) right_obj) == 0;","path":"core/src/main/java/org/apache/accumulo/core/data/Value.java","position":6,"original_position":6,"commit_id":"a618fda9e94fc49732662675a1049c05f62d99b7","original_commit_id":"a618fda9e94fc49732662675a1049c05f62d99b7","user":{"login":"keith-turner","id":1268739,"avatar_url":"https://avatars0.githubusercontent.com/u/1268739?v=4","gravatar_id":"","url":"https://api.github.com/users/keith-turner","html_url":"https://github.com/keith-turner","followers_url":"https://api.github.com/users/keith-turner/followers","following_url":"https://api.github.com/users/keith-turner/following{/other_user}","gists_url":"https://api.github.com/users/keith-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/keith-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith-turner/subscriptions","organizations_url":"https://api.github.com/users/keith-turner/orgs","repos_url":"https://api.github.com/users/keith-turner/repos","events_url":"https://api.github.com/users/keith-turner/events{/privacy}","received_events_url":"https://api.github.com/users/keith-turner/received_events","type":"User","site_admin":false},"body":"Also since this class lacks javadoc, the current impl violates the javadoc from the parent class.","created_at":"2017-10-27T17:32:09Z","updated_at":"2017-10-27T17:32:09Z","html_url":"https://github.com/apache/accumulo/pull/313#discussion_r147470769","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/313","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/147470769"},"html":{"href":"https://github.com/apache/accumulo/pull/313#discussion_r147470769"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/313"}},"in_reply_to_id":145848739},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/313","id":147679972,"html_url":"https://github.com/apache/accumulo/pull/313","diff_url":"https://github.com/apache/accumulo/pull/313.diff","patch_url":"https://github.com/apache/accumulo/pull/313.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/313","number":313,"state":"open","locked":false,"title":"ACCUMULO-4726 Add Value.contentEquals(byte[]) method","user":{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false},"body":"(Note: This PR builds on #312; diffs of NullTServer may show up here, but are part of that PR, not this one.)\r\n\r\nAdd a method to compare Value objects with byte arrays, and stop\r\nsupporting the ability to compare Value objects with byte arrays using\r\nthe existing equals(Object) method, which is unsafe and should only be\r\nused to compare with other Value instances.\r\n","created_at":"2017-10-19T22:22:26Z","updated_at":"2017-10-27T17:32:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d77e7fc624ed2fb0a9f60ba6a901e847dfb0d74","assignee":{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false},"assignees":[{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/313/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/313/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/313/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/a618fda9e94fc49732662675a1049c05f62d99b7","head":{"label":"ctubbsii:no-value-equals-bytes","ref":"no-value-equals-bytes","sha":"a618fda9e94fc49732662675a1049c05f62d99b7","user":{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false},"repo":{"id":9703694,"name":"accumulo","full_name":"ctubbsii/accumulo","owner":{"login":"ctubbsii","id":1280725,"avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctubbsii/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/ctubbsii/accumulo","forks_url":"https://api.github.com/repos/ctubbsii/accumulo/forks","keys_url":"https://api.github.com/repos/ctubbsii/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctubbsii/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctubbsii/accumulo/teams","hooks_url":"https://api.github.com/repos/ctubbsii/accumulo/hooks","issue_events_url":"https://api.github.com/repos/ctubbsii/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/ctubbsii/accumulo/events","assignees_url":"https://api.github.com/repos/ctubbsii/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/ctubbsii/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/ctubbsii/accumulo/tags","blobs_url":"https://api.github.com/repos/ctubbsii/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctubbsii/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctubbsii/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctubbsii/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctubbsii/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/ctubbsii/accumulo/languages","stargazers_url":"https://api.github.com/repos/ctubbsii/accumulo/stargazers","contributors_url":"https://api.github.com/repos/ctubbsii/accumulo/contributors","subscribers_url":"https://api.github.com/repos/ctubbsii/accumulo/subscribers","subscription_url":"https://api.github.com/repos/ctubbsii/accumulo/subscription","commits_url":"https://api.github.com/repos/ctubbsii/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctubbsii/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctubbsii/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctubbsii/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctubbsii/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/ctubbsii/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctubbsii/accumulo/merges","archive_url":"https://api.github.com/repos/ctubbsii/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctubbsii/accumulo/downloads","issues_url":"https://api.github.com/repos/ctubbsii/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/ctubbsii/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/ctubbsii/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/ctubbsii/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctubbsii/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/ctubbsii/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/ctubbsii/accumulo/deployments","created_at":"2013-04-26T20:31:50Z","updated_at":"2017-07-11T19:04:13Z","pushed_at":"2017-10-23T22:23:32Z","git_url":"git://github.com/ctubbsii/accumulo.git","ssh_url":"git@github.com:ctubbsii/accumulo.git","clone_url":"https://github.com/ctubbsii/accumulo.git","svn_url":"https://github.com/ctubbsii/accumulo","homepage":"https://accumulo.apache.org","size":54347,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"98bc31819e6c654a63540709bd83d3b887fb2a3f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"name":"accumulo","full_name":"apache/accumulo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/accumulo","description":"Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2017-10-27T03:43:29Z","pushed_at":"2017-10-27T15:06:34Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"https://accumulo.apache.org","size":57130,"stargazers_count":328,"watchers_count":328,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":"git://git.apache.org/accumulo.git","archived":false,"open_issues_count":12,"forks":185,"open_issues":12,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/313"},"html":{"href":"https://github.com/apache/accumulo/pull/313"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/313"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/a618fda9e94fc49732662675a1049c05f62d99b7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"keith-turner"}}