{"action":"created","comment":{"url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments/118930285","pull_request_review_id":40767101,"id":118930285,"diff_hunk":"@@ -0,0 +1,79 @@\n+package com.nervousfish.nervousfish.service_locator;\n+\n+import android.app.Application;\n+import android.content.ComponentName;\n+import android.content.Context;\n+import android.content.Intent;\n+import android.content.ServiceConnection;\n+import android.os.IBinder;\n+\n+import com.nervousfish.nervousfish.modules.pairing.AndroidBluetoothService;\n+import com.nervousfish.nervousfish.modules.pairing.PairingWrapper;\n+\n+/**\n+ * The controller of the NervousFish application\n+ */\n+public final class NervousFish extends Application implements INervousFish {","path":"app/src/main/java/com/nervousfish/nervousfish/service_locator/NervousFish.java","position":16,"original_position":16,"commit_id":"08e253d03a81a279ca8121989313e0deba095211","original_commit_id":"08e253d03a81a279ca8121989313e0deba095211","user":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"body":"In what ways does this differ from the `EntryActivity`/Why can't this be done by the `EntryActivity`?","created_at":"2017-05-29T12:52:31Z","updated_at":"2017-05-29T12:56:57Z","html_url":"https://github.com/ericcornelissen/NervousFish/pull/170#discussion_r118930285","pull_request_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments/118930285"},"html":{"href":"https://github.com/ericcornelissen/NervousFish/pull/170#discussion_r118930285"},"pull_request":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170","id":122764828,"html_url":"https://github.com/ericcornelissen/NervousFish/pull/170","diff_url":"https://github.com/ericcornelissen/NervousFish/pull/170.diff","patch_url":"https://github.com/ericcornelissen/NervousFish/pull/170.patch","issue_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/170","number":170,"state":"open","locked":false,"title":"Refractor Bluetooth","user":{"login":"jverbraeken","id":15014738,"avatar_url":"https://avatars2.githubusercontent.com/u/15014738?v=3","gravatar_id":"","url":"https://api.github.com/users/jverbraeken","html_url":"https://github.com/jverbraeken","followers_url":"https://api.github.com/users/jverbraeken/followers","following_url":"https://api.github.com/users/jverbraeken/following{/other_user}","gists_url":"https://api.github.com/users/jverbraeken/gists{/gist_id}","starred_url":"https://api.github.com/users/jverbraeken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverbraeken/subscriptions","organizations_url":"https://api.github.com/users/jverbraeken/orgs","repos_url":"https://api.github.com/users/jverbraeken/repos","events_url":"https://api.github.com/users/jverbraeken/events{/privacy}","received_events_url":"https://api.github.com/users/jverbraeken/received_events","type":"User","site_admin":false},"body":"<!-- Check if the title is descriptive! -->\r\n- Relevant Issues: -\r\n- Related Pull Requests: -\r\n\r\n* * *\r\n\r\n## What\r\nThis Pull Request adds to the repository a full refractoring of the Bluetooth related classes.\r\n\r\n- The EventBus is used extensively to communicate \r\n- A background service is introduced\r\n- A global Application class is introduced to keep track of the background service\r\n- Every data type can now be sent over Bluetooth (so not just contacts)\r\n- The large Bluetooth classes is split in 5 new classes (and also for a part in APairingHandler)\r\n\r\n## Why\r\nThis Pull Request is needed because the old Bluetooth class was difficult to understand, the Bluetooth screen had to be opened to receive contacts and only contacts could be sent and PMD didn't like the coupling / class size\r\n\r\n## How\r\nThis feature can be viewed/tested within the project by sharing contacts over Bluetooth\r\n\r\n## Alternative implementation\r\nOther implementations that I've have considered are -\r\n\r\n## Notes\r\n<!-- Is there anything reviewers need to know about? Do they need to take something into account while\r\nreviewing? Is there something they should pay extra attention to? -->\r\nThe very first meeting I'll give you a walkthrough through this new code ;-)","created_at":"2017-05-27T15:34:20Z","updated_at":"2017-05-29T12:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b849f110e16a83eee271e02e63830be91d6f614c","assignee":{"login":"jverbraeken","id":15014738,"avatar_url":"https://avatars2.githubusercontent.com/u/15014738?v=3","gravatar_id":"","url":"https://api.github.com/users/jverbraeken","html_url":"https://github.com/jverbraeken","followers_url":"https://api.github.com/users/jverbraeken/followers","following_url":"https://api.github.com/users/jverbraeken/following{/other_user}","gists_url":"https://api.github.com/users/jverbraeken/gists{/gist_id}","starred_url":"https://api.github.com/users/jverbraeken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverbraeken/subscriptions","organizations_url":"https://api.github.com/users/jverbraeken/orgs","repos_url":"https://api.github.com/users/jverbraeken/repos","events_url":"https://api.github.com/users/jverbraeken/events{/privacy}","received_events_url":"https://api.github.com/users/jverbraeken/received_events","type":"User","site_admin":false},"assignees":[{"login":"jverbraeken","id":15014738,"avatar_url":"https://avatars2.githubusercontent.com/u/15014738?v=3","gravatar_id":"","url":"https://api.github.com/users/jverbraeken","html_url":"https://github.com/jverbraeken","followers_url":"https://api.github.com/users/jverbraeken/followers","following_url":"https://api.github.com/users/jverbraeken/following{/other_user}","gists_url":"https://api.github.com/users/jverbraeken/gists{/gist_id}","starred_url":"https://api.github.com/users/jverbraeken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverbraeken/subscriptions","organizations_url":"https://api.github.com/users/jverbraeken/orgs","repos_url":"https://api.github.com/users/jverbraeken/repos","events_url":"https://api.github.com/users/jverbraeken/events{/privacy}","received_events_url":"https://api.github.com/users/jverbraeken/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false},{"login":"clenrock","id":15815376,"avatar_url":"https://avatars0.githubusercontent.com/u/15815376?v=3","gravatar_id":"","url":"https://api.github.com/users/clenrock","html_url":"https://github.com/clenrock","followers_url":"https://api.github.com/users/clenrock/followers","following_url":"https://api.github.com/users/clenrock/following{/other_user}","gists_url":"https://api.github.com/users/clenrock/gists{/gist_id}","starred_url":"https://api.github.com/users/clenrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clenrock/subscriptions","organizations_url":"https://api.github.com/users/clenrock/orgs","repos_url":"https://api.github.com/users/clenrock/repos","events_url":"https://api.github.com/users/clenrock/events{/privacy}","received_events_url":"https://api.github.com/users/clenrock/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170/commits","review_comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170/comments","review_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/170/comments","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/08e253d03a81a279ca8121989313e0deba095211","head":{"label":"ericcornelissen:bluetooth-refractor","ref":"bluetooth-refractor","sha":"08e253d03a81a279ca8121989313e0deba095211","user":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"repo":{"id":89348865,"name":"NervousFish","full_name":"ericcornelissen/NervousFish","owner":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericcornelissen/NervousFish","description":"An app for your :iphone: to exchange public-keys in a secure manner.","fork":false,"url":"https://api.github.com/repos/ericcornelissen/NervousFish","forks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/forks","keys_url":"https://api.github.com/repos/ericcornelissen/NervousFish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericcornelissen/NervousFish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericcornelissen/NervousFish/teams","hooks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/hooks","issue_events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/events{/number}","events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/events","assignees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/assignees{/user}","branches_url":"https://api.github.com/repos/ericcornelissen/NervousFish/branches{/branch}","tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/tags","blobs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/{sha}","languages_url":"https://api.github.com/repos/ericcornelissen/NervousFish/languages","stargazers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/stargazers","contributors_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contributors","subscribers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscribers","subscription_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscription","commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contents/{+path}","compare_url":"https://api.github.com/repos/ericcornelissen/NervousFish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericcornelissen/NervousFish/merges","archive_url":"https://api.github.com/repos/ericcornelissen/NervousFish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericcornelissen/NervousFish/downloads","issues_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues{/number}","pulls_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls{/number}","milestones_url":"https://api.github.com/repos/ericcornelissen/NervousFish/milestones{/number}","notifications_url":"https://api.github.com/repos/ericcornelissen/NervousFish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericcornelissen/NervousFish/labels{/name}","releases_url":"https://api.github.com/repos/ericcornelissen/NervousFish/releases{/id}","deployments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/deployments","created_at":"2017-04-25T10:37:48Z","updated_at":"2017-04-28T12:31:03Z","pushed_at":"2017-05-29T12:43:33Z","git_url":"git://github.com/ericcornelissen/NervousFish.git","ssh_url":"git@github.com:ericcornelissen/NervousFish.git","clone_url":"https://github.com/ericcornelissen/NervousFish.git","svn_url":"https://github.com/ericcornelissen/NervousFish","homepage":"","size":2690,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":47,"forks":3,"open_issues":47,"watchers":0,"default_branch":"develop"}},"base":{"label":"ericcornelissen:develop","ref":"develop","sha":"4264c0853f80371f3bc653ac6c45883ffb7a4e22","user":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"repo":{"id":89348865,"name":"NervousFish","full_name":"ericcornelissen/NervousFish","owner":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericcornelissen/NervousFish","description":"An app for your :iphone: to exchange public-keys in a secure manner.","fork":false,"url":"https://api.github.com/repos/ericcornelissen/NervousFish","forks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/forks","keys_url":"https://api.github.com/repos/ericcornelissen/NervousFish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericcornelissen/NervousFish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericcornelissen/NervousFish/teams","hooks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/hooks","issue_events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/events{/number}","events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/events","assignees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/assignees{/user}","branches_url":"https://api.github.com/repos/ericcornelissen/NervousFish/branches{/branch}","tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/tags","blobs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/{sha}","languages_url":"https://api.github.com/repos/ericcornelissen/NervousFish/languages","stargazers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/stargazers","contributors_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contributors","subscribers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscribers","subscription_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscription","commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contents/{+path}","compare_url":"https://api.github.com/repos/ericcornelissen/NervousFish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericcornelissen/NervousFish/merges","archive_url":"https://api.github.com/repos/ericcornelissen/NervousFish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericcornelissen/NervousFish/downloads","issues_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues{/number}","pulls_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls{/number}","milestones_url":"https://api.github.com/repos/ericcornelissen/NervousFish/milestones{/number}","notifications_url":"https://api.github.com/repos/ericcornelissen/NervousFish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericcornelissen/NervousFish/labels{/name}","releases_url":"https://api.github.com/repos/ericcornelissen/NervousFish/releases{/id}","deployments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/deployments","created_at":"2017-04-25T10:37:48Z","updated_at":"2017-04-28T12:31:03Z","pushed_at":"2017-05-29T12:43:33Z","git_url":"git://github.com/ericcornelissen/NervousFish.git","ssh_url":"git@github.com:ericcornelissen/NervousFish.git","clone_url":"https://github.com/ericcornelissen/NervousFish.git","svn_url":"https://github.com/ericcornelissen/NervousFish","homepage":"","size":2690,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":47,"forks":3,"open_issues":47,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170"},"html":{"href":"https://github.com/ericcornelissen/NervousFish/pull/170"},"issue":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/170"},"comments":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/08e253d03a81a279ca8121989313e0deba095211"}}}}
{"actor":{"display_login":"ericcornelissen"}}