{"action":"created","comment":{"url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/comments/137272440","pull_request_review_id":60916339,"id":137272440,"diff_hunk":"@@ -30,7 +30,8 @@ Alternatively you can use docker-compose:\n \n We were unable to get the functional tests working via Codeship, so instead you will have to test via the `test-functional` command (which uses `docker-compose` internally). This will spin up a Kubernetes cluster and then run the functional tests against it and then shutdown and delete the cluster afterwards.\n \n-1. `./test-functional`\n+1. First install [minikube](https://kubernetes.io/docs/tasks/tools/install-minikube/)","path":"CONTRIBUTING.md","position":5,"original_position":5,"commit_id":"70d235a56d1e2470409f8c9ae14bebe1ee57bcdc","original_commit_id":"70d235a56d1e2470409f8c9ae14bebe1ee57bcdc","user":{"login":"manute","id":434575,"avatar_url":"https://avatars1.githubusercontent.com/u/434575?v=4","gravatar_id":"","url":"https://api.github.com/users/manute","html_url":"https://github.com/manute","followers_url":"https://api.github.com/users/manute/followers","following_url":"https://api.github.com/users/manute/following{/other_user}","gists_url":"https://api.github.com/users/manute/gists{/gist_id}","starred_url":"https://api.github.com/users/manute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manute/subscriptions","organizations_url":"https://api.github.com/users/manute/orgs","repos_url":"https://api.github.com/users/manute/repos","events_url":"https://api.github.com/users/manute/events{/privacy}","received_events_url":"https://api.github.com/users/manute/received_events","type":"User","site_admin":false},"body":"this is nice. We might do these tests for all our projects that operates with kubernetes ","created_at":"2017-09-06T13:50:08Z","updated_at":"2017-09-06T13:52:40Z","html_url":"https://github.com/InVisionApp/kit-deployer/pull/111#discussion_r137272440","pull_request_url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/comments/137272440"},"html":{"href":"https://github.com/InVisionApp/kit-deployer/pull/111#discussion_r137272440"},"pull_request":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111","id":139565986,"html_url":"https://github.com/InVisionApp/kit-deployer/pull/111","diff_url":"https://github.com/InVisionApp/kit-deployer/pull/111.diff","patch_url":"https://github.com/InVisionApp/kit-deployer/pull/111.patch","issue_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/111","number":111,"state":"open","locked":false,"title":"Fix deploying jobs on 1.6 kubernetes","user":{"login":"chesleybrown","id":492166,"avatar_url":"https://avatars2.githubusercontent.com/u/492166?v=4","gravatar_id":"","url":"https://api.github.com/users/chesleybrown","html_url":"https://github.com/chesleybrown","followers_url":"https://api.github.com/users/chesleybrown/followers","following_url":"https://api.github.com/users/chesleybrown/following{/other_user}","gists_url":"https://api.github.com/users/chesleybrown/gists{/gist_id}","starred_url":"https://api.github.com/users/chesleybrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chesleybrown/subscriptions","organizations_url":"https://api.github.com/users/chesleybrown/orgs","repos_url":"https://api.github.com/users/chesleybrown/repos","events_url":"https://api.github.com/users/chesleybrown/events{/privacy}","received_events_url":"https://api.github.com/users/chesleybrown/received_events","type":"User","site_admin":false},"body":"# What\r\n\r\n- fixes #109 and fixes #94 \r\n- we need to use the `batch` api for deployments and not the `extensions` api\r\n- switched functional tests to use `minikube` which is more stable\r\n- functional tests are now faster by allowing you to run the tests without completely destroying and re-creating the kubernetes cluster\r\n- I downgraded the kubectl from `1.6.7` to `1.6.4` as that was the latest `1.6` version supported by minikube and I wanted to make sure it was working as we expected\r\n\r\n# Testing\r\n\r\n- Install [minikube](https://kubernetes.io/docs/tasks/tools/install-minikube/)\r\n- Run `./test-functional`","created_at":"2017-09-06T13:44:28Z","updated_at":"2017-09-06T13:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1a942da1d2408a588290157f894ce07c391e20e","assignee":{"login":"chesleybrown","id":492166,"avatar_url":"https://avatars2.githubusercontent.com/u/492166?v=4","gravatar_id":"","url":"https://api.github.com/users/chesleybrown","html_url":"https://github.com/chesleybrown","followers_url":"https://api.github.com/users/chesleybrown/followers","following_url":"https://api.github.com/users/chesleybrown/following{/other_user}","gists_url":"https://api.github.com/users/chesleybrown/gists{/gist_id}","starred_url":"https://api.github.com/users/chesleybrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chesleybrown/subscriptions","organizations_url":"https://api.github.com/users/chesleybrown/orgs","repos_url":"https://api.github.com/users/chesleybrown/repos","events_url":"https://api.github.com/users/chesleybrown/events{/privacy}","received_events_url":"https://api.github.com/users/chesleybrown/received_events","type":"User","site_admin":false},"assignees":[{"login":"chesleybrown","id":492166,"avatar_url":"https://avatars2.githubusercontent.com/u/492166?v=4","gravatar_id":"","url":"https://api.github.com/users/chesleybrown","html_url":"https://github.com/chesleybrown","followers_url":"https://api.github.com/users/chesleybrown/followers","following_url":"https://api.github.com/users/chesleybrown/following{/other_user}","gists_url":"https://api.github.com/users/chesleybrown/gists{/gist_id}","starred_url":"https://api.github.com/users/chesleybrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chesleybrown/subscriptions","organizations_url":"https://api.github.com/users/chesleybrown/orgs","repos_url":"https://api.github.com/users/chesleybrown/repos","events_url":"https://api.github.com/users/chesleybrown/events{/privacy}","received_events_url":"https://api.github.com/users/chesleybrown/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111/commits","review_comments_url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111/comments","review_comment_url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/111/comments","statuses_url":"https://api.github.com/repos/InVisionApp/kit-deployer/statuses/70d235a56d1e2470409f8c9ae14bebe1ee57bcdc","head":{"label":"InVisionApp:fix-jobs-1.6","ref":"fix-jobs-1.6","sha":"70d235a56d1e2470409f8c9ae14bebe1ee57bcdc","user":{"login":"InVisionApp","id":1536893,"avatar_url":"https://avatars2.githubusercontent.com/u/1536893?v=4","gravatar_id":"","url":"https://api.github.com/users/InVisionApp","html_url":"https://github.com/InVisionApp","followers_url":"https://api.github.com/users/InVisionApp/followers","following_url":"https://api.github.com/users/InVisionApp/following{/other_user}","gists_url":"https://api.github.com/users/InVisionApp/gists{/gist_id}","starred_url":"https://api.github.com/users/InVisionApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InVisionApp/subscriptions","organizations_url":"https://api.github.com/users/InVisionApp/orgs","repos_url":"https://api.github.com/users/InVisionApp/repos","events_url":"https://api.github.com/users/InVisionApp/events{/privacy}","received_events_url":"https://api.github.com/users/InVisionApp/received_events","type":"Organization","site_admin":false},"repo":{"id":60726566,"name":"kit-deployer","full_name":"InVisionApp/kit-deployer","owner":{"login":"InVisionApp","id":1536893,"avatar_url":"https://avatars2.githubusercontent.com/u/1536893?v=4","gravatar_id":"","url":"https://api.github.com/users/InVisionApp","html_url":"https://github.com/InVisionApp","followers_url":"https://api.github.com/users/InVisionApp/followers","following_url":"https://api.github.com/users/InVisionApp/following{/other_user}","gists_url":"https://api.github.com/users/InVisionApp/gists{/gist_id}","starred_url":"https://api.github.com/users/InVisionApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InVisionApp/subscriptions","organizations_url":"https://api.github.com/users/InVisionApp/orgs","repos_url":"https://api.github.com/users/InVisionApp/repos","events_url":"https://api.github.com/users/InVisionApp/events{/privacy}","received_events_url":"https://api.github.com/users/InVisionApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/InVisionApp/kit-deployer","description":"kit component used for deploying manifests to multiple Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/InVisionApp/kit-deployer","forks_url":"https://api.github.com/repos/InVisionApp/kit-deployer/forks","keys_url":"https://api.github.com/repos/InVisionApp/kit-deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InVisionApp/kit-deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InVisionApp/kit-deployer/teams","hooks_url":"https://api.github.com/repos/InVisionApp/kit-deployer/hooks","issue_events_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/events{/number}","events_url":"https://api.github.com/repos/InVisionApp/kit-deployer/events","assignees_url":"https://api.github.com/repos/InVisionApp/kit-deployer/assignees{/user}","branches_url":"https://api.github.com/repos/InVisionApp/kit-deployer/branches{/branch}","tags_url":"https://api.github.com/repos/InVisionApp/kit-deployer/tags","blobs_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InVisionApp/kit-deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/InVisionApp/kit-deployer/languages","stargazers_url":"https://api.github.com/repos/InVisionApp/kit-deployer/stargazers","contributors_url":"https://api.github.com/repos/InVisionApp/kit-deployer/contributors","subscribers_url":"https://api.github.com/repos/InVisionApp/kit-deployer/subscribers","subscription_url":"https://api.github.com/repos/InVisionApp/kit-deployer/subscription","commits_url":"https://api.github.com/repos/InVisionApp/kit-deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/InVisionApp/kit-deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/InVisionApp/kit-deployer/contents/{+path}","compare_url":"https://api.github.com/repos/InVisionApp/kit-deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InVisionApp/kit-deployer/merges","archive_url":"https://api.github.com/repos/InVisionApp/kit-deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InVisionApp/kit-deployer/downloads","issues_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues{/number}","pulls_url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/InVisionApp/kit-deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/InVisionApp/kit-deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InVisionApp/kit-deployer/labels{/name}","releases_url":"https://api.github.com/repos/InVisionApp/kit-deployer/releases{/id}","deployments_url":"https://api.github.com/repos/InVisionApp/kit-deployer/deployments","created_at":"2016-06-08T19:55:44Z","updated_at":"2017-08-01T15:00:46Z","pushed_at":"2017-09-06T13:46:49Z","git_url":"git://github.com/InVisionApp/kit-deployer.git","ssh_url":"git@github.com:InVisionApp/kit-deployer.git","clone_url":"https://github.com/InVisionApp/kit-deployer.git","svn_url":"https://github.com/InVisionApp/kit-deployer","homepage":"https://invisionapp.github.io/kit/","size":368,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":20,"default_branch":"master"}},"base":{"label":"InVisionApp:master","ref":"master","sha":"6e403cd8c9ce6bb7c7e526495c242e00510bb012","user":{"login":"InVisionApp","id":1536893,"avatar_url":"https://avatars2.githubusercontent.com/u/1536893?v=4","gravatar_id":"","url":"https://api.github.com/users/InVisionApp","html_url":"https://github.com/InVisionApp","followers_url":"https://api.github.com/users/InVisionApp/followers","following_url":"https://api.github.com/users/InVisionApp/following{/other_user}","gists_url":"https://api.github.com/users/InVisionApp/gists{/gist_id}","starred_url":"https://api.github.com/users/InVisionApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InVisionApp/subscriptions","organizations_url":"https://api.github.com/users/InVisionApp/orgs","repos_url":"https://api.github.com/users/InVisionApp/repos","events_url":"https://api.github.com/users/InVisionApp/events{/privacy}","received_events_url":"https://api.github.com/users/InVisionApp/received_events","type":"Organization","site_admin":false},"repo":{"id":60726566,"name":"kit-deployer","full_name":"InVisionApp/kit-deployer","owner":{"login":"InVisionApp","id":1536893,"avatar_url":"https://avatars2.githubusercontent.com/u/1536893?v=4","gravatar_id":"","url":"https://api.github.com/users/InVisionApp","html_url":"https://github.com/InVisionApp","followers_url":"https://api.github.com/users/InVisionApp/followers","following_url":"https://api.github.com/users/InVisionApp/following{/other_user}","gists_url":"https://api.github.com/users/InVisionApp/gists{/gist_id}","starred_url":"https://api.github.com/users/InVisionApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InVisionApp/subscriptions","organizations_url":"https://api.github.com/users/InVisionApp/orgs","repos_url":"https://api.github.com/users/InVisionApp/repos","events_url":"https://api.github.com/users/InVisionApp/events{/privacy}","received_events_url":"https://api.github.com/users/InVisionApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/InVisionApp/kit-deployer","description":"kit component used for deploying manifests to multiple Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/InVisionApp/kit-deployer","forks_url":"https://api.github.com/repos/InVisionApp/kit-deployer/forks","keys_url":"https://api.github.com/repos/InVisionApp/kit-deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InVisionApp/kit-deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InVisionApp/kit-deployer/teams","hooks_url":"https://api.github.com/repos/InVisionApp/kit-deployer/hooks","issue_events_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/events{/number}","events_url":"https://api.github.com/repos/InVisionApp/kit-deployer/events","assignees_url":"https://api.github.com/repos/InVisionApp/kit-deployer/assignees{/user}","branches_url":"https://api.github.com/repos/InVisionApp/kit-deployer/branches{/branch}","tags_url":"https://api.github.com/repos/InVisionApp/kit-deployer/tags","blobs_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InVisionApp/kit-deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/InVisionApp/kit-deployer/languages","stargazers_url":"https://api.github.com/repos/InVisionApp/kit-deployer/stargazers","contributors_url":"https://api.github.com/repos/InVisionApp/kit-deployer/contributors","subscribers_url":"https://api.github.com/repos/InVisionApp/kit-deployer/subscribers","subscription_url":"https://api.github.com/repos/InVisionApp/kit-deployer/subscription","commits_url":"https://api.github.com/repos/InVisionApp/kit-deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/InVisionApp/kit-deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/InVisionApp/kit-deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/InVisionApp/kit-deployer/contents/{+path}","compare_url":"https://api.github.com/repos/InVisionApp/kit-deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InVisionApp/kit-deployer/merges","archive_url":"https://api.github.com/repos/InVisionApp/kit-deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InVisionApp/kit-deployer/downloads","issues_url":"https://api.github.com/repos/InVisionApp/kit-deployer/issues{/number}","pulls_url":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/InVisionApp/kit-deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/InVisionApp/kit-deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InVisionApp/kit-deployer/labels{/name}","releases_url":"https://api.github.com/repos/InVisionApp/kit-deployer/releases{/id}","deployments_url":"https://api.github.com/repos/InVisionApp/kit-deployer/deployments","created_at":"2016-06-08T19:55:44Z","updated_at":"2017-08-01T15:00:46Z","pushed_at":"2017-09-06T13:46:49Z","git_url":"git://github.com/InVisionApp/kit-deployer.git","ssh_url":"git@github.com:InVisionApp/kit-deployer.git","clone_url":"https://github.com/InVisionApp/kit-deployer.git","svn_url":"https://github.com/InVisionApp/kit-deployer","homepage":"https://invisionapp.github.io/kit/","size":368,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111"},"html":{"href":"https://github.com/InVisionApp/kit-deployer/pull/111"},"issue":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/111"},"comments":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/InVisionApp/kit-deployer/statuses/70d235a56d1e2470409f8c9ae14bebe1ee57bcdc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"manute"}}