{"action":"created","comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/120677105","pull_request_review_id":42660030,"id":120677105,"diff_hunk":"@@ -52,42 +52,48 @@ object Main {\n   type DriverEff[A]  = Coproduct[ReplFail, DriverEff0, A]\n   type DriverEffM[A] = Free[DriverEff, A]\n \n-  private def driver(f: Command => Free[DriverEff, Unit], e: Task[Unit]): Task[Unit] = Task.delay {\n-    val console =\n-      new Console(new SettingsBuilder()\n-        .parseOperators(false)\n-        .enableExport(false)\n-        .interruptHook(new InterruptHook {\n-          def handleInterrupt(console: Console, action: Action) = {\n-            console.getShell.out.println(\"exit\")\n-            e.unsafePerformSync\n-            console.stop\n+  private def driver(f: Command => Free[DriverEff, Unit], e: Task[Unit]): Task[Unit] = {\n+    def shutdownConsole(c: Console): Task[Unit] =\n+      Task.delay(c.getShell.out.println(\"Exiting...\")) *>\n+      e.attempt                                        *>","path":"repl/src/main/scala/quasar/repl/Main.scala","position":17,"original_position":17,"commit_id":"050dd40d74fca2e0a1249729c7f1bf2bfc257ade","original_commit_id":"050dd40d74fca2e0a1249729c7f1bf2bfc257ade","user":{"login":"djspiewak","id":752,"avatar_url":"https://avatars2.githubusercontent.com/u/752?v=3","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"body":"Conceptual niggle…  Shouldn't this be `>>` instead of `*>`?  Both work, but only because `Task` happens to consider hidden evaluation semantics to be part of its substitutability.  It mightn't work with another monad, even a lawful one.","created_at":"2017-06-07T16:31:36Z","updated_at":"2017-06-07T16:32:01Z","html_url":"https://github.com/quasar-analytics/quasar/pull/2289#discussion_r120677105","pull_request_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289","_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/120677105"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/2289#discussion_r120677105"},"pull_request":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289"}}},"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289","id":124456335,"html_url":"https://github.com/quasar-analytics/quasar/pull/2289","diff_url":"https://github.com/quasar-analytics/quasar/pull/2289.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/2289.patch","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/2289","number":2289,"state":"open","locked":false,"title":"Actually unmount filesystems when exiting repl/server","user":{"login":"wemrysi","id":32185,"avatar_url":"https://avatars0.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"body":"Fixes #2288.","created_at":"2017-06-07T15:54:32Z","updated_at":"2017-06-07T16:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ab8ce3100493bd628b5fa46179df7c18730ce19","assignee":{"login":"drostron","id":318090,"avatar_url":"https://avatars1.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false},"assignees":[{"login":"wemrysi","id":32185,"avatar_url":"https://avatars0.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},{"login":"drostron","id":318090,"avatar_url":"https://avatars1.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"drostron","id":318090,"avatar_url":"https://avatars1.githubusercontent.com/u/318090?v=3","gravatar_id":"","url":"https://api.github.com/users/drostron","html_url":"https://github.com/drostron","followers_url":"https://api.github.com/users/drostron/followers","following_url":"https://api.github.com/users/drostron/following{/other_user}","gists_url":"https://api.github.com/users/drostron/gists{/gist_id}","starred_url":"https://api.github.com/users/drostron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drostron/subscriptions","organizations_url":"https://api.github.com/users/drostron/orgs","repos_url":"https://api.github.com/users/drostron/repos","events_url":"https://api.github.com/users/drostron/events{/privacy}","received_events_url":"https://api.github.com/users/drostron/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289/commits","review_comments_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289/comments","review_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/2289/comments","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/050dd40d74fca2e0a1249729c7f1bf2bfc257ade","head":{"label":"wemrysi:bug/2288-actually-close-filesystems","ref":"bug/2288-actually-close-filesystems","sha":"050dd40d74fca2e0a1249729c7f1bf2bfc257ade","user":{"login":"wemrysi","id":32185,"avatar_url":"https://avatars0.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"repo":{"id":40374964,"name":"quasar","full_name":"wemrysi/quasar","owner":{"login":"wemrysi","id":32185,"avatar_url":"https://avatars0.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wemrysi/quasar","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/wemrysi/quasar","forks_url":"https://api.github.com/repos/wemrysi/quasar/forks","keys_url":"https://api.github.com/repos/wemrysi/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wemrysi/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wemrysi/quasar/teams","hooks_url":"https://api.github.com/repos/wemrysi/quasar/hooks","issue_events_url":"https://api.github.com/repos/wemrysi/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/wemrysi/quasar/events","assignees_url":"https://api.github.com/repos/wemrysi/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/wemrysi/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/wemrysi/quasar/tags","blobs_url":"https://api.github.com/repos/wemrysi/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wemrysi/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wemrysi/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/wemrysi/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wemrysi/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/wemrysi/quasar/languages","stargazers_url":"https://api.github.com/repos/wemrysi/quasar/stargazers","contributors_url":"https://api.github.com/repos/wemrysi/quasar/contributors","subscribers_url":"https://api.github.com/repos/wemrysi/quasar/subscribers","subscription_url":"https://api.github.com/repos/wemrysi/quasar/subscription","commits_url":"https://api.github.com/repos/wemrysi/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/wemrysi/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/wemrysi/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/wemrysi/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/wemrysi/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/wemrysi/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wemrysi/quasar/merges","archive_url":"https://api.github.com/repos/wemrysi/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wemrysi/quasar/downloads","issues_url":"https://api.github.com/repos/wemrysi/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/wemrysi/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/wemrysi/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/wemrysi/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wemrysi/quasar/labels{/name}","releases_url":"https://api.github.com/repos/wemrysi/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/wemrysi/quasar/deployments","created_at":"2015-08-07T18:29:08Z","updated_at":"2015-09-14T20:43:00Z","pushed_at":"2017-06-07T15:50:46Z","git_url":"git://github.com/wemrysi/quasar.git","ssh_url":"git@github.com:wemrysi/quasar.git","clone_url":"https://github.com/wemrysi/quasar.git","svn_url":"https://github.com/wemrysi/quasar","homepage":null,"size":57856,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quasar-analytics:master","ref":"master","sha":"2a7c0e596da806a78581c1a06b62ad8339bcc2b9","user":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars2.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"quasar-analytics/quasar","owner":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars2.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quasar-analytics/quasar","description":"Quasar Analytics is a general-purpose compiler for translating data processing and analytics over semi-structured data into efficient plans that run 100% in the target infrastructure.","fork":false,"url":"https://api.github.com/repos/quasar-analytics/quasar","forks_url":"https://api.github.com/repos/quasar-analytics/quasar/forks","keys_url":"https://api.github.com/repos/quasar-analytics/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quasar-analytics/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quasar-analytics/quasar/teams","hooks_url":"https://api.github.com/repos/quasar-analytics/quasar/hooks","issue_events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/quasar-analytics/quasar/events","assignees_url":"https://api.github.com/repos/quasar-analytics/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/quasar-analytics/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/quasar-analytics/quasar/tags","blobs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quasar-analytics/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quasar-analytics/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/quasar-analytics/quasar/languages","stargazers_url":"https://api.github.com/repos/quasar-analytics/quasar/stargazers","contributors_url":"https://api.github.com/repos/quasar-analytics/quasar/contributors","subscribers_url":"https://api.github.com/repos/quasar-analytics/quasar/subscribers","subscription_url":"https://api.github.com/repos/quasar-analytics/quasar/subscription","commits_url":"https://api.github.com/repos/quasar-analytics/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quasar-analytics/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quasar-analytics/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/quasar-analytics/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quasar-analytics/quasar/merges","archive_url":"https://api.github.com/repos/quasar-analytics/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quasar-analytics/quasar/downloads","issues_url":"https://api.github.com/repos/quasar-analytics/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/quasar-analytics/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/labels{/name}","releases_url":"https://api.github.com/repos/quasar-analytics/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/quasar-analytics/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2017-06-06T19:51:42Z","pushed_at":"2017-06-07T16:20:58Z","git_url":"git://github.com/quasar-analytics/quasar.git","ssh_url":"git@github.com:quasar-analytics/quasar.git","clone_url":"https://github.com/quasar-analytics/quasar.git","svn_url":"https://github.com/quasar-analytics/quasar","homepage":"http://quasar-analytics.org","size":57823,"stargazers_count":496,"watchers_count":496,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":254,"forks":69,"open_issues":254,"watchers":496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/2289"},"issue":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/2289"},"comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/2289/comments"},"review_comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289/comments"},"review_comment":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2289/commits"},"statuses":{"href":"https://api.github.com/repos/quasar-analytics/quasar/statuses/050dd40d74fca2e0a1249729c7f1bf2bfc257ade"}}}}
{"actor":{"display_login":"djspiewak"}}