{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/comments/152066465","pull_request_review_id":77870958,"id":152066465,"diff_hunk":"@@ -141,6 +143,39 @@ def validate_json(spec_dict, schema_path, spec_url='', http_handlers=None):\n     return spec_resolver\n \n \n+@wrap_exception\n+def validate_value_type(schema, value, deref):\n+    # Extract resolver from deref partial build on ``validate_spec``\n+    # This is used in order to use already fetched external references\n+    # If it is missing a new RefResolver will be initialized\n+    swagger_resolver = getattr(deref, 'keywords', {}).get('resolver', None)","path":"swagger_spec_validator/validator20.py","position":43,"original_position":43,"commit_id":"b555b7299ef24cc99f56eeed68c654e33df560d2","original_commit_id":"b555b7299ef24cc99f56eeed68c654e33df560d2","user":{"login":"bplotnick","id":5392381,"avatar_url":"https://avatars0.githubusercontent.com/u/5392381?v=4","gravatar_id":"","url":"https://api.github.com/users/bplotnick","html_url":"https://github.com/bplotnick","followers_url":"https://api.github.com/users/bplotnick/followers","following_url":"https://api.github.com/users/bplotnick/following{/other_user}","gists_url":"https://api.github.com/users/bplotnick/gists{/gist_id}","starred_url":"https://api.github.com/users/bplotnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bplotnick/subscriptions","organizations_url":"https://api.github.com/users/bplotnick/orgs","repos_url":"https://api.github.com/users/bplotnick/repos","events_url":"https://api.github.com/users/bplotnick/events{/privacy}","received_events_url":"https://api.github.com/users/bplotnick/received_events","type":"User","site_admin":false},"body":"I'm, still not sure where `keywords` comes from. Am I missing something obvious?","created_at":"2017-11-20T18:02:47Z","updated_at":"2017-11-20T18:02:47Z","html_url":"https://github.com/Yelp/swagger_spec_validator/pull/82#discussion_r152066465","pull_request_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/comments/152066465"},"html":{"href":"https://github.com/Yelp/swagger_spec_validator/pull/82#discussion_r152066465"},"pull_request":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82","id":152175931,"html_url":"https://github.com/Yelp/swagger_spec_validator/pull/82","diff_url":"https://github.com/Yelp/swagger_spec_validator/pull/82.diff","patch_url":"https://github.com/Yelp/swagger_spec_validator/pull/82.patch","issue_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/issues/82","number":82,"state":"open","locked":false,"title":"Ensure that defaults are compliant with the object/parameter spec.","user":{"login":"macisamuele","id":6726359,"avatar_url":"https://avatars3.githubusercontent.com/u/6726359?v=4","gravatar_id":"","url":"https://api.github.com/users/macisamuele","html_url":"https://github.com/macisamuele","followers_url":"https://api.github.com/users/macisamuele/followers","following_url":"https://api.github.com/users/macisamuele/following{/other_user}","gists_url":"https://api.github.com/users/macisamuele/gists{/gist_id}","starred_url":"https://api.github.com/users/macisamuele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisamuele/subscriptions","organizations_url":"https://api.github.com/users/macisamuele/orgs","repos_url":"https://api.github.com/users/macisamuele/repos","events_url":"https://api.github.com/users/macisamuele/events{/privacy}","received_events_url":"https://api.github.com/users/macisamuele/received_events","type":"User","site_admin":false},"body":"The goal of this PR is to fix #80 .\r\n\r\nThe main change introduced by this relates to ``validate_schema_value`` method that will allow checking that a property default is respecting the specification of the property itself.\r\n\r\nOther changes introduced are:\r\n * let log library to handle formatting of messages (it will reduce the overhead of logging in case of logging level is not used)\r\n * Ensure that file pointers are closed after their use.","created_at":"2017-11-13T08:18:12Z","updated_at":"2017-11-20T18:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"588ecfb627d91ea4c936f2d280a6ae8bf5ea9774","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82/commits","review_comments_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82/comments","review_comment_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/issues/82/comments","statuses_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/statuses/b555b7299ef24cc99f56eeed68c654e33df560d2","head":{"label":"macisamuele:maci-fixes-issue-80","ref":"maci-fixes-issue-80","sha":"b555b7299ef24cc99f56eeed68c654e33df560d2","user":{"login":"macisamuele","id":6726359,"avatar_url":"https://avatars3.githubusercontent.com/u/6726359?v=4","gravatar_id":"","url":"https://api.github.com/users/macisamuele","html_url":"https://github.com/macisamuele","followers_url":"https://api.github.com/users/macisamuele/followers","following_url":"https://api.github.com/users/macisamuele/following{/other_user}","gists_url":"https://api.github.com/users/macisamuele/gists{/gist_id}","starred_url":"https://api.github.com/users/macisamuele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisamuele/subscriptions","organizations_url":"https://api.github.com/users/macisamuele/orgs","repos_url":"https://api.github.com/users/macisamuele/repos","events_url":"https://api.github.com/users/macisamuele/events{/privacy}","received_events_url":"https://api.github.com/users/macisamuele/received_events","type":"User","site_admin":false},"repo":{"id":81248351,"name":"swagger_spec_validator","full_name":"macisamuele/swagger_spec_validator","owner":{"login":"macisamuele","id":6726359,"avatar_url":"https://avatars3.githubusercontent.com/u/6726359?v=4","gravatar_id":"","url":"https://api.github.com/users/macisamuele","html_url":"https://github.com/macisamuele","followers_url":"https://api.github.com/users/macisamuele/followers","following_url":"https://api.github.com/users/macisamuele/following{/other_user}","gists_url":"https://api.github.com/users/macisamuele/gists{/gist_id}","starred_url":"https://api.github.com/users/macisamuele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macisamuele/subscriptions","organizations_url":"https://api.github.com/users/macisamuele/orgs","repos_url":"https://api.github.com/users/macisamuele/repos","events_url":"https://api.github.com/users/macisamuele/events{/privacy}","received_events_url":"https://api.github.com/users/macisamuele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/macisamuele/swagger_spec_validator","description":null,"fork":true,"url":"https://api.github.com/repos/macisamuele/swagger_spec_validator","forks_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/forks","keys_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/teams","hooks_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/hooks","issue_events_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/issues/events{/number}","events_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/events","assignees_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/assignees{/user}","branches_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/branches{/branch}","tags_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/tags","blobs_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/statuses/{sha}","languages_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/languages","stargazers_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/stargazers","contributors_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/contributors","subscribers_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/subscribers","subscription_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/subscription","commits_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/contents/{+path}","compare_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/merges","archive_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/downloads","issues_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/issues{/number}","pulls_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/pulls{/number}","milestones_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/milestones{/number}","notifications_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/labels{/name}","releases_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/releases{/id}","deployments_url":"https://api.github.com/repos/macisamuele/swagger_spec_validator/deployments","created_at":"2017-02-07T19:59:15Z","updated_at":"2017-02-07T19:59:16Z","pushed_at":"2017-11-14T09:02:51Z","git_url":"git://github.com/macisamuele/swagger_spec_validator.git","ssh_url":"git@github.com:macisamuele/swagger_spec_validator.git","clone_url":"https://github.com/macisamuele/swagger_spec_validator.git","svn_url":"https://github.com/macisamuele/swagger_spec_validator","homepage":null,"size":198,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"f00c33da114128fb4a2babd9c451f121deca1ac4","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":28837384,"name":"swagger_spec_validator","full_name":"Yelp/swagger_spec_validator","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/swagger_spec_validator","description":null,"fork":false,"url":"https://api.github.com/repos/Yelp/swagger_spec_validator","forks_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/forks","keys_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/teams","hooks_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/hooks","issue_events_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/events","assignees_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/tags","blobs_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/languages","stargazers_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/stargazers","contributors_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/contributors","subscribers_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/subscribers","subscription_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/subscription","commits_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/merges","archive_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/downloads","issues_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/swagger_spec_validator/deployments","created_at":"2015-01-05T23:40:39Z","updated_at":"2017-09-01T20:51:33Z","pushed_at":"2017-11-16T22:32:23Z","git_url":"git://github.com/Yelp/swagger_spec_validator.git","ssh_url":"git@github.com:Yelp/swagger_spec_validator.git","clone_url":"https://github.com/Yelp/swagger_spec_validator.git","svn_url":"https://github.com/Yelp/swagger_spec_validator","homepage":null,"size":186,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":20,"forks":39,"open_issues":20,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82"},"html":{"href":"https://github.com/Yelp/swagger_spec_validator/pull/82"},"issue":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/issues/82"},"comments":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/swagger_spec_validator/statuses/b555b7299ef24cc99f56eeed68c654e33df560d2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bplotnick"}}