{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/109972820","pull_request_review_id":31110253,"id":109972820,"diff_hunk":"@@ -25,10 +25,11 @@\n import javax.security.sasl.SaslServer;\n import javax.security.sasl.SaslServerFactory;\n \n-import org.wildfly.security._private.ElytronMessages;\n import org.wildfly.security.auth.callback.MechanismInformationCallback;\n import org.wildfly.security.auth.server.MechanismInformation;\n \n+import static org.wildfly.security._private.ElytronMessages.log;","path":"src/main/java/org/wildfly/security/sasl/util/SetMechanismInformationSaslServerFactory.java","position":8,"original_position":8,"commit_id":"5c0497ca2292f80c0609e7ff64d11ab71c80f8f7","original_commit_id":"5c0497ca2292f80c0609e7ff64d11ab71c80f8f7","user":{"login":"darranl","id":481922,"avatar_url":"https://avatars0.githubusercontent.com/u/481922?v=3","gravatar_id":"","url":"https://api.github.com/users/darranl","html_url":"https://github.com/darranl","followers_url":"https://api.github.com/users/darranl/followers","following_url":"https://api.github.com/users/darranl/following{/other_user}","gists_url":"https://api.github.com/users/darranl/gists{/gist_id}","starred_url":"https://api.github.com/users/darranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darranl/subscriptions","organizations_url":"https://api.github.com/users/darranl/orgs","repos_url":"https://api.github.com/users/darranl/repos","events_url":"https://api.github.com/users/darranl/events{/privacy}","received_events_url":"https://api.github.com/users/darranl/received_events","type":"User","site_admin":false},"body":"Minor issue - statics should be first in the imports not last - can clean up later though.","created_at":"2017-04-05T17:06:46Z","updated_at":"2017-04-05T17:06:46Z","html_url":"https://github.com/wildfly-security/wildfly-elytron/pull/748#discussion_r109972820","pull_request_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748","_links":{"self":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/109972820"},"html":{"href":"https://github.com/wildfly-security/wildfly-elytron/pull/748#discussion_r109972820"},"pull_request":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748","id":113919477,"html_url":"https://github.com/wildfly-security/wildfly-elytron/pull/748","diff_url":"https://github.com/wildfly-security/wildfly-elytron/pull/748.diff","patch_url":"https://github.com/wildfly-security/wildfly-elytron/pull/748.patch","issue_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/748","number":748,"state":"open","locked":false,"title":"[ELY-1014] Warn on missing MechanismConfiguration","user":{"login":"honza889","id":3178122,"avatar_url":"https://avatars0.githubusercontent.com/u/3178122?v=3","gravatar_id":"","url":"https://api.github.com/users/honza889","html_url":"https://github.com/honza889","followers_url":"https://api.github.com/users/honza889/followers","following_url":"https://api.github.com/users/honza889/following{/other_user}","gists_url":"https://api.github.com/users/honza889/gists{/gist_id}","starred_url":"https://api.github.com/users/honza889/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honza889/subscriptions","organizations_url":"https://api.github.com/users/honza889/orgs","repos_url":"https://api.github.com/users/honza889/repos","events_url":"https://api.github.com/users/honza889/events{/privacy}","received_events_url":"https://api.github.com/users/honza889/received_events","type":"User","site_admin":false},"body":"* Added warning on missing MechanismConfiguration for given MechanismInformation\r\n* (trace in ServerAuthenticationContext not necessary already - visible in warn cause)\r\n\r\nno subsystem part\r\nwildfly-core, wildfly ladybird tests green","created_at":"2017-04-03T12:31:21Z","updated_at":"2017-04-05T17:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"075ffe09907fb166c26cc0864ba834884314f08a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748/commits","review_comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748/comments","review_comment_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/748/comments","statuses_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/5c0497ca2292f80c0609e7ff64d11ab71c80f8f7","head":{"label":"honza889:ELY-1014-warn","ref":"ELY-1014-warn","sha":"5c0497ca2292f80c0609e7ff64d11ab71c80f8f7","user":{"login":"honza889","id":3178122,"avatar_url":"https://avatars0.githubusercontent.com/u/3178122?v=3","gravatar_id":"","url":"https://api.github.com/users/honza889","html_url":"https://github.com/honza889","followers_url":"https://api.github.com/users/honza889/followers","following_url":"https://api.github.com/users/honza889/following{/other_user}","gists_url":"https://api.github.com/users/honza889/gists{/gist_id}","starred_url":"https://api.github.com/users/honza889/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honza889/subscriptions","organizations_url":"https://api.github.com/users/honza889/orgs","repos_url":"https://api.github.com/users/honza889/repos","events_url":"https://api.github.com/users/honza889/events{/privacy}","received_events_url":"https://api.github.com/users/honza889/received_events","type":"User","site_admin":false},"repo":{"id":22644117,"name":"wildfly-elytron","full_name":"honza889/wildfly-elytron","owner":{"login":"honza889","id":3178122,"avatar_url":"https://avatars0.githubusercontent.com/u/3178122?v=3","gravatar_id":"","url":"https://api.github.com/users/honza889","html_url":"https://github.com/honza889","followers_url":"https://api.github.com/users/honza889/followers","following_url":"https://api.github.com/users/honza889/following{/other_user}","gists_url":"https://api.github.com/users/honza889/gists{/gist_id}","starred_url":"https://api.github.com/users/honza889/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honza889/subscriptions","organizations_url":"https://api.github.com/users/honza889/orgs","repos_url":"https://api.github.com/users/honza889/repos","events_url":"https://api.github.com/users/honza889/events{/privacy}","received_events_url":"https://api.github.com/users/honza889/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/honza889/wildfly-elytron","description":"WildFly Elytron: Security, Authentication, and Authorization SPIs for the WildFly project","fork":true,"url":"https://api.github.com/repos/honza889/wildfly-elytron","forks_url":"https://api.github.com/repos/honza889/wildfly-elytron/forks","keys_url":"https://api.github.com/repos/honza889/wildfly-elytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honza889/wildfly-elytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honza889/wildfly-elytron/teams","hooks_url":"https://api.github.com/repos/honza889/wildfly-elytron/hooks","issue_events_url":"https://api.github.com/repos/honza889/wildfly-elytron/issues/events{/number}","events_url":"https://api.github.com/repos/honza889/wildfly-elytron/events","assignees_url":"https://api.github.com/repos/honza889/wildfly-elytron/assignees{/user}","branches_url":"https://api.github.com/repos/honza889/wildfly-elytron/branches{/branch}","tags_url":"https://api.github.com/repos/honza889/wildfly-elytron/tags","blobs_url":"https://api.github.com/repos/honza889/wildfly-elytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honza889/wildfly-elytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honza889/wildfly-elytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/honza889/wildfly-elytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honza889/wildfly-elytron/statuses/{sha}","languages_url":"https://api.github.com/repos/honza889/wildfly-elytron/languages","stargazers_url":"https://api.github.com/repos/honza889/wildfly-elytron/stargazers","contributors_url":"https://api.github.com/repos/honza889/wildfly-elytron/contributors","subscribers_url":"https://api.github.com/repos/honza889/wildfly-elytron/subscribers","subscription_url":"https://api.github.com/repos/honza889/wildfly-elytron/subscription","commits_url":"https://api.github.com/repos/honza889/wildfly-elytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/honza889/wildfly-elytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/honza889/wildfly-elytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/honza889/wildfly-elytron/issues/comments{/number}","contents_url":"https://api.github.com/repos/honza889/wildfly-elytron/contents/{+path}","compare_url":"https://api.github.com/repos/honza889/wildfly-elytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honza889/wildfly-elytron/merges","archive_url":"https://api.github.com/repos/honza889/wildfly-elytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honza889/wildfly-elytron/downloads","issues_url":"https://api.github.com/repos/honza889/wildfly-elytron/issues{/number}","pulls_url":"https://api.github.com/repos/honza889/wildfly-elytron/pulls{/number}","milestones_url":"https://api.github.com/repos/honza889/wildfly-elytron/milestones{/number}","notifications_url":"https://api.github.com/repos/honza889/wildfly-elytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honza889/wildfly-elytron/labels{/name}","releases_url":"https://api.github.com/repos/honza889/wildfly-elytron/releases{/id}","deployments_url":"https://api.github.com/repos/honza889/wildfly-elytron/deployments","created_at":"2014-08-05T13:17:41Z","updated_at":"2017-01-02T14:03:37Z","pushed_at":"2017-04-03T12:26:53Z","git_url":"git://github.com/honza889/wildfly-elytron.git","ssh_url":"git@github.com:honza889/wildfly-elytron.git","clone_url":"https://github.com/honza889/wildfly-elytron.git","svn_url":"https://github.com/honza889/wildfly-elytron","homepage":"","size":6376,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-security:master","ref":"master","sha":"81b31bc2f1cf1641436c493cd647dc5a433ce437","user":{"login":"wildfly-security","id":7501379,"avatar_url":"https://avatars1.githubusercontent.com/u/7501379?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security","html_url":"https://github.com/wildfly-security","followers_url":"https://api.github.com/users/wildfly-security/followers","following_url":"https://api.github.com/users/wildfly-security/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security/orgs","repos_url":"https://api.github.com/users/wildfly-security/repos","events_url":"https://api.github.com/users/wildfly-security/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security/received_events","type":"Organization","site_admin":false},"repo":{"id":13660977,"name":"wildfly-elytron","full_name":"wildfly-security/wildfly-elytron","owner":{"login":"wildfly-security","id":7501379,"avatar_url":"https://avatars1.githubusercontent.com/u/7501379?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security","html_url":"https://github.com/wildfly-security","followers_url":"https://api.github.com/users/wildfly-security/followers","following_url":"https://api.github.com/users/wildfly-security/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security/orgs","repos_url":"https://api.github.com/users/wildfly-security/repos","events_url":"https://api.github.com/users/wildfly-security/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-security/wildfly-elytron","description":"WildFly Elytron: Security, Authentication, and Authorization SPIs for the WildFly project","fork":false,"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron","forks_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/forks","keys_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/teams","hooks_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/hooks","issue_events_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/events","assignees_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/tags","blobs_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/languages","stargazers_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/stargazers","contributors_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/contributors","subscribers_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/subscribers","subscription_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/subscription","commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/merges","archive_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/downloads","issues_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/deployments","created_at":"2013-10-17T20:57:07Z","updated_at":"2017-03-30T15:11:31Z","pushed_at":"2017-04-05T17:01:26Z","git_url":"git://github.com/wildfly-security/wildfly-elytron.git","ssh_url":"git@github.com:wildfly-security/wildfly-elytron.git","clone_url":"https://github.com/wildfly-security/wildfly-elytron.git","svn_url":"https://github.com/wildfly-security/wildfly-elytron","homepage":"http://wildfly.org/","size":27258,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":12,"forks":46,"open_issues":12,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748"},"html":{"href":"https://github.com/wildfly-security/wildfly-elytron/pull/748"},"issue":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/748"},"comments":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/748/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/748/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/5c0497ca2292f80c0609e7ff64d11ab71c80f8f7"}}}}
{"actor":{"display_login":"darranl"}}