{"action":"created","comment":{"url":"https://api.github.com/repos/costela/wile/pulls/comments/100259606","pull_request_review_id":20955165,"id":100259606,"diff_hunk":"@@ -35,12 +39,12 @@ def cert():\n @click.option('--key-digest', metavar='DIGEST', default='sha256', show_default=True, help='The digest to use when signing the request with its key (must be supported by openssl)')\n @click.option('--min-valid-time', type=argtypes.TimespanType, metavar='TIMESPAN', default='1d', show_default=True, help='If a certificate is found and its expiration lies inside of this timespan, it will be automatically requested and overwritten; otherwise no request will be made. The format for this option is \"1d\" for one day. Supported units are hours, days and weeks.')\n @click.option('--force', is_flag=True, default=False, show_default=True, help='Whether to force a request to be made, even if a valid certificate is found')\n-@click.argument('domainroots', 'DOMAIN[:WEBROOT]', type=argtypes.DomainWebrootType, metavar='DOMAIN[:WEBROOT]', nargs=-1, required=True)\n+@click.argument('domainroots', '[USER@HOST[@PORT]:]DOMAIN[:WEBROOT]', type=argtypes.RemoteDomainWebrootType, metavar='[USER@HOST[@PORT]:]DOMAIN[:WEBROOT]', nargs=-1, required=True)","path":"cert.py","position":19,"original_position":19,"commit_id":"725c6aaf7aa2ed5207285ce5214e42ac3f9a5ab5","original_commit_id":"725c6aaf7aa2ed5207285ce5214e42ac3f9a5ab5","user":{"login":"costela","id":94699,"avatar_url":"https://avatars.githubusercontent.com/u/94699?v=3","gravatar_id":"","url":"https://api.github.com/users/costela","html_url":"https://github.com/costela","followers_url":"https://api.github.com/users/costela/followers","following_url":"https://api.github.com/users/costela/following{/other_user}","gists_url":"https://api.github.com/users/costela/gists{/gist_id}","starred_url":"https://api.github.com/users/costela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costela/subscriptions","organizations_url":"https://api.github.com/users/costela/orgs","repos_url":"https://api.github.com/users/costela/repos","events_url":"https://api.github.com/users/costela/events{/privacy}","received_events_url":"https://api.github.com/users/costela/received_events","type":"User","site_admin":false},"body":"Wouldn't `DOMAIN:[[[USER@]HOST[:PORT]:]WEBROOT]` make slightly more sense, when considering multiple domains on the same webroot?\r\nThis way we don't have to change `DomainWebrootType` (besides changing the `.split()` to `.split(..., 1)`) and can handle the difference between local and remote solely inside `_store_webroot_validation()`.","created_at":"2017-02-09T09:17:30Z","updated_at":"2017-02-09T09:27:33Z","html_url":"https://github.com/costela/wile/pull/5#discussion_r100259606","pull_request_url":"https://api.github.com/repos/costela/wile/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/costela/wile/pulls/comments/100259606"},"html":{"href":"https://github.com/costela/wile/pull/5#discussion_r100259606"},"pull_request":{"href":"https://api.github.com/repos/costela/wile/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/costela/wile/pulls/5","id":105238191,"html_url":"https://github.com/costela/wile/pull/5","diff_url":"https://github.com/costela/wile/pull/5.diff","patch_url":"https://github.com/costela/wile/pull/5.patch","issue_url":"https://api.github.com/repos/costela/wile/issues/5","number":5,"state":"open","locked":false,"title":"Added support for remote webroot validation","user":{"login":"lumatijev","id":5543101,"avatar_url":"https://avatars.githubusercontent.com/u/5543101?v=3","gravatar_id":"","url":"https://api.github.com/users/lumatijev","html_url":"https://github.com/lumatijev","followers_url":"https://api.github.com/users/lumatijev/followers","following_url":"https://api.github.com/users/lumatijev/following{/other_user}","gists_url":"https://api.github.com/users/lumatijev/gists{/gist_id}","starred_url":"https://api.github.com/users/lumatijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumatijev/subscriptions","organizations_url":"https://api.github.com/users/lumatijev/orgs","repos_url":"https://api.github.com/users/lumatijev/repos","events_url":"https://api.github.com/users/lumatijev/events{/privacy}","received_events_url":"https://api.github.com/users/lumatijev/received_events","type":"User","site_admin":false},"body":"When requesting new certificate one can now store webroot validation on\r\nremote host.\r\n\r\nScript now takes parameters like: [USER@HOST[@PORT]:]DOMAIN[:WEBROOT].\r\n\r\nAdded new dependency (pexpext) that is used for opening SSH connection\r\nand sending commands to remote host.\r\n\r\nAll the changes are backwards compatible.\r\n\r\nPlease test this before merge so that we can be sure there are no corner\r\ncases.","created_at":"2017-02-08T15:22:15Z","updated_at":"2017-02-09T09:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a419272e688d2f3fcfde0ff41fb75fc4f416a5af","assignee":{"login":"costela","id":94699,"avatar_url":"https://avatars.githubusercontent.com/u/94699?v=3","gravatar_id":"","url":"https://api.github.com/users/costela","html_url":"https://github.com/costela","followers_url":"https://api.github.com/users/costela/followers","following_url":"https://api.github.com/users/costela/following{/other_user}","gists_url":"https://api.github.com/users/costela/gists{/gist_id}","starred_url":"https://api.github.com/users/costela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costela/subscriptions","organizations_url":"https://api.github.com/users/costela/orgs","repos_url":"https://api.github.com/users/costela/repos","events_url":"https://api.github.com/users/costela/events{/privacy}","received_events_url":"https://api.github.com/users/costela/received_events","type":"User","site_admin":false},"assignees":[{"login":"costela","id":94699,"avatar_url":"https://avatars.githubusercontent.com/u/94699?v=3","gravatar_id":"","url":"https://api.github.com/users/costela","html_url":"https://github.com/costela","followers_url":"https://api.github.com/users/costela/followers","following_url":"https://api.github.com/users/costela/following{/other_user}","gists_url":"https://api.github.com/users/costela/gists{/gist_id}","starred_url":"https://api.github.com/users/costela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costela/subscriptions","organizations_url":"https://api.github.com/users/costela/orgs","repos_url":"https://api.github.com/users/costela/repos","events_url":"https://api.github.com/users/costela/events{/privacy}","received_events_url":"https://api.github.com/users/costela/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/costela/wile/pulls/5/commits","review_comments_url":"https://api.github.com/repos/costela/wile/pulls/5/comments","review_comment_url":"https://api.github.com/repos/costela/wile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/costela/wile/issues/5/comments","statuses_url":"https://api.github.com/repos/costela/wile/statuses/725c6aaf7aa2ed5207285ce5214e42ac3f9a5ab5","head":{"label":"lumatijev:master","ref":"master","sha":"725c6aaf7aa2ed5207285ce5214e42ac3f9a5ab5","user":{"login":"lumatijev","id":5543101,"avatar_url":"https://avatars.githubusercontent.com/u/5543101?v=3","gravatar_id":"","url":"https://api.github.com/users/lumatijev","html_url":"https://github.com/lumatijev","followers_url":"https://api.github.com/users/lumatijev/followers","following_url":"https://api.github.com/users/lumatijev/following{/other_user}","gists_url":"https://api.github.com/users/lumatijev/gists{/gist_id}","starred_url":"https://api.github.com/users/lumatijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumatijev/subscriptions","organizations_url":"https://api.github.com/users/lumatijev/orgs","repos_url":"https://api.github.com/users/lumatijev/repos","events_url":"https://api.github.com/users/lumatijev/events{/privacy}","received_events_url":"https://api.github.com/users/lumatijev/received_events","type":"User","site_admin":false},"repo":{"id":81342372,"name":"wile","full_name":"lumatijev/wile","owner":{"login":"lumatijev","id":5543101,"avatar_url":"https://avatars.githubusercontent.com/u/5543101?v=3","gravatar_id":"","url":"https://api.github.com/users/lumatijev","html_url":"https://github.com/lumatijev","followers_url":"https://api.github.com/users/lumatijev/followers","following_url":"https://api.github.com/users/lumatijev/following{/other_user}","gists_url":"https://api.github.com/users/lumatijev/gists{/gist_id}","starred_url":"https://api.github.com/users/lumatijev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumatijev/subscriptions","organizations_url":"https://api.github.com/users/lumatijev/orgs","repos_url":"https://api.github.com/users/lumatijev/repos","events_url":"https://api.github.com/users/lumatijev/events{/privacy}","received_events_url":"https://api.github.com/users/lumatijev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lumatijev/wile","description":"Stripped down letsencrypt (ACME) client","fork":true,"url":"https://api.github.com/repos/lumatijev/wile","forks_url":"https://api.github.com/repos/lumatijev/wile/forks","keys_url":"https://api.github.com/repos/lumatijev/wile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumatijev/wile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumatijev/wile/teams","hooks_url":"https://api.github.com/repos/lumatijev/wile/hooks","issue_events_url":"https://api.github.com/repos/lumatijev/wile/issues/events{/number}","events_url":"https://api.github.com/repos/lumatijev/wile/events","assignees_url":"https://api.github.com/repos/lumatijev/wile/assignees{/user}","branches_url":"https://api.github.com/repos/lumatijev/wile/branches{/branch}","tags_url":"https://api.github.com/repos/lumatijev/wile/tags","blobs_url":"https://api.github.com/repos/lumatijev/wile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumatijev/wile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumatijev/wile/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumatijev/wile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumatijev/wile/statuses/{sha}","languages_url":"https://api.github.com/repos/lumatijev/wile/languages","stargazers_url":"https://api.github.com/repos/lumatijev/wile/stargazers","contributors_url":"https://api.github.com/repos/lumatijev/wile/contributors","subscribers_url":"https://api.github.com/repos/lumatijev/wile/subscribers","subscription_url":"https://api.github.com/repos/lumatijev/wile/subscription","commits_url":"https://api.github.com/repos/lumatijev/wile/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumatijev/wile/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumatijev/wile/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumatijev/wile/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumatijev/wile/contents/{+path}","compare_url":"https://api.github.com/repos/lumatijev/wile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumatijev/wile/merges","archive_url":"https://api.github.com/repos/lumatijev/wile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumatijev/wile/downloads","issues_url":"https://api.github.com/repos/lumatijev/wile/issues{/number}","pulls_url":"https://api.github.com/repos/lumatijev/wile/pulls{/number}","milestones_url":"https://api.github.com/repos/lumatijev/wile/milestones{/number}","notifications_url":"https://api.github.com/repos/lumatijev/wile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumatijev/wile/labels{/name}","releases_url":"https://api.github.com/repos/lumatijev/wile/releases{/id}","deployments_url":"https://api.github.com/repos/lumatijev/wile/deployments","created_at":"2017-02-08T15:11:39Z","updated_at":"2017-02-08T15:11:41Z","pushed_at":"2017-02-08T15:32:34Z","git_url":"git://github.com/lumatijev/wile.git","ssh_url":"git@github.com:lumatijev/wile.git","clone_url":"https://github.com/lumatijev/wile.git","svn_url":"https://github.com/lumatijev/wile","homepage":"","size":30,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"costela:master","ref":"master","sha":"29a4e5f7303136cdd25fcfc43430960dd734612e","user":{"login":"costela","id":94699,"avatar_url":"https://avatars.githubusercontent.com/u/94699?v=3","gravatar_id":"","url":"https://api.github.com/users/costela","html_url":"https://github.com/costela","followers_url":"https://api.github.com/users/costela/followers","following_url":"https://api.github.com/users/costela/following{/other_user}","gists_url":"https://api.github.com/users/costela/gists{/gist_id}","starred_url":"https://api.github.com/users/costela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costela/subscriptions","organizations_url":"https://api.github.com/users/costela/orgs","repos_url":"https://api.github.com/users/costela/repos","events_url":"https://api.github.com/users/costela/events{/privacy}","received_events_url":"https://api.github.com/users/costela/received_events","type":"User","site_admin":false},"repo":{"id":61992315,"name":"wile","full_name":"costela/wile","owner":{"login":"costela","id":94699,"avatar_url":"https://avatars.githubusercontent.com/u/94699?v=3","gravatar_id":"","url":"https://api.github.com/users/costela","html_url":"https://github.com/costela","followers_url":"https://api.github.com/users/costela/followers","following_url":"https://api.github.com/users/costela/following{/other_user}","gists_url":"https://api.github.com/users/costela/gists{/gist_id}","starred_url":"https://api.github.com/users/costela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costela/subscriptions","organizations_url":"https://api.github.com/users/costela/orgs","repos_url":"https://api.github.com/users/costela/repos","events_url":"https://api.github.com/users/costela/events{/privacy}","received_events_url":"https://api.github.com/users/costela/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/costela/wile","description":"Stripped down letsencrypt (ACME) client","fork":false,"url":"https://api.github.com/repos/costela/wile","forks_url":"https://api.github.com/repos/costela/wile/forks","keys_url":"https://api.github.com/repos/costela/wile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/costela/wile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/costela/wile/teams","hooks_url":"https://api.github.com/repos/costela/wile/hooks","issue_events_url":"https://api.github.com/repos/costela/wile/issues/events{/number}","events_url":"https://api.github.com/repos/costela/wile/events","assignees_url":"https://api.github.com/repos/costela/wile/assignees{/user}","branches_url":"https://api.github.com/repos/costela/wile/branches{/branch}","tags_url":"https://api.github.com/repos/costela/wile/tags","blobs_url":"https://api.github.com/repos/costela/wile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/costela/wile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/costela/wile/git/refs{/sha}","trees_url":"https://api.github.com/repos/costela/wile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/costela/wile/statuses/{sha}","languages_url":"https://api.github.com/repos/costela/wile/languages","stargazers_url":"https://api.github.com/repos/costela/wile/stargazers","contributors_url":"https://api.github.com/repos/costela/wile/contributors","subscribers_url":"https://api.github.com/repos/costela/wile/subscribers","subscription_url":"https://api.github.com/repos/costela/wile/subscription","commits_url":"https://api.github.com/repos/costela/wile/commits{/sha}","git_commits_url":"https://api.github.com/repos/costela/wile/git/commits{/sha}","comments_url":"https://api.github.com/repos/costela/wile/comments{/number}","issue_comment_url":"https://api.github.com/repos/costela/wile/issues/comments{/number}","contents_url":"https://api.github.com/repos/costela/wile/contents/{+path}","compare_url":"https://api.github.com/repos/costela/wile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/costela/wile/merges","archive_url":"https://api.github.com/repos/costela/wile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/costela/wile/downloads","issues_url":"https://api.github.com/repos/costela/wile/issues{/number}","pulls_url":"https://api.github.com/repos/costela/wile/pulls{/number}","milestones_url":"https://api.github.com/repos/costela/wile/milestones{/number}","notifications_url":"https://api.github.com/repos/costela/wile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/costela/wile/labels{/name}","releases_url":"https://api.github.com/repos/costela/wile/releases{/id}","deployments_url":"https://api.github.com/repos/costela/wile/deployments","created_at":"2016-06-26T14:19:53Z","updated_at":"2016-12-22T13:47:46Z","pushed_at":"2017-02-08T15:32:36Z","git_url":"git://github.com/costela/wile.git","ssh_url":"git@github.com:costela/wile.git","clone_url":"https://github.com/costela/wile.git","svn_url":"https://github.com/costela/wile","homepage":"","size":28,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/costela/wile/pulls/5"},"html":{"href":"https://github.com/costela/wile/pull/5"},"issue":{"href":"https://api.github.com/repos/costela/wile/issues/5"},"comments":{"href":"https://api.github.com/repos/costela/wile/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/costela/wile/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/costela/wile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/costela/wile/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/costela/wile/statuses/725c6aaf7aa2ed5207285ce5214e42ac3f9a5ab5"}}}}
{"actor":{"display_login":"costela"}}