{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41295","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41295/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41295/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41295/events","html_url":"https://github.com/kubernetes/kubernetes/pull/41295","id":206993870,"number":41295,"title":"Use a dedicated key for service account token signing","user":{"login":"andrewrynhard","id":3383143,"avatar_url":"https://avatars.githubusercontent.com/u/3383143?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewrynhard","html_url":"https://github.com/andrewrynhard","followers_url":"https://api.github.com/users/andrewrynhard/followers","following_url":"https://api.github.com/users/andrewrynhard/following{/other_user}","gists_url":"https://api.github.com/users/andrewrynhard/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewrynhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewrynhard/subscriptions","organizations_url":"https://api.github.com/users/andrewrynhard/orgs","repos_url":"https://api.github.com/users/andrewrynhard/repos","events_url":"https://api.github.com/users/andrewrynhard/events{/privacy}","received_events_url":"https://api.github.com/users/andrewrynhard/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"assignees":[{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-02-11T17:15:41Z","updated_at":"2017-02-13T08:32:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41295","html_url":"https://github.com/kubernetes/kubernetes/pull/41295","diff_url":"https://github.com/kubernetes/kubernetes/pull/41295.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/41295.patch"},"body":"**What this PR does / why we need it**:\r\nSee https://github.com/kubernetes/kubeadm/issues/146\r\n\r\n**Special notes for your reviewer**:\r\n`pki_helpers.go` had to be refactored a bit to allow one-off cert/key generation.\r\n\r\n```\r\nbash-4.2# cat /etc/kubernetes/manifests/kube-apiserver.yaml | grep service-account\r\n    - --service-account-key-file=/etc/kubernetes/pki/sa.key\r\nbash-4.2# cat /etc/kubernetes/manifests/kube-controller-manager.yaml | grep service-account\r\n    - --service-account-private-key-file=/etc/kubernetes/pki/sa.key\r\nbash-4.2# ls /etc/kubernetes/pki/\r\napiserver.crt  apiserver-kubelet-client.crt  ca.crt  sa.key\r\napiserver.key  apiserver-kubelet-client.key  ca.key  tokens.csv\r\nbash-4.2# kubectl get pods -n kube-system\r\nNAME                                 READY     STATUS    RESTARTS   AGE\r\ndummy-2165365107-nt0xm               1/1       Running   0          11m\r\nkube-apiserver-k8s-master            1/1       Running   0          11m\r\nkube-controller-manager-k8s-master   1/1       Running   0          11m\r\nkube-discovery-2187510969-gp26r      1/1       Running   0          11m\r\nkube-dns-421332118-58tl8             3/3       Running   0          11m\r\nkube-flannel-ds-03cvf                2/2       Running   0          7m\r\nkube-flannel-ds-llxw5                2/2       Running   0          7m\r\nkube-proxy-j8jhz                     1/1       Running   0          11m\r\nkube-proxy-z761d                     1/1       Running   0          8m\r\nkube-scheduler-k8s-master            1/1       Running   0          11m\r\n```\r\n\r\n@luxas @liggitt @pires "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/279323252","html_url":"https://github.com/kubernetes/kubernetes/pull/41295#issuecomment-279323252","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41295","id":279323252,"user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T08:32:44Z","updated_at":"2017-02-13T08:32:44Z","body":"@k8s-bot ok to test\r\n\r\n@andrewrynhard Thanks, LGTM! But please add tests for the new functions that are created."}}
{"actor":{"display_login":"luxas"}}