{"action":"created","issue":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1330","repository_url":"https://api.github.com/repos/pyfa-org/Pyfa","labels_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1330/labels{/name}","comments_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1330/comments","events_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1330/events","html_url":"https://github.com/pyfa-org/Pyfa/issues/1330","id":269914986,"number":1330,"title":"Crash when deleting fitting","user":{"login":"twothe","id":1131621,"avatar_url":"https://avatars3.githubusercontent.com/u/1131621?v=4","gravatar_id":"","url":"https://api.github.com/users/twothe","html_url":"https://github.com/twothe","followers_url":"https://api.github.com/users/twothe/followers","following_url":"https://api.github.com/users/twothe/following{/other_user}","gists_url":"https://api.github.com/users/twothe/gists{/gist_id}","starred_url":"https://api.github.com/users/twothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twothe/subscriptions","organizations_url":"https://api.github.com/users/twothe/orgs","repos_url":"https://api.github.com/users/twothe/repos","events_url":"https://api.github.com/users/twothe/events{/privacy}","received_events_url":"https://api.github.com/users/twothe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-10-31T10:54:08Z","updated_at":"2017-11-07T15:33:45Z","closed_at":null,"author_association":"NONE","body":"I just deleted a fitting (with an open tab of that fitting), which caused a crash.\r\nI was not using any projections on or with that ship, but I did use projection in a different fitting of a different ship earlier (that fitting was neither deleted nor open nor was any projection still active).\r\n\r\n```\r\nOS version: \tWindows-8-6.2.9200\r\nPython: \t2.7.10\r\nwxPython: \t3.0.2.0\r\nSQLAlchemy: \t1.0.5\r\nLogbook: \t1.0.0\r\npyfa version: 1.33.1 Stable - Lifeblood 1.0\r\npyfa root: D:\\Games\\pyfa\r\nsave path: C:\\Users\\Two\\.pyfa\r\nfs encoding: mbcs\r\n\r\nEXCEPTION: Class '__builtin__.NoneType' is not mapped\r\n\r\n  File \"D:\\Games\\pyfa\\library.zip\\gui\\builtinShipBrowser\\sfBrowserItem.py\", line 333, in OnLeftUp\r\n    btn.DoCallback()\r\n  File \"D:\\Games\\pyfa\\library.zip\\gui\\builtinShipBrowser\\sfBrowserItem.py\", line 50, in DoCallback\r\n    self.callback()\r\n  File \"D:\\Games\\pyfa\\library.zip\\gui\\builtinShipBrowser\\fitItem.py\", line 351, in deleteBtnCB\r\n    self.deleteFit()\r\n  File \"D:\\Games\\pyfa\\library.zip\\gui\\builtinShipBrowser\\fitItem.py\", line 368, in deleteFit\r\n    sFit.deleteFit(self.fitID)\r\n  File \"D:\\Games\\pyfa\\library.zip\\service\\fit.py\", line 182, in deleteFit\r\n    if projection.victim_fit != fit and projection.victim_fit in eos.db.saveddata_session:  # GH issue #359\r\n  File \"C:\\python-2.7.10\\lib\\site-packages\\sqlalchemy\\orm\\session.py\", line 1956, in __contains__\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/comments/342519966","html_url":"https://github.com/pyfa-org/Pyfa/issues/1330#issuecomment-342519966","issue_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/1330","id":342519966,"user":{"login":"taleden","id":23055012,"avatar_url":"https://avatars0.githubusercontent.com/u/23055012?v=4","gravatar_id":"","url":"https://api.github.com/users/taleden","html_url":"https://github.com/taleden","followers_url":"https://api.github.com/users/taleden/followers","following_url":"https://api.github.com/users/taleden/following{/other_user}","gists_url":"https://api.github.com/users/taleden/gists{/gist_id}","starred_url":"https://api.github.com/users/taleden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taleden/subscriptions","organizations_url":"https://api.github.com/users/taleden/orgs","repos_url":"https://api.github.com/users/taleden/repos","events_url":"https://api.github.com/users/taleden/events{/privacy}","received_events_url":"https://api.github.com/users/taleden/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T15:33:45Z","updated_at":"2017-11-07T15:33:45Z","author_association":"NONE","body":"I've seen this crash pretty frequently while cleaning up duplicate fittings. I recently came back to the game and imported all my old EFT and Pyfa fittings into the latest Pyfa; since I previously kept the two somewhat in sync, this left me with many duplicates (two fits for the same hull with the same name).\r\n\r\nWhen I open two such fits, confirm that they have all the same modules and then delete one of them (while both are still among the opened fit tabs and one is the currently active fit), I sometimes (~25-50%?) get a crash with \"pyfa.exe has stopped working\" but no error or stack trace. I also tried running from source with the \"-d\" option and then the error is instead \"python.exe has stopped working\", but still no message or stack trace on screen or in the console log."}}
{"actor":{"display_login":"taleden"}}