{"action":"closed","number":10814,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/10814","id":111574085,"html_url":"https://github.com/elastic/kibana/pull/10814","diff_url":"https://github.com/elastic/kibana/pull/10814.diff","patch_url":"https://github.com/elastic/kibana/pull/10814.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/10814","number":10814,"state":"closed","locked":false,"title":"Nested object support in Discovery results","user":{"login":"ppadovani","id":11234684,"avatar_url":"https://avatars2.githubusercontent.com/u/11234684?v=4","gravatar_id":"","url":"https://api.github.com/users/ppadovani","html_url":"https://github.com/ppadovani","followers_url":"https://api.github.com/users/ppadovani/followers","following_url":"https://api.github.com/users/ppadovani/following{/other_user}","gists_url":"https://api.github.com/users/ppadovani/gists{/gist_id}","starred_url":"https://api.github.com/users/ppadovani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppadovani/subscriptions","organizations_url":"https://api.github.com/users/ppadovani/orgs","repos_url":"https://api.github.com/users/ppadovani/repos","events_url":"https://api.github.com/users/ppadovani/events{/privacy}","received_events_url":"https://api.github.com/users/ppadovani/received_events","type":"User","site_admin":false},"body":"- Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)? Yes\r\n- Have you followed the [contributor guidelines](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md)? Yes\r\n- If submitting code, have you included unit tests that cover the changes? Not yet, wanted to gather feedback prior.\r\n- If submitting code, have you tested and built your code locally prior to submission with `npm test && npm run build`? Yes\r\n- If submitting code, is your pull request against master? Yes - I also have a branch ready against 5.3\r\n\r\n@Bargs - FYI\r\n\r\nThis pull request provides Discovery UI support for nested objects. It will still allow filters to work for nested fields by figuring out the nested path based on how the data was displayed/structured in the response. This work is recursive and should support any number of levels of nested data.\r\n\r\nI could not see a good way to support the \"toggle column in table\" feature for nested fields in a way that made sense, so that feature is disabled for nested fields in this pull request.\r\n\r\nBelow are a set of screenshots that illustrate this support:\r\nTop level object with first level nested fields:\r\n![image](https://cloud.githubusercontent.com/assets/11234684/24105814/12dbb6a2-0d54-11e7-835a-b5638b2153b2.png)\r\n\r\nExpansion of first level nested field:\r\n![image](https://cloud.githubusercontent.com/assets/11234684/24105840/264eeca4-0d54-11e7-96df-3df989fe897f.png)\r\n\r\nExpansion of first entry in first level nested field:\r\n![image](https://cloud.githubusercontent.com/assets/11234684/24105872/3f0e4a3c-0d54-11e7-9967-23dfe05a8291.png)\r\n\r\nNested filter support:\r\n![image](https://cloud.githubusercontent.com/assets/11234684/24107628/42737d32-0d59-11e7-9ccf-f7f48e15d34c.png)\r\nIt would be nice in the nested filter support to 'alias' the filter/query in what is displayed, but I couldn't find a way to do it off hand.","created_at":"2017-03-20T15:08:36Z","updated_at":"2017-08-04T19:05:57Z","closed_at":"2017-08-04T19:05:57Z","merged_at":null,"merge_commit_sha":"8cf20c73753108be3552a022b6c138b55342e024","assignee":{"login":"Bargs","id":6239176,"avatar_url":"https://avatars3.githubusercontent.com/u/6239176?v=4","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false},"assignees":[{"login":"Bargs","id":6239176,"avatar_url":"https://avatars3.githubusercontent.com/u/6239176?v=4","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"weltenwort","id":973741,"avatar_url":"https://avatars3.githubusercontent.com/u/973741?v=4","gravatar_id":"","url":"https://api.github.com/users/weltenwort","html_url":"https://github.com/weltenwort","followers_url":"https://api.github.com/users/weltenwort/followers","following_url":"https://api.github.com/users/weltenwort/following{/other_user}","gists_url":"https://api.github.com/users/weltenwort/gists{/gist_id}","starred_url":"https://api.github.com/users/weltenwort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltenwort/subscriptions","organizations_url":"https://api.github.com/users/weltenwort/orgs","repos_url":"https://api.github.com/users/weltenwort/repos","events_url":"https://api.github.com/users/weltenwort/events{/privacy}","received_events_url":"https://api.github.com/users/weltenwort/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/10814/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/10814/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/10814/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/2f3b81caf9145294807b40af67670ae084cd1b0b","head":{"label":"homeaway:nestedSupportDiscovery","ref":"nestedSupportDiscovery","sha":"2f3b81caf9145294807b40af67670ae084cd1b0b","user":{"login":"homeaway","id":349558,"avatar_url":"https://avatars2.githubusercontent.com/u/349558?v=4","gravatar_id":"","url":"https://api.github.com/users/homeaway","html_url":"https://github.com/homeaway","followers_url":"https://api.github.com/users/homeaway/followers","following_url":"https://api.github.com/users/homeaway/following{/other_user}","gists_url":"https://api.github.com/users/homeaway/gists{/gist_id}","starred_url":"https://api.github.com/users/homeaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homeaway/subscriptions","organizations_url":"https://api.github.com/users/homeaway/orgs","repos_url":"https://api.github.com/users/homeaway/repos","events_url":"https://api.github.com/users/homeaway/events{/privacy}","received_events_url":"https://api.github.com/users/homeaway/received_events","type":"Organization","site_admin":false},"repo":{"id":46362454,"name":"kibana","full_name":"homeaway/kibana","owner":{"login":"homeaway","id":349558,"avatar_url":"https://avatars2.githubusercontent.com/u/349558?v=4","gravatar_id":"","url":"https://api.github.com/users/homeaway","html_url":"https://github.com/homeaway","followers_url":"https://api.github.com/users/homeaway/followers","following_url":"https://api.github.com/users/homeaway/following{/other_user}","gists_url":"https://api.github.com/users/homeaway/gists{/gist_id}","starred_url":"https://api.github.com/users/homeaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homeaway/subscriptions","organizations_url":"https://api.github.com/users/homeaway/orgs","repos_url":"https://api.github.com/users/homeaway/repos","events_url":"https://api.github.com/users/homeaway/events{/privacy}","received_events_url":"https://api.github.com/users/homeaway/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/homeaway/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/homeaway/kibana","forks_url":"https://api.github.com/repos/homeaway/kibana/forks","keys_url":"https://api.github.com/repos/homeaway/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homeaway/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homeaway/kibana/teams","hooks_url":"https://api.github.com/repos/homeaway/kibana/hooks","issue_events_url":"https://api.github.com/repos/homeaway/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/homeaway/kibana/events","assignees_url":"https://api.github.com/repos/homeaway/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/homeaway/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/homeaway/kibana/tags","blobs_url":"https://api.github.com/repos/homeaway/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homeaway/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homeaway/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/homeaway/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homeaway/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/homeaway/kibana/languages","stargazers_url":"https://api.github.com/repos/homeaway/kibana/stargazers","contributors_url":"https://api.github.com/repos/homeaway/kibana/contributors","subscribers_url":"https://api.github.com/repos/homeaway/kibana/subscribers","subscription_url":"https://api.github.com/repos/homeaway/kibana/subscription","commits_url":"https://api.github.com/repos/homeaway/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/homeaway/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/homeaway/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/homeaway/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/homeaway/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/homeaway/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homeaway/kibana/merges","archive_url":"https://api.github.com/repos/homeaway/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homeaway/kibana/downloads","issues_url":"https://api.github.com/repos/homeaway/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/homeaway/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/homeaway/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/homeaway/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homeaway/kibana/labels{/name}","releases_url":"https://api.github.com/repos/homeaway/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/homeaway/kibana/deployments","created_at":"2015-11-17T17:09:51Z","updated_at":"2017-02-15T13:31:50Z","pushed_at":"2017-05-17T15:43:05Z","git_url":"git://github.com/homeaway/kibana.git","ssh_url":"git@github.com:homeaway/kibana.git","clone_url":"https://github.com/homeaway/kibana.git","svn_url":"https://github.com/homeaway/kibana","homepage":"https://www.elastic.co/products/kibana","size":225886,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":13,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"be2cb4b994eb0be618718d411d9cd6e5cb22fa9e","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-08-04T07:04:48Z","pushed_at":"2017-08-04T19:00:19Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":279982,"stargazers_count":7749,"watchers_count":7749,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2994,"mirror_url":null,"open_issues_count":1961,"forks":2994,"open_issues":1961,"watchers":7749,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10814"},"html":{"href":"https://github.com/elastic/kibana/pull/10814"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/10814"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/10814/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10814/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10814/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/2f3b81caf9145294807b40af67670ae084cd1b0b"}},"merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":174,"deletions":32,"changed_files":6}}
{"actor":{"display_login":"Bargs"}}