{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/148940625","pull_request_review_id":74264818,"id":148940625,"diff_hunk":"@@ -109,6 +109,41 @@ func TestCompileManifests(t *testing.T) {\n \t\t\t},\n \t\t\texpected: true,\n \t\t},\n+\t\t{\n+\t\t\tmanifest: CoreDNSDeployment,\n+\t\t\tdata: struct{ MasterTaintKey, Version string }{\n+\t\t\t\tMasterTaintKey: \"foo\",\n+\t\t\t\tVersion:        \"foo\",\n+\t\t\t},\n+\t\t\texpected: true,\n+\t\t},\n+\t\t{\n+\t\t\tmanifest: KubeDNSService,\n+\t\t\tdata: struct{ DNSIP string }{\n+\t\t\t\tDNSIP: \"foo\",\n+\t\t\t},\n+\t\t\texpected: true,\n+\t\t},\n+\t\t{\n+\t\t\tmanifest: CoreDNSConfigMap,\n+\t\t\tdata: struct{ DNSDomain, ServiceCIDR string }{\n+\t\t\t\tDNSDomain:   \"foo\",\n+\t\t\t\tServiceCIDR: \"foo\",\n+\t\t\t},\n+\t\t\texpected: true,\n+\t\t},\n+\t\t{\n+\t\t\tmanifest: CoreDNSClusterRole,\n+\t\t\texpected: true,\n+\t\t},\n+\t\t{\n+\t\t\tmanifest: CoreDNSClusterRoleBinding,","path":"cmd/kubeadm/app/phases/addons/dns/dns_test.go","position":32,"original_position":32,"commit_id":"604ce464147cbee616b128ce9c75fa2e7680aea9","original_commit_id":"604ce464147cbee616b128ce9c75fa2e7680aea9","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"this unit test is not needed as it is not a template\r\n","created_at":"2017-11-04T20:32:04Z","updated_at":"2017-11-04T20:34:04Z","html_url":"https://github.com/kubernetes/kubernetes/pull/52501#discussion_r148940625","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/148940625"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/52501#discussion_r148940625"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501","id":141165032,"html_url":"https://github.com/kubernetes/kubernetes/pull/52501","diff_url":"https://github.com/kubernetes/kubernetes/pull/52501.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/52501.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52501","number":52501,"state":"open","locked":false,"title":"Add CoreDNS as feature in kubeadm","user":{"login":"rajansandeep","id":30265084,"avatar_url":"https://avatars2.githubusercontent.com/u/30265084?v=4","gravatar_id":"","url":"https://api.github.com/users/rajansandeep","html_url":"https://github.com/rajansandeep","followers_url":"https://api.github.com/users/rajansandeep/followers","following_url":"https://api.github.com/users/rajansandeep/following{/other_user}","gists_url":"https://api.github.com/users/rajansandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansandeep/subscriptions","organizations_url":"https://api.github.com/users/rajansandeep/orgs","repos_url":"https://api.github.com/users/rajansandeep/repos","events_url":"https://api.github.com/users/rajansandeep/events{/privacy}","received_events_url":"https://api.github.com/users/rajansandeep/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR adds CoreDNS as a DNS plugin via the feature-gate option in Kubeadm init.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: \r\nFixes kubernetes/features#427\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nkubeadm: Add an experimental mode to deploy CoreDNS instead of KubeDNS\r\n```\r\n/cc @johnbelamaric","created_at":"2017-09-14T20:06:08Z","updated_at":"2017-11-04T20:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be301ece4a925e99f7c7c226047ff41f9c60a872","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/35","html_url":"https://github.com/kubernetes/kubernetes/milestone/35","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/35/labels","id":2422217,"number":35,"title":"v1.9","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":83,"state":"open","created_at":"2017-03-30T14:12:39Z","updated_at":"2017-11-03T21:15:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52501/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/604ce464147cbee616b128ce9c75fa2e7680aea9","head":{"label":"rajansandeep:featurecoredns","ref":"featurecoredns","sha":"604ce464147cbee616b128ce9c75fa2e7680aea9","user":{"login":"rajansandeep","id":30265084,"avatar_url":"https://avatars2.githubusercontent.com/u/30265084?v=4","gravatar_id":"","url":"https://api.github.com/users/rajansandeep","html_url":"https://github.com/rajansandeep","followers_url":"https://api.github.com/users/rajansandeep/followers","following_url":"https://api.github.com/users/rajansandeep/following{/other_user}","gists_url":"https://api.github.com/users/rajansandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansandeep/subscriptions","organizations_url":"https://api.github.com/users/rajansandeep/orgs","repos_url":"https://api.github.com/users/rajansandeep/repos","events_url":"https://api.github.com/users/rajansandeep/events{/privacy}","received_events_url":"https://api.github.com/users/rajansandeep/received_events","type":"User","site_admin":false},"repo":{"id":101199459,"name":"kubernetes","full_name":"rajansandeep/kubernetes","owner":{"login":"rajansandeep","id":30265084,"avatar_url":"https://avatars2.githubusercontent.com/u/30265084?v=4","gravatar_id":"","url":"https://api.github.com/users/rajansandeep","html_url":"https://github.com/rajansandeep","followers_url":"https://api.github.com/users/rajansandeep/followers","following_url":"https://api.github.com/users/rajansandeep/following{/other_user}","gists_url":"https://api.github.com/users/rajansandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansandeep/subscriptions","organizations_url":"https://api.github.com/users/rajansandeep/orgs","repos_url":"https://api.github.com/users/rajansandeep/repos","events_url":"https://api.github.com/users/rajansandeep/events{/privacy}","received_events_url":"https://api.github.com/users/rajansandeep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajansandeep/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/rajansandeep/kubernetes","forks_url":"https://api.github.com/repos/rajansandeep/kubernetes/forks","keys_url":"https://api.github.com/repos/rajansandeep/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajansandeep/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajansandeep/kubernetes/teams","hooks_url":"https://api.github.com/repos/rajansandeep/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/rajansandeep/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/rajansandeep/kubernetes/events","assignees_url":"https://api.github.com/repos/rajansandeep/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/rajansandeep/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/rajansandeep/kubernetes/tags","blobs_url":"https://api.github.com/repos/rajansandeep/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajansandeep/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajansandeep/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajansandeep/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajansandeep/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/rajansandeep/kubernetes/languages","stargazers_url":"https://api.github.com/repos/rajansandeep/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/rajansandeep/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/rajansandeep/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/rajansandeep/kubernetes/subscription","commits_url":"https://api.github.com/repos/rajansandeep/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajansandeep/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajansandeep/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajansandeep/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajansandeep/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/rajansandeep/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajansandeep/kubernetes/merges","archive_url":"https://api.github.com/repos/rajansandeep/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajansandeep/kubernetes/downloads","issues_url":"https://api.github.com/repos/rajansandeep/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/rajansandeep/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/rajansandeep/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/rajansandeep/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajansandeep/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/rajansandeep/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/rajansandeep/kubernetes/deployments","created_at":"2017-08-23T16:01:37Z","updated_at":"2017-08-23T16:02:19Z","pushed_at":"2017-11-03T22:13:30Z","git_url":"git://github.com/rajansandeep/kubernetes.git","ssh_url":"git@github.com:rajansandeep/kubernetes.git","clone_url":"https://github.com/rajansandeep/kubernetes.git","svn_url":"https://github.com/rajansandeep/kubernetes","homepage":"http://kubernetes.io","size":511892,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"fcf9b1f7e5c2012a896f8b9c18d7131866ad2625","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-11-04T19:08:53Z","pushed_at":"2017-11-04T19:35:02Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":733325,"stargazers_count":28485,"watchers_count":28485,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10183,"mirror_url":null,"archived":false,"open_issues_count":5480,"forks":10183,"open_issues":5480,"watchers":28485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/52501"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/52501"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/52501/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52501/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/604ce464147cbee616b128ce9c75fa2e7680aea9"}},"author_association":"NONE"}}
{"actor":{"display_login":"luxas"}}