{"action":"created","comment":{"url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments/131348834","pull_request_review_id":54320308,"id":131348834,"diff_hunk":"@@ -210,12 +316,26 @@ def setup_dump(self, pickup=False):\n             field = Function(functionspaceimpl.WithGeometry(f.function_space(), mesh_ll), val=f.topological, name=name+'_ll')\n             self.to_dump_latlon.append(field)\n \n-    def dump(self, t=0, diagnostic_everydump=False, pickup=False):\n+        # we create new netcdf files to write to, unless pickup=True, in\n+        # which case we just need the filenames\n+        diagnostics_filename = self.dumpdir+\"/diagnostics.nc\"\n+\n+        pointdata_filename = self.dumpdir+\"/point_data.nc\"\n+\n+        self.pointdata_output = PointDataOutput(pointdata_filename,\n+                                                self.output.point_data,\n+                                                self.output.dirname,\n+                                                self.fields,\n+                                                create=not pickup)\n+        self.diagnostic_output = DiagnosticsOutput(diagnostics_filename,\n+                                                   self.diagnostics,\n+                                                   self.output.dirname,\n+                                                   create=not pickup)","path":"gusto/state.py","position":157,"original_position":157,"commit_id":"04a4444fd005ec43228d3f2fb46918c48b57d10b","original_commit_id":"04a4444fd005ec43228d3f2fb46918c48b57d10b","user":{"login":"wence-","id":1126981,"avatar_url":"https://avatars2.githubusercontent.com/u/1126981?v=4","gravatar_id":"","url":"https://api.github.com/users/wence-","html_url":"https://github.com/wence-","followers_url":"https://api.github.com/users/wence-/followers","following_url":"https://api.github.com/users/wence-/following{/other_user}","gists_url":"https://api.github.com/users/wence-/gists{/gist_id}","starred_url":"https://api.github.com/users/wence-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wence-/subscriptions","organizations_url":"https://api.github.com/users/wence-/orgs","repos_url":"https://api.github.com/users/wence-/repos","events_url":"https://api.github.com/users/wence-/events{/privacy}","received_events_url":"https://api.github.com/users/wence-/received_events","type":"User","site_admin":false},"body":"This is basically just attempting to make a smaller handbag...","created_at":"2017-08-04T09:25:16Z","updated_at":"2017-08-04T09:25:16Z","html_url":"https://github.com/firedrakeproject/gusto/pull/116#discussion_r131348834","pull_request_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments/131348834"},"html":{"href":"https://github.com/firedrakeproject/gusto/pull/116#discussion_r131348834"},"pull_request":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116","id":130000607,"html_url":"https://github.com/firedrakeproject/gusto/pull/116","diff_url":"https://github.com/firedrakeproject/gusto/pull/116.diff","patch_url":"https://github.com/firedrakeproject/gusto/pull/116.patch","issue_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/116","number":116,"state":"open","locked":false,"title":"added option to output data at points","user":{"login":"jshipton","id":6875594,"avatar_url":"https://avatars2.githubusercontent.com/u/6875594?v=4","gravatar_id":"","url":"https://api.github.com/users/jshipton","html_url":"https://github.com/jshipton","followers_url":"https://api.github.com/users/jshipton/followers","following_url":"https://api.github.com/users/jshipton/following{/other_user}","gists_url":"https://api.github.com/users/jshipton/gists{/gist_id}","starred_url":"https://api.github.com/users/jshipton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshipton/subscriptions","organizations_url":"https://api.github.com/users/jshipton/orgs","repos_url":"https://api.github.com/users/jshipton/repos","events_url":"https://api.github.com/users/jshipton/events{/privacy}","received_events_url":"https://api.github.com/users/jshipton/received_events","type":"User","site_admin":false},"body":"This PR adds the option to output fields at points. This is done by passing `point_data` to the OutputParameters class. `point_data` is a dictionary of the form `{field_name: points}` where `points` is a list of coordinate points acceptable to the Firedrake `at` function. The data is output to a point_data.json file in the results/dirname directory, in the form `{field_name:{time: list_of_data_at_points}}`. There is a corresponding option `output.pointwise_everydump` to dump this dictionary at every timestep, rather than waiting until the end of the simulation. I have also moved the `diagnostic_everydump` option to the OutputParameters class.","created_at":"2017-07-11T20:40:36Z","updated_at":"2017-08-04T09:25:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27e552db05f705d88bda55ee4c3c2ca871ad660f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116/commits","review_comments_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116/comments","review_comment_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/116/comments","statuses_url":"https://api.github.com/repos/firedrakeproject/gusto/statuses/04a4444fd005ec43228d3f2fb46918c48b57d10b","head":{"label":"firedrakeproject:output_at_points","ref":"output_at_points","sha":"04a4444fd005ec43228d3f2fb46918c48b57d10b","user":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":49564954,"name":"gusto","full_name":"firedrakeproject/gusto","owner":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firedrakeproject/gusto","description":"Three dimensional atmospheric dynamical core using the Gung Ho numerics.","fork":false,"url":"https://api.github.com/repos/firedrakeproject/gusto","forks_url":"https://api.github.com/repos/firedrakeproject/gusto/forks","keys_url":"https://api.github.com/repos/firedrakeproject/gusto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/gusto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/gusto/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/gusto/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/gusto/events","assignees_url":"https://api.github.com/repos/firedrakeproject/gusto/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/gusto/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/gusto/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/gusto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/gusto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/gusto/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/gusto/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/gusto/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/gusto/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/gusto/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/gusto/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/gusto/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/gusto/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/gusto/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/gusto/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/gusto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/gusto/merges","archive_url":"https://api.github.com/repos/firedrakeproject/gusto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/gusto/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/gusto/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/gusto/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/gusto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/gusto/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/gusto/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/gusto/deployments","created_at":"2016-01-13T09:51:17Z","updated_at":"2017-05-29T13:35:56Z","pushed_at":"2017-08-04T09:24:43Z","git_url":"git://github.com/firedrakeproject/gusto.git","ssh_url":"git@github.com:firedrakeproject/gusto.git","clone_url":"https://github.com/firedrakeproject/gusto.git","svn_url":"https://github.com/firedrakeproject/gusto","homepage":"http://firedrakeproject.org/gusto/","size":4580,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":24,"forks":0,"open_issues":24,"watchers":1,"default_branch":"master"}},"base":{"label":"firedrakeproject:master","ref":"master","sha":"d34053c2e9c0f38d70e58ff0510cb49df79f7128","user":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":49564954,"name":"gusto","full_name":"firedrakeproject/gusto","owner":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firedrakeproject/gusto","description":"Three dimensional atmospheric dynamical core using the Gung Ho numerics.","fork":false,"url":"https://api.github.com/repos/firedrakeproject/gusto","forks_url":"https://api.github.com/repos/firedrakeproject/gusto/forks","keys_url":"https://api.github.com/repos/firedrakeproject/gusto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/gusto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/gusto/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/gusto/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/gusto/events","assignees_url":"https://api.github.com/repos/firedrakeproject/gusto/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/gusto/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/gusto/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/gusto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/gusto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/gusto/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/gusto/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/gusto/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/gusto/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/gusto/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/gusto/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/gusto/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/gusto/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/gusto/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/gusto/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/gusto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/gusto/merges","archive_url":"https://api.github.com/repos/firedrakeproject/gusto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/gusto/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/gusto/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/gusto/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/gusto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/gusto/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/gusto/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/gusto/deployments","created_at":"2016-01-13T09:51:17Z","updated_at":"2017-05-29T13:35:56Z","pushed_at":"2017-08-04T09:24:43Z","git_url":"git://github.com/firedrakeproject/gusto.git","ssh_url":"git@github.com:firedrakeproject/gusto.git","clone_url":"https://github.com/firedrakeproject/gusto.git","svn_url":"https://github.com/firedrakeproject/gusto","homepage":"http://firedrakeproject.org/gusto/","size":4580,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":24,"forks":0,"open_issues":24,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116"},"html":{"href":"https://github.com/firedrakeproject/gusto/pull/116"},"issue":{"href":"https://api.github.com/repos/firedrakeproject/gusto/issues/116"},"comments":{"href":"https://api.github.com/repos/firedrakeproject/gusto/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/firedrakeproject/gusto/statuses/04a4444fd005ec43228d3f2fb46918c48b57d10b"}}}}
{"actor":{"display_login":"wence-"}}