{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/comments/151490753","pull_request_review_id":77207735,"id":151490753,"diff_hunk":"@@ -0,0 +1,8 @@\n+FROM golang:1.9-alpine\n+\n+ADD https://github.com/golang/dep/releases/download/v0.3.2/dep-linux-amd64 /usr/local/bin/dep\n+\n+RUN chmod +x /usr/local/bin/dep\n+\n+RUN apk add --update git && rm -rf /var/cache/apk/*\n+RUN go get github.com/onsi/ginkgo/ginkgo","path":"go/Dockerfile","position":8,"original_position":8,"commit_id":"5e3803f0db26c49f7ee065a6b07f9383b7664067","original_commit_id":"5e3803f0db26c49f7ee065a6b07f9383b7664067","user":{"login":"camelpunch","id":141733,"avatar_url":"https://avatars3.githubusercontent.com/u/141733?v=4","gravatar_id":"","url":"https://api.github.com/users/camelpunch","html_url":"https://github.com/camelpunch","followers_url":"https://api.github.com/users/camelpunch/followers","following_url":"https://api.github.com/users/camelpunch/following{/other_user}","gists_url":"https://api.github.com/users/camelpunch/gists{/gist_id}","starred_url":"https://api.github.com/users/camelpunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camelpunch/subscriptions","organizations_url":"https://api.github.com/users/camelpunch/orgs","repos_url":"https://api.github.com/users/camelpunch/repos","events_url":"https://api.github.com/users/camelpunch/events{/privacy}","received_events_url":"https://api.github.com/users/camelpunch/received_events","type":"User","site_admin":false},"body":"So my take is that we should remove ginkgo from here and encourage people to use the binary that corresponds to the version they've vendored. We can do that either by saying \"use `go test`\" or by saying \"`go install` your ginkgo binary from your vendor dir\". Whether or not the vendor dir is committed is a separate issue I think.","created_at":"2017-11-16T17:57:18Z","updated_at":"2017-11-16T17:57:18Z","html_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools/pull/102#discussion_r151490753","pull_request_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/comments/151490753"},"html":{"href":"https://github.com/alphagov/paas-docker-cloudfoundry-tools/pull/102#discussion_r151490753"},"pull_request":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102"}},"in_reply_to_id":151475270},"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102","id":153094373,"html_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools/pull/102","diff_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools/pull/102.diff","patch_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools/pull/102.patch","issue_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/102","number":102,"state":"open","locked":false,"title":"[#152670228] Add go image","user":{"login":"henrytk","id":8709339,"avatar_url":"https://avatars2.githubusercontent.com/u/8709339?v=4","gravatar_id":"","url":"https://api.github.com/users/henrytk","html_url":"https://github.com/henrytk","followers_url":"https://api.github.com/users/henrytk/followers","following_url":"https://api.github.com/users/henrytk/following{/other_user}","gists_url":"https://api.github.com/users/henrytk/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytk/subscriptions","organizations_url":"https://api.github.com/users/henrytk/orgs","repos_url":"https://api.github.com/users/henrytk/repos","events_url":"https://api.github.com/users/henrytk/events{/privacy}","received_events_url":"https://api.github.com/users/henrytk/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nThis is a generic image for running Go programs. It contains `dep`\r\nand `ginkgo`.\r\n\r\nWe initially intend to use this for the integration tests for the Elasticache broker (https://www.pivotaltracker.com/story/show/152670228)\r\n\r\n## How to review\r\n\r\nCheck it is set up as per the README. Confirm the need to create such an image is justified.\r\n\r\n## Who\r\n\r\nAnyone but me or @camelpunch ","created_at":"2017-11-16T16:53:19Z","updated_at":"2017-11-16T17:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb8351fc4109e8b68f2452306310d2bcd8072354","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102/commits","review_comments_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102/comments","review_comment_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/102/comments","statuses_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/statuses/5e3803f0db26c49f7ee065a6b07f9383b7664067","head":{"label":"alphagov:add-go","ref":"add-go","sha":"5e3803f0db26c49f7ee065a6b07f9383b7664067","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47132986,"name":"paas-docker-cloudfoundry-tools","full_name":"alphagov/paas-docker-cloudfoundry-tools","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools","forks_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/forks","keys_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/events","assignees_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/merges","archive_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/deployments","created_at":"2015-11-30T16:58:24Z","updated_at":"2017-05-12T09:31:18Z","pushed_at":"2017-11-16T16:57:35Z","git_url":"git://github.com/alphagov/paas-docker-cloudfoundry-tools.git","ssh_url":"git@github.com:alphagov/paas-docker-cloudfoundry-tools.git","clone_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools.git","svn_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools","homepage":null,"size":181,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":10,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f804160a7e6f455ef206b56eab25063908703dd5","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47132986,"name":"paas-docker-cloudfoundry-tools","full_name":"alphagov/paas-docker-cloudfoundry-tools","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools","forks_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/forks","keys_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/events","assignees_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/merges","archive_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/deployments","created_at":"2015-11-30T16:58:24Z","updated_at":"2017-05-12T09:31:18Z","pushed_at":"2017-11-16T16:57:35Z","git_url":"git://github.com/alphagov/paas-docker-cloudfoundry-tools.git","ssh_url":"git@github.com:alphagov/paas-docker-cloudfoundry-tools.git","clone_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools.git","svn_url":"https://github.com/alphagov/paas-docker-cloudfoundry-tools","homepage":null,"size":181,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102"},"html":{"href":"https://github.com/alphagov/paas-docker-cloudfoundry-tools/pull/102"},"issue":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/102"},"comments":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/paas-docker-cloudfoundry-tools/statuses/5e3803f0db26c49f7ee065a6b07f9383b7664067"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"camelpunch"}}