{"action":"created","issue":{"url":"https://api.github.com/repos/translationCoreApps/ScripturePane/issues/73","repository_url":"https://api.github.com/repos/translationCoreApps/ScripturePane","labels_url":"https://api.github.com/repos/translationCoreApps/ScripturePane/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/translationCoreApps/ScripturePane/issues/73/comments","events_url":"https://api.github.com/repos/translationCoreApps/ScripturePane/issues/73/events","html_url":"https://github.com/translationCoreApps/ScripturePane/pull/73","id":273583107,"number":73,"title":"Feature - #2843 - Makes it obvious when Greek text not available","user":{"login":"richmahn","id":2839925,"avatar_url":"https://avatars0.githubusercontent.com/u/2839925?v=4","gravatar_id":"","url":"https://api.github.com/users/richmahn","html_url":"https://github.com/richmahn","followers_url":"https://api.github.com/users/richmahn/followers","following_url":"https://api.github.com/users/richmahn/following{/other_user}","gists_url":"https://api.github.com/users/richmahn/gists{/gist_id}","starred_url":"https://api.github.com/users/richmahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richmahn/subscriptions","organizations_url":"https://api.github.com/users/richmahn/orgs","repos_url":"https://api.github.com/users/richmahn/repos","events_url":"https://api.github.com/users/richmahn/events{/privacy}","received_events_url":"https://api.github.com/users/richmahn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-13T21:25:24Z","updated_at":"2017-11-15T18:21:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/translationCoreApps/ScripturePane/pulls/73","html_url":"https://github.com/translationCoreApps/ScripturePane/pull/73","diff_url":"https://github.com/translationCoreApps/ScripturePane/pull/73.diff","patch_url":"https://github.com/translationCoreApps/ScripturePane/pull/73.patch"},"body":"#### This pull request addresses:\r\n\r\nAddress issue https://github.com/unfoldingWord-dev/translationCore/issues/2843. It actually addresses any verse missing from any Bible translation. \r\n\r\n**NOTE:** This also moves the PLACE HOLDER (i.e. warning text) constant into the Verse component rather than components that render Verse to set the text, but rather just pass `null` and Verse.js checks if it is null and displays the warning. This is because 1) two places were setting the place holder and 2) Verse needs to know it is a place holder so it can style it correctly.\r\n\r\n\r\n#### How to test this pull request:\r\n\r\n1) Load a project of a book other than Titus. Go into tW tool and you should see for any verse the Greek column says \"[WARNING: This Bible version does not include text for this reference.]\"\r\n\r\n2) Remove/rename the the `~/translationCore/resources/en/bibles/ulb/v11/tit` directory from your home directory. Reload the tC app, load a Titus project, go into tW tool for that project, load the resource in the Scripture Pane if not already, and it also should give you the warning.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/translationcoreapps/scripturepane/73)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/translationCoreApps/ScripturePane/issues/comments/344682424","html_url":"https://github.com/translationCoreApps/ScripturePane/pull/73#issuecomment-344682424","issue_url":"https://api.github.com/repos/translationCoreApps/ScripturePane/issues/73","id":344682424,"user":{"login":"PhotoNomad0","id":14238574,"avatar_url":"https://avatars3.githubusercontent.com/u/14238574?v=4","gravatar_id":"","url":"https://api.github.com/users/PhotoNomad0","html_url":"https://github.com/PhotoNomad0","followers_url":"https://api.github.com/users/PhotoNomad0/followers","following_url":"https://api.github.com/users/PhotoNomad0/following{/other_user}","gists_url":"https://api.github.com/users/PhotoNomad0/gists{/gist_id}","starred_url":"https://api.github.com/users/PhotoNomad0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhotoNomad0/subscriptions","organizations_url":"https://api.github.com/users/PhotoNomad0/orgs","repos_url":"https://api.github.com/users/PhotoNomad0/repos","events_url":"https://api.github.com/users/PhotoNomad0/events{/privacy}","received_events_url":"https://api.github.com/users/PhotoNomad0/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T18:21:45Z","updated_at":"2017-11-15T18:21:45Z","author_association":"NONE","body":"Was able to reproduce the warning.\r\n\r\n:lgtm:"}}
{"actor":{"display_login":"PhotoNomad0"}}