{"action":"closed","number":3956,"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/3956","id":107240925,"html_url":"https://github.com/druid-io/druid/pull/3956","diff_url":"https://github.com/druid-io/druid/pull/3956.diff","patch_url":"https://github.com/druid-io/druid/pull/3956.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/3956","number":3956,"state":"closed","locked":false,"title":"Thread safe reads for aggregators in IncrementalIndex","user":{"login":"nishantmonu51","id":5023786,"avatar_url":"https://avatars.githubusercontent.com/u/5023786?v=3","gravatar_id":"","url":"https://api.github.com/users/nishantmonu51","html_url":"https://github.com/nishantmonu51","followers_url":"https://api.github.com/users/nishantmonu51/followers","following_url":"https://api.github.com/users/nishantmonu51/following{/other_user}","gists_url":"https://api.github.com/users/nishantmonu51/gists{/gist_id}","starred_url":"https://api.github.com/users/nishantmonu51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishantmonu51/subscriptions","organizations_url":"https://api.github.com/users/nishantmonu51/orgs","repos_url":"https://api.github.com/users/nishantmonu51/repos","events_url":"https://api.github.com/users/nishantmonu51/events{/privacy}","received_events_url":"https://api.github.com/users/nishantmonu51/received_events","type":"User","site_admin":false},"body":"Aggregators are *NOT* thread safe and if two threads concurrently try\r\nto read/write to the aggregator the reader may read absurd values since\r\nthe aggregate method is not *atomic*.\r\n\r\nIn case of IncrementalIndex the writes are protected by a sync block\r\nbut the reads are unprotected, so its possible for the queries to read\r\nabsurd values in aggregator.get().\r\n\r\nThis PR adds a test that can reproduce that behavior by wrapping\r\nAggregators inside a ThreadSafetyAssertionAggregator.\r\n\r\nTODO: test any performance impacts.","created_at":"2017-02-21T17:39:45Z","updated_at":"2017-02-21T17:52:16Z","closed_at":"2017-02-21T17:52:16Z","merged_at":null,"merge_commit_sha":"e611cd681607d534fcd9dffbf6d458145242a025","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/3956/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/3956/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/3956/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/8e2e67002d90afc406a6dacaf36f8074296e7f9d","head":{"label":"nishantmonu51:test-concurrency","ref":"test-concurrency","sha":"8e2e67002d90afc406a6dacaf36f8074296e7f9d","user":{"login":"nishantmonu51","id":5023786,"avatar_url":"https://avatars.githubusercontent.com/u/5023786?v=3","gravatar_id":"","url":"https://api.github.com/users/nishantmonu51","html_url":"https://github.com/nishantmonu51","followers_url":"https://api.github.com/users/nishantmonu51/followers","following_url":"https://api.github.com/users/nishantmonu51/following{/other_user}","gists_url":"https://api.github.com/users/nishantmonu51/gists{/gist_id}","starred_url":"https://api.github.com/users/nishantmonu51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishantmonu51/subscriptions","organizations_url":"https://api.github.com/users/nishantmonu51/orgs","repos_url":"https://api.github.com/users/nishantmonu51/repos","events_url":"https://api.github.com/users/nishantmonu51/events{/privacy}","received_events_url":"https://api.github.com/users/nishantmonu51/received_events","type":"User","site_admin":false},"repo":{"id":30287395,"name":"druid","full_name":"nishantmonu51/druid","owner":{"login":"nishantmonu51","id":5023786,"avatar_url":"https://avatars.githubusercontent.com/u/5023786?v=3","gravatar_id":"","url":"https://api.github.com/users/nishantmonu51","html_url":"https://github.com/nishantmonu51","followers_url":"https://api.github.com/users/nishantmonu51/followers","following_url":"https://api.github.com/users/nishantmonu51/following{/other_user}","gists_url":"https://api.github.com/users/nishantmonu51/gists{/gist_id}","starred_url":"https://api.github.com/users/nishantmonu51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishantmonu51/subscriptions","organizations_url":"https://api.github.com/users/nishantmonu51/orgs","repos_url":"https://api.github.com/users/nishantmonu51/repos","events_url":"https://api.github.com/users/nishantmonu51/events{/privacy}","received_events_url":"https://api.github.com/users/nishantmonu51/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nishantmonu51/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/nishantmonu51/druid","forks_url":"https://api.github.com/repos/nishantmonu51/druid/forks","keys_url":"https://api.github.com/repos/nishantmonu51/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nishantmonu51/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nishantmonu51/druid/teams","hooks_url":"https://api.github.com/repos/nishantmonu51/druid/hooks","issue_events_url":"https://api.github.com/repos/nishantmonu51/druid/issues/events{/number}","events_url":"https://api.github.com/repos/nishantmonu51/druid/events","assignees_url":"https://api.github.com/repos/nishantmonu51/druid/assignees{/user}","branches_url":"https://api.github.com/repos/nishantmonu51/druid/branches{/branch}","tags_url":"https://api.github.com/repos/nishantmonu51/druid/tags","blobs_url":"https://api.github.com/repos/nishantmonu51/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nishantmonu51/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nishantmonu51/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/nishantmonu51/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nishantmonu51/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/nishantmonu51/druid/languages","stargazers_url":"https://api.github.com/repos/nishantmonu51/druid/stargazers","contributors_url":"https://api.github.com/repos/nishantmonu51/druid/contributors","subscribers_url":"https://api.github.com/repos/nishantmonu51/druid/subscribers","subscription_url":"https://api.github.com/repos/nishantmonu51/druid/subscription","commits_url":"https://api.github.com/repos/nishantmonu51/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/nishantmonu51/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/nishantmonu51/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/nishantmonu51/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/nishantmonu51/druid/contents/{+path}","compare_url":"https://api.github.com/repos/nishantmonu51/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nishantmonu51/druid/merges","archive_url":"https://api.github.com/repos/nishantmonu51/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nishantmonu51/druid/downloads","issues_url":"https://api.github.com/repos/nishantmonu51/druid/issues{/number}","pulls_url":"https://api.github.com/repos/nishantmonu51/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/nishantmonu51/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/nishantmonu51/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nishantmonu51/druid/labels{/name}","releases_url":"https://api.github.com/repos/nishantmonu51/druid/releases{/id}","deployments_url":"https://api.github.com/repos/nishantmonu51/druid/deployments","created_at":"2015-02-04T07:42:09Z","updated_at":"2016-05-30T13:28:55Z","pushed_at":"2017-02-21T17:45:45Z","git_url":"git://github.com/nishantmonu51/druid.git","ssh_url":"git@github.com:nishantmonu51/druid.git","clone_url":"https://github.com/nishantmonu51/druid.git","svn_url":"https://github.com/nishantmonu51/druid","homepage":"http://druid.io","size":116264,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"bc33b68b513da2a6a89e3467f7289197d323924e","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2017-02-21T14:44:29Z","pushed_at":"2017-02-21T17:49:50Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":117728,"stargazers_count":4461,"watchers_count":4461,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1054,"mirror_url":null,"open_issues_count":597,"forks":1054,"open_issues":597,"watchers":4461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3956"},"html":{"href":"https://github.com/druid-io/druid/pull/3956"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/3956"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/3956/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3956/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3956/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/8e2e67002d90afc406a6dacaf36f8074296e7f9d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":275,"deletions":10,"changed_files":4}}
{"actor":{"display_login":"nishantmonu51"}}