{"action":"created","comment":{"url":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/115150129","pull_request_review_id":36670178,"id":115150129,"diff_hunk":"@@ -320,11 +329,17 @@ private function setupGenerators(IndexedServiceContainer $container)\n         }, ['code_generator.generators']);\n \n         $container->define('code_generator.generators.private_constructor', function (IndexedServiceContainer $c) {\n-            return new CodeGenerator\\Generator\\PrivateConstructorGenerator(\n-                $c->get('console.io'),\n-                $c->get('code_generator.templates'),\n-                $c->get('util.filesystem'),\n-                $c->get('code_generator.writers.tokenized')\n+            return new CodeGenerator\\Generator\\OneTimeGenerator(","path":"src/PhpSpec/Console/ContainerAssembler.php","position":32,"original_position":32,"commit_id":"ed525a97d333e08029b82186e80706f0fb88e2df","original_commit_id":"ed525a97d333e08029b82186e80706f0fb88e2df","user":{"login":"ciaranmcnulty","id":237866,"avatar_url":"https://avatars3.githubusercontent.com/u/237866?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaranmcnulty","html_url":"https://github.com/ciaranmcnulty","followers_url":"https://api.github.com/users/ciaranmcnulty/followers","following_url":"https://api.github.com/users/ciaranmcnulty/following{/other_user}","gists_url":"https://api.github.com/users/ciaranmcnulty/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranmcnulty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranmcnulty/subscriptions","organizations_url":"https://api.github.com/users/ciaranmcnulty/orgs","repos_url":"https://api.github.com/users/ciaranmcnulty/repos","events_url":"https://api.github.com/users/ciaranmcnulty/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranmcnulty/received_events","type":"User","site_admin":false},"body":"Actually looking at it, it's not necessary right now","created_at":"2017-05-07T18:14:45Z","updated_at":"2017-05-07T18:14:45Z","html_url":"https://github.com/phpspec/phpspec/pull/1059#discussion_r115150129","pull_request_url":"https://api.github.com/repos/phpspec/phpspec/pulls/1059","_links":{"self":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/comments/115150129"},"html":{"href":"https://github.com/phpspec/phpspec/pull/1059#discussion_r115150129"},"pull_request":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/1059"}}},"pull_request":{"url":"https://api.github.com/repos/phpspec/phpspec/pulls/1059","id":103781378,"html_url":"https://github.com/phpspec/phpspec/pull/1059","diff_url":"https://github.com/phpspec/phpspec/pull/1059.diff","patch_url":"https://github.com/phpspec/phpspec/pull/1059.patch","issue_url":"https://api.github.com/repos/phpspec/phpspec/issues/1059","number":1059,"state":"open","locked":false,"title":"Bugfix: Constructor is made private multiple times","user":{"login":"carlosV2","id":2642839,"avatar_url":"https://avatars3.githubusercontent.com/u/2642839?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosV2","html_url":"https://github.com/carlosV2","followers_url":"https://api.github.com/users/carlosV2/followers","following_url":"https://api.github.com/users/carlosV2/following{/other_user}","gists_url":"https://api.github.com/users/carlosV2/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosV2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosV2/subscriptions","organizations_url":"https://api.github.com/users/carlosV2/orgs","repos_url":"https://api.github.com/users/carlosV2/repos","events_url":"https://api.github.com/users/carlosV2/events{/privacy}","received_events_url":"https://api.github.com/users/carlosV2/received_events","type":"User","site_admin":false},"body":"This PR fixes the issue raised in https://github.com/phpspec/phpspec/issues/1058.\r\n\r\n===========================================================\r\n\r\nThe solution is to add a new Generator called `OneTimeGenerator` which decorates any other Generator so that it only calls the parent the first time it is called per classname.","created_at":"2017-01-30T17:23:10Z","updated_at":"2017-05-07T18:14:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b1b283ff345c3d25d85cfa5c59f8af0ebdc0fba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpspec/phpspec/pulls/1059/commits","review_comments_url":"https://api.github.com/repos/phpspec/phpspec/pulls/1059/comments","review_comment_url":"https://api.github.com/repos/phpspec/phpspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpspec/phpspec/issues/1059/comments","statuses_url":"https://api.github.com/repos/phpspec/phpspec/statuses/ed525a97d333e08029b82186e80706f0fb88e2df","head":{"label":"carlosV2:master","ref":"master","sha":"ed525a97d333e08029b82186e80706f0fb88e2df","user":{"login":"carlosV2","id":2642839,"avatar_url":"https://avatars3.githubusercontent.com/u/2642839?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosV2","html_url":"https://github.com/carlosV2","followers_url":"https://api.github.com/users/carlosV2/followers","following_url":"https://api.github.com/users/carlosV2/following{/other_user}","gists_url":"https://api.github.com/users/carlosV2/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosV2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosV2/subscriptions","organizations_url":"https://api.github.com/users/carlosV2/orgs","repos_url":"https://api.github.com/users/carlosV2/repos","events_url":"https://api.github.com/users/carlosV2/events{/privacy}","received_events_url":"https://api.github.com/users/carlosV2/received_events","type":"User","site_admin":false},"repo":{"id":80443142,"name":"phpspec","full_name":"carlosV2/phpspec","owner":{"login":"carlosV2","id":2642839,"avatar_url":"https://avatars3.githubusercontent.com/u/2642839?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosV2","html_url":"https://github.com/carlosV2","followers_url":"https://api.github.com/users/carlosV2/followers","following_url":"https://api.github.com/users/carlosV2/following{/other_user}","gists_url":"https://api.github.com/users/carlosV2/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosV2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosV2/subscriptions","organizations_url":"https://api.github.com/users/carlosV2/orgs","repos_url":"https://api.github.com/users/carlosV2/repos","events_url":"https://api.github.com/users/carlosV2/events{/privacy}","received_events_url":"https://api.github.com/users/carlosV2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlosV2/phpspec","description":"SpecBDD Framework for PHP","fork":true,"url":"https://api.github.com/repos/carlosV2/phpspec","forks_url":"https://api.github.com/repos/carlosV2/phpspec/forks","keys_url":"https://api.github.com/repos/carlosV2/phpspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosV2/phpspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosV2/phpspec/teams","hooks_url":"https://api.github.com/repos/carlosV2/phpspec/hooks","issue_events_url":"https://api.github.com/repos/carlosV2/phpspec/issues/events{/number}","events_url":"https://api.github.com/repos/carlosV2/phpspec/events","assignees_url":"https://api.github.com/repos/carlosV2/phpspec/assignees{/user}","branches_url":"https://api.github.com/repos/carlosV2/phpspec/branches{/branch}","tags_url":"https://api.github.com/repos/carlosV2/phpspec/tags","blobs_url":"https://api.github.com/repos/carlosV2/phpspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosV2/phpspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosV2/phpspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosV2/phpspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosV2/phpspec/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosV2/phpspec/languages","stargazers_url":"https://api.github.com/repos/carlosV2/phpspec/stargazers","contributors_url":"https://api.github.com/repos/carlosV2/phpspec/contributors","subscribers_url":"https://api.github.com/repos/carlosV2/phpspec/subscribers","subscription_url":"https://api.github.com/repos/carlosV2/phpspec/subscription","commits_url":"https://api.github.com/repos/carlosV2/phpspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosV2/phpspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosV2/phpspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosV2/phpspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosV2/phpspec/contents/{+path}","compare_url":"https://api.github.com/repos/carlosV2/phpspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosV2/phpspec/merges","archive_url":"https://api.github.com/repos/carlosV2/phpspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosV2/phpspec/downloads","issues_url":"https://api.github.com/repos/carlosV2/phpspec/issues{/number}","pulls_url":"https://api.github.com/repos/carlosV2/phpspec/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosV2/phpspec/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosV2/phpspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosV2/phpspec/labels{/name}","releases_url":"https://api.github.com/repos/carlosV2/phpspec/releases{/id}","deployments_url":"https://api.github.com/repos/carlosV2/phpspec/deployments","created_at":"2017-01-30T17:08:58Z","updated_at":"2017-01-30T17:09:01Z","pushed_at":"2017-02-05T21:52:07Z","git_url":"git://github.com/carlosV2/phpspec.git","ssh_url":"git@github.com:carlosV2/phpspec.git","clone_url":"https://github.com/carlosV2/phpspec.git","svn_url":"https://github.com/carlosV2/phpspec","homepage":"http://www.phpspec.net","size":4040,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpspec:master","ref":"master","sha":"97246d90708cf98983d95d609bbe6f4b039b8600","user":{"login":"phpspec","id":416702,"avatar_url":"https://avatars0.githubusercontent.com/u/416702?v=3","gravatar_id":"","url":"https://api.github.com/users/phpspec","html_url":"https://github.com/phpspec","followers_url":"https://api.github.com/users/phpspec/followers","following_url":"https://api.github.com/users/phpspec/following{/other_user}","gists_url":"https://api.github.com/users/phpspec/gists{/gist_id}","starred_url":"https://api.github.com/users/phpspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpspec/subscriptions","organizations_url":"https://api.github.com/users/phpspec/orgs","repos_url":"https://api.github.com/users/phpspec/repos","events_url":"https://api.github.com/users/phpspec/events{/privacy}","received_events_url":"https://api.github.com/users/phpspec/received_events","type":"Organization","site_admin":false},"repo":{"id":1582219,"name":"phpspec","full_name":"phpspec/phpspec","owner":{"login":"phpspec","id":416702,"avatar_url":"https://avatars0.githubusercontent.com/u/416702?v=3","gravatar_id":"","url":"https://api.github.com/users/phpspec","html_url":"https://github.com/phpspec","followers_url":"https://api.github.com/users/phpspec/followers","following_url":"https://api.github.com/users/phpspec/following{/other_user}","gists_url":"https://api.github.com/users/phpspec/gists{/gist_id}","starred_url":"https://api.github.com/users/phpspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpspec/subscriptions","organizations_url":"https://api.github.com/users/phpspec/orgs","repos_url":"https://api.github.com/users/phpspec/repos","events_url":"https://api.github.com/users/phpspec/events{/privacy}","received_events_url":"https://api.github.com/users/phpspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpspec/phpspec","description":"SpecBDD Framework for PHP","fork":false,"url":"https://api.github.com/repos/phpspec/phpspec","forks_url":"https://api.github.com/repos/phpspec/phpspec/forks","keys_url":"https://api.github.com/repos/phpspec/phpspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpspec/phpspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpspec/phpspec/teams","hooks_url":"https://api.github.com/repos/phpspec/phpspec/hooks","issue_events_url":"https://api.github.com/repos/phpspec/phpspec/issues/events{/number}","events_url":"https://api.github.com/repos/phpspec/phpspec/events","assignees_url":"https://api.github.com/repos/phpspec/phpspec/assignees{/user}","branches_url":"https://api.github.com/repos/phpspec/phpspec/branches{/branch}","tags_url":"https://api.github.com/repos/phpspec/phpspec/tags","blobs_url":"https://api.github.com/repos/phpspec/phpspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpspec/phpspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpspec/phpspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpspec/phpspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpspec/phpspec/statuses/{sha}","languages_url":"https://api.github.com/repos/phpspec/phpspec/languages","stargazers_url":"https://api.github.com/repos/phpspec/phpspec/stargazers","contributors_url":"https://api.github.com/repos/phpspec/phpspec/contributors","subscribers_url":"https://api.github.com/repos/phpspec/phpspec/subscribers","subscription_url":"https://api.github.com/repos/phpspec/phpspec/subscription","commits_url":"https://api.github.com/repos/phpspec/phpspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpspec/phpspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpspec/phpspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpspec/phpspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpspec/phpspec/contents/{+path}","compare_url":"https://api.github.com/repos/phpspec/phpspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpspec/phpspec/merges","archive_url":"https://api.github.com/repos/phpspec/phpspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpspec/phpspec/downloads","issues_url":"https://api.github.com/repos/phpspec/phpspec/issues{/number}","pulls_url":"https://api.github.com/repos/phpspec/phpspec/pulls{/number}","milestones_url":"https://api.github.com/repos/phpspec/phpspec/milestones{/number}","notifications_url":"https://api.github.com/repos/phpspec/phpspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpspec/phpspec/labels{/name}","releases_url":"https://api.github.com/repos/phpspec/phpspec/releases{/id}","deployments_url":"https://api.github.com/repos/phpspec/phpspec/deployments","created_at":"2011-04-07T12:48:08Z","updated_at":"2017-05-05T14:30:08Z","pushed_at":"2017-05-07T17:45:59Z","git_url":"git://github.com/phpspec/phpspec.git","ssh_url":"git@github.com:phpspec/phpspec.git","clone_url":"https://github.com/phpspec/phpspec.git","svn_url":"https://github.com/phpspec/phpspec","homepage":"http://www.phpspec.net","size":4026,"stargazers_count":1184,"watchers_count":1184,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":106,"forks":224,"open_issues":106,"watchers":1184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/1059"},"html":{"href":"https://github.com/phpspec/phpspec/pull/1059"},"issue":{"href":"https://api.github.com/repos/phpspec/phpspec/issues/1059"},"comments":{"href":"https://api.github.com/repos/phpspec/phpspec/issues/1059/comments"},"review_comments":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/1059/comments"},"review_comment":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpspec/phpspec/pulls/1059/commits"},"statuses":{"href":"https://api.github.com/repos/phpspec/phpspec/statuses/ed525a97d333e08029b82186e80706f0fb88e2df"}}}}
{"actor":{"display_login":"ciaranmcnulty"}}