{"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/123128465","pull_request_review_id":45302081,"id":123128465,"diff_hunk":"@@ -45,7 +48,7 @@ public struct BuildSettings {\n \t\t\t.timeout(after: 60, raising: .xcodebuildTimeout(arguments.project), on: QueueScheduler(qos: .default))\n \t\t\t.retry(upTo: 5)\n \t\t\t.map { data in\n-\t\t\t\treturn String(data: data, encoding: .utf8)!\n+\t\t\t\tString(data: data, encoding: .utf8)!","path":"Source/CarthageKit/BuildSettings.swift","position":null,"original_position":17,"commit_id":"56be55081c3ef10ee06fd34bc64a2b6e41186a05","original_commit_id":"3cae8551a39c7265523b73a6e23c6ce0227b5c19","user":{"login":"Dschee","id":6942160,"avatar_url":"https://avatars1.githubusercontent.com/u/6942160?v=3","gravatar_id":"","url":"https://api.github.com/users/Dschee","html_url":"https://github.com/Dschee","followers_url":"https://api.github.com/users/Dschee/followers","following_url":"https://api.github.com/users/Dschee/following{/other_user}","gists_url":"https://api.github.com/users/Dschee/gists{/gist_id}","starred_url":"https://api.github.com/users/Dschee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dschee/subscriptions","organizations_url":"https://api.github.com/users/Dschee/orgs","repos_url":"https://api.github.com/users/Dschee/repos","events_url":"https://api.github.com/users/Dschee/events{/privacy}","received_events_url":"https://api.github.com/users/Dschee/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-06-21T00:20:49Z","updated_at":"2017-06-21T00:20:49Z","html_url":"https://github.com/Carthage/Carthage/pull/2001#discussion_r123128465","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2001","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/123128465"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2001#discussion_r123128465"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2001"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/2001","id":126293973,"html_url":"https://github.com/Carthage/Carthage/pull/2001","diff_url":"https://github.com/Carthage/Carthage/pull/2001.diff","patch_url":"https://github.com/Carthage/Carthage/pull/2001.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/2001","number":2001,"state":"open","locked":false,"title":"Improve Code Quality by using SwiftLint","user":{"login":"Dschee","id":6942160,"avatar_url":"https://avatars1.githubusercontent.com/u/6942160?v=3","gravatar_id":"","url":"https://api.github.com/users/Dschee","html_url":"https://github.com/Dschee","followers_url":"https://api.github.com/users/Dschee/followers","following_url":"https://api.github.com/users/Dschee/following{/other_user}","gists_url":"https://api.github.com/users/Dschee/gists{/gist_id}","starred_url":"https://api.github.com/users/Dschee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dschee/subscriptions","organizations_url":"https://api.github.com/users/Dschee/orgs","repos_url":"https://api.github.com/users/Dschee/repos","events_url":"https://api.github.com/users/Dschee/events{/privacy}","received_events_url":"https://api.github.com/users/Dschee/received_events","type":"User","site_admin":false},"body":"I have setup **SwiftLint** to work with this project and run automatically on build. Note that you need to have the latest SwiftLint installed for this (`brew install swiftlint` if you don't have it yet, `brew upgrade swiftlint` for updating it).\r\n\r\nI've added a `.swiftlint.yml` where I **configured the rules** and even added **many custom rules** to ensure the code is streamlined and consistently the same. I've also done the hard work and have **already fixed most of the issues** (there were 800+) – leaving only around 17 which can be solved over time with other PRs.\r\n\r\nNote that all of the rules are Swift Community rules or extracted from popular projects such as Alamofire and Moya where they are implicitly used.","created_at":"2017-06-19T12:44:40Z","updated_at":"2017-06-21T00:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf607e67ffa378930fb530986f5ba189d729246e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2001/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2001/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/2001/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/56be55081c3ef10ee06fd34bc64a2b6e41186a05","head":{"label":"Dschee:code-quality","ref":"code-quality","sha":"56be55081c3ef10ee06fd34bc64a2b6e41186a05","user":{"login":"Dschee","id":6942160,"avatar_url":"https://avatars1.githubusercontent.com/u/6942160?v=3","gravatar_id":"","url":"https://api.github.com/users/Dschee","html_url":"https://github.com/Dschee","followers_url":"https://api.github.com/users/Dschee/followers","following_url":"https://api.github.com/users/Dschee/following{/other_user}","gists_url":"https://api.github.com/users/Dschee/gists{/gist_id}","starred_url":"https://api.github.com/users/Dschee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dschee/subscriptions","organizations_url":"https://api.github.com/users/Dschee/orgs","repos_url":"https://api.github.com/users/Dschee/repos","events_url":"https://api.github.com/users/Dschee/events{/privacy}","received_events_url":"https://api.github.com/users/Dschee/received_events","type":"User","site_admin":false},"repo":{"id":94399467,"name":"Carthage","full_name":"Dschee/Carthage","owner":{"login":"Dschee","id":6942160,"avatar_url":"https://avatars1.githubusercontent.com/u/6942160?v=3","gravatar_id":"","url":"https://api.github.com/users/Dschee","html_url":"https://github.com/Dschee","followers_url":"https://api.github.com/users/Dschee/followers","following_url":"https://api.github.com/users/Dschee/following{/other_user}","gists_url":"https://api.github.com/users/Dschee/gists{/gist_id}","starred_url":"https://api.github.com/users/Dschee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dschee/subscriptions","organizations_url":"https://api.github.com/users/Dschee/orgs","repos_url":"https://api.github.com/users/Dschee/repos","events_url":"https://api.github.com/users/Dschee/events{/privacy}","received_events_url":"https://api.github.com/users/Dschee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dschee/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/Dschee/Carthage","forks_url":"https://api.github.com/repos/Dschee/Carthage/forks","keys_url":"https://api.github.com/repos/Dschee/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dschee/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dschee/Carthage/teams","hooks_url":"https://api.github.com/repos/Dschee/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Dschee/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Dschee/Carthage/events","assignees_url":"https://api.github.com/repos/Dschee/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Dschee/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Dschee/Carthage/tags","blobs_url":"https://api.github.com/repos/Dschee/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dschee/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dschee/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dschee/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dschee/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Dschee/Carthage/languages","stargazers_url":"https://api.github.com/repos/Dschee/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Dschee/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Dschee/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Dschee/Carthage/subscription","commits_url":"https://api.github.com/repos/Dschee/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dschee/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dschee/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dschee/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dschee/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Dschee/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dschee/Carthage/merges","archive_url":"https://api.github.com/repos/Dschee/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dschee/Carthage/downloads","issues_url":"https://api.github.com/repos/Dschee/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Dschee/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Dschee/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Dschee/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dschee/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Dschee/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/Dschee/Carthage/deployments","created_at":"2017-06-15T04:24:33Z","updated_at":"2017-06-15T04:24:35Z","pushed_at":"2017-06-21T00:20:43Z","git_url":"git://github.com/Dschee/Carthage.git","ssh_url":"git@github.com:Dschee/Carthage.git","clone_url":"https://github.com/Dschee/Carthage.git","svn_url":"https://github.com/Dschee/Carthage","homepage":"","size":13424,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"b29f21badbd5a90abd6ce6350ba5e8c7b7839189","user":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars2.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"name":"Carthage","full_name":"Carthage/Carthage","owner":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars2.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/Carthage/Carthage/deployments","created_at":"2014-10-10T19:54:55Z","updated_at":"2017-06-20T23:19:58Z","pushed_at":"2017-06-21T00:20:46Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"git@github.com:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":13393,"stargazers_count":9631,"watchers_count":9631,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":857,"mirror_url":null,"open_issues_count":162,"forks":857,"open_issues":162,"watchers":9631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2001"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2001"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2001"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2001/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2001/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2001/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/56be55081c3ef10ee06fd34bc64a2b6e41186a05"}}}}
{"actor":{"display_login":"Dschee"}}