{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/110374824","pull_request_review_id":31544348,"id":110374824,"diff_hunk":"@@ -23,18 +23,23 @@ open Source\n \n (* Print a line; return the beginning of the next line *)\n let print_line buffer line_number start point before =\n-  let next = next_linefeed buffer start\n+  let next_linefeed = next_linefeed buffer start\n   and content = buffer_content buffer\n   in\n     printf \"%i \" line_number;\n+    let next =\n+      if content.[next_linefeed - 1] = '\\r' then","path":"debugger/show_source.ml","position":10,"original_position":10,"commit_id":"c410fcf64209477c444a0fde09479a425855d9f7","original_commit_id":"c410fcf64209477c444a0fde09479a425855d9f7","user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars3.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"body":"I thought I'd persuaded that couldn't happen (that the function wouldn't be called in that context) but even if that's right, it would be better to be defensive.","created_at":"2017-04-07T12:07:34Z","updated_at":"2017-04-07T12:07:34Z","html_url":"https://github.com/ocaml/ocaml/pull/1141#discussion_r110374824","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1141","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/110374824"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1141#discussion_r110374824"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1141"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1141","id":114611092,"html_url":"https://github.com/ocaml/ocaml/pull/1141","diff_url":"https://github.com/ocaml/ocaml/pull/1141.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1141.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1141","number":1141,"state":"open","locked":false,"title":"Fix '\\r' build problems with newer Cygwin tools (4.04.1 version)","user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars3.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"body":"4.04 branch version of #1140","created_at":"2017-04-06T14:12:53Z","updated_at":"2017-04-07T12:07:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aadec67a5bf42bafa374e3081c58668832f5ed68","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1141/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1141/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1141/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/c410fcf64209477c444a0fde09479a425855d9f7","head":{"label":"dra27:fix-newer-cygwin-tools-4.04","ref":"fix-newer-cygwin-tools-4.04","sha":"c410fcf64209477c444a0fde09479a425855d9f7","user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars3.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"repo":{"id":39718388,"name":"ocaml","full_name":"dra27/ocaml","owner":{"login":"dra27","id":5250680,"avatar_url":"https://avatars3.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dra27/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":true,"url":"https://api.github.com/repos/dra27/ocaml","forks_url":"https://api.github.com/repos/dra27/ocaml/forks","keys_url":"https://api.github.com/repos/dra27/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dra27/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dra27/ocaml/teams","hooks_url":"https://api.github.com/repos/dra27/ocaml/hooks","issue_events_url":"https://api.github.com/repos/dra27/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/dra27/ocaml/events","assignees_url":"https://api.github.com/repos/dra27/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/dra27/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/dra27/ocaml/tags","blobs_url":"https://api.github.com/repos/dra27/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dra27/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dra27/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/dra27/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dra27/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/dra27/ocaml/languages","stargazers_url":"https://api.github.com/repos/dra27/ocaml/stargazers","contributors_url":"https://api.github.com/repos/dra27/ocaml/contributors","subscribers_url":"https://api.github.com/repos/dra27/ocaml/subscribers","subscription_url":"https://api.github.com/repos/dra27/ocaml/subscription","commits_url":"https://api.github.com/repos/dra27/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/dra27/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/dra27/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/dra27/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/dra27/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/dra27/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dra27/ocaml/merges","archive_url":"https://api.github.com/repos/dra27/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dra27/ocaml/downloads","issues_url":"https://api.github.com/repos/dra27/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/dra27/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/dra27/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/dra27/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dra27/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/dra27/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/dra27/ocaml/deployments","created_at":"2015-07-26T08:02:14Z","updated_at":"2016-10-27T17:57:34Z","pushed_at":"2017-04-06T13:54:56Z","git_url":"git://github.com/dra27/ocaml.git","ssh_url":"git@github.com:dra27/ocaml.git","clone_url":"https://github.com/dra27/ocaml.git","svn_url":"https://github.com/dra27/ocaml","homepage":"","size":123361,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:4.04","ref":"4.04","sha":"8887110150e5de0412a1a915598b48fb9fa5aa7d","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars0.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars0.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2017-04-07T11:40:39Z","pushed_at":"2017-04-07T12:04:34Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":141860,"stargazers_count":1219,"watchers_count":1219,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":350,"mirror_url":null,"open_issues_count":141,"forks":350,"open_issues":141,"watchers":1219,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1141"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1141"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1141"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1141/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1141/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1141/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/c410fcf64209477c444a0fde09479a425855d9f7"}}}}
{"actor":{"display_login":"dra27"}}