{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/102646894","pull_request_review_id":23406679,"id":102646894,"diff_hunk":"@@ -2348,9 +2348,16 @@ func ValidatePodUpdate(newPod, oldPod *api.Pod) field.ErrorList {\n \t\tactiveDeadlineSeconds := *oldPod.Spec.ActiveDeadlineSeconds\n \t\tmungedPod.Spec.ActiveDeadlineSeconds = &activeDeadlineSeconds\n \t}\n+\n+\t// Allow tolerations updates.\n+\tif len(newPod.Spec.Tolerations) > 0 {\n+\t\tallErrs = append(allErrs, validateTolerations(newPod.Spec.Tolerations, fldPath.Child(\"tolerations\"))...)\n+\t}\n+\tmungedPod.Spec.Tolerations = oldPod.Spec.Tolerations","path":"pkg/api/validation/validation.go","position":9,"original_position":9,"commit_id":"8b5cd9eef0b550f5ddd566d4a4f86c5f568d68b5","original_commit_id":"8b5cd9eef0b550f5ddd566d4a4f86c5f568d68b5","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"changing/removing tolerations opens the possibility of scheduling a pod based on stale tolerations, and binding it to a tainted node after the pod changed its mind and became intolerant of that taint. only allowing adding tolerations means a previously chosen node would still be tolerated.","created_at":"2017-02-23T06:28:49Z","updated_at":"2017-02-23T06:28:49Z","html_url":"https://github.com/kubernetes/kubernetes/pull/41818#discussion_r102646894","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/102646894"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/41818#discussion_r102646894"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818","id":107246098,"html_url":"https://github.com/kubernetes/kubernetes/pull/41818","diff_url":"https://github.com/kubernetes/kubernetes/pull/41818.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/41818.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41818","number":41818,"state":"open","locked":false,"title":"Allow updates to pod tolerations.","user":{"login":"aveshagarwal","id":3596412,"avatar_url":"https://avatars.githubusercontent.com/u/3596412?v=3","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false},"body":"Opening this PR to continue discussion for pod spec tolerations updates when a pod has been scheduled already. This PR is built on top of https://github.com/kubernetes/kubernetes/pull/38957.\r\n\r\n@kubernetes/sig-scheduling-pr-reviews @liggitt @davidopp @derekwaynecarr @kubernetes/rh-cluster-infra \r\n","created_at":"2017-02-21T18:07:16Z","updated_at":"2017-02-23T06:28:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"723e79a19097fe9c6d8375f0d298d9f16751420e","assignee":{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"assignees":[{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41818/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8b5cd9eef0b550f5ddd566d4a4f86c5f568d68b5","head":{"label":"aveshagarwal:master-taints-tolerations-api-fields-pod-spec-updates","ref":"master-taints-tolerations-api-fields-pod-spec-updates","sha":"8b5cd9eef0b550f5ddd566d4a4f86c5f568d68b5","user":{"login":"aveshagarwal","id":3596412,"avatar_url":"https://avatars.githubusercontent.com/u/3596412?v=3","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false},"repo":{"id":32509925,"name":"kubernetes","full_name":"aveshagarwal/kubernetes","owner":{"login":"aveshagarwal","id":3596412,"avatar_url":"https://avatars.githubusercontent.com/u/3596412?v=3","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aveshagarwal/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/aveshagarwal/kubernetes","forks_url":"https://api.github.com/repos/aveshagarwal/kubernetes/forks","keys_url":"https://api.github.com/repos/aveshagarwal/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aveshagarwal/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aveshagarwal/kubernetes/teams","hooks_url":"https://api.github.com/repos/aveshagarwal/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/aveshagarwal/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/aveshagarwal/kubernetes/events","assignees_url":"https://api.github.com/repos/aveshagarwal/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/aveshagarwal/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/aveshagarwal/kubernetes/tags","blobs_url":"https://api.github.com/repos/aveshagarwal/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aveshagarwal/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aveshagarwal/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/aveshagarwal/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aveshagarwal/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/aveshagarwal/kubernetes/languages","stargazers_url":"https://api.github.com/repos/aveshagarwal/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/aveshagarwal/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/aveshagarwal/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/aveshagarwal/kubernetes/subscription","commits_url":"https://api.github.com/repos/aveshagarwal/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/aveshagarwal/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/aveshagarwal/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/aveshagarwal/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/aveshagarwal/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/aveshagarwal/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aveshagarwal/kubernetes/merges","archive_url":"https://api.github.com/repos/aveshagarwal/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aveshagarwal/kubernetes/downloads","issues_url":"https://api.github.com/repos/aveshagarwal/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/aveshagarwal/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/aveshagarwal/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/aveshagarwal/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aveshagarwal/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/aveshagarwal/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/aveshagarwal/kubernetes/deployments","created_at":"2015-03-19T08:38:39Z","updated_at":"2016-01-13T15:56:58Z","pushed_at":"2017-02-23T04:36:52Z","git_url":"git://github.com/aveshagarwal/kubernetes.git","ssh_url":"git@github.com:aveshagarwal/kubernetes.git","clone_url":"https://github.com/aveshagarwal/kubernetes.git","svn_url":"https://github.com/aveshagarwal/kubernetes","homepage":"http://kubernetes.io","size":401243,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9cbaff9e0fb7c55b9cb179f62e4272d63c9480f1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-02-23T06:25:08Z","pushed_at":"2017-02-23T06:12:18Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":560484,"stargazers_count":20883,"watchers_count":20883,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7121,"mirror_url":null,"open_issues_count":5725,"forks":7121,"open_issues":5725,"watchers":20883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/41818"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/41818"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/41818/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41818/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8b5cd9eef0b550f5ddd566d4a4f86c5f568d68b5"}}}}
{"actor":{"display_login":"liggitt"}}