{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/138757057","pull_request_review_id":62596626,"id":138757057,"diff_hunk":"@@ -36,12 +36,13 @@ elif [ -f \"$docker_dir/disabled/$image/Dockerfile\" ]; then\n         echo Cannot run disabled images on travis!\n         exit 1\n     fi\n-    retry docker \\\n+    # retry messes with the pipe from tar to docker. Not needed on non-travis\n+    tar --transform 's/^\\.\\/disabled\\//.\\//' -C $docker_dir -c . | docker \\","path":"src/ci/docker/run.sh","position":6,"original_position":6,"commit_id":"b04097b521afefddafcaeed7d789d3271f8d5a01","original_commit_id":"b04097b521afefddafcaeed7d789d3271f8d5a01","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars1.githubusercontent.com/u/1050652?v=4","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"body":"The transform looks right, but it generates a very strange path for the dockerfile for me - `.\\\\/Dockerfile`. All of the backslashes are a bit crazy anyway, can you make `#` the escape character? i.e. `s#^\\./a/#./#'`\r\n\r\nAdditionally, can you add a brief description line of what we're doing here? E.g. something like \"The tar transform below makes the images in the disabled directory look like they're in the main images directory to `docker build`.\"","created_at":"2017-09-13T22:32:55Z","updated_at":"2017-09-13T22:32:55Z","html_url":"https://github.com/rust-lang/rust/pull/44346#discussion_r138757057","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/44346","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/138757057"},"html":{"href":"https://github.com/rust-lang/rust/pull/44346#discussion_r138757057"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44346"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/44346","id":139386269,"html_url":"https://github.com/rust-lang/rust/pull/44346","diff_url":"https://github.com/rust-lang/rust/pull/44346.diff","patch_url":"https://github.com/rust-lang/rust/pull/44346.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/44346","number":44346,"state":"open","locked":false,"title":"ci: Fix building disabled containers","user":{"login":"kallisti5","id":100110,"avatar_url":"https://avatars0.githubusercontent.com/u/100110?v=4","gravatar_id":"","url":"https://api.github.com/users/kallisti5","html_url":"https://github.com/kallisti5","followers_url":"https://api.github.com/users/kallisti5/followers","following_url":"https://api.github.com/users/kallisti5/following{/other_user}","gists_url":"https://api.github.com/users/kallisti5/gists{/gist_id}","starred_url":"https://api.github.com/users/kallisti5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallisti5/subscriptions","organizations_url":"https://api.github.com/users/kallisti5/orgs","repos_url":"https://api.github.com/users/kallisti5/repos","events_url":"https://api.github.com/users/kallisti5/events{/privacy}","received_events_url":"https://api.github.com/users/kallisti5/received_events","type":"User","site_admin":false},"body":"Working on a new CI platform and noticed building disabled containers is broken. (looking at the shell script, it appears being able to build disabled containers *is* desired)","created_at":"2017-09-05T18:09:56Z","updated_at":"2017-09-13T22:32:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f7064421e3d3f8b9efcbd901614e013db991ebc","assignee":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars1.githubusercontent.com/u/1050652?v=4","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"assignees":[{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars1.githubusercontent.com/u/1050652?v=4","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/44346/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/44346/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/44346/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/b04097b521afefddafcaeed7d789d3271f8d5a01","head":{"label":"kallisti5:ci-build-disabled","ref":"ci-build-disabled","sha":"b04097b521afefddafcaeed7d789d3271f8d5a01","user":{"login":"kallisti5","id":100110,"avatar_url":"https://avatars0.githubusercontent.com/u/100110?v=4","gravatar_id":"","url":"https://api.github.com/users/kallisti5","html_url":"https://github.com/kallisti5","followers_url":"https://api.github.com/users/kallisti5/followers","following_url":"https://api.github.com/users/kallisti5/following{/other_user}","gists_url":"https://api.github.com/users/kallisti5/gists{/gist_id}","starred_url":"https://api.github.com/users/kallisti5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallisti5/subscriptions","organizations_url":"https://api.github.com/users/kallisti5/orgs","repos_url":"https://api.github.com/users/kallisti5/repos","events_url":"https://api.github.com/users/kallisti5/events{/privacy}","received_events_url":"https://api.github.com/users/kallisti5/received_events","type":"User","site_admin":false},"repo":{"id":90796985,"name":"rust","full_name":"kallisti5/rust","owner":{"login":"kallisti5","id":100110,"avatar_url":"https://avatars0.githubusercontent.com/u/100110?v=4","gravatar_id":"","url":"https://api.github.com/users/kallisti5","html_url":"https://github.com/kallisti5","followers_url":"https://api.github.com/users/kallisti5/followers","following_url":"https://api.github.com/users/kallisti5/following{/other_user}","gists_url":"https://api.github.com/users/kallisti5/gists{/gist_id}","starred_url":"https://api.github.com/users/kallisti5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallisti5/subscriptions","organizations_url":"https://api.github.com/users/kallisti5/orgs","repos_url":"https://api.github.com/users/kallisti5/repos","events_url":"https://api.github.com/users/kallisti5/events{/privacy}","received_events_url":"https://api.github.com/users/kallisti5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kallisti5/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/kallisti5/rust","forks_url":"https://api.github.com/repos/kallisti5/rust/forks","keys_url":"https://api.github.com/repos/kallisti5/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kallisti5/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kallisti5/rust/teams","hooks_url":"https://api.github.com/repos/kallisti5/rust/hooks","issue_events_url":"https://api.github.com/repos/kallisti5/rust/issues/events{/number}","events_url":"https://api.github.com/repos/kallisti5/rust/events","assignees_url":"https://api.github.com/repos/kallisti5/rust/assignees{/user}","branches_url":"https://api.github.com/repos/kallisti5/rust/branches{/branch}","tags_url":"https://api.github.com/repos/kallisti5/rust/tags","blobs_url":"https://api.github.com/repos/kallisti5/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kallisti5/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kallisti5/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/kallisti5/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kallisti5/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/kallisti5/rust/languages","stargazers_url":"https://api.github.com/repos/kallisti5/rust/stargazers","contributors_url":"https://api.github.com/repos/kallisti5/rust/contributors","subscribers_url":"https://api.github.com/repos/kallisti5/rust/subscribers","subscription_url":"https://api.github.com/repos/kallisti5/rust/subscription","commits_url":"https://api.github.com/repos/kallisti5/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/kallisti5/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/kallisti5/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/kallisti5/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/kallisti5/rust/contents/{+path}","compare_url":"https://api.github.com/repos/kallisti5/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kallisti5/rust/merges","archive_url":"https://api.github.com/repos/kallisti5/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kallisti5/rust/downloads","issues_url":"https://api.github.com/repos/kallisti5/rust/issues{/number}","pulls_url":"https://api.github.com/repos/kallisti5/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/kallisti5/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/kallisti5/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kallisti5/rust/labels{/name}","releases_url":"https://api.github.com/repos/kallisti5/rust/releases{/id}","deployments_url":"https://api.github.com/repos/kallisti5/rust/deployments","created_at":"2017-05-09T22:21:35Z","updated_at":"2017-05-09T22:21:58Z","pushed_at":"2017-09-11T15:01:01Z","git_url":"git://github.com/kallisti5/rust.git","ssh_url":"git@github.com:kallisti5/rust.git","clone_url":"https://github.com/kallisti5/rust.git","svn_url":"https://github.com/kallisti5/rust","homepage":"https://www.rust-lang.org","size":323846,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"5d744e94c2d79573c40de0bfa23345a3a136efb6","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-09-13T20:12:33Z","pushed_at":"2017-09-13T22:32:47Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":325424,"stargazers_count":23412,"watchers_count":23412,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4289,"mirror_url":null,"open_issues_count":2865,"forks":4289,"open_issues":2865,"watchers":23412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44346"},"html":{"href":"https://github.com/rust-lang/rust/pull/44346"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/44346"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/44346/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44346/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44346/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/b04097b521afefddafcaeed7d789d3271f8d5a01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aidanhs"}}