{"action":"created","issue":{"url":"https://api.github.com/repos/leapmotion/UnityModules/issues/494","repository_url":"https://api.github.com/repos/leapmotion/UnityModules","labels_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/494/comments","events_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/494/events","html_url":"https://github.com/leapmotion/UnityModules/issues/494","id":201758918,"number":494,"title":"ExecutionOrder.cs robustness issues","user":{"login":"nickjbenson","id":4485426,"avatar_url":"https://avatars0.githubusercontent.com/u/4485426?v=3","gravatar_id":"","url":"https://api.github.com/users/nickjbenson","html_url":"https://github.com/nickjbenson","followers_url":"https://api.github.com/users/nickjbenson/followers","following_url":"https://api.github.com/users/nickjbenson/following{/other_user}","gists_url":"https://api.github.com/users/nickjbenson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickjbenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickjbenson/subscriptions","organizations_url":"https://api.github.com/users/nickjbenson/orgs","repos_url":"https://api.github.com/users/nickjbenson/repos","events_url":"https://api.github.com/users/nickjbenson/events{/privacy}","received_events_url":"https://api.github.com/users/nickjbenson/received_events","type":"User","site_admin":false},"labels":[{"id":328437188,"url":"https://api.github.com/repos/leapmotion/UnityModules/labels/bug","name":"bug","color":"fc2929","default":true},{"id":525283835,"url":"https://api.github.com/repos/leapmotion/UnityModules/labels/DevX","name":"DevX","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"Amarcolina","id":5723312,"avatar_url":"https://avatars2.githubusercontent.com/u/5723312?v=3","gravatar_id":"","url":"https://api.github.com/users/Amarcolina","html_url":"https://github.com/Amarcolina","followers_url":"https://api.github.com/users/Amarcolina/followers","following_url":"https://api.github.com/users/Amarcolina/following{/other_user}","gists_url":"https://api.github.com/users/Amarcolina/gists{/gist_id}","starred_url":"https://api.github.com/users/Amarcolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amarcolina/subscriptions","organizations_url":"https://api.github.com/users/Amarcolina/orgs","repos_url":"https://api.github.com/users/Amarcolina/repos","events_url":"https://api.github.com/users/Amarcolina/events{/privacy}","received_events_url":"https://api.github.com/users/Amarcolina/received_events","type":"User","site_admin":false},"assignees":[{"login":"Amarcolina","id":5723312,"avatar_url":"https://avatars2.githubusercontent.com/u/5723312?v=3","gravatar_id":"","url":"https://api.github.com/users/Amarcolina","html_url":"https://github.com/Amarcolina","followers_url":"https://api.github.com/users/Amarcolina/followers","following_url":"https://api.github.com/users/Amarcolina/following{/other_user}","gists_url":"https://api.github.com/users/Amarcolina/gists{/gist_id}","starred_url":"https://api.github.com/users/Amarcolina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amarcolina/subscriptions","organizations_url":"https://api.github.com/users/Amarcolina/orgs","repos_url":"https://api.github.com/users/Amarcolina/repos","events_url":"https://api.github.com/users/Amarcolina/events{/privacy}","received_events_url":"https://api.github.com/users/Amarcolina/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-01-19T03:54:42Z","updated_at":"2017-06-21T18:04:23Z","closed_at":null,"body":"The [ExecuteBefore], [ExecuteAfter], and [ExecuteBeforeDefault]/[ExecuteAfterDefault] attributes were super handy to set up easily-readable (and flexible!) execution order constraints on-the-go while building parts of the UI module revamp, but after a number of compilations (and checkouts to and from other branches...) it started complaining, \"Not enough execution indexes to fit all of the scripts!\" This shouldn't be happening based solely on the attributes themselves; the doc comments' explanation of that error is definitely not what's going on.\r\n\r\nAssigning the author, Amarcolina. These attributes are pretty handy. It would be great if they were reliable... But if it's not worth it to fix it, we should remove them so users don't stumble upon them and hit upon these same issues."},"comment":{"url":"https://api.github.com/repos/leapmotion/UnityModules/issues/comments/310159378","html_url":"https://github.com/leapmotion/UnityModules/issues/494#issuecomment-310159378","issue_url":"https://api.github.com/repos/leapmotion/UnityModules/issues/494","id":310159378,"user":{"login":"nickjbenson","id":4485426,"avatar_url":"https://avatars0.githubusercontent.com/u/4485426?v=3","gravatar_id":"","url":"https://api.github.com/users/nickjbenson","html_url":"https://github.com/nickjbenson","followers_url":"https://api.github.com/users/nickjbenson/followers","following_url":"https://api.github.com/users/nickjbenson/following{/other_user}","gists_url":"https://api.github.com/users/nickjbenson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickjbenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickjbenson/subscriptions","organizations_url":"https://api.github.com/users/nickjbenson/orgs","repos_url":"https://api.github.com/users/nickjbenson/repos","events_url":"https://api.github.com/users/nickjbenson/events{/privacy}","received_events_url":"https://api.github.com/users/nickjbenson/received_events","type":"User","site_admin":false},"created_at":"2017-06-21T18:04:23Z","updated_at":"2017-06-21T18:04:23Z","body":"I am in support of removing the attribute in favor of event-based systems or manager systems.\r\n\r\nIn the Interaction Engine, we resolve execution order problems by having everything IE choreographed by the Interaction Manager. This is basically the same as having an Component-System configuration, where InteractionBehaviours are the Components updated by the InteractionManager system. Same deal with the Graphic Renderer component and Feature subcomponents. We'll probably use this pattern a lot.\r\n\r\nThe Hand Controller is a different story, since it can't really be a global manager for all hand-related things, so an event-based model makes more sense and is actually what it uses.\r\n\r\nIn other words, I don't think it's worth maintaining this feature, since we have good alternatives."}}
{"actor":{"display_login":"nickjbenson"}}