{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/8525","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/8525/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/8525/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/8525/events","html_url":"https://github.com/eslint/eslint/pull/8525","id":225244956,"number":8525,"title":"Update default.yml, turn off comma-dangle","user":{"login":"Aladdin-ADD","id":13050025,"avatar_url":"https://avatars1.githubusercontent.com/u/13050025?v=3","gravatar_id":"","url":"https://api.github.com/users/Aladdin-ADD","html_url":"https://github.com/Aladdin-ADD","followers_url":"https://api.github.com/users/Aladdin-ADD/followers","following_url":"https://api.github.com/users/Aladdin-ADD/following{/other_user}","gists_url":"https://api.github.com/users/Aladdin-ADD/gists{/gist_id}","starred_url":"https://api.github.com/users/Aladdin-ADD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aladdin-ADD/subscriptions","organizations_url":"https://api.github.com/users/Aladdin-ADD/orgs","repos_url":"https://api.github.com/users/Aladdin-ADD/repos","events_url":"https://api.github.com/users/Aladdin-ADD/events{/privacy}","received_events_url":"https://api.github.com/users/Aladdin-ADD/received_events","type":"User","site_admin":false},"labels":[{"id":360091515,"url":"https://api.github.com/repos/eslint/eslint/labels/chore","name":"chore","color":"c2e0c6","default":false},{"id":255319420,"url":"https://api.github.com/repos/eslint/eslint/labels/evaluating","name":"evaluating","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-04-29T09:13:43Z","updated_at":"2017-04-29T14:40:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/8525","html_url":"https://github.com/eslint/eslint/pull/8525","diff_url":"https://github.com/eslint/eslint/pull/8525.diff","patch_url":"https://github.com/eslint/eslint/pull/8525.patch"},"body":"**What changes did you make? (Give an overview)**\r\nturn off the rule comma-dangle.\r\n\r\n**What is the purpose of this pull request?**\r\n>Trailing commas simplify adding and removing items to objects and arrays, since only the lines you are modifying must be touched. Another argument in favor of trailing commas is that it improves the clarity of diffs when an item is added or removed from an object or array:\r\n```js\r\n//Less clear:\r\n var foo = {\r\n-    bar: \"baz\",\r\n-    qux: \"quux\"\r\n+    bar: \"baz\"\r\n };\r\n//More clear:\r\n var foo = {\r\n     bar: \"baz\",\r\n-    qux: \"quux\",\r\n };\r\n```\r\nI think the rule is mainly for IE8 and below, for it will throw an error when it encounters trailing commas in JavaScript. But ESLint not run on it, so it's better to turn this rule off.\r\n"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/298173043","html_url":"https://github.com/eslint/eslint/pull/8525#issuecomment-298173043","issue_url":"https://api.github.com/repos/eslint/eslint/issues/8525","id":298173043,"user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars3.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"created_at":"2017-04-29T14:40:55Z","updated_at":"2017-04-29T14:40:55Z","body":"Why do you want to turn the rule off, rather than enforce one way or the other? (Currently we enforce that no trailing commas are allowed. Your PR description seems to suggest you want to enforce trailing commas for cleaner diffs, but your actual change is to turn the rule off entirely.)"}}
{"actor":{"display_login":"platinumazure"}}