{"action":"created","issue":{"url":"https://api.github.com/repos/gap-packages/smallgrp/issues/12","repository_url":"https://api.github.com/repos/gap-packages/smallgrp","labels_url":"https://api.github.com/repos/gap-packages/smallgrp/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/gap-packages/smallgrp/issues/12/comments","events_url":"https://api.github.com/repos/gap-packages/smallgrp/issues/12/events","html_url":"https://github.com/gap-packages/smallgrp/pull/12","id":255514982,"number":12,"title":"Add smlinfo.tst for coverage of gap/smlinfo.gi","user":{"login":"wilfwilson","id":8956868,"avatar_url":"https://avatars3.githubusercontent.com/u/8956868?v=4","gravatar_id":"","url":"https://api.github.com/users/wilfwilson","html_url":"https://github.com/wilfwilson","followers_url":"https://api.github.com/users/wilfwilson/followers","following_url":"https://api.github.com/users/wilfwilson/following{/other_user}","gists_url":"https://api.github.com/users/wilfwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/wilfwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilfwilson/subscriptions","organizations_url":"https://api.github.com/users/wilfwilson/orgs","repos_url":"https://api.github.com/users/wilfwilson/repos","events_url":"https://api.github.com/users/wilfwilson/events{/privacy}","received_events_url":"https://api.github.com/users/wilfwilson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-06T08:02:52Z","updated_at":"2017-09-06T08:14:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gap-packages/smallgrp/pulls/12","html_url":"https://github.com/gap-packages/smallgrp/pull/12","diff_url":"https://github.com/gap-packages/smallgrp/pull/12.diff","patch_url":"https://github.com/gap-packages/smallgrp/pull/12.patch"},"body":"This gives good code coverage of gap/smlinfo.gi\r\n\r\nI have one important question @markuspf: is it acceptable for me to make the change that I made to `gap/smlinfo.gi`? (It simply checks the argument). I'm not sure to what extent we are avoiding touching the code.\r\n\r\nThis change to `smlinfo.gi` of course means that there are a couple of diffs when the test file is run in GAP with the small groups library loaded, rather than the smallgrp package.\r\n\r\nThere is one additional diff, compared with running the file with the package/library loaded. It's this test:\r\n```\r\ngap> SmallGroupsInformation(15625);\r\n```\r\nTo my eye, the test output looks exactly the same, so it must be whitespace differences. But I can't think what would cause this."},"comment":{"url":"https://api.github.com/repos/gap-packages/smallgrp/issues/comments/327410064","html_url":"https://github.com/gap-packages/smallgrp/pull/12#issuecomment-327410064","issue_url":"https://api.github.com/repos/gap-packages/smallgrp/issues/12","id":327410064,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-09-06T08:14:42Z","updated_at":"2017-09-06T08:14:42Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=h1) Report\n> Merging [#12](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=desc) into [master](https://codecov.io/gh/gap-packages/smallgrp/commit/96db7ed6027ea19ebb26e7680f42061f5f328d64?src=pr&el=desc) will **increase** coverage by `12.33%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gap-packages/smallgrp/pull/12/graphs/tree.svg?height=150&src=pr&token=v2TzuEhAYk&width=650)](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           master      #12       +/-   ##\n===========================================\n+ Coverage   24.97%   37.31%   +12.33%     \n===========================================\n  Files          26       26               \n  Lines        4984     4987        +3     \n===========================================\n+ Hits         1245     1861      +616     \n+ Misses       3739     3126      -613\n```\n\n\n| [Impacted Files](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [gap/smlinfo.gi](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree#diff-Z2FwL3NtbGluZm8uZ2k=) | `99.62% <100%> (+99.62%)` | :arrow_up: |\n| [id9/idgrp9.g](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree#diff-aWQ5L2lkZ3JwOS5n) | `8.33% <0%> (+1.66%)` | :arrow_up: |\n| [small11/smlgp11.g](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree#diff-c21hbGwxMS9zbWxncDExLmc=) | `5% <0%> (+2.22%)` | :arrow_up: |\n| [small9/smlgp9.g](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree#diff-c21hbGw5L3NtbGdwOS5n) | `5.53% <0%> (+5.22%)` | :arrow_up: |\n| [small10/smlgp10.g](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree#diff-c21hbGwxMC9zbWxncDEwLmc=) | `46.3% <0%> (+41.37%)` | :arrow_up: |\n| [small2/smlgp2.g](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=tree#diff-c21hbGwyL3NtbGdwMi5n) | `82.84% <0%> (+61.91%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=footer). Last update [96db7ed...45846ad](https://codecov.io/gh/gap-packages/smallgrp/pull/12?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}