{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/130322771","pull_request_review_id":53183458,"id":130322771,"diff_hunk":"@@ -202,6 +202,13 @@ static void device_dump(Unit *u, FILE *f, const char *prefix) {\n                 prefix, strna(d->sysfs));\n }\n \n+_pure_ static int device_reload(Unit *u) {","path":"src/core/device.c","position":4,"original_position":4,"commit_id":"34be5bf54d23cc6aeb18339a79d95daa829d94dc","original_commit_id":"34be5bf54d23cc6aeb18339a79d95daa829d94dc","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"\"pure\" doesn appear right for this. This function returns a constant \"0\" anyway...","created_at":"2017-07-31T10:49:07Z","updated_at":"2017-07-31T11:04:02Z","html_url":"https://github.com/systemd/systemd/pull/6428#discussion_r130322771","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/6428","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/130322771"},"html":{"href":"https://github.com/systemd/systemd/pull/6428#discussion_r130322771"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6428"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/6428","id":131903059,"html_url":"https://github.com/systemd/systemd/pull/6428","diff_url":"https://github.com/systemd/systemd/pull/6428.diff","patch_url":"https://github.com/systemd/systemd/pull/6428.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/6428","number":6428,"state":"open","locked":false,"title":"device : reload when udev generates a \"changed\" event","user":{"login":"boucman","id":1793617,"avatar_url":"https://avatars1.githubusercontent.com/u/1793617?v=4","gravatar_id":"","url":"https://api.github.com/users/boucman","html_url":"https://github.com/boucman","followers_url":"https://api.github.com/users/boucman/followers","following_url":"https://api.github.com/users/boucman/following{/other_user}","gists_url":"https://api.github.com/users/boucman/gists{/gist_id}","starred_url":"https://api.github.com/users/boucman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boucman/subscriptions","organizations_url":"https://api.github.com/users/boucman/orgs","repos_url":"https://api.github.com/users/boucman/repos","events_url":"https://api.github.com/users/boucman/events{/privacy}","received_events_url":"https://api.github.com/users/boucman/received_events","type":"User","site_admin":false},"body":"This commit allows services to react to a device \"changed\" event\r\n\r\nThe commit adds a reload handler to device units (which does nothing). Normal services can use ReloadPropagatedFrom to react to device changes.\r\n\r\nI have made .device reloads trigger a trace in systemd (Reloade unit xxx) I am not sure if that's ok or if that would make too much noise. It's trivial to change.\r\n\r\nI had a tricky problem with the reload job for the unit being GC before being executed. That makes sense with how the monitor main loop works, but I was not able to figure out how other unit-types avoid that. I'll gladly rework that part if someone gives me some pointers","created_at":"2017-07-22T15:35:20Z","updated_at":"2017-07-31T11:04:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd87e1cf0b2bdf4e321f2c2013cb53c95c7bcbfe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/6428/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/6428/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/6428/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/34be5bf54d23cc6aeb18339a79d95daa829d94dc","head":{"label":"boucman:device_reload","ref":"device_reload","sha":"34be5bf54d23cc6aeb18339a79d95daa829d94dc","user":{"login":"boucman","id":1793617,"avatar_url":"https://avatars1.githubusercontent.com/u/1793617?v=4","gravatar_id":"","url":"https://api.github.com/users/boucman","html_url":"https://github.com/boucman","followers_url":"https://api.github.com/users/boucman/followers","following_url":"https://api.github.com/users/boucman/following{/other_user}","gists_url":"https://api.github.com/users/boucman/gists{/gist_id}","starred_url":"https://api.github.com/users/boucman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boucman/subscriptions","organizations_url":"https://api.github.com/users/boucman/orgs","repos_url":"https://api.github.com/users/boucman/repos","events_url":"https://api.github.com/users/boucman/events{/privacy}","received_events_url":"https://api.github.com/users/boucman/received_events","type":"User","site_admin":false},"repo":{"id":95039809,"name":"systemd","full_name":"boucman/systemd","owner":{"login":"boucman","id":1793617,"avatar_url":"https://avatars1.githubusercontent.com/u/1793617?v=4","gravatar_id":"","url":"https://api.github.com/users/boucman","html_url":"https://github.com/boucman","followers_url":"https://api.github.com/users/boucman/followers","following_url":"https://api.github.com/users/boucman/following{/other_user}","gists_url":"https://api.github.com/users/boucman/gists{/gist_id}","starred_url":"https://api.github.com/users/boucman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boucman/subscriptions","organizations_url":"https://api.github.com/users/boucman/orgs","repos_url":"https://api.github.com/users/boucman/repos","events_url":"https://api.github.com/users/boucman/events{/privacy}","received_events_url":"https://api.github.com/users/boucman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boucman/systemd","description":"systemd System and Service Manager","fork":true,"url":"https://api.github.com/repos/boucman/systemd","forks_url":"https://api.github.com/repos/boucman/systemd/forks","keys_url":"https://api.github.com/repos/boucman/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boucman/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boucman/systemd/teams","hooks_url":"https://api.github.com/repos/boucman/systemd/hooks","issue_events_url":"https://api.github.com/repos/boucman/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/boucman/systemd/events","assignees_url":"https://api.github.com/repos/boucman/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/boucman/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/boucman/systemd/tags","blobs_url":"https://api.github.com/repos/boucman/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boucman/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boucman/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/boucman/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boucman/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/boucman/systemd/languages","stargazers_url":"https://api.github.com/repos/boucman/systemd/stargazers","contributors_url":"https://api.github.com/repos/boucman/systemd/contributors","subscribers_url":"https://api.github.com/repos/boucman/systemd/subscribers","subscription_url":"https://api.github.com/repos/boucman/systemd/subscription","commits_url":"https://api.github.com/repos/boucman/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/boucman/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/boucman/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/boucman/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/boucman/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/boucman/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boucman/systemd/merges","archive_url":"https://api.github.com/repos/boucman/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boucman/systemd/downloads","issues_url":"https://api.github.com/repos/boucman/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/boucman/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/boucman/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/boucman/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boucman/systemd/labels{/name}","releases_url":"https://api.github.com/repos/boucman/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/boucman/systemd/deployments","created_at":"2017-06-21T19:43:51Z","updated_at":"2017-06-21T19:44:00Z","pushed_at":"2017-07-22T15:31:09Z","git_url":"git://github.com/boucman/systemd.git","ssh_url":"git@github.com:boucman/systemd.git","clone_url":"https://github.com/boucman/systemd.git","svn_url":"https://github.com/boucman/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":72599,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"c702bd3b6989446048f01815a1e7b35eb0030309","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd System and Service Manager","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2017-07-30T19:04:14Z","pushed_at":"2017-07-31T11:03:02Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":72960,"stargazers_count":2091,"watchers_count":2091,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":882,"mirror_url":null,"open_issues_count":726,"forks":882,"open_issues":726,"watchers":2091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6428"},"html":{"href":"https://github.com/systemd/systemd/pull/6428"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/6428"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/6428/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6428/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6428/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/34be5bf54d23cc6aeb18339a79d95daa829d94dc"}}}}
{"actor":{"display_login":"poettering"}}