{"action":"created","issue":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/413","repository_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module","labels_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/413/labels{/name}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/413/comments","events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/413/events","html_url":"https://github.com/cisco/cisco-network-puppet-module/issues/413","id":200772035,"number":413,"title":"Update README-agent-install for guestshell puppet.service file","user":{"login":"tomcooperca","id":23202065,"avatar_url":"https://avatars.githubusercontent.com/u/23202065?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcooperca","html_url":"https://github.com/tomcooperca","followers_url":"https://api.github.com/users/tomcooperca/followers","following_url":"https://api.github.com/users/tomcooperca/following{/other_user}","gists_url":"https://api.github.com/users/tomcooperca/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcooperca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcooperca/subscriptions","organizations_url":"https://api.github.com/users/tomcooperca/orgs","repos_url":"https://api.github.com/users/tomcooperca/repos","events_url":"https://api.github.com/users/tomcooperca/events{/privacy}","received_events_url":"https://api.github.com/users/tomcooperca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-14T01:53:36Z","updated_at":"2017-01-17T21:22:02Z","closed_at":null,"body":"There is an issue with the /bin/nsenter ExecStart in the puppet.service file for guestshell users.\r\nWhen using the edited .service file from the README, the service never starts as nsenter complains about \"unknown arguments\". A separator ('--') is required between the --net option and the /opt/puppetlabs... command being piped to it.\r\nSee below:\r\n\r\n`systemctl status puppet` using puppet.service from README:\r\n\r\n```\r\npuppet.service - Puppet agent\r\n   Loaded: loaded (/usr/lib/systemd/system/puppet.service; enabled)\r\n   Active: failed (Result: exit-code) since Sat 2017-01-14 01:38:12 UTC; 1min 9s ago\r\n  Process: 3819 ExecStart=/bin/nsenter --net=/var/run/netns/management /opt/puppetlabs/puppet/bin/puppet agent $PUPPET_EXTRA_OPTS --no\r\n-daemonize (code=exited, status=1/FAILURE)\r\n Main PID: 3819 (code=exited, status=1/FAILURE)\r\n\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -u, --uts   [=<file>]  enter UTS namespace (hostname etc)\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -i, --ipc   [=<file>]  enter System V IPC namespace\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -n, --net   [=<file>]  enter network namespace\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -p, --pid   [=<file>]  enter pid namespace\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -r, --root  [=<dir>]   set the root directory\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -w, --wd    [=<dir>]   set the working directory\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -F, --no-fork          do not fork before exec'ing <program>\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -h, --help     display this help and exit\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: -V, --version  output version information and exit\r\nJan 14 01:38:12 sb2sf02bl01 nsenter[3819]: For more details see nsenter(1).\r\n```\r\n\r\nRunning it manually:\r\n\r\n```\r\n[root@switch ~]# /bin/nsenter --net=/var/run/netns/management /opt/puppetlabs/puppet/bin/puppet agent $PUPPET_EXTRA_OPTS --no-daemonize\r\n**/bin/nsenter: unrecognized option '--no-daemonize'**\r\n\r\nUsage:\r\n nsenter [options] <program> [args...]\r\n\r\nOptions:\r\n -t, --target <pid>     target process to get namespaces from\r\n<truncated>\r\n```\r\n\r\nAfter change:\r\n\r\n```\r\n[root@switch ~]# diff puppet.service_notworking puppet.service_working \r\n10c10\r\n< ExecStart=/bin/nsenter --net=/var/run/netns/management /opt/puppetlabs/puppet/bin/puppet agent $PUPPET_EXTRA_OPTS --no-daemonize\r\n---\r\n> ExecStart=/bin/nsenter --net=/var/run/netns/management -- /opt/puppetlabs/puppet/bin/puppet agent $PUPPET_EXTRA_OPTS --no-daemonize\r\n\r\n[root@switch ~]# systemctl status puppet\r\npuppet.service - Puppet agent\r\n   Loaded: loaded (/usr/lib/systemd/system/puppet.service; enabled)\r\n   Active: active (running) since Sat 2017-01-14 01:47:30 UTC; 4s ago\r\n Main PID: 3981 (puppet)\r\n   CGroup: /system.slice/puppet.service\r\n\r\nJan 14 01:47:30 sb2sf02bl01 nsenter[3981]: Executing: /bin/nsenter --net=/var/run/netns/management -- /opt/puppetlabs/puppet/bin/puppet agent --waitforcert=500 --no-daemonize\r\n```"},"comment":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/comments/273303748","html_url":"https://github.com/cisco/cisco-network-puppet-module/issues/413#issuecomment-273303748","issue_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/413","id":273303748,"user":{"login":"mikewiebe","id":12445795,"avatar_url":"https://avatars.githubusercontent.com/u/12445795?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewiebe","html_url":"https://github.com/mikewiebe","followers_url":"https://api.github.com/users/mikewiebe/followers","following_url":"https://api.github.com/users/mikewiebe/following{/other_user}","gists_url":"https://api.github.com/users/mikewiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewiebe/subscriptions","organizations_url":"https://api.github.com/users/mikewiebe/orgs","repos_url":"https://api.github.com/users/mikewiebe/repos","events_url":"https://api.github.com/users/mikewiebe/events{/privacy}","received_events_url":"https://api.github.com/users/mikewiebe/received_events","type":"User","site_admin":false},"created_at":"2017-01-17T21:22:02Z","updated_at":"2017-01-17T21:22:02Z","body":"@tomcooperca Thanks for pointing out the issue in the README!  We will be sure to make the correction in our develop branch so the change is reflected in our next release."}}
{"actor":{"display_login":"mikewiebe"}}