{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2135","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2135/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2135/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2135/events","html_url":"https://github.com/greenplum-db/gpdb/pull/2135","id":218329780,"number":2135,"title":"Remove underutilized CdbCellbuf facility.","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars1.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-30T21:13:10Z","updated_at":"2017-04-01T08:11:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2135","html_url":"https://github.com/greenplum-db/gpdb/pull/2135","diff_url":"https://github.com/greenplum-db/gpdb/pull/2135.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/2135.patch"},"body":"It was only used in hash aggregates, and it only used a fraction of the\r\nfunctionality. In essence, it was using it as a very simple memory\r\nallocator, where each allocation was fixed size, and the only way to free\r\nwas to reset the whole cellbuf. But the same code was using a different,\r\nbut similar, mpool_* mechanism for allocating other things stored in\r\nthe hash buckets. We might as well use mpool_alloc for the HashAggEntry\r\nstruct as well, and get rid of all the cellbuf code."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/290904695","html_url":"https://github.com/greenplum-db/gpdb/pull/2135#issuecomment-290904695","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2135","id":290904695,"user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars1.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"created_at":"2017-04-01T08:11:52Z","updated_at":"2017-04-01T08:11:52Z","body":"Thanks @hardikar, I had not spotted cdbptrbuf.h! Removed that too.\r\n\r\nYeah, I would assume mpool_alloc to be at least as fast as cdbcellbuf. I haven't done any performance testing, though."}}
{"actor":{"display_login":"hlinnaka"}}