{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/26","id":154674876,"html_url":"https://github.com/laboshinl/loam_velodyne/pull/26","diff_url":"https://github.com/laboshinl/loam_velodyne/pull/26.diff","patch_url":"https://github.com/laboshinl/loam_velodyne/pull/26.patch","issue_url":"https://api.github.com/repos/laboshinl/loam_velodyne/issues/26","number":26,"state":"open","locked":false,"title":"Considerable speedup using Nanoflann instead of pcl::KDTreeFLANN ","user":{"login":"facontidavide","id":2822888,"avatar_url":"https://avatars2.githubusercontent.com/u/2822888?v=4","gravatar_id":"","url":"https://api.github.com/users/facontidavide","html_url":"https://github.com/facontidavide","followers_url":"https://api.github.com/users/facontidavide/followers","following_url":"https://api.github.com/users/facontidavide/following{/other_user}","gists_url":"https://api.github.com/users/facontidavide/gists{/gist_id}","starred_url":"https://api.github.com/users/facontidavide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facontidavide/subscriptions","organizations_url":"https://api.github.com/users/facontidavide/orgs","repos_url":"https://api.github.com/users/facontidavide/repos","events_url":"https://api.github.com/users/facontidavide/events{/privacy}","received_events_url":"https://api.github.com/users/facontidavide/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\ndoing some further profiling I noticed that most of time spent in laserMapping and laserOdometry is spent calculating the nearest neighbors with pcl::KDTreeFLANN.\r\n\r\nJust for fun I tested [nanoflann](https://github.com/jlblancoc/nanoflann) and I got very good results.\r\nlaserMapping is more or less 2X faster and laserOdometry 1.4X faster.\r\n\r\nI modified slightly the code of nanoflann and added an adapter to have a class that resemble exactly the PCL one.\r\n\r\nBy the way, this PR is based on the PR #24 , so may be you want to merge that first. \r\n","created_at":"2017-11-26T11:29:49Z","updated_at":"2017-11-26T11:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/26/commits","review_comments_url":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/26/comments","review_comment_url":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laboshinl/loam_velodyne/issues/26/comments","statuses_url":"https://api.github.com/repos/laboshinl/loam_velodyne/statuses/6e1510b7f7bd2e167e3c0b374a0e4d61219a3ea8","head":{"label":"Eurecat:nanoflann","ref":"nanoflann","sha":"6e1510b7f7bd2e167e3c0b374a0e4d61219a3ea8","user":{"login":"Eurecat","id":30143446,"avatar_url":"https://avatars0.githubusercontent.com/u/30143446?v=4","gravatar_id":"","url":"https://api.github.com/users/Eurecat","html_url":"https://github.com/Eurecat","followers_url":"https://api.github.com/users/Eurecat/followers","following_url":"https://api.github.com/users/Eurecat/following{/other_user}","gists_url":"https://api.github.com/users/Eurecat/gists{/gist_id}","starred_url":"https://api.github.com/users/Eurecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eurecat/subscriptions","organizations_url":"https://api.github.com/users/Eurecat/orgs","repos_url":"https://api.github.com/users/Eurecat/repos","events_url":"https://api.github.com/users/Eurecat/events{/privacy}","received_events_url":"https://api.github.com/users/Eurecat/received_events","type":"Organization","site_admin":false},"repo":{"id":111844393,"name":"loam_velodyne","full_name":"Eurecat/loam_velodyne","owner":{"login":"Eurecat","id":30143446,"avatar_url":"https://avatars0.githubusercontent.com/u/30143446?v=4","gravatar_id":"","url":"https://api.github.com/users/Eurecat","html_url":"https://github.com/Eurecat","followers_url":"https://api.github.com/users/Eurecat/followers","following_url":"https://api.github.com/users/Eurecat/following{/other_user}","gists_url":"https://api.github.com/users/Eurecat/gists{/gist_id}","starred_url":"https://api.github.com/users/Eurecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eurecat/subscriptions","organizations_url":"https://api.github.com/users/Eurecat/orgs","repos_url":"https://api.github.com/users/Eurecat/repos","events_url":"https://api.github.com/users/Eurecat/events{/privacy}","received_events_url":"https://api.github.com/users/Eurecat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eurecat/loam_velodyne","description":"Laser Odometry and Mapping (Loam) is a realtime method for state estimation and mapping using a 3D lidar.","fork":true,"url":"https://api.github.com/repos/Eurecat/loam_velodyne","forks_url":"https://api.github.com/repos/Eurecat/loam_velodyne/forks","keys_url":"https://api.github.com/repos/Eurecat/loam_velodyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eurecat/loam_velodyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eurecat/loam_velodyne/teams","hooks_url":"https://api.github.com/repos/Eurecat/loam_velodyne/hooks","issue_events_url":"https://api.github.com/repos/Eurecat/loam_velodyne/issues/events{/number}","events_url":"https://api.github.com/repos/Eurecat/loam_velodyne/events","assignees_url":"https://api.github.com/repos/Eurecat/loam_velodyne/assignees{/user}","branches_url":"https://api.github.com/repos/Eurecat/loam_velodyne/branches{/branch}","tags_url":"https://api.github.com/repos/Eurecat/loam_velodyne/tags","blobs_url":"https://api.github.com/repos/Eurecat/loam_velodyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eurecat/loam_velodyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eurecat/loam_velodyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eurecat/loam_velodyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eurecat/loam_velodyne/statuses/{sha}","languages_url":"https://api.github.com/repos/Eurecat/loam_velodyne/languages","stargazers_url":"https://api.github.com/repos/Eurecat/loam_velodyne/stargazers","contributors_url":"https://api.github.com/repos/Eurecat/loam_velodyne/contributors","subscribers_url":"https://api.github.com/repos/Eurecat/loam_velodyne/subscribers","subscription_url":"https://api.github.com/repos/Eurecat/loam_velodyne/subscription","commits_url":"https://api.github.com/repos/Eurecat/loam_velodyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eurecat/loam_velodyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eurecat/loam_velodyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eurecat/loam_velodyne/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eurecat/loam_velodyne/contents/{+path}","compare_url":"https://api.github.com/repos/Eurecat/loam_velodyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eurecat/loam_velodyne/merges","archive_url":"https://api.github.com/repos/Eurecat/loam_velodyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eurecat/loam_velodyne/downloads","issues_url":"https://api.github.com/repos/Eurecat/loam_velodyne/issues{/number}","pulls_url":"https://api.github.com/repos/Eurecat/loam_velodyne/pulls{/number}","milestones_url":"https://api.github.com/repos/Eurecat/loam_velodyne/milestones{/number}","notifications_url":"https://api.github.com/repos/Eurecat/loam_velodyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eurecat/loam_velodyne/labels{/name}","releases_url":"https://api.github.com/repos/Eurecat/loam_velodyne/releases{/id}","deployments_url":"https://api.github.com/repos/Eurecat/loam_velodyne/deployments","created_at":"2017-11-23T19:37:13Z","updated_at":"2017-11-23T19:37:15Z","pushed_at":"2017-11-26T10:41:07Z","git_url":"git://github.com/Eurecat/loam_velodyne.git","ssh_url":"git@github.com:Eurecat/loam_velodyne.git","clone_url":"https://github.com/Eurecat/loam_velodyne.git","svn_url":"https://github.com/Eurecat/loam_velodyne","homepage":"http://wiki.ros.org/loam_velodyne","size":833,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laboshinl:master","ref":"master","sha":"2bc3b1bf53accf1b1084cc8df15ee93f711cef3a","user":{"login":"laboshinl","id":2180161,"avatar_url":"https://avatars1.githubusercontent.com/u/2180161?v=4","gravatar_id":"","url":"https://api.github.com/users/laboshinl","html_url":"https://github.com/laboshinl","followers_url":"https://api.github.com/users/laboshinl/followers","following_url":"https://api.github.com/users/laboshinl/following{/other_user}","gists_url":"https://api.github.com/users/laboshinl/gists{/gist_id}","starred_url":"https://api.github.com/users/laboshinl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laboshinl/subscriptions","organizations_url":"https://api.github.com/users/laboshinl/orgs","repos_url":"https://api.github.com/users/laboshinl/repos","events_url":"https://api.github.com/users/laboshinl/events{/privacy}","received_events_url":"https://api.github.com/users/laboshinl/received_events","type":"User","site_admin":false},"repo":{"id":51070210,"name":"loam_velodyne","full_name":"laboshinl/loam_velodyne","owner":{"login":"laboshinl","id":2180161,"avatar_url":"https://avatars1.githubusercontent.com/u/2180161?v=4","gravatar_id":"","url":"https://api.github.com/users/laboshinl","html_url":"https://github.com/laboshinl","followers_url":"https://api.github.com/users/laboshinl/followers","following_url":"https://api.github.com/users/laboshinl/following{/other_user}","gists_url":"https://api.github.com/users/laboshinl/gists{/gist_id}","starred_url":"https://api.github.com/users/laboshinl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laboshinl/subscriptions","organizations_url":"https://api.github.com/users/laboshinl/orgs","repos_url":"https://api.github.com/users/laboshinl/repos","events_url":"https://api.github.com/users/laboshinl/events{/privacy}","received_events_url":"https://api.github.com/users/laboshinl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laboshinl/loam_velodyne","description":"Laser Odometry and Mapping (Loam) is a realtime method for state estimation and mapping using a 3D lidar.","fork":false,"url":"https://api.github.com/repos/laboshinl/loam_velodyne","forks_url":"https://api.github.com/repos/laboshinl/loam_velodyne/forks","keys_url":"https://api.github.com/repos/laboshinl/loam_velodyne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laboshinl/loam_velodyne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laboshinl/loam_velodyne/teams","hooks_url":"https://api.github.com/repos/laboshinl/loam_velodyne/hooks","issue_events_url":"https://api.github.com/repos/laboshinl/loam_velodyne/issues/events{/number}","events_url":"https://api.github.com/repos/laboshinl/loam_velodyne/events","assignees_url":"https://api.github.com/repos/laboshinl/loam_velodyne/assignees{/user}","branches_url":"https://api.github.com/repos/laboshinl/loam_velodyne/branches{/branch}","tags_url":"https://api.github.com/repos/laboshinl/loam_velodyne/tags","blobs_url":"https://api.github.com/repos/laboshinl/loam_velodyne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laboshinl/loam_velodyne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laboshinl/loam_velodyne/git/refs{/sha}","trees_url":"https://api.github.com/repos/laboshinl/loam_velodyne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laboshinl/loam_velodyne/statuses/{sha}","languages_url":"https://api.github.com/repos/laboshinl/loam_velodyne/languages","stargazers_url":"https://api.github.com/repos/laboshinl/loam_velodyne/stargazers","contributors_url":"https://api.github.com/repos/laboshinl/loam_velodyne/contributors","subscribers_url":"https://api.github.com/repos/laboshinl/loam_velodyne/subscribers","subscription_url":"https://api.github.com/repos/laboshinl/loam_velodyne/subscription","commits_url":"https://api.github.com/repos/laboshinl/loam_velodyne/commits{/sha}","git_commits_url":"https://api.github.com/repos/laboshinl/loam_velodyne/git/commits{/sha}","comments_url":"https://api.github.com/repos/laboshinl/loam_velodyne/comments{/number}","issue_comment_url":"https://api.github.com/repos/laboshinl/loam_velodyne/issues/comments{/number}","contents_url":"https://api.github.com/repos/laboshinl/loam_velodyne/contents/{+path}","compare_url":"https://api.github.com/repos/laboshinl/loam_velodyne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laboshinl/loam_velodyne/merges","archive_url":"https://api.github.com/repos/laboshinl/loam_velodyne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laboshinl/loam_velodyne/downloads","issues_url":"https://api.github.com/repos/laboshinl/loam_velodyne/issues{/number}","pulls_url":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls{/number}","milestones_url":"https://api.github.com/repos/laboshinl/loam_velodyne/milestones{/number}","notifications_url":"https://api.github.com/repos/laboshinl/loam_velodyne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laboshinl/loam_velodyne/labels{/name}","releases_url":"https://api.github.com/repos/laboshinl/loam_velodyne/releases{/id}","deployments_url":"https://api.github.com/repos/laboshinl/loam_velodyne/deployments","created_at":"2016-02-04T11:01:02Z","updated_at":"2017-11-24T10:53:40Z","pushed_at":"2017-11-25T10:19:12Z","git_url":"git://github.com/laboshinl/loam_velodyne.git","ssh_url":"git@github.com:laboshinl/loam_velodyne.git","clone_url":"https://github.com/laboshinl/loam_velodyne.git","svn_url":"https://github.com/laboshinl/loam_velodyne","homepage":"http://wiki.ros.org/loam_velodyne","size":784,"stargazers_count":193,"watchers_count":193,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":268,"mirror_url":null,"archived":false,"open_issues_count":15,"forks":268,"open_issues":15,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/26"},"html":{"href":"https://github.com/laboshinl/loam_velodyne/pull/26"},"issue":{"href":"https://api.github.com/repos/laboshinl/loam_velodyne/issues/26"},"comments":{"href":"https://api.github.com/repos/laboshinl/loam_velodyne/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laboshinl/loam_velodyne/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/laboshinl/loam_velodyne/statuses/6e1510b7f7bd2e167e3c0b374a0e4d61219a3ea8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":2369,"deletions":184,"changed_files":7}}
{"actor":{"display_login":"facontidavide"}}