{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/remix/pulls/comments/112508510","pull_request_review_id":33830010,"id":112508510,"diff_hunk":"@@ -62,18 +62,18 @@ function storageRangeInternal (self, slotKey, tx, stepIndex, address, callback)\n   if (cached && cached.storage[slotKey]) { // we have the current slot in the cache and maybe the next 1000...\n     return callback(null, cached.storage)\n   }\n-  storageRangeWeb3Call(tx, address, slotKey, self.maxSize, (error, storage, complete) => {\n+  storageRangeWeb3Call(tx, address, slotKey, self.maxSize, (error, storage, nextKey) => {\n     if (error) {\n       return callback(error)\n     }\n-    if (!storage[slotKey]) {\n+    if (!storage[slotKey] && slotKey !== zeroSlot) { // we don't cache the zero slot (could lead to inconsistency)","path":"src/storage/storageResolver.js","position":10,"original_position":10,"commit_id":"b03c67075e70fe0c79d8be140f6aa9525c9979bd","original_commit_id":"b03c67075e70fe0c79d8be140f6aa9525c9979bd","user":{"login":"yann300","id":6940742,"avatar_url":"https://avatars1.githubusercontent.com/u/6940742?v=3","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false},"body":"Because the storage actually stores only hashed key now and `zeroSlot` is obviously not a hashed key.\r\n","created_at":"2017-04-20T17:13:08Z","updated_at":"2017-04-20T17:13:08Z","html_url":"https://github.com/ethereum/remix/pull/489#discussion_r112508510","pull_request_url":"https://api.github.com/repos/ethereum/remix/pulls/489","_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments/112508510"},"html":{"href":"https://github.com/ethereum/remix/pull/489#discussion_r112508510"},"pull_request":{"href":"https://api.github.com/repos/ethereum/remix/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/remix/pulls/489","id":116760084,"html_url":"https://github.com/ethereum/remix/pull/489","diff_url":"https://github.com/ethereum/remix/pull/489.diff","patch_url":"https://github.com/ethereum/remix/pull/489.patch","issue_url":"https://api.github.com/repos/ethereum/remix/issues/489","number":489,"state":"open","locked":false,"title":"Fix storage","user":{"login":"yann300","id":6940742,"avatar_url":"https://avatars1.githubusercontent.com/u/6940742?v=3","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false},"body":" - fix various bugs in storageResolver\r\n - use the new `storageRangeAt` implementation: `complete` flag is replaced by `nextKey` ","created_at":"2017-04-20T12:32:43Z","updated_at":"2017-04-20T17:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f624fe8ddc14f5994835dac12b7317ea516b1b25","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/remix/pulls/489/commits","review_comments_url":"https://api.github.com/repos/ethereum/remix/pulls/489/comments","review_comment_url":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/remix/issues/489/comments","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/b03c67075e70fe0c79d8be140f6aa9525c9979bd","head":{"label":"ethereum:fixStorage","ref":"fixStorage","sha":"b03c67075e70fe0c79d8be140f6aa9525c9979bd","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2017-04-14T15:04:09Z","pushed_at":"2017-04-20T12:36:47Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"git@github.com:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":5383,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":23,"forks":44,"open_issues":23,"watchers":102,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"5ef4a06fea610e126213e7fcdae50843eb1ebf45","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2017-04-14T15:04:09Z","pushed_at":"2017-04-20T12:36:47Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"git@github.com:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":5383,"stargazers_count":102,"watchers_count":102,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":23,"forks":44,"open_issues":23,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/489"},"html":{"href":"https://github.com/ethereum/remix/pull/489"},"issue":{"href":"https://api.github.com/repos/ethereum/remix/issues/489"},"comments":{"href":"https://api.github.com/repos/ethereum/remix/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/remix/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/remix/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/remix/statuses/b03c67075e70fe0c79d8be140f6aa9525c9979bd"}}}}
{"actor":{"display_login":"yann300"}}