{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/comments/147725385","pull_request_review_id":72861222,"id":147725385,"diff_hunk":"@@ -43,7 +43,7 @@ var _ = Describe(\"DatadogClient\", func() {\n \t\t\t\"test-deployment\",\n \t\t\t\"dummy-ip\",\n \t\t\ttime.Second,\n-\t\t\t1024,\n+\t\t\t1500,","path":"datadogclient/datadog_client_test.go","position":5,"original_position":5,"commit_id":"18c28b5962803f6c40949b2a1c45d99876a9b9dd","original_commit_id":"18c28b5962803f6c40949b2a1c45d99876a9b9dd","user":{"login":"gmmeyer","id":3253673,"avatar_url":"https://avatars1.githubusercontent.com/u/3253673?v=4","gravatar_id":"","url":"https://api.github.com/users/gmmeyer","html_url":"https://github.com/gmmeyer","followers_url":"https://api.github.com/users/gmmeyer/followers","following_url":"https://api.github.com/users/gmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/gmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/gmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmmeyer/subscriptions","organizations_url":"https://api.github.com/users/gmmeyer/orgs","repos_url":"https://api.github.com/users/gmmeyer/repos","events_url":"https://api.github.com/users/gmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/gmmeyer/received_events","type":"User","site_admin":false},"body":"Why did you increase this?","created_at":"2017-10-30T14:48:25Z","updated_at":"2017-10-30T14:52:52Z","html_url":"https://github.com/DataDog/datadog-firehose-nozzle/pull/16#discussion_r147725385","pull_request_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/comments/147725385"},"html":{"href":"https://github.com/DataDog/datadog-firehose-nozzle/pull/16#discussion_r147725385"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16","id":149239345,"html_url":"https://github.com/DataDog/datadog-firehose-nozzle/pull/16","diff_url":"https://github.com/DataDog/datadog-firehose-nozzle/pull/16.diff","patch_url":"https://github.com/DataDog/datadog-firehose-nozzle/pull/16.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/16","number":16,"state":"open","locked":false,"title":"Send metric twice, with old & new name","user":{"login":"ISauve","id":11351618,"avatar_url":"https://avatars3.githubusercontent.com/u/11351618?v=4","gravatar_id":"","url":"https://api.github.com/users/ISauve","html_url":"https://github.com/ISauve","followers_url":"https://api.github.com/users/ISauve/followers","following_url":"https://api.github.com/users/ISauve/following{/other_user}","gists_url":"https://api.github.com/users/ISauve/gists{/gist_id}","starred_url":"https://api.github.com/users/ISauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISauve/subscriptions","organizations_url":"https://api.github.com/users/ISauve/orgs","repos_url":"https://api.github.com/users/ISauve/repos","events_url":"https://api.github.com/users/ISauve/events{/privacy}","received_events_url":"https://api.github.com/users/ISauve/received_events","type":"User","site_admin":false},"body":"*Note: Please remember to review the Datadog [Contribution Guidelines](https://github.com/DataDog/dd-agent/blob/master/CONTRIBUTING.md)\r\nif you have not yet done so.*\r\n\r\n### What does this PR do?\r\n\r\nSends each metric twice, once named properly and once named \"the old way\" (aka containing the origin of the metric). For example: \r\n`cloudfoundry.nozzle.analyzer.memoryStats.numBytesAllocated` and `cloudfoundry.nozzle.memoryStats.numBytesAllocated`.\r\n\r\n### Motivation\r\n\r\nThe metric name shouldn't have the origin in it - this does not follow our best practices, and the origin name is already present as a tag. However, we can't outright change all the naming conventions, or we would break current user's dashboards/monitors; so as a compromise, we send the metric in both formats. \r\n\r\n### Testing Guidelines\r\n\r\nAn overview on [testing](https://github.com/DataDog/dd-agent/blob/master/tests/README.md)\r\nis available in our contribution guidelines.\r\n\r\n### Additional Notes\r\n\r\nAnything else we should know when reviewing?\r\n","created_at":"2017-10-27T17:01:01Z","updated_at":"2017-10-30T14:52:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"755bd83f2bcb8dc1193fc4a850f5d0f647e8ff1e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/16/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/statuses/18c28b5962803f6c40949b2a1c45d99876a9b9dd","head":{"label":"DataDog:isabelle/tags","ref":"isabelle/tags","sha":"18c28b5962803f6c40949b2a1c45d99876a9b9dd","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":87980083,"name":"datadog-firehose-nozzle","full_name":"DataDog/datadog-firehose-nozzle","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-firehose-nozzle","description":"CF component to forward metrics from the Loggregator Firehose to Datadog","fork":true,"url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle","forks_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/deployments","created_at":"2017-04-11T21:15:13Z","updated_at":"2017-06-30T04:14:46Z","pushed_at":"2017-10-30T14:15:50Z","git_url":"git://github.com/DataDog/datadog-firehose-nozzle.git","ssh_url":"git@github.com:DataDog/datadog-firehose-nozzle.git","clone_url":"https://github.com/DataDog/datadog-firehose-nozzle.git","svn_url":"https://github.com/DataDog/datadog-firehose-nozzle","homepage":"https://docs.datadoghq.com/integrations/cloud_foundry/","size":173,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"d281dcb2314e5d344012495b6380eb9d259c4ae1","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":87980083,"name":"datadog-firehose-nozzle","full_name":"DataDog/datadog-firehose-nozzle","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-firehose-nozzle","description":"CF component to forward metrics from the Loggregator Firehose to Datadog","fork":true,"url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle","forks_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/deployments","created_at":"2017-04-11T21:15:13Z","updated_at":"2017-06-30T04:14:46Z","pushed_at":"2017-10-30T14:15:50Z","git_url":"git://github.com/DataDog/datadog-firehose-nozzle.git","ssh_url":"git@github.com:DataDog/datadog-firehose-nozzle.git","clone_url":"https://github.com/DataDog/datadog-firehose-nozzle.git","svn_url":"https://github.com/DataDog/datadog-firehose-nozzle","homepage":"https://docs.datadoghq.com/integrations/cloud_foundry/","size":173,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16"},"html":{"href":"https://github.com/DataDog/datadog-firehose-nozzle/pull/16"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/16"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-firehose-nozzle/statuses/18c28b5962803f6c40949b2a1c45d99876a9b9dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"gmmeyer"}}