{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material2/issues/5488","repository_url":"https://api.github.com/repos/angular/material2","labels_url":"https://api.github.com/repos/angular/material2/issues/5488/labels{/name}","comments_url":"https://api.github.com/repos/angular/material2/issues/5488/comments","events_url":"https://api.github.com/repos/angular/material2/issues/5488/events","html_url":"https://github.com/angular/material2/issues/5488","id":240324371,"number":5488,"title":"icon: Keep symbol viewBox value when register an iconSet","user":{"login":"ilaborie","id":111920,"avatar_url":"https://avatars0.githubusercontent.com/u/111920?v=4","gravatar_id":"","url":"https://api.github.com/users/ilaborie","html_url":"https://github.com/ilaborie","followers_url":"https://api.github.com/users/ilaborie/followers","following_url":"https://api.github.com/users/ilaborie/following{/other_user}","gists_url":"https://api.github.com/users/ilaborie/gists{/gist_id}","starred_url":"https://api.github.com/users/ilaborie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilaborie/subscriptions","organizations_url":"https://api.github.com/users/ilaborie/orgs","repos_url":"https://api.github.com/users/ilaborie/repos","events_url":"https://api.github.com/users/ilaborie/events{/privacy}","received_events_url":"https://api.github.com/users/ilaborie/received_events","type":"User","site_admin":false},"labels":[{"id":618683764,"url":"https://api.github.com/repos/angular/material2/labels/P4:%20minor","name":"P4: minor","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-07-04T06:34:42Z","updated_at":"2017-11-24T15:30:11Z","closed_at":"2017-07-06T15:38:57Z","author_association":"NONE","body":"#### Bug, feature request, or proposal:\r\nBug\r\n\r\n#### What is the expected behavior?\r\nWhen registering an SVG iconSet, every symbol may provide a custom `viewBox` attribute. This attribute should be keep in the newly SVG element created.\r\n\r\n#### What is the current behavior?\r\nThe `viewBox` attribute is swallowed.\r\n\r\n#### What are the steps to reproduce?\r\n\r\n\r\n#### What is the use-case or motivation for changing an existing behavior?\r\n\r\n\r\n#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?\r\nAt least since beta 7\r\n\r\n#### Is there anything else we should know?\r\nThis is related to #5188 #2981\r\nFor SVG icon set with `symbol`, see <https://css-tricks.com/svg-symbol-good-choice-icons/>"},"comment":{"url":"https://api.github.com/repos/angular/material2/issues/comments/346852795","html_url":"https://github.com/angular/material2/issues/5488#issuecomment-346852795","issue_url":"https://api.github.com/repos/angular/material2/issues/5488","id":346852795,"user":{"login":"choucry13","id":9515435,"avatar_url":"https://avatars0.githubusercontent.com/u/9515435?v=4","gravatar_id":"","url":"https://api.github.com/users/choucry13","html_url":"https://github.com/choucry13","followers_url":"https://api.github.com/users/choucry13/followers","following_url":"https://api.github.com/users/choucry13/following{/other_user}","gists_url":"https://api.github.com/users/choucry13/gists{/gist_id}","starred_url":"https://api.github.com/users/choucry13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choucry13/subscriptions","organizations_url":"https://api.github.com/users/choucry13/orgs","repos_url":"https://api.github.com/users/choucry13/repos","events_url":"https://api.github.com/users/choucry13/events{/privacy}","received_events_url":"https://api.github.com/users/choucry13/received_events","type":"User","site_admin":false},"created_at":"2017-11-24T15:30:11Z","updated_at":"2017-11-24T15:30:11Z","author_association":"NONE","body":"hi, i don't see the fix of @ilaborie in the current MatIconRegistry ? The fix is current and I always need a override of MatIconRegistry  with this fix.\r\n"}}
{"actor":{"display_login":"choucry13"}}