{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/123038479","pull_request_review_id":45205719,"id":123038479,"diff_hunk":"@@ -0,0 +1,149 @@\n+#define GAINS_SHARP_ON_ACTIVE 1//Chainsaws I guess. Also eswords.\n+#define GAINS_EDGE_ON_ACTIVE 1\n+#define PARRY_REQUIRES_ACTIVE 1 //For energy weapons that need to be active to parry.\n+#define SPARKS_ON_PARRY 1 //For energy weapons that need to be active to parry.\n+\n+/obj/item/weapon/twohanded //Base type, never spawn this.\n+\ticon_state = \"DONGS\"\n+\tvar/wielded = 0\n+\tvar/force_wielded = 0\n+\tvar/unwielded_force_divisor = 0.25\n+\tvar/parry_chance = 15\n+\tvar/parry_sound = 'sound/weapons/punchmiss.ogg'\n+\tvar/active = 0 //So we don't have to use copy-paste procs with one more argument.\n+\n+/obj/item/weapon/twohanded/update_twohanding() //Lets us know if the weapon is being held in both hands\n+\tvar/mob/living/M = loc\n+\tif(istype(M) && M.can_wield_item(src) && is_held_twohanded(M))\n+\t\twielded = 1\n+\t\tforce = force_wielded\n+\t\tname = \"[initial(name)] (wielded)\"\n+\telse\n+\t\twielded = 0\n+\t\tforce = initial(force)\n+\t\tname = \"[initial(name)]\"\n+\tupdate_icon()\n+\t..()\n+\n+/obj/item/weapon/twohanded/New()\n+\t..()\n+\tupdate_icon()\n+\n+//Allow a small chance of parrying melee attacks when wielded\n+/obj/item/weapon/twohanded/handle_shield(mob/user, var/damage, atom/damage_source = null, mob/attacker = null, var/def_zone = null, var/attack_text = \"the attack\")\n+\tif(wielded && default_parry_check(user, attacker, damage_source) \\\n+&& prob(parry_chance) && PARRY_REQUIRES_ACTIVE <= active) // Last two conditions apply mostly to energy weapons. \\\n+\t\t                                                              <= means you can have a weapon that does not need to be active to parry.\n+\t\tuser.visible_message(\"<span class='danger'>\\The [user] parries [attack_text] with \\the [src]!</span>\")\n+\t\tif(SPARKS_ON_PARRY)\n+\t\t\tvar/datum/effect/effect/system/spark_spread/spark_system = new /datum/effect/effect/system/spark_spread()\n+\t\t\tspark_system.set_up(5, 0, user.loc)\n+\t\t\tspark_system.start()\n+\t\tplaysound(user.loc, parry_sound, 50, 1)\n+\t\treturn 1\n+\treturn 0\n+\n+/obj/item/weapon/twohanded/update_icon()\n+\ticon_state = \"[initial(icon)][wielded]\"\n+\titem_state_slots[slot_l_hand_str] = icon_state\n+\n+/*\n+ * Togglable weapons.\n+ */\n+\n+/obj/item/weapon/twohanded/toggled/ //Exists to hold variables. Do not spawn this.","path":"code/game/objects/items/weapons/melee/twohanded.dm","position":54,"original_position":54,"commit_id":"b8c79c15eec704f56771fa432232a2902099a8b1","original_commit_id":"b8c79c15eec704f56771fa432232a2902099a8b1","user":{"login":"Hubblenaut","id":6383576,"avatar_url":"https://avatars0.githubusercontent.com/u/6383576?v=3","gravatar_id":"","url":"https://api.github.com/users/Hubblenaut","html_url":"https://github.com/Hubblenaut","followers_url":"https://api.github.com/users/Hubblenaut/followers","following_url":"https://api.github.com/users/Hubblenaut/following{/other_user}","gists_url":"https://api.github.com/users/Hubblenaut/gists{/gist_id}","starred_url":"https://api.github.com/users/Hubblenaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hubblenaut/subscriptions","organizations_url":"https://api.github.com/users/Hubblenaut/orgs","repos_url":"https://api.github.com/users/Hubblenaut/repos","events_url":"https://api.github.com/users/Hubblenaut/events{/privacy}","received_events_url":"https://api.github.com/users/Hubblenaut/received_events","type":"User","site_admin":false},"body":"Not a fan of this subtype, but a good example that flags like `GAINS_SHARP_ON_ACTIVE` appear very obsolete.","created_at":"2017-06-20T17:14:17Z","updated_at":"2017-06-20T17:14:17Z","html_url":"https://github.com/Baystation12/Baystation12/pull/17114#discussion_r123038479","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/123038479"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/17114#discussion_r123038479"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114","id":119564441,"html_url":"https://github.com/Baystation12/Baystation12/pull/17114","diff_url":"https://github.com/Baystation12/Baystation12/pull/17114.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/17114.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/17114","number":17114,"state":"open","locked":false,"title":"[Ready for review] Adds support for non-material wieldable melee weapons, adds double-swords.","user":{"login":"chaoko99","id":4706052,"avatar_url":"https://avatars3.githubusercontent.com/u/4706052?v=3","gravatar_id":"","url":"https://api.github.com/users/chaoko99","html_url":"https://github.com/chaoko99","followers_url":"https://api.github.com/users/chaoko99/followers","following_url":"https://api.github.com/users/chaoko99/following{/other_user}","gists_url":"https://api.github.com/users/chaoko99/gists{/gist_id}","starred_url":"https://api.github.com/users/chaoko99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaoko99/subscriptions","organizations_url":"https://api.github.com/users/chaoko99/orgs","repos_url":"https://api.github.com/users/chaoko99/repos","events_url":"https://api.github.com/users/chaoko99/events{/privacy}","received_events_url":"https://api.github.com/users/chaoko99/received_events","type":"User","site_admin":false},"body":"Why was this even removed.\nhttps://baystation12.net/forums/threads/poll-double-energy-swords.526/\n\nI don't care if this is an old poll, it passed super hard.","created_at":"2017-05-09T00:58:59Z","updated_at":"2017-06-20T17:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56bce7c4c12924dfe979b1d2b673e5cccc994953","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/17114/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/b8c79c15eec704f56771fa432232a2902099a8b1","head":{"label":"chaoko99:whythefuckwasthisremoved","ref":"whythefuckwasthisremoved","sha":"b8c79c15eec704f56771fa432232a2902099a8b1","user":{"login":"chaoko99","id":4706052,"avatar_url":"https://avatars3.githubusercontent.com/u/4706052?v=3","gravatar_id":"","url":"https://api.github.com/users/chaoko99","html_url":"https://github.com/chaoko99","followers_url":"https://api.github.com/users/chaoko99/followers","following_url":"https://api.github.com/users/chaoko99/following{/other_user}","gists_url":"https://api.github.com/users/chaoko99/gists{/gist_id}","starred_url":"https://api.github.com/users/chaoko99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaoko99/subscriptions","organizations_url":"https://api.github.com/users/chaoko99/orgs","repos_url":"https://api.github.com/users/chaoko99/repos","events_url":"https://api.github.com/users/chaoko99/events{/privacy}","received_events_url":"https://api.github.com/users/chaoko99/received_events","type":"User","site_admin":false},"repo":{"id":84681103,"name":"Baystation12","full_name":"chaoko99/Baystation12","owner":{"login":"chaoko99","id":4706052,"avatar_url":"https://avatars3.githubusercontent.com/u/4706052?v=3","gravatar_id":"","url":"https://api.github.com/users/chaoko99","html_url":"https://github.com/chaoko99","followers_url":"https://api.github.com/users/chaoko99/followers","following_url":"https://api.github.com/users/chaoko99/following{/other_user}","gists_url":"https://api.github.com/users/chaoko99/gists{/gist_id}","starred_url":"https://api.github.com/users/chaoko99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaoko99/subscriptions","organizations_url":"https://api.github.com/users/chaoko99/orgs","repos_url":"https://api.github.com/users/chaoko99/repos","events_url":"https://api.github.com/users/chaoko99/events{/privacy}","received_events_url":"https://api.github.com/users/chaoko99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaoko99/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/chaoko99/Baystation12","forks_url":"https://api.github.com/repos/chaoko99/Baystation12/forks","keys_url":"https://api.github.com/repos/chaoko99/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaoko99/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaoko99/Baystation12/teams","hooks_url":"https://api.github.com/repos/chaoko99/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/chaoko99/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/chaoko99/Baystation12/events","assignees_url":"https://api.github.com/repos/chaoko99/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/chaoko99/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/chaoko99/Baystation12/tags","blobs_url":"https://api.github.com/repos/chaoko99/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaoko99/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaoko99/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaoko99/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaoko99/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/chaoko99/Baystation12/languages","stargazers_url":"https://api.github.com/repos/chaoko99/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/chaoko99/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/chaoko99/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/chaoko99/Baystation12/subscription","commits_url":"https://api.github.com/repos/chaoko99/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaoko99/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaoko99/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaoko99/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaoko99/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/chaoko99/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaoko99/Baystation12/merges","archive_url":"https://api.github.com/repos/chaoko99/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaoko99/Baystation12/downloads","issues_url":"https://api.github.com/repos/chaoko99/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/chaoko99/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/chaoko99/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/chaoko99/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaoko99/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/chaoko99/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/chaoko99/Baystation12/deployments","created_at":"2017-03-11T21:30:14Z","updated_at":"2017-03-11T21:30:28Z","pushed_at":"2017-06-19T07:48:14Z","git_url":"git://github.com/chaoko99/Baystation12.git","ssh_url":"git@github.com:chaoko99/Baystation12.git","clone_url":"https://github.com/chaoko99/Baystation12.git","svn_url":"https://github.com/chaoko99/Baystation12","homepage":"http://baystation12.net/","size":675963,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"cb3fe2378984e3089490fcdcfff245bcadcfb004","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars3.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars3.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2017-06-20T08:54:01Z","pushed_at":"2017-06-20T16:44:38Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":675177,"stargazers_count":255,"watchers_count":255,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":866,"mirror_url":null,"open_issues_count":1329,"forks":866,"open_issues":1329,"watchers":255,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/17114"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/17114"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/17114/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/17114/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/b8c79c15eec704f56771fa432232a2902099a8b1"}}}}
{"actor":{"display_login":"Hubblenaut"}}