{"action":"created","comment":{"url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments/129177302","pull_request_review_id":51922815,"id":129177302,"diff_hunk":"@@ -10651,6 +10724,102 @@ int wolfSSL_set_compression(WOLFSSL* ssl)\n         return SSL_NOT_IMPLEMENTED;\n     }\n \n+    #if defined(WOLFCRYPT_HAVE_SRP) && !defined(NO_SHA256) && !defined(RC_NO_RNG)\n+\n+    int wolfSSL_CTX_set_srp_username(WOLFSSL_CTX* ctx, char* username)\n+    {\n+        int r = 0;\n+        int srp_side = 0;\n+\n+        WOLFSSL_ENTER(\"wolfSSL_CTX_set_srp_username\");\n+        if (ctx == NULL || ctx->srp == NULL || username==NULL)\n+            return SSL_FAILURE;\n+\n+        if (ctx->method->side == WOLFSSL_SERVER_END){\n+            srp_side = SRP_SERVER_SIDE;\n+        } else if (ctx->method->side == WOLFSSL_CLIENT_END){\n+            srp_side = SRP_CLIENT_SIDE;\n+        } else {\n+            WOLFSSL_MSG(\"Init CTX failed\");\n+            XFREE(ctx->srp, heap, DYNAMIC_TYPE_SRP);\n+            wolfSSL_CTX_free(ctx);\n+            return SSL_FAILURE;\n+        }\n+        if (wc_SrpInit(ctx->srp, SRP_TYPE_SHA256, srp_side) < 0){\n+            WOLFSSL_MSG(\"Init CTX failed\");\n+            XFREE(ctx->srp, heap, DYNAMIC_TYPE_SRP);\n+            wolfSSL_CTX_free(ctx);\n+            return SSL_FAILURE;\n+        }\n+        r = wc_SrpSetUsername(ctx->srp, (const byte*)username, sizeof(username));","path":"src/ssl.c","position":153,"original_position":149,"commit_id":"7d540cd7a1b39235f650ff6117251d9d0bcd6e33","original_commit_id":"ad6b7984252f2897831c547188763ca30012e806","user":{"login":"cconlon","id":302241,"avatar_url":"https://avatars2.githubusercontent.com/u/302241?v=4","gravatar_id":"","url":"https://api.github.com/users/cconlon","html_url":"https://github.com/cconlon","followers_url":"https://api.github.com/users/cconlon/followers","following_url":"https://api.github.com/users/cconlon/following{/other_user}","gists_url":"https://api.github.com/users/cconlon/gists{/gist_id}","starred_url":"https://api.github.com/users/cconlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cconlon/subscriptions","organizations_url":"https://api.github.com/users/cconlon/orgs","repos_url":"https://api.github.com/users/cconlon/repos","events_url":"https://api.github.com/users/cconlon/events{/privacy}","received_events_url":"https://api.github.com/users/cconlon/received_events","type":"User","site_admin":false},"body":"This line is still over 80 characters.","created_at":"2017-07-24T23:07:00Z","updated_at":"2017-07-24T23:07:00Z","html_url":"https://github.com/wolfSSL/wolfssl/pull/942#discussion_r129177302","pull_request_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942","_links":{"self":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments/129177302"},"html":{"href":"https://github.com/wolfSSL/wolfssl/pull/942#discussion_r129177302"},"pull_request":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942"}}},"pull_request":{"url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942","id":123059057,"html_url":"https://github.com/wolfSSL/wolfssl/pull/942","diff_url":"https://github.com/wolfSSL/wolfssl/pull/942.diff","patch_url":"https://github.com/wolfSSL/wolfssl/pull/942.patch","issue_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/942","number":942,"state":"open","locked":false,"title":"Go's assignment Part1","user":{"login":"ghoso","id":1472319,"avatar_url":"https://avatars0.githubusercontent.com/u/1472319?v=4","gravatar_id":"","url":"https://api.github.com/users/ghoso","html_url":"https://github.com/ghoso","followers_url":"https://api.github.com/users/ghoso/followers","following_url":"https://api.github.com/users/ghoso/following{/other_user}","gists_url":"https://api.github.com/users/ghoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoso/subscriptions","organizations_url":"https://api.github.com/users/ghoso/orgs","repos_url":"https://api.github.com/users/ghoso/repos","events_url":"https://api.github.com/users/ghoso/events{/privacy}","received_events_url":"https://api.github.com/users/ghoso/received_events","type":"User","site_admin":false},"body":"I have written 3 OpenSSL compatible functions in my assignment.\r\n\r\nBN_mod_inverse\r\nPKCS5_PBKDF2_HMAC_SHA1\r\nSSL_set_tlsext_status_type\r\n\r\nI am not sure SSL_set_tlsext_status_type implementation is correct.\r\nIf I misunderstand it, please let me know.\r\n\r\nThanks !\r\n","created_at":"2017-05-30T14:07:43Z","updated_at":"2017-07-24T23:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fc75414edbc945c90b500f4d60f205e72e732f6","assignee":{"login":"ghoso","id":1472319,"avatar_url":"https://avatars0.githubusercontent.com/u/1472319?v=4","gravatar_id":"","url":"https://api.github.com/users/ghoso","html_url":"https://github.com/ghoso","followers_url":"https://api.github.com/users/ghoso/followers","following_url":"https://api.github.com/users/ghoso/following{/other_user}","gists_url":"https://api.github.com/users/ghoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoso/subscriptions","organizations_url":"https://api.github.com/users/ghoso/orgs","repos_url":"https://api.github.com/users/ghoso/repos","events_url":"https://api.github.com/users/ghoso/events{/privacy}","received_events_url":"https://api.github.com/users/ghoso/received_events","type":"User","site_admin":false},"assignees":[{"login":"ghoso","id":1472319,"avatar_url":"https://avatars0.githubusercontent.com/u/1472319?v=4","gravatar_id":"","url":"https://api.github.com/users/ghoso","html_url":"https://github.com/ghoso","followers_url":"https://api.github.com/users/ghoso/followers","following_url":"https://api.github.com/users/ghoso/following{/other_user}","gists_url":"https://api.github.com/users/ghoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoso/subscriptions","organizations_url":"https://api.github.com/users/ghoso/orgs","repos_url":"https://api.github.com/users/ghoso/repos","events_url":"https://api.github.com/users/ghoso/events{/privacy}","received_events_url":"https://api.github.com/users/ghoso/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942/commits","review_comments_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942/comments","review_comment_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/942/comments","statuses_url":"https://api.github.com/repos/wolfSSL/wolfssl/statuses/7d540cd7a1b39235f650ff6117251d9d0bcd6e33","head":{"label":"ghoso:dev201705","ref":"dev201705","sha":"7d540cd7a1b39235f650ff6117251d9d0bcd6e33","user":{"login":"ghoso","id":1472319,"avatar_url":"https://avatars0.githubusercontent.com/u/1472319?v=4","gravatar_id":"","url":"https://api.github.com/users/ghoso","html_url":"https://github.com/ghoso","followers_url":"https://api.github.com/users/ghoso/followers","following_url":"https://api.github.com/users/ghoso/following{/other_user}","gists_url":"https://api.github.com/users/ghoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoso/subscriptions","organizations_url":"https://api.github.com/users/ghoso/orgs","repos_url":"https://api.github.com/users/ghoso/repos","events_url":"https://api.github.com/users/ghoso/events{/privacy}","received_events_url":"https://api.github.com/users/ghoso/received_events","type":"User","site_admin":false},"repo":{"id":86288923,"name":"wolfssl","full_name":"ghoso/wolfssl","owner":{"login":"ghoso","id":1472319,"avatar_url":"https://avatars0.githubusercontent.com/u/1472319?v=4","gravatar_id":"","url":"https://api.github.com/users/ghoso","html_url":"https://github.com/ghoso","followers_url":"https://api.github.com/users/ghoso/followers","following_url":"https://api.github.com/users/ghoso/following{/other_user}","gists_url":"https://api.github.com/users/ghoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoso/subscriptions","organizations_url":"https://api.github.com/users/ghoso/orgs","repos_url":"https://api.github.com/users/ghoso/repos","events_url":"https://api.github.com/users/ghoso/events{/privacy}","received_events_url":"https://api.github.com/users/ghoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghoso/wolfssl","description":"wolfSSL (formerly CyaSSL) is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. http://www.wolfssl.com","fork":true,"url":"https://api.github.com/repos/ghoso/wolfssl","forks_url":"https://api.github.com/repos/ghoso/wolfssl/forks","keys_url":"https://api.github.com/repos/ghoso/wolfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghoso/wolfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghoso/wolfssl/teams","hooks_url":"https://api.github.com/repos/ghoso/wolfssl/hooks","issue_events_url":"https://api.github.com/repos/ghoso/wolfssl/issues/events{/number}","events_url":"https://api.github.com/repos/ghoso/wolfssl/events","assignees_url":"https://api.github.com/repos/ghoso/wolfssl/assignees{/user}","branches_url":"https://api.github.com/repos/ghoso/wolfssl/branches{/branch}","tags_url":"https://api.github.com/repos/ghoso/wolfssl/tags","blobs_url":"https://api.github.com/repos/ghoso/wolfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghoso/wolfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghoso/wolfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghoso/wolfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghoso/wolfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/ghoso/wolfssl/languages","stargazers_url":"https://api.github.com/repos/ghoso/wolfssl/stargazers","contributors_url":"https://api.github.com/repos/ghoso/wolfssl/contributors","subscribers_url":"https://api.github.com/repos/ghoso/wolfssl/subscribers","subscription_url":"https://api.github.com/repos/ghoso/wolfssl/subscription","commits_url":"https://api.github.com/repos/ghoso/wolfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghoso/wolfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghoso/wolfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghoso/wolfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghoso/wolfssl/contents/{+path}","compare_url":"https://api.github.com/repos/ghoso/wolfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghoso/wolfssl/merges","archive_url":"https://api.github.com/repos/ghoso/wolfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghoso/wolfssl/downloads","issues_url":"https://api.github.com/repos/ghoso/wolfssl/issues{/number}","pulls_url":"https://api.github.com/repos/ghoso/wolfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/ghoso/wolfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/ghoso/wolfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghoso/wolfssl/labels{/name}","releases_url":"https://api.github.com/repos/ghoso/wolfssl/releases{/id}","deployments_url":"https://api.github.com/repos/ghoso/wolfssl/deployments","created_at":"2017-03-27T03:51:13Z","updated_at":"2017-03-27T03:51:18Z","pushed_at":"2017-07-21T04:38:55Z","git_url":"git://github.com/ghoso/wolfssl.git","ssh_url":"git@github.com:ghoso/wolfssl.git","clone_url":"https://github.com/ghoso/wolfssl.git","svn_url":"https://github.com/ghoso/wolfssl","homepage":null,"size":33141,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wolfSSL:master","ref":"master","sha":"b6854d620f827780576633b6715fd3c3fc8b8073","user":{"login":"wolfSSL","id":5891092,"avatar_url":"https://avatars0.githubusercontent.com/u/5891092?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfSSL","html_url":"https://github.com/wolfSSL","followers_url":"https://api.github.com/users/wolfSSL/followers","following_url":"https://api.github.com/users/wolfSSL/following{/other_user}","gists_url":"https://api.github.com/users/wolfSSL/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfSSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfSSL/subscriptions","organizations_url":"https://api.github.com/users/wolfSSL/orgs","repos_url":"https://api.github.com/users/wolfSSL/repos","events_url":"https://api.github.com/users/wolfSSL/events{/privacy}","received_events_url":"https://api.github.com/users/wolfSSL/received_events","type":"Organization","site_admin":false},"repo":{"id":28928522,"name":"wolfssl","full_name":"wolfSSL/wolfssl","owner":{"login":"wolfSSL","id":5891092,"avatar_url":"https://avatars0.githubusercontent.com/u/5891092?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfSSL","html_url":"https://github.com/wolfSSL","followers_url":"https://api.github.com/users/wolfSSL/followers","following_url":"https://api.github.com/users/wolfSSL/following{/other_user}","gists_url":"https://api.github.com/users/wolfSSL/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfSSL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfSSL/subscriptions","organizations_url":"https://api.github.com/users/wolfSSL/orgs","repos_url":"https://api.github.com/users/wolfSSL/repos","events_url":"https://api.github.com/users/wolfSSL/events{/privacy}","received_events_url":"https://api.github.com/users/wolfSSL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wolfSSL/wolfssl","description":"wolfSSL (formerly CyaSSL) is a small, fast, portable implementation of TLS/SSL for embedded devices to the cloud. http://www.wolfssl.com","fork":false,"url":"https://api.github.com/repos/wolfSSL/wolfssl","forks_url":"https://api.github.com/repos/wolfSSL/wolfssl/forks","keys_url":"https://api.github.com/repos/wolfSSL/wolfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfSSL/wolfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfSSL/wolfssl/teams","hooks_url":"https://api.github.com/repos/wolfSSL/wolfssl/hooks","issue_events_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/events{/number}","events_url":"https://api.github.com/repos/wolfSSL/wolfssl/events","assignees_url":"https://api.github.com/repos/wolfSSL/wolfssl/assignees{/user}","branches_url":"https://api.github.com/repos/wolfSSL/wolfssl/branches{/branch}","tags_url":"https://api.github.com/repos/wolfSSL/wolfssl/tags","blobs_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfSSL/wolfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfSSL/wolfssl/languages","stargazers_url":"https://api.github.com/repos/wolfSSL/wolfssl/stargazers","contributors_url":"https://api.github.com/repos/wolfSSL/wolfssl/contributors","subscribers_url":"https://api.github.com/repos/wolfSSL/wolfssl/subscribers","subscription_url":"https://api.github.com/repos/wolfSSL/wolfssl/subscription","commits_url":"https://api.github.com/repos/wolfSSL/wolfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfSSL/wolfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfSSL/wolfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfSSL/wolfssl/contents/{+path}","compare_url":"https://api.github.com/repos/wolfSSL/wolfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfSSL/wolfssl/merges","archive_url":"https://api.github.com/repos/wolfSSL/wolfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfSSL/wolfssl/downloads","issues_url":"https://api.github.com/repos/wolfSSL/wolfssl/issues{/number}","pulls_url":"https://api.github.com/repos/wolfSSL/wolfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfSSL/wolfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfSSL/wolfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfSSL/wolfssl/labels{/name}","releases_url":"https://api.github.com/repos/wolfSSL/wolfssl/releases{/id}","deployments_url":"https://api.github.com/repos/wolfSSL/wolfssl/deployments","created_at":"2015-01-07T18:50:58Z","updated_at":"2017-07-22T18:01:12Z","pushed_at":"2017-07-24T22:37:05Z","git_url":"git://github.com/wolfSSL/wolfssl.git","ssh_url":"git@github.com:wolfSSL/wolfssl.git","clone_url":"https://github.com/wolfSSL/wolfssl.git","svn_url":"https://github.com/wolfSSL/wolfssl","homepage":null,"size":33430,"stargazers_count":249,"watchers_count":249,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":44,"forks":125,"open_issues":44,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942"},"html":{"href":"https://github.com/wolfSSL/wolfssl/pull/942"},"issue":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/issues/942"},"comments":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/issues/942/comments"},"review_comments":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942/comments"},"review_comment":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/pulls/942/commits"},"statuses":{"href":"https://api.github.com/repos/wolfSSL/wolfssl/statuses/7d540cd7a1b39235f650ff6117251d9d0bcd6e33"}}}}
{"actor":{"display_login":"cconlon"}}