{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/120570001","pull_request_review_id":42541806,"id":120570001,"diff_hunk":"@@ -165,20 +166,28 @@ private static String extractVersionNumber(String inputString) {\n \n     /**\n      * Verifies that the test properties specified in test.properties file allows for HTML\n-     * regeneration via God mode to work smoothly (i.e all test HTML files are correctly regenerated,\n+     * regeneration via GodMode to work smoothly (i.e all test HTML files are correctly regenerated,\n      * strings that need to be replaced with placeholders are correctly replaced, and\n      * strings that are not supposed to be replaced with placeholders are not replaced).\n      */\n     public static void verifyReadyForGodMode() {\n+        if (IS_GODMODE_ENABLED && isCiEnvironment() && !isGodModeTest()) {\n+            fail(\"GodMode should only be run locally, not in a CI environment. Please revert the change \"\n+                    + \"to the test properties template file that enabled GodMode in CI.\");\n+        }\n         if (!isDevServer()) {\n-            fail(\"God mode regeneration works only in dev server.\");\n+            fail(\"GodMode regeneration works only in dev server.\");\n         }\n         if (isStudentMotdUrlEmpty()) {\n             fail(\"Student MOTD URL defined in app.student.motd.url in build.properties \"\n                     + \"must not be empty. It is advised to use test-student-motd.html to test it.\");\n         }\n     }\n \n+    private static boolean isGodModeTest() {\n+        return System.getProperty(\"test.godmode\") != null;","path":"src/test/java/teammates/test/driver/TestProperties.java","position":57,"original_position":57,"commit_id":"9d870f4e436fe1d0946b2800aca8c17ce3895984","original_commit_id":"9d870f4e436fe1d0946b2800aca8c17ce3895984","user":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars1.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"body":"Problem is, `sequential-ui-tests` and `parallel-ui-tests` are not mutually exclusive.","created_at":"2017-06-07T08:59:30Z","updated_at":"2017-06-07T08:59:30Z","html_url":"https://github.com/TEAMMATES/teammates/pull/7379#discussion_r120570001","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/120570001"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7379#discussion_r120570001"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379","id":122420465,"html_url":"https://github.com/TEAMMATES/teammates/pull/7379","diff_url":"https://github.com/TEAMMATES/teammates/pull/7379.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/7379.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7379","number":7379,"state":"open","locked":false,"title":"Move GodMode switch into test.properties #7378","user":{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars3.githubusercontent.com/u/6811428?v=3","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false},"body":"Fixes #7378\r\n\r\n**Outline of Solution**\r\n\r\n- Add new test property `test.godmode.enabled` and link GodMode switch to it\r\n- Print reminder to disable GodMode at the end of test runs\r\n- Detect that GodMode is not enabled in CI; add `GodModeTest` to CI test suite to enforce this\r\n- Decommission `godmode` system property; remove GodMode launch configurations","created_at":"2017-05-25T11:19:01Z","updated_at":"2017-06-07T08:59:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34698e2ae9d3e873f8e4bccbb5e8b00b688fd621","assignee":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars1.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"assignees":[{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars1.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},{"login":"thenaesh","id":9165895,"avatar_url":"https://avatars2.githubusercontent.com/u/9165895?v=3","gravatar_id":"","url":"https://api.github.com/users/thenaesh","html_url":"https://github.com/thenaesh","followers_url":"https://api.github.com/users/thenaesh/followers","following_url":"https://api.github.com/users/thenaesh/following{/other_user}","gists_url":"https://api.github.com/users/thenaesh/gists{/gist_id}","starred_url":"https://api.github.com/users/thenaesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenaesh/subscriptions","organizations_url":"https://api.github.com/users/thenaesh/orgs","repos_url":"https://api.github.com/users/thenaesh/repos","events_url":"https://api.github.com/users/thenaesh/events{/privacy}","received_events_url":"https://api.github.com/users/thenaesh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"thenaesh","id":9165895,"avatar_url":"https://avatars2.githubusercontent.com/u/9165895?v=3","gravatar_id":"","url":"https://api.github.com/users/thenaesh","html_url":"https://github.com/thenaesh","followers_url":"https://api.github.com/users/thenaesh/followers","following_url":"https://api.github.com/users/thenaesh/following{/other_user}","gists_url":"https://api.github.com/users/thenaesh/gists{/gist_id}","starred_url":"https://api.github.com/users/thenaesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenaesh/subscriptions","organizations_url":"https://api.github.com/users/thenaesh/orgs","repos_url":"https://api.github.com/users/thenaesh/repos","events_url":"https://api.github.com/users/thenaesh/events{/privacy}","received_events_url":"https://api.github.com/users/thenaesh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7379/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/9d870f4e436fe1d0946b2800aca8c17ce3895984","head":{"label":"whipermr5:7378-godmode-in-ci","ref":"7378-godmode-in-ci","sha":"9d870f4e436fe1d0946b2800aca8c17ce3895984","user":{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars3.githubusercontent.com/u/6811428?v=3","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false},"repo":{"id":78711212,"name":"teammates","full_name":"whipermr5/teammates","owner":{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars3.githubusercontent.com/u/6811428?v=3","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whipermr5/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/whipermr5/teammates","forks_url":"https://api.github.com/repos/whipermr5/teammates/forks","keys_url":"https://api.github.com/repos/whipermr5/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whipermr5/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whipermr5/teammates/teams","hooks_url":"https://api.github.com/repos/whipermr5/teammates/hooks","issue_events_url":"https://api.github.com/repos/whipermr5/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/whipermr5/teammates/events","assignees_url":"https://api.github.com/repos/whipermr5/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/whipermr5/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/whipermr5/teammates/tags","blobs_url":"https://api.github.com/repos/whipermr5/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whipermr5/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whipermr5/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/whipermr5/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whipermr5/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/whipermr5/teammates/languages","stargazers_url":"https://api.github.com/repos/whipermr5/teammates/stargazers","contributors_url":"https://api.github.com/repos/whipermr5/teammates/contributors","subscribers_url":"https://api.github.com/repos/whipermr5/teammates/subscribers","subscription_url":"https://api.github.com/repos/whipermr5/teammates/subscription","commits_url":"https://api.github.com/repos/whipermr5/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/whipermr5/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/whipermr5/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/whipermr5/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/whipermr5/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/whipermr5/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whipermr5/teammates/merges","archive_url":"https://api.github.com/repos/whipermr5/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whipermr5/teammates/downloads","issues_url":"https://api.github.com/repos/whipermr5/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/whipermr5/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/whipermr5/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/whipermr5/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whipermr5/teammates/labels{/name}","releases_url":"https://api.github.com/repos/whipermr5/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/whipermr5/teammates/deployments","created_at":"2017-01-12T05:18:22Z","updated_at":"2017-01-12T05:18:29Z","pushed_at":"2017-06-07T08:04:41Z","git_url":"git://github.com/whipermr5/teammates.git","ssh_url":"git@github.com:whipermr5/teammates.git","clone_url":"https://github.com/whipermr5/teammates.git","svn_url":"https://github.com/whipermr5/teammates","homepage":"http://teammatesv4.appspot.com/","size":183331,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"827790c3c8017a0163a683cea2e4af55aaafc465","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2017-06-06T14:09:11Z","pushed_at":"2017-06-07T08:38:55Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"http://teammatesv4.appspot.com/","size":185996,"stargazers_count":345,"watchers_count":345,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":803,"mirror_url":null,"open_issues_count":305,"forks":803,"open_issues":305,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7379"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7379"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7379/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7379/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/9d870f4e436fe1d0946b2800aca8c17ce3895984"}}}}
{"actor":{"display_login":"wkurniawan07"}}