{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/rfcs/pulls/comments/96403227","pull_request_review_id":16982600,"id":96403227,"diff_hunk":"@@ -0,0 +1,38 @@\n+- Start Date: (fill me in with today's date, YYYY-MM-DD)\n+- RFC PR: (leave this empty)\n+- Ember Issue: (leave this empty)\n+\n+# Summary\n+\n+Support for component `eventManger`s is a seldom used feature and should\n+be deprecated.\n+\n+# Motivation\n+\n+We should strive to simplify the Ember API and source code where possible. As\n+the custom `eventManager` feature is rarely used in apps, we should deprecate\n+it.\n+\n+# Detailed design\n+\n+We'll introduce a deprecation warning which will be displayed when a component\n+defines an `eventManager` property or when `canDispatchToEventManager` is set to\n+true on `EventDispatcher`. The warning will have a target version of `3.0`.\n+\n+If required, we can create an addon which extends the `EventDispatcher` allowing\n+for opt-in custom `eventManager`s in Ember apps.","path":"text/0000-deprecate-custom-event-manager.md","position":23,"original_position":23,"commit_id":"c0106e2051afa06e97bf86cfb8a6b9ba94ae4f36","original_commit_id":"c0106e2051afa06e97bf86cfb8a6b9ba94ae4f36","user":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"body":"if anyone has a need for this, let me know and I'll create the addon","created_at":"2017-01-17T12:46:46Z","updated_at":"2017-01-17T12:46:46Z","html_url":"https://github.com/emberjs/rfcs/pull/194#discussion_r96403227","pull_request_url":"https://api.github.com/repos/emberjs/rfcs/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/comments/96403227"},"html":{"href":"https://github.com/emberjs/rfcs/pull/194#discussion_r96403227"},"pull_request":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/rfcs/pulls/194","id":99367430,"html_url":"https://github.com/emberjs/rfcs/pull/194","diff_url":"https://github.com/emberjs/rfcs/pull/194.diff","patch_url":"https://github.com/emberjs/rfcs/pull/194.patch","issue_url":"https://api.github.com/repos/emberjs/rfcs/issues/194","number":194,"state":"open","locked":false,"title":"Deprecate component `eventManager`","user":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"body":"[Rendered](https://github.com/GavinJoyce/rfcs/blob/c0106e2051afa06e97bf86cfb8a6b9ba94ae4f36/text/0000-deprecate-custom-event-manager.md)\r\n\r\n\r\n---\r\n\r\n\r\nPart of https://github.com/emberjs/ember.js/issues/14754","created_at":"2016-12-26T12:42:39Z","updated_at":"2017-01-17T12:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a0cf7d446ad09bd8374c028c28299cab2ea143a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/rfcs/pulls/194/commits","review_comments_url":"https://api.github.com/repos/emberjs/rfcs/pulls/194/comments","review_comment_url":"https://api.github.com/repos/emberjs/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/rfcs/issues/194/comments","statuses_url":"https://api.github.com/repos/emberjs/rfcs/statuses/c0106e2051afa06e97bf86cfb8a6b9ba94ae4f36","head":{"label":"GavinJoyce:gj/deprecate-custom-event-mananger","ref":"gj/deprecate-custom-event-mananger","sha":"c0106e2051afa06e97bf86cfb8a6b9ba94ae4f36","user":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"repo":{"id":42395983,"name":"rfcs","full_name":"GavinJoyce/rfcs","owner":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GavinJoyce/rfcs","description":"RFCs for changes to Ember","fork":true,"url":"https://api.github.com/repos/GavinJoyce/rfcs","forks_url":"https://api.github.com/repos/GavinJoyce/rfcs/forks","keys_url":"https://api.github.com/repos/GavinJoyce/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GavinJoyce/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GavinJoyce/rfcs/teams","hooks_url":"https://api.github.com/repos/GavinJoyce/rfcs/hooks","issue_events_url":"https://api.github.com/repos/GavinJoyce/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/GavinJoyce/rfcs/events","assignees_url":"https://api.github.com/repos/GavinJoyce/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/GavinJoyce/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/GavinJoyce/rfcs/tags","blobs_url":"https://api.github.com/repos/GavinJoyce/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GavinJoyce/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GavinJoyce/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GavinJoyce/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GavinJoyce/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/GavinJoyce/rfcs/languages","stargazers_url":"https://api.github.com/repos/GavinJoyce/rfcs/stargazers","contributors_url":"https://api.github.com/repos/GavinJoyce/rfcs/contributors","subscribers_url":"https://api.github.com/repos/GavinJoyce/rfcs/subscribers","subscription_url":"https://api.github.com/repos/GavinJoyce/rfcs/subscription","commits_url":"https://api.github.com/repos/GavinJoyce/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GavinJoyce/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GavinJoyce/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GavinJoyce/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GavinJoyce/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/GavinJoyce/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GavinJoyce/rfcs/merges","archive_url":"https://api.github.com/repos/GavinJoyce/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GavinJoyce/rfcs/downloads","issues_url":"https://api.github.com/repos/GavinJoyce/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/GavinJoyce/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/GavinJoyce/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/GavinJoyce/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GavinJoyce/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/GavinJoyce/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/GavinJoyce/rfcs/deployments","created_at":"2015-09-13T13:01:37Z","updated_at":"2016-04-06T12:23:02Z","pushed_at":"2016-12-26T19:43:52Z","git_url":"git://github.com/GavinJoyce/rfcs.git","ssh_url":"git@github.com:GavinJoyce/rfcs.git","clone_url":"https://github.com/GavinJoyce/rfcs.git","svn_url":"https://github.com/GavinJoyce/rfcs","homepage":null,"size":231,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"9319517daea5ea85e98a71c00d459ff05e8b48e3","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":22664562,"name":"rfcs","full_name":"emberjs/rfcs","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/rfcs","description":"RFCs for changes to Ember","fork":false,"url":"https://api.github.com/repos/emberjs/rfcs","forks_url":"https://api.github.com/repos/emberjs/rfcs/forks","keys_url":"https://api.github.com/repos/emberjs/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/rfcs/teams","hooks_url":"https://api.github.com/repos/emberjs/rfcs/hooks","issue_events_url":"https://api.github.com/repos/emberjs/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/rfcs/events","assignees_url":"https://api.github.com/repos/emberjs/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/rfcs/tags","blobs_url":"https://api.github.com/repos/emberjs/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/rfcs/languages","stargazers_url":"https://api.github.com/repos/emberjs/rfcs/stargazers","contributors_url":"https://api.github.com/repos/emberjs/rfcs/contributors","subscribers_url":"https://api.github.com/repos/emberjs/rfcs/subscribers","subscription_url":"https://api.github.com/repos/emberjs/rfcs/subscription","commits_url":"https://api.github.com/repos/emberjs/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/rfcs/merges","archive_url":"https://api.github.com/repos/emberjs/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/rfcs/downloads","issues_url":"https://api.github.com/repos/emberjs/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/rfcs/deployments","created_at":"2014-08-06T00:49:22Z","updated_at":"2017-01-10T16:56:49Z","pushed_at":"2017-01-17T03:18:34Z","git_url":"git://github.com/emberjs/rfcs.git","ssh_url":"git@github.com:emberjs/rfcs.git","clone_url":"https://github.com/emberjs/rfcs.git","svn_url":"https://github.com/emberjs/rfcs","homepage":null,"size":255,"stargazers_count":466,"watchers_count":466,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":80,"forks":156,"open_issues":80,"watchers":466,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/194"},"html":{"href":"https://github.com/emberjs/rfcs/pull/194"},"issue":{"href":"https://api.github.com/repos/emberjs/rfcs/issues/194"},"comments":{"href":"https://api.github.com/repos/emberjs/rfcs/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/rfcs/statuses/c0106e2051afa06e97bf86cfb8a6b9ba94ae4f36"}}}}
{"actor":{"display_login":"GavinJoyce"}}