{"action":"created","issue":{"url":"https://api.github.com/repos/joncampbell123/dosbox-x/issues/284","repository_url":"https://api.github.com/repos/joncampbell123/dosbox-x","labels_url":"https://api.github.com/repos/joncampbell123/dosbox-x/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/joncampbell123/dosbox-x/issues/284/comments","events_url":"https://api.github.com/repos/joncampbell123/dosbox-x/issues/284/events","html_url":"https://github.com/joncampbell123/dosbox-x/issues/284","id":246418096,"number":284,"title":"Compiling on Visual studio 2017 fails (including fix)","user":{"login":"ggnkua","id":5121492,"avatar_url":"https://avatars0.githubusercontent.com/u/5121492?v=4","gravatar_id":"","url":"https://api.github.com/users/ggnkua","html_url":"https://github.com/ggnkua","followers_url":"https://api.github.com/users/ggnkua/followers","following_url":"https://api.github.com/users/ggnkua/following{/other_user}","gists_url":"https://api.github.com/users/ggnkua/gists{/gist_id}","starred_url":"https://api.github.com/users/ggnkua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggnkua/subscriptions","organizations_url":"https://api.github.com/users/ggnkua/orgs","repos_url":"https://api.github.com/users/ggnkua/repos","events_url":"https://api.github.com/users/ggnkua/events{/privacy}","received_events_url":"https://api.github.com/users/ggnkua/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-28T17:59:25Z","updated_at":"2017-07-29T16:06:21Z","closed_at":null,"body":"Hi,\r\n\r\nI just pulled the latest source tree and tried to build on my VS2017 on Win10 and it failed because of redefinition of std::isinf - apparently this was needed in VS2008 but it seems that the definition is present on new versions of VS.\r\n\r\nSo in order to get it to build I modified src\\fpu\\fpu_instructions.h, line 316 to\r\n\r\n`#if defined(WIN32) && (_MSC_VER<1910)`\r\n\r\nand that did the trick. It might work with VS earlier than 2017 (my guess would be up to 2013) but I cannot test.\r\n\r\nSorry for not making a pull request but I'm absolutely terrible when it comes to stuff like this :)."},"comment":{"url":"https://api.github.com/repos/joncampbell123/dosbox-x/issues/comments/318840673","html_url":"https://github.com/joncampbell123/dosbox-x/issues/284#issuecomment-318840673","issue_url":"https://api.github.com/repos/joncampbell123/dosbox-x/issues/284","id":318840673,"user":{"login":"ggnkua","id":5121492,"avatar_url":"https://avatars0.githubusercontent.com/u/5121492?v=4","gravatar_id":"","url":"https://api.github.com/users/ggnkua","html_url":"https://github.com/ggnkua","followers_url":"https://api.github.com/users/ggnkua/followers","following_url":"https://api.github.com/users/ggnkua/following{/other_user}","gists_url":"https://api.github.com/users/ggnkua/gists{/gist_id}","starred_url":"https://api.github.com/users/ggnkua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggnkua/subscriptions","organizations_url":"https://api.github.com/users/ggnkua/orgs","repos_url":"https://api.github.com/users/ggnkua/repos","events_url":"https://api.github.com/users/ggnkua/events{/privacy}","received_events_url":"https://api.github.com/users/ggnkua/received_events","type":"User","site_admin":false},"created_at":"2017-07-29T16:06:21Z","updated_at":"2017-07-29T16:06:21Z","body":"Hi,\r\n\r\nYour suggestion seems to work fine. Just out of curiosity I tried adding `#undef _MSC_VER` just before the `#if` and tried both your suggestion and mine. The compiler didn't throw any errors because of the undefined symbol. So it's a matter of preference I suppose."}}
{"actor":{"display_login":"ggnkua"}}