{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/flow/issues/3043","repository_url":"https://api.github.com/repos/vaadin/flow","labels_url":"https://api.github.com/repos/vaadin/flow/issues/3043/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/3043/comments","events_url":"https://api.github.com/repos/vaadin/flow/issues/3043/events","html_url":"https://github.com/vaadin/flow/pull/3043","id":276581311,"number":3043,"title":"ComponentGenrator to use simple names for `java.lang` classes.","user":{"login":"asashour","id":2410127,"avatar_url":"https://avatars0.githubusercontent.com/u/2410127?v=4","gravatar_id":"","url":"https://api.github.com/users/asashour","html_url":"https://github.com/asashour","followers_url":"https://api.github.com/users/asashour/followers","following_url":"https://api.github.com/users/asashour/following{/other_user}","gists_url":"https://api.github.com/users/asashour/gists{/gist_id}","starred_url":"https://api.github.com/users/asashour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asashour/subscriptions","organizations_url":"https://api.github.com/users/asashour/orgs","repos_url":"https://api.github.com/users/asashour/repos","events_url":"https://api.github.com/users/asashour/events{/privacy}","received_events_url":"https://api.github.com/users/asashour/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-24T10:53:04Z","updated_at":"2017-11-24T13:27:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/3043","html_url":"https://github.com/vaadin/flow/pull/3043","diff_url":"https://github.com/vaadin/flow/pull/3043.diff","patch_url":"https://github.com/vaadin/flow/pull/3043.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/3043)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/flow/issues/comments/346828627","html_url":"https://github.com/vaadin/flow/pull/3043#issuecomment-346828627","issue_url":"https://api.github.com/repos/vaadin/flow/issues/3043","id":346828627,"user":{"login":"asashour","id":2410127,"avatar_url":"https://avatars0.githubusercontent.com/u/2410127?v=4","gravatar_id":"","url":"https://api.github.com/users/asashour","html_url":"https://github.com/asashour","followers_url":"https://api.github.com/users/asashour/followers","following_url":"https://api.github.com/users/asashour/following{/other_user}","gists_url":"https://api.github.com/users/asashour/gists{/gist_id}","starred_url":"https://api.github.com/users/asashour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asashour/subscriptions","organizations_url":"https://api.github.com/users/asashour/orgs","repos_url":"https://api.github.com/users/asashour/repos","events_url":"https://api.github.com/users/asashour/events{/privacy}","received_events_url":"https://api.github.com/users/asashour/received_events","type":"User","site_admin":false},"created_at":"2017-11-24T13:27:49Z","updated_at":"2017-11-24T13:27:49Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 0 of 51 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[flow-components-parent/flow-code-generator-api/src/main/java/com/vaadin/generator/ComponentGenerator.java, line 1032 at r1](https://reviewable.io:443/reviews/vaadin/flow/3043#-KzhkQ8diVvWkDa6HWM5:-KziCVwJvwyMiSX-Bokc:b-fg7wkf) ([raw file](https://github.com/vaadin/flow/blob/cd7dbd343d9afacbf14beb60325f23cc5410331a/flow-components-parent/flow-code-generator-api/src/main/java/com/vaadin/generator/ComponentGenerator.java#L1032)):*\n<details><summary><i>Previously, gilberto-torrezan (Gilberto Torrezan) wrote…</i></summary><blockquote>\n\n> static ParameterSource<JavaClassSource> addMethodParameter\n\nSince this method is used by the `ComponentGenerator` and the `NestedClassGenerator` classes, I suggest moving it to the `ComponentGeneratorUtils` class, which already contains several utility methods for the generation.\n\nThere's a separate test class for it as well, the `ComponentGeneratorUtilsTest`.\n</blockquote></details>\n\nThanks for the hint, now all the class names are shortened.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/flow/3043)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"asashour"}}