{"action":"created","comment":{"url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments/143697689","pull_request_review_id":68243415,"id":143697689,"diff_hunk":"@@ -814,6 +826,22 @@ def on_focus_object_changed(self, obj):\n             log.misc.debug(\"Focus object changed: {}\".format(output))\n         self._last_focus_object = output\n \n+    @pyqtSlot(Qt.ApplicationState)\n+    def on_app_state_changed(self, state):","path":"qutebrowser/app.py","position":71,"original_position":65,"commit_id":"e1f5da3eff50c44462562f900314125f9494a173","original_commit_id":"e537826ff5c057fe57ca1e4ebb0a1b4ef7756462","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars0.githubusercontent.com/u/625793?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"body":"I'll need to look into this, but I still feel like it'd be best to remove it entirely. FWIW, it breaks things when starting qutebrowser for me:\r\n\r\n```\r\nTraceback (most recent call last):\r\n  File \"/home/florian/proj/qutebrowser/git/qutebrowser/utils/objreg.py\", line 300, in last_focused_window\r\n    return get('last-focused-main-window')\r\n  File \"/home/florian/proj/qutebrowser/git/qutebrowser/utils/objreg.py\", line 229, in get\r\n    return reg[name]\r\n  File \"/home/florian/proj/qutebrowser/git/.venv/lib/python3.6/collections/__init__.py\", line 993, in __getitem__\r\n    raise KeyError(key)\r\nKeyError: 'last-focused-main-window'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/home/florian/proj/qutebrowser/git/qutebrowser/app.py\", line 834, in on_app_state_changed\r\n    window = objreg.last_focused_window()\r\n  File \"/home/florian/proj/qutebrowser/git/qutebrowser/utils/objreg.py\", line 302, in last_focused_window\r\n    return window_by_index(-1)\r\n  File \"/home/florian/proj/qutebrowser/git/qutebrowser/utils/objreg.py\", line 308, in window_by_index\r\n    raise NoWindow()\r\nqutebrowser.utils.objreg.NoWindow\r\n```","created_at":"2017-10-10T11:18:38Z","updated_at":"2017-10-10T11:20:54Z","html_url":"https://github.com/qutebrowser/qutebrowser/pull/3055#discussion_r143697689","pull_request_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments/143697689"},"html":{"href":"https://github.com/qutebrowser/qutebrowser/pull/3055#discussion_r143697689"},"pull_request":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055"}},"in_reply_to_id":143670574},"pull_request":{"url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055","id":144537270,"html_url":"https://github.com/qutebrowser/qutebrowser/pull/3055","diff_url":"https://github.com/qutebrowser/qutebrowser/pull/3055.diff","patch_url":"https://github.com/qutebrowser/qutebrowser/pull/3055.patch","issue_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3055","number":3055,"state":"open","locked":false,"title":"OSX URLs handling","user":{"login":"residentsummer","id":813112,"avatar_url":"https://avatars2.githubusercontent.com/u/813112?v=4","gravatar_id":"","url":"https://api.github.com/users/residentsummer","html_url":"https://github.com/residentsummer","followers_url":"https://api.github.com/users/residentsummer/followers","following_url":"https://api.github.com/users/residentsummer/following{/other_user}","gists_url":"https://api.github.com/users/residentsummer/gists{/gist_id}","starred_url":"https://api.github.com/users/residentsummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/residentsummer/subscriptions","organizations_url":"https://api.github.com/users/residentsummer/orgs","repos_url":"https://api.github.com/users/residentsummer/repos","events_url":"https://api.github.com/users/residentsummer/events{/privacy}","received_events_url":"https://api.github.com/users/residentsummer/received_events","type":"User","site_admin":false},"body":"These are some OSX-specific changes, required for being a default browser (see #22):\r\n\r\n- [x] 1. Open links from other apps\r\n- [x] 2. Open html files on double-click and drop\r\n- [x] 3. Patch Info.plist to declare support of 1 and 2\r\n- [x] 4. Open links in background/foreground (cmd-click/left-click)\r\n- [x] 5. Show up in browser selection menu\r\n- [ ] ~~6. Setting itself as default browser~~\r\n\r\nI've also done task 6 (as a `:`-command), but that will add some deps on osx (`pyobjc-framework-LaunchServices`, `pyobjc-framework-Cocoa`, `pyobjc-core`). As of 4 and 5 - the only option, that I haven't tried yet, requires going deeper in pyobjc land (see part 3 of the accepted answer [here](https://stackoverflow.com/questions/49510/how-do-you-set-your-cocoa-application-as-the-default-web-browser)).\r\n\r\nAlso need to make my changes compliant with the contributing guidelines. Haven't started on this, because the main work is not completed.\r\n\r\nUPDATE: completed task 5, agreed to drop task 6.\r\nUPDATE: completed task 4.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qutebrowser/qutebrowser/3055)\r\n<!-- Reviewable:end -->\r\n","created_at":"2017-10-03T21:47:55Z","updated_at":"2017-10-10T11:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af3e6eaf93df9b6a5a95e43597c7de7a31b1a2c0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/qutebrowser/qutebrowser/milestones/7","html_url":"https://github.com/qutebrowser/qutebrowser/milestone/7","labels_url":"https://api.github.com/repos/qutebrowser/qutebrowser/milestones/7/labels","id":1166227,"number":7,"title":"v1.0.0","description":"Or maybe on November 14th seeing that Firefox 57 will be released then... ","creator":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars0.githubusercontent.com/u/625793?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":51,"state":"open","created_at":"2015-06-16T06:45:24Z","updated_at":"2017-10-10T09:24:39Z","due_on":"2017-12-14T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055/commits","review_comments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055/comments","review_comment_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3055/comments","statuses_url":"https://api.github.com/repos/qutebrowser/qutebrowser/statuses/e1f5da3eff50c44462562f900314125f9494a173","head":{"label":"residentsummer:osx-url-handler","ref":"osx-url-handler","sha":"e1f5da3eff50c44462562f900314125f9494a173","user":{"login":"residentsummer","id":813112,"avatar_url":"https://avatars2.githubusercontent.com/u/813112?v=4","gravatar_id":"","url":"https://api.github.com/users/residentsummer","html_url":"https://github.com/residentsummer","followers_url":"https://api.github.com/users/residentsummer/followers","following_url":"https://api.github.com/users/residentsummer/following{/other_user}","gists_url":"https://api.github.com/users/residentsummer/gists{/gist_id}","starred_url":"https://api.github.com/users/residentsummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/residentsummer/subscriptions","organizations_url":"https://api.github.com/users/residentsummer/orgs","repos_url":"https://api.github.com/users/residentsummer/repos","events_url":"https://api.github.com/users/residentsummer/events{/privacy}","received_events_url":"https://api.github.com/users/residentsummer/received_events","type":"User","site_admin":false},"repo":{"id":105702690,"name":"qutebrowser","full_name":"residentsummer/qutebrowser","owner":{"login":"residentsummer","id":813112,"avatar_url":"https://avatars2.githubusercontent.com/u/813112?v=4","gravatar_id":"","url":"https://api.github.com/users/residentsummer","html_url":"https://github.com/residentsummer","followers_url":"https://api.github.com/users/residentsummer/followers","following_url":"https://api.github.com/users/residentsummer/following{/other_user}","gists_url":"https://api.github.com/users/residentsummer/gists{/gist_id}","starred_url":"https://api.github.com/users/residentsummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/residentsummer/subscriptions","organizations_url":"https://api.github.com/users/residentsummer/orgs","repos_url":"https://api.github.com/users/residentsummer/repos","events_url":"https://api.github.com/users/residentsummer/events{/privacy}","received_events_url":"https://api.github.com/users/residentsummer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/residentsummer/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":true,"url":"https://api.github.com/repos/residentsummer/qutebrowser","forks_url":"https://api.github.com/repos/residentsummer/qutebrowser/forks","keys_url":"https://api.github.com/repos/residentsummer/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/residentsummer/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/residentsummer/qutebrowser/teams","hooks_url":"https://api.github.com/repos/residentsummer/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/residentsummer/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/residentsummer/qutebrowser/events","assignees_url":"https://api.github.com/repos/residentsummer/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/residentsummer/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/residentsummer/qutebrowser/tags","blobs_url":"https://api.github.com/repos/residentsummer/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/residentsummer/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/residentsummer/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/residentsummer/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/residentsummer/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/residentsummer/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/residentsummer/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/residentsummer/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/residentsummer/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/residentsummer/qutebrowser/subscription","commits_url":"https://api.github.com/repos/residentsummer/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/residentsummer/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/residentsummer/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/residentsummer/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/residentsummer/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/residentsummer/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/residentsummer/qutebrowser/merges","archive_url":"https://api.github.com/repos/residentsummer/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/residentsummer/qutebrowser/downloads","issues_url":"https://api.github.com/repos/residentsummer/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/residentsummer/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/residentsummer/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/residentsummer/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/residentsummer/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/residentsummer/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/residentsummer/qutebrowser/deployments","created_at":"2017-10-03T20:59:38Z","updated_at":"2017-10-03T20:59:41Z","pushed_at":"2017-10-10T11:14:21Z","git_url":"git://github.com/residentsummer/qutebrowser.git","ssh_url":"git@github.com:residentsummer/qutebrowser.git","clone_url":"https://github.com/residentsummer/qutebrowser.git","svn_url":"https://github.com/residentsummer/qutebrowser","homepage":"https://www.qutebrowser.org/","size":25590,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qutebrowser:master","ref":"master","sha":"feaccb3083b9f97d3f413f70ccf14d6d01dcacfb","user":{"login":"qutebrowser","id":21955151,"avatar_url":"https://avatars1.githubusercontent.com/u/21955151?v=4","gravatar_id":"","url":"https://api.github.com/users/qutebrowser","html_url":"https://github.com/qutebrowser","followers_url":"https://api.github.com/users/qutebrowser/followers","following_url":"https://api.github.com/users/qutebrowser/following{/other_user}","gists_url":"https://api.github.com/users/qutebrowser/gists{/gist_id}","starred_url":"https://api.github.com/users/qutebrowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutebrowser/subscriptions","organizations_url":"https://api.github.com/users/qutebrowser/orgs","repos_url":"https://api.github.com/users/qutebrowser/repos","events_url":"https://api.github.com/users/qutebrowser/events{/privacy}","received_events_url":"https://api.github.com/users/qutebrowser/received_events","type":"Organization","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"qutebrowser/qutebrowser","owner":{"login":"qutebrowser","id":21955151,"avatar_url":"https://avatars1.githubusercontent.com/u/21955151?v=4","gravatar_id":"","url":"https://api.github.com/users/qutebrowser","html_url":"https://github.com/qutebrowser","followers_url":"https://api.github.com/users/qutebrowser/followers","following_url":"https://api.github.com/users/qutebrowser/following{/other_user}","gists_url":"https://api.github.com/users/qutebrowser/gists{/gist_id}","starred_url":"https://api.github.com/users/qutebrowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutebrowser/subscriptions","organizations_url":"https://api.github.com/users/qutebrowser/orgs","repos_url":"https://api.github.com/users/qutebrowser/repos","events_url":"https://api.github.com/users/qutebrowser/events{/privacy}","received_events_url":"https://api.github.com/users/qutebrowser/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qutebrowser/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":false,"url":"https://api.github.com/repos/qutebrowser/qutebrowser","forks_url":"https://api.github.com/repos/qutebrowser/qutebrowser/forks","keys_url":"https://api.github.com/repos/qutebrowser/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qutebrowser/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qutebrowser/qutebrowser/teams","hooks_url":"https://api.github.com/repos/qutebrowser/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/qutebrowser/qutebrowser/events","assignees_url":"https://api.github.com/repos/qutebrowser/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/qutebrowser/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/qutebrowser/qutebrowser/tags","blobs_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qutebrowser/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/qutebrowser/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/qutebrowser/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/qutebrowser/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/qutebrowser/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/qutebrowser/qutebrowser/subscription","commits_url":"https://api.github.com/repos/qutebrowser/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/qutebrowser/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/qutebrowser/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qutebrowser/qutebrowser/merges","archive_url":"https://api.github.com/repos/qutebrowser/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qutebrowser/qutebrowser/downloads","issues_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/qutebrowser/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/qutebrowser/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qutebrowser/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/qutebrowser/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/deployments","created_at":"2014-06-26T14:59:34Z","updated_at":"2017-10-10T09:10:43Z","pushed_at":"2017-10-10T11:14:27Z","git_url":"git://github.com/qutebrowser/qutebrowser.git","ssh_url":"git@github.com:qutebrowser/qutebrowser.git","clone_url":"https://github.com/qutebrowser/qutebrowser.git","svn_url":"https://github.com/qutebrowser/qutebrowser","homepage":"https://www.qutebrowser.org/","size":26273,"stargazers_count":2380,"watchers_count":2380,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":487,"forks":347,"open_issues":487,"watchers":2380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055"},"html":{"href":"https://github.com/qutebrowser/qutebrowser/pull/3055"},"issue":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3055"},"comments":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3055/comments"},"review_comments":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055/comments"},"review_comment":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3055/commits"},"statuses":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/statuses/e1f5da3eff50c44462562f900314125f9494a173"}},"author_association":"NONE"}}
{"actor":{"display_login":"The-Compiler"}}