{"action":"closed","number":5901,"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5901","id":88121910,"html_url":"https://github.com/NREL/EnergyPlus/pull/5901","diff_url":"https://github.com/NREL/EnergyPlus/pull/5901.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5901.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5901","number":5901,"state":"closed","locked":false,"title":"Add Kiva foundation heat transfer calculations","user":{"login":"nealkruis","id":1964570,"avatar_url":"https://avatars.githubusercontent.com/u/1964570?v=3","gravatar_id":"","url":"https://api.github.com/users/nealkruis","html_url":"https://github.com/nealkruis","followers_url":"https://api.github.com/users/nealkruis/followers","following_url":"https://api.github.com/users/nealkruis/following{/other_user}","gists_url":"https://api.github.com/users/nealkruis/gists{/gist_id}","starred_url":"https://api.github.com/users/nealkruis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealkruis/subscriptions","organizations_url":"https://api.github.com/users/nealkruis/orgs","repos_url":"https://api.github.com/users/nealkruis/repos","events_url":"https://api.github.com/users/nealkruis/events{/privacy}","received_events_url":"https://api.github.com/users/nealkruis/received_events","type":"User","site_admin":false},"body":"## Pull request overview\r\n\r\nIntegration of Kiva into EnergyPlus as described in [this NFP](https://github.com/NREL/EnergyPlus/blob/kiva/design/FY2017/Kiva-NFP.md).\r\n\r\nWork completed for:\r\n\r\n- Task Order No. KAGN-4-42502-04 under Task Ordering Agreement No. KAGN-4-42502-00: \"2016 EnergyPlus Foundation Heat Transfer Algorithm Evaluation and Model Development\" and \r\n- Subcontract AEU-7-70112-01: “2017 EnergyPlus Foundation Heat Transfer Algorithm Model Development”\r\n\r\n### Work Checklist\r\n- [x] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n- [x] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n  - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n  - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n  - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n  - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n  - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n### Review Checklist\r\n\r\nThis will not be exhaustively relevant to every PR.\r\n- [ ] Code style (parentheses padding, variable names)\r\n- [ ] Functional code review (it has to work!)\r\n- [ ] CI status: all green or justified\r\n- [ ] Performance: CI Linux results include performance check -- verify this\r\n- [ ] Unit Test(s)\r\n- C++ checks:\r\n  - [ ] Argument types\r\n  - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n- IDD changes:\r\n  - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n  - [x] Open windows IDF Editor with modified IDD to check for errors\r\n  - [ ] If transition, add rules to spreadsheet\r\n  - [ ] If transition, add transition source\r\n  - [ ] If transition, update idfs\r\n- [ ] If new idf included, locally check the err file and other outputs\r\n- [ ] Documentation changes in place\r\n- [ ] Changed docs build successfully\r\n","created_at":"2016-10-05T17:30:41Z","updated_at":"2017-02-23T14:45:34Z","closed_at":"2017-02-23T14:45:34Z","merged_at":"2017-02-23T14:45:34Z","merge_commit_sha":"ae053cab7731bee46d9a54643629cd66914d0586","assignee":{"login":"nealkruis","id":1964570,"avatar_url":"https://avatars.githubusercontent.com/u/1964570?v=3","gravatar_id":"","url":"https://api.github.com/users/nealkruis","html_url":"https://github.com/nealkruis","followers_url":"https://api.github.com/users/nealkruis/followers","following_url":"https://api.github.com/users/nealkruis/following{/other_user}","gists_url":"https://api.github.com/users/nealkruis/gists{/gist_id}","starred_url":"https://api.github.com/users/nealkruis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealkruis/subscriptions","organizations_url":"https://api.github.com/users/nealkruis/orgs","repos_url":"https://api.github.com/users/nealkruis/repos","events_url":"https://api.github.com/users/nealkruis/events{/privacy}","received_events_url":"https://api.github.com/users/nealkruis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nealkruis","id":1964570,"avatar_url":"https://avatars.githubusercontent.com/u/1964570?v=3","gravatar_id":"","url":"https://api.github.com/users/nealkruis","html_url":"https://github.com/nealkruis","followers_url":"https://api.github.com/users/nealkruis/followers","following_url":"https://api.github.com/users/nealkruis/following{/other_user}","gists_url":"https://api.github.com/users/nealkruis/gists{/gist_id}","starred_url":"https://api.github.com/users/nealkruis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealkruis/subscriptions","organizations_url":"https://api.github.com/users/nealkruis/orgs","repos_url":"https://api.github.com/users/nealkruis/repos","events_url":"https://api.github.com/users/nealkruis/events{/privacy}","received_events_url":"https://api.github.com/users/nealkruis/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/5","html_url":"https://github.com/NREL/EnergyPlus/milestone/5","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/5/labels","id":1945154,"number":5,"title":"EnergyPlus 8.7.0","description":"The EnergyPlus 8.7.0 public release at the end of FY17Q2.","creator":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":52,"state":"open","created_at":"2016-08-16T14:27:59Z","updated_at":"2017-02-23T14:45:34Z","due_on":"2017-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5901/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5901/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5901/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/d99d0203016543a6676dfb3868bb1bfef6636b1a","head":{"label":"NREL:kiva","ref":"kiva","sha":"d99d0203016543a6676dfb3868bb1bfef6636b1a","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2017-02-18T05:24:40Z","pushed_at":"2017-02-23T14:45:34Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":305662,"stargazers_count":146,"watchers_count":146,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":444,"forks":98,"open_issues":444,"watchers":146,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"a9a79191d08a1f7ddfc9de569a2586c9999c2e94","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2017-02-18T05:24:40Z","pushed_at":"2017-02-23T14:45:34Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":305662,"stargazers_count":146,"watchers_count":146,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":444,"forks":98,"open_issues":444,"watchers":146,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5901"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5901"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5901"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5901/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5901/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5901/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/d99d0203016543a6676dfb3868bb1bfef6636b1a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"comments":25,"review_comments":50,"maintainer_can_modify":false,"commits":46,"additions":1109523,"deletions":173,"changed_files":5772}}
{"actor":{"display_login":"mjwitte"}}