{"action":"opened","number":681,"pull_request":{"url":"https://api.github.com/repos/casacore/casacore/pulls/681","id":157351682,"html_url":"https://github.com/casacore/casacore/pull/681","diff_url":"https://github.com/casacore/casacore/pull/681.diff","patch_url":"https://github.com/casacore/casacore/pull/681.patch","issue_url":"https://api.github.com/repos/casacore/casacore/issues/681","number":681,"state":"open","locked":false,"title":"Initialize tableiterator in assignment like in constructor","user":{"login":"tammojan","id":7974906,"avatar_url":"https://avatars2.githubusercontent.com/u/7974906?v=4","gravatar_id":"","url":"https://api.github.com/users/tammojan","html_url":"https://github.com/tammojan","followers_url":"https://api.github.com/users/tammojan/followers","following_url":"https://api.github.com/users/tammojan/following{/other_user}","gists_url":"https://api.github.com/users/tammojan/gists{/gist_id}","starred_url":"https://api.github.com/users/tammojan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tammojan/subscriptions","organizations_url":"https://api.github.com/users/tammojan/orgs","repos_url":"https://api.github.com/users/tammojan/repos","events_url":"https://api.github.com/users/tammojan/events{/privacy}","received_events_url":"https://api.github.com/users/tammojan/received_events","type":"User","site_admin":false},"body":"It turns out the solution in #644 did break the DPPP build; I'm not sure how this slipped (I tested it then, but I don't know how it could have passed). Unfortunately this also means that the released 2.4.0 under some circumstances does not work well with DPPP.\r\n\r\nIn the following code, I expect `iter1` and `iter2` to be really the same:\r\n```\r\nTableIterator iter1(tab1, iv1, compObj, orders);\r\nTableIterator iter2 = TableIterator(tab1, iv1, compObj, orders);\r\n```\r\n\r\nIt turns out that although they have the same `nrows()`, they yield a different number of rows. This is demonstrated in the test in this PR.\r\n\r\nI think it is valid to call `next()` in the copy constructor, because it is also called once in the normal [constructor](https://github.com/casacore/casacore/blob/master/tables/Tables/TableIter.cc#L52) of TableIterator. This first call of `next()` yields the initial state of a newly constructed TableIterator. So I do not think it copies the state of the copied constructor, as suggested in #644.\r\n\r\nIn short, I think the solution of #624 and #625 is valid and does not copy the state as suggested in #615. It merely initializes the newly created TableIterator in the same way as in the normal constructor.","created_at":"2017-12-08T22:57:54Z","updated_at":"2017-12-08T22:57:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/casacore/casacore/pulls/681/commits","review_comments_url":"https://api.github.com/repos/casacore/casacore/pulls/681/comments","review_comment_url":"https://api.github.com/repos/casacore/casacore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/casacore/casacore/issues/681/comments","statuses_url":"https://api.github.com/repos/casacore/casacore/statuses/f56b9766019ef2a9062d1b5e78241949d21b200d","head":{"label":"tammojan:fixtabiterclone","ref":"fixtabiterclone","sha":"f56b9766019ef2a9062d1b5e78241949d21b200d","user":{"login":"tammojan","id":7974906,"avatar_url":"https://avatars2.githubusercontent.com/u/7974906?v=4","gravatar_id":"","url":"https://api.github.com/users/tammojan","html_url":"https://github.com/tammojan","followers_url":"https://api.github.com/users/tammojan/followers","following_url":"https://api.github.com/users/tammojan/following{/other_user}","gists_url":"https://api.github.com/users/tammojan/gists{/gist_id}","starred_url":"https://api.github.com/users/tammojan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tammojan/subscriptions","organizations_url":"https://api.github.com/users/tammojan/orgs","repos_url":"https://api.github.com/users/tammojan/repos","events_url":"https://api.github.com/users/tammojan/events{/privacy}","received_events_url":"https://api.github.com/users/tammojan/received_events","type":"User","site_admin":false},"repo":{"id":38172643,"name":"casacore","full_name":"tammojan/casacore","owner":{"login":"tammojan","id":7974906,"avatar_url":"https://avatars2.githubusercontent.com/u/7974906?v=4","gravatar_id":"","url":"https://api.github.com/users/tammojan","html_url":"https://github.com/tammojan","followers_url":"https://api.github.com/users/tammojan/followers","following_url":"https://api.github.com/users/tammojan/following{/other_user}","gists_url":"https://api.github.com/users/tammojan/gists{/gist_id}","starred_url":"https://api.github.com/users/tammojan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tammojan/subscriptions","organizations_url":"https://api.github.com/users/tammojan/orgs","repos_url":"https://api.github.com/users/tammojan/repos","events_url":"https://api.github.com/users/tammojan/events{/privacy}","received_events_url":"https://api.github.com/users/tammojan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tammojan/casacore","description":"Suite of c++ libraries for radio astronomy data processing","fork":true,"url":"https://api.github.com/repos/tammojan/casacore","forks_url":"https://api.github.com/repos/tammojan/casacore/forks","keys_url":"https://api.github.com/repos/tammojan/casacore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tammojan/casacore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tammojan/casacore/teams","hooks_url":"https://api.github.com/repos/tammojan/casacore/hooks","issue_events_url":"https://api.github.com/repos/tammojan/casacore/issues/events{/number}","events_url":"https://api.github.com/repos/tammojan/casacore/events","assignees_url":"https://api.github.com/repos/tammojan/casacore/assignees{/user}","branches_url":"https://api.github.com/repos/tammojan/casacore/branches{/branch}","tags_url":"https://api.github.com/repos/tammojan/casacore/tags","blobs_url":"https://api.github.com/repos/tammojan/casacore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tammojan/casacore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tammojan/casacore/git/refs{/sha}","trees_url":"https://api.github.com/repos/tammojan/casacore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tammojan/casacore/statuses/{sha}","languages_url":"https://api.github.com/repos/tammojan/casacore/languages","stargazers_url":"https://api.github.com/repos/tammojan/casacore/stargazers","contributors_url":"https://api.github.com/repos/tammojan/casacore/contributors","subscribers_url":"https://api.github.com/repos/tammojan/casacore/subscribers","subscription_url":"https://api.github.com/repos/tammojan/casacore/subscription","commits_url":"https://api.github.com/repos/tammojan/casacore/commits{/sha}","git_commits_url":"https://api.github.com/repos/tammojan/casacore/git/commits{/sha}","comments_url":"https://api.github.com/repos/tammojan/casacore/comments{/number}","issue_comment_url":"https://api.github.com/repos/tammojan/casacore/issues/comments{/number}","contents_url":"https://api.github.com/repos/tammojan/casacore/contents/{+path}","compare_url":"https://api.github.com/repos/tammojan/casacore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tammojan/casacore/merges","archive_url":"https://api.github.com/repos/tammojan/casacore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tammojan/casacore/downloads","issues_url":"https://api.github.com/repos/tammojan/casacore/issues{/number}","pulls_url":"https://api.github.com/repos/tammojan/casacore/pulls{/number}","milestones_url":"https://api.github.com/repos/tammojan/casacore/milestones{/number}","notifications_url":"https://api.github.com/repos/tammojan/casacore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tammojan/casacore/labels{/name}","releases_url":"https://api.github.com/repos/tammojan/casacore/releases{/id}","deployments_url":"https://api.github.com/repos/tammojan/casacore/deployments","created_at":"2015-06-27T19:33:59Z","updated_at":"2017-03-08T08:04:06Z","pushed_at":"2017-12-08T22:51:19Z","git_url":"git://github.com/tammojan/casacore.git","ssh_url":"git@github.com:tammojan/casacore.git","clone_url":"https://github.com/tammojan/casacore.git","svn_url":"https://github.com/tammojan/casacore","homepage":"http://casacore.github.io/casacore","size":109332,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"casacore:master","ref":"master","sha":"c677225c10beec461584d27258778d6b98e3ae23","user":{"login":"casacore","id":11732311,"avatar_url":"https://avatars2.githubusercontent.com/u/11732311?v=4","gravatar_id":"","url":"https://api.github.com/users/casacore","html_url":"https://github.com/casacore","followers_url":"https://api.github.com/users/casacore/followers","following_url":"https://api.github.com/users/casacore/following{/other_user}","gists_url":"https://api.github.com/users/casacore/gists{/gist_id}","starred_url":"https://api.github.com/users/casacore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casacore/subscriptions","organizations_url":"https://api.github.com/users/casacore/orgs","repos_url":"https://api.github.com/users/casacore/repos","events_url":"https://api.github.com/users/casacore/events{/privacy}","received_events_url":"https://api.github.com/users/casacore/received_events","type":"Organization","site_admin":false},"repo":{"id":33168839,"name":"casacore","full_name":"casacore/casacore","owner":{"login":"casacore","id":11732311,"avatar_url":"https://avatars2.githubusercontent.com/u/11732311?v=4","gravatar_id":"","url":"https://api.github.com/users/casacore","html_url":"https://github.com/casacore","followers_url":"https://api.github.com/users/casacore/followers","following_url":"https://api.github.com/users/casacore/following{/other_user}","gists_url":"https://api.github.com/users/casacore/gists{/gist_id}","starred_url":"https://api.github.com/users/casacore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casacore/subscriptions","organizations_url":"https://api.github.com/users/casacore/orgs","repos_url":"https://api.github.com/users/casacore/repos","events_url":"https://api.github.com/users/casacore/events{/privacy}","received_events_url":"https://api.github.com/users/casacore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/casacore/casacore","description":"Suite of c++ libraries for radio astronomy data processing","fork":false,"url":"https://api.github.com/repos/casacore/casacore","forks_url":"https://api.github.com/repos/casacore/casacore/forks","keys_url":"https://api.github.com/repos/casacore/casacore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/casacore/casacore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/casacore/casacore/teams","hooks_url":"https://api.github.com/repos/casacore/casacore/hooks","issue_events_url":"https://api.github.com/repos/casacore/casacore/issues/events{/number}","events_url":"https://api.github.com/repos/casacore/casacore/events","assignees_url":"https://api.github.com/repos/casacore/casacore/assignees{/user}","branches_url":"https://api.github.com/repos/casacore/casacore/branches{/branch}","tags_url":"https://api.github.com/repos/casacore/casacore/tags","blobs_url":"https://api.github.com/repos/casacore/casacore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/casacore/casacore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/casacore/casacore/git/refs{/sha}","trees_url":"https://api.github.com/repos/casacore/casacore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/casacore/casacore/statuses/{sha}","languages_url":"https://api.github.com/repos/casacore/casacore/languages","stargazers_url":"https://api.github.com/repos/casacore/casacore/stargazers","contributors_url":"https://api.github.com/repos/casacore/casacore/contributors","subscribers_url":"https://api.github.com/repos/casacore/casacore/subscribers","subscription_url":"https://api.github.com/repos/casacore/casacore/subscription","commits_url":"https://api.github.com/repos/casacore/casacore/commits{/sha}","git_commits_url":"https://api.github.com/repos/casacore/casacore/git/commits{/sha}","comments_url":"https://api.github.com/repos/casacore/casacore/comments{/number}","issue_comment_url":"https://api.github.com/repos/casacore/casacore/issues/comments{/number}","contents_url":"https://api.github.com/repos/casacore/casacore/contents/{+path}","compare_url":"https://api.github.com/repos/casacore/casacore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/casacore/casacore/merges","archive_url":"https://api.github.com/repos/casacore/casacore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/casacore/casacore/downloads","issues_url":"https://api.github.com/repos/casacore/casacore/issues{/number}","pulls_url":"https://api.github.com/repos/casacore/casacore/pulls{/number}","milestones_url":"https://api.github.com/repos/casacore/casacore/milestones{/number}","notifications_url":"https://api.github.com/repos/casacore/casacore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/casacore/casacore/labels{/name}","releases_url":"https://api.github.com/repos/casacore/casacore/releases{/id}","deployments_url":"https://api.github.com/repos/casacore/casacore/deployments","created_at":"2015-03-31T06:27:52Z","updated_at":"2017-10-13T09:14:38Z","pushed_at":"2017-12-08T15:51:25Z","git_url":"git://github.com/casacore/casacore.git","ssh_url":"git@github.com:casacore/casacore.git","clone_url":"https://github.com/casacore/casacore.git","svn_url":"https://github.com/casacore/casacore","homepage":"http://casacore.github.io/casacore","size":113108,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":50,"open_issues":46,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/casacore/casacore/pulls/681"},"html":{"href":"https://github.com/casacore/casacore/pull/681"},"issue":{"href":"https://api.github.com/repos/casacore/casacore/issues/681"},"comments":{"href":"https://api.github.com/repos/casacore/casacore/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/casacore/casacore/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/casacore/casacore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/casacore/casacore/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/casacore/casacore/statuses/f56b9766019ef2a9062d1b5e78241949d21b200d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":22,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"tammojan"}}