{"action":"created","issue":{"url":"https://api.github.com/repos/qTox/qTox/issues/4385","repository_url":"https://api.github.com/repos/qTox/qTox","labels_url":"https://api.github.com/repos/qTox/qTox/issues/4385/labels{/name}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/4385/comments","events_url":"https://api.github.com/repos/qTox/qTox/issues/4385/events","html_url":"https://github.com/qTox/qTox/issues/4385","id":227427735,"number":4385,"title":"[regression] Some profiles fail to connect after the upgrade to 1.10.0","user":{"login":"yurivict","id":271906,"avatar_url":"https://avatars1.githubusercontent.com/u/271906?v=3","gravatar_id":"","url":"https://api.github.com/users/yurivict","html_url":"https://github.com/yurivict","followers_url":"https://api.github.com/users/yurivict/followers","following_url":"https://api.github.com/users/yurivict/following{/other_user}","gists_url":"https://api.github.com/users/yurivict/gists{/gist_id}","starred_url":"https://api.github.com/users/yurivict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurivict/subscriptions","organizations_url":"https://api.github.com/users/yurivict/orgs","repos_url":"https://api.github.com/users/yurivict/repos","events_url":"https://api.github.com/users/yurivict/events{/privacy}","received_events_url":"https://api.github.com/users/yurivict/received_events","type":"User","site_admin":false},"labels":[{"id":109351124,"url":"https://api.github.com/repos/qTox/qTox/labels/I-bug","name":"I-bug","color":"fc2929","default":false},{"id":210312579,"url":"https://api.github.com/repos/qTox/qTox/labels/P-very-high","name":"P-very-high","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/qTox/qTox/milestones/16","html_url":"https://github.com/qTox/qTox/milestone/16","labels_url":"https://api.github.com/repos/qTox/qTox/milestones/16/labels","id":2392997,"number":16,"title":"v1.11.0","description":"Stuff needed for the release","creator":{"login":"zetok","id":3148759,"avatar_url":"https://avatars2.githubusercontent.com/u/3148759?v=3","gravatar_id":"","url":"https://api.github.com/users/zetok","html_url":"https://github.com/zetok","followers_url":"https://api.github.com/users/zetok/followers","following_url":"https://api.github.com/users/zetok/following{/other_user}","gists_url":"https://api.github.com/users/zetok/gists{/gist_id}","starred_url":"https://api.github.com/users/zetok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetok/subscriptions","organizations_url":"https://api.github.com/users/zetok/orgs","repos_url":"https://api.github.com/users/zetok/repos","events_url":"https://api.github.com/users/zetok/events{/privacy}","received_events_url":"https://api.github.com/users/zetok/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2017-03-17T09:01:56Z","updated_at":"2017-05-11T18:41:46Z","due_on":"2017-06-18T07:00:00Z","closed_at":null},"comments":16,"created_at":"2017-05-09T16:41:11Z","updated_at":"2017-05-11T19:17:50Z","closed_at":null,"body":"Some profiles fail to connect in 1.10.0, see log below.\r\nSome other instance connect fine.\r\n\r\nThis is a show-stopper regression.\r\n\r\n```\r\n[16:38:03.735 UTC] widget/systemtrayicon.cpp:61 : Debug: Using GTK backend\r\n[16:38:04.538 UTC] core/core.cpp:415 : Debug: \"Connecting to 2a02:7aa0:1619::bdbd:17b8:33445 (Rotkaermota)\"\r\n[16:38:04.538 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from Rotkaermota\"\r\n[16:38:04.538 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from Rotkaermota\"\r\n[16:38:04.538 UTC] core/core.cpp:415 : Debug: \"Connecting to 95.215.46.114:33445 (Rotkaermota)\"\r\n[16:38:04.538 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from Rotkaermota\"\r\n[16:38:04.538 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from Rotkaermota\"\r\n[16:38:09.170 UTC] core/core.cpp:415 : Debug: \"Connecting to 104.223.122.15:33445 (ru_maniac)\"\r\n[16:38:09.170 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from ru_maniac\"\r\n[16:38:09.170 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from ru_maniac\"\r\n[16:38:09.170 UTC] core/core.cpp:415 : Debug: \"Connecting to 185.58.206.164:33445 (ru_maniac)\"\r\n[16:38:09.170 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from ru_maniac\"\r\n[16:38:09.170 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from ru_maniac\"\r\n[16:38:13.805 UTC] core/core.cpp:415 : Debug: \"Connecting to 2a02:f680:1:1100::3313:33445 (ru_maniac)\"\r\n[16:38:13.805 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from ru_maniac\"\r\n[16:38:13.805 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from ru_maniac\"\r\n[16:38:13.805 UTC] core/core.cpp:415 : Debug: \"Connecting to 5.135.59.163:33445 (Skey)\"\r\n[16:38:13.805 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from Skey\"\r\n[16:38:13.805 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from Skey\"\r\n[16:38:18.485 UTC] core/core.cpp:415 : Debug: \"Connecting to sorunome.de:33445 (Sorunome)\"\r\n[16:38:18.485 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from Sorunome\"\r\n[16:38:18.485 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from Sorunome\"\r\n[16:38:18.485 UTC] core/core.cpp:415 : Debug: \"Connecting to tox.zodiaclabs.org:33445 (stal)\"\r\n[16:38:18.485 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from stal\"\r\n[16:38:18.485 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from stal\"\r\n[16:38:23.172 UTC] core/core.cpp:415 : Debug: \"Connecting to v6.tox.zodiaclabs.org:33445 (stal)\"\r\n[16:38:23.172 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from stal\"\r\n[16:38:23.172 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from stal\"\r\n[16:38:23.172 UTC] core/core.cpp:415 : Debug: \"Connecting to 195.93.190.6:33445 (strngr)\"\r\n[16:38:23.172 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from strngr\"\r\n[16:38:23.172 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from strngr\"\r\n[16:38:27.842 UTC] core/core.cpp:415 : Debug: \"Connecting to 2a01:d0:ffff:a8a::2:33445 (strngr)\"\r\n[16:38:27.842 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from strngr\"\r\n[16:38:27.842 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from strngr\"\r\n[16:38:27.842 UTC] core/core.cpp:415 : Debug: \"Connecting to 92.54.84.70:33445 (t3mp)\"\r\n[16:38:27.842 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from t3mp\"\r\n[16:38:27.842 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from t3mp\"\r\n[16:38:32.524 UTC] core/core.cpp:415 : Debug: \"Connecting to 5.189.176.217:5190 (tastytea)\"\r\n[16:38:32.524 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from tastytea\"\r\n[16:38:32.524 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from tastytea\"\r\n[16:38:32.525 UTC] core/core.cpp:415 : Debug: \"Connecting to 2a00:d880:3:2::8bdc:f19:33445 (tibietigni)\"\r\n[16:38:32.525 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from tibietigni\"\r\n[16:38:32.525 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from tibietigni\"\r\n[16:38:37.159 UTC] core/core.cpp:415 : Debug: \"Connecting to 81.4.110.149:33445 (tibietigni)\"\r\n[16:38:37.159 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from tibietigni\"\r\n[16:38:37.159 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from tibietigni\"\r\n[16:38:37.159 UTC] core/core.cpp:415 : Debug: \"Connecting to 192.99.168.140:33445 (WIeschie)\"\r\n[16:38:37.159 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from WIeschie\"\r\n[16:38:37.159 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from WIeschie\"\r\n[16:38:41.808 UTC] core/core.cpp:415 : Debug: \"Connecting to 128.199.199.197:33445 (wiiaam)\"\r\n[16:38:41.808 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from wiiaam\"\r\n[16:38:41.808 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from wiiaam\"\r\n[16:38:41.808 UTC] core/core.cpp:415 : Debug: \"Connecting to 2400:6180:0:d0::17a:a001:33445 (wiiaam)\"\r\n[16:38:41.808 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from wiiaam\"\r\n[16:38:41.808 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from wiiaam\"\r\n[16:38:46.451 UTC] core/core.cpp:415 : Debug: \"Connecting to 37.97.185.116:33445 (Yani)\"\r\n[16:38:46.451 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from Yani\"\r\n[16:38:46.451 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from Yani\"\r\n[16:38:46.451 UTC] core/core.cpp:415 : Debug: \"Connecting to 51.254.84.212:33445 (a68366)\"\r\n[16:38:46.451 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from a68366\"\r\n[16:38:46.451 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from a68366\"\r\n[16:38:51.140 UTC] core/core.cpp:415 : Debug: \"Connecting to loki.uplinklabs.net:33445 (AbacusAvenger)\"\r\n[16:38:51.140 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from AbacusAvenger\"\r\n[16:38:51.140 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from AbacusAvenger\"\r\n[16:38:51.140 UTC] core/core.cpp:415 : Debug: \"Connecting to tox.ntp.moscow:33445 (abbat)\"\r\n[16:38:51.140 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from abbat\"\r\n[16:38:51.140 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from abbat\"\r\n[16:38:55.822 UTC] core/core.cpp:415 : Debug: \"Connecting to bootybay.club:33445 (AssPirate)\"\r\n[16:38:55.823 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from AssPirate\"\r\n[16:38:55.823 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from AssPirate\"\r\n[16:38:55.823 UTC] core/core.cpp:415 : Debug: \"Connecting to tox.neverlocate.me:33445 (brandon)\"\r\n[16:38:55.823 UTC] core/core.cpp:422 : Debug: \"Error bootstrapping from brandon\"\r\n[16:38:55.823 UTC] core/core.cpp:426 : Debug: \"Error adding TCP relay from brandon\"\r\n```"},"comment":{"url":"https://api.github.com/repos/qTox/qTox/issues/comments/300890110","html_url":"https://github.com/qTox/qTox/issues/4385#issuecomment-300890110","issue_url":"https://api.github.com/repos/qTox/qTox/issues/4385","id":300890110,"user":{"login":"nurupo","id":1855294,"avatar_url":"https://avatars2.githubusercontent.com/u/1855294?v=3","gravatar_id":"","url":"https://api.github.com/users/nurupo","html_url":"https://github.com/nurupo","followers_url":"https://api.github.com/users/nurupo/followers","following_url":"https://api.github.com/users/nurupo/following{/other_user}","gists_url":"https://api.github.com/users/nurupo/gists{/gist_id}","starred_url":"https://api.github.com/users/nurupo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurupo/subscriptions","organizations_url":"https://api.github.com/users/nurupo/orgs","repos_url":"https://api.github.com/users/nurupo/repos","events_url":"https://api.github.com/users/nurupo/events{/privacy}","received_events_url":"https://api.github.com/users/nurupo/received_events","type":"User","site_admin":false},"created_at":"2017-05-11T19:17:50Z","updated_at":"2017-05-11T19:17:50Z","body":"The bug was introduced by https://github.com/qTox/qTox/commit/d126b18d76150700caa52c801e91d94460fe4346 commit.\r\n\r\nThe bug is in line https://github.com/qTox/qTox/blob/d126b18d76150700caa52c801e91d94460fe4346/src/core/core.cpp#L397\r\n\r\n>ToxPk pk{dhtServer.userId.toLatin1()};\r\n\r\n[`ToxPk`'s constructor for `QByteArray` argument](https://github.com/qTox/qTox/blob/master/src/core/toxpk.cpp#L30-L42) expects the argument to be the byte representation of ToxID (which is 32 bytes long, `TOX_PUBLIC_KEY_SIZE`), while `dhtServer.userId.toLatin1()` is ASCII (Latin1) byte representation of ToxId (which is 64 bytes), so it constructs an empty `ToxPk`."}}
{"actor":{"display_login":"nurupo"}}