{"action":"created","comment":{"url":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments/99903491","pull_request_review_id":20593491,"id":99903491,"diff_hunk":"@@ -605,11 +605,17 @@ impl CompInfo {\n                 CXCursor_UnionDecl |\n                 CXCursor_ClassTemplate |\n                 CXCursor_ClassDecl => {\n+                    // We can find non-semantic children here, see:\n+                    // https://github.com/servo/rust-bindgen/issues/482","path":"src/ir/comp.rs","position":5,"original_position":5,"commit_id":"2a4bfc428662acbccf4e4e24c209001caa2b1e15","original_commit_id":"f979b14d6db520ef945245e9272a251c1c87a492","user":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"body":"Please leave a one or two sentence description of why/when we can find non-semantic children here, and only link the issue if you think it is still relevant with those sentences.","created_at":"2017-02-07T19:13:20Z","updated_at":"2017-02-07T19:14:36Z","html_url":"https://github.com/servo/rust-bindgen/pull/486#discussion_r99903491","pull_request_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/486","_links":{"self":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments/99903491"},"html":{"href":"https://github.com/servo/rust-bindgen/pull/486#discussion_r99903491"},"pull_request":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/486"}}},"pull_request":{"url":"https://api.github.com/repos/servo/rust-bindgen/pulls/486","id":104996569,"html_url":"https://github.com/servo/rust-bindgen/pull/486","diff_url":"https://github.com/servo/rust-bindgen/pull/486.diff","patch_url":"https://github.com/servo/rust-bindgen/pull/486.patch","issue_url":"https://api.github.com/repos/servo/rust-bindgen/issues/486","number":486,"state":"open","locked":false,"title":"ir: Don't parse non-semantic-children cursor as inner structs.","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"body":"r? @fitzgen ","created_at":"2017-02-07T12:37:28Z","updated_at":"2017-02-07T19:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10a45ecbee1b4a95eff7c574a5a3dc92008c15e8","assignee":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"assignees":[{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/486/commits","review_comments_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/486/comments","review_comment_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/rust-bindgen/issues/486/comments","statuses_url":"https://api.github.com/repos/servo/rust-bindgen/statuses/2a4bfc428662acbccf4e4e24c209001caa2b1e15","head":{"label":"emilio:unresolved-nasty-thingie","ref":"unresolved-nasty-thingie","sha":"2a4bfc428662acbccf4e4e24c209001caa2b1e15","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"repo":{"id":53173354,"name":"rust-bindgen","full_name":"emilio/rust-bindgen","owner":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emilio/rust-bindgen","description":"binding generator for rust language","fork":true,"url":"https://api.github.com/repos/emilio/rust-bindgen","forks_url":"https://api.github.com/repos/emilio/rust-bindgen/forks","keys_url":"https://api.github.com/repos/emilio/rust-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emilio/rust-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emilio/rust-bindgen/teams","hooks_url":"https://api.github.com/repos/emilio/rust-bindgen/hooks","issue_events_url":"https://api.github.com/repos/emilio/rust-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/emilio/rust-bindgen/events","assignees_url":"https://api.github.com/repos/emilio/rust-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/emilio/rust-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/emilio/rust-bindgen/tags","blobs_url":"https://api.github.com/repos/emilio/rust-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emilio/rust-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emilio/rust-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/emilio/rust-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emilio/rust-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/emilio/rust-bindgen/languages","stargazers_url":"https://api.github.com/repos/emilio/rust-bindgen/stargazers","contributors_url":"https://api.github.com/repos/emilio/rust-bindgen/contributors","subscribers_url":"https://api.github.com/repos/emilio/rust-bindgen/subscribers","subscription_url":"https://api.github.com/repos/emilio/rust-bindgen/subscription","commits_url":"https://api.github.com/repos/emilio/rust-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/emilio/rust-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/emilio/rust-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/emilio/rust-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/emilio/rust-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/emilio/rust-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emilio/rust-bindgen/merges","archive_url":"https://api.github.com/repos/emilio/rust-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emilio/rust-bindgen/downloads","issues_url":"https://api.github.com/repos/emilio/rust-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/emilio/rust-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/emilio/rust-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/emilio/rust-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emilio/rust-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/emilio/rust-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/emilio/rust-bindgen/deployments","created_at":"2016-03-05T00:01:47Z","updated_at":"2016-03-05T00:01:47Z","pushed_at":"2017-02-07T15:54:30Z","git_url":"git://github.com/emilio/rust-bindgen.git","ssh_url":"git@github.com:emilio/rust-bindgen.git","clone_url":"https://github.com/emilio/rust-bindgen.git","svn_url":"https://github.com/emilio/rust-bindgen","homepage":"","size":3291,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"sm-hacks-rebase-squashed"}},"base":{"label":"servo:master","ref":"master","sha":"7fa654c699b61250787e53a300357f0c58c55b18","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":61728459,"name":"rust-bindgen","full_name":"servo/rust-bindgen","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/rust-bindgen","description":"Automatically generates Rust FFI bindings to C and C++ libraries.","fork":false,"url":"https://api.github.com/repos/servo/rust-bindgen","forks_url":"https://api.github.com/repos/servo/rust-bindgen/forks","keys_url":"https://api.github.com/repos/servo/rust-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/rust-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/rust-bindgen/teams","hooks_url":"https://api.github.com/repos/servo/rust-bindgen/hooks","issue_events_url":"https://api.github.com/repos/servo/rust-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/servo/rust-bindgen/events","assignees_url":"https://api.github.com/repos/servo/rust-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/servo/rust-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/servo/rust-bindgen/tags","blobs_url":"https://api.github.com/repos/servo/rust-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/rust-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/rust-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/rust-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/rust-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/rust-bindgen/languages","stargazers_url":"https://api.github.com/repos/servo/rust-bindgen/stargazers","contributors_url":"https://api.github.com/repos/servo/rust-bindgen/contributors","subscribers_url":"https://api.github.com/repos/servo/rust-bindgen/subscribers","subscription_url":"https://api.github.com/repos/servo/rust-bindgen/subscription","commits_url":"https://api.github.com/repos/servo/rust-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/rust-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/rust-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/rust-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/rust-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/servo/rust-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/rust-bindgen/merges","archive_url":"https://api.github.com/repos/servo/rust-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/rust-bindgen/downloads","issues_url":"https://api.github.com/repos/servo/rust-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/servo/rust-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/rust-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/rust-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/rust-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/servo/rust-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/servo/rust-bindgen/deployments","created_at":"2016-06-22T15:05:51Z","updated_at":"2017-02-07T18:00:33Z","pushed_at":"2017-02-07T15:58:09Z","git_url":"git://github.com/servo/rust-bindgen.git","ssh_url":"git@github.com:servo/rust-bindgen.git","clone_url":"https://github.com/servo/rust-bindgen.git","svn_url":"https://github.com/servo/rust-bindgen","homepage":"","size":2998,"stargazers_count":154,"watchers_count":154,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":75,"forks":172,"open_issues":75,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/486"},"html":{"href":"https://github.com/servo/rust-bindgen/pull/486"},"issue":{"href":"https://api.github.com/repos/servo/rust-bindgen/issues/486"},"comments":{"href":"https://api.github.com/repos/servo/rust-bindgen/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/servo/rust-bindgen/statuses/2a4bfc428662acbccf4e4e24c209001caa2b1e15"}}}}
{"actor":{"display_login":"fitzgen"}}