{"push_id":1819930140,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"557ced0f330edd7baf2959cd700ecdc6b3a69b9d","before":"19a6134d03141dc2cb073a904378c2c129b5138d","commits":[{"sha":"a508bf1d8d6ef1c9c4ccd549c6c854a782e3a9ef","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Avoided sending an inconsistent `TaskInfo` to the allocator.\n\nSince we drop invalid tasks on a `LAUNCH` operation, we send a new\n`Operation` with only the valid tasks appended. At the same time,\nwe adjust the `TaskInfo` a little bit to perform validation, and\nto maintain backwards compatibility. However, the unmodified\n`TaskInfo` was sent to the allocator. Since the allocator does not\nlook at the modified fields, this was inconsequential, but we should\navoid sending inconsistent `TaskInfo`s in general.\n\nWe also avoided creating an unnecessary copy of the `TaskInfo`.\n\nReview: https://reviews.apache.org/r/60281","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/a508bf1d8d6ef1c9c4ccd549c6c854a782e3a9ef"},{"sha":"35c5a34f58ccc47a37e77ff0e80039e504ed4dc1","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Introduced `validateAndUpgradeResources`.\n\nValidation code for operations and tasks validated the resources as\nthe first step, and assumed valid resources from then on. This means\nthat it started to use functions such as `isDynamicallyReserved`.\n\nHowever, since `isDynamicallyReserved` requires the resources to be\nin the \"post-reservation-refinement\" format, we must convert the\nresources before using those functions. For now, we introduce\na `validateAndUpgradeResources` abstraction which is called to validate\nand convert the resources before invoking operation / task validation.\n\nReview: https://reviews.apache.org/r/60282","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/35c5a34f58ccc47a37e77ff0e80039e504ed4dc1"},{"sha":"605a24fa7f8932d3253e86c9813a0113177c02b6","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Updated the `operator<<` for repeated resources to use `JSON::protobuf`.\n\nThe `Resource` objects in a `RepeatedPtrField<Resource>` may not be\nvalidated and/or not converted to the \"post-reservation-refinement\"\nformat. Since `Resources` requires the resources to have been validated\nand converted, we cannot rely on the conversion to be meaningful.\nWe opt to print the resources in their JSON representation instead.\n\nReview: https://reviews.apache.org/r/60351","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/605a24fa7f8932d3253e86c9813a0113177c02b6"},{"sha":"0d9baca48dedbff91510d72d9a452776a836c2df","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Relaxed the resource format restriction for frameworks.\n\nThe current restriction is that the master will only accept resources\nin the \"post-reservation-refinement\" format if the framework has opted\ninto the `RESERVATION_REFINEMENT` capability. This patch relaxes this\nsuch that master will accept resources in any of the 3 formats.\n\nFor example, we output the \"endpoint\" format through the endpoints\nfor backward compatibility of external tooling. A framework should be\nable to use the result of an endpoint and pass it back to Mesos,\nsince the result was produced by Mesos. This is especially applicable\nto the V1 API. We also allow the \"pre-reservation-refinement\" format\nbecause existing \"resources files\" are written in that format, and\nthey should still be usable without modification.\n\nReview: https://reviews.apache.org/r/60352","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/0d9baca48dedbff91510d72d9a452776a836c2df"},{"sha":"6524371cafeeaba16af3e7010c8228eac84ad8a4","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Fixed `convertResourceFormat` uses with `validateAndUpgradeResources`.\n\nInitially, it seemed like calling `convertResourceFormat` after\noperation validation seemed safe since the operation validation\nthemselves performed `Resources::validate` within them.\n\nHowever, the rest of the operation validation code relies on\nthe fact that the resources have been validated, and uses\nfunctions such as `isDynamicallyReserved`. Since functions such as\n`isDynamicallyReserved` now requires \"post-reservation-refinement\"\nformat, we must perform this conversion earlier.\n\nIn this patch, we use `upgradeResources` to perform resources\nvalidation __and__ convert the resources before going into the\noperation and task validation.\n\nWe really need a better plan for this going forward. MESOS-7702.\n\nReview: https://reviews.apache.org/r/60283","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/6524371cafeeaba16af3e7010c8228eac84ad8a4"},{"sha":"e0e3e167ac01ee3964a474950d3dad8232798432","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Prevented reserve/create with refined reservation on non-capable agents.\n\nThis patch makes it such that reserve / create operations involving\nresources with refined reservations are invalid if they are attempted\non an agent without a RESERVATION_REFINEMENT capability. Such attempts\nfrom an operator endpoint will result in a `BadRequest` response.\nOn the framework side, the operation will be dropped by the master.\n\nReview: https://reviews.apache.org/r/60255","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/e0e3e167ac01ee3964a474950d3dad8232798432"},{"sha":"8209c0e33ad611cd868421b59423568cf4bbef2b","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Removed unused `convertResourceFormat` for `Operation`.\n\nReview: https://reviews.apache.org/r/60284","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/8209c0e33ad611cd868421b59423568cf4bbef2b"},{"sha":"42ca18cfb4cccfc1ba2d5609de60c267b9a78bcb","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Required that resources are always downgraded for a non-capable agent.\n\nSince the master prevents refined reservations from being created on\nnon-capable agents, we cannot be in a situation in which the resources\nare not downgradable for a non-capable agent.\n\nReview: https://reviews.apache.org/r/60374","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/42ca18cfb4cccfc1ba2d5609de60c267b9a78bcb"},{"sha":"557ced0f330edd7baf2959cd700ecdc6b3a69b9d","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added test for reservation refinements and old agents.\n\nIf the agent does not support reservation refinements, attempts to\ncreate a reservation refinement on the agent should be dropped by the\nmaster.\n\nReview: https://reviews.apache.org/r/60377/","distinct":true,"url":"https://api.github.com/repos/jessfraz/mesos/commits/557ced0f330edd7baf2959cd700ecdc6b3a69b9d"}]}
{"actor":{"display_login":"jessfraz"}}