{"action":"closed","number":8155,"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/8155","id":139654433,"html_url":"https://github.com/elastic/logstash/pull/8155","diff_url":"https://github.com/elastic/logstash/pull/8155.diff","patch_url":"https://github.com/elastic/logstash/pull/8155.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/8155","number":8155,"state":"closed","locked":false,"title":"PERFORMANCE: Remove WriteBatch, it's 100% Redundant","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"`WriteBatch` (apart from from `events` field accessor that I added a few days ago and that never made it to production) exposes no API that `[]` doesn't also expose.\r\n=> We can simply drop the pointless wrapper and use an array a write batch.","created_at":"2017-09-06T20:15:14Z","updated_at":"2017-09-07T07:56:07Z","closed_at":"2017-09-07T07:56:07Z","merged_at":null,"merge_commit_sha":"a3fd5846983667a53f3f5d93d958bef246ff3236","assignee":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrewvc","id":131427,"avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"andrewvc","id":131427,"avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/8155/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/8155/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/8155/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/be045b2ffc845485d654f65afad5e4dce1c52e7d","head":{"label":"original-brownbear:writebatch-is-redundant","ref":"writebatch-is-redundant","sha":"be045b2ffc845485d654f65afad5e4dce1c52e7d","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"repo":{"id":88715786,"name":"logstash","full_name":"original-brownbear/logstash","owner":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/original-brownbear/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/original-brownbear/logstash","forks_url":"https://api.github.com/repos/original-brownbear/logstash/forks","keys_url":"https://api.github.com/repos/original-brownbear/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/original-brownbear/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/original-brownbear/logstash/teams","hooks_url":"https://api.github.com/repos/original-brownbear/logstash/hooks","issue_events_url":"https://api.github.com/repos/original-brownbear/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/original-brownbear/logstash/events","assignees_url":"https://api.github.com/repos/original-brownbear/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/original-brownbear/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/original-brownbear/logstash/tags","blobs_url":"https://api.github.com/repos/original-brownbear/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/original-brownbear/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/original-brownbear/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/original-brownbear/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/original-brownbear/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/original-brownbear/logstash/languages","stargazers_url":"https://api.github.com/repos/original-brownbear/logstash/stargazers","contributors_url":"https://api.github.com/repos/original-brownbear/logstash/contributors","subscribers_url":"https://api.github.com/repos/original-brownbear/logstash/subscribers","subscription_url":"https://api.github.com/repos/original-brownbear/logstash/subscription","commits_url":"https://api.github.com/repos/original-brownbear/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/original-brownbear/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/original-brownbear/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/original-brownbear/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/original-brownbear/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/original-brownbear/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/original-brownbear/logstash/merges","archive_url":"https://api.github.com/repos/original-brownbear/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/original-brownbear/logstash/downloads","issues_url":"https://api.github.com/repos/original-brownbear/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/original-brownbear/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/original-brownbear/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/original-brownbear/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/original-brownbear/logstash/labels{/name}","releases_url":"https://api.github.com/repos/original-brownbear/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/original-brownbear/logstash/deployments","created_at":"2017-04-19T07:40:07Z","updated_at":"2017-04-19T07:40:11Z","pushed_at":"2017-09-07T07:42:22Z","git_url":"git://github.com/original-brownbear/logstash.git","ssh_url":"git@github.com:original-brownbear/logstash.git","clone_url":"https://github.com/original-brownbear/logstash.git","svn_url":"https://github.com/original-brownbear/logstash","homepage":"https://www.elastic.co/products/logstash","size":96860,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"259533aa1fb9ae95fb8baa31a51de8f71f7a3724","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2017-09-07T02:37:20Z","pushed_at":"2017-09-07T07:56:00Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":96048,"stargazers_count":7927,"watchers_count":7927,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2245,"mirror_url":null,"open_issues_count":986,"forks":2245,"open_issues":986,"watchers":7927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8155"},"html":{"href":"https://github.com/elastic/logstash/pull/8155"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/8155"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/8155/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8155/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8155/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/be045b2ffc845485d654f65afad5e4dce1c52e7d"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":47,"changed_files":2}}
{"actor":{"display_login":"elasticsearch-bot"}}