{"action":"created","comment":{"url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/comments/151757960","pull_request_review_id":77523326,"id":151757960,"diff_hunk":"@@ -28,13 +28,23 @@ const RPC_EMULATOR_MODEL = [\n                 example: 'frmPtSel',\n             },\n         ],\n-        invokeRPC: (args, session, callback) => {\n+        invokeRPC: (rpcArgs, session, callback) => {\n             if (_.isEmpty(session.userId)) {\n                 callback(null, '');\n                 return;\n             }\n-            // Get font size via ParameterService\n-            OrderMetaService.loadSize(args, session, callback);\n+            ParameterService.withContext(session).get('ORWCH BOUNDS', { entity: 'USR', instance: rpcArgs[0] })\n+                .then((res) => {\n+                    if (_.isString(rpcArgs[0]) && _.has(res, 'value')) {\n+                        const val = (_.isArray(res) && res.length > 0) ? res[0].value : res.value;","path":"emulation/models/orwch-loadsiz.js","position":33,"original_position":33,"commit_id":"a98240af9d2a985f2571ca536dcd4b38d0b6105b","original_commit_id":"a98240af9d2a985f2571ca536dcd4b38d0b6105b","user":{"login":"creindle","id":17826671,"avatar_url":"https://avatars3.githubusercontent.com/u/17826671?v=4","gravatar_id":"","url":"https://api.github.com/users/creindle","html_url":"https://github.com/creindle","followers_url":"https://api.github.com/users/creindle/followers","following_url":"https://api.github.com/users/creindle/following{/other_user}","gists_url":"https://api.github.com/users/creindle/gists{/gist_id}","starred_url":"https://api.github.com/users/creindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creindle/subscriptions","organizations_url":"https://api.github.com/users/creindle/orgs","repos_url":"https://api.github.com/users/creindle/repos","events_url":"https://api.github.com/users/creindle/events{/privacy}","received_events_url":"https://api.github.com/users/creindle/received_events","type":"User","site_admin":false},"body":"This was another one I transferred over from the service function implementation, so unfortunately I did not test it. Here is the original implementation of this function: https://github.com/vistadataproject/VICSServer/pull/8/files","created_at":"2017-11-17T18:35:39Z","updated_at":"2017-11-17T18:35:39Z","html_url":"https://github.com/vistadataproject/VICSServer/pull/93#discussion_r151757960","pull_request_url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/comments/151757960"},"html":{"href":"https://github.com/vistadataproject/VICSServer/pull/93#discussion_r151757960"},"pull_request":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93"}},"in_reply_to_id":151613816},"pull_request":{"url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93","id":153154022,"html_url":"https://github.com/vistadataproject/VICSServer/pull/93","diff_url":"https://github.com/vistadataproject/VICSServer/pull/93.diff","patch_url":"https://github.com/vistadataproject/VICSServer/pull/93.patch","issue_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues/93","number":93,"state":"open","locked":false,"title":"Refactoring param services ","user":{"login":"creindle","id":17826671,"avatar_url":"https://avatars3.githubusercontent.com/u/17826671?v=4","gravatar_id":"","url":"https://api.github.com/users/creindle","html_url":"https://github.com/creindle","followers_url":"https://api.github.com/users/creindle/followers","following_url":"https://api.github.com/users/creindle/following{/other_user}","gists_url":"https://api.github.com/users/creindle/gists{/gist_id}","starred_url":"https://api.github.com/users/creindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creindle/subscriptions","organizations_url":"https://api.github.com/users/creindle/orgs","repos_url":"https://api.github.com/users/creindle/repos","events_url":"https://api.github.com/users/creindle/events{/privacy}","received_events_url":"https://api.github.com/users/creindle/received_events","type":"User","site_admin":false},"body":"- [X] Grabbed from latest master\r\n- [X] Passes model tests\r\n- [X] Passes comparison tests","created_at":"2017-11-16T21:23:53Z","updated_at":"2017-11-17T18:35:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"074e991ab05121310af7d15db7944065534b8ff3","assignee":{"login":"creindle","id":17826671,"avatar_url":"https://avatars3.githubusercontent.com/u/17826671?v=4","gravatar_id":"","url":"https://api.github.com/users/creindle","html_url":"https://github.com/creindle","followers_url":"https://api.github.com/users/creindle/followers","following_url":"https://api.github.com/users/creindle/following{/other_user}","gists_url":"https://api.github.com/users/creindle/gists{/gist_id}","starred_url":"https://api.github.com/users/creindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creindle/subscriptions","organizations_url":"https://api.github.com/users/creindle/orgs","repos_url":"https://api.github.com/users/creindle/repos","events_url":"https://api.github.com/users/creindle/events{/privacy}","received_events_url":"https://api.github.com/users/creindle/received_events","type":"User","site_admin":false},"assignees":[{"login":"creindle","id":17826671,"avatar_url":"https://avatars3.githubusercontent.com/u/17826671?v=4","gravatar_id":"","url":"https://api.github.com/users/creindle","html_url":"https://github.com/creindle","followers_url":"https://api.github.com/users/creindle/followers","following_url":"https://api.github.com/users/creindle/following{/other_user}","gists_url":"https://api.github.com/users/creindle/gists{/gist_id}","starred_url":"https://api.github.com/users/creindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creindle/subscriptions","organizations_url":"https://api.github.com/users/creindle/orgs","repos_url":"https://api.github.com/users/creindle/repos","events_url":"https://api.github.com/users/creindle/events{/privacy}","received_events_url":"https://api.github.com/users/creindle/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sidjtd","id":18730074,"avatar_url":"https://avatars2.githubusercontent.com/u/18730074?v=4","gravatar_id":"","url":"https://api.github.com/users/sidjtd","html_url":"https://github.com/sidjtd","followers_url":"https://api.github.com/users/sidjtd/followers","following_url":"https://api.github.com/users/sidjtd/following{/other_user}","gists_url":"https://api.github.com/users/sidjtd/gists{/gist_id}","starred_url":"https://api.github.com/users/sidjtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidjtd/subscriptions","organizations_url":"https://api.github.com/users/sidjtd/orgs","repos_url":"https://api.github.com/users/sidjtd/repos","events_url":"https://api.github.com/users/sidjtd/events{/privacy}","received_events_url":"https://api.github.com/users/sidjtd/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93/commits","review_comments_url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93/comments","review_comment_url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues/93/comments","statuses_url":"https://api.github.com/repos/vistadataproject/VICSServer/statuses/a98240af9d2a985f2571ca536dcd4b38d0b6105b","head":{"label":"vistadataproject:refactoring-param-service-2","ref":"refactoring-param-service-2","sha":"a98240af9d2a985f2571ca536dcd4b38d0b6105b","user":{"login":"vistadataproject","id":15674962,"avatar_url":"https://avatars3.githubusercontent.com/u/15674962?v=4","gravatar_id":"","url":"https://api.github.com/users/vistadataproject","html_url":"https://github.com/vistadataproject","followers_url":"https://api.github.com/users/vistadataproject/followers","following_url":"https://api.github.com/users/vistadataproject/following{/other_user}","gists_url":"https://api.github.com/users/vistadataproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vistadataproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vistadataproject/subscriptions","organizations_url":"https://api.github.com/users/vistadataproject/orgs","repos_url":"https://api.github.com/users/vistadataproject/repos","events_url":"https://api.github.com/users/vistadataproject/events{/privacy}","received_events_url":"https://api.github.com/users/vistadataproject/received_events","type":"Organization","site_admin":false},"repo":{"id":105083284,"name":"VICSServer","full_name":"vistadataproject/VICSServer","owner":{"login":"vistadataproject","id":15674962,"avatar_url":"https://avatars3.githubusercontent.com/u/15674962?v=4","gravatar_id":"","url":"https://api.github.com/users/vistadataproject","html_url":"https://github.com/vistadataproject","followers_url":"https://api.github.com/users/vistadataproject/followers","following_url":"https://api.github.com/users/vistadataproject/following{/other_user}","gists_url":"https://api.github.com/users/vistadataproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vistadataproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vistadataproject/subscriptions","organizations_url":"https://api.github.com/users/vistadataproject/orgs","repos_url":"https://api.github.com/users/vistadataproject/repos","events_url":"https://api.github.com/users/vistadataproject/events{/privacy}","received_events_url":"https://api.github.com/users/vistadataproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vistadataproject/VICSServer","description":"VISTA Adaptive Maintenance - Veteran Care Services","fork":false,"url":"https://api.github.com/repos/vistadataproject/VICSServer","forks_url":"https://api.github.com/repos/vistadataproject/VICSServer/forks","keys_url":"https://api.github.com/repos/vistadataproject/VICSServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vistadataproject/VICSServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vistadataproject/VICSServer/teams","hooks_url":"https://api.github.com/repos/vistadataproject/VICSServer/hooks","issue_events_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues/events{/number}","events_url":"https://api.github.com/repos/vistadataproject/VICSServer/events","assignees_url":"https://api.github.com/repos/vistadataproject/VICSServer/assignees{/user}","branches_url":"https://api.github.com/repos/vistadataproject/VICSServer/branches{/branch}","tags_url":"https://api.github.com/repos/vistadataproject/VICSServer/tags","blobs_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vistadataproject/VICSServer/statuses/{sha}","languages_url":"https://api.github.com/repos/vistadataproject/VICSServer/languages","stargazers_url":"https://api.github.com/repos/vistadataproject/VICSServer/stargazers","contributors_url":"https://api.github.com/repos/vistadataproject/VICSServer/contributors","subscribers_url":"https://api.github.com/repos/vistadataproject/VICSServer/subscribers","subscription_url":"https://api.github.com/repos/vistadataproject/VICSServer/subscription","commits_url":"https://api.github.com/repos/vistadataproject/VICSServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/vistadataproject/VICSServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/vistadataproject/VICSServer/contents/{+path}","compare_url":"https://api.github.com/repos/vistadataproject/VICSServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vistadataproject/VICSServer/merges","archive_url":"https://api.github.com/repos/vistadataproject/VICSServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vistadataproject/VICSServer/downloads","issues_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues{/number}","pulls_url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls{/number}","milestones_url":"https://api.github.com/repos/vistadataproject/VICSServer/milestones{/number}","notifications_url":"https://api.github.com/repos/vistadataproject/VICSServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vistadataproject/VICSServer/labels{/name}","releases_url":"https://api.github.com/repos/vistadataproject/VICSServer/releases{/id}","deployments_url":"https://api.github.com/repos/vistadataproject/VICSServer/deployments","created_at":"2017-09-28T00:28:46Z","updated_at":"2017-11-15T19:36:13Z","pushed_at":"2017-11-17T07:11:05Z","git_url":"git://github.com/vistadataproject/VICSServer.git","ssh_url":"git@github.com:vistadataproject/VICSServer.git","clone_url":"https://github.com/vistadataproject/VICSServer.git","svn_url":"https://github.com/vistadataproject/VICSServer","homepage":"","size":1449,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"vistadataproject:master","ref":"master","sha":"7817f111a5b332259ca30670b3e14ba9cd38f88d","user":{"login":"vistadataproject","id":15674962,"avatar_url":"https://avatars3.githubusercontent.com/u/15674962?v=4","gravatar_id":"","url":"https://api.github.com/users/vistadataproject","html_url":"https://github.com/vistadataproject","followers_url":"https://api.github.com/users/vistadataproject/followers","following_url":"https://api.github.com/users/vistadataproject/following{/other_user}","gists_url":"https://api.github.com/users/vistadataproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vistadataproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vistadataproject/subscriptions","organizations_url":"https://api.github.com/users/vistadataproject/orgs","repos_url":"https://api.github.com/users/vistadataproject/repos","events_url":"https://api.github.com/users/vistadataproject/events{/privacy}","received_events_url":"https://api.github.com/users/vistadataproject/received_events","type":"Organization","site_admin":false},"repo":{"id":105083284,"name":"VICSServer","full_name":"vistadataproject/VICSServer","owner":{"login":"vistadataproject","id":15674962,"avatar_url":"https://avatars3.githubusercontent.com/u/15674962?v=4","gravatar_id":"","url":"https://api.github.com/users/vistadataproject","html_url":"https://github.com/vistadataproject","followers_url":"https://api.github.com/users/vistadataproject/followers","following_url":"https://api.github.com/users/vistadataproject/following{/other_user}","gists_url":"https://api.github.com/users/vistadataproject/gists{/gist_id}","starred_url":"https://api.github.com/users/vistadataproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vistadataproject/subscriptions","organizations_url":"https://api.github.com/users/vistadataproject/orgs","repos_url":"https://api.github.com/users/vistadataproject/repos","events_url":"https://api.github.com/users/vistadataproject/events{/privacy}","received_events_url":"https://api.github.com/users/vistadataproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vistadataproject/VICSServer","description":"VISTA Adaptive Maintenance - Veteran Care Services","fork":false,"url":"https://api.github.com/repos/vistadataproject/VICSServer","forks_url":"https://api.github.com/repos/vistadataproject/VICSServer/forks","keys_url":"https://api.github.com/repos/vistadataproject/VICSServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vistadataproject/VICSServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vistadataproject/VICSServer/teams","hooks_url":"https://api.github.com/repos/vistadataproject/VICSServer/hooks","issue_events_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues/events{/number}","events_url":"https://api.github.com/repos/vistadataproject/VICSServer/events","assignees_url":"https://api.github.com/repos/vistadataproject/VICSServer/assignees{/user}","branches_url":"https://api.github.com/repos/vistadataproject/VICSServer/branches{/branch}","tags_url":"https://api.github.com/repos/vistadataproject/VICSServer/tags","blobs_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vistadataproject/VICSServer/statuses/{sha}","languages_url":"https://api.github.com/repos/vistadataproject/VICSServer/languages","stargazers_url":"https://api.github.com/repos/vistadataproject/VICSServer/stargazers","contributors_url":"https://api.github.com/repos/vistadataproject/VICSServer/contributors","subscribers_url":"https://api.github.com/repos/vistadataproject/VICSServer/subscribers","subscription_url":"https://api.github.com/repos/vistadataproject/VICSServer/subscription","commits_url":"https://api.github.com/repos/vistadataproject/VICSServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/vistadataproject/VICSServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/vistadataproject/VICSServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/vistadataproject/VICSServer/contents/{+path}","compare_url":"https://api.github.com/repos/vistadataproject/VICSServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vistadataproject/VICSServer/merges","archive_url":"https://api.github.com/repos/vistadataproject/VICSServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vistadataproject/VICSServer/downloads","issues_url":"https://api.github.com/repos/vistadataproject/VICSServer/issues{/number}","pulls_url":"https://api.github.com/repos/vistadataproject/VICSServer/pulls{/number}","milestones_url":"https://api.github.com/repos/vistadataproject/VICSServer/milestones{/number}","notifications_url":"https://api.github.com/repos/vistadataproject/VICSServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vistadataproject/VICSServer/labels{/name}","releases_url":"https://api.github.com/repos/vistadataproject/VICSServer/releases{/id}","deployments_url":"https://api.github.com/repos/vistadataproject/VICSServer/deployments","created_at":"2017-09-28T00:28:46Z","updated_at":"2017-11-15T19:36:13Z","pushed_at":"2017-11-17T07:11:05Z","git_url":"git://github.com/vistadataproject/VICSServer.git","ssh_url":"git@github.com:vistadataproject/VICSServer.git","clone_url":"https://github.com/vistadataproject/VICSServer.git","svn_url":"https://github.com/vistadataproject/VICSServer","homepage":"","size":1449,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93"},"html":{"href":"https://github.com/vistadataproject/VICSServer/pull/93"},"issue":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/issues/93"},"comments":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/vistadataproject/VICSServer/statuses/a98240af9d2a985f2571ca536dcd4b38d0b6105b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"creindle"}}