{"action":"created","issue":{"url":"https://api.github.com/repos/angular/quickstart/issues/445","repository_url":"https://api.github.com/repos/angular/quickstart","labels_url":"https://api.github.com/repos/angular/quickstart/issues/445/labels{/name}","comments_url":"https://api.github.com/repos/angular/quickstart/issues/445/comments","events_url":"https://api.github.com/repos/angular/quickstart/issues/445/events","html_url":"https://github.com/angular/quickstart/pull/445","id":224668748,"number":445,"title":"Fix systemjs-angular-loader.js for external templates (#444)","user":{"login":"feelingsofwhite","id":5688220,"avatar_url":"https://avatars2.githubusercontent.com/u/5688220?v=3","gravatar_id":"","url":"https://api.github.com/users/feelingsofwhite","html_url":"https://github.com/feelingsofwhite","followers_url":"https://api.github.com/users/feelingsofwhite/followers","following_url":"https://api.github.com/users/feelingsofwhite/following{/other_user}","gists_url":"https://api.github.com/users/feelingsofwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/feelingsofwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feelingsofwhite/subscriptions","organizations_url":"https://api.github.com/users/feelingsofwhite/orgs","repos_url":"https://api.github.com/users/feelingsofwhite/repos","events_url":"https://api.github.com/users/feelingsofwhite/events{/privacy}","received_events_url":"https://api.github.com/users/feelingsofwhite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-27T04:55:15Z","updated_at":"2017-04-27T04:55:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/quickstart/pulls/445","html_url":"https://github.com/angular/quickstart/pull/445","diff_url":"https://github.com/angular/quickstart/pull/445.diff","patch_url":"https://github.com/angular/quickstart/pull/445.patch"},"body":"these code changes are based on code found in the angular docs [component with external testing](https://angular.io/docs/ts/latest/guide/testing.html#!#component-with-external-template) downloadable example.\r\n\r\nAlthough the refactoring I described in #444 seems pretty simple enough to understand, In my fork  you can see branches demonstrate-bug-444 & demonstrate-fix-444 for more context of this bug and how this fix it.  \r\n\r\nI'm assuming because this code came from elsewhere in angular help/tutorial that it's okay.. but as a sidenote, the \"indexof('moduleId')\" seems rather poor because if you've got the word \"moduleId\" _anywhere_ (for example, in a line of sourcecode you just commented out) it, the module fails to load the template.  Not sure what the better solution would be, just my $0.02"},"comment":{"url":"https://api.github.com/repos/angular/quickstart/issues/comments/297611641","html_url":"https://github.com/angular/quickstart/pull/445#issuecomment-297611641","issue_url":"https://api.github.com/repos/angular/quickstart/issues/445","id":297611641,"user":{"login":"googlebot","id":5384588,"avatar_url":"https://avatars0.githubusercontent.com/u/5384588?v=3","gravatar_id":"","url":"https://api.github.com/users/googlebot","html_url":"https://github.com/googlebot","followers_url":"https://api.github.com/users/googlebot/followers","following_url":"https://api.github.com/users/googlebot/following{/other_user}","gists_url":"https://api.github.com/users/googlebot/gists{/gist_id}","starred_url":"https://api.github.com/users/googlebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlebot/subscriptions","organizations_url":"https://api.github.com/users/googlebot/orgs","repos_url":"https://api.github.com/users/googlebot/repos","events_url":"https://api.github.com/users/googlebot/events{/privacy}","received_events_url":"https://api.github.com/users/googlebot/received_events","type":"User","site_admin":false},"created_at":"2017-04-27T04:55:17Z","updated_at":"2017-04-27T04:55:17Z","body":"Thanks for your pull request.  It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\n:memo: **Please visit <https://cla.developers.google.com/> to sign.**\n\nOnce you've signed, please reply here (e.g. `I signed it!`) and we'll verify.  Thanks.\n\n---\n\n- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).\n- If you signed the CLA as a corporation, please let us know the company's name.\n\n<!-- need_sender_cla -->"}}
{"actor":{"display_login":"googlebot"}}