{"action":"created","issue":{"url":"https://api.github.com/repos/tuenti/python-repoman/issues/16","repository_url":"https://api.github.com/repos/tuenti/python-repoman","labels_url":"https://api.github.com/repos/tuenti/python-repoman/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/tuenti/python-repoman/issues/16/comments","events_url":"https://api.github.com/repos/tuenti/python-repoman/issues/16/events","html_url":"https://github.com/tuenti/python-repoman/pull/16","id":254890237,"number":16,"title":"Replacing libgit2 by git commands and fix tests","user":{"login":"jsoriano","id":15763,"avatar_url":"https://avatars2.githubusercontent.com/u/15763?v=4","gravatar_id":"","url":"https://api.github.com/users/jsoriano","html_url":"https://github.com/jsoriano","followers_url":"https://api.github.com/users/jsoriano/followers","following_url":"https://api.github.com/users/jsoriano/following{/other_user}","gists_url":"https://api.github.com/users/jsoriano/gists{/gist_id}","starred_url":"https://api.github.com/users/jsoriano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsoriano/subscriptions","organizations_url":"https://api.github.com/users/jsoriano/orgs","repos_url":"https://api.github.com/users/jsoriano/repos","events_url":"https://api.github.com/users/jsoriano/events{/privacy}","received_events_url":"https://api.github.com/users/jsoriano/received_events","type":"User","site_admin":false},"labels":[{"id":117530109,"url":"https://api.github.com/repos/tuenti/python-repoman/labels/help%20wanted","name":"help wanted","color":"159818","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-03T17:59:00Z","updated_at":"2017-09-11T14:57:04Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/tuenti/python-repoman/pulls/16","html_url":"https://github.com/tuenti/python-repoman/pull/16","diff_url":"https://github.com/tuenti/python-repoman/pull/16.diff","patch_url":"https://github.com/tuenti/python-repoman/pull/16.patch"},"body":"This is a WIP, but is quite advanced. On this I'm basically removing all uses of pygit2 and replacing them by invocations to git command. Even if it's not very nice to parse output of commands I think that at the end this will increase a lot the maintainability of the code. sh library helps a lot, and most of git commands have options to make them easy to be parsed. Also being able to reproduce things just by running a command we all use is easier than looking for a working installation of pygit2.\r\n\r\nI'm modifying the tests to avoid the use of pygit2 there too, but not so much so I can check that new implementation behaves the same as before. I have found some things I have doubts about, I have marked them with TODOs.\r\n\r\nPlease review these changes, specially on tests so I'm not changing expected behaviours.\r\n\r\nPending things:\r\n- [ ] Make all git-related tests pass\r\n- [ ] Even if not related, review tests that are failing for mercurial too, so when merging this branch we have all tests passing\r\n- [ ] Ensure that we have tests to cover recently fixed issues (like #15)\r\n- [ ] Update and fix testing docker scenarios"},"comment":{"url":"https://api.github.com/repos/tuenti/python-repoman/issues/comments/328556092","html_url":"https://github.com/tuenti/python-repoman/pull/16#issuecomment-328556092","issue_url":"https://api.github.com/repos/tuenti/python-repoman/issues/16","id":328556092,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T14:57:04Z","updated_at":"2017-09-11T14:57:04Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/13216705/badge)](https://coveralls.io/builds/13216705)\n\nCoverage increased (+1.4%) to 83.538% when pulling **12ec874f6e833b12a980a0c5de7e7be282357332 on jsoriano:remove-pygit2** into **c3e2242166058bd6089833621396efea2306b461 on tuenti:master**.\n"}}
{"actor":{"display_login":"coveralls"}}