{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44497","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44497/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44497/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44497/events","html_url":"https://github.com/kubernetes/kubernetes/pull/44497","id":221790676,"number":44497,"title":"Add some supported PV types","user":{"login":"NickrenREN","id":6104418,"avatar_url":"https://avatars0.githubusercontent.com/u/6104418?v=3","gravatar_id":"","url":"https://api.github.com/users/NickrenREN","html_url":"https://github.com/NickrenREN","followers_url":"https://api.github.com/users/NickrenREN/followers","following_url":"https://api.github.com/users/NickrenREN/following{/other_user}","gists_url":"https://api.github.com/users/NickrenREN/gists{/gist_id}","starred_url":"https://api.github.com/users/NickrenREN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickrenREN/subscriptions","organizations_url":"https://api.github.com/users/NickrenREN/orgs","repos_url":"https://api.github.com/users/NickrenREN/repos","events_url":"https://api.github.com/users/NickrenREN/events{/privacy}","received_events_url":"https://api.github.com/users/NickrenREN/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars3.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-04-14T11:12:35Z","updated_at":"2017-04-24T09:02:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44497","html_url":"https://github.com/kubernetes/kubernetes/pull/44497","diff_url":"https://github.com/kubernetes/kubernetes/pull/44497.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/44497.patch"},"body":"Flocker,ScaleIO,FC and PortworxVolume are also supported\r\n\r\nAccording to :\r\nhttps://kubernetes.io/docs/concepts/storage/persistent-volumes/#types-of-persistent-volumes\r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L309\r\n\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/296586249","html_url":"https://github.com/kubernetes/kubernetes/pull/44497#issuecomment-296586249","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44497","id":296586249,"user":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars1.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"created_at":"2017-04-24T09:02:52Z","updated_at":"2017-04-24T09:02:52Z","body":"Check in `checkMountOption` is correct as it is supposed to throw an error volume plugins that do not support mount options in PV, see https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/flocker/flocker.go#L115 \r\n\r\nYou can add MountOption support to these plugins and then this PR will be OK. Look at RBD for inspiration, https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/rbd/rbd.go#L152 and how  mountOptions is then used later in the code."}}
{"actor":{"display_login":"jsafrane"}}