{"action":"created","issue":{"url":"https://api.github.com/repos/m-lab/etl/issues/99","repository_url":"https://api.github.com/repos/m-lab/etl","labels_url":"https://api.github.com/repos/m-lab/etl/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/etl/issues/99/comments","events_url":"https://api.github.com/repos/m-lab/etl/issues/99/events","html_url":"https://github.com/m-lab/etl/pull/99","id":231173080,"number":99,"title":"Handle insert errors better.","user":{"login":"gfr10598","id":20915834,"avatar_url":"https://avatars0.githubusercontent.com/u/20915834?v=3","gravatar_id":"","url":"https://api.github.com/users/gfr10598","html_url":"https://github.com/gfr10598","followers_url":"https://api.github.com/users/gfr10598/followers","following_url":"https://api.github.com/users/gfr10598/following{/other_user}","gists_url":"https://api.github.com/users/gfr10598/gists{/gist_id}","starred_url":"https://api.github.com/users/gfr10598/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfr10598/subscriptions","organizations_url":"https://api.github.com/users/gfr10598/orgs","repos_url":"https://api.github.com/users/gfr10598/repos","events_url":"https://api.github.com/users/gfr10598/events{/privacy}","received_events_url":"https://api.github.com/users/gfr10598/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-24T21:13:07Z","updated_at":"2017-05-24T21:48:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/m-lab/etl/pulls/99","html_url":"https://github.com/m-lab/etl/pull/99","diff_url":"https://github.com/m-lab/etl/pull/99.diff","patch_url":"https://github.com/m-lab/etl/pull/99.patch"},"body":"Set SkipInvalidRows, and process error messages when some inserts fail.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/m-lab/etl/99)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/m-lab/etl/issues/comments/303861365","html_url":"https://github.com/m-lab/etl/pull/99#issuecomment-303861365","issue_url":"https://api.github.com/repos/m-lab/etl/issues/99","id":303861365,"user":{"login":"stephen-soltesz","id":1085316,"avatar_url":"https://avatars0.githubusercontent.com/u/1085316?v=3","gravatar_id":"","url":"https://api.github.com/users/stephen-soltesz","html_url":"https://github.com/stephen-soltesz","followers_url":"https://api.github.com/users/stephen-soltesz/followers","following_url":"https://api.github.com/users/stephen-soltesz/following{/other_user}","gists_url":"https://api.github.com/users/stephen-soltesz/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-soltesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-soltesz/subscriptions","organizations_url":"https://api.github.com/users/stephen-soltesz/orgs","repos_url":"https://api.github.com/users/stephen-soltesz/repos","events_url":"https://api.github.com/users/stephen-soltesz/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-soltesz/received_events","type":"User","site_admin":false},"created_at":"2017-05-24T21:48:34Z","updated_at":"2017-05-24T21:48:34Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> one clarifying question.\n\n---\n\nReview status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[metrics/metrics.go, line 110 at r1](https://reviewable.io:443/reviews/m-lab/etl/99#-KkwQ2P5qKAz9dnzKsy6:-KkwQ2P6KGDi9TSmBz7G:bcl78gf) ([raw file](https://github.com/m-lab/etl/blob/ac5ce5136344ab35671d0a857abf50863015ce00/metrics/metrics.go#L110)):*\n> ```Go\n> \t\t},\n> \t\t// Parser type, error description.\n> \t\t[]string{\"parser\", \"kind\"},\n> ```\n\nWhy \"parser\" rather than \"table\" as in TestCount? `TableBase` is given as the parameter in `HandleInsertErrors`.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/m-lab/etl/99#-:-KkwQeXW_cgIlgNZS2Dp:b-z0nrvz)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"stephen-soltesz"}}