{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments/122572359","pull_request_review_id":44703779,"id":122572359,"diff_hunk":"@@ -18,12 +18,10 @@\n public class RxSearchControllerDelegateProxy\n     : DelegateProxy\n     , DelegateProxyType\n-    , UISearchControllerDelegate {\n-\n-    /// For more information take a look at `DelegateProxyType`.\n-    public override class func createProxyForObject(_ object: AnyObject) -> AnyObject {\n-        let pickerView: UISearchController = castOrFatalError(object)\n-        return pickerView.createRxDelegateProxy()\n+, UISearchControllerDelegate {","path":"RxCocoa/iOS/Proxies/RxSearchControllerDelegateProxy.swift","position":10,"original_position":10,"commit_id":"1e19a15dfee80d33a1e25961eb8a6b21d567be34","original_commit_id":"1e19a15dfee80d33a1e25961eb8a6b21d567be34","user":{"login":"kzaher","id":1641148,"avatar_url":"https://avatars2.githubusercontent.com/u/1641148?v=3","gravatar_id":"","url":"https://api.github.com/users/kzaher","html_url":"https://github.com/kzaher","followers_url":"https://api.github.com/users/kzaher/followers","following_url":"https://api.github.com/users/kzaher/following{/other_user}","gists_url":"https://api.github.com/users/kzaher/gists{/gist_id}","starred_url":"https://api.github.com/users/kzaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzaher/subscriptions","organizations_url":"https://api.github.com/users/kzaher/orgs","repos_url":"https://api.github.com/users/kzaher/repos","events_url":"https://api.github.com/users/kzaher/events{/privacy}","received_events_url":"https://api.github.com/users/kzaher/received_events","type":"User","site_admin":false},"body":"Indentation.","created_at":"2017-06-17T16:44:12Z","updated_at":"2017-06-17T16:48:59Z","html_url":"https://github.com/ReactiveX/RxSwift/pull/1300#discussion_r122572359","pull_request_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments/122572359"},"html":{"href":"https://github.com/ReactiveX/RxSwift/pull/1300#discussion_r122572359"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300","id":126072956,"html_url":"https://github.com/ReactiveX/RxSwift/pull/1300","diff_url":"https://github.com/ReactiveX/RxSwift/pull/1300.diff","patch_url":"https://github.com/ReactiveX/RxSwift/pull/1300.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1300","number":1300,"state":"open","locked":false,"title":"Implement DelegateProxy factory for Swift 4.0","user":{"login":"tarunon","id":1830205,"avatar_url":"https://avatars0.githubusercontent.com/u/1830205?v=3","gravatar_id":"","url":"https://api.github.com/users/tarunon","html_url":"https://github.com/tarunon","followers_url":"https://api.github.com/users/tarunon/followers","following_url":"https://api.github.com/users/tarunon/following{/other_user}","gists_url":"https://api.github.com/users/tarunon/gists{/gist_id}","starred_url":"https://api.github.com/users/tarunon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarunon/subscriptions","organizations_url":"https://api.github.com/users/tarunon/orgs","repos_url":"https://api.github.com/users/tarunon/repos","events_url":"https://api.github.com/users/tarunon/events{/privacy}","received_events_url":"https://api.github.com/users/tarunon/received_events","type":"User","site_admin":false},"body":"It's based on discuss of #1287 \r\n\r\nNotes:\r\n- I made this more simply than discussions one.\r\n- Maybe we don't need `func createProxyForObject(_ :)` specific implementation anymore.\r\n- The performance is less than overriding way, but we cannot use overriding way anymore...\r\n- I think I will separate type around `factory` from `DelegateProxy` when I implement `DelegateProxy` with generics type. Because we cannot make static property using generics type.","created_at":"2017-06-16T16:48:58Z","updated_at":"2017-06-17T16:48:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75379501846c17a66432af05ed9d08bb206db6b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1300/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/1e19a15dfee80d33a1e25961eb8a6b21d567be34","head":{"label":"tarunon:fix/cannot_extend_delegate_proxy","ref":"fix/cannot_extend_delegate_proxy","sha":"1e19a15dfee80d33a1e25961eb8a6b21d567be34","user":{"login":"tarunon","id":1830205,"avatar_url":"https://avatars0.githubusercontent.com/u/1830205?v=3","gravatar_id":"","url":"https://api.github.com/users/tarunon","html_url":"https://github.com/tarunon","followers_url":"https://api.github.com/users/tarunon/followers","following_url":"https://api.github.com/users/tarunon/following{/other_user}","gists_url":"https://api.github.com/users/tarunon/gists{/gist_id}","starred_url":"https://api.github.com/users/tarunon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarunon/subscriptions","organizations_url":"https://api.github.com/users/tarunon/orgs","repos_url":"https://api.github.com/users/tarunon/repos","events_url":"https://api.github.com/users/tarunon/events{/privacy}","received_events_url":"https://api.github.com/users/tarunon/received_events","type":"User","site_admin":false},"repo":{"id":48079444,"name":"RxSwift","full_name":"tarunon/RxSwift","owner":{"login":"tarunon","id":1830205,"avatar_url":"https://avatars0.githubusercontent.com/u/1830205?v=3","gravatar_id":"","url":"https://api.github.com/users/tarunon","html_url":"https://github.com/tarunon","followers_url":"https://api.github.com/users/tarunon/followers","following_url":"https://api.github.com/users/tarunon/following{/other_user}","gists_url":"https://api.github.com/users/tarunon/gists{/gist_id}","starred_url":"https://api.github.com/users/tarunon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarunon/subscriptions","organizations_url":"https://api.github.com/users/tarunon/orgs","repos_url":"https://api.github.com/users/tarunon/repos","events_url":"https://api.github.com/users/tarunon/events{/privacy}","received_events_url":"https://api.github.com/users/tarunon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tarunon/RxSwift","description":"Reactive Programming in Swift","fork":true,"url":"https://api.github.com/repos/tarunon/RxSwift","forks_url":"https://api.github.com/repos/tarunon/RxSwift/forks","keys_url":"https://api.github.com/repos/tarunon/RxSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarunon/RxSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarunon/RxSwift/teams","hooks_url":"https://api.github.com/repos/tarunon/RxSwift/hooks","issue_events_url":"https://api.github.com/repos/tarunon/RxSwift/issues/events{/number}","events_url":"https://api.github.com/repos/tarunon/RxSwift/events","assignees_url":"https://api.github.com/repos/tarunon/RxSwift/assignees{/user}","branches_url":"https://api.github.com/repos/tarunon/RxSwift/branches{/branch}","tags_url":"https://api.github.com/repos/tarunon/RxSwift/tags","blobs_url":"https://api.github.com/repos/tarunon/RxSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarunon/RxSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarunon/RxSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarunon/RxSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarunon/RxSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/tarunon/RxSwift/languages","stargazers_url":"https://api.github.com/repos/tarunon/RxSwift/stargazers","contributors_url":"https://api.github.com/repos/tarunon/RxSwift/contributors","subscribers_url":"https://api.github.com/repos/tarunon/RxSwift/subscribers","subscription_url":"https://api.github.com/repos/tarunon/RxSwift/subscription","commits_url":"https://api.github.com/repos/tarunon/RxSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarunon/RxSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarunon/RxSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarunon/RxSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarunon/RxSwift/contents/{+path}","compare_url":"https://api.github.com/repos/tarunon/RxSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarunon/RxSwift/merges","archive_url":"https://api.github.com/repos/tarunon/RxSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarunon/RxSwift/downloads","issues_url":"https://api.github.com/repos/tarunon/RxSwift/issues{/number}","pulls_url":"https://api.github.com/repos/tarunon/RxSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/tarunon/RxSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/tarunon/RxSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarunon/RxSwift/labels{/name}","releases_url":"https://api.github.com/repos/tarunon/RxSwift/releases{/id}","deployments_url":"https://api.github.com/repos/tarunon/RxSwift/deployments","created_at":"2015-12-16T01:30:39Z","updated_at":"2017-04-25T09:34:02Z","pushed_at":"2017-06-17T15:51:58Z","git_url":"git://github.com/tarunon/RxSwift.git","ssh_url":"git@github.com:tarunon/RxSwift.git","clone_url":"https://github.com/tarunon/RxSwift.git","svn_url":"https://github.com/tarunon/RxSwift","homepage":"","size":9822,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:swift4.0","ref":"swift4.0","sha":"16eabd5ea4dd6ff18224e865c668a9ad0b040f05","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars2.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":33569135,"name":"RxSwift","full_name":"ReactiveX/RxSwift","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars2.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxSwift","description":"Reactive Programming in Swift","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxSwift","forks_url":"https://api.github.com/repos/ReactiveX/RxSwift/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxSwift/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxSwift/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxSwift/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxSwift/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxSwift/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxSwift/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxSwift/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxSwift/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxSwift/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxSwift/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxSwift/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxSwift/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxSwift/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxSwift/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxSwift/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxSwift/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/RxSwift/deployments","created_at":"2015-04-07T21:25:17Z","updated_at":"2017-06-17T10:01:35Z","pushed_at":"2017-06-17T15:52:00Z","git_url":"git://github.com/ReactiveX/RxSwift.git","ssh_url":"git@github.com:ReactiveX/RxSwift.git","clone_url":"https://github.com/ReactiveX/RxSwift.git","svn_url":"https://github.com/ReactiveX/RxSwift","homepage":"","size":9773,"stargazers_count":9605,"watchers_count":9605,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1454,"mirror_url":null,"open_issues_count":17,"forks":1454,"open_issues":17,"watchers":9605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300"},"html":{"href":"https://github.com/ReactiveX/RxSwift/pull/1300"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1300"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1300/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1300/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxSwift/statuses/1e19a15dfee80d33a1e25961eb8a6b21d567be34"}}}}
{"actor":{"display_login":"kzaher"}}