{"action":"created","comment":{"url":"https://api.github.com/repos/roc-project/roc/pulls/comments/145319169","pull_request_review_id":70100333,"id":145319169,"diff_hunk":"@@ -35,7 +36,8 @@ ReceiverSession::ReceiverSession(const SessionConfig& config,\n \n     if (config.resampling) {\n         resampler_updater_.reset(new (allocator_) audio::ResamplerUpdater(\n-                                     config.fe_update_interval, config.latency),\n+                                     config.fe_update_interval, config.latency,\n+                                     (float)format->sample_rate / out_sample_rate),","path":"src/modules/roc_pipeline/receiver_session.cpp","position":14,"original_position":14,"commit_id":"93b3792101a66f4d2b909646fbb32ec72fac9eec","original_commit_id":"93b3792101a66f4d2b909646fbb32ec72fac9eec","user":{"login":"dshil","id":8618625,"avatar_url":"https://avatars2.githubusercontent.com/u/8618625?v=4","gravatar_id":"","url":"https://api.github.com/users/dshil","html_url":"https://github.com/dshil","followers_url":"https://api.github.com/users/dshil/followers","following_url":"https://api.github.com/users/dshil/following{/other_user}","gists_url":"https://api.github.com/users/dshil/gists{/gist_id}","starred_url":"https://api.github.com/users/dshil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshil/subscriptions","organizations_url":"https://api.github.com/users/dshil/orgs","repos_url":"https://api.github.com/users/dshil/repos","events_url":"https://api.github.com/users/dshil/events{/privacy}","received_events_url":"https://api.github.com/users/dshil/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2017-10-18T05:31:37Z","updated_at":"2017-10-18T05:31:38Z","html_url":"https://github.com/roc-project/roc/pull/113#discussion_r145319169","pull_request_url":"https://api.github.com/repos/roc-project/roc/pulls/113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/roc-project/roc/pulls/comments/145319169"},"html":{"href":"https://github.com/roc-project/roc/pull/113#discussion_r145319169"},"pull_request":{"href":"https://api.github.com/repos/roc-project/roc/pulls/113"}},"in_reply_to_id":144769349},"pull_request":{"url":"https://api.github.com/repos/roc-project/roc/pulls/113","id":146650973,"html_url":"https://github.com/roc-project/roc/pull/113","diff_url":"https://github.com/roc-project/roc/pull/113.diff","patch_url":"https://github.com/roc-project/roc/pull/113.patch","issue_url":"https://api.github.com/repos/roc-project/roc/issues/113","number":113,"state":"open","locked":false,"title":"roc_audio: adjust resampler coef ","user":{"login":"dshil","id":8618625,"avatar_url":"https://avatars2.githubusercontent.com/u/8618625?v=4","gravatar_id":"","url":"https://api.github.com/users/dshil","html_url":"https://github.com/dshil","followers_url":"https://api.github.com/users/dshil/followers","following_url":"https://api.github.com/users/dshil/following{/other_user}","gists_url":"https://api.github.com/users/dshil/gists{/gist_id}","starred_url":"https://api.github.com/users/dshil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshil/subscriptions","organizations_url":"https://api.github.com/users/dshil/orgs","repos_url":"https://api.github.com/users/dshil/repos","events_url":"https://api.github.com/users/dshil/events{/privacy}","received_events_url":"https://api.github.com/users/dshil/received_events","type":"User","site_admin":false},"body":"#85","created_at":"2017-10-15T14:01:26Z","updated_at":"2017-10-18T05:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9d5f9af995d2bb306b1af0f5fa276f7488834a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/roc-project/roc/pulls/113/commits","review_comments_url":"https://api.github.com/repos/roc-project/roc/pulls/113/comments","review_comment_url":"https://api.github.com/repos/roc-project/roc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roc-project/roc/issues/113/comments","statuses_url":"https://api.github.com/repos/roc-project/roc/statuses/93b3792101a66f4d2b909646fbb32ec72fac9eec","head":{"label":"dshil:dshil/85-sample-rate","ref":"dshil/85-sample-rate","sha":"93b3792101a66f4d2b909646fbb32ec72fac9eec","user":{"login":"dshil","id":8618625,"avatar_url":"https://avatars2.githubusercontent.com/u/8618625?v=4","gravatar_id":"","url":"https://api.github.com/users/dshil","html_url":"https://github.com/dshil","followers_url":"https://api.github.com/users/dshil/followers","following_url":"https://api.github.com/users/dshil/following{/other_user}","gists_url":"https://api.github.com/users/dshil/gists{/gist_id}","starred_url":"https://api.github.com/users/dshil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshil/subscriptions","organizations_url":"https://api.github.com/users/dshil/orgs","repos_url":"https://api.github.com/users/dshil/repos","events_url":"https://api.github.com/users/dshil/events{/privacy}","received_events_url":"https://api.github.com/users/dshil/received_events","type":"User","site_admin":false},"repo":{"id":96970096,"name":"roc","full_name":"dshil/roc","owner":{"login":"dshil","id":8618625,"avatar_url":"https://avatars2.githubusercontent.com/u/8618625?v=4","gravatar_id":"","url":"https://api.github.com/users/dshil","html_url":"https://github.com/dshil","followers_url":"https://api.github.com/users/dshil/followers","following_url":"https://api.github.com/users/dshil/following{/other_user}","gists_url":"https://api.github.com/users/dshil/gists{/gist_id}","starred_url":"https://api.github.com/users/dshil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshil/subscriptions","organizations_url":"https://api.github.com/users/dshil/orgs","repos_url":"https://api.github.com/users/dshil/repos","events_url":"https://api.github.com/users/dshil/events{/privacy}","received_events_url":"https://api.github.com/users/dshil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dshil/roc","description":"Real-time audio streaming over network.","fork":true,"url":"https://api.github.com/repos/dshil/roc","forks_url":"https://api.github.com/repos/dshil/roc/forks","keys_url":"https://api.github.com/repos/dshil/roc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dshil/roc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dshil/roc/teams","hooks_url":"https://api.github.com/repos/dshil/roc/hooks","issue_events_url":"https://api.github.com/repos/dshil/roc/issues/events{/number}","events_url":"https://api.github.com/repos/dshil/roc/events","assignees_url":"https://api.github.com/repos/dshil/roc/assignees{/user}","branches_url":"https://api.github.com/repos/dshil/roc/branches{/branch}","tags_url":"https://api.github.com/repos/dshil/roc/tags","blobs_url":"https://api.github.com/repos/dshil/roc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dshil/roc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dshil/roc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dshil/roc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dshil/roc/statuses/{sha}","languages_url":"https://api.github.com/repos/dshil/roc/languages","stargazers_url":"https://api.github.com/repos/dshil/roc/stargazers","contributors_url":"https://api.github.com/repos/dshil/roc/contributors","subscribers_url":"https://api.github.com/repos/dshil/roc/subscribers","subscription_url":"https://api.github.com/repos/dshil/roc/subscription","commits_url":"https://api.github.com/repos/dshil/roc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dshil/roc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dshil/roc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dshil/roc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dshil/roc/contents/{+path}","compare_url":"https://api.github.com/repos/dshil/roc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dshil/roc/merges","archive_url":"https://api.github.com/repos/dshil/roc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dshil/roc/downloads","issues_url":"https://api.github.com/repos/dshil/roc/issues{/number}","pulls_url":"https://api.github.com/repos/dshil/roc/pulls{/number}","milestones_url":"https://api.github.com/repos/dshil/roc/milestones{/number}","notifications_url":"https://api.github.com/repos/dshil/roc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dshil/roc/labels{/name}","releases_url":"https://api.github.com/repos/dshil/roc/releases{/id}","deployments_url":"https://api.github.com/repos/dshil/roc/deployments","created_at":"2017-07-12T05:51:47Z","updated_at":"2017-07-12T05:51:49Z","pushed_at":"2017-10-16T06:33:48Z","git_url":"git://github.com/dshil/roc.git","ssh_url":"git@github.com:dshil/roc.git","clone_url":"https://github.com/dshil/roc.git","svn_url":"https://github.com/dshil/roc","homepage":"","size":1807,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roc-project:develop","ref":"develop","sha":"7a440febf3c3a41035a1cf34c96ca4a431dea992","user":{"login":"roc-project","id":16302098,"avatar_url":"https://avatars3.githubusercontent.com/u/16302098?v=4","gravatar_id":"","url":"https://api.github.com/users/roc-project","html_url":"https://github.com/roc-project","followers_url":"https://api.github.com/users/roc-project/followers","following_url":"https://api.github.com/users/roc-project/following{/other_user}","gists_url":"https://api.github.com/users/roc-project/gists{/gist_id}","starred_url":"https://api.github.com/users/roc-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roc-project/subscriptions","organizations_url":"https://api.github.com/users/roc-project/orgs","repos_url":"https://api.github.com/users/roc-project/repos","events_url":"https://api.github.com/users/roc-project/events{/privacy}","received_events_url":"https://api.github.com/users/roc-project/received_events","type":"Organization","site_admin":false},"repo":{"id":48029439,"name":"roc","full_name":"roc-project/roc","owner":{"login":"roc-project","id":16302098,"avatar_url":"https://avatars3.githubusercontent.com/u/16302098?v=4","gravatar_id":"","url":"https://api.github.com/users/roc-project","html_url":"https://github.com/roc-project","followers_url":"https://api.github.com/users/roc-project/followers","following_url":"https://api.github.com/users/roc-project/following{/other_user}","gists_url":"https://api.github.com/users/roc-project/gists{/gist_id}","starred_url":"https://api.github.com/users/roc-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roc-project/subscriptions","organizations_url":"https://api.github.com/users/roc-project/orgs","repos_url":"https://api.github.com/users/roc-project/repos","events_url":"https://api.github.com/users/roc-project/events{/privacy}","received_events_url":"https://api.github.com/users/roc-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roc-project/roc","description":"Real-time audio streaming over network.","fork":false,"url":"https://api.github.com/repos/roc-project/roc","forks_url":"https://api.github.com/repos/roc-project/roc/forks","keys_url":"https://api.github.com/repos/roc-project/roc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roc-project/roc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roc-project/roc/teams","hooks_url":"https://api.github.com/repos/roc-project/roc/hooks","issue_events_url":"https://api.github.com/repos/roc-project/roc/issues/events{/number}","events_url":"https://api.github.com/repos/roc-project/roc/events","assignees_url":"https://api.github.com/repos/roc-project/roc/assignees{/user}","branches_url":"https://api.github.com/repos/roc-project/roc/branches{/branch}","tags_url":"https://api.github.com/repos/roc-project/roc/tags","blobs_url":"https://api.github.com/repos/roc-project/roc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roc-project/roc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roc-project/roc/git/refs{/sha}","trees_url":"https://api.github.com/repos/roc-project/roc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roc-project/roc/statuses/{sha}","languages_url":"https://api.github.com/repos/roc-project/roc/languages","stargazers_url":"https://api.github.com/repos/roc-project/roc/stargazers","contributors_url":"https://api.github.com/repos/roc-project/roc/contributors","subscribers_url":"https://api.github.com/repos/roc-project/roc/subscribers","subscription_url":"https://api.github.com/repos/roc-project/roc/subscription","commits_url":"https://api.github.com/repos/roc-project/roc/commits{/sha}","git_commits_url":"https://api.github.com/repos/roc-project/roc/git/commits{/sha}","comments_url":"https://api.github.com/repos/roc-project/roc/comments{/number}","issue_comment_url":"https://api.github.com/repos/roc-project/roc/issues/comments{/number}","contents_url":"https://api.github.com/repos/roc-project/roc/contents/{+path}","compare_url":"https://api.github.com/repos/roc-project/roc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roc-project/roc/merges","archive_url":"https://api.github.com/repos/roc-project/roc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roc-project/roc/downloads","issues_url":"https://api.github.com/repos/roc-project/roc/issues{/number}","pulls_url":"https://api.github.com/repos/roc-project/roc/pulls{/number}","milestones_url":"https://api.github.com/repos/roc-project/roc/milestones{/number}","notifications_url":"https://api.github.com/repos/roc-project/roc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roc-project/roc/labels{/name}","releases_url":"https://api.github.com/repos/roc-project/roc/releases{/id}","deployments_url":"https://api.github.com/repos/roc-project/roc/deployments","created_at":"2015-12-15T08:23:27Z","updated_at":"2017-10-18T04:07:02Z","pushed_at":"2017-10-16T06:33:49Z","git_url":"git://github.com/roc-project/roc.git","ssh_url":"git@github.com:roc-project/roc.git","clone_url":"https://github.com/roc-project/roc.git","svn_url":"https://github.com/roc-project/roc","homepage":"","size":1844,"stargazers_count":72,"watchers_count":72,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":61,"forks":4,"open_issues":61,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roc-project/roc/pulls/113"},"html":{"href":"https://github.com/roc-project/roc/pull/113"},"issue":{"href":"https://api.github.com/repos/roc-project/roc/issues/113"},"comments":{"href":"https://api.github.com/repos/roc-project/roc/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/roc-project/roc/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/roc-project/roc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roc-project/roc/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/roc-project/roc/statuses/93b3792101a66f4d2b909646fbb32ec72fac9eec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dshil"}}