{"action":"opened","number":2054,"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2054","id":132903900,"html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/2054","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/2054.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/2054.patch","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2054","number":2054,"state":"open","locked":false,"title":"dht_read11 DHT12 Fix","user":{"login":"AdrianDroid","id":6862208,"avatar_url":"https://avatars3.githubusercontent.com/u/6862208?v=4","gravatar_id":"","url":"https://api.github.com/users/AdrianDroid","html_url":"https://github.com/AdrianDroid","followers_url":"https://api.github.com/users/AdrianDroid/followers","following_url":"https://api.github.com/users/AdrianDroid/following{/other_user}","gists_url":"https://api.github.com/users/AdrianDroid/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianDroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianDroid/subscriptions","organizations_url":"https://api.github.com/users/AdrianDroid/orgs","repos_url":"https://api.github.com/users/AdrianDroid/repos","events_url":"https://api.github.com/users/AdrianDroid/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianDroid/received_events","type":"User","site_admin":false},"body":"Fixes #2050.\r\n\r\nMake sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.\r\n\r\n- [x ] This PR is for the `dev` branch rather than for `master`.\r\n- [x ] This PR is compliant with the [other contributing guidelines](https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md) as well (if not, please describe why).\r\n- [x ] I have thoroughly tested my contribution.\r\n- [x ] The code changes are reflected in the documentation at `docs/en/*`.\r\n\r\n\\<Description of and rationale behind this PR\\>\r\nDue to shorthand implementation of DHT11,  DHT12 will fail to DHTxx logic.\r\nHowever, DHT12 use the same data representations, thru DHT12 will have the wrong reading when using dht_read().\r\nand shorthand implementation of DHT11 of its checksum will make dht_read11() fail in DHT 12.\r\nthis fix allows DHT12 user to call dht_read11() to have the correct reading.\r\n","created_at":"2017-07-28T06:38:35Z","updated_at":"2017-07-28T06:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2054/commits","review_comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2054/comments","review_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2054/comments","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/a00c3a755a944df18feb0017fc129b2b1b09043c","head":{"label":"AdrianDroid:dev","ref":"dev","sha":"a00c3a755a944df18feb0017fc129b2b1b09043c","user":{"login":"AdrianDroid","id":6862208,"avatar_url":"https://avatars3.githubusercontent.com/u/6862208?v=4","gravatar_id":"","url":"https://api.github.com/users/AdrianDroid","html_url":"https://github.com/AdrianDroid","followers_url":"https://api.github.com/users/AdrianDroid/followers","following_url":"https://api.github.com/users/AdrianDroid/following{/other_user}","gists_url":"https://api.github.com/users/AdrianDroid/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianDroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianDroid/subscriptions","organizations_url":"https://api.github.com/users/AdrianDroid/orgs","repos_url":"https://api.github.com/users/AdrianDroid/repos","events_url":"https://api.github.com/users/AdrianDroid/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianDroid/received_events","type":"User","site_admin":false},"repo":{"id":98616197,"name":"nodemcu-firmware","full_name":"AdrianDroid/nodemcu-firmware","owner":{"login":"AdrianDroid","id":6862208,"avatar_url":"https://avatars3.githubusercontent.com/u/6862208?v=4","gravatar_id":"","url":"https://api.github.com/users/AdrianDroid","html_url":"https://github.com/AdrianDroid","followers_url":"https://api.github.com/users/AdrianDroid/followers","following_url":"https://api.github.com/users/AdrianDroid/following{/other_user}","gists_url":"https://api.github.com/users/AdrianDroid/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianDroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianDroid/subscriptions","organizations_url":"https://api.github.com/users/AdrianDroid/orgs","repos_url":"https://api.github.com/users/AdrianDroid/repos","events_url":"https://api.github.com/users/AdrianDroid/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianDroid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdrianDroid/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":true,"url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware","forks_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/AdrianDroid/nodemcu-firmware/deployments","created_at":"2017-07-28T06:27:01Z","updated_at":"2017-07-28T06:27:07Z","pushed_at":"2017-07-28T06:33:32Z","git_url":"git://github.com/AdrianDroid/nodemcu-firmware.git","ssh_url":"git@github.com:AdrianDroid/nodemcu-firmware.git","clone_url":"https://github.com/AdrianDroid/nodemcu-firmware.git","svn_url":"https://github.com/AdrianDroid/nodemcu-firmware","homepage":"http://nodemcu.com","size":102083,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodemcu:dev","ref":"dev","sha":"d93465cd865dc21efac277e920cf7169d88273d7","user":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars0.githubusercontent.com/u/9865736?v=4","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"repo":{"id":26917568,"name":"nodemcu-firmware","full_name":"nodemcu/nodemcu-firmware","owner":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars0.githubusercontent.com/u/9865736?v=4","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nodemcu/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":false,"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","forks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/deployments","created_at":"2014-11-20T15:06:45Z","updated_at":"2017-07-28T02:16:54Z","pushed_at":"2017-07-27T21:30:30Z","git_url":"git://github.com/nodemcu/nodemcu-firmware.git","ssh_url":"git@github.com:nodemcu/nodemcu-firmware.git","clone_url":"https://github.com/nodemcu/nodemcu-firmware.git","svn_url":"https://github.com/nodemcu/nodemcu-firmware","homepage":"http://nodemcu.com","size":102083,"stargazers_count":3584,"watchers_count":3584,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1666,"mirror_url":null,"open_issues_count":165,"forks":1666,"open_issues":165,"watchers":3584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2054"},"html":{"href":"https://github.com/nodemcu/nodemcu-firmware/pull/2054"},"issue":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2054"},"comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2054/comments"},"review_comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2054/comments"},"review_comment":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2054/commits"},"statuses":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/a00c3a755a944df18feb0017fc129b2b1b09043c"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":27,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"AdrianDroid"}}