{"action":"opened","number":260,"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/260","id":153859030,"html_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/260","diff_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/260.diff","patch_url":"https://github.com/neo4j/neo4j-dotnet-driver/pull/260.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/260","number":260,"state":"open","locked":false,"title":"Do not purge inUse connections","user":{"login":"zhenlineo","id":4190164,"avatar_url":"https://avatars1.githubusercontent.com/u/4190164?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenlineo","html_url":"https://github.com/zhenlineo","followers_url":"https://api.github.com/users/zhenlineo/followers","following_url":"https://api.github.com/users/zhenlineo/following{/other_user}","gists_url":"https://api.github.com/users/zhenlineo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenlineo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenlineo/subscriptions","organizations_url":"https://api.github.com/users/zhenlineo/orgs","repos_url":"https://api.github.com/users/zhenlineo/repos","events_url":"https://api.github.com/users/zhenlineo/events{/privacy}","received_events_url":"https://api.github.com/users/zhenlineo/received_events","type":"User","site_admin":false},"body":"This PR consists of two parts:\r\n1) When updating routing table, the pool of the servers that are removed from routing table should not be closed but be deactivated.\r\n2) When a connection error happens towards a server, the pool of the server should not be purged but deactivated. \r\n\r\nTODOs (Not in this PR but comes later):\r\nWhile working on 2) we found that the `DelegatedConnection.OnError` should also provides a Async impl so that the connections could be closed synchronically. This will be left to some future work. ","created_at":"2017-11-21T11:03:12Z","updated_at":"2017-11-21T11:03:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/260/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/260/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/260/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/statuses/afa64938a50a41e810d9517a234b81cdae70559f","head":{"label":"zhenlineo:1.5-purge-improve","ref":"1.5-purge-improve","sha":"afa64938a50a41e810d9517a234b81cdae70559f","user":{"login":"zhenlineo","id":4190164,"avatar_url":"https://avatars1.githubusercontent.com/u/4190164?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenlineo","html_url":"https://github.com/zhenlineo","followers_url":"https://api.github.com/users/zhenlineo/followers","following_url":"https://api.github.com/users/zhenlineo/following{/other_user}","gists_url":"https://api.github.com/users/zhenlineo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenlineo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenlineo/subscriptions","organizations_url":"https://api.github.com/users/zhenlineo/orgs","repos_url":"https://api.github.com/users/zhenlineo/repos","events_url":"https://api.github.com/users/zhenlineo/events{/privacy}","received_events_url":"https://api.github.com/users/zhenlineo/received_events","type":"User","site_admin":false},"repo":{"id":55067810,"name":"neo4j-dotnet-driver","full_name":"zhenlineo/neo4j-dotnet-driver","owner":{"login":"zhenlineo","id":4190164,"avatar_url":"https://avatars1.githubusercontent.com/u/4190164?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenlineo","html_url":"https://github.com/zhenlineo","followers_url":"https://api.github.com/users/zhenlineo/followers","following_url":"https://api.github.com/users/zhenlineo/following{/other_user}","gists_url":"https://api.github.com/users/zhenlineo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenlineo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenlineo/subscriptions","organizations_url":"https://api.github.com/users/zhenlineo/orgs","repos_url":"https://api.github.com/users/zhenlineo/repos","events_url":"https://api.github.com/users/zhenlineo/events{/privacy}","received_events_url":"https://api.github.com/users/zhenlineo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhenlineo/neo4j-dotnet-driver","description":".Net driver for Neo4j (Bolt)","fork":true,"url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver","forks_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/forks","keys_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/teams","hooks_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/hooks","issue_events_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/issues/events{/number}","events_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/events","assignees_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/assignees{/user}","branches_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/branches{/branch}","tags_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/tags","blobs_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/languages","stargazers_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/stargazers","contributors_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/contributors","subscribers_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/subscribers","subscription_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/subscription","commits_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/contents/{+path}","compare_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/merges","archive_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/downloads","issues_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/issues{/number}","pulls_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/labels{/name}","releases_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/releases{/id}","deployments_url":"https://api.github.com/repos/zhenlineo/neo4j-dotnet-driver/deployments","created_at":"2016-03-30T14:00:40Z","updated_at":"2016-03-30T14:00:41Z","pushed_at":"2017-11-21T11:02:56Z","git_url":"git://github.com/zhenlineo/neo4j-dotnet-driver.git","ssh_url":"git@github.com:zhenlineo/neo4j-dotnet-driver.git","clone_url":"https://github.com/zhenlineo/neo4j-dotnet-driver.git","svn_url":"https://github.com/zhenlineo/neo4j-dotnet-driver","homepage":null,"size":5638,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.1"}},"base":{"label":"neo4j:1.5","ref":"1.5","sha":"8772b73c793ccee00fdf5fbe800128da41240a13","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":49424996,"name":"neo4j-dotnet-driver","full_name":"neo4j/neo4j-dotnet-driver","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j-dotnet-driver","description":"Neo4j Bolt driver for .NET","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver","forks_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/deployments","created_at":"2016-01-11T12:28:56Z","updated_at":"2017-11-09T00:19:51Z","pushed_at":"2017-11-20T09:41:04Z","git_url":"git://github.com/neo4j/neo4j-dotnet-driver.git","ssh_url":"git@github.com:neo4j/neo4j-dotnet-driver.git","clone_url":"https://github.com/neo4j/neo4j-dotnet-driver.git","svn_url":"https://github.com/neo4j/neo4j-dotnet-driver","homepage":"","size":5609,"stargazers_count":49,"watchers_count":49,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":28,"open_issues":6,"watchers":49,"default_branch":"1.5"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/260"},"html":{"href":"https://github.com/neo4j/neo4j-dotnet-driver/pull/260"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/260"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j-dotnet-driver/statuses/afa64938a50a41e810d9517a234b81cdae70559f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":940,"deletions":265,"changed_files":15}}
{"actor":{"display_login":"zhenlineo"}}