{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/2456","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/2456/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/2456/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/2456/events","html_url":"https://github.com/apache/zeppelin/pull/2456","id":239726375,"number":2456,"title":"[ZEPPELIN-2714] Soft-code Spark UI button visualization","user":{"login":"necosta","id":26248959,"avatar_url":"https://avatars2.githubusercontent.com/u/26248959?v=3","gravatar_id":"","url":"https://api.github.com/users/necosta","html_url":"https://github.com/necosta","followers_url":"https://api.github.com/users/necosta/followers","following_url":"https://api.github.com/users/necosta/following{/other_user}","gists_url":"https://api.github.com/users/necosta/gists{/gist_id}","starred_url":"https://api.github.com/users/necosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/necosta/subscriptions","organizations_url":"https://api.github.com/users/necosta/orgs","repos_url":"https://api.github.com/users/necosta/repos","events_url":"https://api.github.com/users/necosta/events{/privacy}","received_events_url":"https://api.github.com/users/necosta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-06-30T09:32:55Z","updated_at":"2017-07-05T03:00:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/2456","html_url":"https://github.com/apache/zeppelin/pull/2456","diff_url":"https://github.com/apache/zeppelin/pull/2456.diff","patch_url":"https://github.com/apache/zeppelin/pull/2456.patch"},"body":"### What is this PR for?\r\nWhen \"spark.ui.enabled\" property is set to \"false\" we should not show the Spark UI button.\r\nWe keep the same behaviour when this property does not exist or when it exists and it's set to true.\r\n\r\n### What type of PR is it?\r\n[ Improvement]\r\n\r\n### What is the Jira issue?\r\n* https://issues.apache.org/jira/browse/ZEPPELIN-2714\r\n\r\n### How should this be tested?\r\n1. Open Zeppelin, go to Interpreter > Spark\r\n1. Click spark ui > msg: \"No spark application running\"\r\n1. Go to a paragraph, run \"sc.parallelize(1 to 100).count()\", check \"SPARK JOB\" button\r\n1. Go to Interpreter > Spark > Set \"spark.ui.enabled\" to \"false\"\r\n1. Rerun paragraph > \"SPARK JOB\" button not visible\r\n1. Go to Interpreter > Spark > \"spark ui\" button not visible\r\nAlso, test with \"spark.ui.enabled\"=\"true\" and other workflow combinations\r\n\r\n### Questions:\r\n* Does the licenses files need update? N\r\n* Is there breaking changes for older versions? N\r\n* Does this needs documentation? N\r\n"},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/312985172","html_url":"https://github.com/apache/zeppelin/pull/2456#issuecomment-312985172","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/2456","id":312985172,"user":{"login":"Leemoonsoo","id":1540981,"avatar_url":"https://avatars2.githubusercontent.com/u/1540981?v=3","gravatar_id":"","url":"https://api.github.com/users/Leemoonsoo","html_url":"https://github.com/Leemoonsoo","followers_url":"https://api.github.com/users/Leemoonsoo/followers","following_url":"https://api.github.com/users/Leemoonsoo/following{/other_user}","gists_url":"https://api.github.com/users/Leemoonsoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Leemoonsoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leemoonsoo/subscriptions","organizations_url":"https://api.github.com/users/Leemoonsoo/orgs","repos_url":"https://api.github.com/users/Leemoonsoo/repos","events_url":"https://api.github.com/users/Leemoonsoo/events{/privacy}","received_events_url":"https://api.github.com/users/Leemoonsoo/received_events","type":"User","site_admin":false},"created_at":"2017-07-05T03:00:03Z","updated_at":"2017-07-05T03:00:03Z","body":"LGTM!"}}
{"actor":{"display_login":"Leemoonsoo"}}