{"action":"created","comment":{"url":"https://api.github.com/repos/nobitlost/MessageManager/pulls/comments/130476995","pull_request_review_id":53356854,"id":130476995,"diff_hunk":"@@ -0,0 +1,75 @@\n+// MIT License\n+//\n+// Copyright 2017 Electric Imp\n+//\n+// SPDX-License-Identifier: MIT\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be\n+// included in all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO\n+// EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES\n+// OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n+// ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR\n+// OTHER DEALINGS IN THE SOFTWARE.\n+// \"Promise\" symbol is injected dependency from ImpUnit_Promise module,\n+// while class being tested can be accessed from global scope as \"::Promise\".\n+\n+@include __PATH__+\"/../Base.nut\"\n+\n+// ConnectionRealTestCase\n+// Tests for MessageManager constructor options (onPartnerConnected, onConnectedReply, connectionManager)\n+// Test connection with real ConnectionManager\n+class ConnectionRealTestCase extends ImpTestCase {\n+\n+    function setUp() {\n+        infoAboutSide();\n+    }\n+    \n+    function testConnection() {\n+        if (isAgentSide()) {","path":"tests/compatibility/ConnectionRealTestCase.nut","position":39,"original_position":39,"commit_id":"29bdf10cfa6d2444febaef7d2b885266776b0184","original_commit_id":"29bdf10cfa6d2444febaef7d2b885266776b0184","user":{"login":"snork-nbl","id":25421169,"avatar_url":"https://avatars3.githubusercontent.com/u/25421169?v=4","gravatar_id":"","url":"https://api.github.com/users/snork-nbl","html_url":"https://github.com/snork-nbl","followers_url":"https://api.github.com/users/snork-nbl/followers","following_url":"https://api.github.com/users/snork-nbl/following{/other_user}","gists_url":"https://api.github.com/users/snork-nbl/gists{/gist_id}","starred_url":"https://api.github.com/users/snork-nbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snork-nbl/subscriptions","organizations_url":"https://api.github.com/users/snork-nbl/orgs","repos_url":"https://api.github.com/users/snork-nbl/repos","events_url":"https://api.github.com/users/snork-nbl/events{/privacy}","received_events_url":"https://api.github.com/users/snork-nbl/received_events","type":"User","site_admin":false},"body":"Two questions here:\r\n1. Why do we need this test for Agent if it doesn't do anything useful (but is even harmful - see 2)?\r\n2. In the case when the code runs on the agent side, mm is not defined which results in `[+616.59/0.97s warning] Agent Runtime Error: ERROR: no handler for agent.send(\"MM_CONNECT\", data)` error message. This is definitely a wrong test behavior.","created_at":"2017-07-31T22:16:26Z","updated_at":"2017-07-31T22:16:26Z","html_url":"https://github.com/nobitlost/MessageManager/pull/1#discussion_r130476995","pull_request_url":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/nobitlost/MessageManager/pulls/comments/130476995"},"html":{"href":"https://github.com/nobitlost/MessageManager/pull/1#discussion_r130476995"},"pull_request":{"href":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1","id":130455206,"html_url":"https://github.com/nobitlost/MessageManager/pull/1","diff_url":"https://github.com/nobitlost/MessageManager/pull/1.diff","patch_url":"https://github.com/nobitlost/MessageManager/pull/1.patch","issue_url":"https://api.github.com/repos/nobitlost/MessageManager/issues/1","number":1,"state":"open","locked":false,"title":"CSE-425 Test coverage for MessageManager library","user":{"login":"dbukhmastov","id":25464160,"avatar_url":"https://avatars2.githubusercontent.com/u/25464160?v=4","gravatar_id":"","url":"https://api.github.com/users/dbukhmastov","html_url":"https://github.com/dbukhmastov","followers_url":"https://api.github.com/users/dbukhmastov/followers","following_url":"https://api.github.com/users/dbukhmastov/following{/other_user}","gists_url":"https://api.github.com/users/dbukhmastov/gists{/gist_id}","starred_url":"https://api.github.com/users/dbukhmastov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbukhmastov/subscriptions","organizations_url":"https://api.github.com/users/dbukhmastov/orgs","repos_url":"https://api.github.com/users/dbukhmastov/repos","events_url":"https://api.github.com/users/dbukhmastov/events{/privacy}","received_events_url":"https://api.github.com/users/dbukhmastov/received_events","type":"User","site_admin":false},"body":"CSE-425 Test coverage for MessageManager library","created_at":"2017-07-13T20:03:26Z","updated_at":"2017-07-31T22:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cecfbf281fdf0b2813ffe1f1e7334c1a07603877","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nobitlost/MessageManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nobitlost/MessageManager/issues/1/comments","statuses_url":"https://api.github.com/repos/nobitlost/MessageManager/statuses/29bdf10cfa6d2444febaef7d2b885266776b0184","head":{"label":"nobitlost:develop","ref":"develop","sha":"29bdf10cfa6d2444febaef7d2b885266776b0184","user":{"login":"nobitlost","id":25421182,"avatar_url":"https://avatars2.githubusercontent.com/u/25421182?v=4","gravatar_id":"","url":"https://api.github.com/users/nobitlost","html_url":"https://github.com/nobitlost","followers_url":"https://api.github.com/users/nobitlost/followers","following_url":"https://api.github.com/users/nobitlost/following{/other_user}","gists_url":"https://api.github.com/users/nobitlost/gists{/gist_id}","starred_url":"https://api.github.com/users/nobitlost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobitlost/subscriptions","organizations_url":"https://api.github.com/users/nobitlost/orgs","repos_url":"https://api.github.com/users/nobitlost/repos","events_url":"https://api.github.com/users/nobitlost/events{/privacy}","received_events_url":"https://api.github.com/users/nobitlost/received_events","type":"Organization","site_admin":false},"repo":{"id":96573164,"name":"MessageManager","full_name":"nobitlost/MessageManager","owner":{"login":"nobitlost","id":25421182,"avatar_url":"https://avatars2.githubusercontent.com/u/25421182?v=4","gravatar_id":"","url":"https://api.github.com/users/nobitlost","html_url":"https://github.com/nobitlost","followers_url":"https://api.github.com/users/nobitlost/followers","following_url":"https://api.github.com/users/nobitlost/following{/other_user}","gists_url":"https://api.github.com/users/nobitlost/gists{/gist_id}","starred_url":"https://api.github.com/users/nobitlost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobitlost/subscriptions","organizations_url":"https://api.github.com/users/nobitlost/orgs","repos_url":"https://api.github.com/users/nobitlost/repos","events_url":"https://api.github.com/users/nobitlost/events{/privacy}","received_events_url":"https://api.github.com/users/nobitlost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nobitlost/MessageManager","description":"MessageManager Library","fork":true,"url":"https://api.github.com/repos/nobitlost/MessageManager","forks_url":"https://api.github.com/repos/nobitlost/MessageManager/forks","keys_url":"https://api.github.com/repos/nobitlost/MessageManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nobitlost/MessageManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nobitlost/MessageManager/teams","hooks_url":"https://api.github.com/repos/nobitlost/MessageManager/hooks","issue_events_url":"https://api.github.com/repos/nobitlost/MessageManager/issues/events{/number}","events_url":"https://api.github.com/repos/nobitlost/MessageManager/events","assignees_url":"https://api.github.com/repos/nobitlost/MessageManager/assignees{/user}","branches_url":"https://api.github.com/repos/nobitlost/MessageManager/branches{/branch}","tags_url":"https://api.github.com/repos/nobitlost/MessageManager/tags","blobs_url":"https://api.github.com/repos/nobitlost/MessageManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nobitlost/MessageManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nobitlost/MessageManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/nobitlost/MessageManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nobitlost/MessageManager/statuses/{sha}","languages_url":"https://api.github.com/repos/nobitlost/MessageManager/languages","stargazers_url":"https://api.github.com/repos/nobitlost/MessageManager/stargazers","contributors_url":"https://api.github.com/repos/nobitlost/MessageManager/contributors","subscribers_url":"https://api.github.com/repos/nobitlost/MessageManager/subscribers","subscription_url":"https://api.github.com/repos/nobitlost/MessageManager/subscription","commits_url":"https://api.github.com/repos/nobitlost/MessageManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/nobitlost/MessageManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/nobitlost/MessageManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/nobitlost/MessageManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/nobitlost/MessageManager/contents/{+path}","compare_url":"https://api.github.com/repos/nobitlost/MessageManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nobitlost/MessageManager/merges","archive_url":"https://api.github.com/repos/nobitlost/MessageManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nobitlost/MessageManager/downloads","issues_url":"https://api.github.com/repos/nobitlost/MessageManager/issues{/number}","pulls_url":"https://api.github.com/repos/nobitlost/MessageManager/pulls{/number}","milestones_url":"https://api.github.com/repos/nobitlost/MessageManager/milestones{/number}","notifications_url":"https://api.github.com/repos/nobitlost/MessageManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nobitlost/MessageManager/labels{/name}","releases_url":"https://api.github.com/repos/nobitlost/MessageManager/releases{/id}","deployments_url":"https://api.github.com/repos/nobitlost/MessageManager/deployments","created_at":"2017-07-07T20:09:59Z","updated_at":"2017-07-07T20:10:01Z","pushed_at":"2017-07-30T12:59:57Z","git_url":"git://github.com/nobitlost/MessageManager.git","ssh_url":"git@github.com:nobitlost/MessageManager.git","clone_url":"https://github.com/nobitlost/MessageManager.git","svn_url":"https://github.com/nobitlost/MessageManager","homepage":null,"size":139,"stargazers_count":0,"watchers_count":0,"language":"Squirrel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nobitlost:master","ref":"master","sha":"aa21bd56c8234cde79d28a94a6d701e0282c5cec","user":{"login":"nobitlost","id":25421182,"avatar_url":"https://avatars2.githubusercontent.com/u/25421182?v=4","gravatar_id":"","url":"https://api.github.com/users/nobitlost","html_url":"https://github.com/nobitlost","followers_url":"https://api.github.com/users/nobitlost/followers","following_url":"https://api.github.com/users/nobitlost/following{/other_user}","gists_url":"https://api.github.com/users/nobitlost/gists{/gist_id}","starred_url":"https://api.github.com/users/nobitlost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobitlost/subscriptions","organizations_url":"https://api.github.com/users/nobitlost/orgs","repos_url":"https://api.github.com/users/nobitlost/repos","events_url":"https://api.github.com/users/nobitlost/events{/privacy}","received_events_url":"https://api.github.com/users/nobitlost/received_events","type":"Organization","site_admin":false},"repo":{"id":96573164,"name":"MessageManager","full_name":"nobitlost/MessageManager","owner":{"login":"nobitlost","id":25421182,"avatar_url":"https://avatars2.githubusercontent.com/u/25421182?v=4","gravatar_id":"","url":"https://api.github.com/users/nobitlost","html_url":"https://github.com/nobitlost","followers_url":"https://api.github.com/users/nobitlost/followers","following_url":"https://api.github.com/users/nobitlost/following{/other_user}","gists_url":"https://api.github.com/users/nobitlost/gists{/gist_id}","starred_url":"https://api.github.com/users/nobitlost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobitlost/subscriptions","organizations_url":"https://api.github.com/users/nobitlost/orgs","repos_url":"https://api.github.com/users/nobitlost/repos","events_url":"https://api.github.com/users/nobitlost/events{/privacy}","received_events_url":"https://api.github.com/users/nobitlost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nobitlost/MessageManager","description":"MessageManager Library","fork":true,"url":"https://api.github.com/repos/nobitlost/MessageManager","forks_url":"https://api.github.com/repos/nobitlost/MessageManager/forks","keys_url":"https://api.github.com/repos/nobitlost/MessageManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nobitlost/MessageManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nobitlost/MessageManager/teams","hooks_url":"https://api.github.com/repos/nobitlost/MessageManager/hooks","issue_events_url":"https://api.github.com/repos/nobitlost/MessageManager/issues/events{/number}","events_url":"https://api.github.com/repos/nobitlost/MessageManager/events","assignees_url":"https://api.github.com/repos/nobitlost/MessageManager/assignees{/user}","branches_url":"https://api.github.com/repos/nobitlost/MessageManager/branches{/branch}","tags_url":"https://api.github.com/repos/nobitlost/MessageManager/tags","blobs_url":"https://api.github.com/repos/nobitlost/MessageManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nobitlost/MessageManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nobitlost/MessageManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/nobitlost/MessageManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nobitlost/MessageManager/statuses/{sha}","languages_url":"https://api.github.com/repos/nobitlost/MessageManager/languages","stargazers_url":"https://api.github.com/repos/nobitlost/MessageManager/stargazers","contributors_url":"https://api.github.com/repos/nobitlost/MessageManager/contributors","subscribers_url":"https://api.github.com/repos/nobitlost/MessageManager/subscribers","subscription_url":"https://api.github.com/repos/nobitlost/MessageManager/subscription","commits_url":"https://api.github.com/repos/nobitlost/MessageManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/nobitlost/MessageManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/nobitlost/MessageManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/nobitlost/MessageManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/nobitlost/MessageManager/contents/{+path}","compare_url":"https://api.github.com/repos/nobitlost/MessageManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nobitlost/MessageManager/merges","archive_url":"https://api.github.com/repos/nobitlost/MessageManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nobitlost/MessageManager/downloads","issues_url":"https://api.github.com/repos/nobitlost/MessageManager/issues{/number}","pulls_url":"https://api.github.com/repos/nobitlost/MessageManager/pulls{/number}","milestones_url":"https://api.github.com/repos/nobitlost/MessageManager/milestones{/number}","notifications_url":"https://api.github.com/repos/nobitlost/MessageManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nobitlost/MessageManager/labels{/name}","releases_url":"https://api.github.com/repos/nobitlost/MessageManager/releases{/id}","deployments_url":"https://api.github.com/repos/nobitlost/MessageManager/deployments","created_at":"2017-07-07T20:09:59Z","updated_at":"2017-07-07T20:10:01Z","pushed_at":"2017-07-30T12:59:57Z","git_url":"git://github.com/nobitlost/MessageManager.git","ssh_url":"git@github.com:nobitlost/MessageManager.git","clone_url":"https://github.com/nobitlost/MessageManager.git","svn_url":"https://github.com/nobitlost/MessageManager","homepage":null,"size":139,"stargazers_count":0,"watchers_count":0,"language":"Squirrel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1"},"html":{"href":"https://github.com/nobitlost/MessageManager/pull/1"},"issue":{"href":"https://api.github.com/repos/nobitlost/MessageManager/issues/1"},"comments":{"href":"https://api.github.com/repos/nobitlost/MessageManager/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nobitlost/MessageManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nobitlost/MessageManager/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nobitlost/MessageManager/statuses/29bdf10cfa6d2444febaef7d2b885266776b0184"}}}}
{"actor":{"display_login":"snork-nbl"}}