{"action":"closed","issue":{"url":"https://api.github.com/repos/petdance/webservice-solr/issues/31","repository_url":"https://api.github.com/repos/petdance/webservice-solr","labels_url":"https://api.github.com/repos/petdance/webservice-solr/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/petdance/webservice-solr/issues/31/comments","events_url":"https://api.github.com/repos/petdance/webservice-solr/issues/31/events","html_url":"https://github.com/petdance/webservice-solr/issues/31","id":196088847,"number":31,"title":"docs field should explicitly be listed as is => 'rw'","user":{"login":"petdance","id":41100,"avatar_url":"https://avatars.githubusercontent.com/u/41100?v=3","gravatar_id":"","url":"https://api.github.com/users/petdance","html_url":"https://github.com/petdance","followers_url":"https://api.github.com/users/petdance/followers","following_url":"https://api.github.com/users/petdance/following{/other_user}","gists_url":"https://api.github.com/users/petdance/gists{/gist_id}","starred_url":"https://api.github.com/users/petdance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petdance/subscriptions","organizations_url":"https://api.github.com/users/petdance/orgs","repos_url":"https://api.github.com/users/petdance/repos","events_url":"https://api.github.com/users/petdance/events{/privacy}","received_events_url":"https://api.github.com/users/petdance/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-16T15:48:46Z","updated_at":"2017-01-20T19:19:13Z","closed_at":"2017-01-20T19:19:13Z","body":"From @lukec in #16:\r\n\r\nI have noticed the following warning from about `$response->docs() being read-only`. I suspect that in the dependency change, the docs field is going from implicit rw to ro.\r\n\r\nThe field is not declared ro/rw:\r\n\r\nhttps://github.com/petdance/webservice-solr/blob/dev/lib/WebService/Solr/Response.pm#L24\r\n\r\nBut then a few lines below we use the setter method: https://github.com/petdance/webservice-solr/blob/dev/lib/WebService/Solr/Response.pm#L29\r\n\r\nSo in summary, I think docs should explicitly be listed as is => 'rw'."}}
{"actor":{"display_login":"petdance"}}