{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/137438096","pull_request_review_id":61104224,"id":137438096,"diff_hunk":"@@ -476,10 +911,21 @@ class _DialState extends State<_Dial> with SingleTickerProviderStateMixin {\n   }\n \n   @override\n+  void reassemble() {\n+    _activeRing = _DialRing.outer;","path":"packages/flutter/lib/src/material/time_picker.dart","position":896,"original_position":896,"commit_id":"027dcc70a1b5365641aafd2a76f1fc4cdbaebd1f","original_commit_id":"027dcc70a1b5365641aafd2a76f1fc4cdbaebd1f","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars3.githubusercontent.com/u/112007?v=4","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"Why do we switch to the outer ring on resassemble?","created_at":"2017-09-07T03:13:03Z","updated_at":"2017-09-07T03:13:03Z","html_url":"https://github.com/flutter/flutter/pull/11967#discussion_r137438096","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/11967","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/137438096"},"html":{"href":"https://github.com/flutter/flutter/pull/11967#discussion_r137438096"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11967"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/11967","id":139680291,"html_url":"https://github.com/flutter/flutter/pull/11967","diff_url":"https://github.com/flutter/flutter/pull/11967.diff","patch_url":"https://github.com/flutter/flutter/pull/11967.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/11967","number":11967,"state":"open","locked":false,"title":"Localize time picker","user":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars1.githubusercontent.com/u/211513?v=4","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/flutter/flutter/issues/10616\r\n\r\nIncludes:\r\n\r\n- Localized header layouts (portrait and landscape) for the following ICU \"Short Time\" patterns: 'h:mm a', 'HH:mm', 'H:mm', 'HH.mm', 'a h:mm', \"HH 'h' mm\", 'HH:mm น.'\r\n- 24-hour hour picker using a two-ring dial (like on Android)\r\n- a mapping between locales/languages and the pattern above\r\n\r\nSome screenshots:\r\n\r\nFrench Canadian:\r\n\r\n![flutter_01](https://user-images.githubusercontent.com/211513/30137548-b3aede2a-9318-11e7-8716-8eecdc92ce9f.png)\r\n\r\nUS English (and many more):\r\n\r\n![flutter_02](https://user-images.githubusercontent.com/211513/30137572-c9c4ce90-9318-11e7-9074-677495a3e61c.png)\r\n\r\nRussian (and many more):\r\n\r\n![flutter_03](https://user-images.githubusercontent.com/211513/30137594-e7c692f2-9318-11e7-9bb4-6e565f37485a.png)\r\n\r\nIndonesian (and a few more):\r\n\r\n![flutter_04](https://user-images.githubusercontent.com/211513/30137619-03044eec-9319-11e7-8837-18ba31cf17f3.png)\r\n\r\nKorean (horizontal):\r\n\r\n![flutter_05](https://user-images.githubusercontent.com/211513/30137647-1ff2ba2a-9319-11e7-9cb7-e8c263b0f809.png)\r\n\r\n/cc @HansMuller @Hixie \r\n","created_at":"2017-09-06T22:37:28Z","updated_at":"2017-09-07T03:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8eb75dec32576c9fab3e3ff3ea2b727ef9013979","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/11967/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/11967/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/11967/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/027dcc70a1b5365641aafd2a76f1fc4cdbaebd1f","head":{"label":"yjbanov:time-picker-i18n","ref":"time-picker-i18n","sha":"027dcc70a1b5365641aafd2a76f1fc4cdbaebd1f","user":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars1.githubusercontent.com/u/211513?v=4","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"repo":{"id":50871415,"name":"flutter","full_name":"yjbanov/flutter","owner":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars1.githubusercontent.com/u/211513?v=4","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjbanov/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":true,"url":"https://api.github.com/repos/yjbanov/flutter","forks_url":"https://api.github.com/repos/yjbanov/flutter/forks","keys_url":"https://api.github.com/repos/yjbanov/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjbanov/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjbanov/flutter/teams","hooks_url":"https://api.github.com/repos/yjbanov/flutter/hooks","issue_events_url":"https://api.github.com/repos/yjbanov/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/yjbanov/flutter/events","assignees_url":"https://api.github.com/repos/yjbanov/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/yjbanov/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/yjbanov/flutter/tags","blobs_url":"https://api.github.com/repos/yjbanov/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjbanov/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjbanov/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjbanov/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjbanov/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/yjbanov/flutter/languages","stargazers_url":"https://api.github.com/repos/yjbanov/flutter/stargazers","contributors_url":"https://api.github.com/repos/yjbanov/flutter/contributors","subscribers_url":"https://api.github.com/repos/yjbanov/flutter/subscribers","subscription_url":"https://api.github.com/repos/yjbanov/flutter/subscription","commits_url":"https://api.github.com/repos/yjbanov/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjbanov/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjbanov/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjbanov/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjbanov/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/yjbanov/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjbanov/flutter/merges","archive_url":"https://api.github.com/repos/yjbanov/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjbanov/flutter/downloads","issues_url":"https://api.github.com/repos/yjbanov/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/yjbanov/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/yjbanov/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/yjbanov/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjbanov/flutter/labels{/name}","releases_url":"https://api.github.com/repos/yjbanov/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/yjbanov/flutter/deployments","created_at":"2016-02-01T21:09:40Z","updated_at":"2016-02-01T21:09:42Z","pushed_at":"2017-09-06T22:22:58Z","git_url":"git://github.com/yjbanov/flutter.git","ssh_url":"git@github.com:yjbanov/flutter.git","clone_url":"https://github.com/yjbanov/flutter.git","svn_url":"https://github.com/yjbanov/flutter","homepage":"http://flutter.io","size":29712,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"0d454724d3707f0ed1c813cddc74a57dd1ed7173","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-09-06T22:06:02Z","pushed_at":"2017-09-07T02:46:41Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":29572,"stargazers_count":6141,"watchers_count":6141,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":603,"mirror_url":null,"open_issues_count":1811,"forks":603,"open_issues":1811,"watchers":6141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11967"},"html":{"href":"https://github.com/flutter/flutter/pull/11967"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/11967"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/11967/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11967/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11967/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/027dcc70a1b5365641aafd2a76f1fc4cdbaebd1f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abarth"}}