{"action":"closed","number":233,"pull_request":{"url":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/233","id":151033451,"html_url":"https://github.com/Microsoft/oxa-tools/pull/233","diff_url":"https://github.com/Microsoft/oxa-tools/pull/233.diff","patch_url":"https://github.com/Microsoft/oxa-tools/pull/233.patch","issue_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/233","number":233,"state":"closed","locked":false,"title":"L&D Intergration","user":{"login":"manikarthikk","id":24417391,"avatar_url":"https://avatars0.githubusercontent.com/u/24417391?v=4","gravatar_id":"","url":"https://api.github.com/users/manikarthikk","html_url":"https://github.com/manikarthikk","followers_url":"https://api.github.com/users/manikarthikk/followers","following_url":"https://api.github.com/users/manikarthikk/following{/other_user}","gists_url":"https://api.github.com/users/manikarthikk/gists{/gist_id}","starred_url":"https://api.github.com/users/manikarthikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manikarthikk/subscriptions","organizations_url":"https://api.github.com/users/manikarthikk/orgs","repos_url":"https://api.github.com/users/manikarthikk/repos","events_url":"https://api.github.com/users/manikarthikk/events{/privacy}","received_events_url":"https://api.github.com/users/manikarthikk/received_events","type":"User","site_admin":false},"body":"## # **This PR will not be merged in to this repo. Submitted for the purpose of feedback**\r\n#### What does this PR do? Please provide some context\r\n    1) GET access token from Azure tenant using MSI\r\n    2) GET secrets from Azure keyvault using the access token\r\n    3) GET the Course catalog data from OpenEdx using the secrets obtined from Azure key vault\r\n    4) Map and process the OpenEdx course catalog data with L&D Catalog_UpdateMultipleCatalogAsync API request body\r\n    5) POST the mapped data to L&D Catalog_UpdateMultipleCatalogAsync API\r\n \r\n#### Where should the reviewer start?\r\ndeploy MSI enabled linux machine and run the script sync_course_catalog.py in python3 environment\r\n#### How can this be manually tested? (brief repro steps)\r\ncreate a course in the edx platform and running the script will make the course catalog data available in L&D services.\r\nuse the following API with course_id to test the course availabulity in L&D\r\nhttps://ldserviceuat.portal.azure-api.net/docs/services/Catalog/operations/58d4f57055915813c8fa7fc3 \r\n\r\n#### What are the relevant TFS items? (list id numbers)\r\n102357\r\n#### Definition of done:\r\n- [ ] Title of the pull request is clear and informative\r\n- [ ] Add pull request hyperlink to relevant TFS items\r\n- [ ] For large or complex change: schedule an in-person review session\r\n- [ ] This change has appropriate test coverage\r\n\r\n#### Reminders BEFORE merging\r\n1. Get at least two approvals\r\n1. If you're merging from a feature branch into the development branch then \"flatten\" or \"squash\" commits\r\n1. If merging from the development branch into master (or porting changes from upstream) then use github's UI to get review feedback, but use the git command line interface to complete the actual merge.\r\n\r\n#### Reminders AFTER merging\r\n1. Delete the remote feature branch\r\n1. Resolve relevant TFS items\r\n1. (reverse merge) If you merged from the development branch into master then check to see if there are any changes in master that can be merged down to the development branch (like hotfixes, etc). In this case, use github's UI for feedback and the git command line interface for the actual merge.\r\n\r\n[//]: # ( todo: If you merged into development branch then verify change in our \"rolling deployment\" environment. Then notify stakeholders interested in or involved with the change )\r\n\r\n[//]: # ( fyi: This content was heavily inspired by )\r\n[//]: # ( 1 Our team's policies and processes )\r\n[//]: # ( 2 https://github.com/sprintly/sprint.ly-culture/blob/master/pr-template.md )\r\n[//]: # ( 3 The book \"The Checklist Manifesto: How to Get Things Right\" by Atul Gawande )\r\n[//]: # ( 4 https://github.com/Azure/azure-event-hubs/blob/master/.github/PULL_REQUEST_TEMPLATE.md )\r\n","created_at":"2017-11-07T06:22:16Z","updated_at":"2017-11-07T08:50:23Z","closed_at":"2017-11-07T08:50:23Z","merged_at":null,"merge_commit_sha":"cee6e941ea2902e0204ce7c5be54a6fb3ebf38d2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/233/commits","review_comments_url":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/233/comments","review_comment_url":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/233/comments","statuses_url":"https://api.github.com/repos/Microsoft/oxa-tools/statuses/9bef7fc93b7a931f7c82e87d3c4c468a52593ebd","head":{"label":"Microsoft:mani/landd_task","ref":"mani/landd_task","sha":"9bef7fc93b7a931f7c82e87d3c4c468a52593ebd","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":68036989,"name":"oxa-tools","full_name":"Microsoft/oxa-tools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/oxa-tools","description":"Open edX on Azure Tools","fork":false,"url":"https://api.github.com/repos/Microsoft/oxa-tools","forks_url":"https://api.github.com/repos/Microsoft/oxa-tools/forks","keys_url":"https://api.github.com/repos/Microsoft/oxa-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/oxa-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/oxa-tools/teams","hooks_url":"https://api.github.com/repos/Microsoft/oxa-tools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/oxa-tools/events","assignees_url":"https://api.github.com/repos/Microsoft/oxa-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/oxa-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/oxa-tools/tags","blobs_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/oxa-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/oxa-tools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/oxa-tools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/oxa-tools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/oxa-tools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/oxa-tools/subscription","commits_url":"https://api.github.com/repos/Microsoft/oxa-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/oxa-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/oxa-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/oxa-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/oxa-tools/merges","archive_url":"https://api.github.com/repos/Microsoft/oxa-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/oxa-tools/downloads","issues_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/oxa-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/oxa-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/oxa-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/oxa-tools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/oxa-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/oxa-tools/deployments","created_at":"2016-09-12T18:40:43Z","updated_at":"2017-09-25T00:58:39Z","pushed_at":"2017-11-07T06:34:33Z","git_url":"git://github.com/Microsoft/oxa-tools.git","ssh_url":"git@github.com:Microsoft/oxa-tools.git","clone_url":"https://github.com/Microsoft/oxa-tools.git","svn_url":"https://github.com/Microsoft/oxa-tools","homepage":null,"size":4731,"stargazers_count":13,"watchers_count":13,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":13,"default_branch":"oxa/dev.fic"}},"base":{"label":"Microsoft:oxa/dev.fic","ref":"oxa/dev.fic","sha":"c0e194ad93e97ee604cf1a06164d6b7d6580d562","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":68036989,"name":"oxa-tools","full_name":"Microsoft/oxa-tools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/oxa-tools","description":"Open edX on Azure Tools","fork":false,"url":"https://api.github.com/repos/Microsoft/oxa-tools","forks_url":"https://api.github.com/repos/Microsoft/oxa-tools/forks","keys_url":"https://api.github.com/repos/Microsoft/oxa-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/oxa-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/oxa-tools/teams","hooks_url":"https://api.github.com/repos/Microsoft/oxa-tools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/oxa-tools/events","assignees_url":"https://api.github.com/repos/Microsoft/oxa-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/oxa-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/oxa-tools/tags","blobs_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/oxa-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/oxa-tools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/oxa-tools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/oxa-tools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/oxa-tools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/oxa-tools/subscription","commits_url":"https://api.github.com/repos/Microsoft/oxa-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/oxa-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/oxa-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/oxa-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/oxa-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/oxa-tools/merges","archive_url":"https://api.github.com/repos/Microsoft/oxa-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/oxa-tools/downloads","issues_url":"https://api.github.com/repos/Microsoft/oxa-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/oxa-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/oxa-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/oxa-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/oxa-tools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/oxa-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/oxa-tools/deployments","created_at":"2016-09-12T18:40:43Z","updated_at":"2017-09-25T00:58:39Z","pushed_at":"2017-11-07T06:34:33Z","git_url":"git://github.com/Microsoft/oxa-tools.git","ssh_url":"git@github.com:Microsoft/oxa-tools.git","clone_url":"https://github.com/Microsoft/oxa-tools.git","svn_url":"https://github.com/Microsoft/oxa-tools","homepage":null,"size":4731,"stargazers_count":13,"watchers_count":13,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":13,"default_branch":"oxa/dev.fic"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/233"},"html":{"href":"https://github.com/Microsoft/oxa-tools/pull/233"},"issue":{"href":"https://api.github.com/repos/Microsoft/oxa-tools/issues/233"},"comments":{"href":"https://api.github.com/repos/Microsoft/oxa-tools/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/oxa-tools/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/oxa-tools/statuses/9bef7fc93b7a931f7c82e87d3c4c468a52593ebd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":464,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"manikarthikk"}}