{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments/123594330","pull_request_review_id":45814198,"id":123594330,"diff_hunk":"@@ -57,11 +57,11 @@ export class EmptyObservable<T> extends Observable<T> {\n    * @name empty\n    * @owner Observable\n    */\n-  static create<T>(scheduler?: IScheduler): Observable<T> {\n-    return new EmptyObservable<T>(scheduler);\n+  static create(scheduler?: IScheduler): Observable<never> {\n+    return new EmptyObservable(scheduler);\n   }\n \n-  static dispatch<T>(arg: DispatchArg<T>) {\n+  static dispatch(arg: DispatchArg<never>) {","path":"src/observable/EmptyObservable.ts","position":20,"original_position":20,"commit_id":"afc77343736415647c754caf06c4ee31fef655fc","original_commit_id":"afc77343736415647c754caf06c4ee31fef655fc","user":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars2.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"body":"wasn't clear if DispatchArg was used elsewhere since it was exported, but certainly can 👍 ","created_at":"2017-06-22T18:54:29Z","updated_at":"2017-06-22T18:54:29Z","html_url":"https://github.com/ReactiveX/rxjs/pull/2691#discussion_r123594330","pull_request_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments/123594330"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/2691#discussion_r123594330"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691","id":127055465,"html_url":"https://github.com/ReactiveX/rxjs/pull/2691","diff_url":"https://github.com/ReactiveX/rxjs/pull/2691.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/2691.patch","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2691","number":2691,"state":"open","locked":false,"title":"fix(never): Observable.never() Observable.empty() .ignoreElements () now return Observable<never>","user":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars2.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"body":"fixes #2640\r\n\r\nBREAKING CHANGE: Previously, `Observable.never()` `Observable.empty()`\r\nand the `.ignoreElements()` operator all returned `Observable<T>` which\r\nwas incorrect since they actually never emit anything. Now they all\r\nreturn `Observable<never>` (`never` was added in TS 2.0 as a special\r\ntype)","created_at":"2017-06-22T18:18:02Z","updated_at":"2017-06-22T18:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81d9f64e8d57e3b4c69e01fcccb54a2c95f99a7c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2691/comments","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/afc77343736415647c754caf06c4ee31fef655fc","head":{"label":"jayphelps:never","ref":"never","sha":"afc77343736415647c754caf06c4ee31fef655fc","user":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars2.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"repo":{"id":54432733,"name":"rxjs","full_name":"jayphelps/rxjs","owner":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars2.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayphelps/rxjs","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/jayphelps/rxjs","forks_url":"https://api.github.com/repos/jayphelps/rxjs/forks","keys_url":"https://api.github.com/repos/jayphelps/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayphelps/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayphelps/rxjs/teams","hooks_url":"https://api.github.com/repos/jayphelps/rxjs/hooks","issue_events_url":"https://api.github.com/repos/jayphelps/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/jayphelps/rxjs/events","assignees_url":"https://api.github.com/repos/jayphelps/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/jayphelps/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/jayphelps/rxjs/tags","blobs_url":"https://api.github.com/repos/jayphelps/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayphelps/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayphelps/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayphelps/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayphelps/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/jayphelps/rxjs/languages","stargazers_url":"https://api.github.com/repos/jayphelps/rxjs/stargazers","contributors_url":"https://api.github.com/repos/jayphelps/rxjs/contributors","subscribers_url":"https://api.github.com/repos/jayphelps/rxjs/subscribers","subscription_url":"https://api.github.com/repos/jayphelps/rxjs/subscription","commits_url":"https://api.github.com/repos/jayphelps/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayphelps/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayphelps/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayphelps/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayphelps/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/jayphelps/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayphelps/rxjs/merges","archive_url":"https://api.github.com/repos/jayphelps/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayphelps/rxjs/downloads","issues_url":"https://api.github.com/repos/jayphelps/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/jayphelps/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/jayphelps/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/jayphelps/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayphelps/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/jayphelps/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/jayphelps/rxjs/deployments","created_at":"2016-03-22T00:27:15Z","updated_at":"2016-03-22T00:27:16Z","pushed_at":"2017-06-22T18:16:31Z","git_url":"git://github.com/jayphelps/rxjs.git","ssh_url":"git@github.com:jayphelps/rxjs.git","clone_url":"https://github.com/jayphelps/rxjs.git","svn_url":"https://github.com/jayphelps/rxjs","homepage":null,"size":22912,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"0506ea04aff77fbc429483efebae6cd0a0670a6d","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars2.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"name":"rxjs","full_name":"ReactiveX/rxjs","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars2.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/rxjs","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/rxjs","forks_url":"https://api.github.com/repos/ReactiveX/rxjs/forks","keys_url":"https://api.github.com/repos/ReactiveX/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/rxjs/teams","hooks_url":"https://api.github.com/repos/ReactiveX/rxjs/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/rxjs/events","assignees_url":"https://api.github.com/repos/ReactiveX/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/rxjs/tags","blobs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/rxjs/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/rxjs/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/rxjs/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/rxjs/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/rxjs/subscription","commits_url":"https://api.github.com/repos/ReactiveX/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/rxjs/merges","archive_url":"https://api.github.com/repos/ReactiveX/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/rxjs/downloads","issues_url":"https://api.github.com/repos/ReactiveX/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/rxjs/deployments","created_at":"2015-03-15T06:17:10Z","updated_at":"2017-06-22T17:47:37Z","pushed_at":"2017-06-22T18:38:57Z","git_url":"git://github.com/ReactiveX/rxjs.git","ssh_url":"git@github.com:ReactiveX/rxjs.git","clone_url":"https://github.com/ReactiveX/rxjs.git","svn_url":"https://github.com/ReactiveX/rxjs","homepage":"http://reactivex.io/rxjs","size":75822,"stargazers_count":6779,"watchers_count":6779,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":653,"mirror_url":null,"open_issues_count":240,"forks":653,"open_issues":240,"watchers":6779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/2691"},"issue":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/2691"},"comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/2691/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2691/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/rxjs/statuses/afc77343736415647c754caf06c4ee31fef655fc"}}}}
{"actor":{"display_login":"jayphelps"}}