{"action":"created","comment":{"url":"https://api.github.com/repos/arquillian/smart-testing/pulls/comments/131386575","pull_request_review_id":54363744,"id":131386575,"diff_hunk":"@@ -75,8 +75,8 @@ private void configureExtension(MavenSession session, Configuration configuratio\n         final MavenProjectConfigurator mavenProjectConfigurator = new MavenProjectConfigurator(configuration);\n         session.getAllProjects().forEach(mavenProject -> {\n             final Model model = mavenProject.getModel();\n-            mavenProjectConfigurator.addRequiredDependencies(model);\n             mavenProjectConfigurator.configureTestRunner(model);\n+            mavenProjectConfigurator.addRequiredDependencies(model);","path":"mvn-extension/src/main/java/org/arquillian/smart/testing/mvn/ext/PreBuildTestOptimizer.java","position":6,"original_position":6,"commit_id":"38eae1c737aa7cda0c938f2b46e1a8265a542393","original_commit_id":"38eae1c737aa7cda0c938f2b46e1a8265a542393","user":{"login":"MatousJobanek","id":1510709,"avatar_url":"https://avatars3.githubusercontent.com/u/1510709?v=4","gravatar_id":"","url":"https://api.github.com/users/MatousJobanek","html_url":"https://github.com/MatousJobanek","followers_url":"https://api.github.com/users/MatousJobanek/followers","following_url":"https://api.github.com/users/MatousJobanek/following{/other_user}","gists_url":"https://api.github.com/users/MatousJobanek/gists{/gist_id}","starred_url":"https://api.github.com/users/MatousJobanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatousJobanek/subscriptions","organizations_url":"https://api.github.com/users/MatousJobanek/orgs","repos_url":"https://api.github.com/users/MatousJobanek/repos","events_url":"https://api.github.com/users/MatousJobanek/events{/privacy}","received_events_url":"https://api.github.com/users/MatousJobanek/received_events","type":"User","site_admin":false},"body":"Ah, cool thanks","created_at":"2017-08-04T13:19:33Z","updated_at":"2017-08-04T13:19:33Z","html_url":"https://github.com/arquillian/smart-testing/pull/86#discussion_r131386575","pull_request_url":"https://api.github.com/repos/arquillian/smart-testing/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/arquillian/smart-testing/pulls/comments/131386575"},"html":{"href":"https://github.com/arquillian/smart-testing/pull/86#discussion_r131386575"},"pull_request":{"href":"https://api.github.com/repos/arquillian/smart-testing/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/arquillian/smart-testing/pulls/86","id":134091687,"html_url":"https://github.com/arquillian/smart-testing/pull/86","diff_url":"https://github.com/arquillian/smart-testing/pull/86.diff","patch_url":"https://github.com/arquillian/smart-testing/pull/86.patch","issue_url":"https://api.github.com/repos/arquillian/smart-testing/issues/86","number":86,"state":"closed","locked":false,"title":"fix(surefire 2.20 compatibility) extension adds surefire-api dependency to the list of dependencies","user":{"login":"MatousJobanek","id":1510709,"avatar_url":"https://avatars3.githubusercontent.com/u/1510709?v=4","gravatar_id":"","url":"https://api.github.com/users/MatousJobanek","html_url":"https://github.com/MatousJobanek","followers_url":"https://api.github.com/users/MatousJobanek/followers","following_url":"https://api.github.com/users/MatousJobanek/following{/other_user}","gists_url":"https://api.github.com/users/MatousJobanek/gists{/gist_id}","starred_url":"https://api.github.com/users/MatousJobanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatousJobanek/subscriptions","organizations_url":"https://api.github.com/users/MatousJobanek/orgs","repos_url":"https://api.github.com/users/MatousJobanek/repos","events_url":"https://api.github.com/users/MatousJobanek/events{/privacy}","received_events_url":"https://api.github.com/users/MatousJobanek/received_events","type":"User","site_admin":false},"body":"Our `smart-testing-surefire-provider` uses the `surefire-api` dependency (2.19.1 version). If the user uses a newer version of surefire plugin, then it throws this exception:\r\n\r\n`java.lang.ClassNotFoundException: org.apache.maven.plugin.surefire.log.api.ConsoleLogger`\r\n\r\nThe reason is that this class has been moved to a new module `surefire-logger-api` which is (in a normal way) transitively fetched. Since our smart-testing-provider has this dependency in the list of dependencies, then the version `2.19.1` is transitively fetched and (thus) the new logger module is missing.\r\nThis is why I have to add the `surefire-api`dependency to the project `Model`- to override the our one.\r\n\r\n","created_at":"2017-08-04T05:08:06Z","updated_at":"2017-08-04T13:19:33Z","closed_at":"2017-08-04T07:35:38Z","merged_at":"2017-08-04T07:35:38Z","merge_commit_sha":"63e98708c914c522915dcbe70d029953f4856443","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/arquillian/smart-testing/pulls/86/commits","review_comments_url":"https://api.github.com/repos/arquillian/smart-testing/pulls/86/comments","review_comment_url":"https://api.github.com/repos/arquillian/smart-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arquillian/smart-testing/issues/86/comments","statuses_url":"https://api.github.com/repos/arquillian/smart-testing/statuses/38eae1c737aa7cda0c938f2b46e1a8265a542393","head":{"label":"MatousJobanek:classloader_2.20","ref":"classloader_2.20","sha":"38eae1c737aa7cda0c938f2b46e1a8265a542393","user":{"login":"MatousJobanek","id":1510709,"avatar_url":"https://avatars3.githubusercontent.com/u/1510709?v=4","gravatar_id":"","url":"https://api.github.com/users/MatousJobanek","html_url":"https://github.com/MatousJobanek","followers_url":"https://api.github.com/users/MatousJobanek/followers","following_url":"https://api.github.com/users/MatousJobanek/following{/other_user}","gists_url":"https://api.github.com/users/MatousJobanek/gists{/gist_id}","starred_url":"https://api.github.com/users/MatousJobanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatousJobanek/subscriptions","organizations_url":"https://api.github.com/users/MatousJobanek/orgs","repos_url":"https://api.github.com/users/MatousJobanek/repos","events_url":"https://api.github.com/users/MatousJobanek/events{/privacy}","received_events_url":"https://api.github.com/users/MatousJobanek/received_events","type":"User","site_admin":false},"repo":{"id":92737368,"name":"smart-testing","full_name":"MatousJobanek/smart-testing","owner":{"login":"MatousJobanek","id":1510709,"avatar_url":"https://avatars3.githubusercontent.com/u/1510709?v=4","gravatar_id":"","url":"https://api.github.com/users/MatousJobanek","html_url":"https://github.com/MatousJobanek","followers_url":"https://api.github.com/users/MatousJobanek/followers","following_url":"https://api.github.com/users/MatousJobanek/following{/other_user}","gists_url":"https://api.github.com/users/MatousJobanek/gists{/gist_id}","starred_url":"https://api.github.com/users/MatousJobanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatousJobanek/subscriptions","organizations_url":"https://api.github.com/users/MatousJobanek/orgs","repos_url":"https://api.github.com/users/MatousJobanek/repos","events_url":"https://api.github.com/users/MatousJobanek/events{/privacy}","received_events_url":"https://api.github.com/users/MatousJobanek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatousJobanek/smart-testing","description":"We know which tests you want to run.","fork":true,"url":"https://api.github.com/repos/MatousJobanek/smart-testing","forks_url":"https://api.github.com/repos/MatousJobanek/smart-testing/forks","keys_url":"https://api.github.com/repos/MatousJobanek/smart-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatousJobanek/smart-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatousJobanek/smart-testing/teams","hooks_url":"https://api.github.com/repos/MatousJobanek/smart-testing/hooks","issue_events_url":"https://api.github.com/repos/MatousJobanek/smart-testing/issues/events{/number}","events_url":"https://api.github.com/repos/MatousJobanek/smart-testing/events","assignees_url":"https://api.github.com/repos/MatousJobanek/smart-testing/assignees{/user}","branches_url":"https://api.github.com/repos/MatousJobanek/smart-testing/branches{/branch}","tags_url":"https://api.github.com/repos/MatousJobanek/smart-testing/tags","blobs_url":"https://api.github.com/repos/MatousJobanek/smart-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatousJobanek/smart-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatousJobanek/smart-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatousJobanek/smart-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatousJobanek/smart-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/MatousJobanek/smart-testing/languages","stargazers_url":"https://api.github.com/repos/MatousJobanek/smart-testing/stargazers","contributors_url":"https://api.github.com/repos/MatousJobanek/smart-testing/contributors","subscribers_url":"https://api.github.com/repos/MatousJobanek/smart-testing/subscribers","subscription_url":"https://api.github.com/repos/MatousJobanek/smart-testing/subscription","commits_url":"https://api.github.com/repos/MatousJobanek/smart-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatousJobanek/smart-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatousJobanek/smart-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatousJobanek/smart-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/MatousJobanek/smart-testing/contents/{+path}","compare_url":"https://api.github.com/repos/MatousJobanek/smart-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatousJobanek/smart-testing/merges","archive_url":"https://api.github.com/repos/MatousJobanek/smart-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatousJobanek/smart-testing/downloads","issues_url":"https://api.github.com/repos/MatousJobanek/smart-testing/issues{/number}","pulls_url":"https://api.github.com/repos/MatousJobanek/smart-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/MatousJobanek/smart-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/MatousJobanek/smart-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatousJobanek/smart-testing/labels{/name}","releases_url":"https://api.github.com/repos/MatousJobanek/smart-testing/releases{/id}","deployments_url":"https://api.github.com/repos/MatousJobanek/smart-testing/deployments","created_at":"2017-05-29T12:21:02Z","updated_at":"2017-05-29T12:21:04Z","pushed_at":"2017-08-04T06:43:26Z","git_url":"git://github.com/MatousJobanek/smart-testing.git","ssh_url":"git@github.com:MatousJobanek/smart-testing.git","clone_url":"https://github.com/MatousJobanek/smart-testing.git","svn_url":"https://github.com/MatousJobanek/smart-testing","homepage":null,"size":426,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arquillian:master","ref":"master","sha":"113c56f83f91344c4fab8458c500704876266999","user":{"login":"arquillian","id":330981,"avatar_url":"https://avatars3.githubusercontent.com/u/330981?v=4","gravatar_id":"","url":"https://api.github.com/users/arquillian","html_url":"https://github.com/arquillian","followers_url":"https://api.github.com/users/arquillian/followers","following_url":"https://api.github.com/users/arquillian/following{/other_user}","gists_url":"https://api.github.com/users/arquillian/gists{/gist_id}","starred_url":"https://api.github.com/users/arquillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arquillian/subscriptions","organizations_url":"https://api.github.com/users/arquillian/orgs","repos_url":"https://api.github.com/users/arquillian/repos","events_url":"https://api.github.com/users/arquillian/events{/privacy}","received_events_url":"https://api.github.com/users/arquillian/received_events","type":"Organization","site_admin":false},"repo":{"id":87460635,"name":"smart-testing","full_name":"arquillian/smart-testing","owner":{"login":"arquillian","id":330981,"avatar_url":"https://avatars3.githubusercontent.com/u/330981?v=4","gravatar_id":"","url":"https://api.github.com/users/arquillian","html_url":"https://github.com/arquillian","followers_url":"https://api.github.com/users/arquillian/followers","following_url":"https://api.github.com/users/arquillian/following{/other_user}","gists_url":"https://api.github.com/users/arquillian/gists{/gist_id}","starred_url":"https://api.github.com/users/arquillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arquillian/subscriptions","organizations_url":"https://api.github.com/users/arquillian/orgs","repos_url":"https://api.github.com/users/arquillian/repos","events_url":"https://api.github.com/users/arquillian/events{/privacy}","received_events_url":"https://api.github.com/users/arquillian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arquillian/smart-testing","description":"We know which tests you want to run.","fork":false,"url":"https://api.github.com/repos/arquillian/smart-testing","forks_url":"https://api.github.com/repos/arquillian/smart-testing/forks","keys_url":"https://api.github.com/repos/arquillian/smart-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arquillian/smart-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arquillian/smart-testing/teams","hooks_url":"https://api.github.com/repos/arquillian/smart-testing/hooks","issue_events_url":"https://api.github.com/repos/arquillian/smart-testing/issues/events{/number}","events_url":"https://api.github.com/repos/arquillian/smart-testing/events","assignees_url":"https://api.github.com/repos/arquillian/smart-testing/assignees{/user}","branches_url":"https://api.github.com/repos/arquillian/smart-testing/branches{/branch}","tags_url":"https://api.github.com/repos/arquillian/smart-testing/tags","blobs_url":"https://api.github.com/repos/arquillian/smart-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arquillian/smart-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arquillian/smart-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/arquillian/smart-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arquillian/smart-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/arquillian/smart-testing/languages","stargazers_url":"https://api.github.com/repos/arquillian/smart-testing/stargazers","contributors_url":"https://api.github.com/repos/arquillian/smart-testing/contributors","subscribers_url":"https://api.github.com/repos/arquillian/smart-testing/subscribers","subscription_url":"https://api.github.com/repos/arquillian/smart-testing/subscription","commits_url":"https://api.github.com/repos/arquillian/smart-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/arquillian/smart-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/arquillian/smart-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/arquillian/smart-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/arquillian/smart-testing/contents/{+path}","compare_url":"https://api.github.com/repos/arquillian/smart-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arquillian/smart-testing/merges","archive_url":"https://api.github.com/repos/arquillian/smart-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arquillian/smart-testing/downloads","issues_url":"https://api.github.com/repos/arquillian/smart-testing/issues{/number}","pulls_url":"https://api.github.com/repos/arquillian/smart-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/arquillian/smart-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/arquillian/smart-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arquillian/smart-testing/labels{/name}","releases_url":"https://api.github.com/repos/arquillian/smart-testing/releases{/id}","deployments_url":"https://api.github.com/repos/arquillian/smart-testing/deployments","created_at":"2017-04-06T18:15:38Z","updated_at":"2017-08-03T08:28:32Z","pushed_at":"2017-08-04T11:46:04Z","git_url":"git://github.com/arquillian/smart-testing.git","ssh_url":"git@github.com:arquillian/smart-testing.git","clone_url":"https://github.com/arquillian/smart-testing.git","svn_url":"https://github.com/arquillian/smart-testing","homepage":null,"size":517,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arquillian/smart-testing/pulls/86"},"html":{"href":"https://github.com/arquillian/smart-testing/pull/86"},"issue":{"href":"https://api.github.com/repos/arquillian/smart-testing/issues/86"},"comments":{"href":"https://api.github.com/repos/arquillian/smart-testing/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/arquillian/smart-testing/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/arquillian/smart-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arquillian/smart-testing/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/arquillian/smart-testing/statuses/38eae1c737aa7cda0c938f2b46e1a8265a542393"}}}}
{"actor":{"display_login":"MatousJobanek"}}