{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/23506","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/23506/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/23506/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/23506/events","html_url":"https://github.com/Microsoft/vscode/issues/23506","id":217710741,"number":23506,"title":"Elements that aren't themable","user":{"login":"roblourens","id":323878,"avatar_url":"https://avatars0.githubusercontent.com/u/323878?v=3","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"labels":[{"id":272689392,"url":"https://api.github.com/repos/Microsoft/vscode/labels/feature-request","name":"feature-request","color":"708090","default":false},{"id":308114150,"url":"https://api.github.com/repos/Microsoft/vscode/labels/themes","name":"themes","color":"c5def5","default":false},{"id":297952453,"url":"https://api.github.com/repos/Microsoft/vscode/labels/workbench","name":"workbench","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"bpasero","id":900690,"avatar_url":"https://avatars0.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"assignees":[{"login":"bpasero","id":900690,"avatar_url":"https://avatars0.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},{"login":"aeschli","id":6461412,"avatar_url":"https://avatars3.githubusercontent.com/u/6461412?v=3","gravatar_id":"","url":"https://api.github.com/users/aeschli","html_url":"https://github.com/aeschli","followers_url":"https://api.github.com/users/aeschli/followers","following_url":"https://api.github.com/users/aeschli/following{/other_user}","gists_url":"https://api.github.com/users/aeschli/gists{/gist_id}","starred_url":"https://api.github.com/users/aeschli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeschli/subscriptions","organizations_url":"https://api.github.com/users/aeschli/orgs","repos_url":"https://api.github.com/users/aeschli/repos","events_url":"https://api.github.com/users/aeschli/events{/privacy}","received_events_url":"https://api.github.com/users/aeschli/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/39","html_url":"https://github.com/Microsoft/vscode/milestone/39","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/39/labels","id":2371220,"number":39,"title":"April 2017","description":"","creator":{"login":"dbaeumer","id":1931590,"avatar_url":"https://avatars2.githubusercontent.com/u/1931590?v=3","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"open_issues":132,"closed_issues":336,"state":"open","created_at":"2017-03-08T07:58:34Z","updated_at":"2017-04-24T09:06:18Z","due_on":"2017-04-30T07:00:00Z","closed_at":null},"comments":10,"created_at":"2017-03-28T22:24:19Z","updated_at":"2017-04-24T09:20:11Z","closed_at":null,"body":"https://github.com/Microsoft/vscode/issues/23294\r\n\r\nNot sure if these are in progress, but I changed every theme attribute to red/yellow so I can notice which elements aren't themable.\r\n\r\n- [x] Selected rows in list (also file explorer, etc)\r\n![image](https://cloud.githubusercontent.com/assets/323878/24429961/3316dbc4-13c9-11e7-9f2f-359c07e9e571.png)\r\n- [ ] Placeholder text in input boxes (above screenshot)\r\n- [ ] Disable/uninstall buttons on extension page\r\n![image](https://cloud.githubusercontent.com/assets/323878/24429978/51a1a178-13c9-11e7-95c3-68c26f60d611.png)\r\n- [ ] Notification bar\r\n![image](https://cloud.githubusercontent.com/assets/323878/24430052/a79c1be4-13c9-11e7-9b84-74e95fe47bfc.png)\r\n- [ ] Badge on list (search results, problems)\r\n![image](https://cloud.githubusercontent.com/assets/323878/24430158/21832196-13ca-11e7-8e63-6246d02379a1.png)\r\n- [ ] Welcome page\r\n![image](https://cloud.githubusercontent.com/assets/323878/24430171/333be15c-13ca-11e7-8eb8-5e364d3d6f7a.png)\r\n![image](https://cloud.githubusercontent.com/assets/323878/24430184/3ddb8040-13ca-11e7-98e6-e389470bd0cf.png)\r\n- [ ] This thing\r\n![image](https://cloud.githubusercontent.com/assets/323878/24430205/5523de78-13ca-11e7-9a7e-24fa2a676f6c.png)\r\n- [ ] And the background on this popup\r\n![image](https://cloud.githubusercontent.com/assets/323878/24430209/5d3efaac-13ca-11e7-8ade-4e501601430d.png)\r\n- [ ] Not all editor settings applied inside the welcome walkthrough\r\n![image](https://cloud.githubusercontent.com/assets/323878/24430322/d8877522-13ca-11e7-9d76-a963fa576ba8.png)\r\n\r\nThis one goes out to [Hot Dog Stand](https://blog.codinghorror.com/a-tribute-to-the-windows-31-hot-dog-stand-color-scheme/)\r\n\r\n### Items collected by @psuedoSudo\r\n \r\n- [x] Autocomplete box\r\n<img width=\"470\" alt=\"autocompletion box and red cursor\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578510/4afd8cd0-172d-11e7-9a06-5497de785bc3.png\">\r\n\r\n- [ ] Background on startup\r\n\r\n<img width=\"1016\" alt=\"background on startup\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578512/4b026b06-172d-11e7-84eb-74ae733ef406.png\">\r\n\r\n- [ ] Button outline in debug panel\r\n\r\n<img width=\"208\" alt=\"button outline in debug view\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578511/4b009b64-172d-11e7-81c5-f44c140ad7fe.png\">\r\n\r\n- [ ] Disable and uninstall buttons\r\n\r\n<img width=\"648\" alt=\"disable and uninstall buttons\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578513/4b031b14-172d-11e7-934c-18af8fe86cf2.png\">\r\n\r\n- [ ] Vscode feedback popup\r\n\r\n<img width=\"456\" alt=\"feedback popup\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578514/4b052940-172d-11e7-827d-820c647d3bfd.png\">\r\n\r\n- [x] Right sidebar in git diff view\r\n\r\n<img width=\"456\" alt=\"git diff right sidebar\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578515/4b06c1e2-172d-11e7-8d5b-5bf86c0857e7.png\">\r\n\r\n- [ ] Search and replace dropdown on hover\r\n\r\n<img width=\"220\" alt=\"search and replace dropdown hover\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578516/4b2c5768-172d-11e7-8b14-2dcaa3afe485.png\">\r\n\r\n- [ ] Selected tab underline in bottom tray\r\n\r\n<img width=\"389\" alt=\"selected tab underline\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578517/4b2eb026-172d-11e7-9007-9617cdb8804e.png\">\r\n\r\n- [ ] Total settings count background and gray lines\r\n\r\n<img width=\"937\" alt=\"settings gray lines and total setting count background\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578518/4b3201ae-172d-11e7-9963-ce6365058fe3.png\">\r\n\r\n- [x] Sidebar file selection highlighting.\r\n> Selected (blue), hovered (dark gray) and out of focus (lighter gray)\r\n\r\n<img width=\"275\" alt=\"sidebar selecting blue and grays\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578519/4b34d38e-172d-11e7-9a0a-2f3bc30669be.png\">\r\n\r\n- [ ] Welcome page quick links\r\n\r\n<img width=\"1137\" alt=\"welcome page quick links\" src=\"https://cloud.githubusercontent.com/assets/4339582/24578520/4b476eb8-172d-11e7-903d-02a44f484450.png\">\r\n\r\n## Extra\r\nThese might be out of scope for the initial workbench theming but as far as I can tell the buttons and badges used throughout the ui are also not themable.\r\n\r\n- [ ] git file status badges and counts\r\n\r\n<img width=\"246\" alt=\"git file status badges and counts\" src=\"https://cloud.githubusercontent.com/assets/4339582/24731419/3d0d7da0-1aad-11e7-8c5f-f033ce71a323.png\">\r\n\r\n- [ ] Install button\r\n\r\n<img width=\"617\" alt=\"install button\" src=\"https://cloud.githubusercontent.com/assets/4339582/24731418/3d0a7e84-1aad-11e7-9397-8034841b1c6c.png\">\r\n\r\n- [ ] open folder button\r\n\r\n<img width=\"447\" alt=\"open folder button\" src=\"https://cloud.githubusercontent.com/assets/4339582/24731420/3d0dde58-1aad-11e7-9fba-ae7e4deb7d9d.png\">\r\n\r\n- [ ] reload button\r\n\r\n<img width=\"275\" alt=\"reload button\" src=\"https://cloud.githubusercontent.com/assets/4339582/24731417/3d0a24ac-1aad-11e7-9cbf-7c0d891bad5f.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/296591104","html_url":"https://github.com/Microsoft/vscode/issues/23506#issuecomment-296591104","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/23506","id":296591104,"user":{"login":"benperiton","id":104396,"avatar_url":"https://avatars1.githubusercontent.com/u/104396?v=3","gravatar_id":"","url":"https://api.github.com/users/benperiton","html_url":"https://github.com/benperiton","followers_url":"https://api.github.com/users/benperiton/followers","following_url":"https://api.github.com/users/benperiton/following{/other_user}","gists_url":"https://api.github.com/users/benperiton/gists{/gist_id}","starred_url":"https://api.github.com/users/benperiton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benperiton/subscriptions","organizations_url":"https://api.github.com/users/benperiton/orgs","repos_url":"https://api.github.com/users/benperiton/repos","events_url":"https://api.github.com/users/benperiton/events{/privacy}","received_events_url":"https://api.github.com/users/benperiton/received_events","type":"User","site_admin":false},"created_at":"2017-04-24T09:20:11Z","updated_at":"2017-04-24T09:20:11Z","body":"I couldn't see it above, but would it be possible to add a background colour for the explorer title? That way the colour from the tabs and activity bar can flow through.\r\n\r\n![screen shot 2017-04-24 at 10 18 18](https://cloud.githubusercontent.com/assets/104396/25330420/8570f1de-28d7-11e7-9e45-c9a0f1dfaa28.png)\r\n\r\n"}}
{"actor":{"display_login":"benperiton"}}