{"action":"created","comment":{"url":"https://api.github.com/repos/php-http/HttplugBundle/pulls/comments/113393768","pull_request_review_id":34776231,"id":113393768,"diff_hunk":"@@ -377,25 +377,53 @@ private function addSharedPluginNodes(ArrayNodeDefinition $pluginNode, $disableA\n                         ->thenInvalid('You can\\'t provide config option \"respect_cache_headers\" and \"respect_response_cache_directives\" simultaniously. Use \"respect_response_cache_directives\" instead.')\n                         ->end()\n                         ->children()\n-                            ->scalarNode('default_ttl')->defaultValue(0)->end()\n+                            ->scalarNode('cache_lifetime')\n+                                ->info('The minimum time we should store a cache item')\n+                            ->end()\n+                            ->enumNode('cache_key_generator')\n+                                ->info('A class implementing Http\\Client\\Common\\Plugin\\Cache\\Generator\\CacheKeyGenerator to generate a PSR-6 cache key')\n+                                ->values([null, 'Http\\Client\\Common\\Plugin\\Cache\\Generator\\CacheKeyGenerator'])","path":"DependencyInjection/Configuration.php","position":10,"original_position":10,"commit_id":"f4e1887ec63e595b183fc097a7159395098eb7bc","original_commit_id":"f4e1887ec63e595b183fc097a7159395098eb7bc","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars0.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"please use CacheKeyGenerator::class instead (we are php 5.5 or later so its supported)","created_at":"2017-04-26T08:32:17Z","updated_at":"2017-04-26T08:33:29Z","html_url":"https://github.com/php-http/HttplugBundle/pull/155#discussion_r113393768","pull_request_url":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/php-http/HttplugBundle/pulls/comments/113393768"},"html":{"href":"https://github.com/php-http/HttplugBundle/pull/155#discussion_r113393768"},"pull_request":{"href":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155","id":117656886,"html_url":"https://github.com/php-http/HttplugBundle/pull/155","diff_url":"https://github.com/php-http/HttplugBundle/pull/155.diff","patch_url":"https://github.com/php-http/HttplugBundle/pull/155.patch","issue_url":"https://api.github.com/repos/php-http/HttplugBundle/issues/155","number":155,"state":"open","locked":false,"title":"expand configuration definition and adjust tests, closes #151","user":{"login":"alcohol","id":21414,"avatar_url":"https://avatars3.githubusercontent.com/u/21414?v=3","gravatar_id":"","url":"https://api.github.com/users/alcohol","html_url":"https://github.com/alcohol","followers_url":"https://api.github.com/users/alcohol/followers","following_url":"https://api.github.com/users/alcohol/following{/other_user}","gists_url":"https://api.github.com/users/alcohol/gists{/gist_id}","starred_url":"https://api.github.com/users/alcohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcohol/subscriptions","organizations_url":"https://api.github.com/users/alcohol/orgs","repos_url":"https://api.github.com/users/alcohol/repos","events_url":"https://api.github.com/users/alcohol/events{/privacy}","received_events_url":"https://api.github.com/users/alcohol/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no\r\n| New feature?    | yes\r\n| BC breaks?      | no\r\n| Deprecations?   | no\r\n| Related tickets | fixes #151\r\n| License         | MIT\r\n\r\nI would like to point out that the official documentation at http://docs.php-http.org/en/latest/plugins/cache.html does not mention the `hash_algo` configuration option.","created_at":"2017-04-26T08:23:01Z","updated_at":"2017-04-26T08:33:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"409d0c08ebbfb2f28d16e1cd024e4e0e3b2e23b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155/commits","review_comments_url":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155/comments","review_comment_url":"https://api.github.com/repos/php-http/HttplugBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-http/HttplugBundle/issues/155/comments","statuses_url":"https://api.github.com/repos/php-http/HttplugBundle/statuses/f4e1887ec63e595b183fc097a7159395098eb7bc","head":{"label":"alcohol:expand-cache-plugin-configuration","ref":"expand-cache-plugin-configuration","sha":"f4e1887ec63e595b183fc097a7159395098eb7bc","user":{"login":"alcohol","id":21414,"avatar_url":"https://avatars3.githubusercontent.com/u/21414?v=3","gravatar_id":"","url":"https://api.github.com/users/alcohol","html_url":"https://github.com/alcohol","followers_url":"https://api.github.com/users/alcohol/followers","following_url":"https://api.github.com/users/alcohol/following{/other_user}","gists_url":"https://api.github.com/users/alcohol/gists{/gist_id}","starred_url":"https://api.github.com/users/alcohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcohol/subscriptions","organizations_url":"https://api.github.com/users/alcohol/orgs","repos_url":"https://api.github.com/users/alcohol/repos","events_url":"https://api.github.com/users/alcohol/events{/privacy}","received_events_url":"https://api.github.com/users/alcohol/received_events","type":"User","site_admin":false},"repo":{"id":87427880,"name":"HttplugBundle","full_name":"alcohol/HttplugBundle","owner":{"login":"alcohol","id":21414,"avatar_url":"https://avatars3.githubusercontent.com/u/21414?v=3","gravatar_id":"","url":"https://api.github.com/users/alcohol","html_url":"https://github.com/alcohol","followers_url":"https://api.github.com/users/alcohol/followers","following_url":"https://api.github.com/users/alcohol/following{/other_user}","gists_url":"https://api.github.com/users/alcohol/gists{/gist_id}","starred_url":"https://api.github.com/users/alcohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcohol/subscriptions","organizations_url":"https://api.github.com/users/alcohol/orgs","repos_url":"https://api.github.com/users/alcohol/repos","events_url":"https://api.github.com/users/alcohol/events{/privacy}","received_events_url":"https://api.github.com/users/alcohol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alcohol/HttplugBundle","description":"Symfony Framework Integration for HTTPlug","fork":true,"url":"https://api.github.com/repos/alcohol/HttplugBundle","forks_url":"https://api.github.com/repos/alcohol/HttplugBundle/forks","keys_url":"https://api.github.com/repos/alcohol/HttplugBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alcohol/HttplugBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alcohol/HttplugBundle/teams","hooks_url":"https://api.github.com/repos/alcohol/HttplugBundle/hooks","issue_events_url":"https://api.github.com/repos/alcohol/HttplugBundle/issues/events{/number}","events_url":"https://api.github.com/repos/alcohol/HttplugBundle/events","assignees_url":"https://api.github.com/repos/alcohol/HttplugBundle/assignees{/user}","branches_url":"https://api.github.com/repos/alcohol/HttplugBundle/branches{/branch}","tags_url":"https://api.github.com/repos/alcohol/HttplugBundle/tags","blobs_url":"https://api.github.com/repos/alcohol/HttplugBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alcohol/HttplugBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alcohol/HttplugBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/alcohol/HttplugBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alcohol/HttplugBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/alcohol/HttplugBundle/languages","stargazers_url":"https://api.github.com/repos/alcohol/HttplugBundle/stargazers","contributors_url":"https://api.github.com/repos/alcohol/HttplugBundle/contributors","subscribers_url":"https://api.github.com/repos/alcohol/HttplugBundle/subscribers","subscription_url":"https://api.github.com/repos/alcohol/HttplugBundle/subscription","commits_url":"https://api.github.com/repos/alcohol/HttplugBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/alcohol/HttplugBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/alcohol/HttplugBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/alcohol/HttplugBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/alcohol/HttplugBundle/contents/{+path}","compare_url":"https://api.github.com/repos/alcohol/HttplugBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alcohol/HttplugBundle/merges","archive_url":"https://api.github.com/repos/alcohol/HttplugBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alcohol/HttplugBundle/downloads","issues_url":"https://api.github.com/repos/alcohol/HttplugBundle/issues{/number}","pulls_url":"https://api.github.com/repos/alcohol/HttplugBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/alcohol/HttplugBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/alcohol/HttplugBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alcohol/HttplugBundle/labels{/name}","releases_url":"https://api.github.com/repos/alcohol/HttplugBundle/releases{/id}","deployments_url":"https://api.github.com/repos/alcohol/HttplugBundle/deployments","created_at":"2017-04-06T12:39:26Z","updated_at":"2017-04-06T12:39:28Z","pushed_at":"2017-04-26T08:29:22Z","git_url":"git://github.com/alcohol/HttplugBundle.git","ssh_url":"git@github.com:alcohol/HttplugBundle.git","clone_url":"https://github.com/alcohol/HttplugBundle.git","svn_url":"https://github.com/alcohol/HttplugBundle","homepage":"http://httplug.io","size":222,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-http:master","ref":"master","sha":"5c2862c21b4b3896b2a2bf9ea881b72328e75ae8","user":{"login":"php-http","id":12104859,"avatar_url":"https://avatars0.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"repo":{"id":41299142,"name":"HttplugBundle","full_name":"php-http/HttplugBundle","owner":{"login":"php-http","id":12104859,"avatar_url":"https://avatars0.githubusercontent.com/u/12104859?v=3","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-http/HttplugBundle","description":"Symfony Framework Integration for HTTPlug","fork":false,"url":"https://api.github.com/repos/php-http/HttplugBundle","forks_url":"https://api.github.com/repos/php-http/HttplugBundle/forks","keys_url":"https://api.github.com/repos/php-http/HttplugBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-http/HttplugBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-http/HttplugBundle/teams","hooks_url":"https://api.github.com/repos/php-http/HttplugBundle/hooks","issue_events_url":"https://api.github.com/repos/php-http/HttplugBundle/issues/events{/number}","events_url":"https://api.github.com/repos/php-http/HttplugBundle/events","assignees_url":"https://api.github.com/repos/php-http/HttplugBundle/assignees{/user}","branches_url":"https://api.github.com/repos/php-http/HttplugBundle/branches{/branch}","tags_url":"https://api.github.com/repos/php-http/HttplugBundle/tags","blobs_url":"https://api.github.com/repos/php-http/HttplugBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-http/HttplugBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-http/HttplugBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-http/HttplugBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-http/HttplugBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/php-http/HttplugBundle/languages","stargazers_url":"https://api.github.com/repos/php-http/HttplugBundle/stargazers","contributors_url":"https://api.github.com/repos/php-http/HttplugBundle/contributors","subscribers_url":"https://api.github.com/repos/php-http/HttplugBundle/subscribers","subscription_url":"https://api.github.com/repos/php-http/HttplugBundle/subscription","commits_url":"https://api.github.com/repos/php-http/HttplugBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-http/HttplugBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-http/HttplugBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-http/HttplugBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-http/HttplugBundle/contents/{+path}","compare_url":"https://api.github.com/repos/php-http/HttplugBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-http/HttplugBundle/merges","archive_url":"https://api.github.com/repos/php-http/HttplugBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-http/HttplugBundle/downloads","issues_url":"https://api.github.com/repos/php-http/HttplugBundle/issues{/number}","pulls_url":"https://api.github.com/repos/php-http/HttplugBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/php-http/HttplugBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/php-http/HttplugBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-http/HttplugBundle/labels{/name}","releases_url":"https://api.github.com/repos/php-http/HttplugBundle/releases{/id}","deployments_url":"https://api.github.com/repos/php-http/HttplugBundle/deployments","created_at":"2015-08-24T11:22:40Z","updated_at":"2017-04-13T23:21:00Z","pushed_at":"2017-04-26T08:29:23Z","git_url":"git://github.com/php-http/HttplugBundle.git","ssh_url":"git@github.com:php-http/HttplugBundle.git","clone_url":"https://github.com/php-http/HttplugBundle.git","svn_url":"https://github.com/php-http/HttplugBundle","homepage":"http://httplug.io","size":222,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":11,"forks":11,"open_issues":11,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155"},"html":{"href":"https://github.com/php-http/HttplugBundle/pull/155"},"issue":{"href":"https://api.github.com/repos/php-http/HttplugBundle/issues/155"},"comments":{"href":"https://api.github.com/repos/php-http/HttplugBundle/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/php-http/HttplugBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-http/HttplugBundle/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/php-http/HttplugBundle/statuses/f4e1887ec63e595b183fc097a7159395098eb7bc"}}}}
{"actor":{"display_login":"dbu"}}