{"action":"created","issue":{"url":"https://api.github.com/repos/rmaia/pavo/issues/71","repository_url":"https://api.github.com/repos/rmaia/pavo","labels_url":"https://api.github.com/repos/rmaia/pavo/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/rmaia/pavo/issues/71/comments","events_url":"https://api.github.com/repos/rmaia/pavo/issues/71/events","html_url":"https://github.com/rmaia/pavo/pull/71","id":271732276,"number":71,"title":"Add ability to parse procspec in getspec","user":{"login":"Bisaloo","id":10783929,"avatar_url":"https://avatars0.githubusercontent.com/u/10783929?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisaloo","html_url":"https://github.com/Bisaloo","followers_url":"https://api.github.com/users/Bisaloo/followers","following_url":"https://api.github.com/users/Bisaloo/following{/other_user}","gists_url":"https://api.github.com/users/Bisaloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisaloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisaloo/subscriptions","organizations_url":"https://api.github.com/users/Bisaloo/orgs","repos_url":"https://api.github.com/users/Bisaloo/repos","events_url":"https://api.github.com/users/Bisaloo/events{/privacy}","received_events_url":"https://api.github.com/users/Bisaloo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-07T07:19:09Z","updated_at":"2017-11-17T21:00:59Z","closed_at":"2017-11-17T21:00:59Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rmaia/pavo/pulls/71","html_url":"https://github.com/rmaia/pavo/pull/71","diff_url":"https://github.com/rmaia/pavo/pull/71.diff","patch_url":"https://github.com/rmaia/pavo/pull/71.patch"},"body":"Some comments:\r\n\r\n- After giving it some thought, I believe the best and cleanest option is to add a separate function to parse individual procspec files. This is the job of the internal function `parse_procspec()`. I didn't list it in the `NAMESPACE` so it shouldn't be visible to users (unless they dig around, that's why I added a minimal documentation nonetheless)\r\n- Apologies for the mess with whitespaces. Trailing whitespaces are automatically removed by my text editor. You can add `?w=1` at the end of the github diff url to hide those changes. [Link to diff without whitespaces](https://github.com/rmaia/pavo/pull/71/files?w=1)\r\n- I am not familiar with R packages development. I tried to follow instructions from Hadley's book but please let me know if something is wrong\r\n\r\nfix #51 "},"comment":{"url":"https://api.github.com/repos/rmaia/pavo/issues/comments/345364092","html_url":"https://github.com/rmaia/pavo/pull/71#issuecomment-345364092","issue_url":"https://api.github.com/repos/rmaia/pavo/issues/71","id":345364092,"user":{"login":"rmaia","id":1189223,"avatar_url":"https://avatars0.githubusercontent.com/u/1189223?v=4","gravatar_id":"","url":"https://api.github.com/users/rmaia","html_url":"https://github.com/rmaia","followers_url":"https://api.github.com/users/rmaia/followers","following_url":"https://api.github.com/users/rmaia/following{/other_user}","gists_url":"https://api.github.com/users/rmaia/gists{/gist_id}","starred_url":"https://api.github.com/users/rmaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmaia/subscriptions","organizations_url":"https://api.github.com/users/rmaia/orgs","repos_url":"https://api.github.com/users/rmaia/repos","events_url":"https://api.github.com/users/rmaia/events{/privacy}","received_events_url":"https://api.github.com/users/rmaia/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T21:00:59Z","updated_at":"2017-11-17T21:00:59Z","author_association":"OWNER","body":"ugh I messed up and made another branch. I'll merge this & then that one next"}}
{"actor":{"display_login":"rmaia"}}