{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments/134306276","pull_request_review_id":57583270,"id":134306276,"diff_hunk":"@@ -234,7 +234,7 @@ sub getSessionID {\n \t# fixme ask Jon ... is this still useful?\n     # determine the centerID and new visit number (which is now deprecated) if getPSC() failed.\n \tif($centerID == 0) {\n-            $query = \"SELECT IFNULL(MAX(VisitNo), 0)+1 AS newVisitNo, CenterID FROM session WHERE CandID=\".$dbh->quote($subjectIDref->{'CandID'}).\" GROUP BY CandID\";\n+            $query = \"SELECT IFNULL(MAX(VisitNo), 0)+1 AS newVisitNo, CenterID FROM session WHERE CandID=\".$dbh->quote($subjectIDref->{'CandID'}).\" GROUP BY CandID, newVisitNo, CenterID\";","path":"uploadNeuroDB/NeuroDB/MRI.pm","position":null,"original_position":5,"commit_id":"3446efcc681b29b2f27f8c8d43f6411fb1ebd397","original_commit_id":"0a086072cd8dd5dd15a615ff463eee93b0ec279f","user":{"login":"Jkat","id":601027,"avatar_url":"https://avatars1.githubusercontent.com/u/601027?v=4","gravatar_id":"","url":"https://api.github.com/users/Jkat","html_url":"https://github.com/Jkat","followers_url":"https://api.github.com/users/Jkat/followers","following_url":"https://api.github.com/users/Jkat/following{/other_user}","gists_url":"https://api.github.com/users/Jkat/gists{/gist_id}","starred_url":"https://api.github.com/users/Jkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jkat/subscriptions","organizations_url":"https://api.github.com/users/Jkat/orgs","repos_url":"https://api.github.com/users/Jkat/repos","events_url":"https://api.github.com/users/Jkat/events{/privacy}","received_events_url":"https://api.github.com/users/Jkat/received_events","type":"User","site_admin":false},"body":"Strange, not sure how my scripts ran fine despite having newVisitNo in the GROUP BY...","created_at":"2017-08-21T19:07:07Z","updated_at":"2017-08-21T19:07:07Z","html_url":"https://github.com/aces/Loris-MRI/pull/192#discussion_r134306276","pull_request_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments/134306276"},"html":{"href":"https://github.com/aces/Loris-MRI/pull/192#discussion_r134306276"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris-MRI/pulls/192","id":136357662,"html_url":"https://github.com/aces/Loris-MRI/pull/192","diff_url":"https://github.com/aces/Loris-MRI/pull/192.diff","patch_url":"https://github.com/aces/Loris-MRI/pull/192.patch","issue_url":"https://api.github.com/repos/aces/Loris-MRI/issues/192","number":192,"state":"open","locked":false,"title":"[SQL] Fixing MySQL 5.7 group by during visit creation","user":{"login":"Jkat","id":601027,"avatar_url":"https://avatars1.githubusercontent.com/u/601027?v=4","gravatar_id":"","url":"https://api.github.com/users/Jkat","html_url":"https://github.com/Jkat","followers_url":"https://api.github.com/users/Jkat/followers","following_url":"https://api.github.com/users/Jkat/following{/other_user}","gists_url":"https://api.github.com/users/Jkat/gists{/gist_id}","starred_url":"https://api.github.com/users/Jkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jkat/subscriptions","organizations_url":"https://api.github.com/users/Jkat/orgs","repos_url":"https://api.github.com/users/Jkat/repos","events_url":"https://api.github.com/users/Jkat/events{/privacy}","received_events_url":"https://api.github.com/users/Jkat/received_events","type":"User","site_admin":false},"body":"@MounaSafiHarab do you think this is fine?","created_at":"2017-08-17T21:28:22Z","updated_at":"2017-08-21T19:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d03dfbe392da8db9d232afc4954b50edeaf98565","assignee":{"login":"MounaSafiHarab","id":15198379,"avatar_url":"https://avatars1.githubusercontent.com/u/15198379?v=4","gravatar_id":"","url":"https://api.github.com/users/MounaSafiHarab","html_url":"https://github.com/MounaSafiHarab","followers_url":"https://api.github.com/users/MounaSafiHarab/followers","following_url":"https://api.github.com/users/MounaSafiHarab/following{/other_user}","gists_url":"https://api.github.com/users/MounaSafiHarab/gists{/gist_id}","starred_url":"https://api.github.com/users/MounaSafiHarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MounaSafiHarab/subscriptions","organizations_url":"https://api.github.com/users/MounaSafiHarab/orgs","repos_url":"https://api.github.com/users/MounaSafiHarab/repos","events_url":"https://api.github.com/users/MounaSafiHarab/events{/privacy}","received_events_url":"https://api.github.com/users/MounaSafiHarab/received_events","type":"User","site_admin":false},"assignees":[{"login":"MounaSafiHarab","id":15198379,"avatar_url":"https://avatars1.githubusercontent.com/u/15198379?v=4","gravatar_id":"","url":"https://api.github.com/users/MounaSafiHarab","html_url":"https://github.com/MounaSafiHarab","followers_url":"https://api.github.com/users/MounaSafiHarab/followers","following_url":"https://api.github.com/users/MounaSafiHarab/following{/other_user}","gists_url":"https://api.github.com/users/MounaSafiHarab/gists{/gist_id}","starred_url":"https://api.github.com/users/MounaSafiHarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MounaSafiHarab/subscriptions","organizations_url":"https://api.github.com/users/MounaSafiHarab/orgs","repos_url":"https://api.github.com/users/MounaSafiHarab/repos","events_url":"https://api.github.com/users/MounaSafiHarab/events{/privacy}","received_events_url":"https://api.github.com/users/MounaSafiHarab/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/aces/Loris-MRI/milestones/6","html_url":"https://github.com/aces/Loris-MRI/milestone/6","labels_url":"https://api.github.com/repos/aces/Loris-MRI/milestones/6/labels","id":2052272,"number":6,"title":"17.1","description":"","creator":{"login":"MounaSafiHarab","id":15198379,"avatar_url":"https://avatars1.githubusercontent.com/u/15198379?v=4","gravatar_id":"","url":"https://api.github.com/users/MounaSafiHarab","html_url":"https://github.com/MounaSafiHarab","followers_url":"https://api.github.com/users/MounaSafiHarab/followers","following_url":"https://api.github.com/users/MounaSafiHarab/following{/other_user}","gists_url":"https://api.github.com/users/MounaSafiHarab/gists{/gist_id}","starred_url":"https://api.github.com/users/MounaSafiHarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MounaSafiHarab/subscriptions","organizations_url":"https://api.github.com/users/MounaSafiHarab/orgs","repos_url":"https://api.github.com/users/MounaSafiHarab/repos","events_url":"https://api.github.com/users/MounaSafiHarab/events{/privacy}","received_events_url":"https://api.github.com/users/MounaSafiHarab/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":11,"state":"open","created_at":"2016-10-06T13:40:02Z","updated_at":"2017-08-17T21:28:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/192/commits","review_comments_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/192/comments","review_comment_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris-MRI/issues/192/comments","statuses_url":"https://api.github.com/repos/aces/Loris-MRI/statuses/3446efcc681b29b2f27f8c8d43f6411fb1ebd397","head":{"label":"Jkat:Fixing-5.7-MySQL-Group-By-visit-creation","ref":"Fixing-5.7-MySQL-Group-By-visit-creation","sha":"3446efcc681b29b2f27f8c8d43f6411fb1ebd397","user":{"login":"Jkat","id":601027,"avatar_url":"https://avatars1.githubusercontent.com/u/601027?v=4","gravatar_id":"","url":"https://api.github.com/users/Jkat","html_url":"https://github.com/Jkat","followers_url":"https://api.github.com/users/Jkat/followers","following_url":"https://api.github.com/users/Jkat/following{/other_user}","gists_url":"https://api.github.com/users/Jkat/gists{/gist_id}","starred_url":"https://api.github.com/users/Jkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jkat/subscriptions","organizations_url":"https://api.github.com/users/Jkat/orgs","repos_url":"https://api.github.com/users/Jkat/repos","events_url":"https://api.github.com/users/Jkat/events{/privacy}","received_events_url":"https://api.github.com/users/Jkat/received_events","type":"User","site_admin":false},"repo":{"id":25542444,"name":"Loris-MRI","full_name":"Jkat/Loris-MRI","owner":{"login":"Jkat","id":601027,"avatar_url":"https://avatars1.githubusercontent.com/u/601027?v=4","gravatar_id":"","url":"https://api.github.com/users/Jkat","html_url":"https://github.com/Jkat","followers_url":"https://api.github.com/users/Jkat/followers","following_url":"https://api.github.com/users/Jkat/following{/other_user}","gists_url":"https://api.github.com/users/Jkat/gists{/gist_id}","starred_url":"https://api.github.com/users/Jkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jkat/subscriptions","organizations_url":"https://api.github.com/users/Jkat/orgs","repos_url":"https://api.github.com/users/Jkat/repos","events_url":"https://api.github.com/users/Jkat/events{/privacy}","received_events_url":"https://api.github.com/users/Jkat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jkat/Loris-MRI","description":"The set of scripts that preprocess and insert MRI data into the database.","fork":true,"url":"https://api.github.com/repos/Jkat/Loris-MRI","forks_url":"https://api.github.com/repos/Jkat/Loris-MRI/forks","keys_url":"https://api.github.com/repos/Jkat/Loris-MRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jkat/Loris-MRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jkat/Loris-MRI/teams","hooks_url":"https://api.github.com/repos/Jkat/Loris-MRI/hooks","issue_events_url":"https://api.github.com/repos/Jkat/Loris-MRI/issues/events{/number}","events_url":"https://api.github.com/repos/Jkat/Loris-MRI/events","assignees_url":"https://api.github.com/repos/Jkat/Loris-MRI/assignees{/user}","branches_url":"https://api.github.com/repos/Jkat/Loris-MRI/branches{/branch}","tags_url":"https://api.github.com/repos/Jkat/Loris-MRI/tags","blobs_url":"https://api.github.com/repos/Jkat/Loris-MRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jkat/Loris-MRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jkat/Loris-MRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jkat/Loris-MRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jkat/Loris-MRI/statuses/{sha}","languages_url":"https://api.github.com/repos/Jkat/Loris-MRI/languages","stargazers_url":"https://api.github.com/repos/Jkat/Loris-MRI/stargazers","contributors_url":"https://api.github.com/repos/Jkat/Loris-MRI/contributors","subscribers_url":"https://api.github.com/repos/Jkat/Loris-MRI/subscribers","subscription_url":"https://api.github.com/repos/Jkat/Loris-MRI/subscription","commits_url":"https://api.github.com/repos/Jkat/Loris-MRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jkat/Loris-MRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jkat/Loris-MRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jkat/Loris-MRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jkat/Loris-MRI/contents/{+path}","compare_url":"https://api.github.com/repos/Jkat/Loris-MRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jkat/Loris-MRI/merges","archive_url":"https://api.github.com/repos/Jkat/Loris-MRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jkat/Loris-MRI/downloads","issues_url":"https://api.github.com/repos/Jkat/Loris-MRI/issues{/number}","pulls_url":"https://api.github.com/repos/Jkat/Loris-MRI/pulls{/number}","milestones_url":"https://api.github.com/repos/Jkat/Loris-MRI/milestones{/number}","notifications_url":"https://api.github.com/repos/Jkat/Loris-MRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jkat/Loris-MRI/labels{/name}","releases_url":"https://api.github.com/repos/Jkat/Loris-MRI/releases{/id}","deployments_url":"https://api.github.com/repos/Jkat/Loris-MRI/deployments","created_at":"2014-10-21T19:47:41Z","updated_at":"2015-06-02T17:42:35Z","pushed_at":"2017-08-21T19:06:42Z","git_url":"git://github.com/Jkat/Loris-MRI.git","ssh_url":"git@github.com:Jkat/Loris-MRI.git","clone_url":"https://github.com/Jkat/Loris-MRI.git","svn_url":"https://github.com/Jkat/Loris-MRI","homepage":"","size":1040,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aces:17.1-dev","ref":"17.1-dev","sha":"6d966673948c25034df6da63250016faa1d0dd76","user":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":2728966,"name":"Loris-MRI","full_name":"aces/Loris-MRI","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris-MRI","description":"The set of scripts that preprocess and insert MRI data into the database.","fork":false,"url":"https://api.github.com/repos/aces/Loris-MRI","forks_url":"https://api.github.com/repos/aces/Loris-MRI/forks","keys_url":"https://api.github.com/repos/aces/Loris-MRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris-MRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris-MRI/teams","hooks_url":"https://api.github.com/repos/aces/Loris-MRI/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris-MRI/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris-MRI/events","assignees_url":"https://api.github.com/repos/aces/Loris-MRI/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris-MRI/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris-MRI/tags","blobs_url":"https://api.github.com/repos/aces/Loris-MRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris-MRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris-MRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris-MRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris-MRI/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris-MRI/languages","stargazers_url":"https://api.github.com/repos/aces/Loris-MRI/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris-MRI/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris-MRI/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris-MRI/subscription","commits_url":"https://api.github.com/repos/aces/Loris-MRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris-MRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris-MRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris-MRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris-MRI/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris-MRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris-MRI/merges","archive_url":"https://api.github.com/repos/aces/Loris-MRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris-MRI/downloads","issues_url":"https://api.github.com/repos/aces/Loris-MRI/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris-MRI/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris-MRI/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris-MRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris-MRI/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris-MRI/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris-MRI/deployments","created_at":"2011-11-07T20:19:37Z","updated_at":"2017-01-31T14:39:09Z","pushed_at":"2017-08-21T19:06:44Z","git_url":"git://github.com/aces/Loris-MRI.git","ssh_url":"git@github.com:aces/Loris-MRI.git","clone_url":"https://github.com/aces/Loris-MRI.git","svn_url":"https://github.com/aces/Loris-MRI","homepage":"","size":1052,"stargazers_count":6,"watchers_count":6,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":8,"forks":25,"open_issues":8,"watchers":6,"default_branch":"17.1-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/192"},"html":{"href":"https://github.com/aces/Loris-MRI/pull/192"},"issue":{"href":"https://api.github.com/repos/aces/Loris-MRI/issues/192"},"comments":{"href":"https://api.github.com/repos/aces/Loris-MRI/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris-MRI/statuses/3446efcc681b29b2f27f8c8d43f6411fb1ebd397"}}}}
{"actor":{"display_login":"Jkat"}}