{"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/comments/108222709","pull_request_review_id":29240925,"id":108222709,"diff_hunk":"@@ -4,12 +4,11 @@\n // TODO Do we want to support OAuth 1.0? https://github.com/indieocean/Titanium-OAuth-Client/blob/master/titanium_oauth.js\n // TODO Allow users to specify scopes when authorizing\n const CALLBACK_URL = 'http://localhost/Callback'; //'urn:ietf:wg:oauth:2.0:oob' // FIXME can we redirect to some other URL scheme that won't show errors in console?\n-// TODO ALlow users to modify the look and feel of the window that opens the webview for auth? really doesn't matter much...\n+// TODO Allow users to modify the look and feel of the window that opens the webview for auth? really doesn't matter much...\n // Only important one here is the title.\n const AUTH_WINDOW_OPTIONS = {\n \tbackgroundColor : 'white',\n \tbarColor : '#000000',\n-\tmodal : true,","path":"src/index.js","position":10,"original_position":10,"commit_id":"7ed8f77d795ad9b6f211257a8607d9cf2502cdaf","original_commit_id":"7ed8f77d795ad9b6f211257a8607d9cf2502cdaf","user":{"login":"sgtcoolguy","id":3252,"avatar_url":"https://avatars3.githubusercontent.com/u/3252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"body":"I think we need this to still be modal by default so they don't switch out of it mid-login?","created_at":"2017-03-27T16:58:46Z","updated_at":"2017-03-27T16:58:47Z","html_url":"https://github.com/appcelerator-modules/ti.oauth/pull/1#discussion_r108222709","pull_request_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/comments/108222709"},"html":{"href":"https://github.com/appcelerator-modules/ti.oauth/pull/1#discussion_r108222709"},"pull_request":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1","id":109350401,"html_url":"https://github.com/appcelerator-modules/ti.oauth/pull/1","diff_url":"https://github.com/appcelerator-modules/ti.oauth/pull/1.diff","patch_url":"https://github.com/appcelerator-modules/ti.oauth/pull/1.patch","issue_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/issues/1","number":1,"state":"open","locked":false,"title":"[SWAGGEN-37] Allow \"invalidSslError\" property to be set","user":{"login":"hansemannn","id":10667698,"avatar_url":"https://avatars3.githubusercontent.com/u/10667698?v=3","gravatar_id":"","url":"https://api.github.com/users/hansemannn","html_url":"https://github.com/hansemannn","followers_url":"https://api.github.com/users/hansemannn/followers","following_url":"https://api.github.com/users/hansemannn/following{/other_user}","gists_url":"https://api.github.com/users/hansemannn/gists{/gist_id}","starred_url":"https://api.github.com/users/hansemannn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansemannn/subscriptions","organizations_url":"https://api.github.com/users/hansemannn/orgs","repos_url":"https://api.github.com/users/hansemannn/repos","events_url":"https://api.github.com/users/hansemannn/events{/privacy}","received_events_url":"https://api.github.com/users/hansemannn/received_events","type":"User","site_admin":false},"body":"**JIRA**: https://techweb.axway.com/jira/browse/SWAGGEN-37\r\n\r\n@sgtcoolguy or @ingo to review.","created_at":"2017-03-06T21:15:05Z","updated_at":"2017-03-27T16:58:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90488eba5aee1ac1c716437e92154ede3dd6b991","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1/commits","review_comments_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1/comments","review_comment_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/issues/1/comments","statuses_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/statuses/7ed8f77d795ad9b6f211257a8607d9cf2502cdaf","head":{"label":"hansemannn:patch-1","ref":"patch-1","sha":"7ed8f77d795ad9b6f211257a8607d9cf2502cdaf","user":{"login":"hansemannn","id":10667698,"avatar_url":"https://avatars3.githubusercontent.com/u/10667698?v=3","gravatar_id":"","url":"https://api.github.com/users/hansemannn","html_url":"https://github.com/hansemannn","followers_url":"https://api.github.com/users/hansemannn/followers","following_url":"https://api.github.com/users/hansemannn/following{/other_user}","gists_url":"https://api.github.com/users/hansemannn/gists{/gist_id}","starred_url":"https://api.github.com/users/hansemannn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansemannn/subscriptions","organizations_url":"https://api.github.com/users/hansemannn/orgs","repos_url":"https://api.github.com/users/hansemannn/repos","events_url":"https://api.github.com/users/hansemannn/events{/privacy}","received_events_url":"https://api.github.com/users/hansemannn/received_events","type":"User","site_admin":false},"repo":{"id":84120910,"name":"ti.oauth","full_name":"hansemannn/ti.oauth","owner":{"login":"hansemannn","id":10667698,"avatar_url":"https://avatars3.githubusercontent.com/u/10667698?v=3","gravatar_id":"","url":"https://api.github.com/users/hansemannn","html_url":"https://github.com/hansemannn","followers_url":"https://api.github.com/users/hansemannn/followers","following_url":"https://api.github.com/users/hansemannn/following{/other_user}","gists_url":"https://api.github.com/users/hansemannn/gists{/gist_id}","starred_url":"https://api.github.com/users/hansemannn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansemannn/subscriptions","organizations_url":"https://api.github.com/users/hansemannn/orgs","repos_url":"https://api.github.com/users/hansemannn/repos","events_url":"https://api.github.com/users/hansemannn/events{/privacy}","received_events_url":"https://api.github.com/users/hansemannn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hansemannn/ti.oauth","description":"Oath 2.0 CommonJS implementation","fork":true,"url":"https://api.github.com/repos/hansemannn/ti.oauth","forks_url":"https://api.github.com/repos/hansemannn/ti.oauth/forks","keys_url":"https://api.github.com/repos/hansemannn/ti.oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hansemannn/ti.oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hansemannn/ti.oauth/teams","hooks_url":"https://api.github.com/repos/hansemannn/ti.oauth/hooks","issue_events_url":"https://api.github.com/repos/hansemannn/ti.oauth/issues/events{/number}","events_url":"https://api.github.com/repos/hansemannn/ti.oauth/events","assignees_url":"https://api.github.com/repos/hansemannn/ti.oauth/assignees{/user}","branches_url":"https://api.github.com/repos/hansemannn/ti.oauth/branches{/branch}","tags_url":"https://api.github.com/repos/hansemannn/ti.oauth/tags","blobs_url":"https://api.github.com/repos/hansemannn/ti.oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hansemannn/ti.oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hansemannn/ti.oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/hansemannn/ti.oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hansemannn/ti.oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/hansemannn/ti.oauth/languages","stargazers_url":"https://api.github.com/repos/hansemannn/ti.oauth/stargazers","contributors_url":"https://api.github.com/repos/hansemannn/ti.oauth/contributors","subscribers_url":"https://api.github.com/repos/hansemannn/ti.oauth/subscribers","subscription_url":"https://api.github.com/repos/hansemannn/ti.oauth/subscription","commits_url":"https://api.github.com/repos/hansemannn/ti.oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/hansemannn/ti.oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/hansemannn/ti.oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/hansemannn/ti.oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/hansemannn/ti.oauth/contents/{+path}","compare_url":"https://api.github.com/repos/hansemannn/ti.oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hansemannn/ti.oauth/merges","archive_url":"https://api.github.com/repos/hansemannn/ti.oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hansemannn/ti.oauth/downloads","issues_url":"https://api.github.com/repos/hansemannn/ti.oauth/issues{/number}","pulls_url":"https://api.github.com/repos/hansemannn/ti.oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/hansemannn/ti.oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/hansemannn/ti.oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hansemannn/ti.oauth/labels{/name}","releases_url":"https://api.github.com/repos/hansemannn/ti.oauth/releases{/id}","deployments_url":"https://api.github.com/repos/hansemannn/ti.oauth/deployments","created_at":"2017-03-06T21:07:24Z","updated_at":"2017-03-06T21:07:26Z","pushed_at":"2017-03-06T21:14:08Z","git_url":"git://github.com/hansemannn/ti.oauth.git","ssh_url":"git@github.com:hansemannn/ti.oauth.git","clone_url":"https://github.com/hansemannn/ti.oauth.git","svn_url":"https://github.com/hansemannn/ti.oauth","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator-modules:master","ref":"master","sha":"1181a67b7cff9b924fb6997a310176102cc1aaa9","user":{"login":"appcelerator-modules","id":1202816,"avatar_url":"https://avatars2.githubusercontent.com/u/1202816?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator-modules","html_url":"https://github.com/appcelerator-modules","followers_url":"https://api.github.com/users/appcelerator-modules/followers","following_url":"https://api.github.com/users/appcelerator-modules/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator-modules/subscriptions","organizations_url":"https://api.github.com/users/appcelerator-modules/orgs","repos_url":"https://api.github.com/users/appcelerator-modules/repos","events_url":"https://api.github.com/users/appcelerator-modules/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":54491409,"name":"ti.oauth","full_name":"appcelerator-modules/ti.oauth","owner":{"login":"appcelerator-modules","id":1202816,"avatar_url":"https://avatars2.githubusercontent.com/u/1202816?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator-modules","html_url":"https://github.com/appcelerator-modules","followers_url":"https://api.github.com/users/appcelerator-modules/followers","following_url":"https://api.github.com/users/appcelerator-modules/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator-modules/subscriptions","organizations_url":"https://api.github.com/users/appcelerator-modules/orgs","repos_url":"https://api.github.com/users/appcelerator-modules/repos","events_url":"https://api.github.com/users/appcelerator-modules/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator-modules/ti.oauth","description":"Oath 2.0 CommonJS implementation","fork":false,"url":"https://api.github.com/repos/appcelerator-modules/ti.oauth","forks_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/forks","keys_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/teams","hooks_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/hooks","issue_events_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/events","assignees_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/tags","blobs_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/languages","stargazers_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/stargazers","contributors_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/contributors","subscribers_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/subscribers","subscription_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/subscription","commits_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/merges","archive_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/downloads","issues_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator-modules/ti.oauth/deployments","created_at":"2016-03-22T16:34:13Z","updated_at":"2017-03-06T21:58:16Z","pushed_at":"2017-03-24T23:04:55Z","git_url":"git://github.com/appcelerator-modules/ti.oauth.git","ssh_url":"git@github.com:appcelerator-modules/ti.oauth.git","clone_url":"https://github.com/appcelerator-modules/ti.oauth.git","svn_url":"https://github.com/appcelerator-modules/ti.oauth","homepage":null,"size":13,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1"},"html":{"href":"https://github.com/appcelerator-modules/ti.oauth/pull/1"},"issue":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/issues/1"},"comments":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator-modules/ti.oauth/statuses/7ed8f77d795ad9b6f211257a8607d9cf2502cdaf"}}}}
{"actor":{"display_login":"sgtcoolguy"}}