{"action":"created","comment":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/101582809","pull_request_review_id":22316735,"id":101582809,"diff_hunk":"@@ -0,0 +1,114 @@\n+/* This software is distributed under BSD 3-clause license (see LICENSE file).\n+ *\n+ * Copyright (c) 2012-2013 Sergey Lisitsyn\n+ */\n+\n+#ifndef KNNSOLVER_H__\n+#define KNNSOLVER_H__\n+\n+#include <shogun/lib/config.h>\n+\n+#include <shogun/lib/common.h>\n+#include <shogun/io/SGIO.h>\n+#include <shogun/distance/Distance.h>\n+#include <shogun/machine/DistanceMachine.h>\n+\n+namespace shogun\n+{\n+/**\n+ * The KNNSolver class is the virtual base class of BruteKNNSolcer, CoverTreeKNNSolver, KDTreeKNNsolver, LSHKNNSolver. \n+ * The KNNSolver class will include most of Variables which been used all the other Solver and methods been used to choose ","path":"src/shogun/multiclass/KNNSolver.h","position":20,"original_position":20,"commit_id":"b08c3cf1299bb4c47733a584e4afbf77b251f8b5","original_commit_id":"b08c3cf1299bb4c47733a584e4afbf77b251f8b5","user":{"login":"karlnapf","id":699071,"avatar_url":"https://avatars.githubusercontent.com/u/699071?v=3","gravatar_id":"","url":"https://api.github.com/users/karlnapf","html_url":"https://github.com/karlnapf","followers_url":"https://api.github.com/users/karlnapf/followers","following_url":"https://api.github.com/users/karlnapf/following{/other_user}","gists_url":"https://api.github.com/users/karlnapf/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnapf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnapf/subscriptions","organizations_url":"https://api.github.com/users/karlnapf/orgs","repos_url":"https://api.github.com/users/karlnapf/repos","events_url":"https://api.github.com/users/karlnapf/events{/privacy}","received_events_url":"https://api.github.com/users/karlnapf/received_events","type":"User","site_admin":false},"body":"dont capitalize words that are not names (solver)","created_at":"2017-02-16T17:47:38Z","updated_at":"2017-02-16T17:55:28Z","html_url":"https://github.com/shogun-toolbox/shogun/pull/3608#discussion_r101582809","pull_request_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608","_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/101582809"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/3608#discussion_r101582809"},"pull_request":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608"}}},"pull_request":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608","id":103485886,"html_url":"https://github.com/shogun-toolbox/shogun/pull/3608","diff_url":"https://github.com/shogun-toolbox/shogun/pull/3608.diff","patch_url":"https://github.com/shogun-toolbox/shogun/pull/3608.patch","issue_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3608","number":3608,"state":"closed","locked":false,"title":"Clean up KNN","user":{"login":"MikeLing","id":2166227,"avatar_url":"https://avatars.githubusercontent.com/u/2166227?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeLing","html_url":"https://github.com/MikeLing","followers_url":"https://api.github.com/users/MikeLing/followers","following_url":"https://api.github.com/users/MikeLing/following{/other_user}","gists_url":"https://api.github.com/users/MikeLing/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeLing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeLing/subscriptions","organizations_url":"https://api.github.com/users/MikeLing/orgs","repos_url":"https://api.github.com/users/MikeLing/repos","events_url":"https://api.github.com/users/MikeLing/events{/privacy}","received_events_url":"https://api.github.com/users/MikeLing/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-27T12:43:59Z","updated_at":"2017-02-16T17:55:29Z","closed_at":"2017-02-16T15:48:44Z","merged_at":"2017-02-16T15:48:44Z","merge_commit_sha":"988fe1e4c3a39e1ca32f91d4a1933661bdbe2f07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608/commits","review_comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608/comments","review_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3608/comments","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/b08c3cf1299bb4c47733a584e4afbf77b251f8b5","head":{"label":"MikeLing:clean_up_KNN","ref":"clean_up_KNN","sha":"b08c3cf1299bb4c47733a584e4afbf77b251f8b5","user":{"login":"MikeLing","id":2166227,"avatar_url":"https://avatars.githubusercontent.com/u/2166227?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeLing","html_url":"https://github.com/MikeLing","followers_url":"https://api.github.com/users/MikeLing/followers","following_url":"https://api.github.com/users/MikeLing/following{/other_user}","gists_url":"https://api.github.com/users/MikeLing/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeLing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeLing/subscriptions","organizations_url":"https://api.github.com/users/MikeLing/orgs","repos_url":"https://api.github.com/users/MikeLing/repos","events_url":"https://api.github.com/users/MikeLing/events{/privacy}","received_events_url":"https://api.github.com/users/MikeLing/received_events","type":"User","site_admin":false},"repo":{"id":76655152,"name":"shogun","full_name":"MikeLing/shogun","owner":{"login":"MikeLing","id":2166227,"avatar_url":"https://avatars.githubusercontent.com/u/2166227?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeLing","html_url":"https://github.com/MikeLing","followers_url":"https://api.github.com/users/MikeLing/followers","following_url":"https://api.github.com/users/MikeLing/following{/other_user}","gists_url":"https://api.github.com/users/MikeLing/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeLing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeLing/subscriptions","organizations_url":"https://api.github.com/users/MikeLing/orgs","repos_url":"https://api.github.com/users/MikeLing/repos","events_url":"https://api.github.com/users/MikeLing/events{/privacy}","received_events_url":"https://api.github.com/users/MikeLing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikeLing/shogun","description":"The Shogun Machine Learning Toolbox (Source Code)","fork":true,"url":"https://api.github.com/repos/MikeLing/shogun","forks_url":"https://api.github.com/repos/MikeLing/shogun/forks","keys_url":"https://api.github.com/repos/MikeLing/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikeLing/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikeLing/shogun/teams","hooks_url":"https://api.github.com/repos/MikeLing/shogun/hooks","issue_events_url":"https://api.github.com/repos/MikeLing/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/MikeLing/shogun/events","assignees_url":"https://api.github.com/repos/MikeLing/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/MikeLing/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/MikeLing/shogun/tags","blobs_url":"https://api.github.com/repos/MikeLing/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikeLing/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikeLing/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikeLing/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikeLing/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/MikeLing/shogun/languages","stargazers_url":"https://api.github.com/repos/MikeLing/shogun/stargazers","contributors_url":"https://api.github.com/repos/MikeLing/shogun/contributors","subscribers_url":"https://api.github.com/repos/MikeLing/shogun/subscribers","subscription_url":"https://api.github.com/repos/MikeLing/shogun/subscription","commits_url":"https://api.github.com/repos/MikeLing/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikeLing/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikeLing/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikeLing/shogun/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikeLing/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/MikeLing/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikeLing/shogun/merges","archive_url":"https://api.github.com/repos/MikeLing/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikeLing/shogun/downloads","issues_url":"https://api.github.com/repos/MikeLing/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/MikeLing/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/MikeLing/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/MikeLing/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikeLing/shogun/labels{/name}","releases_url":"https://api.github.com/repos/MikeLing/shogun/releases{/id}","deployments_url":"https://api.github.com/repos/MikeLing/shogun/deployments","created_at":"2016-12-16T13:17:29Z","updated_at":"2016-12-16T13:17:37Z","pushed_at":"2017-02-16T13:44:29Z","git_url":"git://github.com/MikeLing/shogun.git","ssh_url":"git@github.com:MikeLing/shogun.git","clone_url":"https://github.com/MikeLing/shogun.git","svn_url":"https://github.com/MikeLing/shogun","homepage":"http://www.shogun-toolbox.org","size":61707,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"shogun-toolbox:develop","ref":"develop","sha":"eceda2dc3a5ed163e834e3ca2f70d038f2a99f9b","user":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars.githubusercontent.com/u/690673?v=3","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":1555094,"name":"shogun","full_name":"shogun-toolbox/shogun","owner":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars.githubusercontent.com/u/690673?v=3","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shogun-toolbox/shogun","description":"The Shogun Machine Learning Toolbox (Source Code)","fork":false,"url":"https://api.github.com/repos/shogun-toolbox/shogun","forks_url":"https://api.github.com/repos/shogun-toolbox/shogun/forks","keys_url":"https://api.github.com/repos/shogun-toolbox/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shogun-toolbox/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shogun-toolbox/shogun/teams","hooks_url":"https://api.github.com/repos/shogun-toolbox/shogun/hooks","issue_events_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/shogun-toolbox/shogun/events","assignees_url":"https://api.github.com/repos/shogun-toolbox/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/shogun-toolbox/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/tags","blobs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/shogun-toolbox/shogun/languages","stargazers_url":"https://api.github.com/repos/shogun-toolbox/shogun/stargazers","contributors_url":"https://api.github.com/repos/shogun-toolbox/shogun/contributors","subscribers_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscribers","subscription_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscription","commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/comments{/number}","contents_url":"https://api.github.com/repos/shogun-toolbox/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/shogun-toolbox/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shogun-toolbox/shogun/merges","archive_url":"https://api.github.com/repos/shogun-toolbox/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shogun-toolbox/shogun/downloads","issues_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/shogun-toolbox/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/shogun-toolbox/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shogun-toolbox/shogun/labels{/name}","releases_url":"https://api.github.com/repos/shogun-toolbox/shogun/releases{/id}","deployments_url":"https://api.github.com/repos/shogun-toolbox/shogun/deployments","created_at":"2011-04-01T10:44:32Z","updated_at":"2017-02-16T17:26:10Z","pushed_at":"2017-02-16T15:48:44Z","git_url":"git://github.com/shogun-toolbox/shogun.git","ssh_url":"git@github.com:shogun-toolbox/shogun.git","clone_url":"https://github.com/shogun-toolbox/shogun.git","svn_url":"https://github.com/shogun-toolbox/shogun","homepage":"http://www.shogun-toolbox.org","size":61796,"stargazers_count":1296,"watchers_count":1296,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":667,"mirror_url":null,"open_issues_count":476,"forks":667,"open_issues":476,"watchers":1296,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/3608"},"issue":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3608"},"comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/3608/comments"},"review_comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608/comments"},"review_comment":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/3608/commits"},"statuses":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/b08c3cf1299bb4c47733a584e4afbf77b251f8b5"}}}}
{"actor":{"display_login":"karlnapf"}}