{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker.github.io/pulls/comments/112344086","pull_request_review_id":33651986,"id":112344086,"diff_hunk":"@@ -394,40 +394,28 @@ option to the `--publish` flag.\n > `--mode=global` flag on `docker service  create`, it will be difficult to know\n > which nodes are running the service in order to route work to them.\n \n-##### Example: Run a `cadvisor` monitoring service on every swarm node\n-\n-[Google cAdvisor](https://hub.docker.com/r/google/cadvisor/) is a tool for\n-monitoring Linux hosts which run containers. Typically, cAdvisor is run as a\n-stand-alone container, because it is designed to monitor a given Docker Engine\n-instance. If you run cAdvisor as a service using the routing mesh, connecting\n-to the cAdvisor port on any swarm node will show you the statistics for\n-(effectively) **a random swarm node** running the service. This is probably not\n-what you want.\n-\n-The following example runs cAdvisor as a service on each node in your swarm and\n-exposes cAdvisor port locally on each swarm node. Connecting to the cAdvisor\n-port on a given node will show you **that node's** statistics. In practice, this\n-is similar to running a single stand-alone cAdvisor container on each node, but\n-without the need to manually administer those containers.\n+##### Example: Run a `nginx` web server service on every swarm node\n+\n+[nginx](https://hub.docker.com/_/nginx/) is an open source reverse proxy, load balancer, HTTP cache, and a web server. If you run nginx as a service using the routing mesh, connecting\n+to the nginx port on any swarm node will show you the web page for\n+(effectively) **a random swarm node** running the service.\n+\n+The following example runs nginx as a service on each node in your swarm and","path":"engine/swarm/services.md","position":25,"original_position":25,"commit_id":"e638f816d075d449d04180c8a27a153cb0b000e2","original_commit_id":"e638f816d075d449d04180c8a27a153cb0b000e2","user":{"login":"jmaitrehenry","id":593562,"avatar_url":"https://avatars2.githubusercontent.com/u/593562?v=3","gravatar_id":"","url":"https://api.github.com/users/jmaitrehenry","html_url":"https://github.com/jmaitrehenry","followers_url":"https://api.github.com/users/jmaitrehenry/followers","following_url":"https://api.github.com/users/jmaitrehenry/following{/other_user}","gists_url":"https://api.github.com/users/jmaitrehenry/gists{/gist_id}","starred_url":"https://api.github.com/users/jmaitrehenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmaitrehenry/subscriptions","organizations_url":"https://api.github.com/users/jmaitrehenry/orgs","repos_url":"https://api.github.com/users/jmaitrehenry/repos","events_url":"https://api.github.com/users/jmaitrehenry/events{/privacy}","received_events_url":"https://api.github.com/users/jmaitrehenry/received_events","type":"User","site_admin":false},"body":"Is it really necessary for this example? I can't find when having a nginx listening locally would be a good idea.","created_at":"2017-04-20T00:35:03Z","updated_at":"2017-04-20T00:35:03Z","html_url":"https://github.com/docker/docker.github.io/pull/2939#discussion_r112344086","pull_request_url":"https://api.github.com/repos/docker/docker.github.io/pulls/2939","_links":{"self":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/comments/112344086"},"html":{"href":"https://github.com/docker/docker.github.io/pull/2939#discussion_r112344086"},"pull_request":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/2939"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker.github.io/pulls/2939","id":116654289,"html_url":"https://github.com/docker/docker.github.io/pull/2939","diff_url":"https://github.com/docker/docker.github.io/pull/2939.diff","patch_url":"https://github.com/docker/docker.github.io/pull/2939.patch","issue_url":"https://api.github.com/repos/docker/docker.github.io/issues/2939","number":2939,"state":"open","locked":false,"title":"remove cadvisor from swarm example -- #1840","user":{"login":"t3h2mas","id":598146,"avatar_url":"https://avatars0.githubusercontent.com/u/598146?v=3","gravatar_id":"","url":"https://api.github.com/users/t3h2mas","html_url":"https://github.com/t3h2mas","followers_url":"https://api.github.com/users/t3h2mas/followers","following_url":"https://api.github.com/users/t3h2mas/following{/other_user}","gists_url":"https://api.github.com/users/t3h2mas/gists{/gist_id}","starred_url":"https://api.github.com/users/t3h2mas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3h2mas/subscriptions","organizations_url":"https://api.github.com/users/t3h2mas/orgs","repos_url":"https://api.github.com/users/t3h2mas/repos","events_url":"https://api.github.com/users/t3h2mas/events{/privacy}","received_events_url":"https://api.github.com/users/t3h2mas/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Thomas Noe <thomas.noe@madwiremedia.com>\r\n\r\n<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)\r\n    for this project's contribution guidelines. Remove these comments\r\n    as you go.\r\n\r\n    DO NOT edit files and directories listed in _data/not_edited_here.yaml.\r\n    These are maintained in upstream repos and changes here will be lost.\r\n\r\n    Help us merge your changes more quickly by adding details and setting metadata\r\n    (such as labels, milestones, and reviewers) over at the right-hand side.-->\r\n\r\n### Proposed changes\r\nUse nginx instead of cAdvisor for swarm example\r\n\r\n#1840\r\n\r\n","created_at":"2017-04-19T22:20:50Z","updated_at":"2017-04-20T00:35:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51ea5658a98538f5a170f373347f5b092f59f8fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker.github.io/pulls/2939/commits","review_comments_url":"https://api.github.com/repos/docker/docker.github.io/pulls/2939/comments","review_comment_url":"https://api.github.com/repos/docker/docker.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker.github.io/issues/2939/comments","statuses_url":"https://api.github.com/repos/docker/docker.github.io/statuses/e638f816d075d449d04180c8a27a153cb0b000e2","head":{"label":"t3h2mas:docs/remove-cadvisor","ref":"docs/remove-cadvisor","sha":"e638f816d075d449d04180c8a27a153cb0b000e2","user":{"login":"t3h2mas","id":598146,"avatar_url":"https://avatars0.githubusercontent.com/u/598146?v=3","gravatar_id":"","url":"https://api.github.com/users/t3h2mas","html_url":"https://github.com/t3h2mas","followers_url":"https://api.github.com/users/t3h2mas/followers","following_url":"https://api.github.com/users/t3h2mas/following{/other_user}","gists_url":"https://api.github.com/users/t3h2mas/gists{/gist_id}","starred_url":"https://api.github.com/users/t3h2mas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3h2mas/subscriptions","organizations_url":"https://api.github.com/users/t3h2mas/orgs","repos_url":"https://api.github.com/users/t3h2mas/repos","events_url":"https://api.github.com/users/t3h2mas/events{/privacy}","received_events_url":"https://api.github.com/users/t3h2mas/received_events","type":"User","site_admin":false},"repo":{"id":88795707,"name":"docker.github.io","full_name":"t3h2mas/docker.github.io","owner":{"login":"t3h2mas","id":598146,"avatar_url":"https://avatars0.githubusercontent.com/u/598146?v=3","gravatar_id":"","url":"https://api.github.com/users/t3h2mas","html_url":"https://github.com/t3h2mas","followers_url":"https://api.github.com/users/t3h2mas/followers","following_url":"https://api.github.com/users/t3h2mas/following{/other_user}","gists_url":"https://api.github.com/users/t3h2mas/gists{/gist_id}","starred_url":"https://api.github.com/users/t3h2mas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t3h2mas/subscriptions","organizations_url":"https://api.github.com/users/t3h2mas/orgs","repos_url":"https://api.github.com/users/t3h2mas/repos","events_url":"https://api.github.com/users/t3h2mas/events{/privacy}","received_events_url":"https://api.github.com/users/t3h2mas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t3h2mas/docker.github.io","description":"Source repo for Docker's Documentation","fork":true,"url":"https://api.github.com/repos/t3h2mas/docker.github.io","forks_url":"https://api.github.com/repos/t3h2mas/docker.github.io/forks","keys_url":"https://api.github.com/repos/t3h2mas/docker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t3h2mas/docker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t3h2mas/docker.github.io/teams","hooks_url":"https://api.github.com/repos/t3h2mas/docker.github.io/hooks","issue_events_url":"https://api.github.com/repos/t3h2mas/docker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/t3h2mas/docker.github.io/events","assignees_url":"https://api.github.com/repos/t3h2mas/docker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/t3h2mas/docker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/t3h2mas/docker.github.io/tags","blobs_url":"https://api.github.com/repos/t3h2mas/docker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t3h2mas/docker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t3h2mas/docker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/t3h2mas/docker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t3h2mas/docker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/t3h2mas/docker.github.io/languages","stargazers_url":"https://api.github.com/repos/t3h2mas/docker.github.io/stargazers","contributors_url":"https://api.github.com/repos/t3h2mas/docker.github.io/contributors","subscribers_url":"https://api.github.com/repos/t3h2mas/docker.github.io/subscribers","subscription_url":"https://api.github.com/repos/t3h2mas/docker.github.io/subscription","commits_url":"https://api.github.com/repos/t3h2mas/docker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/t3h2mas/docker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/t3h2mas/docker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/t3h2mas/docker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/t3h2mas/docker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/t3h2mas/docker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t3h2mas/docker.github.io/merges","archive_url":"https://api.github.com/repos/t3h2mas/docker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t3h2mas/docker.github.io/downloads","issues_url":"https://api.github.com/repos/t3h2mas/docker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/t3h2mas/docker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/t3h2mas/docker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/t3h2mas/docker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t3h2mas/docker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/t3h2mas/docker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/t3h2mas/docker.github.io/deployments","created_at":"2017-04-19T22:16:36Z","updated_at":"2017-04-19T22:16:44Z","pushed_at":"2017-04-19T22:19:28Z","git_url":"git://github.com/t3h2mas/docker.github.io.git","ssh_url":"git@github.com:t3h2mas/docker.github.io.git","clone_url":"https://github.com/t3h2mas/docker.github.io.git","svn_url":"https://github.com/t3h2mas/docker.github.io","homepage":"https://docs.docker.com","size":455126,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"60000d2eabd18235a49625b6ebacdbdfd371dac7","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":65772720,"name":"docker.github.io","full_name":"docker/docker.github.io","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker.github.io","description":"Source repo for Docker's Documentation","fork":false,"url":"https://api.github.com/repos/docker/docker.github.io","forks_url":"https://api.github.com/repos/docker/docker.github.io/forks","keys_url":"https://api.github.com/repos/docker/docker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker.github.io/teams","hooks_url":"https://api.github.com/repos/docker/docker.github.io/hooks","issue_events_url":"https://api.github.com/repos/docker/docker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker.github.io/events","assignees_url":"https://api.github.com/repos/docker/docker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker.github.io/tags","blobs_url":"https://api.github.com/repos/docker/docker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker.github.io/languages","stargazers_url":"https://api.github.com/repos/docker/docker.github.io/stargazers","contributors_url":"https://api.github.com/repos/docker/docker.github.io/contributors","subscribers_url":"https://api.github.com/repos/docker/docker.github.io/subscribers","subscription_url":"https://api.github.com/repos/docker/docker.github.io/subscription","commits_url":"https://api.github.com/repos/docker/docker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker.github.io/merges","archive_url":"https://api.github.com/repos/docker/docker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker.github.io/downloads","issues_url":"https://api.github.com/repos/docker/docker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker.github.io/deployments","created_at":"2016-08-15T23:50:51Z","updated_at":"2017-04-19T20:38:18Z","pushed_at":"2017-04-20T00:22:00Z","git_url":"git://github.com/docker/docker.github.io.git","ssh_url":"git@github.com:docker/docker.github.io.git","clone_url":"https://github.com/docker/docker.github.io.git","svn_url":"https://github.com/docker/docker.github.io","homepage":"https://docs.docker.com","size":455125,"stargazers_count":266,"watchers_count":266,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1073,"mirror_url":null,"open_issues_count":303,"forks":1073,"open_issues":303,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/2939"},"html":{"href":"https://github.com/docker/docker.github.io/pull/2939"},"issue":{"href":"https://api.github.com/repos/docker/docker.github.io/issues/2939"},"comments":{"href":"https://api.github.com/repos/docker/docker.github.io/issues/2939/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/2939/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/2939/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker.github.io/statuses/e638f816d075d449d04180c8a27a153cb0b000e2"}}}}
{"actor":{"display_login":"jmaitrehenry"}}