{"action":"created","comment":{"url":"https://api.github.com/repos/teamleadercrm/api/pulls/comments/119041626","pull_request_review_id":40884578,"id":119041626,"diff_hunk":"@@ -7,18 +7,19 @@ Search invoices\n + Request (application/json)\n \n     + Attributes (object)\n-        + date_from: `01/01/2017` (string, required) - Format: dd/mm/yyyy\n-        + date_to: `31/12/2017` (string, required) - Format: dd/mm/yyyy\n+        + date_from: `2016-01-01` (string, required) - Format: yyyy-mm-dd\n+        + date_to: `2016-01-01` (string, required) - yyyy-mm-dd\n         + contact_or_company: `contact` (enum[string], optional) - Use this to filter by client\n             + Members\n                 + contact\n                 + company\n         + contact_or_company_id: `1` (number, optional) - ID of the contact or company\n-        + deep_search: `1` (number, optional) Pass 1 to return not just invoices related to the requested contact, but also to invoices related to linked companies\n+        + deep_search: `true` (boolean, optional) Pass true to return not just invoices related to the requested contact, but also to invoices related to linked companies","path":"src/invoices.apib","position":14,"original_position":14,"commit_id":"930de52fb10962cd6ec87ecdd42d9940b3bc627c","original_commit_id":"930de52fb10962cd6ec87ecdd42d9940b3bc627c","user":{"login":"jdrieghe","id":12606789,"avatar_url":"https://avatars3.githubusercontent.com/u/12606789?v=3","gravatar_id":"","url":"https://api.github.com/users/jdrieghe","html_url":"https://github.com/jdrieghe","followers_url":"https://api.github.com/users/jdrieghe/followers","following_url":"https://api.github.com/users/jdrieghe/following{/other_user}","gists_url":"https://api.github.com/users/jdrieghe/gists{/gist_id}","starred_url":"https://api.github.com/users/jdrieghe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdrieghe/subscriptions","organizations_url":"https://api.github.com/users/jdrieghe/orgs","repos_url":"https://api.github.com/users/jdrieghe/repos","events_url":"https://api.github.com/users/jdrieghe/events{/privacy}","received_events_url":"https://api.github.com/users/jdrieghe/received_events","type":"User","site_admin":false},"body":"PP: get rid of this, we can query the same info through other means","created_at":"2017-05-30T08:43:03Z","updated_at":"2017-05-30T08:43:03Z","html_url":"https://github.com/teamleadercrm/api/pull/43#discussion_r119041626","pull_request_url":"https://api.github.com/repos/teamleadercrm/api/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/comments/119041626"},"html":{"href":"https://github.com/teamleadercrm/api/pull/43#discussion_r119041626"},"pull_request":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/teamleadercrm/api/pulls/43","id":122896681,"html_url":"https://github.com/teamleadercrm/api/pull/43","diff_url":"https://github.com/teamleadercrm/api/pull/43.diff","patch_url":"https://github.com/teamleadercrm/api/pull/43.patch","issue_url":"https://api.github.com/repos/teamleadercrm/api/issues/43","number":43,"state":"open","locked":false,"title":"Reintroduce invoices.list and creditNotes.list in docs","user":{"login":"Brammm","id":851445,"avatar_url":"https://avatars0.githubusercontent.com/u/851445?v=3","gravatar_id":"","url":"https://api.github.com/users/Brammm","html_url":"https://github.com/Brammm","followers_url":"https://api.github.com/users/Brammm/followers","following_url":"https://api.github.com/users/Brammm/following{/other_user}","gists_url":"https://api.github.com/users/Brammm/gists{/gist_id}","starred_url":"https://api.github.com/users/Brammm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brammm/subscriptions","organizations_url":"https://api.github.com/users/Brammm/orgs","repos_url":"https://api.github.com/users/Brammm/repos","events_url":"https://api.github.com/users/Brammm/events{/privacy}","received_events_url":"https://api.github.com/users/Brammm/received_events","type":"User","site_admin":false},"body":"Reintroducing invoices.list and creditNotes.list endpoints in the API.\r\n\r\n**Important: Implementation will happen in core, not api-proxy.** ","created_at":"2017-05-29T13:36:48Z","updated_at":"2017-05-30T08:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20221e338a5a4df515a0f8585a27589a50bf3926","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/teamleadercrm/api/pulls/43/commits","review_comments_url":"https://api.github.com/repos/teamleadercrm/api/pulls/43/comments","review_comment_url":"https://api.github.com/repos/teamleadercrm/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamleadercrm/api/issues/43/comments","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/930de52fb10962cd6ec87ecdd42d9940b3bc627c","head":{"label":"teamleadercrm:add-invoices-creditnotes","ref":"add-invoices-creditnotes","sha":"930de52fb10962cd6ec87ecdd42d9940b3bc627c","user":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars0.githubusercontent.com/u/19797966?v=3","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"repo":{"id":87057787,"name":"api","full_name":"teamleadercrm/api","owner":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars0.githubusercontent.com/u/19797966?v=3","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamleadercrm/api","description":"The Teamleader API definition","fork":false,"url":"https://api.github.com/repos/teamleadercrm/api","forks_url":"https://api.github.com/repos/teamleadercrm/api/forks","keys_url":"https://api.github.com/repos/teamleadercrm/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamleadercrm/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamleadercrm/api/teams","hooks_url":"https://api.github.com/repos/teamleadercrm/api/hooks","issue_events_url":"https://api.github.com/repos/teamleadercrm/api/issues/events{/number}","events_url":"https://api.github.com/repos/teamleadercrm/api/events","assignees_url":"https://api.github.com/repos/teamleadercrm/api/assignees{/user}","branches_url":"https://api.github.com/repos/teamleadercrm/api/branches{/branch}","tags_url":"https://api.github.com/repos/teamleadercrm/api/tags","blobs_url":"https://api.github.com/repos/teamleadercrm/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamleadercrm/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamleadercrm/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamleadercrm/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/{sha}","languages_url":"https://api.github.com/repos/teamleadercrm/api/languages","stargazers_url":"https://api.github.com/repos/teamleadercrm/api/stargazers","contributors_url":"https://api.github.com/repos/teamleadercrm/api/contributors","subscribers_url":"https://api.github.com/repos/teamleadercrm/api/subscribers","subscription_url":"https://api.github.com/repos/teamleadercrm/api/subscription","commits_url":"https://api.github.com/repos/teamleadercrm/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamleadercrm/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamleadercrm/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamleadercrm/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamleadercrm/api/contents/{+path}","compare_url":"https://api.github.com/repos/teamleadercrm/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamleadercrm/api/merges","archive_url":"https://api.github.com/repos/teamleadercrm/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamleadercrm/api/downloads","issues_url":"https://api.github.com/repos/teamleadercrm/api/issues{/number}","pulls_url":"https://api.github.com/repos/teamleadercrm/api/pulls{/number}","milestones_url":"https://api.github.com/repos/teamleadercrm/api/milestones{/number}","notifications_url":"https://api.github.com/repos/teamleadercrm/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamleadercrm/api/labels{/name}","releases_url":"https://api.github.com/repos/teamleadercrm/api/releases{/id}","deployments_url":"https://api.github.com/repos/teamleadercrm/api/deployments","created_at":"2017-04-03T09:27:04Z","updated_at":"2017-04-25T17:32:09Z","pushed_at":"2017-05-29T14:02:10Z","git_url":"git://github.com/teamleadercrm/api.git","ssh_url":"git@github.com:teamleadercrm/api.git","clone_url":"https://github.com/teamleadercrm/api.git","svn_url":"https://github.com/teamleadercrm/api","homepage":"http://apidocs.teamleader.eu/v2/","size":93,"stargazers_count":0,"watchers_count":0,"language":"API Blueprint","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"base":{"label":"teamleadercrm:master","ref":"master","sha":"55687e45cf4ed2636a07c45423b1fcd8a70d752c","user":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars0.githubusercontent.com/u/19797966?v=3","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"repo":{"id":87057787,"name":"api","full_name":"teamleadercrm/api","owner":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars0.githubusercontent.com/u/19797966?v=3","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamleadercrm/api","description":"The Teamleader API definition","fork":false,"url":"https://api.github.com/repos/teamleadercrm/api","forks_url":"https://api.github.com/repos/teamleadercrm/api/forks","keys_url":"https://api.github.com/repos/teamleadercrm/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamleadercrm/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamleadercrm/api/teams","hooks_url":"https://api.github.com/repos/teamleadercrm/api/hooks","issue_events_url":"https://api.github.com/repos/teamleadercrm/api/issues/events{/number}","events_url":"https://api.github.com/repos/teamleadercrm/api/events","assignees_url":"https://api.github.com/repos/teamleadercrm/api/assignees{/user}","branches_url":"https://api.github.com/repos/teamleadercrm/api/branches{/branch}","tags_url":"https://api.github.com/repos/teamleadercrm/api/tags","blobs_url":"https://api.github.com/repos/teamleadercrm/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamleadercrm/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamleadercrm/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamleadercrm/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/{sha}","languages_url":"https://api.github.com/repos/teamleadercrm/api/languages","stargazers_url":"https://api.github.com/repos/teamleadercrm/api/stargazers","contributors_url":"https://api.github.com/repos/teamleadercrm/api/contributors","subscribers_url":"https://api.github.com/repos/teamleadercrm/api/subscribers","subscription_url":"https://api.github.com/repos/teamleadercrm/api/subscription","commits_url":"https://api.github.com/repos/teamleadercrm/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamleadercrm/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamleadercrm/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamleadercrm/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamleadercrm/api/contents/{+path}","compare_url":"https://api.github.com/repos/teamleadercrm/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamleadercrm/api/merges","archive_url":"https://api.github.com/repos/teamleadercrm/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamleadercrm/api/downloads","issues_url":"https://api.github.com/repos/teamleadercrm/api/issues{/number}","pulls_url":"https://api.github.com/repos/teamleadercrm/api/pulls{/number}","milestones_url":"https://api.github.com/repos/teamleadercrm/api/milestones{/number}","notifications_url":"https://api.github.com/repos/teamleadercrm/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamleadercrm/api/labels{/name}","releases_url":"https://api.github.com/repos/teamleadercrm/api/releases{/id}","deployments_url":"https://api.github.com/repos/teamleadercrm/api/deployments","created_at":"2017-04-03T09:27:04Z","updated_at":"2017-04-25T17:32:09Z","pushed_at":"2017-05-29T14:02:10Z","git_url":"git://github.com/teamleadercrm/api.git","ssh_url":"git@github.com:teamleadercrm/api.git","clone_url":"https://github.com/teamleadercrm/api.git","svn_url":"https://github.com/teamleadercrm/api","homepage":"http://apidocs.teamleader.eu/v2/","size":93,"stargazers_count":0,"watchers_count":0,"language":"API Blueprint","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/43"},"html":{"href":"https://github.com/teamleadercrm/api/pull/43"},"issue":{"href":"https://api.github.com/repos/teamleadercrm/api/issues/43"},"comments":{"href":"https://api.github.com/repos/teamleadercrm/api/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/teamleadercrm/api/statuses/930de52fb10962cd6ec87ecdd42d9940b3bc627c"}}}}
{"actor":{"display_login":"jdrieghe"}}