{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments/108316926","pull_request_review_id":29340529,"id":108316926,"diff_hunk":"@@ -115,7 +117,10 @@ public void connectClient(JavaLanguageClient client) {\n \t@Override\n \tpublic void exit() {\n \t\tlogInfo(\">> exit\");\n-\t\tSystem.exit(0);\n+\t\tExecutors.newSingleThreadScheduledExecutor().schedule(() -> {\n+\t\t\tlogInfo(\"Forcing exit after 1 min.\");\n+\t\t\tSystem.exit(0);","path":"org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java","position":16,"original_position":16,"commit_id":"1b7fb72bd849b0e2a0d5ce31965ba08516a1e0ae","original_commit_id":"1b7fb72bd849b0e2a0d5ce31965ba08516a1e0ae","user":{"login":"gorkem","id":82738,"avatar_url":"https://avatars1.githubusercontent.com/u/82738?v=3","gravatar_id":"","url":"https://api.github.com/users/gorkem","html_url":"https://github.com/gorkem","followers_url":"https://api.github.com/users/gorkem/followers","following_url":"https://api.github.com/users/gorkem/following{/other_user}","gists_url":"https://api.github.com/users/gorkem/gists{/gist_id}","starred_url":"https://api.github.com/users/gorkem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorkem/subscriptions","organizations_url":"https://api.github.com/users/gorkem/orgs","repos_url":"https://api.github.com/users/gorkem/repos","events_url":"https://api.github.com/users/gorkem/events{/privacy}","received_events_url":"https://api.github.com/users/gorkem/received_events","type":"User","site_admin":false},"body":"OK, Let's define it as a constant though.","created_at":"2017-03-28T01:24:03Z","updated_at":"2017-03-28T01:24:03Z","html_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/199#discussion_r108316926","pull_request_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments/108316926"},"html":{"href":"https://github.com/eclipse/eclipse.jdt.ls/pull/199#discussion_r108316926"},"pull_request":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199","id":112800870,"html_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/199","diff_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/199.diff","patch_url":"https://github.com/eclipse/eclipse.jdt.ls/pull/199.patch","issue_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/199","number":199,"state":"open","locked":false,"title":"Don't call System.exit on exit, might cause workspace corruption","user":{"login":"fbricon","id":148698,"avatar_url":"https://avatars0.githubusercontent.com/u/148698?v=3","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Fred Bricon <fbricon@gmail.com>","created_at":"2017-03-27T17:48:25Z","updated_at":"2017-03-28T01:24:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d5947f457c96a5fc658c9eeedb7ab88f013d709","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/milestones/12","html_url":"https://github.com/eclipse/eclipse.jdt.ls/milestone/12","labels_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/milestones/12/labels","id":2414024,"number":12,"title":"Late March 2017","description":"","creator":{"login":"fbricon","id":148698,"avatar_url":"https://avatars0.githubusercontent.com/u/148698?v=3","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2017-03-27T15:16:26Z","updated_at":"2017-03-27T17:48:57Z","due_on":"2017-03-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199/commits","review_comments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199/comments","review_comment_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/199/comments","statuses_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/statuses/1b7fb72bd849b0e2a0d5ce31965ba08516a1e0ae","head":{"label":"fbricon:bad-system-exit","ref":"bad-system-exit","sha":"1b7fb72bd849b0e2a0d5ce31965ba08516a1e0ae","user":{"login":"fbricon","id":148698,"avatar_url":"https://avatars0.githubusercontent.com/u/148698?v=3","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"repo":{"id":68128149,"name":"eclipse.jdt.ls","full_name":"fbricon/eclipse.jdt.ls","owner":{"login":"fbricon","id":148698,"avatar_url":"https://avatars0.githubusercontent.com/u/148698?v=3","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbricon/eclipse.jdt.ls","description":"Java language server","fork":true,"url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls","forks_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/forks","keys_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/teams","hooks_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/hooks","issue_events_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/issues/events{/number}","events_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/events","assignees_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/assignees{/user}","branches_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/branches{/branch}","tags_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/tags","blobs_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/statuses/{sha}","languages_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/languages","stargazers_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/stargazers","contributors_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/contributors","subscribers_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/subscribers","subscription_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/subscription","commits_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/contents/{+path}","compare_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/merges","archive_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/downloads","issues_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/issues{/number}","pulls_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/pulls{/number}","milestones_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/milestones{/number}","notifications_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/labels{/name}","releases_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/releases{/id}","deployments_url":"https://api.github.com/repos/fbricon/eclipse.jdt.ls/deployments","created_at":"2016-09-13T16:50:29Z","updated_at":"2017-02-14T23:57:35Z","pushed_at":"2017-03-28T00:38:13Z","git_url":"git://github.com/fbricon/eclipse.jdt.ls.git","ssh_url":"git@github.com:fbricon/eclipse.jdt.ls.git","clone_url":"https://github.com/fbricon/eclipse.jdt.ls.git","svn_url":"https://github.com/fbricon/eclipse.jdt.ls","homepage":null,"size":1823,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"326f6c666202b5aa37f90b40fc7b5fe3b5bf014f","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":62056780,"name":"eclipse.jdt.ls","full_name":"eclipse/eclipse.jdt.ls","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/eclipse.jdt.ls","description":"Java language server","fork":false,"url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls","forks_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/forks","keys_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/teams","hooks_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/hooks","issue_events_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/events","assignees_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/tags","blobs_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/languages","stargazers_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/stargazers","contributors_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/contributors","subscribers_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/subscribers","subscription_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/subscription","commits_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/merges","archive_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/downloads","issues_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/deployments","created_at":"2016-06-27T13:06:53Z","updated_at":"2017-03-24T16:22:30Z","pushed_at":"2017-03-28T00:38:24Z","git_url":"git://github.com/eclipse/eclipse.jdt.ls.git","ssh_url":"git@github.com:eclipse/eclipse.jdt.ls.git","clone_url":"https://github.com/eclipse/eclipse.jdt.ls.git","svn_url":"https://github.com/eclipse/eclipse.jdt.ls","homepage":null,"size":1809,"stargazers_count":134,"watchers_count":134,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":39,"forks":32,"open_issues":39,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199"},"html":{"href":"https://github.com/eclipse/eclipse.jdt.ls/pull/199"},"issue":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/199"},"comments":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/eclipse.jdt.ls/statuses/1b7fb72bd849b0e2a0d5ce31965ba08516a1e0ae"}}}}
{"actor":{"display_login":"gorkem"}}