{"action":"closed","number":1910,"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1910","id":154483206,"html_url":"https://github.com/HerculesWS/Hercules/pull/1910","diff_url":"https://github.com/HerculesWS/Hercules/pull/1910.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/1910.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1910","number":1910,"state":"closed","locked":false,"title":"Allow using the skill DB accessors on non-skill attacks (skill_id = 0)","user":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars3.githubusercontent.com/u/4590397?v=4","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"body":"### Pull Request Prelude\r\n\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\n\r\nThis suppresses an assertion in the skill DB accessors when called with `skill_id = 0` (such as during normal attacks). In such case, they'll now return an appropriate zero value, as it happened before 2b4bfa5d0.\r\n\r\n**Affected Branches:** \r\n\r\n- master\r\n- stable (v2017.11.19)\r\n\r\n**Issues addressed:**\r\n\r\n- #1909 \r\n\r\n### Known Issues and TODO List\r\n\r\nN/A\r\n\r\n### Notes\r\n\r\nThis fixes a regression in v2017.11.19 that makes the map server console very chatty, potentially causing slowdows as the server prints multiple stack traces to the console for every attack. I suggest an uplift to the stable branch (and a v2017.11.19-1 release) once this is merged to master.\r\n\r\nReview for uplifting to stable:\r\n- Regression caused by: 2b4bfa5d0\r\n- Impact if declined performance degradation as multiple stack traces are printed to the console, potentially several times each second (during normal attacks)\r\n- Risks: low/none, as this only suppresses assertions in known safe cases (restoring the behavior that existed before the above mentioned commit)\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n","created_at":"2017-11-24T06:49:22Z","updated_at":"2017-11-24T19:12:53Z","closed_at":"2017-11-24T19:12:53Z","merged_at":"2017-11-24T19:12:53Z","merge_commit_sha":"fb29abd3df655b96bf46e29faf2074b495534e0a","assignee":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars3.githubusercontent.com/u/4590397?v=4","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"assignees":[{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars3.githubusercontent.com/u/4590397?v=4","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1910/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1910/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/1910/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/34a18710fe25efaead50cf10b18a27d1d74e7c09","head":{"label":"MishimaHaruna:skilldb-getters-assertions","ref":"skilldb-getters-assertions","sha":"34a18710fe25efaead50cf10b18a27d1d74e7c09","user":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars3.githubusercontent.com/u/4590397?v=4","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"repo":{"id":10810006,"name":"Hercules","full_name":"MishimaHaruna/Hercules","owner":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars3.githubusercontent.com/u/4590397?v=4","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MishimaHaruna/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/MishimaHaruna/Hercules","forks_url":"https://api.github.com/repos/MishimaHaruna/Hercules/forks","keys_url":"https://api.github.com/repos/MishimaHaruna/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MishimaHaruna/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MishimaHaruna/Hercules/teams","hooks_url":"https://api.github.com/repos/MishimaHaruna/Hercules/hooks","issue_events_url":"https://api.github.com/repos/MishimaHaruna/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/MishimaHaruna/Hercules/events","assignees_url":"https://api.github.com/repos/MishimaHaruna/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/MishimaHaruna/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/MishimaHaruna/Hercules/tags","blobs_url":"https://api.github.com/repos/MishimaHaruna/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MishimaHaruna/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MishimaHaruna/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/MishimaHaruna/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MishimaHaruna/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/MishimaHaruna/Hercules/languages","stargazers_url":"https://api.github.com/repos/MishimaHaruna/Hercules/stargazers","contributors_url":"https://api.github.com/repos/MishimaHaruna/Hercules/contributors","subscribers_url":"https://api.github.com/repos/MishimaHaruna/Hercules/subscribers","subscription_url":"https://api.github.com/repos/MishimaHaruna/Hercules/subscription","commits_url":"https://api.github.com/repos/MishimaHaruna/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/MishimaHaruna/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/MishimaHaruna/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/MishimaHaruna/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/MishimaHaruna/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/MishimaHaruna/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MishimaHaruna/Hercules/merges","archive_url":"https://api.github.com/repos/MishimaHaruna/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MishimaHaruna/Hercules/downloads","issues_url":"https://api.github.com/repos/MishimaHaruna/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/MishimaHaruna/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/MishimaHaruna/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/MishimaHaruna/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MishimaHaruna/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/MishimaHaruna/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/MishimaHaruna/Hercules/deployments","created_at":"2013-06-20T01:47:40Z","updated_at":"2016-11-20T18:07:39Z","pushed_at":"2017-11-24T06:31:48Z","git_url":"git://github.com/MishimaHaruna/Hercules.git","ssh_url":"git@github.com:MishimaHaruna/Hercules.git","clone_url":"https://github.com/MishimaHaruna/Hercules.git","svn_url":"https://github.com/MishimaHaruna/Hercules","homepage":"http://hercules.ws","size":158633,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"c1c8d6b7424b6673bd444b0905171c06602feaa4","user":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2017-11-23T04:13:35Z","pushed_at":"2017-11-24T19:12:53Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":166849,"stargazers_count":388,"watchers_count":388,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":516,"mirror_url":null,"archived":false,"open_issues_count":409,"forks":516,"open_issues":409,"watchers":388,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1910"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/1910"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1910"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/1910/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1910/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/1910/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/34a18710fe25efaead50cf10b18a27d1d74e7c09"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars3.githubusercontent.com/u/4590397?v=4","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":188,"deletions":54,"changed_files":3}}
{"actor":{"display_login":"MishimaHaruna"}}