{"action":"created","comment":{"url":"https://api.github.com/repos/libuv/libuv/pulls/comments/146583097","pull_request_review_id":71545489,"id":146583097,"diff_hunk":"@@ -274,19 +274,44 @@\n           },\n         }],\n         [ 'OS==\"aix\"', {\n-          'sources': [ 'src/unix/aix.c' ],\n+          'variables': {\n+            'TrueOS': '<!(uname -s)',\n+          },\n+          'sources': [ \n+            'src/unix/aix-ibmi.c',\n+          ],\n           'defines': [\n             '_ALL_SOURCE',\n             '_XOPEN_SOURCE=500',\n             '_LINUX_SOURCE_COMPAT',\n             '_THREAD_SAFE',\n-            'HAVE_SYS_AHAFS_EVPRODS_H',\n           ],\n-          'link_settings': {\n-            'libraries': [\n-              '-lperfstat',\n-            ],\n-          },\n+          'conditions': [\n+            [ '\"<(TrueOS)\"==\"OS400\"', {\n+              'sources': [ \n+                'src/unix/ibmi.c',\n+                'src/unix/posix-poll.c',\n+                'src/unix/no-fsevents.c',\n+                'src/unix/no-proctitle.c',\n+              ],\n+              'defines': [\n+                '_PASE'","path":"uv.gyp","position":32,"original_position":32,"commit_id":"6c24d137e3f25130b92fb491d8b200dafb5ada51","original_commit_id":"9a95fc5f1c97b4014cb4f0789db30ff47cd73c6d","user":{"login":"jBarz","id":15161981,"avatar_url":"https://avatars1.githubusercontent.com/u/15161981?v=4","gravatar_id":"","url":"https://api.github.com/users/jBarz","html_url":"https://github.com/jBarz","followers_url":"https://api.github.com/users/jBarz/followers","following_url":"https://api.github.com/users/jBarz/following{/other_user}","gists_url":"https://api.github.com/users/jBarz/gists{/gist_id}","starred_url":"https://api.github.com/users/jBarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jBarz/subscriptions","organizations_url":"https://api.github.com/users/jBarz/orgs","repos_url":"https://api.github.com/users/jBarz/repos","events_url":"https://api.github.com/users/jBarz/events{/privacy}","received_events_url":"https://api.github.com/users/jBarz/received_events","type":"User","site_admin":false},"body":"Given that there are more differences than commonalities in this section between aix and OS400, I think the os400 section should be separate from aix maybe!\r\n```gyp\r\n[ 'OS==\"aix\"', {\r\n   ...\r\n}],\r\n[ 'OS==\"os400\"', {\r\n   ...\r\n}],\r\n```","created_at":"2017-10-24T14:41:46Z","updated_at":"2017-10-24T14:41:46Z","html_url":"https://github.com/libuv/libuv/pull/1601#discussion_r146583097","pull_request_url":"https://api.github.com/repos/libuv/libuv/pulls/1601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments/146583097"},"html":{"href":"https://github.com/libuv/libuv/pull/1601#discussion_r146583097"},"pull_request":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1601"}},"in_reply_to_id":145981273},"pull_request":{"url":"https://api.github.com/repos/libuv/libuv/pulls/1601","id":147698054,"html_url":"https://github.com/libuv/libuv/pull/1601","diff_url":"https://github.com/libuv/libuv/pull/1601.diff","patch_url":"https://github.com/libuv/libuv/pull/1601.patch","issue_url":"https://api.github.com/repos/libuv/libuv/issues/1601","number":1601,"state":"open","locked":false,"title":"IBM i support","user":{"login":"dmabupt","id":7960821,"avatar_url":"https://avatars0.githubusercontent.com/u/7960821?v=4","gravatar_id":"","url":"https://api.github.com/users/dmabupt","html_url":"https://github.com/dmabupt","followers_url":"https://api.github.com/users/dmabupt/followers","following_url":"https://api.github.com/users/dmabupt/following{/other_user}","gists_url":"https://api.github.com/users/dmabupt/gists{/gist_id}","starred_url":"https://api.github.com/users/dmabupt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmabupt/subscriptions","organizations_url":"https://api.github.com/users/dmabupt/orgs","repos_url":"https://api.github.com/users/dmabupt/repos","events_url":"https://api.github.com/users/dmabupt/events{/privacy}","received_events_url":"https://api.github.com/users/dmabupt/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-20T00:55:30Z","updated_at":"2017-10-24T14:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d56ca72ca107ddf3cfb0cded2fdc90bbf406e3f1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/libuv/libuv/pulls/1601/commits","review_comments_url":"https://api.github.com/repos/libuv/libuv/pulls/1601/comments","review_comment_url":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/1601/comments","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/6c24d137e3f25130b92fb491d8b200dafb5ada51","head":{"label":"dmabupt:v1.x","ref":"v1.x","sha":"6c24d137e3f25130b92fb491d8b200dafb5ada51","user":{"login":"dmabupt","id":7960821,"avatar_url":"https://avatars0.githubusercontent.com/u/7960821?v=4","gravatar_id":"","url":"https://api.github.com/users/dmabupt","html_url":"https://github.com/dmabupt","followers_url":"https://api.github.com/users/dmabupt/followers","following_url":"https://api.github.com/users/dmabupt/following{/other_user}","gists_url":"https://api.github.com/users/dmabupt/gists{/gist_id}","starred_url":"https://api.github.com/users/dmabupt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmabupt/subscriptions","organizations_url":"https://api.github.com/users/dmabupt/orgs","repos_url":"https://api.github.com/users/dmabupt/repos","events_url":"https://api.github.com/users/dmabupt/events{/privacy}","received_events_url":"https://api.github.com/users/dmabupt/received_events","type":"User","site_admin":false},"repo":{"id":106221408,"name":"libuv","full_name":"dmabupt/libuv","owner":{"login":"dmabupt","id":7960821,"avatar_url":"https://avatars0.githubusercontent.com/u/7960821?v=4","gravatar_id":"","url":"https://api.github.com/users/dmabupt","html_url":"https://github.com/dmabupt","followers_url":"https://api.github.com/users/dmabupt/followers","following_url":"https://api.github.com/users/dmabupt/following{/other_user}","gists_url":"https://api.github.com/users/dmabupt/gists{/gist_id}","starred_url":"https://api.github.com/users/dmabupt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmabupt/subscriptions","organizations_url":"https://api.github.com/users/dmabupt/orgs","repos_url":"https://api.github.com/users/dmabupt/repos","events_url":"https://api.github.com/users/dmabupt/events{/privacy}","received_events_url":"https://api.github.com/users/dmabupt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmabupt/libuv","description":"Cross-platform asynchronous I/O","fork":true,"url":"https://api.github.com/repos/dmabupt/libuv","forks_url":"https://api.github.com/repos/dmabupt/libuv/forks","keys_url":"https://api.github.com/repos/dmabupt/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmabupt/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmabupt/libuv/teams","hooks_url":"https://api.github.com/repos/dmabupt/libuv/hooks","issue_events_url":"https://api.github.com/repos/dmabupt/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/dmabupt/libuv/events","assignees_url":"https://api.github.com/repos/dmabupt/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/dmabupt/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/dmabupt/libuv/tags","blobs_url":"https://api.github.com/repos/dmabupt/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmabupt/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmabupt/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmabupt/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmabupt/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/dmabupt/libuv/languages","stargazers_url":"https://api.github.com/repos/dmabupt/libuv/stargazers","contributors_url":"https://api.github.com/repos/dmabupt/libuv/contributors","subscribers_url":"https://api.github.com/repos/dmabupt/libuv/subscribers","subscription_url":"https://api.github.com/repos/dmabupt/libuv/subscription","commits_url":"https://api.github.com/repos/dmabupt/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmabupt/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmabupt/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmabupt/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmabupt/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/dmabupt/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmabupt/libuv/merges","archive_url":"https://api.github.com/repos/dmabupt/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmabupt/libuv/downloads","issues_url":"https://api.github.com/repos/dmabupt/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/dmabupt/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/dmabupt/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/dmabupt/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmabupt/libuv/labels{/name}","releases_url":"https://api.github.com/repos/dmabupt/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/dmabupt/libuv/deployments","created_at":"2017-10-09T00:53:01Z","updated_at":"2017-10-09T00:53:06Z","pushed_at":"2017-10-24T08:52:34Z","git_url":"git://github.com/dmabupt/libuv.git","ssh_url":"git@github.com:dmabupt/libuv.git","clone_url":"https://github.com/dmabupt/libuv.git","svn_url":"https://github.com/dmabupt/libuv","homepage":"http://libuv.org/","size":12230,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"libuv:v1.x","ref":"v1.x","sha":"719dfecf95b0c74af6494f05049e56d5771ebfae","user":{"login":"libuv","id":4030929,"avatar_url":"https://avatars1.githubusercontent.com/u/4030929?v=4","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"repo":{"id":14812739,"name":"libuv","full_name":"libuv/libuv","owner":{"login":"libuv","id":4030929,"avatar_url":"https://avatars1.githubusercontent.com/u/4030929?v=4","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libuv/libuv","description":"Cross-platform asynchronous I/O","fork":false,"url":"https://api.github.com/repos/libuv/libuv","forks_url":"https://api.github.com/repos/libuv/libuv/forks","keys_url":"https://api.github.com/repos/libuv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libuv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libuv/libuv/teams","hooks_url":"https://api.github.com/repos/libuv/libuv/hooks","issue_events_url":"https://api.github.com/repos/libuv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/libuv/libuv/events","assignees_url":"https://api.github.com/repos/libuv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/libuv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/libuv/libuv/tags","blobs_url":"https://api.github.com/repos/libuv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libuv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libuv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/libuv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/libuv/libuv/languages","stargazers_url":"https://api.github.com/repos/libuv/libuv/stargazers","contributors_url":"https://api.github.com/repos/libuv/libuv/contributors","subscribers_url":"https://api.github.com/repos/libuv/libuv/subscribers","subscription_url":"https://api.github.com/repos/libuv/libuv/subscription","commits_url":"https://api.github.com/repos/libuv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/libuv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/libuv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/libuv/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/libuv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/libuv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libuv/libuv/merges","archive_url":"https://api.github.com/repos/libuv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libuv/libuv/downloads","issues_url":"https://api.github.com/repos/libuv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/libuv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/libuv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/libuv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libuv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/libuv/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/libuv/libuv/deployments","created_at":"2013-11-30T00:29:56Z","updated_at":"2017-10-24T12:13:36Z","pushed_at":"2017-10-24T08:52:37Z","git_url":"git://github.com/libuv/libuv.git","ssh_url":"git@github.com:libuv/libuv.git","clone_url":"https://github.com/libuv/libuv.git","svn_url":"https://github.com/libuv/libuv","homepage":"http://libuv.org/","size":12224,"stargazers_count":7637,"watchers_count":7637,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1290,"mirror_url":null,"archived":false,"open_issues_count":169,"forks":1290,"open_issues":169,"watchers":7637,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1601"},"html":{"href":"https://github.com/libuv/libuv/pull/1601"},"issue":{"href":"https://api.github.com/repos/libuv/libuv/issues/1601"},"comments":{"href":"https://api.github.com/repos/libuv/libuv/issues/1601/comments"},"review_comments":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1601/comments"},"review_comment":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1601/commits"},"statuses":{"href":"https://api.github.com/repos/libuv/libuv/statuses/6c24d137e3f25130b92fb491d8b200dafb5ada51"}},"author_association":"NONE"}}
{"actor":{"display_login":"jBarz"}}