{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/151781716","pull_request_review_id":77551726,"id":151781716,"diff_hunk":"@@ -217,29 +230,38 @@ Network::FilterStatus TcpProxy::initializeUpstreamConnection() {\n       config_->stats().downstream_cx_no_route_.inc();\n     }\n     request_info_.setResponseFlag(AccessLog::ResponseFlag::NoRouteFound);\n-    onInitFailure();\n+    onInitFailure(Http::Code::ServiceUnavailable);","path":"source/common/filter/tcp_proxy.cc","position":null,"original_position":64,"commit_id":"8a642f073a30c5f5f5034b0d13cd99519d7d6925","original_commit_id":"898b327894b9e6878c638b3e422b4b745b8129ee","user":{"login":"ggreenway","id":8603643,"avatar_url":"https://avatars2.githubusercontent.com/u/8603643?v=4","gravatar_id":"","url":"https://api.github.com/users/ggreenway","html_url":"https://github.com/ggreenway","followers_url":"https://api.github.com/users/ggreenway/followers","following_url":"https://api.github.com/users/ggreenway/following{/other_user}","gists_url":"https://api.github.com/users/ggreenway/gists{/gist_id}","starred_url":"https://api.github.com/users/ggreenway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggreenway/subscriptions","organizations_url":"https://api.github.com/users/ggreenway/orgs","repos_url":"https://api.github.com/users/ggreenway/repos","events_url":"https://api.github.com/users/ggreenway/events{/privacy}","received_events_url":"https://api.github.com/users/ggreenway/received_events","type":"User","site_admin":false},"body":"Yes, I'll do that.  Hopefully I'll have a PR the week after thanksgiving.","created_at":"2017-11-17T20:24:59Z","updated_at":"2017-11-17T20:24:59Z","html_url":"https://github.com/envoyproxy/envoy/pull/2076#discussion_r151781716","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/151781716"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2076#discussion_r151781716"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076"}},"in_reply_to_id":151761260},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076","id":153187846,"html_url":"https://github.com/envoyproxy/envoy/pull/2076","diff_url":"https://github.com/envoyproxy/envoy/pull/2076.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2076.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2076","number":2076,"state":"open","locked":false,"title":"TcpProxy: Add configurable connect retries","user":{"login":"ggreenway","id":8603643,"avatar_url":"https://avatars2.githubusercontent.com/u/8603643?v=4","gravatar_id":"","url":"https://api.github.com/users/ggreenway","html_url":"https://github.com/ggreenway","followers_url":"https://api.github.com/users/ggreenway/followers","following_url":"https://api.github.com/users/ggreenway/following{/other_user}","gists_url":"https://api.github.com/users/ggreenway/gists{/gist_id}","starred_url":"https://api.github.com/users/ggreenway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggreenway/subscriptions","organizations_url":"https://api.github.com/users/ggreenway/orgs","repos_url":"https://api.github.com/users/ggreenway/repos","events_url":"https://api.github.com/users/ggreenway/events{/privacy}","received_events_url":"https://api.github.com/users/ggreenway/received_events","type":"User","site_admin":false},"body":"If the TcpProxy fails to connect to an upstream, retry with a new LB pick, up to a configurable number of times.\r\n\r\n*API Changes*: https://github.com/envoyproxy/data-plane-api/pull/248\r\n\r\n*Risk Level*: Medium\r\n\r\n*Testing*: Unit\r\n","created_at":"2017-11-17T00:38:04Z","updated_at":"2017-11-17T20:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5056a51efca4535d3f5386ab346d0f975079f8f4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2076/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/8a642f073a30c5f5f5034b0d13cd99519d7d6925","head":{"label":"ggreenway:tcp-proxy-connect-attempts","ref":"tcp-proxy-connect-attempts","sha":"8a642f073a30c5f5f5034b0d13cd99519d7d6925","user":{"login":"ggreenway","id":8603643,"avatar_url":"https://avatars2.githubusercontent.com/u/8603643?v=4","gravatar_id":"","url":"https://api.github.com/users/ggreenway","html_url":"https://github.com/ggreenway","followers_url":"https://api.github.com/users/ggreenway/followers","following_url":"https://api.github.com/users/ggreenway/following{/other_user}","gists_url":"https://api.github.com/users/ggreenway/gists{/gist_id}","starred_url":"https://api.github.com/users/ggreenway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggreenway/subscriptions","organizations_url":"https://api.github.com/users/ggreenway/orgs","repos_url":"https://api.github.com/users/ggreenway/repos","events_url":"https://api.github.com/users/ggreenway/events{/privacy}","received_events_url":"https://api.github.com/users/ggreenway/received_events","type":"User","site_admin":false},"repo":{"id":104403571,"name":"envoy","full_name":"ggreenway/envoy","owner":{"login":"ggreenway","id":8603643,"avatar_url":"https://avatars2.githubusercontent.com/u/8603643?v=4","gravatar_id":"","url":"https://api.github.com/users/ggreenway","html_url":"https://github.com/ggreenway","followers_url":"https://api.github.com/users/ggreenway/followers","following_url":"https://api.github.com/users/ggreenway/following{/other_user}","gists_url":"https://api.github.com/users/ggreenway/gists{/gist_id}","starred_url":"https://api.github.com/users/ggreenway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggreenway/subscriptions","organizations_url":"https://api.github.com/users/ggreenway/orgs","repos_url":"https://api.github.com/users/ggreenway/repos","events_url":"https://api.github.com/users/ggreenway/events{/privacy}","received_events_url":"https://api.github.com/users/ggreenway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggreenway/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/ggreenway/envoy","forks_url":"https://api.github.com/repos/ggreenway/envoy/forks","keys_url":"https://api.github.com/repos/ggreenway/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggreenway/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggreenway/envoy/teams","hooks_url":"https://api.github.com/repos/ggreenway/envoy/hooks","issue_events_url":"https://api.github.com/repos/ggreenway/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/ggreenway/envoy/events","assignees_url":"https://api.github.com/repos/ggreenway/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/ggreenway/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/ggreenway/envoy/tags","blobs_url":"https://api.github.com/repos/ggreenway/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggreenway/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggreenway/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggreenway/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggreenway/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/ggreenway/envoy/languages","stargazers_url":"https://api.github.com/repos/ggreenway/envoy/stargazers","contributors_url":"https://api.github.com/repos/ggreenway/envoy/contributors","subscribers_url":"https://api.github.com/repos/ggreenway/envoy/subscribers","subscription_url":"https://api.github.com/repos/ggreenway/envoy/subscription","commits_url":"https://api.github.com/repos/ggreenway/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggreenway/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggreenway/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggreenway/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggreenway/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/ggreenway/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggreenway/envoy/merges","archive_url":"https://api.github.com/repos/ggreenway/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggreenway/envoy/downloads","issues_url":"https://api.github.com/repos/ggreenway/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/ggreenway/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/ggreenway/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/ggreenway/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggreenway/envoy/labels{/name}","releases_url":"https://api.github.com/repos/ggreenway/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/ggreenway/envoy/deployments","created_at":"2017-09-21T22:07:38Z","updated_at":"2017-09-21T22:07:42Z","pushed_at":"2017-11-17T20:01:45Z","git_url":"git://github.com/ggreenway/envoy.git","ssh_url":"git@github.com:ggreenway/envoy.git","clone_url":"https://github.com/ggreenway/envoy.git","svn_url":"https://github.com/ggreenway/envoy","homepage":"https://envoyproxy.github.io/","size":45606,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"8cc2ac9fc6bf87428f22b98471606bfdafb2bf26","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2017-11-17T18:09:20Z","pushed_at":"2017-11-17T20:01:47Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://envoyproxy.github.io/","size":50688,"stargazers_count":2997,"watchers_count":2997,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":345,"mirror_url":null,"archived":false,"open_issues_count":182,"forks":345,"open_issues":182,"watchers":2997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2076"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2076"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2076/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2076/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/8a642f073a30c5f5f5034b0d13cd99519d7d6925"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ggreenway"}}