{"action":"created","issue":{"url":"https://api.github.com/repos/mikelangelo-project/capstan/issues/48","repository_url":"https://api.github.com/repos/mikelangelo-project/capstan","labels_url":"https://api.github.com/repos/mikelangelo-project/capstan/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/mikelangelo-project/capstan/issues/48/comments","events_url":"https://api.github.com/repos/mikelangelo-project/capstan/issues/48/events","html_url":"https://github.com/mikelangelo-project/capstan/pull/48","id":251254438,"number":48,"title":"Rewrite Java runtime to make use of config_set inheritance","user":{"login":"miha-plesko","id":8102426,"avatar_url":"https://avatars1.githubusercontent.com/u/8102426?v=4","gravatar_id":"","url":"https://api.github.com/users/miha-plesko","html_url":"https://github.com/miha-plesko","followers_url":"https://api.github.com/users/miha-plesko/followers","following_url":"https://api.github.com/users/miha-plesko/following{/other_user}","gists_url":"https://api.github.com/users/miha-plesko/gists{/gist_id}","starred_url":"https://api.github.com/users/miha-plesko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miha-plesko/subscriptions","organizations_url":"https://api.github.com/users/miha-plesko/orgs","repos_url":"https://api.github.com/users/miha-plesko/repos","events_url":"https://api.github.com/users/miha-plesko/events{/privacy}","received_events_url":"https://api.github.com/users/miha-plesko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"gberginc","id":1437960,"avatar_url":"https://avatars3.githubusercontent.com/u/1437960?v=4","gravatar_id":"","url":"https://api.github.com/users/gberginc","html_url":"https://github.com/gberginc","followers_url":"https://api.github.com/users/gberginc/followers","following_url":"https://api.github.com/users/gberginc/following{/other_user}","gists_url":"https://api.github.com/users/gberginc/gists{/gist_id}","starred_url":"https://api.github.com/users/gberginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberginc/subscriptions","organizations_url":"https://api.github.com/users/gberginc/orgs","repos_url":"https://api.github.com/users/gberginc/repos","events_url":"https://api.github.com/users/gberginc/events{/privacy}","received_events_url":"https://api.github.com/users/gberginc/received_events","type":"User","site_admin":false},"assignees":[{"login":"gberginc","id":1437960,"avatar_url":"https://avatars3.githubusercontent.com/u/1437960?v=4","gravatar_id":"","url":"https://api.github.com/users/gberginc","html_url":"https://github.com/gberginc","followers_url":"https://api.github.com/users/gberginc/followers","following_url":"https://api.github.com/users/gberginc/following{/other_user}","gists_url":"https://api.github.com/users/gberginc/gists{/gist_id}","starred_url":"https://api.github.com/users/gberginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberginc/subscriptions","organizations_url":"https://api.github.com/users/gberginc/orgs","repos_url":"https://api.github.com/users/gberginc/repos","events_url":"https://api.github.com/users/gberginc/events{/privacy}","received_events_url":"https://api.github.com/users/gberginc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-08-18T14:01:00Z","updated_at":"2017-08-29T05:08:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mikelangelo-project/capstan/pulls/48","html_url":"https://github.com/mikelangelo-project/capstan/pull/48","diff_url":"https://github.com/mikelangelo-project/capstan/pull/48.diff","patch_url":"https://github.com/mikelangelo-project/capstan/pull/48.patch"},"body":"Current Java runtime is implemented in a very old fashion that relies on /etc/javamains file be present on the unikernel. Since this is now obsolete and brings issues since bootcmd cannot be set after the unikernel is built, we rewrite the runtime.\r\n\r\nWith this commit we first get rid of the problematic OnCollect function that was creating /etc/javamains file. With openjdk8-zulu-compact1 package the javamains is no longer needed. Then we reimplement the GetBootCmd function that now doesn't build the actual bootcmd on its own anymore but rather makes use of bootcmd provided by openjdk8-zulu-compact1 package (bootcmd inheritance). We also ensure that list of available arguments of \"runtime: java\" matches those of openjdk8-zulu-compact1 meta/run.yaml.\r\n\r\nSo with this commit we actually transform runtime into a thin wrapper of a specific package. User could easily use package directly, but the wrapper offers him some validation and nicer format of arguments."},"comment":{"url":"https://api.github.com/repos/mikelangelo-project/capstan/issues/comments/325556533","html_url":"https://github.com/mikelangelo-project/capstan/pull/48#issuecomment-325556533","issue_url":"https://api.github.com/repos/mikelangelo-project/capstan/issues/48","id":325556533,"user":{"login":"gberginc","id":1437960,"avatar_url":"https://avatars3.githubusercontent.com/u/1437960?v=4","gravatar_id":"","url":"https://api.github.com/users/gberginc","html_url":"https://github.com/gberginc","followers_url":"https://api.github.com/users/gberginc/followers","following_url":"https://api.github.com/users/gberginc/following{/other_user}","gists_url":"https://api.github.com/users/gberginc/gists{/gist_id}","starred_url":"https://api.github.com/users/gberginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberginc/subscriptions","organizations_url":"https://api.github.com/users/gberginc/orgs","repos_url":"https://api.github.com/users/gberginc/repos","events_url":"https://api.github.com/users/gberginc/events{/privacy}","received_events_url":"https://api.github.com/users/gberginc/received_events","type":"User","site_admin":false},"created_at":"2017-08-29T05:08:09Z","updated_at":"2017-08-29T05:08:09Z","body":"@miha-plesko can you let me know what is the status of this PR? Do you plan to have a separate PR for adding dependency based on the chosen configuration the user is extending?"}}
{"actor":{"display_login":"gberginc"}}