{"action":"created","comment":{"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments/132809781","pull_request_review_id":55935875,"id":132809781,"diff_hunk":"@@ -210,16 +212,17 @@ private void parseAndPersistFile(final UploadInformation the_info) {\n     if (the_info.my_ok) {\n       try (InputStream cvr_is = new FileInputStream(the_info.my_file)) {\n         final InputStreamReader cvr_isr = new InputStreamReader(cvr_is, \"UTF-8\");\n-        final CVRExportParser parser = new DominionCVRExportParser(cvr_isr, county, \n-                                                                   the_info.my_timestamp);\n+        final CVRExportParser parser =\n+            new DominionCVRExportParser(cvr_isr, county, the_info.my_timestamp);\n         if (parser.parse()) {\n-          Main.LOGGER.info(parser.parsedIDs().size() + \" CVRs parsed from \" + county + \n+          Main.LOGGER.info(parser.parsedIDs().size() + \" CVRs parsed from \" + county +\n                            \" county upload file\");\n           final OptionalLong count = count();\n           if (count.isPresent()) {\n             Main.LOGGER.info(count.getAsLong() + \" uploaded CVRs in storage\");\n           }\n-          attemptFilePersistence(the_info.my_file, county, hash, the_info.my_timestamp);\n+          attemptFilePersistence(the_response, the_info.my_file, county, hash,","path":"server/eclipse-project/src/main/java/us/freeandfair/corla/endpoint/CVRExportUpload.java","position":190,"original_position":190,"commit_id":"bf0f965d96044a50141ff30c1c07869ba52ab664","original_commit_id":"213d7a7e7f00f3b4a2c7eb842bc9174f9edacf85","user":{"login":"kiniry","id":478911,"avatar_url":"https://avatars3.githubusercontent.com/u/478911?v=4","gravatar_id":"","url":"https://api.github.com/users/kiniry","html_url":"https://github.com/kiniry","followers_url":"https://api.github.com/users/kiniry/followers","following_url":"https://api.github.com/users/kiniry/following{/other_user}","gists_url":"https://api.github.com/users/kiniry/gists{/gist_id}","starred_url":"https://api.github.com/users/kiniry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiniry/subscriptions","organizations_url":"https://api.github.com/users/kiniry/orgs","repos_url":"https://api.github.com/users/kiniry/repos","events_url":"https://api.github.com/users/kiniry/events{/privacy}","received_events_url":"https://api.github.com/users/kiniry/received_events","type":"User","site_admin":false},"body":"Would it be abusive to simply return HTTP error codes?  My problem is that this particular helper method actually has four exceptional behaviors...","created_at":"2017-08-12T04:52:05Z","updated_at":"2017-08-12T04:52:05Z","html_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/218#discussion_r132809781","pull_request_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments/132809781"},"html":{"href":"https://github.com/FreeAndFair/ColoradoRLA/pull/218#discussion_r132809781"},"pull_request":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218","id":135419349,"html_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/218","diff_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/218.diff","patch_url":"https://github.com/FreeAndFair/ColoradoRLA/pull/218.patch","issue_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/218","number":218,"state":"open","locked":false,"title":"ASM precondition filter","user":{"login":"kiniry","id":478911,"avatar_url":"https://avatars3.githubusercontent.com/u/478911?v=4","gravatar_id":"","url":"https://api.github.com/users/kiniry","html_url":"https://github.com/kiniry","followers_url":"https://api.github.com/users/kiniry/followers","following_url":"https://api.github.com/users/kiniry/following{/other_user}","gists_url":"https://api.github.com/users/kiniry/gists{/gist_id}","starred_url":"https://api.github.com/users/kiniry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiniry/subscriptions","organizations_url":"https://api.github.com/users/kiniry/orgs","repos_url":"https://api.github.com/users/kiniry/repos","events_url":"https://api.github.com/users/kiniry/events{/privacy}","received_events_url":"https://api.github.com/users/kiniry/received_events","type":"User","site_admin":false},"body":"This filter and a bunch of other code to simplify exceptional behavior handling are added through the introduction of a new base class for endpoints, `AbstractEndpoint`.","created_at":"2017-08-11T21:07:07Z","updated_at":"2017-08-12T04:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d50af8a7221655223dd6b997db468bc76783419a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones/1","html_url":"https://github.com/FreeAndFair/ColoradoRLA/milestone/1","labels_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones/1/labels","id":2648558,"number":1,"title":"phase-1","description":"Initial implementation of CORLA system.","creator":{"login":"ranweiler","id":515835,"avatar_url":"https://avatars1.githubusercontent.com/u/515835?v=4","gravatar_id":"","url":"https://api.github.com/users/ranweiler","html_url":"https://github.com/ranweiler","followers_url":"https://api.github.com/users/ranweiler/followers","following_url":"https://api.github.com/users/ranweiler/following{/other_user}","gists_url":"https://api.github.com/users/ranweiler/gists{/gist_id}","starred_url":"https://api.github.com/users/ranweiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranweiler/subscriptions","organizations_url":"https://api.github.com/users/ranweiler/orgs","repos_url":"https://api.github.com/users/ranweiler/repos","events_url":"https://api.github.com/users/ranweiler/events{/privacy}","received_events_url":"https://api.github.com/users/ranweiler/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":49,"state":"open","created_at":"2017-07-18T21:22:53Z","updated_at":"2017-08-12T04:16:51Z","due_on":"2017-08-13T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218/commits","review_comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218/comments","review_comment_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/218/comments","statuses_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/bf0f965d96044a50141ff30c1c07869ba52ab664","head":{"label":"FreeAndFair:asm-precondition-filter","ref":"asm-precondition-filter","sha":"bf0f965d96044a50141ff30c1c07869ba52ab664","user":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"repo":{"id":95474825,"name":"ColoradoRLA","full_name":"FreeAndFair/ColoradoRLA","owner":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeAndFair/ColoradoRLA","description":"Software to facilitate risk-limiting audits at the state level, developed for the state of Colorado.","fork":false,"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA","forks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/forks","keys_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/teams","hooks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/hooks","issue_events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/events{/number}","events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/events","assignees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/assignees{/user}","branches_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/branches{/branch}","tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/tags","blobs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/languages","stargazers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/stargazers","contributors_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contributors","subscribers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscribers","subscription_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscription","commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contents/{+path}","compare_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/merges","archive_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/downloads","issues_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues{/number}","pulls_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/labels{/name}","releases_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/releases{/id}","deployments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/deployments","created_at":"2017-06-26T18:05:40Z","updated_at":"2017-07-28T17:32:24Z","pushed_at":"2017-08-12T04:16:51Z","git_url":"git://github.com/FreeAndFair/ColoradoRLA.git","ssh_url":"git@github.com:FreeAndFair/ColoradoRLA.git","clone_url":"https://github.com/FreeAndFair/ColoradoRLA.git","svn_url":"https://github.com/FreeAndFair/ColoradoRLA","homepage":null,"size":20977,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":5,"default_branch":"master"}},"base":{"label":"FreeAndFair:master","ref":"master","sha":"54a95d4b16b5b19f294a30f2c8f16f7a9d8f4ddb","user":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"repo":{"id":95474825,"name":"ColoradoRLA","full_name":"FreeAndFair/ColoradoRLA","owner":{"login":"FreeAndFair","id":17015775,"avatar_url":"https://avatars1.githubusercontent.com/u/17015775?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeAndFair","html_url":"https://github.com/FreeAndFair","followers_url":"https://api.github.com/users/FreeAndFair/followers","following_url":"https://api.github.com/users/FreeAndFair/following{/other_user}","gists_url":"https://api.github.com/users/FreeAndFair/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeAndFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeAndFair/subscriptions","organizations_url":"https://api.github.com/users/FreeAndFair/orgs","repos_url":"https://api.github.com/users/FreeAndFair/repos","events_url":"https://api.github.com/users/FreeAndFair/events{/privacy}","received_events_url":"https://api.github.com/users/FreeAndFair/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeAndFair/ColoradoRLA","description":"Software to facilitate risk-limiting audits at the state level, developed for the state of Colorado.","fork":false,"url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA","forks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/forks","keys_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/teams","hooks_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/hooks","issue_events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/events{/number}","events_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/events","assignees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/assignees{/user}","branches_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/branches{/branch}","tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/tags","blobs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/languages","stargazers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/stargazers","contributors_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contributors","subscribers_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscribers","subscription_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/subscription","commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/contents/{+path}","compare_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/merges","archive_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/downloads","issues_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues{/number}","pulls_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/labels{/name}","releases_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/releases{/id}","deployments_url":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/deployments","created_at":"2017-06-26T18:05:40Z","updated_at":"2017-07-28T17:32:24Z","pushed_at":"2017-08-12T04:16:51Z","git_url":"git://github.com/FreeAndFair/ColoradoRLA.git","ssh_url":"git@github.com:FreeAndFair/ColoradoRLA.git","clone_url":"https://github.com/FreeAndFair/ColoradoRLA.git","svn_url":"https://github.com/FreeAndFair/ColoradoRLA","homepage":null,"size":20977,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218"},"html":{"href":"https://github.com/FreeAndFair/ColoradoRLA/pull/218"},"issue":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/218"},"comments":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/FreeAndFair/ColoradoRLA/statuses/bf0f965d96044a50141ff30c1c07869ba52ab664"}}}}
{"actor":{"display_login":"kiniry"}}