{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/msf4j/pulls/comments/105151473","pull_request_review_id":26016238,"id":105151473,"diff_hunk":"@@ -167,7 +256,275 @@ public void setTransportSender(TransportSender transportSender) {\n     }\n \n     @Override\n+    public void setClientConnector(ClientConnector clientConnector) {\n+    }\n+\n+    @Override\n     public String getId() {\n         return MSF4J_MSG_PROC_ID;\n     }\n+\n+\n+    /*\n+    Handle WebSocket handshake\n+     */\n+    private boolean handleWebSocketHandshake(CarbonMessage carbonMessage, Session session)\n+            throws WebSocketEndpointAnnotationException {\n+        EndpointsRegistryImpl endpointsRegistry = EndpointsRegistryImpl.getInstance();\n+            PatternPathRouter.RoutableDestination<Object>\n+                    routableEndpoint = endpointsRegistry.getRoutableEndpoint(carbonMessage);\n+        try {\n+            //If endpoint cannot be found close the connection\n+            if (routableEndpoint == null) {\n+                throw new IllegalStateException(\"Cannot find the URI for the endpoint\");\n+            }\n+\n+            Method method = new EndpointDispatcher().getOnOpenMethod(routableEndpoint.getDestination());\n+            List<Object> parameterList = new LinkedList<>();\n+            Map<String, String> paramValues = routableEndpoint.getGroupNameValues();\n+            Arrays.stream(method.getParameters()).forEach(\n+                    parameter -> {\n+                        if (parameter.getType() == Session.class) {\n+                            parameterList.add(session);\n+                        } else if (parameter.getType() == String.class) {\n+                            PathParam pathParam = parameter.getAnnotation(PathParam.class);\n+                            if (pathParam != null) {\n+                                parameterList.add(paramValues.get(pathParam.value()));\n+                            } else {\n+                                throw new IllegalArgumentException(\"String parameters without\" +\n+                                                                                 \" @PathParam annotation\");\n+                            }\n+                        } else {\n+                            parameterList.add(null);","path":"core/src/main/java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java","position":221,"original_position":221,"commit_id":"e98a7d54f4e6c8758188afdae044175f57b4d245","original_commit_id":"e98a7d54f4e6c8758188afdae044175f57b4d245","user":{"login":"irunika","id":9251082,"avatar_url":"https://avatars0.githubusercontent.com/u/9251082?v=3","gravatar_id":"","url":"https://api.github.com/users/irunika","html_url":"https://github.com/irunika","followers_url":"https://api.github.com/users/irunika/followers","following_url":"https://api.github.com/users/irunika/following{/other_user}","gists_url":"https://api.github.com/users/irunika/gists{/gist_id}","starred_url":"https://api.github.com/users/irunika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irunika/subscriptions","organizations_url":"https://api.github.com/users/irunika/orgs","repos_url":"https://api.github.com/users/irunika/repos","events_url":"https://api.github.com/users/irunika/events{/privacy}","received_events_url":"https://api.github.com/users/irunika/received_events","type":"User","site_admin":false},"body":"I tried it when we do it it gives us\r\n**java.lang.IllegalArgumentException: argument type mismatch**","created_at":"2017-03-09T12:27:21Z","updated_at":"2017-03-09T12:27:21Z","html_url":"https://github.com/wso2/msf4j/pull/364#discussion_r105151473","pull_request_url":"https://api.github.com/repos/wso2/msf4j/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/wso2/msf4j/pulls/comments/105151473"},"html":{"href":"https://github.com/wso2/msf4j/pull/364#discussion_r105151473"},"pull_request":{"href":"https://api.github.com/repos/wso2/msf4j/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/msf4j/pulls/364","id":109687556,"html_url":"https://github.com/wso2/msf4j/pull/364","diff_url":"https://github.com/wso2/msf4j/pull/364.diff","patch_url":"https://github.com/wso2/msf4j/pull/364.patch","issue_url":"https://api.github.com/repos/wso2/msf4j/issues/364","number":364,"state":"open","locked":false,"title":"Websocket support for MSF4J","user":{"login":"irunika","id":9251082,"avatar_url":"https://avatars0.githubusercontent.com/u/9251082?v=3","gravatar_id":"","url":"https://api.github.com/users/irunika","html_url":"https://github.com/irunika","followers_url":"https://api.github.com/users/irunika/followers","following_url":"https://api.github.com/users/irunika/following{/other_user}","gists_url":"https://api.github.com/users/irunika/gists{/gist_id}","starred_url":"https://api.github.com/users/irunika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irunika/subscriptions","organizations_url":"https://api.github.com/users/irunika/orgs","repos_url":"https://api.github.com/users/irunika/repos","events_url":"https://api.github.com/users/irunika/events{/privacy}","received_events_url":"https://api.github.com/users/irunika/received_events","type":"User","site_admin":false},"body":"This includes the basic implementation of WebSocket for MSF4J\r\nresolves #272","created_at":"2017-03-08T12:40:16Z","updated_at":"2017-03-09T12:27:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e35390b4070c89e0edcbae54f5610ab21d9ec1ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/msf4j/pulls/364/commits","review_comments_url":"https://api.github.com/repos/wso2/msf4j/pulls/364/comments","review_comment_url":"https://api.github.com/repos/wso2/msf4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/msf4j/issues/364/comments","statuses_url":"https://api.github.com/repos/wso2/msf4j/statuses/e98a7d54f4e6c8758188afdae044175f57b4d245","head":{"label":"irunika:websocket-support","ref":"websocket-support","sha":"e98a7d54f4e6c8758188afdae044175f57b4d245","user":{"login":"irunika","id":9251082,"avatar_url":"https://avatars0.githubusercontent.com/u/9251082?v=3","gravatar_id":"","url":"https://api.github.com/users/irunika","html_url":"https://github.com/irunika","followers_url":"https://api.github.com/users/irunika/followers","following_url":"https://api.github.com/users/irunika/following{/other_user}","gists_url":"https://api.github.com/users/irunika/gists{/gist_id}","starred_url":"https://api.github.com/users/irunika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irunika/subscriptions","organizations_url":"https://api.github.com/users/irunika/orgs","repos_url":"https://api.github.com/users/irunika/repos","events_url":"https://api.github.com/users/irunika/events{/privacy}","received_events_url":"https://api.github.com/users/irunika/received_events","type":"User","site_admin":false},"repo":{"id":74013349,"name":"msf4j","full_name":"irunika/msf4j","owner":{"login":"irunika","id":9251082,"avatar_url":"https://avatars0.githubusercontent.com/u/9251082?v=3","gravatar_id":"","url":"https://api.github.com/users/irunika","html_url":"https://github.com/irunika","followers_url":"https://api.github.com/users/irunika/followers","following_url":"https://api.github.com/users/irunika/following{/other_user}","gists_url":"https://api.github.com/users/irunika/gists{/gist_id}","starred_url":"https://api.github.com/users/irunika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irunika/subscriptions","organizations_url":"https://api.github.com/users/irunika/orgs","repos_url":"https://api.github.com/users/irunika/repos","events_url":"https://api.github.com/users/irunika/events{/privacy}","received_events_url":"https://api.github.com/users/irunika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/irunika/msf4j","description":"WSO2 Microservices Framework for Java (MSF4J)","fork":true,"url":"https://api.github.com/repos/irunika/msf4j","forks_url":"https://api.github.com/repos/irunika/msf4j/forks","keys_url":"https://api.github.com/repos/irunika/msf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irunika/msf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irunika/msf4j/teams","hooks_url":"https://api.github.com/repos/irunika/msf4j/hooks","issue_events_url":"https://api.github.com/repos/irunika/msf4j/issues/events{/number}","events_url":"https://api.github.com/repos/irunika/msf4j/events","assignees_url":"https://api.github.com/repos/irunika/msf4j/assignees{/user}","branches_url":"https://api.github.com/repos/irunika/msf4j/branches{/branch}","tags_url":"https://api.github.com/repos/irunika/msf4j/tags","blobs_url":"https://api.github.com/repos/irunika/msf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irunika/msf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irunika/msf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/irunika/msf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irunika/msf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/irunika/msf4j/languages","stargazers_url":"https://api.github.com/repos/irunika/msf4j/stargazers","contributors_url":"https://api.github.com/repos/irunika/msf4j/contributors","subscribers_url":"https://api.github.com/repos/irunika/msf4j/subscribers","subscription_url":"https://api.github.com/repos/irunika/msf4j/subscription","commits_url":"https://api.github.com/repos/irunika/msf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/irunika/msf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/irunika/msf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/irunika/msf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/irunika/msf4j/contents/{+path}","compare_url":"https://api.github.com/repos/irunika/msf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irunika/msf4j/merges","archive_url":"https://api.github.com/repos/irunika/msf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irunika/msf4j/downloads","issues_url":"https://api.github.com/repos/irunika/msf4j/issues{/number}","pulls_url":"https://api.github.com/repos/irunika/msf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/irunika/msf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/irunika/msf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irunika/msf4j/labels{/name}","releases_url":"https://api.github.com/repos/irunika/msf4j/releases{/id}","deployments_url":"https://api.github.com/repos/irunika/msf4j/deployments","created_at":"2016-11-17T09:51:20Z","updated_at":"2016-11-17T09:51:23Z","pushed_at":"2017-03-08T17:57:47Z","git_url":"git://github.com/irunika/msf4j.git","ssh_url":"git@github.com:irunika/msf4j.git","clone_url":"https://github.com/irunika/msf4j.git","svn_url":"https://github.com/irunika/msf4j","homepage":"http://wso2.com/products/microservices-framework-for-java/","size":31621,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:msf4j-with-new-transport","ref":"msf4j-with-new-transport","sha":"8a85960a6bda46b5304d3e44d5dc1cea838a68bf","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars0.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":42847560,"name":"msf4j","full_name":"wso2/msf4j","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars0.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/msf4j","description":"WSO2 Microservices Framework for Java (MSF4J)","fork":false,"url":"https://api.github.com/repos/wso2/msf4j","forks_url":"https://api.github.com/repos/wso2/msf4j/forks","keys_url":"https://api.github.com/repos/wso2/msf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/msf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/msf4j/teams","hooks_url":"https://api.github.com/repos/wso2/msf4j/hooks","issue_events_url":"https://api.github.com/repos/wso2/msf4j/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/msf4j/events","assignees_url":"https://api.github.com/repos/wso2/msf4j/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/msf4j/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/msf4j/tags","blobs_url":"https://api.github.com/repos/wso2/msf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/msf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/msf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/msf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/msf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/msf4j/languages","stargazers_url":"https://api.github.com/repos/wso2/msf4j/stargazers","contributors_url":"https://api.github.com/repos/wso2/msf4j/contributors","subscribers_url":"https://api.github.com/repos/wso2/msf4j/subscribers","subscription_url":"https://api.github.com/repos/wso2/msf4j/subscription","commits_url":"https://api.github.com/repos/wso2/msf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/msf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/msf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/msf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/msf4j/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/msf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/msf4j/merges","archive_url":"https://api.github.com/repos/wso2/msf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/msf4j/downloads","issues_url":"https://api.github.com/repos/wso2/msf4j/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/msf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/msf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/msf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/msf4j/labels{/name}","releases_url":"https://api.github.com/repos/wso2/msf4j/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/msf4j/deployments","created_at":"2015-09-21T06:19:29Z","updated_at":"2017-03-09T05:14:07Z","pushed_at":"2017-03-08T17:57:49Z","git_url":"git://github.com/wso2/msf4j.git","ssh_url":"git@github.com:wso2/msf4j.git","clone_url":"https://github.com/wso2/msf4j.git","svn_url":"https://github.com/wso2/msf4j","homepage":"http://wso2.com/products/microservices-framework-for-java/","size":31441,"stargazers_count":191,"watchers_count":191,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":33,"forks":180,"open_issues":33,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/msf4j/pulls/364"},"html":{"href":"https://github.com/wso2/msf4j/pull/364"},"issue":{"href":"https://api.github.com/repos/wso2/msf4j/issues/364"},"comments":{"href":"https://api.github.com/repos/wso2/msf4j/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/msf4j/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/msf4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/msf4j/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/msf4j/statuses/e98a7d54f4e6c8758188afdae044175f57b4d245"}}}}
{"actor":{"display_login":"irunika"}}