{"action":"created","issue":{"url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/113","repository_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2","labels_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/113/comments","events_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/113/events","html_url":"https://github.com/schrodinger/fixed-data-table-2/issues/113","id":203145948,"number":113,"title":"Browser zoom in / out does not work correctly when table has mouse context","user":{"login":"weaseliam","id":20503267,"avatar_url":"https://avatars.githubusercontent.com/u/20503267?v=3","gravatar_id":"","url":"https://api.github.com/users/weaseliam","html_url":"https://github.com/weaseliam","followers_url":"https://api.github.com/users/weaseliam/followers","following_url":"https://api.github.com/users/weaseliam/following{/other_user}","gists_url":"https://api.github.com/users/weaseliam/gists{/gist_id}","starred_url":"https://api.github.com/users/weaseliam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaseliam/subscriptions","organizations_url":"https://api.github.com/users/weaseliam/orgs","repos_url":"https://api.github.com/users/weaseliam/repos","events_url":"https://api.github.com/users/weaseliam/events{/privacy}","received_events_url":"https://api.github.com/users/weaseliam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"KamranAsif","id":2875524,"avatar_url":"https://avatars.githubusercontent.com/u/2875524?v=3","gravatar_id":"","url":"https://api.github.com/users/KamranAsif","html_url":"https://github.com/KamranAsif","followers_url":"https://api.github.com/users/KamranAsif/followers","following_url":"https://api.github.com/users/KamranAsif/following{/other_user}","gists_url":"https://api.github.com/users/KamranAsif/gists{/gist_id}","starred_url":"https://api.github.com/users/KamranAsif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KamranAsif/subscriptions","organizations_url":"https://api.github.com/users/KamranAsif/orgs","repos_url":"https://api.github.com/users/KamranAsif/repos","events_url":"https://api.github.com/users/KamranAsif/events{/privacy}","received_events_url":"https://api.github.com/users/KamranAsif/received_events","type":"User","site_admin":false},"assignees":[{"login":"KamranAsif","id":2875524,"avatar_url":"https://avatars.githubusercontent.com/u/2875524?v=3","gravatar_id":"","url":"https://api.github.com/users/KamranAsif","html_url":"https://github.com/KamranAsif","followers_url":"https://api.github.com/users/KamranAsif/followers","following_url":"https://api.github.com/users/KamranAsif/following{/other_user}","gists_url":"https://api.github.com/users/KamranAsif/gists{/gist_id}","starred_url":"https://api.github.com/users/KamranAsif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KamranAsif/subscriptions","organizations_url":"https://api.github.com/users/KamranAsif/orgs","repos_url":"https://api.github.com/users/KamranAsif/repos","events_url":"https://api.github.com/users/KamranAsif/events{/privacy}","received_events_url":"https://api.github.com/users/KamranAsif/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-01-25T16:08:45Z","updated_at":"2017-01-25T19:28:42Z","closed_at":null,"body":"## Current Behavior\r\nOn Ctrl + Mouse Wheel Up / Down, the table scrolls up / down.\r\nThe browser zooms in / out only when the table reaches on top / bottom.\r\n\r\n## Expected Behavior\r\nOn Ctrl + Mouse Wheel Up / Down, the browser should zoom in / out.\r\nThe table should not scroll on Ctrl + Mouse Wheel Up / Down.\r\n\r\n## Possible Solution\r\nI saw that in ReactWheelHandler.js::onWheel, an event.preventDefault() is called.\r\nWhen I commented it, the browser took into account the Ctrl + Mouse Wheel Up / Down.\r\nOf course when I changed the method to just return if Ctrl is pressed, otherwise leave the code as is, it worked as expected on all browsers.\r\n\r\n## Steps to Reproduce (for bugs)\r\n* The table should have many results so that the scrollbar appears\r\n* Scroll the table so that the scrollbar is at the half of it\r\n* Have the mouse cursor over the table\r\n* Press Ctrl + Mouse Wheel Up or Down\r\n* The table scrolls then when it reaches the top or bottom, the browser zooms in / out\r\n\r\n## Your Environment\r\n* Version used: 0.7.7, 0.7.10\r\n* Browser Name and version: Chrome 55.0.2883.75, Firefox 49.0.2, IE 11\r\n* Operating System and version (desktop or mobile): Windows 7\r\n"},"comment":{"url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/comments/275207864","html_url":"https://github.com/schrodinger/fixed-data-table-2/issues/113#issuecomment-275207864","issue_url":"https://api.github.com/repos/schrodinger/fixed-data-table-2/issues/113","id":275207864,"user":{"login":"weaseliam","id":20503267,"avatar_url":"https://avatars.githubusercontent.com/u/20503267?v=3","gravatar_id":"","url":"https://api.github.com/users/weaseliam","html_url":"https://github.com/weaseliam","followers_url":"https://api.github.com/users/weaseliam/followers","following_url":"https://api.github.com/users/weaseliam/following{/other_user}","gists_url":"https://api.github.com/users/weaseliam/gists{/gist_id}","starred_url":"https://api.github.com/users/weaseliam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaseliam/subscriptions","organizations_url":"https://api.github.com/users/weaseliam/orgs","repos_url":"https://api.github.com/users/weaseliam/repos","events_url":"https://api.github.com/users/weaseliam/events{/privacy}","received_events_url":"https://api.github.com/users/weaseliam/received_events","type":"User","site_admin":false},"created_at":"2017-01-25T19:28:42Z","updated_at":"2017-01-25T19:28:42Z","body":"Indeed after having a deeper look into fixed-data-table-code, not just the surface, I agree that passing the event as the last argument in ReactWheelHandler to _handleScrollX and _handleScrollY and doing the fix in _shouldHandleWheelX / _shouldHandleWheelY seems the way to go.\r\nIn fact I do not understand why didn't they pass it in the first place."}}
{"actor":{"display_login":"weaseliam"}}