{"action":"created","comment":{"url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments/146035823","pull_request_review_id":70922016,"id":146035823,"diff_hunk":"@@ -38,6 +38,18 @@ SHAREDIMAGEPATH = ../shared_image\n # VIC RUN PATH\n VICPATH = ../../vic_run\n \n+# VIC EXTENTIONS PATH\n+EXTPATH = ../../extensions\n+\n+# Set the routing model extension\n+# | Level      | Value                              |\n+# |----------  |---------------------------------   |\n+# | rout_stub  | Stub routing model (no routing)    |\n+# | rout_rvic  | Use RVIC routing scheme            |\n+ROUT=rout_stub","path":"vic/drivers/image/Makefile","position":12,"original_position":12,"commit_id":"90c6a682343cfc240648e7e1a74f3429ac7a9c8e","original_commit_id":"90c6a682343cfc240648e7e1a74f3429ac7a9c8e","user":{"login":"jhamman","id":2443309,"avatar_url":"https://avatars3.githubusercontent.com/u/2443309?v=4","gravatar_id":"","url":"https://api.github.com/users/jhamman","html_url":"https://github.com/jhamman","followers_url":"https://api.github.com/users/jhamman/followers","following_url":"https://api.github.com/users/jhamman/following{/other_user}","gists_url":"https://api.github.com/users/jhamman/gists{/gist_id}","starred_url":"https://api.github.com/users/jhamman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhamman/subscriptions","organizations_url":"https://api.github.com/users/jhamman/orgs","repos_url":"https://api.github.com/users/jhamman/repos","events_url":"https://api.github.com/users/jhamman/events{/privacy}","received_events_url":"https://api.github.com/users/jhamman/received_events","type":"User","site_admin":false},"body":"should this be  `ROUT := rout_stub` to allow it to be set on the command line via `make ROUT=rout_rvic`?","created_at":"2017-10-20T18:27:21Z","updated_at":"2017-10-20T18:42:20Z","html_url":"https://github.com/UW-Hydro/VIC/pull/231#discussion_r146035823","pull_request_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments/146035823"},"html":{"href":"https://github.com/UW-Hydro/VIC/pull/231#discussion_r146035823"},"pull_request":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231","id":41261683,"html_url":"https://github.com/UW-Hydro/VIC/pull/231","diff_url":"https://github.com/UW-Hydro/VIC/pull/231.diff","patch_url":"https://github.com/UW-Hydro/VIC/pull/231.patch","issue_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/231","number":231,"state":"open","locked":false,"title":"Routing extension for VIC image driver.","user":{"login":"wietsefranssen","id":13525266,"avatar_url":"https://avatars0.githubusercontent.com/u/13525266?v=4","gravatar_id":"","url":"https://api.github.com/users/wietsefranssen","html_url":"https://github.com/wietsefranssen","followers_url":"https://api.github.com/users/wietsefranssen/followers","following_url":"https://api.github.com/users/wietsefranssen/following{/other_user}","gists_url":"https://api.github.com/users/wietsefranssen/gists{/gist_id}","starred_url":"https://api.github.com/users/wietsefranssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wietsefranssen/subscriptions","organizations_url":"https://api.github.com/users/wietsefranssen/orgs","repos_url":"https://api.github.com/users/wietsefranssen/repos","events_url":"https://api.github.com/users/wietsefranssen/events{/privacy}","received_events_url":"https://api.github.com/users/wietsefranssen/received_events","type":"User","site_admin":false},"body":"Affected files in the original VIC files are: `./drivers/image/Makefile`  and `./drivers/image/src/vic_image.c`.\n\nTo change the routing scheme once they are implemented, only change the following line in the makefile\n-> `ROUT=rout_stub`\n\nStill only an empty routing module is implemented (rout_stub). See ./extensions/rout_stub\n\ncloses #24 \n","created_at":"2015-07-30T17:46:38Z","updated_at":"2017-10-20T18:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0116faaf5a8b4833d561fc651822914791fb70d","assignee":{"login":"wietsefranssen","id":13525266,"avatar_url":"https://avatars0.githubusercontent.com/u/13525266?v=4","gravatar_id":"","url":"https://api.github.com/users/wietsefranssen","html_url":"https://github.com/wietsefranssen","followers_url":"https://api.github.com/users/wietsefranssen/followers","following_url":"https://api.github.com/users/wietsefranssen/following{/other_user}","gists_url":"https://api.github.com/users/wietsefranssen/gists{/gist_id}","starred_url":"https://api.github.com/users/wietsefranssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wietsefranssen/subscriptions","organizations_url":"https://api.github.com/users/wietsefranssen/orgs","repos_url":"https://api.github.com/users/wietsefranssen/repos","events_url":"https://api.github.com/users/wietsefranssen/events{/privacy}","received_events_url":"https://api.github.com/users/wietsefranssen/received_events","type":"User","site_admin":false},"assignees":[{"login":"wietsefranssen","id":13525266,"avatar_url":"https://avatars0.githubusercontent.com/u/13525266?v=4","gravatar_id":"","url":"https://api.github.com/users/wietsefranssen","html_url":"https://github.com/wietsefranssen","followers_url":"https://api.github.com/users/wietsefranssen/followers","following_url":"https://api.github.com/users/wietsefranssen/following{/other_user}","gists_url":"https://api.github.com/users/wietsefranssen/gists{/gist_id}","starred_url":"https://api.github.com/users/wietsefranssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wietsefranssen/subscriptions","organizations_url":"https://api.github.com/users/wietsefranssen/orgs","repos_url":"https://api.github.com/users/wietsefranssen/repos","events_url":"https://api.github.com/users/wietsefranssen/events{/privacy}","received_events_url":"https://api.github.com/users/wietsefranssen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/UW-Hydro/VIC/milestones/9","html_url":"https://github.com/UW-Hydro/VIC/milestone/9","labels_url":"https://api.github.com/repos/UW-Hydro/VIC/milestones/9/labels","id":673465,"number":9,"title":"5.1.0 (Next minor release)","description":"","creator":{"login":"jhamman","id":2443309,"avatar_url":"https://avatars3.githubusercontent.com/u/2443309?v=4","gravatar_id":"","url":"https://api.github.com/users/jhamman","html_url":"https://github.com/jhamman","followers_url":"https://api.github.com/users/jhamman/followers","following_url":"https://api.github.com/users/jhamman/following{/other_user}","gists_url":"https://api.github.com/users/jhamman/gists{/gist_id}","starred_url":"https://api.github.com/users/jhamman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhamman/subscriptions","organizations_url":"https://api.github.com/users/jhamman/orgs","repos_url":"https://api.github.com/users/jhamman/repos","events_url":"https://api.github.com/users/jhamman/events{/privacy}","received_events_url":"https://api.github.com/users/jhamman/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":16,"state":"open","created_at":"2014-05-28T21:17:27Z","updated_at":"2017-09-22T19:32:06Z","due_on":"2017-04-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231/commits","review_comments_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231/comments","review_comment_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/231/comments","statuses_url":"https://api.github.com/repos/UW-Hydro/VIC/statuses/90c6a682343cfc240648e7e1a74f3429ac7a9c8e","head":{"label":"wietsefranssen:feature/routing_lohmann","ref":"feature/routing_lohmann","sha":"90c6a682343cfc240648e7e1a74f3429ac7a9c8e","user":{"login":"wietsefranssen","id":13525266,"avatar_url":"https://avatars0.githubusercontent.com/u/13525266?v=4","gravatar_id":"","url":"https://api.github.com/users/wietsefranssen","html_url":"https://github.com/wietsefranssen","followers_url":"https://api.github.com/users/wietsefranssen/followers","following_url":"https://api.github.com/users/wietsefranssen/following{/other_user}","gists_url":"https://api.github.com/users/wietsefranssen/gists{/gist_id}","starred_url":"https://api.github.com/users/wietsefranssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wietsefranssen/subscriptions","organizations_url":"https://api.github.com/users/wietsefranssen/orgs","repos_url":"https://api.github.com/users/wietsefranssen/repos","events_url":"https://api.github.com/users/wietsefranssen/events{/privacy}","received_events_url":"https://api.github.com/users/wietsefranssen/received_events","type":"User","site_admin":false},"repo":{"id":39787260,"name":"VIC","full_name":"wietsefranssen/VIC","owner":{"login":"wietsefranssen","id":13525266,"avatar_url":"https://avatars0.githubusercontent.com/u/13525266?v=4","gravatar_id":"","url":"https://api.github.com/users/wietsefranssen","html_url":"https://github.com/wietsefranssen","followers_url":"https://api.github.com/users/wietsefranssen/followers","following_url":"https://api.github.com/users/wietsefranssen/following{/other_user}","gists_url":"https://api.github.com/users/wietsefranssen/gists{/gist_id}","starred_url":"https://api.github.com/users/wietsefranssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wietsefranssen/subscriptions","organizations_url":"https://api.github.com/users/wietsefranssen/orgs","repos_url":"https://api.github.com/users/wietsefranssen/repos","events_url":"https://api.github.com/users/wietsefranssen/events{/privacy}","received_events_url":"https://api.github.com/users/wietsefranssen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wietsefranssen/VIC","description":"The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model","fork":true,"url":"https://api.github.com/repos/wietsefranssen/VIC","forks_url":"https://api.github.com/repos/wietsefranssen/VIC/forks","keys_url":"https://api.github.com/repos/wietsefranssen/VIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wietsefranssen/VIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wietsefranssen/VIC/teams","hooks_url":"https://api.github.com/repos/wietsefranssen/VIC/hooks","issue_events_url":"https://api.github.com/repos/wietsefranssen/VIC/issues/events{/number}","events_url":"https://api.github.com/repos/wietsefranssen/VIC/events","assignees_url":"https://api.github.com/repos/wietsefranssen/VIC/assignees{/user}","branches_url":"https://api.github.com/repos/wietsefranssen/VIC/branches{/branch}","tags_url":"https://api.github.com/repos/wietsefranssen/VIC/tags","blobs_url":"https://api.github.com/repos/wietsefranssen/VIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wietsefranssen/VIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wietsefranssen/VIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/wietsefranssen/VIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wietsefranssen/VIC/statuses/{sha}","languages_url":"https://api.github.com/repos/wietsefranssen/VIC/languages","stargazers_url":"https://api.github.com/repos/wietsefranssen/VIC/stargazers","contributors_url":"https://api.github.com/repos/wietsefranssen/VIC/contributors","subscribers_url":"https://api.github.com/repos/wietsefranssen/VIC/subscribers","subscription_url":"https://api.github.com/repos/wietsefranssen/VIC/subscription","commits_url":"https://api.github.com/repos/wietsefranssen/VIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/wietsefranssen/VIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/wietsefranssen/VIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/wietsefranssen/VIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/wietsefranssen/VIC/contents/{+path}","compare_url":"https://api.github.com/repos/wietsefranssen/VIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wietsefranssen/VIC/merges","archive_url":"https://api.github.com/repos/wietsefranssen/VIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wietsefranssen/VIC/downloads","issues_url":"https://api.github.com/repos/wietsefranssen/VIC/issues{/number}","pulls_url":"https://api.github.com/repos/wietsefranssen/VIC/pulls{/number}","milestones_url":"https://api.github.com/repos/wietsefranssen/VIC/milestones{/number}","notifications_url":"https://api.github.com/repos/wietsefranssen/VIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wietsefranssen/VIC/labels{/name}","releases_url":"https://api.github.com/repos/wietsefranssen/VIC/releases{/id}","deployments_url":"https://api.github.com/repos/wietsefranssen/VIC/deployments","created_at":"2015-07-27T17:12:37Z","updated_at":"2017-01-26T12:16:43Z","pushed_at":"2017-10-19T14:50:31Z","git_url":"git://github.com/wietsefranssen/VIC.git","ssh_url":"git@github.com:wietsefranssen/VIC.git","clone_url":"https://github.com/wietsefranssen/VIC.git","svn_url":"https://github.com/wietsefranssen/VIC","homepage":"http://www.hydro.washington.edu/Lettenmaier/Models/VIC/index.shtml","size":15861,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"UW-Hydro:develop","ref":"develop","sha":"5317327fc80c24132e37f29928b6665e754360f1","user":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars2.githubusercontent.com/u/3475662?v=4","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"repo":{"id":8064928,"name":"VIC","full_name":"UW-Hydro/VIC","owner":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars2.githubusercontent.com/u/3475662?v=4","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Hydro/VIC","description":"The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model","fork":false,"url":"https://api.github.com/repos/UW-Hydro/VIC","forks_url":"https://api.github.com/repos/UW-Hydro/VIC/forks","keys_url":"https://api.github.com/repos/UW-Hydro/VIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Hydro/VIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Hydro/VIC/teams","hooks_url":"https://api.github.com/repos/UW-Hydro/VIC/hooks","issue_events_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Hydro/VIC/events","assignees_url":"https://api.github.com/repos/UW-Hydro/VIC/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Hydro/VIC/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Hydro/VIC/tags","blobs_url":"https://api.github.com/repos/UW-Hydro/VIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Hydro/VIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Hydro/VIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Hydro/VIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Hydro/VIC/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Hydro/VIC/languages","stargazers_url":"https://api.github.com/repos/UW-Hydro/VIC/stargazers","contributors_url":"https://api.github.com/repos/UW-Hydro/VIC/contributors","subscribers_url":"https://api.github.com/repos/UW-Hydro/VIC/subscribers","subscription_url":"https://api.github.com/repos/UW-Hydro/VIC/subscription","commits_url":"https://api.github.com/repos/UW-Hydro/VIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Hydro/VIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Hydro/VIC/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Hydro/VIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Hydro/VIC/merges","archive_url":"https://api.github.com/repos/UW-Hydro/VIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Hydro/VIC/downloads","issues_url":"https://api.github.com/repos/UW-Hydro/VIC/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Hydro/VIC/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Hydro/VIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Hydro/VIC/labels{/name}","releases_url":"https://api.github.com/repos/UW-Hydro/VIC/releases{/id}","deployments_url":"https://api.github.com/repos/UW-Hydro/VIC/deployments","created_at":"2013-02-07T02:30:14Z","updated_at":"2017-09-30T03:35:45Z","pushed_at":"2017-10-20T17:59:31Z","git_url":"git://github.com/UW-Hydro/VIC.git","ssh_url":"git@github.com:UW-Hydro/VIC.git","clone_url":"https://github.com/UW-Hydro/VIC.git","svn_url":"https://github.com/UW-Hydro/VIC","homepage":"http://vic.readthedocs.io","size":20708,"stargazers_count":54,"watchers_count":54,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":69,"forks":156,"open_issues":69,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231"},"html":{"href":"https://github.com/UW-Hydro/VIC/pull/231"},"issue":{"href":"https://api.github.com/repos/UW-Hydro/VIC/issues/231"},"comments":{"href":"https://api.github.com/repos/UW-Hydro/VIC/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Hydro/VIC/statuses/90c6a682343cfc240648e7e1a74f3429ac7a9c8e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jhamman"}}