{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/103255759","pull_request_review_id":24036854,"id":103255759,"diff_hunk":"@@ -125,7 +125,7 @@ block content\n           err.style['text-align'] = 'center';\n           err.style['background'] = '#F44336';\n           err.style['padding'] = '25px';\n-          err.innerText = '#{i18n('UI-WELCOME_ERROR')}';\n+          err.innerText = '#{i18n_singleQuoteVar('UI-WELCOME_ERROR')}';\n ","path":"src/ui/views/ui_app.jade","position":6,"original_position":6,"commit_id":"559bb8bf3cbad7a189681f9ae864fc4f9f1cbe0c","original_commit_id":"559bb8bf3cbad7a189681f9ae864fc4f9f1cbe0c","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?v=3","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"body":"@hickeyma I tried that, actually using `JSON.stringify` instead and double quotes… but Jade (now pug) ends up quoting oddly- I think a html safe transform is implicated.","created_at":"2017-02-27T16:56:32Z","updated_at":"2017-02-27T16:56:32Z","html_url":"https://github.com/elastic/kibana/pull/10581#discussion_r103255759","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/10581","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/103255759"},"html":{"href":"https://github.com/elastic/kibana/pull/10581#discussion_r103255759"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10581"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/10581","id":107938805,"html_url":"https://github.com/elastic/kibana/pull/10581","diff_url":"https://github.com/elastic/kibana/pull/10581.diff","patch_url":"https://github.com/elastic/kibana/pull/10581.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/10581","number":10581,"state":"open","locked":false,"title":"escape ' -> \\' for the UI-WELCOME_ERROR","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?v=3","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"body":"* add a new function i18n_singleQuoteVar() for ui_app.jade so that “err.innerText = '#{i18n_singleQuoteVar('UI-WELCOME_ERROR')}';” doesn’t fail if the UI-WELCOME_ERROR contains a single quote\r\n\r\nFixes: https://github.com/elastic/kibana/issues/10580\r\n\r\n","created_at":"2017-02-25T01:24:56Z","updated_at":"2017-02-27T16:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b286e9a332cbd6832d2e6fdf63e53d64deb3e4d4","assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"assignees":[{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/10581/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/10581/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/10581/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/559bb8bf3cbad7a189681f9ae864fc4f9f1cbe0c","head":{"label":"srl295:fix-broken-quote","ref":"fix-broken-quote","sha":"559bb8bf3cbad7a189681f9ae864fc4f9f1cbe0c","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?v=3","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"repo":{"id":53697253,"name":"kibana","full_name":"srl295/kibana","owner":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?v=3","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srl295/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/srl295/kibana","forks_url":"https://api.github.com/repos/srl295/kibana/forks","keys_url":"https://api.github.com/repos/srl295/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srl295/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srl295/kibana/teams","hooks_url":"https://api.github.com/repos/srl295/kibana/hooks","issue_events_url":"https://api.github.com/repos/srl295/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/srl295/kibana/events","assignees_url":"https://api.github.com/repos/srl295/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/srl295/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/srl295/kibana/tags","blobs_url":"https://api.github.com/repos/srl295/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srl295/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srl295/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/srl295/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srl295/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/srl295/kibana/languages","stargazers_url":"https://api.github.com/repos/srl295/kibana/stargazers","contributors_url":"https://api.github.com/repos/srl295/kibana/contributors","subscribers_url":"https://api.github.com/repos/srl295/kibana/subscribers","subscription_url":"https://api.github.com/repos/srl295/kibana/subscription","commits_url":"https://api.github.com/repos/srl295/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/srl295/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/srl295/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/srl295/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/srl295/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/srl295/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srl295/kibana/merges","archive_url":"https://api.github.com/repos/srl295/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srl295/kibana/downloads","issues_url":"https://api.github.com/repos/srl295/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/srl295/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/srl295/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/srl295/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srl295/kibana/labels{/name}","releases_url":"https://api.github.com/repos/srl295/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/srl295/kibana/deployments","created_at":"2016-03-11T21:16:45Z","updated_at":"2016-03-11T21:16:49Z","pushed_at":"2017-02-25T01:22:59Z","git_url":"git://github.com/srl295/kibana.git","ssh_url":"git@github.com:srl295/kibana.git","clone_url":"https://github.com/srl295/kibana.git","svn_url":"https://github.com/srl295/kibana","homepage":"https://www.elastic.co/products/kibana","size":222905,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"7084d5573ff5e2664ee6bb9ab8022e1706ab6764","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-02-27T15:43:43Z","pushed_at":"2017-02-27T16:55:01Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":225287,"stargazers_count":6835,"watchers_count":6835,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2562,"mirror_url":null,"open_issues_count":1493,"forks":2562,"open_issues":1493,"watchers":6835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10581"},"html":{"href":"https://github.com/elastic/kibana/pull/10581"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/10581"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/10581/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10581/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10581/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/559bb8bf3cbad7a189681f9ae864fc4f9f1cbe0c"}}}}
{"actor":{"display_login":"srl295"}}