{"action":"closed","issue":{"url":"https://api.github.com/repos/jaredhanson/passport/issues/624","repository_url":"https://api.github.com/repos/jaredhanson/passport","labels_url":"https://api.github.com/repos/jaredhanson/passport/issues/624/labels{/name}","comments_url":"https://api.github.com/repos/jaredhanson/passport/issues/624/comments","events_url":"https://api.github.com/repos/jaredhanson/passport/issues/624/events","html_url":"https://github.com/jaredhanson/passport/issues/624","id":274774119,"number":624,"title":"drop the words \"Simple\" and \"unobtrusive\" from marketing copy","user":{"login":"kevinburkeotto","id":32654572,"avatar_url":"https://avatars0.githubusercontent.com/u/32654572?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinburkeotto","html_url":"https://github.com/kevinburkeotto","followers_url":"https://api.github.com/users/kevinburkeotto/followers","following_url":"https://api.github.com/users/kevinburkeotto/following{/other_user}","gists_url":"https://api.github.com/users/kevinburkeotto/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinburkeotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinburkeotto/subscriptions","organizations_url":"https://api.github.com/users/kevinburkeotto/orgs","repos_url":"https://api.github.com/users/kevinburkeotto/repos","events_url":"https://api.github.com/users/kevinburkeotto/events{/privacy}","received_events_url":"https://api.github.com/users/kevinburkeotto/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-17T07:19:15Z","updated_at":"2017-11-17T07:53:31Z","closed_at":"2017-11-17T07:53:31Z","author_association":"NONE","body":"I just spent about three hours determining why our tests were returning a 500 server error but the returned error contained no data and our 500 server error framework (the one that we've integrated into Express.js) was not logging anything.\r\n\r\nIt turns out Passport was rendering an HTML error page (including a stack trace(?) ) and returning immediately. This took a long time to debug because I had to determine on the client why the response was not JSON (and what the response actually was), and then on the server which piece of the response handling stack was executing and then returning without logging anything about what it was doing. Basically the only approach is to do a binary search and a) remove half of the middlewares until you don't see the error, then iteratively add them back until you find it or b) add print lines until you determine which print lines run and don't run, then iterate until you find the error.\r\n\r\nIn any event, my experience with 'Passport' was not that it was \"simple\" or \"unobtrusive\"; I would expect either of these things to let me know when it encountered an error condition instead of hiding it. It's bothersome that the library is being marketed this way."}}
{"actor":{"display_login":"kevinburkeotto"}}