{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/brave/pulls/comments/115108554","pull_request_review_id":36632530,"id":115108554,"diff_hunk":"@@ -0,0 +1,88 @@\n+package brave.p6spy;\n+\n+import brave.Span;\n+import brave.Tracer;\n+import brave.Tracing;\n+import com.p6spy.engine.common.StatementInformation;\n+import com.p6spy.engine.event.SimpleJdbcEventListener;\n+import java.net.InetAddress;\n+import java.net.URI;\n+import java.sql.Connection;\n+import java.sql.SQLException;\n+import zipkin.Constants;\n+import zipkin.Endpoint;\n+import zipkin.TraceKeys;\n+\n+final class TracingJdbcEventListener extends SimpleJdbcEventListener {\n+\n+  final String remoteServiceName;\n+\n+  TracingJdbcEventListener(String remoteServiceName) {\n+    this.remoteServiceName = remoteServiceName;\n+  }\n+\n+  @Override public void onBeforeAnyExecute(StatementInformation info) {\n+    Tracer tracer = Tracing.currentTracer();\n+    if (tracer == null) return;","path":"instrumentation/p6spy/src/main/java/brave/p6spy/TracingJdbcEventListener.java","position":26,"original_position":26,"commit_id":"d843b63f856aa16aae5bb559fad8fa2ff90ab89a","original_commit_id":"cecaaa76776f3faca9ff95c9b0116f40ece5d672","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars1.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"This method is special-cased variant of `Tracing.tracer() != null` Anyway the rationale was expanded on here https://github.com/openzipkin/brave/pull/379#discussion_r111049601\r\n","created_at":"2017-05-06T00:45:56Z","updated_at":"2017-05-06T00:45:56Z","html_url":"https://github.com/openzipkin/brave/pull/350#discussion_r115108554","pull_request_url":"https://api.github.com/repos/openzipkin/brave/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/comments/115108554"},"html":{"href":"https://github.com/openzipkin/brave/pull/350#discussion_r115108554"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/brave/pulls/350","id":103063237,"html_url":"https://github.com/openzipkin/brave/pull/350","diff_url":"https://github.com/openzipkin/brave/pull/350.diff","patch_url":"https://github.com/openzipkin/brave/pull/350.patch","issue_url":"https://api.github.com/repos/openzipkin/brave/issues/350","number":350,"state":"open","locked":false,"title":"Brave 4.x modernization","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars1.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"This includes code resurrected from earlier attempts to adapt a replacement for the interceptors from Brave 3. This includes a replacement for every instrumentation (except cxf which is in flux).\r\n\r\nExpect this to change dramatically until explicitly noted that it is stabilizing.\r\n\r\n - [x] Rough in a tentative client and server tracer api\r\n - [x] Integrate each library such that it sets spans in scope so `Tracer.currentSpan()` works\r\n - [x] Integrate each staticly initialized library such that it uses `Tracer.current()`\r\n - [x] Backport client and server integration tests\r\n - [x] add Async HttpClient and Servlet (which we never had before)\r\n - [x] add Tests for servlet 2.5 and grpc compat (which we never had before)\r\n - [x] ensure we can swap out propagation format when needed. Ex https://github.com/TraceContext/tracecontext-spec\r\n - [x] revise tagging approach so that it solves #276 #264\r\n - [x] Add tests for http client redirects\r\n - [x] Revisit exception parsing\r\n - [x] Revisit remote address parsing\r\n","created_at":"2017-01-25T06:35:18Z","updated_at":"2017-05-06T00:45:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a0add01b73377bef46e0e53773785159535e32e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/brave/pulls/350/commits","review_comments_url":"https://api.github.com/repos/openzipkin/brave/pulls/350/comments","review_comment_url":"https://api.github.com/repos/openzipkin/brave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/brave/issues/350/comments","statuses_url":"https://api.github.com/repos/openzipkin/brave/statuses/d843b63f856aa16aae5bb559fad8fa2ff90ab89a","head":{"label":"openzipkin:brave4-instrument","ref":"brave4-instrument","sha":"d843b63f856aa16aae5bb559fad8fa2ff90ab89a","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars0.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":9278888,"name":"brave","full_name":"openzipkin/brave","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars0.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/brave","description":"Java distributed tracing implementation compatible with Zipkin backend services.","fork":false,"url":"https://api.github.com/repos/openzipkin/brave","forks_url":"https://api.github.com/repos/openzipkin/brave/forks","keys_url":"https://api.github.com/repos/openzipkin/brave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/brave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/brave/teams","hooks_url":"https://api.github.com/repos/openzipkin/brave/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/brave/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/brave/events","assignees_url":"https://api.github.com/repos/openzipkin/brave/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/brave/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/brave/tags","blobs_url":"https://api.github.com/repos/openzipkin/brave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/brave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/brave/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/brave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/brave/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/brave/languages","stargazers_url":"https://api.github.com/repos/openzipkin/brave/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/brave/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/brave/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/brave/subscription","commits_url":"https://api.github.com/repos/openzipkin/brave/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/brave/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/brave/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/brave/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/brave/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/brave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/brave/merges","archive_url":"https://api.github.com/repos/openzipkin/brave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/brave/downloads","issues_url":"https://api.github.com/repos/openzipkin/brave/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/brave/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/brave/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/brave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/brave/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/brave/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/brave/deployments","created_at":"2013-04-07T15:48:18Z","updated_at":"2017-05-04T15:30:52Z","pushed_at":"2017-05-05T16:06:29Z","git_url":"git://github.com/openzipkin/brave.git","ssh_url":"git@github.com:openzipkin/brave.git","clone_url":"https://github.com/openzipkin/brave.git","svn_url":"https://github.com/openzipkin/brave","homepage":"","size":2931,"stargazers_count":640,"watchers_count":640,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":51,"forks":230,"open_issues":51,"watchers":640,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"7da71d770efc892997d3f912404a6eb95c6207f0","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars0.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":9278888,"name":"brave","full_name":"openzipkin/brave","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars0.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/brave","description":"Java distributed tracing implementation compatible with Zipkin backend services.","fork":false,"url":"https://api.github.com/repos/openzipkin/brave","forks_url":"https://api.github.com/repos/openzipkin/brave/forks","keys_url":"https://api.github.com/repos/openzipkin/brave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/brave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/brave/teams","hooks_url":"https://api.github.com/repos/openzipkin/brave/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/brave/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/brave/events","assignees_url":"https://api.github.com/repos/openzipkin/brave/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/brave/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/brave/tags","blobs_url":"https://api.github.com/repos/openzipkin/brave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/brave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/brave/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/brave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/brave/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/brave/languages","stargazers_url":"https://api.github.com/repos/openzipkin/brave/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/brave/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/brave/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/brave/subscription","commits_url":"https://api.github.com/repos/openzipkin/brave/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/brave/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/brave/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/brave/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/brave/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/brave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/brave/merges","archive_url":"https://api.github.com/repos/openzipkin/brave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/brave/downloads","issues_url":"https://api.github.com/repos/openzipkin/brave/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/brave/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/brave/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/brave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/brave/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/brave/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/brave/deployments","created_at":"2013-04-07T15:48:18Z","updated_at":"2017-05-04T15:30:52Z","pushed_at":"2017-05-05T16:06:29Z","git_url":"git://github.com/openzipkin/brave.git","ssh_url":"git@github.com:openzipkin/brave.git","clone_url":"https://github.com/openzipkin/brave.git","svn_url":"https://github.com/openzipkin/brave","homepage":"","size":2931,"stargazers_count":640,"watchers_count":640,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":51,"forks":230,"open_issues":51,"watchers":640,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/350"},"html":{"href":"https://github.com/openzipkin/brave/pull/350"},"issue":{"href":"https://api.github.com/repos/openzipkin/brave/issues/350"},"comments":{"href":"https://api.github.com/repos/openzipkin/brave/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/brave/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/brave/statuses/d843b63f856aa16aae5bb559fad8fa2ff90ab89a"}}}}
{"actor":{"display_login":"adriancole"}}