{"action":"created","issue":{"url":"https://api.github.com/repos/cbm755/octsympy/issues/805","repository_url":"https://api.github.com/repos/cbm755/octsympy","labels_url":"https://api.github.com/repos/cbm755/octsympy/issues/805/labels{/name}","comments_url":"https://api.github.com/repos/cbm755/octsympy/issues/805/comments","events_url":"https://api.github.com/repos/cbm755/octsympy/issues/805/events","html_url":"https://github.com/cbm755/octsympy/pull/805","id":229821817,"number":805,"title":"Pass strings instead of generating code","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars3.githubusercontent.com/u/818622?v=3","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-18T22:24:50Z","updated_at":"2017-05-19T14:08:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cbm755/octsympy/pulls/805","html_url":"https://github.com/cbm755/octsympy/pull/805","diff_url":"https://github.com/cbm755/octsympy/pull/805.diff","patch_url":"https://github.com/cbm755/octsympy/pull/805.patch"},"body":"@latot, do these two commits look ok?"},"comment":{"url":"https://api.github.com/repos/cbm755/octsympy/issues/comments/302712620","html_url":"https://github.com/cbm755/octsympy/pull/805#issuecomment-302712620","issue_url":"https://api.github.com/repos/cbm755/octsympy/issues/805","id":302712620,"user":{"login":"latot","id":10523095,"avatar_url":"https://avatars1.githubusercontent.com/u/10523095?v=3","gravatar_id":"","url":"https://api.github.com/users/latot","html_url":"https://github.com/latot","followers_url":"https://api.github.com/users/latot/followers","following_url":"https://api.github.com/users/latot/following{/other_user}","gists_url":"https://api.github.com/users/latot/gists{/gist_id}","starred_url":"https://api.github.com/users/latot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latot/subscriptions","organizations_url":"https://api.github.com/users/latot/orgs","repos_url":"https://api.github.com/users/latot/repos","events_url":"https://api.github.com/users/latot/events{/privacy}","received_events_url":"https://api.github.com/users/latot/received_events","type":"User","site_admin":false},"created_at":"2017-05-19T14:08:20Z","updated_at":"2017-05-19T14:08:20Z","body":"Hi, this is great, now is possible this because some behavior change, before when we get the python string we get ```Symbol(\"x\")```, so with the syntax we was getting the error, but now we get ```Symbol('x')``` and works fine, only as a note, some possible conflict is if we write some code with ```'``` instead of ```\"``` we cat get that error again, so i think we can keep this change and wait that possibility or  do something like this:\r\n\r\n```x = strrep (x, \"'\", \"\\'\");```\r\n\r\nIn any case, while we use only double quotes inside the python expressions we shouldn't get this problem.\r\n\r\nJust in case we add a test to check this:\r\n\r\n```\r\nx=sym(\"x\");\r\nassert(x, sym(sympy(x)))\r\n```\r\n\r\n(I don't know how we miss this test xD)\r\n\r\nI think this would can catch the most possible problems, because this in one of the few files where we really manipulate the python string like that.\r\n\r\nCya."}}
{"actor":{"display_login":"latot"}}