{"action":"created","comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments/153233544","pull_request_review_id":79144463,"id":153233544,"diff_hunk":"@@ -0,0 +1,112 @@\n+import UIKit\n+\n+class TimeZoneSelectorViewController: UITableViewController, ImmuTablePresenter {\n+\n+    /// users current timezone passed by SiteSettingsVC, if empty means manual offset is to be used\n+    @objc var usersCurrentTimeZone: String?\n+    /// users manual offset passed by SiteSettingsVC\n+    @objc var usersManualOffset: NSNumber?\n+\n+    /// timezoneString will be set to a non empty string\n+    /// if user selects anything other than Manual Offset section\n+    /// manualOffset will be set if users selects anything from Manual Offset section\n+    @objc var onChange: ((_ timezoneString: String, _ manualOffset: NSNumber?) -> Void)?\n+\n+    /// ImmuTableViewHandler, takes over the datasource, delegate from this VC\n+    private lazy var handler: ImmuTableViewHandler = {\n+        return ImmuTableViewHandler(takeOver: self)\n+    }()\n+\n+    /// common action passed to TimezoneListRow cells, executed on select of a cell\n+    private lazy var action: ImmuTableAction = { [weak self] (aRow) -> Void in","path":"WordPress/Classes/ViewRelated/Blog/TimeZoneSelectorViewController.swift","position":21,"original_position":21,"commit_id":"22d278607560e21b007fa1ae659717c5e5b00d15","original_commit_id":"22d278607560e21b007fa1ae659717c5e5b00d15","user":{"login":"frosty","id":4780,"avatar_url":"https://avatars0.githubusercontent.com/u/4780?v=4","gravatar_id":"","url":"https://api.github.com/users/frosty","html_url":"https://github.com/frosty","followers_url":"https://api.github.com/users/frosty/followers","following_url":"https://api.github.com/users/frosty/following{/other_user}","gists_url":"https://api.github.com/users/frosty/gists{/gist_id}","starred_url":"https://api.github.com/users/frosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frosty/subscriptions","organizations_url":"https://api.github.com/users/frosty/orgs","repos_url":"https://api.github.com/users/frosty/repos","events_url":"https://api.github.com/users/frosty/events{/privacy}","received_events_url":"https://api.github.com/users/frosty/received_events","type":"User","site_admin":false},"body":"You can make this a little more concise – `{ [weak self] row in`","created_at":"2017-11-27T15:44:28Z","updated_at":"2017-11-27T16:03:13Z","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/8184#discussion_r153233544","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments/153233544"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-iOS/pull/8184#discussion_r153233544"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184"}}},"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184","id":153302133,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/8184","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/8184.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/8184.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/8184","number":8184,"state":"open","locked":false,"title":"Site Settings: Timezone","user":{"login":"asifmohd","id":4892875,"avatar_url":"https://avatars0.githubusercontent.com/u/4892875?v=4","gravatar_id":"","url":"https://api.github.com/users/asifmohd","html_url":"https://github.com/asifmohd","followers_url":"https://api.github.com/users/asifmohd/followers","following_url":"https://api.github.com/users/asifmohd/following{/other_user}","gists_url":"https://api.github.com/users/asifmohd/gists{/gist_id}","starred_url":"https://api.github.com/users/asifmohd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asifmohd/subscriptions","organizations_url":"https://api.github.com/users/asifmohd/orgs","repos_url":"https://api.github.com/users/asifmohd/repos","events_url":"https://api.github.com/users/asifmohd/events{/privacy}","received_events_url":"https://api.github.com/users/asifmohd/received_events","type":"User","site_admin":false},"body":"Fixes #7831 \r\n\r\nThis PR adds support for changing Timezone settings in Site settings.\r\nThis PR is one of the first in a line of PRs which will further enhance site settings, by bringing more settings to mobile.\r\n\r\n**Notes:**\r\n- We took a call to not save the Timezones API to a local.json file.\r\n  Instead the way it's implemented is that the app will make an API call the first time, when there is no Timezone data in the core data DB, to get the data and save it to DB.\r\n  And subsequent views of the screen will just load the data from DB.\r\n  Reasoning to not go with the local.json file:\r\n  - While the Timezones API would probably change very infrequently, the possibility still exists and making a one time API call should be fine, as otherwise we'd have to keep a check on the Timezone API every once in a while and make sure it hasn't changed, if it did change then we'd have to ship out an app update.\r\n- Also it seems that you cannot see the timezone settings for Jetpack enabled sites in the Calypso editor.\r\n  You have to go to `wp-admin/options-general.php` and then you can see the time zone option there.\r\n\r\n**To test:**\r\n- Go to site settings for a Jetpack enabled WordPress site on mobile as well as web.\r\n- Check if the timezone displayed on mobile is the same as displayed on web.\r\n- Try changing the time zone to another time zone\r\n- Also try experimenting around changing to the manual offset section as well\r\n- Observe the same is reflected on web as well.\r\n- Repeat the above steps for a wordpress.com website as well\r\n","created_at":"2017-11-17T13:50:38Z","updated_at":"2017-11-27T16:03:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ee7770ab3de0e992e282e5a8f83387ed312cef9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/8184/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/statuses/22d278607560e21b007fa1ae659717c5e5b00d15","head":{"label":"asifmohd:enhanced_site_settings","ref":"enhanced_site_settings","sha":"22d278607560e21b007fa1ae659717c5e5b00d15","user":{"login":"asifmohd","id":4892875,"avatar_url":"https://avatars0.githubusercontent.com/u/4892875?v=4","gravatar_id":"","url":"https://api.github.com/users/asifmohd","html_url":"https://github.com/asifmohd","followers_url":"https://api.github.com/users/asifmohd/followers","following_url":"https://api.github.com/users/asifmohd/following{/other_user}","gists_url":"https://api.github.com/users/asifmohd/gists{/gist_id}","starred_url":"https://api.github.com/users/asifmohd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asifmohd/subscriptions","organizations_url":"https://api.github.com/users/asifmohd/orgs","repos_url":"https://api.github.com/users/asifmohd/repos","events_url":"https://api.github.com/users/asifmohd/events{/privacy}","received_events_url":"https://api.github.com/users/asifmohd/received_events","type":"User","site_admin":false},"repo":{"id":111052239,"name":"WordPress-iOS","full_name":"asifmohd/WordPress-iOS","owner":{"login":"asifmohd","id":4892875,"avatar_url":"https://avatars0.githubusercontent.com/u/4892875?v=4","gravatar_id":"","url":"https://api.github.com/users/asifmohd","html_url":"https://github.com/asifmohd","followers_url":"https://api.github.com/users/asifmohd/followers","following_url":"https://api.github.com/users/asifmohd/following{/other_user}","gists_url":"https://api.github.com/users/asifmohd/gists{/gist_id}","starred_url":"https://api.github.com/users/asifmohd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asifmohd/subscriptions","organizations_url":"https://api.github.com/users/asifmohd/orgs","repos_url":"https://api.github.com/users/asifmohd/repos","events_url":"https://api.github.com/users/asifmohd/events{/privacy}","received_events_url":"https://api.github.com/users/asifmohd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asifmohd/WordPress-iOS","description":"WordPress for iOS - Official repository","fork":true,"url":"https://api.github.com/repos/asifmohd/WordPress-iOS","forks_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/forks","keys_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/teams","hooks_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/hooks","issue_events_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/events","assignees_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/tags","blobs_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/languages","stargazers_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/stargazers","contributors_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/contributors","subscribers_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/subscribers","subscription_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/subscription","commits_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/merges","archive_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/downloads","issues_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/labels{/name}","releases_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/asifmohd/WordPress-iOS/deployments","created_at":"2017-11-17T03:21:33Z","updated_at":"2017-11-17T03:21:42Z","pushed_at":"2017-11-25T15:34:09Z","git_url":"git://github.com/asifmohd/WordPress-iOS.git","ssh_url":"git@github.com:asifmohd/WordPress-iOS.git","clone_url":"https://github.com/asifmohd/WordPress-iOS.git","svn_url":"https://github.com/asifmohd/WordPress-iOS","homepage":"http://ios.wordpress.org/","size":410396,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"ecf9bf6e9dc695da16266ea64cb4693c42274787","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":8859285,"name":"WordPress-iOS","full_name":"wordpress-mobile/WordPress-iOS","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars2.githubusercontent.com/u/1306301?v=4","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-iOS","description":"WordPress for iOS - Official repository","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/deployments","created_at":"2013-03-18T16:59:33Z","updated_at":"2017-11-27T14:08:01Z","pushed_at":"2017-11-27T16:00:24Z","git_url":"git://github.com/wordpress-mobile/WordPress-iOS.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-iOS.git","clone_url":"https://github.com/wordpress-mobile/WordPress-iOS.git","svn_url":"https://github.com/wordpress-mobile/WordPress-iOS","homepage":"http://ios.wordpress.org/","size":410394,"stargazers_count":2102,"watchers_count":2102,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":746,"mirror_url":null,"archived":false,"open_issues_count":514,"forks":746,"open_issues":514,"watchers":2102,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-iOS/pull/8184"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/8184"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/8184/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/8184/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/statuses/22d278607560e21b007fa1ae659717c5e5b00d15"}},"author_association":"NONE"}}
{"actor":{"display_login":"frosty"}}