{"action":"created","issue":{"url":"https://api.github.com/repos/krb5/krb5/issues/695","repository_url":"https://api.github.com/repos/krb5/krb5","labels_url":"https://api.github.com/repos/krb5/krb5/issues/695/labels{/name}","comments_url":"https://api.github.com/repos/krb5/krb5/issues/695/comments","events_url":"https://api.github.com/repos/krb5/krb5/issues/695/events","html_url":"https://github.com/krb5/krb5/pull/695","id":252715449,"number":695,"title":"Renewable ticket processing changes","user":{"login":"greghudson","id":1131421,"avatar_url":"https://avatars2.githubusercontent.com/u/1131421?v=4","gravatar_id":"","url":"https://api.github.com/users/greghudson","html_url":"https://github.com/greghudson","followers_url":"https://api.github.com/users/greghudson/followers","following_url":"https://api.github.com/users/greghudson/following{/other_user}","gists_url":"https://api.github.com/users/greghudson/gists{/gist_id}","starred_url":"https://api.github.com/users/greghudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greghudson/subscriptions","organizations_url":"https://api.github.com/users/greghudson/orgs","repos_url":"https://api.github.com/users/greghudson/repos","events_url":"https://api.github.com/users/greghudson/events{/privacy}","received_events_url":"https://api.github.com/users/greghudson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-24T20:04:05Z","updated_at":"2017-08-31T18:01:10Z","closed_at":"2017-08-31T04:29:01Z","author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/krb5/krb5/pulls/695","html_url":"https://github.com/krb5/krb5/pull/695","diff_url":"https://github.com/krb5/krb5/pull/695.diff","patch_url":"https://github.com/krb5/krb5/pull/695.patch"},"body":"The second commit here is a trivial y2038 fix that I noticed while preparing the first commit.  The impact of the bug would have been miniscule.\r\n\r\nThe first commit addresses some feedback we got years ago about KDC behavior around issuing renewable tickets, and a recent observation from Weijun that we have a minor bug where we issue inconsistent renewed tickets.  I don't think the bug is important enough for a backport so I combined the fix with the behavior change."},"comment":{"url":"https://api.github.com/repos/krb5/krb5/issues/comments/326375490","html_url":"https://github.com/krb5/krb5/pull/695#issuecomment-326375490","issue_url":"https://api.github.com/repos/krb5/krb5/issues/695","id":326375490,"user":{"login":"greghudson","id":1131421,"avatar_url":"https://avatars2.githubusercontent.com/u/1131421?v=4","gravatar_id":"","url":"https://api.github.com/users/greghudson","html_url":"https://github.com/greghudson","followers_url":"https://api.github.com/users/greghudson/followers","following_url":"https://api.github.com/users/greghudson/following{/other_user}","gists_url":"https://api.github.com/users/greghudson/gists{/gist_id}","starred_url":"https://api.github.com/users/greghudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greghudson/subscriptions","organizations_url":"https://api.github.com/users/greghudson/orgs","repos_url":"https://api.github.com/users/greghudson/repos","events_url":"https://api.github.com/users/greghudson/events{/privacy}","received_events_url":"https://api.github.com/users/greghudson/received_events","type":"User","site_admin":false},"created_at":"2017-08-31T18:01:10Z","updated_at":"2017-08-31T18:01:10Z","author_association":"OWNER","body":"I might need to add some slop allowance to the checks in t_renew.py.  I just saw:\r\n\r\n    *** Failure: maxrenewlife client 1: expected life 14400, got 14401\r\n\r\nSince KDC-REQ-BODY contains an absolute end time and not a lifetime, the requested lifetime may not exactly match the resulting ticket lifetime, if the lifetime is not constrained by any KDC policy.  I'm not quite sure why the resulting ticket lifetime is longer (I would expect it to be shorter, if the clock second advanced between the client request and the KDC servicing it), but in hindsight it's not surprising that it's one second different.\r\n"}}
{"actor":{"display_login":"greghudson"}}