{"action":"created","comment":{"url":"https://api.github.com/repos/LongoMatch/longomatch/pulls/comments/106188656","pull_request_review_id":27098750,"id":106188656,"diff_hunk":"@@ -260,52 +219,35 @@ public void TestCaptureFinished ()\n \t\t[Test ()]\n \t\tpublic async Task TestCloseCaptureProject ()\n \t\t{\n-\t\t\tint projectChanged = 0;\n-\n-\t\t\tEventToken et = App.Current.EventsBroker.Subscribe<OpenedProjectEvent> ((e) => projectChanged++);\n \t\t\tawait App.Current.EventsBroker.Publish (new CloseOpenedProjectEvent ());\n-\t\t\tAssert.AreEqual (0, projectChanged);\n \n-\t\t\tawait App.Current.EventsBroker.Publish (\n-\t\t\t\tnew OpenNewProjectEvent {\n-\t\t\t\t\tProject = project,\n-\t\t\t\t\tProjectType = ProjectType.CaptureProject,\n-\t\t\t\t\tCaptureSettings = settings\n-\t\t\t\t}\n-\t\t\t);\n-\t\t\tprojectChanged = 0;\n+\t\t\tprojectsManager.Capturer = capturerBinMock.Object;\n+\t\t\tprojectsManager.ViewModel.Project.Model = project;\n+\t\t\tprojectsManager.ViewModel.CaptureSettings = settings;\n+\t\t\tprojectsManager.ViewModel.Project.ProjectType = ProjectType.CaptureProject;\n \n \t\t\tgtkMock.Setup (g => g.EndCapture (false)).Returns (EndCaptureResponse.Return);\n-\t\t\tawait App.Current.EventsBroker.Publish (new CloseOpenedProjectEvent ());\n-\t\t\tAssert.AreEqual (project, projectsManager.Project);\n-\t\t\t//Assert.AreEqual (ProjectType.CaptureProject, projectsManager.OpenedProjectType);\n-\t\t\tAssert.AreEqual (0, projectChanged);\n+\t\t\tawait App.Current.EventsBroker.Publish (new CloseEvent<LMProjectVM> { Object = projectsManager.ViewModel.Project});\n+\t\t\tAssert.AreEqual (project, projectsManager.Project.Model);\n \n \t\t\tgtkMock.Setup (g => g.EndCapture (false)).Returns (EndCaptureResponse.Quit);\n-\t\t\tawait App.Current.EventsBroker.Publish (new CloseOpenedProjectEvent ());\n-\t\t\tAssert.AreEqual (null, projectsManager.Project);\n+\t\t\tawait App.Current.EventsBroker.Publish (new CloseEvent<LMProjectVM> { Object = projectsManager.ViewModel.Project });\n+\t\t\tAssert.AreEqual (project, projectsManager.Project.Model);\n \t\t\tAssert.AreEqual (0, App.Current.DatabaseManager.ActiveDB.Count<LMProject> ());\n-\t\t\tAssert.AreEqual (1, projectChanged);\n \n-\t\t\tawait App.Current.EventsBroker.Publish (\n-\t\t\t\tnew OpenNewProjectEvent {\n-\t\t\t\t\tProject = project,\n-\t\t\t\t\tProjectType = ProjectType.CaptureProject,\n-\t\t\t\t\tCaptureSettings = settings\n-\t\t\t\t}\n-\t\t\t);\n-\t\t\tprojectChanged = 0;\n+\t\t\tprojectsManager.Capturer = capturerBinMock.Object;\n+\t\t\tprojectsManager.ViewModel.Project.Model = project;\n+\t\t\tprojectsManager.ViewModel.CaptureSettings = settings;\n+\t\t\tprojectsManager.ViewModel.Project.ProjectType = ProjectType.CaptureProject;\n+\n \t\t\tgtkMock.Setup (g => g.EndCapture (false)).Returns (EndCaptureResponse.Save);\n-\t\t\tawait App.Current.EventsBroker.Publish (new CloseOpenedProjectEvent ());\n-\t\t\tAssert.AreEqual (project, projectsManager.Project);\n-\t\t\t//Assert.AreEqual (ProjectType.FileProject, projectsManager.OpenedProjectType);\n+\t\t\tawait App.Current.EventsBroker.Publish (new CloseEvent<LMProjectVM> { Object = projectsManager.ViewModel.Project });\n+\t\t\tAssert.AreEqual (project, projectsManager.Project.Model);\n \t\t\tAssert.AreEqual (1, App.Current.DatabaseManager.ActiveDB.Count<LMProject> ());\n-\t\t\tAssert.AreEqual (2, projectChanged);\n-\n-\t\t\tApp.Current.EventsBroker.Unsubscribe<OpenedProjectEvent> (et);\n \t\t}\n \n-\t\t[Test ()]\n+\t\t// SP-Question: Has sense this test in here after latest changes?\n+\t\t/*[Test ()]","path":"Tests/Controller/TestProjectAnalysisController.cs","position":221,"original_position":221,"commit_id":"87450e5110dbeccb66f4d3245e711fe700aa3dbe","original_commit_id":"87450e5110dbeccb66f4d3245e711fe700aa3dbe","user":{"login":"SandraPG85","id":19749571,"avatar_url":"https://avatars0.githubusercontent.com/u/19749571?v=3","gravatar_id":"","url":"https://api.github.com/users/SandraPG85","html_url":"https://github.com/SandraPG85","followers_url":"https://api.github.com/users/SandraPG85/followers","following_url":"https://api.github.com/users/SandraPG85/following{/other_user}","gists_url":"https://api.github.com/users/SandraPG85/gists{/gist_id}","starred_url":"https://api.github.com/users/SandraPG85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SandraPG85/subscriptions","organizations_url":"https://api.github.com/users/SandraPG85/orgs","repos_url":"https://api.github.com/users/SandraPG85/repos","events_url":"https://api.github.com/users/SandraPG85/events{/privacy}","received_events_url":"https://api.github.com/users/SandraPG85/received_events","type":"User","site_admin":false},"body":"Test enabled again but it failing, I will fix it after discussing with Andoni the Open behaviour.","created_at":"2017-03-15T15:02:28Z","updated_at":"2017-03-15T15:02:28Z","html_url":"https://github.com/LongoMatch/longomatch/pull/194#discussion_r106188656","pull_request_url":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/LongoMatch/longomatch/pulls/comments/106188656"},"html":{"href":"https://github.com/LongoMatch/longomatch/pull/194#discussion_r106188656"},"pull_request":{"href":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194","id":110812760,"html_url":"https://github.com/LongoMatch/longomatch/pull/194","diff_url":"https://github.com/LongoMatch/longomatch/pull/194.diff","patch_url":"https://github.com/LongoMatch/longomatch/pull/194.patch","issue_url":"https://api.github.com/repos/LongoMatch/longomatch/issues/194","number":194,"state":"open","locked":false,"title":"Longomatch 962","user":{"login":"SandraPG85","id":19749571,"avatar_url":"https://avatars0.githubusercontent.com/u/19749571?v=3","gravatar_id":"","url":"https://api.github.com/users/SandraPG85","html_url":"https://github.com/SandraPG85","followers_url":"https://api.github.com/users/SandraPG85/followers","following_url":"https://api.github.com/users/SandraPG85/following{/other_user}","gists_url":"https://api.github.com/users/SandraPG85/gists{/gist_id}","starred_url":"https://api.github.com/users/SandraPG85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SandraPG85/subscriptions","organizations_url":"https://api.github.com/users/SandraPG85/orgs","repos_url":"https://api.github.com/users/SandraPG85/repos","events_url":"https://api.github.com/users/SandraPG85/events{/privacy}","received_events_url":"https://api.github.com/users/SandraPG85/received_events","type":"User","site_admin":false},"body":"+ Small fix for issue 965\r\n+ Tests fixed with some minor code changes required (some tests are still failing but pending to be checked with Andoni)\r\n","created_at":"2017-03-15T10:30:01Z","updated_at":"2017-03-15T15:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72b33878a5dcc406a7161ca8fb7a82c51ebd285d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194/commits","review_comments_url":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194/comments","review_comment_url":"https://api.github.com/repos/LongoMatch/longomatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LongoMatch/longomatch/issues/194/comments","statuses_url":"https://api.github.com/repos/LongoMatch/longomatch/statuses/87450e5110dbeccb66f4d3245e711fe700aa3dbe","head":{"label":"LongoMatch:longomatch-962","ref":"longomatch-962","sha":"87450e5110dbeccb66f4d3245e711fe700aa3dbe","user":{"login":"LongoMatch","id":17885145,"avatar_url":"https://avatars1.githubusercontent.com/u/17885145?v=3","gravatar_id":"","url":"https://api.github.com/users/LongoMatch","html_url":"https://github.com/LongoMatch","followers_url":"https://api.github.com/users/LongoMatch/followers","following_url":"https://api.github.com/users/LongoMatch/following{/other_user}","gists_url":"https://api.github.com/users/LongoMatch/gists{/gist_id}","starred_url":"https://api.github.com/users/LongoMatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongoMatch/subscriptions","organizations_url":"https://api.github.com/users/LongoMatch/orgs","repos_url":"https://api.github.com/users/LongoMatch/repos","events_url":"https://api.github.com/users/LongoMatch/events{/privacy}","received_events_url":"https://api.github.com/users/LongoMatch/received_events","type":"Organization","site_admin":false},"repo":{"id":2885436,"name":"longomatch","full_name":"LongoMatch/longomatch","owner":{"login":"LongoMatch","id":17885145,"avatar_url":"https://avatars1.githubusercontent.com/u/17885145?v=3","gravatar_id":"","url":"https://api.github.com/users/LongoMatch","html_url":"https://github.com/LongoMatch","followers_url":"https://api.github.com/users/LongoMatch/followers","following_url":"https://api.github.com/users/LongoMatch/following{/other_user}","gists_url":"https://api.github.com/users/LongoMatch/gists{/gist_id}","starred_url":"https://api.github.com/users/LongoMatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongoMatch/subscriptions","organizations_url":"https://api.github.com/users/LongoMatch/orgs","repos_url":"https://api.github.com/users/LongoMatch/repos","events_url":"https://api.github.com/users/LongoMatch/events{/privacy}","received_events_url":"https://api.github.com/users/LongoMatch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LongoMatch/longomatch","description":null,"fork":false,"url":"https://api.github.com/repos/LongoMatch/longomatch","forks_url":"https://api.github.com/repos/LongoMatch/longomatch/forks","keys_url":"https://api.github.com/repos/LongoMatch/longomatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LongoMatch/longomatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LongoMatch/longomatch/teams","hooks_url":"https://api.github.com/repos/LongoMatch/longomatch/hooks","issue_events_url":"https://api.github.com/repos/LongoMatch/longomatch/issues/events{/number}","events_url":"https://api.github.com/repos/LongoMatch/longomatch/events","assignees_url":"https://api.github.com/repos/LongoMatch/longomatch/assignees{/user}","branches_url":"https://api.github.com/repos/LongoMatch/longomatch/branches{/branch}","tags_url":"https://api.github.com/repos/LongoMatch/longomatch/tags","blobs_url":"https://api.github.com/repos/LongoMatch/longomatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LongoMatch/longomatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LongoMatch/longomatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/LongoMatch/longomatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LongoMatch/longomatch/statuses/{sha}","languages_url":"https://api.github.com/repos/LongoMatch/longomatch/languages","stargazers_url":"https://api.github.com/repos/LongoMatch/longomatch/stargazers","contributors_url":"https://api.github.com/repos/LongoMatch/longomatch/contributors","subscribers_url":"https://api.github.com/repos/LongoMatch/longomatch/subscribers","subscription_url":"https://api.github.com/repos/LongoMatch/longomatch/subscription","commits_url":"https://api.github.com/repos/LongoMatch/longomatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/LongoMatch/longomatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/LongoMatch/longomatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/LongoMatch/longomatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/LongoMatch/longomatch/contents/{+path}","compare_url":"https://api.github.com/repos/LongoMatch/longomatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LongoMatch/longomatch/merges","archive_url":"https://api.github.com/repos/LongoMatch/longomatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LongoMatch/longomatch/downloads","issues_url":"https://api.github.com/repos/LongoMatch/longomatch/issues{/number}","pulls_url":"https://api.github.com/repos/LongoMatch/longomatch/pulls{/number}","milestones_url":"https://api.github.com/repos/LongoMatch/longomatch/milestones{/number}","notifications_url":"https://api.github.com/repos/LongoMatch/longomatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LongoMatch/longomatch/labels{/name}","releases_url":"https://api.github.com/repos/LongoMatch/longomatch/releases{/id}","deployments_url":"https://api.github.com/repos/LongoMatch/longomatch/deployments","created_at":"2011-11-30T18:49:28Z","updated_at":"2017-02-17T12:17:44Z","pushed_at":"2017-03-15T10:57:03Z","git_url":"git://github.com/LongoMatch/longomatch.git","ssh_url":"git@github.com:LongoMatch/longomatch.git","clone_url":"https://github.com/LongoMatch/longomatch.git","svn_url":"https://github.com/LongoMatch/longomatch","homepage":"","size":165775,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"LongoMatch:longomatch-fix","ref":"longomatch-fix","sha":"dd93be090996de4402a921beeddbafd8d1bb8d2b","user":{"login":"LongoMatch","id":17885145,"avatar_url":"https://avatars1.githubusercontent.com/u/17885145?v=3","gravatar_id":"","url":"https://api.github.com/users/LongoMatch","html_url":"https://github.com/LongoMatch","followers_url":"https://api.github.com/users/LongoMatch/followers","following_url":"https://api.github.com/users/LongoMatch/following{/other_user}","gists_url":"https://api.github.com/users/LongoMatch/gists{/gist_id}","starred_url":"https://api.github.com/users/LongoMatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongoMatch/subscriptions","organizations_url":"https://api.github.com/users/LongoMatch/orgs","repos_url":"https://api.github.com/users/LongoMatch/repos","events_url":"https://api.github.com/users/LongoMatch/events{/privacy}","received_events_url":"https://api.github.com/users/LongoMatch/received_events","type":"Organization","site_admin":false},"repo":{"id":2885436,"name":"longomatch","full_name":"LongoMatch/longomatch","owner":{"login":"LongoMatch","id":17885145,"avatar_url":"https://avatars1.githubusercontent.com/u/17885145?v=3","gravatar_id":"","url":"https://api.github.com/users/LongoMatch","html_url":"https://github.com/LongoMatch","followers_url":"https://api.github.com/users/LongoMatch/followers","following_url":"https://api.github.com/users/LongoMatch/following{/other_user}","gists_url":"https://api.github.com/users/LongoMatch/gists{/gist_id}","starred_url":"https://api.github.com/users/LongoMatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongoMatch/subscriptions","organizations_url":"https://api.github.com/users/LongoMatch/orgs","repos_url":"https://api.github.com/users/LongoMatch/repos","events_url":"https://api.github.com/users/LongoMatch/events{/privacy}","received_events_url":"https://api.github.com/users/LongoMatch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LongoMatch/longomatch","description":null,"fork":false,"url":"https://api.github.com/repos/LongoMatch/longomatch","forks_url":"https://api.github.com/repos/LongoMatch/longomatch/forks","keys_url":"https://api.github.com/repos/LongoMatch/longomatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LongoMatch/longomatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LongoMatch/longomatch/teams","hooks_url":"https://api.github.com/repos/LongoMatch/longomatch/hooks","issue_events_url":"https://api.github.com/repos/LongoMatch/longomatch/issues/events{/number}","events_url":"https://api.github.com/repos/LongoMatch/longomatch/events","assignees_url":"https://api.github.com/repos/LongoMatch/longomatch/assignees{/user}","branches_url":"https://api.github.com/repos/LongoMatch/longomatch/branches{/branch}","tags_url":"https://api.github.com/repos/LongoMatch/longomatch/tags","blobs_url":"https://api.github.com/repos/LongoMatch/longomatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LongoMatch/longomatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LongoMatch/longomatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/LongoMatch/longomatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LongoMatch/longomatch/statuses/{sha}","languages_url":"https://api.github.com/repos/LongoMatch/longomatch/languages","stargazers_url":"https://api.github.com/repos/LongoMatch/longomatch/stargazers","contributors_url":"https://api.github.com/repos/LongoMatch/longomatch/contributors","subscribers_url":"https://api.github.com/repos/LongoMatch/longomatch/subscribers","subscription_url":"https://api.github.com/repos/LongoMatch/longomatch/subscription","commits_url":"https://api.github.com/repos/LongoMatch/longomatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/LongoMatch/longomatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/LongoMatch/longomatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/LongoMatch/longomatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/LongoMatch/longomatch/contents/{+path}","compare_url":"https://api.github.com/repos/LongoMatch/longomatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LongoMatch/longomatch/merges","archive_url":"https://api.github.com/repos/LongoMatch/longomatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LongoMatch/longomatch/downloads","issues_url":"https://api.github.com/repos/LongoMatch/longomatch/issues{/number}","pulls_url":"https://api.github.com/repos/LongoMatch/longomatch/pulls{/number}","milestones_url":"https://api.github.com/repos/LongoMatch/longomatch/milestones{/number}","notifications_url":"https://api.github.com/repos/LongoMatch/longomatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LongoMatch/longomatch/labels{/name}","releases_url":"https://api.github.com/repos/LongoMatch/longomatch/releases{/id}","deployments_url":"https://api.github.com/repos/LongoMatch/longomatch/deployments","created_at":"2011-11-30T18:49:28Z","updated_at":"2017-02-17T12:17:44Z","pushed_at":"2017-03-15T10:57:03Z","git_url":"git://github.com/LongoMatch/longomatch.git","ssh_url":"git@github.com:LongoMatch/longomatch.git","clone_url":"https://github.com/LongoMatch/longomatch.git","svn_url":"https://github.com/LongoMatch/longomatch","homepage":"","size":165775,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194"},"html":{"href":"https://github.com/LongoMatch/longomatch/pull/194"},"issue":{"href":"https://api.github.com/repos/LongoMatch/longomatch/issues/194"},"comments":{"href":"https://api.github.com/repos/LongoMatch/longomatch/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/LongoMatch/longomatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LongoMatch/longomatch/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/LongoMatch/longomatch/statuses/87450e5110dbeccb66f4d3245e711fe700aa3dbe"}}}}
{"actor":{"display_login":"SandraPG85"}}