{"action":"opened","number":10362,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/10362","id":118781160,"html_url":"https://github.com/highfidelity/hifi/pull/10362","diff_url":"https://github.com/highfidelity/hifi/pull/10362.diff","patch_url":"https://github.com/highfidelity/hifi/pull/10362.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/10362","number":10362,"state":"open","locked":false,"title":"Request module refactor","user":{"login":"cfresquet","id":13633603,"avatar_url":"https://avatars2.githubusercontent.com/u/13633603?v=3","gravatar_id":"","url":"https://api.github.com/users/cfresquet","html_url":"https://github.com/cfresquet","followers_url":"https://api.github.com/users/cfresquet/followers","following_url":"https://api.github.com/users/cfresquet/following{/other_user}","gists_url":"https://api.github.com/users/cfresquet/gists{/gist_id}","starred_url":"https://api.github.com/users/cfresquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfresquet/subscriptions","organizations_url":"https://api.github.com/users/cfresquet/orgs","repos_url":"https://api.github.com/users/cfresquet/repos","events_url":"https://api.github.com/users/cfresquet/events{/privacy}","received_events_url":"https://api.github.com/users/cfresquet/received_events","type":"User","site_admin":false},"body":"Replacement for https://github.com/highfidelity/hifi/pull/10339, since Howard pointed out that I should create a branch in my fork, and use that to do the pull request from, instead of from my master.\r\n\r\nPulled out the \"request\" function from pal.js and makeUserConnection.js to a new request.js file in the modules directory.\r\n\r\nTest: Confirm handshake functionality still works as expected.\r\nConfirm connections/friends list & info still function as expected.","created_at":"2017-05-03T14:55:17Z","updated_at":"2017-05-03T14:55:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/10362/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/10362/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/10362/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/28b166c51fd74201502a1af0622795817bd95331","head":{"label":"cfresquet:requestModuleRefactor","ref":"requestModuleRefactor","sha":"28b166c51fd74201502a1af0622795817bd95331","user":{"login":"cfresquet","id":13633603,"avatar_url":"https://avatars2.githubusercontent.com/u/13633603?v=3","gravatar_id":"","url":"https://api.github.com/users/cfresquet","html_url":"https://github.com/cfresquet","followers_url":"https://api.github.com/users/cfresquet/followers","following_url":"https://api.github.com/users/cfresquet/following{/other_user}","gists_url":"https://api.github.com/users/cfresquet/gists{/gist_id}","starred_url":"https://api.github.com/users/cfresquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfresquet/subscriptions","organizations_url":"https://api.github.com/users/cfresquet/orgs","repos_url":"https://api.github.com/users/cfresquet/repos","events_url":"https://api.github.com/users/cfresquet/events{/privacy}","received_events_url":"https://api.github.com/users/cfresquet/received_events","type":"User","site_admin":false},"repo":{"id":89660357,"name":"hifi","full_name":"cfresquet/hifi","owner":{"login":"cfresquet","id":13633603,"avatar_url":"https://avatars2.githubusercontent.com/u/13633603?v=3","gravatar_id":"","url":"https://api.github.com/users/cfresquet","html_url":"https://github.com/cfresquet","followers_url":"https://api.github.com/users/cfresquet/followers","following_url":"https://api.github.com/users/cfresquet/following{/other_user}","gists_url":"https://api.github.com/users/cfresquet/gists{/gist_id}","starred_url":"https://api.github.com/users/cfresquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfresquet/subscriptions","organizations_url":"https://api.github.com/users/cfresquet/orgs","repos_url":"https://api.github.com/users/cfresquet/repos","events_url":"https://api.github.com/users/cfresquet/events{/privacy}","received_events_url":"https://api.github.com/users/cfresquet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cfresquet/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://wiki.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":true,"url":"https://api.github.com/repos/cfresquet/hifi","forks_url":"https://api.github.com/repos/cfresquet/hifi/forks","keys_url":"https://api.github.com/repos/cfresquet/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfresquet/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfresquet/hifi/teams","hooks_url":"https://api.github.com/repos/cfresquet/hifi/hooks","issue_events_url":"https://api.github.com/repos/cfresquet/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/cfresquet/hifi/events","assignees_url":"https://api.github.com/repos/cfresquet/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/cfresquet/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/cfresquet/hifi/tags","blobs_url":"https://api.github.com/repos/cfresquet/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfresquet/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfresquet/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfresquet/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfresquet/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/cfresquet/hifi/languages","stargazers_url":"https://api.github.com/repos/cfresquet/hifi/stargazers","contributors_url":"https://api.github.com/repos/cfresquet/hifi/contributors","subscribers_url":"https://api.github.com/repos/cfresquet/hifi/subscribers","subscription_url":"https://api.github.com/repos/cfresquet/hifi/subscription","commits_url":"https://api.github.com/repos/cfresquet/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfresquet/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfresquet/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfresquet/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfresquet/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/cfresquet/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfresquet/hifi/merges","archive_url":"https://api.github.com/repos/cfresquet/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfresquet/hifi/downloads","issues_url":"https://api.github.com/repos/cfresquet/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/cfresquet/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/cfresquet/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/cfresquet/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfresquet/hifi/labels{/name}","releases_url":"https://api.github.com/repos/cfresquet/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/cfresquet/hifi/deployments","created_at":"2017-04-28T02:42:14Z","updated_at":"2017-04-28T02:42:28Z","pushed_at":"2017-05-03T14:52:11Z","git_url":"git://github.com/cfresquet/hifi.git","ssh_url":"git@github.com:cfresquet/hifi.git","clone_url":"https://github.com/cfresquet/hifi.git","svn_url":"https://github.com/cfresquet/hifi","homepage":"","size":308978,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"ef628eaec6c01b4b69df261db237052e5729dd1a","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars3.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars3.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://wiki.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2017-04-30T12:01:54Z","pushed_at":"2017-05-03T05:53:11Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":309929,"stargazers_count":502,"watchers_count":502,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":136,"forks":319,"open_issues":136,"watchers":502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10362"},"html":{"href":"https://github.com/highfidelity/hifi/pull/10362"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/10362"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/10362/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10362/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10362/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/28b166c51fd74201502a1af0622795817bd95331"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":7,"additions":98,"deletions":154,"changed_files":4}}
{"actor":{"display_login":"cfresquet"}}