{"action":"created","issue":{"url":"https://api.github.com/repos/octobercms/october/issues/2801","repository_url":"https://api.github.com/repos/octobercms/october","labels_url":"https://api.github.com/repos/octobercms/october/issues/2801/labels{/name}","comments_url":"https://api.github.com/repos/octobercms/october/issues/2801/comments","events_url":"https://api.github.com/repos/octobercms/october/issues/2801/events","html_url":"https://github.com/octobercms/october/pull/2801","id":220145725,"number":2801,"title":"Prevent preloading files in advance","user":{"login":"amdad","id":10062429,"avatar_url":"https://avatars2.githubusercontent.com/u/10062429?v=3","gravatar_id":"","url":"https://api.github.com/users/amdad","html_url":"https://github.com/amdad","followers_url":"https://api.github.com/users/amdad/followers","following_url":"https://api.github.com/users/amdad/following{/other_user}","gists_url":"https://api.github.com/users/amdad/gists{/gist_id}","starred_url":"https://api.github.com/users/amdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amdad/subscriptions","organizations_url":"https://api.github.com/users/amdad/orgs","repos_url":"https://api.github.com/users/amdad/repos","events_url":"https://api.github.com/users/amdad/events{/privacy}","received_events_url":"https://api.github.com/users/amdad/received_events","type":"User","site_admin":false},"labels":[{"id":247986935,"url":"https://api.github.com/repos/octobercms/october/labels/Status:%20Revision%20Needed","name":"Status: Revision Needed","color":"e11d21","default":false},{"id":330614039,"url":"https://api.github.com/repos/octobercms/october/labels/Type:%20Maintenance","name":"Type: Maintenance","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-07T08:30:06Z","updated_at":"2017-04-13T19:12:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/octobercms/october/pulls/2801","html_url":"https://github.com/octobercms/october/pull/2801","diff_url":"https://github.com/octobercms/october/pull/2801.diff","patch_url":"https://github.com/octobercms/october/pull/2801.patch"},"body":"Files should be loaded on user click. Huge amount of data is loaded on page load, especially if many audio/VIDEO instances are on page. This is temporary solution. Ultimately widget should support params to match html5 audio/video tags."},"comment":{"url":"https://api.github.com/repos/octobercms/october/issues/comments/293995122","html_url":"https://github.com/octobercms/october/pull/2801#issuecomment-293995122","issue_url":"https://api.github.com/repos/octobercms/october/issues/2801","id":293995122,"user":{"login":"amdad","id":10062429,"avatar_url":"https://avatars2.githubusercontent.com/u/10062429?v=3","gravatar_id":"","url":"https://api.github.com/users/amdad","html_url":"https://github.com/amdad","followers_url":"https://api.github.com/users/amdad/followers","following_url":"https://api.github.com/users/amdad/following{/other_user}","gists_url":"https://api.github.com/users/amdad/gists{/gist_id}","starred_url":"https://api.github.com/users/amdad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amdad/subscriptions","organizations_url":"https://api.github.com/users/amdad/orgs","repos_url":"https://api.github.com/users/amdad/repos","events_url":"https://api.github.com/users/amdad/events{/privacy}","received_events_url":"https://api.github.com/users/amdad/received_events","type":"User","site_admin":false},"created_at":"2017-04-13T19:12:15Z","updated_at":"2017-04-13T19:12:15Z","body":"If I thought it will be useful only for special occasions I wouldn't try to commit this to core.\r\nIn those days where we fight for every KB of data, responsive images, small JS, CDN, etc.  Preloading whole sets of media in background by default is probably not best idea. From user/viewer perspective it may be a small disaster. \r\n\r\nSimple scenario. You are on mobile with slow connection. You got 5 media files on page. You read the list, ignore first 4 and click on fifth. But, browser already waste a lot of transfer on rest of items which you don't need. What if list is longer? If someone want's to allow to preloading like this THEN he can override partial. But I think by default we should think about economy.  As you see in default markup 'controls' are in tag. Then by default left in user control, to decide what he want to see/hear (and load).\r\n\r\nEnough said. Final decision is always on your side."}}
{"actor":{"display_login":"amdad"}}