{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/126158607","pull_request_review_id":48619340,"id":126158607,"diff_hunk":"@@ -84,6 +84,21 @@ struct rgw_statvfs {\n     uint64_t     f_namemax;  /* maximum filename length */\n };\n \n+enum rgw_fl_type {\n+  RGW_FS_TYPE_FL_RDLOCK = 0,\n+  RGW_FS_TYPE_FL_WRLOCK,\n+  RGW_FS_TYPE_FL_UNLOCK,\n+};\n+\n+struct rgw_flock {\n+    uint64_t start;\n+    uint64_t length;\n+    uint64_t client;","path":"src/include/rados/rgw_file.h","position":13,"original_position":13,"commit_id":"495143eb86e0077b6861a4b08a00c1f148c85d18","original_commit_id":"adde45c2db977f0812e4734154859f3b983b9427","user":{"login":"mattbenjamin","id":301287,"avatar_url":"https://avatars1.githubusercontent.com/u/301287?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},"body":"we might need a different data type for client","created_at":"2017-07-07T14:21:11Z","updated_at":"2017-07-07T14:35:32Z","html_url":"https://github.com/ceph/ceph/pull/16207#discussion_r126158607","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/16207","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/126158607"},"html":{"href":"https://github.com/ceph/ceph/pull/16207#discussion_r126158607"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/16207"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/16207","id":129365255,"html_url":"https://github.com/ceph/ceph/pull/16207","diff_url":"https://github.com/ceph/ceph/pull/16207.diff","patch_url":"https://github.com/ceph/ceph/pull/16207.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/16207","number":16207,"state":"open","locked":false,"title":"rgw_file: add lock op support","user":{"login":"guihecheng","id":22789849,"avatar_url":"https://avatars3.githubusercontent.com/u/22789849?v=3","gravatar_id":"","url":"https://api.github.com/users/guihecheng","html_url":"https://github.com/guihecheng","followers_url":"https://api.github.com/users/guihecheng/followers","following_url":"https://api.github.com/users/guihecheng/following{/other_user}","gists_url":"https://api.github.com/users/guihecheng/gists{/gist_id}","starred_url":"https://api.github.com/users/guihecheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guihecheng/subscriptions","organizations_url":"https://api.github.com/users/guihecheng/orgs","repos_url":"https://api.github.com/users/guihecheng/repos","events_url":"https://api.github.com/users/guihecheng/events{/privacy}","received_events_url":"https://api.github.com/users/guihecheng/received_events","type":"User","site_admin":false},"body":"+ rgw_file flock api\r\n  - setlk\r\n  - getlk\r\n+ unittest\r\n  - librgw_file_locks \r\n\r\nfor now, flocks are managed in memory only, we shall consolidate them later.","created_at":"2017-07-07T09:32:12Z","updated_at":"2017-07-07T14:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbde7188994b51a72736a4b01f5cf7b81e977b6b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/16207/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/16207/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/16207/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/495143eb86e0077b6861a4b08a00c1f148c85d18","head":{"label":"guihecheng:rgw_file-flock","ref":"rgw_file-flock","sha":"495143eb86e0077b6861a4b08a00c1f148c85d18","user":{"login":"guihecheng","id":22789849,"avatar_url":"https://avatars3.githubusercontent.com/u/22789849?v=3","gravatar_id":"","url":"https://api.github.com/users/guihecheng","html_url":"https://github.com/guihecheng","followers_url":"https://api.github.com/users/guihecheng/followers","following_url":"https://api.github.com/users/guihecheng/following{/other_user}","gists_url":"https://api.github.com/users/guihecheng/gists{/gist_id}","starred_url":"https://api.github.com/users/guihecheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guihecheng/subscriptions","organizations_url":"https://api.github.com/users/guihecheng/orgs","repos_url":"https://api.github.com/users/guihecheng/repos","events_url":"https://api.github.com/users/guihecheng/events{/privacy}","received_events_url":"https://api.github.com/users/guihecheng/received_events","type":"User","site_admin":false},"repo":{"id":74082372,"name":"ceph","full_name":"guihecheng/ceph","owner":{"login":"guihecheng","id":22789849,"avatar_url":"https://avatars3.githubusercontent.com/u/22789849?v=3","gravatar_id":"","url":"https://api.github.com/users/guihecheng","html_url":"https://github.com/guihecheng","followers_url":"https://api.github.com/users/guihecheng/followers","following_url":"https://api.github.com/users/guihecheng/following{/other_user}","gists_url":"https://api.github.com/users/guihecheng/gists{/gist_id}","starred_url":"https://api.github.com/users/guihecheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guihecheng/subscriptions","organizations_url":"https://api.github.com/users/guihecheng/orgs","repos_url":"https://api.github.com/users/guihecheng/repos","events_url":"https://api.github.com/users/guihecheng/events{/privacy}","received_events_url":"https://api.github.com/users/guihecheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guihecheng/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/guihecheng/ceph","forks_url":"https://api.github.com/repos/guihecheng/ceph/forks","keys_url":"https://api.github.com/repos/guihecheng/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guihecheng/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guihecheng/ceph/teams","hooks_url":"https://api.github.com/repos/guihecheng/ceph/hooks","issue_events_url":"https://api.github.com/repos/guihecheng/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/guihecheng/ceph/events","assignees_url":"https://api.github.com/repos/guihecheng/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/guihecheng/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/guihecheng/ceph/tags","blobs_url":"https://api.github.com/repos/guihecheng/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guihecheng/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guihecheng/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/guihecheng/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guihecheng/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/guihecheng/ceph/languages","stargazers_url":"https://api.github.com/repos/guihecheng/ceph/stargazers","contributors_url":"https://api.github.com/repos/guihecheng/ceph/contributors","subscribers_url":"https://api.github.com/repos/guihecheng/ceph/subscribers","subscription_url":"https://api.github.com/repos/guihecheng/ceph/subscription","commits_url":"https://api.github.com/repos/guihecheng/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/guihecheng/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/guihecheng/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/guihecheng/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/guihecheng/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/guihecheng/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guihecheng/ceph/merges","archive_url":"https://api.github.com/repos/guihecheng/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guihecheng/ceph/downloads","issues_url":"https://api.github.com/repos/guihecheng/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/guihecheng/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/guihecheng/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/guihecheng/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guihecheng/ceph/labels{/name}","releases_url":"https://api.github.com/repos/guihecheng/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/guihecheng/ceph/deployments","created_at":"2016-11-18T01:16:42Z","updated_at":"2016-11-18T01:17:13Z","pushed_at":"2017-07-07T09:15:06Z","git_url":"git://github.com/guihecheng/ceph.git","ssh_url":"git@github.com:guihecheng/ceph.git","clone_url":"https://github.com/guihecheng/ceph.git","svn_url":"https://github.com/guihecheng/ceph","homepage":"http://ceph.com","size":230842,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"148bb4cdb54fe3af5d9dda9fdfc8b1b6e4aab6c2","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars0.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars0.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-07-07T03:09:08Z","pushed_at":"2017-07-07T14:33:24Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":226327,"stargazers_count":3365,"watchers_count":3365,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1971,"mirror_url":null,"open_issues_count":556,"forks":1971,"open_issues":556,"watchers":3365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/16207"},"html":{"href":"https://github.com/ceph/ceph/pull/16207"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/16207"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/16207/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/16207/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/16207/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/495143eb86e0077b6861a4b08a00c1f148c85d18"}}}}
{"actor":{"display_login":"mattbenjamin"}}