{"action":"created","comment":{"url":"https://api.github.com/repos/python/typeshed/pulls/comments/108294001","pull_request_review_id":29316782,"id":108294001,"diff_hunk":"@@ -31,7 +31,7 @@ class SRE_Pattern(object):\n     pattern = ...  # type: str\n     flags = ...  # type: int\n     groups = ...  # type: int\n-    groupindex = ...  # type: Mapping[int, int]\n+    groupindex = ...  # type: Mapping[str, int]","path":"stdlib/2/_sre.pyi","position":5,"original_position":5,"commit_id":"735df3c31200bb57cc89dcf749dd85e0d846a63f","original_commit_id":"735df3c31200bb57cc89dcf749dd85e0d846a63f","user":{"login":"JelleZijlstra","id":906600,"avatar_url":"https://avatars3.githubusercontent.com/u/906600?v=3","gravatar_id":"","url":"https://api.github.com/users/JelleZijlstra","html_url":"https://github.com/JelleZijlstra","followers_url":"https://api.github.com/users/JelleZijlstra/followers","following_url":"https://api.github.com/users/JelleZijlstra/following{/other_user}","gists_url":"https://api.github.com/users/JelleZijlstra/gists{/gist_id}","starred_url":"https://api.github.com/users/JelleZijlstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JelleZijlstra/subscriptions","organizations_url":"https://api.github.com/users/JelleZijlstra/orgs","repos_url":"https://api.github.com/users/JelleZijlstra/repos","events_url":"https://api.github.com/users/JelleZijlstra/events{/privacy}","received_events_url":"https://api.github.com/users/JelleZijlstra/received_events","type":"User","site_admin":false},"body":"This doesn't seem to belong in this PR.","created_at":"2017-03-27T22:16:44Z","updated_at":"2017-03-27T22:16:45Z","html_url":"https://github.com/python/typeshed/pull/1107#discussion_r108294001","pull_request_url":"https://api.github.com/repos/python/typeshed/pulls/1107","_links":{"self":{"href":"https://api.github.com/repos/python/typeshed/pulls/comments/108294001"},"html":{"href":"https://github.com/python/typeshed/pull/1107#discussion_r108294001"},"pull_request":{"href":"https://api.github.com/repos/python/typeshed/pulls/1107"}}},"pull_request":{"url":"https://api.github.com/repos/python/typeshed/pulls/1107","id":112849790,"html_url":"https://github.com/python/typeshed/pull/1107","diff_url":"https://github.com/python/typeshed/pull/1107.diff","patch_url":"https://github.com/python/typeshed/pull/1107.patch","issue_url":"https://api.github.com/repos/python/typeshed/issues/1107","number":1107,"state":"open","locked":false,"title":"Change builtin method signatures to be compatible with Sequence, at the expense of accuracy.","user":{"login":"gwk","id":406380,"avatar_url":"https://avatars1.githubusercontent.com/u/406380?v=3","gravatar_id":"","url":"https://api.github.com/users/gwk","html_url":"https://github.com/gwk","followers_url":"https://api.github.com/users/gwk/followers","following_url":"https://api.github.com/users/gwk/following{/other_user}","gists_url":"https://api.github.com/users/gwk/gists{/gist_id}","starred_url":"https://api.github.com/users/gwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwk/subscriptions","organizations_url":"https://api.github.com/users/gwk/orgs","repos_url":"https://api.github.com/users/gwk/repos","events_url":"https://api.github.com/users/gwk/events{/privacy}","received_events_url":"https://api.github.com/users/gwk/received_events","type":"User","site_admin":false},"body":"This one is a bit weird, but it's the best I could do. Essentially, some of the builtin types implementing Sequence have start/end or start/stop optional parameters that accept None, and others do not. `list` and `tuple` raise errors suggesting they accept None but actually do not. `range` does not take start/end at all. Finally, slice accepts any type implementing `__index__`, suggesting that the typing module should have a `SupportsIndex` ABC.\r\n\r\nDepending on how seriously you take this note in the `object.__index__` documentation, SupportsIndex might require `__int__` as well as `__index__`:\r\n> Note In order to have a coherent integer type class, when `__index__()` is defined `__int__()` should also be defined, and both should return the same value","created_at":"2017-03-27T22:08:35Z","updated_at":"2017-03-27T22:16:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a09007466e8eddbb1e435a3e616a56518a89c3ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/typeshed/pulls/1107/commits","review_comments_url":"https://api.github.com/repos/python/typeshed/pulls/1107/comments","review_comment_url":"https://api.github.com/repos/python/typeshed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/typeshed/issues/1107/comments","statuses_url":"https://api.github.com/repos/python/typeshed/statuses/735df3c31200bb57cc89dcf749dd85e0d846a63f","head":{"label":"gwk:pr-sequence","ref":"pr-sequence","sha":"735df3c31200bb57cc89dcf749dd85e0d846a63f","user":{"login":"gwk","id":406380,"avatar_url":"https://avatars1.githubusercontent.com/u/406380?v=3","gravatar_id":"","url":"https://api.github.com/users/gwk","html_url":"https://github.com/gwk","followers_url":"https://api.github.com/users/gwk/followers","following_url":"https://api.github.com/users/gwk/following{/other_user}","gists_url":"https://api.github.com/users/gwk/gists{/gist_id}","starred_url":"https://api.github.com/users/gwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwk/subscriptions","organizations_url":"https://api.github.com/users/gwk/orgs","repos_url":"https://api.github.com/users/gwk/repos","events_url":"https://api.github.com/users/gwk/events{/privacy}","received_events_url":"https://api.github.com/users/gwk/received_events","type":"User","site_admin":false},"repo":{"id":75574905,"name":"typeshed","full_name":"gwk/typeshed","owner":{"login":"gwk","id":406380,"avatar_url":"https://avatars1.githubusercontent.com/u/406380?v=3","gravatar_id":"","url":"https://api.github.com/users/gwk","html_url":"https://github.com/gwk","followers_url":"https://api.github.com/users/gwk/followers","following_url":"https://api.github.com/users/gwk/following{/other_user}","gists_url":"https://api.github.com/users/gwk/gists{/gist_id}","starred_url":"https://api.github.com/users/gwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwk/subscriptions","organizations_url":"https://api.github.com/users/gwk/orgs","repos_url":"https://api.github.com/users/gwk/repos","events_url":"https://api.github.com/users/gwk/events{/privacy}","received_events_url":"https://api.github.com/users/gwk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwk/typeshed","description":"Collection of library stubs for Python, with static types","fork":true,"url":"https://api.github.com/repos/gwk/typeshed","forks_url":"https://api.github.com/repos/gwk/typeshed/forks","keys_url":"https://api.github.com/repos/gwk/typeshed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwk/typeshed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwk/typeshed/teams","hooks_url":"https://api.github.com/repos/gwk/typeshed/hooks","issue_events_url":"https://api.github.com/repos/gwk/typeshed/issues/events{/number}","events_url":"https://api.github.com/repos/gwk/typeshed/events","assignees_url":"https://api.github.com/repos/gwk/typeshed/assignees{/user}","branches_url":"https://api.github.com/repos/gwk/typeshed/branches{/branch}","tags_url":"https://api.github.com/repos/gwk/typeshed/tags","blobs_url":"https://api.github.com/repos/gwk/typeshed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwk/typeshed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwk/typeshed/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwk/typeshed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwk/typeshed/statuses/{sha}","languages_url":"https://api.github.com/repos/gwk/typeshed/languages","stargazers_url":"https://api.github.com/repos/gwk/typeshed/stargazers","contributors_url":"https://api.github.com/repos/gwk/typeshed/contributors","subscribers_url":"https://api.github.com/repos/gwk/typeshed/subscribers","subscription_url":"https://api.github.com/repos/gwk/typeshed/subscription","commits_url":"https://api.github.com/repos/gwk/typeshed/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwk/typeshed/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwk/typeshed/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwk/typeshed/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwk/typeshed/contents/{+path}","compare_url":"https://api.github.com/repos/gwk/typeshed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwk/typeshed/merges","archive_url":"https://api.github.com/repos/gwk/typeshed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwk/typeshed/downloads","issues_url":"https://api.github.com/repos/gwk/typeshed/issues{/number}","pulls_url":"https://api.github.com/repos/gwk/typeshed/pulls{/number}","milestones_url":"https://api.github.com/repos/gwk/typeshed/milestones{/number}","notifications_url":"https://api.github.com/repos/gwk/typeshed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwk/typeshed/labels{/name}","releases_url":"https://api.github.com/repos/gwk/typeshed/releases{/id}","deployments_url":"https://api.github.com/repos/gwk/typeshed/deployments","created_at":"2016-12-05T00:48:54Z","updated_at":"2016-12-05T00:48:58Z","pushed_at":"2017-03-27T22:15:44Z","git_url":"git://github.com/gwk/typeshed.git","ssh_url":"git@github.com:gwk/typeshed.git","clone_url":"https://github.com/gwk/typeshed.git","svn_url":"https://github.com/gwk/typeshed","homepage":null,"size":2147,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"671d3870c279a3bafe75ab128c7175dce89d45d2","user":{"login":"python","id":1525981,"avatar_url":"https://avatars0.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":31696383,"name":"typeshed","full_name":"python/typeshed","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars0.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/typeshed","description":"Collection of library stubs for Python, with static types","fork":false,"url":"https://api.github.com/repos/python/typeshed","forks_url":"https://api.github.com/repos/python/typeshed/forks","keys_url":"https://api.github.com/repos/python/typeshed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/typeshed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/typeshed/teams","hooks_url":"https://api.github.com/repos/python/typeshed/hooks","issue_events_url":"https://api.github.com/repos/python/typeshed/issues/events{/number}","events_url":"https://api.github.com/repos/python/typeshed/events","assignees_url":"https://api.github.com/repos/python/typeshed/assignees{/user}","branches_url":"https://api.github.com/repos/python/typeshed/branches{/branch}","tags_url":"https://api.github.com/repos/python/typeshed/tags","blobs_url":"https://api.github.com/repos/python/typeshed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/typeshed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/typeshed/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/typeshed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/typeshed/statuses/{sha}","languages_url":"https://api.github.com/repos/python/typeshed/languages","stargazers_url":"https://api.github.com/repos/python/typeshed/stargazers","contributors_url":"https://api.github.com/repos/python/typeshed/contributors","subscribers_url":"https://api.github.com/repos/python/typeshed/subscribers","subscription_url":"https://api.github.com/repos/python/typeshed/subscription","commits_url":"https://api.github.com/repos/python/typeshed/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/typeshed/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/typeshed/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/typeshed/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/typeshed/contents/{+path}","compare_url":"https://api.github.com/repos/python/typeshed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/typeshed/merges","archive_url":"https://api.github.com/repos/python/typeshed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/typeshed/downloads","issues_url":"https://api.github.com/repos/python/typeshed/issues{/number}","pulls_url":"https://api.github.com/repos/python/typeshed/pulls{/number}","milestones_url":"https://api.github.com/repos/python/typeshed/milestones{/number}","notifications_url":"https://api.github.com/repos/python/typeshed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/typeshed/labels{/name}","releases_url":"https://api.github.com/repos/python/typeshed/releases{/id}","deployments_url":"https://api.github.com/repos/python/typeshed/deployments","created_at":"2015-03-05T04:51:28Z","updated_at":"2017-03-25T21:39:24Z","pushed_at":"2017-03-27T22:15:45Z","git_url":"git://github.com/python/typeshed.git","ssh_url":"git@github.com:python/typeshed.git","clone_url":"https://github.com/python/typeshed.git","svn_url":"https://github.com/python/typeshed","homepage":null,"size":2152,"stargazers_count":379,"watchers_count":379,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":221,"mirror_url":null,"open_issues_count":92,"forks":221,"open_issues":92,"watchers":379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/typeshed/pulls/1107"},"html":{"href":"https://github.com/python/typeshed/pull/1107"},"issue":{"href":"https://api.github.com/repos/python/typeshed/issues/1107"},"comments":{"href":"https://api.github.com/repos/python/typeshed/issues/1107/comments"},"review_comments":{"href":"https://api.github.com/repos/python/typeshed/pulls/1107/comments"},"review_comment":{"href":"https://api.github.com/repos/python/typeshed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/typeshed/pulls/1107/commits"},"statuses":{"href":"https://api.github.com/repos/python/typeshed/statuses/735df3c31200bb57cc89dcf749dd85e0d846a63f"}}}}
{"actor":{"display_login":"JelleZijlstra"}}