{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/127737015","pull_request_review_id":50351352,"id":127737015,"diff_hunk":"@@ -931,3 +938,26 @@ def test_same_ordering():\n     dfs_lxml = read_html(filename, index_col=0, flavor=['lxml'])\n     dfs_bs4 = read_html(filename, index_col=0, flavor=['bs4'])\n     assert_framelist_equal(dfs_lxml, dfs_bs4)\n+\n+\n+class ErrorThread(threading.Thread):\n+    def run(self):\n+        try:\n+            super(ErrorThread, self).run()\n+        except Exception as e:\n+            self.err = e\n+        else:\n+            self.err = None\n+\n+\n+@pytest.mark.slow\n+def test_importcheck_thread_safety():\n+    reload(pandas.io.html)","path":"pandas/tests/io/test_html.py","position":46,"original_position":46,"commit_id":"10aee0866e38b407c74378c1e5ef171ecb45c013","original_commit_id":"ad8541b292347fe2684737d2fe7ff097ce42f22c","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars4.githubusercontent.com/u/9273653?v=4","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"body":"Could you briefly write that as a comment above the `reload` call?","created_at":"2017-07-17T15:16:43Z","updated_at":"2017-07-17T15:16:44Z","html_url":"https://github.com/pandas-dev/pandas/pull/16930#discussion_r127737015","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/127737015"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/16930#discussion_r127737015"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930","id":130657199,"html_url":"https://github.com/pandas-dev/pandas/pull/16930","diff_url":"https://github.com/pandas-dev/pandas/pull/16930.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/16930.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/16930","number":16930,"state":"open","locked":false,"title":"EHN: Improved thread safety for read_html() GH16928","user":{"login":"3553x","id":25621909,"avatar_url":"https://avatars4.githubusercontent.com/u/25621909?v=4","gravatar_id":"","url":"https://api.github.com/users/3553x","html_url":"https://github.com/3553x","followers_url":"https://api.github.com/users/3553x/followers","following_url":"https://api.github.com/users/3553x/following{/other_user}","gists_url":"https://api.github.com/users/3553x/gists{/gist_id}","starred_url":"https://api.github.com/users/3553x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3553x/subscriptions","organizations_url":"https://api.github.com/users/3553x/orgs","repos_url":"https://api.github.com/users/3553x/repos","events_url":"https://api.github.com/users/3553x/events{/privacy}","received_events_url":"https://api.github.com/users/3553x/received_events","type":"User","site_admin":false},"body":" - [X] closes #16928\r\n - [x] tests added / passed\r\n - [X] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff`` (On Windows, ``git diff upstream/master -u -- \"*.py\" | flake8 --diff`` might work as an alternative.)\r\n - [X] whatsnew entry\r\n\r\nIt failed a total of 6 tests when running `test_fast.sh` but failed none when running `pytest pandas/tests/io/test_html.py`.\r\nIt seems that these 6 failed tests are unrelated to my changes since they also occur on the master branch.","created_at":"2017-07-14T19:25:11Z","updated_at":"2017-07-17T15:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfb0f3327279566c6b365b193e8fab4e9ac111d9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/16930/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/10aee0866e38b407c74378c1e5ef171ecb45c013","head":{"label":"3553x:read_html_thread_safety","ref":"read_html_thread_safety","sha":"10aee0866e38b407c74378c1e5ef171ecb45c013","user":{"login":"3553x","id":25621909,"avatar_url":"https://avatars4.githubusercontent.com/u/25621909?v=4","gravatar_id":"","url":"https://api.github.com/users/3553x","html_url":"https://github.com/3553x","followers_url":"https://api.github.com/users/3553x/followers","following_url":"https://api.github.com/users/3553x/following{/other_user}","gists_url":"https://api.github.com/users/3553x/gists{/gist_id}","starred_url":"https://api.github.com/users/3553x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3553x/subscriptions","organizations_url":"https://api.github.com/users/3553x/orgs","repos_url":"https://api.github.com/users/3553x/repos","events_url":"https://api.github.com/users/3553x/events{/privacy}","received_events_url":"https://api.github.com/users/3553x/received_events","type":"User","site_admin":false},"repo":{"id":97258397,"name":"pandas","full_name":"3553x/pandas","owner":{"login":"3553x","id":25621909,"avatar_url":"https://avatars4.githubusercontent.com/u/25621909?v=4","gravatar_id":"","url":"https://api.github.com/users/3553x","html_url":"https://github.com/3553x","followers_url":"https://api.github.com/users/3553x/followers","following_url":"https://api.github.com/users/3553x/following{/other_user}","gists_url":"https://api.github.com/users/3553x/gists{/gist_id}","starred_url":"https://api.github.com/users/3553x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3553x/subscriptions","organizations_url":"https://api.github.com/users/3553x/orgs","repos_url":"https://api.github.com/users/3553x/repos","events_url":"https://api.github.com/users/3553x/events{/privacy}","received_events_url":"https://api.github.com/users/3553x/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/3553x/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/3553x/pandas","forks_url":"https://api.github.com/repos/3553x/pandas/forks","keys_url":"https://api.github.com/repos/3553x/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3553x/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3553x/pandas/teams","hooks_url":"https://api.github.com/repos/3553x/pandas/hooks","issue_events_url":"https://api.github.com/repos/3553x/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/3553x/pandas/events","assignees_url":"https://api.github.com/repos/3553x/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/3553x/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/3553x/pandas/tags","blobs_url":"https://api.github.com/repos/3553x/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3553x/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3553x/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/3553x/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3553x/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/3553x/pandas/languages","stargazers_url":"https://api.github.com/repos/3553x/pandas/stargazers","contributors_url":"https://api.github.com/repos/3553x/pandas/contributors","subscribers_url":"https://api.github.com/repos/3553x/pandas/subscribers","subscription_url":"https://api.github.com/repos/3553x/pandas/subscription","commits_url":"https://api.github.com/repos/3553x/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/3553x/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/3553x/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/3553x/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/3553x/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/3553x/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3553x/pandas/merges","archive_url":"https://api.github.com/repos/3553x/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3553x/pandas/downloads","issues_url":"https://api.github.com/repos/3553x/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/3553x/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/3553x/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/3553x/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3553x/pandas/labels{/name}","releases_url":"https://api.github.com/repos/3553x/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/3553x/pandas/deployments","created_at":"2017-07-14T17:36:35Z","updated_at":"2017-07-14T17:36:42Z","pushed_at":"2017-07-17T09:08:36Z","git_url":"git://github.com/3553x/pandas.git","ssh_url":"git@github.com:3553x/pandas.git","clone_url":"https://github.com/3553x/pandas.git","svn_url":"https://github.com/3553x/pandas","homepage":"http://pandas.pydata.org","size":101733,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"ea487fc9b197285f25b066450c46fc456db09e2a","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars6.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars6.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-07-17T15:09:22Z","pushed_at":"2017-07-17T15:14:25Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":101975,"stargazers_count":10262,"watchers_count":10262,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4072,"mirror_url":null,"open_issues_count":2034,"forks":4072,"open_issues":2034,"watchers":10262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/16930"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/16930"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/16930/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16930/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/10aee0866e38b407c74378c1e5ef171ecb45c013"}}}}
{"actor":{"display_login":"gfyoung"}}