{"action":"closed","number":1902,"pull_request":{"url":"https://api.github.com/repos/haraka/Haraka/pulls/1902","id":119031686,"html_url":"https://github.com/haraka/Haraka/pull/1902","diff_url":"https://github.com/haraka/Haraka/pull/1902.diff","patch_url":"https://github.com/haraka/Haraka/pull/1902.patch","issue_url":"https://api.github.com/repos/haraka/Haraka/issues/1902","number":1902,"state":"closed","locked":false,"title":"1861 binary log","user":{"login":"msimerson","id":261635,"avatar_url":"https://avatars1.githubusercontent.com/u/261635?v=3","gravatar_id":"","url":"https://api.github.com/users/msimerson","html_url":"https://github.com/msimerson","followers_url":"https://api.github.com/users/msimerson/followers","following_url":"https://api.github.com/users/msimerson/following{/other_user}","gists_url":"https://api.github.com/users/msimerson/gists{/gist_id}","starred_url":"https://api.github.com/users/msimerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimerson/subscriptions","organizations_url":"https://api.github.com/users/msimerson/orgs","repos_url":"https://api.github.com/users/msimerson/repos","events_url":"https://api.github.com/users/msimerson/events{/privacy}","received_events_url":"https://api.github.com/users/msimerson/received_events","type":"User","site_admin":false},"body":"don't emit binary characters into the logs.\r\n\r\n- I intend to self merge and close this issue, unless someone has a good reason why binary data in the log files is actually useful.\r\n- I'm also going to address the original issue at the other end, and tell grep to always assume the log file is ascii (`grep --text`). \r\n    - done. [haraka/haraka-plugin-log-reader#11]\r\n\r\ncloses #1861 ","created_at":"2017-05-04T17:59:41Z","updated_at":"2017-05-04T18:29:50Z","closed_at":"2017-05-04T18:29:50Z","merged_at":"2017-05-04T18:29:50Z","merge_commit_sha":"1ff3931c4a8dbd10e6d070386840e837a507e814","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haraka/Haraka/pulls/1902/commits","review_comments_url":"https://api.github.com/repos/haraka/Haraka/pulls/1902/comments","review_comment_url":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haraka/Haraka/issues/1902/comments","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/88b2868f2812c61b89eb3cd6573bda2058cf557e","head":{"label":"msimerson:1861-binary-log","ref":"1861-binary-log","sha":"88b2868f2812c61b89eb3cd6573bda2058cf557e","user":{"login":"msimerson","id":261635,"avatar_url":"https://avatars1.githubusercontent.com/u/261635?v=3","gravatar_id":"","url":"https://api.github.com/users/msimerson","html_url":"https://github.com/msimerson","followers_url":"https://api.github.com/users/msimerson/followers","following_url":"https://api.github.com/users/msimerson/following{/other_user}","gists_url":"https://api.github.com/users/msimerson/gists{/gist_id}","starred_url":"https://api.github.com/users/msimerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimerson/subscriptions","organizations_url":"https://api.github.com/users/msimerson/orgs","repos_url":"https://api.github.com/users/msimerson/repos","events_url":"https://api.github.com/users/msimerson/events{/privacy}","received_events_url":"https://api.github.com/users/msimerson/received_events","type":"User","site_admin":false},"repo":{"id":80856379,"name":"Haraka","full_name":"msimerson/Haraka","owner":{"login":"msimerson","id":261635,"avatar_url":"https://avatars1.githubusercontent.com/u/261635?v=3","gravatar_id":"","url":"https://api.github.com/users/msimerson","html_url":"https://github.com/msimerson","followers_url":"https://api.github.com/users/msimerson/followers","following_url":"https://api.github.com/users/msimerson/following{/other_user}","gists_url":"https://api.github.com/users/msimerson/gists{/gist_id}","starred_url":"https://api.github.com/users/msimerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msimerson/subscriptions","organizations_url":"https://api.github.com/users/msimerson/orgs","repos_url":"https://api.github.com/users/msimerson/repos","events_url":"https://api.github.com/users/msimerson/events{/privacy}","received_events_url":"https://api.github.com/users/msimerson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msimerson/Haraka","description":"An event driven SMTP server","fork":true,"url":"https://api.github.com/repos/msimerson/Haraka","forks_url":"https://api.github.com/repos/msimerson/Haraka/forks","keys_url":"https://api.github.com/repos/msimerson/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msimerson/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msimerson/Haraka/teams","hooks_url":"https://api.github.com/repos/msimerson/Haraka/hooks","issue_events_url":"https://api.github.com/repos/msimerson/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/msimerson/Haraka/events","assignees_url":"https://api.github.com/repos/msimerson/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/msimerson/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/msimerson/Haraka/tags","blobs_url":"https://api.github.com/repos/msimerson/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msimerson/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msimerson/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/msimerson/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msimerson/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/msimerson/Haraka/languages","stargazers_url":"https://api.github.com/repos/msimerson/Haraka/stargazers","contributors_url":"https://api.github.com/repos/msimerson/Haraka/contributors","subscribers_url":"https://api.github.com/repos/msimerson/Haraka/subscribers","subscription_url":"https://api.github.com/repos/msimerson/Haraka/subscription","commits_url":"https://api.github.com/repos/msimerson/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/msimerson/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/msimerson/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/msimerson/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/msimerson/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/msimerson/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msimerson/Haraka/merges","archive_url":"https://api.github.com/repos/msimerson/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msimerson/Haraka/downloads","issues_url":"https://api.github.com/repos/msimerson/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/msimerson/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/msimerson/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/msimerson/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msimerson/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/msimerson/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/msimerson/Haraka/deployments","created_at":"2017-02-03T18:19:41Z","updated_at":"2017-02-03T18:19:44Z","pushed_at":"2017-05-04T17:56:28Z","git_url":"git://github.com/msimerson/Haraka.git","ssh_url":"git@github.com:msimerson/Haraka.git","clone_url":"https://github.com/msimerson/Haraka.git","svn_url":"https://github.com/msimerson/Haraka","homepage":"http://haraka.github.io/","size":5005,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haraka:master","ref":"master","sha":"ab0513333b3d3feef320e59fca81f57bd8ce0679","user":{"login":"haraka","id":1111229,"avatar_url":"https://avatars0.githubusercontent.com/u/1111229?v=3","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"repo":{"id":1464380,"name":"Haraka","full_name":"haraka/Haraka","owner":{"login":"haraka","id":1111229,"avatar_url":"https://avatars0.githubusercontent.com/u/1111229?v=3","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haraka/Haraka","description":"A fast, highly extensible, and event driven SMTP server","fork":false,"url":"https://api.github.com/repos/haraka/Haraka","forks_url":"https://api.github.com/repos/haraka/Haraka/forks","keys_url":"https://api.github.com/repos/haraka/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haraka/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haraka/Haraka/teams","hooks_url":"https://api.github.com/repos/haraka/Haraka/hooks","issue_events_url":"https://api.github.com/repos/haraka/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/haraka/Haraka/events","assignees_url":"https://api.github.com/repos/haraka/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/haraka/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/haraka/Haraka/tags","blobs_url":"https://api.github.com/repos/haraka/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haraka/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haraka/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/haraka/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/haraka/Haraka/languages","stargazers_url":"https://api.github.com/repos/haraka/Haraka/stargazers","contributors_url":"https://api.github.com/repos/haraka/Haraka/contributors","subscribers_url":"https://api.github.com/repos/haraka/Haraka/subscribers","subscription_url":"https://api.github.com/repos/haraka/Haraka/subscription","commits_url":"https://api.github.com/repos/haraka/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/haraka/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/haraka/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/haraka/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/haraka/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/haraka/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haraka/Haraka/merges","archive_url":"https://api.github.com/repos/haraka/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haraka/Haraka/downloads","issues_url":"https://api.github.com/repos/haraka/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/haraka/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/haraka/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/haraka/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haraka/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/haraka/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/haraka/Haraka/deployments","created_at":"2011-03-10T17:00:20Z","updated_at":"2017-05-04T04:19:03Z","pushed_at":"2017-05-04T18:29:50Z","git_url":"git://github.com/haraka/Haraka.git","ssh_url":"git@github.com:haraka/Haraka.git","clone_url":"https://github.com/haraka/Haraka.git","svn_url":"https://github.com/haraka/Haraka","homepage":"http://haraka.github.io/","size":5094,"stargazers_count":2454,"watchers_count":2454,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"open_issues_count":50,"forks":363,"open_issues":50,"watchers":2454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1902"},"html":{"href":"https://github.com/haraka/Haraka/pull/1902"},"issue":{"href":"https://api.github.com/repos/haraka/Haraka/issues/1902"},"comments":{"href":"https://api.github.com/repos/haraka/Haraka/issues/1902/comments"},"review_comments":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1902/comments"},"review_comment":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/1902/commits"},"statuses":{"href":"https://api.github.com/repos/haraka/Haraka/statuses/88b2868f2812c61b89eb3cd6573bda2058cf557e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"smfreegard","id":550490,"avatar_url":"https://avatars0.githubusercontent.com/u/550490?v=3","gravatar_id":"","url":"https://api.github.com/users/smfreegard","html_url":"https://github.com/smfreegard","followers_url":"https://api.github.com/users/smfreegard/followers","following_url":"https://api.github.com/users/smfreegard/following{/other_user}","gists_url":"https://api.github.com/users/smfreegard/gists{/gist_id}","starred_url":"https://api.github.com/users/smfreegard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smfreegard/subscriptions","organizations_url":"https://api.github.com/users/smfreegard/orgs","repos_url":"https://api.github.com/users/smfreegard/repos","events_url":"https://api.github.com/users/smfreegard/events{/privacy}","received_events_url":"https://api.github.com/users/smfreegard/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"smfreegard"}}