{"action":"created","comment":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/143330869","pull_request_review_id":67833216,"id":143330869,"diff_hunk":"@@ -4635,7 +4635,7 @@ function showOptionals($extrafields, $mode='view', $params=null, $keyprefix='')\n \t\t\t\t\tcase \"edit\":\n \t\t\t\t\t\t// GETPOST(\"options_\" . $key) can be 'abc' or array(0=>'abc')\n \t\t\t\t\t\t$getposttemp = GETPOST('options_'.$key, 'none');\t\t\t\t// GETPOST can get value from GET, POST or setup of default values.\n-\t\t\t\t\t\tif (isset($getposttemp)) {\n+\t\t\t\t\t\tif (isset($getposttemp) && $getposttemp != '') {","path":"htdocs/core/class/commonobject.class.php","position":5,"original_position":5,"commit_id":"03ed776d3337a33e2aa1eadcdf96dd72955e4250","original_commit_id":"03ed776d3337a33e2aa1eadcdf96dd72955e4250","user":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"body":"@eldy \r\nadd an extrafields in thirdparty by example, edit a thirdparty and add value in field, valid... the value is visible in view mode,  but edit again this thirparty, the value is hidden in edit mode","created_at":"2017-10-07T13:34:01Z","updated_at":"2017-10-07T13:34:01Z","html_url":"https://github.com/Dolibarr/dolibarr/pull/7585#discussion_r143330869","pull_request_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments/143330869"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/7585#discussion_r143330869"},"pull_request":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585"}},"in_reply_to_id":143329107},"pull_request":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585","id":145286521,"html_url":"https://github.com/Dolibarr/dolibarr/pull/7585","diff_url":"https://github.com/Dolibarr/dolibarr/pull/7585.diff","patch_url":"https://github.com/Dolibarr/dolibarr/pull/7585.patch","issue_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7585","number":7585,"state":"open","locked":false,"title":"Fix: check if value is not empty","user":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"body":"@eldy ","created_at":"2017-10-07T10:42:11Z","updated_at":"2017-10-07T13:34:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"366d28c53621390d4f1d34fe555a365476006526","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585/commits","review_comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585/comments","review_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7585/comments","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/03ed776d3337a33e2aa1eadcdf96dd72955e4250","head":{"label":"hregis:develop_bug","ref":"develop_bug","sha":"03ed776d3337a33e2aa1eadcdf96dd72955e4250","user":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"repo":{"id":2254163,"name":"dolibarr","full_name":"hregis/dolibarr","owner":{"login":"hregis","id":454387,"avatar_url":"https://avatars0.githubusercontent.com/u/454387?v=4","gravatar_id":"","url":"https://api.github.com/users/hregis","html_url":"https://github.com/hregis","followers_url":"https://api.github.com/users/hregis/followers","following_url":"https://api.github.com/users/hregis/following{/other_user}","gists_url":"https://api.github.com/users/hregis/gists{/gist_id}","starred_url":"https://api.github.com/users/hregis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hregis/subscriptions","organizations_url":"https://api.github.com/users/hregis/orgs","repos_url":"https://api.github.com/users/hregis/repos","events_url":"https://api.github.com/users/hregis/events{/privacy}","received_events_url":"https://api.github.com/users/hregis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hregis/dolibarr","description":"Dolibarr ERP/CRM is a modern software to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's an opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":true,"url":"https://api.github.com/repos/hregis/dolibarr","forks_url":"https://api.github.com/repos/hregis/dolibarr/forks","keys_url":"https://api.github.com/repos/hregis/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hregis/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hregis/dolibarr/teams","hooks_url":"https://api.github.com/repos/hregis/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/hregis/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/hregis/dolibarr/events","assignees_url":"https://api.github.com/repos/hregis/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/hregis/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/hregis/dolibarr/tags","blobs_url":"https://api.github.com/repos/hregis/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hregis/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hregis/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/hregis/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hregis/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/hregis/dolibarr/languages","stargazers_url":"https://api.github.com/repos/hregis/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/hregis/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/hregis/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/hregis/dolibarr/subscription","commits_url":"https://api.github.com/repos/hregis/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/hregis/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/hregis/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/hregis/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/hregis/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/hregis/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hregis/dolibarr/merges","archive_url":"https://api.github.com/repos/hregis/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hregis/dolibarr/downloads","issues_url":"https://api.github.com/repos/hregis/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/hregis/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/hregis/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/hregis/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hregis/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/hregis/dolibarr/releases{/id}","deployments_url":"https://api.github.com/repos/hregis/dolibarr/deployments","created_at":"2011-08-23T09:21:05Z","updated_at":"2015-05-07T10:08:32Z","pushed_at":"2017-10-07T10:41:31Z","git_url":"git://github.com/hregis/dolibarr.git","ssh_url":"git@github.com:hregis/dolibarr.git","clone_url":"https://github.com/hregis/dolibarr.git","svn_url":"https://github.com/hregis/dolibarr","homepage":"http://www.dolibarr.org","size":412879,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"Dolibarr:develop","ref":"develop","sha":"41716281eda8b4c674f37402c117f5b30ec4ae3e","user":{"login":"Dolibarr","id":877491,"avatar_url":"https://avatars0.githubusercontent.com/u/877491?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"repo":{"id":1957456,"name":"dolibarr","full_name":"Dolibarr/dolibarr","owner":{"login":"Dolibarr","id":877491,"avatar_url":"https://avatars0.githubusercontent.com/u/877491?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolibarr","html_url":"https://github.com/Dolibarr","followers_url":"https://api.github.com/users/Dolibarr/followers","following_url":"https://api.github.com/users/Dolibarr/following{/other_user}","gists_url":"https://api.github.com/users/Dolibarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolibarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolibarr/subscriptions","organizations_url":"https://api.github.com/users/Dolibarr/orgs","repos_url":"https://api.github.com/users/Dolibarr/repos","events_url":"https://api.github.com/users/Dolibarr/events{/privacy}","received_events_url":"https://api.github.com/users/Dolibarr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Dolibarr/dolibarr","description":"Dolibarr ERP CRM is a modern software package to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.","fork":false,"url":"https://api.github.com/repos/Dolibarr/dolibarr","forks_url":"https://api.github.com/repos/Dolibarr/dolibarr/forks","keys_url":"https://api.github.com/repos/Dolibarr/dolibarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dolibarr/dolibarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dolibarr/dolibarr/teams","hooks_url":"https://api.github.com/repos/Dolibarr/dolibarr/hooks","issue_events_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/events{/number}","events_url":"https://api.github.com/repos/Dolibarr/dolibarr/events","assignees_url":"https://api.github.com/repos/Dolibarr/dolibarr/assignees{/user}","branches_url":"https://api.github.com/repos/Dolibarr/dolibarr/branches{/branch}","tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/tags","blobs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/{sha}","languages_url":"https://api.github.com/repos/Dolibarr/dolibarr/languages","stargazers_url":"https://api.github.com/repos/Dolibarr/dolibarr/stargazers","contributors_url":"https://api.github.com/repos/Dolibarr/dolibarr/contributors","subscribers_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscribers","subscription_url":"https://api.github.com/repos/Dolibarr/dolibarr/subscription","commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dolibarr/dolibarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dolibarr/dolibarr/contents/{+path}","compare_url":"https://api.github.com/repos/Dolibarr/dolibarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dolibarr/dolibarr/merges","archive_url":"https://api.github.com/repos/Dolibarr/dolibarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dolibarr/dolibarr/downloads","issues_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues{/number}","pulls_url":"https://api.github.com/repos/Dolibarr/dolibarr/pulls{/number}","milestones_url":"https://api.github.com/repos/Dolibarr/dolibarr/milestones{/number}","notifications_url":"https://api.github.com/repos/Dolibarr/dolibarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dolibarr/dolibarr/labels{/name}","releases_url":"https://api.github.com/repos/Dolibarr/dolibarr/releases{/id}","deployments_url":"https://api.github.com/repos/Dolibarr/dolibarr/deployments","created_at":"2011-06-26T21:55:03Z","updated_at":"2017-10-05T06:21:08Z","pushed_at":"2017-10-07T12:54:34Z","git_url":"git://github.com/Dolibarr/dolibarr.git","ssh_url":"git@github.com:Dolibarr/dolibarr.git","clone_url":"https://github.com/Dolibarr/dolibarr.git","svn_url":"https://github.com/Dolibarr/dolibarr","homepage":"https://www.dolibarr.org","size":412897,"stargazers_count":806,"watchers_count":806,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":665,"mirror_url":null,"open_issues_count":752,"forks":665,"open_issues":752,"watchers":806,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585"},"html":{"href":"https://github.com/Dolibarr/dolibarr/pull/7585"},"issue":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7585"},"comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/issues/7585/comments"},"review_comments":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585/comments"},"review_comment":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/pulls/7585/commits"},"statuses":{"href":"https://api.github.com/repos/Dolibarr/dolibarr/statuses/03ed776d3337a33e2aa1eadcdf96dd72955e4250"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hregis"}}