{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-simulators/issues/1313","repository_url":"https://api.github.com/repos/OPM/opm-simulators","labels_url":"https://api.github.com/repos/OPM/opm-simulators/issues/1313/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-simulators/issues/1313/comments","events_url":"https://api.github.com/repos/OPM/opm-simulators/issues/1313/events","html_url":"https://github.com/OPM/opm-simulators/pull/1313","id":269103946,"number":1313,"title":"Make the wellModel self-contained","user":{"login":"totto82","id":3223024,"avatar_url":"https://avatars1.githubusercontent.com/u/3223024?v=4","gravatar_id":"","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-10-27T13:17:44Z","updated_at":"2017-11-08T12:01:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OPM/opm-simulators/pulls/1313","html_url":"https://github.com/OPM/opm-simulators/pull/1313","diff_url":"https://github.com/OPM/opm-simulators/pull/1313.diff","patch_url":"https://github.com/OPM/opm-simulators/pull/1313.patch"},"body":"The wellModel is now persistent over the time steps,\r\nwith an update method called every reportStep/episode.\r\n\r\nThis allows the following simplifications:\r\n1) move the wellState to the WellModel\r\n2) add a ref to the ebosSimulator to the wellModel\r\n3) clean up the parameters passed to the wellModel methods\r\n4) split the legacy ADB VFP table code.\r\n5) move RESV handling to the WellModel and the rateConverter\r\n6) move the econLimit update to the WellModel\r\n\r\nThis has been tested on norne and with unit tests on OPM simulators.\r\n\r\nThis should not be merged before the release. \r\nIt also needs to be tested on Rel0++ "},"comment":{"url":"https://api.github.com/repos/OPM/opm-simulators/issues/comments/342797446","html_url":"https://github.com/OPM/opm-simulators/pull/1313#issuecomment-342797446","issue_url":"https://api.github.com/repos/OPM/opm-simulators/issues/1313","id":342797446,"user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars0.githubusercontent.com/u/1876621?v=4","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"created_at":"2017-11-08T12:01:50Z","updated_at":"2017-11-08T12:01:50Z","author_association":"OWNER","body":"> OK, I will do it. I will also revert the include \" \" style before we spent to much time discussion it so this PR becomes purely about stuffing all well related stuff into the well model.\r\n\r\nThanks a lot!"}}
{"actor":{"display_login":"atgeirr"}}