{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/105526015","pull_request_review_id":26415772,"id":105526015,"diff_hunk":"@@ -244,30 +245,59 @@ public static String simpleClassName(Class<?> clazz) {\n      * @return {@link CharSequence} the escaped value if necessary, or the value unchanged\n      */\n     public static CharSequence escapeCsv(CharSequence value) {\n+        return escapeCsv(value, false);\n+    }\n+\n+    /**\n+     * Escapes the specified value, if necessary according to\n+     * <a href=\"https://tools.ietf.org/html/rfc4180#section-2\">RFC-4180</a>.\n+     *\n+     * @param value          The value which will be escaped according to\n+     *                       <a href=\"https://tools.ietf.org/html/rfc4180#section-2\">RFC-4180</a>\n+     * @param trimWhiteSpace The value will first be trimmed of its optional white-space characters,\n+     *                       according to <a href=\"https://tools.ietf.org/html/rfc7230#section-7\">RFC-7230</a>\n+     * @return {@link CharSequence} the escaped value if necessary, or the value unchanged\n+     */\n+    public static CharSequence escapeCsv(CharSequence value, boolean trimWhiteSpace) {","path":"common/src/main/java/io/netty/util/internal/StringUtil.java","position":81,"original_position":81,"commit_id":"2c52bc40caf8264826ddd355e7bffb756f12f7cf","original_commit_id":"2c52bc40caf8264826ddd355e7bffb756f12f7cf","user":{"login":"netkins","id":9507557,"avatar_url":"https://avatars0.githubusercontent.com/u/9507557?v=3","gravatar_id":"","url":"https://api.github.com/users/netkins","html_url":"https://github.com/netkins","followers_url":"https://api.github.com/users/netkins/followers","following_url":"https://api.github.com/users/netkins/following{/other_user}","gists_url":"https://api.github.com/users/netkins/gists{/gist_id}","starred_url":"https://api.github.com/users/netkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netkins/subscriptions","organizations_url":"https://api.github.com/users/netkins/orgs","repos_url":"https://api.github.com/users/netkins/repos","events_url":"https://api.github.com/users/netkins/events{/privacy}","received_events_url":"https://api.github.com/users/netkins/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) The Cyclomatic Complexity of this method \"escapeCsv\" is 28 which is greater than 25 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://garage.netty.io/sonarqube/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n","created_at":"2017-03-11T04:48:48Z","updated_at":"2017-03-11T04:48:48Z","html_url":"https://github.com/netty/netty/pull/6502#discussion_r105526015","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/6502","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/105526015"},"html":{"href":"https://github.com/netty/netty/pull/6502#discussion_r105526015"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/6502"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/6502","id":109392959,"html_url":"https://github.com/netty/netty/pull/6502","diff_url":"https://github.com/netty/netty/pull/6502.diff","patch_url":"https://github.com/netty/netty/pull/6502.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/6502","number":6502,"state":"open","locked":false,"title":"Trim optional white space in CombinedHttpHeaders values","user":{"login":"ddossot","id":119028,"avatar_url":"https://avatars0.githubusercontent.com/u/119028?v=3","gravatar_id":"","url":"https://api.github.com/users/ddossot","html_url":"https://github.com/ddossot","followers_url":"https://api.github.com/users/ddossot/followers","following_url":"https://api.github.com/users/ddossot/following{/other_user}","gists_url":"https://api.github.com/users/ddossot/gists{/gist_id}","starred_url":"https://api.github.com/users/ddossot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddossot/subscriptions","organizations_url":"https://api.github.com/users/ddossot/orgs","repos_url":"https://api.github.com/users/ddossot/repos","events_url":"https://api.github.com/users/ddossot/events{/privacy}","received_events_url":"https://api.github.com/users/ddossot/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nThe updated HTTP/1.x RFC allows for header values to be `CSV` and separated by `OWS` [1]. `CombinedHttpHeaders` should remove this `OWS` on insertion.\r\n\r\n[1] https://tools.ietf.org/html/rfc7230#section-7\r\n\r\nModification:\r\n\r\n`CombinedHttpHeaders` doesn't account for the `OWS` and returns it back to the user as part of the value.\r\n\r\nResult:\r\n\r\nFixes #6452","created_at":"2017-03-07T02:19:09Z","updated_at":"2017-03-11T04:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9b706636e5248e0a981a8242fbde2b22c4db4f0","assignee":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars3.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"assignees":[{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars3.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/6502/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/6502/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/6502/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/2c52bc40caf8264826ddd355e7bffb756f12f7cf","head":{"label":"ddossot:6452-trim-ows-in-header-values","ref":"6452-trim-ows-in-header-values","sha":"2c52bc40caf8264826ddd355e7bffb756f12f7cf","user":{"login":"ddossot","id":119028,"avatar_url":"https://avatars0.githubusercontent.com/u/119028?v=3","gravatar_id":"","url":"https://api.github.com/users/ddossot","html_url":"https://github.com/ddossot","followers_url":"https://api.github.com/users/ddossot/followers","following_url":"https://api.github.com/users/ddossot/following{/other_user}","gists_url":"https://api.github.com/users/ddossot/gists{/gist_id}","starred_url":"https://api.github.com/users/ddossot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddossot/subscriptions","organizations_url":"https://api.github.com/users/ddossot/orgs","repos_url":"https://api.github.com/users/ddossot/repos","events_url":"https://api.github.com/users/ddossot/events{/privacy}","received_events_url":"https://api.github.com/users/ddossot/received_events","type":"User","site_admin":false},"repo":{"id":17524940,"name":"netty","full_name":"ddossot/netty","owner":{"login":"ddossot","id":119028,"avatar_url":"https://avatars0.githubusercontent.com/u/119028?v=3","gravatar_id":"","url":"https://api.github.com/users/ddossot","html_url":"https://github.com/ddossot","followers_url":"https://api.github.com/users/ddossot/followers","following_url":"https://api.github.com/users/ddossot/following{/other_user}","gists_url":"https://api.github.com/users/ddossot/gists{/gist_id}","starred_url":"https://api.github.com/users/ddossot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddossot/subscriptions","organizations_url":"https://api.github.com/users/ddossot/orgs","repos_url":"https://api.github.com/users/ddossot/repos","events_url":"https://api.github.com/users/ddossot/events{/privacy}","received_events_url":"https://api.github.com/users/ddossot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddossot/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/ddossot/netty","forks_url":"https://api.github.com/repos/ddossot/netty/forks","keys_url":"https://api.github.com/repos/ddossot/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddossot/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddossot/netty/teams","hooks_url":"https://api.github.com/repos/ddossot/netty/hooks","issue_events_url":"https://api.github.com/repos/ddossot/netty/issues/events{/number}","events_url":"https://api.github.com/repos/ddossot/netty/events","assignees_url":"https://api.github.com/repos/ddossot/netty/assignees{/user}","branches_url":"https://api.github.com/repos/ddossot/netty/branches{/branch}","tags_url":"https://api.github.com/repos/ddossot/netty/tags","blobs_url":"https://api.github.com/repos/ddossot/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddossot/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddossot/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddossot/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddossot/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/ddossot/netty/languages","stargazers_url":"https://api.github.com/repos/ddossot/netty/stargazers","contributors_url":"https://api.github.com/repos/ddossot/netty/contributors","subscribers_url":"https://api.github.com/repos/ddossot/netty/subscribers","subscription_url":"https://api.github.com/repos/ddossot/netty/subscription","commits_url":"https://api.github.com/repos/ddossot/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddossot/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddossot/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddossot/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddossot/netty/contents/{+path}","compare_url":"https://api.github.com/repos/ddossot/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddossot/netty/merges","archive_url":"https://api.github.com/repos/ddossot/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddossot/netty/downloads","issues_url":"https://api.github.com/repos/ddossot/netty/issues{/number}","pulls_url":"https://api.github.com/repos/ddossot/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/ddossot/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/ddossot/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddossot/netty/labels{/name}","releases_url":"https://api.github.com/repos/ddossot/netty/releases{/id}","deployments_url":"https://api.github.com/repos/ddossot/netty/deployments","created_at":"2014-03-07T19:33:42Z","updated_at":"2014-03-10T14:28:18Z","pushed_at":"2017-03-11T02:43:50Z","git_url":"git://github.com/ddossot/netty.git","ssh_url":"git@github.com:ddossot/netty.git","clone_url":"https://github.com/ddossot/netty.git","svn_url":"https://github.com/ddossot/netty","homepage":"http://netty.io/","size":37555,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"3861b7de2bd1c1e845ba11f80c73c2e1c466c009","user":{"login":"netty","id":473791,"avatar_url":"https://avatars2.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars2.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2017-03-11T04:19:19Z","pushed_at":"2017-03-11T02:43:59Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":46157,"stargazers_count":9336,"watchers_count":9336,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4587,"mirror_url":null,"open_issues_count":348,"forks":4587,"open_issues":348,"watchers":9336,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/6502"},"html":{"href":"https://github.com/netty/netty/pull/6502"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/6502"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/6502/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/6502/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/6502/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/2c52bc40caf8264826ddd355e7bffb756f12f7cf"}}}}
{"actor":{"display_login":"netkins"}}