{"action":"created","comment":{"url":"https://api.github.com/repos/jvilk/BrowserFS/pulls/comments/130713787","pull_request_review_id":53616903,"id":130713787,"diff_hunk":"@@ -69,11 +75,12 @@ export default class XmlHttpRequest extends BaseFileSystem implements FileSystem\n     if (typeof(opts.index) === \"string\") {\n       XmlHttpRequest.FromURL(opts.index, cb, opts.baseUrl, false);\n     } else {\n-      cb(null, new XmlHttpRequest(opts.index, opts.baseUrl, false));\n+      cb(null, new XmlHttpRequest(opts.index, opts.baseUrl, false, opts.use));\n     }\n   }\n   public static isAvailable(): boolean {\n-    return typeof(XMLHttpRequest) !== \"undefined\" && XMLHttpRequest !== null;\n+    return (typeof(fetch) !== \"undefined\" && fetch !== null) ||\n+           (typeof(XMLHttpRequest) !== \"undefined\" && XMLHttpRequest !== null);","path":"src/backend/XmlHttpRequest.ts","position":33,"original_position":33,"commit_id":"1bbbcc6183d6d1b09e7bc5661c4bb4c33f0f4fc1","original_commit_id":"1bbbcc6183d6d1b09e7bc5661c4bb4c33f0f4fc1","user":{"login":"jvilk","id":1141042,"avatar_url":"https://avatars1.githubusercontent.com/u/1141042?v=4","gravatar_id":"","url":"https://api.github.com/users/jvilk","html_url":"https://github.com/jvilk","followers_url":"https://api.github.com/users/jvilk/followers","following_url":"https://api.github.com/users/jvilk/following{/other_user}","gists_url":"https://api.github.com/users/jvilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jvilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvilk/subscriptions","organizations_url":"https://api.github.com/users/jvilk/orgs","repos_url":"https://api.github.com/users/jvilk/repos","events_url":"https://api.github.com/users/jvilk/events{/privacy}","received_events_url":"https://api.github.com/users/jvilk/received_events","type":"User","site_admin":false},"body":"Note: `supportsSynch()` needs to be updated in the Node case. If `XMLHttpRequest` isn't available, there is no way to synchronously download files, and `supportsSynch()` should return `false`.","created_at":"2017-08-01T20:08:25Z","updated_at":"2017-08-01T20:18:16Z","html_url":"https://github.com/jvilk/BrowserFS/pull/185#discussion_r130713787","pull_request_url":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/jvilk/BrowserFS/pulls/comments/130713787"},"html":{"href":"https://github.com/jvilk/BrowserFS/pull/185#discussion_r130713787"},"pull_request":{"href":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185","id":133263252,"html_url":"https://github.com/jvilk/BrowserFS/pull/185","diff_url":"https://github.com/jvilk/BrowserFS/pull/185.diff","patch_url":"https://github.com/jvilk/BrowserFS/pull/185.patch","issue_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/185","number":185,"state":"open","locked":false,"title":"Support for window.fetch","user":{"login":"wmhilton","id":587740,"avatar_url":"https://avatars2.githubusercontent.com/u/587740?v=4","gravatar_id":"","url":"https://api.github.com/users/wmhilton","html_url":"https://github.com/wmhilton","followers_url":"https://api.github.com/users/wmhilton/followers","following_url":"https://api.github.com/users/wmhilton/following{/other_user}","gists_url":"https://api.github.com/users/wmhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/wmhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmhilton/subscriptions","organizations_url":"https://api.github.com/users/wmhilton/orgs","repos_url":"https://api.github.com/users/wmhilton/repos","events_url":"https://api.github.com/users/wmhilton/events{/privacy}","received_events_url":"https://api.github.com/users/wmhilton/received_events","type":"User","site_admin":false},"body":"I'm starting to work on issue #182 . It's very basic right now. ~~, and I haven't tested to see if it works. I also can't get `npm test` to run on my machine so I'm relying on Travis for feedback.~~\r\n\r\nTODOs\r\n- [ ] rename?\r\n- [ ] tests\r\n- [ ] doc\r\n- [ ] Configuration option: Use XHR instead of Fetch\r\n- [ ] Test factory: Create fetch / non-fetch variants.","created_at":"2017-07-31T14:47:12Z","updated_at":"2017-08-01T20:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e41a204878b38b8e3e4635870c76116e2d7ee6de","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185/commits","review_comments_url":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185/comments","review_comment_url":"https://api.github.com/repos/jvilk/BrowserFS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/185/comments","statuses_url":"https://api.github.com/repos/jvilk/BrowserFS/statuses/1bbbcc6183d6d1b09e7bc5661c4bb4c33f0f4fc1","head":{"label":"wmhilton-contrib:window.fetch","ref":"window.fetch","sha":"1bbbcc6183d6d1b09e7bc5661c4bb4c33f0f4fc1","user":{"login":"wmhilton-contrib","id":25273533,"avatar_url":"https://avatars3.githubusercontent.com/u/25273533?v=4","gravatar_id":"","url":"https://api.github.com/users/wmhilton-contrib","html_url":"https://github.com/wmhilton-contrib","followers_url":"https://api.github.com/users/wmhilton-contrib/followers","following_url":"https://api.github.com/users/wmhilton-contrib/following{/other_user}","gists_url":"https://api.github.com/users/wmhilton-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/wmhilton-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmhilton-contrib/subscriptions","organizations_url":"https://api.github.com/users/wmhilton-contrib/orgs","repos_url":"https://api.github.com/users/wmhilton-contrib/repos","events_url":"https://api.github.com/users/wmhilton-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/wmhilton-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":98127736,"name":"BrowserFS","full_name":"wmhilton-contrib/BrowserFS","owner":{"login":"wmhilton-contrib","id":25273533,"avatar_url":"https://avatars3.githubusercontent.com/u/25273533?v=4","gravatar_id":"","url":"https://api.github.com/users/wmhilton-contrib","html_url":"https://github.com/wmhilton-contrib","followers_url":"https://api.github.com/users/wmhilton-contrib/followers","following_url":"https://api.github.com/users/wmhilton-contrib/following{/other_user}","gists_url":"https://api.github.com/users/wmhilton-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/wmhilton-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmhilton-contrib/subscriptions","organizations_url":"https://api.github.com/users/wmhilton-contrib/orgs","repos_url":"https://api.github.com/users/wmhilton-contrib/repos","events_url":"https://api.github.com/users/wmhilton-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/wmhilton-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmhilton-contrib/BrowserFS","description":"BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.","fork":true,"url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS","forks_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/forks","keys_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/teams","hooks_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/hooks","issue_events_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/issues/events{/number}","events_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/events","assignees_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/assignees{/user}","branches_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/branches{/branch}","tags_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/tags","blobs_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/statuses/{sha}","languages_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/languages","stargazers_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/stargazers","contributors_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/contributors","subscribers_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/subscribers","subscription_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/subscription","commits_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/contents/{+path}","compare_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/merges","archive_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/downloads","issues_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/issues{/number}","pulls_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/pulls{/number}","milestones_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/milestones{/number}","notifications_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/labels{/name}","releases_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/releases{/id}","deployments_url":"https://api.github.com/repos/wmhilton-contrib/BrowserFS/deployments","created_at":"2017-07-23T21:54:54Z","updated_at":"2017-07-23T21:54:56Z","pushed_at":"2017-08-01T19:14:06Z","git_url":"git://github.com/wmhilton-contrib/BrowserFS.git","ssh_url":"git@github.com:wmhilton-contrib/BrowserFS.git","clone_url":"https://github.com/wmhilton-contrib/BrowserFS.git","svn_url":"https://github.com/wmhilton-contrib/BrowserFS","homepage":null,"size":7784,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jvilk:master","ref":"master","sha":"df2993934f4cc7074590a52f2737c5ce4aa179cc","user":{"login":"jvilk","id":1141042,"avatar_url":"https://avatars1.githubusercontent.com/u/1141042?v=4","gravatar_id":"","url":"https://api.github.com/users/jvilk","html_url":"https://github.com/jvilk","followers_url":"https://api.github.com/users/jvilk/followers","following_url":"https://api.github.com/users/jvilk/following{/other_user}","gists_url":"https://api.github.com/users/jvilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jvilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvilk/subscriptions","organizations_url":"https://api.github.com/users/jvilk/orgs","repos_url":"https://api.github.com/users/jvilk/repos","events_url":"https://api.github.com/users/jvilk/events{/privacy}","received_events_url":"https://api.github.com/users/jvilk/received_events","type":"User","site_admin":false},"repo":{"id":9527640,"name":"BrowserFS","full_name":"jvilk/BrowserFS","owner":{"login":"jvilk","id":1141042,"avatar_url":"https://avatars1.githubusercontent.com/u/1141042?v=4","gravatar_id":"","url":"https://api.github.com/users/jvilk","html_url":"https://github.com/jvilk","followers_url":"https://api.github.com/users/jvilk/followers","following_url":"https://api.github.com/users/jvilk/following{/other_user}","gists_url":"https://api.github.com/users/jvilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jvilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvilk/subscriptions","organizations_url":"https://api.github.com/users/jvilk/orgs","repos_url":"https://api.github.com/users/jvilk/repos","events_url":"https://api.github.com/users/jvilk/events{/privacy}","received_events_url":"https://api.github.com/users/jvilk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvilk/BrowserFS","description":"BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.","fork":false,"url":"https://api.github.com/repos/jvilk/BrowserFS","forks_url":"https://api.github.com/repos/jvilk/BrowserFS/forks","keys_url":"https://api.github.com/repos/jvilk/BrowserFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvilk/BrowserFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvilk/BrowserFS/teams","hooks_url":"https://api.github.com/repos/jvilk/BrowserFS/hooks","issue_events_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/events{/number}","events_url":"https://api.github.com/repos/jvilk/BrowserFS/events","assignees_url":"https://api.github.com/repos/jvilk/BrowserFS/assignees{/user}","branches_url":"https://api.github.com/repos/jvilk/BrowserFS/branches{/branch}","tags_url":"https://api.github.com/repos/jvilk/BrowserFS/tags","blobs_url":"https://api.github.com/repos/jvilk/BrowserFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvilk/BrowserFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvilk/BrowserFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvilk/BrowserFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvilk/BrowserFS/statuses/{sha}","languages_url":"https://api.github.com/repos/jvilk/BrowserFS/languages","stargazers_url":"https://api.github.com/repos/jvilk/BrowserFS/stargazers","contributors_url":"https://api.github.com/repos/jvilk/BrowserFS/contributors","subscribers_url":"https://api.github.com/repos/jvilk/BrowserFS/subscribers","subscription_url":"https://api.github.com/repos/jvilk/BrowserFS/subscription","commits_url":"https://api.github.com/repos/jvilk/BrowserFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvilk/BrowserFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvilk/BrowserFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvilk/BrowserFS/contents/{+path}","compare_url":"https://api.github.com/repos/jvilk/BrowserFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvilk/BrowserFS/merges","archive_url":"https://api.github.com/repos/jvilk/BrowserFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvilk/BrowserFS/downloads","issues_url":"https://api.github.com/repos/jvilk/BrowserFS/issues{/number}","pulls_url":"https://api.github.com/repos/jvilk/BrowserFS/pulls{/number}","milestones_url":"https://api.github.com/repos/jvilk/BrowserFS/milestones{/number}","notifications_url":"https://api.github.com/repos/jvilk/BrowserFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvilk/BrowserFS/labels{/name}","releases_url":"https://api.github.com/repos/jvilk/BrowserFS/releases{/id}","deployments_url":"https://api.github.com/repos/jvilk/BrowserFS/deployments","created_at":"2013-04-18T17:32:50Z","updated_at":"2017-07-31T14:54:08Z","pushed_at":"2017-08-01T19:14:07Z","git_url":"git://github.com/jvilk/BrowserFS.git","ssh_url":"git@github.com:jvilk/BrowserFS.git","clone_url":"https://github.com/jvilk/BrowserFS.git","svn_url":"https://github.com/jvilk/BrowserFS","homepage":null,"size":7789,"stargazers_count":802,"watchers_count":802,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":20,"forks":70,"open_issues":20,"watchers":802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185"},"html":{"href":"https://github.com/jvilk/BrowserFS/pull/185"},"issue":{"href":"https://api.github.com/repos/jvilk/BrowserFS/issues/185"},"comments":{"href":"https://api.github.com/repos/jvilk/BrowserFS/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/jvilk/BrowserFS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jvilk/BrowserFS/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/jvilk/BrowserFS/statuses/1bbbcc6183d6d1b09e7bc5661c4bb4c33f0f4fc1"}}}}
{"actor":{"display_login":"jvilk"}}