{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/s2n/pulls/comments/129723660","pull_request_review_id":52526705,"id":129723660,"diff_hunk":"@@ -404,3 +405,11 @@ int s2n_config_set_client_hello_cb(struct s2n_config *config, s2n_client_hello_f\n \n     return 0;\n }\n+\n+int s2n_config_set_max_fragment_length(struct s2n_config *config, uint8_t mfl_code)\n+{\n+    config->mfl_code = mfl_code;","path":"tls/s2n_config.c","position":15,"original_position":15,"commit_id":"905bf0e8a6228087dc7242f29320e1408438d9b4","original_commit_id":"905bf0e8a6228087dc7242f29320e1408438d9b4","user":{"login":"baekkyok","id":5386340,"avatar_url":"https://avatars2.githubusercontent.com/u/5386340?v=4","gravatar_id":"","url":"https://api.github.com/users/baekkyok","html_url":"https://github.com/baekkyok","followers_url":"https://api.github.com/users/baekkyok/followers","following_url":"https://api.github.com/users/baekkyok/following{/other_user}","gists_url":"https://api.github.com/users/baekkyok/gists{/gist_id}","starred_url":"https://api.github.com/users/baekkyok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baekkyok/subscriptions","organizations_url":"https://api.github.com/users/baekkyok/orgs","repos_url":"https://api.github.com/users/baekkyok/repos","events_url":"https://api.github.com/users/baekkyok/events{/privacy}","received_events_url":"https://api.github.com/users/baekkyok/received_events","type":"User","site_admin":false},"body":"Good call.\r\nShould we alert (print) the user but not terminate the handshake in case of invalid input as we discussed above?\r\n\r\n```\r\nif (mfl_code >= S2N_TLS_MAX_FRAG_LEN_INVALID) {\r\n       fprintf(stderr, \"invalid Max Fragmentation Length encountered\"\\n\");\r\n    }\r\n```","created_at":"2017-07-26T23:41:38Z","updated_at":"2017-07-26T23:41:38Z","html_url":"https://github.com/awslabs/s2n/pull/548#discussion_r129723660","pull_request_url":"https://api.github.com/repos/awslabs/s2n/pulls/548","_links":{"self":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/comments/129723660"},"html":{"href":"https://github.com/awslabs/s2n/pull/548#discussion_r129723660"},"pull_request":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/548"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/s2n/pulls/548","id":130415428,"html_url":"https://github.com/awslabs/s2n/pull/548","diff_url":"https://github.com/awslabs/s2n/pull/548.diff","patch_url":"https://github.com/awslabs/s2n/pull/548.patch","issue_url":"https://api.github.com/repos/awslabs/s2n/issues/548","number":548,"state":"open","locked":false,"title":"Implement the max_fragment_length extension","user":{"login":"baekkyok","id":5386340,"avatar_url":"https://avatars2.githubusercontent.com/u/5386340?v=4","gravatar_id":"","url":"https://api.github.com/users/baekkyok","html_url":"https://github.com/baekkyok","followers_url":"https://api.github.com/users/baekkyok/followers","following_url":"https://api.github.com/users/baekkyok/following{/other_user}","gists_url":"https://api.github.com/users/baekkyok/gists{/gist_id}","starred_url":"https://api.github.com/users/baekkyok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baekkyok/subscriptions","organizations_url":"https://api.github.com/users/baekkyok/orgs","repos_url":"https://api.github.com/users/baekkyok/repos","events_url":"https://api.github.com/users/baekkyok/events{/privacy}","received_events_url":"https://api.github.com/users/baekkyok/received_events","type":"User","site_admin":false},"body":"This PR is for the issue #534 ","created_at":"2017-07-13T16:36:46Z","updated_at":"2017-07-26T23:41:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45cf662266080c68b9ace1feb6a3848e02be7f04","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/s2n/pulls/548/commits","review_comments_url":"https://api.github.com/repos/awslabs/s2n/pulls/548/comments","review_comment_url":"https://api.github.com/repos/awslabs/s2n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/s2n/issues/548/comments","statuses_url":"https://api.github.com/repos/awslabs/s2n/statuses/905bf0e8a6228087dc7242f29320e1408438d9b4","head":{"label":"baekkyok:maxfrag","ref":"maxfrag","sha":"905bf0e8a6228087dc7242f29320e1408438d9b4","user":{"login":"baekkyok","id":5386340,"avatar_url":"https://avatars2.githubusercontent.com/u/5386340?v=4","gravatar_id":"","url":"https://api.github.com/users/baekkyok","html_url":"https://github.com/baekkyok","followers_url":"https://api.github.com/users/baekkyok/followers","following_url":"https://api.github.com/users/baekkyok/following{/other_user}","gists_url":"https://api.github.com/users/baekkyok/gists{/gist_id}","starred_url":"https://api.github.com/users/baekkyok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baekkyok/subscriptions","organizations_url":"https://api.github.com/users/baekkyok/orgs","repos_url":"https://api.github.com/users/baekkyok/repos","events_url":"https://api.github.com/users/baekkyok/events{/privacy}","received_events_url":"https://api.github.com/users/baekkyok/received_events","type":"User","site_admin":false},"repo":{"id":91628476,"name":"s2n","full_name":"baekkyok/s2n","owner":{"login":"baekkyok","id":5386340,"avatar_url":"https://avatars2.githubusercontent.com/u/5386340?v=4","gravatar_id":"","url":"https://api.github.com/users/baekkyok","html_url":"https://github.com/baekkyok","followers_url":"https://api.github.com/users/baekkyok/followers","following_url":"https://api.github.com/users/baekkyok/following{/other_user}","gists_url":"https://api.github.com/users/baekkyok/gists{/gist_id}","starred_url":"https://api.github.com/users/baekkyok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baekkyok/subscriptions","organizations_url":"https://api.github.com/users/baekkyok/orgs","repos_url":"https://api.github.com/users/baekkyok/repos","events_url":"https://api.github.com/users/baekkyok/events{/privacy}","received_events_url":"https://api.github.com/users/baekkyok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baekkyok/s2n","description":"s2n : an implementation of the TLS/SSL protocols","fork":true,"url":"https://api.github.com/repos/baekkyok/s2n","forks_url":"https://api.github.com/repos/baekkyok/s2n/forks","keys_url":"https://api.github.com/repos/baekkyok/s2n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baekkyok/s2n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baekkyok/s2n/teams","hooks_url":"https://api.github.com/repos/baekkyok/s2n/hooks","issue_events_url":"https://api.github.com/repos/baekkyok/s2n/issues/events{/number}","events_url":"https://api.github.com/repos/baekkyok/s2n/events","assignees_url":"https://api.github.com/repos/baekkyok/s2n/assignees{/user}","branches_url":"https://api.github.com/repos/baekkyok/s2n/branches{/branch}","tags_url":"https://api.github.com/repos/baekkyok/s2n/tags","blobs_url":"https://api.github.com/repos/baekkyok/s2n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baekkyok/s2n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baekkyok/s2n/git/refs{/sha}","trees_url":"https://api.github.com/repos/baekkyok/s2n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baekkyok/s2n/statuses/{sha}","languages_url":"https://api.github.com/repos/baekkyok/s2n/languages","stargazers_url":"https://api.github.com/repos/baekkyok/s2n/stargazers","contributors_url":"https://api.github.com/repos/baekkyok/s2n/contributors","subscribers_url":"https://api.github.com/repos/baekkyok/s2n/subscribers","subscription_url":"https://api.github.com/repos/baekkyok/s2n/subscription","commits_url":"https://api.github.com/repos/baekkyok/s2n/commits{/sha}","git_commits_url":"https://api.github.com/repos/baekkyok/s2n/git/commits{/sha}","comments_url":"https://api.github.com/repos/baekkyok/s2n/comments{/number}","issue_comment_url":"https://api.github.com/repos/baekkyok/s2n/issues/comments{/number}","contents_url":"https://api.github.com/repos/baekkyok/s2n/contents/{+path}","compare_url":"https://api.github.com/repos/baekkyok/s2n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baekkyok/s2n/merges","archive_url":"https://api.github.com/repos/baekkyok/s2n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baekkyok/s2n/downloads","issues_url":"https://api.github.com/repos/baekkyok/s2n/issues{/number}","pulls_url":"https://api.github.com/repos/baekkyok/s2n/pulls{/number}","milestones_url":"https://api.github.com/repos/baekkyok/s2n/milestones{/number}","notifications_url":"https://api.github.com/repos/baekkyok/s2n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baekkyok/s2n/labels{/name}","releases_url":"https://api.github.com/repos/baekkyok/s2n/releases{/id}","deployments_url":"https://api.github.com/repos/baekkyok/s2n/deployments","created_at":"2017-05-17T23:23:46Z","updated_at":"2017-05-17T23:23:49Z","pushed_at":"2017-07-13T17:56:55Z","git_url":"git://github.com/baekkyok/s2n.git","ssh_url":"git@github.com:baekkyok/s2n.git","clone_url":"https://github.com/baekkyok/s2n.git","svn_url":"https://github.com/baekkyok/s2n","homepage":"","size":2491,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"2ed0058395f6eb92348e355b951c17c7fb11136e","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":21287076,"name":"s2n","full_name":"awslabs/s2n","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/s2n","description":"s2n : an implementation of the TLS/SSL protocols","fork":false,"url":"https://api.github.com/repos/awslabs/s2n","forks_url":"https://api.github.com/repos/awslabs/s2n/forks","keys_url":"https://api.github.com/repos/awslabs/s2n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/s2n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/s2n/teams","hooks_url":"https://api.github.com/repos/awslabs/s2n/hooks","issue_events_url":"https://api.github.com/repos/awslabs/s2n/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/s2n/events","assignees_url":"https://api.github.com/repos/awslabs/s2n/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/s2n/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/s2n/tags","blobs_url":"https://api.github.com/repos/awslabs/s2n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/s2n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/s2n/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/s2n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/s2n/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/s2n/languages","stargazers_url":"https://api.github.com/repos/awslabs/s2n/stargazers","contributors_url":"https://api.github.com/repos/awslabs/s2n/contributors","subscribers_url":"https://api.github.com/repos/awslabs/s2n/subscribers","subscription_url":"https://api.github.com/repos/awslabs/s2n/subscription","commits_url":"https://api.github.com/repos/awslabs/s2n/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/s2n/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/s2n/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/s2n/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/s2n/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/s2n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/s2n/merges","archive_url":"https://api.github.com/repos/awslabs/s2n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/s2n/downloads","issues_url":"https://api.github.com/repos/awslabs/s2n/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/s2n/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/s2n/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/s2n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/s2n/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/s2n/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/s2n/deployments","created_at":"2014-06-27T19:37:59Z","updated_at":"2017-07-21T07:41:30Z","pushed_at":"2017-07-25T22:36:35Z","git_url":"git://github.com/awslabs/s2n.git","ssh_url":"git@github.com:awslabs/s2n.git","clone_url":"https://github.com/awslabs/s2n.git","svn_url":"https://github.com/awslabs/s2n","homepage":"","size":2478,"stargazers_count":2826,"watchers_count":2826,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":253,"mirror_url":null,"open_issues_count":87,"forks":253,"open_issues":87,"watchers":2826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/548"},"html":{"href":"https://github.com/awslabs/s2n/pull/548"},"issue":{"href":"https://api.github.com/repos/awslabs/s2n/issues/548"},"comments":{"href":"https://api.github.com/repos/awslabs/s2n/issues/548/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/548/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/548/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/s2n/statuses/905bf0e8a6228087dc7242f29320e1408438d9b4"}}}}
{"actor":{"display_login":"baekkyok"}}