{"action":"created","issue":{"url":"https://api.github.com/repos/smyte/jsxstyle/issues/96","repository_url":"https://api.github.com/repos/smyte/jsxstyle","labels_url":"https://api.github.com/repos/smyte/jsxstyle/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/smyte/jsxstyle/issues/96/comments","events_url":"https://api.github.com/repos/smyte/jsxstyle/issues/96/events","html_url":"https://github.com/smyte/jsxstyle/issues/96","id":279100673,"number":96,"title":"Upgrading to from jsxstyle 1.02 to 2.0.6 cause react-modal errors","user":{"login":"StokeMasterJack","id":123349,"avatar_url":"https://avatars2.githubusercontent.com/u/123349?v=4","gravatar_id":"","url":"https://api.github.com/users/StokeMasterJack","html_url":"https://github.com/StokeMasterJack","followers_url":"https://api.github.com/users/StokeMasterJack/followers","following_url":"https://api.github.com/users/StokeMasterJack/following{/other_user}","gists_url":"https://api.github.com/users/StokeMasterJack/gists{/gist_id}","starred_url":"https://api.github.com/users/StokeMasterJack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StokeMasterJack/subscriptions","organizations_url":"https://api.github.com/users/StokeMasterJack/orgs","repos_url":"https://api.github.com/users/StokeMasterJack/repos","events_url":"https://api.github.com/users/StokeMasterJack/events{/privacy}","received_events_url":"https://api.github.com/users/StokeMasterJack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-04T18:32:24Z","updated_at":"2017-12-04T19:32:27Z","closed_at":null,"author_association":"NONE","body":"After updating jsxstyle from 1.02 to 2.0.6 I now gets a bunch react-modal errors in the js console:\r\n\r\nWarning: react-modal: App element is not defined. Please use `Modal.setAppElement(el)` or set `appElement={el}`. This is needed so screen reades don't see main content when modal is opened. It is not recommended, but you can opt-out by setting `ariaHideApp={false}`."},"comment":{"url":"https://api.github.com/repos/smyte/jsxstyle/issues/comments/349079093","html_url":"https://github.com/smyte/jsxstyle/issues/96#issuecomment-349079093","issue_url":"https://api.github.com/repos/smyte/jsxstyle/issues/96","id":349079093,"user":{"login":"StokeMasterJack","id":123349,"avatar_url":"https://avatars2.githubusercontent.com/u/123349?v=4","gravatar_id":"","url":"https://api.github.com/users/StokeMasterJack","html_url":"https://github.com/StokeMasterJack","followers_url":"https://api.github.com/users/StokeMasterJack/followers","following_url":"https://api.github.com/users/StokeMasterJack/following{/other_user}","gists_url":"https://api.github.com/users/StokeMasterJack/gists{/gist_id}","starred_url":"https://api.github.com/users/StokeMasterJack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StokeMasterJack/subscriptions","organizations_url":"https://api.github.com/users/StokeMasterJack/orgs","repos_url":"https://api.github.com/users/StokeMasterJack/repos","events_url":"https://api.github.com/users/StokeMasterJack/events{/privacy}","received_events_url":"https://api.github.com/users/StokeMasterJack/received_events","type":"User","site_admin":false},"created_at":"2017-12-04T19:32:27Z","updated_at":"2017-12-04T19:32:27Z","author_association":"NONE","body":"Actually I did a rollback of the jsx upgrade and I'm still getting the react-modal errors. It's strange because we were not getting those before. The only thing that changed was that I updated my version of yarn and re-ran yarn install. No way to roll that back since node_modules doesn't get added to git. So apparently rebuilding the node_modules folder from package.json is not deterministic.\r\n\r\nAnyway, not a jsxstyle issue. Thanks. Sorry for wasting your time."}}
{"actor":{"display_login":"StokeMasterJack"}}