{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/127616957","pull_request_review_id":50220540,"id":127616957,"diff_hunk":"@@ -0,0 +1,54 @@\n+{{- if .Values.controller.rbac.enabled -}}\n+apiVersion: rbac.authorization.k8s.io/v1beta1\n+kind: ClusterRole\n+metadata:\n+  name: {{ template \"fullname\" . }}\n+rules:\n+  - apiGroups:\n+      - \"\"\n+    resources:\n+      - configmaps\n+      - endpoints\n+      - nodes\n+      - pods\n+      - secrets\n+    verbs:\n+      - list\n+      - watch\n+  - apiGroups:\n+      - \"\"\n+    resources:\n+      - nodes","path":"stable/nginx-ingress/templates/controller-cluster-role.yaml","position":21,"original_position":21,"commit_id":"e359b0b6bd15a47ae9531c3e51e08a87ebbbbd07","original_commit_id":"17cfeeaa6779b6420fa9e62039cc3880af30d762","user":{"login":"icereval","id":3111541,"avatar_url":"https://avatars4.githubusercontent.com/u/3111541?v=4","gravatar_id":"","url":"https://api.github.com/users/icereval","html_url":"https://github.com/icereval","followers_url":"https://api.github.com/users/icereval/followers","following_url":"https://api.github.com/users/icereval/following{/other_user}","gists_url":"https://api.github.com/users/icereval/gists{/gist_id}","starred_url":"https://api.github.com/users/icereval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icereval/subscriptions","organizations_url":"https://api.github.com/users/icereval/orgs","repos_url":"https://api.github.com/users/icereval/repos","events_url":"https://api.github.com/users/icereval/events{/privacy}","received_events_url":"https://api.github.com/users/icereval/received_events","type":"User","site_admin":false},"body":"```\r\n                          .─────────────────.                           \r\n                      _.─'                   `──.                       \r\n                     (         Internet          )                      \r\n                      `───.                 _.──'                       \r\n                           `───────────────'                            \r\n                                   │                                    \r\n                                   ▼                                    \r\n                       ┌───────────────────────┐                        \r\n                       │  Google Load Balancer │                        \r\n                       └───────────────────────┘                        \r\n                                   │                                    \r\n                 ┌─────────────────┴──────────────────┐                 \r\n                 ▼                                    ▼                 \r\n┌Namesapce (Testing)──────────────┐  ┌Namesapce (Staging)──────────────┐\r\n│┌──────────────┐ ┌──────────────┐│  │┌──────────────┐ ┌──────────────┐│\r\n││   Ingress    │ │   Default    ││  ││   Ingress    │ │   Default    ││\r\n││  Controller  │ │   Backend    ││  ││  Controller  │ │   Backend    ││\r\n│└──────────────┘ └──────────────┘│  │└──────────────┘ └──────────────┘│\r\n│        │                ▲       │  │        │                ▲       │\r\n│        └───────┬────────┘       │  │        └───────┬────────┘       │\r\n│                │                │  │                │                │\r\n│       ┌────────────────┐        │  │       ┌────────────────┐        │\r\n│       │  ingress.yaml  │        │  │       │  ingress.yaml  │        │\r\n│       └────────────────┘        │  │       └────────────────┘        │\r\n│                │                │  │                │                │\r\n│     ┌──────────┼──────────┐     │  │     ┌──────────┼──────────┐     │\r\n│     ▼          ▼          ▼     │  │     ▼          ▼          ▼     │\r\n│ ┌───────┐  ┌───────┐  ┌───────┐ │  │ ┌───────┐  ┌───────┐  ┌───────┐ │\r\n│ │ Pod 1 │  │ Pod 2 │  │ Pod 3 │ │  │ │ Pod 1 │  │ Pod 2 │  │ Pod 3 │ │\r\n│ └───────┘  └───────┘  └───────┘ │  │ └───────┘  └───────┘  └───────┘ │\r\n└─────────────────────────────────┘  └─────────────────────────────────┘\r\n```","created_at":"2017-07-16T21:15:40Z","updated_at":"2017-07-16T21:15:40Z","html_url":"https://github.com/kubernetes/charts/pull/1235#discussion_r127616957","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/1235","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/127616957"},"html":{"href":"https://github.com/kubernetes/charts/pull/1235#discussion_r127616957"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1235"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/1235","id":123865408,"html_url":"https://github.com/kubernetes/charts/pull/1235","diff_url":"https://github.com/kubernetes/charts/pull/1235.diff","patch_url":"https://github.com/kubernetes/charts/pull/1235.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/1235","number":1235,"state":"open","locked":false,"title":"[stable/nginx-ingress] Add RBAC support","user":{"login":"jsulinski","id":51166,"avatar_url":"https://avatars6.githubusercontent.com/u/51166?v=4","gravatar_id":"","url":"https://api.github.com/users/jsulinski","html_url":"https://github.com/jsulinski","followers_url":"https://api.github.com/users/jsulinski/followers","following_url":"https://api.github.com/users/jsulinski/following{/other_user}","gists_url":"https://api.github.com/users/jsulinski/gists{/gist_id}","starred_url":"https://api.github.com/users/jsulinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsulinski/subscriptions","organizations_url":"https://api.github.com/users/jsulinski/orgs","repos_url":"https://api.github.com/users/jsulinski/repos","events_url":"https://api.github.com/users/jsulinski/events{/privacy}","received_events_url":"https://api.github.com/users/jsulinski/received_events","type":"User","site_admin":false},"body":"Enable RBAC as per: https://github.com/kubernetes/ingress/tree/master/examples/rbac/nginx and https://github.com/kubernetes/ingress/issues/266","created_at":"2017-06-04T04:56:57Z","updated_at":"2017-07-16T21:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64db18babc5fb154d8894debe04261f145132aec","assignee":{"login":"mgoodness","id":2781657,"avatar_url":"https://avatars4.githubusercontent.com/u/2781657?v=4","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false},"assignees":[{"login":"mgoodness","id":2781657,"avatar_url":"https://avatars4.githubusercontent.com/u/2781657?v=4","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/1235/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/1235/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/1235/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/e359b0b6bd15a47ae9531c3e51e08a87ebbbbd07","head":{"label":"federacy:rbac","ref":"rbac","sha":"e359b0b6bd15a47ae9531c3e51e08a87ebbbbd07","user":{"login":"federacy","id":3166278,"avatar_url":"https://avatars5.githubusercontent.com/u/3166278?v=4","gravatar_id":"","url":"https://api.github.com/users/federacy","html_url":"https://github.com/federacy","followers_url":"https://api.github.com/users/federacy/followers","following_url":"https://api.github.com/users/federacy/following{/other_user}","gists_url":"https://api.github.com/users/federacy/gists{/gist_id}","starred_url":"https://api.github.com/users/federacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/federacy/subscriptions","organizations_url":"https://api.github.com/users/federacy/orgs","repos_url":"https://api.github.com/users/federacy/repos","events_url":"https://api.github.com/users/federacy/events{/privacy}","received_events_url":"https://api.github.com/users/federacy/received_events","type":"Organization","site_admin":false},"repo":{"id":93289205,"name":"charts","full_name":"federacy/charts","owner":{"login":"federacy","id":3166278,"avatar_url":"https://avatars5.githubusercontent.com/u/3166278?v=4","gravatar_id":"","url":"https://api.github.com/users/federacy","html_url":"https://github.com/federacy","followers_url":"https://api.github.com/users/federacy/followers","following_url":"https://api.github.com/users/federacy/following{/other_user}","gists_url":"https://api.github.com/users/federacy/gists{/gist_id}","starred_url":"https://api.github.com/users/federacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/federacy/subscriptions","organizations_url":"https://api.github.com/users/federacy/orgs","repos_url":"https://api.github.com/users/federacy/repos","events_url":"https://api.github.com/users/federacy/events{/privacy}","received_events_url":"https://api.github.com/users/federacy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/federacy/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/federacy/charts","forks_url":"https://api.github.com/repos/federacy/charts/forks","keys_url":"https://api.github.com/repos/federacy/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/federacy/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/federacy/charts/teams","hooks_url":"https://api.github.com/repos/federacy/charts/hooks","issue_events_url":"https://api.github.com/repos/federacy/charts/issues/events{/number}","events_url":"https://api.github.com/repos/federacy/charts/events","assignees_url":"https://api.github.com/repos/federacy/charts/assignees{/user}","branches_url":"https://api.github.com/repos/federacy/charts/branches{/branch}","tags_url":"https://api.github.com/repos/federacy/charts/tags","blobs_url":"https://api.github.com/repos/federacy/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/federacy/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/federacy/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/federacy/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/federacy/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/federacy/charts/languages","stargazers_url":"https://api.github.com/repos/federacy/charts/stargazers","contributors_url":"https://api.github.com/repos/federacy/charts/contributors","subscribers_url":"https://api.github.com/repos/federacy/charts/subscribers","subscription_url":"https://api.github.com/repos/federacy/charts/subscription","commits_url":"https://api.github.com/repos/federacy/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/federacy/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/federacy/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/federacy/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/federacy/charts/contents/{+path}","compare_url":"https://api.github.com/repos/federacy/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/federacy/charts/merges","archive_url":"https://api.github.com/repos/federacy/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/federacy/charts/downloads","issues_url":"https://api.github.com/repos/federacy/charts/issues{/number}","pulls_url":"https://api.github.com/repos/federacy/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/federacy/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/federacy/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/federacy/charts/labels{/name}","releases_url":"https://api.github.com/repos/federacy/charts/releases{/id}","deployments_url":"https://api.github.com/repos/federacy/charts/deployments","created_at":"2017-06-04T04:04:54Z","updated_at":"2017-06-04T04:04:56Z","pushed_at":"2017-07-14T23:46:21Z","git_url":"git://github.com/federacy/charts.git","ssh_url":"git@github.com:federacy/charts.git","clone_url":"https://github.com/federacy/charts.git","svn_url":"https://github.com/federacy/charts","homepage":"","size":1711,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"921209fe15621d6645e024290da448919c6cad49","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars6.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars6.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2017-07-16T19:02:16Z","pushed_at":"2017-07-16T20:17:42Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":1776,"stargazers_count":814,"watchers_count":814,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":636,"mirror_url":null,"open_issues_count":213,"forks":636,"open_issues":213,"watchers":814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1235"},"html":{"href":"https://github.com/kubernetes/charts/pull/1235"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/1235"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/1235/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1235/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1235/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/e359b0b6bd15a47ae9531c3e51e08a87ebbbbd07"}}}}
{"actor":{"display_login":"icereval"}}