{"action":"created","comment":{"url":"https://api.github.com/repos/apache/systemml/pulls/comments/123833106","pull_request_review_id":46063084,"id":123833106,"diff_hunk":"@@ -727,9 +727,15 @@ protected double computeOutputMemEstimate( long dim1, long dim2, long nnz )\n \t\t\t\t// Output is a vector of length = #of quantiles to be computed, and it is likely to be dense.\n \t\t\t\treturn OptimizerUtils.estimateSizeExactSparsity(dim1, dim2, 1.0);\n \t\t\tcase PLUS_MULT:\n-\t\t\tcase MINUS_MULT:\n-\t\t\t\tsparsity = OptimizerUtils.getSparsity(dim1, dim2, nnz); \n+\t\t\tcase MINUS_MULT: {\n+\t\t\t\tif (DMLScript.USE_ACCELERATOR) {\n+\t\t\t\t\t// For the GPU, the input is converted to dense\n+\t\t\t\t\tsparsity = 1.0;\n+\t\t\t\t} else {\n+\t\t\t\t\tsparsity = OptimizerUtils.getSparsity(dim1, dim2, nnz);\n+\t\t\t\t}","path":"src/main/java/org/apache/sysml/hops/TernaryOp.java","position":12,"original_position":12,"commit_id":"25e809abd59e21ac6a6094f9a7efb01dcbe5a027","original_commit_id":"25e809abd59e21ac6a6094f9a7efb01dcbe5a027","user":{"login":"nakul02","id":5394361,"avatar_url":"https://avatars0.githubusercontent.com/u/5394361?v=3","gravatar_id":"","url":"https://api.github.com/users/nakul02","html_url":"https://github.com/nakul02","followers_url":"https://api.github.com/users/nakul02/followers","following_url":"https://api.github.com/users/nakul02/following{/other_user}","gists_url":"https://api.github.com/users/nakul02/gists{/gist_id}","starred_url":"https://api.github.com/users/nakul02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakul02/subscriptions","organizations_url":"https://api.github.com/users/nakul02/orgs","repos_url":"https://api.github.com/users/nakul02/repos","events_url":"https://api.github.com/users/nakul02/events{/privacy}","received_events_url":"https://api.github.com/users/nakul02/received_events","type":"User","site_admin":false},"body":"Same as above for AggUnaryOp. ","created_at":"2017-06-23T20:00:27Z","updated_at":"2017-06-23T20:02:27Z","html_url":"https://github.com/apache/systemml/pull/553#discussion_r123833106","pull_request_url":"https://api.github.com/repos/apache/systemml/pulls/553","_links":{"self":{"href":"https://api.github.com/repos/apache/systemml/pulls/comments/123833106"},"html":{"href":"https://github.com/apache/systemml/pull/553#discussion_r123833106"},"pull_request":{"href":"https://api.github.com/repos/apache/systemml/pulls/553"}}},"pull_request":{"url":"https://api.github.com/repos/apache/systemml/pulls/553","id":126890975,"html_url":"https://github.com/apache/systemml/pull/553","diff_url":"https://github.com/apache/systemml/pull/553.diff","patch_url":"https://github.com/apache/systemml/pull/553.patch","issue_url":"https://api.github.com/repos/apache/systemml/issues/553","number":553,"state":"open","locked":false,"title":"[SYSTEMML-1713][WIP] correct memory estimates for gpu","user":{"login":"nakul02","id":5394361,"avatar_url":"https://avatars0.githubusercontent.com/u/5394361?v=3","gravatar_id":"","url":"https://api.github.com/users/nakul02","html_url":"https://github.com/nakul02","followers_url":"https://api.github.com/users/nakul02/followers","following_url":"https://api.github.com/users/nakul02/following{/other_user}","gists_url":"https://api.github.com/users/nakul02/gists{/gist_id}","starred_url":"https://api.github.com/users/nakul02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakul02/subscriptions","organizations_url":"https://api.github.com/users/nakul02/orgs","repos_url":"https://api.github.com/users/nakul02/repos","events_url":"https://api.github.com/users/nakul02/events{/privacy}","received_events_url":"https://api.github.com/users/nakul02/received_events","type":"User","site_admin":false},"body":"Ping @mboehm7, @bertholdreinwald, @niketanpansare, @dusenberrymw ","created_at":"2017-06-22T01:05:35Z","updated_at":"2017-06-23T20:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e7a1726b1df0fcdcb5fbc5be53d57bd61d9005a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/systemml/pulls/553/commits","review_comments_url":"https://api.github.com/repos/apache/systemml/pulls/553/comments","review_comment_url":"https://api.github.com/repos/apache/systemml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/systemml/issues/553/comments","statuses_url":"https://api.github.com/repos/apache/systemml/statuses/25e809abd59e21ac6a6094f9a7efb01dcbe5a027","head":{"label":"nakul02:SYSTEMML-1713_correct_memory_estimates_for_GPU","ref":"SYSTEMML-1713_correct_memory_estimates_for_GPU","sha":"25e809abd59e21ac6a6094f9a7efb01dcbe5a027","user":{"login":"nakul02","id":5394361,"avatar_url":"https://avatars0.githubusercontent.com/u/5394361?v=3","gravatar_id":"","url":"https://api.github.com/users/nakul02","html_url":"https://github.com/nakul02","followers_url":"https://api.github.com/users/nakul02/followers","following_url":"https://api.github.com/users/nakul02/following{/other_user}","gists_url":"https://api.github.com/users/nakul02/gists{/gist_id}","starred_url":"https://api.github.com/users/nakul02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakul02/subscriptions","organizations_url":"https://api.github.com/users/nakul02/orgs","repos_url":"https://api.github.com/users/nakul02/repos","events_url":"https://api.github.com/users/nakul02/events{/privacy}","received_events_url":"https://api.github.com/users/nakul02/received_events","type":"User","site_admin":false},"repo":{"id":49258505,"name":"systemml","full_name":"nakul02/systemml","owner":{"login":"nakul02","id":5394361,"avatar_url":"https://avatars0.githubusercontent.com/u/5394361?v=3","gravatar_id":"","url":"https://api.github.com/users/nakul02","html_url":"https://github.com/nakul02","followers_url":"https://api.github.com/users/nakul02/followers","following_url":"https://api.github.com/users/nakul02/following{/other_user}","gists_url":"https://api.github.com/users/nakul02/gists{/gist_id}","starred_url":"https://api.github.com/users/nakul02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakul02/subscriptions","organizations_url":"https://api.github.com/users/nakul02/orgs","repos_url":"https://api.github.com/users/nakul02/repos","events_url":"https://api.github.com/users/nakul02/events{/privacy}","received_events_url":"https://api.github.com/users/nakul02/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nakul02/systemml","description":"Mirror of Apache SystemML (Incubating)","fork":true,"url":"https://api.github.com/repos/nakul02/systemml","forks_url":"https://api.github.com/repos/nakul02/systemml/forks","keys_url":"https://api.github.com/repos/nakul02/systemml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nakul02/systemml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nakul02/systemml/teams","hooks_url":"https://api.github.com/repos/nakul02/systemml/hooks","issue_events_url":"https://api.github.com/repos/nakul02/systemml/issues/events{/number}","events_url":"https://api.github.com/repos/nakul02/systemml/events","assignees_url":"https://api.github.com/repos/nakul02/systemml/assignees{/user}","branches_url":"https://api.github.com/repos/nakul02/systemml/branches{/branch}","tags_url":"https://api.github.com/repos/nakul02/systemml/tags","blobs_url":"https://api.github.com/repos/nakul02/systemml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nakul02/systemml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nakul02/systemml/git/refs{/sha}","trees_url":"https://api.github.com/repos/nakul02/systemml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nakul02/systemml/statuses/{sha}","languages_url":"https://api.github.com/repos/nakul02/systemml/languages","stargazers_url":"https://api.github.com/repos/nakul02/systemml/stargazers","contributors_url":"https://api.github.com/repos/nakul02/systemml/contributors","subscribers_url":"https://api.github.com/repos/nakul02/systemml/subscribers","subscription_url":"https://api.github.com/repos/nakul02/systemml/subscription","commits_url":"https://api.github.com/repos/nakul02/systemml/commits{/sha}","git_commits_url":"https://api.github.com/repos/nakul02/systemml/git/commits{/sha}","comments_url":"https://api.github.com/repos/nakul02/systemml/comments{/number}","issue_comment_url":"https://api.github.com/repos/nakul02/systemml/issues/comments{/number}","contents_url":"https://api.github.com/repos/nakul02/systemml/contents/{+path}","compare_url":"https://api.github.com/repos/nakul02/systemml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nakul02/systemml/merges","archive_url":"https://api.github.com/repos/nakul02/systemml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nakul02/systemml/downloads","issues_url":"https://api.github.com/repos/nakul02/systemml/issues{/number}","pulls_url":"https://api.github.com/repos/nakul02/systemml/pulls{/number}","milestones_url":"https://api.github.com/repos/nakul02/systemml/milestones{/number}","notifications_url":"https://api.github.com/repos/nakul02/systemml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nakul02/systemml/labels{/name}","releases_url":"https://api.github.com/repos/nakul02/systemml/releases{/id}","deployments_url":"https://api.github.com/repos/nakul02/systemml/deployments","created_at":"2016-01-08T08:01:14Z","updated_at":"2017-06-08T20:40:26Z","pushed_at":"2017-06-23T00:05:10Z","git_url":"git://github.com/nakul02/systemml.git","ssh_url":"git@github.com:nakul02/systemml.git","clone_url":"https://github.com/nakul02/systemml.git","svn_url":"https://github.com/nakul02/systemml","homepage":null,"size":199269,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a5c834b27da9cfeffe0ad6e606c43fe3246831d2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45896813,"name":"systemml","full_name":"apache/systemml","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/systemml","description":"Mirror of Apache SystemML","fork":false,"url":"https://api.github.com/repos/apache/systemml","forks_url":"https://api.github.com/repos/apache/systemml/forks","keys_url":"https://api.github.com/repos/apache/systemml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/systemml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/systemml/teams","hooks_url":"https://api.github.com/repos/apache/systemml/hooks","issue_events_url":"https://api.github.com/repos/apache/systemml/issues/events{/number}","events_url":"https://api.github.com/repos/apache/systemml/events","assignees_url":"https://api.github.com/repos/apache/systemml/assignees{/user}","branches_url":"https://api.github.com/repos/apache/systemml/branches{/branch}","tags_url":"https://api.github.com/repos/apache/systemml/tags","blobs_url":"https://api.github.com/repos/apache/systemml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/systemml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/systemml/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/systemml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/systemml/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/systemml/languages","stargazers_url":"https://api.github.com/repos/apache/systemml/stargazers","contributors_url":"https://api.github.com/repos/apache/systemml/contributors","subscribers_url":"https://api.github.com/repos/apache/systemml/subscribers","subscription_url":"https://api.github.com/repos/apache/systemml/subscription","commits_url":"https://api.github.com/repos/apache/systemml/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/systemml/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/systemml/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/systemml/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/systemml/contents/{+path}","compare_url":"https://api.github.com/repos/apache/systemml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/systemml/merges","archive_url":"https://api.github.com/repos/apache/systemml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/systemml/downloads","issues_url":"https://api.github.com/repos/apache/systemml/issues{/number}","pulls_url":"https://api.github.com/repos/apache/systemml/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/systemml/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/systemml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/systemml/labels{/name}","releases_url":"https://api.github.com/repos/apache/systemml/releases{/id}","deployments_url":"https://api.github.com/repos/apache/systemml/deployments","created_at":"2015-11-10T08:00:06Z","updated_at":"2017-06-21T08:24:36Z","pushed_at":"2017-06-23T19:55:08Z","git_url":"git://github.com/apache/systemml.git","ssh_url":"git@github.com:apache/systemml.git","clone_url":"https://github.com/apache/systemml.git","svn_url":"https://github.com/apache/systemml","homepage":"","size":198877,"stargazers_count":532,"watchers_count":532,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":193,"mirror_url":"git://git.apache.org/systemml.git","open_issues_count":15,"forks":193,"open_issues":15,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/systemml/pulls/553"},"html":{"href":"https://github.com/apache/systemml/pull/553"},"issue":{"href":"https://api.github.com/repos/apache/systemml/issues/553"},"comments":{"href":"https://api.github.com/repos/apache/systemml/issues/553/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/systemml/pulls/553/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/systemml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/systemml/pulls/553/commits"},"statuses":{"href":"https://api.github.com/repos/apache/systemml/statuses/25e809abd59e21ac6a6094f9a7efb01dcbe5a027"}}}}
{"actor":{"display_login":"nakul02"}}