{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/13","id":114160163,"html_url":"https://github.com/OpenConceptConsulting/puppet-nslcd/pull/13","diff_url":"https://github.com/OpenConceptConsulting/puppet-nslcd/pull/13.diff","patch_url":"https://github.com/OpenConceptConsulting/puppet-nslcd/pull/13.patch","issue_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/issues/13","number":13,"state":"closed","locked":false,"title":"Add generic ldap options","user":{"login":"rstruber","id":3433905,"avatar_url":"https://avatars2.githubusercontent.com/u/3433905?v=3","gravatar_id":"","url":"https://api.github.com/users/rstruber","html_url":"https://github.com/rstruber","followers_url":"https://api.github.com/users/rstruber/followers","following_url":"https://api.github.com/users/rstruber/following{/other_user}","gists_url":"https://api.github.com/users/rstruber/gists{/gist_id}","starred_url":"https://api.github.com/users/rstruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstruber/subscriptions","organizations_url":"https://api.github.com/users/rstruber/orgs","repos_url":"https://api.github.com/users/rstruber/repos","events_url":"https://api.github.com/users/rstruber/events{/privacy}","received_events_url":"https://api.github.com/users/rstruber/received_events","type":"User","site_admin":false},"body":"There are several options that are not exposed as parameters. Rather than writing a parameter for every possible value, at least expose something for \"key-value\" pairs.\r\n\r\nPossible to generically write hieradata:\r\n\r\n```\r\nldap_options:\r\n    nss_initgroups_ignoreusers: puppet\r\n    idle_timelimit: 60\r\n    bind_timelimit: 60\r\n    tls_cacertdir: /etc/ssl\r\n```","created_at":"2017-04-04T14:20:12Z","updated_at":"2017-04-04T14:39:04Z","closed_at":"2017-04-04T14:39:04Z","merged_at":null,"merge_commit_sha":"325c86fec432cc16937d8169a851ec064a3cbeaf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/13/commits","review_comments_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/13/comments","review_comment_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/issues/13/comments","statuses_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/statuses/fe3844ebe869a4d2bf14a565614a6fd1c78ad234","head":{"label":"rstruber:add-generic-ldap-options","ref":"add-generic-ldap-options","sha":"fe3844ebe869a4d2bf14a565614a6fd1c78ad234","user":{"login":"rstruber","id":3433905,"avatar_url":"https://avatars2.githubusercontent.com/u/3433905?v=3","gravatar_id":"","url":"https://api.github.com/users/rstruber","html_url":"https://github.com/rstruber","followers_url":"https://api.github.com/users/rstruber/followers","following_url":"https://api.github.com/users/rstruber/following{/other_user}","gists_url":"https://api.github.com/users/rstruber/gists{/gist_id}","starred_url":"https://api.github.com/users/rstruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstruber/subscriptions","organizations_url":"https://api.github.com/users/rstruber/orgs","repos_url":"https://api.github.com/users/rstruber/repos","events_url":"https://api.github.com/users/rstruber/events{/privacy}","received_events_url":"https://api.github.com/users/rstruber/received_events","type":"User","site_admin":false},"repo":{"id":87194110,"name":"puppet-nslcd","full_name":"rstruber/puppet-nslcd","owner":{"login":"rstruber","id":3433905,"avatar_url":"https://avatars2.githubusercontent.com/u/3433905?v=3","gravatar_id":"","url":"https://api.github.com/users/rstruber","html_url":"https://github.com/rstruber","followers_url":"https://api.github.com/users/rstruber/followers","following_url":"https://api.github.com/users/rstruber/following{/other_user}","gists_url":"https://api.github.com/users/rstruber/gists{/gist_id}","starred_url":"https://api.github.com/users/rstruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstruber/subscriptions","organizations_url":"https://api.github.com/users/rstruber/orgs","repos_url":"https://api.github.com/users/rstruber/repos","events_url":"https://api.github.com/users/rstruber/events{/privacy}","received_events_url":"https://api.github.com/users/rstruber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rstruber/puppet-nslcd","description":"NSLCD module","fork":true,"url":"https://api.github.com/repos/rstruber/puppet-nslcd","forks_url":"https://api.github.com/repos/rstruber/puppet-nslcd/forks","keys_url":"https://api.github.com/repos/rstruber/puppet-nslcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstruber/puppet-nslcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstruber/puppet-nslcd/teams","hooks_url":"https://api.github.com/repos/rstruber/puppet-nslcd/hooks","issue_events_url":"https://api.github.com/repos/rstruber/puppet-nslcd/issues/events{/number}","events_url":"https://api.github.com/repos/rstruber/puppet-nslcd/events","assignees_url":"https://api.github.com/repos/rstruber/puppet-nslcd/assignees{/user}","branches_url":"https://api.github.com/repos/rstruber/puppet-nslcd/branches{/branch}","tags_url":"https://api.github.com/repos/rstruber/puppet-nslcd/tags","blobs_url":"https://api.github.com/repos/rstruber/puppet-nslcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstruber/puppet-nslcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstruber/puppet-nslcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstruber/puppet-nslcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstruber/puppet-nslcd/statuses/{sha}","languages_url":"https://api.github.com/repos/rstruber/puppet-nslcd/languages","stargazers_url":"https://api.github.com/repos/rstruber/puppet-nslcd/stargazers","contributors_url":"https://api.github.com/repos/rstruber/puppet-nslcd/contributors","subscribers_url":"https://api.github.com/repos/rstruber/puppet-nslcd/subscribers","subscription_url":"https://api.github.com/repos/rstruber/puppet-nslcd/subscription","commits_url":"https://api.github.com/repos/rstruber/puppet-nslcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstruber/puppet-nslcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstruber/puppet-nslcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstruber/puppet-nslcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstruber/puppet-nslcd/contents/{+path}","compare_url":"https://api.github.com/repos/rstruber/puppet-nslcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstruber/puppet-nslcd/merges","archive_url":"https://api.github.com/repos/rstruber/puppet-nslcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstruber/puppet-nslcd/downloads","issues_url":"https://api.github.com/repos/rstruber/puppet-nslcd/issues{/number}","pulls_url":"https://api.github.com/repos/rstruber/puppet-nslcd/pulls{/number}","milestones_url":"https://api.github.com/repos/rstruber/puppet-nslcd/milestones{/number}","notifications_url":"https://api.github.com/repos/rstruber/puppet-nslcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstruber/puppet-nslcd/labels{/name}","releases_url":"https://api.github.com/repos/rstruber/puppet-nslcd/releases{/id}","deployments_url":"https://api.github.com/repos/rstruber/puppet-nslcd/deployments","created_at":"2017-04-04T14:05:30Z","updated_at":"2017-04-04T14:05:32Z","pushed_at":"2017-04-04T14:17:37Z","git_url":"git://github.com/rstruber/puppet-nslcd.git","ssh_url":"git@github.com:rstruber/puppet-nslcd.git","clone_url":"https://github.com/rstruber/puppet-nslcd.git","svn_url":"https://github.com/rstruber/puppet-nslcd","homepage":null,"size":42,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenConceptConsulting:master","ref":"master","sha":"3ba601b3b802e0d301b0a2466c5de7cd2d61f786","user":{"login":"OpenConceptConsulting","id":2243327,"avatar_url":"https://avatars1.githubusercontent.com/u/2243327?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenConceptConsulting","html_url":"https://github.com/OpenConceptConsulting","followers_url":"https://api.github.com/users/OpenConceptConsulting/followers","following_url":"https://api.github.com/users/OpenConceptConsulting/following{/other_user}","gists_url":"https://api.github.com/users/OpenConceptConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenConceptConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenConceptConsulting/subscriptions","organizations_url":"https://api.github.com/users/OpenConceptConsulting/orgs","repos_url":"https://api.github.com/users/OpenConceptConsulting/repos","events_url":"https://api.github.com/users/OpenConceptConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/OpenConceptConsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":34081546,"name":"puppet-nslcd","full_name":"OpenConceptConsulting/puppet-nslcd","owner":{"login":"OpenConceptConsulting","id":2243327,"avatar_url":"https://avatars1.githubusercontent.com/u/2243327?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenConceptConsulting","html_url":"https://github.com/OpenConceptConsulting","followers_url":"https://api.github.com/users/OpenConceptConsulting/followers","following_url":"https://api.github.com/users/OpenConceptConsulting/following{/other_user}","gists_url":"https://api.github.com/users/OpenConceptConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenConceptConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenConceptConsulting/subscriptions","organizations_url":"https://api.github.com/users/OpenConceptConsulting/orgs","repos_url":"https://api.github.com/users/OpenConceptConsulting/repos","events_url":"https://api.github.com/users/OpenConceptConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/OpenConceptConsulting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenConceptConsulting/puppet-nslcd","description":"NSLCD module","fork":false,"url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd","forks_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/forks","keys_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/teams","hooks_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/hooks","issue_events_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/issues/events{/number}","events_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/events","assignees_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/assignees{/user}","branches_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/branches{/branch}","tags_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/tags","blobs_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/languages","stargazers_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/stargazers","contributors_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/contributors","subscribers_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/subscribers","subscription_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/subscription","commits_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/contents/{+path}","compare_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/merges","archive_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/downloads","issues_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/issues{/number}","pulls_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/labels{/name}","releases_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/releases{/id}","deployments_url":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/deployments","created_at":"2015-04-16T21:28:03Z","updated_at":"2016-04-11T17:44:46Z","pushed_at":"2017-04-04T14:20:13Z","git_url":"git://github.com/OpenConceptConsulting/puppet-nslcd.git","ssh_url":"git@github.com:OpenConceptConsulting/puppet-nslcd.git","clone_url":"https://github.com/OpenConceptConsulting/puppet-nslcd.git","svn_url":"https://github.com/OpenConceptConsulting/puppet-nslcd","homepage":null,"size":42,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/13"},"html":{"href":"https://github.com/OpenConceptConsulting/puppet-nslcd/pull/13"},"issue":{"href":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/issues/13"},"comments":{"href":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/OpenConceptConsulting/puppet-nslcd/statuses/fe3844ebe869a4d2bf14a565614a6fd1c78ad234"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":9,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"rstruber"}}