{"action":"created","issue":{"url":"https://api.github.com/repos/lyft/envoy/issues/1203","repository_url":"https://api.github.com/repos/lyft/envoy","labels_url":"https://api.github.com/repos/lyft/envoy/issues/1203/labels{/name}","comments_url":"https://api.github.com/repos/lyft/envoy/issues/1203/comments","events_url":"https://api.github.com/repos/lyft/envoy/issues/1203/events","html_url":"https://github.com/lyft/envoy/pull/1203","id":240415905,"number":1203,"title":"ssl: verify certificates during the handshake.","user":{"login":"PiotrSikora","id":190297,"avatar_url":"https://avatars0.githubusercontent.com/u/190297?v=3","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2017-07-04T13:07:36Z","updated_at":"2017-07-11T20:36:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lyft/envoy/pulls/1203","html_url":"https://github.com/lyft/envoy/pull/1203","diff_url":"https://github.com/lyft/envoy/pull/1203.diff","patch_url":"https://github.com/lyft/envoy/pull/1203.patch"},"body":"Previously, verification of SANs and/or certificate hashes was performed\r\nafter successful handshake, and failures resulted in closed connections.\r\n\r\nThat behavior was different from that of failed certificate verification\r\ndue to untrusted issuer or expired certificates, which results in failed\r\nhandshake.\r\n\r\nThis commit changes time at which verification of SANs and/or certificate\r\nhashes is happening in order to provide consistent behavior for different\r\nfailures.\r\n\r\nWhile there, add \"ssl.fail_verify_error\" counter for failed verifications,\r\nwhich were previously counted towards \"ssl.connection_error\"."},"comment":{"url":"https://api.github.com/repos/lyft/envoy/issues/comments/314563737","html_url":"https://github.com/lyft/envoy/pull/1203#issuecomment-314563737","issue_url":"https://api.github.com/repos/lyft/envoy/issues/1203","id":314563737,"user":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars0.githubusercontent.com/u/6305260?v=3","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"created_at":"2017-07-11T20:36:11Z","updated_at":"2017-07-11T20:36:11Z","body":"@PiotrSikora I don't have a strong preference either way on the remaining @davidben comment. Up to you. Let me know if you want me to merge or wait."}}
{"actor":{"display_login":"mattklein123"}}