{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/55","id":134967419,"html_url":"https://github.com/HuasoFoundries/phpPgAdmin6/pull/55","diff_url":"https://github.com/HuasoFoundries/phpPgAdmin6/pull/55.diff","patch_url":"https://github.com/HuasoFoundries/phpPgAdmin6/pull/55.patch","issue_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/55","number":55,"state":"closed","locked":false,"title":"Creates HTMLFooterController, fixes #54 regression","user":{"login":"amenadiel","id":238439,"avatar_url":"https://avatars2.githubusercontent.com/u/238439?v=4","gravatar_id":"","url":"https://api.github.com/users/amenadiel","html_url":"https://github.com/amenadiel","followers_url":"https://api.github.com/users/amenadiel/followers","following_url":"https://api.github.com/users/amenadiel/following{/other_user}","gists_url":"https://api.github.com/users/amenadiel/gists{/gist_id}","starred_url":"https://api.github.com/users/amenadiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amenadiel/subscriptions","organizations_url":"https://api.github.com/users/amenadiel/orgs","repos_url":"https://api.github.com/users/amenadiel/repos","events_url":"https://api.github.com/users/amenadiel/events{/privacy}","received_events_url":"https://api.github.com/users/amenadiel/received_events","type":"User","site_admin":false},"body":"In reference to #54\r\n\r\nA new class `\\PHPPgAdmin\\XHtml\\HTMLFooterController` was created to manage methods\r\n\r\n - printFooter\r\n - printReload\r\n - setFocus\r\n - setWindowName\r\n\r\nThis class has member private properties\r\n\r\n -  $_reload_drop_database\r\n - $_no_bottom_link\r\n\r\nThese variables used to be in class `Misc` and were not visible from `HelperTrait` (which explain the regression). They are now set via their respective setters `setReloadDropDatabase` and `setNoBottomLink`.\r\n\r\nMethods `printFooter` and `setWindowName` need the value of `Misc` private member variables `$server_id` and `$_reload_browser`. To retrieve these values, getter methods of `Misc` are used.\r\n\r\nEvery method on `HTMLFooterController` can be called from `BaseController` which in turns instances a new  `HTMLFooterController` (if it doesn't exist already) and forwards to the respective method on this instance.\r\n\r\n\r\n","created_at":"2017-08-09T19:08:22Z","updated_at":"2017-08-09T19:21:24Z","closed_at":"2017-08-09T19:21:23Z","merged_at":"2017-08-09T19:21:23Z","merge_commit_sha":"99932d827dd08e942bc79568367045ecf3932001","assignee":{"login":"amenadiel","id":238439,"avatar_url":"https://avatars2.githubusercontent.com/u/238439?v=4","gravatar_id":"","url":"https://api.github.com/users/amenadiel","html_url":"https://github.com/amenadiel","followers_url":"https://api.github.com/users/amenadiel/followers","following_url":"https://api.github.com/users/amenadiel/following{/other_user}","gists_url":"https://api.github.com/users/amenadiel/gists{/gist_id}","starred_url":"https://api.github.com/users/amenadiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amenadiel/subscriptions","organizations_url":"https://api.github.com/users/amenadiel/orgs","repos_url":"https://api.github.com/users/amenadiel/repos","events_url":"https://api.github.com/users/amenadiel/events{/privacy}","received_events_url":"https://api.github.com/users/amenadiel/received_events","type":"User","site_admin":false},"assignees":[{"login":"amenadiel","id":238439,"avatar_url":"https://avatars2.githubusercontent.com/u/238439?v=4","gravatar_id":"","url":"https://api.github.com/users/amenadiel","html_url":"https://github.com/amenadiel","followers_url":"https://api.github.com/users/amenadiel/followers","following_url":"https://api.github.com/users/amenadiel/following{/other_user}","gists_url":"https://api.github.com/users/amenadiel/gists{/gist_id}","starred_url":"https://api.github.com/users/amenadiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amenadiel/subscriptions","organizations_url":"https://api.github.com/users/amenadiel/orgs","repos_url":"https://api.github.com/users/amenadiel/repos","events_url":"https://api.github.com/users/amenadiel/events{/privacy}","received_events_url":"https://api.github.com/users/amenadiel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/milestones/1","html_url":"https://github.com/HuasoFoundries/phpPgAdmin6/milestone/1","labels_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/milestones/1/labels","id":2016448,"number":1,"title":"v6.0.0 Release Candidate 1","description":"Stuff that should be working before declaring our first RC","creator":{"login":"amenadiel","id":238439,"avatar_url":"https://avatars2.githubusercontent.com/u/238439?v=4","gravatar_id":"","url":"https://api.github.com/users/amenadiel","html_url":"https://github.com/amenadiel","followers_url":"https://api.github.com/users/amenadiel/followers","following_url":"https://api.github.com/users/amenadiel/following{/other_user}","gists_url":"https://api.github.com/users/amenadiel/gists{/gist_id}","starred_url":"https://api.github.com/users/amenadiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amenadiel/subscriptions","organizations_url":"https://api.github.com/users/amenadiel/orgs","repos_url":"https://api.github.com/users/amenadiel/repos","events_url":"https://api.github.com/users/amenadiel/events{/privacy}","received_events_url":"https://api.github.com/users/amenadiel/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":5,"state":"open","created_at":"2016-09-20T13:09:50Z","updated_at":"2017-08-09T19:21:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/55/commits","review_comments_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/55/comments","review_comment_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/55/comments","statuses_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/statuses/b1dbff4f9c4f5fbab1afc9274082c8325fe5943e","head":{"label":"HuasoFoundries:feature/footer_controller","ref":"feature/footer_controller","sha":"b1dbff4f9c4f5fbab1afc9274082c8325fe5943e","user":{"login":"HuasoFoundries","id":17783051,"avatar_url":"https://avatars1.githubusercontent.com/u/17783051?v=4","gravatar_id":"","url":"https://api.github.com/users/HuasoFoundries","html_url":"https://github.com/HuasoFoundries","followers_url":"https://api.github.com/users/HuasoFoundries/followers","following_url":"https://api.github.com/users/HuasoFoundries/following{/other_user}","gists_url":"https://api.github.com/users/HuasoFoundries/gists{/gist_id}","starred_url":"https://api.github.com/users/HuasoFoundries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuasoFoundries/subscriptions","organizations_url":"https://api.github.com/users/HuasoFoundries/orgs","repos_url":"https://api.github.com/users/HuasoFoundries/repos","events_url":"https://api.github.com/users/HuasoFoundries/events{/privacy}","received_events_url":"https://api.github.com/users/HuasoFoundries/received_events","type":"Organization","site_admin":false},"repo":{"id":21398998,"name":"phpPgAdmin6","full_name":"HuasoFoundries/phpPgAdmin6","owner":{"login":"HuasoFoundries","id":17783051,"avatar_url":"https://avatars1.githubusercontent.com/u/17783051?v=4","gravatar_id":"","url":"https://api.github.com/users/HuasoFoundries","html_url":"https://github.com/HuasoFoundries","followers_url":"https://api.github.com/users/HuasoFoundries/followers","following_url":"https://api.github.com/users/HuasoFoundries/following{/other_user}","gists_url":"https://api.github.com/users/HuasoFoundries/gists{/gist_id}","starred_url":"https://api.github.com/users/HuasoFoundries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuasoFoundries/subscriptions","organizations_url":"https://api.github.com/users/HuasoFoundries/orgs","repos_url":"https://api.github.com/users/HuasoFoundries/repos","events_url":"https://api.github.com/users/HuasoFoundries/events{/privacy}","received_events_url":"https://api.github.com/users/HuasoFoundries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HuasoFoundries/phpPgAdmin6","description":"composer ready fork of this awesome web admin for postgres","fork":false,"url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6","forks_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/forks","keys_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/teams","hooks_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/hooks","issue_events_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/events{/number}","events_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/events","assignees_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/assignees{/user}","branches_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/branches{/branch}","tags_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/tags","blobs_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/statuses/{sha}","languages_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/languages","stargazers_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/stargazers","contributors_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/contributors","subscribers_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/subscribers","subscription_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/subscription","commits_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/contents/{+path}","compare_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/merges","archive_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/downloads","issues_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues{/number}","pulls_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls{/number}","milestones_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/milestones{/number}","notifications_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/labels{/name}","releases_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/releases{/id}","deployments_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/deployments","created_at":"2014-07-01T18:59:09Z","updated_at":"2017-08-03T11:49:32Z","pushed_at":"2017-08-09T19:21:23Z","git_url":"git://github.com/HuasoFoundries/phpPgAdmin6.git","ssh_url":"git@github.com:HuasoFoundries/phpPgAdmin6.git","clone_url":"https://github.com/HuasoFoundries/phpPgAdmin6.git","svn_url":"https://github.com/HuasoFoundries/phpPgAdmin6","homepage":"https://github.com/phppgadmin/phppgadmin","size":14068,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":17,"default_branch":"master"}},"base":{"label":"HuasoFoundries:develop","ref":"develop","sha":"8c8a799cd071079585a342170648882dbeb42edb","user":{"login":"HuasoFoundries","id":17783051,"avatar_url":"https://avatars1.githubusercontent.com/u/17783051?v=4","gravatar_id":"","url":"https://api.github.com/users/HuasoFoundries","html_url":"https://github.com/HuasoFoundries","followers_url":"https://api.github.com/users/HuasoFoundries/followers","following_url":"https://api.github.com/users/HuasoFoundries/following{/other_user}","gists_url":"https://api.github.com/users/HuasoFoundries/gists{/gist_id}","starred_url":"https://api.github.com/users/HuasoFoundries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuasoFoundries/subscriptions","organizations_url":"https://api.github.com/users/HuasoFoundries/orgs","repos_url":"https://api.github.com/users/HuasoFoundries/repos","events_url":"https://api.github.com/users/HuasoFoundries/events{/privacy}","received_events_url":"https://api.github.com/users/HuasoFoundries/received_events","type":"Organization","site_admin":false},"repo":{"id":21398998,"name":"phpPgAdmin6","full_name":"HuasoFoundries/phpPgAdmin6","owner":{"login":"HuasoFoundries","id":17783051,"avatar_url":"https://avatars1.githubusercontent.com/u/17783051?v=4","gravatar_id":"","url":"https://api.github.com/users/HuasoFoundries","html_url":"https://github.com/HuasoFoundries","followers_url":"https://api.github.com/users/HuasoFoundries/followers","following_url":"https://api.github.com/users/HuasoFoundries/following{/other_user}","gists_url":"https://api.github.com/users/HuasoFoundries/gists{/gist_id}","starred_url":"https://api.github.com/users/HuasoFoundries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuasoFoundries/subscriptions","organizations_url":"https://api.github.com/users/HuasoFoundries/orgs","repos_url":"https://api.github.com/users/HuasoFoundries/repos","events_url":"https://api.github.com/users/HuasoFoundries/events{/privacy}","received_events_url":"https://api.github.com/users/HuasoFoundries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HuasoFoundries/phpPgAdmin6","description":"composer ready fork of this awesome web admin for postgres","fork":false,"url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6","forks_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/forks","keys_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/teams","hooks_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/hooks","issue_events_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/events{/number}","events_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/events","assignees_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/assignees{/user}","branches_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/branches{/branch}","tags_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/tags","blobs_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/statuses/{sha}","languages_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/languages","stargazers_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/stargazers","contributors_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/contributors","subscribers_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/subscribers","subscription_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/subscription","commits_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/contents/{+path}","compare_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/merges","archive_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/downloads","issues_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues{/number}","pulls_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls{/number}","milestones_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/milestones{/number}","notifications_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/labels{/name}","releases_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/releases{/id}","deployments_url":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/deployments","created_at":"2014-07-01T18:59:09Z","updated_at":"2017-08-03T11:49:32Z","pushed_at":"2017-08-09T19:21:23Z","git_url":"git://github.com/HuasoFoundries/phpPgAdmin6.git","ssh_url":"git@github.com:HuasoFoundries/phpPgAdmin6.git","clone_url":"https://github.com/HuasoFoundries/phpPgAdmin6.git","svn_url":"https://github.com/HuasoFoundries/phpPgAdmin6","homepage":"https://github.com/phppgadmin/phppgadmin","size":14068,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/55"},"html":{"href":"https://github.com/HuasoFoundries/phpPgAdmin6/pull/55"},"issue":{"href":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/55"},"comments":{"href":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/HuasoFoundries/phpPgAdmin6/statuses/b1dbff4f9c4f5fbab1afc9274082c8325fe5943e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"amenadiel","id":238439,"avatar_url":"https://avatars2.githubusercontent.com/u/238439?v=4","gravatar_id":"","url":"https://api.github.com/users/amenadiel","html_url":"https://github.com/amenadiel","followers_url":"https://api.github.com/users/amenadiel/followers","following_url":"https://api.github.com/users/amenadiel/following{/other_user}","gists_url":"https://api.github.com/users/amenadiel/gists{/gist_id}","starred_url":"https://api.github.com/users/amenadiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amenadiel/subscriptions","organizations_url":"https://api.github.com/users/amenadiel/orgs","repos_url":"https://api.github.com/users/amenadiel/repos","events_url":"https://api.github.com/users/amenadiel/events{/privacy}","received_events_url":"https://api.github.com/users/amenadiel/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":353,"deletions":284,"changed_files":48}}
{"actor":{"display_login":"amenadiel"}}