{"action":"created","issue":{"url":"https://api.github.com/repos/loggerhead/shadowsocks-rust/issues/2","repository_url":"https://api.github.com/repos/loggerhead/shadowsocks-rust","labels_url":"https://api.github.com/repos/loggerhead/shadowsocks-rust/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/loggerhead/shadowsocks-rust/issues/2/comments","events_url":"https://api.github.com/repos/loggerhead/shadowsocks-rust/issues/2/events","html_url":"https://github.com/loggerhead/shadowsocks-rust/issues/2","id":198194159,"number":2,"title":"Possible timing attack vulnerability","user":{"login":"Philipp91","id":2501211,"avatar_url":"https://avatars.githubusercontent.com/u/2501211?v=3","gravatar_id":"","url":"https://api.github.com/users/Philipp91","html_url":"https://github.com/Philipp91","followers_url":"https://api.github.com/users/Philipp91/followers","following_url":"https://api.github.com/users/Philipp91/following{/other_user}","gists_url":"https://api.github.com/users/Philipp91/gists{/gist_id}","starred_url":"https://api.github.com/users/Philipp91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Philipp91/subscriptions","organizations_url":"https://api.github.com/users/Philipp91/orgs","repos_url":"https://api.github.com/users/Philipp91/repos","events_url":"https://api.github.com/users/Philipp91/events{/privacy}","received_events_url":"https://api.github.com/users/Philipp91/received_events","type":"User","site_admin":false},"labels":[{"id":436876544,"url":"https://api.github.com/repos/loggerhead/shadowsocks-rust/labels/wontfix","name":"wontfix","color":"ffffff","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-30T21:01:31Z","updated_at":"2017-01-01T13:39:07Z","closed_at":null,"body":"Just a quick heads-up from a passer-by:\r\nhttps://github.com/loggerhead/shadowsocks-rust/blob/master/src/crypto/encryptor.rs#L314\r\nThis comparison might be vulnerable to timing attacks because it's not constant-time. Not sure if that's relevant here at all. I'm reporting such issues to a couple of repositories, please just ignore/close if it isn't applicable here."},"comment":{"url":"https://api.github.com/repos/loggerhead/shadowsocks-rust/issues/comments/269903399","html_url":"https://github.com/loggerhead/shadowsocks-rust/issues/2#issuecomment-269903399","issue_url":"https://api.github.com/repos/loggerhead/shadowsocks-rust/issues/2","id":269903399,"user":{"login":"loggerhead","id":5056390,"avatar_url":"https://avatars.githubusercontent.com/u/5056390?v=3","gravatar_id":"","url":"https://api.github.com/users/loggerhead","html_url":"https://github.com/loggerhead","followers_url":"https://api.github.com/users/loggerhead/followers","following_url":"https://api.github.com/users/loggerhead/following{/other_user}","gists_url":"https://api.github.com/users/loggerhead/gists{/gist_id}","starred_url":"https://api.github.com/users/loggerhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loggerhead/subscriptions","organizations_url":"https://api.github.com/users/loggerhead/orgs","repos_url":"https://api.github.com/users/loggerhead/repos","events_url":"https://api.github.com/users/loggerhead/events{/privacy}","received_events_url":"https://api.github.com/users/loggerhead/received_events","type":"User","site_admin":false},"created_at":"2017-01-01T13:39:07Z","updated_at":"2017-01-01T13:39:07Z","body":"@quininer \r\n> No, attacker could use this vulnerability to construct any packet and pass one time auth (just MAC).\r\n\r\n Sorry, I understand the risk of the \"insecure compare\", but I don't understand how to implementation the attack you described above. As the attacker don't know the key (need `password` to construct) used in encryption, so he can't construct a correct packet with a custom hmac that `ssserver` can correctly decrypt, so he can't construct \"insecure compare\" as he wanted."}}
{"actor":{"display_login":"loggerhead"}}