{"action":"closed","number":1467,"pull_request":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1467","id":104777798,"html_url":"https://github.com/mishoo/UglifyJS2/pull/1467","diff_url":"https://github.com/mishoo/UglifyJS2/pull/1467.diff","patch_url":"https://github.com/mishoo/UglifyJS2/pull/1467.patch","issue_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1467","number":1467,"state":"closed","locked":false,"title":"[WIP] allow global_defs to pass in objects and arrays","user":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars.githubusercontent.com/u/1898413?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"body":"This is an alternative approach to #1198 which is based upon #1425 to fix #1416. We extend `global_defs` to allow object as input values, which it would previously [throw an error](https://github.com/mishoo/UglifyJS2/blob/0610c020b1544820be9898a285ab6c9066490552/lib/compress.js#L218-L220) [upon compression](https://github.com/mishoo/UglifyJS2/blob/0610c020b1544820be9898a285ab6c9066490552/lib/compress.js#L2692).\r\n\r\nWith this PR `global_defs` now requires `evaluate` (`true` by default) for substitutions to take place. Also the `evaluate()` caching that was implemented in #1425 is now used in general.","created_at":"2017-02-06T11:11:23Z","updated_at":"2017-02-08T00:12:31Z","closed_at":"2017-02-08T00:12:31Z","merged_at":null,"merge_commit_sha":"0bd94294efaef426fb98249d2ba102d965177a77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1467/commits","review_comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1467/comments","review_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1467/comments","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/263fb4c2d9e8f1266efab4f0d3558703e3a0a8bd","head":{"label":"alexlamsl:global_defs-unsafe","ref":"global_defs-unsafe","sha":"263fb4c2d9e8f1266efab4f0d3558703e3a0a8bd","user":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars.githubusercontent.com/u/1898413?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"repo":{"id":79024614,"name":"UglifyJS2","full_name":"alexlamsl/UglifyJS2","owner":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars.githubusercontent.com/u/1898413?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexlamsl/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":true,"url":"https://api.github.com/repos/alexlamsl/UglifyJS2","forks_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/forks","keys_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/events","assignees_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/merges","archive_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/deployments","created_at":"2017-01-15T10:31:17Z","updated_at":"2017-01-15T10:31:20Z","pushed_at":"2017-02-08T00:12:06Z","git_url":"git://github.com/alexlamsl/UglifyJS2.git","ssh_url":"git@github.com:alexlamsl/UglifyJS2.git","clone_url":"https://github.com/alexlamsl/UglifyJS2.git","svn_url":"https://github.com/alexlamsl/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":2465,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mishoo:master","ref":"master","sha":"7f8d72d9d37396f2da05d5d824f74bd414c30119","user":{"login":"mishoo","id":334725,"avatar_url":"https://avatars.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"repo":{"id":5569059,"name":"UglifyJS2","full_name":"mishoo/UglifyJS2","owner":{"login":"mishoo","id":334725,"avatar_url":"https://avatars.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishoo/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":false,"url":"https://api.github.com/repos/mishoo/UglifyJS2","forks_url":"https://api.github.com/repos/mishoo/UglifyJS2/forks","keys_url":"https://api.github.com/repos/mishoo/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishoo/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishoo/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/mishoo/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/mishoo/UglifyJS2/events","assignees_url":"https://api.github.com/repos/mishoo/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/mishoo/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/mishoo/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/mishoo/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/mishoo/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishoo/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/mishoo/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishoo/UglifyJS2/merges","archive_url":"https://api.github.com/repos/mishoo/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishoo/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/mishoo/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/mishoo/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishoo/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/mishoo/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/mishoo/UglifyJS2/deployments","created_at":"2012-08-27T09:31:03Z","updated_at":"2017-02-07T20:06:21Z","pushed_at":"2017-02-08T00:12:07Z","git_url":"git://github.com/mishoo/UglifyJS2.git","ssh_url":"git@github.com:mishoo/UglifyJS2.git","clone_url":"https://github.com/mishoo/UglifyJS2.git","svn_url":"https://github.com/mishoo/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":2441,"stargazers_count":5955,"watchers_count":5955,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":680,"mirror_url":null,"open_issues_count":326,"forks":680,"open_issues":326,"watchers":5955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1467"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/1467"},"issue":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1467"},"comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1467/comments"},"review_comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1467/comments"},"review_comment":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1467/commits"},"statuses":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/263fb4c2d9e8f1266efab4f0d3558703e3a0a8bd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":34,"review_comments":8,"maintainer_can_modify":false,"commits":1,"additions":249,"deletions":22,"changed_files":8}}
{"actor":{"display_login":"alexlamsl"}}