{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments/103257699","pull_request_review_id":24038815,"id":103257699,"diff_hunk":"@@ -0,0 +1,12 @@\n+# Run eos-firewall-localonly before NetworkManager starts\n+\n+[Unit]\n+Description=Endless local-only firewall\n+Before=NetworkManager.service\n+\n+[Service]\n+Type=oneshot","path":"eos-firewall-localonly.service","position":8,"original_position":8,"commit_id":"0a678fdd8b39403d9fe752797acc439b96d63cba","original_commit_id":"0a678fdd8b39403d9fe752797acc439b96d63cba","user":{"login":"pwithnall","id":53172,"avatar_url":"https://avatars.githubusercontent.com/u/53172?v=3","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"body":"It’s a bit counterintuitive that `sudo systemctl start eos-firewall-localonly.service` will enable the firewall, but `sudo systemctl stop eos-firewall-localonly.service` will *not* stop it.","created_at":"2017-02-27T17:04:19Z","updated_at":"2017-02-27T17:04:19Z","html_url":"https://github.com/endlessm/eos-boot-helper/pull/97#discussion_r103257699","pull_request_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments/103257699"},"html":{"href":"https://github.com/endlessm/eos-boot-helper/pull/97#discussion_r103257699"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97","id":108124001,"html_url":"https://github.com/endlessm/eos-boot-helper/pull/97","diff_url":"https://github.com/endlessm/eos-boot-helper/pull/97.diff","patch_url":"https://github.com/endlessm/eos-boot-helper/pull/97.patch","issue_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/97","number":97,"state":"open","locked":false,"title":"add eos-firewall-localonly service","user":{"login":"ramcq","id":254468,"avatar_url":"https://avatars.githubusercontent.com/u/254468?v=3","gravatar_id":"","url":"https://api.github.com/users/ramcq","html_url":"https://github.com/ramcq","followers_url":"https://api.github.com/users/ramcq/followers","following_url":"https://api.github.com/users/ramcq/following{/other_user}","gists_url":"https://api.github.com/users/ramcq/gists{/gist_id}","starred_url":"https://api.github.com/users/ramcq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramcq/subscriptions","organizations_url":"https://api.github.com/users/ramcq/orgs","repos_url":"https://api.github.com/users/ramcq/repos","events_url":"https://api.github.com/users/ramcq/events{/privacy}","received_events_url":"https://api.github.com/users/ramcq/received_events","type":"User","site_admin":false},"body":"This implements a simple iptables/ip6tables firewall which allows the\r\nhost to communicate only with resources on the local network, plus a few\r\nexplicitly-enabled hosts (the Endless metrics / phone-home servers) and\r\nservices (DNS and NTP).\r\n\r\nThere is a script eos-firewall-localonly which sets up the initial\r\ntables with common local network and local multicast addresses,\r\npermitted interfaces (lo) and the permitted services, and a\r\nNetworkManager dispatch script called eos-firewall-localonly-nm which\r\nadds additional rules allowing traffic to the permitted hosts (so that the\r\nDNS requests are not done at boot time before the network is available)\r\nand any other local network routes which have been assigned via DHCP.\r\n\r\nDenied TCP connections are reset so that the local application receives\r\nan error immediately, and any blocked packets are logged to the journal\r\nwith a relatively low frequency.\r\n\r\nFor obvious reasons, the systemd service is disabled by default: this\r\nfunctionality must be explicitly enabled on the hosts where it is\r\ndesirable.\r\n\r\nhttps://phabricator.endlessm.com/T15709","created_at":"2017-02-27T14:24:48Z","updated_at":"2017-02-27T17:04:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc5ee60c5460a1d0e3e47e0f834857ed889d1dcb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/97/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/0a678fdd8b39403d9fe752797acc439b96d63cba","head":{"label":"endlessm:T15709","ref":"T15709","sha":"0a678fdd8b39403d9fe752797acc439b96d63cba","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2016-11-02T20:32:37Z","pushed_at":"2017-02-27T14:38:50Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"git@github.com:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":171,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"d7dd154a7a59781d871ad5bd4c25e26adbf18e89","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2016-11-02T20:32:37Z","pushed_at":"2017-02-27T14:38:50Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"git@github.com:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":171,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97"},"html":{"href":"https://github.com/endlessm/eos-boot-helper/pull/97"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/97"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/0a678fdd8b39403d9fe752797acc439b96d63cba"}}}}
{"actor":{"display_login":"pwithnall"}}