{"action":"created","issue":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/1993","repository_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/1993/labels{/name}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/1993/comments","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/1993/events","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/issues/1993","id":252065903,"number":1993,"title":"[Dropdown] `selectOnKeydown` option from docs is not implemented","user":{"login":"rijk","id":159500,"avatar_url":"https://avatars2.githubusercontent.com/u/159500?v=4","gravatar_id":"","url":"https://api.github.com/users/rijk","html_url":"https://github.com/rijk","followers_url":"https://api.github.com/users/rijk/followers","following_url":"https://api.github.com/users/rijk/following{/other_user}","gists_url":"https://api.github.com/users/rijk/gists{/gist_id}","starred_url":"https://api.github.com/users/rijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rijk/subscriptions","organizations_url":"https://api.github.com/users/rijk/orgs","repos_url":"https://api.github.com/users/rijk/repos","events_url":"https://api.github.com/users/rijk/events{/privacy}","received_events_url":"https://api.github.com/users/rijk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-22T19:36:19Z","updated_at":"2017-08-22T20:03:38Z","closed_at":null,"body":"### Steps\r\nUsed the `selectOnKeydown={false}` option as [mentioned in the docs](https://semantic-ui.com/modules/dropdown.html#/settings):\r\n\r\n> Whether dropdown should select new option when using keyboard shortcuts. Setting to false will require enter or left click to confirm a choice.\r\n\r\n### Expected Result\r\n\r\nKeyboard navigation moving selection, without actually changing value.\r\n\r\n### Actual Result\r\n\r\nValue changes and dropdown closes when pressing e.g. arrow down key. + React warning:\r\n\r\n```\r\nWarning: Unknown prop `selectOnKeydown` on <div> tag. Remove this prop from the element.\r\n```\r\n\r\n### Version\r\n0.71.5\r\n\r\nI think the problem is here: https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/modules/Dropdown/Dropdown.js#L543\r\n\r\nThis line should be IMO something like this:\r\n\r\n`if (!multiple && selectOnKeydown) this.makeSelectedItemActive(e)`"},"comment":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/comments/324136168","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/issues/1993#issuecomment-324136168","issue_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/1993","id":324136168,"user":{"login":"rijk","id":159500,"avatar_url":"https://avatars2.githubusercontent.com/u/159500?v=4","gravatar_id":"","url":"https://api.github.com/users/rijk","html_url":"https://github.com/rijk","followers_url":"https://api.github.com/users/rijk/followers","following_url":"https://api.github.com/users/rijk/following{/other_user}","gists_url":"https://api.github.com/users/rijk/gists{/gist_id}","starred_url":"https://api.github.com/users/rijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rijk/subscriptions","organizations_url":"https://api.github.com/users/rijk/orgs","repos_url":"https://api.github.com/users/rijk/repos","events_url":"https://api.github.com/users/rijk/events{/privacy}","received_events_url":"https://api.github.com/users/rijk/received_events","type":"User","site_admin":false},"created_at":"2017-08-22T20:03:38Z","updated_at":"2017-08-22T20:03:38Z","body":"Ah doh, this is the Semantic docs, not the Semantic React. Even so, it would be nice to see this option implemented. Having the value selected right away when pressing down arrow just feels really unintuitive."}}
{"actor":{"display_login":"rijk"}}