{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/synapse-tools/pulls/comments/128383092","pull_request_review_id":51056571,"id":128383092,"diff_hunk":"@@ -475,6 +477,31 @@ def generate_configuration(synapse_tools_config, zookeeper_topology, services):\n                     )\n                 )\n \n+            # Add HAProxy options if logging is enabled\n+            plugins = service_info.get('plugins', {})\n+            if plugins.get('logging') is not None:","path":"src/synapse_tools/configure_synapse.py","position":15,"original_position":15,"commit_id":"1c7d065d246f577a8f81bcb57d59dbc167502814","original_commit_id":"1c7d065d246f577a8f81bcb57d59dbc167502814","user":{"login":"jvperrin","id":1523594,"avatar_url":"https://avatars1.githubusercontent.com/u/1523594?v=4","gravatar_id":"","url":"https://api.github.com/users/jvperrin","html_url":"https://github.com/jvperrin","followers_url":"https://api.github.com/users/jvperrin/followers","following_url":"https://api.github.com/users/jvperrin/following{/other_user}","gists_url":"https://api.github.com/users/jvperrin/gists{/gist_id}","starred_url":"https://api.github.com/users/jvperrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvperrin/subscriptions","organizations_url":"https://api.github.com/users/jvperrin/orgs","repos_url":"https://api.github.com/users/jvperrin/repos","events_url":"https://api.github.com/users/jvperrin/events{/privacy}","received_events_url":"https://api.github.com/users/jvperrin/received_events","type":"User","site_admin":false},"body":"Could this be `if plugins.get('logging'):` instead? (if it's not an empty list or anything \"Falsy\")\r\n\r\nIt would be a little cleaner if so.","created_at":"2017-07-19T22:20:42Z","updated_at":"2017-07-19T22:23:24Z","html_url":"https://github.com/Yelp/synapse-tools/pull/34#discussion_r128383092","pull_request_url":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/Yelp/synapse-tools/pulls/comments/128383092"},"html":{"href":"https://github.com/Yelp/synapse-tools/pull/34#discussion_r128383092"},"pull_request":{"href":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34","id":131428907,"html_url":"https://github.com/Yelp/synapse-tools/pull/34","diff_url":"https://github.com/Yelp/synapse-tools/pull/34.diff","patch_url":"https://github.com/Yelp/synapse-tools/pull/34.patch","issue_url":"https://api.github.com/repos/Yelp/synapse-tools/issues/34","number":34,"state":"open","locked":false,"title":"Configure synapse plugins","user":{"login":"zareenc","id":8904273,"avatar_url":"https://avatars3.githubusercontent.com/u/8904273?v=4","gravatar_id":"","url":"https://api.github.com/users/zareenc","html_url":"https://github.com/zareenc","followers_url":"https://api.github.com/users/zareenc/followers","following_url":"https://api.github.com/users/zareenc/following{/other_user}","gists_url":"https://api.github.com/users/zareenc/gists{/gist_id}","starred_url":"https://api.github.com/users/zareenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zareenc/subscriptions","organizations_url":"https://api.github.com/users/zareenc/orgs","repos_url":"https://api.github.com/users/zareenc/repos","events_url":"https://api.github.com/users/zareenc/events{/privacy}","received_events_url":"https://api.github.com/users/zareenc/received_events","type":"User","site_admin":false},"body":"Support for Python plugins for configuring synapse, with initial support and testing for Lua logging plugin\r\n\r\ncc: @jolynch ","created_at":"2017-07-19T21:56:06Z","updated_at":"2017-07-19T22:23:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11bed58a58972b2b66c8b23e2e1581c52c295be0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34/commits","review_comments_url":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34/comments","review_comment_url":"https://api.github.com/repos/Yelp/synapse-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/synapse-tools/issues/34/comments","statuses_url":"https://api.github.com/repos/Yelp/synapse-tools/statuses/1c7d065d246f577a8f81bcb57d59dbc167502814","head":{"label":"zareenc:synapse-config-plugin","ref":"synapse-config-plugin","sha":"1c7d065d246f577a8f81bcb57d59dbc167502814","user":{"login":"zareenc","id":8904273,"avatar_url":"https://avatars3.githubusercontent.com/u/8904273?v=4","gravatar_id":"","url":"https://api.github.com/users/zareenc","html_url":"https://github.com/zareenc","followers_url":"https://api.github.com/users/zareenc/followers","following_url":"https://api.github.com/users/zareenc/following{/other_user}","gists_url":"https://api.github.com/users/zareenc/gists{/gist_id}","starred_url":"https://api.github.com/users/zareenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zareenc/subscriptions","organizations_url":"https://api.github.com/users/zareenc/orgs","repos_url":"https://api.github.com/users/zareenc/repos","events_url":"https://api.github.com/users/zareenc/events{/privacy}","received_events_url":"https://api.github.com/users/zareenc/received_events","type":"User","site_admin":false},"repo":{"id":97175976,"name":"synapse-tools","full_name":"zareenc/synapse-tools","owner":{"login":"zareenc","id":8904273,"avatar_url":"https://avatars3.githubusercontent.com/u/8904273?v=4","gravatar_id":"","url":"https://api.github.com/users/zareenc","html_url":"https://github.com/zareenc","followers_url":"https://api.github.com/users/zareenc/followers","following_url":"https://api.github.com/users/zareenc/following{/other_user}","gists_url":"https://api.github.com/users/zareenc/gists{/gist_id}","starred_url":"https://api.github.com/users/zareenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zareenc/subscriptions","organizations_url":"https://api.github.com/users/zareenc/orgs","repos_url":"https://api.github.com/users/zareenc/repos","events_url":"https://api.github.com/users/zareenc/events{/privacy}","received_events_url":"https://api.github.com/users/zareenc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zareenc/synapse-tools","description":"Tools for configuring synapse and reloading haproxy hitlessly","fork":true,"url":"https://api.github.com/repos/zareenc/synapse-tools","forks_url":"https://api.github.com/repos/zareenc/synapse-tools/forks","keys_url":"https://api.github.com/repos/zareenc/synapse-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zareenc/synapse-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zareenc/synapse-tools/teams","hooks_url":"https://api.github.com/repos/zareenc/synapse-tools/hooks","issue_events_url":"https://api.github.com/repos/zareenc/synapse-tools/issues/events{/number}","events_url":"https://api.github.com/repos/zareenc/synapse-tools/events","assignees_url":"https://api.github.com/repos/zareenc/synapse-tools/assignees{/user}","branches_url":"https://api.github.com/repos/zareenc/synapse-tools/branches{/branch}","tags_url":"https://api.github.com/repos/zareenc/synapse-tools/tags","blobs_url":"https://api.github.com/repos/zareenc/synapse-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zareenc/synapse-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zareenc/synapse-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/zareenc/synapse-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zareenc/synapse-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/zareenc/synapse-tools/languages","stargazers_url":"https://api.github.com/repos/zareenc/synapse-tools/stargazers","contributors_url":"https://api.github.com/repos/zareenc/synapse-tools/contributors","subscribers_url":"https://api.github.com/repos/zareenc/synapse-tools/subscribers","subscription_url":"https://api.github.com/repos/zareenc/synapse-tools/subscription","commits_url":"https://api.github.com/repos/zareenc/synapse-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/zareenc/synapse-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/zareenc/synapse-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/zareenc/synapse-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/zareenc/synapse-tools/contents/{+path}","compare_url":"https://api.github.com/repos/zareenc/synapse-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zareenc/synapse-tools/merges","archive_url":"https://api.github.com/repos/zareenc/synapse-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zareenc/synapse-tools/downloads","issues_url":"https://api.github.com/repos/zareenc/synapse-tools/issues{/number}","pulls_url":"https://api.github.com/repos/zareenc/synapse-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/zareenc/synapse-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/zareenc/synapse-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zareenc/synapse-tools/labels{/name}","releases_url":"https://api.github.com/repos/zareenc/synapse-tools/releases{/id}","deployments_url":"https://api.github.com/repos/zareenc/synapse-tools/deployments","created_at":"2017-07-14T00:27:32Z","updated_at":"2017-07-14T00:27:33Z","pushed_at":"2017-07-19T21:49:40Z","git_url":"git://github.com/zareenc/synapse-tools.git","ssh_url":"git@github.com:zareenc/synapse-tools.git","clone_url":"https://github.com/zareenc/synapse-tools.git","svn_url":"https://github.com/zareenc/synapse-tools","homepage":"","size":47965,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"d9c7cb48e5cf9cc5f3493eb6bee2135d8afd13f8","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":45880431,"name":"synapse-tools","full_name":"Yelp/synapse-tools","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/synapse-tools","description":"Tools for configuring synapse and reloading haproxy hitlessly","fork":false,"url":"https://api.github.com/repos/Yelp/synapse-tools","forks_url":"https://api.github.com/repos/Yelp/synapse-tools/forks","keys_url":"https://api.github.com/repos/Yelp/synapse-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/synapse-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/synapse-tools/teams","hooks_url":"https://api.github.com/repos/Yelp/synapse-tools/hooks","issue_events_url":"https://api.github.com/repos/Yelp/synapse-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/synapse-tools/events","assignees_url":"https://api.github.com/repos/Yelp/synapse-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/synapse-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/synapse-tools/tags","blobs_url":"https://api.github.com/repos/Yelp/synapse-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/synapse-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/synapse-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/synapse-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/synapse-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/synapse-tools/languages","stargazers_url":"https://api.github.com/repos/Yelp/synapse-tools/stargazers","contributors_url":"https://api.github.com/repos/Yelp/synapse-tools/contributors","subscribers_url":"https://api.github.com/repos/Yelp/synapse-tools/subscribers","subscription_url":"https://api.github.com/repos/Yelp/synapse-tools/subscription","commits_url":"https://api.github.com/repos/Yelp/synapse-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/synapse-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/synapse-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/synapse-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/synapse-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/synapse-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/synapse-tools/merges","archive_url":"https://api.github.com/repos/Yelp/synapse-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/synapse-tools/downloads","issues_url":"https://api.github.com/repos/Yelp/synapse-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/synapse-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/synapse-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/synapse-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/synapse-tools/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/synapse-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/synapse-tools/deployments","created_at":"2015-11-10T01:56:56Z","updated_at":"2017-07-19T22:12:17Z","pushed_at":"2017-07-19T21:56:07Z","git_url":"git://github.com/Yelp/synapse-tools.git","ssh_url":"git@github.com:Yelp/synapse-tools.git","clone_url":"https://github.com/Yelp/synapse-tools.git","svn_url":"https://github.com/Yelp/synapse-tools","homepage":"","size":47949,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34"},"html":{"href":"https://github.com/Yelp/synapse-tools/pull/34"},"issue":{"href":"https://api.github.com/repos/Yelp/synapse-tools/issues/34"},"comments":{"href":"https://api.github.com/repos/Yelp/synapse-tools/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/synapse-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/synapse-tools/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/synapse-tools/statuses/1c7d065d246f577a8f81bcb57d59dbc167502814"}}}}
{"actor":{"display_login":"jvperrin"}}