{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/34880","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/34880/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/34880/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/34880/events","html_url":"https://github.com/saltstack/salt/issues/34880","id":167053255,"number":34880,"title":"salt-cloud (non templated) VM deploy to an ESXi Host appears to require a \"clonefrom\" parameter","user":{"login":"abrinded","id":9746381,"avatar_url":"https://avatars3.githubusercontent.com/u/9746381?v=3","gravatar_id":"","url":"https://api.github.com/users/abrinded","html_url":"https://github.com/abrinded","followers_url":"https://api.github.com/users/abrinded/followers","following_url":"https://api.github.com/users/abrinded/following{/other_user}","gists_url":"https://api.github.com/users/abrinded/gists{/gist_id}","starred_url":"https://api.github.com/users/abrinded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrinded/subscriptions","organizations_url":"https://api.github.com/users/abrinded/orgs","repos_url":"https://api.github.com/users/abrinded/repos","events_url":"https://api.github.com/users/abrinded/events{/privacy}","received_events_url":"https://api.github.com/users/abrinded/received_events","type":"User","site_admin":false},"labels":[{"id":41387723,"url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":194766302,"url":"https://api.github.com/repos/saltstack/salt/labels/P3","name":"P3","color":"0a3d77","default":false},{"id":220527153,"url":"https://api.github.com/repos/saltstack/salt/labels/RIoT","name":"RIoT","color":"fef2c0","default":false},{"id":65370277,"url":"https://api.github.com/repos/saltstack/salt/labels/Salt-Cloud","name":"Salt-Cloud","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestone/13","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars3.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":3490,"closed_issues":4691,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2017-06-12T22:22:45Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-07-22T14:08:08Z","updated_at":"2017-06-12T22:22:45Z","closed_at":"2017-06-12T22:22:45Z","body":"### Description of Issue/Question\n\nI am trying to create a new blank Virtual Machine using this shiny new feature introduced in 2016.3.0 via salt-cloud with a target of a single ESXi host \n\n(**NOTE:** Not using vCenter, thus no template in use nor specified)\n### Setup\n- Single Salt-Master with Salt-Cloud installed, both at version 2016.3.1\n- Followed guide: https://docs.saltstack.com/en/latest/topics/cloud/vmware.html#creating-a-vm\n- Target is a single ESXI host using a very basic provider configuration\n\n```\nesx01:\n  driver: vmware\n  user: 'root'\n  password: 'password'\n  url: '192.168.1.13'\n```\n- Using a very basic profile configuration\n\n```\nbase-gold:\n  provider: esx01\n  datastore: Datastore1\n  resourcepool: Resources\n  folder: vm\n\n  ## Optional arguments\n  num_cpus: 1\n  memory: 4GB\n  devices:\n    cd:\n      CD/DVD drive 1:\n        controller: 'IDE 0'\n        device_type: datastore_iso_file\n        iso_path: \"[Datastore1] ISOs/Microsoft/WindowsServer2012R2.iso\"\n    disk:\n      Hard disk 1:\n        size: 40\n        controller: 'SCSI controller 1'\n    network:\n      Network adapter 1:\n        name: 'VM Network'\n        adapter_type: e1000\n        switch_type: standard\n    scsi:\n      SCSI controller 1:\n        type: lsilogic\n    ide:\n      IDE 0\n      IDE 1\n\n  deploy: True\n  customization: False\n  power_on: True\n  hardware_version: 10\n  image: windows8Server64Guest\n```\n- Using the following command **salt-cloud -f test_vcenter_connection esx01** returns success\n- I couldn't find a test_esxi_connection thus assumed because it returned success, this would be fine\n\n```\nesx01:\n    ----------\n    vmware:\n        connection successful\n```\n- Using command **salt-cloud -p base-gold TESTVM -l debug** fails to deploy\n\n> [ERROR   ] The required **'clonefrom'** configuration setting is missing from the 'base-gold' profile, which is configured under the 'esx01' alias.\n> Error: There was a profile error: Failed to deploy VM\n- Other commands work fine, for example listing datastores\n\n```\nesx01:\n    ----------\n    vmware:\n        ----------\n        Datastores:\n            - Datastore1\n            - Datastore2\n```\n- Weirdly enough if I specify a template name with the name of an existing VM on my ESXI host, which is obviously not a template, I get a different error, as for whether its relevant, no idea.\n\n```\n[ERROR   ] There was a profile error: 'str' object has no attribute 'keys'\nTraceback (most recent call last):\n  File \"/usr/lib/python2.7/dist-packages/salt/cloud/cli.py\", line 284, in run\n    self.config.get('names')\n  File \"/usr/lib/python2.7/dist-packages/salt/cloud/__init__.py\", line 1446, in run_profile\n    ret[name] = self.create(vm_)\n  File \"/usr/lib/python2.7/dist-packages/salt/cloud/__init__.py\", line 1281, in create\n    output = self.clouds[func](vm_)\n  File \"/usr/lib/python2.7/dist-packages/salt/cloud/clouds/vmware.py\", line 2319, in create\n    specs = _manage_devices(devices, object_ref)\n  File \"/usr/lib/python2.7/dist-packages/salt/cloud/clouds/vmware.py\", line 687, in _manage_devices\n    ide_controllers_to_create = list(set(devices['ide'].keys()) - set(existing_ide_controllers_label))\nAttributeError: 'str' object has no attribute 'keys'\n```\n### Steps to Reproduce Issue\n- Create provider as per above\n- Create profile as per above\n- Attempt to create a new Virtual Machine on a standalone host\n### Versions Report\n\n> Salt Version:\n>            Salt: 2016.3.1\n> \n> Dependency Versions:\n>            cffi: Not Installed\n>        cherrypy: 3.5.0\n>        dateutil: 2.4.2\n>           gitdb: 0.6.4\n>       gitpython: 1.0.1\n>           ioflo: Not Installed\n>          Jinja2: 2.8\n>         libgit2: Not Installed\n>         libnacl: Not Installed\n>        M2Crypto: Not Installed\n>            Mako: 1.0.3\n>    msgpack-pure: Not Installed\n>  msgpack-python: 0.4.6\n>    mysql-python: Not Installed\n>       pycparser: Not Installed\n>        pycrypto: 2.6.1\n>          pygit2: Not Installed\n>          Python: 2.7.12 (default, Jul  1 2016, 15:12:24)\n>    python-gnupg: Not Installed\n>          PyYAML: 3.11\n>           PyZMQ: 15.2.0\n>            RAET: Not Installed\n>           smmap: 0.9.0\n>         timelib: Not Installed\n>         Tornado: 4.2.1\n>             ZMQ: 4.1.4\n> \n> System Versions:\n>            dist: Ubuntu 16.04 xenial\n>         machine: x86_64\n>         release: 4.4.0-28-generic\n>          system: Linux\n>         version: Ubuntu 16.04 xenial\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/307950904","html_url":"https://github.com/saltstack/salt/issues/34880#issuecomment-307950904","issue_url":"https://api.github.com/repos/saltstack/salt/issues/34880","id":307950904,"user":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars1.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"created_at":"2017-06-12T22:22:45Z","updated_at":"2017-06-12T22:22:45Z","body":"Thanks everyone for following up here. I agree that this can be closed now. Please let us know if this problem pops up again and we will be happy to open this issue once more."}}
{"actor":{"display_login":"rallytime"}}