{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/151910336","pull_request_review_id":77691075,"id":151910336,"diff_hunk":"@@ -20,14 +20,22 @@\n  */\n package org.apache.bookkeeper.client.api;\n \n-import com.google.common.base.Preconditions;\n+import static com.google.common.base.Preconditions.checkArgument;\n+\n import java.util.EnumSet;\n+import lombok.Getter;\n \n /**\n  * Flags to specify the behaviour of writes\n  */\n+@Getter\n public enum WriteFlag {\n-    DEFERRED_FORCE(1);\n+\n+    /**\n+     * Writes will be ackknowledged by the server even if the entry","path":"bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java","position":null,"original_position":18,"commit_id":"8fbd60937e59a588505616c1c827a03ad5d4d6fb","original_commit_id":"8fbd60937e59a588505616c1c827a03ad5d4d6fb","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"typo - acknowledged\r\n\r\nI would suggest changing the comment to \"acknowledged after writing to filesystem but not yet been persisted to disks\" or something like that.","created_at":"2017-11-20T06:32:13Z","updated_at":"2017-11-20T06:35:58Z","html_url":"https://github.com/apache/bookkeeper/pull/742#discussion_r151910336","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/742","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/151910336"},"html":{"href":"https://github.com/apache/bookkeeper/pull/742#discussion_r151910336"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/742"}}},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/742","id":153293334,"html_url":"https://github.com/apache/bookkeeper/pull/742","diff_url":"https://github.com/apache/bookkeeper/pull/742.diff","patch_url":"https://github.com/apache/bookkeeper/pull/742.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/742","number":742,"state":"open","locked":false,"title":"Issue-744 BP-18 introduce write flags","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"Introduce writeflags on the API and on protobuf files.\r\nClient and server do not use these flags yet.","created_at":"2017-11-17T13:05:31Z","updated_at":"2017-11-20T06:35:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fde2c9b54f22ca77d4b2377539ae6f8f9fbddacb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jvrao","id":41390,"avatar_url":"https://avatars1.githubusercontent.com/u/41390?v=4","gravatar_id":"","url":"https://api.github.com/users/jvrao","html_url":"https://github.com/jvrao","followers_url":"https://api.github.com/users/jvrao/followers","following_url":"https://api.github.com/users/jvrao/following{/other_user}","gists_url":"https://api.github.com/users/jvrao/gists{/gist_id}","starred_url":"https://api.github.com/users/jvrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvrao/subscriptions","organizations_url":"https://api.github.com/users/jvrao/orgs","repos_url":"https://api.github.com/users/jvrao/repos","events_url":"https://api.github.com/users/jvrao/events{/privacy}","received_events_url":"https://api.github.com/users/jvrao/received_events","type":"User","site_admin":false},{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/742/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/742/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/742/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/8fbd60937e59a588505616c1c827a03ad5d4d6fb","head":{"label":"eolivelli:bp14-writeflags","ref":"bp14-writeflags","sha":"8fbd60937e59a588505616c1c827a03ad5d4d6fb","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"repo":{"id":61374519,"name":"bookkeeper","full_name":"eolivelli/bookkeeper","owner":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eolivelli/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/eolivelli/bookkeeper","forks_url":"https://api.github.com/repos/eolivelli/bookkeeper/forks","keys_url":"https://api.github.com/repos/eolivelli/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eolivelli/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eolivelli/bookkeeper/teams","hooks_url":"https://api.github.com/repos/eolivelli/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/eolivelli/bookkeeper/events","assignees_url":"https://api.github.com/repos/eolivelli/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/eolivelli/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/tags","blobs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eolivelli/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/eolivelli/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/eolivelli/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/eolivelli/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscription","commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/eolivelli/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/eolivelli/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/eolivelli/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eolivelli/bookkeeper/merges","archive_url":"https://api.github.com/repos/eolivelli/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eolivelli/bookkeeper/downloads","issues_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/eolivelli/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/eolivelli/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/eolivelli/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eolivelli/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/eolivelli/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/eolivelli/bookkeeper/deployments","created_at":"2016-06-17T13:11:53Z","updated_at":"2016-06-17T13:11:55Z","pushed_at":"2017-11-20T02:23:43Z","git_url":"git://github.com/eolivelli/bookkeeper.git","ssh_url":"git@github.com:eolivelli/bookkeeper.git","clone_url":"https://github.com/eolivelli/bookkeeper.git","svn_url":"https://github.com/eolivelli/bookkeeper","homepage":null,"size":13668,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2b660b1e06a9b0deac011d0d6b8a2e990bf974b9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2017-11-16T21:30:41Z","pushed_at":"2017-11-20T02:23:44Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":18065,"stargazers_count":220,"watchers_count":220,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":156,"forks":138,"open_issues":156,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/742"},"html":{"href":"https://github.com/apache/bookkeeper/pull/742"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/742"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/742/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/742/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/742/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/8fbd60937e59a588505616c1c827a03ad5d4d6fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sijie"}}