{"action":"created","issue":{"url":"https://api.github.com/repos/sportngin/okcomputer/issues/130","repository_url":"https://api.github.com/repos/sportngin/okcomputer","labels_url":"https://api.github.com/repos/sportngin/okcomputer/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/sportngin/okcomputer/issues/130/comments","events_url":"https://api.github.com/repos/sportngin/okcomputer/issues/130/events","html_url":"https://github.com/sportngin/okcomputer/pull/130","id":216793190,"number":130,"title":"Gracefully handle both strings and symbols as check names","user":{"login":"pbyrne","id":34053,"avatar_url":"https://avatars1.githubusercontent.com/u/34053?v=3","gravatar_id":"","url":"https://api.github.com/users/pbyrne","html_url":"https://github.com/pbyrne","followers_url":"https://api.github.com/users/pbyrne/followers","following_url":"https://api.github.com/users/pbyrne/following{/other_user}","gists_url":"https://api.github.com/users/pbyrne/gists{/gist_id}","starred_url":"https://api.github.com/users/pbyrne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbyrne/subscriptions","organizations_url":"https://api.github.com/users/pbyrne/orgs","repos_url":"https://api.github.com/users/pbyrne/repos","events_url":"https://api.github.com/users/pbyrne/events{/privacy}","received_events_url":"https://api.github.com/users/pbyrne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-24T13:57:20Z","updated_at":"2017-03-24T16:01:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sportngin/okcomputer/pulls/130","html_url":"https://github.com/sportngin/okcomputer/pull/130","diff_url":"https://github.com/sportngin/okcomputer/pull/130.diff","patch_url":"https://github.com/sportngin/okcomputer/pull/130.patch"},"body":"Closes https://github.com/sportngin/okcomputer/issues/129.\r\n\r\n```\r\n  1) OkComputer::Registry.register(check_name, check_object) gracefully handles checks defined with a combination of strings and symbols as their name\r\n     Failure/Error: \"#{display}\\n#{checks.sort.map{ |c| \"#{\"\\s\\s\" unless c.is_a?(CheckCollection)}#{c.to_text}\"}.join(\"\\n\")}\"\r\n     \r\n     ArgumentError:\r\n       comparison of OkComputer::Check with OkComputer::Check failed\r\n     # ./lib/ok_computer/check_collection.rb:85:in `sort'\r\n     # ./lib/ok_computer/check_collection.rb:85:in `to_text'\r\n     # ./spec/ok_computer/registry_spec.rb:74:in `block (3 levels) in <module:OkComputer>'\r\n```"},"comment":{"url":"https://api.github.com/repos/sportngin/okcomputer/issues/comments/289064928","html_url":"https://github.com/sportngin/okcomputer/pull/130#issuecomment-289064928","issue_url":"https://api.github.com/repos/sportngin/okcomputer/issues/130","id":289064928,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars2.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T16:01:07Z","updated_at":"2017-03-24T16:01:07Z","body":"\n[![Coverage Status](https://coveralls.io/builds/10759530/badge)](https://coveralls.io/builds/10759530)\n\nCoverage decreased (-0.2%) to 98.329% when pulling **9ddb8c8f6d2d3a9f926a26f4eea3c977b97fc914 on whats-in-a-name** into **e14da89c79212d78e0f533870b20acd8bd700449 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}