{"action":"created","comment":{"url":"https://api.github.com/repos/DAVFoundation/missions/pulls/comments/158717492","pull_request_review_id":85566191,"id":158717492,"diff_hunk":"@@ -24,7 +24,7 @@ export default handleActions({\n     const mission = {\n       id: parseInt(mission_id),\n       vehicleId: vehicle_id,\n-      price: parseFloat(price),\n+      price: price,","path":"src/reducers/mission.js","position":null,"original_position":5,"commit_id":"dc3b0e6777eb065304568a4e2ec8a859ac5a1a72","original_commit_id":"4a0a9ed979cf581ba9cca7800c0880fc4280444c","user":{"login":"griffobeid","id":12220672,"avatar_url":"https://avatars3.githubusercontent.com/u/12220672?v=4","gravatar_id":"","url":"https://api.github.com/users/griffobeid","html_url":"https://github.com/griffobeid","followers_url":"https://api.github.com/users/griffobeid/followers","following_url":"https://api.github.com/users/griffobeid/following{/other_user}","gists_url":"https://api.github.com/users/griffobeid/gists{/gist_id}","starred_url":"https://api.github.com/users/griffobeid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griffobeid/subscriptions","organizations_url":"https://api.github.com/users/griffobeid/orgs","repos_url":"https://api.github.com/users/griffobeid/repos","events_url":"https://api.github.com/users/griffobeid/events{/privacy}","received_events_url":"https://api.github.com/users/griffobeid/received_events","type":"User","site_admin":false},"body":"Good point, added it back 👍 ","created_at":"2017-12-26T15:56:46Z","updated_at":"2017-12-26T15:56:46Z","html_url":"https://github.com/DAVFoundation/missions/pull/40#discussion_r158717492","pull_request_url":"https://api.github.com/repos/DAVFoundation/missions/pulls/40","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DAVFoundation/missions/pulls/comments/158717492"},"html":{"href":"https://github.com/DAVFoundation/missions/pull/40#discussion_r158717492"},"pull_request":{"href":"https://api.github.com/repos/DAVFoundation/missions/pulls/40"}},"in_reply_to_id":158715081},"pull_request":{"url":"https://api.github.com/repos/DAVFoundation/missions/pulls/40","id":160139560,"html_url":"https://github.com/DAVFoundation/missions/pull/40","diff_url":"https://github.com/DAVFoundation/missions/pull/40.diff","patch_url":"https://github.com/DAVFoundation/missions/pull/40.patch","issue_url":"https://api.github.com/repos/DAVFoundation/missions/issues/40","number":40,"state":"open","locked":false,"title":"Changed the price variable to expect a float. Mission Control issue #86","user":{"login":"griffobeid","id":12220672,"avatar_url":"https://avatars3.githubusercontent.com/u/12220672?v=4","gravatar_id":"","url":"https://api.github.com/users/griffobeid","html_url":"https://github.com/griffobeid","followers_url":"https://api.github.com/users/griffobeid/followers","following_url":"https://api.github.com/users/griffobeid/following{/other_user}","gists_url":"https://api.github.com/users/griffobeid/gists{/gist_id}","starred_url":"https://api.github.com/users/griffobeid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griffobeid/subscriptions","organizations_url":"https://api.github.com/users/griffobeid/orgs","repos_url":"https://api.github.com/users/griffobeid/repos","events_url":"https://api.github.com/users/griffobeid/events{/privacy}","received_events_url":"https://api.github.com/users/griffobeid/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThe price variable in Mission Control was a string and being converted to float in Missions. I changed this so that Missions expects price to be a float already. This goes along with the change I made to mission control in this pull request https://github.com/DAVFoundation/missioncontrol/pull/108#discussion_r158684336.\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\nhttps://github.com/DAVFoundation/missioncontrol/issues/86\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nIt fixes an issue in which the price variable was a string but should be a float. \r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nI tested by opening the app and ordering a drone. The price displays 2 decimal points unless it ends in a 0. For example something with the price 3.60 would display as 3.6. For some reason I couldn't call toFixed(2) where the price is being displayed in the UI. \r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2017-12-26T15:15:32Z","updated_at":"2017-12-26T15:56:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6778bd4215b51f11ea8852cb51f013f763c575cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DAVFoundation/missions/pulls/40/commits","review_comments_url":"https://api.github.com/repos/DAVFoundation/missions/pulls/40/comments","review_comment_url":"https://api.github.com/repos/DAVFoundation/missions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DAVFoundation/missions/issues/40/comments","statuses_url":"https://api.github.com/repos/DAVFoundation/missions/statuses/dc3b0e6777eb065304568a4e2ec8a859ac5a1a72","head":{"label":"griffobeid:master","ref":"master","sha":"dc3b0e6777eb065304568a4e2ec8a859ac5a1a72","user":{"login":"griffobeid","id":12220672,"avatar_url":"https://avatars3.githubusercontent.com/u/12220672?v=4","gravatar_id":"","url":"https://api.github.com/users/griffobeid","html_url":"https://github.com/griffobeid","followers_url":"https://api.github.com/users/griffobeid/followers","following_url":"https://api.github.com/users/griffobeid/following{/other_user}","gists_url":"https://api.github.com/users/griffobeid/gists{/gist_id}","starred_url":"https://api.github.com/users/griffobeid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griffobeid/subscriptions","organizations_url":"https://api.github.com/users/griffobeid/orgs","repos_url":"https://api.github.com/users/griffobeid/repos","events_url":"https://api.github.com/users/griffobeid/events{/privacy}","received_events_url":"https://api.github.com/users/griffobeid/received_events","type":"User","site_admin":false},"repo":{"id":115390641,"name":"missions","full_name":"griffobeid/missions","owner":{"login":"griffobeid","id":12220672,"avatar_url":"https://avatars3.githubusercontent.com/u/12220672?v=4","gravatar_id":"","url":"https://api.github.com/users/griffobeid","html_url":"https://github.com/griffobeid","followers_url":"https://api.github.com/users/griffobeid/followers","following_url":"https://api.github.com/users/griffobeid/following{/other_user}","gists_url":"https://api.github.com/users/griffobeid/gists{/gist_id}","starred_url":"https://api.github.com/users/griffobeid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griffobeid/subscriptions","organizations_url":"https://api.github.com/users/griffobeid/orgs","repos_url":"https://api.github.com/users/griffobeid/repos","events_url":"https://api.github.com/users/griffobeid/events{/privacy}","received_events_url":"https://api.github.com/users/griffobeid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/griffobeid/missions","description":"📱 Our proof of concept app for ordering and tracking drone deliveries","fork":true,"url":"https://api.github.com/repos/griffobeid/missions","forks_url":"https://api.github.com/repos/griffobeid/missions/forks","keys_url":"https://api.github.com/repos/griffobeid/missions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/griffobeid/missions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/griffobeid/missions/teams","hooks_url":"https://api.github.com/repos/griffobeid/missions/hooks","issue_events_url":"https://api.github.com/repos/griffobeid/missions/issues/events{/number}","events_url":"https://api.github.com/repos/griffobeid/missions/events","assignees_url":"https://api.github.com/repos/griffobeid/missions/assignees{/user}","branches_url":"https://api.github.com/repos/griffobeid/missions/branches{/branch}","tags_url":"https://api.github.com/repos/griffobeid/missions/tags","blobs_url":"https://api.github.com/repos/griffobeid/missions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/griffobeid/missions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/griffobeid/missions/git/refs{/sha}","trees_url":"https://api.github.com/repos/griffobeid/missions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/griffobeid/missions/statuses/{sha}","languages_url":"https://api.github.com/repos/griffobeid/missions/languages","stargazers_url":"https://api.github.com/repos/griffobeid/missions/stargazers","contributors_url":"https://api.github.com/repos/griffobeid/missions/contributors","subscribers_url":"https://api.github.com/repos/griffobeid/missions/subscribers","subscription_url":"https://api.github.com/repos/griffobeid/missions/subscription","commits_url":"https://api.github.com/repos/griffobeid/missions/commits{/sha}","git_commits_url":"https://api.github.com/repos/griffobeid/missions/git/commits{/sha}","comments_url":"https://api.github.com/repos/griffobeid/missions/comments{/number}","issue_comment_url":"https://api.github.com/repos/griffobeid/missions/issues/comments{/number}","contents_url":"https://api.github.com/repos/griffobeid/missions/contents/{+path}","compare_url":"https://api.github.com/repos/griffobeid/missions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/griffobeid/missions/merges","archive_url":"https://api.github.com/repos/griffobeid/missions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/griffobeid/missions/downloads","issues_url":"https://api.github.com/repos/griffobeid/missions/issues{/number}","pulls_url":"https://api.github.com/repos/griffobeid/missions/pulls{/number}","milestones_url":"https://api.github.com/repos/griffobeid/missions/milestones{/number}","notifications_url":"https://api.github.com/repos/griffobeid/missions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/griffobeid/missions/labels{/name}","releases_url":"https://api.github.com/repos/griffobeid/missions/releases{/id}","deployments_url":"https://api.github.com/repos/griffobeid/missions/deployments","created_at":"2017-12-26T05:59:40Z","updated_at":"2017-12-26T05:59:42Z","pushed_at":"2017-12-26T15:56:15Z","git_url":"git://github.com/griffobeid/missions.git","ssh_url":"git@github.com:griffobeid/missions.git","clone_url":"https://github.com/griffobeid/missions.git","svn_url":"https://github.com/griffobeid/missions","homepage":"","size":1227,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DAVFoundation:master","ref":"master","sha":"ecb4db1ba801732fe72d11ab0017890e991855a0","user":{"login":"DAVFoundation","id":30435774,"avatar_url":"https://avatars1.githubusercontent.com/u/30435774?v=4","gravatar_id":"","url":"https://api.github.com/users/DAVFoundation","html_url":"https://github.com/DAVFoundation","followers_url":"https://api.github.com/users/DAVFoundation/followers","following_url":"https://api.github.com/users/DAVFoundation/following{/other_user}","gists_url":"https://api.github.com/users/DAVFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/DAVFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DAVFoundation/subscriptions","organizations_url":"https://api.github.com/users/DAVFoundation/orgs","repos_url":"https://api.github.com/users/DAVFoundation/repos","events_url":"https://api.github.com/users/DAVFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/DAVFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":99484613,"name":"missions","full_name":"DAVFoundation/missions","owner":{"login":"DAVFoundation","id":30435774,"avatar_url":"https://avatars1.githubusercontent.com/u/30435774?v=4","gravatar_id":"","url":"https://api.github.com/users/DAVFoundation","html_url":"https://github.com/DAVFoundation","followers_url":"https://api.github.com/users/DAVFoundation/followers","following_url":"https://api.github.com/users/DAVFoundation/following{/other_user}","gists_url":"https://api.github.com/users/DAVFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/DAVFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DAVFoundation/subscriptions","organizations_url":"https://api.github.com/users/DAVFoundation/orgs","repos_url":"https://api.github.com/users/DAVFoundation/repos","events_url":"https://api.github.com/users/DAVFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/DAVFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DAVFoundation/missions","description":"📱 Our proof of concept app for ordering and tracking drone deliveries","fork":false,"url":"https://api.github.com/repos/DAVFoundation/missions","forks_url":"https://api.github.com/repos/DAVFoundation/missions/forks","keys_url":"https://api.github.com/repos/DAVFoundation/missions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DAVFoundation/missions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DAVFoundation/missions/teams","hooks_url":"https://api.github.com/repos/DAVFoundation/missions/hooks","issue_events_url":"https://api.github.com/repos/DAVFoundation/missions/issues/events{/number}","events_url":"https://api.github.com/repos/DAVFoundation/missions/events","assignees_url":"https://api.github.com/repos/DAVFoundation/missions/assignees{/user}","branches_url":"https://api.github.com/repos/DAVFoundation/missions/branches{/branch}","tags_url":"https://api.github.com/repos/DAVFoundation/missions/tags","blobs_url":"https://api.github.com/repos/DAVFoundation/missions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DAVFoundation/missions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DAVFoundation/missions/git/refs{/sha}","trees_url":"https://api.github.com/repos/DAVFoundation/missions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DAVFoundation/missions/statuses/{sha}","languages_url":"https://api.github.com/repos/DAVFoundation/missions/languages","stargazers_url":"https://api.github.com/repos/DAVFoundation/missions/stargazers","contributors_url":"https://api.github.com/repos/DAVFoundation/missions/contributors","subscribers_url":"https://api.github.com/repos/DAVFoundation/missions/subscribers","subscription_url":"https://api.github.com/repos/DAVFoundation/missions/subscription","commits_url":"https://api.github.com/repos/DAVFoundation/missions/commits{/sha}","git_commits_url":"https://api.github.com/repos/DAVFoundation/missions/git/commits{/sha}","comments_url":"https://api.github.com/repos/DAVFoundation/missions/comments{/number}","issue_comment_url":"https://api.github.com/repos/DAVFoundation/missions/issues/comments{/number}","contents_url":"https://api.github.com/repos/DAVFoundation/missions/contents/{+path}","compare_url":"https://api.github.com/repos/DAVFoundation/missions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DAVFoundation/missions/merges","archive_url":"https://api.github.com/repos/DAVFoundation/missions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DAVFoundation/missions/downloads","issues_url":"https://api.github.com/repos/DAVFoundation/missions/issues{/number}","pulls_url":"https://api.github.com/repos/DAVFoundation/missions/pulls{/number}","milestones_url":"https://api.github.com/repos/DAVFoundation/missions/milestones{/number}","notifications_url":"https://api.github.com/repos/DAVFoundation/missions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DAVFoundation/missions/labels{/name}","releases_url":"https://api.github.com/repos/DAVFoundation/missions/releases{/id}","deployments_url":"https://api.github.com/repos/DAVFoundation/missions/deployments","created_at":"2017-08-06T12:22:05Z","updated_at":"2017-12-20T20:47:22Z","pushed_at":"2017-12-26T15:56:16Z","git_url":"git://github.com/DAVFoundation/missions.git","ssh_url":"git@github.com:DAVFoundation/missions.git","clone_url":"https://github.com/DAVFoundation/missions.git","svn_url":"https://github.com/DAVFoundation/missions","homepage":"","size":1225,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":25,"open_issues":10,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DAVFoundation/missions/pulls/40"},"html":{"href":"https://github.com/DAVFoundation/missions/pull/40"},"issue":{"href":"https://api.github.com/repos/DAVFoundation/missions/issues/40"},"comments":{"href":"https://api.github.com/repos/DAVFoundation/missions/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/DAVFoundation/missions/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/DAVFoundation/missions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DAVFoundation/missions/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/DAVFoundation/missions/statuses/dc3b0e6777eb065304568a4e2ec8a859ac5a1a72"}},"author_association":"NONE"}}
{"actor":{"display_login":"griffobeid"}}