{"action":"closed","number":1355,"pull_request":{"url":"https://api.github.com/repos/googledatalab/datalab/pulls/1355","id":119031880,"html_url":"https://github.com/googledatalab/datalab/pull/1355","diff_url":"https://github.com/googledatalab/datalab/pull/1355.diff","patch_url":"https://github.com/googledatalab/datalab/pull/1355.patch","issue_url":"https://api.github.com/repos/googledatalab/datalab/issues/1355","number":1355,"state":"closed","locked":false,"title":"Terminal fixes: use bash, UI improvements","user":{"login":"yebrahim","id":1424661,"avatar_url":"https://avatars1.githubusercontent.com/u/1424661?v=3","gravatar_id":"","url":"https://api.github.com/users/yebrahim","html_url":"https://github.com/yebrahim","followers_url":"https://api.github.com/users/yebrahim/followers","following_url":"https://api.github.com/users/yebrahim/following{/other_user}","gists_url":"https://api.github.com/users/yebrahim/gists{/gist_id}","starred_url":"https://api.github.com/users/yebrahim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebrahim/subscriptions","organizations_url":"https://api.github.com/users/yebrahim/orgs","repos_url":"https://api.github.com/users/yebrahim/repos","events_url":"https://api.github.com/users/yebrahim/events{/privacy}","received_events_url":"https://api.github.com/users/yebrahim/received_events","type":"User","site_admin":false},"body":"This fix adds a bashrc file inside the container to set up the enviornment for the user. Currently it changes directory to `/content`, colors the prompt, and adds a message to tell the user to keep sensitive work in `/content`. The `ENV` env var is set so that file gets loaded by all shells.\r\n\r\nThe rest of the PR is UI fixes to make things look better, and fixed the order of loading the Jupyter dialog module.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1424661/25717519/8c4dcf94-30b7-11e7-827d-fd3bd06ace5d.png)\r\n","created_at":"2017-05-04T18:00:45Z","updated_at":"2017-05-04T22:56:32Z","closed_at":"2017-05-04T22:56:31Z","merged_at":"2017-05-04T22:56:31Z","merge_commit_sha":"4ff5762100f76cff5e49a190020f21e7eee732d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/googledatalab/datalab/pulls/1355/commits","review_comments_url":"https://api.github.com/repos/googledatalab/datalab/pulls/1355/comments","review_comment_url":"https://api.github.com/repos/googledatalab/datalab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googledatalab/datalab/issues/1355/comments","statuses_url":"https://api.github.com/repos/googledatalab/datalab/statuses/3c89b54f27c95428b8fc55a8b29fd468f68d3651","head":{"label":"yebrahim:yebrahim/terminals","ref":"yebrahim/terminals","sha":"3c89b54f27c95428b8fc55a8b29fd468f68d3651","user":{"login":"yebrahim","id":1424661,"avatar_url":"https://avatars1.githubusercontent.com/u/1424661?v=3","gravatar_id":"","url":"https://api.github.com/users/yebrahim","html_url":"https://github.com/yebrahim","followers_url":"https://api.github.com/users/yebrahim/followers","following_url":"https://api.github.com/users/yebrahim/following{/other_user}","gists_url":"https://api.github.com/users/yebrahim/gists{/gist_id}","starred_url":"https://api.github.com/users/yebrahim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebrahim/subscriptions","organizations_url":"https://api.github.com/users/yebrahim/orgs","repos_url":"https://api.github.com/users/yebrahim/repos","events_url":"https://api.github.com/users/yebrahim/events{/privacy}","received_events_url":"https://api.github.com/users/yebrahim/received_events","type":"User","site_admin":false},"repo":{"id":68153961,"name":"datalab","full_name":"yebrahim/datalab","owner":{"login":"yebrahim","id":1424661,"avatar_url":"https://avatars1.githubusercontent.com/u/1424661?v=3","gravatar_id":"","url":"https://api.github.com/users/yebrahim","html_url":"https://github.com/yebrahim","followers_url":"https://api.github.com/users/yebrahim/followers","following_url":"https://api.github.com/users/yebrahim/following{/other_user}","gists_url":"https://api.github.com/users/yebrahim/gists{/gist_id}","starred_url":"https://api.github.com/users/yebrahim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebrahim/subscriptions","organizations_url":"https://api.github.com/users/yebrahim/orgs","repos_url":"https://api.github.com/users/yebrahim/repos","events_url":"https://api.github.com/users/yebrahim/events{/privacy}","received_events_url":"https://api.github.com/users/yebrahim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yebrahim/datalab","description":"Interactive tools and developer experiences for Big Data on Google Cloud Platform.","fork":true,"url":"https://api.github.com/repos/yebrahim/datalab","forks_url":"https://api.github.com/repos/yebrahim/datalab/forks","keys_url":"https://api.github.com/repos/yebrahim/datalab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yebrahim/datalab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yebrahim/datalab/teams","hooks_url":"https://api.github.com/repos/yebrahim/datalab/hooks","issue_events_url":"https://api.github.com/repos/yebrahim/datalab/issues/events{/number}","events_url":"https://api.github.com/repos/yebrahim/datalab/events","assignees_url":"https://api.github.com/repos/yebrahim/datalab/assignees{/user}","branches_url":"https://api.github.com/repos/yebrahim/datalab/branches{/branch}","tags_url":"https://api.github.com/repos/yebrahim/datalab/tags","blobs_url":"https://api.github.com/repos/yebrahim/datalab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yebrahim/datalab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yebrahim/datalab/git/refs{/sha}","trees_url":"https://api.github.com/repos/yebrahim/datalab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yebrahim/datalab/statuses/{sha}","languages_url":"https://api.github.com/repos/yebrahim/datalab/languages","stargazers_url":"https://api.github.com/repos/yebrahim/datalab/stargazers","contributors_url":"https://api.github.com/repos/yebrahim/datalab/contributors","subscribers_url":"https://api.github.com/repos/yebrahim/datalab/subscribers","subscription_url":"https://api.github.com/repos/yebrahim/datalab/subscription","commits_url":"https://api.github.com/repos/yebrahim/datalab/commits{/sha}","git_commits_url":"https://api.github.com/repos/yebrahim/datalab/git/commits{/sha}","comments_url":"https://api.github.com/repos/yebrahim/datalab/comments{/number}","issue_comment_url":"https://api.github.com/repos/yebrahim/datalab/issues/comments{/number}","contents_url":"https://api.github.com/repos/yebrahim/datalab/contents/{+path}","compare_url":"https://api.github.com/repos/yebrahim/datalab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yebrahim/datalab/merges","archive_url":"https://api.github.com/repos/yebrahim/datalab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yebrahim/datalab/downloads","issues_url":"https://api.github.com/repos/yebrahim/datalab/issues{/number}","pulls_url":"https://api.github.com/repos/yebrahim/datalab/pulls{/number}","milestones_url":"https://api.github.com/repos/yebrahim/datalab/milestones{/number}","notifications_url":"https://api.github.com/repos/yebrahim/datalab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yebrahim/datalab/labels{/name}","releases_url":"https://api.github.com/repos/yebrahim/datalab/releases{/id}","deployments_url":"https://api.github.com/repos/yebrahim/datalab/deployments","created_at":"2016-09-13T22:55:10Z","updated_at":"2017-01-13T23:36:45Z","pushed_at":"2017-05-04T22:33:59Z","git_url":"git://github.com/yebrahim/datalab.git","ssh_url":"git@github.com:yebrahim/datalab.git","clone_url":"https://github.com/yebrahim/datalab.git","svn_url":"https://github.com/yebrahim/datalab","homepage":"","size":184929,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googledatalab:master","ref":"master","sha":"18cbcc5a41bdf30fe3835701874835122a7b99f1","user":{"login":"googledatalab","id":18582876,"avatar_url":"https://avatars3.githubusercontent.com/u/18582876?v=3","gravatar_id":"","url":"https://api.github.com/users/googledatalab","html_url":"https://github.com/googledatalab","followers_url":"https://api.github.com/users/googledatalab/followers","following_url":"https://api.github.com/users/googledatalab/following{/other_user}","gists_url":"https://api.github.com/users/googledatalab/gists{/gist_id}","starred_url":"https://api.github.com/users/googledatalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googledatalab/subscriptions","organizations_url":"https://api.github.com/users/googledatalab/orgs","repos_url":"https://api.github.com/users/googledatalab/repos","events_url":"https://api.github.com/users/googledatalab/events{/privacy}","received_events_url":"https://api.github.com/users/googledatalab/received_events","type":"Organization","site_admin":false},"repo":{"id":22693761,"name":"datalab","full_name":"googledatalab/datalab","owner":{"login":"googledatalab","id":18582876,"avatar_url":"https://avatars3.githubusercontent.com/u/18582876?v=3","gravatar_id":"","url":"https://api.github.com/users/googledatalab","html_url":"https://github.com/googledatalab","followers_url":"https://api.github.com/users/googledatalab/followers","following_url":"https://api.github.com/users/googledatalab/following{/other_user}","gists_url":"https://api.github.com/users/googledatalab/gists{/gist_id}","starred_url":"https://api.github.com/users/googledatalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googledatalab/subscriptions","organizations_url":"https://api.github.com/users/googledatalab/orgs","repos_url":"https://api.github.com/users/googledatalab/repos","events_url":"https://api.github.com/users/googledatalab/events{/privacy}","received_events_url":"https://api.github.com/users/googledatalab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googledatalab/datalab","description":"Interactive tools and developer experiences for Big Data on Google Cloud Platform.","fork":false,"url":"https://api.github.com/repos/googledatalab/datalab","forks_url":"https://api.github.com/repos/googledatalab/datalab/forks","keys_url":"https://api.github.com/repos/googledatalab/datalab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googledatalab/datalab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googledatalab/datalab/teams","hooks_url":"https://api.github.com/repos/googledatalab/datalab/hooks","issue_events_url":"https://api.github.com/repos/googledatalab/datalab/issues/events{/number}","events_url":"https://api.github.com/repos/googledatalab/datalab/events","assignees_url":"https://api.github.com/repos/googledatalab/datalab/assignees{/user}","branches_url":"https://api.github.com/repos/googledatalab/datalab/branches{/branch}","tags_url":"https://api.github.com/repos/googledatalab/datalab/tags","blobs_url":"https://api.github.com/repos/googledatalab/datalab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googledatalab/datalab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googledatalab/datalab/git/refs{/sha}","trees_url":"https://api.github.com/repos/googledatalab/datalab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googledatalab/datalab/statuses/{sha}","languages_url":"https://api.github.com/repos/googledatalab/datalab/languages","stargazers_url":"https://api.github.com/repos/googledatalab/datalab/stargazers","contributors_url":"https://api.github.com/repos/googledatalab/datalab/contributors","subscribers_url":"https://api.github.com/repos/googledatalab/datalab/subscribers","subscription_url":"https://api.github.com/repos/googledatalab/datalab/subscription","commits_url":"https://api.github.com/repos/googledatalab/datalab/commits{/sha}","git_commits_url":"https://api.github.com/repos/googledatalab/datalab/git/commits{/sha}","comments_url":"https://api.github.com/repos/googledatalab/datalab/comments{/number}","issue_comment_url":"https://api.github.com/repos/googledatalab/datalab/issues/comments{/number}","contents_url":"https://api.github.com/repos/googledatalab/datalab/contents/{+path}","compare_url":"https://api.github.com/repos/googledatalab/datalab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googledatalab/datalab/merges","archive_url":"https://api.github.com/repos/googledatalab/datalab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googledatalab/datalab/downloads","issues_url":"https://api.github.com/repos/googledatalab/datalab/issues{/number}","pulls_url":"https://api.github.com/repos/googledatalab/datalab/pulls{/number}","milestones_url":"https://api.github.com/repos/googledatalab/datalab/milestones{/number}","notifications_url":"https://api.github.com/repos/googledatalab/datalab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googledatalab/datalab/labels{/name}","releases_url":"https://api.github.com/repos/googledatalab/datalab/releases{/id}","deployments_url":"https://api.github.com/repos/googledatalab/datalab/deployments","created_at":"2014-08-06T18:37:34Z","updated_at":"2017-05-04T22:03:59Z","pushed_at":"2017-05-04T22:56:31Z","git_url":"git://github.com/googledatalab/datalab.git","ssh_url":"git@github.com:googledatalab/datalab.git","clone_url":"https://github.com/googledatalab/datalab.git","svn_url":"https://github.com/googledatalab/datalab","homepage":"","size":184489,"stargazers_count":465,"watchers_count":465,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"open_issues_count":123,"forks":109,"open_issues":123,"watchers":465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googledatalab/datalab/pulls/1355"},"html":{"href":"https://github.com/googledatalab/datalab/pull/1355"},"issue":{"href":"https://api.github.com/repos/googledatalab/datalab/issues/1355"},"comments":{"href":"https://api.github.com/repos/googledatalab/datalab/issues/1355/comments"},"review_comments":{"href":"https://api.github.com/repos/googledatalab/datalab/pulls/1355/comments"},"review_comment":{"href":"https://api.github.com/repos/googledatalab/datalab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googledatalab/datalab/pulls/1355/commits"},"statuses":{"href":"https://api.github.com/repos/googledatalab/datalab/statuses/3c89b54f27c95428b8fc55a8b29fd468f68d3651"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"yebrahim","id":1424661,"avatar_url":"https://avatars1.githubusercontent.com/u/1424661?v=3","gravatar_id":"","url":"https://api.github.com/users/yebrahim","html_url":"https://github.com/yebrahim","followers_url":"https://api.github.com/users/yebrahim/followers","following_url":"https://api.github.com/users/yebrahim/following{/other_user}","gists_url":"https://api.github.com/users/yebrahim/gists{/gist_id}","starred_url":"https://api.github.com/users/yebrahim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebrahim/subscriptions","organizations_url":"https://api.github.com/users/yebrahim/orgs","repos_url":"https://api.github.com/users/yebrahim/repos","events_url":"https://api.github.com/users/yebrahim/events{/privacy}","received_events_url":"https://api.github.com/users/yebrahim/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"maintainer_can_modify":false,"commits":3,"additions":32,"deletions":17,"changed_files":6}}
{"actor":{"display_login":"yebrahim"}}