{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/router/issues/433","repository_url":"https://api.github.com/repos/aurelia/router","labels_url":"https://api.github.com/repos/aurelia/router/issues/433/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/router/issues/433/comments","events_url":"https://api.github.com/repos/aurelia/router/issues/433/events","html_url":"https://github.com/aurelia/router/issues/433","id":189693494,"number":433,"title":"If the router has multiple routes using the same route and different hrefs then rowActive does not work.","user":{"login":"glennpierce","id":691783,"avatar_url":"https://avatars2.githubusercontent.com/u/691783?v=4","gravatar_id":"","url":"https://api.github.com/users/glennpierce","html_url":"https://github.com/glennpierce","followers_url":"https://api.github.com/users/glennpierce/followers","following_url":"https://api.github.com/users/glennpierce/following{/other_user}","gists_url":"https://api.github.com/users/glennpierce/gists{/gist_id}","starred_url":"https://api.github.com/users/glennpierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennpierce/subscriptions","organizations_url":"https://api.github.com/users/glennpierce/orgs","repos_url":"https://api.github.com/users/glennpierce/repos","events_url":"https://api.github.com/users/glennpierce/events{/privacy}","received_events_url":"https://api.github.com/users/glennpierce/received_events","type":"User","site_admin":false},"labels":[{"id":155921236,"url":"https://api.github.com/repos/aurelia/router/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-16T12:46:46Z","updated_at":"2017-10-24T18:17:28Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nBUGS: Please use this template.\r\n\r\nSUPPORT REQUESTS/QUESTIONS: If you have a support request or question please\r\nsubmit them to StackOverflow using the tags aurelia and aurelia-framework\r\nhttp://stackoverflow.com/questions/tagged/aurelia\r\nor the Aurelia Gitter https://gitter.im/aurelia/discuss\r\n\r\nBlue Spire offers paid support agreements. Further information regarding paid support\r\nmay be obtained by emailing support@bluespire.com\r\n\r\nFuture support requests submitted here will be closed.\r\n\r\nThe HTML comments below are for your reference, and are not displayed\r\nwhen your issue is submitted, feel free to leave them.\r\n\r\nChoose one of the two headings, delete the other.\r\n-->\r\n**I'm submitting a bug report**\r\n\r\n\r\n* **Library Version:**\r\n1.0.2\r\n\r\n\r\n**Please tell us about your environment:**\r\n* **Operating System:**\r\nLinux Fedora23\r\n\r\n* **Node Version:**\r\n6.2.2\r\n<!--\r\nMinimum supported Node version is latest Node 4.x LTS\r\nrun `node -v`\r\n-->\r\n\r\n* **NPM Version:**\r\n3.9.5\r\n<!--\r\nMinimum supported NPM version is 3.x\r\nrun `npm -v`\r\n-->\r\n\r\n* **JSPM OR Webpack AND Version**\r\nJSPM 0.16.32 | webpack 2.1.0-beta.17\r\n<!--\r\nIf using JSPM\r\nrun `jspm -v`\r\nIf using Webpack\r\nrun `webpack --help | grep webpack`\r\n-->\r\n2.1.0-beta.22\r\n\r\n* **Browser:**\r\nall | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView\r\nChrome 52\r\n\r\n* **Language:**\r\nall | TypeScript X.X | ESNext\r\ntypescript 2.0.0\r\n\r\n**Current behavior:**\r\n\r\nI have routes defined like\r\n\r\n{ route: \"shimmy_section/:id\", href:'shimmy_section/yourcommunity', name: 'yourcommunity', moduleId: \"./shimmy_section\", nav:true, title: 'Your Community'},\r\n      { route: \"shimmy_section/:id\", href:'shimmy_section/yourtravel', name: 'yourtravel', moduleId: \"./shimmy_section\", nav:true, title: 'Your Travel'},\r\n      { route: \"shimmy_section/:id\", href:'shimmy_section/yourenergyandwater', name: 'yourenergyandwater', moduleId: \"./shimmy_section\", nav:true, title: 'Energy & Water'},\r\n      { route: \"shimmy_section/:id\", href:'shimmy_section/yourneighbourhood', name: 'yourneighbourhood', moduleId: \"./shimmy_section\", nav:true, title: 'Your Neighbourhood'},\r\n\r\nIe they are handled by the same module hence I used href.\r\nHowever, row.isActive does not work with this setup. The last item is always active\r\n\r\n**Expected/desired behavior:**\r\n<!--\r\nIf the current behavior is a bug, please provide the steps to reproduce and, if possible, a minimal demo of the\r\nproblem along with a runnable gist, if possible.\r\nTo create a runnable gist, go to https://gist.run/?id=7542e061bc940cde506b&sha=6821c521a6c7bae6f59a36fb8628ecd1032b2d10\r\nThen click \"Fork to Public Gist\".\r\nCreate your gist, then finally click \"Update Gist.\" Include a link to the gist.run below.\r\n-->\r\n\r\nThe following example shows the issue\r\n\r\nhttps://github.com/glennpierce/test\r\n\r\n\r\n* **What is the expected behavior?**\r\n\r\nrowActive should work with this setup.\r\n\r\n* **What is the motivation / use case for changing the behavior?**\r\nI wan't to show the active select in the nav bar."},"comment":{"url":"https://api.github.com/repos/aurelia/router/issues/comments/339083496","html_url":"https://github.com/aurelia/router/issues/433#issuecomment-339083496","issue_url":"https://api.github.com/repos/aurelia/router/issues/433","id":339083496,"user":{"login":"gheoan","id":9906612,"avatar_url":"https://avatars0.githubusercontent.com/u/9906612?v=4","gravatar_id":"","url":"https://api.github.com/users/gheoan","html_url":"https://github.com/gheoan","followers_url":"https://api.github.com/users/gheoan/followers","following_url":"https://api.github.com/users/gheoan/following{/other_user}","gists_url":"https://api.github.com/users/gheoan/gists{/gist_id}","starred_url":"https://api.github.com/users/gheoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gheoan/subscriptions","organizations_url":"https://api.github.com/users/gheoan/orgs","repos_url":"https://api.github.com/users/gheoan/repos","events_url":"https://api.github.com/users/gheoan/events{/privacy}","received_events_url":"https://api.github.com/users/gheoan/received_events","type":"User","site_admin":false},"created_at":"2017-10-24T18:17:28Z","updated_at":"2017-10-24T18:17:28Z","author_association":"CONTRIBUTOR","body":"@dweggemans Feel free to contribute if you need this. You can use my fork of the route-recognizer library which contains the PR to add this feature (https://github.com/aurelia/route-recognizer/pull/30) and provide feedback. Install it from the `fork` branch of `https://github.com/gheoan/route-recognizer` (if you are using npm execute `npm install --save github:gheoan/route-recognizer#fork`). Note that the `href` property needs to have a leading `/` for my PR to work."}}
{"actor":{"display_login":"gheoan"}}