{"action":"closed","number":513,"pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/513","id":155506406,"html_url":"https://github.com/bitshares/bitshares-core/pull/513","diff_url":"https://github.com/bitshares/bitshares-core/pull/513.diff","patch_url":"https://github.com/bitshares/bitshares-core/pull/513.patch","issue_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/513","number":513,"state":"closed","locked":false,"title":"Precalculate market ticker data","user":{"login":"abitmore","id":9946777,"avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"body":"PR for #509.\r\n\r\nBenchmark:\r\n* before change\r\n```\r\n$ time for n in {1..1000};do curl -d '{\"id\":1,\"method\":\"call\",\"params\":[\"database\",\"get_24_volume\",[\"1.3.0\",\"1.3.113\"]]}' http://127.0.0.1:38380/ws >/dev/null 2>&1;done;echo\r\n\r\nreal    0m9.517s\r\nuser    0m3.020s\r\nsys     0m1.408s\r\n```\r\n* after change:\r\n```\r\n$ time for n in {1..1000};do curl -d '{\"id\":1,\"method\":\"call\",\"params\":[\"database\",\"get_24_volume\",[\"1.3.0\",\"1.3.113\"]]}' http://127.0.0.1:38480/ws >/dev/null 2>&1;done;echo\r\n\r\nreal    0m5.185s\r\nuser    0m2.852s\r\nsys     0m1.404s\r\n```\r\n\r\nAPI query speed slightly increased.\r\n\r\nBy the way, it seems the overhead is quite high, even an empty query takes around 5 seconds to complete (1000 times). I'm not sure why.\r\n```\r\n$ time for n in {1..1000}; do curl -d '{}' http://127.0.0.1:38380/ws >/dev/null 2>&1;done\r\nreal    0m4.777s\r\nuser    0m2.968s\r\nsys     0m1.300s\r\n```","created_at":"2017-11-30T02:51:05Z","updated_at":"2017-12-11T10:33:52Z","closed_at":"2017-12-11T10:33:52Z","merged_at":"2017-12-11T10:33:52Z","merge_commit_sha":"ee06ec19935a34cb52789245b8d29918f8fbae83","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/bitshares/bitshares-core/milestones/7","html_url":"https://github.com/bitshares/bitshares-core/milestone/7","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/milestones/7/labels","id":2938775,"number":7,"title":"201712 - Non-Consensus-Changing Release","description":"","creator":{"login":"abitmore","id":9946777,"avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":30,"state":"open","created_at":"2017-11-27T09:27:05Z","updated_at":"2017-12-11T10:33:52Z","due_on":"2017-12-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/513/commits","review_comments_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/513/comments","review_comment_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/513/comments","statuses_url":"https://api.github.com/repos/bitshares/bitshares-core/statuses/43a8d04b94fcd4311a6949b65eab92313da4fa3a","head":{"label":"abitmore:509-prepared-ticker","ref":"509-prepared-ticker","sha":"43a8d04b94fcd4311a6949b65eab92313da4fa3a","user":{"login":"abitmore","id":9946777,"avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"repo":{"id":44431463,"name":"bitshares-core","full_name":"abitmore/bitshares-core","owner":{"login":"abitmore","id":9946777,"avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abitmore/bitshares-core","description":null,"fork":true,"url":"https://api.github.com/repos/abitmore/bitshares-core","forks_url":"https://api.github.com/repos/abitmore/bitshares-core/forks","keys_url":"https://api.github.com/repos/abitmore/bitshares-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abitmore/bitshares-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abitmore/bitshares-core/teams","hooks_url":"https://api.github.com/repos/abitmore/bitshares-core/hooks","issue_events_url":"https://api.github.com/repos/abitmore/bitshares-core/issues/events{/number}","events_url":"https://api.github.com/repos/abitmore/bitshares-core/events","assignees_url":"https://api.github.com/repos/abitmore/bitshares-core/assignees{/user}","branches_url":"https://api.github.com/repos/abitmore/bitshares-core/branches{/branch}","tags_url":"https://api.github.com/repos/abitmore/bitshares-core/tags","blobs_url":"https://api.github.com/repos/abitmore/bitshares-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abitmore/bitshares-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abitmore/bitshares-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/abitmore/bitshares-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abitmore/bitshares-core/statuses/{sha}","languages_url":"https://api.github.com/repos/abitmore/bitshares-core/languages","stargazers_url":"https://api.github.com/repos/abitmore/bitshares-core/stargazers","contributors_url":"https://api.github.com/repos/abitmore/bitshares-core/contributors","subscribers_url":"https://api.github.com/repos/abitmore/bitshares-core/subscribers","subscription_url":"https://api.github.com/repos/abitmore/bitshares-core/subscription","commits_url":"https://api.github.com/repos/abitmore/bitshares-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/abitmore/bitshares-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/abitmore/bitshares-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/abitmore/bitshares-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/abitmore/bitshares-core/contents/{+path}","compare_url":"https://api.github.com/repos/abitmore/bitshares-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abitmore/bitshares-core/merges","archive_url":"https://api.github.com/repos/abitmore/bitshares-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abitmore/bitshares-core/downloads","issues_url":"https://api.github.com/repos/abitmore/bitshares-core/issues{/number}","pulls_url":"https://api.github.com/repos/abitmore/bitshares-core/pulls{/number}","milestones_url":"https://api.github.com/repos/abitmore/bitshares-core/milestones{/number}","notifications_url":"https://api.github.com/repos/abitmore/bitshares-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abitmore/bitshares-core/labels{/name}","releases_url":"https://api.github.com/repos/abitmore/bitshares-core/releases{/id}","deployments_url":"https://api.github.com/repos/abitmore/bitshares-core/deployments","created_at":"2015-10-17T09:37:32Z","updated_at":"2017-09-28T08:14:51Z","pushed_at":"2017-11-30T02:19:57Z","git_url":"git://github.com/abitmore/bitshares-core.git","ssh_url":"git@github.com:abitmore/bitshares-core.git","clone_url":"https://github.com/abitmore/bitshares-core.git","svn_url":"https://github.com/abitmore/bitshares-core","homepage":"","size":19512,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"bitshares2-bitshares"}},"base":{"label":"bitshares:develop","ref":"develop","sha":"ef374cdadf82bc7678555a48d9f61407e770f685","user":{"login":"bitshares","id":6914094,"avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":44123252,"name":"bitshares-core","full_name":"bitshares/bitshares-core","owner":{"login":"bitshares","id":6914094,"avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitshares/bitshares-core","description":"Your share in the Decentralized Exchange","fork":true,"url":"https://api.github.com/repos/bitshares/bitshares-core","forks_url":"https://api.github.com/repos/bitshares/bitshares-core/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-core/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-core/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-core/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-core/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-core/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-core/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-core/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-core/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-core/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-core/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-core/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-core/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-core/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-core/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-core/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-core/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-core/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-core/deployments","created_at":"2015-10-12T17:36:04Z","updated_at":"2017-12-11T09:53:44Z","pushed_at":"2017-12-11T10:33:52Z","git_url":"git://github.com/bitshares/bitshares-core.git","ssh_url":"git@github.com:bitshares/bitshares-core.git","clone_url":"https://github.com/bitshares/bitshares-core.git","svn_url":"https://github.com/bitshares/bitshares-core","homepage":"https://bitshares.org/","size":19117,"stargazers_count":460,"watchers_count":460,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":180,"open_issues":106,"watchers":460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/513"},"html":{"href":"https://github.com/bitshares/bitshares-core/pull/513"},"issue":{"href":"https://api.github.com/repos/bitshares/bitshares-core/issues/513"},"comments":{"href":"https://api.github.com/repos/bitshares/bitshares-core/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitshares/bitshares-core/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/bitshares/bitshares-core/statuses/43a8d04b94fcd4311a6949b65eab92313da4fa3a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"abitmore","id":9946777,"avatar_url":"https://avatars1.githubusercontent.com/u/9946777?v=4","gravatar_id":"","url":"https://api.github.com/users/abitmore","html_url":"https://github.com/abitmore","followers_url":"https://api.github.com/users/abitmore/followers","following_url":"https://api.github.com/users/abitmore/following{/other_user}","gists_url":"https://api.github.com/users/abitmore/gists{/gist_id}","starred_url":"https://api.github.com/users/abitmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abitmore/subscriptions","organizations_url":"https://api.github.com/users/abitmore/orgs","repos_url":"https://api.github.com/users/abitmore/repos","events_url":"https://api.github.com/users/abitmore/events{/privacy}","received_events_url":"https://api.github.com/users/abitmore/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":225,"deletions":68,"changed_files":4}}
{"actor":{"display_login":"abitmore"}}