{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/105951099","pull_request_review_id":26852392,"id":105951099,"diff_hunk":"@@ -138,10 +138,10 @@ public AdjustmentRule[] GetAdjustmentRules()\n             {\n                 var rule = _adjustmentRules[i];\n                 var start = rule.DateStart.Kind == DateTimeKind.Utc ?\n-                            new DateTime(TimeZoneInfo.ConvertTime(rule.DateStart, this).Ticks, DateTimeKind.Unspecified) :\n+                            new DateTime(rule.DateStart.Ticks + _baseUtcOffset.Ticks, DateTimeKind.Unspecified) :\n                             rule.DateStart;\n                 var end = rule.DateEnd.Kind == DateTimeKind.Utc ?\n-                            new DateTime(TimeZoneInfo.ConvertTime(rule.DateEnd, this).Ticks - 1, DateTimeKind.Unspecified) :\n+                            new DateTime(rule.DateEnd.Ticks + _baseUtcOffset.Ticks + rule.DaylightDelta.Ticks, DateTimeKind.Unspecified) :","path":"src/mscorlib/src/System/TimeZoneInfo.Unix.cs","position":20,"original_position":20,"commit_id":"5c4ded8e76198ce9dcb88defafaafaaf0d7268a7","original_commit_id":"5c4ded8e76198ce9dcb88defafaafaaf0d7268a7","user":{"login":"tarekgh","id":10833894,"avatar_url":"https://avatars1.githubusercontent.com/u/10833894?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},"body":"yes. rule.DateEnd is UTC time which is mapping to the local time (with the daylight delta adjustment). \r\n\r\nfor instance Pacific Time zone has _baseUtcOffset -08:00 hours and the daylight saving ends at 09:00 AM (which is equivalent to 2:00 AM when we having the daylight saving is on which is one hour delta) \r\n\r\nthen the end time would be 09:00 - 08:00 + 01:00 which will give us 02:00 AM which is exactly the time the daylight saving end.","created_at":"2017-03-14T16:03:28Z","updated_at":"2017-03-14T16:03:28Z","html_url":"https://github.com/dotnet/coreclr/pull/10169#discussion_r105951099","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10169","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/105951099"},"html":{"href":"https://github.com/dotnet/coreclr/pull/10169#discussion_r105951099"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10169"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/10169","id":110652154,"html_url":"https://github.com/dotnet/coreclr/pull/10169","diff_url":"https://github.com/dotnet/coreclr/pull/10169.diff","patch_url":"https://github.com/dotnet/coreclr/pull/10169.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/10169","number":10169,"state":"open","locked":false,"title":"Fix tz rules","user":{"login":"tarekgh","id":10833894,"avatar_url":"https://avatars1.githubusercontent.com/u/10833894?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},"body":"On Linux when the caller ask for the TZ adjustment rules we convert the internal stored rule data from UTC to local time. we used to TZI.Convert which is wrong because calculating the start the daylight start time should always not include the daylight delta because we didn't start the daylight saving yet. and calculating the end of daylight should always include the daylight delta because we were in the daylight saving period.\r\n\r\nThe fix here is manually calculating the start and end of the daylight saving inside the rule\r\n\r\nFixes https://github.com/dotnet/corefx/issues/17028","created_at":"2017-03-14T15:46:25Z","updated_at":"2017-03-14T16:03:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1cfb8bfbf3962ae02d9af25730f97889e557ef4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10169/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10169/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/10169/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/5c4ded8e76198ce9dcb88defafaafaaf0d7268a7","head":{"label":"tarekgh:FixTZRules","ref":"FixTZRules","sha":"5c4ded8e76198ce9dcb88defafaafaaf0d7268a7","user":{"login":"tarekgh","id":10833894,"avatar_url":"https://avatars1.githubusercontent.com/u/10833894?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},"repo":{"id":31682116,"name":"coreclr","full_name":"tarekgh/coreclr","owner":{"login":"tarekgh","id":10833894,"avatar_url":"https://avatars1.githubusercontent.com/u/10833894?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tarekgh/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/tarekgh/coreclr","forks_url":"https://api.github.com/repos/tarekgh/coreclr/forks","keys_url":"https://api.github.com/repos/tarekgh/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarekgh/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarekgh/coreclr/teams","hooks_url":"https://api.github.com/repos/tarekgh/coreclr/hooks","issue_events_url":"https://api.github.com/repos/tarekgh/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/tarekgh/coreclr/events","assignees_url":"https://api.github.com/repos/tarekgh/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/tarekgh/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/tarekgh/coreclr/tags","blobs_url":"https://api.github.com/repos/tarekgh/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarekgh/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarekgh/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarekgh/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarekgh/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/tarekgh/coreclr/languages","stargazers_url":"https://api.github.com/repos/tarekgh/coreclr/stargazers","contributors_url":"https://api.github.com/repos/tarekgh/coreclr/contributors","subscribers_url":"https://api.github.com/repos/tarekgh/coreclr/subscribers","subscription_url":"https://api.github.com/repos/tarekgh/coreclr/subscription","commits_url":"https://api.github.com/repos/tarekgh/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarekgh/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarekgh/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarekgh/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarekgh/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/tarekgh/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarekgh/coreclr/merges","archive_url":"https://api.github.com/repos/tarekgh/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarekgh/coreclr/downloads","issues_url":"https://api.github.com/repos/tarekgh/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/tarekgh/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/tarekgh/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/tarekgh/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarekgh/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/tarekgh/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/tarekgh/coreclr/deployments","created_at":"2015-03-04T21:58:52Z","updated_at":"2016-01-20T22:31:58Z","pushed_at":"2017-03-14T15:45:20Z","git_url":"git://github.com/tarekgh/coreclr.git","ssh_url":"git@github.com:tarekgh/coreclr.git","clone_url":"https://github.com/tarekgh/coreclr.git","svn_url":"https://github.com/tarekgh/coreclr","homepage":"","size":142665,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c52a9f7a3019d408cd03aef9e5fb33263cb047ba","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-03-14T13:32:10Z","pushed_at":"2017-03-14T15:58:06Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":142942,"stargazers_count":7495,"watchers_count":7495,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1866,"mirror_url":null,"open_issues_count":1169,"forks":1866,"open_issues":1169,"watchers":7495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10169"},"html":{"href":"https://github.com/dotnet/coreclr/pull/10169"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/10169"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/10169/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10169/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10169/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/5c4ded8e76198ce9dcb88defafaafaaf0d7268a7"}}}}
{"actor":{"display_login":"tarekgh"}}