{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/17310","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/17310/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/17310/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/17310/events","html_url":"https://github.com/guardian/frontend/pull/17310","id":239769756,"number":17310,"title":"Use reader revenue flag not sensitive","user":{"login":"joelochlann","id":5122968,"avatar_url":"https://avatars0.githubusercontent.com/u/5122968?v=3","gravatar_id":"","url":"https://api.github.com/users/joelochlann","html_url":"https://github.com/joelochlann","followers_url":"https://api.github.com/users/joelochlann/followers","following_url":"https://api.github.com/users/joelochlann/following{/other_user}","gists_url":"https://api.github.com/users/joelochlann/gists{/gist_id}","starred_url":"https://api.github.com/users/joelochlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelochlann/subscriptions","organizations_url":"https://api.github.com/users/joelochlann/orgs","repos_url":"https://api.github.com/users/joelochlann/repos","events_url":"https://api.github.com/users/joelochlann/events{/privacy}","received_events_url":"https://api.github.com/users/joelochlann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-30T12:50:42Z","updated_at":"2017-07-03T11:30:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/17310","html_url":"https://github.com/guardian/frontend/pull/17310","diff_url":"https://github.com/guardian/frontend/pull/17310.diff","patch_url":"https://github.com/guardian/frontend/pull/17310.patch"},"body":"## What does this change?\r\nUse the `shouldHideReaderRevenue` flag to disable the epic, instead of the sensitive flag\r\n\r\nI also refactored a bit:\r\n- `isContributor`, `isRecentContributor` etc are now in `userFeatures` since they're properties of the user\r\n- Some contributions/membership-related stuff has been moved out of `commercial-features.js` as this should just be for ad-related code\r\n- `shouldShowReaderRevenue` in `contributions-utilities.js` should now be the source of the truth for default behaviour\r\n\r\n## What is the value of this and can you measure success?\r\nThe sensitive flag is used for things other than just controlling reader revenue asks, so we sometimes have the epic disabled on articles where we'd actually like it to appear. These things should be separate\r\n\r\n@guardian/contributions \r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/312621922","html_url":"https://github.com/guardian/frontend/pull/17310#issuecomment-312621922","issue_url":"https://api.github.com/repos/guardian/frontend/issues/17310","id":312621922,"user":{"login":"joelochlann","id":5122968,"avatar_url":"https://avatars0.githubusercontent.com/u/5122968?v=3","gravatar_id":"","url":"https://api.github.com/users/joelochlann","html_url":"https://github.com/joelochlann","followers_url":"https://api.github.com/users/joelochlann/followers","following_url":"https://api.github.com/users/joelochlann/following{/other_user}","gists_url":"https://api.github.com/users/joelochlann/gists{/gist_id}","starred_url":"https://api.github.com/users/joelochlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelochlann/subscriptions","organizations_url":"https://api.github.com/users/joelochlann/orgs","repos_url":"https://api.github.com/users/joelochlann/repos","events_url":"https://api.github.com/users/joelochlann/events{/privacy}","received_events_url":"https://api.github.com/users/joelochlann/received_events","type":"User","site_admin":false},"created_at":"2017-07-03T11:30:20Z","updated_at":"2017-07-03T11:30:20Z","body":"Thanks @regiskuckaertz.\r\n\r\nWe're currently blocked on resolving the failing test. It looks like making `contributions-utilities.js` a dependency of `commercial-features.js` is what causes the test to fail - but the ultimate problem is that loading SVGs in ES6 will not work when running a Karma (= ES5) test. In our case it breaks because `contributions-utilities.js` depends on `acquisitions-epic-testimonial-parameters.js` which in turn loads an SVG - apparently we've never had a Karma test which depends on ES6 SVG loading before\r\n\r\n@sndrs is looking for a way to get ES6 SVG imports to work with Karma"}}
{"actor":{"display_login":"joelochlann"}}