{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/147553252","pull_request_review_id":72670480,"id":147553252,"diff_hunk":"@@ -15,6 +15,11 @@ class State(NamedModel):\n     pass\n \n \n+class Province(NamedModel):\n+    bag_id = models.CharField(max_length=16, primary_key=True)\n+    border = models.MultiPolygonField(null=True)","path":"tests/gis_tests/layermap/models.py","position":6,"original_position":6,"commit_id":"72b617cabe944ed5ba9f285fb598fba77941633c","original_commit_id":"14a26f266a49c3f8c3c4cbd27ce963a03ed57ba3","user":{"login":"melvyn-sopacua","id":3591955,"avatar_url":"https://avatars3.githubusercontent.com/u/3591955?v=4","gravatar_id":"","url":"https://api.github.com/users/melvyn-sopacua","html_url":"https://github.com/melvyn-sopacua","followers_url":"https://api.github.com/users/melvyn-sopacua/followers","following_url":"https://api.github.com/users/melvyn-sopacua/following{/other_user}","gists_url":"https://api.github.com/users/melvyn-sopacua/gists{/gist_id}","starred_url":"https://api.github.com/users/melvyn-sopacua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melvyn-sopacua/subscriptions","organizations_url":"https://api.github.com/users/melvyn-sopacua/orgs","repos_url":"https://api.github.com/users/melvyn-sopacua/repos","events_url":"https://api.github.com/users/melvyn-sopacua/events{/privacy}","received_events_url":"https://api.github.com/users/melvyn-sopacua/received_events","type":"User","site_admin":false},"body":"If you're ok with not having a MultiPolygon field without null available (and thus not being able to test on required enforcement), then it's fine with me and I will refactor to use that model.","created_at":"2017-10-28T12:24:54Z","updated_at":"2017-10-28T12:24:54Z","html_url":"https://github.com/django/django/pull/9188#discussion_r147553252","pull_request_url":"https://api.github.com/repos/django/django/pulls/9188","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/147553252"},"html":{"href":"https://github.com/django/django/pull/9188#discussion_r147553252"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/9188"}},"in_reply_to_id":145981890},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/9188","id":144114811,"html_url":"https://github.com/django/django/pull/9188","diff_url":"https://github.com/django/django/pull/9188.diff","patch_url":"https://github.com/django/django/pull/9188.patch","issue_url":"https://api.github.com/repos/django/django/issues/9188","number":9188,"state":"open","locked":false,"title":"Fixed #28659 -- Fixed Layermapping crash with null fields.","user":{"login":"melvyn-sopacua","id":3591955,"avatar_url":"https://avatars3.githubusercontent.com/u/3591955?v=4","gravatar_id":"","url":"https://api.github.com/users/melvyn-sopacua","html_url":"https://github.com/melvyn-sopacua","followers_url":"https://api.github.com/users/melvyn-sopacua/followers","following_url":"https://api.github.com/users/melvyn-sopacua/following{/other_user}","gists_url":"https://api.github.com/users/melvyn-sopacua/gists{/gist_id}","starred_url":"https://api.github.com/users/melvyn-sopacua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melvyn-sopacua/subscriptions","organizations_url":"https://api.github.com/users/melvyn-sopacua/orgs","repos_url":"https://api.github.com/users/melvyn-sopacua/repos","events_url":"https://api.github.com/users/melvyn-sopacua/events{/privacy}","received_events_url":"https://api.github.com/users/melvyn-sopacua/received_events","type":"User","site_admin":false},"body":"- Add test models and shape files to expose the problem\r\n- Fix bug by testing for None and simply adding the new geom","created_at":"2017-10-02T05:55:09Z","updated_at":"2017-10-28T12:24:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0a0533950e000cf7093056f45cde5311e31f445","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/9188/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/9188/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/9188/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/72b617cabe944ed5ba9f285fb598fba77941633c","head":{"label":"melvyn-sopacua:fix-28659-contrib-gis","ref":"fix-28659-contrib-gis","sha":"72b617cabe944ed5ba9f285fb598fba77941633c","user":{"login":"melvyn-sopacua","id":3591955,"avatar_url":"https://avatars3.githubusercontent.com/u/3591955?v=4","gravatar_id":"","url":"https://api.github.com/users/melvyn-sopacua","html_url":"https://github.com/melvyn-sopacua","followers_url":"https://api.github.com/users/melvyn-sopacua/followers","following_url":"https://api.github.com/users/melvyn-sopacua/following{/other_user}","gists_url":"https://api.github.com/users/melvyn-sopacua/gists{/gist_id}","starred_url":"https://api.github.com/users/melvyn-sopacua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melvyn-sopacua/subscriptions","organizations_url":"https://api.github.com/users/melvyn-sopacua/orgs","repos_url":"https://api.github.com/users/melvyn-sopacua/repos","events_url":"https://api.github.com/users/melvyn-sopacua/events{/privacy}","received_events_url":"https://api.github.com/users/melvyn-sopacua/received_events","type":"User","site_admin":false},"repo":{"id":68280578,"name":"django","full_name":"melvyn-sopacua/django","owner":{"login":"melvyn-sopacua","id":3591955,"avatar_url":"https://avatars3.githubusercontent.com/u/3591955?v=4","gravatar_id":"","url":"https://api.github.com/users/melvyn-sopacua","html_url":"https://github.com/melvyn-sopacua","followers_url":"https://api.github.com/users/melvyn-sopacua/followers","following_url":"https://api.github.com/users/melvyn-sopacua/following{/other_user}","gists_url":"https://api.github.com/users/melvyn-sopacua/gists{/gist_id}","starred_url":"https://api.github.com/users/melvyn-sopacua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melvyn-sopacua/subscriptions","organizations_url":"https://api.github.com/users/melvyn-sopacua/orgs","repos_url":"https://api.github.com/users/melvyn-sopacua/repos","events_url":"https://api.github.com/users/melvyn-sopacua/events{/privacy}","received_events_url":"https://api.github.com/users/melvyn-sopacua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melvyn-sopacua/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/melvyn-sopacua/django","forks_url":"https://api.github.com/repos/melvyn-sopacua/django/forks","keys_url":"https://api.github.com/repos/melvyn-sopacua/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melvyn-sopacua/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melvyn-sopacua/django/teams","hooks_url":"https://api.github.com/repos/melvyn-sopacua/django/hooks","issue_events_url":"https://api.github.com/repos/melvyn-sopacua/django/issues/events{/number}","events_url":"https://api.github.com/repos/melvyn-sopacua/django/events","assignees_url":"https://api.github.com/repos/melvyn-sopacua/django/assignees{/user}","branches_url":"https://api.github.com/repos/melvyn-sopacua/django/branches{/branch}","tags_url":"https://api.github.com/repos/melvyn-sopacua/django/tags","blobs_url":"https://api.github.com/repos/melvyn-sopacua/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melvyn-sopacua/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melvyn-sopacua/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/melvyn-sopacua/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melvyn-sopacua/django/statuses/{sha}","languages_url":"https://api.github.com/repos/melvyn-sopacua/django/languages","stargazers_url":"https://api.github.com/repos/melvyn-sopacua/django/stargazers","contributors_url":"https://api.github.com/repos/melvyn-sopacua/django/contributors","subscribers_url":"https://api.github.com/repos/melvyn-sopacua/django/subscribers","subscription_url":"https://api.github.com/repos/melvyn-sopacua/django/subscription","commits_url":"https://api.github.com/repos/melvyn-sopacua/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/melvyn-sopacua/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/melvyn-sopacua/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/melvyn-sopacua/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/melvyn-sopacua/django/contents/{+path}","compare_url":"https://api.github.com/repos/melvyn-sopacua/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melvyn-sopacua/django/merges","archive_url":"https://api.github.com/repos/melvyn-sopacua/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melvyn-sopacua/django/downloads","issues_url":"https://api.github.com/repos/melvyn-sopacua/django/issues{/number}","pulls_url":"https://api.github.com/repos/melvyn-sopacua/django/pulls{/number}","milestones_url":"https://api.github.com/repos/melvyn-sopacua/django/milestones{/number}","notifications_url":"https://api.github.com/repos/melvyn-sopacua/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melvyn-sopacua/django/labels{/name}","releases_url":"https://api.github.com/repos/melvyn-sopacua/django/releases{/id}","deployments_url":"https://api.github.com/repos/melvyn-sopacua/django/deployments","created_at":"2016-09-15T09:10:37Z","updated_at":"2016-09-15T09:10:58Z","pushed_at":"2017-10-28T11:50:20Z","git_url":"git://github.com/melvyn-sopacua/django.git","ssh_url":"git@github.com:melvyn-sopacua/django.git","clone_url":"https://github.com/melvyn-sopacua/django.git","svn_url":"https://github.com/melvyn-sopacua/django","homepage":"https://www.djangoproject.com/","size":168708,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"6c98c5abdfb8572936992b5395aab001aeb245f2","user":{"login":"django","id":27804,"avatar_url":"https://avatars2.githubusercontent.com/u/27804?v=4","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars2.githubusercontent.com/u/27804?v=4","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2017-10-28T10:01:10Z","pushed_at":"2017-10-28T12:01:26Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":169324,"stargazers_count":29212,"watchers_count":29212,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12311,"mirror_url":null,"archived":false,"open_issues_count":193,"forks":12311,"open_issues":193,"watchers":29212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/9188"},"html":{"href":"https://github.com/django/django/pull/9188"},"issue":{"href":"https://api.github.com/repos/django/django/issues/9188"},"comments":{"href":"https://api.github.com/repos/django/django/issues/9188/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/9188/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/9188/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/72b617cabe944ed5ba9f285fb598fba77941633c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"melvyn-sopacua"}}