{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/143326526","pull_request_review_id":67828948,"id":143326526,"diff_hunk":"@@ -0,0 +1,27 @@\n+{ stdenv, fetchgit, cmake, pkgconfig, libdrm, pythonBindings ? null }:","path":"pkgs/development/libraries/kmsxx/default.nix","position":1,"original_position":1,"commit_id":"40ba308f63c2e3b0cdb33f4868f484cf6f4f58b4","original_commit_id":"40ba308f63c2e3b0cdb33f4868f484cf6f4f58b4","user":{"login":"FRidh","id":2129135,"avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false},"body":"I suggest to just pass in `python` and build the bindings regardless. We could (perhaps later) put them in a separate output.","created_at":"2017-10-07T09:00:06Z","updated_at":"2017-10-07T09:03:59Z","html_url":"https://github.com/NixOS/nixpkgs/pull/30167#discussion_r143326526","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/143326526"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/30167#discussion_r143326526"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167","id":145240185,"html_url":"https://github.com/NixOS/nixpkgs/pull/30167","diff_url":"https://github.com/NixOS/nixpkgs/pull/30167.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/30167.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/30167","number":30167,"state":"open","locked":false,"title":"kmsxx and pykms: init at 2017-10-03","user":{"login":"gnidorah","id":12064730,"avatar_url":"https://avatars2.githubusercontent.com/u/12064730?v=4","gravatar_id":"","url":"https://api.github.com/users/gnidorah","html_url":"https://github.com/gnidorah","followers_url":"https://api.github.com/users/gnidorah/followers","following_url":"https://api.github.com/users/gnidorah/following{/other_user}","gists_url":"https://api.github.com/users/gnidorah/gists{/gist_id}","starred_url":"https://api.github.com/users/gnidorah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnidorah/subscriptions","organizations_url":"https://api.github.com/users/gnidorah/orgs","repos_url":"https://api.github.com/users/gnidorah/repos","events_url":"https://api.github.com/users/gnidorah/events{/privacy}","received_events_url":"https://api.github.com/users/gnidorah/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-10-06T20:32:17Z","updated_at":"2017-10-07T09:03:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d481bc12be203cf052f23faad79fce700353f29","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/30167/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/40ba308f63c2e3b0cdb33f4868f484cf6f4f58b4","head":{"label":"gnidorah:kmsxx","ref":"kmsxx","sha":"40ba308f63c2e3b0cdb33f4868f484cf6f4f58b4","user":{"login":"gnidorah","id":12064730,"avatar_url":"https://avatars2.githubusercontent.com/u/12064730?v=4","gravatar_id":"","url":"https://api.github.com/users/gnidorah","html_url":"https://github.com/gnidorah","followers_url":"https://api.github.com/users/gnidorah/followers","following_url":"https://api.github.com/users/gnidorah/following{/other_user}","gists_url":"https://api.github.com/users/gnidorah/gists{/gist_id}","starred_url":"https://api.github.com/users/gnidorah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnidorah/subscriptions","organizations_url":"https://api.github.com/users/gnidorah/orgs","repos_url":"https://api.github.com/users/gnidorah/repos","events_url":"https://api.github.com/users/gnidorah/events{/privacy}","received_events_url":"https://api.github.com/users/gnidorah/received_events","type":"User","site_admin":false},"repo":{"id":69858071,"name":"nixpkgs","full_name":"gnidorah/nixpkgs","owner":{"login":"gnidorah","id":12064730,"avatar_url":"https://avatars2.githubusercontent.com/u/12064730?v=4","gravatar_id":"","url":"https://api.github.com/users/gnidorah","html_url":"https://github.com/gnidorah","followers_url":"https://api.github.com/users/gnidorah/followers","following_url":"https://api.github.com/users/gnidorah/following{/other_user}","gists_url":"https://api.github.com/users/gnidorah/gists{/gist_id}","starred_url":"https://api.github.com/users/gnidorah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnidorah/subscriptions","organizations_url":"https://api.github.com/users/gnidorah/orgs","repos_url":"https://api.github.com/users/gnidorah/repos","events_url":"https://api.github.com/users/gnidorah/events{/privacy}","received_events_url":"https://api.github.com/users/gnidorah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gnidorah/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/gnidorah/nixpkgs","forks_url":"https://api.github.com/repos/gnidorah/nixpkgs/forks","keys_url":"https://api.github.com/repos/gnidorah/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnidorah/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnidorah/nixpkgs/teams","hooks_url":"https://api.github.com/repos/gnidorah/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/gnidorah/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/gnidorah/nixpkgs/events","assignees_url":"https://api.github.com/repos/gnidorah/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/gnidorah/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/gnidorah/nixpkgs/tags","blobs_url":"https://api.github.com/repos/gnidorah/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnidorah/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnidorah/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnidorah/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnidorah/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/gnidorah/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/gnidorah/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/gnidorah/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/gnidorah/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/gnidorah/nixpkgs/subscription","commits_url":"https://api.github.com/repos/gnidorah/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnidorah/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnidorah/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnidorah/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnidorah/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/gnidorah/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnidorah/nixpkgs/merges","archive_url":"https://api.github.com/repos/gnidorah/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnidorah/nixpkgs/downloads","issues_url":"https://api.github.com/repos/gnidorah/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/gnidorah/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/gnidorah/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/gnidorah/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnidorah/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/gnidorah/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/gnidorah/nixpkgs/deployments","created_at":"2016-10-03T09:41:33Z","updated_at":"2016-10-03T09:41:57Z","pushed_at":"2017-10-06T20:17:26Z","git_url":"git://github.com/gnidorah/nixpkgs.git","ssh_url":"git@github.com:gnidorah/nixpkgs.git","clone_url":"https://github.com/gnidorah/nixpkgs.git","svn_url":"https://github.com/gnidorah/nixpkgs","homepage":null,"size":559436,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"6d7d7c5840580f2458ed6180d0b08c74ee946f37","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-10-04T23:07:36Z","pushed_at":"2017-10-07T08:34:05Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":607756,"stargazers_count":1907,"watchers_count":1907,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2265,"mirror_url":null,"open_issues_count":2354,"forks":2265,"open_issues":2354,"watchers":1907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/30167"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/30167"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/30167/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30167/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/40ba308f63c2e3b0cdb33f4868f484cf6f4f58b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FRidh"}}