{"action":"created","issue":{"url":"https://api.github.com/repos/securesocketfunneling/ssf/issues/51","repository_url":"https://api.github.com/repos/securesocketfunneling/ssf","labels_url":"https://api.github.com/repos/securesocketfunneling/ssf/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/securesocketfunneling/ssf/issues/51/comments","events_url":"https://api.github.com/repos/securesocketfunneling/ssf/issues/51/events","html_url":"https://github.com/securesocketfunneling/ssf/pull/51","id":273644558,"number":51,"title":"Address some MacOS build items from #50","user":{"login":"jnardone","id":1351078,"avatar_url":"https://avatars0.githubusercontent.com/u/1351078?v=4","gravatar_id":"","url":"https://api.github.com/users/jnardone","html_url":"https://github.com/jnardone","followers_url":"https://api.github.com/users/jnardone/followers","following_url":"https://api.github.com/users/jnardone/following{/other_user}","gists_url":"https://api.github.com/users/jnardone/gists{/gist_id}","starred_url":"https://api.github.com/users/jnardone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnardone/subscriptions","organizations_url":"https://api.github.com/users/jnardone/orgs","repos_url":"https://api.github.com/users/jnardone/repos","events_url":"https://api.github.com/users/jnardone/events{/privacy}","received_events_url":"https://api.github.com/users/jnardone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-14T02:15:54Z","updated_at":"2017-11-14T16:08:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/securesocketfunneling/ssf/pulls/51","html_url":"https://github.com/securesocketfunneling/ssf/pull/51","diff_url":"https://github.com/securesocketfunneling/ssf/pull/51.diff","patch_url":"https://github.com/securesocketfunneling/ssf/pull/51.patch"},"body":"This covers a number of issues:\r\n1) enables logging sink on MacOS\r\n2) fixes \"const\" error and \"override\" warnings \r\n3) excludes MacOS from \"memcpy\" compat lib\r\n\r\nThere is one warning I'm not sure how to fix, because I'm not sure what (if anything) to do for the states listed:\r\n\r\n```\r\n[ 95%] Building CXX object src/client/CMakeFiles/ssf.dir/ssf.cpp.o\r\n/Users/jnardone/src/t/ssf/src/client/ssf.cpp:112:13: warning: enumeration values 'kInitialized',\r\n      'kServerNotSupported', and 'kRunning' not handled in switch [-Wswitch]\r\n    switch (status) {\r\n            ^\r\n/Users/jnardone/src/t/ssf/src/client/ssf.cpp:112:13: note: add missing switch cases\r\n    switch (status) {\r\n            ^\r\n1 warning generated.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/securesocketfunneling/ssf/issues/comments/344308284","html_url":"https://github.com/securesocketfunneling/ssf/pull/51#issuecomment-344308284","issue_url":"https://api.github.com/repos/securesocketfunneling/ssf/issues/51","id":344308284,"user":{"login":"securesocketfunneling","id":12052641,"avatar_url":"https://avatars0.githubusercontent.com/u/12052641?v=4","gravatar_id":"","url":"https://api.github.com/users/securesocketfunneling","html_url":"https://github.com/securesocketfunneling","followers_url":"https://api.github.com/users/securesocketfunneling/followers","following_url":"https://api.github.com/users/securesocketfunneling/following{/other_user}","gists_url":"https://api.github.com/users/securesocketfunneling/gists{/gist_id}","starred_url":"https://api.github.com/users/securesocketfunneling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/securesocketfunneling/subscriptions","organizations_url":"https://api.github.com/users/securesocketfunneling/orgs","repos_url":"https://api.github.com/users/securesocketfunneling/repos","events_url":"https://api.github.com/users/securesocketfunneling/events{/privacy}","received_events_url":"https://api.github.com/users/securesocketfunneling/received_events","type":"User","site_admin":false},"created_at":"2017-11-14T16:08:54Z","updated_at":"2017-11-14T16:08:54Z","author_association":"OWNER","body":"Thanks for your PR, it is really appreciated!\r\n\r\nI would like to add minor fixes to your proposal. Would you mind applying the [following patch](https://github.com/securesocketfunneling/ssf/files/1471495/patch.txt)?\r\nIt provides fixes for `ssf.cpp` and ssfd compilation warnings. It also improves the memcpy tweak management (mostly related to GCC and GLIBC versions). The latter is not perfect but it should do the trick for now.\r\n \r\nCould you also check that your OSX build is still fine?\r\n\r\nThank you\r\n\r\n\r\n"}}
{"actor":{"display_login":"securesocketfunneling"}}