{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/7378","repository_url":"https://api.github.com/repos/callemall/material-ui","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/7378/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/7378/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/7378/events","html_url":"https://github.com/callemall/material-ui/pull/7378","id":241367294,"number":7378,"title":"[Menu] remove maxHeight - too prescriptive","user":{"login":"rosskevin","id":136564,"avatar_url":"https://avatars2.githubusercontent.com/u/136564?v=3","gravatar_id":"","url":"https://api.github.com/users/rosskevin","html_url":"https://github.com/rosskevin","followers_url":"https://api.github.com/users/rosskevin/followers","following_url":"https://api.github.com/users/rosskevin/following{/other_user}","gists_url":"https://api.github.com/users/rosskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/rosskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosskevin/subscriptions","organizations_url":"https://api.github.com/users/rosskevin/orgs","repos_url":"https://api.github.com/users/rosskevin/repos","events_url":"https://api.github.com/users/rosskevin/events{/privacy}","received_events_url":"https://api.github.com/users/rosskevin/received_events","type":"User","site_admin":false},"labels":[{"id":122764862,"url":"https://api.github.com/repos/callemall/material-ui/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":460200154,"url":"https://api.github.com/repos/callemall/material-ui/labels/component:%20Menu","name":"component: Menu","color":"ffffff","default":false},{"id":416834291,"url":"https://api.github.com/repos/callemall/material-ui/labels/v1-alpha","name":"v1-alpha","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-07T20:08:21Z","updated_at":"2017-07-08T04:06:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/7378","html_url":"https://github.com/callemall/material-ui/pull/7378","diff_url":"https://github.com/callemall/material-ui/pull/7378.diff","patch_url":"https://github.com/callemall/material-ui/pull/7378.patch"},"body":"The current menu `maxHeight` is arbitrarily set to be `250px`, and this is too prescriptive for general use.\r\n\r\n[The spec states](https://material.io/guidelines/components/menus.html#menus-simple-menus):\r\n\r\n> The maximum height of a simple menu should be one or more rows less than the view height. This ensures a tappable area outside of the simple menu with which to dismiss the menu.\r\n\r\nTherefore, it is up to userland to set this limitation unless someone wants to create a smart height listener/implementation.\r\n\r\nAs a note, I left an empty stylesheet as `withStyles` requires one and classes are passed down (and tested).\r\n\r\nThis fixes a situation like this:\r\n<img src=\"https://user-images.githubusercontent.com/136564/27974988-fe2fe656-6325-11e7-8e17-7438835525ab.png\"  width=400 />\r\n\r\n\r\n---\r\n- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/313831934","html_url":"https://github.com/callemall/material-ui/pull/7378#issuecomment-313831934","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/7378","id":313831934,"user":{"login":"rosskevin","id":136564,"avatar_url":"https://avatars2.githubusercontent.com/u/136564?v=3","gravatar_id":"","url":"https://api.github.com/users/rosskevin","html_url":"https://github.com/rosskevin","followers_url":"https://api.github.com/users/rosskevin/followers","following_url":"https://api.github.com/users/rosskevin/following{/other_user}","gists_url":"https://api.github.com/users/rosskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/rosskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosskevin/subscriptions","organizations_url":"https://api.github.com/users/rosskevin/orgs","repos_url":"https://api.github.com/users/rosskevin/repos","events_url":"https://api.github.com/users/rosskevin/events{/privacy}","received_events_url":"https://api.github.com/users/rosskevin/received_events","type":"User","site_admin":false},"created_at":"2017-07-08T04:06:49Z","updated_at":"2017-07-08T04:06:49Z","body":"As I started the requested change, I noticed an inconsistency and started increasing flow types, which I ended up strengthening flow coverage on several interrelated files.  So the purpose is still the same, I just increased flow coverage with the additional changes."}}
{"actor":{"display_login":"rosskevin"}}