{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/151965406","pull_request_review_id":77753184,"id":151965406,"diff_hunk":"@@ -582,13 +600,30 @@ void gnrc_netif_ipv6_addr_remove(gnrc_netif_t *netif,\n                                  const ipv6_addr_t *addr)\n {\n     int idx;\n+    bool remove_sol_nodes = true;\n+    ipv6_addr_t sol_nodes;\n \n     assert((netif != NULL) && (addr != NULL));\n+    ipv6_addr_set_solicited_nodes(&sol_nodes, addr);\n     gnrc_netif_acquire(netif);\n-    idx = _addr_idx(netif, addr);\n-    if (idx >= 0) {\n-        netif->ipv6.addrs_flags[idx] = 0;\n-        ipv6_addr_set_unspecified(&netif->ipv6.addrs[idx]);\n+    for (unsigned i = 0; i < GNRC_NETIF_IPV6_ADDRS_NUMOF; i++) {\n+        if (ipv6_addr_equal(&netif->ipv6.addrs[i], addr)) {\n+            netif->ipv6.addrs_flags[idx] = 0;","path":"sys/net/gnrc/netif/gnrc_netif.c","position":41,"original_position":41,"commit_id":"da6ad359f4c192a5fbe44a4994f7569e0cccefce","original_commit_id":"da6ad359f4c192a5fbe44a4994f7569e0cccefce","user":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"body":"I'm getting an unitialized variable error on `idx` here.\r\n```\r\n/home/hydrazine/dev/RIOT/sys/net/gnrc/netif/gnrc_netif.c:611:42: error: ‘idx’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\r\n             netif->ipv6.addrs_flags[idx] = 0;\r\n```","created_at":"2017-11-20T11:25:00Z","updated_at":"2017-11-20T11:25:00Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/8089#discussion_r151965406","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/151965406"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8089#discussion_r151965406"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089","id":153603092,"html_url":"https://github.com/RIOT-OS/RIOT/pull/8089","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8089.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8089.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8089","number":8089,"state":"open","locked":false,"title":"gnrc_netif: join/leave solicited nodes IPv6 address add/remove","user":{"login":"miri64","id":675644,"avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"Fixes #8085 by actually joining the solicited nodes group on adding a new IPv6 address to an interface. Likewise, the group is left, when no IPv6 address associated to that group is left on the interface.","created_at":"2017-11-20T11:17:02Z","updated_at":"2017-11-20T11:25:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c46b7c7bf34652149d635bb5cf4f084d3fb78008","assignee":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"assignees":[{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8089/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/da6ad359f4c192a5fbe44a4994f7569e0cccefce","head":{"label":"miri64:gnrc_netif/fix/add-sol-nodes","ref":"gnrc_netif/fix/add-sol-nodes","sha":"da6ad359f4c192a5fbe44a4994f7569e0cccefce","user":{"login":"miri64","id":675644,"avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"repo":{"id":7667624,"name":"RIOT","full_name":"miri64/RIOT","owner":{"login":"miri64","id":675644,"avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miri64/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/miri64/RIOT","forks_url":"https://api.github.com/repos/miri64/RIOT/forks","keys_url":"https://api.github.com/repos/miri64/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miri64/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miri64/RIOT/teams","hooks_url":"https://api.github.com/repos/miri64/RIOT/hooks","issue_events_url":"https://api.github.com/repos/miri64/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/miri64/RIOT/events","assignees_url":"https://api.github.com/repos/miri64/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/miri64/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/miri64/RIOT/tags","blobs_url":"https://api.github.com/repos/miri64/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miri64/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miri64/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/miri64/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miri64/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/miri64/RIOT/languages","stargazers_url":"https://api.github.com/repos/miri64/RIOT/stargazers","contributors_url":"https://api.github.com/repos/miri64/RIOT/contributors","subscribers_url":"https://api.github.com/repos/miri64/RIOT/subscribers","subscription_url":"https://api.github.com/repos/miri64/RIOT/subscription","commits_url":"https://api.github.com/repos/miri64/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/miri64/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/miri64/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/miri64/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/miri64/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/miri64/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miri64/RIOT/merges","archive_url":"https://api.github.com/repos/miri64/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miri64/RIOT/downloads","issues_url":"https://api.github.com/repos/miri64/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/miri64/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/miri64/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/miri64/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miri64/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/miri64/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/miri64/RIOT/deployments","created_at":"2013-01-17T14:31:57Z","updated_at":"2015-05-01T13:02:29Z","pushed_at":"2017-11-20T11:15:38Z","git_url":"git://github.com/miri64/RIOT.git","ssh_url":"git@github.com:miri64/RIOT.git","clone_url":"https://github.com/miri64/RIOT.git","svn_url":"https://github.com/miri64/RIOT","homepage":null,"size":45477,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:gnrc_netif2_integration/master","ref":"gnrc_netif2_integration/master","sha":"460d3c44fe30987464949a954866d070887a9bf8","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2017-11-19T18:30:35Z","pushed_at":"2017-11-20T11:17:03Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":45422,"stargazers_count":1493,"watchers_count":1493,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":885,"mirror_url":null,"archived":false,"open_issues_count":678,"forks":885,"open_issues":678,"watchers":1493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8089"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8089"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8089/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8089/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/da6ad359f4c192a5fbe44a4994f7569e0cccefce"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bergzand"}}