{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/127845762","pull_request_review_id":50469442,"id":127845762,"diff_hunk":"@@ -76,6 +83,11 @@ export class StandardActions {\n     actionService.addGlobalMethodHandler('show', this.handleShow.bind(this));\n     actionService.addGlobalMethodHandler(\n         'toggleVisibility', this.handleToggle.bind(this));\n+    actionService.addGlobalMethodHandler(\n+        'scrollTo', this.handleScrollTo.bind(this));\n+    actionService.addGlobalMethodHandler(\n+        'focus', this.handleFocus.bind(this));\n+    actionService.addGlobalMethodHandler('blur', this.handleBlur.bind(this));","path":"src/service/standard-actions-impl.js","position":29,"original_position":29,"commit_id":"b48556a9fda20cb672a77cc2f80998e8dbde7ce4","original_commit_id":"b48556a9fda20cb672a77cc2f80998e8dbde7ce4","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"remove","created_at":"2017-07-17T22:48:41Z","updated_at":"2017-07-17T22:52:06Z","html_url":"https://github.com/ampproject/amphtml/pull/10398#discussion_r127845762","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/10398","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/127845762"},"html":{"href":"https://github.com/ampproject/amphtml/pull/10398#discussion_r127845762"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10398"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/10398","id":130274947,"html_url":"https://github.com/ampproject/amphtml/pull/10398","diff_url":"https://github.com/ampproject/amphtml/pull/10398.diff","patch_url":"https://github.com/ampproject/amphtml/pull/10398.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/10398","number":10398,"state":"open","locked":false,"title":"Implements scrollTo, focus and blur standard actions","user":{"login":"wassgha","id":591655,"avatar_url":"https://avatars3.githubusercontent.com/u/591655?v=4","gravatar_id":"","url":"https://api.github.com/users/wassgha","html_url":"https://github.com/wassgha","followers_url":"https://api.github.com/users/wassgha/followers","following_url":"https://api.github.com/users/wassgha/following{/other_user}","gists_url":"https://api.github.com/users/wassgha/gists{/gist_id}","starred_url":"https://api.github.com/users/wassgha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wassgha/subscriptions","organizations_url":"https://api.github.com/users/wassgha/orgs","repos_url":"https://api.github.com/users/wassgha/repos","events_url":"https://api.github.com/users/wassgha/events{/privacy}","received_events_url":"https://api.github.com/users/wassgha/received_events","type":"User","site_admin":false},"body":"This adds an action to dynamically focus and scroll to elements as detailed in #7626\r\n\r\n### Changes\r\n\r\n- Added position parameter to `animateScrollIntoView` in `viewport-impl` specifying the final position of the element in the viewport after the scroll animation is over\r\n- Implemented `scrollTo` action on all elements with configurable `duration` of animation and `position` inside the viewport\r\n- Implemented `focus` action on all elements\r\n- Implemented `blur` action on all elements\r\n- Added example that implements the changes\r\n- Made changes to standard action spec\r\n- Added unit tests\r\n\r\nCloses #7626","created_at":"2017-07-13T02:34:20Z","updated_at":"2017-07-17T22:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2507b30fcc849b0cce71eb162ab5d22fc97b24a1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/31","html_url":"https://github.com/ampproject/amphtml/milestone/31","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/31/labels","id":2431487,"number":31,"title":"Fixit Week EOQ2","description":"","creator":{"login":"adelinamart","id":24213793,"avatar_url":"https://avatars2.githubusercontent.com/u/24213793?v=4","gravatar_id":"","url":"https://api.github.com/users/adelinamart","html_url":"https://github.com/adelinamart","followers_url":"https://api.github.com/users/adelinamart/followers","following_url":"https://api.github.com/users/adelinamart/following{/other_user}","gists_url":"https://api.github.com/users/adelinamart/gists{/gist_id}","starred_url":"https://api.github.com/users/adelinamart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelinamart/subscriptions","organizations_url":"https://api.github.com/users/adelinamart/orgs","repos_url":"https://api.github.com/users/adelinamart/repos","events_url":"https://api.github.com/users/adelinamart/events{/privacy}","received_events_url":"https://api.github.com/users/adelinamart/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":29,"state":"open","created_at":"2017-04-03T22:12:16Z","updated_at":"2017-07-17T22:01:40Z","due_on":"2017-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/10398/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/10398/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/10398/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/b48556a9fda20cb672a77cc2f80998e8dbde7ce4","head":{"label":"wassgha:git","ref":"git","sha":"b48556a9fda20cb672a77cc2f80998e8dbde7ce4","user":{"login":"wassgha","id":591655,"avatar_url":"https://avatars3.githubusercontent.com/u/591655?v=4","gravatar_id":"","url":"https://api.github.com/users/wassgha","html_url":"https://github.com/wassgha","followers_url":"https://api.github.com/users/wassgha/followers","following_url":"https://api.github.com/users/wassgha/following{/other_user}","gists_url":"https://api.github.com/users/wassgha/gists{/gist_id}","starred_url":"https://api.github.com/users/wassgha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wassgha/subscriptions","organizations_url":"https://api.github.com/users/wassgha/orgs","repos_url":"https://api.github.com/users/wassgha/repos","events_url":"https://api.github.com/users/wassgha/events{/privacy}","received_events_url":"https://api.github.com/users/wassgha/received_events","type":"User","site_admin":false},"repo":{"id":92342164,"name":"amphtml","full_name":"wassgha/amphtml","owner":{"login":"wassgha","id":591655,"avatar_url":"https://avatars3.githubusercontent.com/u/591655?v=4","gravatar_id":"","url":"https://api.github.com/users/wassgha","html_url":"https://github.com/wassgha","followers_url":"https://api.github.com/users/wassgha/followers","following_url":"https://api.github.com/users/wassgha/following{/other_user}","gists_url":"https://api.github.com/users/wassgha/gists{/gist_id}","starred_url":"https://api.github.com/users/wassgha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wassgha/subscriptions","organizations_url":"https://api.github.com/users/wassgha/orgs","repos_url":"https://api.github.com/users/wassgha/repos","events_url":"https://api.github.com/users/wassgha/events{/privacy}","received_events_url":"https://api.github.com/users/wassgha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wassgha/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/wassgha/amphtml","forks_url":"https://api.github.com/repos/wassgha/amphtml/forks","keys_url":"https://api.github.com/repos/wassgha/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wassgha/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wassgha/amphtml/teams","hooks_url":"https://api.github.com/repos/wassgha/amphtml/hooks","issue_events_url":"https://api.github.com/repos/wassgha/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/wassgha/amphtml/events","assignees_url":"https://api.github.com/repos/wassgha/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/wassgha/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/wassgha/amphtml/tags","blobs_url":"https://api.github.com/repos/wassgha/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wassgha/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wassgha/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/wassgha/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wassgha/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/wassgha/amphtml/languages","stargazers_url":"https://api.github.com/repos/wassgha/amphtml/stargazers","contributors_url":"https://api.github.com/repos/wassgha/amphtml/contributors","subscribers_url":"https://api.github.com/repos/wassgha/amphtml/subscribers","subscription_url":"https://api.github.com/repos/wassgha/amphtml/subscription","commits_url":"https://api.github.com/repos/wassgha/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/wassgha/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/wassgha/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/wassgha/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/wassgha/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/wassgha/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wassgha/amphtml/merges","archive_url":"https://api.github.com/repos/wassgha/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wassgha/amphtml/downloads","issues_url":"https://api.github.com/repos/wassgha/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/wassgha/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/wassgha/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/wassgha/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wassgha/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/wassgha/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/wassgha/amphtml/deployments","created_at":"2017-05-24T22:32:53Z","updated_at":"2017-05-24T22:33:02Z","pushed_at":"2017-07-17T22:04:33Z","git_url":"git://github.com/wassgha/amphtml.git","ssh_url":"git@github.com:wassgha/amphtml.git","clone_url":"https://github.com/wassgha/amphtml.git","svn_url":"https://github.com/wassgha/amphtml","homepage":"https://www.ampproject.org","size":261666,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"3b8c24b4dcd4aa6f8f026e9634d53d0ed8b50dd3","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-07-17T17:35:22Z","pushed_at":"2017-07-17T22:44:24Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":256737,"stargazers_count":10293,"watchers_count":10293,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1841,"mirror_url":null,"open_issues_count":881,"forks":1841,"open_issues":881,"watchers":10293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10398"},"html":{"href":"https://github.com/ampproject/amphtml/pull/10398"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/10398"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/10398/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10398/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10398/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/b48556a9fda20cb672a77cc2f80998e8dbde7ce4"}}}}
{"actor":{"display_login":"aghassemi"}}