{"action":"created","issue":{"url":"https://api.github.com/repos/jeerbl/webfonts-loader/issues/37","repository_url":"https://api.github.com/repos/jeerbl/webfonts-loader","labels_url":"https://api.github.com/repos/jeerbl/webfonts-loader/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/jeerbl/webfonts-loader/issues/37/comments","events_url":"https://api.github.com/repos/jeerbl/webfonts-loader/issues/37/events","html_url":"https://github.com/jeerbl/webfonts-loader/pull/37","id":260934375,"number":37,"title":"Fix handling of dest and publicPath options","user":{"login":"IlyaSemenov","id":128121,"avatar_url":"https://avatars1.githubusercontent.com/u/128121?v=4","gravatar_id":"","url":"https://api.github.com/users/IlyaSemenov","html_url":"https://github.com/IlyaSemenov","followers_url":"https://api.github.com/users/IlyaSemenov/followers","following_url":"https://api.github.com/users/IlyaSemenov/following{/other_user}","gists_url":"https://api.github.com/users/IlyaSemenov/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaSemenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaSemenov/subscriptions","organizations_url":"https://api.github.com/users/IlyaSemenov/orgs","repos_url":"https://api.github.com/users/IlyaSemenov/repos","events_url":"https://api.github.com/users/IlyaSemenov/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaSemenov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-27T11:06:38Z","updated_at":"2017-09-27T13:03:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jeerbl/webfonts-loader/pulls/37","html_url":"https://github.com/jeerbl/webfonts-loader/pull/37","diff_url":"https://github.com/jeerbl/webfonts-loader/pull/37.diff","patch_url":"https://github.com/jeerbl/webfonts-loader/pull/37.patch"},"body":"This PR fixes handling of `dest` and `publicPath` opts (#36):\r\n\r\n* `dest` is no more used directly. It's simply passed to webfonts generator if provided.\r\n* `publicPath` is used to construct font URLs, and supports fully-qualified URL prefix like `http://cdn.project.net/`\r\n* all other loader options are used as defaults for font configs\r\n\r\nLoading and merging of options is streamlined, and the variables are renamed uniformly:\r\n\r\n* `params` is now `options`, as in \"Webpack loader options\" (I also removed duplicate call to `loaderUtils.getOptions()`)\r\n* `opts` is now `webpackOptions`, as it refers to global webpack config options (in webpack 1.x, or when `LoaderOptionsPlugin` is used)\r\n* `config` is now `fontConfig`, as in \"font config\"\r\n* `generatorConfiguration` is now `generatorOptions`, as in `webfontsGenerator(options, ...)`\r\n* `pub` is now `publicPath`, same as in Webpack"},"comment":{"url":"https://api.github.com/repos/jeerbl/webfonts-loader/issues/comments/332513470","html_url":"https://github.com/jeerbl/webfonts-loader/pull/37#issuecomment-332513470","issue_url":"https://api.github.com/repos/jeerbl/webfonts-loader/issues/37","id":332513470,"user":{"login":"jeerbl","id":3242928,"avatar_url":"https://avatars3.githubusercontent.com/u/3242928?v=4","gravatar_id":"","url":"https://api.github.com/users/jeerbl","html_url":"https://github.com/jeerbl","followers_url":"https://api.github.com/users/jeerbl/followers","following_url":"https://api.github.com/users/jeerbl/following{/other_user}","gists_url":"https://api.github.com/users/jeerbl/gists{/gist_id}","starred_url":"https://api.github.com/users/jeerbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeerbl/subscriptions","organizations_url":"https://api.github.com/users/jeerbl/orgs","repos_url":"https://api.github.com/users/jeerbl/repos","events_url":"https://api.github.com/users/jeerbl/events{/privacy}","received_events_url":"https://api.github.com/users/jeerbl/received_events","type":"User","site_admin":false},"created_at":"2017-09-27T13:03:40Z","updated_at":"2017-09-27T13:03:40Z","author_association":"OWNER","body":"Seems good to me"}}
{"actor":{"display_login":"jeerbl"}}