{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments/135180647","pull_request_review_id":58565352,"id":135180647,"diff_hunk":"@@ -123,6 +124,21 @@ public DelegatingResourceDescription getUpdatableProperties() throws ResourceDoe\n \t\treturn orderResource.getUpdatableProperties();\n \t}\n \t\n+\t@Override\n+\tpublic Model getGETModel(Representation representation) {\n+\t\treturn null;\n+\t}\n+\t\n+\t@Override","path":"omod-1.10/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_10/TestOrderSubclassHandler1_10.java","position":17,"original_position":17,"commit_id":"c739c17d35036dfb4b315f9581ce2f9b9bdd33d5","original_commit_id":"c739c17d35036dfb4b315f9581ce2f9b9bdd33d5","user":{"login":"gayanW","id":5927747,"avatar_url":"https://avatars0.githubusercontent.com/u/5927747?v=4","gravatar_id":"","url":"https://api.github.com/users/gayanW","html_url":"https://github.com/gayanW","followers_url":"https://api.github.com/users/gayanW/followers","following_url":"https://api.github.com/users/gayanW/following{/other_user}","gists_url":"https://api.github.com/users/gayanW/gists{/gist_id}","starred_url":"https://api.github.com/users/gayanW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gayanW/subscriptions","organizations_url":"https://api.github.com/users/gayanW/orgs","repos_url":"https://api.github.com/users/gayanW/repos","events_url":"https://api.github.com/users/gayanW/events{/privacy}","received_events_url":"https://api.github.com/users/gayanW/received_events","type":"User","site_admin":false},"body":"Do we need to document handlers? I don't think they appear either as a resource or a property. If needed let me know.","created_at":"2017-08-25T04:12:20Z","updated_at":"2017-08-25T04:12:20Z","html_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/288#discussion_r135180647","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments/135180647"},"html":{"href":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/288#discussion_r135180647"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288"}},"in_reply_to_id":135131204},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288","id":130538392,"html_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/288","diff_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/288.diff","patch_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/288.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/288","number":288,"state":"open","locked":false,"title":"RESTWS-562 Improve Resource Definition Documentation","user":{"login":"gayanW","id":5927747,"avatar_url":"https://avatars0.githubusercontent.com/u/5927747?v=4","gravatar_id":"","url":"https://api.github.com/users/gayanW","html_url":"https://github.com/gayanW","followers_url":"https://api.github.com/users/gayanW/followers","following_url":"https://api.github.com/users/gayanW/following{/other_user}","gists_url":"https://api.github.com/users/gayanW/gists{/gist_id}","starred_url":"https://api.github.com/users/gayanW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gayanW/subscriptions","organizations_url":"https://api.github.com/users/gayanW/orgs","repos_url":"https://api.github.com/users/gayanW/repos","events_url":"https://api.github.com/users/gayanW/events{/privacy}","received_events_url":"https://api.github.com/users/gayanW/received_events","type":"User","site_admin":false},"body":"- adds swagger-core library\r\n  * uses its Java API and model classes to construct and generate the swagger json.\r\n- introudce new methods which model objects used in constructing the definitions section:\r\n  * getGETModel(Representation) :  returns a object represting GET representation schema of resource\r\n  * getCREATEModel(Representation) : returns a object representing CREATE representation shema of a resource\r\n  * getUPDATEModel(Representation) : returns a object representing POST Update representation schema of a resource\r\n\r\nex: PersonGet, PersonCreate, PersonUpdate\r\n- adds new test cases to: SwaggerSpecificationCreatorTest.java\r\n\r\n- adds support for multiple representation types\r\nGET schemas have support for representations: DEFAULT, REF, and FULL\r\nCREATE schemas have support for representations: DEFAULT, and FULL\r\nPOST_UPDATE schemas have support for representations: DEFAULT\r\n\r\n  * uses default schema for the shema of responses and parameters\r\n\r\nSwagger before: http://www.jsoneditoronline.org/?id=6ac2d0c797f5e8e4060d09b62b300b04\r\nSwagger after: http://jsoneditoronline.org/?id=d692754b9b4543f7388572317dc10400","created_at":"2017-07-14T08:18:38Z","updated_at":"2017-08-25T04:12:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec3c0abaec1b4f9312873cf96780d709a5dd5a30","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/288/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/statuses/c739c17d35036dfb4b315f9581ce2f9b9bdd33d5","head":{"label":"gayanW:restws-662","ref":"restws-662","sha":"c739c17d35036dfb4b315f9581ce2f9b9bdd33d5","user":{"login":"gayanW","id":5927747,"avatar_url":"https://avatars0.githubusercontent.com/u/5927747?v=4","gravatar_id":"","url":"https://api.github.com/users/gayanW","html_url":"https://github.com/gayanW","followers_url":"https://api.github.com/users/gayanW/followers","following_url":"https://api.github.com/users/gayanW/following{/other_user}","gists_url":"https://api.github.com/users/gayanW/gists{/gist_id}","starred_url":"https://api.github.com/users/gayanW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gayanW/subscriptions","organizations_url":"https://api.github.com/users/gayanW/orgs","repos_url":"https://api.github.com/users/gayanW/repos","events_url":"https://api.github.com/users/gayanW/events{/privacy}","received_events_url":"https://api.github.com/users/gayanW/received_events","type":"User","site_admin":false},"repo":{"id":86255609,"name":"openmrs-module-webservices.rest","full_name":"gayanW/openmrs-module-webservices.rest","owner":{"login":"gayanW","id":5927747,"avatar_url":"https://avatars0.githubusercontent.com/u/5927747?v=4","gravatar_id":"","url":"https://api.github.com/users/gayanW","html_url":"https://github.com/gayanW","followers_url":"https://api.github.com/users/gayanW/followers","following_url":"https://api.github.com/users/gayanW/following{/other_user}","gists_url":"https://api.github.com/users/gayanW/gists{/gist_id}","starred_url":"https://api.github.com/users/gayanW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gayanW/subscriptions","organizations_url":"https://api.github.com/users/gayanW/orgs","repos_url":"https://api.github.com/users/gayanW/repos","events_url":"https://api.github.com/users/gayanW/events{/privacy}","received_events_url":"https://api.github.com/users/gayanW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gayanW/openmrs-module-webservices.rest","description":"Provides RESTful web services for OpenMRS","fork":true,"url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest","forks_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/forks","keys_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/teams","hooks_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/hooks","issue_events_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/issues/events{/number}","events_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/events","assignees_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/assignees{/user}","branches_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/branches{/branch}","tags_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/tags","blobs_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/statuses/{sha}","languages_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/languages","stargazers_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/stargazers","contributors_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/contributors","subscribers_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/subscribers","subscription_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/subscription","commits_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/contents/{+path}","compare_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/merges","archive_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/downloads","issues_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/issues{/number}","pulls_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/pulls{/number}","milestones_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/milestones{/number}","notifications_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/labels{/name}","releases_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/releases{/id}","deployments_url":"https://api.github.com/repos/gayanW/openmrs-module-webservices.rest/deployments","created_at":"2017-03-26T18:35:53Z","updated_at":"2017-03-26T18:35:56Z","pushed_at":"2017-08-24T12:01:56Z","git_url":"git://github.com/gayanW/openmrs-module-webservices.rest.git","ssh_url":"git@github.com:gayanW/openmrs-module-webservices.rest.git","clone_url":"https://github.com/gayanW/openmrs-module-webservices.rest.git","svn_url":"https://github.com/gayanW/openmrs-module-webservices.rest","homepage":null,"size":6667,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"e12f8c7a910f70df65edf880a7046a54d59f5245","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":6951233,"name":"openmrs-module-webservices.rest","full_name":"openmrs/openmrs-module-webservices.rest","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-webservices.rest","description":"Provides RESTful web services for OpenMRS","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/deployments","created_at":"2012-12-01T06:50:25Z","updated_at":"2017-08-20T09:09:14Z","pushed_at":"2017-08-24T20:33:16Z","git_url":"git://github.com/openmrs/openmrs-module-webservices.rest.git","ssh_url":"git@github.com:openmrs/openmrs-module-webservices.rest.git","clone_url":"https://github.com/openmrs/openmrs-module-webservices.rest.git","svn_url":"https://github.com/openmrs/openmrs-module-webservices.rest","homepage":null,"size":5685,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":3,"forks":202,"open_issues":3,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288"},"html":{"href":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/288"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/288"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/statuses/c739c17d35036dfb4b315f9581ce2f9b9bdd33d5"}}}}
{"actor":{"display_login":"gayanW"}}