{"action":"created","comment":{"url":"https://api.github.com/repos/istio/manager/pulls/comments/97928700","pull_request_review_id":18553010,"id":97928700,"diff_hunk":"@@ -67,10 +92,13 @@ type ServiceInstance struct {\n \n // Port represents a network port\n type Port struct {\n-\t// Port value (may be distinct from the service port with the same name)\n-\tPort int `json:\"port\"`\n-\t// Name of the port classifies ports for a single service, optional\n+\t// Name of the port classifies ports for a single service, optional only for\n+\t// a single port service\n \tName string `json:\"name,omitempty\"`\n+","path":"model/service.go","position":74,"original_position":74,"commit_id":"602437720442e376101f891efaeac15b01481803","original_commit_id":"602437720442e376101f891efaeac15b01481803","user":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars.githubusercontent.com/u/8202871?v=3","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"per offline discussion, this is once again a K8S specific abstraction, thats leaking into the generic Istio model of a service. I don't have a good solution for this at this hour. Pushing it down into platform/kube.go may make the code there ugly, but keeps interfaces clean. Keeping name field here is fine, as long as its a benign entry in the port spec, but there needs to be an API to retrieve ports by Protocol or Port or Name. ","created_at":"2017-01-26T03:59:35Z","updated_at":"2017-01-26T04:01:51Z","html_url":"https://github.com/istio/manager/pull/60#discussion_r97928700","pull_request_url":"https://api.github.com/repos/istio/manager/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/comments/97928700"},"html":{"href":"https://github.com/istio/manager/pull/60#discussion_r97928700"},"pull_request":{"href":"https://api.github.com/repos/istio/manager/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/istio/manager/pulls/60","id":103245081,"html_url":"https://github.com/istio/manager/pull/60","diff_url":"https://github.com/istio/manager/pull/60.diff","patch_url":"https://github.com/istio/manager/pull/60.patch","issue_url":"https://api.github.com/repos/istio/manager/issues/60","number":60,"state":"open","locked":false,"title":"Fixes for HTTP routing","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars.githubusercontent.com/u/9537734?v=3","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"Addressed the following HTTP routing capabilities:\r\n- multiple HTTP ports in a service\r\n- domain names can be \"name\" or \"name.namespace\"\r\n- port is a part of the host name\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/istio/manager/60)\n<!-- Reviewable:end -->\n","created_at":"2017-01-26T02:42:34Z","updated_at":"2017-01-26T04:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36e83fc2471d1811445a306f5aed06dd435c2e82","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/manager/pulls/60/commits","review_comments_url":"https://api.github.com/repos/istio/manager/pulls/60/comments","review_comment_url":"https://api.github.com/repos/istio/manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/manager/issues/60/comments","statuses_url":"https://api.github.com/repos/istio/manager/statuses/602437720442e376101f891efaeac15b01481803","head":{"label":"kyessenov:k8s_services","ref":"k8s_services","sha":"602437720442e376101f891efaeac15b01481803","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars.githubusercontent.com/u/9537734?v=3","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"repo":{"id":75991473,"name":"manager","full_name":"kyessenov/manager","owner":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars.githubusercontent.com/u/9537734?v=3","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyessenov/manager","description":"The Istio manager implementation","fork":true,"url":"https://api.github.com/repos/kyessenov/manager","forks_url":"https://api.github.com/repos/kyessenov/manager/forks","keys_url":"https://api.github.com/repos/kyessenov/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyessenov/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyessenov/manager/teams","hooks_url":"https://api.github.com/repos/kyessenov/manager/hooks","issue_events_url":"https://api.github.com/repos/kyessenov/manager/issues/events{/number}","events_url":"https://api.github.com/repos/kyessenov/manager/events","assignees_url":"https://api.github.com/repos/kyessenov/manager/assignees{/user}","branches_url":"https://api.github.com/repos/kyessenov/manager/branches{/branch}","tags_url":"https://api.github.com/repos/kyessenov/manager/tags","blobs_url":"https://api.github.com/repos/kyessenov/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyessenov/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyessenov/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyessenov/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyessenov/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/kyessenov/manager/languages","stargazers_url":"https://api.github.com/repos/kyessenov/manager/stargazers","contributors_url":"https://api.github.com/repos/kyessenov/manager/contributors","subscribers_url":"https://api.github.com/repos/kyessenov/manager/subscribers","subscription_url":"https://api.github.com/repos/kyessenov/manager/subscription","commits_url":"https://api.github.com/repos/kyessenov/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyessenov/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyessenov/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyessenov/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyessenov/manager/contents/{+path}","compare_url":"https://api.github.com/repos/kyessenov/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyessenov/manager/merges","archive_url":"https://api.github.com/repos/kyessenov/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyessenov/manager/downloads","issues_url":"https://api.github.com/repos/kyessenov/manager/issues{/number}","pulls_url":"https://api.github.com/repos/kyessenov/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/kyessenov/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/kyessenov/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyessenov/manager/labels{/name}","releases_url":"https://api.github.com/repos/kyessenov/manager/releases{/id}","deployments_url":"https://api.github.com/repos/kyessenov/manager/deployments","created_at":"2016-12-09T01:53:54Z","updated_at":"2016-12-09T02:06:57Z","pushed_at":"2017-01-26T02:47:40Z","git_url":"git://github.com/kyessenov/manager.git","ssh_url":"git@github.com:kyessenov/manager.git","clone_url":"https://github.com/kyessenov/manager.git","svn_url":"https://github.com/kyessenov/manager","homepage":"","size":203,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"8650614b8f6002a94db2a58e3e2d8ee45e9e3629","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"manager","full_name":"istio/manager","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/manager","description":"The Istio manager implementation","fork":false,"url":"https://api.github.com/repos/istio/manager","forks_url":"https://api.github.com/repos/istio/manager/forks","keys_url":"https://api.github.com/repos/istio/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/manager/teams","hooks_url":"https://api.github.com/repos/istio/manager/hooks","issue_events_url":"https://api.github.com/repos/istio/manager/issues/events{/number}","events_url":"https://api.github.com/repos/istio/manager/events","assignees_url":"https://api.github.com/repos/istio/manager/assignees{/user}","branches_url":"https://api.github.com/repos/istio/manager/branches{/branch}","tags_url":"https://api.github.com/repos/istio/manager/tags","blobs_url":"https://api.github.com/repos/istio/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/manager/languages","stargazers_url":"https://api.github.com/repos/istio/manager/stargazers","contributors_url":"https://api.github.com/repos/istio/manager/contributors","subscribers_url":"https://api.github.com/repos/istio/manager/subscribers","subscription_url":"https://api.github.com/repos/istio/manager/subscription","commits_url":"https://api.github.com/repos/istio/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/manager/contents/{+path}","compare_url":"https://api.github.com/repos/istio/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/manager/merges","archive_url":"https://api.github.com/repos/istio/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/manager/downloads","issues_url":"https://api.github.com/repos/istio/manager/issues{/number}","pulls_url":"https://api.github.com/repos/istio/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/manager/labels{/name}","releases_url":"https://api.github.com/repos/istio/manager/releases{/id}","deployments_url":"https://api.github.com/repos/istio/manager/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2017-01-17T17:45:40Z","pushed_at":"2017-01-26T02:47:45Z","git_url":"git://github.com/istio/manager.git","ssh_url":"git@github.com:istio/manager.git","clone_url":"https://github.com/istio/manager.git","svn_url":"https://github.com/istio/manager","homepage":"","size":207,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":20,"forks":8,"open_issues":20,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/60"},"html":{"href":"https://github.com/istio/manager/pull/60"},"issue":{"href":"https://api.github.com/repos/istio/manager/issues/60"},"comments":{"href":"https://api.github.com/repos/istio/manager/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/manager/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/manager/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/istio/manager/statuses/602437720442e376101f891efaeac15b01481803"}}}}
{"actor":{"display_login":"rshriram"}}