{"push_id":2204025577,"size":2,"distinct_size":2,"ref":"refs/heads/binary-open","head":"8014a76f7811114875f1f47fc75044475fcf85d9","before":"1e23ef6ccbfd175acb81b94d8d2558c234b38db5","commits":[{"sha":"20ea121957f6f93419cb2d4cfaee435759fd7543","author":{"name":"Andrew Schwartzmeyer","email":"6b7c097d961f68685fc978cf91eeae17be6cbb45@schwartzmeyer.com"},"message":"Windows: Fixed `os::open()` to always use `O_BINARY`.\n\nPreviously, we had been manually adding the `O_BINARY` flag as we\nencountered bugs due to the Windows default behavior of performing\nline-ending translation. This was error prone.\n\nGiven this precedent, it seems safe to assume that all our existing code\nexpects the POSIX semantics of \"binary mode\", that is, no translation of\nwritten data at all. So now we add this flag by default in `os::open()`\ninstead of in the users.\n\nIt is possible that a future use requires text translation. At such\npoint, we can trivially fix `os::open()` to take a boolean flag to\ncontrol the addition of `O_BINARY`, but we do not currently need to\nengineer this.","distinct":true,"url":"https://api.github.com/repos/andschwa/mesos/commits/20ea121957f6f93419cb2d4cfaee435759fd7543"},{"sha":"8014a76f7811114875f1f47fc75044475fcf85d9","author":{"name":"Andrew Schwartzmeyer","email":"6b7c097d961f68685fc978cf91eeae17be6cbb45@schwartzmeyer.com"},"message":"Windows: Removed manual use of `O_BINARY`.\n\nThis is now superfluous as it is added in stout.","distinct":true,"url":"https://api.github.com/repos/andschwa/mesos/commits/8014a76f7811114875f1f47fc75044475fcf85d9"}]}
{"actor":{"display_login":"andschwa"}}