{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/128769912","pull_request_review_id":51483726,"id":128769912,"diff_hunk":"@@ -246,22 +247,20 @@ node::DebugOptions debug_options;\n \n static struct {\n #if NODE_USE_V8_PLATFORM\n-  void Initialize(int thread_pool_size) {\n-    platform_ = v8::platform::CreateDefaultPlatform(\n-        thread_pool_size,\n-        v8::platform::IdleTaskSupport::kDisabled,\n-        v8::platform::InProcessStackDumping::kDisabled);\n+  void Initialize(int thread_pool_size, uv_loop_t* loop) {\n+    tracing_agent_ =\n+      trace_enabled ? new tracing::Agent() : nullptr;\n+    platform_ = new NodePlatform(thread_pool_size, loop,\n+      trace_enabled ? tracing_agent_->GetTracingController() : nullptr);","path":"src/node.cc","position":21,"original_position":21,"commit_id":"43143fdb87dcb2adf8b3e402a27f11829b876a54","original_commit_id":"43143fdb87dcb2adf8b3e402a27f11829b876a54","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Style nit: four space indent.","created_at":"2017-07-21T14:07:16Z","updated_at":"2017-07-21T14:19:47Z","html_url":"https://github.com/nodejs/node/pull/14001#discussion_r128769912","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/14001","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/128769912"},"html":{"href":"https://github.com/nodejs/node/pull/14001#discussion_r128769912"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/14001"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14001","id":128346153,"html_url":"https://github.com/nodejs/node/pull/14001","diff_url":"https://github.com/nodejs/node/pull/14001.diff","patch_url":"https://github.com/nodejs/node/pull/14001.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/14001","number":14001,"state":"open","locked":false,"title":"src: Node implementation of v8::Platform","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars3.githubusercontent.com/u/1485909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"Node.js currently uses the V8 implementation of the DefaultPlatform\r\nwhich schedules VM tasks on a V8 managed thread pool. Since the Node.js\r\nevent loop is not aware of these tasks, the Node.js process may exit\r\nwhile there are outstanding VM tasks. This will become problematic once\r\nasynchronous wasm compilation lands in V8.\r\n\r\nThis PR introduces a Node.js specific implementation of the v8::Platform\r\non top of libuv so that the event loop is aware of outstanding VM tasks.\r\n\r\nFixes: nodejs#12980\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nsrc, tracing\r\n","created_at":"2017-06-30T11:01:16Z","updated_at":"2017-07-21T14:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3eda6e6aac8aeacaa2fb87f56370e1fbe62050c0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/14001/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/14001/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14001/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/43143fdb87dcb2adf8b3e402a27f11829b876a54","head":{"label":"matthewloring:new-node-platform","ref":"new-node-platform","sha":"43143fdb87dcb2adf8b3e402a27f11829b876a54","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars3.githubusercontent.com/u/1485909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"repo":{"id":38261750,"name":"node","full_name":"matthewloring/node","owner":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars3.githubusercontent.com/u/1485909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewloring/node","description":"Node.js JavaScript runtime ✨🐢🚀✨","fork":true,"url":"https://api.github.com/repos/matthewloring/node","forks_url":"https://api.github.com/repos/matthewloring/node/forks","keys_url":"https://api.github.com/repos/matthewloring/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewloring/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewloring/node/teams","hooks_url":"https://api.github.com/repos/matthewloring/node/hooks","issue_events_url":"https://api.github.com/repos/matthewloring/node/issues/events{/number}","events_url":"https://api.github.com/repos/matthewloring/node/events","assignees_url":"https://api.github.com/repos/matthewloring/node/assignees{/user}","branches_url":"https://api.github.com/repos/matthewloring/node/branches{/branch}","tags_url":"https://api.github.com/repos/matthewloring/node/tags","blobs_url":"https://api.github.com/repos/matthewloring/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewloring/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewloring/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewloring/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewloring/node/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewloring/node/languages","stargazers_url":"https://api.github.com/repos/matthewloring/node/stargazers","contributors_url":"https://api.github.com/repos/matthewloring/node/contributors","subscribers_url":"https://api.github.com/repos/matthewloring/node/subscribers","subscription_url":"https://api.github.com/repos/matthewloring/node/subscription","commits_url":"https://api.github.com/repos/matthewloring/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewloring/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewloring/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewloring/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewloring/node/contents/{+path}","compare_url":"https://api.github.com/repos/matthewloring/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewloring/node/merges","archive_url":"https://api.github.com/repos/matthewloring/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewloring/node/downloads","issues_url":"https://api.github.com/repos/matthewloring/node/issues{/number}","pulls_url":"https://api.github.com/repos/matthewloring/node/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewloring/node/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewloring/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewloring/node/labels{/name}","releases_url":"https://api.github.com/repos/matthewloring/node/releases{/id}","deployments_url":"https://api.github.com/repos/matthewloring/node/deployments","created_at":"2015-06-29T17:49:00Z","updated_at":"2016-10-26T16:46:47Z","pushed_at":"2017-07-21T03:57:03Z","git_url":"git://github.com/matthewloring/node.git","ssh_url":"git@github.com:matthewloring/node.git","clone_url":"https://github.com/matthewloring/node.git","svn_url":"https://github.com/matthewloring/node","homepage":"https://nodejs.org","size":277972,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"b61cab2234b3d9bf7265980f9286a136af20365b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-07-21T13:45:49Z","pushed_at":"2017-07-21T14:04:40Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":300024,"stargazers_count":37249,"watchers_count":37249,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7313,"mirror_url":null,"open_issues_count":948,"forks":7313,"open_issues":948,"watchers":37249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/14001"},"html":{"href":"https://github.com/nodejs/node/pull/14001"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/14001"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/14001/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/14001/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/14001/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/43143fdb87dcb2adf8b3e402a27f11829b876a54"}}}}
{"actor":{"display_login":"bnoordhuis"}}