{"action":"created","comment":{"url":"https://api.github.com/repos/decentraland/mana/pulls/comments/131250562","pull_request_review_id":54212940,"id":131250562,"diff_hunk":"@@ -41,16 +40,22 @@ contract MANACrowdsale is ContinuousCrowdsale, WhitelistedCrowdsale, CappedCrowd\n     {\n         require(_rateStepDecrease > 0);\n         require(_preferentialRate > 0);\n-        require(_rate > _rateStepDecrease * (_endBlock - _startBlock));\n+        require(_rate > _rateStepDecrease * (1 + _endBlock - _startBlock));\n \n         rateStepDecrease = _rateStepDecrease;\n         preferentialRate = _preferentialRate;\n+\n+        createContinuousSaleContract();","path":"contracts/MANACrowdsale.sol","position":null,"original_position":36,"commit_id":"d72364ab0ccc4654f82b662ec49334101270c79f","original_commit_id":"94641959dc12a3f04309028fee9ea05ec740a9e0","user":{"login":"spalladino","id":429604,"avatar_url":"https://avatars2.githubusercontent.com/u/429604?v=4","gravatar_id":"","url":"https://api.github.com/users/spalladino","html_url":"https://github.com/spalladino","followers_url":"https://api.github.com/users/spalladino/followers","following_url":"https://api.github.com/users/spalladino/following{/other_user}","gists_url":"https://api.github.com/users/spalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/spalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalladino/subscriptions","organizations_url":"https://api.github.com/users/spalladino/orgs","repos_url":"https://api.github.com/users/spalladino/repos","events_url":"https://api.github.com/users/spalladino/events{/privacy}","received_events_url":"https://api.github.com/users/spalladino/received_events","type":"User","site_admin":false},"body":"The contract created here should be assigned to the `continuousSale` field. (credit to @frangio)","created_at":"2017-08-03T20:26:12Z","updated_at":"2017-08-03T20:26:12Z","html_url":"https://github.com/decentraland/mana/pull/24#discussion_r131250562","pull_request_url":"https://api.github.com/repos/decentraland/mana/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/decentraland/mana/pulls/comments/131250562"},"html":{"href":"https://github.com/decentraland/mana/pull/24#discussion_r131250562"},"pull_request":{"href":"https://api.github.com/repos/decentraland/mana/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/decentraland/mana/pulls/24","id":132858714,"html_url":"https://github.com/decentraland/mana/pull/24","diff_url":"https://github.com/decentraland/mana/pull/24.diff","patch_url":"https://github.com/decentraland/mana/pull/24.patch","issue_url":"https://api.github.com/repos/decentraland/mana/issues/24","number":24,"state":"open","locked":false,"title":"Split main sale and continuous sale contracts","user":{"login":"federicobond","id":138426,"avatar_url":"https://avatars1.githubusercontent.com/u/138426?v=4","gravatar_id":"","url":"https://api.github.com/users/federicobond","html_url":"https://github.com/federicobond","followers_url":"https://api.github.com/users/federicobond/followers","following_url":"https://api.github.com/users/federicobond/following{/other_user}","gists_url":"https://api.github.com/users/federicobond/gists{/gist_id}","starred_url":"https://api.github.com/users/federicobond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/federicobond/subscriptions","organizations_url":"https://api.github.com/users/federicobond/orgs","repos_url":"https://api.github.com/users/federicobond/repos","events_url":"https://api.github.com/users/federicobond/events{/privacy}","received_events_url":"https://api.github.com/users/federicobond/received_events","type":"User","site_admin":false},"body":"Need to fix some tests, but pushing this to gather feedback.","created_at":"2017-07-27T22:22:25Z","updated_at":"2017-08-03T20:26:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c182d1f95ef25ee1cb4255ee69dbf4aea0837290","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/decentraland/mana/pulls/24/commits","review_comments_url":"https://api.github.com/repos/decentraland/mana/pulls/24/comments","review_comment_url":"https://api.github.com/repos/decentraland/mana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decentraland/mana/issues/24/comments","statuses_url":"https://api.github.com/repos/decentraland/mana/statuses/d72364ab0ccc4654f82b662ec49334101270c79f","head":{"label":"decentraland:continuous-split","ref":"continuous-split","sha":"d72364ab0ccc4654f82b662ec49334101270c79f","user":{"login":"decentraland","id":12685795,"avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"repo":{"id":96849830,"name":"mana","full_name":"decentraland/mana","owner":{"login":"decentraland","id":12685795,"avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decentraland/mana","description":"Solidity Contracts for the Decentraland MANA Token","fork":false,"url":"https://api.github.com/repos/decentraland/mana","forks_url":"https://api.github.com/repos/decentraland/mana/forks","keys_url":"https://api.github.com/repos/decentraland/mana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentraland/mana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentraland/mana/teams","hooks_url":"https://api.github.com/repos/decentraland/mana/hooks","issue_events_url":"https://api.github.com/repos/decentraland/mana/issues/events{/number}","events_url":"https://api.github.com/repos/decentraland/mana/events","assignees_url":"https://api.github.com/repos/decentraland/mana/assignees{/user}","branches_url":"https://api.github.com/repos/decentraland/mana/branches{/branch}","tags_url":"https://api.github.com/repos/decentraland/mana/tags","blobs_url":"https://api.github.com/repos/decentraland/mana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentraland/mana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentraland/mana/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentraland/mana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentraland/mana/statuses/{sha}","languages_url":"https://api.github.com/repos/decentraland/mana/languages","stargazers_url":"https://api.github.com/repos/decentraland/mana/stargazers","contributors_url":"https://api.github.com/repos/decentraland/mana/contributors","subscribers_url":"https://api.github.com/repos/decentraland/mana/subscribers","subscription_url":"https://api.github.com/repos/decentraland/mana/subscription","commits_url":"https://api.github.com/repos/decentraland/mana/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentraland/mana/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentraland/mana/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentraland/mana/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentraland/mana/contents/{+path}","compare_url":"https://api.github.com/repos/decentraland/mana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentraland/mana/merges","archive_url":"https://api.github.com/repos/decentraland/mana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentraland/mana/downloads","issues_url":"https://api.github.com/repos/decentraland/mana/issues{/number}","pulls_url":"https://api.github.com/repos/decentraland/mana/pulls{/number}","milestones_url":"https://api.github.com/repos/decentraland/mana/milestones{/number}","notifications_url":"https://api.github.com/repos/decentraland/mana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentraland/mana/labels{/name}","releases_url":"https://api.github.com/repos/decentraland/mana/releases{/id}","deployments_url":"https://api.github.com/repos/decentraland/mana/deployments","created_at":"2017-07-11T04:13:11Z","updated_at":"2017-08-01T22:16:02Z","pushed_at":"2017-08-03T17:42:14Z","git_url":"git://github.com/decentraland/mana.git","ssh_url":"git@github.com:decentraland/mana.git","clone_url":"https://github.com/decentraland/mana.git","svn_url":"https://github.com/decentraland/mana","homepage":null,"size":106,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":15,"default_branch":"master"}},"base":{"label":"decentraland:master","ref":"master","sha":"da203a1d85ce0e1c8180de3952ec3ae40b39a792","user":{"login":"decentraland","id":12685795,"avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"repo":{"id":96849830,"name":"mana","full_name":"decentraland/mana","owner":{"login":"decentraland","id":12685795,"avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decentraland/mana","description":"Solidity Contracts for the Decentraland MANA Token","fork":false,"url":"https://api.github.com/repos/decentraland/mana","forks_url":"https://api.github.com/repos/decentraland/mana/forks","keys_url":"https://api.github.com/repos/decentraland/mana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentraland/mana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentraland/mana/teams","hooks_url":"https://api.github.com/repos/decentraland/mana/hooks","issue_events_url":"https://api.github.com/repos/decentraland/mana/issues/events{/number}","events_url":"https://api.github.com/repos/decentraland/mana/events","assignees_url":"https://api.github.com/repos/decentraland/mana/assignees{/user}","branches_url":"https://api.github.com/repos/decentraland/mana/branches{/branch}","tags_url":"https://api.github.com/repos/decentraland/mana/tags","blobs_url":"https://api.github.com/repos/decentraland/mana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentraland/mana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentraland/mana/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentraland/mana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentraland/mana/statuses/{sha}","languages_url":"https://api.github.com/repos/decentraland/mana/languages","stargazers_url":"https://api.github.com/repos/decentraland/mana/stargazers","contributors_url":"https://api.github.com/repos/decentraland/mana/contributors","subscribers_url":"https://api.github.com/repos/decentraland/mana/subscribers","subscription_url":"https://api.github.com/repos/decentraland/mana/subscription","commits_url":"https://api.github.com/repos/decentraland/mana/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentraland/mana/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentraland/mana/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentraland/mana/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentraland/mana/contents/{+path}","compare_url":"https://api.github.com/repos/decentraland/mana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentraland/mana/merges","archive_url":"https://api.github.com/repos/decentraland/mana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentraland/mana/downloads","issues_url":"https://api.github.com/repos/decentraland/mana/issues{/number}","pulls_url":"https://api.github.com/repos/decentraland/mana/pulls{/number}","milestones_url":"https://api.github.com/repos/decentraland/mana/milestones{/number}","notifications_url":"https://api.github.com/repos/decentraland/mana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentraland/mana/labels{/name}","releases_url":"https://api.github.com/repos/decentraland/mana/releases{/id}","deployments_url":"https://api.github.com/repos/decentraland/mana/deployments","created_at":"2017-07-11T04:13:11Z","updated_at":"2017-08-01T22:16:02Z","pushed_at":"2017-08-03T17:42:14Z","git_url":"git://github.com/decentraland/mana.git","ssh_url":"git@github.com:decentraland/mana.git","clone_url":"https://github.com/decentraland/mana.git","svn_url":"https://github.com/decentraland/mana","homepage":null,"size":106,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decentraland/mana/pulls/24"},"html":{"href":"https://github.com/decentraland/mana/pull/24"},"issue":{"href":"https://api.github.com/repos/decentraland/mana/issues/24"},"comments":{"href":"https://api.github.com/repos/decentraland/mana/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/decentraland/mana/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/decentraland/mana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decentraland/mana/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/decentraland/mana/statuses/d72364ab0ccc4654f82b662ec49334101270c79f"}}}}
{"actor":{"display_login":"spalladino"}}