{"action":"created","comment":{"url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/comments/140314101","pull_request_review_id":64368989,"id":140314101,"diff_hunk":"@@ -29,11 +29,7 @@ - (NSMutableDictionary *)toJSONWithIncludedTypes:(NSSet *)types\n   NSDictionary        *map = [[self class] JSONtoModelMap];\n   RLMSchema           *schema = self.realm ? self.realm.schema : [RLMRealm defaultRealm].schema;\n   Class                class = [self class];\n-  // Realm often subclasses our objects with RLMAccessor, or RLMStandalone if we're not in a Realm\n-  if ([NSStringFromClass(class) rangeOfString:@\"RLMAccessor\"].location != NSNotFound\n-      || [NSStringFromClass(class) rangeOfString:@\"RLMStandalone\"].location != NSNotFound) {\n-    class = [class superclass];\n-  }","path":"Realm-JSONAPI/Classes/RLMObject+JSONAPISerializer.m","position":8,"original_position":8,"commit_id":"dbabe3b6642e03bedd1de88efe1ba5cd70b427c4","original_commit_id":"a857df7d55457c0a3b69b9cc181e1db3f8127817","user":{"login":"tedlee","id":465289,"avatar_url":"https://avatars2.githubusercontent.com/u/465289?v=4","gravatar_id":"","url":"https://api.github.com/users/tedlee","html_url":"https://github.com/tedlee","followers_url":"https://api.github.com/users/tedlee/followers","following_url":"https://api.github.com/users/tedlee/following{/other_user}","gists_url":"https://api.github.com/users/tedlee/gists{/gist_id}","starred_url":"https://api.github.com/users/tedlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedlee/subscriptions","organizations_url":"https://api.github.com/users/tedlee/orgs","repos_url":"https://api.github.com/users/tedlee/repos","events_url":"https://api.github.com/users/tedlee/events{/privacy}","received_events_url":"https://api.github.com/users/tedlee/received_events","type":"User","site_admin":false},"body":"In testing with Realm 2.10.1 `[self class]` was of type RLM:Managed (previously RLM:Accessor) which resulted in never grabbing the correct superclass","created_at":"2017-09-21T17:52:45Z","updated_at":"2017-09-21T17:52:45Z","html_url":"https://github.com/Patreon/Realm-JSONAPI/pull/10#discussion_r140314101","pull_request_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/comments/140314101"},"html":{"href":"https://github.com/Patreon/Realm-JSONAPI/pull/10#discussion_r140314101"},"pull_request":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10"}},"in_reply_to_id":140136373},"pull_request":{"url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10","id":142241674,"html_url":"https://github.com/Patreon/Realm-JSONAPI/pull/10","diff_url":"https://github.com/Patreon/Realm-JSONAPI/pull/10.diff","patch_url":"https://github.com/Patreon/Realm-JSONAPI/pull/10.patch","issue_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/10","number":10,"state":"open","locked":false,"title":"Upgrade realm dependency for Xcode compatibility","user":{"login":"tedlee","id":465289,"avatar_url":"https://avatars2.githubusercontent.com/u/465289?v=4","gravatar_id":"","url":"https://api.github.com/users/tedlee","html_url":"https://github.com/tedlee","followers_url":"https://api.github.com/users/tedlee/followers","following_url":"https://api.github.com/users/tedlee/following{/other_user}","gists_url":"https://api.github.com/users/tedlee/gists{/gist_id}","starred_url":"https://api.github.com/users/tedlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedlee/subscriptions","organizations_url":"https://api.github.com/users/tedlee/orgs","repos_url":"https://api.github.com/users/tedlee/repos","events_url":"https://api.github.com/users/tedlee/events{/privacy}","received_events_url":"https://api.github.com/users/tedlee/received_events","type":"User","site_admin":false},"body":"Xcode 9 made some changes to how c++ files are handled which broke our Realm 2.1.0 dependency. Upgrading to the latest Realm build, 2.10.1, fixes the issue. \r\n\r\n@21echoes - we'll use this in testing for a while before merging to ensure there are no unforeseen consequences","created_at":"2017-09-21T02:11:37Z","updated_at":"2017-09-21T17:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3916b6afb739c7f270d7b0b296829ed633b972f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"minoue10","id":6021277,"avatar_url":"https://avatars1.githubusercontent.com/u/6021277?v=4","gravatar_id":"","url":"https://api.github.com/users/minoue10","html_url":"https://github.com/minoue10","followers_url":"https://api.github.com/users/minoue10/followers","following_url":"https://api.github.com/users/minoue10/following{/other_user}","gists_url":"https://api.github.com/users/minoue10/gists{/gist_id}","starred_url":"https://api.github.com/users/minoue10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minoue10/subscriptions","organizations_url":"https://api.github.com/users/minoue10/orgs","repos_url":"https://api.github.com/users/minoue10/repos","events_url":"https://api.github.com/users/minoue10/events{/privacy}","received_events_url":"https://api.github.com/users/minoue10/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/10/comments","statuses_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/statuses/dbabe3b6642e03bedd1de88efe1ba5cd70b427c4","head":{"label":"Patreon:Upgrade-realm-dependency","ref":"Upgrade-realm-dependency","sha":"dbabe3b6642e03bedd1de88efe1ba5cd70b427c4","user":{"login":"Patreon","id":6578555,"avatar_url":"https://avatars0.githubusercontent.com/u/6578555?v=4","gravatar_id":"","url":"https://api.github.com/users/Patreon","html_url":"https://github.com/Patreon","followers_url":"https://api.github.com/users/Patreon/followers","following_url":"https://api.github.com/users/Patreon/following{/other_user}","gists_url":"https://api.github.com/users/Patreon/gists{/gist_id}","starred_url":"https://api.github.com/users/Patreon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patreon/subscriptions","organizations_url":"https://api.github.com/users/Patreon/orgs","repos_url":"https://api.github.com/users/Patreon/repos","events_url":"https://api.github.com/users/Patreon/events{/privacy}","received_events_url":"https://api.github.com/users/Patreon/received_events","type":"Organization","site_admin":false},"repo":{"id":58848868,"name":"Realm-JSONAPI","full_name":"Patreon/Realm-JSONAPI","owner":{"login":"Patreon","id":6578555,"avatar_url":"https://avatars0.githubusercontent.com/u/6578555?v=4","gravatar_id":"","url":"https://api.github.com/users/Patreon","html_url":"https://github.com/Patreon","followers_url":"https://api.github.com/users/Patreon/followers","following_url":"https://api.github.com/users/Patreon/following{/other_user}","gists_url":"https://api.github.com/users/Patreon/gists{/gist_id}","starred_url":"https://api.github.com/users/Patreon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patreon/subscriptions","organizations_url":"https://api.github.com/users/Patreon/orgs","repos_url":"https://api.github.com/users/Patreon/repos","events_url":"https://api.github.com/users/Patreon/events{/privacy}","received_events_url":"https://api.github.com/users/Patreon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Patreon/Realm-JSONAPI","description":"Easily integrate Realm for iOS with a JSON-API compliant server","fork":false,"url":"https://api.github.com/repos/Patreon/Realm-JSONAPI","forks_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/forks","keys_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/teams","hooks_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/hooks","issue_events_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/events{/number}","events_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/events","assignees_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/assignees{/user}","branches_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/branches{/branch}","tags_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/tags","blobs_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/languages","stargazers_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/stargazers","contributors_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/contributors","subscribers_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/subscribers","subscription_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/subscription","commits_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/contents/{+path}","compare_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/merges","archive_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/downloads","issues_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues{/number}","pulls_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/labels{/name}","releases_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/releases{/id}","deployments_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/deployments","created_at":"2016-05-15T07:13:53Z","updated_at":"2017-08-03T06:42:30Z","pushed_at":"2017-09-21T17:32:54Z","git_url":"git://github.com/Patreon/Realm-JSONAPI.git","ssh_url":"git@github.com:Patreon/Realm-JSONAPI.git","clone_url":"https://github.com/Patreon/Realm-JSONAPI.git","svn_url":"https://github.com/Patreon/Realm-JSONAPI","homepage":null,"size":46204,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":34,"default_branch":"master"}},"base":{"label":"Patreon:master","ref":"master","sha":"7aab7dde0e4b9fbe0af35868c8333e511db59254","user":{"login":"Patreon","id":6578555,"avatar_url":"https://avatars0.githubusercontent.com/u/6578555?v=4","gravatar_id":"","url":"https://api.github.com/users/Patreon","html_url":"https://github.com/Patreon","followers_url":"https://api.github.com/users/Patreon/followers","following_url":"https://api.github.com/users/Patreon/following{/other_user}","gists_url":"https://api.github.com/users/Patreon/gists{/gist_id}","starred_url":"https://api.github.com/users/Patreon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patreon/subscriptions","organizations_url":"https://api.github.com/users/Patreon/orgs","repos_url":"https://api.github.com/users/Patreon/repos","events_url":"https://api.github.com/users/Patreon/events{/privacy}","received_events_url":"https://api.github.com/users/Patreon/received_events","type":"Organization","site_admin":false},"repo":{"id":58848868,"name":"Realm-JSONAPI","full_name":"Patreon/Realm-JSONAPI","owner":{"login":"Patreon","id":6578555,"avatar_url":"https://avatars0.githubusercontent.com/u/6578555?v=4","gravatar_id":"","url":"https://api.github.com/users/Patreon","html_url":"https://github.com/Patreon","followers_url":"https://api.github.com/users/Patreon/followers","following_url":"https://api.github.com/users/Patreon/following{/other_user}","gists_url":"https://api.github.com/users/Patreon/gists{/gist_id}","starred_url":"https://api.github.com/users/Patreon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patreon/subscriptions","organizations_url":"https://api.github.com/users/Patreon/orgs","repos_url":"https://api.github.com/users/Patreon/repos","events_url":"https://api.github.com/users/Patreon/events{/privacy}","received_events_url":"https://api.github.com/users/Patreon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Patreon/Realm-JSONAPI","description":"Easily integrate Realm for iOS with a JSON-API compliant server","fork":false,"url":"https://api.github.com/repos/Patreon/Realm-JSONAPI","forks_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/forks","keys_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/teams","hooks_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/hooks","issue_events_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/events{/number}","events_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/events","assignees_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/assignees{/user}","branches_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/branches{/branch}","tags_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/tags","blobs_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/languages","stargazers_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/stargazers","contributors_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/contributors","subscribers_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/subscribers","subscription_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/subscription","commits_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/contents/{+path}","compare_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/merges","archive_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/downloads","issues_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues{/number}","pulls_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/labels{/name}","releases_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/releases{/id}","deployments_url":"https://api.github.com/repos/Patreon/Realm-JSONAPI/deployments","created_at":"2016-05-15T07:13:53Z","updated_at":"2017-08-03T06:42:30Z","pushed_at":"2017-09-21T17:32:54Z","git_url":"git://github.com/Patreon/Realm-JSONAPI.git","ssh_url":"git@github.com:Patreon/Realm-JSONAPI.git","clone_url":"https://github.com/Patreon/Realm-JSONAPI.git","svn_url":"https://github.com/Patreon/Realm-JSONAPI","homepage":null,"size":46204,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10"},"html":{"href":"https://github.com/Patreon/Realm-JSONAPI/pull/10"},"issue":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/10"},"comments":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Patreon/Realm-JSONAPI/statuses/dbabe3b6642e03bedd1de88efe1ba5cd70b427c4"}},"author_association":"NONE"}}
{"actor":{"display_login":"tedlee"}}