{"action":"created","issue":{"url":"https://api.github.com/repos/ps2dev/ps2sdk/issues/40","repository_url":"https://api.github.com/repos/ps2dev/ps2sdk","labels_url":"https://api.github.com/repos/ps2dev/ps2sdk/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/ps2dev/ps2sdk/issues/40/comments","events_url":"https://api.github.com/repos/ps2dev/ps2sdk/issues/40/events","html_url":"https://github.com/ps2dev/ps2sdk/pull/40","id":225702311,"number":40,"title":"Some keyboards make control endpoint halted when requesting iManufact…","user":{"login":"belek666","id":15877417,"avatar_url":"https://avatars0.githubusercontent.com/u/15877417?v=3","gravatar_id":"","url":"https://api.github.com/users/belek666","html_url":"https://github.com/belek666","followers_url":"https://api.github.com/users/belek666/followers","following_url":"https://api.github.com/users/belek666/following{/other_user}","gists_url":"https://api.github.com/users/belek666/gists{/gist_id}","starred_url":"https://api.github.com/users/belek666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belek666/subscriptions","organizations_url":"https://api.github.com/users/belek666/orgs","repos_url":"https://api.github.com/users/belek666/repos","events_url":"https://api.github.com/users/belek666/events{/privacy}","received_events_url":"https://api.github.com/users/belek666/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-02T13:54:28Z","updated_at":"2017-05-08T13:16:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ps2dev/ps2sdk/pulls/40","html_url":"https://github.com/ps2dev/ps2sdk/pull/40","diff_url":"https://github.com/ps2dev/ps2sdk/pull/40.diff","patch_url":"https://github.com/ps2dev/ps2sdk/pull/40.patch"},"body":"…urer and iProduct strings"},"comment":{"url":"https://api.github.com/repos/ps2dev/ps2sdk/issues/comments/299863701","html_url":"https://github.com/ps2dev/ps2sdk/pull/40#issuecomment-299863701","issue_url":"https://api.github.com/repos/ps2dev/ps2sdk/issues/40","id":299863701,"user":{"login":"sp193","id":3446348,"avatar_url":"https://avatars2.githubusercontent.com/u/3446348?v=3","gravatar_id":"","url":"https://api.github.com/users/sp193","html_url":"https://github.com/sp193","followers_url":"https://api.github.com/users/sp193/followers","following_url":"https://api.github.com/users/sp193/following{/other_user}","gists_url":"https://api.github.com/users/sp193/gists{/gist_id}","starred_url":"https://api.github.com/users/sp193/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sp193/subscriptions","organizations_url":"https://api.github.com/users/sp193/orgs","repos_url":"https://api.github.com/users/sp193/repos","events_url":"https://api.github.com/users/sp193/events{/privacy}","received_events_url":"https://api.github.com/users/sp193/received_events","type":"User","site_admin":false},"created_at":"2017-05-08T13:16:11Z","updated_at":"2017-05-08T13:16:11Z","body":"It appears that the code is already doing a valid check on whether iManufacturer and iProduct do exist. There may be a mistake in [this line](https://github.com/ps2dev/ps2sdk/blob/master/iop/usb/keyboard/src/ps2kbd.c#L362), whereby the language value is set to 0 instead of 0x0409 (English). Can you try this instead?\r\n\r\nI haven't read the full USB specifications, but the few pages that I read about reading a string descriptor indicate that a language should be specified in wIndex."}}
{"actor":{"display_login":"sp193"}}