{"action":"created","issue":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1963","repository_url":"https://api.github.com/repos/MvvmCross/MvvmCross","labels_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1963/labels{/name}","comments_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1963/comments","events_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1963/events","html_url":"https://github.com/MvvmCross/MvvmCross/pull/1963","id":236496970,"number":1963,"title":"#1921 Changed wpf implementation to use view model parameter sent wit…","user":{"login":"Bowman74","id":4380198,"avatar_url":"https://avatars0.githubusercontent.com/u/4380198?v=3","gravatar_id":"","url":"https://api.github.com/users/Bowman74","html_url":"https://github.com/Bowman74","followers_url":"https://api.github.com/users/Bowman74/followers","following_url":"https://api.github.com/users/Bowman74/following{/other_user}","gists_url":"https://api.github.com/users/Bowman74/gists{/gist_id}","starred_url":"https://api.github.com/users/Bowman74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bowman74/subscriptions","organizations_url":"https://api.github.com/users/Bowman74/orgs","repos_url":"https://api.github.com/users/Bowman74/repos","events_url":"https://api.github.com/users/Bowman74/events{/privacy}","received_events_url":"https://api.github.com/users/Bowman74/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-16T14:19:58Z","updated_at":"2017-06-16T16:01:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/1963","html_url":"https://github.com/MvvmCross/MvvmCross/pull/1963","diff_url":"https://github.com/MvvmCross/MvvmCross/pull/1963.diff","patch_url":"https://github.com/MvvmCross/MvvmCross/pull/1963.patch"},"body":"…h request by new navigation service. Updated wfp event hooks sample application to be more complete.\r\n\r\n## :sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)\r\nBug Fix\r\n\r\n## :arrow_heading_down: What is the current behavior?\r\nWhen using the new navigation service the view model created with the request is ignored, instead the original ShowViewModel behavior is used creating a second view model ignoring the one from the request that has the parameter passed to it.\r\n\r\n## :new: What is the new behavior (if this is a feature change)?\r\nOnly one view model is created when the new navigation service is used and the parameter properly passed to it.\r\n\r\n## :boom: Does this PR introduce a breaking change?\r\nNo\r\n\r\n## :bug: Recommendations for testing\r\nTest in a variety of scenarios for navigation. I tested about three of the many possible scenarios\r\n\r\n## :memo: Links to relevant issues/docs\r\n#1921, #1943 \r\n\r\n## :thinking: Checklist before submitting\r\n\r\n- [x] All projects build\r\n- [ ] Follows style guide lines ([code style guide](https://github.com/MvvmCross/MvvmCross#code-style-guidelines))\r\n- [ ] Relevant documentation was updated ([docs style guide](https://www.mvvmcross.com/documentation/contribute/mvvmcross-docs-style-guide))\r\n- [ ] Nuspec files were updated (when applicable)\r\n- [ ] Rebased onto current develop"},"comment":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/comments/309065470","html_url":"https://github.com/MvvmCross/MvvmCross/pull/1963#issuecomment-309065470","issue_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1963","id":309065470,"user":{"login":"nickrandolph","id":1614057,"avatar_url":"https://avatars1.githubusercontent.com/u/1614057?v=3","gravatar_id":"","url":"https://api.github.com/users/nickrandolph","html_url":"https://github.com/nickrandolph","followers_url":"https://api.github.com/users/nickrandolph/followers","following_url":"https://api.github.com/users/nickrandolph/following{/other_user}","gists_url":"https://api.github.com/users/nickrandolph/gists{/gist_id}","starred_url":"https://api.github.com/users/nickrandolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickrandolph/subscriptions","organizations_url":"https://api.github.com/users/nickrandolph/orgs","repos_url":"https://api.github.com/users/nickrandolph/repos","events_url":"https://api.github.com/users/nickrandolph/events{/privacy}","received_events_url":"https://api.github.com/users/nickrandolph/received_events","type":"User","site_admin":false},"created_at":"2017-06-16T16:01:38Z","updated_at":"2017-06-16T16:01:38Z","body":"Yep fair enough. I didn't have time to do a full test on that suggestion (hence no pull request). \r\n\r\nThis issue is actually pretty severe as it is completely screwing up navigation on Forms using Master Details. You can see this if you attempt to navigate to a different view model from one of the details view models in the forms master-detail sample project"}}
{"actor":{"display_login":"nickrandolph"}}