{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/vic/issues/6949","repository_url":"https://api.github.com/repos/vmware/vic","labels_url":"https://api.github.com/repos/vmware/vic/issues/6949/labels{/name}","comments_url":"https://api.github.com/repos/vmware/vic/issues/6949/comments","events_url":"https://api.github.com/repos/vmware/vic/issues/6949/events","html_url":"https://github.com/vmware/vic/pull/6949","id":281576221,"number":6949,"title":"Ensure that only a single session is constructed for each VCH Management API requet [specific ci=Group23-VIC-Machine-Service]","user":{"login":"zjs","id":408880,"avatar_url":"https://avatars2.githubusercontent.com/u/408880?v=4","gravatar_id":"","url":"https://api.github.com/users/zjs","html_url":"https://github.com/zjs","followers_url":"https://api.github.com/users/zjs/followers","following_url":"https://api.github.com/users/zjs/following{/other_user}","gists_url":"https://api.github.com/users/zjs/gists{/gist_id}","starred_url":"https://api.github.com/users/zjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjs/subscriptions","organizations_url":"https://api.github.com/users/zjs/orgs","repos_url":"https://api.github.com/users/zjs/repos","events_url":"https://api.github.com/users/zjs/events{/privacy}","received_events_url":"https://api.github.com/users/zjs/received_events","type":"User","site_admin":false},"labels":[{"id":353174341,"url":"https://api.github.com/repos/vmware/vic/labels/cla-not-required","name":"cla-not-required","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":{"login":"zjs","id":408880,"avatar_url":"https://avatars2.githubusercontent.com/u/408880?v=4","gravatar_id":"","url":"https://api.github.com/users/zjs","html_url":"https://github.com/zjs","followers_url":"https://api.github.com/users/zjs/followers","following_url":"https://api.github.com/users/zjs/following{/other_user}","gists_url":"https://api.github.com/users/zjs/gists{/gist_id}","starred_url":"https://api.github.com/users/zjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjs/subscriptions","organizations_url":"https://api.github.com/users/zjs/orgs","repos_url":"https://api.github.com/users/zjs/repos","events_url":"https://api.github.com/users/zjs/events{/privacy}","received_events_url":"https://api.github.com/users/zjs/received_events","type":"User","site_admin":false},"assignees":[{"login":"zjs","id":408880,"avatar_url":"https://avatars2.githubusercontent.com/u/408880?v=4","gravatar_id":"","url":"https://api.github.com/users/zjs","html_url":"https://github.com/zjs","followers_url":"https://api.github.com/users/zjs/followers","following_url":"https://api.github.com/users/zjs/following{/other_user}","gists_url":"https://api.github.com/users/zjs/gists{/gist_id}","starred_url":"https://api.github.com/users/zjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjs/subscriptions","organizations_url":"https://api.github.com/users/zjs/orgs","repos_url":"https://api.github.com/users/zjs/repos","events_url":"https://api.github.com/users/zjs/events{/privacy}","received_events_url":"https://api.github.com/users/zjs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-12-12T23:41:13Z","updated_at":"2017-12-13T14:41:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/6949","html_url":"https://github.com/vmware/vic/pull/6949","diff_url":"https://github.com/vmware/vic/pull/6949.diff","patch_url":"https://github.com/vmware/vic/pull/6949.patch"},"body":"The VCH Management API supports two authentication mechanisms:\r\n1. Basic authentication with a username and password.\r\n2. Ticket-based authentication using a session ticket.\r\n\r\nOne limitation of ticket-based authentication, which is used by the vSphere H5 Client Plugin, is that a session ticket may only be used once.\r\n\r\nPrior to this series, we created two sessions as a part of handling datacenter-scoped API requests: one un-scoped session to resolve and validate the supplied datacenter, and one datacenter-scoped session to actually handle the request.\r\n\r\nThis pattern worked fine for basic authentication, but not for ticket-based authentication.\r\n\r\nTo correct this mostly involves refactoring of handler code, followed by a commit to eliminate the use of two validators (f274cde).\r\n\r\nTwo test cases are introduced for session-based authentication to un-scoped and datacenter-scoped requests (749058a). Additionally, the datacenter-scoped list and create APIs were manually exercised using ticket-based authentication.\r\n\r\nFixes #6947 \r\n\r\n---\r\n\r\nNote: I have broken this fix into a series of small (atomic?) commits. It may be easier to understand by reading commit-by-commit instead of attempting to understand the entire change at once."},"comment":{"url":"https://api.github.com/repos/vmware/vic/issues/comments/351410355","html_url":"https://github.com/vmware/vic/pull/6949#issuecomment-351410355","issue_url":"https://api.github.com/repos/vmware/vic/issues/6949","id":351410355,"user":{"login":"andrewtchin","id":1649165,"avatar_url":"https://avatars2.githubusercontent.com/u/1649165?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewtchin","html_url":"https://github.com/andrewtchin","followers_url":"https://api.github.com/users/andrewtchin/followers","following_url":"https://api.github.com/users/andrewtchin/following{/other_user}","gists_url":"https://api.github.com/users/andrewtchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtchin/subscriptions","organizations_url":"https://api.github.com/users/andrewtchin/orgs","repos_url":"https://api.github.com/users/andrewtchin/repos","events_url":"https://api.github.com/users/andrewtchin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtchin/received_events","type":"User","site_admin":false},"created_at":"2017-12-13T14:41:13Z","updated_at":"2017-12-13T14:41:13Z","author_association":"MEMBER","body":"should this be targeted to master then cherry picked to 1.3?"}}
{"actor":{"display_login":"andrewtchin"}}