{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/salopensource/gosal/pulls/9","id":133015620,"html_url":"https://github.com/salopensource/gosal/pull/9","diff_url":"https://github.com/salopensource/gosal/pull/9.diff","patch_url":"https://github.com/salopensource/gosal/pull/9.patch","issue_url":"https://api.github.com/repos/salopensource/gosal/issues/9","number":9,"state":"closed","locked":false,"title":"Refactor sal API client","user":{"login":"groob","id":1526945,"avatar_url":"https://avatars3.githubusercontent.com/u/1526945?v=4","gravatar_id":"","url":"https://api.github.com/users/groob","html_url":"https://github.com/groob","followers_url":"https://api.github.com/users/groob/followers","following_url":"https://api.github.com/users/groob/following{/other_user}","gists_url":"https://api.github.com/users/groob/gists{/gist_id}","starred_url":"https://api.github.com/users/groob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groob/subscriptions","organizations_url":"https://api.github.com/users/groob/orgs","repos_url":"https://api.github.com/users/groob/repos","events_url":"https://api.github.com/users/groob/events{/privacy}","received_events_url":"https://api.github.com/users/groob/received_events","type":"User","site_admin":false},"body":"Made the following changes and added tests:\r\nMight be a bit opinionated, but feedback welcome!\r\n\r\n```\r\n    refactor the API client and start handling errors\r\n\r\n    renamed package 'send' to 'sal'. The change makes it clearer that the library\r\n    is an API client. Introduced a method to create an API client like so:\r\n\r\n            config, err := sal.LoadConfig(path/to/conf.json)\r\n            client, err := sal.NewClient(config)\r\n\r\n    I also deleted the `utils` package because it only had one method, and the name\r\n    itself isn't very meaningful. I would avoid creating `utils` packages in go whenever possible\r\n    because they end up being a grab bag of random functions without a proper home and end up\r\n    being imported everywhere.\r\n\r\n    See https://www.goinggo.net/2017/02/design-philosophy-on-packaging.html\r\n```","created_at":"2017-07-28T17:26:32Z","updated_at":"2017-07-28T22:35:34Z","closed_at":"2017-07-28T22:35:34Z","merged_at":"2017-07-28T22:35:34Z","merge_commit_sha":"5fff0911131b720e6683bef3072e0afad0873255","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/salopensource/gosal/pulls/9/commits","review_comments_url":"https://api.github.com/repos/salopensource/gosal/pulls/9/comments","review_comment_url":"https://api.github.com/repos/salopensource/gosal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salopensource/gosal/issues/9/comments","statuses_url":"https://api.github.com/repos/salopensource/gosal/statuses/3b2af80569f08abe4a517a205e6ad3b362e9ec93","head":{"label":"groob:refactor_send","ref":"refactor_send","sha":"3b2af80569f08abe4a517a205e6ad3b362e9ec93","user":{"login":"groob","id":1526945,"avatar_url":"https://avatars3.githubusercontent.com/u/1526945?v=4","gravatar_id":"","url":"https://api.github.com/users/groob","html_url":"https://github.com/groob","followers_url":"https://api.github.com/users/groob/followers","following_url":"https://api.github.com/users/groob/following{/other_user}","gists_url":"https://api.github.com/users/groob/gists{/gist_id}","starred_url":"https://api.github.com/users/groob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groob/subscriptions","organizations_url":"https://api.github.com/users/groob/orgs","repos_url":"https://api.github.com/users/groob/repos","events_url":"https://api.github.com/users/groob/events{/privacy}","received_events_url":"https://api.github.com/users/groob/received_events","type":"User","site_admin":false},"repo":{"id":98665206,"name":"gosal","full_name":"groob/gosal","owner":{"login":"groob","id":1526945,"avatar_url":"https://avatars3.githubusercontent.com/u/1526945?v=4","gravatar_id":"","url":"https://api.github.com/users/groob","html_url":"https://github.com/groob","followers_url":"https://api.github.com/users/groob/followers","following_url":"https://api.github.com/users/groob/following{/other_user}","gists_url":"https://api.github.com/users/groob/gists{/gist_id}","starred_url":"https://api.github.com/users/groob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groob/subscriptions","organizations_url":"https://api.github.com/users/groob/orgs","repos_url":"https://api.github.com/users/groob/repos","events_url":"https://api.github.com/users/groob/events{/privacy}","received_events_url":"https://api.github.com/users/groob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/groob/gosal","description":"A Sal client written in Go","fork":true,"url":"https://api.github.com/repos/groob/gosal","forks_url":"https://api.github.com/repos/groob/gosal/forks","keys_url":"https://api.github.com/repos/groob/gosal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groob/gosal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groob/gosal/teams","hooks_url":"https://api.github.com/repos/groob/gosal/hooks","issue_events_url":"https://api.github.com/repos/groob/gosal/issues/events{/number}","events_url":"https://api.github.com/repos/groob/gosal/events","assignees_url":"https://api.github.com/repos/groob/gosal/assignees{/user}","branches_url":"https://api.github.com/repos/groob/gosal/branches{/branch}","tags_url":"https://api.github.com/repos/groob/gosal/tags","blobs_url":"https://api.github.com/repos/groob/gosal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groob/gosal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groob/gosal/git/refs{/sha}","trees_url":"https://api.github.com/repos/groob/gosal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groob/gosal/statuses/{sha}","languages_url":"https://api.github.com/repos/groob/gosal/languages","stargazers_url":"https://api.github.com/repos/groob/gosal/stargazers","contributors_url":"https://api.github.com/repos/groob/gosal/contributors","subscribers_url":"https://api.github.com/repos/groob/gosal/subscribers","subscription_url":"https://api.github.com/repos/groob/gosal/subscription","commits_url":"https://api.github.com/repos/groob/gosal/commits{/sha}","git_commits_url":"https://api.github.com/repos/groob/gosal/git/commits{/sha}","comments_url":"https://api.github.com/repos/groob/gosal/comments{/number}","issue_comment_url":"https://api.github.com/repos/groob/gosal/issues/comments{/number}","contents_url":"https://api.github.com/repos/groob/gosal/contents/{+path}","compare_url":"https://api.github.com/repos/groob/gosal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groob/gosal/merges","archive_url":"https://api.github.com/repos/groob/gosal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groob/gosal/downloads","issues_url":"https://api.github.com/repos/groob/gosal/issues{/number}","pulls_url":"https://api.github.com/repos/groob/gosal/pulls{/number}","milestones_url":"https://api.github.com/repos/groob/gosal/milestones{/number}","notifications_url":"https://api.github.com/repos/groob/gosal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groob/gosal/labels{/name}","releases_url":"https://api.github.com/repos/groob/gosal/releases{/id}","deployments_url":"https://api.github.com/repos/groob/gosal/deployments","created_at":"2017-07-28T15:56:07Z","updated_at":"2017-07-28T15:56:09Z","pushed_at":"2017-07-28T17:30:43Z","git_url":"git://github.com/groob/gosal.git","ssh_url":"git@github.com:groob/gosal.git","clone_url":"https://github.com/groob/gosal.git","svn_url":"https://github.com/groob/gosal","homepage":"","size":26,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"salopensource:master","ref":"master","sha":"8a97bde3cdfdb64248871b3199792c9be8cc8e08","user":{"login":"salopensource","id":12195555,"avatar_url":"https://avatars3.githubusercontent.com/u/12195555?v=4","gravatar_id":"","url":"https://api.github.com/users/salopensource","html_url":"https://github.com/salopensource","followers_url":"https://api.github.com/users/salopensource/followers","following_url":"https://api.github.com/users/salopensource/following{/other_user}","gists_url":"https://api.github.com/users/salopensource/gists{/gist_id}","starred_url":"https://api.github.com/users/salopensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salopensource/subscriptions","organizations_url":"https://api.github.com/users/salopensource/orgs","repos_url":"https://api.github.com/users/salopensource/repos","events_url":"https://api.github.com/users/salopensource/events{/privacy}","received_events_url":"https://api.github.com/users/salopensource/received_events","type":"Organization","site_admin":false},"repo":{"id":92109363,"name":"gosal","full_name":"salopensource/gosal","owner":{"login":"salopensource","id":12195555,"avatar_url":"https://avatars3.githubusercontent.com/u/12195555?v=4","gravatar_id":"","url":"https://api.github.com/users/salopensource","html_url":"https://github.com/salopensource","followers_url":"https://api.github.com/users/salopensource/followers","following_url":"https://api.github.com/users/salopensource/following{/other_user}","gists_url":"https://api.github.com/users/salopensource/gists{/gist_id}","starred_url":"https://api.github.com/users/salopensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salopensource/subscriptions","organizations_url":"https://api.github.com/users/salopensource/orgs","repos_url":"https://api.github.com/users/salopensource/repos","events_url":"https://api.github.com/users/salopensource/events{/privacy}","received_events_url":"https://api.github.com/users/salopensource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salopensource/gosal","description":"A Sal client written in Go","fork":false,"url":"https://api.github.com/repos/salopensource/gosal","forks_url":"https://api.github.com/repos/salopensource/gosal/forks","keys_url":"https://api.github.com/repos/salopensource/gosal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salopensource/gosal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salopensource/gosal/teams","hooks_url":"https://api.github.com/repos/salopensource/gosal/hooks","issue_events_url":"https://api.github.com/repos/salopensource/gosal/issues/events{/number}","events_url":"https://api.github.com/repos/salopensource/gosal/events","assignees_url":"https://api.github.com/repos/salopensource/gosal/assignees{/user}","branches_url":"https://api.github.com/repos/salopensource/gosal/branches{/branch}","tags_url":"https://api.github.com/repos/salopensource/gosal/tags","blobs_url":"https://api.github.com/repos/salopensource/gosal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salopensource/gosal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salopensource/gosal/git/refs{/sha}","trees_url":"https://api.github.com/repos/salopensource/gosal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salopensource/gosal/statuses/{sha}","languages_url":"https://api.github.com/repos/salopensource/gosal/languages","stargazers_url":"https://api.github.com/repos/salopensource/gosal/stargazers","contributors_url":"https://api.github.com/repos/salopensource/gosal/contributors","subscribers_url":"https://api.github.com/repos/salopensource/gosal/subscribers","subscription_url":"https://api.github.com/repos/salopensource/gosal/subscription","commits_url":"https://api.github.com/repos/salopensource/gosal/commits{/sha}","git_commits_url":"https://api.github.com/repos/salopensource/gosal/git/commits{/sha}","comments_url":"https://api.github.com/repos/salopensource/gosal/comments{/number}","issue_comment_url":"https://api.github.com/repos/salopensource/gosal/issues/comments{/number}","contents_url":"https://api.github.com/repos/salopensource/gosal/contents/{+path}","compare_url":"https://api.github.com/repos/salopensource/gosal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salopensource/gosal/merges","archive_url":"https://api.github.com/repos/salopensource/gosal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salopensource/gosal/downloads","issues_url":"https://api.github.com/repos/salopensource/gosal/issues{/number}","pulls_url":"https://api.github.com/repos/salopensource/gosal/pulls{/number}","milestones_url":"https://api.github.com/repos/salopensource/gosal/milestones{/number}","notifications_url":"https://api.github.com/repos/salopensource/gosal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salopensource/gosal/labels{/name}","releases_url":"https://api.github.com/repos/salopensource/gosal/releases{/id}","deployments_url":"https://api.github.com/repos/salopensource/gosal/deployments","created_at":"2017-05-22T23:48:12Z","updated_at":"2017-07-28T16:09:03Z","pushed_at":"2017-07-28T22:35:34Z","git_url":"git://github.com/salopensource/gosal.git","ssh_url":"git@github.com:salopensource/gosal.git","clone_url":"https://github.com/salopensource/gosal.git","svn_url":"https://github.com/salopensource/gosal","homepage":"","size":21,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salopensource/gosal/pulls/9"},"html":{"href":"https://github.com/salopensource/gosal/pull/9"},"issue":{"href":"https://api.github.com/repos/salopensource/gosal/issues/9"},"comments":{"href":"https://api.github.com/repos/salopensource/gosal/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/salopensource/gosal/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/salopensource/gosal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salopensource/gosal/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/salopensource/gosal/statuses/3b2af80569f08abe4a517a205e6ad3b362e9ec93"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bdemetris","id":7342160,"avatar_url":"https://avatars3.githubusercontent.com/u/7342160?v=4","gravatar_id":"","url":"https://api.github.com/users/bdemetris","html_url":"https://github.com/bdemetris","followers_url":"https://api.github.com/users/bdemetris/followers","following_url":"https://api.github.com/users/bdemetris/following{/other_user}","gists_url":"https://api.github.com/users/bdemetris/gists{/gist_id}","starred_url":"https://api.github.com/users/bdemetris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdemetris/subscriptions","organizations_url":"https://api.github.com/users/bdemetris/orgs","repos_url":"https://api.github.com/users/bdemetris/repos","events_url":"https://api.github.com/users/bdemetris/events{/privacy}","received_events_url":"https://api.github.com/users/bdemetris/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":199,"deletions":127,"changed_files":6}}
{"actor":{"display_login":"bdemetris"}}