{"action":"created","comment":{"url":"https://api.github.com/repos/hhslepicka/py4syn/pulls/comments/115100474","pull_request_review_id":36623708,"id":115100474,"diff_hunk":"@@ -104,7 +108,19 @@ def setCountTime(self, time):\n         self.timer = Timer(time + self.responseTimeout)\n \n     def getCountTime(self):\n-        return self.pvDxpTime.get()\n+        # AcquireTimes are the same\n+        return self.pvDxpAcquireTime[0].get()\n+\n+    def getRealTime(self):\n+        \"\"\"Return the Real Time\"\"\"\n+        if self.channels == 1:\n+            return self.pvDxpRealTime[1].get()","path":"py4syn/epics/DxpClass.py","position":29,"original_position":29,"commit_id":"a66271fb27de71533f972708b3cd3eddfb31f426","original_commit_id":"a66271fb27de71533f972708b3cd3eddfb31f426","user":{"login":"hhslepicka","id":8185425,"avatar_url":"https://avatars3.githubusercontent.com/u/8185425?v=3","gravatar_id":"","url":"https://api.github.com/users/hhslepicka","html_url":"https://github.com/hhslepicka","followers_url":"https://api.github.com/users/hhslepicka/followers","following_url":"https://api.github.com/users/hhslepicka/following{/other_user}","gists_url":"https://api.github.com/users/hhslepicka/gists{/gist_id}","starred_url":"https://api.github.com/users/hhslepicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhslepicka/subscriptions","organizations_url":"https://api.github.com/users/hhslepicka/orgs","repos_url":"https://api.github.com/users/hhslepicka/repos","events_url":"https://api.github.com/users/hhslepicka/events{/privacy}","received_events_url":"https://api.github.com/users/hhslepicka/received_events","type":"User","site_admin":false},"body":"Please define a constant for ```1``` to make the code more clear.","created_at":"2017-05-05T22:46:32Z","updated_at":"2017-05-05T22:46:55Z","html_url":"https://github.com/hhslepicka/py4syn/pull/25#discussion_r115100474","pull_request_url":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/hhslepicka/py4syn/pulls/comments/115100474"},"html":{"href":"https://github.com/hhslepicka/py4syn/pull/25#discussion_r115100474"},"pull_request":{"href":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25","id":119232829,"html_url":"https://github.com/hhslepicka/py4syn/pull/25","diff_url":"https://github.com/hhslepicka/py4syn/pull/25.diff","patch_url":"https://github.com/hhslepicka/py4syn/pull/25.patch","issue_url":"https://api.github.com/repos/hhslepicka/py4syn/issues/25","number":25,"state":"open","locked":false,"title":"Improve getTimes from DxpClass","user":{"login":"gabrielfedel","id":2080121,"avatar_url":"https://avatars2.githubusercontent.com/u/2080121?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielfedel","html_url":"https://github.com/gabrielfedel","followers_url":"https://api.github.com/users/gabrielfedel/followers","following_url":"https://api.github.com/users/gabrielfedel/following{/other_user}","gists_url":"https://api.github.com/users/gabrielfedel/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielfedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielfedel/subscriptions","organizations_url":"https://api.github.com/users/gabrielfedel/orgs","repos_url":"https://api.github.com/users/gabrielfedel/repos","events_url":"https://api.github.com/users/gabrielfedel/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielfedel/received_events","type":"User","site_admin":false},"body":"Fix the getCountTime and added getRealTime, where realTime = LiveTime + DeadTime","created_at":"2017-05-05T18:29:57Z","updated_at":"2017-05-05T22:46:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"758d2fac4dfb7baf5d3ebdab34d32e84e2ac7ebb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25/commits","review_comments_url":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25/comments","review_comment_url":"https://api.github.com/repos/hhslepicka/py4syn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhslepicka/py4syn/issues/25/comments","statuses_url":"https://api.github.com/repos/hhslepicka/py4syn/statuses/a66271fb27de71533f972708b3cd3eddfb31f426","head":{"label":"gabrielfedel:fixDxp2","ref":"fixDxp2","sha":"a66271fb27de71533f972708b3cd3eddfb31f426","user":{"login":"gabrielfedel","id":2080121,"avatar_url":"https://avatars2.githubusercontent.com/u/2080121?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielfedel","html_url":"https://github.com/gabrielfedel","followers_url":"https://api.github.com/users/gabrielfedel/followers","following_url":"https://api.github.com/users/gabrielfedel/following{/other_user}","gists_url":"https://api.github.com/users/gabrielfedel/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielfedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielfedel/subscriptions","organizations_url":"https://api.github.com/users/gabrielfedel/orgs","repos_url":"https://api.github.com/users/gabrielfedel/repos","events_url":"https://api.github.com/users/gabrielfedel/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielfedel/received_events","type":"User","site_admin":false},"repo":{"id":71381698,"name":"py4syn","full_name":"gabrielfedel/py4syn","owner":{"login":"gabrielfedel","id":2080121,"avatar_url":"https://avatars2.githubusercontent.com/u/2080121?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielfedel","html_url":"https://github.com/gabrielfedel","followers_url":"https://api.github.com/users/gabrielfedel/followers","following_url":"https://api.github.com/users/gabrielfedel/following{/other_user}","gists_url":"https://api.github.com/users/gabrielfedel/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielfedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielfedel/subscriptions","organizations_url":"https://api.github.com/users/gabrielfedel/orgs","repos_url":"https://api.github.com/users/gabrielfedel/repos","events_url":"https://api.github.com/users/gabrielfedel/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielfedel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabrielfedel/py4syn","description":"Python For Synchrotron","fork":true,"url":"https://api.github.com/repos/gabrielfedel/py4syn","forks_url":"https://api.github.com/repos/gabrielfedel/py4syn/forks","keys_url":"https://api.github.com/repos/gabrielfedel/py4syn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrielfedel/py4syn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrielfedel/py4syn/teams","hooks_url":"https://api.github.com/repos/gabrielfedel/py4syn/hooks","issue_events_url":"https://api.github.com/repos/gabrielfedel/py4syn/issues/events{/number}","events_url":"https://api.github.com/repos/gabrielfedel/py4syn/events","assignees_url":"https://api.github.com/repos/gabrielfedel/py4syn/assignees{/user}","branches_url":"https://api.github.com/repos/gabrielfedel/py4syn/branches{/branch}","tags_url":"https://api.github.com/repos/gabrielfedel/py4syn/tags","blobs_url":"https://api.github.com/repos/gabrielfedel/py4syn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrielfedel/py4syn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrielfedel/py4syn/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrielfedel/py4syn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrielfedel/py4syn/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrielfedel/py4syn/languages","stargazers_url":"https://api.github.com/repos/gabrielfedel/py4syn/stargazers","contributors_url":"https://api.github.com/repos/gabrielfedel/py4syn/contributors","subscribers_url":"https://api.github.com/repos/gabrielfedel/py4syn/subscribers","subscription_url":"https://api.github.com/repos/gabrielfedel/py4syn/subscription","commits_url":"https://api.github.com/repos/gabrielfedel/py4syn/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrielfedel/py4syn/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrielfedel/py4syn/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrielfedel/py4syn/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrielfedel/py4syn/contents/{+path}","compare_url":"https://api.github.com/repos/gabrielfedel/py4syn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrielfedel/py4syn/merges","archive_url":"https://api.github.com/repos/gabrielfedel/py4syn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrielfedel/py4syn/downloads","issues_url":"https://api.github.com/repos/gabrielfedel/py4syn/issues{/number}","pulls_url":"https://api.github.com/repos/gabrielfedel/py4syn/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrielfedel/py4syn/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrielfedel/py4syn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrielfedel/py4syn/labels{/name}","releases_url":"https://api.github.com/repos/gabrielfedel/py4syn/releases{/id}","deployments_url":"https://api.github.com/repos/gabrielfedel/py4syn/deployments","created_at":"2016-10-19T17:18:12Z","updated_at":"2016-11-01T15:32:35Z","pushed_at":"2017-05-05T20:46:08Z","git_url":"git://github.com/gabrielfedel/py4syn.git","ssh_url":"git@github.com:gabrielfedel/py4syn.git","clone_url":"https://github.com/gabrielfedel/py4syn.git","svn_url":"https://github.com/gabrielfedel/py4syn","homepage":null,"size":380,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hhslepicka:master","ref":"master","sha":"89b1c61bb3caf5063c22dd782b47ee946acd914a","user":{"login":"hhslepicka","id":8185425,"avatar_url":"https://avatars3.githubusercontent.com/u/8185425?v=3","gravatar_id":"","url":"https://api.github.com/users/hhslepicka","html_url":"https://github.com/hhslepicka","followers_url":"https://api.github.com/users/hhslepicka/followers","following_url":"https://api.github.com/users/hhslepicka/following{/other_user}","gists_url":"https://api.github.com/users/hhslepicka/gists{/gist_id}","starred_url":"https://api.github.com/users/hhslepicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhslepicka/subscriptions","organizations_url":"https://api.github.com/users/hhslepicka/orgs","repos_url":"https://api.github.com/users/hhslepicka/repos","events_url":"https://api.github.com/users/hhslepicka/events{/privacy}","received_events_url":"https://api.github.com/users/hhslepicka/received_events","type":"User","site_admin":false},"repo":{"id":37469334,"name":"py4syn","full_name":"hhslepicka/py4syn","owner":{"login":"hhslepicka","id":8185425,"avatar_url":"https://avatars3.githubusercontent.com/u/8185425?v=3","gravatar_id":"","url":"https://api.github.com/users/hhslepicka","html_url":"https://github.com/hhslepicka","followers_url":"https://api.github.com/users/hhslepicka/followers","following_url":"https://api.github.com/users/hhslepicka/following{/other_user}","gists_url":"https://api.github.com/users/hhslepicka/gists{/gist_id}","starred_url":"https://api.github.com/users/hhslepicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhslepicka/subscriptions","organizations_url":"https://api.github.com/users/hhslepicka/orgs","repos_url":"https://api.github.com/users/hhslepicka/repos","events_url":"https://api.github.com/users/hhslepicka/events{/privacy}","received_events_url":"https://api.github.com/users/hhslepicka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhslepicka/py4syn","description":"Python For Synchrotron","fork":false,"url":"https://api.github.com/repos/hhslepicka/py4syn","forks_url":"https://api.github.com/repos/hhslepicka/py4syn/forks","keys_url":"https://api.github.com/repos/hhslepicka/py4syn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhslepicka/py4syn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhslepicka/py4syn/teams","hooks_url":"https://api.github.com/repos/hhslepicka/py4syn/hooks","issue_events_url":"https://api.github.com/repos/hhslepicka/py4syn/issues/events{/number}","events_url":"https://api.github.com/repos/hhslepicka/py4syn/events","assignees_url":"https://api.github.com/repos/hhslepicka/py4syn/assignees{/user}","branches_url":"https://api.github.com/repos/hhslepicka/py4syn/branches{/branch}","tags_url":"https://api.github.com/repos/hhslepicka/py4syn/tags","blobs_url":"https://api.github.com/repos/hhslepicka/py4syn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhslepicka/py4syn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhslepicka/py4syn/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhslepicka/py4syn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhslepicka/py4syn/statuses/{sha}","languages_url":"https://api.github.com/repos/hhslepicka/py4syn/languages","stargazers_url":"https://api.github.com/repos/hhslepicka/py4syn/stargazers","contributors_url":"https://api.github.com/repos/hhslepicka/py4syn/contributors","subscribers_url":"https://api.github.com/repos/hhslepicka/py4syn/subscribers","subscription_url":"https://api.github.com/repos/hhslepicka/py4syn/subscription","commits_url":"https://api.github.com/repos/hhslepicka/py4syn/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhslepicka/py4syn/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhslepicka/py4syn/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhslepicka/py4syn/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhslepicka/py4syn/contents/{+path}","compare_url":"https://api.github.com/repos/hhslepicka/py4syn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhslepicka/py4syn/merges","archive_url":"https://api.github.com/repos/hhslepicka/py4syn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhslepicka/py4syn/downloads","issues_url":"https://api.github.com/repos/hhslepicka/py4syn/issues{/number}","pulls_url":"https://api.github.com/repos/hhslepicka/py4syn/pulls{/number}","milestones_url":"https://api.github.com/repos/hhslepicka/py4syn/milestones{/number}","notifications_url":"https://api.github.com/repos/hhslepicka/py4syn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhslepicka/py4syn/labels{/name}","releases_url":"https://api.github.com/repos/hhslepicka/py4syn/releases{/id}","deployments_url":"https://api.github.com/repos/hhslepicka/py4syn/deployments","created_at":"2015-06-15T14:14:08Z","updated_at":"2017-04-05T16:44:23Z","pushed_at":"2017-05-05T18:29:58Z","git_url":"git://github.com/hhslepicka/py4syn.git","ssh_url":"git@github.com:hhslepicka/py4syn.git","clone_url":"https://github.com/hhslepicka/py4syn.git","svn_url":"https://github.com/hhslepicka/py4syn","homepage":null,"size":403,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25"},"html":{"href":"https://github.com/hhslepicka/py4syn/pull/25"},"issue":{"href":"https://api.github.com/repos/hhslepicka/py4syn/issues/25"},"comments":{"href":"https://api.github.com/repos/hhslepicka/py4syn/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/hhslepicka/py4syn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhslepicka/py4syn/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/hhslepicka/py4syn/statuses/a66271fb27de71533f972708b3cd3eddfb31f426"}}}}
{"actor":{"display_login":"hhslepicka"}}