{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/107174025","pull_request_review_id":28129556,"id":107174025,"diff_hunk":"@@ -1387,9 +1394,25 @@ var FolderToolbarView = Backbone.View.extend({\n     '<strong>Choose the datasets to import:</strong>',\n     '<ul>',\n       '<% _.each(history_contents, function(history_item) { %>',\n-        '<li data-id=\"<%= _.escape(history_item.get(\"id\")) %>\">',\n-          '<input style=\"margin: 0;\" type=\"checkbox\"> <%= _.escape(history_item.get(\"hid\")) %>: <%= _.escape(history_item.get(\"name\")) %>',\n-        '</li>',\n+        '<% if (history_item.get(\"deleted\") != true ) { %>',\n+          '<% if (history_item.get(\"type\") === \"collection\") { %>',\n+              '<% var collection_type = history_item.get(\"collection_type\") %>',\n+              '<% if (collection_type === \"list\") { %>',\n+                '<li data-id=\"<%= _.escape(history_item.get(\"id\")) %>\" data-name=\"<%= _.escape(history_item.get(\"type\")) %>\">',\n+                  '<input style=\"margin: 0;\" type=\"checkbox\"> <%= _.escape(history_item.get(\"hid\")) %>: <%= _.escape(history_item.get(\"name\")) %> (Dataset Collection)',\n+                '</li>',\n+               '<% } else { %>',\n+                 '<li><input style=\"margin: 0;\" type=\"checkbox\" onclick=\"return false;\" disabled=\"disabled\">',\n+                   '<a title=\"You can convert this collection into a collection of type list using the Collection Tools\" href=\"\" onclick=\"return false;\" style=\"text-decoration: none\">',\n+                     '<%= _.escape(history_item.get(\"hid\")) %>: <%= _.escape(history_item.get(\"name\")) %> (Dataset Collection of type <%= _.escape(collection_type) %> not supported.)',\n+                  '</a></li>',\n+                '<% } %>',\n+          '<% } else if (history_item.get(\"visible\") === true && history_item.get(\"state\") === \"ok\") { %>',","path":"client/galaxy/scripts/mvc/library/library-foldertoolbar-view.js","position":null,"original_position":66,"commit_id":"7a6579878a09862e1cd5919ba7d94c527f3b0e56","original_commit_id":"75994c8816cdac0af80614db629553495dcb6bff","user":{"login":"mvdbeek","id":6804901,"avatar_url":"https://avatars2.githubusercontent.com/u/6804901?v=3","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"body":"@martenson filtering collection elements is happening here. I think it is more logical that you can only add datasets that are visible and whose state is ok. Otherwise in a history with large collections you'd have a huge amount of datasets to select. But I can certainly revert that if you prefer.","created_at":"2017-03-21T14:45:13Z","updated_at":"2017-03-21T14:45:13Z","html_url":"https://github.com/galaxyproject/galaxy/pull/3559#discussion_r107174025","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/107174025"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/3559#discussion_r107174025"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559","id":104657560,"html_url":"https://github.com/galaxyproject/galaxy/pull/3559","diff_url":"https://github.com/galaxyproject/galaxy/pull/3559.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/3559.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/3559","number":3559,"state":"open","locked":false,"title":"Add possibility to load collection into library","user":{"login":"mvdbeek","id":6804901,"avatar_url":"https://avatars2.githubusercontent.com/u/6804901?v=3","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"body":"and to conserve element_identifier.\r\n\r\nThe idea here is to simply add all hdas of a collection of collection_type `list` into a folder,\r\nwhile passing along the element_identifier so that the created LDDA has the element_identifier as its name.\r\nI have limited this to flat collections, since there are quite some choices to be made regarding the organization and naming of nested and/or paired collections. The new unzip/flatten collection tools can be used to create a flattened collection and transfer that one to the library.\r\n\r\nA bunch of tests are included that test the creation of library/folder items via HDAs and HDCAs,\r\nand a test that checks that the security checking works correctly after refactoring the Exception handling and moving the shared code in the FolderContentsController and LibraryContentsController into the UsesLibraryMixinItems.\r\n\r\n\r\nI'm putting it out there so @martenson can stop me early if this would block future plans of supporting full scale collections in the library.","created_at":"2017-02-04T10:47:26Z","updated_at":"2017-03-21T14:45:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22150c357721c0fe3a3413bc5a39125b3369624a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/7","html_url":"https://github.com/galaxyproject/galaxy/milestone/7","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/7/labels","id":2244335,"number":7,"title":"17.05","description":"Tentative freeze date for Galaxy 17.05 release","creator":{"login":"martenson","id":1814954,"avatar_url":"https://avatars1.githubusercontent.com/u/1814954?v=3","gravatar_id":"","url":"https://api.github.com/users/martenson","html_url":"https://github.com/martenson","followers_url":"https://api.github.com/users/martenson/followers","following_url":"https://api.github.com/users/martenson/following{/other_user}","gists_url":"https://api.github.com/users/martenson/gists{/gist_id}","starred_url":"https://api.github.com/users/martenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martenson/subscriptions","organizations_url":"https://api.github.com/users/martenson/orgs","repos_url":"https://api.github.com/users/martenson/repos","events_url":"https://api.github.com/users/martenson/events{/privacy}","received_events_url":"https://api.github.com/users/martenson/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":142,"state":"open","created_at":"2017-01-11T16:07:03Z","updated_at":"2017-03-21T13:56:17Z","due_on":"2017-05-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/3559/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/7a6579878a09862e1cd5919ba7d94c527f3b0e56","head":{"label":"mvdbeek:add_hdca_to_library","ref":"add_hdca_to_library","sha":"7a6579878a09862e1cd5919ba7d94c527f3b0e56","user":{"login":"mvdbeek","id":6804901,"avatar_url":"https://avatars2.githubusercontent.com/u/6804901?v=3","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"repo":{"id":38568566,"name":"galaxy","full_name":"mvdbeek/galaxy","owner":{"login":"mvdbeek","id":6804901,"avatar_url":"https://avatars2.githubusercontent.com/u/6804901?v=3","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvdbeek/galaxy","description":"Data intensive biology for everyone.","fork":true,"url":"https://api.github.com/repos/mvdbeek/galaxy","forks_url":"https://api.github.com/repos/mvdbeek/galaxy/forks","keys_url":"https://api.github.com/repos/mvdbeek/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvdbeek/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvdbeek/galaxy/teams","hooks_url":"https://api.github.com/repos/mvdbeek/galaxy/hooks","issue_events_url":"https://api.github.com/repos/mvdbeek/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/mvdbeek/galaxy/events","assignees_url":"https://api.github.com/repos/mvdbeek/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/mvdbeek/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/mvdbeek/galaxy/tags","blobs_url":"https://api.github.com/repos/mvdbeek/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvdbeek/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvdbeek/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvdbeek/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvdbeek/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mvdbeek/galaxy/languages","stargazers_url":"https://api.github.com/repos/mvdbeek/galaxy/stargazers","contributors_url":"https://api.github.com/repos/mvdbeek/galaxy/contributors","subscribers_url":"https://api.github.com/repos/mvdbeek/galaxy/subscribers","subscription_url":"https://api.github.com/repos/mvdbeek/galaxy/subscription","commits_url":"https://api.github.com/repos/mvdbeek/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvdbeek/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvdbeek/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvdbeek/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvdbeek/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/mvdbeek/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvdbeek/galaxy/merges","archive_url":"https://api.github.com/repos/mvdbeek/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvdbeek/galaxy/downloads","issues_url":"https://api.github.com/repos/mvdbeek/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/mvdbeek/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mvdbeek/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mvdbeek/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvdbeek/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/mvdbeek/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/mvdbeek/galaxy/deployments","created_at":"2015-07-05T12:40:16Z","updated_at":"2016-01-14T19:06:53Z","pushed_at":"2017-03-21T14:42:02Z","git_url":"git://github.com/mvdbeek/galaxy.git","ssh_url":"git@github.com:mvdbeek/galaxy.git","clone_url":"https://github.com/mvdbeek/galaxy.git","svn_url":"https://github.com/mvdbeek/galaxy","homepage":"http://galaxyproject.org/","size":200125,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"c952f1be33602fe23d0107c351e3305bf310fceb","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars0.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars0.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2017-03-20T15:02:10Z","pushed_at":"2017-03-21T14:42:06Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":205545,"stargazers_count":246,"watchers_count":246,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":313,"mirror_url":null,"open_issues_count":697,"forks":313,"open_issues":697,"watchers":246,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/3559"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/3559"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/3559/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/3559/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/7a6579878a09862e1cd5919ba7d94c527f3b0e56"}}}}
{"actor":{"display_login":"mvdbeek"}}