{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/Loopring/protocol/pulls/27","id":144833255,"html_url":"https://github.com/Loopring/protocol/pull/27","diff_url":"https://github.com/Loopring/protocol/pull/27.diff","patch_url":"https://github.com/Loopring/protocol/pull/27.patch","issue_url":"https://api.github.com/repos/Loopring/protocol/issues/27","number":27,"state":"closed","locked":false,"title":"fix tsc errors on bignumber.js","user":{"login":"jonasshen","id":6257898,"avatar_url":"https://avatars1.githubusercontent.com/u/6257898?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasshen","html_url":"https://github.com/jonasshen","followers_url":"https://api.github.com/users/jonasshen/followers","following_url":"https://api.github.com/users/jonasshen/following{/other_user}","gists_url":"https://api.github.com/users/jonasshen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasshen/subscriptions","organizations_url":"https://api.github.com/users/jonasshen/orgs","repos_url":"https://api.github.com/users/jonasshen/repos","events_url":"https://api.github.com/users/jonasshen/events{/privacy}","received_events_url":"https://api.github.com/users/jonasshen/received_events","type":"User","site_admin":false},"body":"Hi, I got some typescript compile errors. It was be caused by the dependency upgrade of `bignumber.js`. The file `bignumber.d.ts` was added to the latest version of `bignumber.js`. Now it's a typescript module.","created_at":"2017-10-05T05:45:46Z","updated_at":"2017-10-05T21:51:09Z","closed_at":"2017-10-05T21:51:09Z","merged_at":"2017-10-05T21:51:09Z","merge_commit_sha":"00ac53f859e6d0812dc1e736f292e8e277e8ae98","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Loopring/protocol/pulls/27/commits","review_comments_url":"https://api.github.com/repos/Loopring/protocol/pulls/27/comments","review_comment_url":"https://api.github.com/repos/Loopring/protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Loopring/protocol/issues/27/comments","statuses_url":"https://api.github.com/repos/Loopring/protocol/statuses/97ca993859b29791920c40c2ae5bcdade6a5fca6","head":{"label":"jonasshen:master","ref":"master","sha":"97ca993859b29791920c40c2ae5bcdade6a5fca6","user":{"login":"jonasshen","id":6257898,"avatar_url":"https://avatars1.githubusercontent.com/u/6257898?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasshen","html_url":"https://github.com/jonasshen","followers_url":"https://api.github.com/users/jonasshen/followers","following_url":"https://api.github.com/users/jonasshen/following{/other_user}","gists_url":"https://api.github.com/users/jonasshen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasshen/subscriptions","organizations_url":"https://api.github.com/users/jonasshen/orgs","repos_url":"https://api.github.com/users/jonasshen/repos","events_url":"https://api.github.com/users/jonasshen/events{/privacy}","received_events_url":"https://api.github.com/users/jonasshen/received_events","type":"User","site_admin":false},"repo":{"id":105849195,"name":"protocol","full_name":"jonasshen/protocol","owner":{"login":"jonasshen","id":6257898,"avatar_url":"https://avatars1.githubusercontent.com/u/6257898?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasshen","html_url":"https://github.com/jonasshen","followers_url":"https://api.github.com/users/jonasshen/followers","following_url":"https://api.github.com/users/jonasshen/following{/other_user}","gists_url":"https://api.github.com/users/jonasshen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasshen/subscriptions","organizations_url":"https://api.github.com/users/jonasshen/orgs","repos_url":"https://api.github.com/users/jonasshen/repos","events_url":"https://api.github.com/users/jonasshen/events{/privacy}","received_events_url":"https://api.github.com/users/jonasshen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonasshen/protocol","description":"Loopring Protocol Smart Contract","fork":true,"url":"https://api.github.com/repos/jonasshen/protocol","forks_url":"https://api.github.com/repos/jonasshen/protocol/forks","keys_url":"https://api.github.com/repos/jonasshen/protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonasshen/protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonasshen/protocol/teams","hooks_url":"https://api.github.com/repos/jonasshen/protocol/hooks","issue_events_url":"https://api.github.com/repos/jonasshen/protocol/issues/events{/number}","events_url":"https://api.github.com/repos/jonasshen/protocol/events","assignees_url":"https://api.github.com/repos/jonasshen/protocol/assignees{/user}","branches_url":"https://api.github.com/repos/jonasshen/protocol/branches{/branch}","tags_url":"https://api.github.com/repos/jonasshen/protocol/tags","blobs_url":"https://api.github.com/repos/jonasshen/protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonasshen/protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonasshen/protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonasshen/protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonasshen/protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/jonasshen/protocol/languages","stargazers_url":"https://api.github.com/repos/jonasshen/protocol/stargazers","contributors_url":"https://api.github.com/repos/jonasshen/protocol/contributors","subscribers_url":"https://api.github.com/repos/jonasshen/protocol/subscribers","subscription_url":"https://api.github.com/repos/jonasshen/protocol/subscription","commits_url":"https://api.github.com/repos/jonasshen/protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonasshen/protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonasshen/protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonasshen/protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonasshen/protocol/contents/{+path}","compare_url":"https://api.github.com/repos/jonasshen/protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonasshen/protocol/merges","archive_url":"https://api.github.com/repos/jonasshen/protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonasshen/protocol/downloads","issues_url":"https://api.github.com/repos/jonasshen/protocol/issues{/number}","pulls_url":"https://api.github.com/repos/jonasshen/protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/jonasshen/protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/jonasshen/protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonasshen/protocol/labels{/name}","releases_url":"https://api.github.com/repos/jonasshen/protocol/releases{/id}","deployments_url":"https://api.github.com/repos/jonasshen/protocol/deployments","created_at":"2017-10-05T04:27:12Z","updated_at":"2017-10-05T04:27:14Z","pushed_at":"2017-10-05T07:09:04Z","git_url":"git://github.com/jonasshen/protocol.git","ssh_url":"git@github.com:jonasshen/protocol.git","clone_url":"https://github.com/jonasshen/protocol.git","svn_url":"https://github.com/jonasshen/protocol","homepage":"https://docs.loopring.org/protocol","size":174,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Loopring:master","ref":"master","sha":"f8eb5ac3525ce05820d4e656330c6b2cbd41f18d","user":{"login":"Loopring","id":29633125,"avatar_url":"https://avatars0.githubusercontent.com/u/29633125?v=4","gravatar_id":"","url":"https://api.github.com/users/Loopring","html_url":"https://github.com/Loopring","followers_url":"https://api.github.com/users/Loopring/followers","following_url":"https://api.github.com/users/Loopring/following{/other_user}","gists_url":"https://api.github.com/users/Loopring/gists{/gist_id}","starred_url":"https://api.github.com/users/Loopring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Loopring/subscriptions","organizations_url":"https://api.github.com/users/Loopring/orgs","repos_url":"https://api.github.com/users/Loopring/repos","events_url":"https://api.github.com/users/Loopring/events{/privacy}","received_events_url":"https://api.github.com/users/Loopring/received_events","type":"Organization","site_admin":false},"repo":{"id":101029595,"name":"protocol","full_name":"Loopring/protocol","owner":{"login":"Loopring","id":29633125,"avatar_url":"https://avatars0.githubusercontent.com/u/29633125?v=4","gravatar_id":"","url":"https://api.github.com/users/Loopring","html_url":"https://github.com/Loopring","followers_url":"https://api.github.com/users/Loopring/followers","following_url":"https://api.github.com/users/Loopring/following{/other_user}","gists_url":"https://api.github.com/users/Loopring/gists{/gist_id}","starred_url":"https://api.github.com/users/Loopring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Loopring/subscriptions","organizations_url":"https://api.github.com/users/Loopring/orgs","repos_url":"https://api.github.com/users/Loopring/repos","events_url":"https://api.github.com/users/Loopring/events{/privacy}","received_events_url":"https://api.github.com/users/Loopring/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Loopring/protocol","description":"Loopring Protocol Smart Contract","fork":false,"url":"https://api.github.com/repos/Loopring/protocol","forks_url":"https://api.github.com/repos/Loopring/protocol/forks","keys_url":"https://api.github.com/repos/Loopring/protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Loopring/protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Loopring/protocol/teams","hooks_url":"https://api.github.com/repos/Loopring/protocol/hooks","issue_events_url":"https://api.github.com/repos/Loopring/protocol/issues/events{/number}","events_url":"https://api.github.com/repos/Loopring/protocol/events","assignees_url":"https://api.github.com/repos/Loopring/protocol/assignees{/user}","branches_url":"https://api.github.com/repos/Loopring/protocol/branches{/branch}","tags_url":"https://api.github.com/repos/Loopring/protocol/tags","blobs_url":"https://api.github.com/repos/Loopring/protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Loopring/protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Loopring/protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/Loopring/protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Loopring/protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/Loopring/protocol/languages","stargazers_url":"https://api.github.com/repos/Loopring/protocol/stargazers","contributors_url":"https://api.github.com/repos/Loopring/protocol/contributors","subscribers_url":"https://api.github.com/repos/Loopring/protocol/subscribers","subscription_url":"https://api.github.com/repos/Loopring/protocol/subscription","commits_url":"https://api.github.com/repos/Loopring/protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/Loopring/protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/Loopring/protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/Loopring/protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/Loopring/protocol/contents/{+path}","compare_url":"https://api.github.com/repos/Loopring/protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Loopring/protocol/merges","archive_url":"https://api.github.com/repos/Loopring/protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Loopring/protocol/downloads","issues_url":"https://api.github.com/repos/Loopring/protocol/issues{/number}","pulls_url":"https://api.github.com/repos/Loopring/protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/Loopring/protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/Loopring/protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Loopring/protocol/labels{/name}","releases_url":"https://api.github.com/repos/Loopring/protocol/releases{/id}","deployments_url":"https://api.github.com/repos/Loopring/protocol/deployments","created_at":"2017-08-22T06:34:28Z","updated_at":"2017-10-05T10:20:01Z","pushed_at":"2017-10-05T21:51:08Z","git_url":"git://github.com/Loopring/protocol.git","ssh_url":"git@github.com:Loopring/protocol.git","clone_url":"https://github.com/Loopring/protocol.git","svn_url":"https://github.com/Loopring/protocol","homepage":"https://docs.loopring.org/protocol","size":171,"stargazers_count":30,"watchers_count":30,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Loopring/protocol/pulls/27"},"html":{"href":"https://github.com/Loopring/protocol/pull/27"},"issue":{"href":"https://api.github.com/repos/Loopring/protocol/issues/27"},"comments":{"href":"https://api.github.com/repos/Loopring/protocol/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/Loopring/protocol/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/Loopring/protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Loopring/protocol/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/Loopring/protocol/statuses/97ca993859b29791920c40c2ae5bcdade6a5fca6"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dong77","id":1710087,"avatar_url":"https://avatars0.githubusercontent.com/u/1710087?v=4","gravatar_id":"","url":"https://api.github.com/users/dong77","html_url":"https://github.com/dong77","followers_url":"https://api.github.com/users/dong77/followers","following_url":"https://api.github.com/users/dong77/following{/other_user}","gists_url":"https://api.github.com/users/dong77/gists{/gist_id}","starred_url":"https://api.github.com/users/dong77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dong77/subscriptions","organizations_url":"https://api.github.com/users/dong77/orgs","repos_url":"https://api.github.com/users/dong77/repos","events_url":"https://api.github.com/users/dong77/events{/privacy}","received_events_url":"https://api.github.com/users/dong77/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":10,"deletions":10,"changed_files":6}}
{"actor":{"display_login":"dong77"}}