{"action":"created","comment":{"url":"https://api.github.com/repos/golang/dep/pulls/comments/116553966","pull_request_review_id":38183687,"id":116553966,"diff_hunk":"@@ -67,8 +67,13 @@ func validateManifest(s string) ([]error, error) {\n \t\t\t\t\tfor key, value := range v.(map[string]interface{}) {\n \t\t\t\t\t\t// Check if the key is valid\n \t\t\t\t\t\tswitch key {\n-\t\t\t\t\t\tcase \"name\", \"branch\", \"revision\", \"version\", \"source\":\n+\t\t\t\t\t\tcase \"name\", \"branch\", \"version\", \"source\":\n \t\t\t\t\t\t\t// valid key\n+\t\t\t\t\t\tcase \"revision\":\n+\t\t\t\t\t\t\t// Check if sha1 hash is abbreviated\n+\t\t\t\t\t\t\tif valueStr, ok := value.(string); ok && len(valueStr) < 40 {","path":"manifest.go","position":9,"original_position":9,"commit_id":"5ef510eac4ceb82cb44e3d435b372c154faaffc8","original_commit_id":"5ef510eac4ceb82cb44e3d435b372c154faaffc8","user":{"login":"carolynvs","id":1368985,"avatar_url":"https://avatars2.githubusercontent.com/u/1368985?v=3","gravatar_id":"","url":"https://api.github.com/users/carolynvs","html_url":"https://github.com/carolynvs","followers_url":"https://api.github.com/users/carolynvs/followers","following_url":"https://api.github.com/users/carolynvs/following{/other_user}","gists_url":"https://api.github.com/users/carolynvs/gists{/gist_id}","starred_url":"https://api.github.com/users/carolynvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolynvs/subscriptions","organizations_url":"https://api.github.com/users/carolynvs/orgs","repos_url":"https://api.github.com/users/carolynvs/repos","events_url":"https://api.github.com/users/carolynvs/events{/privacy}","received_events_url":"https://api.github.com/users/carolynvs/received_events","type":"User","site_admin":false},"body":"Pretty sure it's a revision-id, see https://github.com/golang/dep/blob/master/cmd/dep/ensure_test.go#L24 for what we are validating against in our tests. I think that's a revision-id, yeah?","created_at":"2017-05-15T17:37:19Z","updated_at":"2017-05-15T17:37:19Z","html_url":"https://github.com/golang/dep/pull/582#discussion_r116553966","pull_request_url":"https://api.github.com/repos/golang/dep/pulls/582","_links":{"self":{"href":"https://api.github.com/repos/golang/dep/pulls/comments/116553966"},"html":{"href":"https://github.com/golang/dep/pull/582#discussion_r116553966"},"pull_request":{"href":"https://api.github.com/repos/golang/dep/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/golang/dep/pulls/582","id":120543238,"html_url":"https://github.com/golang/dep/pull/582","diff_url":"https://github.com/golang/dep/pull/582.diff","patch_url":"https://github.com/golang/dep/pull/582.patch","issue_url":"https://api.github.com/repos/golang/dep/issues/582","number":582,"state":"open","locked":false,"title":"Warn on use of abbreviated sha1 commit hash","user":{"login":"zknill","id":6664336,"avatar_url":"https://avatars3.githubusercontent.com/u/6664336?v=3","gravatar_id":"","url":"https://api.github.com/users/zknill","html_url":"https://github.com/zknill","followers_url":"https://api.github.com/users/zknill/followers","following_url":"https://api.github.com/users/zknill/following{/other_user}","gists_url":"https://api.github.com/users/zknill/gists{/gist_id}","starred_url":"https://api.github.com/users/zknill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zknill/subscriptions","organizations_url":"https://api.github.com/users/zknill/orgs","repos_url":"https://api.github.com/users/zknill/repos","events_url":"https://api.github.com/users/zknill/events{/privacy}","received_events_url":"https://api.github.com/users/zknill/received_events","type":"User","site_admin":false},"body":"Update manifest validation to warn when an abbreviated version of a\r\nsha1 commit hash is used.\r\n\r\nAdd test for warn.\r\n\r\nFixes #567 ","created_at":"2017-05-15T07:56:05Z","updated_at":"2017-05-15T17:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ad16ff0d39dae577902943a0d32dbdd91d0e7b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/golang/dep/pulls/582/commits","review_comments_url":"https://api.github.com/repos/golang/dep/pulls/582/comments","review_comment_url":"https://api.github.com/repos/golang/dep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golang/dep/issues/582/comments","statuses_url":"https://api.github.com/repos/golang/dep/statuses/5ef510eac4ceb82cb44e3d435b372c154faaffc8","head":{"label":"zknill:warn-on-abbreviateed-sha1-hash","ref":"warn-on-abbreviateed-sha1-hash","sha":"5ef510eac4ceb82cb44e3d435b372c154faaffc8","user":{"login":"zknill","id":6664336,"avatar_url":"https://avatars3.githubusercontent.com/u/6664336?v=3","gravatar_id":"","url":"https://api.github.com/users/zknill","html_url":"https://github.com/zknill","followers_url":"https://api.github.com/users/zknill/followers","following_url":"https://api.github.com/users/zknill/following{/other_user}","gists_url":"https://api.github.com/users/zknill/gists{/gist_id}","starred_url":"https://api.github.com/users/zknill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zknill/subscriptions","organizations_url":"https://api.github.com/users/zknill/orgs","repos_url":"https://api.github.com/users/zknill/repos","events_url":"https://api.github.com/users/zknill/events{/privacy}","received_events_url":"https://api.github.com/users/zknill/received_events","type":"User","site_admin":false},"repo":{"id":91119768,"name":"dep","full_name":"zknill/dep","owner":{"login":"zknill","id":6664336,"avatar_url":"https://avatars3.githubusercontent.com/u/6664336?v=3","gravatar_id":"","url":"https://api.github.com/users/zknill","html_url":"https://github.com/zknill","followers_url":"https://api.github.com/users/zknill/followers","following_url":"https://api.github.com/users/zknill/following{/other_user}","gists_url":"https://api.github.com/users/zknill/gists{/gist_id}","starred_url":"https://api.github.com/users/zknill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zknill/subscriptions","organizations_url":"https://api.github.com/users/zknill/orgs","repos_url":"https://api.github.com/users/zknill/repos","events_url":"https://api.github.com/users/zknill/events{/privacy}","received_events_url":"https://api.github.com/users/zknill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zknill/dep","description":"Go dependency tool","fork":true,"url":"https://api.github.com/repos/zknill/dep","forks_url":"https://api.github.com/repos/zknill/dep/forks","keys_url":"https://api.github.com/repos/zknill/dep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zknill/dep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zknill/dep/teams","hooks_url":"https://api.github.com/repos/zknill/dep/hooks","issue_events_url":"https://api.github.com/repos/zknill/dep/issues/events{/number}","events_url":"https://api.github.com/repos/zknill/dep/events","assignees_url":"https://api.github.com/repos/zknill/dep/assignees{/user}","branches_url":"https://api.github.com/repos/zknill/dep/branches{/branch}","tags_url":"https://api.github.com/repos/zknill/dep/tags","blobs_url":"https://api.github.com/repos/zknill/dep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zknill/dep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zknill/dep/git/refs{/sha}","trees_url":"https://api.github.com/repos/zknill/dep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zknill/dep/statuses/{sha}","languages_url":"https://api.github.com/repos/zknill/dep/languages","stargazers_url":"https://api.github.com/repos/zknill/dep/stargazers","contributors_url":"https://api.github.com/repos/zknill/dep/contributors","subscribers_url":"https://api.github.com/repos/zknill/dep/subscribers","subscription_url":"https://api.github.com/repos/zknill/dep/subscription","commits_url":"https://api.github.com/repos/zknill/dep/commits{/sha}","git_commits_url":"https://api.github.com/repos/zknill/dep/git/commits{/sha}","comments_url":"https://api.github.com/repos/zknill/dep/comments{/number}","issue_comment_url":"https://api.github.com/repos/zknill/dep/issues/comments{/number}","contents_url":"https://api.github.com/repos/zknill/dep/contents/{+path}","compare_url":"https://api.github.com/repos/zknill/dep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zknill/dep/merges","archive_url":"https://api.github.com/repos/zknill/dep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zknill/dep/downloads","issues_url":"https://api.github.com/repos/zknill/dep/issues{/number}","pulls_url":"https://api.github.com/repos/zknill/dep/pulls{/number}","milestones_url":"https://api.github.com/repos/zknill/dep/milestones{/number}","notifications_url":"https://api.github.com/repos/zknill/dep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zknill/dep/labels{/name}","releases_url":"https://api.github.com/repos/zknill/dep/releases{/id}","deployments_url":"https://api.github.com/repos/zknill/dep/deployments","created_at":"2017-05-12T18:36:46Z","updated_at":"2017-05-12T18:36:48Z","pushed_at":"2017-05-15T07:53:35Z","git_url":"git://github.com/zknill/dep.git","ssh_url":"git@github.com:zknill/dep.git","clone_url":"https://github.com/zknill/dep.git","svn_url":"https://github.com/zknill/dep","homepage":null,"size":2395,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"golang:master","ref":"master","sha":"b86ad168229fbc57e8e4362d9a531493e52ebce8","user":{"login":"golang","id":4314092,"avatar_url":"https://avatars0.githubusercontent.com/u/4314092?v=3","gravatar_id":"","url":"https://api.github.com/users/golang","html_url":"https://github.com/golang","followers_url":"https://api.github.com/users/golang/followers","following_url":"https://api.github.com/users/golang/following{/other_user}","gists_url":"https://api.github.com/users/golang/gists{/gist_id}","starred_url":"https://api.github.com/users/golang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golang/subscriptions","organizations_url":"https://api.github.com/users/golang/orgs","repos_url":"https://api.github.com/users/golang/repos","events_url":"https://api.github.com/users/golang/events{/privacy}","received_events_url":"https://api.github.com/users/golang/received_events","type":"Organization","site_admin":false},"repo":{"id":70202506,"name":"dep","full_name":"golang/dep","owner":{"login":"golang","id":4314092,"avatar_url":"https://avatars0.githubusercontent.com/u/4314092?v=3","gravatar_id":"","url":"https://api.github.com/users/golang","html_url":"https://github.com/golang","followers_url":"https://api.github.com/users/golang/followers","following_url":"https://api.github.com/users/golang/following{/other_user}","gists_url":"https://api.github.com/users/golang/gists{/gist_id}","starred_url":"https://api.github.com/users/golang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golang/subscriptions","organizations_url":"https://api.github.com/users/golang/orgs","repos_url":"https://api.github.com/users/golang/repos","events_url":"https://api.github.com/users/golang/events{/privacy}","received_events_url":"https://api.github.com/users/golang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golang/dep","description":"Go dependency tool","fork":false,"url":"https://api.github.com/repos/golang/dep","forks_url":"https://api.github.com/repos/golang/dep/forks","keys_url":"https://api.github.com/repos/golang/dep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golang/dep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golang/dep/teams","hooks_url":"https://api.github.com/repos/golang/dep/hooks","issue_events_url":"https://api.github.com/repos/golang/dep/issues/events{/number}","events_url":"https://api.github.com/repos/golang/dep/events","assignees_url":"https://api.github.com/repos/golang/dep/assignees{/user}","branches_url":"https://api.github.com/repos/golang/dep/branches{/branch}","tags_url":"https://api.github.com/repos/golang/dep/tags","blobs_url":"https://api.github.com/repos/golang/dep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golang/dep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golang/dep/git/refs{/sha}","trees_url":"https://api.github.com/repos/golang/dep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golang/dep/statuses/{sha}","languages_url":"https://api.github.com/repos/golang/dep/languages","stargazers_url":"https://api.github.com/repos/golang/dep/stargazers","contributors_url":"https://api.github.com/repos/golang/dep/contributors","subscribers_url":"https://api.github.com/repos/golang/dep/subscribers","subscription_url":"https://api.github.com/repos/golang/dep/subscription","commits_url":"https://api.github.com/repos/golang/dep/commits{/sha}","git_commits_url":"https://api.github.com/repos/golang/dep/git/commits{/sha}","comments_url":"https://api.github.com/repos/golang/dep/comments{/number}","issue_comment_url":"https://api.github.com/repos/golang/dep/issues/comments{/number}","contents_url":"https://api.github.com/repos/golang/dep/contents/{+path}","compare_url":"https://api.github.com/repos/golang/dep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golang/dep/merges","archive_url":"https://api.github.com/repos/golang/dep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golang/dep/downloads","issues_url":"https://api.github.com/repos/golang/dep/issues{/number}","pulls_url":"https://api.github.com/repos/golang/dep/pulls{/number}","milestones_url":"https://api.github.com/repos/golang/dep/milestones{/number}","notifications_url":"https://api.github.com/repos/golang/dep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golang/dep/labels{/name}","releases_url":"https://api.github.com/repos/golang/dep/releases{/id}","deployments_url":"https://api.github.com/repos/golang/dep/deployments","created_at":"2016-10-07T00:04:51Z","updated_at":"2017-05-15T17:27:00Z","pushed_at":"2017-05-15T17:17:15Z","git_url":"git://github.com/golang/dep.git","ssh_url":"git@github.com:golang/dep.git","clone_url":"https://github.com/golang/dep.git","svn_url":"https://github.com/golang/dep","homepage":null,"size":2394,"stargazers_count":3047,"watchers_count":3047,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":152,"forks":139,"open_issues":152,"watchers":3047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/golang/dep/pulls/582"},"html":{"href":"https://github.com/golang/dep/pull/582"},"issue":{"href":"https://api.github.com/repos/golang/dep/issues/582"},"comments":{"href":"https://api.github.com/repos/golang/dep/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/golang/dep/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/golang/dep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golang/dep/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/golang/dep/statuses/5ef510eac4ceb82cb44e3d435b372c154faaffc8"}}}}
{"actor":{"display_login":"carolynvs"}}