{"action":"created","issue":{"url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/issues/54","repository_url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE","labels_url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/issues/54/comments","events_url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/issues/54/events","html_url":"https://github.com/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/pull/54","id":215910860,"number":54,"title":"Add cooldown to national value change","user":{"login":"ARR8","id":8064135,"avatar_url":"https://avatars3.githubusercontent.com/u/8064135?v=3","gravatar_id":"","url":"https://api.github.com/users/ARR8","html_url":"https://github.com/ARR8","followers_url":"https://api.github.com/users/ARR8/followers","following_url":"https://api.github.com/users/ARR8/following{/other_user}","gists_url":"https://api.github.com/users/ARR8/gists{/gist_id}","starred_url":"https://api.github.com/users/ARR8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARR8/subscriptions","organizations_url":"https://api.github.com/users/ARR8/orgs","repos_url":"https://api.github.com/users/ARR8/repos","events_url":"https://api.github.com/users/ARR8/events{/privacy}","received_events_url":"https://api.github.com/users/ARR8/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-21T23:37:53Z","updated_at":"2017-03-22T03:06:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/pulls/54","html_url":"https://github.com/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/pull/54","diff_url":"https://github.com/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/pull/54.diff","patch_url":"https://github.com/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/pull/54.patch"},"body":"I have noticed that the AI changes the country's national value whenever the pop majority ideology changes. However, this can change very quickly, especially for small nations where one event can add support for an issue for the whole country.\r\n\r\nIt seems to me that a fundamental shift in the important value of a country should have a cooldown. Ideally this would be generational, but given the abstract nature of the game, I set a preliminary value for four years, long enough for the political discourse of a country to change. I have also changed the text to give an explanation of what changing the national value would entail.\r\n  The cooldown uses the modifier used when switching tech schools, to block a nation from changing both, and the effects make sense, in my opinion.\r\n\r\nTo help issue #50, I have allowed countries to switch to order as a response to terrorism, to simulate the rise of the right in our day.\r\n\r\nIf you like these changes, do not merge the PR yet, but let me know and I will also add conditions for AI_will_do to all of these, to prevent, for example, dictatorships changing their national value to liberty."},"comment":{"url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/issues/comments/288285408","html_url":"https://github.com/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/pull/54#issuecomment-288285408","issue_url":"https://api.github.com/repos/settintotrieste/Victoria-2-Cold-War-Enhancement-Mod-CWE/issues/54","id":288285408,"user":{"login":"settintotrieste","id":24409479,"avatar_url":"https://avatars1.githubusercontent.com/u/24409479?v=3","gravatar_id":"","url":"https://api.github.com/users/settintotrieste","html_url":"https://github.com/settintotrieste","followers_url":"https://api.github.com/users/settintotrieste/followers","following_url":"https://api.github.com/users/settintotrieste/following{/other_user}","gists_url":"https://api.github.com/users/settintotrieste/gists{/gist_id}","starred_url":"https://api.github.com/users/settintotrieste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/settintotrieste/subscriptions","organizations_url":"https://api.github.com/users/settintotrieste/orgs","repos_url":"https://api.github.com/users/settintotrieste/repos","events_url":"https://api.github.com/users/settintotrieste/events{/privacy}","received_events_url":"https://api.github.com/users/settintotrieste/received_events","type":"User","site_admin":false},"created_at":"2017-03-22T03:06:38Z","updated_at":"2017-03-22T03:06:38Z","body":"I understand what you're saying however there is a problem with making the national value stay the same most of the time as many of the national values set for many of the countries in the base NWO that I used are just equality. So this was kind of a compromise solution to allow the countries to dynamically switch their national values along the way to simulate the changing values of nations throughout the 100 years of the game. An example would be the UK in real life where the national focus went from valuing order (empire days) to equality (1960-70s) to meritocracy (post 80s) then perhaps equality again today. \r\n\r\nBut in the meantime you can tie the change in government to change in NV and do the changes in the localisation."}}
{"actor":{"display_login":"settintotrieste"}}