{"action":"created","issue":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/697","repository_url":"https://api.github.com/repos/marmelab/admin-on-rest","labels_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/697/labels{/name}","comments_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/697/comments","events_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/697/events","html_url":"https://github.com/marmelab/admin-on-rest/pull/697","id":231139109,"number":697,"title":"[WIP] Feature embedded arrays","user":{"login":"MhdSyrwan","id":730201,"avatar_url":"https://avatars2.githubusercontent.com/u/730201?v=4","gravatar_id":"","url":"https://api.github.com/users/MhdSyrwan","html_url":"https://github.com/MhdSyrwan","followers_url":"https://api.github.com/users/MhdSyrwan/followers","following_url":"https://api.github.com/users/MhdSyrwan/following{/other_user}","gists_url":"https://api.github.com/users/MhdSyrwan/gists{/gist_id}","starred_url":"https://api.github.com/users/MhdSyrwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MhdSyrwan/subscriptions","organizations_url":"https://api.github.com/users/MhdSyrwan/orgs","repos_url":"https://api.github.com/users/MhdSyrwan/repos","events_url":"https://api.github.com/users/MhdSyrwan/events{/privacy}","received_events_url":"https://api.github.com/users/MhdSyrwan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2017-05-24T18:59:33Z","updated_at":"2017-07-25T12:40:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/697","html_url":"https://github.com/marmelab/admin-on-rest/pull/697","diff_url":"https://github.com/marmelab/admin-on-rest/pull/697.diff","patch_url":"https://github.com/marmelab/admin-on-rest/pull/697.patch"},"body":"Field Array Implementation based on RFC #695 \r\n\r\n- [x] Main Behavior Development.\r\n- [x] Changing Button Colors to blue (primary buttons).\r\n- [x] Changing name to `EmbeddedArrayInput`\r\n- [x] Renaming `elStyle` to `arrayElStyle`.\r\n- [x] Adding FormField-like rendering features.\r\n- [x] Writing Tests.\r\n- [x] Translation framework compatibility.\r\n- [x] Implement `EmbeddedArrayField`.\r\n\r\nNotes:\r\n\r\n- Currently I've set the default behavior is to show element as lines. User can change that by providing an `elStyle` attribute like `{display: 'inline-block'}`\r\n- I've tried to re-use `FormField` but I think we cannot since it uses the same source provided by the `input` meanwhile we need to prefix it by something like `array[index].` should i skip this? or edit the `FormField` to support prefixes ?\r\n- Proposed Alternative component names: `EmbeddedArrayInput` or just `ArrayInput`.\r\n- using `elStyle` to style each group might be confusing, should i use another name? any suggestions?\r\n\r\n## Current Component Example\r\n```jsx\r\n<EmbeddedManyInput source=\"links\"> <!-- Line by line -->\r\n    <TextInput source=\"url\" />\r\n    <TextInput source=\"context\"/>\r\n</EmbeddedManyInput>\r\n\r\n<EmbeddedManyInput source=\"links\" elStyle={{display: 'inline-block'}}> <!-- inline blocks (grid-like) -->\r\n    <TextInput source=\"url\" />\r\n    <TextInput source=\"context\"/>\r\n</EmbeddedManyInput>\r\n```"},"comment":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/comments/317724638","html_url":"https://github.com/marmelab/admin-on-rest/pull/697#issuecomment-317724638","issue_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/697","id":317724638,"user":{"login":"natrim","id":488136,"avatar_url":"https://avatars2.githubusercontent.com/u/488136?v=4","gravatar_id":"","url":"https://api.github.com/users/natrim","html_url":"https://github.com/natrim","followers_url":"https://api.github.com/users/natrim/followers","following_url":"https://api.github.com/users/natrim/following{/other_user}","gists_url":"https://api.github.com/users/natrim/gists{/gist_id}","starred_url":"https://api.github.com/users/natrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natrim/subscriptions","organizations_url":"https://api.github.com/users/natrim/orgs","repos_url":"https://api.github.com/users/natrim/repos","events_url":"https://api.github.com/users/natrim/events{/privacy}","received_events_url":"https://api.github.com/users/natrim/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T12:40:08Z","updated_at":"2017-07-25T12:40:08Z","body":"@sidferreira no skype but i can add you on hangouts (but i am not english speaker .)\r\n@MhdSyrwan normal aor components that are not direct children of EmbeddedArrayInput are not prefixed too\r\n\r\nmaybe there is some way to change the wrapper so it will work?\r\n\r\n\r\n"}}
{"actor":{"display_login":"natrim"}}