{"action":"created","comment":{"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/comments/119141621","pull_request_review_id":40994779,"id":119141621,"diff_hunk":"@@ -95,7 +107,11 @@ def run\n       @message += \" with #{@failures} failures\"\n     end\n \n-    if @now - @last_run > config[:crit_age] || @failures > 0\n+    if @restart_failures > 0","path":"bin/check-puppet-last-run.rb","position":31,"original_position":31,"commit_id":"58953640bebf3dbe482ee29479bbadca9021ffcb","original_commit_id":"63ede30a77f7927cd164a2a6478b4132f8d4dab4","user":{"login":"majormoses","id":3145127,"avatar_url":"https://avatars0.githubusercontent.com/u/3145127?v=3","gravatar_id":"","url":"https://api.github.com/users/majormoses","html_url":"https://github.com/majormoses","followers_url":"https://api.github.com/users/majormoses/followers","following_url":"https://api.github.com/users/majormoses/following{/other_user}","gists_url":"https://api.github.com/users/majormoses/gists{/gist_id}","starred_url":"https://api.github.com/users/majormoses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majormoses/subscriptions","organizations_url":"https://api.github.com/users/majormoses/orgs","repos_url":"https://api.github.com/users/majormoses/repos","events_url":"https://api.github.com/users/majormoses/events{/privacy}","received_events_url":"https://api.github.com/users/majormoses/received_events","type":"User","site_admin":false},"body":"how does that change that we want to check if the user specified that they want to report on restart failures?","created_at":"2017-05-30T15:58:44Z","updated_at":"2017-05-30T15:58:44Z","html_url":"https://github.com/sensu-plugins/sensu-plugins-puppet/pull/14#discussion_r119141621","pull_request_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/comments/119141621"},"html":{"href":"https://github.com/sensu-plugins/sensu-plugins-puppet/pull/14#discussion_r119141621"},"pull_request":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14","id":120579565,"html_url":"https://github.com/sensu-plugins/sensu-plugins-puppet/pull/14","diff_url":"https://github.com/sensu-plugins/sensu-plugins-puppet/pull/14.diff","patch_url":"https://github.com/sensu-plugins/sensu-plugins-puppet/pull/14.patch","issue_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/issues/14","number":14,"state":"open","locked":false,"title":"New option to trigger alert on failed restarts","user":{"login":"antonidabek","id":25926941,"avatar_url":"https://avatars0.githubusercontent.com/u/25926941?v=3","gravatar_id":"","url":"https://api.github.com/users/antonidabek","html_url":"https://github.com/antonidabek","followers_url":"https://api.github.com/users/antonidabek/followers","following_url":"https://api.github.com/users/antonidabek/following{/other_user}","gists_url":"https://api.github.com/users/antonidabek/gists{/gist_id}","starred_url":"https://api.github.com/users/antonidabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonidabek/subscriptions","organizations_url":"https://api.github.com/users/antonidabek/orgs","repos_url":"https://api.github.com/users/antonidabek/repos","events_url":"https://api.github.com/users/antonidabek/events{/privacy}","received_events_url":"https://api.github.com/users/antonidabek/received_events","type":"User","site_admin":false},"body":"Current versions of puppet treat resources that failed to restart as different\r\nkind of failures and they are not necessarily reported, there is puppet bug\r\nPUP-2280 that explains it in more detail. Until it is fixed in version 5 of\r\npuppet it would be useful to see such failures in monitoring, so I added option\r\nto report this failure. Option is by default off to not change usual behavior.\r\n\r\n\r\n","created_at":"2017-05-15T11:28:22Z","updated_at":"2017-05-30T15:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fbd3489673ded00215aae82ffad63fd16bd28b8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14/commits","review_comments_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14/comments","review_comment_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/issues/14/comments","statuses_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/statuses/58953640bebf3dbe482ee29479bbadca9021ffcb","head":{"label":"antonidabek:failed_restarts","ref":"failed_restarts","sha":"58953640bebf3dbe482ee29479bbadca9021ffcb","user":{"login":"antonidabek","id":25926941,"avatar_url":"https://avatars0.githubusercontent.com/u/25926941?v=3","gravatar_id":"","url":"https://api.github.com/users/antonidabek","html_url":"https://github.com/antonidabek","followers_url":"https://api.github.com/users/antonidabek/followers","following_url":"https://api.github.com/users/antonidabek/following{/other_user}","gists_url":"https://api.github.com/users/antonidabek/gists{/gist_id}","starred_url":"https://api.github.com/users/antonidabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonidabek/subscriptions","organizations_url":"https://api.github.com/users/antonidabek/orgs","repos_url":"https://api.github.com/users/antonidabek/repos","events_url":"https://api.github.com/users/antonidabek/events{/privacy}","received_events_url":"https://api.github.com/users/antonidabek/received_events","type":"User","site_admin":false},"repo":{"id":90972043,"name":"sensu-plugins-puppet","full_name":"antonidabek/sensu-plugins-puppet","owner":{"login":"antonidabek","id":25926941,"avatar_url":"https://avatars0.githubusercontent.com/u/25926941?v=3","gravatar_id":"","url":"https://api.github.com/users/antonidabek","html_url":"https://github.com/antonidabek","followers_url":"https://api.github.com/users/antonidabek/followers","following_url":"https://api.github.com/users/antonidabek/following{/other_user}","gists_url":"https://api.github.com/users/antonidabek/gists{/gist_id}","starred_url":"https://api.github.com/users/antonidabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonidabek/subscriptions","organizations_url":"https://api.github.com/users/antonidabek/orgs","repos_url":"https://api.github.com/users/antonidabek/repos","events_url":"https://api.github.com/users/antonidabek/events{/privacy}","received_events_url":"https://api.github.com/users/antonidabek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antonidabek/sensu-plugins-puppet","description":"This plugin provides native Puppet instrumentation for monitoring and collecting metrics from Puppet runs.","fork":true,"url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet","forks_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/forks","keys_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/teams","hooks_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/hooks","issue_events_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/events","assignees_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/tags","blobs_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/languages","stargazers_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/stargazers","contributors_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/contributors","subscribers_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/subscribers","subscription_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/subscription","commits_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/merges","archive_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/downloads","issues_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/labels{/name}","releases_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/antonidabek/sensu-plugins-puppet/deployments","created_at":"2017-05-11T11:32:39Z","updated_at":"2017-05-11T11:32:41Z","pushed_at":"2017-05-30T15:05:58Z","git_url":"git://github.com/antonidabek/sensu-plugins-puppet.git","ssh_url":"git@github.com:antonidabek/sensu-plugins-puppet.git","clone_url":"https://github.com/antonidabek/sensu-plugins-puppet.git","svn_url":"https://github.com/antonidabek/sensu-plugins-puppet","homepage":"http://sensu-plugins.io","size":32,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sensu-plugins:master","ref":"master","sha":"0c98425f8b1452d359dfa6d3e5b85f01ecf78436","user":{"login":"sensu-plugins","id":10713628,"avatar_url":"https://avatars1.githubusercontent.com/u/10713628?v=3","gravatar_id":"","url":"https://api.github.com/users/sensu-plugins","html_url":"https://github.com/sensu-plugins","followers_url":"https://api.github.com/users/sensu-plugins/followers","following_url":"https://api.github.com/users/sensu-plugins/following{/other_user}","gists_url":"https://api.github.com/users/sensu-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu-plugins/subscriptions","organizations_url":"https://api.github.com/users/sensu-plugins/orgs","repos_url":"https://api.github.com/users/sensu-plugins/repos","events_url":"https://api.github.com/users/sensu-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/sensu-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":35250037,"name":"sensu-plugins-puppet","full_name":"sensu-plugins/sensu-plugins-puppet","owner":{"login":"sensu-plugins","id":10713628,"avatar_url":"https://avatars1.githubusercontent.com/u/10713628?v=3","gravatar_id":"","url":"https://api.github.com/users/sensu-plugins","html_url":"https://github.com/sensu-plugins","followers_url":"https://api.github.com/users/sensu-plugins/followers","following_url":"https://api.github.com/users/sensu-plugins/following{/other_user}","gists_url":"https://api.github.com/users/sensu-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu-plugins/subscriptions","organizations_url":"https://api.github.com/users/sensu-plugins/orgs","repos_url":"https://api.github.com/users/sensu-plugins/repos","events_url":"https://api.github.com/users/sensu-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/sensu-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensu-plugins/sensu-plugins-puppet","description":"This plugin provides native Puppet instrumentation for monitoring and collecting metrics from Puppet runs.","fork":false,"url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet","forks_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/forks","keys_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/teams","hooks_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/hooks","issue_events_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/events","assignees_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/tags","blobs_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/languages","stargazers_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/stargazers","contributors_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/contributors","subscribers_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/subscribers","subscription_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/subscription","commits_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/merges","archive_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/downloads","issues_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/labels{/name}","releases_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/deployments","created_at":"2015-05-08T00:20:25Z","updated_at":"2017-03-17T01:07:15Z","pushed_at":"2017-05-30T15:06:01Z","git_url":"git://github.com/sensu-plugins/sensu-plugins-puppet.git","ssh_url":"git@github.com:sensu-plugins/sensu-plugins-puppet.git","clone_url":"https://github.com/sensu-plugins/sensu-plugins-puppet.git","svn_url":"https://github.com/sensu-plugins/sensu-plugins-puppet","homepage":"http://sensu-plugins.io","size":31,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14"},"html":{"href":"https://github.com/sensu-plugins/sensu-plugins-puppet/pull/14"},"issue":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/issues/14"},"comments":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/sensu-plugins/sensu-plugins-puppet/statuses/58953640bebf3dbe482ee29479bbadca9021ffcb"}}}}
{"actor":{"display_login":"majormoses"}}