{"action":"created","issue":{"url":"https://api.github.com/repos/ra3xdh/qucs/issues/25","repository_url":"https://api.github.com/repos/ra3xdh/qucs","labels_url":"https://api.github.com/repos/ra3xdh/qucs/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/ra3xdh/qucs/issues/25/comments","events_url":"https://api.github.com/repos/ra3xdh/qucs/issues/25/events","html_url":"https://github.com/ra3xdh/qucs/pull/25","id":230490145,"number":25,"title":"Force settings save when Default Simulator dialog \"apply\" button is clicked.","user":{"login":"tvrusso","id":10872812,"avatar_url":"https://avatars2.githubusercontent.com/u/10872812?v=3","gravatar_id":"","url":"https://api.github.com/users/tvrusso","html_url":"https://github.com/tvrusso","followers_url":"https://api.github.com/users/tvrusso/followers","following_url":"https://api.github.com/users/tvrusso/following{/other_user}","gists_url":"https://api.github.com/users/tvrusso/gists{/gist_id}","starred_url":"https://api.github.com/users/tvrusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvrusso/subscriptions","organizations_url":"https://api.github.com/users/tvrusso/orgs","repos_url":"https://api.github.com/users/tvrusso/repos","events_url":"https://api.github.com/users/tvrusso/events{/privacy}","received_events_url":"https://api.github.com/users/tvrusso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-05-22T19:10:46Z","updated_at":"2017-05-24T09:22:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ra3xdh/qucs/pulls/25","html_url":"https://github.com/ra3xdh/qucs/pull/25","diff_url":"https://github.com/ra3xdh/qucs/pull/25.diff","patch_url":"https://github.com/ra3xdh/qucs/pull/25.patch"},"body":"If a user modifies settings in the Simulator->Select default simulator dialog and clicks \"apply,\"  the settings are not saved until the user also opens the File->Application Settings dialog and clicks \"Ok\" there.  This confused me for a long time, and is a source of confusion for our potential users of Qucs-s as a Xyce schematic capture tool.\r\n\r\nThat's because there is a missing call to saveApplSettings in the slotApply slot in qucs/qucs/extsimkernels/simsettingsdialog.cpp\r\n\r\nAdding this call makes the code behave as a user would expect: the persistent storage is created upon clicking \"Apply\" if it doesn't already exist, and is updated correctly if it did already exist."},"comment":{"url":"https://api.github.com/repos/ra3xdh/qucs/issues/comments/303668110","html_url":"https://github.com/ra3xdh/qucs/pull/25#issuecomment-303668110","issue_url":"https://api.github.com/repos/ra3xdh/qucs/issues/25","id":303668110,"user":{"login":"ra3xdh","id":4920080,"avatar_url":"https://avatars3.githubusercontent.com/u/4920080?v=3","gravatar_id":"","url":"https://api.github.com/users/ra3xdh","html_url":"https://github.com/ra3xdh","followers_url":"https://api.github.com/users/ra3xdh/followers","following_url":"https://api.github.com/users/ra3xdh/following{/other_user}","gists_url":"https://api.github.com/users/ra3xdh/gists{/gist_id}","starred_url":"https://api.github.com/users/ra3xdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ra3xdh/subscriptions","organizations_url":"https://api.github.com/users/ra3xdh/orgs","repos_url":"https://api.github.com/users/ra3xdh/repos","events_url":"https://api.github.com/users/ra3xdh/events{/privacy}","received_events_url":"https://api.github.com/users/ra3xdh/received_events","type":"User","site_admin":false},"created_at":"2017-05-24T09:22:44Z","updated_at":"2017-05-24T09:22:44Z","body":"I cannot reproduce this bug, but I believe that it can take place. It seems Qt generates the `closeEvent` depending on DE/WM used. I am using KDE4 and `saveApplSettings()` invoked at every application exit. It doesn't depend on way to close application window. I have checked this fact with debugger setting breakpoint at `saveApplSettings()` call. But other DE/WM can generate `CloseEvent()` in a random way. So, I think the good practice will be to explicitly write settings to file when something is modified. And I am merging your PR. Thank you for finding this unobvious bug. "}}
{"actor":{"display_login":"ra3xdh"}}