{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-services/screenshots/issues/2747","repository_url":"https://api.github.com/repos/mozilla-services/screenshots","labels_url":"https://api.github.com/repos/mozilla-services/screenshots/issues/2747/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-services/screenshots/issues/2747/comments","events_url":"https://api.github.com/repos/mozilla-services/screenshots/issues/2747/events","html_url":"https://github.com/mozilla-services/screenshots/pull/2747","id":224273855,"number":2747,"title":"Fix #2652, avoid error popups when selector is torn down during save","user":{"login":"ianb","id":44390,"avatar_url":"https://avatars2.githubusercontent.com/u/44390?v=3","gravatar_id":"","url":"https://api.github.com/users/ianb","html_url":"https://github.com/ianb","followers_url":"https://api.github.com/users/ianb/followers","following_url":"https://api.github.com/users/ianb/following{/other_user}","gists_url":"https://api.github.com/users/ianb/gists{/gist_id}","starred_url":"https://api.github.com/users/ianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianb/subscriptions","organizations_url":"https://api.github.com/users/ianb/orgs","repos_url":"https://api.github.com/users/ianb/repos","events_url":"https://api.github.com/users/ianb/events{/privacy}","received_events_url":"https://api.github.com/users/ianb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-25T21:12:46Z","updated_at":"2017-04-25T21:18:56Z","closed_at":"2017-04-25T21:18:56Z","pull_request":{"url":"https://api.github.com/repos/mozilla-services/screenshots/pulls/2747","html_url":"https://github.com/mozilla-services/screenshots/pull/2747","diff_url":"https://github.com/mozilla-services/screenshots/pull/2747.diff","patch_url":"https://github.com/mozilla-services/screenshots/pull/2747.patch"},"body":"Also bind several modules so that catcher works even after selectorLoader.unloadModules has been called\r\n\r\nNote that an error is still signalled when there is a premature teardown, but only to the console\r\n\r\nTo reproduce the original error, run the server like this:\r\n\r\n```\r\n$ TEST_SLOW_RESPONSE=3000 ./bin/run-server\r\n```\r\n\r\nThis gives enough time to switch tabs and hit Escape to close the selector.\r\n\r\nThere was another bug that caused the popup to stop displaying when there was an error that happened after teardown.  This also fixes that, while avoiding any popup for this particular situation."},"comment":{"url":"https://api.github.com/repos/mozilla-services/screenshots/issues/comments/297168117","html_url":"https://github.com/mozilla-services/screenshots/pull/2747#issuecomment-297168117","issue_url":"https://api.github.com/repos/mozilla-services/screenshots/issues/2747","id":297168117,"user":{"login":"ianb","id":44390,"avatar_url":"https://avatars2.githubusercontent.com/u/44390?v=3","gravatar_id":"","url":"https://api.github.com/users/ianb","html_url":"https://github.com/ianb","followers_url":"https://api.github.com/users/ianb/followers","following_url":"https://api.github.com/users/ianb/following{/other_user}","gists_url":"https://api.github.com/users/ianb/gists{/gist_id}","starred_url":"https://api.github.com/users/ianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianb/subscriptions","organizations_url":"https://api.github.com/users/ianb/orgs","repos_url":"https://api.github.com/users/ianb/repos","events_url":"https://api.github.com/users/ianb/events{/privacy}","received_events_url":"https://api.github.com/users/ianb/received_events","type":"User","site_admin":false},"created_at":"2017-04-25T21:18:56Z","updated_at":"2017-04-25T21:18:56Z","body":"This isn't working right, will re-open later."}}
{"actor":{"display_login":"ianb"}}