{"action":"opened","number":174,"pull_request":{"url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/174","id":131235297,"html_url":"https://github.com/Workiva/go-datastructures/pull/174","diff_url":"https://github.com/Workiva/go-datastructures/pull/174.diff","patch_url":"https://github.com/Workiva/go-datastructures/pull/174.patch","issue_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/174","number":174,"state":"open","locked":false,"title":"Remove Gosched call limiting","user":{"login":"tylertreat","id":552817,"avatar_url":"https://avatars3.githubusercontent.com/u/552817?v=4","gravatar_id":"","url":"https://api.github.com/users/tylertreat","html_url":"https://github.com/tylertreat","followers_url":"https://api.github.com/users/tylertreat/followers","following_url":"https://api.github.com/users/tylertreat/following{/other_user}","gists_url":"https://api.github.com/users/tylertreat/gists{/gist_id}","starred_url":"https://api.github.com/users/tylertreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylertreat/subscriptions","organizations_url":"https://api.github.com/users/tylertreat/orgs","repos_url":"https://api.github.com/users/tylertreat/repos","events_url":"https://api.github.com/users/tylertreat/events{/privacy}","received_events_url":"https://api.github.com/users/tylertreat/received_events","type":"User","site_admin":false},"body":"Currently `RingBuffer` limits the calls to `runtime.Gosched()` to every 10,000 loop iterations in `Put`/`Get`, presumably because it used to be more expensive in earlier versions of Go. However, running benchmarks on a contended `RingBuffer` with go1.8.3 shows a significant scalability improvement when the `Gosched` throttling is removed (see below).\r\n\r\n![rb](https://user-images.githubusercontent.com/552817/28350863-783c4054-6c11-11e7-9919-3abd2eb5e6a6.png)\r\n\r\n```\r\ngo version go1.8.3 linux/amd64\r\n\r\nbenchmark                             old ns/op     new ns/op     delta\r\nBenchmarkRBLifeCycle-2                93.5          91.8          -1.82%\r\nBenchmarkRBLifeCycle-4                83.3          91.3          +9.60%\r\nBenchmarkRBLifeCycle-6                84.8          90.1          +6.25%\r\nBenchmarkRBLifeCycle-8                84.3          89.6          +6.29%\r\nBenchmarkRBLifeCycle-10               86.1          90.3          +4.88%\r\nBenchmarkRBLifeCycle-12               83.8          90.1          +7.52%\r\nBenchmarkRBLifeCycle-14               84.4          90.2          +6.87%\r\nBenchmarkRBLifeCycle-16               84.9          90.1          +6.12%\r\nBenchmarkRBLifeCycleContention-2      1043          638           -38.83%\r\nBenchmarkRBLifeCycleContention-4      2464          1160          -52.92%\r\nBenchmarkRBLifeCycleContention-6      3117          1278          -59.00%\r\nBenchmarkRBLifeCycleContention-8      3472          1317          -62.07%\r\nBenchmarkRBLifeCycleContention-10     3452          1349          -60.92%\r\nBenchmarkRBLifeCycleContention-12     3481          1494          -57.08%\r\nBenchmarkRBLifeCycleContention-14     3467          1675          -51.69%\r\nBenchmarkRBLifeCycleContention-16     3515          1772          -49.59%\r\nBenchmarkRBPut-2                      50.8          49.7          -2.17%\r\nBenchmarkRBPut-4                      62.5          62.1          -0.64%\r\nBenchmarkRBPut-6                      57.2          56.9          -0.52%\r\nBenchmarkRBPut-8                      58.0          57.4          -1.03%\r\nBenchmarkRBPut-10                     55.0          54.7          -0.55%\r\nBenchmarkRBPut-12                     54.5          57.5          +5.50%\r\nBenchmarkRBPut-14                     55.1          57.5          +4.36%\r\nBenchmarkRBPut-16                     58.8          54.3          -7.65%\r\nBenchmarkRBGet-2                      26.4          26.1          -1.14%\r\nBenchmarkRBGet-4                      26.4          26.1          -1.14%\r\nBenchmarkRBGet-6                      26.4          26.1          -1.14%\r\nBenchmarkRBGet-8                      26.4          26.1          -1.14%\r\nBenchmarkRBGet-10                     26.4          26.1          -1.14%\r\nBenchmarkRBGet-12                     26.4          26.1          -1.14%\r\nBenchmarkRBGet-14                     26.4          26.1          -1.14%\r\nBenchmarkRBGet-16                     26.4          26.1          -1.14%\r\n```\r\n\r\n@stevenosborne-wf @brianshannan-wf @charliestrawn-wf \r\ncc @dzyp ","created_at":"2017-07-19T04:33:35Z","updated_at":"2017-07-19T04:33:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/174/commits","review_comments_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/174/comments","review_comment_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/174/comments","statuses_url":"https://api.github.com/repos/Workiva/go-datastructures/statuses/6c7399c334719eabed84b33b11ab2e680f708d61","head":{"label":"tylertreat:gosched_changes","ref":"gosched_changes","sha":"6c7399c334719eabed84b33b11ab2e680f708d61","user":{"login":"tylertreat","id":552817,"avatar_url":"https://avatars3.githubusercontent.com/u/552817?v=4","gravatar_id":"","url":"https://api.github.com/users/tylertreat","html_url":"https://github.com/tylertreat","followers_url":"https://api.github.com/users/tylertreat/followers","following_url":"https://api.github.com/users/tylertreat/following{/other_user}","gists_url":"https://api.github.com/users/tylertreat/gists{/gist_id}","starred_url":"https://api.github.com/users/tylertreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylertreat/subscriptions","organizations_url":"https://api.github.com/users/tylertreat/orgs","repos_url":"https://api.github.com/users/tylertreat/repos","events_url":"https://api.github.com/users/tylertreat/events{/privacy}","received_events_url":"https://api.github.com/users/tylertreat/received_events","type":"User","site_admin":false},"repo":{"id":30676136,"name":"go-datastructures","full_name":"tylertreat/go-datastructures","owner":{"login":"tylertreat","id":552817,"avatar_url":"https://avatars3.githubusercontent.com/u/552817?v=4","gravatar_id":"","url":"https://api.github.com/users/tylertreat","html_url":"https://github.com/tylertreat","followers_url":"https://api.github.com/users/tylertreat/followers","following_url":"https://api.github.com/users/tylertreat/following{/other_user}","gists_url":"https://api.github.com/users/tylertreat/gists{/gist_id}","starred_url":"https://api.github.com/users/tylertreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylertreat/subscriptions","organizations_url":"https://api.github.com/users/tylertreat/orgs","repos_url":"https://api.github.com/users/tylertreat/repos","events_url":"https://api.github.com/users/tylertreat/events{/privacy}","received_events_url":"https://api.github.com/users/tylertreat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tylertreat/go-datastructures","description":null,"fork":true,"url":"https://api.github.com/repos/tylertreat/go-datastructures","forks_url":"https://api.github.com/repos/tylertreat/go-datastructures/forks","keys_url":"https://api.github.com/repos/tylertreat/go-datastructures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylertreat/go-datastructures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylertreat/go-datastructures/teams","hooks_url":"https://api.github.com/repos/tylertreat/go-datastructures/hooks","issue_events_url":"https://api.github.com/repos/tylertreat/go-datastructures/issues/events{/number}","events_url":"https://api.github.com/repos/tylertreat/go-datastructures/events","assignees_url":"https://api.github.com/repos/tylertreat/go-datastructures/assignees{/user}","branches_url":"https://api.github.com/repos/tylertreat/go-datastructures/branches{/branch}","tags_url":"https://api.github.com/repos/tylertreat/go-datastructures/tags","blobs_url":"https://api.github.com/repos/tylertreat/go-datastructures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylertreat/go-datastructures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylertreat/go-datastructures/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylertreat/go-datastructures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylertreat/go-datastructures/statuses/{sha}","languages_url":"https://api.github.com/repos/tylertreat/go-datastructures/languages","stargazers_url":"https://api.github.com/repos/tylertreat/go-datastructures/stargazers","contributors_url":"https://api.github.com/repos/tylertreat/go-datastructures/contributors","subscribers_url":"https://api.github.com/repos/tylertreat/go-datastructures/subscribers","subscription_url":"https://api.github.com/repos/tylertreat/go-datastructures/subscription","commits_url":"https://api.github.com/repos/tylertreat/go-datastructures/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylertreat/go-datastructures/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylertreat/go-datastructures/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylertreat/go-datastructures/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylertreat/go-datastructures/contents/{+path}","compare_url":"https://api.github.com/repos/tylertreat/go-datastructures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylertreat/go-datastructures/merges","archive_url":"https://api.github.com/repos/tylertreat/go-datastructures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylertreat/go-datastructures/downloads","issues_url":"https://api.github.com/repos/tylertreat/go-datastructures/issues{/number}","pulls_url":"https://api.github.com/repos/tylertreat/go-datastructures/pulls{/number}","milestones_url":"https://api.github.com/repos/tylertreat/go-datastructures/milestones{/number}","notifications_url":"https://api.github.com/repos/tylertreat/go-datastructures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylertreat/go-datastructures/labels{/name}","releases_url":"https://api.github.com/repos/tylertreat/go-datastructures/releases{/id}","deployments_url":"https://api.github.com/repos/tylertreat/go-datastructures/deployments","created_at":"2015-02-11T23:50:57Z","updated_at":"2017-07-10T19:41:44Z","pushed_at":"2017-07-19T04:00:37Z","git_url":"git://github.com/tylertreat/go-datastructures.git","ssh_url":"git@github.com:tylertreat/go-datastructures.git","clone_url":"https://github.com/tylertreat/go-datastructures.git","svn_url":"https://github.com/tylertreat/go-datastructures","homepage":null,"size":8505,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"3620bd07cd0ac1d85c9f8e5b133865330eeacd25","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":25923208,"name":"go-datastructures","full_name":"Workiva/go-datastructures","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/go-datastructures","description":null,"fork":false,"url":"https://api.github.com/repos/Workiva/go-datastructures","forks_url":"https://api.github.com/repos/Workiva/go-datastructures/forks","keys_url":"https://api.github.com/repos/Workiva/go-datastructures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/go-datastructures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/go-datastructures/teams","hooks_url":"https://api.github.com/repos/Workiva/go-datastructures/hooks","issue_events_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/go-datastructures/events","assignees_url":"https://api.github.com/repos/Workiva/go-datastructures/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/go-datastructures/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/go-datastructures/tags","blobs_url":"https://api.github.com/repos/Workiva/go-datastructures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/go-datastructures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/go-datastructures/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/go-datastructures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/go-datastructures/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/go-datastructures/languages","stargazers_url":"https://api.github.com/repos/Workiva/go-datastructures/stargazers","contributors_url":"https://api.github.com/repos/Workiva/go-datastructures/contributors","subscribers_url":"https://api.github.com/repos/Workiva/go-datastructures/subscribers","subscription_url":"https://api.github.com/repos/Workiva/go-datastructures/subscription","commits_url":"https://api.github.com/repos/Workiva/go-datastructures/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/go-datastructures/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/go-datastructures/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/go-datastructures/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/go-datastructures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/go-datastructures/merges","archive_url":"https://api.github.com/repos/Workiva/go-datastructures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/go-datastructures/downloads","issues_url":"https://api.github.com/repos/Workiva/go-datastructures/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/go-datastructures/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/go-datastructures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/go-datastructures/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/go-datastructures/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/go-datastructures/deployments","created_at":"2014-10-29T13:55:17Z","updated_at":"2017-07-18T12:33:58Z","pushed_at":"2017-07-10T21:12:40Z","git_url":"git://github.com/Workiva/go-datastructures.git","ssh_url":"git@github.com:Workiva/go-datastructures.git","clone_url":"https://github.com/Workiva/go-datastructures.git","svn_url":"https://github.com/Workiva/go-datastructures","homepage":null,"size":8512,"stargazers_count":3299,"watchers_count":3299,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":11,"forks":317,"open_issues":11,"watchers":3299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/174"},"html":{"href":"https://github.com/Workiva/go-datastructures/pull/174"},"issue":{"href":"https://api.github.com/repos/Workiva/go-datastructures/issues/174"},"comments":{"href":"https://api.github.com/repos/Workiva/go-datastructures/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/go-datastructures/statuses/6c7399c334719eabed84b33b11ab2e680f708d61"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":40,"deletions":14,"changed_files":2}}
{"actor":{"display_login":"tylertreat"}}