{"action":"created","issue":{"url":"https://api.github.com/repos/StevenBlack/hosts/issues/286","repository_url":"https://api.github.com/repos/StevenBlack/hosts","labels_url":"https://api.github.com/repos/StevenBlack/hosts/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/StevenBlack/hosts/issues/286/comments","events_url":"https://api.github.com/repos/StevenBlack/hosts/issues/286/events","html_url":"https://github.com/StevenBlack/hosts/pull/286","id":226939328,"number":286,"title":"Patch promptForFlushDnsCache Bug","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars3.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-08T05:11:40Z","updated_at":"2017-05-09T03:06:54Z","closed_at":"2017-05-09T03:04:27Z","pull_request":{"url":"https://api.github.com/repos/StevenBlack/hosts/pulls/286","html_url":"https://github.com/StevenBlack/hosts/pull/286","diff_url":"https://github.com/StevenBlack/hosts/pull/286.diff","patch_url":"https://github.com/StevenBlack/hosts/pull/286.patch"},"body":"Previously, it was checking if `query_yes_no` returned `False`, which does not happen, as the function only\r\nreturns `\"yes\"` or `\"no\"`. As a result, the check was always returning `True`, even when the user did not\r\nwant to flush the DNS cache."},"comment":{"url":"https://api.github.com/repos/StevenBlack/hosts/issues/comments/300048988","html_url":"https://github.com/StevenBlack/hosts/pull/286#issuecomment-300048988","issue_url":"https://api.github.com/repos/StevenBlack/hosts/issues/286","id":300048988,"user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars3.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T03:06:54Z","updated_at":"2017-05-09T03:06:54Z","body":"As an aside, I wonder if it might be better to just return `True` or `False` (instead of `\"yes\"` or `\"no\"`).  Less prone to bugs IMO."}}
{"actor":{"display_login":"gfyoung"}}