{"action":"created","comment":{"url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/comments/159159490","pull_request_review_id":86065823,"id":159159490,"diff_hunk":"@@ -154,34 +154,36 @@ function flipSwitch(){\n //++\n //++\n function knobRange(elem){\n+  debugger;\n     switch ($(elem).attr('class')) {\n-      case \"range-indicator long\":\n+      case \"close-range-knob\":","path":"client/assets/js/meter.js","position":29,"original_position":29,"commit_id":"1c64f33f4d63e454c420141a1ef65de19163a2a1","original_commit_id":"1c64f33f4d63e454c420141a1ef65de19163a2a1","user":{"login":"sloumdrone","id":21182475,"avatar_url":"https://avatars3.githubusercontent.com/u/21182475?v=4","gravatar_id":"","url":"https://api.github.com/users/sloumdrone","html_url":"https://github.com/sloumdrone","followers_url":"https://api.github.com/users/sloumdrone/followers","following_url":"https://api.github.com/users/sloumdrone/following{/other_user}","gists_url":"https://api.github.com/users/sloumdrone/gists{/gist_id}","starred_url":"https://api.github.com/users/sloumdrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloumdrone/subscriptions","organizations_url":"https://api.github.com/users/sloumdrone/orgs","repos_url":"https://api.github.com/users/sloumdrone/repos","events_url":"https://api.github.com/users/sloumdrone/events{/privacy}","received_events_url":"https://api.github.com/users/sloumdrone/received_events","type":"User","site_admin":false},"body":"That explains it perfectly. Thank you!\r\n\r\nYeah, I know Dan is of that opinion. That said, in an app that you designed yourself (rather than as a huge team) you can account for the inline styles in the code just fine. I'm good either way for this, I just get confused by the class route, since you have to check a whole other file to see what is happening instead of it just being in the code.","created_at":"2018-01-01T16:55:51Z","updated_at":"2018-01-01T16:56:06Z","html_url":"https://github.com/unleashalicia/c10.17_ghost_stories/pull/15#discussion_r159159490","pull_request_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/comments/159159490"},"html":{"href":"https://github.com/unleashalicia/c10.17_ghost_stories/pull/15#discussion_r159159490"},"pull_request":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15"}},"in_reply_to_id":159149468},"pull_request":{"url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15","id":160632680,"html_url":"https://github.com/unleashalicia/c10.17_ghost_stories/pull/15","diff_url":"https://github.com/unleashalicia/c10.17_ghost_stories/pull/15.diff","patch_url":"https://github.com/unleashalicia/c10.17_ghost_stories/pull/15.patch","issue_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/15","number":15,"state":"open","locked":false,"title":"moved clickhandler to knob itself","user":{"login":"sicnarfodider","id":30843647,"avatar_url":"https://avatars3.githubusercontent.com/u/30843647?v=4","gravatar_id":"","url":"https://api.github.com/users/sicnarfodider","html_url":"https://github.com/sicnarfodider","followers_url":"https://api.github.com/users/sicnarfodider/followers","following_url":"https://api.github.com/users/sicnarfodider/following{/other_user}","gists_url":"https://api.github.com/users/sicnarfodider/gists{/gist_id}","starred_url":"https://api.github.com/users/sicnarfodider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sicnarfodider/subscriptions","organizations_url":"https://api.github.com/users/sicnarfodider/orgs","repos_url":"https://api.github.com/users/sicnarfodider/repos","events_url":"https://api.github.com/users/sicnarfodider/events{/privacy}","received_events_url":"https://api.github.com/users/sicnarfodider/received_events","type":"User","site_admin":false},"body":"also removed global variable knob and just passed in the string of the knob range into handlemeter()","created_at":"2017-12-31T23:18:28Z","updated_at":"2018-01-01T16:56:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fd476f50af52321fda440a83e72f75eee81bf34","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15/commits","review_comments_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15/comments","review_comment_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/15/comments","statuses_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/statuses/1c64f33f4d63e454c420141a1ef65de19163a2a1","head":{"label":"unleashalicia:knob-rework","ref":"knob-rework","sha":"1c64f33f4d63e454c420141a1ef65de19163a2a1","user":{"login":"unleashalicia","id":28938534,"avatar_url":"https://avatars1.githubusercontent.com/u/28938534?v=4","gravatar_id":"","url":"https://api.github.com/users/unleashalicia","html_url":"https://github.com/unleashalicia","followers_url":"https://api.github.com/users/unleashalicia/followers","following_url":"https://api.github.com/users/unleashalicia/following{/other_user}","gists_url":"https://api.github.com/users/unleashalicia/gists{/gist_id}","starred_url":"https://api.github.com/users/unleashalicia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unleashalicia/subscriptions","organizations_url":"https://api.github.com/users/unleashalicia/orgs","repos_url":"https://api.github.com/users/unleashalicia/repos","events_url":"https://api.github.com/users/unleashalicia/events{/privacy}","received_events_url":"https://api.github.com/users/unleashalicia/received_events","type":"User","site_admin":false},"repo":{"id":114065803,"name":"c10.17_ghost_stories","full_name":"unleashalicia/c10.17_ghost_stories","owner":{"login":"unleashalicia","id":28938534,"avatar_url":"https://avatars1.githubusercontent.com/u/28938534?v=4","gravatar_id":"","url":"https://api.github.com/users/unleashalicia","html_url":"https://github.com/unleashalicia","followers_url":"https://api.github.com/users/unleashalicia/followers","following_url":"https://api.github.com/users/unleashalicia/following{/other_user}","gists_url":"https://api.github.com/users/unleashalicia/gists{/gist_id}","starred_url":"https://api.github.com/users/unleashalicia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unleashalicia/subscriptions","organizations_url":"https://api.github.com/users/unleashalicia/orgs","repos_url":"https://api.github.com/users/unleashalicia/repos","events_url":"https://api.github.com/users/unleashalicia/events{/privacy}","received_events_url":"https://api.github.com/users/unleashalicia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unleashalicia/c10.17_ghost_stories","description":"A ghost themed augmented reality app ","fork":true,"url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories","forks_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/forks","keys_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/teams","hooks_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/hooks","issue_events_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/events{/number}","events_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/events","assignees_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/assignees{/user}","branches_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/branches{/branch}","tags_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/tags","blobs_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/refs{/sha}","trees_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/statuses/{sha}","languages_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/languages","stargazers_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/stargazers","contributors_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/contributors","subscribers_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/subscribers","subscription_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/subscription","commits_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/commits{/sha}","git_commits_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/commits{/sha}","comments_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/comments{/number}","issue_comment_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/comments{/number}","contents_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/contents/{+path}","compare_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/merges","archive_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/downloads","issues_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues{/number}","pulls_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls{/number}","milestones_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/milestones{/number}","notifications_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/labels{/name}","releases_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/releases{/id}","deployments_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/deployments","created_at":"2017-12-13T02:53:14Z","updated_at":"2017-12-13T01:50:57Z","pushed_at":"2018-01-01T08:43:09Z","git_url":"git://github.com/unleashalicia/c10.17_ghost_stories.git","ssh_url":"git@github.com:unleashalicia/c10.17_ghost_stories.git","clone_url":"https://github.com/unleashalicia/c10.17_ghost_stories.git","svn_url":"https://github.com/unleashalicia/c10.17_ghost_stories","homepage":null,"size":25262,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"unleashalicia:dev","ref":"dev","sha":"826ec644a6aa00ca411ea1b147346cef48de8971","user":{"login":"unleashalicia","id":28938534,"avatar_url":"https://avatars1.githubusercontent.com/u/28938534?v=4","gravatar_id":"","url":"https://api.github.com/users/unleashalicia","html_url":"https://github.com/unleashalicia","followers_url":"https://api.github.com/users/unleashalicia/followers","following_url":"https://api.github.com/users/unleashalicia/following{/other_user}","gists_url":"https://api.github.com/users/unleashalicia/gists{/gist_id}","starred_url":"https://api.github.com/users/unleashalicia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unleashalicia/subscriptions","organizations_url":"https://api.github.com/users/unleashalicia/orgs","repos_url":"https://api.github.com/users/unleashalicia/repos","events_url":"https://api.github.com/users/unleashalicia/events{/privacy}","received_events_url":"https://api.github.com/users/unleashalicia/received_events","type":"User","site_admin":false},"repo":{"id":114065803,"name":"c10.17_ghost_stories","full_name":"unleashalicia/c10.17_ghost_stories","owner":{"login":"unleashalicia","id":28938534,"avatar_url":"https://avatars1.githubusercontent.com/u/28938534?v=4","gravatar_id":"","url":"https://api.github.com/users/unleashalicia","html_url":"https://github.com/unleashalicia","followers_url":"https://api.github.com/users/unleashalicia/followers","following_url":"https://api.github.com/users/unleashalicia/following{/other_user}","gists_url":"https://api.github.com/users/unleashalicia/gists{/gist_id}","starred_url":"https://api.github.com/users/unleashalicia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unleashalicia/subscriptions","organizations_url":"https://api.github.com/users/unleashalicia/orgs","repos_url":"https://api.github.com/users/unleashalicia/repos","events_url":"https://api.github.com/users/unleashalicia/events{/privacy}","received_events_url":"https://api.github.com/users/unleashalicia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unleashalicia/c10.17_ghost_stories","description":"A ghost themed augmented reality app ","fork":true,"url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories","forks_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/forks","keys_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/teams","hooks_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/hooks","issue_events_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/events{/number}","events_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/events","assignees_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/assignees{/user}","branches_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/branches{/branch}","tags_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/tags","blobs_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/refs{/sha}","trees_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/statuses/{sha}","languages_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/languages","stargazers_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/stargazers","contributors_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/contributors","subscribers_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/subscribers","subscription_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/subscription","commits_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/commits{/sha}","git_commits_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/git/commits{/sha}","comments_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/comments{/number}","issue_comment_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/comments{/number}","contents_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/contents/{+path}","compare_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/merges","archive_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/downloads","issues_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues{/number}","pulls_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls{/number}","milestones_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/milestones{/number}","notifications_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/labels{/name}","releases_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/releases{/id}","deployments_url":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/deployments","created_at":"2017-12-13T02:53:14Z","updated_at":"2017-12-13T01:50:57Z","pushed_at":"2018-01-01T08:43:09Z","git_url":"git://github.com/unleashalicia/c10.17_ghost_stories.git","ssh_url":"git@github.com:unleashalicia/c10.17_ghost_stories.git","clone_url":"https://github.com/unleashalicia/c10.17_ghost_stories.git","svn_url":"https://github.com/unleashalicia/c10.17_ghost_stories","homepage":null,"size":25262,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15"},"html":{"href":"https://github.com/unleashalicia/c10.17_ghost_stories/pull/15"},"issue":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/15"},"comments":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/unleashalicia/c10.17_ghost_stories/statuses/1c64f33f4d63e454c420141a1ef65de19163a2a1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sloumdrone"}}