{"action":"created","comment":{"url":"https://api.github.com/repos/tableau/server-client-python/pulls/comments/102510410","pull_request_review_id":23268028,"id":102510410,"diff_hunk":"@@ -1,20 +1,31 @@\n from .endpoint import Endpoint\n from .exceptions import MissingRequiredFieldError\n-from .. import ViewItem, PaginationItem\n+from .resource_tagger import _ResourceTagger\n+from .. import RequestFactory, ViewItem, PaginationItem\n+from ...models.tag_item import TagItem\n import logging\n+import copy","path":"tableauserverclient/server/endpoint/views_endpoint.py","position":8,"original_position":8,"commit_id":"57d69f0f3e5a6db107e4dc0736cabd5f5b35e766","original_commit_id":"57d69f0f3e5a6db107e4dc0736cabd5f5b35e766","user":{"login":"RussTheAerialist","id":94549,"avatar_url":"https://avatars.githubusercontent.com/u/94549?v=3","gravatar_id":"","url":"https://api.github.com/users/RussTheAerialist","html_url":"https://github.com/RussTheAerialist","followers_url":"https://api.github.com/users/RussTheAerialist/followers","following_url":"https://api.github.com/users/RussTheAerialist/following{/other_user}","gists_url":"https://api.github.com/users/RussTheAerialist/gists{/gist_id}","starred_url":"https://api.github.com/users/RussTheAerialist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussTheAerialist/subscriptions","organizations_url":"https://api.github.com/users/RussTheAerialist/orgs","repos_url":"https://api.github.com/users/RussTheAerialist/repos","events_url":"https://api.github.com/users/RussTheAerialist/events{/privacy}","received_events_url":"https://api.github.com/users/RussTheAerialist/received_events","type":"User","site_admin":false},"body":"is this used anywhere?","created_at":"2017-02-22T16:42:01Z","updated_at":"2017-02-22T16:44:48Z","html_url":"https://github.com/tableau/server-client-python/pull/146#discussion_r102510410","pull_request_url":"https://api.github.com/repos/tableau/server-client-python/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/comments/102510410"},"html":{"href":"https://github.com/tableau/server-client-python/pull/146#discussion_r102510410"},"pull_request":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/tableau/server-client-python/pulls/146","id":106797984,"html_url":"https://github.com/tableau/server-client-python/pull/146","diff_url":"https://github.com/tableau/server-client-python/pull/146.diff","patch_url":"https://github.com/tableau/server-client-python/pull/146.patch","issue_url":"https://api.github.com/repos/tableau/server-client-python/issues/146","number":146,"state":"open","locked":false,"title":"Feature datasource and view tagging","user":{"login":"lbrendanl","id":5441045,"avatar_url":"https://avatars.githubusercontent.com/u/5441045?v=3","gravatar_id":"","url":"https://api.github.com/users/lbrendanl","html_url":"https://github.com/lbrendanl","followers_url":"https://api.github.com/users/lbrendanl/followers","following_url":"https://api.github.com/users/lbrendanl/following{/other_user}","gists_url":"https://api.github.com/users/lbrendanl/gists{/gist_id}","starred_url":"https://api.github.com/users/lbrendanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbrendanl/subscriptions","organizations_url":"https://api.github.com/users/lbrendanl/orgs","repos_url":"https://api.github.com/users/lbrendanl/repos","events_url":"https://api.github.com/users/lbrendanl/events{/privacy}","received_events_url":"https://api.github.com/users/lbrendanl/received_events","type":"User","site_admin":false},"body":"This adds the ability to add and delete tags from both datasources and views (currently only workbook tagging is supported through the REST API, even though you can tag datasources and views through Tableau).\r\n\r\nI pulled the tagging functionality into a base class that the views/workbooks/datasource items and endpoints classes now inherit from.  Manually tested and added some unit tests.","created_at":"2017-02-17T19:37:42Z","updated_at":"2017-02-22T16:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5448170ed8a1682eec2aba86a878fde77ed1394","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tableau/server-client-python/pulls/146/commits","review_comments_url":"https://api.github.com/repos/tableau/server-client-python/pulls/146/comments","review_comment_url":"https://api.github.com/repos/tableau/server-client-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tableau/server-client-python/issues/146/comments","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/57d69f0f3e5a6db107e4dc0736cabd5f5b35e766","head":{"label":"tableau:feature-datasource-and-view-tagging","ref":"feature-datasource-and-view-tagging","sha":"57d69f0f3e5a6db107e4dc0736cabd5f5b35e766","user":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"repo":{"id":62177327,"name":"server-client-python","full_name":"tableau/server-client-python","owner":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tableau/server-client-python","description":"A Python library for the Tableau Server REST API","fork":false,"url":"https://api.github.com/repos/tableau/server-client-python","forks_url":"https://api.github.com/repos/tableau/server-client-python/forks","keys_url":"https://api.github.com/repos/tableau/server-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tableau/server-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tableau/server-client-python/teams","hooks_url":"https://api.github.com/repos/tableau/server-client-python/hooks","issue_events_url":"https://api.github.com/repos/tableau/server-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/tableau/server-client-python/events","assignees_url":"https://api.github.com/repos/tableau/server-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/tableau/server-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/tableau/server-client-python/tags","blobs_url":"https://api.github.com/repos/tableau/server-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tableau/server-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tableau/server-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tableau/server-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tableau/server-client-python/languages","stargazers_url":"https://api.github.com/repos/tableau/server-client-python/stargazers","contributors_url":"https://api.github.com/repos/tableau/server-client-python/contributors","subscribers_url":"https://api.github.com/repos/tableau/server-client-python/subscribers","subscription_url":"https://api.github.com/repos/tableau/server-client-python/subscription","commits_url":"https://api.github.com/repos/tableau/server-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tableau/server-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tableau/server-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tableau/server-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tableau/server-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/tableau/server-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tableau/server-client-python/merges","archive_url":"https://api.github.com/repos/tableau/server-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tableau/server-client-python/downloads","issues_url":"https://api.github.com/repos/tableau/server-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/tableau/server-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tableau/server-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tableau/server-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tableau/server-client-python/labels{/name}","releases_url":"https://api.github.com/repos/tableau/server-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/tableau/server-client-python/deployments","created_at":"2016-06-28T22:05:32Z","updated_at":"2017-02-17T15:04:45Z","pushed_at":"2017-02-21T23:34:08Z","git_url":"git://github.com/tableau/server-client-python.git","ssh_url":"git@github.com:tableau/server-client-python.git","clone_url":"https://github.com/tableau/server-client-python.git","svn_url":"https://github.com/tableau/server-client-python","homepage":"https://tableau.github.io/server-client-python","size":562,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":35,"forks":20,"open_issues":35,"watchers":33,"default_branch":"master"}},"base":{"label":"tableau:vnext","ref":"vnext","sha":"668b52426531f85781587fb5e4deaf526f80b419","user":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"repo":{"id":62177327,"name":"server-client-python","full_name":"tableau/server-client-python","owner":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tableau/server-client-python","description":"A Python library for the Tableau Server REST API","fork":false,"url":"https://api.github.com/repos/tableau/server-client-python","forks_url":"https://api.github.com/repos/tableau/server-client-python/forks","keys_url":"https://api.github.com/repos/tableau/server-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tableau/server-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tableau/server-client-python/teams","hooks_url":"https://api.github.com/repos/tableau/server-client-python/hooks","issue_events_url":"https://api.github.com/repos/tableau/server-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/tableau/server-client-python/events","assignees_url":"https://api.github.com/repos/tableau/server-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/tableau/server-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/tableau/server-client-python/tags","blobs_url":"https://api.github.com/repos/tableau/server-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tableau/server-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tableau/server-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tableau/server-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tableau/server-client-python/languages","stargazers_url":"https://api.github.com/repos/tableau/server-client-python/stargazers","contributors_url":"https://api.github.com/repos/tableau/server-client-python/contributors","subscribers_url":"https://api.github.com/repos/tableau/server-client-python/subscribers","subscription_url":"https://api.github.com/repos/tableau/server-client-python/subscription","commits_url":"https://api.github.com/repos/tableau/server-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tableau/server-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tableau/server-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tableau/server-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tableau/server-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/tableau/server-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tableau/server-client-python/merges","archive_url":"https://api.github.com/repos/tableau/server-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tableau/server-client-python/downloads","issues_url":"https://api.github.com/repos/tableau/server-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/tableau/server-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tableau/server-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tableau/server-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tableau/server-client-python/labels{/name}","releases_url":"https://api.github.com/repos/tableau/server-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/tableau/server-client-python/deployments","created_at":"2016-06-28T22:05:32Z","updated_at":"2017-02-17T15:04:45Z","pushed_at":"2017-02-21T23:34:08Z","git_url":"git://github.com/tableau/server-client-python.git","ssh_url":"git@github.com:tableau/server-client-python.git","clone_url":"https://github.com/tableau/server-client-python.git","svn_url":"https://github.com/tableau/server-client-python","homepage":"https://tableau.github.io/server-client-python","size":562,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":35,"forks":20,"open_issues":35,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/146"},"html":{"href":"https://github.com/tableau/server-client-python/pull/146"},"issue":{"href":"https://api.github.com/repos/tableau/server-client-python/issues/146"},"comments":{"href":"https://api.github.com/repos/tableau/server-client-python/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/tableau/server-client-python/statuses/57d69f0f3e5a6db107e4dc0736cabd5f5b35e766"}}}}
{"actor":{"display_login":"RussTheAerialist"}}