{"action":"created","issue":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/606","repository_url":"https://api.github.com/repos/AliceO2Group/AliceO2","labels_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/606/labels{/name}","comments_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/606/comments","events_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/606/events","html_url":"https://github.com/AliceO2Group/AliceO2/pull/606","id":263064764,"number":606,"title":"Update code affected by breaking FairMQ changes.","user":{"login":"rbx","id":1915061,"avatar_url":"https://avatars3.githubusercontent.com/u/1915061?v=4","gravatar_id":"","url":"https://api.github.com/users/rbx","html_url":"https://github.com/rbx","followers_url":"https://api.github.com/users/rbx/followers","following_url":"https://api.github.com/users/rbx/following{/other_user}","gists_url":"https://api.github.com/users/rbx/gists{/gist_id}","starred_url":"https://api.github.com/users/rbx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbx/subscriptions","organizations_url":"https://api.github.com/users/rbx/orgs","repos_url":"https://api.github.com/users/rbx/repos","events_url":"https://api.github.com/users/rbx/events{/privacy}","received_events_url":"https://api.github.com/users/rbx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-05T09:49:18Z","updated_at":"2017-10-05T09:51:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/pulls/606","html_url":"https://github.com/AliceO2Group/AliceO2/pull/606","diff_url":"https://github.com/AliceO2Group/AliceO2/pull/606.diff","patch_url":"https://github.com/AliceO2Group/AliceO2/pull/606.patch"},"body":"This patch adapts O2 code to breaking FairMQ changes (coming to FairRoot dev branch when FairRootGroup/FairRoot#607 is merged). Merge after the FairRoot PR is merged (and O2 fork is updated).\r\n\r\nFollowing changes require update of O2 code (done in this PR):\r\n\r\n- removal of `FairMQConfigurable`.\r\n  - Since long unused by O2, but still some remaining dead code (`FairMQDevice::Last`). (**backwards-compatible**)\r\n- FairMQLogger header no longer includes `<iostream>`.\r\n  - Some includes must be added in O2. (**backwards-compatible**)\r\n- introduction of `DeviceRunner`, control/config plugins, removal of `runSimpleMQStateMachine`.\r\n  - This simplifies some of the setup code for devices that have custom `main()`. For O2 this is `Framework/Core/src/runDataProcessing` (fixed in this PR) and QC devices (this PR brings them to working state, however maintainers should consider switching them to use DeviceRunner/plugins, as no custom main is required for them. Feel free to contact me if help with this is needed). (**non-backwards-compatible**)\r\n"},"comment":{"url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/comments/334416596","html_url":"https://github.com/AliceO2Group/AliceO2/pull/606#issuecomment-334416596","issue_url":"https://api.github.com/repos/AliceO2Group/AliceO2/issues/606","id":334416596,"user":{"login":"alibuild","id":13233178,"avatar_url":"https://avatars0.githubusercontent.com/u/13233178?v=4","gravatar_id":"","url":"https://api.github.com/users/alibuild","html_url":"https://github.com/alibuild","followers_url":"https://api.github.com/users/alibuild/followers","following_url":"https://api.github.com/users/alibuild/following{/other_user}","gists_url":"https://api.github.com/users/alibuild/gists{/gist_id}","starred_url":"https://api.github.com/users/alibuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibuild/subscriptions","organizations_url":"https://api.github.com/users/alibuild/orgs","repos_url":"https://api.github.com/users/alibuild/repos","events_url":"https://api.github.com/users/alibuild/events{/privacy}","received_events_url":"https://api.github.com/users/alibuild/received_events","type":"User","site_admin":false},"created_at":"2017-10-05T09:51:30Z","updated_at":"2017-10-05T09:51:30Z","author_association":"COLLABORATOR","body":"Error while checking build/O2/o2-dev-fairroot for 2842b754576e12c659f41e8590eb89305baceb60:\n```\nsw/BUILD/O2-latest/log\n[ 26%] Built target standalone-client\n[ 26%] Built target testCachingTF1\n[ 26%] Built target testCartesian3D\n[ 28%] Built target Field\n[ 29%] Built target testSimConf\n[ 29%] Built target test_HeartbeatFrame\n[ 29%] Built target testTimeStamp\n[ 30%] Built target testDataHeader\n[ 30%] Built target TimeFrame\n[ 32%] Built target DetectorsBase\n[ 32%] Built target testTPCBase\n[ 33%] Built target testTPCCalDet\n[ 34%] Built target testTPCMapper\n[ 34%] Built target testTPCParameters\n[ 34%] Built target EventVisualisationDataConverter\n[ 34%] Built target testEPN\n[ 34%] Built target testProxy\n[ 34%] Built target testFLP\n[ 35%] Built target testExampleModule1\n[ 35%] Built target runExampleModule1\n[ 36%] Built target ExampleModule2\nScanning dependencies of target Framework\n[ 37%] Linking CXX shared library ../../lib/libSimulationDataFormat.so\n[ 37%] Building CXX object Framework/Core/CMakeFiles/Framework.dir/src/TextControlService.cxx.o\n[ 37%] Built target SimulationDataFormat\n[ 37%] Building CXX object Framework/Core/CMakeFiles/Framework.dir/src/runDataProcessing.cxx.o\n/mnt/mesos/sandbox/sandbox/sw/SOURCES/O2/0_O2_DEV_FAIRROOT/0/Framework/Core/src/runDataProcessing.cxx:52:33: fatal error: fairmq/DeviceRunner.h: No such file or directory\n #include <fairmq/DeviceRunner.h>\n                                 ^\ncompilation terminated.\nmake[2]: *** [Framework/Core/CMakeFiles/Framework.dir/src/runDataProcessing.cxx.o] Error 1\nmake[2]: *** Waiting for unfinished jobs....\nScanning dependencies of target aliceHLTwrapper\n[ 38%] Building CXX object Utilities/aliceHLTwrapper/CMakeFiles/aliceHLTwrapper.dir/src/WrapperDevice.cxx.o\n[ 38%] Linking CXX shared library ../../../lib/libQCMerger.so\n[ 38%] Built target QCMerger\n[ 39%] Built target O2MessageMonitorTest\n[ 39%] Built target runO2MessageMonitor\nScanning dependencies of target runQCProducerDevice\n[ 39%] Building CXX object Utilities/QC/QCProducer/CMakeFiles/runQCProducerDevice.dir/src/runProducer.cxx.o\nmake[1]: *** [Framework/Core/CMakeFiles/Framework.dir/all] Error 2\nmake[1]: *** Waiting for unfinished jobs....\n[ 39%] Building CXX object Utilities/aliceHLTwrapper/CMakeFiles/aliceHLTwrapper.dir/src/EventSampler.cxx.o\n[ 39%] Linking CXX shared library ../../lib/libFLP2EPNex_distributed.so\n[ 39%] Built target FLP2EPNex_distributed\n[ 39%] Linking CXX executable ../../../bin/runQCProducerDevice\n[ 39%] Built target runQCProducerDevice\n[ 39%] Linking CXX shared library ../../lib/libaliceHLTwrapper.so\n[ 39%] Built target aliceHLTwrapper\n```\nFull log [here](https://ali-ci.cern.ch/repo/logs/AliceO2Group/AliceO2/606/2842b754576e12c659f41e8590eb89305baceb60/fullLog.txt).\n"}}
{"actor":{"display_login":"alibuild"}}