{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/154698662","pull_request_review_id":80900192,"id":154698662,"diff_hunk":"@@ -168,3 +182,24 @@ func (t *TLSConfig) Merge(b *TLSConfig) *TLSConfig {\n \t}\n \treturn result\n }\n+\n+// Equals compares the fields of two TLS configuration objects, returning a\n+// boolean indicating if they are the same.\n+// NewConfig should never be nil- calling code is responsible for walways\n+// passing a valid TLSConfig object\n+func (t *TLSConfig) Equals(newConfig *TLSConfig) bool {\n+\tif t == nil {\n+\t\treturn false\n+\t}\n+\n+\tif t == nil && newConfig != nil {","path":"nomad/structs/config/tls.go","position":null,"original_position":35,"commit_id":"9898354a6a239e6f9e058a493083725bc23038b2","original_commit_id":"cbbeeaae7ed88f3617c55e76b99e659a1d4c3efc","user":{"login":"chelseakomlo","id":2530163,"avatar_url":"https://avatars2.githubusercontent.com/u/2530163?v=4","gravatar_id":"","url":"https://api.github.com/users/chelseakomlo","html_url":"https://github.com/chelseakomlo","followers_url":"https://api.github.com/users/chelseakomlo/followers","following_url":"https://api.github.com/users/chelseakomlo/following{/other_user}","gists_url":"https://api.github.com/users/chelseakomlo/gists{/gist_id}","starred_url":"https://api.github.com/users/chelseakomlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chelseakomlo/subscriptions","organizations_url":"https://api.github.com/users/chelseakomlo/orgs","repos_url":"https://api.github.com/users/chelseakomlo/repos","events_url":"https://api.github.com/users/chelseakomlo/events{/privacy}","received_events_url":"https://api.github.com/users/chelseakomlo/received_events","type":"User","site_admin":false},"body":"Both could equal nil, although neither _should_. I see your point about removing the checks though, and letting a failure occur in the case the caller does mistakenly does call this method on a nil pointer or pass nil as a parameter. ","created_at":"2017-12-04T16:25:52Z","updated_at":"2017-12-04T16:25:53Z","html_url":"https://github.com/hashicorp/nomad/pull/3492#discussion_r154698662","pull_request_url":"https://api.github.com/repos/hashicorp/nomad/pulls/3492","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/154698662"},"html":{"href":"https://github.com/hashicorp/nomad/pull/3492#discussion_r154698662"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/3492"}},"in_reply_to_id":154475058},"pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/3492","id":150369089,"html_url":"https://github.com/hashicorp/nomad/pull/3492","diff_url":"https://github.com/hashicorp/nomad/pull/3492.diff","patch_url":"https://github.com/hashicorp/nomad/pull/3492.patch","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/3492","number":3492,"state":"open","locked":false,"title":"Client/Server TLS dynamic reload","user":{"login":"chelseakomlo","id":2530163,"avatar_url":"https://avatars2.githubusercontent.com/u/2530163?v=4","gravatar_id":"","url":"https://api.github.com/users/chelseakomlo","html_url":"https://github.com/chelseakomlo","followers_url":"https://api.github.com/users/chelseakomlo/followers","following_url":"https://api.github.com/users/chelseakomlo/following{/other_user}","gists_url":"https://api.github.com/users/chelseakomlo/gists{/gist_id}","starred_url":"https://api.github.com/users/chelseakomlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chelseakomlo/subscriptions","organizations_url":"https://api.github.com/users/chelseakomlo/orgs","repos_url":"https://api.github.com/users/chelseakomlo/repos","events_url":"https://api.github.com/users/chelseakomlo/events{/privacy}","received_events_url":"https://api.github.com/users/chelseakomlo/received_events","type":"User","site_admin":false},"body":"This PR includes: \r\n- Upgrading/downgrading from non-TLS connections to TLS via SIGHUP\r\n- Closing long-lived connections on reload (HTTP, RPC, Raft) \r\n\r\n- Thorough testing is needed for clients, servers, and at larger cluster sizes. \r\n\r\n","created_at":"2017-11-02T18:24:34Z","updated_at":"2017-12-04T16:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d966dfa16afbec0aec8aa57185a224b66893d66","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/nomad/pulls/3492/commits","review_comments_url":"https://api.github.com/repos/hashicorp/nomad/pulls/3492/comments","review_comment_url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/3492/comments","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/9898354a6a239e6f9e058a493083725bc23038b2","head":{"label":"hashicorp:f-client-tls-reload","ref":"f-client-tls-reload","sha":"9898354a6a239e6f9e058a493083725bc23038b2","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"name":"nomad","full_name":"hashicorp/nomad","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a highly available, distributed, data-center aware cluster and application scheduler designed to support the modern datacenter with support for long-running services, batch jobs, and much more.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2017-12-04T09:40:23Z","pushed_at":"2017-12-04T16:22:11Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":48386,"stargazers_count":3057,"watchers_count":3057,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":587,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":587,"open_issues":330,"watchers":3057,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"619189e7a9c6baa80d843677070dfae4b329cc82","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"name":"nomad","full_name":"hashicorp/nomad","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a highly available, distributed, data-center aware cluster and application scheduler designed to support the modern datacenter with support for long-running services, batch jobs, and much more.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2017-12-04T09:40:23Z","pushed_at":"2017-12-04T16:22:11Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":48386,"stargazers_count":3057,"watchers_count":3057,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":587,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":587,"open_issues":330,"watchers":3057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/3492"},"html":{"href":"https://github.com/hashicorp/nomad/pull/3492"},"issue":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/3492"},"comments":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/3492/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/3492/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/3492/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/nomad/statuses/9898354a6a239e6f9e058a493083725bc23038b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chelseakomlo"}}