{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/126505314","pull_request_review_id":48995944,"id":126505314,"diff_hunk":"@@ -84,7 +84,7 @@ func (s *RestartTestData) TestVolumeDetached(c *C) {\n \tc.Assert(err, IsNil, Commentf(out))\n \n \t// 4. Verify detached status. Volume should be detached (within the timeout)\n-\tstatus = verification.VerifyDetachedStatus(s.volumeName, s.config.DockerHosts[1], s.config.EsxHost)\n+\tstatus = verification.PollDetachedStatus(s.volumeName, s.config.DockerHosts[1], s.config.EsxHost)","path":"tests/e2e/restart_test.go","position":15,"original_position":15,"commit_id":"b14dff3799f79d3873a53aaf714c7a06fdea392d","original_commit_id":"b14dff3799f79d3873a53aaf714c7a06fdea392d","user":{"login":"govint","id":15854712,"avatar_url":"https://avatars0.githubusercontent.com/u/15854712?v=3","gravatar_id":"","url":"https://api.github.com/users/govint","html_url":"https://github.com/govint","followers_url":"https://api.github.com/users/govint/followers","following_url":"https://api.github.com/users/govint/following{/other_user}","gists_url":"https://api.github.com/users/govint/gists{/gist_id}","starred_url":"https://api.github.com/users/govint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govint/subscriptions","organizations_url":"https://api.github.com/users/govint/orgs","repos_url":"https://api.github.com/users/govint/repos","events_url":"https://api.github.com/users/govint/events{/privacy}","received_events_url":"https://api.github.com/users/govint/received_events","type":"User","site_admin":false},"body":"Actually, the admin CLi and docker cli ways of getting the volume status is the same - from the KV. So there's no difference in getting the status from the ESX side. Just doing a docker inspect is sufficient.  Which is why I was pointing to the newly added function. An instantaneous result is something that can change and doesn't require needing multiple checks (which are based off the same source anyway).","created_at":"2017-07-10T18:48:02Z","updated_at":"2017-07-10T18:48:03Z","html_url":"https://github.com/vmware/docker-volume-vsphere/pull/1552#discussion_r126505314","pull_request_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552","_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/126505314"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/1552#discussion_r126505314"},"pull_request":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552","id":129308434,"html_url":"https://github.com/vmware/docker-volume-vsphere/pull/1552","diff_url":"https://github.com/vmware/docker-volume-vsphere/pull/1552.diff","patch_url":"https://github.com/vmware/docker-volume-vsphere/pull/1552.patch","issue_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1552","number":1552,"state":"open","locked":false,"title":"Test util to verify detached status and poll the detached status of a volume","user":{"login":"pshahzeb","id":25597778,"avatar_url":"https://avatars3.githubusercontent.com/u/25597778?v=3","gravatar_id":"","url":"https://api.github.com/users/pshahzeb","html_url":"https://github.com/pshahzeb","followers_url":"https://api.github.com/users/pshahzeb/followers","following_url":"https://api.github.com/users/pshahzeb/following{/other_user}","gists_url":"https://api.github.com/users/pshahzeb/gists{/gist_id}","starred_url":"https://api.github.com/users/pshahzeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshahzeb/subscriptions","organizations_url":"https://api.github.com/users/pshahzeb/orgs","repos_url":"https://api.github.com/users/pshahzeb/repos","events_url":"https://api.github.com/users/pshahzeb/events{/privacy}","received_events_url":"https://api.github.com/users/pshahzeb/received_events","type":"User","site_admin":false},"body":"This PR does two things.\r\n1. Removes unnecessary wait in VerifyDetachedStatus. It instantly checks if the status is \"detached\". This is used in most of the places except destructive test scenarios i.e. restarts and failovers.\r\n\r\n2. PollDetachedStatus retries to make check if volume status is detached. This is used in scenarios of restarts and failovers where plugin takes a bit of time to stabilize.\r\n\r\nTesting:\r\ntest-e2e passes locally.\r\n```\r\n2017/07/07 00:10:51 END: VsanTestSuite.TestValidPolicy\r\n2017/07/07 00:10:51 Destroying volume [vsanVol_volume_400787@vsanDatastore]\r\n2017/07/07 00:10:52 Removing policy [validPolicy] on esx [10.192.248.54]\r\n--- PASS: Test (926.32s)\r\nPASS\r\nOK: 30 passed\r\nok  \tgithub.com/vmware/docker-volume-vsphere/tests/e2e\t926.330s\r\n```\r\n\r\nFixes #1528","created_at":"2017-07-07T00:34:33Z","updated_at":"2017-07-10T18:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbf8b76b7d85124c84089c960a69c7e559c96646","assignee":{"login":"pshahzeb","id":25597778,"avatar_url":"https://avatars3.githubusercontent.com/u/25597778?v=3","gravatar_id":"","url":"https://api.github.com/users/pshahzeb","html_url":"https://github.com/pshahzeb","followers_url":"https://api.github.com/users/pshahzeb/followers","following_url":"https://api.github.com/users/pshahzeb/following{/other_user}","gists_url":"https://api.github.com/users/pshahzeb/gists{/gist_id}","starred_url":"https://api.github.com/users/pshahzeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshahzeb/subscriptions","organizations_url":"https://api.github.com/users/pshahzeb/orgs","repos_url":"https://api.github.com/users/pshahzeb/repos","events_url":"https://api.github.com/users/pshahzeb/events{/privacy}","received_events_url":"https://api.github.com/users/pshahzeb/received_events","type":"User","site_admin":false},"assignees":[{"login":"pshahzeb","id":25597778,"avatar_url":"https://avatars3.githubusercontent.com/u/25597778?v=3","gravatar_id":"","url":"https://api.github.com/users/pshahzeb","html_url":"https://github.com/pshahzeb","followers_url":"https://api.github.com/users/pshahzeb/followers","following_url":"https://api.github.com/users/pshahzeb/following{/other_user}","gists_url":"https://api.github.com/users/pshahzeb/gists{/gist_id}","starred_url":"https://api.github.com/users/pshahzeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshahzeb/subscriptions","organizations_url":"https://api.github.com/users/pshahzeb/orgs","repos_url":"https://api.github.com/users/pshahzeb/repos","events_url":"https://api.github.com/users/pshahzeb/events{/privacy}","received_events_url":"https://api.github.com/users/pshahzeb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552/commits","review_comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552/comments","review_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1552/comments","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/b14dff3799f79d3873a53aaf714c7a06fdea392d","head":{"label":"pshahzeb:issue_1528","ref":"issue_1528","sha":"b14dff3799f79d3873a53aaf714c7a06fdea392d","user":{"login":"pshahzeb","id":25597778,"avatar_url":"https://avatars3.githubusercontent.com/u/25597778?v=3","gravatar_id":"","url":"https://api.github.com/users/pshahzeb","html_url":"https://github.com/pshahzeb","followers_url":"https://api.github.com/users/pshahzeb/followers","following_url":"https://api.github.com/users/pshahzeb/following{/other_user}","gists_url":"https://api.github.com/users/pshahzeb/gists{/gist_id}","starred_url":"https://api.github.com/users/pshahzeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshahzeb/subscriptions","organizations_url":"https://api.github.com/users/pshahzeb/orgs","repos_url":"https://api.github.com/users/pshahzeb/repos","events_url":"https://api.github.com/users/pshahzeb/events{/privacy}","received_events_url":"https://api.github.com/users/pshahzeb/received_events","type":"User","site_admin":false},"repo":{"id":91139673,"name":"docker-volume-vsphere","full_name":"pshahzeb/docker-volume-vsphere","owner":{"login":"pshahzeb","id":25597778,"avatar_url":"https://avatars3.githubusercontent.com/u/25597778?v=3","gravatar_id":"","url":"https://api.github.com/users/pshahzeb","html_url":"https://github.com/pshahzeb","followers_url":"https://api.github.com/users/pshahzeb/followers","following_url":"https://api.github.com/users/pshahzeb/following{/other_user}","gists_url":"https://api.github.com/users/pshahzeb/gists{/gist_id}","starred_url":"https://api.github.com/users/pshahzeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshahzeb/subscriptions","organizations_url":"https://api.github.com/users/pshahzeb/orgs","repos_url":"https://api.github.com/users/pshahzeb/repos","events_url":"https://api.github.com/users/pshahzeb/events{/privacy}","received_events_url":"https://api.github.com/users/pshahzeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pshahzeb/docker-volume-vsphere","description":"vSphere Docker Volume Service","fork":true,"url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere","forks_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/pshahzeb/docker-volume-vsphere/deployments","created_at":"2017-05-13T00:48:28Z","updated_at":"2017-05-13T00:48:30Z","pushed_at":"2017-07-10T17:23:21Z","git_url":"git://github.com/pshahzeb/docker-volume-vsphere.git","ssh_url":"git@github.com:pshahzeb/docker-volume-vsphere.git","clone_url":"https://github.com/pshahzeb/docker-volume-vsphere.git","svn_url":"https://github.com/pshahzeb/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":15342,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"3337e4ca9be50140b567120ca84def3e8ed59e8c","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49599693,"name":"docker-volume-vsphere","full_name":"vmware/docker-volume-vsphere","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/docker-volume-vsphere","description":"vSphere Docker Volume Service","fork":false,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere","forks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/deployments","created_at":"2016-01-13T20:25:36Z","updated_at":"2017-07-10T18:15:02Z","pushed_at":"2017-07-10T18:43:41Z","git_url":"git://github.com/vmware/docker-volume-vsphere.git","ssh_url":"git@github.com:vmware/docker-volume-vsphere.git","clone_url":"https://github.com/vmware/docker-volume-vsphere.git","svn_url":"https://github.com/vmware/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":18107,"stargazers_count":148,"watchers_count":148,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":189,"forks":44,"open_issues":189,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/1552"},"issue":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1552"},"comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1552/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1552/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/b14dff3799f79d3873a53aaf714c7a06fdea392d"}}}}
{"actor":{"display_login":"govint"}}