{"action":"opened","number":68,"pull_request":{"url":"https://api.github.com/repos/eblot/pyftdi/pulls/68","id":138114926,"html_url":"https://github.com/eblot/pyftdi/pull/68","diff_url":"https://github.com/eblot/pyftdi/pull/68.diff","patch_url":"https://github.com/eblot/pyftdi/pull/68.patch","issue_url":"https://api.github.com/repos/eblot/pyftdi/issues/68","number":68,"state":"open","locked":false,"title":"serialext: Fix timeout interpretation","user":{"login":"vianney","id":244908,"avatar_url":"https://avatars2.githubusercontent.com/u/244908?v=4","gravatar_id":"","url":"https://api.github.com/users/vianney","html_url":"https://github.com/vianney","followers_url":"https://api.github.com/users/vianney/followers","following_url":"https://api.github.com/users/vianney/following{/other_user}","gists_url":"https://api.github.com/users/vianney/gists{/gist_id}","starred_url":"https://api.github.com/users/vianney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vianney/subscriptions","organizations_url":"https://api.github.com/users/vianney/orgs","repos_url":"https://api.github.com/users/vianney/repos","events_url":"https://api.github.com/users/vianney/events{/privacy}","received_events_url":"https://api.github.com/users/vianney/received_events","type":"User","site_admin":false},"body":"According to the pySerial API documentation, the possible values for the\r\ntimeout parameter are:\r\n\r\n* `timeout = None`: wait forever / until requested number of bytes are\r\n  received;\r\n* `timeout = 0`: non-blocking mode, return immediately in any case,\r\n  returning zero or more, up to the requested number of bytes;\r\n* `timeout = x`: set timeout to x seconds (float allowed) returns\r\n  immediately when the requested number of bytes are available,\r\n  otherwise wait until the timeout expires and return all bytes that\r\n  were received until then.\r\n\r\nThe FtdiSerial class did not comply with this specification, as it\r\ntreated timeout = 0 as wait forever, and crashes when timeout is None.","created_at":"2017-08-29T08:12:22Z","updated_at":"2017-08-29T08:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eblot/pyftdi/pulls/68/commits","review_comments_url":"https://api.github.com/repos/eblot/pyftdi/pulls/68/comments","review_comment_url":"https://api.github.com/repos/eblot/pyftdi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eblot/pyftdi/issues/68/comments","statuses_url":"https://api.github.com/repos/eblot/pyftdi/statuses/6c298a4c421a98368302fa826cf6777f36016b7f","head":{"label":"vianney:serial-timeout","ref":"serial-timeout","sha":"6c298a4c421a98368302fa826cf6777f36016b7f","user":{"login":"vianney","id":244908,"avatar_url":"https://avatars2.githubusercontent.com/u/244908?v=4","gravatar_id":"","url":"https://api.github.com/users/vianney","html_url":"https://github.com/vianney","followers_url":"https://api.github.com/users/vianney/followers","following_url":"https://api.github.com/users/vianney/following{/other_user}","gists_url":"https://api.github.com/users/vianney/gists{/gist_id}","starred_url":"https://api.github.com/users/vianney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vianney/subscriptions","organizations_url":"https://api.github.com/users/vianney/orgs","repos_url":"https://api.github.com/users/vianney/repos","events_url":"https://api.github.com/users/vianney/events{/privacy}","received_events_url":"https://api.github.com/users/vianney/received_events","type":"User","site_admin":false},"repo":{"id":101734338,"name":"pyftdi","full_name":"vianney/pyftdi","owner":{"login":"vianney","id":244908,"avatar_url":"https://avatars2.githubusercontent.com/u/244908?v=4","gravatar_id":"","url":"https://api.github.com/users/vianney","html_url":"https://github.com/vianney","followers_url":"https://api.github.com/users/vianney/followers","following_url":"https://api.github.com/users/vianney/following{/other_user}","gists_url":"https://api.github.com/users/vianney/gists{/gist_id}","starred_url":"https://api.github.com/users/vianney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vianney/subscriptions","organizations_url":"https://api.github.com/users/vianney/orgs","repos_url":"https://api.github.com/users/vianney/repos","events_url":"https://api.github.com/users/vianney/events{/privacy}","received_events_url":"https://api.github.com/users/vianney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vianney/pyftdi","description":"FTDI device driver written in pure Python","fork":true,"url":"https://api.github.com/repos/vianney/pyftdi","forks_url":"https://api.github.com/repos/vianney/pyftdi/forks","keys_url":"https://api.github.com/repos/vianney/pyftdi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vianney/pyftdi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vianney/pyftdi/teams","hooks_url":"https://api.github.com/repos/vianney/pyftdi/hooks","issue_events_url":"https://api.github.com/repos/vianney/pyftdi/issues/events{/number}","events_url":"https://api.github.com/repos/vianney/pyftdi/events","assignees_url":"https://api.github.com/repos/vianney/pyftdi/assignees{/user}","branches_url":"https://api.github.com/repos/vianney/pyftdi/branches{/branch}","tags_url":"https://api.github.com/repos/vianney/pyftdi/tags","blobs_url":"https://api.github.com/repos/vianney/pyftdi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vianney/pyftdi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vianney/pyftdi/git/refs{/sha}","trees_url":"https://api.github.com/repos/vianney/pyftdi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vianney/pyftdi/statuses/{sha}","languages_url":"https://api.github.com/repos/vianney/pyftdi/languages","stargazers_url":"https://api.github.com/repos/vianney/pyftdi/stargazers","contributors_url":"https://api.github.com/repos/vianney/pyftdi/contributors","subscribers_url":"https://api.github.com/repos/vianney/pyftdi/subscribers","subscription_url":"https://api.github.com/repos/vianney/pyftdi/subscription","commits_url":"https://api.github.com/repos/vianney/pyftdi/commits{/sha}","git_commits_url":"https://api.github.com/repos/vianney/pyftdi/git/commits{/sha}","comments_url":"https://api.github.com/repos/vianney/pyftdi/comments{/number}","issue_comment_url":"https://api.github.com/repos/vianney/pyftdi/issues/comments{/number}","contents_url":"https://api.github.com/repos/vianney/pyftdi/contents/{+path}","compare_url":"https://api.github.com/repos/vianney/pyftdi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vianney/pyftdi/merges","archive_url":"https://api.github.com/repos/vianney/pyftdi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vianney/pyftdi/downloads","issues_url":"https://api.github.com/repos/vianney/pyftdi/issues{/number}","pulls_url":"https://api.github.com/repos/vianney/pyftdi/pulls{/number}","milestones_url":"https://api.github.com/repos/vianney/pyftdi/milestones{/number}","notifications_url":"https://api.github.com/repos/vianney/pyftdi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vianney/pyftdi/labels{/name}","releases_url":"https://api.github.com/repos/vianney/pyftdi/releases{/id}","deployments_url":"https://api.github.com/repos/vianney/pyftdi/deployments","created_at":"2017-08-29T07:48:06Z","updated_at":"2017-08-29T07:48:08Z","pushed_at":"2017-08-29T07:49:15Z","git_url":"git://github.com/vianney/pyftdi.git","ssh_url":"git@github.com:vianney/pyftdi.git","clone_url":"https://github.com/vianney/pyftdi.git","svn_url":"https://github.com/vianney/pyftdi","homepage":"","size":1902,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eblot:master","ref":"master","sha":"5350c6a62a063c6aca1c0c128ca7a978f73eb6e7","user":{"login":"eblot","id":172423,"avatar_url":"https://avatars1.githubusercontent.com/u/172423?v=4","gravatar_id":"","url":"https://api.github.com/users/eblot","html_url":"https://github.com/eblot","followers_url":"https://api.github.com/users/eblot/followers","following_url":"https://api.github.com/users/eblot/following{/other_user}","gists_url":"https://api.github.com/users/eblot/gists{/gist_id}","starred_url":"https://api.github.com/users/eblot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eblot/subscriptions","organizations_url":"https://api.github.com/users/eblot/orgs","repos_url":"https://api.github.com/users/eblot/repos","events_url":"https://api.github.com/users/eblot/events{/privacy}","received_events_url":"https://api.github.com/users/eblot/received_events","type":"User","site_admin":false},"repo":{"id":1162758,"name":"pyftdi","full_name":"eblot/pyftdi","owner":{"login":"eblot","id":172423,"avatar_url":"https://avatars1.githubusercontent.com/u/172423?v=4","gravatar_id":"","url":"https://api.github.com/users/eblot","html_url":"https://github.com/eblot","followers_url":"https://api.github.com/users/eblot/followers","following_url":"https://api.github.com/users/eblot/following{/other_user}","gists_url":"https://api.github.com/users/eblot/gists{/gist_id}","starred_url":"https://api.github.com/users/eblot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eblot/subscriptions","organizations_url":"https://api.github.com/users/eblot/orgs","repos_url":"https://api.github.com/users/eblot/repos","events_url":"https://api.github.com/users/eblot/events{/privacy}","received_events_url":"https://api.github.com/users/eblot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eblot/pyftdi","description":"FTDI device driver written in pure Python","fork":false,"url":"https://api.github.com/repos/eblot/pyftdi","forks_url":"https://api.github.com/repos/eblot/pyftdi/forks","keys_url":"https://api.github.com/repos/eblot/pyftdi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eblot/pyftdi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eblot/pyftdi/teams","hooks_url":"https://api.github.com/repos/eblot/pyftdi/hooks","issue_events_url":"https://api.github.com/repos/eblot/pyftdi/issues/events{/number}","events_url":"https://api.github.com/repos/eblot/pyftdi/events","assignees_url":"https://api.github.com/repos/eblot/pyftdi/assignees{/user}","branches_url":"https://api.github.com/repos/eblot/pyftdi/branches{/branch}","tags_url":"https://api.github.com/repos/eblot/pyftdi/tags","blobs_url":"https://api.github.com/repos/eblot/pyftdi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eblot/pyftdi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eblot/pyftdi/git/refs{/sha}","trees_url":"https://api.github.com/repos/eblot/pyftdi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eblot/pyftdi/statuses/{sha}","languages_url":"https://api.github.com/repos/eblot/pyftdi/languages","stargazers_url":"https://api.github.com/repos/eblot/pyftdi/stargazers","contributors_url":"https://api.github.com/repos/eblot/pyftdi/contributors","subscribers_url":"https://api.github.com/repos/eblot/pyftdi/subscribers","subscription_url":"https://api.github.com/repos/eblot/pyftdi/subscription","commits_url":"https://api.github.com/repos/eblot/pyftdi/commits{/sha}","git_commits_url":"https://api.github.com/repos/eblot/pyftdi/git/commits{/sha}","comments_url":"https://api.github.com/repos/eblot/pyftdi/comments{/number}","issue_comment_url":"https://api.github.com/repos/eblot/pyftdi/issues/comments{/number}","contents_url":"https://api.github.com/repos/eblot/pyftdi/contents/{+path}","compare_url":"https://api.github.com/repos/eblot/pyftdi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eblot/pyftdi/merges","archive_url":"https://api.github.com/repos/eblot/pyftdi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eblot/pyftdi/downloads","issues_url":"https://api.github.com/repos/eblot/pyftdi/issues{/number}","pulls_url":"https://api.github.com/repos/eblot/pyftdi/pulls{/number}","milestones_url":"https://api.github.com/repos/eblot/pyftdi/milestones{/number}","notifications_url":"https://api.github.com/repos/eblot/pyftdi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eblot/pyftdi/labels{/name}","releases_url":"https://api.github.com/repos/eblot/pyftdi/releases{/id}","deployments_url":"https://api.github.com/repos/eblot/pyftdi/deployments","created_at":"2010-12-13T00:49:37Z","updated_at":"2017-08-27T13:13:56Z","pushed_at":"2017-08-28T07:42:22Z","git_url":"git://github.com/eblot/pyftdi.git","ssh_url":"git@github.com:eblot/pyftdi.git","clone_url":"https://github.com/eblot/pyftdi.git","svn_url":"https://github.com/eblot/pyftdi","homepage":"","size":1902,"stargazers_count":74,"watchers_count":74,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":11,"forks":43,"open_issues":11,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eblot/pyftdi/pulls/68"},"html":{"href":"https://github.com/eblot/pyftdi/pull/68"},"issue":{"href":"https://api.github.com/repos/eblot/pyftdi/issues/68"},"comments":{"href":"https://api.github.com/repos/eblot/pyftdi/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/eblot/pyftdi/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/eblot/pyftdi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eblot/pyftdi/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/eblot/pyftdi/statuses/6c298a4c421a98368302fa826cf6777f36016b7f"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"vianney"}}