{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/comments/134884273","pull_request_review_id":58230886,"id":134884273,"diff_hunk":"@@ -74,4 +81,21 @@ public function testCatchAllExceptionsWithInstanceVarTest()\n         $this->runEventuallyConsistentTest($func, $retries);\n         $this->assertEquals($i, $retries);\n     }\n+    /**\n+     * @expectedException \\Exception\n+     */\n+    public function testNoCatchAllExceptionsTest()\n+    {\n+        $retries = 4;\n+        $i = 0;\n+        $func = function () use (&$i, $retries) {\n+            if (++$i == $retries) {\n+                // return on the final retry\n+                return;\n+            }\n+            throw new \\Exception('Something goes wrong');\n+        };\n+        $this->runEventuallyConsistentTest($func, $retries);\n+        $this->assertEquals($i, $retries);","path":"test/EventuallyConsistentTestTraitTest.php","position":49,"original_position":33,"commit_id":"0bb6e782d2c3d2d7aa86b2af3319777fb9072333","original_commit_id":"0bb6e782d2c3d2d7aa86b2af3319777fb9072333","user":{"login":"chingor13","id":32483,"avatar_url":"https://avatars0.githubusercontent.com/u/32483?v=4","gravatar_id":"","url":"https://api.github.com/users/chingor13","html_url":"https://github.com/chingor13","followers_url":"https://api.github.com/users/chingor13/followers","following_url":"https://api.github.com/users/chingor13/following{/other_user}","gists_url":"https://api.github.com/users/chingor13/gists{/gist_id}","starred_url":"https://api.github.com/users/chingor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingor13/subscriptions","organizations_url":"https://api.github.com/users/chingor13/orgs","repos_url":"https://api.github.com/users/chingor13/repos","events_url":"https://api.github.com/users/chingor13/events{/privacy}","received_events_url":"https://api.github.com/users/chingor13/received_events","type":"User","site_admin":false},"body":"This line won't actually get hit.","created_at":"2017-08-23T22:12:09Z","updated_at":"2017-08-23T22:12:09Z","html_url":"https://github.com/GoogleCloudPlatform/php-tools/pull/23#discussion_r134884273","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/comments/134884273"},"html":{"href":"https://github.com/GoogleCloudPlatform/php-tools/pull/23#discussion_r134884273"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23","id":137328017,"html_url":"https://github.com/GoogleCloudPlatform/php-tools/pull/23","diff_url":"https://github.com/GoogleCloudPlatform/php-tools/pull/23.diff","patch_url":"https://github.com/GoogleCloudPlatform/php-tools/pull/23.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/23","number":23,"state":"open","locked":false,"title":"Allow setting default value for catchAllExceptions via an instance var.","user":{"login":"tmatsuo","id":41815,"avatar_url":"https://avatars2.githubusercontent.com/u/41815?v=4","gravatar_id":"","url":"https://api.github.com/users/tmatsuo","html_url":"https://github.com/tmatsuo","followers_url":"https://api.github.com/users/tmatsuo/followers","following_url":"https://api.github.com/users/tmatsuo/following{/other_user}","gists_url":"https://api.github.com/users/tmatsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/tmatsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmatsuo/subscriptions","organizations_url":"https://api.github.com/users/tmatsuo/orgs","repos_url":"https://api.github.com/users/tmatsuo/repos","events_url":"https://api.github.com/users/tmatsuo/events{/privacy}","received_events_url":"https://api.github.com/users/tmatsuo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-23T22:00:43Z","updated_at":"2017-08-23T22:12:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"528db2edfd1ac541b9c556070646a7e14017556b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/23/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/statuses/0bb6e782d2c3d2d7aa86b2af3319777fb9072333","head":{"label":"GoogleCloudPlatform:catchall-flag-on-instance","ref":"catchall-flag-on-instance","sha":"0bb6e782d2c3d2d7aa86b2af3319777fb9072333","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":58236041,"name":"php-tools","full_name":"GoogleCloudPlatform/php-tools","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/php-tools","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/deployments","created_at":"2016-05-06T21:32:18Z","updated_at":"2017-08-19T21:41:23Z","pushed_at":"2017-08-23T22:10:57Z","git_url":"git://github.com/GoogleCloudPlatform/php-tools.git","ssh_url":"git@github.com:GoogleCloudPlatform/php-tools.git","clone_url":"https://github.com/GoogleCloudPlatform/php-tools.git","svn_url":"https://github.com/GoogleCloudPlatform/php-tools","homepage":null,"size":42,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"26506484e5f4aee2e93b0452f27945f58fc2187e","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":58236041,"name":"php-tools","full_name":"GoogleCloudPlatform/php-tools","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/php-tools","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/deployments","created_at":"2016-05-06T21:32:18Z","updated_at":"2017-08-19T21:41:23Z","pushed_at":"2017-08-23T22:10:57Z","git_url":"git://github.com/GoogleCloudPlatform/php-tools.git","ssh_url":"git@github.com:GoogleCloudPlatform/php-tools.git","clone_url":"https://github.com/GoogleCloudPlatform/php-tools.git","svn_url":"https://github.com/GoogleCloudPlatform/php-tools","homepage":null,"size":42,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23"},"html":{"href":"https://github.com/GoogleCloudPlatform/php-tools/pull/23"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/23"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-tools/statuses/0bb6e782d2c3d2d7aa86b2af3319777fb9072333"}}}}
{"actor":{"display_login":"chingor13"}}