{"action":"opened","number":15312,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/15312","id":123390799,"html_url":"https://github.com/emberjs/ember.js/pull/15312","diff_url":"https://github.com/emberjs/ember.js/pull/15312.diff","patch_url":"https://github.com/emberjs/ember.js/pull/15312.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/15312","number":15312,"state":"open","locked":false,"title":"[BUGFIX release] Avoid re-freezing already frozen objects.","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars3.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"When a helper is invoked we pass in the arguments, those arguments are frozen (via Object.freeze) so that helpers can't mutate them (and cause issues in the rendering engine itself). When a helper doesn't have hash arguments, we use a shared `EMPTY_HASH` empty object to avoid allocating a bunch of empty objects for no reason (we do roughly the same thing when no positional params are passed). Since these objects are shared they are being frozen over and over again (throughout the lifetime of the running application). Turns out that there is what we think is almost certainly a bug in Chrome, where re-freezing the same object many times starts taking significantly more time upon each freeze attempt.\n\nThis change introduces a guard to ensure we do not re-freeze repeatedly.\n\nThanks to @krisselden for identifying the root cause.\n\nFixes https://github.com/emberjs/ember.js/issues/15290","created_at":"2017-05-31T23:27:22Z","updated_at":"2017-05-31T23:27:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/15312/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/15312/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/15312/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/4f5c12365a4ee479b7de448304cee68cf31cb2f8","head":{"label":"rwjblue:avoid-refreezing","ref":"avoid-refreezing","sha":"4f5c12365a4ee479b7de448304cee68cf31cb2f8","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars3.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"repo":{"id":12009595,"name":"ember.js","full_name":"rwjblue/ember.js","owner":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars3.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwjblue/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/rwjblue/ember.js","forks_url":"https://api.github.com/repos/rwjblue/ember.js/forks","keys_url":"https://api.github.com/repos/rwjblue/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwjblue/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwjblue/ember.js/teams","hooks_url":"https://api.github.com/repos/rwjblue/ember.js/hooks","issue_events_url":"https://api.github.com/repos/rwjblue/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/rwjblue/ember.js/events","assignees_url":"https://api.github.com/repos/rwjblue/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/rwjblue/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/rwjblue/ember.js/tags","blobs_url":"https://api.github.com/repos/rwjblue/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwjblue/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwjblue/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwjblue/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwjblue/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/rwjblue/ember.js/languages","stargazers_url":"https://api.github.com/repos/rwjblue/ember.js/stargazers","contributors_url":"https://api.github.com/repos/rwjblue/ember.js/contributors","subscribers_url":"https://api.github.com/repos/rwjblue/ember.js/subscribers","subscription_url":"https://api.github.com/repos/rwjblue/ember.js/subscription","commits_url":"https://api.github.com/repos/rwjblue/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwjblue/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwjblue/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwjblue/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwjblue/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/rwjblue/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwjblue/ember.js/merges","archive_url":"https://api.github.com/repos/rwjblue/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwjblue/ember.js/downloads","issues_url":"https://api.github.com/repos/rwjblue/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/rwjblue/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/rwjblue/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/rwjblue/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwjblue/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/rwjblue/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/rwjblue/ember.js/deployments","created_at":"2013-08-09T20:05:11Z","updated_at":"2014-07-18T12:44:07Z","pushed_at":"2017-05-31T23:26:46Z","git_url":"git://github.com/rwjblue/ember.js.git","ssh_url":"git@github.com:rwjblue/ember.js.git","clone_url":"https://github.com/rwjblue/ember.js.git","svn_url":"https://github.com/rwjblue/ember.js","homepage":"http://www.emberjs.com","size":33975,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"eff9312c7db81bbdfa3e738ad9fb3d0285855f34","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars1.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars1.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2017-05-31T17:59:32Z","pushed_at":"2017-05-31T15:46:12Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":39355,"stargazers_count":17901,"watchers_count":17901,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3720,"mirror_url":null,"open_issues_count":323,"forks":3720,"open_issues":323,"watchers":17901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/15312"},"html":{"href":"https://github.com/emberjs/ember.js/pull/15312"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/15312"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/15312/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/15312/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/15312/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/4f5c12365a4ee479b7de448304cee68cf31cb2f8"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":19,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"rwjblue"}}