{"action":"created","comment":{"url":"https://api.github.com/repos/git-lfs/git-lfs/pulls/comments/110030833","pull_request_review_id":31172665,"id":110030833,"diff_hunk":"@@ -14,16 +14,16 @@ servers.\n By default, Git LFS will append `.git/info/lfs` to the end of a Git remote url\n to build the LFS server URL it will use:\n \n-Git Remote: `https://git-server.com/foo/bar`  \n+Git Remote: `https://git-server.com/foo/bar`\n LFS Server: `https://git-server.com/foo/bar.git/info/lfs`\n \n-Git Remote: `https://git-server.com/foo/bar.git`  \n+Git Remote: `https://git-server.com/foo/bar.git`\n LFS Server: `https://git-server.com/foo/bar.git/info/lfs`\n \n-Git Remote: `git@git-server.com:foo/bar.git`  \n+Git Remote: `git@git-server.com:foo/bar.git`\n LFS Server: `https://git-server.com/foo/bar.git/info/lfs`\n \n-Git Remote: `ssh://git-server.com/foo/bar.git`  \n+Git Remote: `ssh://git-server.com/foo/bar.git`","path":"docs/api/server-discovery.md","position":17,"original_position":17,"commit_id":"804a91dbd69fe069acba08259af4ff85a27532bc","original_commit_id":"804a91dbd69fe069acba08259af4ff85a27532bc","user":{"login":"technoweenie","id":21,"avatar_url":"https://avatars0.githubusercontent.com/u/21?v=3","gravatar_id":"","url":"https://api.github.com/users/technoweenie","html_url":"https://github.com/technoweenie","followers_url":"https://api.github.com/users/technoweenie/followers","following_url":"https://api.github.com/users/technoweenie/following{/other_user}","gists_url":"https://api.github.com/users/technoweenie/gists{/gist_id}","starred_url":"https://api.github.com/users/technoweenie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technoweenie/subscriptions","organizations_url":"https://api.github.com/users/technoweenie/orgs","repos_url":"https://api.github.com/users/technoweenie/repos","events_url":"https://api.github.com/users/technoweenie/events{/privacy}","received_events_url":"https://api.github.com/users/technoweenie/received_events","type":"User","site_admin":true},"body":"Same markdown line ending issue. \r\n\r\nI suppose this could be table too, like:\r\n\r\n```\r\n| Git Remote | LFS Server |\r\n|------------|------------|\r\n| `https://git-server.com/foo/bar` | `https://git-server.com/foo/bar.git/info/lfs` |\r\n```","created_at":"2017-04-05T21:19:44Z","updated_at":"2017-04-05T21:42:42Z","html_url":"https://github.com/git-lfs/git-lfs/pull/2130#discussion_r110030833","pull_request_url":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130","_links":{"self":{"href":"https://api.github.com/repos/git-lfs/git-lfs/pulls/comments/110030833"},"html":{"href":"https://github.com/git-lfs/git-lfs/pull/2130#discussion_r110030833"},"pull_request":{"href":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130"}}},"pull_request":{"url":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130","id":114461620,"html_url":"https://github.com/git-lfs/git-lfs/pull/2130","diff_url":"https://github.com/git-lfs/git-lfs/pull/2130.diff","patch_url":"https://github.com/git-lfs/git-lfs/pull/2130.patch","issue_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/2130","number":2130,"state":"open","locked":false,"title":"lfsapi,tq: relative expiration support","user":{"login":"ttaylorr","id":443245,"avatar_url":"https://avatars2.githubusercontent.com/u/443245?v=3","gravatar_id":"","url":"https://api.github.com/users/ttaylorr","html_url":"https://github.com/ttaylorr","followers_url":"https://api.github.com/users/ttaylorr/followers","following_url":"https://api.github.com/users/ttaylorr/following{/other_user}","gists_url":"https://api.github.com/users/ttaylorr/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaylorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaylorr/subscriptions","organizations_url":"https://api.github.com/users/ttaylorr/orgs","repos_url":"https://api.github.com/users/ttaylorr/repos","events_url":"https://api.github.com/users/ttaylorr/events{/privacy}","received_events_url":"https://api.github.com/users/ttaylorr/received_events","type":"User","site_admin":true},"body":"This pull-request implements the idea proposed in #2125 to allow an optional `expires_in` property in both the SSH auth API and the batch API. It is introduced as a non-breaking change.\r\n\r\nBoth the SSH auth response and batch API response types have been expanded as described in https://github.com/git-lfs/git-lfs/issues/2125#issuecomment-291539131:\r\n\r\n```go\r\ntype T struct {\r\n        // ...\r\n        ExpiresAt time.Time `json:\"expires_at,omitempty\"`\r\n        ExpiresIn time.Duration `json:\"expires_in,omitempty\"` \r\n}\r\n```\r\n\r\nand have gained a new helper method:\r\n\r\n```go\r\nfunc (t *T) IsExpiredWithin(d time.Duration) (time.Time, bool) { ... }\r\n```\r\n\r\nwhich returns whether or not the action/SSH auth response is expired, and if so, when.\r\n\r\nThe behavior for the batch API remains the same, and the SSH auth behavior only changes when `lfs.cachecredentials` which will cause a cached SSH auth response to be invalidated if it is expired.\r\n\r\n---\r\n\r\n/cc @git-lfs/core #2125","created_at":"2017-04-05T20:08:16Z","updated_at":"2017-04-05T21:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0f207afa5514ec4451ff8c70bbe75b2538238f3","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/git-lfs/git-lfs/milestones/7","html_url":"https://github.com/git-lfs/git-lfs/milestone/7","labels_url":"https://api.github.com/repos/git-lfs/git-lfs/milestones/7/labels","id":2339152,"number":7,"title":"v2.1.0","description":"","creator":{"login":"ttaylorr","id":443245,"avatar_url":"https://avatars2.githubusercontent.com/u/443245?v=3","gravatar_id":"","url":"https://api.github.com/users/ttaylorr","html_url":"https://github.com/ttaylorr","followers_url":"https://api.github.com/users/ttaylorr/followers","following_url":"https://api.github.com/users/ttaylorr/following{/other_user}","gists_url":"https://api.github.com/users/ttaylorr/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaylorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaylorr/subscriptions","organizations_url":"https://api.github.com/users/ttaylorr/orgs","repos_url":"https://api.github.com/users/ttaylorr/repos","events_url":"https://api.github.com/users/ttaylorr/events{/privacy}","received_events_url":"https://api.github.com/users/ttaylorr/received_events","type":"User","site_admin":true},"open_issues":7,"closed_issues":9,"state":"open","created_at":"2017-02-21T23:00:14Z","updated_at":"2017-04-05T20:08:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130/commits","review_comments_url":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130/comments","review_comment_url":"https://api.github.com/repos/git-lfs/git-lfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/2130/comments","statuses_url":"https://api.github.com/repos/git-lfs/git-lfs/statuses/804a91dbd69fe069acba08259af4ff85a27532bc","head":{"label":"git-lfs:expires-in","ref":"expires-in","sha":"804a91dbd69fe069acba08259af4ff85a27532bc","user":{"login":"git-lfs","id":20246716,"avatar_url":"https://avatars1.githubusercontent.com/u/20246716?v=3","gravatar_id":"","url":"https://api.github.com/users/git-lfs","html_url":"https://github.com/git-lfs","followers_url":"https://api.github.com/users/git-lfs/followers","following_url":"https://api.github.com/users/git-lfs/following{/other_user}","gists_url":"https://api.github.com/users/git-lfs/gists{/gist_id}","starred_url":"https://api.github.com/users/git-lfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-lfs/subscriptions","organizations_url":"https://api.github.com/users/git-lfs/orgs","repos_url":"https://api.github.com/users/git-lfs/repos","events_url":"https://api.github.com/users/git-lfs/events{/privacy}","received_events_url":"https://api.github.com/users/git-lfs/received_events","type":"Organization","site_admin":false},"repo":{"id":13021798,"name":"git-lfs","full_name":"git-lfs/git-lfs","owner":{"login":"git-lfs","id":20246716,"avatar_url":"https://avatars1.githubusercontent.com/u/20246716?v=3","gravatar_id":"","url":"https://api.github.com/users/git-lfs","html_url":"https://github.com/git-lfs","followers_url":"https://api.github.com/users/git-lfs/followers","following_url":"https://api.github.com/users/git-lfs/following{/other_user}","gists_url":"https://api.github.com/users/git-lfs/gists{/gist_id}","starred_url":"https://api.github.com/users/git-lfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-lfs/subscriptions","organizations_url":"https://api.github.com/users/git-lfs/orgs","repos_url":"https://api.github.com/users/git-lfs/repos","events_url":"https://api.github.com/users/git-lfs/events{/privacy}","received_events_url":"https://api.github.com/users/git-lfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/git-lfs/git-lfs","description":"Git extension for versioning large files","fork":false,"url":"https://api.github.com/repos/git-lfs/git-lfs","forks_url":"https://api.github.com/repos/git-lfs/git-lfs/forks","keys_url":"https://api.github.com/repos/git-lfs/git-lfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/git-lfs/git-lfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/git-lfs/git-lfs/teams","hooks_url":"https://api.github.com/repos/git-lfs/git-lfs/hooks","issue_events_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/events{/number}","events_url":"https://api.github.com/repos/git-lfs/git-lfs/events","assignees_url":"https://api.github.com/repos/git-lfs/git-lfs/assignees{/user}","branches_url":"https://api.github.com/repos/git-lfs/git-lfs/branches{/branch}","tags_url":"https://api.github.com/repos/git-lfs/git-lfs/tags","blobs_url":"https://api.github.com/repos/git-lfs/git-lfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/git-lfs/git-lfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/git-lfs/git-lfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/git-lfs/git-lfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/git-lfs/git-lfs/statuses/{sha}","languages_url":"https://api.github.com/repos/git-lfs/git-lfs/languages","stargazers_url":"https://api.github.com/repos/git-lfs/git-lfs/stargazers","contributors_url":"https://api.github.com/repos/git-lfs/git-lfs/contributors","subscribers_url":"https://api.github.com/repos/git-lfs/git-lfs/subscribers","subscription_url":"https://api.github.com/repos/git-lfs/git-lfs/subscription","commits_url":"https://api.github.com/repos/git-lfs/git-lfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/git-lfs/git-lfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/git-lfs/git-lfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/git-lfs/git-lfs/contents/{+path}","compare_url":"https://api.github.com/repos/git-lfs/git-lfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/git-lfs/git-lfs/merges","archive_url":"https://api.github.com/repos/git-lfs/git-lfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/git-lfs/git-lfs/downloads","issues_url":"https://api.github.com/repos/git-lfs/git-lfs/issues{/number}","pulls_url":"https://api.github.com/repos/git-lfs/git-lfs/pulls{/number}","milestones_url":"https://api.github.com/repos/git-lfs/git-lfs/milestones{/number}","notifications_url":"https://api.github.com/repos/git-lfs/git-lfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/git-lfs/git-lfs/labels{/name}","releases_url":"https://api.github.com/repos/git-lfs/git-lfs/releases{/id}","deployments_url":"https://api.github.com/repos/git-lfs/git-lfs/deployments","created_at":"2013-09-22T22:03:28Z","updated_at":"2017-04-05T17:10:31Z","pushed_at":"2017-04-05T21:18:50Z","git_url":"git://github.com/git-lfs/git-lfs.git","ssh_url":"git@github.com:git-lfs/git-lfs.git","clone_url":"https://github.com/git-lfs/git-lfs.git","svn_url":"https://github.com/git-lfs/git-lfs","homepage":"https://git-lfs.github.com","size":7957,"stargazers_count":4471,"watchers_count":4471,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":700,"mirror_url":null,"open_issues_count":223,"forks":700,"open_issues":223,"watchers":4471,"default_branch":"master"}},"base":{"label":"git-lfs:master","ref":"master","sha":"dc0b3c60ad01b456f8cfbce3d28523632ed01571","user":{"login":"git-lfs","id":20246716,"avatar_url":"https://avatars1.githubusercontent.com/u/20246716?v=3","gravatar_id":"","url":"https://api.github.com/users/git-lfs","html_url":"https://github.com/git-lfs","followers_url":"https://api.github.com/users/git-lfs/followers","following_url":"https://api.github.com/users/git-lfs/following{/other_user}","gists_url":"https://api.github.com/users/git-lfs/gists{/gist_id}","starred_url":"https://api.github.com/users/git-lfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-lfs/subscriptions","organizations_url":"https://api.github.com/users/git-lfs/orgs","repos_url":"https://api.github.com/users/git-lfs/repos","events_url":"https://api.github.com/users/git-lfs/events{/privacy}","received_events_url":"https://api.github.com/users/git-lfs/received_events","type":"Organization","site_admin":false},"repo":{"id":13021798,"name":"git-lfs","full_name":"git-lfs/git-lfs","owner":{"login":"git-lfs","id":20246716,"avatar_url":"https://avatars1.githubusercontent.com/u/20246716?v=3","gravatar_id":"","url":"https://api.github.com/users/git-lfs","html_url":"https://github.com/git-lfs","followers_url":"https://api.github.com/users/git-lfs/followers","following_url":"https://api.github.com/users/git-lfs/following{/other_user}","gists_url":"https://api.github.com/users/git-lfs/gists{/gist_id}","starred_url":"https://api.github.com/users/git-lfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-lfs/subscriptions","organizations_url":"https://api.github.com/users/git-lfs/orgs","repos_url":"https://api.github.com/users/git-lfs/repos","events_url":"https://api.github.com/users/git-lfs/events{/privacy}","received_events_url":"https://api.github.com/users/git-lfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/git-lfs/git-lfs","description":"Git extension for versioning large files","fork":false,"url":"https://api.github.com/repos/git-lfs/git-lfs","forks_url":"https://api.github.com/repos/git-lfs/git-lfs/forks","keys_url":"https://api.github.com/repos/git-lfs/git-lfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/git-lfs/git-lfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/git-lfs/git-lfs/teams","hooks_url":"https://api.github.com/repos/git-lfs/git-lfs/hooks","issue_events_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/events{/number}","events_url":"https://api.github.com/repos/git-lfs/git-lfs/events","assignees_url":"https://api.github.com/repos/git-lfs/git-lfs/assignees{/user}","branches_url":"https://api.github.com/repos/git-lfs/git-lfs/branches{/branch}","tags_url":"https://api.github.com/repos/git-lfs/git-lfs/tags","blobs_url":"https://api.github.com/repos/git-lfs/git-lfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/git-lfs/git-lfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/git-lfs/git-lfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/git-lfs/git-lfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/git-lfs/git-lfs/statuses/{sha}","languages_url":"https://api.github.com/repos/git-lfs/git-lfs/languages","stargazers_url":"https://api.github.com/repos/git-lfs/git-lfs/stargazers","contributors_url":"https://api.github.com/repos/git-lfs/git-lfs/contributors","subscribers_url":"https://api.github.com/repos/git-lfs/git-lfs/subscribers","subscription_url":"https://api.github.com/repos/git-lfs/git-lfs/subscription","commits_url":"https://api.github.com/repos/git-lfs/git-lfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/git-lfs/git-lfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/git-lfs/git-lfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/git-lfs/git-lfs/contents/{+path}","compare_url":"https://api.github.com/repos/git-lfs/git-lfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/git-lfs/git-lfs/merges","archive_url":"https://api.github.com/repos/git-lfs/git-lfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/git-lfs/git-lfs/downloads","issues_url":"https://api.github.com/repos/git-lfs/git-lfs/issues{/number}","pulls_url":"https://api.github.com/repos/git-lfs/git-lfs/pulls{/number}","milestones_url":"https://api.github.com/repos/git-lfs/git-lfs/milestones{/number}","notifications_url":"https://api.github.com/repos/git-lfs/git-lfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/git-lfs/git-lfs/labels{/name}","releases_url":"https://api.github.com/repos/git-lfs/git-lfs/releases{/id}","deployments_url":"https://api.github.com/repos/git-lfs/git-lfs/deployments","created_at":"2013-09-22T22:03:28Z","updated_at":"2017-04-05T17:10:31Z","pushed_at":"2017-04-05T21:18:50Z","git_url":"git://github.com/git-lfs/git-lfs.git","ssh_url":"git@github.com:git-lfs/git-lfs.git","clone_url":"https://github.com/git-lfs/git-lfs.git","svn_url":"https://github.com/git-lfs/git-lfs","homepage":"https://git-lfs.github.com","size":7957,"stargazers_count":4471,"watchers_count":4471,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":700,"mirror_url":null,"open_issues_count":223,"forks":700,"open_issues":223,"watchers":4471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130"},"html":{"href":"https://github.com/git-lfs/git-lfs/pull/2130"},"issue":{"href":"https://api.github.com/repos/git-lfs/git-lfs/issues/2130"},"comments":{"href":"https://api.github.com/repos/git-lfs/git-lfs/issues/2130/comments"},"review_comments":{"href":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130/comments"},"review_comment":{"href":"https://api.github.com/repos/git-lfs/git-lfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/git-lfs/git-lfs/pulls/2130/commits"},"statuses":{"href":"https://api.github.com/repos/git-lfs/git-lfs/statuses/804a91dbd69fe069acba08259af4ff85a27532bc"}}}}
{"actor":{"display_login":"technoweenie"}}