{"action":"created","comment":{"url":"https://api.github.com/repos/neulab/xnmt/pulls/comments/132256377","pull_request_review_id":55317755,"id":132256377,"diff_hunk":"@@ -8,6 +8,26 @@\n \n # This is a CNN-based encoder that was used in the following paper:\n #  http://papers.nips.cc/paper/6186-unsupervised-learning-of-spoken-language-with-visual-context.pdf\n+\n+def padding(src, src_height, src_width,filter_width, stride, batch_size, channel=1):\n+   ''' do padding for the sequence input along the time step (for example speech), so that so that the output of convolutional layer has the same size(time) of the input.\n+\n+       note that for padding image(two dimensional padding), please refer to dyne.conv2d(..., is_valid = False)\n+   '''\n+   # make sure the src is the right shape \n+   src = dy.reshape(src, (src_height, src_width, channel), batch_size=batch_size)","path":"xnmt/specialized_encoders.py","position":null,"original_position":11,"commit_id":"0a3c4ece9592a1a01cc9da2fbe5d8187f4d88c87","original_commit_id":"249b24529cdf2993d67ace686ff7c57dc5e39166","user":{"login":"mingxingdu","id":20781655,"avatar_url":"https://avatars1.githubusercontent.com/u/20781655?v=4","gravatar_id":"","url":"https://api.github.com/users/mingxingdu","html_url":"https://github.com/mingxingdu","followers_url":"https://api.github.com/users/mingxingdu/followers","following_url":"https://api.github.com/users/mingxingdu/following{/other_user}","gists_url":"https://api.github.com/users/mingxingdu/gists{/gist_id}","starred_url":"https://api.github.com/users/mingxingdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingxingdu/subscriptions","organizations_url":"https://api.github.com/users/mingxingdu/orgs","repos_url":"https://api.github.com/users/mingxingdu/repos","events_url":"https://api.github.com/users/mingxingdu/events{/privacy}","received_events_url":"https://api.github.com/users/mingxingdu/received_events","type":"User","site_admin":false},"body":"I can remove it ! \r\n\r\nIt's done in my push just now","created_at":"2017-08-09T17:48:01Z","updated_at":"2017-08-09T17:48:01Z","html_url":"https://github.com/neulab/xnmt/pull/160#discussion_r132256377","pull_request_url":"https://api.github.com/repos/neulab/xnmt/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/comments/132256377"},"html":{"href":"https://github.com/neulab/xnmt/pull/160#discussion_r132256377"},"pull_request":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/neulab/xnmt/pulls/160","id":134939957,"html_url":"https://github.com/neulab/xnmt/pull/160","diff_url":"https://github.com/neulab/xnmt/pull/160.diff","patch_url":"https://github.com/neulab/xnmt/pull/160.patch","issue_url":"https://api.github.com/repos/neulab/xnmt/issues/160","number":160,"state":"open","locked":false,"title":"Mingxing","user":{"login":"mingxingdu","id":20781655,"avatar_url":"https://avatars1.githubusercontent.com/u/20781655?v=4","gravatar_id":"","url":"https://api.github.com/users/mingxingdu","html_url":"https://github.com/mingxingdu","followers_url":"https://api.github.com/users/mingxingdu/followers","following_url":"https://api.github.com/users/mingxingdu/following{/other_user}","gists_url":"https://api.github.com/users/mingxingdu/gists{/gist_id}","starred_url":"https://api.github.com/users/mingxingdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingxingdu/subscriptions","organizations_url":"https://api.github.com/users/mingxingdu/orgs","repos_url":"https://api.github.com/users/mingxingdu/repos","events_url":"https://api.github.com/users/mingxingdu/events{/privacy}","received_events_url":"https://api.github.com/users/mingxingdu/received_events","type":"User","site_admin":false},"body":"Hello Graham,\r\n\r\nI added padding before pass to conv layer for Harwath's encoder and Tilburg encoder\r\n\r\nI tested both of them with speech_retrieval.yaml and flickr40k_retrieval.yaml\r\n\r\nThanks for your review\r\n","created_at":"2017-08-09T16:48:51Z","updated_at":"2017-08-09T17:48:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"080d15d7f80d7acdc42604e1ce8f6ae11e801513","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neulab/xnmt/pulls/160/commits","review_comments_url":"https://api.github.com/repos/neulab/xnmt/pulls/160/comments","review_comment_url":"https://api.github.com/repos/neulab/xnmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neulab/xnmt/issues/160/comments","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/0a3c4ece9592a1a01cc9da2fbe5d8187f4d88c87","head":{"label":"neulab:mingxing","ref":"mingxing","sha":"0a3c4ece9592a1a01cc9da2fbe5d8187f4d88c87","user":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"repo":{"id":79833244,"name":"xnmt","full_name":"neulab/xnmt","owner":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neulab/xnmt","description":"eXtensible Neural Machine Translation","fork":false,"url":"https://api.github.com/repos/neulab/xnmt","forks_url":"https://api.github.com/repos/neulab/xnmt/forks","keys_url":"https://api.github.com/repos/neulab/xnmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neulab/xnmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neulab/xnmt/teams","hooks_url":"https://api.github.com/repos/neulab/xnmt/hooks","issue_events_url":"https://api.github.com/repos/neulab/xnmt/issues/events{/number}","events_url":"https://api.github.com/repos/neulab/xnmt/events","assignees_url":"https://api.github.com/repos/neulab/xnmt/assignees{/user}","branches_url":"https://api.github.com/repos/neulab/xnmt/branches{/branch}","tags_url":"https://api.github.com/repos/neulab/xnmt/tags","blobs_url":"https://api.github.com/repos/neulab/xnmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neulab/xnmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neulab/xnmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/neulab/xnmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/{sha}","languages_url":"https://api.github.com/repos/neulab/xnmt/languages","stargazers_url":"https://api.github.com/repos/neulab/xnmt/stargazers","contributors_url":"https://api.github.com/repos/neulab/xnmt/contributors","subscribers_url":"https://api.github.com/repos/neulab/xnmt/subscribers","subscription_url":"https://api.github.com/repos/neulab/xnmt/subscription","commits_url":"https://api.github.com/repos/neulab/xnmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/neulab/xnmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/neulab/xnmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/neulab/xnmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/neulab/xnmt/contents/{+path}","compare_url":"https://api.github.com/repos/neulab/xnmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neulab/xnmt/merges","archive_url":"https://api.github.com/repos/neulab/xnmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neulab/xnmt/downloads","issues_url":"https://api.github.com/repos/neulab/xnmt/issues{/number}","pulls_url":"https://api.github.com/repos/neulab/xnmt/pulls{/number}","milestones_url":"https://api.github.com/repos/neulab/xnmt/milestones{/number}","notifications_url":"https://api.github.com/repos/neulab/xnmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neulab/xnmt/labels{/name}","releases_url":"https://api.github.com/repos/neulab/xnmt/releases{/id}","deployments_url":"https://api.github.com/repos/neulab/xnmt/deployments","created_at":"2017-01-23T18:18:54Z","updated_at":"2017-08-02T23:03:20Z","pushed_at":"2017-08-09T17:46:24Z","git_url":"git://github.com/neulab/xnmt.git","ssh_url":"git@github.com:neulab/xnmt.git","clone_url":"https://github.com/neulab/xnmt.git","svn_url":"https://github.com/neulab/xnmt","homepage":null,"size":13482,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":28,"default_branch":"master"}},"base":{"label":"neulab:master","ref":"master","sha":"61f113d5cf8d1cc0cfadd25960108a4aecd0554f","user":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"repo":{"id":79833244,"name":"xnmt","full_name":"neulab/xnmt","owner":{"login":"neulab","id":22324665,"avatar_url":"https://avatars2.githubusercontent.com/u/22324665?v=4","gravatar_id":"","url":"https://api.github.com/users/neulab","html_url":"https://github.com/neulab","followers_url":"https://api.github.com/users/neulab/followers","following_url":"https://api.github.com/users/neulab/following{/other_user}","gists_url":"https://api.github.com/users/neulab/gists{/gist_id}","starred_url":"https://api.github.com/users/neulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neulab/subscriptions","organizations_url":"https://api.github.com/users/neulab/orgs","repos_url":"https://api.github.com/users/neulab/repos","events_url":"https://api.github.com/users/neulab/events{/privacy}","received_events_url":"https://api.github.com/users/neulab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neulab/xnmt","description":"eXtensible Neural Machine Translation","fork":false,"url":"https://api.github.com/repos/neulab/xnmt","forks_url":"https://api.github.com/repos/neulab/xnmt/forks","keys_url":"https://api.github.com/repos/neulab/xnmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neulab/xnmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neulab/xnmt/teams","hooks_url":"https://api.github.com/repos/neulab/xnmt/hooks","issue_events_url":"https://api.github.com/repos/neulab/xnmt/issues/events{/number}","events_url":"https://api.github.com/repos/neulab/xnmt/events","assignees_url":"https://api.github.com/repos/neulab/xnmt/assignees{/user}","branches_url":"https://api.github.com/repos/neulab/xnmt/branches{/branch}","tags_url":"https://api.github.com/repos/neulab/xnmt/tags","blobs_url":"https://api.github.com/repos/neulab/xnmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neulab/xnmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neulab/xnmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/neulab/xnmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neulab/xnmt/statuses/{sha}","languages_url":"https://api.github.com/repos/neulab/xnmt/languages","stargazers_url":"https://api.github.com/repos/neulab/xnmt/stargazers","contributors_url":"https://api.github.com/repos/neulab/xnmt/contributors","subscribers_url":"https://api.github.com/repos/neulab/xnmt/subscribers","subscription_url":"https://api.github.com/repos/neulab/xnmt/subscription","commits_url":"https://api.github.com/repos/neulab/xnmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/neulab/xnmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/neulab/xnmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/neulab/xnmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/neulab/xnmt/contents/{+path}","compare_url":"https://api.github.com/repos/neulab/xnmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neulab/xnmt/merges","archive_url":"https://api.github.com/repos/neulab/xnmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neulab/xnmt/downloads","issues_url":"https://api.github.com/repos/neulab/xnmt/issues{/number}","pulls_url":"https://api.github.com/repos/neulab/xnmt/pulls{/number}","milestones_url":"https://api.github.com/repos/neulab/xnmt/milestones{/number}","notifications_url":"https://api.github.com/repos/neulab/xnmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neulab/xnmt/labels{/name}","releases_url":"https://api.github.com/repos/neulab/xnmt/releases{/id}","deployments_url":"https://api.github.com/repos/neulab/xnmt/deployments","created_at":"2017-01-23T18:18:54Z","updated_at":"2017-08-02T23:03:20Z","pushed_at":"2017-08-09T17:46:24Z","git_url":"git://github.com/neulab/xnmt.git","ssh_url":"git@github.com:neulab/xnmt.git","clone_url":"https://github.com/neulab/xnmt.git","svn_url":"https://github.com/neulab/xnmt","homepage":null,"size":13482,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/160"},"html":{"href":"https://github.com/neulab/xnmt/pull/160"},"issue":{"href":"https://api.github.com/repos/neulab/xnmt/issues/160"},"comments":{"href":"https://api.github.com/repos/neulab/xnmt/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neulab/xnmt/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/neulab/xnmt/statuses/0a3c4ece9592a1a01cc9da2fbe5d8187f4d88c87"}}}}
{"actor":{"display_login":"mingxingdu"}}