{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/6620","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/6620/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/6620/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/6620/events","html_url":"https://github.com/RobotLocomotion/drake/pull/6620","id":244529158,"number":6620,"title":"Make Quadrotor C++ slightly more idiomatic","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"naveenoid","id":3089530,"avatar_url":"https://avatars0.githubusercontent.com/u/3089530?v=4","gravatar_id":"","url":"https://api.github.com/users/naveenoid","html_url":"https://github.com/naveenoid","followers_url":"https://api.github.com/users/naveenoid/followers","following_url":"https://api.github.com/users/naveenoid/following{/other_user}","gists_url":"https://api.github.com/users/naveenoid/gists{/gist_id}","starred_url":"https://api.github.com/users/naveenoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naveenoid/subscriptions","organizations_url":"https://api.github.com/users/naveenoid/orgs","repos_url":"https://api.github.com/users/naveenoid/repos","events_url":"https://api.github.com/users/naveenoid/events{/privacy}","received_events_url":"https://api.github.com/users/naveenoid/received_events","type":"User","site_admin":false},"assignees":[{"login":"naveenoid","id":3089530,"avatar_url":"https://avatars0.githubusercontent.com/u/3089530?v=4","gravatar_id":"","url":"https://api.github.com/users/naveenoid","html_url":"https://github.com/naveenoid","followers_url":"https://api.github.com/users/naveenoid/followers","following_url":"https://api.github.com/users/naveenoid/following{/other_user}","gists_url":"https://api.github.com/users/naveenoid/gists{/gist_id}","starred_url":"https://api.github.com/users/naveenoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naveenoid/subscriptions","organizations_url":"https://api.github.com/users/naveenoid/orgs","repos_url":"https://api.github.com/users/naveenoid/repos","events_url":"https://api.github.com/users/naveenoid/events{/privacy}","received_events_url":"https://api.github.com/users/naveenoid/received_events","type":"User","site_admin":false},{"login":"sherm1","id":4088016,"avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},{"login":"SeanCurtis-TRI","id":22159799,"avatar_url":"https://avatars3.githubusercontent.com/u/22159799?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCurtis-TRI","html_url":"https://github.com/SeanCurtis-TRI","followers_url":"https://api.github.com/users/SeanCurtis-TRI/followers","following_url":"https://api.github.com/users/SeanCurtis-TRI/following{/other_user}","gists_url":"https://api.github.com/users/SeanCurtis-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCurtis-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCurtis-TRI/subscriptions","organizations_url":"https://api.github.com/users/SeanCurtis-TRI/orgs","repos_url":"https://api.github.com/users/SeanCurtis-TRI/repos","events_url":"https://api.github.com/users/SeanCurtis-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCurtis-TRI/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2017-07-21T00:00:25Z","updated_at":"2017-07-21T19:14:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/6620","html_url":"https://github.com/RobotLocomotion/drake/pull/6620","diff_url":"https://github.com/RobotLocomotion/drake/pull/6620.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/6620.patch"},"body":"I stumbled upon this when investigating transmogrification.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/6620)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/317088852","html_url":"https://github.com/RobotLocomotion/drake/pull/6620#issuecomment-317088852","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/6620","id":317088852,"user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"created_at":"2017-07-21T19:14:21Z","updated_at":"2017-07-21T19:14:21Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[drake/examples/Quadrotor/quadrotor_plant.cc, line 107 at r2](https://reviewable.io:443/reviews/robotlocomotion/drake/6620#-KpaO5Z2syve2KSX3GVz:-KpaY5vlM42oixeInU3e:b-9hbm1h) ([raw file](https://github.com/robotlocomotion/drake/blob/6260840c1f08868e6eefd0b58e6d8d4cb776f2f0/drake/examples/Quadrotor/quadrotor_plant.cc#L107)):*\n> providing out-of-class definitions for static constexpr members is not required\n\nI don't think thats true?  Setting aside C++17 rules (since our compilers don't use it), the C++11 rules cited on that page seem to be:\n\n> > \"If a ... constexpr static data member is odr-used, a definition at namespace scope is still required.\"\n\nTo me, that says that a definition is _sometimes_ required.\n\nBecause it is difficult to know whether a constant will be odr-used, and there is no diagnostic required if it later it becomes odr-used but lack a definition, it seems sensible to me to keep these definitions intact.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/6620)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jwnimmer-tri"}}