{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x.js/pulls/comments/157249882","pull_request_review_id":83866919,"id":157249882,"diff_hunk":"@@ -34,9 +33,6 @@ export class Subprovider {\n     }\n     public setEngine(engine: any): void {\n         this.engine = engine;\n-        engine.on('block', (block: any) => {\n-            this.currentBlock = block;\n-        });","path":"packages/subproviders/src/subproviders/subprovider.ts","position":14,"original_position":14,"commit_id":"818a50a3fb0b78992919e0366c73b36cbffa69b0","original_commit_id":"818a50a3fb0b78992919e0366c73b36cbffa69b0","user":{"login":"LogvinovLeon","id":6204356,"avatar_url":"https://avatars1.githubusercontent.com/u/6204356?v=4","gravatar_id":"","url":"https://api.github.com/users/LogvinovLeon","html_url":"https://github.com/LogvinovLeon","followers_url":"https://api.github.com/users/LogvinovLeon/followers","following_url":"https://api.github.com/users/LogvinovLeon/following{/other_user}","gists_url":"https://api.github.com/users/LogvinovLeon/gists{/gist_id}","starred_url":"https://api.github.com/users/LogvinovLeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogvinovLeon/subscriptions","organizations_url":"https://api.github.com/users/LogvinovLeon/orgs","repos_url":"https://api.github.com/users/LogvinovLeon/repos","events_url":"https://api.github.com/users/LogvinovLeon/events{/privacy}","received_events_url":"https://api.github.com/users/LogvinovLeon/received_events","type":"User","site_admin":false},"body":"Could be. Dead code. We'll add it as soon as it will be used by a super class.","created_at":"2017-12-15T16:59:50Z","updated_at":"2017-12-15T16:59:50Z","html_url":"https://github.com/0xProject/0x.js/pull/266#discussion_r157249882","pull_request_url":"https://api.github.com/repos/0xProject/0x.js/pulls/266","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/comments/157249882"},"html":{"href":"https://github.com/0xProject/0x.js/pull/266#discussion_r157249882"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/266"}},"in_reply_to_id":157243454},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x.js/pulls/266","id":158618913,"html_url":"https://github.com/0xProject/0x.js/pull/266","diff_url":"https://github.com/0xProject/0x.js/pull/266.diff","patch_url":"https://github.com/0xProject/0x.js/pull/266.patch","issue_url":"https://api.github.com/repos/0xProject/0x.js/issues/266","number":266,"state":"open","locked":false,"title":"Remove all unused vars and imports","user":{"login":"LogvinovLeon","id":6204356,"avatar_url":"https://avatars1.githubusercontent.com/u/6204356?v=4","gravatar_id":"","url":"https://api.github.com/users/LogvinovLeon","html_url":"https://github.com/LogvinovLeon","followers_url":"https://api.github.com/users/LogvinovLeon/followers","following_url":"https://api.github.com/users/LogvinovLeon/following{/other_user}","gists_url":"https://api.github.com/users/LogvinovLeon/gists{/gist_id}","starred_url":"https://api.github.com/users/LogvinovLeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogvinovLeon/subscriptions","organizations_url":"https://api.github.com/users/LogvinovLeon/orgs","repos_url":"https://api.github.com/users/LogvinovLeon/repos","events_url":"https://api.github.com/users/LogvinovLeon/events{/privacy}","received_events_url":"https://api.github.com/users/LogvinovLeon/received_events","type":"User","site_admin":false},"body":"This PR:\r\n* Enables new linter rule\r\n* Fixes all the errors (oh boy there was a lot)\r\n* Fixes tests on 0x.js (have no idea how did this work before)\r\n* Not all of the things here are stupid unused vars removals. Review carefully","created_at":"2017-12-15T14:43:47Z","updated_at":"2017-12-15T16:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad9bb33eff4fdb7960964f177b3f0794398a3ec3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x.js/pulls/266/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x.js/pulls/266/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x.js/issues/266/comments","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/818a50a3fb0b78992919e0366c73b36cbffa69b0","head":{"label":"0xProject:fix/no-unused-vars","ref":"fix/no-unused-vars","sha":"818a50a3fb0b78992919e0366c73b36cbffa69b0","user":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"name":"0x.js","full_name":"0xProject/0x.js","owner":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x.js","description":"0x protocol TypeScript monorepo","fork":false,"url":"https://api.github.com/repos/0xProject/0x.js","forks_url":"https://api.github.com/repos/0xProject/0x.js/forks","keys_url":"https://api.github.com/repos/0xProject/0x.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x.js/teams","hooks_url":"https://api.github.com/repos/0xProject/0x.js/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x.js/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x.js/events","assignees_url":"https://api.github.com/repos/0xProject/0x.js/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x.js/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x.js/tags","blobs_url":"https://api.github.com/repos/0xProject/0x.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x.js/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x.js/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x.js/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x.js/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x.js/subscription","commits_url":"https://api.github.com/repos/0xProject/0x.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x.js/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x.js/merges","archive_url":"https://api.github.com/repos/0xProject/0x.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x.js/downloads","issues_url":"https://api.github.com/repos/0xProject/0x.js/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x.js/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x.js/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x.js/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x.js/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x.js/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2017-12-14T10:59:36Z","pushed_at":"2017-12-15T15:07:13Z","git_url":"git://github.com/0xProject/0x.js.git","ssh_url":"git@github.com:0xProject/0x.js.git","clone_url":"https://github.com/0xProject/0x.js.git","svn_url":"https://github.com/0xProject/0x.js","homepage":"","size":20274,"stargazers_count":211,"watchers_count":211,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":10,"watchers":211,"default_branch":"development"}},"base":{"label":"0xProject:development","ref":"development","sha":"de8c445f961e1a09bed6a01397e36b96e0ea3d9a","user":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"name":"0x.js","full_name":"0xProject/0x.js","owner":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x.js","description":"0x protocol TypeScript monorepo","fork":false,"url":"https://api.github.com/repos/0xProject/0x.js","forks_url":"https://api.github.com/repos/0xProject/0x.js/forks","keys_url":"https://api.github.com/repos/0xProject/0x.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x.js/teams","hooks_url":"https://api.github.com/repos/0xProject/0x.js/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x.js/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x.js/events","assignees_url":"https://api.github.com/repos/0xProject/0x.js/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x.js/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x.js/tags","blobs_url":"https://api.github.com/repos/0xProject/0x.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x.js/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x.js/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x.js/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x.js/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x.js/subscription","commits_url":"https://api.github.com/repos/0xProject/0x.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x.js/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x.js/merges","archive_url":"https://api.github.com/repos/0xProject/0x.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x.js/downloads","issues_url":"https://api.github.com/repos/0xProject/0x.js/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x.js/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x.js/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x.js/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x.js/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x.js/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2017-12-14T10:59:36Z","pushed_at":"2017-12-15T15:07:13Z","git_url":"git://github.com/0xProject/0x.js.git","ssh_url":"git@github.com:0xProject/0x.js.git","clone_url":"https://github.com/0xProject/0x.js.git","svn_url":"https://github.com/0xProject/0x.js","homepage":"","size":20274,"stargazers_count":211,"watchers_count":211,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":10,"watchers":211,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/266"},"html":{"href":"https://github.com/0xProject/0x.js/pull/266"},"issue":{"href":"https://api.github.com/repos/0xProject/0x.js/issues/266"},"comments":{"href":"https://api.github.com/repos/0xProject/0x.js/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x.js/statuses/818a50a3fb0b78992919e0366c73b36cbffa69b0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"LogvinovLeon"}}