{"action":"created","comment":{"url":"https://api.github.com/repos/go-hep/hep/pulls/comments/125825822","pull_request_review_id":48250077,"id":125825822,"diff_hunk":"@@ -19,10 +19,11 @@ type TrackerRawDataContainer struct {\n }\n \n type TrackerRawData struct {\n-\tCellID0 int32\n-\tCellID1 int32\n-\tTime    int32\n-\tADCs    []uint16\n+\tCellID0    int32\n+\tCellID1    int32\n+\tTime       int32\n+\tnADCValues int32\n+\tADCValues  []uint16","path":"lcio/trackerrawdata.go","position":12,"original_position":12,"commit_id":"b57c3bc92228b0c747144a0e8d1ed2d64337573d","original_commit_id":"b57c3bc92228b0c747144a0e8d1ed2d64337573d","user":{"login":"sbinet","id":1070920,"avatar_url":"https://avatars1.githubusercontent.com/u/1070920?v=3","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false},"body":"I am relatively agnostic wrt this but, is there a fundamental reason to rename this as `ADCValues` ?","created_at":"2017-07-06T07:12:02Z","updated_at":"2017-07-06T07:21:30Z","html_url":"https://github.com/go-hep/hep/pull/74#discussion_r125825822","pull_request_url":"https://api.github.com/repos/go-hep/hep/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/go-hep/hep/pulls/comments/125825822"},"html":{"href":"https://github.com/go-hep/hep/pull/74#discussion_r125825822"},"pull_request":{"href":"https://api.github.com/repos/go-hep/hep/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/go-hep/hep/pulls/74","id":129087156,"html_url":"https://github.com/go-hep/hep/pull/74","diff_url":"https://github.com/go-hep/hep/pull/74.diff","patch_url":"https://github.com/go-hep/hep/pull/74.patch","issue_url":"https://api.github.com/repos/go-hep/hep/issues/74","number":74,"state":"open","locked":false,"title":"lcio: Fixed ADC value marshaling in TrackerRawData","user":{"login":"decibelCooper","id":13596458,"avatar_url":"https://avatars0.githubusercontent.com/u/13596458?v=3","gravatar_id":"","url":"https://api.github.com/users/decibelCooper","html_url":"https://github.com/decibelCooper","followers_url":"https://api.github.com/users/decibelCooper/followers","following_url":"https://api.github.com/users/decibelCooper/following{/other_user}","gists_url":"https://api.github.com/users/decibelCooper/gists{/gist_id}","starred_url":"https://api.github.com/users/decibelCooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decibelCooper/subscriptions","organizations_url":"https://api.github.com/users/decibelCooper/orgs","repos_url":"https://api.github.com/users/decibelCooper/repos","events_url":"https://api.github.com/users/decibelCooper/events{/privacy}","received_events_url":"https://api.github.com/users/decibelCooper/received_events","type":"User","site_admin":false},"body":"Resolves #73\r\n\r\n* Fix marshaling of TrackerRawData hits by matching the behavior found in https://github.com/iLCSoft/LCIO","created_at":"2017-07-06T01:34:32Z","updated_at":"2017-07-06T07:21:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3030643a9d9893a09029113038387de18d7f435f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-hep/hep/pulls/74/commits","review_comments_url":"https://api.github.com/repos/go-hep/hep/pulls/74/comments","review_comment_url":"https://api.github.com/repos/go-hep/hep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-hep/hep/issues/74/comments","statuses_url":"https://api.github.com/repos/go-hep/hep/statuses/b57c3bc92228b0c747144a0e8d1ed2d64337573d","head":{"label":"decibelCooper:master","ref":"master","sha":"b57c3bc92228b0c747144a0e8d1ed2d64337573d","user":{"login":"decibelCooper","id":13596458,"avatar_url":"https://avatars0.githubusercontent.com/u/13596458?v=3","gravatar_id":"","url":"https://api.github.com/users/decibelCooper","html_url":"https://github.com/decibelCooper","followers_url":"https://api.github.com/users/decibelCooper/followers","following_url":"https://api.github.com/users/decibelCooper/following{/other_user}","gists_url":"https://api.github.com/users/decibelCooper/gists{/gist_id}","starred_url":"https://api.github.com/users/decibelCooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decibelCooper/subscriptions","organizations_url":"https://api.github.com/users/decibelCooper/orgs","repos_url":"https://api.github.com/users/decibelCooper/repos","events_url":"https://api.github.com/users/decibelCooper/events{/privacy}","received_events_url":"https://api.github.com/users/decibelCooper/received_events","type":"User","site_admin":false},"repo":{"id":95910113,"name":"hep","full_name":"decibelCooper/hep","owner":{"login":"decibelCooper","id":13596458,"avatar_url":"https://avatars0.githubusercontent.com/u/13596458?v=3","gravatar_id":"","url":"https://api.github.com/users/decibelCooper","html_url":"https://github.com/decibelCooper","followers_url":"https://api.github.com/users/decibelCooper/followers","following_url":"https://api.github.com/users/decibelCooper/following{/other_user}","gists_url":"https://api.github.com/users/decibelCooper/gists{/gist_id}","starred_url":"https://api.github.com/users/decibelCooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decibelCooper/subscriptions","organizations_url":"https://api.github.com/users/decibelCooper/orgs","repos_url":"https://api.github.com/users/decibelCooper/repos","events_url":"https://api.github.com/users/decibelCooper/events{/privacy}","received_events_url":"https://api.github.com/users/decibelCooper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/decibelCooper/hep","description":"hep is the mono repository holding all of go-hep.org/x/hep packages and tools","fork":true,"url":"https://api.github.com/repos/decibelCooper/hep","forks_url":"https://api.github.com/repos/decibelCooper/hep/forks","keys_url":"https://api.github.com/repos/decibelCooper/hep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decibelCooper/hep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decibelCooper/hep/teams","hooks_url":"https://api.github.com/repos/decibelCooper/hep/hooks","issue_events_url":"https://api.github.com/repos/decibelCooper/hep/issues/events{/number}","events_url":"https://api.github.com/repos/decibelCooper/hep/events","assignees_url":"https://api.github.com/repos/decibelCooper/hep/assignees{/user}","branches_url":"https://api.github.com/repos/decibelCooper/hep/branches{/branch}","tags_url":"https://api.github.com/repos/decibelCooper/hep/tags","blobs_url":"https://api.github.com/repos/decibelCooper/hep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decibelCooper/hep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decibelCooper/hep/git/refs{/sha}","trees_url":"https://api.github.com/repos/decibelCooper/hep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decibelCooper/hep/statuses/{sha}","languages_url":"https://api.github.com/repos/decibelCooper/hep/languages","stargazers_url":"https://api.github.com/repos/decibelCooper/hep/stargazers","contributors_url":"https://api.github.com/repos/decibelCooper/hep/contributors","subscribers_url":"https://api.github.com/repos/decibelCooper/hep/subscribers","subscription_url":"https://api.github.com/repos/decibelCooper/hep/subscription","commits_url":"https://api.github.com/repos/decibelCooper/hep/commits{/sha}","git_commits_url":"https://api.github.com/repos/decibelCooper/hep/git/commits{/sha}","comments_url":"https://api.github.com/repos/decibelCooper/hep/comments{/number}","issue_comment_url":"https://api.github.com/repos/decibelCooper/hep/issues/comments{/number}","contents_url":"https://api.github.com/repos/decibelCooper/hep/contents/{+path}","compare_url":"https://api.github.com/repos/decibelCooper/hep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decibelCooper/hep/merges","archive_url":"https://api.github.com/repos/decibelCooper/hep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decibelCooper/hep/downloads","issues_url":"https://api.github.com/repos/decibelCooper/hep/issues{/number}","pulls_url":"https://api.github.com/repos/decibelCooper/hep/pulls{/number}","milestones_url":"https://api.github.com/repos/decibelCooper/hep/milestones{/number}","notifications_url":"https://api.github.com/repos/decibelCooper/hep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decibelCooper/hep/labels{/name}","releases_url":"https://api.github.com/repos/decibelCooper/hep/releases{/id}","deployments_url":"https://api.github.com/repos/decibelCooper/hep/deployments","created_at":"2017-06-30T17:29:33Z","updated_at":"2017-06-30T17:29:35Z","pushed_at":"2017-07-06T01:21:43Z","git_url":"git://github.com/decibelCooper/hep.git","ssh_url":"git@github.com:decibelCooper/hep.git","clone_url":"https://github.com/decibelCooper/hep.git","svn_url":"https://github.com/decibelCooper/hep","homepage":"https://go-hep.org","size":4038,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-hep:master","ref":"master","sha":"e9aef3f8f4a7454cf3832aca77847133a6bf4848","user":{"login":"go-hep","id":2822440,"avatar_url":"https://avatars3.githubusercontent.com/u/2822440?v=3","gravatar_id":"","url":"https://api.github.com/users/go-hep","html_url":"https://github.com/go-hep","followers_url":"https://api.github.com/users/go-hep/followers","following_url":"https://api.github.com/users/go-hep/following{/other_user}","gists_url":"https://api.github.com/users/go-hep/gists{/gist_id}","starred_url":"https://api.github.com/users/go-hep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-hep/subscriptions","organizations_url":"https://api.github.com/users/go-hep/orgs","repos_url":"https://api.github.com/users/go-hep/repos","events_url":"https://api.github.com/users/go-hep/events{/privacy}","received_events_url":"https://api.github.com/users/go-hep/received_events","type":"Organization","site_admin":false},"repo":{"id":81190550,"name":"hep","full_name":"go-hep/hep","owner":{"login":"go-hep","id":2822440,"avatar_url":"https://avatars3.githubusercontent.com/u/2822440?v=3","gravatar_id":"","url":"https://api.github.com/users/go-hep","html_url":"https://github.com/go-hep","followers_url":"https://api.github.com/users/go-hep/followers","following_url":"https://api.github.com/users/go-hep/following{/other_user}","gists_url":"https://api.github.com/users/go-hep/gists{/gist_id}","starred_url":"https://api.github.com/users/go-hep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-hep/subscriptions","organizations_url":"https://api.github.com/users/go-hep/orgs","repos_url":"https://api.github.com/users/go-hep/repos","events_url":"https://api.github.com/users/go-hep/events{/privacy}","received_events_url":"https://api.github.com/users/go-hep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-hep/hep","description":"hep is the mono repository holding all of go-hep.org/x/hep packages and tools","fork":false,"url":"https://api.github.com/repos/go-hep/hep","forks_url":"https://api.github.com/repos/go-hep/hep/forks","keys_url":"https://api.github.com/repos/go-hep/hep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-hep/hep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-hep/hep/teams","hooks_url":"https://api.github.com/repos/go-hep/hep/hooks","issue_events_url":"https://api.github.com/repos/go-hep/hep/issues/events{/number}","events_url":"https://api.github.com/repos/go-hep/hep/events","assignees_url":"https://api.github.com/repos/go-hep/hep/assignees{/user}","branches_url":"https://api.github.com/repos/go-hep/hep/branches{/branch}","tags_url":"https://api.github.com/repos/go-hep/hep/tags","blobs_url":"https://api.github.com/repos/go-hep/hep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-hep/hep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-hep/hep/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-hep/hep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-hep/hep/statuses/{sha}","languages_url":"https://api.github.com/repos/go-hep/hep/languages","stargazers_url":"https://api.github.com/repos/go-hep/hep/stargazers","contributors_url":"https://api.github.com/repos/go-hep/hep/contributors","subscribers_url":"https://api.github.com/repos/go-hep/hep/subscribers","subscription_url":"https://api.github.com/repos/go-hep/hep/subscription","commits_url":"https://api.github.com/repos/go-hep/hep/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-hep/hep/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-hep/hep/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-hep/hep/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-hep/hep/contents/{+path}","compare_url":"https://api.github.com/repos/go-hep/hep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-hep/hep/merges","archive_url":"https://api.github.com/repos/go-hep/hep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-hep/hep/downloads","issues_url":"https://api.github.com/repos/go-hep/hep/issues{/number}","pulls_url":"https://api.github.com/repos/go-hep/hep/pulls{/number}","milestones_url":"https://api.github.com/repos/go-hep/hep/milestones{/number}","notifications_url":"https://api.github.com/repos/go-hep/hep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-hep/hep/labels{/name}","releases_url":"https://api.github.com/repos/go-hep/hep/releases{/id}","deployments_url":"https://api.github.com/repos/go-hep/hep/deployments","created_at":"2017-02-07T09:28:30Z","updated_at":"2017-06-26T08:20:00Z","pushed_at":"2017-07-06T01:34:33Z","git_url":"git://github.com/go-hep/hep.git","ssh_url":"git@github.com:go-hep/hep.git","clone_url":"https://github.com/go-hep/hep.git","svn_url":"https://github.com/go-hep/hep","homepage":"https://go-hep.org","size":4038,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":45,"forks":4,"open_issues":45,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-hep/hep/pulls/74"},"html":{"href":"https://github.com/go-hep/hep/pull/74"},"issue":{"href":"https://api.github.com/repos/go-hep/hep/issues/74"},"comments":{"href":"https://api.github.com/repos/go-hep/hep/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/go-hep/hep/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/go-hep/hep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-hep/hep/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/go-hep/hep/statuses/b57c3bc92228b0c747144a0e8d1ed2d64337573d"}}}}
{"actor":{"display_login":"sbinet"}}