{"action":"created","issue":{"url":"https://api.github.com/repos/opentx/opentx/issues/4435","repository_url":"https://api.github.com/repos/opentx/opentx","labels_url":"https://api.github.com/repos/opentx/opentx/issues/4435/labels{/name}","comments_url":"https://api.github.com/repos/opentx/opentx/issues/4435/comments","events_url":"https://api.github.com/repos/opentx/opentx/issues/4435/events","html_url":"https://github.com/opentx/opentx/pull/4435","id":206721917,"number":4435,"title":"Make build setup a little more Windows-friendly","user":{"login":"mpaperno","id":1366615,"avatar_url":"https://avatars.githubusercontent.com/u/1366615?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaperno","html_url":"https://github.com/mpaperno","followers_url":"https://api.github.com/users/mpaperno/followers","following_url":"https://api.github.com/users/mpaperno/following{/other_user}","gists_url":"https://api.github.com/users/mpaperno/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaperno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaperno/subscriptions","organizations_url":"https://api.github.com/users/mpaperno/orgs","repos_url":"https://api.github.com/users/mpaperno/repos","events_url":"https://api.github.com/users/mpaperno/events{/privacy}","received_events_url":"https://api.github.com/users/mpaperno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-10T06:50:18Z","updated_at":"2017-02-10T21:27:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opentx/opentx/pulls/4435","html_url":"https://github.com/opentx/opentx/pull/4435","diff_url":"https://github.com/opentx/opentx/pull/4435.diff","patch_url":"https://github.com/opentx/opentx/pull/4435.patch"},"body":"This adds friendlier warnings in case `grep` or `git` are missing and replaces using `rm` on Windows with `del`.  (git is not actually required, just makes the version stamp more specific, and grep is \"only\" required for building Lua-enabled firmware/simu).\r\n\r\nI also propose including `dirent` and `msinttypes` headers in the source tree -- their licenses allow it, they're not likely to change at this point (and if they do the changes should be reviewed first anyway), it eliminates 2 extra setup steps, plus leaves less room for error/support requests.  \r\n\r\nI'm not sure about also including pthreads, but maybe it's not a bad idea (eg. the latest official 2.9 version doesn't seem to work so we're relying on the old 2.8 version to still be available). License is GPL so shouldn't be a problem there.\r\n\r\nThanks,\r\n-Max"},"comment":{"url":"https://api.github.com/repos/opentx/opentx/issues/comments/279070383","html_url":"https://github.com/opentx/opentx/pull/4435#issuecomment-279070383","issue_url":"https://api.github.com/repos/opentx/opentx/issues/4435","id":279070383,"user":{"login":"mpaperno","id":1366615,"avatar_url":"https://avatars.githubusercontent.com/u/1366615?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaperno","html_url":"https://github.com/mpaperno","followers_url":"https://api.github.com/users/mpaperno/followers","following_url":"https://api.github.com/users/mpaperno/following{/other_user}","gists_url":"https://api.github.com/users/mpaperno/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaperno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaperno/subscriptions","organizations_url":"https://api.github.com/users/mpaperno/orgs","repos_url":"https://api.github.com/users/mpaperno/repos","events_url":"https://api.github.com/users/mpaperno/events{/privacy}","received_events_url":"https://api.github.com/users/mpaperno/received_events","type":"User","site_admin":false},"created_at":"2017-02-10T21:27:13Z","updated_at":"2017-02-10T21:27:13Z","body":"Nice, you just beat me to it on the python script (had to brew some fresh tea).  👍 \r\nI think we can rid of the rm/del detection as well.  Woot!\r\n\r\nGit next.  Also found some raw `python` calls hiding in the Cmake files."}}
{"actor":{"display_login":"mpaperno"}}