{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/22998","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/22998/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/22998/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/22998/events","html_url":"https://github.com/dotnet/corefx/pull/22998","id":248273591,"number":22998,"title":"SslStream Improvements for Unix Performance","user":{"login":"Drawaes","id":16406969,"avatar_url":"https://avatars2.githubusercontent.com/u/16406969?v=4","gravatar_id":"","url":"https://api.github.com/users/Drawaes","html_url":"https://github.com/Drawaes","followers_url":"https://api.github.com/users/Drawaes/followers","following_url":"https://api.github.com/users/Drawaes/following{/other_user}","gists_url":"https://api.github.com/users/Drawaes/gists{/gist_id}","starred_url":"https://api.github.com/users/Drawaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drawaes/subscriptions","organizations_url":"https://api.github.com/users/Drawaes/orgs","repos_url":"https://api.github.com/users/Drawaes/repos","events_url":"https://api.github.com/users/Drawaes/events{/privacy}","received_events_url":"https://api.github.com/users/Drawaes/received_events","type":"User","site_admin":false},"labels":[{"id":497898777,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Net.Security","name":"area-System.Net.Security","color":"d4c5f9","default":false},{"id":197706871,"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":205613977,"url":"https://api.github.com/repos/dotnet/corefx/labels/os-linux","name":"os-linux","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars3.githubusercontent.com/u/7853870?v=4","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"assignees":[{"login":"Priya91","id":7853870,"avatar_url":"https://avatars3.githubusercontent.com/u/7853870?v=4","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},{"login":"geoffkizer","id":12518809,"avatar_url":"https://avatars2.githubusercontent.com/u/12518809?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffkizer","html_url":"https://github.com/geoffkizer","followers_url":"https://api.github.com/users/geoffkizer/followers","following_url":"https://api.github.com/users/geoffkizer/following{/other_user}","gists_url":"https://api.github.com/users/geoffkizer/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffkizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffkizer/subscriptions","organizations_url":"https://api.github.com/users/geoffkizer/orgs","repos_url":"https://api.github.com/users/geoffkizer/repos","events_url":"https://api.github.com/users/geoffkizer/events{/privacy}","received_events_url":"https://api.github.com/users/geoffkizer/received_events","type":"User","site_admin":false},{"login":"Drawaes","id":16406969,"avatar_url":"https://avatars2.githubusercontent.com/u/16406969?v=4","gravatar_id":"","url":"https://api.github.com/users/Drawaes","html_url":"https://github.com/Drawaes","followers_url":"https://api.github.com/users/Drawaes/followers","following_url":"https://api.github.com/users/Drawaes/following{/other_user}","gists_url":"https://api.github.com/users/Drawaes/gists{/gist_id}","starred_url":"https://api.github.com/users/Drawaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drawaes/subscriptions","organizations_url":"https://api.github.com/users/Drawaes/orgs","repos_url":"https://api.github.com/users/Drawaes/repos","events_url":"https://api.github.com/users/Drawaes/events{/privacy}","received_events_url":"https://api.github.com/users/Drawaes/received_events","type":"User","site_admin":false}],"milestone":null,"comments":145,"created_at":"2017-08-06T21:33:56Z","updated_at":"2017-08-23T21:42:56Z","closed_at":"2017-08-22T20:05:36Z","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/22998","html_url":"https://github.com/dotnet/corefx/pull/22998","diff_url":"https://github.com/dotnet/corefx/pull/22998.diff","patch_url":"https://github.com/dotnet/corefx/pull/22998.patch"},"body":"#21371\r\nChanged the OpenSsl code to use a \"custom\" bio that uses the buffers from managed code directly rather than using an interim MemoryBio to stop extra copying.\r\n\r\nThis alone didn't provide much performance however I have modified the encrypt side to write directly to the output buffer, if the content is too large it will then send that to the socket and return to get more of the frame/frames.\r\n\r\nThis should setup the future for improvements on the read side and to react to Buffer/Span changes.\r\n\r\nThe performance diff I see on my hardware using the Techempower plaintext on Ubuntu 14.04 with SSL turned on is as below these are unconfirmed numbers. There is a clear convergence of the new and old code as the send sizes get bigger, the numbers don't include the HTTP Header, so the 11 bytes == Hello World. The tests use 256 connections, and pipelining with a depth of 16\r\n\r\n![2017-08-06 22_28_44-new test results](https://user-images.githubusercontent.com/16406969/29007252-b9162fa6-7af6-11e7-9fdf-50431c4b4c94.png)\r\n\r\n \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/324470981","html_url":"https://github.com/dotnet/corefx/pull/22998#issuecomment-324470981","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/22998","id":324470981,"user":{"login":"Drawaes","id":16406969,"avatar_url":"https://avatars2.githubusercontent.com/u/16406969?v=4","gravatar_id":"","url":"https://api.github.com/users/Drawaes","html_url":"https://github.com/Drawaes","followers_url":"https://api.github.com/users/Drawaes/followers","following_url":"https://api.github.com/users/Drawaes/following{/other_user}","gists_url":"https://api.github.com/users/Drawaes/gists{/gist_id}","starred_url":"https://api.github.com/users/Drawaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drawaes/subscriptions","organizations_url":"https://api.github.com/users/Drawaes/orgs","repos_url":"https://api.github.com/users/Drawaes/repos","events_url":"https://api.github.com/users/Drawaes/events{/privacy}","received_events_url":"https://api.github.com/users/Drawaes/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T21:42:55Z","updated_at":"2017-08-23T21:42:55Z","body":"Cool.. I am feeling upbeat, I got vtune working on my benchmark machines finally...so if I seemed to have gone quiet I haven't stopped looking :) I might have some interesting numbers (or not but hey proving it's not something is useful as well right ? ) soon."}}
{"actor":{"display_login":"Drawaes"}}