{"action":"created","issue":{"url":"https://api.github.com/repos/servo/ipc-channel/issues/139","repository_url":"https://api.github.com/repos/servo/ipc-channel","labels_url":"https://api.github.com/repos/servo/ipc-channel/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/servo/ipc-channel/issues/139/comments","events_url":"https://api.github.com/repos/servo/ipc-channel/issues/139/events","html_url":"https://github.com/servo/ipc-channel/pull/139","id":206314307,"number":139,"title":"tests: `fork()`: Automatically exit child process after closure returns","user":{"login":"antrik","id":19555,"avatar_url":"https://avatars.githubusercontent.com/u/19555?v=3","gravatar_id":"","url":"https://api.github.com/users/antrik","html_url":"https://github.com/antrik","followers_url":"https://api.github.com/users/antrik/followers","following_url":"https://api.github.com/users/antrik/following{/other_user}","gists_url":"https://api.github.com/users/antrik/gists{/gist_id}","starred_url":"https://api.github.com/users/antrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antrik/subscriptions","organizations_url":"https://api.github.com/users/antrik/orgs","repos_url":"https://api.github.com/users/antrik/repos","events_url":"https://api.github.com/users/antrik/events{/privacy}","received_events_url":"https://api.github.com/users/antrik/received_events","type":"User","site_admin":false},"labels":[{"id":508891357,"url":"https://api.github.com/repos/servo/ipc-channel/labels/S-awaiting-review","name":"S-awaiting-review","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"metajack","id":28357,"avatar_url":"https://avatars.githubusercontent.com/u/28357?v=3","gravatar_id":"","url":"https://api.github.com/users/metajack","html_url":"https://github.com/metajack","followers_url":"https://api.github.com/users/metajack/followers","following_url":"https://api.github.com/users/metajack/following{/other_user}","gists_url":"https://api.github.com/users/metajack/gists{/gist_id}","starred_url":"https://api.github.com/users/metajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metajack/subscriptions","organizations_url":"https://api.github.com/users/metajack/orgs","repos_url":"https://api.github.com/users/metajack/repos","events_url":"https://api.github.com/users/metajack/events{/privacy}","received_events_url":"https://api.github.com/users/metajack/received_events","type":"User","site_admin":false},"assignees":[{"login":"metajack","id":28357,"avatar_url":"https://avatars.githubusercontent.com/u/28357?v=3","gravatar_id":"","url":"https://api.github.com/users/metajack","html_url":"https://github.com/metajack","followers_url":"https://api.github.com/users/metajack/followers","following_url":"https://api.github.com/users/metajack/following{/other_user}","gists_url":"https://api.github.com/users/metajack/gists{/gist_id}","starred_url":"https://api.github.com/users/metajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metajack/subscriptions","organizations_url":"https://api.github.com/users/metajack/orgs","repos_url":"https://api.github.com/users/metajack/repos","events_url":"https://api.github.com/users/metajack/events{/privacy}","received_events_url":"https://api.github.com/users/metajack/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-02-08T20:26:08Z","updated_at":"2017-02-08T20:52:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/ipc-channel/pulls/139","html_url":"https://github.com/servo/ipc-channel/pull/139","diff_url":"https://github.com/servo/ipc-channel/pull/139.diff","patch_url":"https://github.com/servo/ipc-channel/pull/139.patch"},"body":"Rather than panicking, just exit the process cleanly.\r\n\r\nThe idea with this was that the closure is never supposed to return,\r\nsince chaos would ensue otherwise, as the child process and the parent\r\nprocess would continue running the rest of the test suite.\r\n\r\nHowever, the existing `unreachable!()` panic that was supposed to\r\nenforce this, effectively just terminated the process anyway. The panic\r\nmessage wouldn't even show up unless using `--nocapture`. So we can just\r\nas well make this official, so callers are no longer required to exit\r\nthe process explicitly. This actually makes use of `fork()` more\r\nergonomic."},"comment":{"url":"https://api.github.com/repos/servo/ipc-channel/issues/comments/278457905","html_url":"https://github.com/servo/ipc-channel/pull/139#issuecomment-278457905","issue_url":"https://api.github.com/repos/servo/ipc-channel/issues/139","id":278457905,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2017-02-08T20:52:20Z","updated_at":"2017-02-08T20:52:20Z","body":":pushpin: Commit 38eba4b has been approved by `metajack`\n\n<!-- @bors-servo r=metajack 38eba4baac66c0b09382f95a70f03f89624716e3 -->"}}
{"actor":{"display_login":"bors-servo"}}