{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/150296900","pull_request_review_id":75831854,"id":150296900,"diff_hunk":"@@ -58,6 +58,21 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL Clang)\n endif(CMAKE_CXX_COMPILER_ID STREQUAL GNU)\n set(CMAKE_CXX_FLAGS \"${CMAKE_C_FLAGS} ${CMAKE_CXX_FLAGS}\")\n \n+include(CheckCXXSourceCompiles)\n+CHECK_CXX_SOURCE_COMPILES(\"\n+int main() {\n+#ifdef __GLIBCXX__\n+#if __GLIBCXX__ < 20150422ul /* libstdc++ < 5.1.0 */\n+#error slow std::list::size()\n+#endif\n+#endif\n+}\n+\" HAVE_GLIBCXX_5_1)\n+if(NOT HAVE_GLIBCXX_5_1)\n+  # libc++'s list::size() is O(1) also.\n+  message(WARNING \"performance regression is expected due to an O(n) implementation of 'std::list::size()' in libstdc++ older than 5.1.0\")","path":"src/CMakeLists.txt","position":16,"original_position":16,"commit_id":"3391c58b6f9dd08beccac7958a3766f32900f6c6","original_commit_id":"38023d7a4de9811263c6253f1565a5a1c1902bf8","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"Hmm, I'm not sure we've discussed it.  Is trusty the only one that is problematic here?  I would very happily drop trusty!","created_at":"2017-11-10T17:42:25Z","updated_at":"2017-11-10T17:42:25Z","html_url":"https://github.com/ceph/ceph/pull/18863#discussion_r150296900","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/18863","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/150296900"},"html":{"href":"https://github.com/ceph/ceph/pull/18863#discussion_r150296900"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18863"}},"in_reply_to_id":150230018},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/18863","id":151819242,"html_url":"https://github.com/ceph/ceph/pull/18863","diff_url":"https://github.com/ceph/ceph/pull/18863.diff","patch_url":"https://github.com/ceph/ceph/pull/18863.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/18863","number":18863,"state":"open","locked":false,"title":"build/ops: use devtoolset-7 on centos/rhel-7","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-10T03:33:58Z","updated_at":"2017-11-10T17:42:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"898b97e73e7d18d7f28ec09a1c0cf2446fbe2d72","assignee":null,"assignees":[],"requested_reviewers":[{"login":"smithfarm","id":3974844,"avatar_url":"https://avatars2.githubusercontent.com/u/3974844?v=4","gravatar_id":"","url":"https://api.github.com/users/smithfarm","html_url":"https://github.com/smithfarm","followers_url":"https://api.github.com/users/smithfarm/followers","following_url":"https://api.github.com/users/smithfarm/following{/other_user}","gists_url":"https://api.github.com/users/smithfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/smithfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithfarm/subscriptions","organizations_url":"https://api.github.com/users/smithfarm/orgs","repos_url":"https://api.github.com/users/smithfarm/repos","events_url":"https://api.github.com/users/smithfarm/events{/privacy}","received_events_url":"https://api.github.com/users/smithfarm/received_events","type":"User","site_admin":false},{"login":"b-ranto","id":8439091,"avatar_url":"https://avatars2.githubusercontent.com/u/8439091?v=4","gravatar_id":"","url":"https://api.github.com/users/b-ranto","html_url":"https://github.com/b-ranto","followers_url":"https://api.github.com/users/b-ranto/followers","following_url":"https://api.github.com/users/b-ranto/following{/other_user}","gists_url":"https://api.github.com/users/b-ranto/gists{/gist_id}","starred_url":"https://api.github.com/users/b-ranto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-ranto/subscriptions","organizations_url":"https://api.github.com/users/b-ranto/orgs","repos_url":"https://api.github.com/users/b-ranto/repos","events_url":"https://api.github.com/users/b-ranto/events{/privacy}","received_events_url":"https://api.github.com/users/b-ranto/received_events","type":"User","site_admin":false},{"login":"aclamk","id":13020832,"avatar_url":"https://avatars1.githubusercontent.com/u/13020832?v=4","gravatar_id":"","url":"https://api.github.com/users/aclamk","html_url":"https://github.com/aclamk","followers_url":"https://api.github.com/users/aclamk/followers","following_url":"https://api.github.com/users/aclamk/following{/other_user}","gists_url":"https://api.github.com/users/aclamk/gists{/gist_id}","starred_url":"https://api.github.com/users/aclamk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aclamk/subscriptions","organizations_url":"https://api.github.com/users/aclamk/orgs","repos_url":"https://api.github.com/users/aclamk/repos","events_url":"https://api.github.com/users/aclamk/events{/privacy}","received_events_url":"https://api.github.com/users/aclamk/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/18863/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/18863/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/18863/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/3391c58b6f9dd08beccac7958a3766f32900f6c6","head":{"label":"tchaikov:wip-devtoolset-7","ref":"wip-devtoolset-7","sha":"3391c58b6f9dd08beccac7958a3766f32900f6c6","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"repo":{"id":26736928,"name":"ceph","full_name":"tchaikov/ceph","owner":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tchaikov/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/tchaikov/ceph","forks_url":"https://api.github.com/repos/tchaikov/ceph/forks","keys_url":"https://api.github.com/repos/tchaikov/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tchaikov/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tchaikov/ceph/teams","hooks_url":"https://api.github.com/repos/tchaikov/ceph/hooks","issue_events_url":"https://api.github.com/repos/tchaikov/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tchaikov/ceph/events","assignees_url":"https://api.github.com/repos/tchaikov/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tchaikov/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tchaikov/ceph/tags","blobs_url":"https://api.github.com/repos/tchaikov/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tchaikov/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tchaikov/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tchaikov/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tchaikov/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tchaikov/ceph/languages","stargazers_url":"https://api.github.com/repos/tchaikov/ceph/stargazers","contributors_url":"https://api.github.com/repos/tchaikov/ceph/contributors","subscribers_url":"https://api.github.com/repos/tchaikov/ceph/subscribers","subscription_url":"https://api.github.com/repos/tchaikov/ceph/subscription","commits_url":"https://api.github.com/repos/tchaikov/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tchaikov/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tchaikov/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tchaikov/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tchaikov/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tchaikov/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tchaikov/ceph/merges","archive_url":"https://api.github.com/repos/tchaikov/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tchaikov/ceph/downloads","issues_url":"https://api.github.com/repos/tchaikov/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tchaikov/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tchaikov/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tchaikov/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tchaikov/ceph/labels{/name}","releases_url":"https://api.github.com/repos/tchaikov/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/tchaikov/ceph/deployments","created_at":"2014-11-17T02:40:21Z","updated_at":"2017-03-03T08:58:24Z","pushed_at":"2017-11-10T15:55:01Z","git_url":"git://github.com/tchaikov/ceph.git","ssh_url":"git@github.com:tchaikov/ceph.git","clone_url":"https://github.com/tchaikov/ceph.git","svn_url":"https://github.com/tchaikov/ceph","homepage":"http://ceph.com","size":258931,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"39da34bfba42337a78e064e8a1f17be3e6b62e64","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-11-10T02:52:34Z","pushed_at":"2017-11-10T17:35:14Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":254625,"stargazers_count":3789,"watchers_count":3789,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2167,"mirror_url":null,"archived":false,"open_issues_count":551,"forks":2167,"open_issues":551,"watchers":3789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18863"},"html":{"href":"https://github.com/ceph/ceph/pull/18863"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/18863"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/18863/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18863/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/18863/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/3391c58b6f9dd08beccac7958a3766f32900f6c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liewegas"}}