{"action":"created","issue":{"url":"https://api.github.com/repos/GriddleGriddle/Griddle/issues/757","repository_url":"https://api.github.com/repos/GriddleGriddle/Griddle","labels_url":"https://api.github.com/repos/GriddleGriddle/Griddle/issues/757/labels{/name}","comments_url":"https://api.github.com/repos/GriddleGriddle/Griddle/issues/757/comments","events_url":"https://api.github.com/repos/GriddleGriddle/Griddle/issues/757/events","html_url":"https://github.com/GriddleGriddle/Griddle/pull/757","id":265884610,"number":757,"title":"Extract Initializer","user":{"login":"dahlbyk","id":133987,"avatar_url":"https://avatars1.githubusercontent.com/u/133987?v=4","gravatar_id":"","url":"https://api.github.com/users/dahlbyk","html_url":"https://github.com/dahlbyk","followers_url":"https://api.github.com/users/dahlbyk/followers","following_url":"https://api.github.com/users/dahlbyk/following{/other_user}","gists_url":"https://api.github.com/users/dahlbyk/gists{/gist_id}","starred_url":"https://api.github.com/users/dahlbyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahlbyk/subscriptions","organizations_url":"https://api.github.com/users/dahlbyk/orgs","repos_url":"https://api.github.com/users/dahlbyk/repos","events_url":"https://api.github.com/users/dahlbyk/events{/privacy}","received_events_url":"https://api.github.com/users/dahlbyk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-16T19:20:26Z","updated_at":"2017-10-20T19:31:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/GriddleGriddle/Griddle/pulls/757","html_url":"https://github.com/GriddleGriddle/Griddle/pull/757","diff_url":"https://github.com/GriddleGriddle/Griddle/pull/757.diff","patch_url":"https://github.com/GriddleGriddle/Griddle/pull/757.patch"},"body":"## Griddle major version\r\n\r\n1.x\r\n\r\n## Changes proposed in this pull request\r\n\r\nPulls the default+plugin+props composition out of the Griddle constructor into a testable initializer.\r\n\r\nThis is really just prep to work on supporting function plugins for #733.\r\n\r\n## Why these changes are made\r\n\r\nTests are good, especially for this sort of composition (which seems likely to get more complex).\r\n\r\n## Are there tests?\r\n\r\nLots!"},"comment":{"url":"https://api.github.com/repos/GriddleGriddle/Griddle/issues/comments/338301964","html_url":"https://github.com/GriddleGriddle/Griddle/pull/757#issuecomment-338301964","issue_url":"https://api.github.com/repos/GriddleGriddle/Griddle/issues/757","id":338301964,"user":{"login":"dahlbyk","id":133987,"avatar_url":"https://avatars1.githubusercontent.com/u/133987?v=4","gravatar_id":"","url":"https://api.github.com/users/dahlbyk","html_url":"https://github.com/dahlbyk","followers_url":"https://api.github.com/users/dahlbyk/followers","following_url":"https://api.github.com/users/dahlbyk/following{/other_user}","gists_url":"https://api.github.com/users/dahlbyk/gists{/gist_id}","starred_url":"https://api.github.com/users/dahlbyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahlbyk/subscriptions","organizations_url":"https://api.github.com/users/dahlbyk/orgs","repos_url":"https://api.github.com/users/dahlbyk/repos","events_url":"https://api.github.com/users/dahlbyk/events{/privacy}","received_events_url":"https://api.github.com/users/dahlbyk/received_events","type":"User","site_admin":false},"created_at":"2017-10-20T19:31:46Z","updated_at":"2017-10-20T19:31:46Z","author_association":"CONTRIBUTOR","body":"Inspired by #760, I've added commits to pull the current `defaults` into a `CorePlugin` of sorts that can be replaced (or omitted) via `<Griddle core={...} />`. Not sure if `core` is the right name for it, but it does seem a useful extra seem to adjust Griddle default behavior.\r\n\r\nI did not bring in @shorja's `core` support for accepting a function from `props`, so parsing `renderProperties` from `children` (`RowDefinition`/`ColumnDefinition`) is the only behavior that's really not extensible. I'm not thrilled with `core` as function-of-`props` because for #733 I have been thinking of plugins as more of a reducer. But I'm not sure what a better pattern for handling `renderProperties` would be."}}
{"actor":{"display_login":"dahlbyk"}}