{"action":"closed","issue":{"url":"https://api.github.com/repos/paritytech/second-price-auction/issues/17","repository_url":"https://api.github.com/repos/paritytech/second-price-auction","labels_url":"https://api.github.com/repos/paritytech/second-price-auction/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/paritytech/second-price-auction/issues/17/comments","events_url":"https://api.github.com/repos/paritytech/second-price-auction/issues/17/events","html_url":"https://github.com/paritytech/second-price-auction/issues/17","id":261526781,"number":17,"title":"Allow refunds at the tail end.","user":{"login":"MicahZoltu","id":886059,"avatar_url":"https://avatars2.githubusercontent.com/u/886059?v=4","gravatar_id":"","url":"https://api.github.com/users/MicahZoltu","html_url":"https://github.com/MicahZoltu","followers_url":"https://api.github.com/users/MicahZoltu/followers","following_url":"https://api.github.com/users/MicahZoltu/following{/other_user}","gists_url":"https://api.github.com/users/MicahZoltu/gists{/gist_id}","starred_url":"https://api.github.com/users/MicahZoltu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicahZoltu/subscriptions","organizations_url":"https://api.github.com/users/MicahZoltu/orgs","repos_url":"https://api.github.com/users/MicahZoltu/repos","events_url":"https://api.github.com/users/MicahZoltu/events{/privacy}","received_events_url":"https://api.github.com/users/MicahZoltu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-29T04:08:46Z","updated_at":"2017-10-03T16:32:37Z","closed_at":"2017-10-03T16:32:37Z","author_association":"NONE","body":"https://github.com/paritytech/second-price-auction/blob/master/src/contracts/SecondPriceAuction.sol#L96\r\n\r\nThis line will result in a ton of transaction spam at the end of the auction that will clog up the network and burn a lot of gas needlessly.  When the auction is coming to a close, the FOMO will kick in and people will scramble to buy the last bits.  This will result in people sending transactions to max out the remaining amount but other users will get in first (especially because transaction ordering by miners is non-deterministic with a gas cap).  These people will then have their transactions fail, burning all of the gas in the transaction, and then they will try again with the new max value, which will once again be wrong by the time they get in.\r\n\r\nRecommendation: Refund any amount in excess of the cap to the caller."}}
{"actor":{"display_login":"gavofyork"}}