{"action":"created","comment":{"url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments/141440780","pull_request_review_id":65655332,"id":141440780,"diff_hunk":"@@ -0,0 +1,49 @@\n+export default [\n+  {\n+    type: 'do',\n+    title: 'override theme variables at the top level',\n+    example: `\n+\\`\\`\\`\n+import { mineralTheme } from 'mineral-ui/utils';\n+\n+<ThemeProvider theme={{\n+  ...mineralTheme,\n+  color_primary: 'rebeccapurple'\n+}}>\n+  <App />\n+</ThemeProvider>\n+\\`\\`\\`\n+`,\n+    description: `Try to keep theme overrides all in one place, as they will be easier to change later.`\n+  },\n+  {\n+    type: 'do',\n+    title: 'use a second or third themeprovider to style different sections',\n+    example: `\n+\\`\\`\\`\n+<ThemeProvider>\n+  <div>The Main Part of your app</div>\n+  <ThemeProvider theme={{\n+    color_primary: 'limegreen'\n+  }}>\n+    <div>The admin section</div>\n+  </ThemeProvider\n+</ThemeProvider>\n+\\`\\`\\`\n+`,\n+    description: `You might want to style different sections of your app with different themes,\n+    such as admin consoles, or a preferences section to create a visual separation.`","path":"src/website/app/demos/ThemeProvider/bestPractices.js","position":35,"original_position":35,"commit_id":"1006dddf6cea968991ed47e43f8007a47ed85ae4","original_commit_id":"1006dddf6cea968991ed47e43f8007a47ed85ae4","user":{"login":"riley","id":282503,"avatar_url":"https://avatars0.githubusercontent.com/u/282503?v=4","gravatar_id":"","url":"https://api.github.com/users/riley","html_url":"https://github.com/riley","followers_url":"https://api.github.com/users/riley/followers","following_url":"https://api.github.com/users/riley/following{/other_user}","gists_url":"https://api.github.com/users/riley/gists{/gist_id}","starred_url":"https://api.github.com/users/riley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riley/subscriptions","organizations_url":"https://api.github.com/users/riley/orgs","repos_url":"https://api.github.com/users/riley/repos","events_url":"https://api.github.com/users/riley/events{/privacy}","received_events_url":"https://api.github.com/users/riley/received_events","type":"User","site_admin":false},"body":"addressed","created_at":"2017-09-27T19:13:36Z","updated_at":"2017-09-27T19:13:36Z","html_url":"https://github.com/mineral-ui/mineral-ui/pull/352#discussion_r141440780","pull_request_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments/141440780"},"html":{"href":"https://github.com/mineral-ui/mineral-ui/pull/352#discussion_r141440780"},"pull_request":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352"}},"in_reply_to_id":141248446},"pull_request":{"url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352","id":142210272,"html_url":"https://github.com/mineral-ui/mineral-ui/pull/352","diff_url":"https://github.com/mineral-ui/mineral-ui/pull/352.diff","patch_url":"https://github.com/mineral-ui/mineral-ui/pull/352.patch","issue_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/352","number":352,"state":"open","locked":false,"title":"[Website] component docs content","user":{"login":"riley","id":282503,"avatar_url":"https://avatars0.githubusercontent.com/u/282503?v=4","gravatar_id":"","url":"https://api.github.com/users/riley","html_url":"https://github.com/riley","followers_url":"https://api.github.com/users/riley/followers","following_url":"https://api.github.com/users/riley/following{/other_user}","gists_url":"https://api.github.com/users/riley/gists{/gist_id}","starred_url":"https://api.github.com/users/riley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riley/subscriptions","organizations_url":"https://api.github.com/users/riley/orgs","repos_url":"https://api.github.com/users/riley/repos","events_url":"https://api.github.com/users/riley/events{/privacy}","received_events_url":"https://api.github.com/users/riley/received_events","type":"User","site_admin":false},"body":"closes #346 \r\n\r\n### Description\r\nThe component pages needed context to explain intended usage. This PR moves the needle a bit towards having a documented design system.\r\n\r\n_Note: I was going to put mineral content from wikipedia in here, and while we might do that eventually, it should probably be a separate effort. The CC license allows us to use images and copy for the most part, but we have some hoops to jump through, and we shouldn't do it incorrectly._\r\n\r\n### Motivation and context\r\nWe had good docs on _how_ to use the components, but we needed a bit more of when and how to use the components and what their intended uses are. This PR also removes the Fill Murray content, since technically that needs attribution too now that it's public-facing.\r\n\r\n### How to test\r\n1. `cd mineral-ui && npm start`\r\n2. All the components pages have been updated. Make sure I didn't mispel anything.\r\n3. Sections to check are Intro, all the examples, When/How, and Dos and Don'ts\r\n\r\n### Types of changes\r\n- Docs\r\n\r\n### Checklist\r\n<!-- Put an `x` in all the boxes that apply and are complete. If an item does not apply, put an `x` in it anyway and add \"[n/a]\" to the end of the line. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n* [x] Renders and functions properly in [all supported browsers](https://github.com/mineral-ui/mineral-ui#browser-support)\r\n* [x] Automated tests written and passing\r\n* [x] [Accessibility](http://webaim.org/intro) and [inclusivity](https://24ways.org/2016/what-the-heck-is-inclusive-design/) considered\r\n* [x] Rendering performance (initial load time & 60fps) and [perceived performance](http://blog.teamtreehouse.com/perceived-performance) considered\r\n* [x] Documentation created or updated\r\n* [x] Tested in [sandbox](https://github.com/facebookincubator/create-react-app#getting-started) if new component or breaking change [n/a]\r\n\r\n<!-- If any of the above need further details, you should include those here. -->\r\n\r\n### How does this PR make you feel?\r\n![Alt text here](https://media.giphy.com/media/14w9WNvpFKXoZO/giphy.gif)\r\n","created_at":"2017-09-20T21:43:42Z","updated_at":"2017-09-27T19:13:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"397e0ceb86c6daef990cade4e0924a687328d852","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352/commits","review_comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352/comments","review_comment_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/352/comments","statuses_url":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/1006dddf6cea968991ed47e43f8007a47ed85ae4","head":{"label":"mineral-ui:synthesize-component-docs","ref":"synthesize-component-docs","sha":"1006dddf6cea968991ed47e43f8007a47ed85ae4","user":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":87827232,"name":"mineral-ui","full_name":"mineral-ui/mineral-ui","owner":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mineral-ui/mineral-ui","description":"A design system and React component library for the web brought to you by CA Technologies.","fork":false,"url":"https://api.github.com/repos/mineral-ui/mineral-ui","forks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/forks","keys_url":"https://api.github.com/repos/mineral-ui/mineral-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mineral-ui/mineral-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mineral-ui/mineral-ui/teams","hooks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/hooks","issue_events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/events","assignees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mineral-ui/mineral-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/tags","blobs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mineral-ui/mineral-ui/languages","stargazers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/stargazers","contributors_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contributors","subscribers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscribers","subscription_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscription","commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mineral-ui/mineral-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mineral-ui/mineral-ui/merges","archive_url":"https://api.github.com/repos/mineral-ui/mineral-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mineral-ui/mineral-ui/downloads","issues_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mineral-ui/mineral-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mineral-ui/mineral-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mineral-ui/mineral-ui/labels{/name}","releases_url":"https://api.github.com/repos/mineral-ui/mineral-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/deployments","created_at":"2017-04-10T15:29:20Z","updated_at":"2017-09-26T21:19:54Z","pushed_at":"2017-09-27T18:44:27Z","git_url":"git://github.com/mineral-ui/mineral-ui.git","ssh_url":"git@github.com:mineral-ui/mineral-ui.git","clone_url":"https://github.com/mineral-ui/mineral-ui.git","svn_url":"https://github.com/mineral-ui/mineral-ui","homepage":"http://mineral-ui.com","size":3800,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":90,"forks":3,"open_issues":90,"watchers":62,"default_branch":"master"}},"base":{"label":"mineral-ui:master","ref":"master","sha":"a5fbeb747da1a272274197984a92b8fc2c18d335","user":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":87827232,"name":"mineral-ui","full_name":"mineral-ui/mineral-ui","owner":{"login":"mineral-ui","id":27220460,"avatar_url":"https://avatars1.githubusercontent.com/u/27220460?v=4","gravatar_id":"","url":"https://api.github.com/users/mineral-ui","html_url":"https://github.com/mineral-ui","followers_url":"https://api.github.com/users/mineral-ui/followers","following_url":"https://api.github.com/users/mineral-ui/following{/other_user}","gists_url":"https://api.github.com/users/mineral-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/mineral-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mineral-ui/subscriptions","organizations_url":"https://api.github.com/users/mineral-ui/orgs","repos_url":"https://api.github.com/users/mineral-ui/repos","events_url":"https://api.github.com/users/mineral-ui/events{/privacy}","received_events_url":"https://api.github.com/users/mineral-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mineral-ui/mineral-ui","description":"A design system and React component library for the web brought to you by CA Technologies.","fork":false,"url":"https://api.github.com/repos/mineral-ui/mineral-ui","forks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/forks","keys_url":"https://api.github.com/repos/mineral-ui/mineral-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mineral-ui/mineral-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mineral-ui/mineral-ui/teams","hooks_url":"https://api.github.com/repos/mineral-ui/mineral-ui/hooks","issue_events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mineral-ui/mineral-ui/events","assignees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mineral-ui/mineral-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/tags","blobs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mineral-ui/mineral-ui/languages","stargazers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/stargazers","contributors_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contributors","subscribers_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscribers","subscription_url":"https://api.github.com/repos/mineral-ui/mineral-ui/subscription","commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mineral-ui/mineral-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mineral-ui/mineral-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mineral-ui/mineral-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mineral-ui/mineral-ui/merges","archive_url":"https://api.github.com/repos/mineral-ui/mineral-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mineral-ui/mineral-ui/downloads","issues_url":"https://api.github.com/repos/mineral-ui/mineral-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mineral-ui/mineral-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mineral-ui/mineral-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mineral-ui/mineral-ui/labels{/name}","releases_url":"https://api.github.com/repos/mineral-ui/mineral-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mineral-ui/mineral-ui/deployments","created_at":"2017-04-10T15:29:20Z","updated_at":"2017-09-26T21:19:54Z","pushed_at":"2017-09-27T18:44:27Z","git_url":"git://github.com/mineral-ui/mineral-ui.git","ssh_url":"git@github.com:mineral-ui/mineral-ui.git","clone_url":"https://github.com/mineral-ui/mineral-ui.git","svn_url":"https://github.com/mineral-ui/mineral-ui","homepage":"http://mineral-ui.com","size":3800,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":90,"forks":3,"open_issues":90,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352"},"html":{"href":"https://github.com/mineral-ui/mineral-ui/pull/352"},"issue":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/352"},"comments":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/mineral-ui/mineral-ui/statuses/1006dddf6cea968991ed47e43f8007a47ed85ae4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"riley"}}