{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/113755088","pull_request_review_id":35171234,"id":113755088,"diff_hunk":"@@ -170,24 +175,20 @@ func (i *InteractionHandlersImpl) ContainerResizeHandler(params interaction.Cont\n func (i *InteractionHandlersImpl) ContainerSetStdinHandler(params interaction.ContainerSetStdinParams) middleware.Responder {\n \tdefer trace.End(trace.Begin(params.ID))\n \n-\tvar ctxDeadline time.Time\n-\tvar timeout time.Duration\n-\n-\t// Calculate the timeout for the attach if the caller specified a deadline.  This deadline\n+\tctx, cancel := context.WithTimeout(context.Background(), interactionTimeout)\n \tif params.Deadline != nil {\n-\t\tctxDeadline = time.Time(*params.Deadline)\n-\t\ttimeout = ctxDeadline.Sub(time.Now())\n-\t\tlog.Debugf(\"Attempting to get ssh session for container %s stdin with deadline %s\", params.ID, ctxDeadline.Format(time.UnixDate))\n-\t\tif timeout < 0 {\n-\t\t\te := &models.Error{Message: fmt.Sprintf(\"Deadline for stdin already passed for container %s\", params.ID)}\n-\t\t\treturn interaction.NewContainerSetStdinInternalServerError().WithPayload(e)\n+\t\tctx, cancel = context.WithDeadline(context.Background(), time.Time(*params.Deadline))\n+\t}\n+\tdefer cancel()\n+\n+\tif ctx.Err() == context.DeadlineExceeded {","path":"lib/apiservers/portlayer/restapi/handlers/interaction_handlers.go","position":82,"original_position":82,"commit_id":"5c93dd89f144098e5f7e5578b8ae37a284527a1b","original_commit_id":"0522308b7ba82ca26f072747f2f02447de5cbf89","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars3.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"It was written this way originally, droping them","created_at":"2017-04-27T17:24:21Z","updated_at":"2017-04-27T17:24:21Z","html_url":"https://github.com/vmware/vic/pull/4339#discussion_r113755088","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/4339","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/113755088"},"html":{"href":"https://github.com/vmware/vic/pull/4339#discussion_r113755088"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/4339"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/4339","id":112095777,"html_url":"https://github.com/vmware/vic/pull/4339","diff_url":"https://github.com/vmware/vic/pull/4339.diff","patch_url":"https://github.com/vmware/vic/pull/4339.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/4339","number":4339,"state":"open","locked":false,"title":"[full ci] Attach support for exec'ed session","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars3.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"Fixes #4263\r\nFixes #4367\r\nFixes #4598 \r\nFixes #4410\r\nFixes #4339\r\nFixes #4881\r\n\r\nRequires #4288 ","created_at":"2017-03-22T19:50:23Z","updated_at":"2017-04-27T17:24:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e2e2ed5bdb46c263ad637da32049f95772e1ca1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/4339/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/4339/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/4339/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/5c93dd89f144098e5f7e5578b8ae37a284527a1b","head":{"label":"caglar10ur:attach","ref":"attach","sha":"5c93dd89f144098e5f7e5578b8ae37a284527a1b","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars3.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"repo":{"id":55449160,"name":"vic","full_name":"caglar10ur/vic","owner":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars3.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caglar10ur/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/caglar10ur/vic","forks_url":"https://api.github.com/repos/caglar10ur/vic/forks","keys_url":"https://api.github.com/repos/caglar10ur/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caglar10ur/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caglar10ur/vic/teams","hooks_url":"https://api.github.com/repos/caglar10ur/vic/hooks","issue_events_url":"https://api.github.com/repos/caglar10ur/vic/issues/events{/number}","events_url":"https://api.github.com/repos/caglar10ur/vic/events","assignees_url":"https://api.github.com/repos/caglar10ur/vic/assignees{/user}","branches_url":"https://api.github.com/repos/caglar10ur/vic/branches{/branch}","tags_url":"https://api.github.com/repos/caglar10ur/vic/tags","blobs_url":"https://api.github.com/repos/caglar10ur/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caglar10ur/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caglar10ur/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/caglar10ur/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caglar10ur/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/caglar10ur/vic/languages","stargazers_url":"https://api.github.com/repos/caglar10ur/vic/stargazers","contributors_url":"https://api.github.com/repos/caglar10ur/vic/contributors","subscribers_url":"https://api.github.com/repos/caglar10ur/vic/subscribers","subscription_url":"https://api.github.com/repos/caglar10ur/vic/subscription","commits_url":"https://api.github.com/repos/caglar10ur/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/caglar10ur/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/caglar10ur/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/caglar10ur/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/caglar10ur/vic/contents/{+path}","compare_url":"https://api.github.com/repos/caglar10ur/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caglar10ur/vic/merges","archive_url":"https://api.github.com/repos/caglar10ur/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caglar10ur/vic/downloads","issues_url":"https://api.github.com/repos/caglar10ur/vic/issues{/number}","pulls_url":"https://api.github.com/repos/caglar10ur/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/caglar10ur/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/caglar10ur/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caglar10ur/vic/labels{/name}","releases_url":"https://api.github.com/repos/caglar10ur/vic/releases{/id}","deployments_url":"https://api.github.com/repos/caglar10ur/vic/deployments","created_at":"2016-04-04T22:13:10Z","updated_at":"2016-04-04T22:13:12Z","pushed_at":"2017-04-27T00:29:00Z","git_url":"git://github.com/caglar10ur/vic.git","ssh_url":"git@github.com:caglar10ur/vic.git","clone_url":"https://github.com/caglar10ur/vic.git","svn_url":"https://github.com/caglar10ur/vic","homepage":null,"size":46035,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"69f21b20b13f84f34eb40d033b4ae2859b2375e7","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2017-04-27T13:56:57Z","pushed_at":"2017-04-27T17:17:26Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"http://vmware.github.io/vic","size":55240,"stargazers_count":228,"watchers_count":228,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":775,"forks":90,"open_issues":775,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/4339"},"html":{"href":"https://github.com/vmware/vic/pull/4339"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/4339"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/4339/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/4339/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/4339/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/5c93dd89f144098e5f7e5578b8ae37a284527a1b"}}}}
{"actor":{"display_login":"caglar10ur"}}