{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/118536882","pull_request_review_id":40339328,"id":118536882,"diff_hunk":"@@ -172,20 +174,42 @@ func NewValidator(ctx context.Context, vch *config.VirtualContainerHostConfigSpe\n \n \t// Network Connection Check\n \thosts := []string{\n-\t\t\"google.com:80\",\n-\t\t\"docker.io:443\",\n+\t\t\"http://google.com\",\n+\t\t\"https://docker.io\",\n \t}\n+\n \tnwErrors := []error{}\n \n-\tfor _, host := range hosts {\n-\t\tconn, err := net.DialTimeout(\"tcp\", host, time.Minute/2)\n+\t// create a http client with a custom transport. The transport uses the [s/h]proxy defined in vicmachine create if applicable.\n+\tclient := &http.Client{Timeout: 30 * time.Second}\n+\tvchArgs := make(map[string]string)\n+\tfor _, args := range vch.VicMachineCreateOptions {","path":"lib/vicadmin/validate.go","position":26,"original_position":26,"commit_id":"7fefb60c7c5adc2438914f54f5ffe2cf7a7395b0","original_commit_id":"cb1791191e1907d3e98d67e7a405cf7353cd6c51","user":{"login":"morris-jason","id":10388115,"avatar_url":"https://avatars3.githubusercontent.com/u/10388115?v=3","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},"body":"I don't think what I changes should alter guestinfo, just access it. \r\nEven if I changed the Session Client to ignore the http variable there still may be other places that use http.Client in vicadmin or it's vendored dependencies. \r\nBasically, it seems like the proper approach to only include the proxy where needed instead of excluding it in all the place it's not needed.","created_at":"2017-05-25T17:23:32Z","updated_at":"2017-05-25T17:23:32Z","html_url":"https://github.com/vmware/vic/pull/5233#discussion_r118536882","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/5233","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/118536882"},"html":{"href":"https://github.com/vmware/vic/pull/5233#discussion_r118536882"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/5233"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/5233","id":122290651,"html_url":"https://github.com/vmware/vic/pull/5233","diff_url":"https://github.com/vmware/vic/pull/5233.diff","patch_url":"https://github.com/vmware/vic/pull/5233.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/5233","number":5233,"state":"open","locked":false,"title":"4557/proxy vic admin [full ci]","user":{"login":"morris-jason","id":10388115,"avatar_url":"https://avatars3.githubusercontent.com/u/10388115?v=3","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},"body":"Fixes #4557 \r\n\r\n- Removed HTTP[S]_PROXY env var for vicadmin. It was causing govmomi to attempt connections to vSphere over the proxy.\r\n- WAN Checks now go over the proxy if it exists.","created_at":"2017-05-24T18:11:46Z","updated_at":"2017-05-25T17:23:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c25af8f177f1368ddfc34561c71d0fa013d3346","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars0.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/5233/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/5233/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/5233/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/7fefb60c7c5adc2438914f54f5ffe2cf7a7395b0","head":{"label":"morris-jason:4557/proxy-vic-admin","ref":"4557/proxy-vic-admin","sha":"7fefb60c7c5adc2438914f54f5ffe2cf7a7395b0","user":{"login":"morris-jason","id":10388115,"avatar_url":"https://avatars3.githubusercontent.com/u/10388115?v=3","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},"repo":{"id":91376388,"name":"vic","full_name":"morris-jason/vic","owner":{"login":"morris-jason","id":10388115,"avatar_url":"https://avatars3.githubusercontent.com/u/10388115?v=3","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/morris-jason/vic","description":"Integrated containers engine on vSphere","fork":true,"url":"https://api.github.com/repos/morris-jason/vic","forks_url":"https://api.github.com/repos/morris-jason/vic/forks","keys_url":"https://api.github.com/repos/morris-jason/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morris-jason/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morris-jason/vic/teams","hooks_url":"https://api.github.com/repos/morris-jason/vic/hooks","issue_events_url":"https://api.github.com/repos/morris-jason/vic/issues/events{/number}","events_url":"https://api.github.com/repos/morris-jason/vic/events","assignees_url":"https://api.github.com/repos/morris-jason/vic/assignees{/user}","branches_url":"https://api.github.com/repos/morris-jason/vic/branches{/branch}","tags_url":"https://api.github.com/repos/morris-jason/vic/tags","blobs_url":"https://api.github.com/repos/morris-jason/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morris-jason/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morris-jason/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/morris-jason/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morris-jason/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/morris-jason/vic/languages","stargazers_url":"https://api.github.com/repos/morris-jason/vic/stargazers","contributors_url":"https://api.github.com/repos/morris-jason/vic/contributors","subscribers_url":"https://api.github.com/repos/morris-jason/vic/subscribers","subscription_url":"https://api.github.com/repos/morris-jason/vic/subscription","commits_url":"https://api.github.com/repos/morris-jason/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/morris-jason/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/morris-jason/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/morris-jason/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/morris-jason/vic/contents/{+path}","compare_url":"https://api.github.com/repos/morris-jason/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morris-jason/vic/merges","archive_url":"https://api.github.com/repos/morris-jason/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morris-jason/vic/downloads","issues_url":"https://api.github.com/repos/morris-jason/vic/issues{/number}","pulls_url":"https://api.github.com/repos/morris-jason/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/morris-jason/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/morris-jason/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morris-jason/vic/labels{/name}","releases_url":"https://api.github.com/repos/morris-jason/vic/releases{/id}","deployments_url":"https://api.github.com/repos/morris-jason/vic/deployments","created_at":"2017-05-15T19:24:34Z","updated_at":"2017-05-15T19:24:38Z","pushed_at":"2017-05-25T16:15:53Z","git_url":"git://github.com/morris-jason/vic.git","ssh_url":"git@github.com:morris-jason/vic.git","clone_url":"https://github.com/morris-jason/vic.git","svn_url":"https://github.com/morris-jason/vic","homepage":"http://vmware.github.io/vic","size":63143,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"1692fea71ddff1df692ec7c9e074f0944066d692","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2017-05-24T15:34:41Z","pushed_at":"2017-05-25T17:22:29Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"http://vmware.github.io/vic","size":64552,"stargazers_count":239,"watchers_count":239,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":790,"forks":97,"open_issues":790,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/5233"},"html":{"href":"https://github.com/vmware/vic/pull/5233"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/5233"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/5233/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/5233/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/5233/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/7fefb60c7c5adc2438914f54f5ffe2cf7a7395b0"}}}}
{"actor":{"display_login":"morris-jason"}}