{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/15188","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/15188/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/15188/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/15188/events","html_url":"https://github.com/nodejs/node/pull/15188","id":255090937,"number":15188,"title":"http2: use session not socket timeout, tests","user":{"login":"apapirovski","id":20809,"avatar_url":"https://avatars2.githubusercontent.com/u/20809?v=4","gravatar_id":"","url":"https://api.github.com/users/apapirovski","html_url":"https://github.com/apapirovski","followers_url":"https://api.github.com/users/apapirovski/followers","following_url":"https://api.github.com/users/apapirovski/following{/other_user}","gists_url":"https://api.github.com/users/apapirovski/gists{/gist_id}","starred_url":"https://api.github.com/users/apapirovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapirovski/subscriptions","organizations_url":"https://api.github.com/users/apapirovski/orgs","repos_url":"https://api.github.com/users/apapirovski/repos","events_url":"https://api.github.com/users/apapirovski/events{/privacy}","received_events_url":"https://api.github.com/users/apapirovski/received_events","type":"User","site_admin":false},"labels":[{"id":647282877,"url":"https://api.github.com/repos/nodejs/node/labels/http2","name":"http2","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-04T17:09:46Z","updated_at":"2017-09-06T11:52:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/15188","html_url":"https://github.com/nodejs/node/pull/15188","diff_url":"https://github.com/nodejs/node/pull/15188.diff","patch_url":"https://github.com/nodejs/node/pull/15188.patch"},"body":"This fixes https://github.com/nodejs/node/issues/15158. Two changes included:\r\n\r\n- there's no longer a default server socket timeout, it's now replaced by a default session timeout\r\n- `_unrefActive` was being called on the handler rather than the actual session\r\n\r\nMarked as WIP as I think we need to investigate whether socket timeout is necessary anywhere and also because this needs a lot more tests, ideally.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nhttp2, test"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/327459921","html_url":"https://github.com/nodejs/node/pull/15188#issuecomment-327459921","issue_url":"https://api.github.com/repos/nodejs/node/issues/15188","id":327459921,"user":{"login":"apapirovski","id":20809,"avatar_url":"https://avatars2.githubusercontent.com/u/20809?v=4","gravatar_id":"","url":"https://api.github.com/users/apapirovski","html_url":"https://github.com/apapirovski","followers_url":"https://api.github.com/users/apapirovski/followers","following_url":"https://api.github.com/users/apapirovski/following{/other_user}","gists_url":"https://api.github.com/users/apapirovski/gists{/gist_id}","starred_url":"https://api.github.com/users/apapirovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapirovski/subscriptions","organizations_url":"https://api.github.com/users/apapirovski/orgs","repos_url":"https://api.github.com/users/apapirovski/repos","events_url":"https://api.github.com/users/apapirovski/events{/privacy}","received_events_url":"https://api.github.com/users/apapirovski/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T11:52:35Z","updated_at":"2017-09-06T11:52:35Z","author_association":"CONTRIBUTOR","body":"Will test later today but I would be surprised if it doesn't affect performance at least a little bit. For one, `_unrefActive` was being called on something that wasn't a timer and two, the socket timeout was never `_unrefActive` either."}}
{"actor":{"display_login":"apapirovski"}}