{"action":"created","comment":{"url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/comments/124007593","pull_request_review_id":46259101,"id":124007593,"diff_hunk":"@@ -129,24 +132,38 @@\n     end\n end\n \n-% -------------------------------------------------------------------------\n-%                      ___\n-%                1     \\\n-% D(phi0,w) = -------  /__     Hm(w) e^(im(phi0-phi_src))\n-%             2 pi r0  m=-M..M\n-%\n-% see Spors et al. (2011), eq.(4) and (5)\n-%--------------------------------------------------------------------------\n+if strcmp('2.5D',dimension)\n+    % -------------------------------------------------------------------------\n+    %                      ___\n+    %                1     \\\n+    % D(phi0,w) = -------  /__     Hm(w) e^(im(phi0-phi_src))\n+    %             2 pi r0  m=-M..M\n+    %\n+    % see Spors et al. (2011), eq.(4) and (5)\n+    %--------------------------------------------------------------------------\n+    \n+    % apply modal weighting\n+    wm = modal_weighting(order,conf);  % modal weighting function\n+    Hm = bsxfun(@times,Hm,wm);\n+    \n+    % apply phase shift due to source angle\n+    m = 0:order;\n+    dm = bsxfun(@times,Hm,exp(-1i*m*phi_src));\n+    \n+    % Spatial IFFT\n+    dm = [conj(dm(:,end:-1:2)), dm];  % append coefficients for negative m\n+    d = inverse_cht(dm,nls);\n+    d = 1/(2*pi*R)*real(d);\n+\n+elseif strcmp('3D',dimension)\n ","path":"SFS_time_domain/driving_function_imp_nfchoa.m","position":62,"original_position":62,"commit_id":"c3a2dfbc3d88d727b2bfad7bb3b5b8df78eafe8b","original_commit_id":"cc28ecc654797a455de454d5b81de43894ea856b","user":{"login":"hagenw","id":173624,"avatar_url":"https://avatars1.githubusercontent.com/u/173624?v=3","gravatar_id":"","url":"https://api.github.com/users/hagenw","html_url":"https://github.com/hagenw","followers_url":"https://api.github.com/users/hagenw/followers","following_url":"https://api.github.com/users/hagenw/following{/other_user}","gists_url":"https://api.github.com/users/hagenw/gists{/gist_id}","starred_url":"https://api.github.com/users/hagenw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hagenw/subscriptions","organizations_url":"https://api.github.com/users/hagenw/orgs","repos_url":"https://api.github.com/users/hagenw/repos","events_url":"https://api.github.com/users/hagenw/events{/privacy}","received_events_url":"https://api.github.com/users/hagenw/received_events","type":"User","site_admin":false},"body":"Could you add a comment with the actual function and a reference similar to the 2.5D case.","created_at":"2017-06-26T13:24:13Z","updated_at":"2017-06-26T13:35:17Z","html_url":"https://github.com/sfstoolbox/sfs-matlab/pull/149#discussion_r124007593","pull_request_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/comments/124007593"},"html":{"href":"https://github.com/sfstoolbox/sfs-matlab/pull/149#discussion_r124007593"},"pull_request":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149","id":120324492,"html_url":"https://github.com/sfstoolbox/sfs-matlab/pull/149","diff_url":"https://github.com/sfstoolbox/sfs-matlab/pull/149.diff","patch_url":"https://github.com/sfstoolbox/sfs-matlab/pull/149.patch","issue_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/149","number":149,"state":"open","locked":false,"title":"3D time-domain NFCHOA driving function","user":{"login":"fietew","id":7665585,"avatar_url":"https://avatars0.githubusercontent.com/u/7665585?v=3","gravatar_id":"","url":"https://api.github.com/users/fietew","html_url":"https://github.com/fietew","followers_url":"https://api.github.com/users/fietew/followers","following_url":"https://api.github.com/users/fietew/following{/other_user}","gists_url":"https://api.github.com/users/fietew/gists{/gist_id}","starred_url":"https://api.github.com/users/fietew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fietew/subscriptions","organizations_url":"https://api.github.com/users/fietew/orgs","repos_url":"https://api.github.com/users/fietew/repos","events_url":"https://api.github.com/users/fietew/events{/privacy}","received_events_url":"https://api.github.com/users/fietew/received_events","type":"User","site_admin":false},"body":"Follow up to #117: Supports plane waves and point sources\r\n\r\nuse ``test_driving_functions_imp_with_delay`` to test","created_at":"2017-05-12T13:36:00Z","updated_at":"2017-06-26T13:35:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab246be7a6232745d68147336d20d47de233336c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149/commits","review_comments_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149/comments","review_comment_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/149/comments","statuses_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/statuses/c3a2dfbc3d88d727b2bfad7bb3b5b8df78eafe8b","head":{"label":"sfstoolbox:nfchoa_imp_3D","ref":"nfchoa_imp_3D","sha":"c3a2dfbc3d88d727b2bfad7bb3b5b8df78eafe8b","user":{"login":"sfstoolbox","id":2727328,"avatar_url":"https://avatars0.githubusercontent.com/u/2727328?v=3","gravatar_id":"","url":"https://api.github.com/users/sfstoolbox","html_url":"https://github.com/sfstoolbox","followers_url":"https://api.github.com/users/sfstoolbox/followers","following_url":"https://api.github.com/users/sfstoolbox/following{/other_user}","gists_url":"https://api.github.com/users/sfstoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/sfstoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfstoolbox/subscriptions","organizations_url":"https://api.github.com/users/sfstoolbox/orgs","repos_url":"https://api.github.com/users/sfstoolbox/repos","events_url":"https://api.github.com/users/sfstoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/sfstoolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":6603359,"name":"sfs-matlab","full_name":"sfstoolbox/sfs-matlab","owner":{"login":"sfstoolbox","id":2727328,"avatar_url":"https://avatars0.githubusercontent.com/u/2727328?v=3","gravatar_id":"","url":"https://api.github.com/users/sfstoolbox","html_url":"https://github.com/sfstoolbox","followers_url":"https://api.github.com/users/sfstoolbox/followers","following_url":"https://api.github.com/users/sfstoolbox/following{/other_user}","gists_url":"https://api.github.com/users/sfstoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/sfstoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfstoolbox/subscriptions","organizations_url":"https://api.github.com/users/sfstoolbox/orgs","repos_url":"https://api.github.com/users/sfstoolbox/repos","events_url":"https://api.github.com/users/sfstoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/sfstoolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sfstoolbox/sfs-matlab","description":"SFS Toolbox for Matlab/Octave","fork":false,"url":"https://api.github.com/repos/sfstoolbox/sfs-matlab","forks_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/forks","keys_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/teams","hooks_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/hooks","issue_events_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/events{/number}","events_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/events","assignees_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/assignees{/user}","branches_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/branches{/branch}","tags_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/tags","blobs_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/statuses/{sha}","languages_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/languages","stargazers_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/stargazers","contributors_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/contributors","subscribers_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/subscribers","subscription_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/subscription","commits_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/contents/{+path}","compare_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/merges","archive_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/downloads","issues_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues{/number}","pulls_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls{/number}","milestones_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/milestones{/number}","notifications_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/labels{/name}","releases_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/releases{/id}","deployments_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/deployments","created_at":"2012-11-08T21:04:30Z","updated_at":"2017-03-18T03:15:59Z","pushed_at":"2017-06-26T13:35:04Z","git_url":"git://github.com/sfstoolbox/sfs-matlab.git","ssh_url":"git@github.com:sfstoolbox/sfs-matlab.git","clone_url":"https://github.com/sfstoolbox/sfs-matlab.git","svn_url":"https://github.com/sfstoolbox/sfs-matlab","homepage":"http://matlab.sfstoolbox.org","size":9998,"stargazers_count":38,"watchers_count":38,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":28,"forks":10,"open_issues":28,"watchers":38,"default_branch":"master"}},"base":{"label":"sfstoolbox:master","ref":"master","sha":"1b5c02d25668b638907d05ecf0b4f4388f420eb0","user":{"login":"sfstoolbox","id":2727328,"avatar_url":"https://avatars0.githubusercontent.com/u/2727328?v=3","gravatar_id":"","url":"https://api.github.com/users/sfstoolbox","html_url":"https://github.com/sfstoolbox","followers_url":"https://api.github.com/users/sfstoolbox/followers","following_url":"https://api.github.com/users/sfstoolbox/following{/other_user}","gists_url":"https://api.github.com/users/sfstoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/sfstoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfstoolbox/subscriptions","organizations_url":"https://api.github.com/users/sfstoolbox/orgs","repos_url":"https://api.github.com/users/sfstoolbox/repos","events_url":"https://api.github.com/users/sfstoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/sfstoolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":6603359,"name":"sfs-matlab","full_name":"sfstoolbox/sfs-matlab","owner":{"login":"sfstoolbox","id":2727328,"avatar_url":"https://avatars0.githubusercontent.com/u/2727328?v=3","gravatar_id":"","url":"https://api.github.com/users/sfstoolbox","html_url":"https://github.com/sfstoolbox","followers_url":"https://api.github.com/users/sfstoolbox/followers","following_url":"https://api.github.com/users/sfstoolbox/following{/other_user}","gists_url":"https://api.github.com/users/sfstoolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/sfstoolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfstoolbox/subscriptions","organizations_url":"https://api.github.com/users/sfstoolbox/orgs","repos_url":"https://api.github.com/users/sfstoolbox/repos","events_url":"https://api.github.com/users/sfstoolbox/events{/privacy}","received_events_url":"https://api.github.com/users/sfstoolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sfstoolbox/sfs-matlab","description":"SFS Toolbox for Matlab/Octave","fork":false,"url":"https://api.github.com/repos/sfstoolbox/sfs-matlab","forks_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/forks","keys_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/teams","hooks_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/hooks","issue_events_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/events{/number}","events_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/events","assignees_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/assignees{/user}","branches_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/branches{/branch}","tags_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/tags","blobs_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/statuses/{sha}","languages_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/languages","stargazers_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/stargazers","contributors_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/contributors","subscribers_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/subscribers","subscription_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/subscription","commits_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/contents/{+path}","compare_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/merges","archive_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/downloads","issues_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues{/number}","pulls_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls{/number}","milestones_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/milestones{/number}","notifications_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/labels{/name}","releases_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/releases{/id}","deployments_url":"https://api.github.com/repos/sfstoolbox/sfs-matlab/deployments","created_at":"2012-11-08T21:04:30Z","updated_at":"2017-03-18T03:15:59Z","pushed_at":"2017-06-26T13:35:04Z","git_url":"git://github.com/sfstoolbox/sfs-matlab.git","ssh_url":"git@github.com:sfstoolbox/sfs-matlab.git","clone_url":"https://github.com/sfstoolbox/sfs-matlab.git","svn_url":"https://github.com/sfstoolbox/sfs-matlab","homepage":"http://matlab.sfstoolbox.org","size":9998,"stargazers_count":38,"watchers_count":38,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":28,"forks":10,"open_issues":28,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149"},"html":{"href":"https://github.com/sfstoolbox/sfs-matlab/pull/149"},"issue":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/149"},"comments":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/sfstoolbox/sfs-matlab/statuses/c3a2dfbc3d88d727b2bfad7bb3b5b8df78eafe8b"}}}}
{"actor":{"display_login":"hagenw"}}