{"action":"created","issue":{"url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/issues/668","repository_url":"https://api.github.com/repos/LibreHealthIO/LibreEHR","labels_url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/issues/668/labels{/name}","comments_url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/issues/668/comments","events_url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/issues/668/events","html_url":"https://github.com/LibreHealthIO/LibreEHR/issues/668","id":251785314,"number":668,"title":"call_required_libraries is badly implemented (not self documenting)","user":{"login":"tmccormi","id":285835,"avatar_url":"https://avatars3.githubusercontent.com/u/285835?v=4","gravatar_id":"","url":"https://api.github.com/users/tmccormi","html_url":"https://github.com/tmccormi","followers_url":"https://api.github.com/users/tmccormi/followers","following_url":"https://api.github.com/users/tmccormi/following{/other_user}","gists_url":"https://api.github.com/users/tmccormi/gists{/gist_id}","starred_url":"https://api.github.com/users/tmccormi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmccormi/subscriptions","organizations_url":"https://api.github.com/users/tmccormi/orgs","repos_url":"https://api.github.com/users/tmccormi/repos","events_url":"https://api.github.com/users/tmccormi/events{/privacy}","received_events_url":"https://api.github.com/users/tmccormi/received_events","type":"User","site_admin":false},"labels":[{"id":539743307,"url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/labels/Consistency/Code%20Formatting","name":"Consistency/Code Formatting","color":"fbca04","default":false},{"id":500313125,"url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/labels/House%20Keeping","name":"House Keeping","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-08-21T22:13:36Z","updated_at":"2017-09-25T00:30:48Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In my opinion:\r\n  **This is bad:**  call_required_libraries(true,false,false,false);  //impossible to know at a glance what is being included\r\n\r\n  **This better:**  call_required_libraries(bootstrap=true,\r\n                                        fancybox=false,\r\n                                        knockout=false,\r\n                                        datepicker=false);\r\n  \r\n  Or maybe use constants\r\n  add this to header.inc.php\r\n  define (BOOTSTRAP,true);\r\n  define (FANCYBOX,true);\r\n  define (KNOCKOUT,true);\r\n  define (DATEPICKER,true);\r\n  \r\n  Modify the function:\r\n  function call_required_libraries($bootstrap=false,$fancybox=false,$knockout=false,$datepicker=false)\r\n  \r\n  Then use the call like this:\r\n  \r\n call_required_libraries(BOOTSTRAP);\r\n \r\n"},"comment":{"url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/issues/comments/331750822","html_url":"https://github.com/LibreHealthIO/LibreEHR/issues/668#issuecomment-331750822","issue_url":"https://api.github.com/repos/LibreHealthIO/LibreEHR/issues/668","id":331750822,"user":{"login":"teryhill","id":4655366,"avatar_url":"https://avatars1.githubusercontent.com/u/4655366?v=4","gravatar_id":"","url":"https://api.github.com/users/teryhill","html_url":"https://github.com/teryhill","followers_url":"https://api.github.com/users/teryhill/followers","following_url":"https://api.github.com/users/teryhill/following{/other_user}","gists_url":"https://api.github.com/users/teryhill/gists{/gist_id}","starred_url":"https://api.github.com/users/teryhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teryhill/subscriptions","organizations_url":"https://api.github.com/users/teryhill/orgs","repos_url":"https://api.github.com/users/teryhill/repos","events_url":"https://api.github.com/users/teryhill/events{/privacy}","received_events_url":"https://api.github.com/users/teryhill/received_events","type":"User","site_admin":false},"created_at":"2017-09-25T00:30:48Z","updated_at":"2017-09-25T00:30:48Z","author_association":"CONTRIBUTOR","body":"Here here we need all the help we can get."}}
{"actor":{"display_login":"teryhill"}}