{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-llbuild/issues/196","repository_url":"https://api.github.com/repos/apple/swift-llbuild","labels_url":"https://api.github.com/repos/apple/swift-llbuild/issues/196/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-llbuild/issues/196/comments","events_url":"https://api.github.com/repos/apple/swift-llbuild/issues/196/events","html_url":"https://github.com/apple/swift-llbuild/pull/196","id":271703535,"number":196,"title":"[BuildSystem] Don't propagate cancel state through phony commands.","user":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars3.githubusercontent.com/u/106625?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-07T04:05:14Z","updated_at":"2017-11-07T04:05:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apple/swift-llbuild/pulls/196","html_url":"https://github.com/apple/swift-llbuild/pull/196","diff_url":"https://github.com/apple/swift-llbuild/pull/196.diff","patch_url":"https://github.com/apple/swift-llbuild/pull/196.patch"},"body":" - When using phony commands to enforce ordering constraints, the cancelled\r\n   state would incorrectly propagate through the phony command, thus causing\r\n   unnecessary rebuilds of all downstream tasks. Instead, we\r\n\r\n - A more fundamental solution to this problem will be to adopt support for\r\n   engine cancellation, and to ultimately allow individual commands to fail\r\n   without reporting a result value (and then triggering engine termination).\r\n\r\n - <rdar://problem/35319783> Unnecessary rebuilds after an error"},"comment":{"url":"https://api.github.com/repos/apple/swift-llbuild/issues/comments/342369637","html_url":"https://github.com/apple/swift-llbuild/pull/196#issuecomment-342369637","issue_url":"https://api.github.com/repos/apple/swift-llbuild/issues/196","id":342369637,"user":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars3.githubusercontent.com/u/106625?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T04:05:21Z","updated_at":"2017-11-07T04:05:21Z","author_association":"MEMBER","body":"@swift-ci please smoke test"}}
{"actor":{"display_login":"ddunbar"}}