{"action":"opened","number":2169,"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/2169","id":134424075,"html_url":"https://github.com/forkcms/forkcms/pull/2169","diff_url":"https://github.com/forkcms/forkcms/pull/2169.diff","patch_url":"https://github.com/forkcms/forkcms/pull/2169.patch","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/2169","number":2169,"state":"open","locked":false,"title":"Install script fix","user":{"login":"StijnVrolijk","id":442529,"avatar_url":"https://avatars1.githubusercontent.com/u/442529?v=4","gravatar_id":"","url":"https://api.github.com/users/StijnVrolijk","html_url":"https://github.com/StijnVrolijk","followers_url":"https://api.github.com/users/StijnVrolijk/followers","following_url":"https://api.github.com/users/StijnVrolijk/following{/other_user}","gists_url":"https://api.github.com/users/StijnVrolijk/gists{/gist_id}","starred_url":"https://api.github.com/users/StijnVrolijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StijnVrolijk/subscriptions","organizations_url":"https://api.github.com/users/StijnVrolijk/orgs","repos_url":"https://api.github.com/users/StijnVrolijk/repos","events_url":"https://api.github.com/users/StijnVrolijk/events{/privacy}","received_events_url":"https://api.github.com/users/StijnVrolijk/received_events","type":"User","site_admin":false},"body":"When installing Fork through a script (like on the demo) there's a bit of a hitch. \r\n\r\nThe Doctrine connection gets created in `ForkCMS\\Bundle\\InstallerBundle/Service/InstallerConnectionFactory.php` but that relies on the installation data getting created in the `InstallerController`. Since we're not using the controller to install Fork, it's not set so we have to set it manually. It does create a few useless calls when actually using the controller (The controller fetches its data, passes it to the installer and the installer passes it back to the controller) but that shouldn't matter too much.\r\n\r\nI've also removed the `InstallerConnection` since it was used for fixing the `remove_cache` tool which is removed in Fork 5 and it prevented Doctrine from creating an actual connection when installing","created_at":"2017-08-07T12:15:08Z","updated_at":"2017-08-07T12:15:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/forkcms/forkcms/milestones/41","html_url":"https://github.com/forkcms/forkcms/milestone/41","labels_url":"https://api.github.com/repos/forkcms/forkcms/milestones/41/labels","id":2682622,"number":41,"title":"5.0.1","description":null,"creator":{"login":"jeroendesloovere","id":588616,"avatar_url":"https://avatars1.githubusercontent.com/u/588616?v=4","gravatar_id":"","url":"https://api.github.com/users/jeroendesloovere","html_url":"https://github.com/jeroendesloovere","followers_url":"https://api.github.com/users/jeroendesloovere/followers","following_url":"https://api.github.com/users/jeroendesloovere/following{/other_user}","gists_url":"https://api.github.com/users/jeroendesloovere/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroendesloovere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroendesloovere/subscriptions","organizations_url":"https://api.github.com/users/jeroendesloovere/orgs","repos_url":"https://api.github.com/users/jeroendesloovere/repos","events_url":"https://api.github.com/users/jeroendesloovere/events{/privacy}","received_events_url":"https://api.github.com/users/jeroendesloovere/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2017-08-05T07:10:08Z","updated_at":"2017-08-07T12:15:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/forkcms/forkcms/pulls/2169/commits","review_comments_url":"https://api.github.com/repos/forkcms/forkcms/pulls/2169/comments","review_comment_url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/2169/comments","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/6e122369a49463f62637d5185084a57f04039588","head":{"label":"forkcms:install-script-fix","ref":"install-script-fix","sha":"6e122369a49463f62637d5185084a57f04039588","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an easy to use open source CMS using Symfony Components.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/forkcms/forkcms/deployments","created_at":"2010-12-04T18:06:15Z","updated_at":"2017-08-01T08:19:38Z","pushed_at":"2017-08-07T12:09:09Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":65309,"stargazers_count":981,"watchers_count":981,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":39,"forks":246,"open_issues":39,"watchers":981,"default_branch":"master"}},"base":{"label":"forkcms:master","ref":"master","sha":"0264994e4781bca099afbfc9988fc98de6f541d3","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an easy to use open source CMS using Symfony Components.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/forkcms/forkcms/deployments","created_at":"2010-12-04T18:06:15Z","updated_at":"2017-08-01T08:19:38Z","pushed_at":"2017-08-07T12:09:09Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":65309,"stargazers_count":981,"watchers_count":981,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":39,"forks":246,"open_issues":39,"watchers":981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/2169"},"html":{"href":"https://github.com/forkcms/forkcms/pull/2169"},"issue":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/2169"},"comments":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/2169/comments"},"review_comments":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/2169/comments"},"review_comment":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/2169/commits"},"statuses":{"href":"https://api.github.com/repos/forkcms/forkcms/statuses/6e122369a49463f62637d5185084a57f04039588"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":16,"changed_files":3}}
{"actor":{"display_login":"StijnVrolijk"}}