{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/128251742","pull_request_review_id":50912901,"id":128251742,"diff_hunk":"@@ -97,8 +97,10 @@ class NDB_Menu_Filter_Instrument_Manager extends NDB_Menu_Filter\n                 );\n \n                 exec(","path":"modules/instrument_manager/php/NDB_Menu_Filter_instrument_manager.class.inc","position":3,"original_position":3,"commit_id":"1bcc1ae750194d6f21846a63e830d81de8ccd6c8","original_commit_id":"1bcc1ae750194d6f21846a63e830d81de8ccd6c8","user":{"login":"johnsaigle","id":4022790,"avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"body":"Is there a reason that this class uses manual queries at all instead of the `Database` class? Seems like a weird choice.\r\n\r\nThis might be a good opportunity to refactor while we're updating this code (unless somebody knows a reason why it's written this way..)","created_at":"2017-07-19T13:52:07Z","updated_at":"2017-07-19T13:52:14Z","html_url":"https://github.com/aces/Loris/pull/2962#discussion_r128251742","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/2962","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/128251742"},"html":{"href":"https://github.com/aces/Loris/pull/2962#discussion_r128251742"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/2962"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/2962","id":131210599,"html_url":"https://github.com/aces/Loris/pull/2962","diff_url":"https://github.com/aces/Loris/pull/2962.diff","patch_url":"https://github.com/aces/Loris/pull/2962.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/2962","number":2962,"state":"open","locked":false,"title":"Instrument Manager Sourcing SQL (#12748 on Redmine)","user":{"login":"suzanne-lee","id":29237731,"avatar_url":"https://avatars3.githubusercontent.com/u/29237731?v=4","gravatar_id":"","url":"https://api.github.com/users/suzanne-lee","html_url":"https://github.com/suzanne-lee","followers_url":"https://api.github.com/users/suzanne-lee/followers","following_url":"https://api.github.com/users/suzanne-lee/following{/other_user}","gists_url":"https://api.github.com/users/suzanne-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/suzanne-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suzanne-lee/subscriptions","organizations_url":"https://api.github.com/users/suzanne-lee/orgs","repos_url":"https://api.github.com/users/suzanne-lee/repos","events_url":"https://api.github.com/users/suzanne-lee/events{/privacy}","received_events_url":"https://api.github.com/users/suzanne-lee/received_events","type":"User","site_admin":false},"body":"When installing an instrument from the instrument manager, the linst file was put in instruments, the SQL script was created in tables_sql, but the SQL script needed to be run manually. \r\n\r\nThis pull request allows the SQL script to be run automatically. \r\n","created_at":"2017-07-18T23:48:58Z","updated_at":"2017-07-19T13:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39d1861560eb74ea91993e2a0a3ea9b8847e7744","assignee":null,"assignees":[],"requested_reviewers":[{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aces/Loris/milestones/14","html_url":"https://github.com/aces/Loris/milestone/14","labels_url":"https://api.github.com/repos/aces/Loris/milestones/14/labels","id":2062428,"number":14,"title":"17.1","description":"","creator":{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":333,"state":"open","created_at":"2016-10-11T14:50:29Z","updated_at":"2017-07-18T23:48:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aces/Loris/pulls/2962/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/2962/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/2962/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/1bcc1ae750194d6f21846a63e830d81de8ccd6c8","head":{"label":"suzanne-lee:fixing-instrument-manager","ref":"fixing-instrument-manager","sha":"1bcc1ae750194d6f21846a63e830d81de8ccd6c8","user":{"login":"suzanne-lee","id":29237731,"avatar_url":"https://avatars3.githubusercontent.com/u/29237731?v=4","gravatar_id":"","url":"https://api.github.com/users/suzanne-lee","html_url":"https://github.com/suzanne-lee","followers_url":"https://api.github.com/users/suzanne-lee/followers","following_url":"https://api.github.com/users/suzanne-lee/following{/other_user}","gists_url":"https://api.github.com/users/suzanne-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/suzanne-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suzanne-lee/subscriptions","organizations_url":"https://api.github.com/users/suzanne-lee/orgs","repos_url":"https://api.github.com/users/suzanne-lee/repos","events_url":"https://api.github.com/users/suzanne-lee/events{/privacy}","received_events_url":"https://api.github.com/users/suzanne-lee/received_events","type":"User","site_admin":false},"repo":{"id":93556430,"name":"Loris","full_name":"suzanne-lee/Loris","owner":{"login":"suzanne-lee","id":29237731,"avatar_url":"https://avatars3.githubusercontent.com/u/29237731?v=4","gravatar_id":"","url":"https://api.github.com/users/suzanne-lee","html_url":"https://github.com/suzanne-lee","followers_url":"https://api.github.com/users/suzanne-lee/followers","following_url":"https://api.github.com/users/suzanne-lee/following{/other_user}","gists_url":"https://api.github.com/users/suzanne-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/suzanne-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suzanne-lee/subscriptions","organizations_url":"https://api.github.com/users/suzanne-lee/orgs","repos_url":"https://api.github.com/users/suzanne-lee/repos","events_url":"https://api.github.com/users/suzanne-lee/events{/privacy}","received_events_url":"https://api.github.com/users/suzanne-lee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suzanne-lee/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/suzanne-lee/Loris","forks_url":"https://api.github.com/repos/suzanne-lee/Loris/forks","keys_url":"https://api.github.com/repos/suzanne-lee/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suzanne-lee/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suzanne-lee/Loris/teams","hooks_url":"https://api.github.com/repos/suzanne-lee/Loris/hooks","issue_events_url":"https://api.github.com/repos/suzanne-lee/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/suzanne-lee/Loris/events","assignees_url":"https://api.github.com/repos/suzanne-lee/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/suzanne-lee/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/suzanne-lee/Loris/tags","blobs_url":"https://api.github.com/repos/suzanne-lee/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suzanne-lee/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suzanne-lee/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/suzanne-lee/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suzanne-lee/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/suzanne-lee/Loris/languages","stargazers_url":"https://api.github.com/repos/suzanne-lee/Loris/stargazers","contributors_url":"https://api.github.com/repos/suzanne-lee/Loris/contributors","subscribers_url":"https://api.github.com/repos/suzanne-lee/Loris/subscribers","subscription_url":"https://api.github.com/repos/suzanne-lee/Loris/subscription","commits_url":"https://api.github.com/repos/suzanne-lee/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/suzanne-lee/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/suzanne-lee/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/suzanne-lee/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/suzanne-lee/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/suzanne-lee/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suzanne-lee/Loris/merges","archive_url":"https://api.github.com/repos/suzanne-lee/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suzanne-lee/Loris/downloads","issues_url":"https://api.github.com/repos/suzanne-lee/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/suzanne-lee/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/suzanne-lee/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/suzanne-lee/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suzanne-lee/Loris/labels{/name}","releases_url":"https://api.github.com/repos/suzanne-lee/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/suzanne-lee/Loris/deployments","created_at":"2017-06-06T19:34:41Z","updated_at":"2017-06-06T19:34:45Z","pushed_at":"2017-07-18T23:41:01Z","git_url":"git://github.com/suzanne-lee/Loris.git","ssh_url":"git@github.com:suzanne-lee/Loris.git","clone_url":"https://github.com/suzanne-lee/Loris.git","svn_url":"https://github.com/suzanne-lee/Loris","homepage":"","size":70128,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"17.1-dev"}},"base":{"label":"aces:17.1-dev","ref":"17.1-dev","sha":"73ff1d97f38bc459f0837db4e1035789c4f03b16","user":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2017-07-06T23:20:19Z","pushed_at":"2017-07-18T23:48:59Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":70173,"stargazers_count":50,"watchers_count":50,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":73,"forks":78,"open_issues":73,"watchers":50,"default_branch":"17.1-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/2962"},"html":{"href":"https://github.com/aces/Loris/pull/2962"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/2962"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/2962/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/2962/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/2962/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/1bcc1ae750194d6f21846a63e830d81de8ccd6c8"}}}}
{"actor":{"display_login":"johnsaigle"}}