{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7458","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7458/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7458/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7458/events","html_url":"https://github.com/RobotLocomotion/drake/pull/7458","id":273093166,"number":7458,"title":"Collect our own list of transitive headers","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"EricCousineau-TRI","id":26719449,"avatar_url":"https://avatars1.githubusercontent.com/u/26719449?v=4","gravatar_id":"","url":"https://api.github.com/users/EricCousineau-TRI","html_url":"https://github.com/EricCousineau-TRI","followers_url":"https://api.github.com/users/EricCousineau-TRI/followers","following_url":"https://api.github.com/users/EricCousineau-TRI/following{/other_user}","gists_url":"https://api.github.com/users/EricCousineau-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/EricCousineau-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricCousineau-TRI/subscriptions","organizations_url":"https://api.github.com/users/EricCousineau-TRI/orgs","repos_url":"https://api.github.com/users/EricCousineau-TRI/repos","events_url":"https://api.github.com/users/EricCousineau-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/EricCousineau-TRI/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamiesnape","id":3630149,"avatar_url":"https://avatars3.githubusercontent.com/u/3630149?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiesnape","html_url":"https://github.com/jamiesnape","followers_url":"https://api.github.com/users/jamiesnape/followers","following_url":"https://api.github.com/users/jamiesnape/following{/other_user}","gists_url":"https://api.github.com/users/jamiesnape/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesnape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesnape/subscriptions","organizations_url":"https://api.github.com/users/jamiesnape/orgs","repos_url":"https://api.github.com/users/jamiesnape/repos","events_url":"https://api.github.com/users/jamiesnape/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesnape/received_events","type":"User","site_admin":false},{"login":"EricCousineau-TRI","id":26719449,"avatar_url":"https://avatars1.githubusercontent.com/u/26719449?v=4","gravatar_id":"","url":"https://api.github.com/users/EricCousineau-TRI","html_url":"https://github.com/EricCousineau-TRI","followers_url":"https://api.github.com/users/EricCousineau-TRI/followers","following_url":"https://api.github.com/users/EricCousineau-TRI/following{/other_user}","gists_url":"https://api.github.com/users/EricCousineau-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/EricCousineau-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricCousineau-TRI/subscriptions","organizations_url":"https://api.github.com/users/EricCousineau-TRI/orgs","repos_url":"https://api.github.com/users/EricCousineau-TRI/repos","events_url":"https://api.github.com/users/EricCousineau-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/EricCousineau-TRI/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-11-10T23:55:52Z","updated_at":"2017-11-13T17:59:48Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/7458","html_url":"https://github.com/RobotLocomotion/drake/pull/7458","diff_url":"https://github.com/RobotLocomotion/drake/pull/7458.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/7458.patch"},"body":"Relates #6996.\r\n\r\nUse our own list instead of the built-in `cc` provider so that we can adjust and filter what is going to be installed, versus everything that is required to compile.  This lets us move the current yaml and vtk exclusions to their point of declaration.\r\n\r\nThis mechanism will also become important for #6996, where we have to be very careful about include paths while compiling pydrake `*.so`s.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/7458)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/344003902","html_url":"https://github.com/RobotLocomotion/drake/pull/7458#issuecomment-344003902","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7458","id":344003902,"user":{"login":"EricCousineau-TRI","id":26719449,"avatar_url":"https://avatars1.githubusercontent.com/u/26719449?v=4","gravatar_id":"","url":"https://api.github.com/users/EricCousineau-TRI","html_url":"https://github.com/EricCousineau-TRI","followers_url":"https://api.github.com/users/EricCousineau-TRI/followers","following_url":"https://api.github.com/users/EricCousineau-TRI/following{/other_user}","gists_url":"https://api.github.com/users/EricCousineau-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/EricCousineau-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricCousineau-TRI/subscriptions","organizations_url":"https://api.github.com/users/EricCousineau-TRI/orgs","repos_url":"https://api.github.com/users/EricCousineau-TRI/repos","events_url":"https://api.github.com/users/EricCousineau-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/EricCousineau-TRI/received_events","type":"User","site_admin":false},"created_at":"2017-11-13T17:59:48Z","updated_at":"2017-11-13T17:59:48Z","author_association":"CONTRIBUTOR","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>, with minor remaining comments. Thanks!\n\n---\n\nReviewed 1 of 1 files at r3.\nReview status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[tools/skylark/drake_cc.bzl, line 133 at r2](https://reviewable.io:443/reviews/robotlocomotion/drake/7458#-Kyq7NfpRzBwZkLKb7Hp:-KyqW7iobYXkf3-v-rUI:brm25jh) ([raw file](https://github.com/robotlocomotion/drake/blob/da095d7f425d15589c425a1bc5045ce198e15ce5/tools/skylark/drake_cc.bzl#L133)):*\n<details><summary><i>Previously, jwnimmer-tri (Jeremy Nimmer) wrote…</i></summary><blockquote>\n\nOK Using `select()` on sources is used ~10 times in the code, mostly in `//drake/solvers` were we use `foo_solver.cc` vs `no_foo.cc`.  I think to get a useful interlock here, we'd need to add `srcs_select_noheaders` arg to drake_cc_library, and change solvers (etc.) to use that.  My intuition is to leave it alone, but if you prefer, I am happy to try that.\n</blockquote></details>\n\nI would prefer there be some sort of indication that behavior is not going to change according to `--config` options, but I'm fine with that being deferred to a later point.\nCould this be promoted to a `TODO` in that case?\n\n---\n\n*[tools/skylark/drake_cc.bzl, line 251 at r2](https://reviewable.io:443/reviews/robotlocomotion/drake/7458#-KyqIigJzi2ZkmRNFN5B:-KyqVPY1RoE_Q8xiMzAj:b-59fzrb) ([raw file](https://github.com/robotlocomotion/drake/blob/da095d7f425d15589c425a1bc5045ce198e15ce5/tools/skylark/drake_cc.bzl#L251)):*\n> There is install_hdrs_exclude to blacklist certain headers. I'm not sure what use case that doesn't cover?\n\nIt was related to the points below (e.g. if I make a non-Drake `cc_library` or what not and don't want to try and trudge through generating the correct glue / \"butter\" rules), but given that I have no concrete use cases / workflows that this needs, I'll go ahead and resolve my discussion.\n\n>  It might come in handy for Drake-using code to have some test stubs or mocks available in the same way that Drake does. What's the thought process behind this request?\n\nThe thought process was that Bazel is for development and `install` is for deployment of production `drake`, but I realize that is relatively narrowly scoped; that's a good point!\n\n---\n\n*[tools/skylark/drake_cc.bzl, line 255 at r2](https://reviewable.io:443/reviews/robotlocomotion/drake/7458#-Kyq8bsciT4i7bw-j47h:-KyqVDJeMUoK6V3Ov954:b-y5euvc) ([raw file](https://github.com/robotlocomotion/drake/blob/da095d7f425d15589c425a1bc5045ce198e15ce5/tools/skylark/drake_cc.bzl#L255)):*\n> Or at least, that's how I see it now. If we come up with some different story, we could update the macro to become more flexible once we know what that is.\n\nOK That sounds good! (and much simpler)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/7458#-:-KyqXCeZBPtQIwEkWARV:b-rnv394)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"EricCousineau-TRI"}}