{"action":"opened","number":61,"pull_request":{"url":"https://api.github.com/repos/esa/pagmo2/pulls/61","id":113817110,"html_url":"https://github.com/esa/pagmo2/pull/61","diff_url":"https://github.com/esa/pagmo2/pull/61.diff","patch_url":"https://github.com/esa/pagmo2/pull/61.patch","issue_url":"https://api.github.com/repos/esa/pagmo2/issues/61","number":61,"state":"open","locked":false,"title":"Problem iteration","user":{"login":"bluescarni","id":623038,"avatar_url":"https://avatars1.githubusercontent.com/u/623038?v=3","gravatar_id":"","url":"https://api.github.com/users/bluescarni","html_url":"https://github.com/bluescarni","followers_url":"https://api.github.com/users/bluescarni/followers","following_url":"https://api.github.com/users/bluescarni/following{/other_user}","gists_url":"https://api.github.com/users/bluescarni/gists{/gist_id}","starred_url":"https://api.github.com/users/bluescarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluescarni/subscriptions","organizations_url":"https://api.github.com/users/bluescarni/orgs","repos_url":"https://api.github.com/users/bluescarni/repos","events_url":"https://api.github.com/users/bluescarni/events{/privacy}","received_events_url":"https://api.github.com/users/bluescarni/received_events","type":"User","site_admin":false},"body":"Some work on the problem class from initial experience on nlopt integration. I'll try to describe the 3 commits here.\r\n\r\nThe first bit is easy: remove ``safe_cast`` in favour of ``boost::numeric_cast``, since we now depend on Boost anyway. Code removed, life is good.\r\n\r\nThe second bit implements some additional checking on the return values of ``gradient_sparsity()`` and ``hessians_sparsity()``. Specifically, we now check also that the returned value's dimension(s) is consistent with the dimension(s) recorded as problem members during problem construction. This was prompted by the realisation that, with an UDP which is badly behaved enough, we can trigger out-of-bounds memory accesses when mapping a sparse gradient to a dense one. This is because, for instance ``gradient()`` checks that the returned value is consistent with ``m_gs_dim`` but ``gradient_sparsity()`` previously didn't (so potentially the problem previously could return a gradient sparsity pattern inconsistent with the size of the sparse gradient vector). Same for hessians.\r\n\r\nThe third bit enforces that all sparsity patterns need to be sorted lexicographically. This is what we were always doing anyway (no tests had to be altered), and in my opinion it makes it easier to reason about and handle the sparsity information. It is also consistent with many standard formats for storing sparse data.\r\n\r\n","created_at":"2017-04-02T12:53:18Z","updated_at":"2017-04-02T12:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/esa/pagmo2/pulls/61/commits","review_comments_url":"https://api.github.com/repos/esa/pagmo2/pulls/61/comments","review_comment_url":"https://api.github.com/repos/esa/pagmo2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esa/pagmo2/issues/61/comments","statuses_url":"https://api.github.com/repos/esa/pagmo2/statuses/57667e6c36ddaecf38e8359e492877fcd082f91f","head":{"label":"bluescarni:problem_iteration","ref":"problem_iteration","sha":"57667e6c36ddaecf38e8359e492877fcd082f91f","user":{"login":"bluescarni","id":623038,"avatar_url":"https://avatars1.githubusercontent.com/u/623038?v=3","gravatar_id":"","url":"https://api.github.com/users/bluescarni","html_url":"https://github.com/bluescarni","followers_url":"https://api.github.com/users/bluescarni/followers","following_url":"https://api.github.com/users/bluescarni/following{/other_user}","gists_url":"https://api.github.com/users/bluescarni/gists{/gist_id}","starred_url":"https://api.github.com/users/bluescarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluescarni/subscriptions","organizations_url":"https://api.github.com/users/bluescarni/orgs","repos_url":"https://api.github.com/users/bluescarni/repos","events_url":"https://api.github.com/users/bluescarni/events{/privacy}","received_events_url":"https://api.github.com/users/bluescarni/received_events","type":"User","site_admin":false},"repo":{"id":79350804,"name":"pagmo2","full_name":"bluescarni/pagmo2","owner":{"login":"bluescarni","id":623038,"avatar_url":"https://avatars1.githubusercontent.com/u/623038?v=3","gravatar_id":"","url":"https://api.github.com/users/bluescarni","html_url":"https://github.com/bluescarni","followers_url":"https://api.github.com/users/bluescarni/followers","following_url":"https://api.github.com/users/bluescarni/following{/other_user}","gists_url":"https://api.github.com/users/bluescarni/gists{/gist_id}","starred_url":"https://api.github.com/users/bluescarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluescarni/subscriptions","organizations_url":"https://api.github.com/users/bluescarni/orgs","repos_url":"https://api.github.com/users/bluescarni/repos","events_url":"https://api.github.com/users/bluescarni/events{/privacy}","received_events_url":"https://api.github.com/users/bluescarni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluescarni/pagmo2","description":"A C++ / Python platform to perform parallel computations of optimisation tasks (global and local) via the asynchronous generalized island model.","fork":true,"url":"https://api.github.com/repos/bluescarni/pagmo2","forks_url":"https://api.github.com/repos/bluescarni/pagmo2/forks","keys_url":"https://api.github.com/repos/bluescarni/pagmo2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluescarni/pagmo2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluescarni/pagmo2/teams","hooks_url":"https://api.github.com/repos/bluescarni/pagmo2/hooks","issue_events_url":"https://api.github.com/repos/bluescarni/pagmo2/issues/events{/number}","events_url":"https://api.github.com/repos/bluescarni/pagmo2/events","assignees_url":"https://api.github.com/repos/bluescarni/pagmo2/assignees{/user}","branches_url":"https://api.github.com/repos/bluescarni/pagmo2/branches{/branch}","tags_url":"https://api.github.com/repos/bluescarni/pagmo2/tags","blobs_url":"https://api.github.com/repos/bluescarni/pagmo2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluescarni/pagmo2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluescarni/pagmo2/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluescarni/pagmo2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluescarni/pagmo2/statuses/{sha}","languages_url":"https://api.github.com/repos/bluescarni/pagmo2/languages","stargazers_url":"https://api.github.com/repos/bluescarni/pagmo2/stargazers","contributors_url":"https://api.github.com/repos/bluescarni/pagmo2/contributors","subscribers_url":"https://api.github.com/repos/bluescarni/pagmo2/subscribers","subscription_url":"https://api.github.com/repos/bluescarni/pagmo2/subscription","commits_url":"https://api.github.com/repos/bluescarni/pagmo2/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluescarni/pagmo2/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluescarni/pagmo2/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluescarni/pagmo2/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluescarni/pagmo2/contents/{+path}","compare_url":"https://api.github.com/repos/bluescarni/pagmo2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluescarni/pagmo2/merges","archive_url":"https://api.github.com/repos/bluescarni/pagmo2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluescarni/pagmo2/downloads","issues_url":"https://api.github.com/repos/bluescarni/pagmo2/issues{/number}","pulls_url":"https://api.github.com/repos/bluescarni/pagmo2/pulls{/number}","milestones_url":"https://api.github.com/repos/bluescarni/pagmo2/milestones{/number}","notifications_url":"https://api.github.com/repos/bluescarni/pagmo2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluescarni/pagmo2/labels{/name}","releases_url":"https://api.github.com/repos/bluescarni/pagmo2/releases{/id}","deployments_url":"https://api.github.com/repos/bluescarni/pagmo2/deployments","created_at":"2017-01-18T14:59:55Z","updated_at":"2017-01-18T14:59:57Z","pushed_at":"2017-04-02T12:44:03Z","git_url":"git://github.com/bluescarni/pagmo2.git","ssh_url":"git@github.com:bluescarni/pagmo2.git","clone_url":"https://github.com/bluescarni/pagmo2.git","svn_url":"https://github.com/bluescarni/pagmo2","homepage":null,"size":13625,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"esa:master","ref":"master","sha":"3dda31c0bedd7b361ac7bb9d951dc91eb3eb325c","user":{"login":"esa","id":3287599,"avatar_url":"https://avatars3.githubusercontent.com/u/3287599?v=3","gravatar_id":"","url":"https://api.github.com/users/esa","html_url":"https://github.com/esa","followers_url":"https://api.github.com/users/esa/followers","following_url":"https://api.github.com/users/esa/following{/other_user}","gists_url":"https://api.github.com/users/esa/gists{/gist_id}","starred_url":"https://api.github.com/users/esa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esa/subscriptions","organizations_url":"https://api.github.com/users/esa/orgs","repos_url":"https://api.github.com/users/esa/repos","events_url":"https://api.github.com/users/esa/events{/privacy}","received_events_url":"https://api.github.com/users/esa/received_events","type":"Organization","site_admin":false},"repo":{"id":78372913,"name":"pagmo2","full_name":"esa/pagmo2","owner":{"login":"esa","id":3287599,"avatar_url":"https://avatars3.githubusercontent.com/u/3287599?v=3","gravatar_id":"","url":"https://api.github.com/users/esa","html_url":"https://github.com/esa","followers_url":"https://api.github.com/users/esa/followers","following_url":"https://api.github.com/users/esa/following{/other_user}","gists_url":"https://api.github.com/users/esa/gists{/gist_id}","starred_url":"https://api.github.com/users/esa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esa/subscriptions","organizations_url":"https://api.github.com/users/esa/orgs","repos_url":"https://api.github.com/users/esa/repos","events_url":"https://api.github.com/users/esa/events{/privacy}","received_events_url":"https://api.github.com/users/esa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esa/pagmo2","description":"A C++ / Python platform to perform parallel computations of optimisation tasks (global and local) via the asynchronous generalized island model.","fork":false,"url":"https://api.github.com/repos/esa/pagmo2","forks_url":"https://api.github.com/repos/esa/pagmo2/forks","keys_url":"https://api.github.com/repos/esa/pagmo2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esa/pagmo2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esa/pagmo2/teams","hooks_url":"https://api.github.com/repos/esa/pagmo2/hooks","issue_events_url":"https://api.github.com/repos/esa/pagmo2/issues/events{/number}","events_url":"https://api.github.com/repos/esa/pagmo2/events","assignees_url":"https://api.github.com/repos/esa/pagmo2/assignees{/user}","branches_url":"https://api.github.com/repos/esa/pagmo2/branches{/branch}","tags_url":"https://api.github.com/repos/esa/pagmo2/tags","blobs_url":"https://api.github.com/repos/esa/pagmo2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esa/pagmo2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esa/pagmo2/git/refs{/sha}","trees_url":"https://api.github.com/repos/esa/pagmo2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esa/pagmo2/statuses/{sha}","languages_url":"https://api.github.com/repos/esa/pagmo2/languages","stargazers_url":"https://api.github.com/repos/esa/pagmo2/stargazers","contributors_url":"https://api.github.com/repos/esa/pagmo2/contributors","subscribers_url":"https://api.github.com/repos/esa/pagmo2/subscribers","subscription_url":"https://api.github.com/repos/esa/pagmo2/subscription","commits_url":"https://api.github.com/repos/esa/pagmo2/commits{/sha}","git_commits_url":"https://api.github.com/repos/esa/pagmo2/git/commits{/sha}","comments_url":"https://api.github.com/repos/esa/pagmo2/comments{/number}","issue_comment_url":"https://api.github.com/repos/esa/pagmo2/issues/comments{/number}","contents_url":"https://api.github.com/repos/esa/pagmo2/contents/{+path}","compare_url":"https://api.github.com/repos/esa/pagmo2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esa/pagmo2/merges","archive_url":"https://api.github.com/repos/esa/pagmo2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esa/pagmo2/downloads","issues_url":"https://api.github.com/repos/esa/pagmo2/issues{/number}","pulls_url":"https://api.github.com/repos/esa/pagmo2/pulls{/number}","milestones_url":"https://api.github.com/repos/esa/pagmo2/milestones{/number}","notifications_url":"https://api.github.com/repos/esa/pagmo2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esa/pagmo2/labels{/name}","releases_url":"https://api.github.com/repos/esa/pagmo2/releases{/id}","deployments_url":"https://api.github.com/repos/esa/pagmo2/deployments","created_at":"2017-01-08T21:53:43Z","updated_at":"2017-03-26T08:03:20Z","pushed_at":"2017-03-30T12:33:49Z","git_url":"git://github.com/esa/pagmo2.git","ssh_url":"git@github.com:esa/pagmo2.git","clone_url":"https://github.com/esa/pagmo2.git","svn_url":"https://github.com/esa/pagmo2","homepage":"","size":14670,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esa/pagmo2/pulls/61"},"html":{"href":"https://github.com/esa/pagmo2/pull/61"},"issue":{"href":"https://api.github.com/repos/esa/pagmo2/issues/61"},"comments":{"href":"https://api.github.com/repos/esa/pagmo2/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/esa/pagmo2/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/esa/pagmo2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esa/pagmo2/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/esa/pagmo2/statuses/57667e6c36ddaecf38e8359e492877fcd082f91f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":346,"deletions":109,"changed_files":9}}
{"actor":{"display_login":"bluescarni"}}