{"action":"created","comment":{"url":"https://api.github.com/repos/clearpathrobotics/people/pulls/comments/122485185","pull_request_review_id":44608705,"id":122485185,"diff_hunk":"@@ -0,0 +1,387 @@\n+#include \"leg_detector/leg_detector_lib.h\"\n+\n+ LegDetector::LegDetector(const std::string& model_path) :\n+    mask_count_(0),\n+    feat_count_(0),\n+    next_p_id_(0),\n+    no_observation_timeout_s_(0.5),\n+    max_second_leg_age_s_(2.0),\n+    max_track_jump_m_(1.0),\n+    max_meas_jump_m_(1.0),\n+    leg_pair_separation_m_(1.0),\n+    fixed_frame_(\"odom\"),\n+    kal_p_(4),\n+    kal_q_(0.002),\n+    kal_r_(10),\n+    use_filter_(true),\n+    connected_thresh_(0.06),\n+    min_points_per_group(5),\n+    leg_reliability_limit_(0.7)\n+  {\n+    forest = cv::ml::StatModel::load<cv::ml::RTrees>(model_path);\n+    feat_count_ = forest->getVarCount();\n+    printf(\"Loaded forest with %d features: %s\\n\", feat_count_, model_path.c_str());\n+    feature_id_ = 0;\n+  }\n+\n+\n+  LegDetector::~LegDetector()\n+  {\n+  }\n+\n+  double LegDetector::distance(list<SavedFeature*>::iterator it1,  list<SavedFeature*>::iterator it2)\n+  {\n+    Stamped<Point> one = (*it1)->position_, two = (*it2)->position_;\n+    double dx = one[0] - two[0], dy = one[1] - two[1], dz = one[2] - two[2];\n+    return sqrt(dx * dx + dy * dy + dz * dz);","path":"leg_detector/src/leg_detector_lib.cpp","position":36,"original_position":36,"commit_id":"5d25a5aed6438cc2030efb147c47bd62066a5269","original_commit_id":"5d25a5aed6438cc2030efb147c47bd62066a5269","user":{"login":"efernandez","id":382167,"avatar_url":"https://avatars3.githubusercontent.com/u/382167?v=3","gravatar_id":"","url":"https://api.github.com/users/efernandez","html_url":"https://github.com/efernandez","followers_url":"https://api.github.com/users/efernandez/followers","following_url":"https://api.github.com/users/efernandez/following{/other_user}","gists_url":"https://api.github.com/users/efernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/efernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efernandez/subscriptions","organizations_url":"https://api.github.com/users/efernandez/orgs","repos_url":"https://api.github.com/users/efernandez/repos","events_url":"https://api.github.com/users/efernandez/events{/privacy}","received_events_url":"https://api.github.com/users/efernandez/received_events","type":"User","site_admin":false},"body":"optimization, provide a `distance2` version w/o the `sqrt`","created_at":"2017-06-16T16:47:35Z","updated_at":"2017-06-16T16:59:39Z","html_url":"https://github.com/clearpathrobotics/people/pull/1#discussion_r122485185","pull_request_url":"https://api.github.com/repos/clearpathrobotics/people/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/people/pulls/comments/122485185"},"html":{"href":"https://github.com/clearpathrobotics/people/pull/1#discussion_r122485185"},"pull_request":{"href":"https://api.github.com/repos/clearpathrobotics/people/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/clearpathrobotics/people/pulls/1","id":125670663,"html_url":"https://github.com/clearpathrobotics/people/pull/1","diff_url":"https://github.com/clearpathrobotics/people/pull/1.diff","patch_url":"https://github.com/clearpathrobotics/people/pull/1.patch","issue_url":"https://api.github.com/repos/clearpathrobotics/people/issues/1","number":1,"state":"open","locked":false,"title":"library version of people tracker","user":{"login":"asaini89","id":17413647,"avatar_url":"https://avatars1.githubusercontent.com/u/17413647?v=3","gravatar_id":"","url":"https://api.github.com/users/asaini89","html_url":"https://github.com/asaini89","followers_url":"https://api.github.com/users/asaini89/followers","following_url":"https://api.github.com/users/asaini89/following{/other_user}","gists_url":"https://api.github.com/users/asaini89/gists{/gist_id}","starred_url":"https://api.github.com/users/asaini89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaini89/subscriptions","organizations_url":"https://api.github.com/users/asaini89/orgs","repos_url":"https://api.github.com/users/asaini89/repos","events_url":"https://api.github.com/users/asaini89/events{/privacy}","received_events_url":"https://api.github.com/users/asaini89/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-14T19:08:13Z","updated_at":"2017-06-16T16:59:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e42c330e94d64727fead5d04a8528cb6f061c9c","assignee":{"login":"asaini89","id":17413647,"avatar_url":"https://avatars1.githubusercontent.com/u/17413647?v=3","gravatar_id":"","url":"https://api.github.com/users/asaini89","html_url":"https://github.com/asaini89","followers_url":"https://api.github.com/users/asaini89/followers","following_url":"https://api.github.com/users/asaini89/following{/other_user}","gists_url":"https://api.github.com/users/asaini89/gists{/gist_id}","starred_url":"https://api.github.com/users/asaini89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaini89/subscriptions","organizations_url":"https://api.github.com/users/asaini89/orgs","repos_url":"https://api.github.com/users/asaini89/repos","events_url":"https://api.github.com/users/asaini89/events{/privacy}","received_events_url":"https://api.github.com/users/asaini89/received_events","type":"User","site_admin":false},"assignees":[{"login":"asaini89","id":17413647,"avatar_url":"https://avatars1.githubusercontent.com/u/17413647?v=3","gravatar_id":"","url":"https://api.github.com/users/asaini89","html_url":"https://github.com/asaini89","followers_url":"https://api.github.com/users/asaini89/followers","following_url":"https://api.github.com/users/asaini89/following{/other_user}","gists_url":"https://api.github.com/users/asaini89/gists{/gist_id}","starred_url":"https://api.github.com/users/asaini89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaini89/subscriptions","organizations_url":"https://api.github.com/users/asaini89/orgs","repos_url":"https://api.github.com/users/asaini89/repos","events_url":"https://api.github.com/users/asaini89/events{/privacy}","received_events_url":"https://api.github.com/users/asaini89/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"servos","id":2147442,"avatar_url":"https://avatars3.githubusercontent.com/u/2147442?v=3","gravatar_id":"","url":"https://api.github.com/users/servos","html_url":"https://github.com/servos","followers_url":"https://api.github.com/users/servos/followers","following_url":"https://api.github.com/users/servos/following{/other_user}","gists_url":"https://api.github.com/users/servos/gists{/gist_id}","starred_url":"https://api.github.com/users/servos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servos/subscriptions","organizations_url":"https://api.github.com/users/servos/orgs","repos_url":"https://api.github.com/users/servos/repos","events_url":"https://api.github.com/users/servos/events{/privacy}","received_events_url":"https://api.github.com/users/servos/received_events","type":"User","site_admin":false},{"login":"v-mehta","id":7396943,"avatar_url":"https://avatars1.githubusercontent.com/u/7396943?v=3","gravatar_id":"","url":"https://api.github.com/users/v-mehta","html_url":"https://github.com/v-mehta","followers_url":"https://api.github.com/users/v-mehta/followers","following_url":"https://api.github.com/users/v-mehta/following{/other_user}","gists_url":"https://api.github.com/users/v-mehta/gists{/gist_id}","starred_url":"https://api.github.com/users/v-mehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-mehta/subscriptions","organizations_url":"https://api.github.com/users/v-mehta/orgs","repos_url":"https://api.github.com/users/v-mehta/repos","events_url":"https://api.github.com/users/v-mehta/events{/privacy}","received_events_url":"https://api.github.com/users/v-mehta/received_events","type":"User","site_admin":false},{"login":"afakihcpr","id":13023458,"avatar_url":"https://avatars1.githubusercontent.com/u/13023458?v=3","gravatar_id":"","url":"https://api.github.com/users/afakihcpr","html_url":"https://github.com/afakihcpr","followers_url":"https://api.github.com/users/afakihcpr/followers","following_url":"https://api.github.com/users/afakihcpr/following{/other_user}","gists_url":"https://api.github.com/users/afakihcpr/gists{/gist_id}","starred_url":"https://api.github.com/users/afakihcpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afakihcpr/subscriptions","organizations_url":"https://api.github.com/users/afakihcpr/orgs","repos_url":"https://api.github.com/users/afakihcpr/repos","events_url":"https://api.github.com/users/afakihcpr/events{/privacy}","received_events_url":"https://api.github.com/users/afakihcpr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/clearpathrobotics/people/pulls/1/commits","review_comments_url":"https://api.github.com/repos/clearpathrobotics/people/pulls/1/comments","review_comment_url":"https://api.github.com/repos/clearpathrobotics/people/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearpathrobotics/people/issues/1/comments","statuses_url":"https://api.github.com/repos/clearpathrobotics/people/statuses/5d25a5aed6438cc2030efb147c47bd62066a5269","head":{"label":"clearpathrobotics:people_detector_lib","ref":"people_detector_lib","sha":"5d25a5aed6438cc2030efb147c47bd62066a5269","user":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars1.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":94362131,"name":"people","full_name":"clearpathrobotics/people","owner":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars1.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearpathrobotics/people","description":null,"fork":true,"url":"https://api.github.com/repos/clearpathrobotics/people","forks_url":"https://api.github.com/repos/clearpathrobotics/people/forks","keys_url":"https://api.github.com/repos/clearpathrobotics/people/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearpathrobotics/people/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearpathrobotics/people/teams","hooks_url":"https://api.github.com/repos/clearpathrobotics/people/hooks","issue_events_url":"https://api.github.com/repos/clearpathrobotics/people/issues/events{/number}","events_url":"https://api.github.com/repos/clearpathrobotics/people/events","assignees_url":"https://api.github.com/repos/clearpathrobotics/people/assignees{/user}","branches_url":"https://api.github.com/repos/clearpathrobotics/people/branches{/branch}","tags_url":"https://api.github.com/repos/clearpathrobotics/people/tags","blobs_url":"https://api.github.com/repos/clearpathrobotics/people/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearpathrobotics/people/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearpathrobotics/people/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearpathrobotics/people/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearpathrobotics/people/statuses/{sha}","languages_url":"https://api.github.com/repos/clearpathrobotics/people/languages","stargazers_url":"https://api.github.com/repos/clearpathrobotics/people/stargazers","contributors_url":"https://api.github.com/repos/clearpathrobotics/people/contributors","subscribers_url":"https://api.github.com/repos/clearpathrobotics/people/subscribers","subscription_url":"https://api.github.com/repos/clearpathrobotics/people/subscription","commits_url":"https://api.github.com/repos/clearpathrobotics/people/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearpathrobotics/people/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearpathrobotics/people/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearpathrobotics/people/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearpathrobotics/people/contents/{+path}","compare_url":"https://api.github.com/repos/clearpathrobotics/people/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearpathrobotics/people/merges","archive_url":"https://api.github.com/repos/clearpathrobotics/people/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearpathrobotics/people/downloads","issues_url":"https://api.github.com/repos/clearpathrobotics/people/issues{/number}","pulls_url":"https://api.github.com/repos/clearpathrobotics/people/pulls{/number}","milestones_url":"https://api.github.com/repos/clearpathrobotics/people/milestones{/number}","notifications_url":"https://api.github.com/repos/clearpathrobotics/people/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearpathrobotics/people/labels{/name}","releases_url":"https://api.github.com/repos/clearpathrobotics/people/releases{/id}","deployments_url":"https://api.github.com/repos/clearpathrobotics/people/deployments","created_at":"2017-06-14T18:39:41Z","updated_at":"2017-06-14T18:39:43Z","pushed_at":"2017-06-16T15:38:29Z","git_url":"git://github.com/clearpathrobotics/people.git","ssh_url":"git@github.com:clearpathrobotics/people.git","clone_url":"https://github.com/clearpathrobotics/people.git","svn_url":"https://github.com/clearpathrobotics/people","homepage":null,"size":1414,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"indigo-devel"}},"base":{"label":"clearpathrobotics:indigo-devel","ref":"indigo-devel","sha":"4895a759392f23bfd0cf9ba01b964061426c03eb","user":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars1.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":94362131,"name":"people","full_name":"clearpathrobotics/people","owner":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars1.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearpathrobotics/people","description":null,"fork":true,"url":"https://api.github.com/repos/clearpathrobotics/people","forks_url":"https://api.github.com/repos/clearpathrobotics/people/forks","keys_url":"https://api.github.com/repos/clearpathrobotics/people/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearpathrobotics/people/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearpathrobotics/people/teams","hooks_url":"https://api.github.com/repos/clearpathrobotics/people/hooks","issue_events_url":"https://api.github.com/repos/clearpathrobotics/people/issues/events{/number}","events_url":"https://api.github.com/repos/clearpathrobotics/people/events","assignees_url":"https://api.github.com/repos/clearpathrobotics/people/assignees{/user}","branches_url":"https://api.github.com/repos/clearpathrobotics/people/branches{/branch}","tags_url":"https://api.github.com/repos/clearpathrobotics/people/tags","blobs_url":"https://api.github.com/repos/clearpathrobotics/people/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearpathrobotics/people/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearpathrobotics/people/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearpathrobotics/people/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearpathrobotics/people/statuses/{sha}","languages_url":"https://api.github.com/repos/clearpathrobotics/people/languages","stargazers_url":"https://api.github.com/repos/clearpathrobotics/people/stargazers","contributors_url":"https://api.github.com/repos/clearpathrobotics/people/contributors","subscribers_url":"https://api.github.com/repos/clearpathrobotics/people/subscribers","subscription_url":"https://api.github.com/repos/clearpathrobotics/people/subscription","commits_url":"https://api.github.com/repos/clearpathrobotics/people/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearpathrobotics/people/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearpathrobotics/people/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearpathrobotics/people/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearpathrobotics/people/contents/{+path}","compare_url":"https://api.github.com/repos/clearpathrobotics/people/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearpathrobotics/people/merges","archive_url":"https://api.github.com/repos/clearpathrobotics/people/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearpathrobotics/people/downloads","issues_url":"https://api.github.com/repos/clearpathrobotics/people/issues{/number}","pulls_url":"https://api.github.com/repos/clearpathrobotics/people/pulls{/number}","milestones_url":"https://api.github.com/repos/clearpathrobotics/people/milestones{/number}","notifications_url":"https://api.github.com/repos/clearpathrobotics/people/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearpathrobotics/people/labels{/name}","releases_url":"https://api.github.com/repos/clearpathrobotics/people/releases{/id}","deployments_url":"https://api.github.com/repos/clearpathrobotics/people/deployments","created_at":"2017-06-14T18:39:41Z","updated_at":"2017-06-14T18:39:43Z","pushed_at":"2017-06-16T15:38:29Z","git_url":"git://github.com/clearpathrobotics/people.git","ssh_url":"git@github.com:clearpathrobotics/people.git","clone_url":"https://github.com/clearpathrobotics/people.git","svn_url":"https://github.com/clearpathrobotics/people","homepage":null,"size":1414,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/people/pulls/1"},"html":{"href":"https://github.com/clearpathrobotics/people/pull/1"},"issue":{"href":"https://api.github.com/repos/clearpathrobotics/people/issues/1"},"comments":{"href":"https://api.github.com/repos/clearpathrobotics/people/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/clearpathrobotics/people/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/clearpathrobotics/people/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearpathrobotics/people/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/clearpathrobotics/people/statuses/5d25a5aed6438cc2030efb147c47bd62066a5269"}}}}
{"actor":{"display_login":"efernandez"}}