{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/133502613","pull_request_review_id":56690991,"id":133502613,"diff_hunk":"@@ -0,0 +1,128 @@\n+/**\n+ * Copyright (c) 2014-2017 by the respective copyright holders.\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ */\n+package org.eclipse.smarthome.binding.dmx.handler;\n+\n+import static org.eclipse.smarthome.binding.dmx.DmxBindingConstants.*;\n+\n+import java.util.Collections;\n+import java.util.HashMap;\n+import java.util.Map;\n+import java.util.Set;\n+\n+import org.eclipse.smarthome.binding.dmx.internal.DmxBridgeHandler;\n+import org.eclipse.smarthome.binding.dmx.internal.dmxoverethernet.IpNode;\n+import org.eclipse.smarthome.config.core.Configuration;\n+import org.eclipse.smarthome.core.thing.Bridge;\n+import org.eclipse.smarthome.core.thing.ThingStatus;\n+import org.eclipse.smarthome.core.thing.ThingStatusDetail;\n+import org.eclipse.smarthome.core.thing.ThingTypeUID;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import ola.OlaClient;\n+\n+/**\n+ * The {@link OlaBridgeHandler} is responsible for communication with\n+ * an OLA instance\n+ *\n+ * @author Jan N. Klug - Initial contribution\n+ */\n+\n+public class OlaBridgeHandler extends DmxBridgeHandler {\n+    public final static Set<ThingTypeUID> SUPPORTED_THING_TYPES = Collections.singleton(THING_TYPE_OLA_BRIDGE);\n+    public static final int MIN_UNIVERSE_ID = 0;\n+    public static final int MAX_UNIVERSE_ID = 65535;\n+    public static final int DEFAULT_PORT = 9010;\n+\n+    private final Logger logger = LoggerFactory.getLogger(OlaBridgeHandler.class);\n+    private Map<IpNode, OlaClient> receiverNodes = new HashMap<IpNode, OlaClient>();\n+\n+    public OlaBridgeHandler(Bridge olaBridge) {\n+        super(olaBridge);\n+    }\n+\n+    @Override\n+    protected void openConnection() {\n+        if (this.thing.getStatus().equals(ThingStatus.OFFLINE)) {\n+            for (IpNode receiverNode : receiverNodes.keySet()) {\n+                OlaClient olaClient = receiverNodes.get(receiverNode);\n+                try {\n+                    olaClient.connect(receiverNode.getAddressString(), receiverNode.getPort());\n+                } catch (Exception e) {","path":"extensions/binding/org.eclipse.smarthome.binding.dmx/src/main/java/org/eclipse/smarthome/binding/dmx/handler/OlaBridgeHandler.java","position":56,"original_position":56,"commit_id":"6eb5a0b3af885894ec8945a77cb91a04bf588d2c","original_commit_id":"6eb5a0b3af885894ec8945a77cb91a04bf588d2c","user":{"login":"J-N-K","id":5159123,"avatar_url":"https://avatars0.githubusercontent.com/u/5159123?v=4","gravatar_id":"","url":"https://api.github.com/users/J-N-K","html_url":"https://github.com/J-N-K","followers_url":"https://api.github.com/users/J-N-K/followers","following_url":"https://api.github.com/users/J-N-K/following{/other_user}","gists_url":"https://api.github.com/users/J-N-K/gists{/gist_id}","starred_url":"https://api.github.com/users/J-N-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-N-K/subscriptions","organizations_url":"https://api.github.com/users/J-N-K/orgs","repos_url":"https://api.github.com/users/J-N-K/repos","events_url":"https://api.github.com/users/J-N-K/events{/privacy}","received_events_url":"https://api.github.com/users/J-N-K/received_events","type":"User","site_admin":false},"body":"Unfortunately I don't know that. The JavaDoc only states \"throws Exception\" ","created_at":"2017-08-16T16:38:29Z","updated_at":"2017-08-16T16:38:29Z","html_url":"https://github.com/eclipse/smarthome/pull/2704#discussion_r133502613","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/2704","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/133502613"},"html":{"href":"https://github.com/eclipse/smarthome/pull/2704#discussion_r133502613"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2704"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/2704","id":99386354,"html_url":"https://github.com/eclipse/smarthome/pull/2704","diff_url":"https://github.com/eclipse/smarthome/pull/2704.diff","patch_url":"https://github.com/eclipse/smarthome/pull/2704.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/2704","number":2704,"state":"open","locked":false,"title":"Feature: DMX binding","user":{"login":"J-N-K","id":5159123,"avatar_url":"https://avatars0.githubusercontent.com/u/5159123?v=4","gravatar_id":"","url":"https://api.github.com/users/J-N-K","html_url":"https://github.com/J-N-K","followers_url":"https://api.github.com/users/J-N-K/followers","following_url":"https://api.github.com/users/J-N-K/following{/other_user}","gists_url":"https://api.github.com/users/J-N-K/gists{/gist_id}","starred_url":"https://api.github.com/users/J-N-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-N-K/subscriptions","organizations_url":"https://api.github.com/users/J-N-K/orgs","repos_url":"https://api.github.com/users/J-N-K/repos","events_url":"https://api.github.com/users/J-N-K/events{/privacy}","received_events_url":"https://api.github.com/users/J-N-K/received_events","type":"User","site_admin":false},"body":"See #2703 \r\n\r\nThis binding ist still between alpha- and beta state. It runs fine at my home but needs further real-life testing, This especially true for all Bridges besides the sACN/E1.31 bridge.\r\n\r\nSince these 5k loc will probably take a lot of work to review, I created this PR so the review process can start. After reviewing is finished and all requests incorporated I'll squash and add proper sign-off.\r\n","created_at":"2016-12-26T19:00:49Z","updated_at":"2017-08-16T16:38:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"068aa6a02bbb9e2df8478fe6a17fc1240f4f923c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/2704/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/2704/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/2704/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/6eb5a0b3af885894ec8945a77cb91a04bf588d2c","head":{"label":"J-N-K:feature-dmx-binding","ref":"feature-dmx-binding","sha":"6eb5a0b3af885894ec8945a77cb91a04bf588d2c","user":{"login":"J-N-K","id":5159123,"avatar_url":"https://avatars0.githubusercontent.com/u/5159123?v=4","gravatar_id":"","url":"https://api.github.com/users/J-N-K","html_url":"https://github.com/J-N-K","followers_url":"https://api.github.com/users/J-N-K/followers","following_url":"https://api.github.com/users/J-N-K/following{/other_user}","gists_url":"https://api.github.com/users/J-N-K/gists{/gist_id}","starred_url":"https://api.github.com/users/J-N-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-N-K/subscriptions","organizations_url":"https://api.github.com/users/J-N-K/orgs","repos_url":"https://api.github.com/users/J-N-K/repos","events_url":"https://api.github.com/users/J-N-K/events{/privacy}","received_events_url":"https://api.github.com/users/J-N-K/received_events","type":"User","site_admin":false},"repo":{"id":72736574,"name":"smarthome","full_name":"J-N-K/smarthome","owner":{"login":"J-N-K","id":5159123,"avatar_url":"https://avatars0.githubusercontent.com/u/5159123?v=4","gravatar_id":"","url":"https://api.github.com/users/J-N-K","html_url":"https://github.com/J-N-K","followers_url":"https://api.github.com/users/J-N-K/followers","following_url":"https://api.github.com/users/J-N-K/following{/other_user}","gists_url":"https://api.github.com/users/J-N-K/gists{/gist_id}","starred_url":"https://api.github.com/users/J-N-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-N-K/subscriptions","organizations_url":"https://api.github.com/users/J-N-K/orgs","repos_url":"https://api.github.com/users/J-N-K/repos","events_url":"https://api.github.com/users/J-N-K/events{/privacy}","received_events_url":"https://api.github.com/users/J-N-K/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/J-N-K/smarthome","description":"Eclipse SmartHome™ project","fork":true,"url":"https://api.github.com/repos/J-N-K/smarthome","forks_url":"https://api.github.com/repos/J-N-K/smarthome/forks","keys_url":"https://api.github.com/repos/J-N-K/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/J-N-K/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/J-N-K/smarthome/teams","hooks_url":"https://api.github.com/repos/J-N-K/smarthome/hooks","issue_events_url":"https://api.github.com/repos/J-N-K/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/J-N-K/smarthome/events","assignees_url":"https://api.github.com/repos/J-N-K/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/J-N-K/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/J-N-K/smarthome/tags","blobs_url":"https://api.github.com/repos/J-N-K/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/J-N-K/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/J-N-K/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/J-N-K/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/J-N-K/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/J-N-K/smarthome/languages","stargazers_url":"https://api.github.com/repos/J-N-K/smarthome/stargazers","contributors_url":"https://api.github.com/repos/J-N-K/smarthome/contributors","subscribers_url":"https://api.github.com/repos/J-N-K/smarthome/subscribers","subscription_url":"https://api.github.com/repos/J-N-K/smarthome/subscription","commits_url":"https://api.github.com/repos/J-N-K/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/J-N-K/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/J-N-K/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/J-N-K/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/J-N-K/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/J-N-K/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/J-N-K/smarthome/merges","archive_url":"https://api.github.com/repos/J-N-K/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/J-N-K/smarthome/downloads","issues_url":"https://api.github.com/repos/J-N-K/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/J-N-K/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/J-N-K/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/J-N-K/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/J-N-K/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/J-N-K/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/J-N-K/smarthome/deployments","created_at":"2016-11-03T10:59:13Z","updated_at":"2016-11-03T10:59:20Z","pushed_at":"2017-08-16T15:34:26Z","git_url":"git://github.com/J-N-K/smarthome.git","ssh_url":"git@github.com:J-N-K/smarthome.git","clone_url":"https://github.com/J-N-K/smarthome.git","svn_url":"https://github.com/J-N-K/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":31717,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"74a486dfbf8201a2c48f021fa2ef4353a5ba2ca8","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome™ project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2017-08-16T06:49:35Z","pushed_at":"2017-08-16T16:02:59Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":35990,"stargazers_count":541,"watchers_count":541,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":527,"mirror_url":null,"open_issues_count":330,"forks":527,"open_issues":330,"watchers":541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2704"},"html":{"href":"https://github.com/eclipse/smarthome/pull/2704"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/2704"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/2704/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2704/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2704/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/6eb5a0b3af885894ec8945a77cb91a04bf588d2c"}}}}
{"actor":{"display_login":"J-N-K"}}