{"action":"created","comment":{"url":"https://api.github.com/repos/ni/VireoSDK/pulls/comments/128108126","pull_request_review_id":50757603,"id":128108126,"diff_hunk":"@@ -2437,6 +2437,84 @@ VIREO_FUNCTION_SIGNATURE4(ConvertEnum, StaticType, void, StaticType, void)\n     return _NextInstruction();\n }\n //------------------------------------------------------------\n+// arguments: output cluster, then variable number of inputs that can be null, error cluster or a 1D array of error clusters\n+struct MergeErrorsParamBlock : public VarArgInstruction\n+{\n+    _ParamDef(ErrorCluster, ErrorClusterOut);\n+    _ParamImmediateDef(StaticTypeAndData, ErrorClusterInputs[1]);\n+    NEXT_INSTRUCTION_METHODV()\n+};\n+\n+static Boolean UpdateErrorWhenErrorOrWarningFound(ErrorCluster* errorClusterIn, ErrorCluster* errorClusterOut, Boolean findErrors) {\n+    Boolean errorFound = errorClusterIn->status && findErrors;\n+    Boolean warningFound = !errorClusterIn->status && errorClusterIn->code != 0 && !findErrors;","path":"source/core/GenericFunctions.cpp","position":14,"original_position":14,"commit_id":"d49203b47a27f705b2119a0466ae8f67af9b3c4d","original_commit_id":"d49203b47a27f705b2119a0466ae8f67af9b3c4d","user":{"login":"spathiwa","id":860388,"avatar_url":"https://avatars0.githubusercontent.com/u/860388?v=4","gravatar_id":"","url":"https://api.github.com/users/spathiwa","html_url":"https://github.com/spathiwa","followers_url":"https://api.github.com/users/spathiwa/followers","following_url":"https://api.github.com/users/spathiwa/following{/other_user}","gists_url":"https://api.github.com/users/spathiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/spathiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spathiwa/subscriptions","organizations_url":"https://api.github.com/users/spathiwa/orgs","repos_url":"https://api.github.com/users/spathiwa/repos","events_url":"https://api.github.com/users/spathiwa/events{/privacy}","received_events_url":"https://api.github.com/users/spathiwa/received_events","type":"User","site_admin":false},"body":"Agree with suggestion, but I'd prefer hasError() and hasWarning(), because isError() could be misread as if it's querying the type rather than the data.\r\n","created_at":"2017-07-18T22:03:36Z","updated_at":"2017-07-18T22:03:36Z","html_url":"https://github.com/ni/VireoSDK/pull/302#discussion_r128108126","pull_request_url":"https://api.github.com/repos/ni/VireoSDK/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/comments/128108126"},"html":{"href":"https://github.com/ni/VireoSDK/pull/302#discussion_r128108126"},"pull_request":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/ni/VireoSDK/pulls/302","id":131170586,"html_url":"https://github.com/ni/VireoSDK/pull/302","diff_url":"https://github.com/ni/VireoSDK/pull/302.diff","patch_url":"https://github.com/ni/VireoSDK/pull/302.patch","issue_url":"https://api.github.com/repos/ni/VireoSDK/issues/302","number":302,"state":"open","locked":false,"title":"Merge errors","user":{"login":"cglzaguilar","id":8452083,"avatar_url":"https://avatars3.githubusercontent.com/u/8452083?v=4","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false},"body":"Fix for defect DE12829. Implement Retain First Error Primitive","created_at":"2017-07-18T19:43:24Z","updated_at":"2017-07-18T22:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9d6fb49b83f67bf6fc42a234be4f2524ba9e614","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ni/VireoSDK/pulls/302/commits","review_comments_url":"https://api.github.com/repos/ni/VireoSDK/pulls/302/comments","review_comment_url":"https://api.github.com/repos/ni/VireoSDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ni/VireoSDK/issues/302/comments","statuses_url":"https://api.github.com/repos/ni/VireoSDK/statuses/d49203b47a27f705b2119a0466ae8f67af9b3c4d","head":{"label":"cglzaguilar:MergeErrors","ref":"MergeErrors","sha":"d49203b47a27f705b2119a0466ae8f67af9b3c4d","user":{"login":"cglzaguilar","id":8452083,"avatar_url":"https://avatars3.githubusercontent.com/u/8452083?v=4","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false},"repo":{"id":82117315,"name":"VireoSDK","full_name":"cglzaguilar/VireoSDK","owner":{"login":"cglzaguilar","id":8452083,"avatar_url":"https://avatars3.githubusercontent.com/u/8452083?v=4","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cglzaguilar/VireoSDK","description":"Compact runtime for a subset of LabVIEW","fork":true,"url":"https://api.github.com/repos/cglzaguilar/VireoSDK","forks_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/forks","keys_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/teams","hooks_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/hooks","issue_events_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/issues/events{/number}","events_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/events","assignees_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/assignees{/user}","branches_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/branches{/branch}","tags_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/tags","blobs_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/languages","stargazers_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/stargazers","contributors_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/contributors","subscribers_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/subscribers","subscription_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/subscription","commits_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/contents/{+path}","compare_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/merges","archive_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/downloads","issues_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/issues{/number}","pulls_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/labels{/name}","releases_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/releases{/id}","deployments_url":"https://api.github.com/repos/cglzaguilar/VireoSDK/deployments","created_at":"2017-02-15T23:27:26Z","updated_at":"2017-02-15T23:27:30Z","pushed_at":"2017-07-18T19:42:22Z","git_url":"git://github.com/cglzaguilar/VireoSDK.git","ssh_url":"git@github.com:cglzaguilar/VireoSDK.git","clone_url":"https://github.com/cglzaguilar/VireoSDK.git","svn_url":"https://github.com/cglzaguilar/VireoSDK","homepage":"http://ni.github.io/VireoSDK/","size":24083,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"incoming"}},"base":{"label":"ni:incoming","ref":"incoming","sha":"61309d67d85739a5b8b9543b1feda217fd8dce4c","user":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":18154590,"name":"VireoSDK","full_name":"ni/VireoSDK","owner":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/VireoSDK","description":"Compact runtime for a subset of LabVIEW","fork":false,"url":"https://api.github.com/repos/ni/VireoSDK","forks_url":"https://api.github.com/repos/ni/VireoSDK/forks","keys_url":"https://api.github.com/repos/ni/VireoSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/VireoSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/VireoSDK/teams","hooks_url":"https://api.github.com/repos/ni/VireoSDK/hooks","issue_events_url":"https://api.github.com/repos/ni/VireoSDK/issues/events{/number}","events_url":"https://api.github.com/repos/ni/VireoSDK/events","assignees_url":"https://api.github.com/repos/ni/VireoSDK/assignees{/user}","branches_url":"https://api.github.com/repos/ni/VireoSDK/branches{/branch}","tags_url":"https://api.github.com/repos/ni/VireoSDK/tags","blobs_url":"https://api.github.com/repos/ni/VireoSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/VireoSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/VireoSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/VireoSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/VireoSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/VireoSDK/languages","stargazers_url":"https://api.github.com/repos/ni/VireoSDK/stargazers","contributors_url":"https://api.github.com/repos/ni/VireoSDK/contributors","subscribers_url":"https://api.github.com/repos/ni/VireoSDK/subscribers","subscription_url":"https://api.github.com/repos/ni/VireoSDK/subscription","commits_url":"https://api.github.com/repos/ni/VireoSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/VireoSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/VireoSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/VireoSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/VireoSDK/contents/{+path}","compare_url":"https://api.github.com/repos/ni/VireoSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/VireoSDK/merges","archive_url":"https://api.github.com/repos/ni/VireoSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/VireoSDK/downloads","issues_url":"https://api.github.com/repos/ni/VireoSDK/issues{/number}","pulls_url":"https://api.github.com/repos/ni/VireoSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/VireoSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/VireoSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/VireoSDK/labels{/name}","releases_url":"https://api.github.com/repos/ni/VireoSDK/releases{/id}","deployments_url":"https://api.github.com/repos/ni/VireoSDK/deployments","created_at":"2014-03-26T21:30:22Z","updated_at":"2017-07-16T20:16:07Z","pushed_at":"2017-07-18T19:43:25Z","git_url":"git://github.com/ni/VireoSDK.git","ssh_url":"git@github.com:ni/VireoSDK.git","clone_url":"https://github.com/ni/VireoSDK.git","svn_url":"https://github.com/ni/VireoSDK","homepage":"http://ni.github.io/VireoSDK/","size":24665,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":24,"forks":13,"open_issues":24,"watchers":19,"default_branch":"incoming"}},"_links":{"self":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/302"},"html":{"href":"https://github.com/ni/VireoSDK/pull/302"},"issue":{"href":"https://api.github.com/repos/ni/VireoSDK/issues/302"},"comments":{"href":"https://api.github.com/repos/ni/VireoSDK/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/ni/VireoSDK/statuses/d49203b47a27f705b2119a0466ae8f67af9b3c4d"}}}}
{"actor":{"display_login":"spathiwa"}}