{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/11","id":124133776,"html_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab/pull/11","diff_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab/pull/11.diff","patch_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab/pull/11.patch","issue_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/11","number":11,"state":"closed","locked":false,"title":"Volume computation","user":{"login":"paulmueller","id":2853022,"avatar_url":"https://avatars2.githubusercontent.com/u/2853022?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmueller","html_url":"https://github.com/paulmueller","followers_url":"https://api.github.com/users/paulmueller/followers","following_url":"https://api.github.com/users/paulmueller/following{/other_user}","gists_url":"https://api.github.com/users/paulmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmueller/subscriptions","organizations_url":"https://api.github.com/users/paulmueller/orgs","repos_url":"https://api.github.com/users/paulmueller/repos","events_url":"https://api.github.com/users/paulmueller/events{/privacy}","received_events_url":"https://api.github.com/users/paulmueller/received_events","type":"User","site_admin":false},"body":"@maikherbig I created a new branch for the volume computation and improved readability of the code. Your test runs, however:\r\n\r\n- Does the parameter `pos_x` have any effect on the volume computation? I guess we should remove it?\r\n  I added a test here that runs through perfectly for different values of `pos_x`: https://github.com/ZELLMECHANIK-DRESDEN/dclab/blob/volume_computation/tests/test_volume.py#L118-L139\r\n\r\n- I saw that `get_volume` only works for contours that are counter-clockwise. It would be nice to test that and not rely on the contour being oriented the way it usually is (that might change): https://github.com/ZELLMECHANIK-DRESDEN/dclab/blob/volume_computation/dclab/volume.py#L67-L71","created_at":"2017-06-06T08:21:55Z","updated_at":"2017-06-08T13:04:15Z","closed_at":"2017-06-08T13:04:15Z","merged_at":"2017-06-08T13:04:15Z","merge_commit_sha":"67fa9042eda685da2170390acecfdbedfb0c460e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/11/comments","statuses_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/statuses/3e31b3591044deb90168856c6b8e9bfa733d942b","head":{"label":"ZELLMECHANIK-DRESDEN:volume_computation","ref":"volume_computation","sha":"3e31b3591044deb90168856c6b8e9bfa733d942b","user":{"login":"ZELLMECHANIK-DRESDEN","id":12834101,"avatar_url":"https://avatars2.githubusercontent.com/u/12834101?v=3","gravatar_id":"","url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN","html_url":"https://github.com/ZELLMECHANIK-DRESDEN","followers_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/followers","following_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/following{/other_user}","gists_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/gists{/gist_id}","starred_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/subscriptions","organizations_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/orgs","repos_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/repos","events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/events{/privacy}","received_events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/received_events","type":"Organization","site_admin":false},"repo":{"id":37213902,"name":"dclab","full_name":"ZELLMECHANIK-DRESDEN/dclab","owner":{"login":"ZELLMECHANIK-DRESDEN","id":12834101,"avatar_url":"https://avatars2.githubusercontent.com/u/12834101?v=3","gravatar_id":"","url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN","html_url":"https://github.com/ZELLMECHANIK-DRESDEN","followers_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/followers","following_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/following{/other_user}","gists_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/gists{/gist_id}","starred_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/subscriptions","organizations_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/orgs","repos_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/repos","events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/events{/privacy}","received_events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab","description":"python library for the post-measurement analysis of real-time deformability cytometry (RT-DC) data sets","fork":false,"url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab","forks_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/forks","keys_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/teams","hooks_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/hooks","issue_events_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/events{/number}","events_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/events","assignees_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/assignees{/user}","branches_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/branches{/branch}","tags_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/tags","blobs_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/statuses/{sha}","languages_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/languages","stargazers_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/stargazers","contributors_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/contributors","subscribers_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/subscribers","subscription_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/subscription","commits_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/contents/{+path}","compare_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/merges","archive_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/downloads","issues_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues{/number}","pulls_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls{/number}","milestones_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/milestones{/number}","notifications_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/labels{/name}","releases_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/releases{/id}","deployments_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/deployments","created_at":"2015-06-10T18:09:03Z","updated_at":"2016-01-11T12:46:32Z","pushed_at":"2017-06-08T13:04:15Z","git_url":"git://github.com/ZELLMECHANIK-DRESDEN/dclab.git","ssh_url":"git@github.com:ZELLMECHANIK-DRESDEN/dclab.git","clone_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab.git","svn_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab","homepage":null,"size":662,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"ZELLMECHANIK-DRESDEN:master","ref":"master","sha":"c1854a8e39e02de69787597717f39a14ebb1b649","user":{"login":"ZELLMECHANIK-DRESDEN","id":12834101,"avatar_url":"https://avatars2.githubusercontent.com/u/12834101?v=3","gravatar_id":"","url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN","html_url":"https://github.com/ZELLMECHANIK-DRESDEN","followers_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/followers","following_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/following{/other_user}","gists_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/gists{/gist_id}","starred_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/subscriptions","organizations_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/orgs","repos_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/repos","events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/events{/privacy}","received_events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/received_events","type":"Organization","site_admin":false},"repo":{"id":37213902,"name":"dclab","full_name":"ZELLMECHANIK-DRESDEN/dclab","owner":{"login":"ZELLMECHANIK-DRESDEN","id":12834101,"avatar_url":"https://avatars2.githubusercontent.com/u/12834101?v=3","gravatar_id":"","url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN","html_url":"https://github.com/ZELLMECHANIK-DRESDEN","followers_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/followers","following_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/following{/other_user}","gists_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/gists{/gist_id}","starred_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/subscriptions","organizations_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/orgs","repos_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/repos","events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/events{/privacy}","received_events_url":"https://api.github.com/users/ZELLMECHANIK-DRESDEN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab","description":"python library for the post-measurement analysis of real-time deformability cytometry (RT-DC) data sets","fork":false,"url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab","forks_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/forks","keys_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/teams","hooks_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/hooks","issue_events_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/events{/number}","events_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/events","assignees_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/assignees{/user}","branches_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/branches{/branch}","tags_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/tags","blobs_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/statuses/{sha}","languages_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/languages","stargazers_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/stargazers","contributors_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/contributors","subscribers_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/subscribers","subscription_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/subscription","commits_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/contents/{+path}","compare_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/merges","archive_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/downloads","issues_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues{/number}","pulls_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls{/number}","milestones_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/milestones{/number}","notifications_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/labels{/name}","releases_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/releases{/id}","deployments_url":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/deployments","created_at":"2015-06-10T18:09:03Z","updated_at":"2016-01-11T12:46:32Z","pushed_at":"2017-06-08T13:04:15Z","git_url":"git://github.com/ZELLMECHANIK-DRESDEN/dclab.git","ssh_url":"git@github.com:ZELLMECHANIK-DRESDEN/dclab.git","clone_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab.git","svn_url":"https://github.com/ZELLMECHANIK-DRESDEN/dclab","homepage":null,"size":662,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/11"},"html":{"href":"https://github.com/ZELLMECHANIK-DRESDEN/dclab/pull/11"},"issue":{"href":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/11"},"comments":{"href":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ZELLMECHANIK-DRESDEN/dclab/statuses/3e31b3591044deb90168856c6b8e9bfa733d942b"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"paulmueller","id":2853022,"avatar_url":"https://avatars2.githubusercontent.com/u/2853022?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmueller","html_url":"https://github.com/paulmueller","followers_url":"https://api.github.com/users/paulmueller/followers","following_url":"https://api.github.com/users/paulmueller/following{/other_user}","gists_url":"https://api.github.com/users/paulmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmueller/subscriptions","organizations_url":"https://api.github.com/users/paulmueller/orgs","repos_url":"https://api.github.com/users/paulmueller/repos","events_url":"https://api.github.com/users/paulmueller/events{/privacy}","received_events_url":"https://api.github.com/users/paulmueller/received_events","type":"User","site_admin":false},"comments":15,"review_comments":0,"maintainer_can_modify":false,"commits":14,"additions":471,"deletions":74,"changed_files":15}}
{"actor":{"display_login":"paulmueller"}}