{"action":"created","comment":{"url":"https://api.github.com/repos/google/ExoPlayer/pulls/comments/99812990","pull_request_review_id":20497755,"id":99812990,"diff_hunk":"@@ -1192,7 +1192,7 @@ private static DrmInitData getDrmInitDataFromAtoms(List<Atom.LeafAtom> leafChild\n         if (uuid == null) {\n           Log.w(TAG, \"Skipped pssh atom (failed to extract uuid)\");\n         } else {\n-          schemeDatas.add(new SchemeData(uuid, MimeTypes.VIDEO_MP4, psshData));\n+          schemeDatas.add(new SchemeData(uuid, MimeTypes.CENC, psshData));","path":"library/src/main/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4Extractor.java","position":null,"original_position":5,"commit_id":"f9de196ebc32be3a970c117c0cd38a979ce659da","original_commit_id":"ee61e5df7518f29e5c266f844783f6d7beb6473c","user":{"login":"abouda","id":4817549,"avatar_url":"https://avatars.githubusercontent.com/u/4817549?v=3","gravatar_id":"","url":"https://api.github.com/users/abouda","html_url":"https://github.com/abouda","followers_url":"https://api.github.com/users/abouda/followers","following_url":"https://api.github.com/users/abouda/following{/other_user}","gists_url":"https://api.github.com/users/abouda/gists{/gist_id}","starred_url":"https://api.github.com/users/abouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abouda/subscriptions","organizations_url":"https://api.github.com/users/abouda/orgs","repos_url":"https://api.github.com/users/abouda/repos","events_url":"https://api.github.com/users/abouda/events{/privacy}","received_events_url":"https://api.github.com/users/abouda/received_events","type":"User","site_admin":false},"body":"You should also add this for the case where the pssh is parsed from the manifest. That is in `DashManifestParser#parseContentProtection`.\r\nOtherwise if you follow @ojw28 tip about doing this in the DrmSessionManager, that would cover both cases.","created_at":"2017-02-07T12:42:02Z","updated_at":"2017-02-07T12:42:02Z","html_url":"https://github.com/google/ExoPlayer/pull/2372#discussion_r99812990","pull_request_url":"https://api.github.com/repos/google/ExoPlayer/pulls/2372","_links":{"self":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/comments/99812990"},"html":{"href":"https://github.com/google/ExoPlayer/pull/2372#discussion_r99812990"},"pull_request":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2372"}}},"pull_request":{"url":"https://api.github.com/repos/google/ExoPlayer/pulls/2372","id":103052607,"html_url":"https://github.com/google/ExoPlayer/pull/2372","diff_url":"https://github.com/google/ExoPlayer/pull/2372.diff","patch_url":"https://github.com/google/ExoPlayer/pull/2372.patch","issue_url":"https://api.github.com/repos/google/ExoPlayer/issues/2372","number":2372,"state":"open","locked":false,"title":"Added support for CENC ClearKey","user":{"login":"wasabeef","id":1833474,"avatar_url":"https://avatars.githubusercontent.com/u/1833474?v=3","gravatar_id":"","url":"https://api.github.com/users/wasabeef","html_url":"https://github.com/wasabeef","followers_url":"https://api.github.com/users/wasabeef/followers","following_url":"https://api.github.com/users/wasabeef/following{/other_user}","gists_url":"https://api.github.com/users/wasabeef/gists{/gist_id}","starred_url":"https://api.github.com/users/wasabeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasabeef/subscriptions","organizations_url":"https://api.github.com/users/wasabeef/orgs","repos_url":"https://api.github.com/users/wasabeef/repos","events_url":"https://api.github.com/users/wasabeef/events{/privacy}","received_events_url":"https://api.github.com/users/wasabeef/received_events","type":"User","site_admin":false},"body":"Support CENC ClearKey\r\nhttps://w3c.github.io/encrypted-media/format-registry/initdata/cenc.html\r\n\r\nSee issue https://github.com/google/ExoPlayer/issues/2361","created_at":"2017-01-25T04:15:40Z","updated_at":"2017-02-07T12:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f0de20814d11aed879936f162ac67ffb081916c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/ExoPlayer/pulls/2372/commits","review_comments_url":"https://api.github.com/repos/google/ExoPlayer/pulls/2372/comments","review_comment_url":"https://api.github.com/repos/google/ExoPlayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ExoPlayer/issues/2372/comments","statuses_url":"https://api.github.com/repos/google/ExoPlayer/statuses/f9de196ebc32be3a970c117c0cd38a979ce659da","head":{"label":"wasabeef:dev-v2-cenc-clearkey","ref":"dev-v2-cenc-clearkey","sha":"f9de196ebc32be3a970c117c0cd38a979ce659da","user":{"login":"wasabeef","id":1833474,"avatar_url":"https://avatars.githubusercontent.com/u/1833474?v=3","gravatar_id":"","url":"https://api.github.com/users/wasabeef","html_url":"https://github.com/wasabeef","followers_url":"https://api.github.com/users/wasabeef/followers","following_url":"https://api.github.com/users/wasabeef/following{/other_user}","gists_url":"https://api.github.com/users/wasabeef/gists{/gist_id}","starred_url":"https://api.github.com/users/wasabeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasabeef/subscriptions","organizations_url":"https://api.github.com/users/wasabeef/orgs","repos_url":"https://api.github.com/users/wasabeef/repos","events_url":"https://api.github.com/users/wasabeef/events{/privacy}","received_events_url":"https://api.github.com/users/wasabeef/received_events","type":"User","site_admin":false},"repo":{"id":79901974,"name":"ExoPlayer","full_name":"wasabeef/ExoPlayer","owner":{"login":"wasabeef","id":1833474,"avatar_url":"https://avatars.githubusercontent.com/u/1833474?v=3","gravatar_id":"","url":"https://api.github.com/users/wasabeef","html_url":"https://github.com/wasabeef","followers_url":"https://api.github.com/users/wasabeef/followers","following_url":"https://api.github.com/users/wasabeef/following{/other_user}","gists_url":"https://api.github.com/users/wasabeef/gists{/gist_id}","starred_url":"https://api.github.com/users/wasabeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasabeef/subscriptions","organizations_url":"https://api.github.com/users/wasabeef/orgs","repos_url":"https://api.github.com/users/wasabeef/repos","events_url":"https://api.github.com/users/wasabeef/events{/privacy}","received_events_url":"https://api.github.com/users/wasabeef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wasabeef/ExoPlayer","description":"An extensible media player for Android","fork":true,"url":"https://api.github.com/repos/wasabeef/ExoPlayer","forks_url":"https://api.github.com/repos/wasabeef/ExoPlayer/forks","keys_url":"https://api.github.com/repos/wasabeef/ExoPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wasabeef/ExoPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wasabeef/ExoPlayer/teams","hooks_url":"https://api.github.com/repos/wasabeef/ExoPlayer/hooks","issue_events_url":"https://api.github.com/repos/wasabeef/ExoPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/wasabeef/ExoPlayer/events","assignees_url":"https://api.github.com/repos/wasabeef/ExoPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/wasabeef/ExoPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/wasabeef/ExoPlayer/tags","blobs_url":"https://api.github.com/repos/wasabeef/ExoPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wasabeef/ExoPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wasabeef/ExoPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/wasabeef/ExoPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wasabeef/ExoPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/wasabeef/ExoPlayer/languages","stargazers_url":"https://api.github.com/repos/wasabeef/ExoPlayer/stargazers","contributors_url":"https://api.github.com/repos/wasabeef/ExoPlayer/contributors","subscribers_url":"https://api.github.com/repos/wasabeef/ExoPlayer/subscribers","subscription_url":"https://api.github.com/repos/wasabeef/ExoPlayer/subscription","commits_url":"https://api.github.com/repos/wasabeef/ExoPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/wasabeef/ExoPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/wasabeef/ExoPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/wasabeef/ExoPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/wasabeef/ExoPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/wasabeef/ExoPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wasabeef/ExoPlayer/merges","archive_url":"https://api.github.com/repos/wasabeef/ExoPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wasabeef/ExoPlayer/downloads","issues_url":"https://api.github.com/repos/wasabeef/ExoPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/wasabeef/ExoPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/wasabeef/ExoPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/wasabeef/ExoPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wasabeef/ExoPlayer/labels{/name}","releases_url":"https://api.github.com/repos/wasabeef/ExoPlayer/releases{/id}","deployments_url":"https://api.github.com/repos/wasabeef/ExoPlayer/deployments","created_at":"2017-01-24T10:38:13Z","updated_at":"2017-01-29T12:58:59Z","pushed_at":"2017-01-30T11:12:37Z","git_url":"git://github.com/wasabeef/ExoPlayer.git","ssh_url":"git@github.com:wasabeef/ExoPlayer.git","clone_url":"https://github.com/wasabeef/ExoPlayer.git","svn_url":"https://github.com/wasabeef/ExoPlayer","homepage":"","size":41738,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"release-v2"}},"base":{"label":"google:dev-v2","ref":"dev-v2","sha":"25c18ca1b461870a0aaad15c339a522a38226627","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20818126,"name":"ExoPlayer","full_name":"google/ExoPlayer","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ExoPlayer","description":"An extensible media player for Android","fork":false,"url":"https://api.github.com/repos/google/ExoPlayer","forks_url":"https://api.github.com/repos/google/ExoPlayer/forks","keys_url":"https://api.github.com/repos/google/ExoPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ExoPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ExoPlayer/teams","hooks_url":"https://api.github.com/repos/google/ExoPlayer/hooks","issue_events_url":"https://api.github.com/repos/google/ExoPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/google/ExoPlayer/events","assignees_url":"https://api.github.com/repos/google/ExoPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/google/ExoPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/google/ExoPlayer/tags","blobs_url":"https://api.github.com/repos/google/ExoPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ExoPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ExoPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ExoPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ExoPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ExoPlayer/languages","stargazers_url":"https://api.github.com/repos/google/ExoPlayer/stargazers","contributors_url":"https://api.github.com/repos/google/ExoPlayer/contributors","subscribers_url":"https://api.github.com/repos/google/ExoPlayer/subscribers","subscription_url":"https://api.github.com/repos/google/ExoPlayer/subscription","commits_url":"https://api.github.com/repos/google/ExoPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ExoPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ExoPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ExoPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ExoPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/google/ExoPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ExoPlayer/merges","archive_url":"https://api.github.com/repos/google/ExoPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ExoPlayer/downloads","issues_url":"https://api.github.com/repos/google/ExoPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/google/ExoPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ExoPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ExoPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ExoPlayer/labels{/name}","releases_url":"https://api.github.com/repos/google/ExoPlayer/releases{/id}","deployments_url":"https://api.github.com/repos/google/ExoPlayer/deployments","created_at":"2014-06-13T21:19:18Z","updated_at":"2017-02-07T12:36:40Z","pushed_at":"2017-02-03T18:28:56Z","git_url":"git://github.com/google/ExoPlayer.git","ssh_url":"git@github.com:google/ExoPlayer.git","clone_url":"https://github.com/google/ExoPlayer.git","svn_url":"https://github.com/google/ExoPlayer","homepage":"","size":42177,"stargazers_count":5693,"watchers_count":5693,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2026,"mirror_url":null,"open_issues_count":177,"forks":2026,"open_issues":177,"watchers":5693,"default_branch":"release-v2"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2372"},"html":{"href":"https://github.com/google/ExoPlayer/pull/2372"},"issue":{"href":"https://api.github.com/repos/google/ExoPlayer/issues/2372"},"comments":{"href":"https://api.github.com/repos/google/ExoPlayer/issues/2372/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2372/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2372/commits"},"statuses":{"href":"https://api.github.com/repos/google/ExoPlayer/statuses/f9de196ebc32be3a970c117c0cd38a979ce659da"}}}}
{"actor":{"display_login":"abouda"}}