{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/comments/142756813","pull_request_review_id":67162107,"id":142756813,"diff_hunk":"@@ -0,0 +1,119 @@\n+package google\n+\n+import (\n+\t\"fmt\"\n+\t\"testing\"\n+\n+\t\"github.com/hashicorp/terraform/helper/acctest\"\n+\t\"github.com/hashicorp/terraform/helper/resource\"\n+\t\"github.com/hashicorp/terraform/terraform\"\n+)\n+\n+func TestAccComputeTargeTcpProxy_basic(t *testing.T) {\n+\ttarget := fmt.Sprintf(\"ttcp-test-%s\", acctest.RandString(10))\n+\tbackend := fmt.Sprintf(\"ttcp-test-%s\", acctest.RandString(10))\n+\thc := fmt.Sprintf(\"ttcp-test-%s\", acctest.RandString(10))\n+\n+\tresource.Test(t, resource.TestCase{\n+\t\tPreCheck:     func() { testAccPreCheck(t) },\n+\t\tProviders:    testAccProviders,\n+\t\tCheckDestroy: testAccCheckComputeTargetTcpProxyDestroy,\n+\t\tSteps: []resource.TestStep{\n+\t\t\tresource.TestStep{\n+\t\t\t\tConfig: testAccComputeTargetTcpProxy_basic1(target, backend, hc),\n+\t\t\t\tCheck: resource.ComposeTestCheckFunc(\n+\t\t\t\t\ttestAccCheckComputeTargetTcpProxyExists(\n+\t\t\t\t\t\t\"google_compute_target_tcp_proxy.foobar\"),\n+\t\t\t\t),\n+\t\t\t},\n+\t\t},\n+\t})\n+}\n+\n+func TestAccComputeTargetTcpProxy_update(t *testing.T) {\n+\ttarget := fmt.Sprintf(\"ttcp-test-%s\", acctest.RandString(10))\n+\tbackend := fmt.Sprintf(\"ttcp-test-%s\", acctest.RandString(10))\n+\thc := fmt.Sprintf(\"ttcp-test-%s\", acctest.RandString(10))\n+\n+\tresource.Test(t, resource.TestCase{\n+\t\tPreCheck:     func() { testAccPreCheck(t) },\n+\t\tProviders:    testAccProviders,\n+\t\tCheckDestroy: testAccCheckComputeTargetTcpProxyDestroy,\n+\t\tSteps: []resource.TestStep{\n+\t\t\tresource.TestStep{","path":"google/resource_compute_target_tcp_proxy_test.go","position":22,"original_position":43,"commit_id":"cc6eaefc952c2f6b05bc2ce3d16557c64dec09c0","original_commit_id":"cc6eaefc952c2f6b05bc2ce3d16557c64dec09c0","user":{"login":"rosbo","id":1190441,"avatar_url":"https://avatars3.githubusercontent.com/u/1190441?v=4","gravatar_id":"","url":"https://api.github.com/users/rosbo","html_url":"https://github.com/rosbo","followers_url":"https://api.github.com/users/rosbo/followers","following_url":"https://api.github.com/users/rosbo/following{/other_user}","gists_url":"https://api.github.com/users/rosbo/gists{/gist_id}","starred_url":"https://api.github.com/users/rosbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosbo/subscriptions","organizations_url":"https://api.github.com/users/rosbo/orgs","repos_url":"https://api.github.com/users/rosbo/repos","events_url":"https://api.github.com/users/rosbo/events{/privacy}","received_events_url":"https://api.github.com/users/rosbo/received_events","type":"User","site_admin":false},"body":"How is this testing the update feature? You need at least two `TestStep`. Make sure to test the update with the proxyHeader field (only updateable field) otherwise it will do a Delete/Create operation which won't test the update method.","created_at":"2017-10-04T18:37:23Z","updated_at":"2017-10-04T18:40:19Z","html_url":"https://github.com/terraform-providers/terraform-provider-google/pull/528#discussion_r142756813","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/comments/142756813"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-google/pull/528#discussion_r142756813"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528","id":144732104,"html_url":"https://github.com/terraform-providers/terraform-provider-google/pull/528","diff_url":"https://github.com/terraform-providers/terraform-provider-google/pull/528.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-google/pull/528.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/528","number":528,"state":"open","locked":false,"title":"Add support for target_tcp_proxy","user":{"login":"enxebre","id":1230698,"avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"body":"Fixes #363 \r\n\r\nIntroduces support google_compute_target_tcp_proxy","created_at":"2017-10-04T17:41:32Z","updated_at":"2017-10-04T18:40:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd6fd2e1e00f28c3988f85b94ade6ca533d3496c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/528/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/statuses/cc6eaefc952c2f6b05bc2ce3d16557c64dec09c0","head":{"label":"enxebre:target-tcp-proxy","ref":"target-tcp-proxy","sha":"cc6eaefc952c2f6b05bc2ce3d16557c64dec09c0","user":{"login":"enxebre","id":1230698,"avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"repo":{"id":105757176,"name":"terraform-provider-google","full_name":"enxebre/terraform-provider-google","owner":{"login":"enxebre","id":1230698,"avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enxebre/terraform-provider-google","description":"Terraform google provider","fork":true,"url":"https://api.github.com/repos/enxebre/terraform-provider-google","forks_url":"https://api.github.com/repos/enxebre/terraform-provider-google/forks","keys_url":"https://api.github.com/repos/enxebre/terraform-provider-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enxebre/terraform-provider-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enxebre/terraform-provider-google/teams","hooks_url":"https://api.github.com/repos/enxebre/terraform-provider-google/hooks","issue_events_url":"https://api.github.com/repos/enxebre/terraform-provider-google/issues/events{/number}","events_url":"https://api.github.com/repos/enxebre/terraform-provider-google/events","assignees_url":"https://api.github.com/repos/enxebre/terraform-provider-google/assignees{/user}","branches_url":"https://api.github.com/repos/enxebre/terraform-provider-google/branches{/branch}","tags_url":"https://api.github.com/repos/enxebre/terraform-provider-google/tags","blobs_url":"https://api.github.com/repos/enxebre/terraform-provider-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enxebre/terraform-provider-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enxebre/terraform-provider-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/enxebre/terraform-provider-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enxebre/terraform-provider-google/statuses/{sha}","languages_url":"https://api.github.com/repos/enxebre/terraform-provider-google/languages","stargazers_url":"https://api.github.com/repos/enxebre/terraform-provider-google/stargazers","contributors_url":"https://api.github.com/repos/enxebre/terraform-provider-google/contributors","subscribers_url":"https://api.github.com/repos/enxebre/terraform-provider-google/subscribers","subscription_url":"https://api.github.com/repos/enxebre/terraform-provider-google/subscription","commits_url":"https://api.github.com/repos/enxebre/terraform-provider-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/enxebre/terraform-provider-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/enxebre/terraform-provider-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/enxebre/terraform-provider-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/enxebre/terraform-provider-google/contents/{+path}","compare_url":"https://api.github.com/repos/enxebre/terraform-provider-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enxebre/terraform-provider-google/merges","archive_url":"https://api.github.com/repos/enxebre/terraform-provider-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enxebre/terraform-provider-google/downloads","issues_url":"https://api.github.com/repos/enxebre/terraform-provider-google/issues{/number}","pulls_url":"https://api.github.com/repos/enxebre/terraform-provider-google/pulls{/number}","milestones_url":"https://api.github.com/repos/enxebre/terraform-provider-google/milestones{/number}","notifications_url":"https://api.github.com/repos/enxebre/terraform-provider-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enxebre/terraform-provider-google/labels{/name}","releases_url":"https://api.github.com/repos/enxebre/terraform-provider-google/releases{/id}","deployments_url":"https://api.github.com/repos/enxebre/terraform-provider-google/deployments","created_at":"2017-10-04T10:43:28Z","updated_at":"2017-10-04T10:43:30Z","pushed_at":"2017-10-04T17:20:08Z","git_url":"git://github.com/enxebre/terraform-provider-google.git","ssh_url":"git@github.com:enxebre/terraform-provider-google.git","clone_url":"https://github.com/enxebre/terraform-provider-google.git","svn_url":"https://github.com/enxebre/terraform-provider-google","homepage":"","size":6575,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"467481745f768e8273bae27310945efa0023a34d","user":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446075,"name":"terraform-provider-google","full_name":"terraform-providers/terraform-provider-google","owner":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-google","description":"Terraform google provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-google","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-google/deployments","created_at":"2017-06-05T20:54:02Z","updated_at":"2017-10-03T22:14:28Z","pushed_at":"2017-10-04T17:41:33Z","git_url":"git://github.com/terraform-providers/terraform-provider-google.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-google.git","clone_url":"https://github.com/terraform-providers/terraform-provider-google.git","svn_url":"https://github.com/terraform-providers/terraform-provider-google","homepage":"","size":6574,"stargazers_count":92,"watchers_count":92,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":140,"forks":70,"open_issues":140,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-google/pull/528"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/528"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-google/statuses/cc6eaefc952c2f6b05bc2ce3d16557c64dec09c0"}},"author_association":"NONE"}}
{"actor":{"display_login":"rosbo"}}