{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/122479443","pull_request_review_id":44603362,"id":122479443,"diff_hunk":"@@ -375,6 +398,7 @@ class Paint {\n     _data.setInt32(_kIsAntiAliasOffset, encoded, _kFakeHostEndian);\n   }\n \n+  // Must be kept in sync with the default in paint.cc","path":"lib/ui/painting.dart","position":null,"original_position":72,"commit_id":"8d2c2b8ba7ac1f14d464dab6cda0be646a0c160a","original_commit_id":"5dcc5baa9197d1bf10e0a08a51d98dc98f80fc29","user":{"login":"gspencergoog","id":8867023,"avatar_url":"https://avatars1.githubusercontent.com/u/8867023?v=3","gravatar_id":"","url":"https://api.github.com/users/gspencergoog","html_url":"https://github.com/gspencergoog","followers_url":"https://api.github.com/users/gspencergoog/followers","following_url":"https://api.github.com/users/gspencergoog/following{/other_user}","gists_url":"https://api.github.com/users/gspencergoog/gists{/gist_id}","starred_url":"https://api.github.com/users/gspencergoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspencergoog/subscriptions","organizations_url":"https://api.github.com/users/gspencergoog/orgs","repos_url":"https://api.github.com/users/gspencergoog/repos","events_url":"https://api.github.com/users/gspencergoog/events{/privacy}","received_events_url":"https://api.github.com/users/gspencergoog/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-06-16T16:17:41Z","updated_at":"2017-06-16T16:17:41Z","html_url":"https://github.com/flutter/engine/pull/3777#discussion_r122479443","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/3777","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/122479443"},"html":{"href":"https://github.com/flutter/engine/pull/3777#discussion_r122479443"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/3777"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/3777","id":125900752,"html_url":"https://github.com/flutter/engine/pull/3777","diff_url":"https://github.com/flutter/engine/pull/3777.diff","patch_url":"https://github.com/flutter/engine/pull/3777.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/3777","number":3777,"state":"open","locked":false,"title":"Enable line join styles and miter limit.","user":{"login":"gspencergoog","id":8867023,"avatar_url":"https://avatars1.githubusercontent.com/u/8867023?v=3","gravatar_id":"","url":"https://api.github.com/users/gspencergoog","html_url":"https://github.com/gspencergoog","followers_url":"https://api.github.com/users/gspencergoog/followers","following_url":"https://api.github.com/users/gspencergoog/following{/other_user}","gists_url":"https://api.github.com/users/gspencergoog/gists{/gist_id}","starred_url":"https://api.github.com/users/gspencergoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspencergoog/subscriptions","organizations_url":"https://api.github.com/users/gspencergoog/orgs","repos_url":"https://api.github.com/users/gspencergoog/repos","events_url":"https://api.github.com/users/gspencergoog/events{/privacy}","received_events_url":"https://api.github.com/users/gspencergoog/received_events","type":"User","site_admin":false},"body":"This fixes https://github.com/flutter/flutter/issues/7199 and also enables setting of the miter limit.\r\n\r\nA separate pull request for the flutter/flutter repo will enable it there once this is committed.\r\n\r\nThis adds StrokeJoin as a type, and the Paint.strokeJoin property, so that the caller can set the join type for paths and rectangles.  Canvas.drawPoints is unaffected by this property (unfortunately, in my opinion) when drawing points as lines.","created_at":"2017-06-15T20:03:50Z","updated_at":"2017-06-16T16:17:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d296d3421c9f45814a6f2148f425c1bc1b6dcdf1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/3777/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/3777/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/3777/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/8d2c2b8ba7ac1f14d464dab6cda0be646a0c160a","head":{"label":"gspencergoog:master","ref":"master","sha":"8d2c2b8ba7ac1f14d464dab6cda0be646a0c160a","user":{"login":"gspencergoog","id":8867023,"avatar_url":"https://avatars1.githubusercontent.com/u/8867023?v=3","gravatar_id":"","url":"https://api.github.com/users/gspencergoog","html_url":"https://github.com/gspencergoog","followers_url":"https://api.github.com/users/gspencergoog/followers","following_url":"https://api.github.com/users/gspencergoog/following{/other_user}","gists_url":"https://api.github.com/users/gspencergoog/gists{/gist_id}","starred_url":"https://api.github.com/users/gspencergoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspencergoog/subscriptions","organizations_url":"https://api.github.com/users/gspencergoog/orgs","repos_url":"https://api.github.com/users/gspencergoog/repos","events_url":"https://api.github.com/users/gspencergoog/events{/privacy}","received_events_url":"https://api.github.com/users/gspencergoog/received_events","type":"User","site_admin":false},"repo":{"id":92983158,"name":"engine","full_name":"gspencergoog/engine","owner":{"login":"gspencergoog","id":8867023,"avatar_url":"https://avatars1.githubusercontent.com/u/8867023?v=3","gravatar_id":"","url":"https://api.github.com/users/gspencergoog","html_url":"https://github.com/gspencergoog","followers_url":"https://api.github.com/users/gspencergoog/followers","following_url":"https://api.github.com/users/gspencergoog/following{/other_user}","gists_url":"https://api.github.com/users/gspencergoog/gists{/gist_id}","starred_url":"https://api.github.com/users/gspencergoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspencergoog/subscriptions","organizations_url":"https://api.github.com/users/gspencergoog/orgs","repos_url":"https://api.github.com/users/gspencergoog/repos","events_url":"https://api.github.com/users/gspencergoog/events{/privacy}","received_events_url":"https://api.github.com/users/gspencergoog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gspencergoog/engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/gspencergoog/engine","forks_url":"https://api.github.com/repos/gspencergoog/engine/forks","keys_url":"https://api.github.com/repos/gspencergoog/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gspencergoog/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gspencergoog/engine/teams","hooks_url":"https://api.github.com/repos/gspencergoog/engine/hooks","issue_events_url":"https://api.github.com/repos/gspencergoog/engine/issues/events{/number}","events_url":"https://api.github.com/repos/gspencergoog/engine/events","assignees_url":"https://api.github.com/repos/gspencergoog/engine/assignees{/user}","branches_url":"https://api.github.com/repos/gspencergoog/engine/branches{/branch}","tags_url":"https://api.github.com/repos/gspencergoog/engine/tags","blobs_url":"https://api.github.com/repos/gspencergoog/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gspencergoog/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gspencergoog/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/gspencergoog/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gspencergoog/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/gspencergoog/engine/languages","stargazers_url":"https://api.github.com/repos/gspencergoog/engine/stargazers","contributors_url":"https://api.github.com/repos/gspencergoog/engine/contributors","subscribers_url":"https://api.github.com/repos/gspencergoog/engine/subscribers","subscription_url":"https://api.github.com/repos/gspencergoog/engine/subscription","commits_url":"https://api.github.com/repos/gspencergoog/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/gspencergoog/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/gspencergoog/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/gspencergoog/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/gspencergoog/engine/contents/{+path}","compare_url":"https://api.github.com/repos/gspencergoog/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gspencergoog/engine/merges","archive_url":"https://api.github.com/repos/gspencergoog/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gspencergoog/engine/downloads","issues_url":"https://api.github.com/repos/gspencergoog/engine/issues{/number}","pulls_url":"https://api.github.com/repos/gspencergoog/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/gspencergoog/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/gspencergoog/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gspencergoog/engine/labels{/name}","releases_url":"https://api.github.com/repos/gspencergoog/engine/releases{/id}","deployments_url":"https://api.github.com/repos/gspencergoog/engine/deployments","created_at":"2017-05-31T19:51:56Z","updated_at":"2017-05-31T19:52:01Z","pushed_at":"2017-06-16T16:16:28Z","git_url":"git://github.com/gspencergoog/engine.git","ssh_url":"git@github.com:gspencergoog/engine.git","clone_url":"https://github.com/gspencergoog/engine.git","svn_url":"https://github.com/gspencergoog/engine","homepage":"http://flutter.io","size":87417,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"18fdfb86bb3876fcbb4e1d25e5b2aad0c5cd669f","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2017-06-09T22:15:11Z","pushed_at":"2017-06-16T16:16:30Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":87391,"stargazers_count":987,"watchers_count":987,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":10,"forks":208,"open_issues":10,"watchers":987,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/3777"},"html":{"href":"https://github.com/flutter/engine/pull/3777"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/3777"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/3777/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/3777/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/3777/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/8d2c2b8ba7ac1f14d464dab6cda0be646a0c160a"}}}}
{"actor":{"display_login":"gspencergoog"}}