{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/prepack/pulls/comments/139859580","pull_request_review_id":63849835,"id":139859580,"diff_hunk":"@@ -195,15 +191,16 @@ export class ResidualFunctions {\n             // modified variable of its parent scope. In some cases it could be\n             // an improvement to split these variables into multiple\n             // scopes.\n+            const variableIndexInScope = String(scope.initializationValues.length);\n             invariant(serializedBinding.serializedValue);\n-            scope.initializationValues.set(name, serializedBinding.serializedValue);\n+            scope.initializationValues.push(serializedBinding.serializedValue);\n             scope.capturedScope = capturedScope;\n \n             // Replace binding usage with scope references\n             serializedBinding.serializedValue = t.memberExpression(\n               t.identifier(capturedScope),\n-              t.identifier(name),\n-              false\n+              t.identifier(variableIndexInScope),","path":"src/serializer/ResidualFunctions.js","position":37,"original_position":37,"commit_id":"fb12ae18f2d7d39103fa50d450093c2b4b73d741","original_commit_id":"fb12ae18f2d7d39103fa50d450093c2b4b73d741","user":{"login":"yinghuitan","id":10968261,"avatar_url":"https://avatars2.githubusercontent.com/u/10968261?v=4","gravatar_id":"","url":"https://api.github.com/users/yinghuitan","html_url":"https://github.com/yinghuitan","followers_url":"https://api.github.com/users/yinghuitan/followers","following_url":"https://api.github.com/users/yinghuitan/following{/other_user}","gists_url":"https://api.github.com/users/yinghuitan/gists{/gist_id}","starred_url":"https://api.github.com/users/yinghuitan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinghuitan/subscriptions","organizations_url":"https://api.github.com/users/yinghuitan/orgs","repos_url":"https://api.github.com/users/yinghuitan/repos","events_url":"https://api.github.com/users/yinghuitan/events{/privacy}","received_events_url":"https://api.github.com/users/yinghuitan/received_events","type":"User","site_admin":false},"body":"Thanks, it should be a number literal.","created_at":"2017-09-20T01:53:58Z","updated_at":"2017-09-20T01:53:58Z","html_url":"https://github.com/facebook/prepack/pull/980#discussion_r139859580","pull_request_url":"https://api.github.com/repos/facebook/prepack/pulls/980","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments/139859580"},"html":{"href":"https://github.com/facebook/prepack/pull/980#discussion_r139859580"},"pull_request":{"href":"https://api.github.com/repos/facebook/prepack/pulls/980"}},"in_reply_to_id":139857250},"pull_request":{"url":"https://api.github.com/repos/facebook/prepack/pulls/980","id":141974714,"html_url":"https://github.com/facebook/prepack/pull/980","diff_url":"https://github.com/facebook/prepack/pull/980.diff","patch_url":"https://github.com/facebook/prepack/pull/980.patch","issue_url":"https://api.github.com/repos/facebook/prepack/issues/980","number":980,"state":"open","locked":false,"title":"Change modified scope binding to use array instead of object property","user":{"login":"yinghuitan","id":10968261,"avatar_url":"https://avatars2.githubusercontent.com/u/10968261?v=4","gravatar_id":"","url":"https://api.github.com/users/yinghuitan","html_url":"https://github.com/yinghuitan","followers_url":"https://api.github.com/users/yinghuitan/followers","following_url":"https://api.github.com/users/yinghuitan/following{/other_user}","gists_url":"https://api.github.com/users/yinghuitan/gists{/gist_id}","starred_url":"https://api.github.com/users/yinghuitan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinghuitan/subscriptions","organizations_url":"https://api.github.com/users/yinghuitan/orgs","repos_url":"https://api.github.com/users/yinghuitan/repos","events_url":"https://api.github.com/users/yinghuitan/events{/privacy}","received_events_url":"https://api.github.com/users/yinghuitan/received_events","type":"User","site_admin":false},"body":"#919","created_at":"2017-09-19T22:50:50Z","updated_at":"2017-09-20T01:53:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8ede9bb467e340d30025779bc603f3519e8dfb7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cblappert","id":3744743,"avatar_url":"https://avatars1.githubusercontent.com/u/3744743?v=4","gravatar_id":"","url":"https://api.github.com/users/cblappert","html_url":"https://github.com/cblappert","followers_url":"https://api.github.com/users/cblappert/followers","following_url":"https://api.github.com/users/cblappert/following{/other_user}","gists_url":"https://api.github.com/users/cblappert/gists{/gist_id}","starred_url":"https://api.github.com/users/cblappert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblappert/subscriptions","organizations_url":"https://api.github.com/users/cblappert/orgs","repos_url":"https://api.github.com/users/cblappert/repos","events_url":"https://api.github.com/users/cblappert/events{/privacy}","received_events_url":"https://api.github.com/users/cblappert/received_events","type":"User","site_admin":false},{"login":"NTillmann","id":6457462,"avatar_url":"https://avatars2.githubusercontent.com/u/6457462?v=4","gravatar_id":"","url":"https://api.github.com/users/NTillmann","html_url":"https://github.com/NTillmann","followers_url":"https://api.github.com/users/NTillmann/followers","following_url":"https://api.github.com/users/NTillmann/following{/other_user}","gists_url":"https://api.github.com/users/NTillmann/gists{/gist_id}","starred_url":"https://api.github.com/users/NTillmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTillmann/subscriptions","organizations_url":"https://api.github.com/users/NTillmann/orgs","repos_url":"https://api.github.com/users/NTillmann/repos","events_url":"https://api.github.com/users/NTillmann/events{/privacy}","received_events_url":"https://api.github.com/users/NTillmann/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/prepack/pulls/980/commits","review_comments_url":"https://api.github.com/repos/facebook/prepack/pulls/980/comments","review_comment_url":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/prepack/issues/980/comments","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/fb12ae18f2d7d39103fa50d450093c2b4b73d741","head":{"label":"facebook:UseArrayIndexForModifiedBindings","ref":"UseArrayIndexForModifiedBindings","sha":"fb12ae18f2d7d39103fa50d450093c2b4b73d741","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2017-09-20T01:40:57Z","pushed_at":"2017-09-20T00:55:15Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"git@github.com:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"https://prepack.io","size":3327,"stargazers_count":10145,"watchers_count":10145,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":278,"mirror_url":null,"open_issues_count":92,"forks":278,"open_issues":92,"watchers":10145,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f8369fb58d0731c100dfc48f33f30cfe3c5ecabf","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2017-09-20T01:40:57Z","pushed_at":"2017-09-20T00:55:15Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"git@github.com:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"https://prepack.io","size":3327,"stargazers_count":10145,"watchers_count":10145,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":278,"mirror_url":null,"open_issues_count":92,"forks":278,"open_issues":92,"watchers":10145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/980"},"html":{"href":"https://github.com/facebook/prepack/pull/980"},"issue":{"href":"https://api.github.com/repos/facebook/prepack/issues/980"},"comments":{"href":"https://api.github.com/repos/facebook/prepack/issues/980/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/prepack/pulls/980/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/prepack/pulls/980/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/prepack/statuses/fb12ae18f2d7d39103fa50d450093c2b4b73d741"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yinghuitan"}}