{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3metrics/pulls/comments/159141332","pull_request_review_id":86048324,"id":159141332,"diff_hunk":"@@ -171,20 +172,15 @@ func (v *validator) validateRollupRules(rrv map[string]*rules.RollupRuleView) er\n }\n \n func (v *validator) validateFilter(ruleName string, f string) (filters.TagFilterValueMap, error) {\n-\tfilterValues, err := filters.ParseTagFilterValueMap(f)\n+\tfilterValues, err := filters.ValidateTagsFilter(f)","path":"rules/validator/validator.go","position":40,"original_position":40,"commit_id":"fae47fefa3549fdb88be7495895413d5109ad2ef","original_commit_id":"fae47fefa3549fdb88be7495895413d5109ad2ef","user":{"login":"jeromefroe","id":7217598,"avatar_url":"https://avatars1.githubusercontent.com/u/7217598?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromefroe","html_url":"https://github.com/jeromefroe","followers_url":"https://api.github.com/users/jeromefroe/followers","following_url":"https://api.github.com/users/jeromefroe/following{/other_user}","gists_url":"https://api.github.com/users/jeromefroe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromefroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromefroe/subscriptions","organizations_url":"https://api.github.com/users/jeromefroe/orgs","repos_url":"https://api.github.com/users/jeromefroe/repos","events_url":"https://api.github.com/users/jeromefroe/events{/privacy}","received_events_url":"https://api.github.com/users/jeromefroe/received_events","type":"User","site_admin":false},"body":"Using `wrapError` seems at the top level seems fine to me.","created_at":"2017-12-31T14:29:11Z","updated_at":"2017-12-31T14:29:11Z","html_url":"https://github.com/m3db/m3metrics/pull/126#discussion_r159141332","pull_request_url":"https://api.github.com/repos/m3db/m3metrics/pulls/126","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/comments/159141332"},"html":{"href":"https://github.com/m3db/m3metrics/pull/126#discussion_r159141332"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/126"}},"in_reply_to_id":159141117},"pull_request":{"url":"https://api.github.com/repos/m3db/m3metrics/pulls/126","id":160601094,"html_url":"https://github.com/m3db/m3metrics/pull/126","diff_url":"https://github.com/m3db/m3metrics/pull/126.diff","patch_url":"https://github.com/m3db/m3metrics/pull/126.patch","issue_url":"https://api.github.com/repos/m3db/m3metrics/issues/126","number":126,"state":"open","locked":false,"title":"Validate filter during snapshot construction","user":{"login":"xichen2020","id":12239421,"avatar_url":"https://avatars1.githubusercontent.com/u/12239421?v=4","gravatar_id":"","url":"https://api.github.com/users/xichen2020","html_url":"https://github.com/xichen2020","followers_url":"https://api.github.com/users/xichen2020/followers","following_url":"https://api.github.com/users/xichen2020/following{/other_user}","gists_url":"https://api.github.com/users/xichen2020/gists{/gist_id}","starred_url":"https://api.github.com/users/xichen2020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xichen2020/subscriptions","organizations_url":"https://api.github.com/users/xichen2020/orgs","repos_url":"https://api.github.com/users/xichen2020/repos","events_url":"https://api.github.com/users/xichen2020/events{/privacy}","received_events_url":"https://api.github.com/users/xichen2020/received_events","type":"User","site_admin":false},"body":"cc @jeromefroe @cw9 \r\n\r\nThis PR adds filter validation when constructing mapping rule and rollup rule snapshots. This validation is currently done in the rules store right before persistence, so bad filter expression won't be detected till before the rule is persisted. By performing filter validation during construction, this can fail early when bad filter expression is detected.","created_at":"2017-12-30T21:09:20Z","updated_at":"2017-12-31T14:29:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edbc2ce9e65197e34befac8fb852fd4fcd236133","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3metrics/pulls/126/commits","review_comments_url":"https://api.github.com/repos/m3db/m3metrics/pulls/126/comments","review_comment_url":"https://api.github.com/repos/m3db/m3metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3metrics/issues/126/comments","statuses_url":"https://api.github.com/repos/m3db/m3metrics/statuses/fae47fefa3549fdb88be7495895413d5109ad2ef","head":{"label":"m3db:xichen-validate-during-construction","ref":"xichen-validate-during-construction","sha":"fae47fefa3549fdb88be7495895413d5109ad2ef","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":76399863,"name":"m3metrics","full_name":"m3db/m3metrics","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3metrics","description":"Metrics data structures and serialization/deserializtion protocols","fork":false,"url":"https://api.github.com/repos/m3db/m3metrics","forks_url":"https://api.github.com/repos/m3db/m3metrics/forks","keys_url":"https://api.github.com/repos/m3db/m3metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3metrics/teams","hooks_url":"https://api.github.com/repos/m3db/m3metrics/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3metrics/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3metrics/events","assignees_url":"https://api.github.com/repos/m3db/m3metrics/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3metrics/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3metrics/tags","blobs_url":"https://api.github.com/repos/m3db/m3metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3metrics/languages","stargazers_url":"https://api.github.com/repos/m3db/m3metrics/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3metrics/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3metrics/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3metrics/subscription","commits_url":"https://api.github.com/repos/m3db/m3metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3metrics/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3metrics/merges","archive_url":"https://api.github.com/repos/m3db/m3metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3metrics/downloads","issues_url":"https://api.github.com/repos/m3db/m3metrics/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3metrics/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3metrics/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3metrics/deployments","created_at":"2016-12-13T21:28:26Z","updated_at":"2017-11-06T21:15:03Z","pushed_at":"2017-12-31T14:13:45Z","git_url":"git://github.com/m3db/m3metrics.git","ssh_url":"git@github.com:m3db/m3metrics.git","clone_url":"https://github.com/m3db/m3metrics.git","svn_url":"https://github.com/m3db/m3metrics","homepage":null,"size":646,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"f5cc881ab5d3577071d9664d60939bb668ed01c2","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":76399863,"name":"m3metrics","full_name":"m3db/m3metrics","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3metrics","description":"Metrics data structures and serialization/deserializtion protocols","fork":false,"url":"https://api.github.com/repos/m3db/m3metrics","forks_url":"https://api.github.com/repos/m3db/m3metrics/forks","keys_url":"https://api.github.com/repos/m3db/m3metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3metrics/teams","hooks_url":"https://api.github.com/repos/m3db/m3metrics/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3metrics/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3metrics/events","assignees_url":"https://api.github.com/repos/m3db/m3metrics/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3metrics/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3metrics/tags","blobs_url":"https://api.github.com/repos/m3db/m3metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3metrics/languages","stargazers_url":"https://api.github.com/repos/m3db/m3metrics/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3metrics/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3metrics/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3metrics/subscription","commits_url":"https://api.github.com/repos/m3db/m3metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3metrics/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3metrics/merges","archive_url":"https://api.github.com/repos/m3db/m3metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3metrics/downloads","issues_url":"https://api.github.com/repos/m3db/m3metrics/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3metrics/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3metrics/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3metrics/deployments","created_at":"2016-12-13T21:28:26Z","updated_at":"2017-11-06T21:15:03Z","pushed_at":"2017-12-31T14:13:45Z","git_url":"git://github.com/m3db/m3metrics.git","ssh_url":"git@github.com:m3db/m3metrics.git","clone_url":"https://github.com/m3db/m3metrics.git","svn_url":"https://github.com/m3db/m3metrics","homepage":null,"size":646,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/126"},"html":{"href":"https://github.com/m3db/m3metrics/pull/126"},"issue":{"href":"https://api.github.com/repos/m3db/m3metrics/issues/126"},"comments":{"href":"https://api.github.com/repos/m3db/m3metrics/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3metrics/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3metrics/statuses/fae47fefa3549fdb88be7495895413d5109ad2ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeromefroe"}}