{"action":"created","comment":{"url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/comments/98462272","pull_request_review_id":19103691,"id":98462272,"diff_hunk":"@@ -3,13 +3,18 @@\n ## Description\n \n A CDN service provided under `*.cdn.cra.cz.` DNS tree is delegated to\n-`sr01.cdn.cra.cz.` and `sr02.cdn.cra.cz.` nameservers.  Those\n-nameservers fails to answer to `IN NS` queries by returning\n-`RCODE=NOTIMPL`and thus breaking QNAME minimization\n-[RFC 7816](https://tools.ietf.org/html/rfc7816).  As an additional\n-*bonus* the packets are malformed as there are extra 11 bytes at the\n-end of the message and sets `AD` bit on in all DNS responses violating\n-[RFC 4035](https://tools.ietf.org/html/rfc4035#section-3.1.6)\n+`sr01.cdn.cra.cz.` and `sr02.cdn.cra.cz.` nameservers.  These\n+authoritative nameservers fails to answer to `IN NS` queries by\n+returning `RCODE=NOTIMPL`and thus breaking QNAME minimization [RFC\n+7816](https://tools.ietf.org/html/rfc7816).\n+\n+There's additional breakagin in the DNS packets as they are malformed","path":"2017/DVE-2017-0007.md","position":16,"original_position":16,"commit_id":"0039d55a69a4c551cb0e0450817e27d55a380b51","original_commit_id":"0039d55a69a4c551cb0e0450817e27d55a380b51","user":{"login":"jelu","id":1446909,"avatar_url":"https://avatars.githubusercontent.com/u/1446909?v=3","gravatar_id":"","url":"https://api.github.com/users/jelu","html_url":"https://github.com/jelu","followers_url":"https://api.github.com/users/jelu/followers","following_url":"https://api.github.com/users/jelu/following{/other_user}","gists_url":"https://api.github.com/users/jelu/gists{/gist_id}","starred_url":"https://api.github.com/users/jelu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelu/subscriptions","organizations_url":"https://api.github.com/users/jelu/orgs","repos_url":"https://api.github.com/users/jelu/repos","events_url":"https://api.github.com/users/jelu/events{/privacy}","received_events_url":"https://api.github.com/users/jelu/received_events","type":"User","site_admin":false},"body":"Typo `breakagin` and is this not another DVE?","created_at":"2017-01-30T15:18:59Z","updated_at":"2017-01-30T15:19:25Z","html_url":"https://github.com/DNS-OARC/dns-violations/pull/30#discussion_r98462272","pull_request_url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/comments/98462272"},"html":{"href":"https://github.com/DNS-OARC/dns-violations/pull/30#discussion_r98462272"},"pull_request":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30","id":103727073,"html_url":"https://github.com/DNS-OARC/dns-violations/pull/30","diff_url":"https://github.com/DNS-OARC/dns-violations/pull/30.diff","patch_url":"https://github.com/DNS-OARC/dns-violations/pull/30.patch","issue_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/30","number":30,"state":"open","locked":false,"title":"Add dnstap recordings for DVE-2017-0007, add updated information about  issue fixed","user":{"login":"oerdnj","id":130731,"avatar_url":"https://avatars.githubusercontent.com/u/130731?v=3","gravatar_id":"","url":"https://api.github.com/users/oerdnj","html_url":"https://github.com/oerdnj","followers_url":"https://api.github.com/users/oerdnj/followers","following_url":"https://api.github.com/users/oerdnj/following{/other_user}","gists_url":"https://api.github.com/users/oerdnj/gists{/gist_id}","starred_url":"https://api.github.com/users/oerdnj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oerdnj/subscriptions","organizations_url":"https://api.github.com/users/oerdnj/orgs","repos_url":"https://api.github.com/users/oerdnj/repos","events_url":"https://api.github.com/users/oerdnj/events{/privacy}","received_events_url":"https://api.github.com/users/oerdnj/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-30T12:30:26Z","updated_at":"2017-01-30T15:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97c76c7b68ee08710ca36a0b711460cf9cceaa37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30/commits","review_comments_url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30/comments","review_comment_url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/30/comments","statuses_url":"https://api.github.com/repos/DNS-OARC/dns-violations/statuses/0039d55a69a4c551cb0e0450817e27d55a380b51","head":{"label":"DNS-OARC:DVE-2017-0007-dnstap","ref":"DVE-2017-0007-dnstap","sha":"0039d55a69a4c551cb0e0450817e27d55a380b51","user":{"login":"DNS-OARC","id":1955488,"avatar_url":"https://avatars.githubusercontent.com/u/1955488?v=3","gravatar_id":"","url":"https://api.github.com/users/DNS-OARC","html_url":"https://github.com/DNS-OARC","followers_url":"https://api.github.com/users/DNS-OARC/followers","following_url":"https://api.github.com/users/DNS-OARC/following{/other_user}","gists_url":"https://api.github.com/users/DNS-OARC/gists{/gist_id}","starred_url":"https://api.github.com/users/DNS-OARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNS-OARC/subscriptions","organizations_url":"https://api.github.com/users/DNS-OARC/orgs","repos_url":"https://api.github.com/users/DNS-OARC/repos","events_url":"https://api.github.com/users/DNS-OARC/events{/privacy}","received_events_url":"https://api.github.com/users/DNS-OARC/received_events","type":"Organization","site_admin":false},"repo":{"id":80027130,"name":"dns-violations","full_name":"DNS-OARC/dns-violations","owner":{"login":"DNS-OARC","id":1955488,"avatar_url":"https://avatars.githubusercontent.com/u/1955488?v=3","gravatar_id":"","url":"https://api.github.com/users/DNS-OARC","html_url":"https://github.com/DNS-OARC","followers_url":"https://api.github.com/users/DNS-OARC/followers","following_url":"https://api.github.com/users/DNS-OARC/following{/other_user}","gists_url":"https://api.github.com/users/DNS-OARC/gists{/gist_id}","starred_url":"https://api.github.com/users/DNS-OARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNS-OARC/subscriptions","organizations_url":"https://api.github.com/users/DNS-OARC/orgs","repos_url":"https://api.github.com/users/DNS-OARC/repos","events_url":"https://api.github.com/users/DNS-OARC/events{/privacy}","received_events_url":"https://api.github.com/users/DNS-OARC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DNS-OARC/dns-violations","description":"List of DNS violations by implementations, software and/or systems","fork":false,"url":"https://api.github.com/repos/DNS-OARC/dns-violations","forks_url":"https://api.github.com/repos/DNS-OARC/dns-violations/forks","keys_url":"https://api.github.com/repos/DNS-OARC/dns-violations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DNS-OARC/dns-violations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DNS-OARC/dns-violations/teams","hooks_url":"https://api.github.com/repos/DNS-OARC/dns-violations/hooks","issue_events_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/events{/number}","events_url":"https://api.github.com/repos/DNS-OARC/dns-violations/events","assignees_url":"https://api.github.com/repos/DNS-OARC/dns-violations/assignees{/user}","branches_url":"https://api.github.com/repos/DNS-OARC/dns-violations/branches{/branch}","tags_url":"https://api.github.com/repos/DNS-OARC/dns-violations/tags","blobs_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/refs{/sha}","trees_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DNS-OARC/dns-violations/statuses/{sha}","languages_url":"https://api.github.com/repos/DNS-OARC/dns-violations/languages","stargazers_url":"https://api.github.com/repos/DNS-OARC/dns-violations/stargazers","contributors_url":"https://api.github.com/repos/DNS-OARC/dns-violations/contributors","subscribers_url":"https://api.github.com/repos/DNS-OARC/dns-violations/subscribers","subscription_url":"https://api.github.com/repos/DNS-OARC/dns-violations/subscription","commits_url":"https://api.github.com/repos/DNS-OARC/dns-violations/commits{/sha}","git_commits_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/commits{/sha}","comments_url":"https://api.github.com/repos/DNS-OARC/dns-violations/comments{/number}","issue_comment_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/comments{/number}","contents_url":"https://api.github.com/repos/DNS-OARC/dns-violations/contents/{+path}","compare_url":"https://api.github.com/repos/DNS-OARC/dns-violations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DNS-OARC/dns-violations/merges","archive_url":"https://api.github.com/repos/DNS-OARC/dns-violations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DNS-OARC/dns-violations/downloads","issues_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues{/number}","pulls_url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls{/number}","milestones_url":"https://api.github.com/repos/DNS-OARC/dns-violations/milestones{/number}","notifications_url":"https://api.github.com/repos/DNS-OARC/dns-violations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DNS-OARC/dns-violations/labels{/name}","releases_url":"https://api.github.com/repos/DNS-OARC/dns-violations/releases{/id}","deployments_url":"https://api.github.com/repos/DNS-OARC/dns-violations/deployments","created_at":"2017-01-25T15:26:39Z","updated_at":"2017-01-30T03:55:48Z","pushed_at":"2017-01-30T15:15:54Z","git_url":"git://github.com/DNS-OARC/dns-violations.git","ssh_url":"git@github.com:DNS-OARC/dns-violations.git","clone_url":"https://github.com/DNS-OARC/dns-violations.git","svn_url":"https://github.com/DNS-OARC/dns-violations","homepage":"","size":35,"stargazers_count":45,"watchers_count":45,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":45,"default_branch":"master"}},"base":{"label":"DNS-OARC:master","ref":"master","sha":"af835e7b1e681dc331457346e3fd39183138ba0b","user":{"login":"DNS-OARC","id":1955488,"avatar_url":"https://avatars.githubusercontent.com/u/1955488?v=3","gravatar_id":"","url":"https://api.github.com/users/DNS-OARC","html_url":"https://github.com/DNS-OARC","followers_url":"https://api.github.com/users/DNS-OARC/followers","following_url":"https://api.github.com/users/DNS-OARC/following{/other_user}","gists_url":"https://api.github.com/users/DNS-OARC/gists{/gist_id}","starred_url":"https://api.github.com/users/DNS-OARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNS-OARC/subscriptions","organizations_url":"https://api.github.com/users/DNS-OARC/orgs","repos_url":"https://api.github.com/users/DNS-OARC/repos","events_url":"https://api.github.com/users/DNS-OARC/events{/privacy}","received_events_url":"https://api.github.com/users/DNS-OARC/received_events","type":"Organization","site_admin":false},"repo":{"id":80027130,"name":"dns-violations","full_name":"DNS-OARC/dns-violations","owner":{"login":"DNS-OARC","id":1955488,"avatar_url":"https://avatars.githubusercontent.com/u/1955488?v=3","gravatar_id":"","url":"https://api.github.com/users/DNS-OARC","html_url":"https://github.com/DNS-OARC","followers_url":"https://api.github.com/users/DNS-OARC/followers","following_url":"https://api.github.com/users/DNS-OARC/following{/other_user}","gists_url":"https://api.github.com/users/DNS-OARC/gists{/gist_id}","starred_url":"https://api.github.com/users/DNS-OARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNS-OARC/subscriptions","organizations_url":"https://api.github.com/users/DNS-OARC/orgs","repos_url":"https://api.github.com/users/DNS-OARC/repos","events_url":"https://api.github.com/users/DNS-OARC/events{/privacy}","received_events_url":"https://api.github.com/users/DNS-OARC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DNS-OARC/dns-violations","description":"List of DNS violations by implementations, software and/or systems","fork":false,"url":"https://api.github.com/repos/DNS-OARC/dns-violations","forks_url":"https://api.github.com/repos/DNS-OARC/dns-violations/forks","keys_url":"https://api.github.com/repos/DNS-OARC/dns-violations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DNS-OARC/dns-violations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DNS-OARC/dns-violations/teams","hooks_url":"https://api.github.com/repos/DNS-OARC/dns-violations/hooks","issue_events_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/events{/number}","events_url":"https://api.github.com/repos/DNS-OARC/dns-violations/events","assignees_url":"https://api.github.com/repos/DNS-OARC/dns-violations/assignees{/user}","branches_url":"https://api.github.com/repos/DNS-OARC/dns-violations/branches{/branch}","tags_url":"https://api.github.com/repos/DNS-OARC/dns-violations/tags","blobs_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/refs{/sha}","trees_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DNS-OARC/dns-violations/statuses/{sha}","languages_url":"https://api.github.com/repos/DNS-OARC/dns-violations/languages","stargazers_url":"https://api.github.com/repos/DNS-OARC/dns-violations/stargazers","contributors_url":"https://api.github.com/repos/DNS-OARC/dns-violations/contributors","subscribers_url":"https://api.github.com/repos/DNS-OARC/dns-violations/subscribers","subscription_url":"https://api.github.com/repos/DNS-OARC/dns-violations/subscription","commits_url":"https://api.github.com/repos/DNS-OARC/dns-violations/commits{/sha}","git_commits_url":"https://api.github.com/repos/DNS-OARC/dns-violations/git/commits{/sha}","comments_url":"https://api.github.com/repos/DNS-OARC/dns-violations/comments{/number}","issue_comment_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/comments{/number}","contents_url":"https://api.github.com/repos/DNS-OARC/dns-violations/contents/{+path}","compare_url":"https://api.github.com/repos/DNS-OARC/dns-violations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DNS-OARC/dns-violations/merges","archive_url":"https://api.github.com/repos/DNS-OARC/dns-violations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DNS-OARC/dns-violations/downloads","issues_url":"https://api.github.com/repos/DNS-OARC/dns-violations/issues{/number}","pulls_url":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls{/number}","milestones_url":"https://api.github.com/repos/DNS-OARC/dns-violations/milestones{/number}","notifications_url":"https://api.github.com/repos/DNS-OARC/dns-violations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DNS-OARC/dns-violations/labels{/name}","releases_url":"https://api.github.com/repos/DNS-OARC/dns-violations/releases{/id}","deployments_url":"https://api.github.com/repos/DNS-OARC/dns-violations/deployments","created_at":"2017-01-25T15:26:39Z","updated_at":"2017-01-30T03:55:48Z","pushed_at":"2017-01-30T15:15:54Z","git_url":"git://github.com/DNS-OARC/dns-violations.git","ssh_url":"git@github.com:DNS-OARC/dns-violations.git","clone_url":"https://github.com/DNS-OARC/dns-violations.git","svn_url":"https://github.com/DNS-OARC/dns-violations","homepage":"","size":35,"stargazers_count":45,"watchers_count":45,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30"},"html":{"href":"https://github.com/DNS-OARC/dns-violations/pull/30"},"issue":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/30"},"comments":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/DNS-OARC/dns-violations/statuses/0039d55a69a4c551cb0e0450817e27d55a380b51"}}}}
{"actor":{"display_login":"jelu"}}