{"action":"created","issue":{"url":"https://api.github.com/repos/EFForg/https-everywhere/issues/10872","repository_url":"https://api.github.com/repos/EFForg/https-everywhere","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/10872/labels{/name}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/10872/comments","events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/10872/events","html_url":"https://github.com/EFForg/https-everywhere/pull/10872","id":240521313,"number":10872,"title":"Trivialize direct rewrite rules","user":{"login":"cschanaj","id":23636124,"avatar_url":"https://avatars3.githubusercontent.com/u/23636124?v=3","gravatar_id":"","url":"https://api.github.com/users/cschanaj","html_url":"https://github.com/cschanaj","followers_url":"https://api.github.com/users/cschanaj/followers","following_url":"https://api.github.com/users/cschanaj/following{/other_user}","gists_url":"https://api.github.com/users/cschanaj/gists{/gist_id}","starred_url":"https://api.github.com/users/cschanaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschanaj/subscriptions","organizations_url":"https://api.github.com/users/cschanaj/orgs","repos_url":"https://api.github.com/users/cschanaj/repos","events_url":"https://api.github.com/users/cschanaj/events{/privacy}","received_events_url":"https://api.github.com/users/cschanaj/received_events","type":"User","site_admin":false},"labels":[{"id":427778479,"url":"https://api.github.com/repos/EFForg/https-everywhere/labels/top-100k","name":"top-100k","color":"ffb3b3","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-07-05T02:08:34Z","updated_at":"2017-07-08T22:18:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/10872","html_url":"https://github.com/EFForg/https-everywhere/pull/10872","diff_url":"https://github.com/EFForg/https-everywhere/pull/10872.diff","patch_url":"https://github.com/EFForg/https-everywhere/pull/10872.patch"},"body":"A list of candidates is generated such that\r\n\r\n - Neither `default_off` nor `platform`\r\n - No linked rulesets (no occurrence of the string `.xml`)\r\n - Exclude all rulesets (8) failing Travis\r\n   * 3dglassesfree.com.xml\r\n   * Ebi.ac.uk.xml\r\n   * RoboForm.com.xml\r\n   * UpsideOut.com.xml\r\n   * CounterPunch.org.xml\r\n   * Kursbuero.de.xml\r\n   * Toshiba.co.jp.xml\r\n   * xServers.xml\r\n - `#rule` == `#target` == `#non-wildcard target` == 1\r\n\r\nNote: The following ruleset from the PR require might some attention (non effective rewrite)\r\n - E-rewards.com.xml\r\n - Myftp.utechsoft.com.xml\r\n - Owl.English.Purdue.edu.xml\r\n\r\nRemark: The number of rulesets satisfying these conditions is much lesser than my expectation. IMHO, this is not urgent at all. \r\n\r\nRemark: The code I used is written in Go, I might provide the code to reproduce this change if necessary."},"comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments/313884258","html_url":"https://github.com/EFForg/https-everywhere/pull/10872#issuecomment-313884258","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/10872","id":313884258,"user":{"login":"Hainish","id":156137,"avatar_url":"https://avatars0.githubusercontent.com/u/156137?v=3","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"created_at":"2017-07-08T22:18:23Z","updated_at":"2017-07-08T22:18:23Z","body":"We don't have any current tools for benchmarking.  We may want to utilize https://benchmarkjs.com/ for this purpose, building it into our selenium tests.\r\n\r\nThere are a lot of good reasons for trivializing rules, aside from performance.  For instance, some downstream dependencies only use the trivialized rules.  It's also simpler to read."}}
{"actor":{"display_login":"Hainish"}}