{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/122590632","pull_request_review_id":44720427,"id":122590632,"diff_hunk":"@@ -153,7 +154,7 @@\n     <!-- Fix for collapsing margin problem. Reference: http://stackoverflow.com/questions/6204670 -->\n     <div class=\"visibilityMessage overflow-hidden\" id=\"visibilityMessage-${fqForm.questionIndex}\">\n         This is the visibility hint as seen by the feedback giver:\n-        <ul class=\"text-muted background-color-warning\">\n+        <ul class=\"text-muted <%= fqForm.isQuestionHasResponses() ? \"\" : \"background-color-warning\" %>\">","path":"src/main/webapp/WEB-INF/tags/instructor/feedbackEdit/questionVisibilityOptions.tag","position":18,"original_position":18,"commit_id":"9de165843c7b872f22bb1317395dc8d46f07016f","original_commit_id":"9de165843c7b872f22bb1317395dc8d46f07016f","user":{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars3.githubusercontent.com/u/6811428?v=3","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false},"body":"I feel `background-color-warning` can stay for both. The yellow background helps indicate that the visibility can still be edited if the user really wants to (without it, it gives the impression that it's completely disabled).","created_at":"2017-06-18T13:05:56Z","updated_at":"2017-06-18T13:11:29Z","html_url":"https://github.com/TEAMMATES/teammates/pull/7453#discussion_r122590632","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/122590632"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7453#discussion_r122590632"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453","id":124128594,"html_url":"https://github.com/TEAMMATES/teammates/pull/7453","diff_url":"https://github.com/TEAMMATES/teammates/pull/7453.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/7453.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7453","number":7453,"state":"open","locked":false,"title":"Instructor: add session: warn that it's not recommended to change visibility after the session is open #5980","user":{"login":"HirdayGupta","id":18088721,"avatar_url":"https://avatars1.githubusercontent.com/u/18088721?v=3","gravatar_id":"","url":"https://api.github.com/users/HirdayGupta","html_url":"https://github.com/HirdayGupta","followers_url":"https://api.github.com/users/HirdayGupta/followers","following_url":"https://api.github.com/users/HirdayGupta/following{/other_user}","gists_url":"https://api.github.com/users/HirdayGupta/gists{/gist_id}","starred_url":"https://api.github.com/users/HirdayGupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HirdayGupta/subscriptions","organizations_url":"https://api.github.com/users/HirdayGupta/orgs","repos_url":"https://api.github.com/users/HirdayGupta/repos","events_url":"https://api.github.com/users/HirdayGupta/events{/privacy}","received_events_url":"https://api.github.com/users/HirdayGupta/received_events","type":"User","site_admin":false},"body":"Fixes #5980 \r\n\r\n**Outline of Solution**:\r\n\r\nin questionVisibilityOptions.tag, I modified some of the CSS stylings in order to include `alert alert-danger` in the CSS classes conditionally, if responses have been collected. Other changes are aesthetic.\r\n\r\n### Edit:\r\n\r\n**TODO:** \r\n- Update expected HTML using god mode (Will implement once design is finalized)\r\n- Implement a test to check if relevant CSS classes have been applied when instructor attempts to edit an FS which has responses. (Currently working on this)\r\n\r\n**Screenshot of proposed change:** \r\n\r\n<img width=\"1280\" alt=\"screen shot 2017-06-06 at 10 37 15 pm\" src=\"https://user-images.githubusercontent.com/18088721/26841954-cad28b68-4b08-11e7-82fa-99e3f72963c4.png\">\r\n\r\n**Requesting a review on the design**","created_at":"2017-06-06T07:48:47Z","updated_at":"2017-06-18T13:11:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d6b6d12cbfbad19645712b2a6d3545be038bdc3","assignee":{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars3.githubusercontent.com/u/6811428?v=3","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false},"assignees":[{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars3.githubusercontent.com/u/6811428?v=3","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7453/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/9de165843c7b872f22bb1317395dc8d46f07016f","head":{"label":"HirdayGupta:5980-warn-visibility-change-not-recommended-after-session-open","ref":"5980-warn-visibility-change-not-recommended-after-session-open","sha":"9de165843c7b872f22bb1317395dc8d46f07016f","user":{"login":"HirdayGupta","id":18088721,"avatar_url":"https://avatars1.githubusercontent.com/u/18088721?v=3","gravatar_id":"","url":"https://api.github.com/users/HirdayGupta","html_url":"https://github.com/HirdayGupta","followers_url":"https://api.github.com/users/HirdayGupta/followers","following_url":"https://api.github.com/users/HirdayGupta/following{/other_user}","gists_url":"https://api.github.com/users/HirdayGupta/gists{/gist_id}","starred_url":"https://api.github.com/users/HirdayGupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HirdayGupta/subscriptions","organizations_url":"https://api.github.com/users/HirdayGupta/orgs","repos_url":"https://api.github.com/users/HirdayGupta/repos","events_url":"https://api.github.com/users/HirdayGupta/events{/privacy}","received_events_url":"https://api.github.com/users/HirdayGupta/received_events","type":"User","site_admin":false},"repo":{"id":86348810,"name":"teammates","full_name":"HirdayGupta/teammates","owner":{"login":"HirdayGupta","id":18088721,"avatar_url":"https://avatars1.githubusercontent.com/u/18088721?v=3","gravatar_id":"","url":"https://api.github.com/users/HirdayGupta","html_url":"https://github.com/HirdayGupta","followers_url":"https://api.github.com/users/HirdayGupta/followers","following_url":"https://api.github.com/users/HirdayGupta/following{/other_user}","gists_url":"https://api.github.com/users/HirdayGupta/gists{/gist_id}","starred_url":"https://api.github.com/users/HirdayGupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HirdayGupta/subscriptions","organizations_url":"https://api.github.com/users/HirdayGupta/orgs","repos_url":"https://api.github.com/users/HirdayGupta/repos","events_url":"https://api.github.com/users/HirdayGupta/events{/privacy}","received_events_url":"https://api.github.com/users/HirdayGupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HirdayGupta/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/HirdayGupta/teammates","forks_url":"https://api.github.com/repos/HirdayGupta/teammates/forks","keys_url":"https://api.github.com/repos/HirdayGupta/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HirdayGupta/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HirdayGupta/teammates/teams","hooks_url":"https://api.github.com/repos/HirdayGupta/teammates/hooks","issue_events_url":"https://api.github.com/repos/HirdayGupta/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/HirdayGupta/teammates/events","assignees_url":"https://api.github.com/repos/HirdayGupta/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/HirdayGupta/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/HirdayGupta/teammates/tags","blobs_url":"https://api.github.com/repos/HirdayGupta/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HirdayGupta/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HirdayGupta/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/HirdayGupta/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HirdayGupta/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/HirdayGupta/teammates/languages","stargazers_url":"https://api.github.com/repos/HirdayGupta/teammates/stargazers","contributors_url":"https://api.github.com/repos/HirdayGupta/teammates/contributors","subscribers_url":"https://api.github.com/repos/HirdayGupta/teammates/subscribers","subscription_url":"https://api.github.com/repos/HirdayGupta/teammates/subscription","commits_url":"https://api.github.com/repos/HirdayGupta/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/HirdayGupta/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/HirdayGupta/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/HirdayGupta/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/HirdayGupta/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/HirdayGupta/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HirdayGupta/teammates/merges","archive_url":"https://api.github.com/repos/HirdayGupta/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HirdayGupta/teammates/downloads","issues_url":"https://api.github.com/repos/HirdayGupta/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/HirdayGupta/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/HirdayGupta/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/HirdayGupta/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HirdayGupta/teammates/labels{/name}","releases_url":"https://api.github.com/repos/HirdayGupta/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/HirdayGupta/teammates/deployments","created_at":"2017-03-27T14:58:06Z","updated_at":"2017-03-27T14:58:13Z","pushed_at":"2017-06-18T11:35:55Z","git_url":"git://github.com/HirdayGupta/teammates.git","ssh_url":"git@github.com:HirdayGupta/teammates.git","clone_url":"https://github.com/HirdayGupta/teammates.git","svn_url":"https://github.com/HirdayGupta/teammates","homepage":"http://teammatesv4.appspot.com/","size":186538,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"81bc6820c5c22503ee6dd60ea081cb89968fc265","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2017-06-16T18:46:15Z","pushed_at":"2017-06-18T13:05:40Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":186903,"stargazers_count":358,"watchers_count":358,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":815,"mirror_url":null,"open_issues_count":317,"forks":815,"open_issues":317,"watchers":358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7453"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7453"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7453/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7453/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/9de165843c7b872f22bb1317395dc8d46f07016f"}}}}
{"actor":{"display_login":"whipermr5"}}