{"action":"closed","number":265,"pull_request":{"url":"https://api.github.com/repos/bitinn/node-fetch/pulls/265","id":115645522,"html_url":"https://github.com/bitinn/node-fetch/pull/265","diff_url":"https://github.com/bitinn/node-fetch/pull/265.diff","patch_url":"https://github.com/bitinn/node-fetch/pull/265.patch","issue_url":"https://api.github.com/repos/bitinn/node-fetch/issues/265","number":265,"state":"closed","locked":false,"title":"expose url property on request object","user":{"login":"m59peacemaker","id":4369247,"avatar_url":"https://avatars3.githubusercontent.com/u/4369247?v=3","gravatar_id":"","url":"https://api.github.com/users/m59peacemaker","html_url":"https://github.com/m59peacemaker","followers_url":"https://api.github.com/users/m59peacemaker/followers","following_url":"https://api.github.com/users/m59peacemaker/following{/other_user}","gists_url":"https://api.github.com/users/m59peacemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/m59peacemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m59peacemaker/subscriptions","organizations_url":"https://api.github.com/users/m59peacemaker/orgs","repos_url":"https://api.github.com/users/m59peacemaker/repos","events_url":"https://api.github.com/users/m59peacemaker/events{/privacy}","received_events_url":"https://api.github.com/users/m59peacemaker/received_events","type":"User","site_admin":false},"body":"In browsers, the `url` property appears when iterating over the properties of an instance of Request. I think that is the proper behavior. `node-fetch` is currently accessing `url` with a getter, so it is hidden when iterating the properties or logging the object. I removed the getter, set `this.url` in the constructor, and added a test that `url` is exposed. All the tests continue to pass after my change with no additional changes needed. I'm unsure why it was a getter, as no tests depended on it being so.","created_at":"2017-04-12T22:03:13Z","updated_at":"2017-05-12T04:14:02Z","closed_at":"2017-05-12T04:14:02Z","merged_at":null,"merge_commit_sha":"106ed0eca797bdaf0d9cc5de39affa1a2c78fb33","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitinn/node-fetch/pulls/265/commits","review_comments_url":"https://api.github.com/repos/bitinn/node-fetch/pulls/265/comments","review_comment_url":"https://api.github.com/repos/bitinn/node-fetch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitinn/node-fetch/issues/265/comments","statuses_url":"https://api.github.com/repos/bitinn/node-fetch/statuses/ff8a04f7963c6c82773334f61bbd5b4f49e27d10","head":{"label":"m59peacemaker:expose-url","ref":"expose-url","sha":"ff8a04f7963c6c82773334f61bbd5b4f49e27d10","user":{"login":"m59peacemaker","id":4369247,"avatar_url":"https://avatars3.githubusercontent.com/u/4369247?v=3","gravatar_id":"","url":"https://api.github.com/users/m59peacemaker","html_url":"https://github.com/m59peacemaker","followers_url":"https://api.github.com/users/m59peacemaker/followers","following_url":"https://api.github.com/users/m59peacemaker/following{/other_user}","gists_url":"https://api.github.com/users/m59peacemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/m59peacemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m59peacemaker/subscriptions","organizations_url":"https://api.github.com/users/m59peacemaker/orgs","repos_url":"https://api.github.com/users/m59peacemaker/repos","events_url":"https://api.github.com/users/m59peacemaker/events{/privacy}","received_events_url":"https://api.github.com/users/m59peacemaker/received_events","type":"User","site_admin":false},"repo":{"id":87730530,"name":"node-fetch","full_name":"m59peacemaker/node-fetch","owner":{"login":"m59peacemaker","id":4369247,"avatar_url":"https://avatars3.githubusercontent.com/u/4369247?v=3","gravatar_id":"","url":"https://api.github.com/users/m59peacemaker","html_url":"https://github.com/m59peacemaker","followers_url":"https://api.github.com/users/m59peacemaker/followers","following_url":"https://api.github.com/users/m59peacemaker/following{/other_user}","gists_url":"https://api.github.com/users/m59peacemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/m59peacemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m59peacemaker/subscriptions","organizations_url":"https://api.github.com/users/m59peacemaker/orgs","repos_url":"https://api.github.com/users/m59peacemaker/repos","events_url":"https://api.github.com/users/m59peacemaker/events{/privacy}","received_events_url":"https://api.github.com/users/m59peacemaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m59peacemaker/node-fetch","description":"A light-weight module that brings window.fetch to Node.js","fork":true,"url":"https://api.github.com/repos/m59peacemaker/node-fetch","forks_url":"https://api.github.com/repos/m59peacemaker/node-fetch/forks","keys_url":"https://api.github.com/repos/m59peacemaker/node-fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m59peacemaker/node-fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m59peacemaker/node-fetch/teams","hooks_url":"https://api.github.com/repos/m59peacemaker/node-fetch/hooks","issue_events_url":"https://api.github.com/repos/m59peacemaker/node-fetch/issues/events{/number}","events_url":"https://api.github.com/repos/m59peacemaker/node-fetch/events","assignees_url":"https://api.github.com/repos/m59peacemaker/node-fetch/assignees{/user}","branches_url":"https://api.github.com/repos/m59peacemaker/node-fetch/branches{/branch}","tags_url":"https://api.github.com/repos/m59peacemaker/node-fetch/tags","blobs_url":"https://api.github.com/repos/m59peacemaker/node-fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m59peacemaker/node-fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m59peacemaker/node-fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/m59peacemaker/node-fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m59peacemaker/node-fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/m59peacemaker/node-fetch/languages","stargazers_url":"https://api.github.com/repos/m59peacemaker/node-fetch/stargazers","contributors_url":"https://api.github.com/repos/m59peacemaker/node-fetch/contributors","subscribers_url":"https://api.github.com/repos/m59peacemaker/node-fetch/subscribers","subscription_url":"https://api.github.com/repos/m59peacemaker/node-fetch/subscription","commits_url":"https://api.github.com/repos/m59peacemaker/node-fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/m59peacemaker/node-fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/m59peacemaker/node-fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/m59peacemaker/node-fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/m59peacemaker/node-fetch/contents/{+path}","compare_url":"https://api.github.com/repos/m59peacemaker/node-fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m59peacemaker/node-fetch/merges","archive_url":"https://api.github.com/repos/m59peacemaker/node-fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m59peacemaker/node-fetch/downloads","issues_url":"https://api.github.com/repos/m59peacemaker/node-fetch/issues{/number}","pulls_url":"https://api.github.com/repos/m59peacemaker/node-fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/m59peacemaker/node-fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/m59peacemaker/node-fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m59peacemaker/node-fetch/labels{/name}","releases_url":"https://api.github.com/repos/m59peacemaker/node-fetch/releases{/id}","deployments_url":"https://api.github.com/repos/m59peacemaker/node-fetch/deployments","created_at":"2017-04-09T18:36:02Z","updated_at":"2017-04-09T18:36:04Z","pushed_at":"2017-04-18T14:13:21Z","git_url":"git://github.com/m59peacemaker/node-fetch.git","ssh_url":"git@github.com:m59peacemaker/node-fetch.git","clone_url":"https://github.com/m59peacemaker/node-fetch.git","svn_url":"https://github.com/m59peacemaker/node-fetch","homepage":"","size":343,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitinn:master","ref":"master","sha":"e5ff203ef41186954b5eea1ddc3b3b0c31c23593","user":{"login":"bitinn","id":1484279,"avatar_url":"https://avatars0.githubusercontent.com/u/1484279?v=3","gravatar_id":"","url":"https://api.github.com/users/bitinn","html_url":"https://github.com/bitinn","followers_url":"https://api.github.com/users/bitinn/followers","following_url":"https://api.github.com/users/bitinn/following{/other_user}","gists_url":"https://api.github.com/users/bitinn/gists{/gist_id}","starred_url":"https://api.github.com/users/bitinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitinn/subscriptions","organizations_url":"https://api.github.com/users/bitinn/orgs","repos_url":"https://api.github.com/users/bitinn/repos","events_url":"https://api.github.com/users/bitinn/events{/privacy}","received_events_url":"https://api.github.com/users/bitinn/received_events","type":"User","site_admin":false},"repo":{"id":29849956,"name":"node-fetch","full_name":"bitinn/node-fetch","owner":{"login":"bitinn","id":1484279,"avatar_url":"https://avatars0.githubusercontent.com/u/1484279?v=3","gravatar_id":"","url":"https://api.github.com/users/bitinn","html_url":"https://github.com/bitinn","followers_url":"https://api.github.com/users/bitinn/followers","following_url":"https://api.github.com/users/bitinn/following{/other_user}","gists_url":"https://api.github.com/users/bitinn/gists{/gist_id}","starred_url":"https://api.github.com/users/bitinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitinn/subscriptions","organizations_url":"https://api.github.com/users/bitinn/orgs","repos_url":"https://api.github.com/users/bitinn/repos","events_url":"https://api.github.com/users/bitinn/events{/privacy}","received_events_url":"https://api.github.com/users/bitinn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitinn/node-fetch","description":"A light-weight module that brings window.fetch to Node.js","fork":false,"url":"https://api.github.com/repos/bitinn/node-fetch","forks_url":"https://api.github.com/repos/bitinn/node-fetch/forks","keys_url":"https://api.github.com/repos/bitinn/node-fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitinn/node-fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitinn/node-fetch/teams","hooks_url":"https://api.github.com/repos/bitinn/node-fetch/hooks","issue_events_url":"https://api.github.com/repos/bitinn/node-fetch/issues/events{/number}","events_url":"https://api.github.com/repos/bitinn/node-fetch/events","assignees_url":"https://api.github.com/repos/bitinn/node-fetch/assignees{/user}","branches_url":"https://api.github.com/repos/bitinn/node-fetch/branches{/branch}","tags_url":"https://api.github.com/repos/bitinn/node-fetch/tags","blobs_url":"https://api.github.com/repos/bitinn/node-fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitinn/node-fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitinn/node-fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitinn/node-fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitinn/node-fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/bitinn/node-fetch/languages","stargazers_url":"https://api.github.com/repos/bitinn/node-fetch/stargazers","contributors_url":"https://api.github.com/repos/bitinn/node-fetch/contributors","subscribers_url":"https://api.github.com/repos/bitinn/node-fetch/subscribers","subscription_url":"https://api.github.com/repos/bitinn/node-fetch/subscription","commits_url":"https://api.github.com/repos/bitinn/node-fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitinn/node-fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitinn/node-fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitinn/node-fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitinn/node-fetch/contents/{+path}","compare_url":"https://api.github.com/repos/bitinn/node-fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitinn/node-fetch/merges","archive_url":"https://api.github.com/repos/bitinn/node-fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitinn/node-fetch/downloads","issues_url":"https://api.github.com/repos/bitinn/node-fetch/issues{/number}","pulls_url":"https://api.github.com/repos/bitinn/node-fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/bitinn/node-fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/bitinn/node-fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitinn/node-fetch/labels{/name}","releases_url":"https://api.github.com/repos/bitinn/node-fetch/releases{/id}","deployments_url":"https://api.github.com/repos/bitinn/node-fetch/deployments","created_at":"2015-01-26T07:29:26Z","updated_at":"2017-05-11T20:11:01Z","pushed_at":"2017-05-12T04:09:05Z","git_url":"git://github.com/bitinn/node-fetch.git","ssh_url":"git@github.com:bitinn/node-fetch.git","clone_url":"https://github.com/bitinn/node-fetch.git","svn_url":"https://github.com/bitinn/node-fetch","homepage":"","size":307,"stargazers_count":1692,"watchers_count":1692,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":23,"forks":179,"open_issues":23,"watchers":1692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/265"},"html":{"href":"https://github.com/bitinn/node-fetch/pull/265"},"issue":{"href":"https://api.github.com/repos/bitinn/node-fetch/issues/265"},"comments":{"href":"https://api.github.com/repos/bitinn/node-fetch/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitinn/node-fetch/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/bitinn/node-fetch/statuses/ff8a04f7963c6c82773334f61bbd5b4f49e27d10"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"bitinn"}}