{"action":"created","comment":{"url":"https://api.github.com/repos/ionic-team/ionic/pulls/comments/121318266","pull_request_review_id":43355633,"id":121318266,"diff_hunk":"@@ -0,0 +1,28 @@\n+import { Component, Input, ViewEncapsulation, HostBinding } from '@angular/core';\n+\n+@Component({\n+  selector: 'ion-progress',\n+  templateUrl : './progress.html',\n+  encapsulation: ViewEncapsulation.None\n+})\n+export class Progress {\n+\n+  constructor( ) { }\n+\n+  /**\n+   * @input {'determinate' | 'indeterminate' | 'buffer' | 'query'} The current mode of the progress indicator\n+   */\n+  @Input()\n+  @HostBinding('class')","path":"src/components/progress/progress.ts","position":16,"original_position":16,"commit_id":"624f751643d8142db6223480866cccf65edbd429","original_commit_id":"624f751643d8142db6223480866cccf65edbd429","user":{"login":"realappie","id":10495548,"avatar_url":"https://avatars1.githubusercontent.com/u/10495548?v=3","gravatar_id":"","url":"https://api.github.com/users/realappie","html_url":"https://github.com/realappie","followers_url":"https://api.github.com/users/realappie/followers","following_url":"https://api.github.com/users/realappie/following{/other_user}","gists_url":"https://api.github.com/users/realappie/gists{/gist_id}","starred_url":"https://api.github.com/users/realappie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realappie/subscriptions","organizations_url":"https://api.github.com/users/realappie/orgs","repos_url":"https://api.github.com/users/realappie/repos","events_url":"https://api.github.com/users/realappie/events{/privacy}","received_events_url":"https://api.github.com/users/realappie/received_events","type":"User","site_admin":false},"body":"According to the angular docs its best to use `Hostbinding` in contrast with host. But if you would like me to use `host` instead, I have no problem in doing so.","created_at":"2017-06-12T06:36:18Z","updated_at":"2017-06-12T06:36:18Z","html_url":"https://github.com/ionic-team/ionic/pull/12010#discussion_r121318266","pull_request_url":"https://api.github.com/repos/ionic-team/ionic/pulls/12010","_links":{"self":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/comments/121318266"},"html":{"href":"https://github.com/ionic-team/ionic/pull/12010#discussion_r121318266"},"pull_request":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/12010"}}},"pull_request":{"url":"https://api.github.com/repos/ionic-team/ionic/pulls/12010","id":125035314,"html_url":"https://github.com/ionic-team/ionic/pull/12010","diff_url":"https://github.com/ionic-team/ionic/pull/12010.diff","patch_url":"https://github.com/ionic-team/ionic/pull/12010.patch","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/12010","number":12010,"state":"open","locked":false,"title":"feat(progress): adds progress bar","user":{"login":"realappie","id":10495548,"avatar_url":"https://avatars1.githubusercontent.com/u/10495548?v=3","gravatar_id":"","url":"https://api.github.com/users/realappie","html_url":"https://github.com/realappie","followers_url":"https://api.github.com/users/realappie/followers","following_url":"https://api.github.com/users/realappie/following{/other_user}","gists_url":"https://api.github.com/users/realappie/gists{/gist_id}","starred_url":"https://api.github.com/users/realappie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realappie/subscriptions","organizations_url":"https://api.github.com/users/realappie/orgs","repos_url":"https://api.github.com/users/realappie/repos","events_url":"https://api.github.com/users/realappie/events{/privacy}","received_events_url":"https://api.github.com/users/realappie/received_events","type":"User","site_admin":false},"body":"#### Short description of what this resolves:\r\n\r\nThis resolves #6669 \r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- Add progress bars with determinate, indeterminate, buffer and query as available modes\r\n- Theming options for the progress bar\r\n- RTL support\r\n\r\n![](https://i.gyazo.com/b576ceb24065d67340ae28f7697b44e7.gif)\r\nRTL version\r\n![](https://i.gyazo.com/ea2ce3ef1eb05da3baa8c73551e27ac9.gif)\r\n\r\nThis PR has some SCSS linting errors, I hope @brandyscarney can help out here :) \r\n\r\n**Ionic Version**: 2.x\r\n\r\n","created_at":"2017-06-11T18:27:49Z","updated_at":"2017-06-12T06:36:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90257386bd85b04e59fa2078d345f05b32039785","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ionic-team/ionic/pulls/12010/commits","review_comments_url":"https://api.github.com/repos/ionic-team/ionic/pulls/12010/comments","review_comment_url":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/12010/comments","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/624f751643d8142db6223480866cccf65edbd429","head":{"label":"realappie:feature/progress-bar","ref":"feature/progress-bar","sha":"624f751643d8142db6223480866cccf65edbd429","user":{"login":"realappie","id":10495548,"avatar_url":"https://avatars1.githubusercontent.com/u/10495548?v=3","gravatar_id":"","url":"https://api.github.com/users/realappie","html_url":"https://github.com/realappie","followers_url":"https://api.github.com/users/realappie/followers","following_url":"https://api.github.com/users/realappie/following{/other_user}","gists_url":"https://api.github.com/users/realappie/gists{/gist_id}","starred_url":"https://api.github.com/users/realappie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realappie/subscriptions","organizations_url":"https://api.github.com/users/realappie/orgs","repos_url":"https://api.github.com/users/realappie/repos","events_url":"https://api.github.com/users/realappie/events{/privacy}","received_events_url":"https://api.github.com/users/realappie/received_events","type":"User","site_admin":false},"repo":{"id":94022050,"name":"ionic","full_name":"realappie/ionic","owner":{"login":"realappie","id":10495548,"avatar_url":"https://avatars1.githubusercontent.com/u/10495548?v=3","gravatar_id":"","url":"https://api.github.com/users/realappie","html_url":"https://github.com/realappie","followers_url":"https://api.github.com/users/realappie/followers","following_url":"https://api.github.com/users/realappie/following{/other_user}","gists_url":"https://api.github.com/users/realappie/gists{/gist_id}","starred_url":"https://api.github.com/users/realappie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realappie/subscriptions","organizations_url":"https://api.github.com/users/realappie/orgs","repos_url":"https://api.github.com/users/realappie/repos","events_url":"https://api.github.com/users/realappie/events{/privacy}","received_events_url":"https://api.github.com/users/realappie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/realappie/ionic","description":"Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉","fork":true,"url":"https://api.github.com/repos/realappie/ionic","forks_url":"https://api.github.com/repos/realappie/ionic/forks","keys_url":"https://api.github.com/repos/realappie/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realappie/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realappie/ionic/teams","hooks_url":"https://api.github.com/repos/realappie/ionic/hooks","issue_events_url":"https://api.github.com/repos/realappie/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/realappie/ionic/events","assignees_url":"https://api.github.com/repos/realappie/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/realappie/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/realappie/ionic/tags","blobs_url":"https://api.github.com/repos/realappie/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realappie/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realappie/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/realappie/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realappie/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/realappie/ionic/languages","stargazers_url":"https://api.github.com/repos/realappie/ionic/stargazers","contributors_url":"https://api.github.com/repos/realappie/ionic/contributors","subscribers_url":"https://api.github.com/repos/realappie/ionic/subscribers","subscription_url":"https://api.github.com/repos/realappie/ionic/subscription","commits_url":"https://api.github.com/repos/realappie/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/realappie/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/realappie/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/realappie/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/realappie/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/realappie/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realappie/ionic/merges","archive_url":"https://api.github.com/repos/realappie/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realappie/ionic/downloads","issues_url":"https://api.github.com/repos/realappie/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/realappie/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/realappie/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/realappie/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realappie/ionic/labels{/name}","releases_url":"https://api.github.com/repos/realappie/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/realappie/ionic/deployments","created_at":"2017-06-11T17:54:01Z","updated_at":"2017-06-11T17:54:09Z","pushed_at":"2017-06-11T17:55:50Z","git_url":"git://github.com/realappie/ionic.git","ssh_url":"git@github.com:realappie/ionic.git","clone_url":"https://github.com/realappie/ionic.git","svn_url":"https://github.com/realappie/ionic","homepage":"https://ionicframework.com/","size":72387,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ionic-team:master","ref":"master","sha":"d0847aabdb27bf76331e2c0947b4375b7b2b902d","user":{"login":"ionic-team","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"name":"ionic","full_name":"ionic-team/ionic","owner":{"login":"ionic-team","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ionic-team/ionic","description":"Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/ionic-team/ionic","forks_url":"https://api.github.com/repos/ionic-team/ionic/forks","keys_url":"https://api.github.com/repos/ionic-team/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ionic-team/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ionic-team/ionic/teams","hooks_url":"https://api.github.com/repos/ionic-team/ionic/hooks","issue_events_url":"https://api.github.com/repos/ionic-team/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/ionic-team/ionic/events","assignees_url":"https://api.github.com/repos/ionic-team/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/ionic-team/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/ionic-team/ionic/tags","blobs_url":"https://api.github.com/repos/ionic-team/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ionic-team/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ionic-team/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ionic-team/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ionic-team/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/ionic-team/ionic/languages","stargazers_url":"https://api.github.com/repos/ionic-team/ionic/stargazers","contributors_url":"https://api.github.com/repos/ionic-team/ionic/contributors","subscribers_url":"https://api.github.com/repos/ionic-team/ionic/subscribers","subscription_url":"https://api.github.com/repos/ionic-team/ionic/subscription","commits_url":"https://api.github.com/repos/ionic-team/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ionic-team/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ionic-team/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ionic-team/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ionic-team/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/ionic-team/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ionic-team/ionic/merges","archive_url":"https://api.github.com/repos/ionic-team/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ionic-team/ionic/downloads","issues_url":"https://api.github.com/repos/ionic-team/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/ionic-team/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/ionic-team/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/ionic-team/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ionic-team/ionic/labels{/name}","releases_url":"https://api.github.com/repos/ionic-team/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/ionic-team/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2017-06-12T05:23:18Z","pushed_at":"2017-06-11T18:27:50Z","git_url":"git://github.com/ionic-team/ionic.git","ssh_url":"git@github.com:ionic-team/ionic.git","clone_url":"https://github.com/ionic-team/ionic.git","svn_url":"https://github.com/ionic-team/ionic","homepage":"https://ionicframework.com/","size":72383,"stargazers_count":29945,"watchers_count":29945,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7908,"mirror_url":null,"open_issues_count":775,"forks":7908,"open_issues":775,"watchers":29945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/12010"},"html":{"href":"https://github.com/ionic-team/ionic/pull/12010"},"issue":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/12010"},"comments":{"href":"https://api.github.com/repos/ionic-team/ionic/issues/12010/comments"},"review_comments":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/12010/comments"},"review_comment":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ionic-team/ionic/pulls/12010/commits"},"statuses":{"href":"https://api.github.com/repos/ionic-team/ionic/statuses/624f751643d8142db6223480866cccf65edbd429"}}}}
{"actor":{"display_login":"realappie"}}