{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-python/pulls/comments/114948303","pull_request_review_id":36452309,"id":114948303,"diff_hunk":"@@ -20,40 +20,28 @@\n package org.sonar.python.checks;\n \n import org.junit.Test;\n-import org.sonar.python.PythonAstScanner;\n-import org.sonar.squidbridge.api.SourceFile;\n-import org.sonar.squidbridge.checks.CheckMessagesVerifier;\n+import org.sonar.python.checks.utils.PythonCheckVerifier;\n \n public class MissingNewlineAtEndOfFileCheckTest {\n \n   @Test\n   public void missing_new_line() {\n-    SourceFile file = PythonAstScanner.scanSingleFile(\"src/test/resources/checks/missingNewlineAtEndOfFile1.py\", new MissingNewlineAtEndOfFileCheck());\n-    CheckMessagesVerifier.verify(file.getCheckMessages())\n-        .next().withMessage(String.format(MissingNewlineAtEndOfFileCheck.MESSAGE, \"missingNewlineAtEndOfFile1.py\"))\n-        .noMore();\n+    PythonCheckVerifier.verify(\"src/test/resources/checks/missingNewlineAtEndOfFile1.py\", new MissingNewlineAtEndOfFileCheck());","path":"python-checks/src/test/java/org/sonar/python/checks/MissingNewlineAtEndOfFileCheckTest.java","position":17,"original_position":17,"commit_id":"b8123abee8fa17bd4ed16ff8239d3e43f09da682","original_commit_id":"b13c302b84b5f7c8d5b4fababd5967c507d78626","user":{"login":"ivandalbosco","id":19170614,"avatar_url":"https://avatars1.githubusercontent.com/u/19170614?v=3","gravatar_id":"","url":"https://api.github.com/users/ivandalbosco","html_url":"https://github.com/ivandalbosco","followers_url":"https://api.github.com/users/ivandalbosco/followers","following_url":"https://api.github.com/users/ivandalbosco/following{/other_user}","gists_url":"https://api.github.com/users/ivandalbosco/gists{/gist_id}","starred_url":"https://api.github.com/users/ivandalbosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivandalbosco/subscriptions","organizations_url":"https://api.github.com/users/ivandalbosco/orgs","repos_url":"https://api.github.com/users/ivandalbosco/repos","events_url":"https://api.github.com/users/ivandalbosco/events{/privacy}","received_events_url":"https://api.github.com/users/ivandalbosco/received_events","type":"User","site_admin":false},"body":"@pynicolas You're right, unless it is static. Anyway, not truly relevant for this very rule, since it has no state.","created_at":"2017-05-05T08:10:28Z","updated_at":"2017-05-05T08:10:28Z","html_url":"https://github.com/SonarSource/sonar-python/pull/88#discussion_r114948303","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-python/pulls/comments/114948303"},"html":{"href":"https://github.com/SonarSource/sonar-python/pull/88#discussion_r114948303"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88","id":117481243,"html_url":"https://github.com/SonarSource/sonar-python/pull/88","diff_url":"https://github.com/SonarSource/sonar-python/pull/88.diff","patch_url":"https://github.com/SonarSource/sonar-python/pull/88.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-python/issues/88","number":88,"state":"open","locked":false,"title":"SONARPY-201 Use InputFile API to read source files","user":{"login":"pynicolas","id":6371790,"avatar_url":"https://avatars1.githubusercontent.com/u/6371790?v=3","gravatar_id":"","url":"https://api.github.com/users/pynicolas","html_url":"https://github.com/pynicolas","followers_url":"https://api.github.com/users/pynicolas/followers","following_url":"https://api.github.com/users/pynicolas/following{/other_user}","gists_url":"https://api.github.com/users/pynicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/pynicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynicolas/subscriptions","organizations_url":"https://api.github.com/users/pynicolas/orgs","repos_url":"https://api.github.com/users/pynicolas/repos","events_url":"https://api.github.com/users/pynicolas/events{/privacy}","received_events_url":"https://api.github.com/users/pynicolas/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-25T13:14:26Z","updated_at":"2017-05-05T08:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f0cfaea578003e40d080b8d5ed01728dae20728","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-python/issues/88/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-python/statuses/b8123abee8fa17bd4ed16ff8239d3e43f09da682","head":{"label":"SonarSource:SONARPY-201","ref":"SONARPY-201","sha":"b8123abee8fa17bd4ed16ff8239d3e43f09da682","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars3.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4810329,"name":"sonar-python","full_name":"SonarSource/sonar-python","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars3.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-python","description":":snake: SonarQube Python plugin","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-python","forks_url":"https://api.github.com/repos/SonarSource/sonar-python/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-python/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-python/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-python/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-python/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-python/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-python/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-python/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-python/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-python/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-python/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-python/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-python/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-python/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-python/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-python/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-python/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-python/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-python/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-python/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-python/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-python/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-python/deployments","created_at":"2012-06-27T15:50:36Z","updated_at":"2017-05-03T22:13:17Z","pushed_at":"2017-05-04T15:22:29Z","git_url":"git://github.com/SonarSource/sonar-python.git","ssh_url":"git@github.com:SonarSource/sonar-python.git","clone_url":"https://github.com/SonarSource/sonar-python.git","svn_url":"https://github.com/SonarSource/sonar-python","homepage":"http://docs.codehaus.org/display/SONAR/Python+Plugin","size":1982,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":5,"forks":28,"open_issues":5,"watchers":34,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"69371ef2710b885544976ce5b8379883408dc9ae","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars3.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4810329,"name":"sonar-python","full_name":"SonarSource/sonar-python","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars3.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-python","description":":snake: SonarQube Python plugin","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-python","forks_url":"https://api.github.com/repos/SonarSource/sonar-python/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-python/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-python/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-python/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-python/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-python/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-python/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-python/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-python/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-python/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-python/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-python/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-python/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-python/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-python/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-python/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-python/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-python/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-python/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-python/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-python/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-python/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-python/deployments","created_at":"2012-06-27T15:50:36Z","updated_at":"2017-05-03T22:13:17Z","pushed_at":"2017-05-04T15:22:29Z","git_url":"git://github.com/SonarSource/sonar-python.git","ssh_url":"git@github.com:SonarSource/sonar-python.git","clone_url":"https://github.com/SonarSource/sonar-python.git","svn_url":"https://github.com/SonarSource/sonar-python","homepage":"http://docs.codehaus.org/display/SONAR/Python+Plugin","size":1982,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":5,"forks":28,"open_issues":5,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88"},"html":{"href":"https://github.com/SonarSource/sonar-python/pull/88"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-python/issues/88"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-python/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-python/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-python/statuses/b8123abee8fa17bd4ed16ff8239d3e43f09da682"}}}}
{"actor":{"display_login":"ivandalbosco"}}