{"action":"opened","issue":{"url":"https://api.github.com/repos/go-gomail/gomail/issues/87","repository_url":"https://api.github.com/repos/go-gomail/gomail","labels_url":"https://api.github.com/repos/go-gomail/gomail/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/go-gomail/gomail/issues/87/comments","events_url":"https://api.github.com/repos/go-gomail/gomail/issues/87/events","html_url":"https://github.com/go-gomail/gomail/issues/87","id":235230789,"number":87,"title":"Embedding a lot of images","user":{"login":"suntong","id":422244,"avatar_url":"https://avatars2.githubusercontent.com/u/422244?v=3","gravatar_id":"","url":"https://api.github.com/users/suntong","html_url":"https://github.com/suntong","followers_url":"https://api.github.com/users/suntong/followers","following_url":"https://api.github.com/users/suntong/following{/other_user}","gists_url":"https://api.github.com/users/suntong/gists{/gist_id}","starred_url":"https://api.github.com/users/suntong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suntong/subscriptions","organizations_url":"https://api.github.com/users/suntong/orgs","repos_url":"https://api.github.com/users/suntong/repos","events_url":"https://api.github.com/users/suntong/events{/privacy}","received_events_url":"https://api.github.com/users/suntong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-12T13:23:21Z","updated_at":"2017-06-12T13:23:21Z","closed_at":null,"body":"Can gomail supports embedding a lot of images?\r\n\r\nFrom\r\nhttps://godoc.org/gopkg.in/gomail.v2#Message.Embed\r\n\r\nit seems that gomail only support embedding one image.   \r\nTo embed a lot of them, there are still lots of extra manual works to make it works, i.e., you have to specify where shall those emails appear, _both_ in the Text portion and the HTML portion. But all these can be dealt with grammatically, to free people from such tedious manual work. \r\n\r\nI'm proposing, \r\n\r\n`func (m *Message) Embed(filename ...string) string string\r\n`\r\n\r\nthe two string returns are Text and HTML content for such embeds the images. For e.g., for single image, \r\n\r\n```\r\nText: image1.jpg\r\nHTML: <img src=\"cid:image1.jpg\" alt=\"image1\" />\r\n```\r\n\r\nso on and so forth. \r\n\r\nWould that be OK? If I submit a patch, would it be accepted? "}}
{"actor":{"display_login":"suntong"}}