{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments/144044901","pull_request_review_id":68646214,"id":144044901,"diff_hunk":"@@ -53,20 +46,37 @@ export default class OfflineIndicator extends PureComponent {\n     }\n \n     componentWillReceiveProps(nextProps) {\n-        const {appState, isConnecting, isOnline, webSocketStatus} = nextProps;\n-        if (appState) { // The app is in the foreground\n-            if (isOnline) {\n-                if (this.state.network && webSocketStatus === RequestStatus.SUCCESS) {\n-                    // Show the connected animation only if we had a previous network status\n-                    this.connected();\n-                } else if ((webSocketStatus === RequestStatus.STARTED || webSocketStatus === RequestStatus.FAILURE) && isConnecting) {\n-                    // Show the connecting bar if it failed to connect at least twice\n-                    this.connecting();\n-                }\n-            } else {\n-                this.offline();\n+        const {isConnecting, isOnline, webSocketStatus} = nextProps;\n+        if (isOnline) {\n+            if (this.state.network && this.props.webSocketStatus === RequestStatus.STARTED && webSocketStatus === RequestStatus.SUCCESS) {\n+                // Show the connected animation only if we had a previous network status\n+                this.connected();","path":"app/components/offline_indicator/offline_indicator.js","position":58,"original_position":58,"commit_id":"63f594f91b50b8ce2ed4a60d733581a265c916c7","original_commit_id":"63f594f91b50b8ce2ed4a60d733581a265c916c7","user":{"login":"enahum","id":6757047,"avatar_url":"https://avatars1.githubusercontent.com/u/6757047?v=4","gravatar_id":"","url":"https://api.github.com/users/enahum","html_url":"https://github.com/enahum","followers_url":"https://api.github.com/users/enahum/followers","following_url":"https://api.github.com/users/enahum/following{/other_user}","gists_url":"https://api.github.com/users/enahum/gists{/gist_id}","starred_url":"https://api.github.com/users/enahum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enahum/subscriptions","organizations_url":"https://api.github.com/users/enahum/orgs","repos_url":"https://api.github.com/users/enahum/repos","events_url":"https://api.github.com/users/enahum/events{/privacy}","received_events_url":"https://api.github.com/users/enahum/received_events","type":"User","site_admin":false},"body":"are you sure? I'll give it a try to see if that works","created_at":"2017-10-11T15:17:45Z","updated_at":"2017-10-11T15:17:45Z","html_url":"https://github.com/mattermost/mattermost-mobile/pull/1010#discussion_r144044901","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments/144044901"},"html":{"href":"https://github.com/mattermost/mattermost-mobile/pull/1010#discussion_r144044901"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010"}},"in_reply_to_id":144035711},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010","id":145940202,"html_url":"https://github.com/mattermost/mattermost-mobile/pull/1010","diff_url":"https://github.com/mattermost/mattermost-mobile/pull/1010.diff","patch_url":"https://github.com/mattermost/mattermost-mobile/pull/1010.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1010","number":1010,"state":"open","locked":false,"title":"Improving Performance Part 2","user":{"login":"enahum","id":6757047,"avatar_url":"https://avatars1.githubusercontent.com/u/6757047?v=4","gravatar_id":"","url":"https://api.github.com/users/enahum","html_url":"https://github.com/enahum","followers_url":"https://api.github.com/users/enahum/followers","following_url":"https://api.github.com/users/enahum/following{/other_user}","gists_url":"https://api.github.com/users/enahum/gists{/gist_id}","starred_url":"https://api.github.com/users/enahum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enahum/subscriptions","organizations_url":"https://api.github.com/users/enahum/orgs","repos_url":"https://api.github.com/users/enahum/repos","events_url":"https://api.github.com/users/enahum/events{/privacy}","received_events_url":"https://api.github.com/users/enahum/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nThis is part 2 of a series of 3 PR's to improve performance\r\nIncluded in this PR:\r\n* Removed the verification of the serverVersion no longer needed to show GitLab login option\r\n* Avoid unnecessary re-renders of the root screen\r\n* Avoid unnecessary re-renders of the options modal screen\r\n* Avoid unnecessary re-renders of the thread screen\r\n* Avoid unnecessary re-renders of the offline indicator component\r\n* Avoid unnecessary re-renders of the channel loader component","created_at":"2017-10-11T12:51:14Z","updated_at":"2017-10-11T15:17:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"641987acc294117d05105b74c942f313026d83af","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jarredwitt","id":5090577,"avatar_url":"https://avatars1.githubusercontent.com/u/5090577?v=4","gravatar_id":"","url":"https://api.github.com/users/jarredwitt","html_url":"https://github.com/jarredwitt","followers_url":"https://api.github.com/users/jarredwitt/followers","following_url":"https://api.github.com/users/jarredwitt/following{/other_user}","gists_url":"https://api.github.com/users/jarredwitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jarredwitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarredwitt/subscriptions","organizations_url":"https://api.github.com/users/jarredwitt/orgs","repos_url":"https://api.github.com/users/jarredwitt/repos","events_url":"https://api.github.com/users/jarredwitt/events{/privacy}","received_events_url":"https://api.github.com/users/jarredwitt/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/4","html_url":"https://github.com/mattermost/mattermost-mobile/milestone/4","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/4/labels","id":2821691,"number":4,"title":"1.4","description":"","creator":{"login":"enahum","id":6757047,"avatar_url":"https://avatars1.githubusercontent.com/u/6757047?v=4","gravatar_id":"","url":"https://api.github.com/users/enahum","html_url":"https://github.com/enahum","followers_url":"https://api.github.com/users/enahum/followers","following_url":"https://api.github.com/users/enahum/following{/other_user}","gists_url":"https://api.github.com/users/enahum/gists{/gist_id}","starred_url":"https://api.github.com/users/enahum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enahum/subscriptions","organizations_url":"https://api.github.com/users/enahum/orgs","repos_url":"https://api.github.com/users/enahum/repos","events_url":"https://api.github.com/users/enahum/events{/privacy}","received_events_url":"https://api.github.com/users/enahum/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2017-10-07T15:08:13Z","updated_at":"2017-10-11T13:35:47Z","due_on":"2017-11-03T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1010/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/63f594f91b50b8ce2ed4a60d733581a265c916c7","head":{"label":"mattermost:performance-2","ref":"performance-2","sha":"63f594f91b50b8ce2ed4a60d733581a265c916c7","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":70265724,"name":"mattermost-mobile","full_name":"mattermost/mattermost-mobile","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-mobile","description":"Next generation iOS and Android apps for Mattermost in React Native","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-mobile","forks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/deployments","created_at":"2016-10-07T16:52:32Z","updated_at":"2017-10-11T03:26:09Z","pushed_at":"2017-10-11T14:00:15Z","git_url":"git://github.com/mattermost/mattermost-mobile.git","ssh_url":"git@github.com:mattermost/mattermost-mobile.git","clone_url":"https://github.com/mattermost/mattermost-mobile.git","svn_url":"https://github.com/mattermost/mattermost-mobile","homepage":"https://about.mattermost.com/","size":8879,"stargazers_count":242,"watchers_count":242,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":38,"forks":68,"open_issues":38,"watchers":242,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"5bfe97b1f233b1c2f20144070b36ccf1fab7972c","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":70265724,"name":"mattermost-mobile","full_name":"mattermost/mattermost-mobile","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-mobile","description":"Next generation iOS and Android apps for Mattermost in React Native","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-mobile","forks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/deployments","created_at":"2016-10-07T16:52:32Z","updated_at":"2017-10-11T03:26:09Z","pushed_at":"2017-10-11T14:00:15Z","git_url":"git://github.com/mattermost/mattermost-mobile.git","ssh_url":"git@github.com:mattermost/mattermost-mobile.git","clone_url":"https://github.com/mattermost/mattermost-mobile.git","svn_url":"https://github.com/mattermost/mattermost-mobile","homepage":"https://about.mattermost.com/","size":8879,"stargazers_count":242,"watchers_count":242,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":38,"forks":68,"open_issues":38,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010"},"html":{"href":"https://github.com/mattermost/mattermost-mobile/pull/1010"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1010"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/63f594f91b50b8ce2ed4a60d733581a265c916c7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"enahum"}}