{"action":"created","issue":{"url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2454","repository_url":"https://api.github.com/repos/linuxkit/linuxkit","labels_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2454/labels{/name}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2454/comments","events_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2454/events","html_url":"https://github.com/linuxkit/linuxkit/pull/2454","id":252158207,"number":2454,"title":"tools: Support iso-efi generation for both arm64 and amd64","user":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"labels":[{"id":572728714,"url":"https://api.github.com/repos/linuxkit/linuxkit/labels/status/0-triage","name":"status/0-triage","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2017-08-23T04:44:13Z","updated_at":"2017-08-24T09:27:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2454","html_url":"https://github.com/linuxkit/linuxkit/pull/2454","diff_url":"https://github.com/linuxkit/linuxkit/pull/2454.diff","patch_url":"https://github.com/linuxkit/linuxkit/pull/2454.patch"},"body":"This patch uses coreos grub2 instead of the built-in gummiboot\r\ntool with Alpine distribution.\r\n\r\nCoreos grub2 has the security feature such as TPM and kernel\r\nverification, so we can setup a trust chain when loading\r\nmodules with grub2.\r\n\r\nGNU grub2[1] also has the plan to add those security related\r\nfeatures, they have a 'verifiers' branch to do that, but\r\nthere're some build issue need to fix,so this patch use\r\ncoreos as an alternative.\r\n\r\nThis patch is used to address the #2359 #2375\r\n\r\nChange Log:\r\n1. Remove the comments raised by @rn\r\n2. Resolve the trust build issue raised by @rn \r\n3. Change the `/dev/vda` as the device name point by kernel command line `root=` on arm64, `/dev/sr0` on amd64. As next plan, we can adapt a more flexible method to get the dev name of the CDROM.\r\n\r\n[1] https://git.savannah.gnu.org/git/grub.git\r\n\r\nSigned-off-by: Dennis Chen <dennis.chen@arm.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/linuxkit/linuxkit/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nSupport iso-efi format image generation\r\n**- How I did it**\r\nBuild a grub2 core image with help of ubuntu, then use that core image to construct the bootable iso image within Alpine distribution\r\n**- How to verify it**\r\n`tools/mkimage-iso-efi/make ORG=m0824`\r\nChange the `src/moby/output.go` in moby tool git repos to point to the new built `mkimage-iso-efi` image.\r\n`bin/moby build -output iso-efi linuxkit.yml`\r\n`bin/linuxkit run qemu -uefi -fw \"/path/to/ovmf/ovmf.fd\" -iso linuxkit-efi.iso`\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![summit](https://user-images.githubusercontent.com/29669302/29599191-b0fab9e2-8800-11e7-840f-3c70c8921b10.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/linuxkit/linuxkit/issues/comments/324583505","html_url":"https://github.com/linuxkit/linuxkit/pull/2454#issuecomment-324583505","issue_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2454","id":324583505,"user":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"created_at":"2017-08-24T09:27:44Z","updated_at":"2017-08-24T09:27:44Z","body":"> the base distro should not make a difference for that?\r\nDo you mean the Debian should have the same behavior as Ubuntu?"}}
{"actor":{"display_login":"arm64b"}}