{"action":"created","comment":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments/104553321","pull_request_review_id":25392705,"id":104553321,"diff_hunk":"@@ -160,7 +160,6 @@ export function data(\n             store: previousState,\n             query: query.document,\n             variables: query.variables,\n-            returnPartialData: true,","path":"src/data/store.ts","position":4,"original_position":4,"commit_id":"90c1ade6412fadcd1b3b3069474969a67b409e11","original_commit_id":"90c1ade6412fadcd1b3b3069474969a67b409e11","user":{"login":"helfer","id":6569980,"avatar_url":"https://avatars0.githubusercontent.com/u/6569980?v=3","gravatar_id":"","url":"https://api.github.com/users/helfer","html_url":"https://github.com/helfer","followers_url":"https://api.github.com/users/helfer/followers","following_url":"https://api.github.com/users/helfer/following{/other_user}","gists_url":"https://api.github.com/users/helfer/gists{/gist_id}","starred_url":"https://api.github.com/users/helfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfer/subscriptions","organizations_url":"https://api.github.com/users/helfer/orgs","repos_url":"https://api.github.com/users/helfer/repos","events_url":"https://api.github.com/users/helfer/events{/privacy}","received_events_url":"https://api.github.com/users/helfer/received_events","type":"User","site_admin":false},"body":"I think this was set to true because of the same reason the result reducers were reading partial data. We shouldn't support that any more in my opinion, but I'll add a test to make sure that updateQueries doesn't get run for queries that are not completely in the store.","created_at":"2017-03-06T23:36:44Z","updated_at":"2017-03-06T23:52:14Z","html_url":"https://github.com/apollographql/apollo-client/pull/1370#discussion_r104553321","pull_request_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370","_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments/104553321"},"html":{"href":"https://github.com/apollographql/apollo-client/pull/1370#discussion_r104553321"},"pull_request":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370"}}},"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370","id":109340245,"html_url":"https://github.com/apollographql/apollo-client/pull/1370","diff_url":"https://github.com/apollographql/apollo-client/pull/1370.diff","patch_url":"https://github.com/apollographql/apollo-client/pull/1370.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/1370","number":1370,"state":"open","locked":false,"title":"Remove return partial","user":{"login":"helfer","id":6569980,"avatar_url":"https://avatars0.githubusercontent.com/u/6569980?v=3","gravatar_id":"","url":"https://api.github.com/users/helfer","html_url":"https://github.com/helfer","followers_url":"https://api.github.com/users/helfer/followers","following_url":"https://api.github.com/users/helfer/following{/other_user}","gists_url":"https://api.github.com/users/helfer/gists{/gist_id}","starred_url":"https://api.github.com/users/helfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfer/subscriptions","organizations_url":"https://api.github.com/users/helfer/orgs","repos_url":"https://api.github.com/users/helfer/repos","events_url":"https://api.github.com/users/helfer/events{/privacy}","received_events_url":"https://api.github.com/users/helfer/received_events","type":"User","site_admin":false},"body":"This removes the `returnPartialData` option from the watchQuery and query APIs.\r\n\r\nTo replace current usage of `returnPartialData`, specify a query with the data that you know / expect to be in the store at that moment. If for instance you want to provide a preview, then write a query that requests a subset of the data you know to be available. Render the component with that query while the larger query is loading.\r\n\r\n\r\nnote: this does not remove the ability to read partial results from the store internally. That functionality is still required for fragment matching.\r\n\r\nTODO:\r\n\r\n- [x] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)\r\n- [x] Make sure all of the significant new logic is covered by tests\r\n- [x] Rebase your changes on master so that they can be merged easily\r\n- [x] Make sure all tests and linter rules pass\r\n- [x] Update CHANGELOG.md with your change\r\n- [x] Add your name and email to the AUTHORS file (optional)\r\n- [ ] If this was a change that affects the external API, update the docs and post a link to the PR in the discussion\r\n","created_at":"2017-03-06T20:20:25Z","updated_at":"2017-03-06T23:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed90a286e05374eec903cd2825fc1276627f1aaa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/1370/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/90c1ade6412fadcd1b3b3069474969a67b409e11","head":{"label":"apollographql:remove-return-partial","ref":"remove-return-partial","sha":"90c1ade6412fadcd1b3b3069474969a67b409e11","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollographql/apollo-client","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-client","description":":rocket: A fully-featured caching GraphQL client for any server or UI framework","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-client","forks_url":"https://api.github.com/repos/apollographql/apollo-client/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-client/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-client/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2017-03-06T22:41:01Z","pushed_at":"2017-03-06T22:04:47Z","git_url":"git://github.com/apollographql/apollo-client.git","ssh_url":"git@github.com:apollographql/apollo-client.git","clone_url":"https://github.com/apollographql/apollo-client.git","svn_url":"https://github.com/apollographql/apollo-client","homepage":"http://dev.apollodata.com","size":3390,"stargazers_count":1951,"watchers_count":1951,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"open_issues_count":116,"forks":210,"open_issues":116,"watchers":1951,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"b1c9b27fe85d995e0ff17490a3511c4f66923554","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"name":"apollo-client","full_name":"apollographql/apollo-client","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-client","description":":rocket: A fully-featured caching GraphQL client for any server or UI framework","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-client","forks_url":"https://api.github.com/repos/apollographql/apollo-client/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-client/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-client/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2017-03-06T22:41:01Z","pushed_at":"2017-03-06T22:04:47Z","git_url":"git://github.com/apollographql/apollo-client.git","ssh_url":"git@github.com:apollographql/apollo-client.git","clone_url":"https://github.com/apollographql/apollo-client.git","svn_url":"https://github.com/apollographql/apollo-client","homepage":"http://dev.apollodata.com","size":3390,"stargazers_count":1951,"watchers_count":1951,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"open_issues_count":116,"forks":210,"open_issues":116,"watchers":1951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370"},"html":{"href":"https://github.com/apollographql/apollo-client/pull/1370"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/1370"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/1370/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/1370/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-client/statuses/90c1ade6412fadcd1b3b3069474969a67b409e11"}}}}
{"actor":{"display_login":"helfer"}}