{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/comments/150762198","pull_request_review_id":76358129,"id":150762198,"diff_hunk":"@@ -456,22 +462,12 @@ impl<'a> RequestAction<'a> for Rename {\n \n pub struct Deglob;\n \n-impl<'a> Action<'a> for Deglob {\n-    type Params = Location;\n-    const METHOD: &'static str = \"rustWorkspace/deglob\";\n-\n-    fn new(_: &'a mut LsState) -> Self {\n-        Deglob\n-    }\n-}\n-\n-impl<'a> RequestAction<'a> for Deglob {\n-    type Response = Ack;\n-    fn handle<O: Output>(&mut self, id: usize, location: Self::Params, ctx: &mut ActionContext, out: O) -> Result<Self::Response, ()> {\n+impl Deglob {\n+    fn calculate_workspace_edit(&mut self, location: &<Self as Action>::Params, ctx: &ActionContext) -> Result<DeglobResult, (ErrorCode, &'static str)> {","path":"src/actions/requests.rs","position":30,"original_position":30,"commit_id":"49181947f7f8f02ee3783fb15219fafc224969fc","original_commit_id":"49181947f7f8f02ee3783fb15219fafc224969fc","user":{"login":"jonasbb","id":273459,"avatar_url":"https://avatars1.githubusercontent.com/u/273459?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasbb","html_url":"https://github.com/jonasbb","followers_url":"https://api.github.com/users/jonasbb/followers","following_url":"https://api.github.com/users/jonasbb/following{/other_user}","gists_url":"https://api.github.com/users/jonasbb/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasbb/subscriptions","organizations_url":"https://api.github.com/users/jonasbb/orgs","repos_url":"https://api.github.com/users/jonasbb/repos","events_url":"https://api.github.com/users/jonasbb/events{/privacy}","received_events_url":"https://api.github.com/users/jonasbb/received_events","type":"User","site_admin":false},"body":"Yes, copy and paste error from handle ","created_at":"2017-11-14T08:18:46Z","updated_at":"2017-11-14T08:18:46Z","html_url":"https://github.com/rust-lang-nursery/rls/pull/567#discussion_r150762198","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/comments/150762198"},"html":{"href":"https://github.com/rust-lang-nursery/rls/pull/567#discussion_r150762198"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567"}},"in_reply_to_id":150755843},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567","id":152070383,"html_url":"https://github.com/rust-lang-nursery/rls/pull/567","diff_url":"https://github.com/rust-lang-nursery/rls/pull/567.diff","patch_url":"https://github.com/rust-lang-nursery/rls/pull/567.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/567","number":567,"state":"open","locked":false,"title":"Implement Deglob as a CodeAction","user":{"login":"jonasbb","id":273459,"avatar_url":"https://avatars1.githubusercontent.com/u/273459?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasbb","html_url":"https://github.com/jonasbb","followers_url":"https://api.github.com/users/jonasbb/followers","following_url":"https://api.github.com/users/jonasbb/following{/other_user}","gists_url":"https://api.github.com/users/jonasbb/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasbb/subscriptions","organizations_url":"https://api.github.com/users/jonasbb/orgs","repos_url":"https://api.github.com/users/jonasbb/repos","events_url":"https://api.github.com/users/jonasbb/events{/privacy}","received_events_url":"https://api.github.com/users/jonasbb/received_events","type":"User","site_admin":false},"body":"Provide code actions for deglobbing import for wildcard imports, except\r\nfor `prelude::*`. To avoid false positives (*) in the code actions, the\r\ndeglob command is run before the code action is presented to the user.\r\n\r\nThe original custom LSP extension is still in place in works. As such\r\nthe `Deglob::handle` function is split into a new\r\n`calculate_workspace_edit`, which calculates the data for the deglob\r\naction and is not used to the code action. The original `Deglob::handle`\r\njust calls this function and is reponsible for sending the messages to\r\nthe client.\r\n\r\nAddresses https://github.com/rust-lang-nursery/rls/issues/515\r\n\r\n(*) The path in `CodeAction::handle` only checks for the existence of `use ` and `::*`. False positives could be multiline strings or doc comments.","created_at":"2017-11-11T19:04:47Z","updated_at":"2017-11-14T08:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"863016e4917f8d5f266d5aa251907666ba8f3ea5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/567/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rls/statuses/49181947f7f8f02ee3783fb15219fafc224969fc","head":{"label":"jonasbb:deglob-as-code-action","ref":"deglob-as-code-action","sha":"49181947f7f8f02ee3783fb15219fafc224969fc","user":{"login":"jonasbb","id":273459,"avatar_url":"https://avatars1.githubusercontent.com/u/273459?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasbb","html_url":"https://github.com/jonasbb","followers_url":"https://api.github.com/users/jonasbb/followers","following_url":"https://api.github.com/users/jonasbb/following{/other_user}","gists_url":"https://api.github.com/users/jonasbb/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasbb/subscriptions","organizations_url":"https://api.github.com/users/jonasbb/orgs","repos_url":"https://api.github.com/users/jonasbb/repos","events_url":"https://api.github.com/users/jonasbb/events{/privacy}","received_events_url":"https://api.github.com/users/jonasbb/received_events","type":"User","site_admin":false},"repo":{"id":78934873,"name":"rls","full_name":"jonasbb/rls","owner":{"login":"jonasbb","id":273459,"avatar_url":"https://avatars1.githubusercontent.com/u/273459?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasbb","html_url":"https://github.com/jonasbb","followers_url":"https://api.github.com/users/jonasbb/followers","following_url":"https://api.github.com/users/jonasbb/following{/other_user}","gists_url":"https://api.github.com/users/jonasbb/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasbb/subscriptions","organizations_url":"https://api.github.com/users/jonasbb/orgs","repos_url":"https://api.github.com/users/jonasbb/repos","events_url":"https://api.github.com/users/jonasbb/events{/privacy}","received_events_url":"https://api.github.com/users/jonasbb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonasbb/rls","description":"Repository for the Rust Language Service (aka RLS)","fork":true,"url":"https://api.github.com/repos/jonasbb/rls","forks_url":"https://api.github.com/repos/jonasbb/rls/forks","keys_url":"https://api.github.com/repos/jonasbb/rls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonasbb/rls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonasbb/rls/teams","hooks_url":"https://api.github.com/repos/jonasbb/rls/hooks","issue_events_url":"https://api.github.com/repos/jonasbb/rls/issues/events{/number}","events_url":"https://api.github.com/repos/jonasbb/rls/events","assignees_url":"https://api.github.com/repos/jonasbb/rls/assignees{/user}","branches_url":"https://api.github.com/repos/jonasbb/rls/branches{/branch}","tags_url":"https://api.github.com/repos/jonasbb/rls/tags","blobs_url":"https://api.github.com/repos/jonasbb/rls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonasbb/rls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonasbb/rls/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonasbb/rls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonasbb/rls/statuses/{sha}","languages_url":"https://api.github.com/repos/jonasbb/rls/languages","stargazers_url":"https://api.github.com/repos/jonasbb/rls/stargazers","contributors_url":"https://api.github.com/repos/jonasbb/rls/contributors","subscribers_url":"https://api.github.com/repos/jonasbb/rls/subscribers","subscription_url":"https://api.github.com/repos/jonasbb/rls/subscription","commits_url":"https://api.github.com/repos/jonasbb/rls/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonasbb/rls/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonasbb/rls/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonasbb/rls/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonasbb/rls/contents/{+path}","compare_url":"https://api.github.com/repos/jonasbb/rls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonasbb/rls/merges","archive_url":"https://api.github.com/repos/jonasbb/rls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonasbb/rls/downloads","issues_url":"https://api.github.com/repos/jonasbb/rls/issues{/number}","pulls_url":"https://api.github.com/repos/jonasbb/rls/pulls{/number}","milestones_url":"https://api.github.com/repos/jonasbb/rls/milestones{/number}","notifications_url":"https://api.github.com/repos/jonasbb/rls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonasbb/rls/labels{/name}","releases_url":"https://api.github.com/repos/jonasbb/rls/releases{/id}","deployments_url":"https://api.github.com/repos/jonasbb/rls/deployments","created_at":"2017-01-14T10:53:59Z","updated_at":"2017-01-14T10:54:01Z","pushed_at":"2017-11-11T19:01:49Z","git_url":"git://github.com/jonasbb/rls.git","ssh_url":"git@github.com:jonasbb/rls.git","clone_url":"https://github.com/jonasbb/rls.git","svn_url":"https://github.com/jonasbb/rls","homepage":"","size":1256,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"015073b7c8a192584c15b2c1bd34a92025cf6836","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":66979953,"name":"rls","full_name":"rust-lang-nursery/rls","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/rls","description":"Repository for the Rust Language Server (aka RLS)","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/rls","forks_url":"https://api.github.com/repos/rust-lang-nursery/rls/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/rls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/rls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/rls/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/rls/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/rls/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/rls/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/rls/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/rls/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/rls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/rls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/rls/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/rls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rls/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/rls/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/rls/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/rls/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/rls/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/rls/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/rls/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/rls/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rls/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/rls/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/rls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/rls/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/rls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/rls/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/rls/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/rls/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/rls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/rls/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/rls/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/rls/deployments","created_at":"2016-08-30T21:42:03Z","updated_at":"2017-11-13T02:23:15Z","pushed_at":"2017-11-14T02:01:13Z","git_url":"git://github.com/rust-lang-nursery/rls.git","ssh_url":"git@github.com:rust-lang-nursery/rls.git","clone_url":"https://github.com/rust-lang-nursery/rls.git","svn_url":"https://github.com/rust-lang-nursery/rls","homepage":"","size":1262,"stargazers_count":1137,"watchers_count":1137,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":96,"forks":103,"open_issues":96,"watchers":1137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567"},"html":{"href":"https://github.com/rust-lang-nursery/rls/pull/567"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/issues/567"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/issues/567/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/pulls/567/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/rls/statuses/49181947f7f8f02ee3783fb15219fafc224969fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jonasbb"}}