{"action":"opened","number":13458,"pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/13458","id":126168387,"html_url":"https://github.com/adobe/brackets/pull/13458","diff_url":"https://github.com/adobe/brackets/pull/13458.diff","patch_url":"https://github.com/adobe/brackets/pull/13458.patch","issue_url":"https://api.github.com/repos/adobe/brackets/issues/13458","number":13458,"state":"open","locked":false,"title":"In writeJSON (grunt), use CRLF on Windows","user":{"login":"MarcelGerber","id":2641501,"avatar_url":"https://avatars3.githubusercontent.com/u/2641501?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcelGerber","html_url":"https://github.com/MarcelGerber","followers_url":"https://api.github.com/users/MarcelGerber/followers","following_url":"https://api.github.com/users/MarcelGerber/following{/other_user}","gists_url":"https://api.github.com/users/MarcelGerber/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelGerber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelGerber/subscriptions","organizations_url":"https://api.github.com/users/MarcelGerber/orgs","repos_url":"https://api.github.com/users/MarcelGerber/repos","events_url":"https://api.github.com/users/MarcelGerber/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelGerber/received_events","type":"User","site_admin":false},"body":"On current master and Windows, `grunt write-config` still adds changes to my `git status`, even though the diff is only \"warning: LF will be replaced by CRLF in src/config.json.\"\r\n\r\n![image](https://user-images.githubusercontent.com/2641501/27256334-b9b0046c-53b1-11e7-8cb2-9808057a3c93.png)\r\n\r\nThis now fixes it by making the grunt method `common.writeJSON` use CRLF line endings on Windows only.\r\nI couldn't test this on Linux or Mac, but it should only affect Windows.\r\n\r\nAlso, the other times `common.writeJSON` is used are as follows:\r\n* In task `build-config` writing to `dist/config.json`\r\n* In task `npm-install` writing to `dist/npm-shrinkwrap.json` and `dist/package.json`\r\n* In task `update-release-number` writing to `package.json`\r\nI don't think the difference of CRLF and LF (used before) matters in these cases, but I'm not 100% sure either and don't know how to test.\r\n\r\ncc @ficristo @zaggino \r\n#12771 would be fully fixed with this.","created_at":"2017-06-17T21:15:25Z","updated_at":"2017-06-17T21:15:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"zaggino","id":1067319,"avatar_url":"https://avatars2.githubusercontent.com/u/1067319?v=3","gravatar_id":"","url":"https://api.github.com/users/zaggino","html_url":"https://github.com/zaggino","followers_url":"https://api.github.com/users/zaggino/followers","following_url":"https://api.github.com/users/zaggino/following{/other_user}","gists_url":"https://api.github.com/users/zaggino/gists{/gist_id}","starred_url":"https://api.github.com/users/zaggino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaggino/subscriptions","organizations_url":"https://api.github.com/users/zaggino/orgs","repos_url":"https://api.github.com/users/zaggino/repos","events_url":"https://api.github.com/users/zaggino/events{/privacy}","received_events_url":"https://api.github.com/users/zaggino/received_events","type":"User","site_admin":false},{"login":"ficristo","id":10583268,"avatar_url":"https://avatars2.githubusercontent.com/u/10583268?v=3","gravatar_id":"","url":"https://api.github.com/users/ficristo","html_url":"https://github.com/ficristo","followers_url":"https://api.github.com/users/ficristo/followers","following_url":"https://api.github.com/users/ficristo/following{/other_user}","gists_url":"https://api.github.com/users/ficristo/gists{/gist_id}","starred_url":"https://api.github.com/users/ficristo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ficristo/subscriptions","organizations_url":"https://api.github.com/users/ficristo/orgs","repos_url":"https://api.github.com/users/ficristo/repos","events_url":"https://api.github.com/users/ficristo/events{/privacy}","received_events_url":"https://api.github.com/users/ficristo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/adobe/brackets/pulls/13458/commits","review_comments_url":"https://api.github.com/repos/adobe/brackets/pulls/13458/comments","review_comment_url":"https://api.github.com/repos/adobe/brackets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/13458/comments","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/908662dcfd4983ab62c1f20a724eeb762beb6061","head":{"label":"adobe:marcel/grunt-win-crlf","ref":"marcel/grunt-win-crlf","sha":"908662dcfd4983ab62c1f20a724eeb762beb6061","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars1.githubusercontent.com/u/476009?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":2935735,"name":"brackets","full_name":"adobe/brackets","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars1.githubusercontent.com/u/476009?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":false,"url":"https://api.github.com/repos/adobe/brackets","forks_url":"https://api.github.com/repos/adobe/brackets/forks","keys_url":"https://api.github.com/repos/adobe/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/brackets/teams","hooks_url":"https://api.github.com/repos/adobe/brackets/hooks","issue_events_url":"https://api.github.com/repos/adobe/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/brackets/events","assignees_url":"https://api.github.com/repos/adobe/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/brackets/tags","blobs_url":"https://api.github.com/repos/adobe/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/brackets/languages","stargazers_url":"https://api.github.com/repos/adobe/brackets/stargazers","contributors_url":"https://api.github.com/repos/adobe/brackets/contributors","subscribers_url":"https://api.github.com/repos/adobe/brackets/subscribers","subscription_url":"https://api.github.com/repos/adobe/brackets/subscription","commits_url":"https://api.github.com/repos/adobe/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/brackets/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/brackets/merges","archive_url":"https://api.github.com/repos/adobe/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/brackets/downloads","issues_url":"https://api.github.com/repos/adobe/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/brackets/labels{/name}","releases_url":"https://api.github.com/repos/adobe/brackets/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/brackets/deployments","created_at":"2011-12-07T21:14:40Z","updated_at":"2017-06-17T21:05:21Z","pushed_at":"2017-06-17T21:10:47Z","git_url":"git://github.com/adobe/brackets.git","ssh_url":"git@github.com:adobe/brackets.git","clone_url":"https://github.com/adobe/brackets.git","svn_url":"https://github.com/adobe/brackets","homepage":"http://brackets.io","size":89281,"stargazers_count":27569,"watchers_count":27569,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5883,"mirror_url":null,"open_issues_count":1885,"forks":5883,"open_issues":1885,"watchers":27569,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"9b7a4ee2b204716d438c357572570df5d2f1cd30","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars1.githubusercontent.com/u/476009?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":2935735,"name":"brackets","full_name":"adobe/brackets","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars1.githubusercontent.com/u/476009?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":false,"url":"https://api.github.com/repos/adobe/brackets","forks_url":"https://api.github.com/repos/adobe/brackets/forks","keys_url":"https://api.github.com/repos/adobe/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/brackets/teams","hooks_url":"https://api.github.com/repos/adobe/brackets/hooks","issue_events_url":"https://api.github.com/repos/adobe/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/brackets/events","assignees_url":"https://api.github.com/repos/adobe/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/brackets/tags","blobs_url":"https://api.github.com/repos/adobe/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/brackets/languages","stargazers_url":"https://api.github.com/repos/adobe/brackets/stargazers","contributors_url":"https://api.github.com/repos/adobe/brackets/contributors","subscribers_url":"https://api.github.com/repos/adobe/brackets/subscribers","subscription_url":"https://api.github.com/repos/adobe/brackets/subscription","commits_url":"https://api.github.com/repos/adobe/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/brackets/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/brackets/merges","archive_url":"https://api.github.com/repos/adobe/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/brackets/downloads","issues_url":"https://api.github.com/repos/adobe/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/brackets/labels{/name}","releases_url":"https://api.github.com/repos/adobe/brackets/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/brackets/deployments","created_at":"2011-12-07T21:14:40Z","updated_at":"2017-06-17T21:05:21Z","pushed_at":"2017-06-17T21:10:47Z","git_url":"git://github.com/adobe/brackets.git","ssh_url":"git@github.com:adobe/brackets.git","clone_url":"https://github.com/adobe/brackets.git","svn_url":"https://github.com/adobe/brackets","homepage":"http://brackets.io","size":89281,"stargazers_count":27569,"watchers_count":27569,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5883,"mirror_url":null,"open_issues_count":1885,"forks":5883,"open_issues":1885,"watchers":27569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/13458"},"html":{"href":"https://github.com/adobe/brackets/pull/13458"},"issue":{"href":"https://api.github.com/repos/adobe/brackets/issues/13458"},"comments":{"href":"https://api.github.com/repos/adobe/brackets/issues/13458/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/brackets/pulls/13458/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe/brackets/pulls/13458/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/brackets/statuses/908662dcfd4983ab62c1f20a724eeb762beb6061"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"MarcelGerber"}}