{"action":"created","issue":{"url":"https://api.github.com/repos/gonetz/GLideN64/issues/1616","repository_url":"https://api.github.com/repos/gonetz/GLideN64","labels_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1616/labels{/name}","comments_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1616/comments","events_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1616/events","html_url":"https://github.com/gonetz/GLideN64/issues/1616","id":262115275,"number":1616,"title":"VidExt_ResizeWindow is called if fullscreen is enabled","user":{"login":"gizmo98","id":6412699,"avatar_url":"https://avatars3.githubusercontent.com/u/6412699?v=4","gravatar_id":"","url":"https://api.github.com/users/gizmo98","html_url":"https://github.com/gizmo98","followers_url":"https://api.github.com/users/gizmo98/followers","following_url":"https://api.github.com/users/gizmo98/following{/other_user}","gists_url":"https://api.github.com/users/gizmo98/gists{/gist_id}","starred_url":"https://api.github.com/users/gizmo98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gizmo98/subscriptions","organizations_url":"https://api.github.com/users/gizmo98/orgs","repos_url":"https://api.github.com/users/gizmo98/repos","events_url":"https://api.github.com/users/gizmo98/events{/privacy}","received_events_url":"https://api.github.com/users/gizmo98/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-02T15:00:37Z","updated_at":"2017-10-02T15:33:58Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**System:**\r\n- Intel Core i3 with integrated GPU\r\n- Ubuntu 16.04 with hardware enablement stack HWE\r\n- Monitor resolution is 1024x768\r\n- SDL 2.0.4\r\n- fresh compiled mupen64plus and plugins\r\n\r\n**Problem:**\r\nIf mupen64plus is started with `--fullscreen` display flickers and there is no picture. According to logfile VidExt_ResizeWindow() is called in fullscreen mode multiple times. The requested (fullscreen) resolution of 1024x796 is not supported. \r\n[runcommand.txt](https://github.com/gonetz/GLideN64/files/1349293/runcommand.txt)\r\n\r\n\r\n```\r\nCore Error: VidExt_ResizeWindow() called in fullscreen mode.\r\n(EE) Error setting videomode 1024x796\r\n(II) Setting video mode 1024x768...\r\nCore: Setting video mode: 1024x768\r\n```\r\n\r\nI don't think VidExt_ResizeWindow() should be called if fullscreen is enabled."},"comment":{"url":"https://api.github.com/repos/gonetz/GLideN64/issues/comments/333571712","html_url":"https://github.com/gonetz/GLideN64/issues/1616#issuecomment-333571712","issue_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1616","id":333571712,"user":{"login":"loganmc10","id":848146,"avatar_url":"https://avatars0.githubusercontent.com/u/848146?v=4","gravatar_id":"","url":"https://api.github.com/users/loganmc10","html_url":"https://github.com/loganmc10","followers_url":"https://api.github.com/users/loganmc10/followers","following_url":"https://api.github.com/users/loganmc10/following{/other_user}","gists_url":"https://api.github.com/users/loganmc10/gists{/gist_id}","starred_url":"https://api.github.com/users/loganmc10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganmc10/subscriptions","organizations_url":"https://api.github.com/users/loganmc10/orgs","repos_url":"https://api.github.com/users/loganmc10/repos","events_url":"https://api.github.com/users/loganmc10/events{/privacy}","received_events_url":"https://api.github.com/users/loganmc10/received_events","type":"User","site_admin":false},"created_at":"2017-10-02T15:33:58Z","updated_at":"2017-10-02T15:33:58Z","author_association":"CONTRIBUTOR","body":"But either way, stopping ResizeWindow from being called in fullscreen won't break mupen64plus-gui.\r\n\r\nhttps://github.com/gonetz/GLideN64/blob/master/src/Graphics/OpenGLContext/mupen64plus/mupen64plus_DisplayWindow.cpp\r\n\r\nm_bFullscreen needs a bit of work, it's not properly tracking the fullscreen state (it doesn't get toggled when _changeWindow is called)\r\n\r\nThen inside ```DisplayWindowMupen64plus::_resizeWindow()``` you can just wrap ```CoreVideo_ResizeWindow()``` instead a check for !m_bFullscreen "}}
{"actor":{"display_login":"loganmc10"}}