{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/18742","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/18742/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/18742/comments","events_url":"https://api.github.com/repos/apache/spark/issues/18742/events","html_url":"https://github.com/apache/spark/pull/18742","id":245878581,"number":18742,"title":"Python persistence helper functions","user":{"login":"ajaysaini725","id":9918578,"avatar_url":"https://avatars0.githubusercontent.com/u/9918578?v=4","gravatar_id":"","url":"https://api.github.com/users/ajaysaini725","html_url":"https://github.com/ajaysaini725","followers_url":"https://api.github.com/users/ajaysaini725/followers","following_url":"https://api.github.com/users/ajaysaini725/following{/other_user}","gists_url":"https://api.github.com/users/ajaysaini725/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaysaini725/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaysaini725/subscriptions","organizations_url":"https://api.github.com/users/ajaysaini725/orgs","repos_url":"https://api.github.com/users/ajaysaini725/repos","events_url":"https://api.github.com/users/ajaysaini725/events{/privacy}","received_events_url":"https://api.github.com/users/ajaysaini725/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-26T22:57:10Z","updated_at":"2017-07-26T22:58:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/18742","html_url":"https://github.com/apache/spark/pull/18742","diff_url":"https://github.com/apache/spark/pull/18742.diff","patch_url":"https://github.com/apache/spark/pull/18742.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nAdded DefaultParamsWriteable, DefaultParamsReadable, DefaultParamsWriter, and DefaultParamsReader to Python to support Python-only persistence of Json-serializable parameters. \r\n\r\n## How was this patch tested?\r\n\r\nInstantiated an estimator with Json-serializable parameters (ex. LogisticRegression), saved it using the added helper functions, and loaded it back, and compared it to the original instance to make sure it is the same. This test was done in both the Python REPL and the unit tests.\r\n\r\nNote to reviewers: there are a few excess comments that I left in the code for clarity but will remove before the code is merged to master.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/318207207","html_url":"https://github.com/apache/spark/pull/18742#issuecomment-318207207","issue_url":"https://api.github.com/repos/apache/spark/issues/18742","id":318207207,"user":{"login":"ajaysaini725","id":9918578,"avatar_url":"https://avatars0.githubusercontent.com/u/9918578?v=4","gravatar_id":"","url":"https://api.github.com/users/ajaysaini725","html_url":"https://github.com/ajaysaini725","followers_url":"https://api.github.com/users/ajaysaini725/followers","following_url":"https://api.github.com/users/ajaysaini725/following{/other_user}","gists_url":"https://api.github.com/users/ajaysaini725/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaysaini725/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaysaini725/subscriptions","organizations_url":"https://api.github.com/users/ajaysaini725/orgs","repos_url":"https://api.github.com/users/ajaysaini725/repos","events_url":"https://api.github.com/users/ajaysaini725/events{/privacy}","received_events_url":"https://api.github.com/users/ajaysaini725/received_events","type":"User","site_admin":false},"created_at":"2017-07-26T22:58:01Z","updated_at":"2017-07-26T22:58:01Z","body":"@jkbradley @thunterdb @MrBago Could you please review this PR?"}}
{"actor":{"display_login":"ajaysaini725"}}