{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/120200577","pull_request_review_id":42143256,"id":120200577,"diff_hunk":"@@ -104,39 +90,30 @@\n    *\n    * <p>Any filename component of the provided resource will be used as the filename prefix.\n    *\n-   * <p>If provided, the shard name template will be used; otherwise {@link #DEFAULT_SHARD_TEMPLATE}\n-   * will be used for non-windowed file names and {@link #DEFAULT_WINDOWED_SHARD_TEMPLATE} will\n-   * be used for windowed file names.\n+   * <p>If provided, the shard name template will be used; otherwise\n+   * {@link #DEFAULT_UNWINDOWED_SHARD_TEMPLATE} will be used for non-windowed file names and\n+   * {@link #DEFAULT_WINDOWED_SHARD_TEMPLATE} will be used for windowed file names.\n    *\n    * <p>If provided, the suffix will be used; otherwise the files will have an empty suffix.\n    */\n   public static DefaultFilenamePolicy constructUsingStandardParameters(","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/io/DefaultFilenamePolicy.java","position":60,"original_position":60,"commit_id":"6c696665f1e7e6ed373eab3eb6a5652e4731312b","original_commit_id":"6c696665f1e7e6ed373eab3eb6a5652e4731312b","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars1.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"body":"Some of these changes are backwards incompatible, and this class appears to be on the public API and not marked with `@Experimental` or `@Internal`.","created_at":"2017-06-05T20:25:22Z","updated_at":"2017-06-05T20:25:46Z","html_url":"https://github.com/apache/beam/pull/3232#discussion_r120200577","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/3232","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/120200577"},"html":{"href":"https://github.com/apache/beam/pull/3232#discussion_r120200577"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/3232"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/3232","id":122582137,"html_url":"https://github.com/apache/beam/pull/3232","diff_url":"https://github.com/apache/beam/pull/3232.diff","patch_url":"https://github.com/apache/beam/pull/3232.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/3232","number":3232,"state":"open","locked":false,"title":"[BEAM-2276] Cleanups to windowed DefaultFilenamePolicy","user":{"login":"reuvenlax","id":21071061,"avatar_url":"https://avatars2.githubusercontent.com/u/21071061?v=3","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"body":"Make window strings more concise, and provide more information about the pane more concisely (most users care about whether a pane is the last one, and whether it is late).\r\n\r\nCleanup complicated code around filename templates - simply store two default templates, and pick the correct one based on whether windowed writes are enabled.\r\n\r\nRemove log statements that would be extremely noisy in practice. Users may have valid reasons for not including W and P template variables - e.g. they may know they are in the global window and not want every file to contain GlobalWindow. This is the same reason we don't warn if S and N are missing from their template (they may be writing to a single shard).\r\n\r\nR: @jbonofre ","created_at":"2017-05-26T06:48:05Z","updated_at":"2017-06-05T20:25:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"895addacdbd62e4431b745fa5866d97197bae629","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/3232/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/3232/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/3232/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/6c696665f1e7e6ed373eab3eb6a5652e4731312b","head":{"label":"reuvenlax:cleanup_filename_policy","ref":"cleanup_filename_policy","sha":"6c696665f1e7e6ed373eab3eb6a5652e4731312b","user":{"login":"reuvenlax","id":21071061,"avatar_url":"https://avatars2.githubusercontent.com/u/21071061?v=3","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"repo":{"id":72963016,"name":"incubator-beam","full_name":"reuvenlax/incubator-beam","owner":{"login":"reuvenlax","id":21071061,"avatar_url":"https://avatars2.githubusercontent.com/u/21071061?v=3","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reuvenlax/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/reuvenlax/incubator-beam","forks_url":"https://api.github.com/repos/reuvenlax/incubator-beam/forks","keys_url":"https://api.github.com/repos/reuvenlax/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reuvenlax/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reuvenlax/incubator-beam/teams","hooks_url":"https://api.github.com/repos/reuvenlax/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/reuvenlax/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/reuvenlax/incubator-beam/events","assignees_url":"https://api.github.com/repos/reuvenlax/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/reuvenlax/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/reuvenlax/incubator-beam/tags","blobs_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reuvenlax/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/reuvenlax/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/reuvenlax/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/reuvenlax/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/reuvenlax/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/reuvenlax/incubator-beam/subscription","commits_url":"https://api.github.com/repos/reuvenlax/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/reuvenlax/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/reuvenlax/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/reuvenlax/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/reuvenlax/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reuvenlax/incubator-beam/merges","archive_url":"https://api.github.com/repos/reuvenlax/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reuvenlax/incubator-beam/downloads","issues_url":"https://api.github.com/repos/reuvenlax/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/reuvenlax/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/reuvenlax/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/reuvenlax/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reuvenlax/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/reuvenlax/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/reuvenlax/incubator-beam/deployments","created_at":"2016-11-06T01:16:14Z","updated_at":"2016-11-06T01:16:20Z","pushed_at":"2017-06-05T17:51:07Z","git_url":"git://github.com/reuvenlax/incubator-beam.git","ssh_url":"git@github.com:reuvenlax/incubator-beam.git","clone_url":"https://github.com/reuvenlax/incubator-beam.git","svn_url":"https://github.com/reuvenlax/incubator-beam","homepage":null,"size":38060,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"deee5b3c29f16cc29db7ee30d4f482b360df53f0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Mirror of Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2017-06-05T14:56:27Z","pushed_at":"2017-06-05T20:16:34Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":38517,"stargazers_count":1196,"watchers_count":1196,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":667,"mirror_url":"git://git.apache.org/beam.git","open_issues_count":73,"forks":667,"open_issues":73,"watchers":1196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/3232"},"html":{"href":"https://github.com/apache/beam/pull/3232"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/3232"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/3232/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/3232/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/3232/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/6c696665f1e7e6ed373eab3eb6a5652e4731312b"}}}}
{"actor":{"display_login":"tgroh"}}