{"push_id":2079728959,"size":2,"distinct_size":1,"ref":"refs/heads/feature-romo-js","head":"8d860a9b0f571ca0522d3cda9225349b66e863dc","before":"4a07523ac37ddf939dc7a1e17ae81185df402558","commits":[{"sha":"a4311a73226f233ce640aea11b5c846aa8dc6c9d","author":{"name":"Collin Redding","email":"d46f375d8aaf6893782d4503835b61ef3c034b5b@gmail.com"},"message":"Fixes and cleanups related to modals\n\nThis is a set of fixes and cleanups related to modals. These\nwere discovered while testing modals and modal forms, and getting\nthem working. This includes:\n\n* Add missing `px` when setting the modal `top` and `left` styles\nto place the modal. This was also done for dropdowns in PR 192 and\nwas similarly missed in modals when switching from jquery to\nvanilla js.\n* Update the logic to place the modal to be consistent with the\ndropdown logic (PR 192). This avoids using a `css` object and\nswitches to separate local variables for determing the top and\nleft for the modal. Since we are no longer using the jquery\n`offset` method which took an object there isn't any gain in\nbuilding a `css` object.\n* Update the bind body logic to bind to multiple close and drag\nelems. This was noticed because modals typically have both a\nX for closing the modal and a close button. The same was done for\ndrag elems because there isn't really any negatives to supporting\nmultiple and we may want a modal with multiple drag elems in the\nfuture.\n* Update the dropdown close elem binding to match the modals. This\nis to keep them consistent and as mentioned for the drag elems\nthere isn't really a negative to supporting multiple.\n* Update modal and modal form private method names. The modal\nmouse related event bindings were using the wrong method names\nand the modal form's method for binding the form was incorrect.\nThis updates the modal form's method name to match the dropdown\nform and the inline form method name.","distinct":false,"url":"https://api.github.com/repos/redding/romo/commits/a4311a73226f233ce640aea11b5c846aa8dc6c9d"},{"sha":"8d860a9b0f571ca0522d3cda9225349b66e863dc","author":{"name":"Collin Redding","email":"d46f375d8aaf6893782d4503835b61ef3c034b5b@gmail.com"},"message":"Merge pull request #203 from redding/jcr-modal-fixes-cleanups\n\nFixes and cleanups related to modals","distinct":true,"url":"https://api.github.com/repos/redding/romo/commits/8d860a9b0f571ca0522d3cda9225349b66e863dc"}]}
{"actor":{"display_login":"jcredding"}}