{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments/123092689","pull_request_review_id":45264428,"id":123092689,"diff_hunk":"@@ -1765,15 +1772,15 @@ enum class ConstructorBehavior { kThrow, kAllow };\n class V8_EXPORT Function : public Object {\n  public:\n   static MaybeLocal<Function> New(Local<Context> context,\n-                                  FunctionCallback callback,\n-                                  Local<Value> data = Local<Value>(),\n-                                  int length = 0,\n-                                  ConstructorBehavior behavior = ConstructorBehavior::kAllow);\n+    FunctionCallback callback,","path":"deps/chakrashim/include/v8.h","position":85,"original_position":85,"commit_id":"15a84455c5ff549f5e8eff0221d10840d2d7c905","original_commit_id":"15a84455c5ff549f5e8eff0221d10840d2d7c905","user":{"login":"kfarnung","id":931192,"avatar_url":"https://avatars1.githubusercontent.com/u/931192?v=3","gravatar_id":"","url":"https://api.github.com/users/kfarnung","html_url":"https://github.com/kfarnung","followers_url":"https://api.github.com/users/kfarnung/followers","following_url":"https://api.github.com/users/kfarnung/following{/other_user}","gists_url":"https://api.github.com/users/kfarnung/gists{/gist_id}","starred_url":"https://api.github.com/users/kfarnung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfarnung/subscriptions","organizations_url":"https://api.github.com/users/kfarnung/orgs","repos_url":"https://api.github.com/users/kfarnung/repos","events_url":"https://api.github.com/users/kfarnung/events{/privacy}","received_events_url":"https://api.github.com/users/kfarnung/received_events","type":"User","site_admin":false},"body":"super nit:  Can you bring the first parameter down and indent them all two more spaces?","created_at":"2017-06-20T20:54:26Z","updated_at":"2017-06-20T20:54:26Z","html_url":"https://github.com/nodejs/node-chakracore/pull/313#discussion_r123092689","pull_request_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments/123092689"},"html":{"href":"https://github.com/nodejs/node-chakracore/pull/313#discussion_r123092689"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313","id":126435612,"html_url":"https://github.com/nodejs/node-chakracore/pull/313","diff_url":"https://github.com/nodejs/node-chakracore/pull/313.diff","patch_url":"https://github.com/nodejs/node-chakracore/pull/313.patch","issue_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/313","number":313,"state":"open","locked":false,"title":"chakrashim: add JSON methods","user":{"login":"boingoing","id":1569843,"avatar_url":"https://avatars0.githubusercontent.com/u/1569843?v=3","gravatar_id":"","url":"https://api.github.com/users/boingoing","html_url":"https://github.com/boingoing","followers_url":"https://api.github.com/users/boingoing/followers","following_url":"https://api.github.com/users/boingoing/following{/other_user}","gists_url":"https://api.github.com/users/boingoing/gists{/gist_id}","starred_url":"https://api.github.com/users/boingoing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boingoing/subscriptions","organizations_url":"https://api.github.com/users/boingoing/orgs","repos_url":"https://api.github.com/users/boingoing/repos","events_url":"https://api.github.com/users/boingoing/events{/privacy}","received_events_url":"https://api.github.com/users/boingoing/received_events","type":"User","site_admin":false},"body":"Add `v8::JSON::Parse` and `v8::JSON::Stringify` to chakrashim. These methods were recently added to `Nan::JSON` which a lot of native modules depend on and now fail to build against node-chakracore. One example is [this](https://github.com/sass/node-sass/pull/1777#issuecomment-309180302) thread:\r\nhttps://github.com/sass/node-sass/pull/1777\r\n\r\nIncludes some new node tests in test/addons/json.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\nchakrashim","created_at":"2017-06-20T02:33:25Z","updated_at":"2017-06-20T20:54:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43b3a09c5d20264a075474ccbcc8def6ef378b95","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313/commits","review_comments_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313/comments","review_comment_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/313/comments","statuses_url":"https://api.github.com/repos/nodejs/node-chakracore/statuses/15a84455c5ff549f5e8eff0221d10840d2d7c905","head":{"label":"boingoing:addv8jsontochakrashim","ref":"addv8jsontochakrashim","sha":"15a84455c5ff549f5e8eff0221d10840d2d7c905","user":{"login":"boingoing","id":1569843,"avatar_url":"https://avatars0.githubusercontent.com/u/1569843?v=3","gravatar_id":"","url":"https://api.github.com/users/boingoing","html_url":"https://github.com/boingoing","followers_url":"https://api.github.com/users/boingoing/followers","following_url":"https://api.github.com/users/boingoing/following{/other_user}","gists_url":"https://api.github.com/users/boingoing/gists{/gist_id}","starred_url":"https://api.github.com/users/boingoing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boingoing/subscriptions","organizations_url":"https://api.github.com/users/boingoing/orgs","repos_url":"https://api.github.com/users/boingoing/repos","events_url":"https://api.github.com/users/boingoing/events{/privacy}","received_events_url":"https://api.github.com/users/boingoing/received_events","type":"User","site_admin":false},"repo":{"id":87994802,"name":"node-chakracore","full_name":"boingoing/node-chakracore","owner":{"login":"boingoing","id":1569843,"avatar_url":"https://avatars0.githubusercontent.com/u/1569843?v=3","gravatar_id":"","url":"https://api.github.com/users/boingoing","html_url":"https://github.com/boingoing","followers_url":"https://api.github.com/users/boingoing/followers","following_url":"https://api.github.com/users/boingoing/following{/other_user}","gists_url":"https://api.github.com/users/boingoing/gists{/gist_id}","starred_url":"https://api.github.com/users/boingoing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boingoing/subscriptions","organizations_url":"https://api.github.com/users/boingoing/orgs","repos_url":"https://api.github.com/users/boingoing/repos","events_url":"https://api.github.com/users/boingoing/events{/privacy}","received_events_url":"https://api.github.com/users/boingoing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boingoing/node-chakracore","description":"Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/boingoing/node-chakracore","forks_url":"https://api.github.com/repos/boingoing/node-chakracore/forks","keys_url":"https://api.github.com/repos/boingoing/node-chakracore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boingoing/node-chakracore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boingoing/node-chakracore/teams","hooks_url":"https://api.github.com/repos/boingoing/node-chakracore/hooks","issue_events_url":"https://api.github.com/repos/boingoing/node-chakracore/issues/events{/number}","events_url":"https://api.github.com/repos/boingoing/node-chakracore/events","assignees_url":"https://api.github.com/repos/boingoing/node-chakracore/assignees{/user}","branches_url":"https://api.github.com/repos/boingoing/node-chakracore/branches{/branch}","tags_url":"https://api.github.com/repos/boingoing/node-chakracore/tags","blobs_url":"https://api.github.com/repos/boingoing/node-chakracore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boingoing/node-chakracore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boingoing/node-chakracore/git/refs{/sha}","trees_url":"https://api.github.com/repos/boingoing/node-chakracore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boingoing/node-chakracore/statuses/{sha}","languages_url":"https://api.github.com/repos/boingoing/node-chakracore/languages","stargazers_url":"https://api.github.com/repos/boingoing/node-chakracore/stargazers","contributors_url":"https://api.github.com/repos/boingoing/node-chakracore/contributors","subscribers_url":"https://api.github.com/repos/boingoing/node-chakracore/subscribers","subscription_url":"https://api.github.com/repos/boingoing/node-chakracore/subscription","commits_url":"https://api.github.com/repos/boingoing/node-chakracore/commits{/sha}","git_commits_url":"https://api.github.com/repos/boingoing/node-chakracore/git/commits{/sha}","comments_url":"https://api.github.com/repos/boingoing/node-chakracore/comments{/number}","issue_comment_url":"https://api.github.com/repos/boingoing/node-chakracore/issues/comments{/number}","contents_url":"https://api.github.com/repos/boingoing/node-chakracore/contents/{+path}","compare_url":"https://api.github.com/repos/boingoing/node-chakracore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boingoing/node-chakracore/merges","archive_url":"https://api.github.com/repos/boingoing/node-chakracore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boingoing/node-chakracore/downloads","issues_url":"https://api.github.com/repos/boingoing/node-chakracore/issues{/number}","pulls_url":"https://api.github.com/repos/boingoing/node-chakracore/pulls{/number}","milestones_url":"https://api.github.com/repos/boingoing/node-chakracore/milestones{/number}","notifications_url":"https://api.github.com/repos/boingoing/node-chakracore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boingoing/node-chakracore/labels{/name}","releases_url":"https://api.github.com/repos/boingoing/node-chakracore/releases{/id}","deployments_url":"https://api.github.com/repos/boingoing/node-chakracore/deployments","created_at":"2017-04-12T01:17:50Z","updated_at":"2017-04-12T01:17:58Z","pushed_at":"2017-06-20T20:49:25Z","git_url":"git://github.com/boingoing/node-chakracore.git","ssh_url":"git@github.com:boingoing/node-chakracore.git","clone_url":"https://github.com/boingoing/node-chakracore.git","svn_url":"https://github.com/boingoing/node-chakracore","homepage":"","size":260392,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"xplat"}},"base":{"label":"nodejs:master","ref":"master","sha":"0f1feb93fd01d92486c6e9a8410ca21f9a369731","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":46881155,"name":"node-chakracore","full_name":"nodejs/node-chakracore","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node-chakracore","description":"Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node-chakracore","forks_url":"https://api.github.com/repos/nodejs/node-chakracore/forks","keys_url":"https://api.github.com/repos/nodejs/node-chakracore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node-chakracore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node-chakracore/teams","hooks_url":"https://api.github.com/repos/nodejs/node-chakracore/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node-chakracore/events","assignees_url":"https://api.github.com/repos/nodejs/node-chakracore/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node-chakracore/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node-chakracore/tags","blobs_url":"https://api.github.com/repos/nodejs/node-chakracore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node-chakracore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node-chakracore/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node-chakracore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node-chakracore/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node-chakracore/languages","stargazers_url":"https://api.github.com/repos/nodejs/node-chakracore/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node-chakracore/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node-chakracore/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node-chakracore/subscription","commits_url":"https://api.github.com/repos/nodejs/node-chakracore/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node-chakracore/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node-chakracore/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node-chakracore/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node-chakracore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node-chakracore/merges","archive_url":"https://api.github.com/repos/nodejs/node-chakracore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node-chakracore/downloads","issues_url":"https://api.github.com/repos/nodejs/node-chakracore/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node-chakracore/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node-chakracore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node-chakracore/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node-chakracore/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node-chakracore/deployments","created_at":"2015-11-25T19:09:26Z","updated_at":"2017-06-19T18:22:49Z","pushed_at":"2017-06-20T20:49:28Z","git_url":"git://github.com/nodejs/node-chakracore.git","ssh_url":"git@github.com:nodejs/node-chakracore.git","clone_url":"https://github.com/nodejs/node-chakracore.git","svn_url":"https://github.com/nodejs/node-chakracore","homepage":"","size":264226,"stargazers_count":1098,"watchers_count":1098,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":44,"forks":84,"open_issues":44,"watchers":1098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313"},"html":{"href":"https://github.com/nodejs/node-chakracore/pull/313"},"issue":{"href":"https://api.github.com/repos/nodejs/node-chakracore/issues/313"},"comments":{"href":"https://api.github.com/repos/nodejs/node-chakracore/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node-chakracore/statuses/15a84455c5ff549f5e8eff0221d10840d2d7c905"}}}}
{"actor":{"display_login":"kfarnung"}}