{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/notifications-admin/issues/1649","repository_url":"https://api.github.com/repos/alphagov/notifications-admin","labels_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/1649/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/1649/comments","events_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/1649/events","html_url":"https://github.com/alphagov/notifications-admin/pull/1649","id":274238444,"number":1649,"title":"Existing user email auth invite","user":{"login":"leohemsted","id":5020841,"avatar_url":"https://avatars2.githubusercontent.com/u/5020841?v=4","gravatar_id":"","url":"https://api.github.com/users/leohemsted","html_url":"https://github.com/leohemsted","followers_url":"https://api.github.com/users/leohemsted/followers","following_url":"https://api.github.com/users/leohemsted/following{/other_user}","gists_url":"https://api.github.com/users/leohemsted/gists{/gist_id}","starred_url":"https://api.github.com/users/leohemsted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leohemsted/subscriptions","organizations_url":"https://api.github.com/users/leohemsted/orgs","repos_url":"https://api.github.com/users/leohemsted/repos","events_url":"https://api.github.com/users/leohemsted/events{/privacy}","received_events_url":"https://api.github.com/users/leohemsted/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-15T17:22:22Z","updated_at":"2017-11-15T18:33:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/1649","html_url":"https://github.com/alphagov/notifications-admin/pull/1649","diff_url":"https://github.com/alphagov/notifications-admin/pull/1649.diff","patch_url":"https://github.com/alphagov/notifications-admin/pull/1649.patch"},"body":"make sure existing users accepting invites get their auth types set properly, EXCEPT FOR:\r\n* if the service issuing the invite does not have permission to edit auth types, don't let them do anything. This will stop them turning existing email_auth users back to sms auth\r\n* if the user hasn't got a mobile number, but the invite is for sms login, don't do anything either. They won't have a phone number if they signed up via an email_auth invite previously.\r\n\r\nin these cases, we accept the invite and add the user to the service as normal, however, just don't update the user's auth type.\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/notifications-admin/issues/comments/344685570","html_url":"https://github.com/alphagov/notifications-admin/pull/1649#issuecomment-344685570","issue_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/1649","id":344685570,"user":{"login":"kentsanggds","id":22152807,"avatar_url":"https://avatars1.githubusercontent.com/u/22152807?v=4","gravatar_id":"","url":"https://api.github.com/users/kentsanggds","html_url":"https://github.com/kentsanggds","followers_url":"https://api.github.com/users/kentsanggds/followers","following_url":"https://api.github.com/users/kentsanggds/following{/other_user}","gists_url":"https://api.github.com/users/kentsanggds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentsanggds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentsanggds/subscriptions","organizations_url":"https://api.github.com/users/kentsanggds/orgs","repos_url":"https://api.github.com/users/kentsanggds/repos","events_url":"https://api.github.com/users/kentsanggds/events{/privacy}","received_events_url":"https://api.github.com/users/kentsanggds/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T18:33:16Z","updated_at":"2017-11-15T18:33:16Z","author_association":"CONTRIBUTOR","body":"Not sure if this is a concern as it's an edge case but if you turn off the edit user auth, there is no indication of what type of user auth they log in with? "}}
{"actor":{"display_login":"kentsanggds"}}