{"action":"created","comment":{"url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/comments/114636505","pull_request_review_id":36120092,"id":114636505,"diff_hunk":"@@ -0,0 +1,399 @@\n+meta:\n+  zones:\n+    z1: (( properties.template_only.aws.availability_zone ))\n+    z2: (( properties.template_only.aws.availability_zone2 ))\n+\n+  elbs: (( merge ))\n+\n+  fog_config:\n+    provider: AWS\n+    use_iam_profile: true\n+    region: (( properties.template_only.aws.region ))\n+\n+  aws:\n+    key_name: ~\n+\n+properties:\n+  <<: (( merge ))\n+  template_only: (( merge ))\n+\n+  logger_endpoint:\n+    port: 443\n+\n+  loggregator:\n+    <<: (( merge ))\n+    blacklisted_syslog_ranges:\n+    - start: 10.8.0.0\n+      end: 10.8.255.255\n+\n+  cc:\n+    resource_pool:\n+      blobstore_type: fog\n+      fog_connection: (( meta.fog_config ))\n+      fog_aws_storage_options:\n+        encryption: AES256\n+    packages:\n+      blobstore_type: fog\n+      fog_connection: (( meta.fog_config ))\n+      fog_aws_storage_options:\n+        encryption: AES256\n+    droplets:\n+      blobstore_type: fog\n+      fog_connection: (( meta.fog_config ))\n+      fog_aws_storage_options:\n+        encryption: AES256\n+    buildpacks:\n+      blobstore_type: fog\n+      fog_connection: (( meta.fog_config ))\n+      fog_aws_storage_options:\n+        encryption: AES256\n+\n+  uaa:\n+    port: 8081\n+\n+  dea_next:\n+    deny_networks:\n+      - 169.254.0.0/16 # AWS Status\n+      - 10.8.1.0/16\n+    allow_networks: (( merge || [\"10.8.1.2/32\",\"10.8.2.2/32\", \"10.8.3.0/24\", \"10.8.4.0/24\"] )) # Amazon DNS and services","path":"cf-infrastructure-aws-development.yml","position":58,"original_position":58,"commit_id":"31db2f90b0f8fccef5e070f91ce0e23a22283b0a","original_commit_id":"9d34ca81ea9a91ce294ebc39424c615e6b616ba8","user":{"login":"LinuxBozo","id":723420,"avatar_url":"https://avatars0.githubusercontent.com/u/723420?v=3","gravatar_id":"","url":"https://api.github.com/users/LinuxBozo","html_url":"https://github.com/LinuxBozo","followers_url":"https://api.github.com/users/LinuxBozo/followers","following_url":"https://api.github.com/users/LinuxBozo/following{/other_user}","gists_url":"https://api.github.com/users/LinuxBozo/gists{/gist_id}","starred_url":"https://api.github.com/users/LinuxBozo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinuxBozo/subscriptions","organizations_url":"https://api.github.com/users/LinuxBozo/orgs","repos_url":"https://api.github.com/users/LinuxBozo/repos","events_url":"https://api.github.com/users/LinuxBozo/events{/privacy}","received_events_url":"https://api.github.com/users/LinuxBozo/received_events","type":"User","site_admin":false},"body":"I get where you both are coming from (and agree) but this wasn't about total refactoring, just simple dev proof of concept. If it were, there would be quite a bit more yanked out here, and more pulled in, e.g., `cg-deploy-diego` repo would be completely deprecated. We can go down that road, but I was looking to attack that work further in the PI as part of other refactoring efforts, and get this card closed out (since this technically should meet the AC)","created_at":"2017-05-03T19:49:06Z","updated_at":"2017-05-03T19:49:06Z","html_url":"https://github.com/18F/cg-deploy-cf/pull/209#discussion_r114636505","pull_request_url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/comments/114636505"},"html":{"href":"https://github.com/18F/cg-deploy-cf/pull/209#discussion_r114636505"},"pull_request":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209","id":118792884,"html_url":"https://github.com/18F/cg-deploy-cf/pull/209","diff_url":"https://github.com/18F/cg-deploy-cf/pull/209.diff","patch_url":"https://github.com/18F/cg-deploy-cf/pull/209.patch","issue_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues/209","number":209,"state":"open","locked":false,"title":"Diego in CF pipeline","user":{"login":"LinuxBozo","id":723420,"avatar_url":"https://avatars0.githubusercontent.com/u/723420?v=3","gravatar_id":"","url":"https://api.github.com/users/LinuxBozo","html_url":"https://github.com/LinuxBozo","followers_url":"https://api.github.com/users/LinuxBozo/followers","following_url":"https://api.github.com/users/LinuxBozo/following{/other_user}","gists_url":"https://api.github.com/users/LinuxBozo/gists{/gist_id}","starred_url":"https://api.github.com/users/LinuxBozo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinuxBozo/subscriptions","organizations_url":"https://api.github.com/users/LinuxBozo/orgs","repos_url":"https://api.github.com/users/LinuxBozo/repos","events_url":"https://api.github.com/users/LinuxBozo/events{/privacy}","received_events_url":"https://api.github.com/users/LinuxBozo/received_events","type":"User","site_admin":false},"body":"This addresses https://favro.com/card/1e11108a2da81e3bd7153a7a/18F-2352\r\nThis is not a complete refactor, just bringing in the development environment, and what a combined pipeline might look like. It still relies on the [cg-deploy-diego](https://github.com/18F/cg-deploy-diego) repo for manifests and such.\r\n\r\nAfter some review, will fly to Concourse.\r\nCan see what pipeline will look like here: https://ci.fr-stage.cloud.gov/teams/main/pipelines/deploy-cf?groups=all","created_at":"2017-05-03T15:43:29Z","updated_at":"2017-05-03T19:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"355ef5b9b5ebdc803676fe9ae58fab163acfd1b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209/commits","review_comments_url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209/comments","review_comment_url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues/209/comments","statuses_url":"https://api.github.com/repos/18F/cg-deploy-cf/statuses/31db2f90b0f8fccef5e070f91ce0e23a22283b0a","head":{"label":"18F:rogeruiz/dev","ref":"rogeruiz/dev","sha":"31db2f90b0f8fccef5e070f91ce0e23a22283b0a","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars3.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":52111805,"name":"cg-deploy-cf","full_name":"18F/cg-deploy-cf","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars3.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cg-deploy-cf","description":"Concourse pipeline and manifests for the 18F Cloud Foundry deployment.","fork":false,"url":"https://api.github.com/repos/18F/cg-deploy-cf","forks_url":"https://api.github.com/repos/18F/cg-deploy-cf/forks","keys_url":"https://api.github.com/repos/18F/cg-deploy-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cg-deploy-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cg-deploy-cf/teams","hooks_url":"https://api.github.com/repos/18F/cg-deploy-cf/hooks","issue_events_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cg-deploy-cf/events","assignees_url":"https://api.github.com/repos/18F/cg-deploy-cf/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cg-deploy-cf/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cg-deploy-cf/tags","blobs_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cg-deploy-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cg-deploy-cf/languages","stargazers_url":"https://api.github.com/repos/18F/cg-deploy-cf/stargazers","contributors_url":"https://api.github.com/repos/18F/cg-deploy-cf/contributors","subscribers_url":"https://api.github.com/repos/18F/cg-deploy-cf/subscribers","subscription_url":"https://api.github.com/repos/18F/cg-deploy-cf/subscription","commits_url":"https://api.github.com/repos/18F/cg-deploy-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cg-deploy-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cg-deploy-cf/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cg-deploy-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cg-deploy-cf/merges","archive_url":"https://api.github.com/repos/18F/cg-deploy-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cg-deploy-cf/downloads","issues_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cg-deploy-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cg-deploy-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cg-deploy-cf/labels{/name}","releases_url":"https://api.github.com/repos/18F/cg-deploy-cf/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cg-deploy-cf/deployments","created_at":"2016-02-19T19:39:01Z","updated_at":"2017-04-07T17:28:03Z","pushed_at":"2017-05-03T19:47:13Z","git_url":"git://github.com/18F/cg-deploy-cf.git","ssh_url":"git@github.com:18F/cg-deploy-cf.git","clone_url":"https://github.com/18F/cg-deploy-cf.git","svn_url":"https://github.com/18F/cg-deploy-cf","homepage":null,"size":424,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":7,"default_branch":"staging"}},"base":{"label":"18F:staging","ref":"staging","sha":"e0402f99b08cfd2d718975ea3c919b4f5e4c08ea","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars3.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":52111805,"name":"cg-deploy-cf","full_name":"18F/cg-deploy-cf","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars3.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cg-deploy-cf","description":"Concourse pipeline and manifests for the 18F Cloud Foundry deployment.","fork":false,"url":"https://api.github.com/repos/18F/cg-deploy-cf","forks_url":"https://api.github.com/repos/18F/cg-deploy-cf/forks","keys_url":"https://api.github.com/repos/18F/cg-deploy-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cg-deploy-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cg-deploy-cf/teams","hooks_url":"https://api.github.com/repos/18F/cg-deploy-cf/hooks","issue_events_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cg-deploy-cf/events","assignees_url":"https://api.github.com/repos/18F/cg-deploy-cf/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cg-deploy-cf/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cg-deploy-cf/tags","blobs_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cg-deploy-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cg-deploy-cf/languages","stargazers_url":"https://api.github.com/repos/18F/cg-deploy-cf/stargazers","contributors_url":"https://api.github.com/repos/18F/cg-deploy-cf/contributors","subscribers_url":"https://api.github.com/repos/18F/cg-deploy-cf/subscribers","subscription_url":"https://api.github.com/repos/18F/cg-deploy-cf/subscription","commits_url":"https://api.github.com/repos/18F/cg-deploy-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cg-deploy-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cg-deploy-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cg-deploy-cf/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cg-deploy-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cg-deploy-cf/merges","archive_url":"https://api.github.com/repos/18F/cg-deploy-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cg-deploy-cf/downloads","issues_url":"https://api.github.com/repos/18F/cg-deploy-cf/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cg-deploy-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cg-deploy-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cg-deploy-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cg-deploy-cf/labels{/name}","releases_url":"https://api.github.com/repos/18F/cg-deploy-cf/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cg-deploy-cf/deployments","created_at":"2016-02-19T19:39:01Z","updated_at":"2017-04-07T17:28:03Z","pushed_at":"2017-05-03T19:47:13Z","git_url":"git://github.com/18F/cg-deploy-cf.git","ssh_url":"git@github.com:18F/cg-deploy-cf.git","clone_url":"https://github.com/18F/cg-deploy-cf.git","svn_url":"https://github.com/18F/cg-deploy-cf","homepage":null,"size":424,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":7,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209"},"html":{"href":"https://github.com/18F/cg-deploy-cf/pull/209"},"issue":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/issues/209"},"comments":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/18F/cg-deploy-cf/statuses/31db2f90b0f8fccef5e070f91ce0e23a22283b0a"}}}}
{"actor":{"display_login":"LinuxBozo"}}