{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/10","id":121034877,"html_url":"https://github.com/whdlgp/ARMv6m_Simulator/pull/10","diff_url":"https://github.com/whdlgp/ARMv6m_Simulator/pull/10.diff","patch_url":"https://github.com/whdlgp/ARMv6m_Simulator/pull/10.patch","issue_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/10","number":10,"state":"closed","locked":false,"title":"UDF executed, automatically PC + 2","user":{"login":"whdlgp","id":12744720,"avatar_url":"https://avatars3.githubusercontent.com/u/12744720?v=3","gravatar_id":"","url":"https://api.github.com/users/whdlgp","html_url":"https://github.com/whdlgp","followers_url":"https://api.github.com/users/whdlgp/followers","following_url":"https://api.github.com/users/whdlgp/following{/other_user}","gists_url":"https://api.github.com/users/whdlgp/gists{/gist_id}","starred_url":"https://api.github.com/users/whdlgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whdlgp/subscriptions","organizations_url":"https://api.github.com/users/whdlgp/orgs","repos_url":"https://api.github.com/users/whdlgp/repos","events_url":"https://api.github.com/users/whdlgp/events{/privacy}","received_events_url":"https://api.github.com/users/whdlgp/received_events","type":"User","site_admin":false},"body":"First of all, I'm sorry to have done it merge.\r\n\r\nI read that it might violate the original [pinkySim](https://github.com/adamgreen/pinkySim) spirit that Andrea Barisani sent me, and I looked at the test behavior of that repository.\r\n\r\n```cpp\r\nTEST(adr, pcWillNeedToBeWordAlignedBeforeAdd)\r\n{\r\n    // Emit UNDEFINED 16-bit instruction.\r\n    emitInstruction16(\"1101111000000000\");\r\n    // Emit actual test instruction at a 2-byte aligned address which isn't 4-byte aligned.\r\n    emitInstruction16(\"10100dddiiiiiiii\", R3, 0);\r\n    setRegisterValue(PC, INITIAL_PC + 2);\r\n    setExpectedRegisterValue(R3, INITIAL_PC + 4);\r\n    pinkySimStep(&m_context);\r\n}\r\n```\r\n\r\nin this test, Initially, I expected pinkysim's emitInstruction16 to be executed right away, as in our simulator test suite, but not in actual operation.\r\n\r\nHowever, emitInstruction16 was to pre-write the instruction to be executed in the memory space, and setRegisterValue was to pre-specify the register state before execution.\r\n\r\n```cpp\r\n    // Emit UNDEFINED 16-bit instruction.\r\n    emitInstruction16(\"1101111000000000\");\r\n    // Emit actual test instruction at a 2-byte aligned address which isn't 4-byte aligned.\r\n    emitInstruction16(\"10100dddiiiiiiii\", R3, 0);\r\n    setRegisterValue(PC, INITIAL_PC + 2);\r\n    setExpectedRegisterValue(R3, INITIAL_PC + 4);\r\n```\r\n\r\nTherefore, when the source is executed as above, the memory space is as follows, and the PC points to the ADR instruction as follows.\r\n\r\n![](http://i.imgur.com/Hj3ayHk.jpg)\r\n\r\nSo, test in pinkySim means, in other words, that the UDF has already been executed and PC + 2.\r\n\r\nTherefore, this part is unnecessary in our simulator. Because we run the UDF and automatically add two PC values.\r\n\r\n```cpp\r\n    setRegisterValue(PC, INITIAL_PC + 2); //already added. Don't need to do this\r\n```\r\n\r\nThis pull request has a commit that removes the \"set PC value unnecessarily\".\r\n\r\nI had to check these parts and merge them, but I'm sorry to have to merge them. If there is something wrong with my understanding, please ask me for a comment.\r\n\r\nBest Regards,","created_at":"2017-05-17T11:32:35Z","updated_at":"2017-05-17T11:50:21Z","closed_at":"2017-05-17T11:50:21Z","merged_at":"2017-05-17T11:50:21Z","merge_commit_sha":"8a4935e5d078c5977652513d78e6e211771f9c25","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/10/commits","review_comments_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/10/comments","review_comment_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/10/comments","statuses_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/statuses/d9a7f01974997cf0909b047c2f0b563062bdda73","head":{"label":"whdlgp:adr_pc_fix","ref":"adr_pc_fix","sha":"d9a7f01974997cf0909b047c2f0b563062bdda73","user":{"login":"whdlgp","id":12744720,"avatar_url":"https://avatars3.githubusercontent.com/u/12744720?v=3","gravatar_id":"","url":"https://api.github.com/users/whdlgp","html_url":"https://github.com/whdlgp","followers_url":"https://api.github.com/users/whdlgp/followers","following_url":"https://api.github.com/users/whdlgp/following{/other_user}","gists_url":"https://api.github.com/users/whdlgp/gists{/gist_id}","starred_url":"https://api.github.com/users/whdlgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whdlgp/subscriptions","organizations_url":"https://api.github.com/users/whdlgp/orgs","repos_url":"https://api.github.com/users/whdlgp/repos","events_url":"https://api.github.com/users/whdlgp/events{/privacy}","received_events_url":"https://api.github.com/users/whdlgp/received_events","type":"User","site_admin":false},"repo":{"id":76018569,"name":"ARMv6m_Simulator","full_name":"whdlgp/ARMv6m_Simulator","owner":{"login":"whdlgp","id":12744720,"avatar_url":"https://avatars3.githubusercontent.com/u/12744720?v=3","gravatar_id":"","url":"https://api.github.com/users/whdlgp","html_url":"https://github.com/whdlgp","followers_url":"https://api.github.com/users/whdlgp/followers","following_url":"https://api.github.com/users/whdlgp/following{/other_user}","gists_url":"https://api.github.com/users/whdlgp/gists{/gist_id}","starred_url":"https://api.github.com/users/whdlgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whdlgp/subscriptions","organizations_url":"https://api.github.com/users/whdlgp/orgs","repos_url":"https://api.github.com/users/whdlgp/repos","events_url":"https://api.github.com/users/whdlgp/events{/privacy}","received_events_url":"https://api.github.com/users/whdlgp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whdlgp/ARMv6m_Simulator","description":"Simple Simulator of ARMv6m instructions","fork":false,"url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator","forks_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/forks","keys_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/teams","hooks_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/hooks","issue_events_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/events{/number}","events_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/events","assignees_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/assignees{/user}","branches_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/branches{/branch}","tags_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/tags","blobs_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/languages","stargazers_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/stargazers","contributors_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/contributors","subscribers_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/subscribers","subscription_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/subscription","commits_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/contents/{+path}","compare_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/merges","archive_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/downloads","issues_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues{/number}","pulls_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/labels{/name}","releases_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/releases{/id}","deployments_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/deployments","created_at":"2016-12-09T08:54:06Z","updated_at":"2017-05-12T03:40:55Z","pushed_at":"2017-05-17T11:50:21Z","git_url":"git://github.com/whdlgp/ARMv6m_Simulator.git","ssh_url":"git@github.com:whdlgp/ARMv6m_Simulator.git","clone_url":"https://github.com/whdlgp/ARMv6m_Simulator.git","svn_url":"https://github.com/whdlgp/ARMv6m_Simulator","homepage":null,"size":430,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"whdlgp:master","ref":"master","sha":"60a7280e8f9e48fe9c5e3c46f74e5367dfe855b4","user":{"login":"whdlgp","id":12744720,"avatar_url":"https://avatars3.githubusercontent.com/u/12744720?v=3","gravatar_id":"","url":"https://api.github.com/users/whdlgp","html_url":"https://github.com/whdlgp","followers_url":"https://api.github.com/users/whdlgp/followers","following_url":"https://api.github.com/users/whdlgp/following{/other_user}","gists_url":"https://api.github.com/users/whdlgp/gists{/gist_id}","starred_url":"https://api.github.com/users/whdlgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whdlgp/subscriptions","organizations_url":"https://api.github.com/users/whdlgp/orgs","repos_url":"https://api.github.com/users/whdlgp/repos","events_url":"https://api.github.com/users/whdlgp/events{/privacy}","received_events_url":"https://api.github.com/users/whdlgp/received_events","type":"User","site_admin":false},"repo":{"id":76018569,"name":"ARMv6m_Simulator","full_name":"whdlgp/ARMv6m_Simulator","owner":{"login":"whdlgp","id":12744720,"avatar_url":"https://avatars3.githubusercontent.com/u/12744720?v=3","gravatar_id":"","url":"https://api.github.com/users/whdlgp","html_url":"https://github.com/whdlgp","followers_url":"https://api.github.com/users/whdlgp/followers","following_url":"https://api.github.com/users/whdlgp/following{/other_user}","gists_url":"https://api.github.com/users/whdlgp/gists{/gist_id}","starred_url":"https://api.github.com/users/whdlgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whdlgp/subscriptions","organizations_url":"https://api.github.com/users/whdlgp/orgs","repos_url":"https://api.github.com/users/whdlgp/repos","events_url":"https://api.github.com/users/whdlgp/events{/privacy}","received_events_url":"https://api.github.com/users/whdlgp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whdlgp/ARMv6m_Simulator","description":"Simple Simulator of ARMv6m instructions","fork":false,"url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator","forks_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/forks","keys_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/teams","hooks_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/hooks","issue_events_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/events{/number}","events_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/events","assignees_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/assignees{/user}","branches_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/branches{/branch}","tags_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/tags","blobs_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/languages","stargazers_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/stargazers","contributors_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/contributors","subscribers_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/subscribers","subscription_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/subscription","commits_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/contents/{+path}","compare_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/merges","archive_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/downloads","issues_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues{/number}","pulls_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/labels{/name}","releases_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/releases{/id}","deployments_url":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/deployments","created_at":"2016-12-09T08:54:06Z","updated_at":"2017-05-12T03:40:55Z","pushed_at":"2017-05-17T11:50:21Z","git_url":"git://github.com/whdlgp/ARMv6m_Simulator.git","ssh_url":"git@github.com:whdlgp/ARMv6m_Simulator.git","clone_url":"https://github.com/whdlgp/ARMv6m_Simulator.git","svn_url":"https://github.com/whdlgp/ARMv6m_Simulator","homepage":null,"size":430,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/10"},"html":{"href":"https://github.com/whdlgp/ARMv6m_Simulator/pull/10"},"issue":{"href":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/10"},"comments":{"href":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/whdlgp/ARMv6m_Simulator/statuses/d9a7f01974997cf0909b047c2f0b563062bdda73"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"abarisani","id":8976118,"avatar_url":"https://avatars1.githubusercontent.com/u/8976118?v=3","gravatar_id":"","url":"https://api.github.com/users/abarisani","html_url":"https://github.com/abarisani","followers_url":"https://api.github.com/users/abarisani/followers","following_url":"https://api.github.com/users/abarisani/following{/other_user}","gists_url":"https://api.github.com/users/abarisani/gists{/gist_id}","starred_url":"https://api.github.com/users/abarisani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarisani/subscriptions","organizations_url":"https://api.github.com/users/abarisani/orgs","repos_url":"https://api.github.com/users/abarisani/repos","events_url":"https://api.github.com/users/abarisani/events{/privacy}","received_events_url":"https://api.github.com/users/abarisani/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"abarisani"}}