{"action":"closed","number":78,"pull_request":{"url":"https://api.github.com/repos/amagnasco/xwpe/pulls/78","id":135045767,"html_url":"https://github.com/amagnasco/xwpe/pull/78","diff_url":"https://github.com/amagnasco/xwpe/pull/78.diff","patch_url":"https://github.com/amagnasco/xwpe/pull/78.patch","issue_url":"https://api.github.com/repos/amagnasco/xwpe/issues/78","number":78,"state":"closed","locked":false,"title":"Cleanup2: repair of search / replace","user":{"login":"gbonnema","id":2283947,"avatar_url":"https://avatars1.githubusercontent.com/u/2283947?v=4","gravatar_id":"","url":"https://api.github.com/users/gbonnema","html_url":"https://github.com/gbonnema","followers_url":"https://api.github.com/users/gbonnema/followers","following_url":"https://api.github.com/users/gbonnema/following{/other_user}","gists_url":"https://api.github.com/users/gbonnema/gists{/gist_id}","starred_url":"https://api.github.com/users/gbonnema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbonnema/subscriptions","organizations_url":"https://api.github.com/users/gbonnema/orgs","repos_url":"https://api.github.com/users/gbonnema/repos","events_url":"https://api.github.com/users/gbonnema/events{/privacy}","received_events_url":"https://api.github.com/users/gbonnema/received_events","type":"User","site_admin":false},"body":"This branch is a cleanup, but also a repair of the replace that did not work properly in combination with undo and redo. Undo followed by redo messed up the text. The cause was a oneliner in the base function for both undo and redo: e_make_rudo, where the length taken was the wrong one.\r\n\r\nThis is only one step in this intracate piece of programming. The other pieces are block copy, block delete, block paste, and character insertion and deletion. They all are intracately connected to undo / redo and share a lot of complex code. They are for a next refactoring and bugfix action lateron.\r\n\r\nI also corrected a missing library that was only missing on Ubuntu. The test library `check` was apparantly split in to `libcheck` and `libsubunit`. On Fedora this is not the case, so I noticed nothing while travis had errors. I connected to travis to my own repo so I will know whether travis will run or not when I do a pull request to your repo.","created_at":"2017-08-10T05:47:03Z","updated_at":"2017-08-10T05:56:19Z","closed_at":"2017-08-10T05:56:19Z","merged_at":"2017-08-10T05:56:19Z","merge_commit_sha":"c6cc2e3818a6fc2c2fe12ab8dcc3f17f53d3fa88","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/amagnasco/xwpe/pulls/78/commits","review_comments_url":"https://api.github.com/repos/amagnasco/xwpe/pulls/78/comments","review_comment_url":"https://api.github.com/repos/amagnasco/xwpe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amagnasco/xwpe/issues/78/comments","statuses_url":"https://api.github.com/repos/amagnasco/xwpe/statuses/c4f6d47690bd162ff50c93dd5bb39d53c1b8299a","head":{"label":"gbonnema:cleanup2","ref":"cleanup2","sha":"c4f6d47690bd162ff50c93dd5bb39d53c1b8299a","user":{"login":"gbonnema","id":2283947,"avatar_url":"https://avatars1.githubusercontent.com/u/2283947?v=4","gravatar_id":"","url":"https://api.github.com/users/gbonnema","html_url":"https://github.com/gbonnema","followers_url":"https://api.github.com/users/gbonnema/followers","following_url":"https://api.github.com/users/gbonnema/following{/other_user}","gists_url":"https://api.github.com/users/gbonnema/gists{/gist_id}","starred_url":"https://api.github.com/users/gbonnema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbonnema/subscriptions","organizations_url":"https://api.github.com/users/gbonnema/orgs","repos_url":"https://api.github.com/users/gbonnema/repos","events_url":"https://api.github.com/users/gbonnema/events{/privacy}","received_events_url":"https://api.github.com/users/gbonnema/received_events","type":"User","site_admin":false},"repo":{"id":91453619,"name":"xwpe","full_name":"gbonnema/xwpe","owner":{"login":"gbonnema","id":2283947,"avatar_url":"https://avatars1.githubusercontent.com/u/2283947?v=4","gravatar_id":"","url":"https://api.github.com/users/gbonnema","html_url":"https://github.com/gbonnema","followers_url":"https://api.github.com/users/gbonnema/followers","following_url":"https://api.github.com/users/gbonnema/following{/other_user}","gists_url":"https://api.github.com/users/gbonnema/gists{/gist_id}","starred_url":"https://api.github.com/users/gbonnema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbonnema/subscriptions","organizations_url":"https://api.github.com/users/gbonnema/orgs","repos_url":"https://api.github.com/users/gbonnema/repos","events_url":"https://api.github.com/users/gbonnema/events{/privacy}","received_events_url":"https://api.github.com/users/gbonnema/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbonnema/xwpe","description":"An ncurses-based programming environment, copied from abandoned project on","fork":true,"url":"https://api.github.com/repos/gbonnema/xwpe","forks_url":"https://api.github.com/repos/gbonnema/xwpe/forks","keys_url":"https://api.github.com/repos/gbonnema/xwpe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbonnema/xwpe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbonnema/xwpe/teams","hooks_url":"https://api.github.com/repos/gbonnema/xwpe/hooks","issue_events_url":"https://api.github.com/repos/gbonnema/xwpe/issues/events{/number}","events_url":"https://api.github.com/repos/gbonnema/xwpe/events","assignees_url":"https://api.github.com/repos/gbonnema/xwpe/assignees{/user}","branches_url":"https://api.github.com/repos/gbonnema/xwpe/branches{/branch}","tags_url":"https://api.github.com/repos/gbonnema/xwpe/tags","blobs_url":"https://api.github.com/repos/gbonnema/xwpe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbonnema/xwpe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbonnema/xwpe/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbonnema/xwpe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbonnema/xwpe/statuses/{sha}","languages_url":"https://api.github.com/repos/gbonnema/xwpe/languages","stargazers_url":"https://api.github.com/repos/gbonnema/xwpe/stargazers","contributors_url":"https://api.github.com/repos/gbonnema/xwpe/contributors","subscribers_url":"https://api.github.com/repos/gbonnema/xwpe/subscribers","subscription_url":"https://api.github.com/repos/gbonnema/xwpe/subscription","commits_url":"https://api.github.com/repos/gbonnema/xwpe/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbonnema/xwpe/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbonnema/xwpe/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbonnema/xwpe/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbonnema/xwpe/contents/{+path}","compare_url":"https://api.github.com/repos/gbonnema/xwpe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbonnema/xwpe/merges","archive_url":"https://api.github.com/repos/gbonnema/xwpe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbonnema/xwpe/downloads","issues_url":"https://api.github.com/repos/gbonnema/xwpe/issues{/number}","pulls_url":"https://api.github.com/repos/gbonnema/xwpe/pulls{/number}","milestones_url":"https://api.github.com/repos/gbonnema/xwpe/milestones{/number}","notifications_url":"https://api.github.com/repos/gbonnema/xwpe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbonnema/xwpe/labels{/name}","releases_url":"https://api.github.com/repos/gbonnema/xwpe/releases{/id}","deployments_url":"https://api.github.com/repos/gbonnema/xwpe/deployments","created_at":"2017-05-16T12:04:39Z","updated_at":"2017-08-09T09:05:02Z","pushed_at":"2017-08-09T11:52:24Z","git_url":"git://github.com/gbonnema/xwpe.git","ssh_url":"git@github.com:gbonnema/xwpe.git","clone_url":"https://github.com/gbonnema/xwpe.git","svn_url":"https://github.com/gbonnema/xwpe","homepage":"http://www.identicalsoftware.com/xwpe/","size":2175,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amagnasco:experimental","ref":"experimental","sha":"659fe6aa781156e5de18ab8ab23e3a0b5e6f7cb1","user":{"login":"amagnasco","id":13786028,"avatar_url":"https://avatars2.githubusercontent.com/u/13786028?v=4","gravatar_id":"","url":"https://api.github.com/users/amagnasco","html_url":"https://github.com/amagnasco","followers_url":"https://api.github.com/users/amagnasco/followers","following_url":"https://api.github.com/users/amagnasco/following{/other_user}","gists_url":"https://api.github.com/users/amagnasco/gists{/gist_id}","starred_url":"https://api.github.com/users/amagnasco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amagnasco/subscriptions","organizations_url":"https://api.github.com/users/amagnasco/orgs","repos_url":"https://api.github.com/users/amagnasco/repos","events_url":"https://api.github.com/users/amagnasco/events{/privacy}","received_events_url":"https://api.github.com/users/amagnasco/received_events","type":"User","site_admin":false},"repo":{"id":50188366,"name":"xwpe","full_name":"amagnasco/xwpe","owner":{"login":"amagnasco","id":13786028,"avatar_url":"https://avatars2.githubusercontent.com/u/13786028?v=4","gravatar_id":"","url":"https://api.github.com/users/amagnasco","html_url":"https://github.com/amagnasco","followers_url":"https://api.github.com/users/amagnasco/followers","following_url":"https://api.github.com/users/amagnasco/following{/other_user}","gists_url":"https://api.github.com/users/amagnasco/gists{/gist_id}","starred_url":"https://api.github.com/users/amagnasco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amagnasco/subscriptions","organizations_url":"https://api.github.com/users/amagnasco/orgs","repos_url":"https://api.github.com/users/amagnasco/repos","events_url":"https://api.github.com/users/amagnasco/events{/privacy}","received_events_url":"https://api.github.com/users/amagnasco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amagnasco/xwpe","description":"Upload of an abandoned ncurses-based programming environment","fork":false,"url":"https://api.github.com/repos/amagnasco/xwpe","forks_url":"https://api.github.com/repos/amagnasco/xwpe/forks","keys_url":"https://api.github.com/repos/amagnasco/xwpe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amagnasco/xwpe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amagnasco/xwpe/teams","hooks_url":"https://api.github.com/repos/amagnasco/xwpe/hooks","issue_events_url":"https://api.github.com/repos/amagnasco/xwpe/issues/events{/number}","events_url":"https://api.github.com/repos/amagnasco/xwpe/events","assignees_url":"https://api.github.com/repos/amagnasco/xwpe/assignees{/user}","branches_url":"https://api.github.com/repos/amagnasco/xwpe/branches{/branch}","tags_url":"https://api.github.com/repos/amagnasco/xwpe/tags","blobs_url":"https://api.github.com/repos/amagnasco/xwpe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amagnasco/xwpe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amagnasco/xwpe/git/refs{/sha}","trees_url":"https://api.github.com/repos/amagnasco/xwpe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amagnasco/xwpe/statuses/{sha}","languages_url":"https://api.github.com/repos/amagnasco/xwpe/languages","stargazers_url":"https://api.github.com/repos/amagnasco/xwpe/stargazers","contributors_url":"https://api.github.com/repos/amagnasco/xwpe/contributors","subscribers_url":"https://api.github.com/repos/amagnasco/xwpe/subscribers","subscription_url":"https://api.github.com/repos/amagnasco/xwpe/subscription","commits_url":"https://api.github.com/repos/amagnasco/xwpe/commits{/sha}","git_commits_url":"https://api.github.com/repos/amagnasco/xwpe/git/commits{/sha}","comments_url":"https://api.github.com/repos/amagnasco/xwpe/comments{/number}","issue_comment_url":"https://api.github.com/repos/amagnasco/xwpe/issues/comments{/number}","contents_url":"https://api.github.com/repos/amagnasco/xwpe/contents/{+path}","compare_url":"https://api.github.com/repos/amagnasco/xwpe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amagnasco/xwpe/merges","archive_url":"https://api.github.com/repos/amagnasco/xwpe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amagnasco/xwpe/downloads","issues_url":"https://api.github.com/repos/amagnasco/xwpe/issues{/number}","pulls_url":"https://api.github.com/repos/amagnasco/xwpe/pulls{/number}","milestones_url":"https://api.github.com/repos/amagnasco/xwpe/milestones{/number}","notifications_url":"https://api.github.com/repos/amagnasco/xwpe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amagnasco/xwpe/labels{/name}","releases_url":"https://api.github.com/repos/amagnasco/xwpe/releases{/id}","deployments_url":"https://api.github.com/repos/amagnasco/xwpe/deployments","created_at":"2016-01-22T15:09:34Z","updated_at":"2017-06-04T22:13:26Z","pushed_at":"2017-08-10T05:56:19Z","git_url":"git://github.com/amagnasco/xwpe.git","ssh_url":"git@github.com:amagnasco/xwpe.git","clone_url":"https://github.com/amagnasco/xwpe.git","svn_url":"https://github.com/amagnasco/xwpe","homepage":"http://www.identicalsoftware.com/xwpe/","size":2935,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":36,"forks":1,"open_issues":36,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amagnasco/xwpe/pulls/78"},"html":{"href":"https://github.com/amagnasco/xwpe/pull/78"},"issue":{"href":"https://api.github.com/repos/amagnasco/xwpe/issues/78"},"comments":{"href":"https://api.github.com/repos/amagnasco/xwpe/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/amagnasco/xwpe/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/amagnasco/xwpe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amagnasco/xwpe/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/amagnasco/xwpe/statuses/c4f6d47690bd162ff50c93dd5bb39d53c1b8299a"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gbonnema","id":2283947,"avatar_url":"https://avatars1.githubusercontent.com/u/2283947?v=4","gravatar_id":"","url":"https://api.github.com/users/gbonnema","html_url":"https://github.com/gbonnema","followers_url":"https://api.github.com/users/gbonnema/followers","following_url":"https://api.github.com/users/gbonnema/following{/other_user}","gists_url":"https://api.github.com/users/gbonnema/gists{/gist_id}","starred_url":"https://api.github.com/users/gbonnema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbonnema/subscriptions","organizations_url":"https://api.github.com/users/gbonnema/orgs","repos_url":"https://api.github.com/users/gbonnema/repos","events_url":"https://api.github.com/users/gbonnema/events{/privacy}","received_events_url":"https://api.github.com/users/gbonnema/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":21,"additions":1691,"deletions":25186,"changed_files":58}}
{"actor":{"display_login":"gbonnema"}}