{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-cli/issues/2893","repository_url":"https://api.github.com/repos/aws/aws-cli","labels_url":"https://api.github.com/repos/aws/aws-cli/issues/2893/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-cli/issues/2893/comments","events_url":"https://api.github.com/repos/aws/aws-cli/issues/2893/events","html_url":"https://github.com/aws/aws-cli/issues/2893","id":265311315,"number":2893,"title":"Weird zip behavior during \"aws deploy push\"","user":{"login":"ylmrx","id":12843753,"avatar_url":"https://avatars0.githubusercontent.com/u/12843753?v=4","gravatar_id":"","url":"https://api.github.com/users/ylmrx","html_url":"https://github.com/ylmrx","followers_url":"https://api.github.com/users/ylmrx/followers","following_url":"https://api.github.com/users/ylmrx/following{/other_user}","gists_url":"https://api.github.com/users/ylmrx/gists{/gist_id}","starred_url":"https://api.github.com/users/ylmrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylmrx/subscriptions","organizations_url":"https://api.github.com/users/ylmrx/orgs","repos_url":"https://api.github.com/users/ylmrx/repos","events_url":"https://api.github.com/users/ylmrx/events{/privacy}","received_events_url":"https://api.github.com/users/ylmrx/received_events","type":"User","site_admin":false},"labels":[{"id":217040864,"url":"https://api.github.com/repos/aws/aws-cli/labels/closing-soon-if-no-response","name":"closing-soon-if-no-response","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-13T14:35:31Z","updated_at":"2017-10-27T23:10:52Z","closed_at":null,"author_association":"NONE","body":"1. **the process fails harshly when zipping a folder > 4GB.**\r\n\r\nIt shows this debug trace : \r\n`10 error: 'L' format requires 0 <= number <= 4294967295`\r\n\r\nThat is, despite : `zf = zipfile.ZipFile(tf, 'w', allowZip64=True)` (allowZip64 flag **should** allow very large archive) [1]\r\n\r\n2. **the tmpfile is deleted at creation (but its FD is still being written to).**\r\n\r\nThis gave us a hard time when debugging this as we couldn't easily find the temporary file.\r\nI tried to zip a file with the relevant python lib and mimic the options you use : i couldn't reproduce this behavior.\r\nI feel the temporary file should be held visible.\r\n\r\n[1] -- `awscli/customizations/codedeploy/push.py` line 187\r\n\r\nCurrent awscli : `aws-cli/1.11.170 Python/2.7.3 Linux/3.14.79-cerberhost-0.11.0deb7+nbs20161028-grsec botocore/1.7.28`"},"comment":{"url":"https://api.github.com/repos/aws/aws-cli/issues/comments/340118437","html_url":"https://github.com/aws/aws-cli/issues/2893#issuecomment-340118437","issue_url":"https://api.github.com/repos/aws/aws-cli/issues/2893","id":340118437,"user":{"login":"ylmrx","id":12843753,"avatar_url":"https://avatars0.githubusercontent.com/u/12843753?v=4","gravatar_id":"","url":"https://api.github.com/users/ylmrx","html_url":"https://github.com/ylmrx","followers_url":"https://api.github.com/users/ylmrx/followers","following_url":"https://api.github.com/users/ylmrx/following{/other_user}","gists_url":"https://api.github.com/users/ylmrx/gists{/gist_id}","starred_url":"https://api.github.com/users/ylmrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylmrx/subscriptions","organizations_url":"https://api.github.com/users/ylmrx/orgs","repos_url":"https://api.github.com/users/ylmrx/repos","events_url":"https://api.github.com/users/ylmrx/events{/privacy}","received_events_url":"https://api.github.com/users/ylmrx/received_events","type":"User","site_admin":false},"created_at":"2017-10-27T23:10:52Z","updated_at":"2017-10-27T23:10:52Z","author_association":"NONE","body":"Hi :)\nI didn’t check that part. And the distribution we use is kinda outdated,\ndidn’t take the time to check the behavior on a fresher setup.\nThanks a lot for your time anyway.\n\nOn Sat 28 Oct 2017 at 00:46, Jordon Phillips <notifications@github.com>\nwrote:\n\n> @ylmrx <https://github.com/ylmrx> that looks like it's a python bug\n> <https://bugs.python.org/issue9720>. Unfortunately it looks like you'll\n> need to upgrade your python version to work around it. It looks like that\n> made it into python 2.7.4+ on the python 2 branch.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/aws/aws-cli/issues/2893#issuecomment-340114758>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AMP66fGAUZkltI7jHhJS9quCUng7CvuVks5swl1cgaJpZM4P4lTS>\n> .\n>\n"}}
{"actor":{"display_login":"ylmrx"}}