{"action":"created","issue":{"url":"https://api.github.com/repos/opendatakit/collect/issues/311","repository_url":"https://api.github.com/repos/opendatakit/collect","labels_url":"https://api.github.com/repos/opendatakit/collect/issues/311/labels{/name}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/311/comments","events_url":"https://api.github.com/repos/opendatakit/collect/issues/311/events","html_url":"https://github.com/opendatakit/collect/issues/311","id":196990035,"number":311,"title":"Separate form preloaded values for username, email from server settings","user":{"login":"lognaturel","id":967540,"avatar_url":"https://avatars0.githubusercontent.com/u/967540?v=3","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"labels":[{"id":244236113,"url":"https://api.github.com/repos/opendatakit/collect/labels/contributor%20friendly","name":"contributor friendly","color":"1d76db","default":false},{"id":474694259,"url":"https://api.github.com/repos/opendatakit/collect/labels/needs%20discussion","name":"needs discussion","color":"fbca04","default":false},{"id":474682718,"url":"https://api.github.com/repos/opendatakit/collect/labels/user%20experience","name":"user experience","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/opendatakit/collect/milestones/2","html_url":"https://github.com/opendatakit/collect/milestone/2","labels_url":"https://api.github.com/repos/opendatakit/collect/milestones/2/labels","id":2399053,"number":2,"title":"April Release","description":"","creator":{"login":"lognaturel","id":967540,"avatar_url":"https://avatars0.githubusercontent.com/u/967540?v=3","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2017-03-20T20:21:10Z","updated_at":"2017-03-22T15:20:31Z","due_on":"2017-04-26T07:00:00Z","closed_at":null},"comments":31,"created_at":"2016-12-21T17:32:41Z","updated_at":"2017-03-22T15:25:41Z","closed_at":null,"body":"#### Software and hardware versions \r\nCollect v1.4.12\r\n\r\n#### Problem description\r\nValues for preloaded username and email address fields in forms are pulled from the settings for username and google account, respectively. [This page](https://opendatakit.org/help/form-design/examples/#Property_values) has more information about adding preloaded fields to forms.  [This comment](https://github.com/opendatakit/collect/blob/81f8038c0723c023d1e1dbf360dc0de41a913798/collect_app/src/main/java/org/odk/collect/android/preferences/PreferencesActivity.java#L70) explains why the duplicate fields are there and [this code](https://github.com/opendatakit/collect/blob/81f8038c0723c023d1e1dbf360dc0de41a913798/collect_app/src/main/java/org/odk/collect/android/logic/PropertyManager.java#L135) sets the values of the preloaded fields.\r\n\r\nPreloaded values explain why Google account / username / password are shown on the settings screen in addition to in the Configure platform settings submenu. Having these settings values in two places makes the settings screen confusing. Additionally, the different configuration fields point to the same value which means that it's not possible to set identifying values for data collectors that are separate from server auth values. This is problematic because organizations often use the same username to connect to their servers across all data collectors.\r\n\r\n#### Steps to reproduce the problem\r\nGo to General Settings. See the username, password and google account fields that are also available in Configure Server Settings.\r\n\r\n#### Expected behavior\r\nServer settings should only be configurable from Configure Server Settings. Metadata values should be set separately.\r\n\r\nI propose to:\r\n1. Remove Google account, username and password from the Server Settings settings group\r\n1. <strike>Create a new settings group titled Form Metadata (other name suggestions welcome) below the Server Settings group.</strike> Create a link to a new activity with text \"Form Metadata\" or something like it.\r\n1. Add hint text to the new <strike>settings group</strike> activity that says something like \"These values will be added to forms that have username, email and/or telephone preloaded fields to identify the person submitting data.\"\r\n1. Add new username, email and telephone fields to the Form Metadata <strike>group</strike> activity. These values should be separate from server authentication and used in PropertyManager\r\n1. Remove the code in PropertyManager that attempts to get a phone number from the device because it doesn't actually work.\r\n\r\nThis should probably be done as several smaller pull requests."},"comment":{"url":"https://api.github.com/repos/opendatakit/collect/issues/comments/288434728","html_url":"https://github.com/opendatakit/collect/issues/311#issuecomment-288434728","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/311","id":288434728,"user":{"login":"lognaturel","id":967540,"avatar_url":"https://avatars0.githubusercontent.com/u/967540?v=3","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"created_at":"2017-03-22T15:25:41Z","updated_at":"2017-03-22T15:25:41Z","body":"@hooverlunch @dcbriccetti The challenge with that is knowing when to set it. Whenever the field is blank? But then how does the user indicate a blank phone number? Only the first time that the menu is viewed? If you have a good way around that, then it might be nice to have.\r\n\r\nI really think that in practice very few physical phones will have phone numbers readable in this way. @dcbriccetti you're on an emulator, right?"}}
{"actor":{"display_login":"lognaturel"}}