{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/ervinb/chef-gluster/pulls/1","id":112216079,"html_url":"https://github.com/ervinb/chef-gluster/pull/1","diff_url":"https://github.com/ervinb/chef-gluster/pull/1.diff","patch_url":"https://github.com/ervinb/chef-gluster/pull/1.patch","issue_url":"https://api.github.com/repos/ervinb/chef-gluster/issues/1","number":1,"state":"closed","locked":false,"title":"Loosen up the condition for FQDN and hostname matching","user":{"login":"ervinb","id":2212814,"avatar_url":"https://avatars0.githubusercontent.com/u/2212814?v=3","gravatar_id":"","url":"https://api.github.com/users/ervinb","html_url":"https://github.com/ervinb","followers_url":"https://api.github.com/users/ervinb/followers","following_url":"https://api.github.com/users/ervinb/following{/other_user}","gists_url":"https://api.github.com/users/ervinb/gists{/gist_id}","starred_url":"https://api.github.com/users/ervinb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ervinb/subscriptions","organizations_url":"https://api.github.com/users/ervinb/orgs","repos_url":"https://api.github.com/users/ervinb/repos","events_url":"https://api.github.com/users/ervinb/events{/privacy}","received_events_url":"https://api.github.com/users/ervinb/received_events","type":"User","site_admin":false},"body":"With this, if a peer changes its FQDN or hostname before running the GlusterFS cookbook (eg. `host -> host.local`), the setup will still run correctly.\r\n\r\nAlternatively, the `node['fqdn']` and `node['hostname']` variables should be update mid-run. This is harder than it seems, because Ohai sets these variables compile time, and they're tricky to modify. The `server-setup` recipe uses a lot of Ruby, which is interpreted at compile time, and lazy loading the automatic variables is tricky.\r\n\r\nDoing this, is the next best thing and it's useful if you're doing local host discovery with `Avahi`. During the provisioning process, a cookbook sets up the `avahi-daemon`, and configures the FQDN to`<host>.local`, and finally GlusterFS is set up with this cookbook.","created_at":"2017-03-23T11:26:53Z","updated_at":"2017-03-23T11:29:40Z","closed_at":"2017-03-23T11:29:40Z","merged_at":"2017-03-23T11:29:40Z","merge_commit_sha":"4352c83304b029d9a73800307dc94e662994e05f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ervinb/chef-gluster/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ervinb/chef-gluster/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ervinb/chef-gluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ervinb/chef-gluster/issues/1/comments","statuses_url":"https://api.github.com/repos/ervinb/chef-gluster/statuses/8eddc278d607b354cba6cc54e7064142a42d98af","head":{"label":"ervinb:change-fqdn-fetching","ref":"change-fqdn-fetching","sha":"8eddc278d607b354cba6cc54e7064142a42d98af","user":{"login":"ervinb","id":2212814,"avatar_url":"https://avatars0.githubusercontent.com/u/2212814?v=3","gravatar_id":"","url":"https://api.github.com/users/ervinb","html_url":"https://github.com/ervinb","followers_url":"https://api.github.com/users/ervinb/followers","following_url":"https://api.github.com/users/ervinb/following{/other_user}","gists_url":"https://api.github.com/users/ervinb/gists{/gist_id}","starred_url":"https://api.github.com/users/ervinb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ervinb/subscriptions","organizations_url":"https://api.github.com/users/ervinb/orgs","repos_url":"https://api.github.com/users/ervinb/repos","events_url":"https://api.github.com/users/ervinb/events{/privacy}","received_events_url":"https://api.github.com/users/ervinb/received_events","type":"User","site_admin":false},"repo":{"id":84543258,"name":"chef-gluster","full_name":"ervinb/chef-gluster","owner":{"login":"ervinb","id":2212814,"avatar_url":"https://avatars0.githubusercontent.com/u/2212814?v=3","gravatar_id":"","url":"https://api.github.com/users/ervinb","html_url":"https://github.com/ervinb","followers_url":"https://api.github.com/users/ervinb/followers","following_url":"https://api.github.com/users/ervinb/following{/other_user}","gists_url":"https://api.github.com/users/ervinb/gists{/gist_id}","starred_url":"https://api.github.com/users/ervinb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ervinb/subscriptions","organizations_url":"https://api.github.com/users/ervinb/orgs","repos_url":"https://api.github.com/users/ervinb/repos","events_url":"https://api.github.com/users/ervinb/events{/privacy}","received_events_url":"https://api.github.com/users/ervinb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ervinb/chef-gluster","description":"Chef cookbook for deploying Gluster","fork":true,"url":"https://api.github.com/repos/ervinb/chef-gluster","forks_url":"https://api.github.com/repos/ervinb/chef-gluster/forks","keys_url":"https://api.github.com/repos/ervinb/chef-gluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ervinb/chef-gluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ervinb/chef-gluster/teams","hooks_url":"https://api.github.com/repos/ervinb/chef-gluster/hooks","issue_events_url":"https://api.github.com/repos/ervinb/chef-gluster/issues/events{/number}","events_url":"https://api.github.com/repos/ervinb/chef-gluster/events","assignees_url":"https://api.github.com/repos/ervinb/chef-gluster/assignees{/user}","branches_url":"https://api.github.com/repos/ervinb/chef-gluster/branches{/branch}","tags_url":"https://api.github.com/repos/ervinb/chef-gluster/tags","blobs_url":"https://api.github.com/repos/ervinb/chef-gluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ervinb/chef-gluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ervinb/chef-gluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/ervinb/chef-gluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ervinb/chef-gluster/statuses/{sha}","languages_url":"https://api.github.com/repos/ervinb/chef-gluster/languages","stargazers_url":"https://api.github.com/repos/ervinb/chef-gluster/stargazers","contributors_url":"https://api.github.com/repos/ervinb/chef-gluster/contributors","subscribers_url":"https://api.github.com/repos/ervinb/chef-gluster/subscribers","subscription_url":"https://api.github.com/repos/ervinb/chef-gluster/subscription","commits_url":"https://api.github.com/repos/ervinb/chef-gluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/ervinb/chef-gluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/ervinb/chef-gluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/ervinb/chef-gluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/ervinb/chef-gluster/contents/{+path}","compare_url":"https://api.github.com/repos/ervinb/chef-gluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ervinb/chef-gluster/merges","archive_url":"https://api.github.com/repos/ervinb/chef-gluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ervinb/chef-gluster/downloads","issues_url":"https://api.github.com/repos/ervinb/chef-gluster/issues{/number}","pulls_url":"https://api.github.com/repos/ervinb/chef-gluster/pulls{/number}","milestones_url":"https://api.github.com/repos/ervinb/chef-gluster/milestones{/number}","notifications_url":"https://api.github.com/repos/ervinb/chef-gluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ervinb/chef-gluster/labels{/name}","releases_url":"https://api.github.com/repos/ervinb/chef-gluster/releases{/id}","deployments_url":"https://api.github.com/repos/ervinb/chef-gluster/deployments","created_at":"2017-03-10T09:31:13Z","updated_at":"2017-03-10T09:31:15Z","pushed_at":"2017-03-23T11:29:40Z","git_url":"git://github.com/ervinb/chef-gluster.git","ssh_url":"git@github.com:ervinb/chef-gluster.git","clone_url":"https://github.com/ervinb/chef-gluster.git","svn_url":"https://github.com/ervinb/chef-gluster","homepage":"https://supermarket.chef.io/cookbooks/gluster","size":167,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ervinb:master","ref":"master","sha":"085dabd52f7f4a7b21bf588b8e4849d8c2860bb1","user":{"login":"ervinb","id":2212814,"avatar_url":"https://avatars0.githubusercontent.com/u/2212814?v=3","gravatar_id":"","url":"https://api.github.com/users/ervinb","html_url":"https://github.com/ervinb","followers_url":"https://api.github.com/users/ervinb/followers","following_url":"https://api.github.com/users/ervinb/following{/other_user}","gists_url":"https://api.github.com/users/ervinb/gists{/gist_id}","starred_url":"https://api.github.com/users/ervinb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ervinb/subscriptions","organizations_url":"https://api.github.com/users/ervinb/orgs","repos_url":"https://api.github.com/users/ervinb/repos","events_url":"https://api.github.com/users/ervinb/events{/privacy}","received_events_url":"https://api.github.com/users/ervinb/received_events","type":"User","site_admin":false},"repo":{"id":84543258,"name":"chef-gluster","full_name":"ervinb/chef-gluster","owner":{"login":"ervinb","id":2212814,"avatar_url":"https://avatars0.githubusercontent.com/u/2212814?v=3","gravatar_id":"","url":"https://api.github.com/users/ervinb","html_url":"https://github.com/ervinb","followers_url":"https://api.github.com/users/ervinb/followers","following_url":"https://api.github.com/users/ervinb/following{/other_user}","gists_url":"https://api.github.com/users/ervinb/gists{/gist_id}","starred_url":"https://api.github.com/users/ervinb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ervinb/subscriptions","organizations_url":"https://api.github.com/users/ervinb/orgs","repos_url":"https://api.github.com/users/ervinb/repos","events_url":"https://api.github.com/users/ervinb/events{/privacy}","received_events_url":"https://api.github.com/users/ervinb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ervinb/chef-gluster","description":"Chef cookbook for deploying Gluster","fork":true,"url":"https://api.github.com/repos/ervinb/chef-gluster","forks_url":"https://api.github.com/repos/ervinb/chef-gluster/forks","keys_url":"https://api.github.com/repos/ervinb/chef-gluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ervinb/chef-gluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ervinb/chef-gluster/teams","hooks_url":"https://api.github.com/repos/ervinb/chef-gluster/hooks","issue_events_url":"https://api.github.com/repos/ervinb/chef-gluster/issues/events{/number}","events_url":"https://api.github.com/repos/ervinb/chef-gluster/events","assignees_url":"https://api.github.com/repos/ervinb/chef-gluster/assignees{/user}","branches_url":"https://api.github.com/repos/ervinb/chef-gluster/branches{/branch}","tags_url":"https://api.github.com/repos/ervinb/chef-gluster/tags","blobs_url":"https://api.github.com/repos/ervinb/chef-gluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ervinb/chef-gluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ervinb/chef-gluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/ervinb/chef-gluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ervinb/chef-gluster/statuses/{sha}","languages_url":"https://api.github.com/repos/ervinb/chef-gluster/languages","stargazers_url":"https://api.github.com/repos/ervinb/chef-gluster/stargazers","contributors_url":"https://api.github.com/repos/ervinb/chef-gluster/contributors","subscribers_url":"https://api.github.com/repos/ervinb/chef-gluster/subscribers","subscription_url":"https://api.github.com/repos/ervinb/chef-gluster/subscription","commits_url":"https://api.github.com/repos/ervinb/chef-gluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/ervinb/chef-gluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/ervinb/chef-gluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/ervinb/chef-gluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/ervinb/chef-gluster/contents/{+path}","compare_url":"https://api.github.com/repos/ervinb/chef-gluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ervinb/chef-gluster/merges","archive_url":"https://api.github.com/repos/ervinb/chef-gluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ervinb/chef-gluster/downloads","issues_url":"https://api.github.com/repos/ervinb/chef-gluster/issues{/number}","pulls_url":"https://api.github.com/repos/ervinb/chef-gluster/pulls{/number}","milestones_url":"https://api.github.com/repos/ervinb/chef-gluster/milestones{/number}","notifications_url":"https://api.github.com/repos/ervinb/chef-gluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ervinb/chef-gluster/labels{/name}","releases_url":"https://api.github.com/repos/ervinb/chef-gluster/releases{/id}","deployments_url":"https://api.github.com/repos/ervinb/chef-gluster/deployments","created_at":"2017-03-10T09:31:13Z","updated_at":"2017-03-10T09:31:15Z","pushed_at":"2017-03-23T11:29:40Z","git_url":"git://github.com/ervinb/chef-gluster.git","ssh_url":"git@github.com:ervinb/chef-gluster.git","clone_url":"https://github.com/ervinb/chef-gluster.git","svn_url":"https://github.com/ervinb/chef-gluster","homepage":"https://supermarket.chef.io/cookbooks/gluster","size":167,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ervinb/chef-gluster/pulls/1"},"html":{"href":"https://github.com/ervinb/chef-gluster/pull/1"},"issue":{"href":"https://api.github.com/repos/ervinb/chef-gluster/issues/1"},"comments":{"href":"https://api.github.com/repos/ervinb/chef-gluster/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ervinb/chef-gluster/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ervinb/chef-gluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ervinb/chef-gluster/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ervinb/chef-gluster/statuses/8eddc278d607b354cba6cc54e7064142a42d98af"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ervinb","id":2212814,"avatar_url":"https://avatars0.githubusercontent.com/u/2212814?v=3","gravatar_id":"","url":"https://api.github.com/users/ervinb","html_url":"https://github.com/ervinb","followers_url":"https://api.github.com/users/ervinb/followers","following_url":"https://api.github.com/users/ervinb/following{/other_user}","gists_url":"https://api.github.com/users/ervinb/gists{/gist_id}","starred_url":"https://api.github.com/users/ervinb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ervinb/subscriptions","organizations_url":"https://api.github.com/users/ervinb/orgs","repos_url":"https://api.github.com/users/ervinb/repos","events_url":"https://api.github.com/users/ervinb/events{/privacy}","received_events_url":"https://api.github.com/users/ervinb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"ervinb"}}