{"action":"created","issue":{"url":"https://api.github.com/repos/explosion/spaCy/issues/955","repository_url":"https://api.github.com/repos/explosion/spaCy","labels_url":"https://api.github.com/repos/explosion/spaCy/issues/955/labels{/name}","comments_url":"https://api.github.com/repos/explosion/spaCy/issues/955/comments","events_url":"https://api.github.com/repos/explosion/spaCy/issues/955/events","html_url":"https://github.com/explosion/spaCy/pull/955","id":219551333,"number":955,"title":"Fix keras_parikh_entailment example bugs","user":{"login":"kumaranvpl","id":7011056,"avatar_url":"https://avatars1.githubusercontent.com/u/7011056?v=3","gravatar_id":"","url":"https://api.github.com/users/kumaranvpl","html_url":"https://github.com/kumaranvpl","followers_url":"https://api.github.com/users/kumaranvpl/followers","following_url":"https://api.github.com/users/kumaranvpl/following{/other_user}","gists_url":"https://api.github.com/users/kumaranvpl/gists{/gist_id}","starred_url":"https://api.github.com/users/kumaranvpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumaranvpl/subscriptions","organizations_url":"https://api.github.com/users/kumaranvpl/orgs","repos_url":"https://api.github.com/users/kumaranvpl/repos","events_url":"https://api.github.com/users/kumaranvpl/events{/privacy}","received_events_url":"https://api.github.com/users/kumaranvpl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-05T11:26:12Z","updated_at":"2017-04-07T12:59:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/explosion/spaCy/pulls/955","html_url":"https://github.com/explosion/spaCy/pull/955","diff_url":"https://github.com/explosion/spaCy/pull/955.diff","patch_url":"https://github.com/explosion/spaCy/pull/955.patch"},"body":"<!--- Provide a general summary of your changes in the Title -->\r\n\r\n## Description\r\n1. Removed model_dir from [evaluate function](https://github.com/explosion/spaCy/blob/master/examples/keras_parikh_entailment/__main__.py#L55) which is not needed and not used inside function too\r\n2. Set [max_length](https://github.com/explosion/spaCy/blob/master/examples/keras_parikh_entailment/spacy_hook.py#L88) to 100 for evaluate and demo. This bug is specified in this [issue comment](https://github.com/explosion/spaCy/issues/767#issuecomment-278651113)\r\n3. Update command to run train in README. The model_dir was removed on this [commit](https://github.com/explosion/spaCy/commit/c031c677ccfcf0c425c4ad838ddf1f795add9b5d) and that change is not updated in README. This PR fixes it.\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all applicable boxes.: -->\r\n- [x] **Bug fix** (non-breaking change fixing an issue)\r\n- [ ] **New feature** (non-breaking change adding functionality to spaCy)\r\n- [ ] **Breaking change** (fix or feature causing change to spaCy's existing functionality)\r\n- [ ] **Documentation** (addition to documentation of spaCy)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/explosion/spaCy/issues/comments/292529696","html_url":"https://github.com/explosion/spaCy/pull/955#issuecomment-292529696","issue_url":"https://api.github.com/repos/explosion/spaCy/issues/955","id":292529696,"user":{"login":"honnibal","id":8059750,"avatar_url":"https://avatars0.githubusercontent.com/u/8059750?v=3","gravatar_id":"","url":"https://api.github.com/users/honnibal","html_url":"https://github.com/honnibal","followers_url":"https://api.github.com/users/honnibal/followers","following_url":"https://api.github.com/users/honnibal/following{/other_user}","gists_url":"https://api.github.com/users/honnibal/gists{/gist_id}","starred_url":"https://api.github.com/users/honnibal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honnibal/subscriptions","organizations_url":"https://api.github.com/users/honnibal/orgs","repos_url":"https://api.github.com/users/honnibal/repos","events_url":"https://api.github.com/users/honnibal/events{/privacy}","received_events_url":"https://api.github.com/users/honnibal/received_events","type":"User","site_admin":false},"created_at":"2017-04-07T12:59:47Z","updated_at":"2017-04-07T12:59:47Z","body":"Thanks!\r\n\r\nObviously I've had tonnes of trouble with this code since publishing it. I'd be very interested in a PyTorch-based implementation. I feel that Keras and TensorFlow aren't well suited to NLP, which is why I've been developing my own NN code in the explosion/thinc repo."}}
{"actor":{"display_login":"honnibal"}}