{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/732","repository_url":"https://api.github.com/repos/Azure/acs-engine","labels_url":"https://api.github.com/repos/Azure/acs-engine/issues/732/labels{/name}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/732/comments","events_url":"https://api.github.com/repos/Azure/acs-engine/issues/732/events","html_url":"https://github.com/Azure/acs-engine/pull/732","id":233786006,"number":732,"title":"add location setting for national cloud in sample setting files","user":{"login":"VincentLiu028","id":17308665,"avatar_url":"https://avatars2.githubusercontent.com/u/17308665?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentLiu028","html_url":"https://github.com/VincentLiu028","followers_url":"https://api.github.com/users/VincentLiu028/followers","following_url":"https://api.github.com/users/VincentLiu028/following{/other_user}","gists_url":"https://api.github.com/users/VincentLiu028/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentLiu028/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentLiu028/subscriptions","organizations_url":"https://api.github.com/users/VincentLiu028/orgs","repos_url":"https://api.github.com/users/VincentLiu028/repos","events_url":"https://api.github.com/users/VincentLiu028/events{/privacy}","received_events_url":"https://api.github.com/users/VincentLiu028/received_events","type":"User","site_admin":false},"labels":[{"id":482553557,"url":"https://api.github.com/repos/Azure/acs-engine/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-06T05:53:32Z","updated_at":"2017-06-22T23:59:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/732","html_url":"https://github.com/Azure/acs-engine/pull/732","diff_url":"https://github.com/Azure/acs-engine/pull/732.diff","patch_url":"https://github.com/Azure/acs-engine/pull/732.patch"},"body":"Add location setting in sample configuration files to support national clouds. The default value is empty, so public cloud is used. For national cloud, use the data center name of national cloud. For China the value is chinaeast or chinanorth\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/azure/acs-engine/732)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/comments/310534007","html_url":"https://github.com/Azure/acs-engine/pull/732#issuecomment-310534007","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/732","id":310534007,"user":{"login":"rjtsdl","id":10858648,"avatar_url":"https://avatars3.githubusercontent.com/u/10858648?v=3","gravatar_id":"","url":"https://api.github.com/users/rjtsdl","html_url":"https://github.com/rjtsdl","followers_url":"https://api.github.com/users/rjtsdl/followers","following_url":"https://api.github.com/users/rjtsdl/following{/other_user}","gists_url":"https://api.github.com/users/rjtsdl/gists{/gist_id}","starred_url":"https://api.github.com/users/rjtsdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjtsdl/subscriptions","organizations_url":"https://api.github.com/users/rjtsdl/orgs","repos_url":"https://api.github.com/users/rjtsdl/repos","events_url":"https://api.github.com/users/rjtsdl/events{/privacy}","received_events_url":"https://api.github.com/users/rjtsdl/received_events","type":"User","site_admin":false},"created_at":"2017-06-22T23:59:07Z","updated_at":"2017-06-22T23:59:07Z","body":"Btw, \"location\" is one of the reserved field by ARM, it is the Azure region. It cannot be customized. \r\nIf your change is compatible with ARM's specs, it is fine. Otherwise, please come up with something else. "}}
{"actor":{"display_login":"rjtsdl"}}