{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/123719450","pull_request_review_id":45951641,"id":123719450,"diff_hunk":"@@ -15,21 +15,21 @@ OS: mac, windows, linux, ios, android, html5\n Platforms: desktop, mobile\n \n Example:\n-visual effect dissolve\n+visual effect \"dissolve\"\n go next card\n \n Example:\n -- This handler in an object will cause to hide then show \n --  with a visual effect when clicked.\n on mouseUp\n   hide me\n-  show me with visual effect iris close slow\n+  show me with visual effect \"iris\" close slow","path":"docs/dictionary/command/visual-effect.lcdoc","position":14,"original_position":14,"commit_id":"df1a0bd524bcda7527f4ea60004b243be5e0ea00","original_commit_id":"92ff22d2687dfa8a1f4c3af94e942e894b65ef7e","user":{"login":"livecodepanos","id":5111835,"avatar_url":"https://avatars0.githubusercontent.com/u/5111835?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodepanos","html_url":"https://github.com/livecodepanos","followers_url":"https://api.github.com/users/livecodepanos/followers","following_url":"https://api.github.com/users/livecodepanos/following{/other_user}","gists_url":"https://api.github.com/users/livecodepanos/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodepanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodepanos/subscriptions","organizations_url":"https://api.github.com/users/livecodepanos/orgs","repos_url":"https://api.github.com/users/livecodepanos/repos","events_url":"https://api.github.com/users/livecodepanos/events{/privacy}","received_events_url":"https://api.github.com/users/livecodepanos/received_events","type":"User","site_admin":false},"body":"Hi Sam and Sean,\r\n\r\nThanks for the PR and the comments. Here are some clarifications, for anyone following this PR:\r\n\r\n1. The `hide` and `show` commands can be used with a visual effect\r\n2. There are 2 kinds of visual effects:\r\n- The built-in ones, as described in the `visual effect` entry\r\n- The QuickTime-specific ones, which were available only in the platforms were QT was supported (Win and OS X), and those effects were the ones returned by the `qtEffects()` function.\r\n\r\n3. The `hide` command mentions that QT is deprecated in LC 8.1, thus the QT-specific effects should not be used with this command after LC 8.1\r\n\r\n4. The `hide` command is currently marked as \"deprecated\". This is incorrect.\r\n5. The `show` command does not mention anything about QT-specific effects being deprecated.\r\n\r\n6. Some examples in `hide` and `show` entries have no quotes in the visual effect, which will cause a compile error when in Strict Compilation Mode.\r\n\r\n\r\nSo, we will file a new report about those issues in `hide` and `show` entries. So in short, we have to:\r\n\r\n- Remove the deprecation note from `hide`\r\n- Add a note in `show` about QT (as it is in `hide`\r\n- Add quotes in the effects used in the example of `hide` and `show`\r\n- Add references to `hide` and `show` in this PR (—> This is now done)","created_at":"2017-06-23T10:33:16Z","updated_at":"2017-06-23T10:33:16Z","html_url":"https://github.com/livecode/livecode/pull/5633#discussion_r123719450","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/5633","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/123719450"},"html":{"href":"https://github.com/livecode/livecode/pull/5633#discussion_r123719450"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5633"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/5633","id":127168074,"html_url":"https://github.com/livecode/livecode/pull/5633","diff_url":"https://github.com/livecode/livecode/pull/5633.diff","patch_url":"https://github.com/livecode/livecode/pull/5633.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/5633","number":5633,"state":"open","locked":false,"title":"[Bug 11827] Updated Dictionary Entry for visual effect","user":{"login":"livecodesam","id":29141642,"avatar_url":"https://avatars1.githubusercontent.com/u/29141642?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodesam","html_url":"https://github.com/livecodesam","followers_url":"https://api.github.com/users/livecodesam/followers","following_url":"https://api.github.com/users/livecodesam/following{/other_user}","gists_url":"https://api.github.com/users/livecodesam/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodesam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodesam/subscriptions","organizations_url":"https://api.github.com/users/livecodesam/orgs","repos_url":"https://api.github.com/users/livecodesam/repos","events_url":"https://api.github.com/users/livecodesam/events{/privacy}","received_events_url":"https://api.github.com/users/livecodesam/received_events","type":"User","site_admin":false},"body":"Added quotes to effect names in examples so that compilation errors wouldn't occur in Strict Compilation Mode.","created_at":"2017-06-23T09:29:54Z","updated_at":"2017-06-23T10:33:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"875a0d6badc5f307d57a1adff90a0d8c6fde6dec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/5633/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/5633/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/5633/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/df1a0bd524bcda7527f4ea60004b243be5e0ea00","head":{"label":"livecodesam:patch-9","ref":"patch-9","sha":"df1a0bd524bcda7527f4ea60004b243be5e0ea00","user":{"login":"livecodesam","id":29141642,"avatar_url":"https://avatars1.githubusercontent.com/u/29141642?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodesam","html_url":"https://github.com/livecodesam","followers_url":"https://api.github.com/users/livecodesam/followers","following_url":"https://api.github.com/users/livecodesam/following{/other_user}","gists_url":"https://api.github.com/users/livecodesam/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodesam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodesam/subscriptions","organizations_url":"https://api.github.com/users/livecodesam/orgs","repos_url":"https://api.github.com/users/livecodesam/repos","events_url":"https://api.github.com/users/livecodesam/events{/privacy}","received_events_url":"https://api.github.com/users/livecodesam/received_events","type":"User","site_admin":false},"repo":{"id":93153451,"name":"livecode","full_name":"livecodesam/livecode","owner":{"login":"livecodesam","id":29141642,"avatar_url":"https://avatars1.githubusercontent.com/u/29141642?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodesam","html_url":"https://github.com/livecodesam","followers_url":"https://api.github.com/users/livecodesam/followers","following_url":"https://api.github.com/users/livecodesam/following{/other_user}","gists_url":"https://api.github.com/users/livecodesam/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodesam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodesam/subscriptions","organizations_url":"https://api.github.com/users/livecodesam/orgs","repos_url":"https://api.github.com/users/livecodesam/repos","events_url":"https://api.github.com/users/livecodesam/events{/privacy}","received_events_url":"https://api.github.com/users/livecodesam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/livecodesam/livecode","description":"LiveCode cross-platform development environment (engine)","fork":true,"url":"https://api.github.com/repos/livecodesam/livecode","forks_url":"https://api.github.com/repos/livecodesam/livecode/forks","keys_url":"https://api.github.com/repos/livecodesam/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecodesam/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecodesam/livecode/teams","hooks_url":"https://api.github.com/repos/livecodesam/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecodesam/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecodesam/livecode/events","assignees_url":"https://api.github.com/repos/livecodesam/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecodesam/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecodesam/livecode/tags","blobs_url":"https://api.github.com/repos/livecodesam/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecodesam/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecodesam/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecodesam/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecodesam/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecodesam/livecode/languages","stargazers_url":"https://api.github.com/repos/livecodesam/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecodesam/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecodesam/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecodesam/livecode/subscription","commits_url":"https://api.github.com/repos/livecodesam/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecodesam/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecodesam/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecodesam/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecodesam/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecodesam/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecodesam/livecode/merges","archive_url":"https://api.github.com/repos/livecodesam/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecodesam/livecode/downloads","issues_url":"https://api.github.com/repos/livecodesam/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecodesam/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecodesam/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecodesam/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecodesam/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecodesam/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecodesam/livecode/deployments","created_at":"2017-06-02T10:07:47Z","updated_at":"2017-06-02T10:08:01Z","pushed_at":"2017-06-23T10:16:47Z","git_url":"git://github.com/livecodesam/livecode.git","ssh_url":"git@github.com:livecodesam/livecode.git","clone_url":"https://github.com/livecodesam/livecode.git","svn_url":"https://github.com/livecodesam/livecode","homepage":"https://livecode.com/","size":140035,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"livecode:develop","ref":"develop","sha":"c49afeee0d58aec06895c607e8ab07bd936690ef","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars2.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars2.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"LiveCode cross-platform development environment (engine)","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecode/livecode/deployments","created_at":"2013-04-10T00:15:57Z","updated_at":"2017-06-18T02:47:04Z","pushed_at":"2017-06-23T10:16:48Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":"https://livecode.com/","size":140614,"stargazers_count":177,"watchers_count":177,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":107,"forks":121,"open_issues":107,"watchers":177,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5633"},"html":{"href":"https://github.com/livecode/livecode/pull/5633"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/5633"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/5633/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5633/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5633/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/df1a0bd524bcda7527f4ea60004b243be5e0ea00"}}}}
{"actor":{"display_login":"livecodepanos"}}