{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/balrog/pulls/comments/115917752","pull_request_review_id":37496944,"id":115917752,"diff_hunk":"@@ -141,9 +141,22 @@ def testNewRuleWithoutPermission(self):\n     def testMissingFields(self):\n         # But we still need to pass product, because permission checking\n         # is done before what we're testing\n-        ret = self._post('/rules', data=dict({'product': 'a'}))\n+        post_data = {'product': 'a'}\n+        ret = self._post('/rules', data=post_data)\n+        self.assertEquals(ret.status_code, 400, \"Status Code: %d, Data: %s\" % (ret.status_code, ret.data))\n+        # Connexion and manual request.json validation methods will preempt and throw 400 error as\n+        # soon as the first field invalidates. Only one field may be present in the response.data depending\n+        # upon the order of fields sorted in swagger yaml file and in views.\n+        self.assertTrue('title' in ret.data, msg=ret.data)","path":"auslib/test/admin/views/test_rules.py","position":11,"original_position":11,"commit_id":"3aac9ee4a5e1fa7031b1f0581c41cc8fc5974028","original_commit_id":"3aac9ee4a5e1fa7031b1f0581c41cc8fc5974028","user":{"login":"tarekziade","id":250019,"avatar_url":"https://avatars2.githubusercontent.com/u/250019?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekziade","html_url":"https://github.com/tarekziade","followers_url":"https://api.github.com/users/tarekziade/followers","following_url":"https://api.github.com/users/tarekziade/following{/other_user}","gists_url":"https://api.github.com/users/tarekziade/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekziade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekziade/subscriptions","organizations_url":"https://api.github.com/users/tarekziade/orgs","repos_url":"https://api.github.com/users/tarekziade/repos","events_url":"https://api.github.com/users/tarekziade/events{/privacy}","received_events_url":"https://api.github.com/users/tarekziade/received_events","type":"User","site_admin":false},"body":"@mozbhearsum reading at the connexion code, looks like you need a custom RequestBodyValidator to set up the problem response correctly.  I am not sure what it entails, I'd ask the connexion folks :)\r\n","created_at":"2017-05-11T07:08:36Z","updated_at":"2017-05-11T07:08:37Z","html_url":"https://github.com/mozilla/balrog/pull/312#discussion_r115917752","pull_request_url":"https://api.github.com/repos/mozilla/balrog/pulls/312","_links":{"self":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/comments/115917752"},"html":{"href":"https://github.com/mozilla/balrog/pull/312#discussion_r115917752"},"pull_request":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/312"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/balrog/pulls/312","id":118864146,"html_url":"https://github.com/mozilla/balrog/pull/312","diff_url":"https://github.com/mozilla/balrog/pull/312.diff","patch_url":"https://github.com/mozilla/balrog/pull/312.patch","issue_url":"https://api.github.com/repos/mozilla/balrog/issues/312","number":312,"state":"open","locked":false,"title":"Bug 1336452 : Migrating /rules , /users and /csrf_token to connexion app","user":{"login":"aksareen","id":8070566,"avatar_url":"https://avatars2.githubusercontent.com/u/8070566?v=3","gravatar_id":"","url":"https://api.github.com/users/aksareen","html_url":"https://github.com/aksareen","followers_url":"https://api.github.com/users/aksareen/followers","following_url":"https://api.github.com/users/aksareen/following{/other_user}","gists_url":"https://api.github.com/users/aksareen/gists{/gist_id}","starred_url":"https://api.github.com/users/aksareen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksareen/subscriptions","organizations_url":"https://api.github.com/users/aksareen/orgs","repos_url":"https://api.github.com/users/aksareen/repos","events_url":"https://api.github.com/users/aksareen/events{/privacy}","received_events_url":"https://api.github.com/users/aksareen/received_events","type":"User","site_admin":false},"body":"Relevant code for initial review and also to serve as background for this bug : https://pastebin.mozilla.org/9020651","created_at":"2017-05-03T21:58:37Z","updated_at":"2017-05-11T07:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05911d72234f83a1521298bf3183884f3396f6ff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/balrog/pulls/312/commits","review_comments_url":"https://api.github.com/repos/mozilla/balrog/pulls/312/comments","review_comment_url":"https://api.github.com/repos/mozilla/balrog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/balrog/issues/312/comments","statuses_url":"https://api.github.com/repos/mozilla/balrog/statuses/3aac9ee4a5e1fa7031b1f0581c41cc8fc5974028","head":{"label":"aksareen:first_set_of_apis_migrate","ref":"first_set_of_apis_migrate","sha":"3aac9ee4a5e1fa7031b1f0581c41cc8fc5974028","user":{"login":"aksareen","id":8070566,"avatar_url":"https://avatars2.githubusercontent.com/u/8070566?v=3","gravatar_id":"","url":"https://api.github.com/users/aksareen","html_url":"https://github.com/aksareen","followers_url":"https://api.github.com/users/aksareen/followers","following_url":"https://api.github.com/users/aksareen/following{/other_user}","gists_url":"https://api.github.com/users/aksareen/gists{/gist_id}","starred_url":"https://api.github.com/users/aksareen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksareen/subscriptions","organizations_url":"https://api.github.com/users/aksareen/orgs","repos_url":"https://api.github.com/users/aksareen/repos","events_url":"https://api.github.com/users/aksareen/events{/privacy}","received_events_url":"https://api.github.com/users/aksareen/received_events","type":"User","site_admin":false},"repo":{"id":76987690,"name":"balrog","full_name":"aksareen/balrog","owner":{"login":"aksareen","id":8070566,"avatar_url":"https://avatars2.githubusercontent.com/u/8070566?v=3","gravatar_id":"","url":"https://api.github.com/users/aksareen","html_url":"https://github.com/aksareen","followers_url":"https://api.github.com/users/aksareen/followers","following_url":"https://api.github.com/users/aksareen/following{/other_user}","gists_url":"https://api.github.com/users/aksareen/gists{/gist_id}","starred_url":"https://api.github.com/users/aksareen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksareen/subscriptions","organizations_url":"https://api.github.com/users/aksareen/orgs","repos_url":"https://api.github.com/users/aksareen/repos","events_url":"https://api.github.com/users/aksareen/events{/privacy}","received_events_url":"https://api.github.com/users/aksareen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aksareen/balrog","description":"Next generation update service for Mozilla products","fork":true,"url":"https://api.github.com/repos/aksareen/balrog","forks_url":"https://api.github.com/repos/aksareen/balrog/forks","keys_url":"https://api.github.com/repos/aksareen/balrog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aksareen/balrog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aksareen/balrog/teams","hooks_url":"https://api.github.com/repos/aksareen/balrog/hooks","issue_events_url":"https://api.github.com/repos/aksareen/balrog/issues/events{/number}","events_url":"https://api.github.com/repos/aksareen/balrog/events","assignees_url":"https://api.github.com/repos/aksareen/balrog/assignees{/user}","branches_url":"https://api.github.com/repos/aksareen/balrog/branches{/branch}","tags_url":"https://api.github.com/repos/aksareen/balrog/tags","blobs_url":"https://api.github.com/repos/aksareen/balrog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aksareen/balrog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aksareen/balrog/git/refs{/sha}","trees_url":"https://api.github.com/repos/aksareen/balrog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aksareen/balrog/statuses/{sha}","languages_url":"https://api.github.com/repos/aksareen/balrog/languages","stargazers_url":"https://api.github.com/repos/aksareen/balrog/stargazers","contributors_url":"https://api.github.com/repos/aksareen/balrog/contributors","subscribers_url":"https://api.github.com/repos/aksareen/balrog/subscribers","subscription_url":"https://api.github.com/repos/aksareen/balrog/subscription","commits_url":"https://api.github.com/repos/aksareen/balrog/commits{/sha}","git_commits_url":"https://api.github.com/repos/aksareen/balrog/git/commits{/sha}","comments_url":"https://api.github.com/repos/aksareen/balrog/comments{/number}","issue_comment_url":"https://api.github.com/repos/aksareen/balrog/issues/comments{/number}","contents_url":"https://api.github.com/repos/aksareen/balrog/contents/{+path}","compare_url":"https://api.github.com/repos/aksareen/balrog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aksareen/balrog/merges","archive_url":"https://api.github.com/repos/aksareen/balrog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aksareen/balrog/downloads","issues_url":"https://api.github.com/repos/aksareen/balrog/issues{/number}","pulls_url":"https://api.github.com/repos/aksareen/balrog/pulls{/number}","milestones_url":"https://api.github.com/repos/aksareen/balrog/milestones{/number}","notifications_url":"https://api.github.com/repos/aksareen/balrog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aksareen/balrog/labels{/name}","releases_url":"https://api.github.com/repos/aksareen/balrog/releases{/id}","deployments_url":"https://api.github.com/repos/aksareen/balrog/deployments","created_at":"2016-12-20T20:01:25Z","updated_at":"2017-02-01T17:54:37Z","pushed_at":"2017-05-04T07:43:36Z","git_url":"git://github.com/aksareen/balrog.git","ssh_url":"git@github.com:aksareen/balrog.git","clone_url":"https://github.com/aksareen/balrog.git","svn_url":"https://github.com/aksareen/balrog","homepage":"","size":61727,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"19b506d80c9070610956ae11bd2f1c0bc310f319","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2570444,"name":"balrog","full_name":"mozilla/balrog","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/balrog","description":"Next generation update service for Mozilla products","fork":false,"url":"https://api.github.com/repos/mozilla/balrog","forks_url":"https://api.github.com/repos/mozilla/balrog/forks","keys_url":"https://api.github.com/repos/mozilla/balrog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/balrog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/balrog/teams","hooks_url":"https://api.github.com/repos/mozilla/balrog/hooks","issue_events_url":"https://api.github.com/repos/mozilla/balrog/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/balrog/events","assignees_url":"https://api.github.com/repos/mozilla/balrog/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/balrog/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/balrog/tags","blobs_url":"https://api.github.com/repos/mozilla/balrog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/balrog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/balrog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/balrog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/balrog/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/balrog/languages","stargazers_url":"https://api.github.com/repos/mozilla/balrog/stargazers","contributors_url":"https://api.github.com/repos/mozilla/balrog/contributors","subscribers_url":"https://api.github.com/repos/mozilla/balrog/subscribers","subscription_url":"https://api.github.com/repos/mozilla/balrog/subscription","commits_url":"https://api.github.com/repos/mozilla/balrog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/balrog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/balrog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/balrog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/balrog/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/balrog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/balrog/merges","archive_url":"https://api.github.com/repos/mozilla/balrog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/balrog/downloads","issues_url":"https://api.github.com/repos/mozilla/balrog/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/balrog/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/balrog/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/balrog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/balrog/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/balrog/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/balrog/deployments","created_at":"2011-10-13T15:51:47Z","updated_at":"2017-04-21T10:53:50Z","pushed_at":"2017-05-10T19:34:00Z","git_url":"git://github.com/mozilla/balrog.git","ssh_url":"git@github.com:mozilla/balrog.git","clone_url":"https://github.com/mozilla/balrog.git","svn_url":"https://github.com/mozilla/balrog","homepage":"","size":61786,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":6,"forks":88,"open_issues":6,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/312"},"html":{"href":"https://github.com/mozilla/balrog/pull/312"},"issue":{"href":"https://api.github.com/repos/mozilla/balrog/issues/312"},"comments":{"href":"https://api.github.com/repos/mozilla/balrog/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/balrog/statuses/3aac9ee4a5e1fa7031b1f0581c41cc8fc5974028"}}}}
{"actor":{"display_login":"tarekziade"}}