{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/137899713","pull_request_review_id":61634309,"id":137899713,"diff_hunk":"@@ -0,0 +1,46 @@\n+# Copyright (C) 2017 Google Inc.\n+# Licensed under http://www.apache.org/licenses/LICENSE-2.0 <see LICENSE file>\n+\n+\"\"\"\n+Remove Meeting and ObjectEvent data\n+\n+Create Date: 2017-09-08 14:26:13.029930\n+\"\"\"\n+# disable Invalid constant name pylint warning for mandatory Alembic variables.\n+# pylint: disable=invalid-name\n+\n+from alembic import op\n+\n+from ggrc.migrations.utils import cleanup\n+\n+# revision identifiers, used by Alembic.\n+revision = '3c69a1e45812'\n+down_revision = '2ada007df3ee'\n+\n+\n+DELETIONS = (\n+    (\"audit_objects\", \"auditable_type\"),\n+    (\"custom_attribute_definitions\", \"definition_type\"),\n+    (\"fulltext_record_properties\", \"type\"),\n+    (\"notifications\", \"object_type\"),\n+    (\"object_documents\", \"documentable_type\"),\n+    (\"object_owners\", \"ownable_type\"),\n+    (\"object_people\", \"personable_type\"),\n+    (\"relationships\", \"source_type\"),\n+    (\"relationships\", \"destination_type\"),\n+    (\"revisions\", \"resource_type\"),\n+    (\"revisions\", \"source_type\"),\n+    (\"revisions\", \"destination_type\"),","path":"src/ggrc/migrations/versions/20170908142613_3c69a1e45812_remove_meeting_and_objectevent_data.py","position":33,"original_position":33,"commit_id":"2171e174042c35050add181c113afd951161abe5","original_commit_id":"2171e174042c35050add181c113afd951161abe5","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars2.githubusercontent.com/u/566311?v=4","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"body":"I do not believe we should ever remove anything in our revisions table. \r\n\r\nIs there a specific reason for these deletions?","created_at":"2017-09-08T22:08:09Z","updated_at":"2017-09-08T22:08:09Z","html_url":"https://github.com/google/ggrc-core/pull/6398#discussion_r137899713","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/6398","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/137899713"},"html":{"href":"https://github.com/google/ggrc-core/pull/6398#discussion_r137899713"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6398"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/6398","id":140053610,"html_url":"https://github.com/google/ggrc-core/pull/6398","diff_url":"https://github.com/google/ggrc-core/pull/6398.diff","patch_url":"https://github.com/google/ggrc-core/pull/6398.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/6398","number":6398,"state":"open","locked":false,"title":"QUICK-FIX Remove Meeting model","user":{"login":"alieh-rymasheuski","id":9883236,"avatar_url":"https://avatars2.githubusercontent.com/u/9883236?v=4","gravatar_id":"","url":"https://api.github.com/users/alieh-rymasheuski","html_url":"https://github.com/alieh-rymasheuski","followers_url":"https://api.github.com/users/alieh-rymasheuski/followers","following_url":"https://api.github.com/users/alieh-rymasheuski/following{/other_user}","gists_url":"https://api.github.com/users/alieh-rymasheuski/gists{/gist_id}","starred_url":"https://api.github.com/users/alieh-rymasheuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alieh-rymasheuski/subscriptions","organizations_url":"https://api.github.com/users/alieh-rymasheuski/orgs","repos_url":"https://api.github.com/users/alieh-rymasheuski/repos","events_url":"https://api.github.com/users/alieh-rymasheuski/events{/privacy}","received_events_url":"https://api.github.com/users/alieh-rymasheuski/received_events","type":"User","site_admin":false},"body":"The model has been unused for a long time.","created_at":"2017-09-08T14:40:22Z","updated_at":"2017-09-08T22:08:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b17fe659daf55a8ce09d179dee87bc6171c4749","assignee":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars2.githubusercontent.com/u/566311?v=4","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"assignees":[{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars2.githubusercontent.com/u/566311?v=4","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},{"login":"AlexNo","id":4737102,"avatar_url":"https://avatars0.githubusercontent.com/u/4737102?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNo","html_url":"https://github.com/AlexNo","followers_url":"https://api.github.com/users/AlexNo/followers","following_url":"https://api.github.com/users/AlexNo/following{/other_user}","gists_url":"https://api.github.com/users/AlexNo/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNo/subscriptions","organizations_url":"https://api.github.com/users/AlexNo/orgs","repos_url":"https://api.github.com/users/AlexNo/repos","events_url":"https://api.github.com/users/AlexNo/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/61","html_url":"https://github.com/google/ggrc-core/milestone/61","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/61/labels","id":2715480,"number":61,"title":"0.10.29-Raspberry","description":"","creator":{"login":"alieh-rymasheuski","id":9883236,"avatar_url":"https://avatars2.githubusercontent.com/u/9883236?v=4","gravatar_id":"","url":"https://api.github.com/users/alieh-rymasheuski","html_url":"https://github.com/alieh-rymasheuski","followers_url":"https://api.github.com/users/alieh-rymasheuski/followers","following_url":"https://api.github.com/users/alieh-rymasheuski/following{/other_user}","gists_url":"https://api.github.com/users/alieh-rymasheuski/gists{/gist_id}","starred_url":"https://api.github.com/users/alieh-rymasheuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alieh-rymasheuski/subscriptions","organizations_url":"https://api.github.com/users/alieh-rymasheuski/orgs","repos_url":"https://api.github.com/users/alieh-rymasheuski/repos","events_url":"https://api.github.com/users/alieh-rymasheuski/events{/privacy}","received_events_url":"https://api.github.com/users/alieh-rymasheuski/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":68,"state":"open","created_at":"2017-08-22T10:46:44Z","updated_at":"2017-09-08T16:17:32Z","due_on":"2017-09-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/6398/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/6398/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/6398/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/2171e174042c35050add181c113afd951161abe5","head":{"label":"alieh-rymasheuski:QUICK-FIX-remove-meeting","ref":"QUICK-FIX-remove-meeting","sha":"2171e174042c35050add181c113afd951161abe5","user":{"login":"alieh-rymasheuski","id":9883236,"avatar_url":"https://avatars2.githubusercontent.com/u/9883236?v=4","gravatar_id":"","url":"https://api.github.com/users/alieh-rymasheuski","html_url":"https://github.com/alieh-rymasheuski","followers_url":"https://api.github.com/users/alieh-rymasheuski/followers","following_url":"https://api.github.com/users/alieh-rymasheuski/following{/other_user}","gists_url":"https://api.github.com/users/alieh-rymasheuski/gists{/gist_id}","starred_url":"https://api.github.com/users/alieh-rymasheuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alieh-rymasheuski/subscriptions","organizations_url":"https://api.github.com/users/alieh-rymasheuski/orgs","repos_url":"https://api.github.com/users/alieh-rymasheuski/repos","events_url":"https://api.github.com/users/alieh-rymasheuski/events{/privacy}","received_events_url":"https://api.github.com/users/alieh-rymasheuski/received_events","type":"User","site_admin":false},"repo":{"id":59271499,"name":"ggrc-core","full_name":"alieh-rymasheuski/ggrc-core","owner":{"login":"alieh-rymasheuski","id":9883236,"avatar_url":"https://avatars2.githubusercontent.com/u/9883236?v=4","gravatar_id":"","url":"https://api.github.com/users/alieh-rymasheuski","html_url":"https://github.com/alieh-rymasheuski","followers_url":"https://api.github.com/users/alieh-rymasheuski/followers","following_url":"https://api.github.com/users/alieh-rymasheuski/following{/other_user}","gists_url":"https://api.github.com/users/alieh-rymasheuski/gists{/gist_id}","starred_url":"https://api.github.com/users/alieh-rymasheuski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alieh-rymasheuski/subscriptions","organizations_url":"https://api.github.com/users/alieh-rymasheuski/orgs","repos_url":"https://api.github.com/users/alieh-rymasheuski/repos","events_url":"https://api.github.com/users/alieh-rymasheuski/events{/privacy}","received_events_url":"https://api.github.com/users/alieh-rymasheuski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alieh-rymasheuski/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core","forks_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/forks","keys_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/teams","hooks_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/events","assignees_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/tags","blobs_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/subscription","commits_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/merges","archive_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/downloads","issues_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/alieh-rymasheuski/ggrc-core/deployments","created_at":"2016-05-20T06:44:56Z","updated_at":"2016-05-23T08:41:47Z","pushed_at":"2017-09-08T15:36:36Z","git_url":"git://github.com/alieh-rymasheuski/ggrc-core.git","ssh_url":"git@github.com:alieh-rymasheuski/ggrc-core.git","clone_url":"https://github.com/alieh-rymasheuski/ggrc-core.git","svn_url":"https://github.com/alieh-rymasheuski/ggrc-core","homepage":null,"size":65261,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"google:dev","ref":"dev","sha":"c1b82cccc04deae9694b4b01c1094261ca75f37d","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2017-09-03T01:24:47Z","pushed_at":"2017-09-08T21:41:41Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":65010,"stargazers_count":222,"watchers_count":222,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":44,"forks":162,"open_issues":44,"watchers":222,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6398"},"html":{"href":"https://github.com/google/ggrc-core/pull/6398"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/6398"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/6398/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6398/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/6398/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/2171e174042c35050add181c113afd951161abe5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zidarsk8"}}