{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/139041381","pull_request_review_id":62921497,"id":139041381,"diff_hunk":"@@ -40,21 +38,21 @@ class FifoRecorder\n                       u32 xfRegsSize, const u8* texMem);\n \n   // Checked once per frame prior to callng EndFrame()\n-  bool IsRecording() const { return m_IsRecording; }\n+  bool IsRecording() const;\n   static FifoRecorder& GetInstance();\n \n private:\n   // Accessed from both GUI and video threads\n \n+  std::recursive_mutex m_mutex;\n   // True if video thread should send data\n-  volatile bool m_IsRecording = false;\n+  bool m_IsRecording = false;\n   // True if m_IsRecording was true during last frame\n-  volatile bool m_WasRecording = false;\n-  volatile bool m_RequestedRecordingEnd = false;\n-  volatile s32 m_RecordFramesRemaining = 0;\n-  volatile CallbackFunc m_FinishedCb = nullptr;\n-\n-  FifoDataFile* volatile m_File = nullptr;\n+  bool m_WasRecording = false;\n+  bool m_RequestedRecordingEnd = false;\n+  s32 m_RecordFramesRemaining = 0;\n+  CallbackFunc m_FinishedCb = nullptr;\n+  FifoDataFile* m_File = nullptr;","path":"Source/Core/Core/FifoPlayer/FifoRecorder.h","position":49,"original_position":49,"commit_id":"3886c845af7d39664e016d16ac8161c4825e85e1","original_commit_id":"3886c845af7d39664e016d16ac8161c4825e85e1","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"body":"Ah, that makes sense, I had wondered why it wasn't using a smart pointer.","created_at":"2017-09-15T00:26:47Z","updated_at":"2017-09-15T00:26:47Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/6061#discussion_r139041381","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/139041381"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/6061#discussion_r139041381"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061"}},"in_reply_to_id":139037068},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061","id":141153683,"html_url":"https://github.com/dolphin-emu/dolphin/pull/6061","diff_url":"https://github.com/dolphin-emu/dolphin/pull/6061.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/6061.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6061","number":6061,"state":"open","locked":false,"title":"FifoRecorder: remove use of volatile","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"body":"It already took a mutex lock for almost all multithreaded accesses, so this just removes `volatile` and adds a lock to the one access without it. Plus a little cleanup.","created_at":"2017-09-14T19:08:12Z","updated_at":"2017-09-15T00:26:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd71d028fd59f4ab1f2a3459de63bc131d69fdf3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6061/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3886c845af7d39664e016d16ac8161c4825e85e1","head":{"label":"ligfx:removefiforecordervolatile","ref":"removefiforecordervolatile","sha":"3886c845af7d39664e016d16ac8161c4825e85e1","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"repo":{"id":65220721,"name":"dolphin","full_name":"ligfx/dolphin","owner":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ligfx/dolphin","description":"Personal development branch of dolphin-emu/dolphin.","fork":true,"url":"https://api.github.com/repos/ligfx/dolphin","forks_url":"https://api.github.com/repos/ligfx/dolphin/forks","keys_url":"https://api.github.com/repos/ligfx/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligfx/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligfx/dolphin/teams","hooks_url":"https://api.github.com/repos/ligfx/dolphin/hooks","issue_events_url":"https://api.github.com/repos/ligfx/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/ligfx/dolphin/events","assignees_url":"https://api.github.com/repos/ligfx/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/ligfx/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/ligfx/dolphin/tags","blobs_url":"https://api.github.com/repos/ligfx/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligfx/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligfx/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligfx/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligfx/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/ligfx/dolphin/languages","stargazers_url":"https://api.github.com/repos/ligfx/dolphin/stargazers","contributors_url":"https://api.github.com/repos/ligfx/dolphin/contributors","subscribers_url":"https://api.github.com/repos/ligfx/dolphin/subscribers","subscription_url":"https://api.github.com/repos/ligfx/dolphin/subscription","commits_url":"https://api.github.com/repos/ligfx/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligfx/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligfx/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligfx/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligfx/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/ligfx/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligfx/dolphin/merges","archive_url":"https://api.github.com/repos/ligfx/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligfx/dolphin/downloads","issues_url":"https://api.github.com/repos/ligfx/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/ligfx/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/ligfx/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/ligfx/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligfx/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/ligfx/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/ligfx/dolphin/deployments","created_at":"2016-08-08T16:31:32Z","updated_at":"2017-05-17T22:06:54Z","pushed_at":"2017-09-15T00:15:27Z","git_url":"git://github.com/ligfx/dolphin.git","ssh_url":"git@github.com:ligfx/dolphin.git","clone_url":"https://github.com/ligfx/dolphin.git","svn_url":"https://github.com/ligfx/dolphin","homepage":"https://github.com/dolphin-emu/dolphin","size":311469,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ligfx"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"030dc11c6e31125cd03862f86815fe67d978f98d","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-09-14T15:32:09Z","pushed_at":"2017-09-15T00:19:10Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":348780,"stargazers_count":3684,"watchers_count":3684,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":924,"mirror_url":null,"open_issues_count":137,"forks":924,"open_issues":137,"watchers":3684,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/6061"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6061"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6061/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6061/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3886c845af7d39664e016d16ac8161c4825e85e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ligfx"}}