{"action":"created","comment":{"url":"https://api.github.com/repos/zeit/hyper/pulls/comments/118827675","pull_request_review_id":40659275,"id":118827675,"diff_hunk":"@@ -1,82 +1,31 @@\n-const {statSync, renameSync, readFileSync, writeFileSync} = require('fs');\n-const vm = require('vm');\n-\n-const {dialog} = require('electron');\n const gaze = require('gaze');\n-const Config = require('electron-config');\n const notify = require('./notify');\n-const _paths = require('./config/paths');\n+const _import = require('./config/import');\n+const {confPath, confDir} = require('./config/paths');\n const _openConfig = require('./config/open');\n-\n-// local storage\n-const winCfg = new Config({\n-  defaults: {\n-    windowPosition: [50, 50],\n-    windowSize: [540, 380]\n-  }\n-});\n-\n-const path = _paths.confPath;\n-const pathLegacy = _paths.pathLegacy;\n+const win = require('./config/windows');\n \n const watchers = [];\n-\n+const scanInterval = 2000;\n let cfg = {};\n \n-function watch() {\n+const _watch = function () {\n   // watch for changes on config every 2s\n   // windows interval: https://github.com/zeit/hyper/pull/1772\n-  gaze(path, process.platform === 'win32' ? {interval: 2000} : {}, function (err) {\n+  gaze(confPath, process.platform === 'win32' ? {interval: scanInterval} : {}, function (err) {\n     if (err) {\n       throw err;\n     }\n     this.on('changed', () => {\n-      try {\n-        if (exec(readFileSync(path, 'utf8'))) {\n-          notify('Hyper configuration reloaded!');\n-          watchers.forEach(fn => fn());\n-        }\n-      } catch (err) {\n-        dialog.showMessageBox({","path":"app/config.js","position":46,"original_position":46,"commit_id":"7a311422b76ce473e62cac4fc9bd5bfb7b22e34c","original_commit_id":"7a311422b76ce473e62cac4fc9bd5bfb7b22e34c","user":{"login":"albinekb","id":5027156,"avatar_url":"https://avatars2.githubusercontent.com/u/5027156?v=3","gravatar_id":"","url":"https://api.github.com/users/albinekb","html_url":"https://github.com/albinekb","followers_url":"https://api.github.com/users/albinekb/followers","following_url":"https://api.github.com/users/albinekb/following{/other_user}","gists_url":"https://api.github.com/users/albinekb/gists{/gist_id}","starred_url":"https://api.github.com/users/albinekb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albinekb/subscriptions","organizations_url":"https://api.github.com/users/albinekb/orgs","repos_url":"https://api.github.com/users/albinekb/repos","events_url":"https://api.github.com/users/albinekb/events{/privacy}","received_events_url":"https://api.github.com/users/albinekb/received_events","type":"User","site_admin":false},"body":"This PR changes from displaying a dialog to just a notification, correct?","created_at":"2017-05-27T19:39:01Z","updated_at":"2017-05-27T19:39:02Z","html_url":"https://github.com/zeit/hyper/pull/1876#discussion_r118827675","pull_request_url":"https://api.github.com/repos/zeit/hyper/pulls/1876","_links":{"self":{"href":"https://api.github.com/repos/zeit/hyper/pulls/comments/118827675"},"html":{"href":"https://github.com/zeit/hyper/pull/1876#discussion_r118827675"},"pull_request":{"href":"https://api.github.com/repos/zeit/hyper/pulls/1876"}}},"pull_request":{"url":"https://api.github.com/repos/zeit/hyper/pulls/1876","id":122679866,"html_url":"https://github.com/zeit/hyper/pull/1876","diff_url":"https://github.com/zeit/hyper/pull/1876.diff","patch_url":"https://github.com/zeit/hyper/pull/1876.patch","issue_url":"https://api.github.com/repos/zeit/hyper/issues/1876","number":1876,"state":"open","locked":false,"title":"Part2 of keymaps","user":{"login":"ppot","id":5577409,"avatar_url":"https://avatars0.githubusercontent.com/u/5577409?v=3","gravatar_id":"","url":"https://api.github.com/users/ppot","html_url":"https://github.com/ppot","followers_url":"https://api.github.com/users/ppot/followers","following_url":"https://api.github.com/users/ppot/following{/other_user}","gists_url":"https://api.github.com/users/ppot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppot/subscriptions","organizations_url":"https://api.github.com/users/ppot/orgs","repos_url":"https://api.github.com/users/ppot/repos","events_url":"https://api.github.com/users/ppot/events{/privacy}","received_events_url":"https://api.github.com/users/ppot/received_events","type":"User","site_admin":false},"body":"-> keymaps files\r\n-> config structure change (file deconstruction)\r\n-> plugins extends keymaps\r\n-> update hterm to use `commands-registry`","created_at":"2017-05-26T16:43:15Z","updated_at":"2017-05-27T19:39:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e1d5e154de19af5ba60bd13ef2a32c02b10ed70","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/hyper/pulls/1876/commits","review_comments_url":"https://api.github.com/repos/zeit/hyper/pulls/1876/comments","review_comment_url":"https://api.github.com/repos/zeit/hyper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/hyper/issues/1876/comments","statuses_url":"https://api.github.com/repos/zeit/hyper/statuses/7a311422b76ce473e62cac4fc9bd5bfb7b22e34c","head":{"label":"ppot:keymap@part2","ref":"keymap@part2","sha":"7a311422b76ce473e62cac4fc9bd5bfb7b22e34c","user":{"login":"ppot","id":5577409,"avatar_url":"https://avatars0.githubusercontent.com/u/5577409?v=3","gravatar_id":"","url":"https://api.github.com/users/ppot","html_url":"https://github.com/ppot","followers_url":"https://api.github.com/users/ppot/followers","following_url":"https://api.github.com/users/ppot/following{/other_user}","gists_url":"https://api.github.com/users/ppot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppot/subscriptions","organizations_url":"https://api.github.com/users/ppot/orgs","repos_url":"https://api.github.com/users/ppot/repos","events_url":"https://api.github.com/users/ppot/events{/privacy}","received_events_url":"https://api.github.com/users/ppot/received_events","type":"User","site_admin":false},"repo":{"id":70296187,"name":"hyper","full_name":"ppot/hyper","owner":{"login":"ppot","id":5577409,"avatar_url":"https://avatars0.githubusercontent.com/u/5577409?v=3","gravatar_id":"","url":"https://api.github.com/users/ppot","html_url":"https://github.com/ppot","followers_url":"https://api.github.com/users/ppot/followers","following_url":"https://api.github.com/users/ppot/following{/other_user}","gists_url":"https://api.github.com/users/ppot/gists{/gist_id}","starred_url":"https://api.github.com/users/ppot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppot/subscriptions","organizations_url":"https://api.github.com/users/ppot/orgs","repos_url":"https://api.github.com/users/ppot/repos","events_url":"https://api.github.com/users/ppot/events{/privacy}","received_events_url":"https://api.github.com/users/ppot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppot/hyper","description":"A terminal built on web technologies","fork":true,"url":"https://api.github.com/repos/ppot/hyper","forks_url":"https://api.github.com/repos/ppot/hyper/forks","keys_url":"https://api.github.com/repos/ppot/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppot/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppot/hyper/teams","hooks_url":"https://api.github.com/repos/ppot/hyper/hooks","issue_events_url":"https://api.github.com/repos/ppot/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/ppot/hyper/events","assignees_url":"https://api.github.com/repos/ppot/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/ppot/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/ppot/hyper/tags","blobs_url":"https://api.github.com/repos/ppot/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppot/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppot/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppot/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppot/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/ppot/hyper/languages","stargazers_url":"https://api.github.com/repos/ppot/hyper/stargazers","contributors_url":"https://api.github.com/repos/ppot/hyper/contributors","subscribers_url":"https://api.github.com/repos/ppot/hyper/subscribers","subscription_url":"https://api.github.com/repos/ppot/hyper/subscription","commits_url":"https://api.github.com/repos/ppot/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppot/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppot/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppot/hyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppot/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/ppot/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppot/hyper/merges","archive_url":"https://api.github.com/repos/ppot/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppot/hyper/downloads","issues_url":"https://api.github.com/repos/ppot/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/ppot/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/ppot/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/ppot/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppot/hyper/labels{/name}","releases_url":"https://api.github.com/repos/ppot/hyper/releases{/id}","deployments_url":"https://api.github.com/repos/ppot/hyper/deployments","created_at":"2016-10-08T02:03:04Z","updated_at":"2017-02-10T11:41:27Z","pushed_at":"2017-05-26T16:41:38Z","git_url":"git://github.com/ppot/hyper.git","ssh_url":"git@github.com:ppot/hyper.git","clone_url":"https://github.com/ppot/hyper.git","svn_url":"https://github.com/ppot/hyper","homepage":"https://hyper.is","size":2734,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"zeit:master","ref":"master","sha":"0d63360011852eda7294b9cd98032407bd4e8b21","user":{"login":"zeit","id":14985020,"avatar_url":"https://avatars3.githubusercontent.com/u/14985020?v=3","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":62367558,"name":"hyper","full_name":"zeit/hyper","owner":{"login":"zeit","id":14985020,"avatar_url":"https://avatars3.githubusercontent.com/u/14985020?v=3","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeit/hyper","description":"A terminal built on web technologies","fork":false,"url":"https://api.github.com/repos/zeit/hyper","forks_url":"https://api.github.com/repos/zeit/hyper/forks","keys_url":"https://api.github.com/repos/zeit/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/hyper/teams","hooks_url":"https://api.github.com/repos/zeit/hyper/hooks","issue_events_url":"https://api.github.com/repos/zeit/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/hyper/events","assignees_url":"https://api.github.com/repos/zeit/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/hyper/tags","blobs_url":"https://api.github.com/repos/zeit/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/hyper/languages","stargazers_url":"https://api.github.com/repos/zeit/hyper/stargazers","contributors_url":"https://api.github.com/repos/zeit/hyper/contributors","subscribers_url":"https://api.github.com/repos/zeit/hyper/subscribers","subscription_url":"https://api.github.com/repos/zeit/hyper/subscription","commits_url":"https://api.github.com/repos/zeit/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/hyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/hyper/merges","archive_url":"https://api.github.com/repos/zeit/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/hyper/downloads","issues_url":"https://api.github.com/repos/zeit/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/hyper/labels{/name}","releases_url":"https://api.github.com/repos/zeit/hyper/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/hyper/deployments","created_at":"2016-07-01T06:01:21Z","updated_at":"2017-05-27T19:25:10Z","pushed_at":"2017-05-27T19:37:44Z","git_url":"git://github.com/zeit/hyper.git","ssh_url":"git@github.com:zeit/hyper.git","clone_url":"https://github.com/zeit/hyper.git","svn_url":"https://github.com/zeit/hyper","homepage":"https://hyper.is","size":2574,"stargazers_count":16990,"watchers_count":16990,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1197,"mirror_url":null,"open_issues_count":562,"forks":1197,"open_issues":562,"watchers":16990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/hyper/pulls/1876"},"html":{"href":"https://github.com/zeit/hyper/pull/1876"},"issue":{"href":"https://api.github.com/repos/zeit/hyper/issues/1876"},"comments":{"href":"https://api.github.com/repos/zeit/hyper/issues/1876/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/hyper/pulls/1876/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/hyper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/hyper/pulls/1876/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/hyper/statuses/7a311422b76ce473e62cac4fc9bd5bfb7b22e34c"}}}}
{"actor":{"display_login":"albinekb"}}