{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/130763571","pull_request_review_id":53674869,"id":130763571,"diff_hunk":"@@ -467,6 +472,44 @@ <h4 class=\"title\">${_('Your Course Creator Request Status:')}</h4>\n       </div>\n       % endif\n \n+      %if archived_courses:\n+      <div class=\"archived-courses archived-courses-tab\">","path":"cms/templates/index.html","position":22,"original_position":22,"commit_id":"8087a1d165649b65907df5ed12df5940d8ff3462","original_commit_id":"8087a1d165649b65907df5ed12df5940d8ff3462","user":{"login":"pomegranited","id":7556571,"avatar_url":"https://avatars3.githubusercontent.com/u/7556571?v=4","gravatar_id":"","url":"https://api.github.com/users/pomegranited","html_url":"https://github.com/pomegranited","followers_url":"https://api.github.com/users/pomegranited/followers","following_url":"https://api.github.com/users/pomegranited/following{/other_user}","gists_url":"https://api.github.com/users/pomegranited/gists{/gist_id}","starred_url":"https://api.github.com/users/pomegranited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomegranited/subscriptions","organizations_url":"https://api.github.com/users/pomegranited/orgs","repos_url":"https://api.github.com/users/pomegranited/repos","events_url":"https://api.github.com/users/pomegranited/events{/privacy}","received_events_url":"https://api.github.com/users/pomegranited/received_events","type":"User","site_admin":false},"body":"Sorry about that, @cahrens :(","created_at":"2017-08-02T00:45:46Z","updated_at":"2017-08-02T00:45:46Z","html_url":"https://github.com/edx/edx-platform/pull/15431#discussion_r130763571","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/15431","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/130763571"},"html":{"href":"https://github.com/edx/edx-platform/pull/15431#discussion_r130763571"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15431"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/15431","id":128102807,"html_url":"https://github.com/edx/edx-platform/pull/15431","diff_url":"https://github.com/edx/edx-platform/pull/15431.diff","patch_url":"https://github.com/edx/edx-platform/pull/15431.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/15431","number":15431,"state":"open","locked":false,"title":"Separate Archived courses into a separate list in Studio","user":{"login":"pomegranited","id":7556571,"avatar_url":"https://avatars3.githubusercontent.com/u/7556571?v=4","gravatar_id":"","url":"https://api.github.com/users/pomegranited","html_url":"https://github.com/pomegranited","followers_url":"https://api.github.com/users/pomegranited/followers","following_url":"https://api.github.com/users/pomegranited/following{/other_user}","gists_url":"https://api.github.com/users/pomegranited/gists{/gist_id}","starred_url":"https://api.github.com/users/pomegranited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomegranited/subscriptions","organizations_url":"https://api.github.com/users/pomegranited/orgs","repos_url":"https://api.github.com/users/pomegranited/repos","events_url":"https://api.github.com/users/pomegranited/events{/privacy}","received_events_url":"https://api.github.com/users/pomegranited/received_events","type":"User","site_admin":false},"body":"Adds a feature flag which, when enabled, splits the Courses listed on the Studio Home page into two lists:\r\n* Courses - \"active\" courses with no end date, or whose end date has not passed yet.\r\n* Archived Courses - courses whose end date has passed.\r\n\r\n**JIRA tickets**: [OSPR-1803](https://openedx.atlassian.net/browse/OSPR-1803)\r\n\r\n**Discussions**: [`edx-code` group post](https://groups.google.com/forum/#!msg/edx-code/Oao9f_Atd_8/S5JxMUObAwAJ)\r\n\r\n**Screenshots**:\r\n\r\n![active courses](https://user-images.githubusercontent.com/7556571/27680252-44f137e8-5cfa-11e7-8fb4-c3cb55038934.png)\r\n![archived courses](https://user-images.githubusercontent.com/7556571/27680256-472ab750-5cfa-11e7-8856-ea55aa73b03f.png)\r\n\r\n**Sandbox URL**:\r\n\r\nSandbox has `FEATURES['ENABLE_SEPARATE_ARCHIVED_COURSES']` enabled.\r\n\r\nLMS: https://pr15431.sandbox.opencraft.hosting/\r\nStudio: https://studio-pr15431.sandbox.opencraft.hosting/\r\n\r\n**Partner information**: 3rd party-hosted open edX instance\r\n\r\n**Deployment targets**: edx.org and edge.edx.org\r\n\r\n**Merge deadline**: None\r\n\r\n**Testing instructions**:\r\n\r\nWith `FEATURES['ENABLE_SEPARATE_ARCHIVED_COURSES']` enabled:\r\n1. Load the Studio home page.  Notice that there is no Archived Courses tab shown.\r\n1. Create two courses in Studio:\r\n    * Active Course - with no end date set, or with an end date set in the future.\r\n    * Archived Course - with an end date set in the past.\r\n1. Refresh the Studio home page.  Notice that:\r\n    * The Active Course appears under the main Courses tab.\r\n    * The Archived Course appears under the Archived Courses tab.\r\n\r\nWith `FEATURES['ENABLE_SEPARATE_ARCHIVED_COURSES']` disabled or removed:\r\n1. Load the Studio home page.  Notice that:\r\n* There is no Archived Courses tab shown.\r\n* The new courses appear under the main Courses tab\r\n\r\n**Author notes and concerns**:\r\n\r\n1. The original aim of this feature was to avoid loading the archived courses during the initial request, and instead provide them via a separate, asynchronous request.\r\n   However, since the mongo offers no clear way to filter out archived courses from the modulestore queries, it made more sense to just return the archived courses synchronously with the active courses, since they're all being fetched anyway.\r\n   See the tests added which verify that enabling the feature does not add any new database queries.\r\n\r\n**Reviewers**\r\n- [x] @smarnach \r\n- [ ] edX reviewer[s] TBD - CC @gsong \r\n\r\n**Settings**\r\n```yaml\r\nEDXAPP_FEATURES:\r\n  ENABLE_SEPARATE_ARCHIVED_COURSES: true\r\n  ENABLE_COMBINED_LOGIN_REGISTRATION: true\r\n```","created_at":"2017-06-29T09:11:05Z","updated_at":"2017-08-02T00:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7d4b7a5891950ac2bc5300c20c97c0acbd874ad","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/15431/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/15431/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/15431/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/8087a1d165649b65907df5ed12df5940d8ff3462","head":{"label":"open-craft:jill/studio-filter-archived-courses","ref":"jill/studio-filter-archived-courses","sha":"8087a1d165649b65907df5ed12df5940d8ff3462","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":19940883,"name":"edx-platform","full_name":"open-craft/edx-platform","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/open-craft/edx-platform","forks_url":"https://api.github.com/repos/open-craft/edx-platform/forks","keys_url":"https://api.github.com/repos/open-craft/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/edx-platform/teams","hooks_url":"https://api.github.com/repos/open-craft/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/open-craft/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/edx-platform/events","assignees_url":"https://api.github.com/repos/open-craft/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/edx-platform/tags","blobs_url":"https://api.github.com/repos/open-craft/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/edx-platform/languages","stargazers_url":"https://api.github.com/repos/open-craft/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/open-craft/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/open-craft/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/open-craft/edx-platform/subscription","commits_url":"https://api.github.com/repos/open-craft/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/edx-platform/merges","archive_url":"https://api.github.com/repos/open-craft/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/edx-platform/downloads","issues_url":"https://api.github.com/repos/open-craft/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/edx-platform/deployments","created_at":"2014-05-19T12:28:25Z","updated_at":"2017-02-08T21:05:25Z","pushed_at":"2017-08-01T18:12:07Z","git_url":"git://github.com/open-craft/edx-platform.git","ssh_url":"git@github.com:open-craft/edx-platform.git","clone_url":"https://github.com/open-craft/edx-platform.git","svn_url":"https://github.com/open-craft/edx-platform","homepage":"http://code.edx.org/","size":806754,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"53d9f87df380e0cc2cb76c8414bcc9273e3aa6c6","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-08-01T02:16:57Z","pushed_at":"2017-08-02T00:06:02Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":834376,"stargazers_count":3235,"watchers_count":3235,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1871,"mirror_url":null,"open_issues_count":170,"forks":1871,"open_issues":170,"watchers":3235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15431"},"html":{"href":"https://github.com/edx/edx-platform/pull/15431"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15431"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15431/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15431/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15431/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/8087a1d165649b65907df5ed12df5940d8ff3462"}}}}
{"actor":{"display_login":"pomegranited"}}