{"action":"created","issue":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3131","repository_url":"https://api.github.com/repos/salesagility/SuiteCRM","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3131/labels{/name}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3131/comments","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3131/events","html_url":"https://github.com/salesagility/SuiteCRM/issues/3131","id":207946807,"number":3131,"title":"Noticing changes for no reason/benefit","user":{"login":"eggsurplus","id":89315,"avatar_url":"https://avatars.githubusercontent.com/u/89315?v=3","gravatar_id":"","url":"https://api.github.com/users/eggsurplus","html_url":"https://github.com/eggsurplus","followers_url":"https://api.github.com/users/eggsurplus/followers","following_url":"https://api.github.com/users/eggsurplus/following{/other_user}","gists_url":"https://api.github.com/users/eggsurplus/gists{/gist_id}","starred_url":"https://api.github.com/users/eggsurplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggsurplus/subscriptions","organizations_url":"https://api.github.com/users/eggsurplus/orgs","repos_url":"https://api.github.com/users/eggsurplus/repos","events_url":"https://api.github.com/users/eggsurplus/events{/privacy}","received_events_url":"https://api.github.com/users/eggsurplus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-02-15T22:20:35Z","updated_at":"2017-02-16T12:29:15Z","closed_at":null,"body":"Noticing a trend as I check changes from version to version. Code styles/preferences are overriding code that has been there for many years and is dependent on the whim of whomever is editing a specific file. Take for example /data/SugarBean.php with the recent changes in the 7.8.0 release:\r\n\r\nhttps://www.dropbox.com/s/ywqm69t5u6om8xc/Screenshot%202017-02-15%2016.11.57.png?dl=0\r\n\r\nHere the valid entry point check is moved to be low the header comment and the parenthesis are removed from the require_once.\r\n\r\nAnother case: \r\n\r\nhttps://www.dropbox.com/s/moftokujzvyq2ur/Screenshot%202017-02-15%2016.17.35.png?dl=0\r\n\r\nThe == true is removed which makes it harder to read.\r\n\r\nThere are many more like these.\r\n\r\nWhile these changes are not syntactically incorrect, they add no value and in many cases goes against best practices. While it is recommended to have a styling guide, it shouldn't be enforced randomly. I suggest erring to the side of history within the project and only changing toward one's personal preferences in new code moving forward, if at all. Adopting a chameleon method to coding to blend in with past practices may be best until all code is under a unified coding standard."},"comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments/280317853","html_url":"https://github.com/salesagility/SuiteCRM/issues/3131#issuecomment-280317853","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3131","id":280317853,"user":{"login":"samus-aran","id":4041275,"avatar_url":"https://avatars.githubusercontent.com/u/4041275?v=3","gravatar_id":"","url":"https://api.github.com/users/samus-aran","html_url":"https://github.com/samus-aran","followers_url":"https://api.github.com/users/samus-aran/followers","following_url":"https://api.github.com/users/samus-aran/following{/other_user}","gists_url":"https://api.github.com/users/samus-aran/gists{/gist_id}","starred_url":"https://api.github.com/users/samus-aran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samus-aran/subscriptions","organizations_url":"https://api.github.com/users/samus-aran/orgs","repos_url":"https://api.github.com/users/samus-aran/repos","events_url":"https://api.github.com/users/samus-aran/events{/privacy}","received_events_url":"https://api.github.com/users/samus-aran/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T12:29:15Z","updated_at":"2017-02-16T12:29:15Z","body":"Hey guys.\r\n\r\nJust would like to address your concerns with a little clarify from our side.  \r\n\r\nWe, as a company, are always trying to improve our processes and more importantly the code of a legacy application – there is no denying that it is legacy.  Yes the code has worked for many years, but you would also agree that even though it works it needs to be updated to meet more modern standards and technology, yeah?  That is always our aim - moving forward with the times (as fast we possibly can).\r\n\r\nOne of our immediate goals is to make SuiteCRM PSR-2 complaint but as with any large project we are resource limited and so those changes are happening in increments (as you can see).  We do have a strategy in place currently that will increase these file changes which you will see more in the up coming releases – but again, they will be in increments.\r\n\r\nThe reason for these increments are because we have already tested the route making it automatic – we've discovered potential issues with that and we are working our way through them.  But for the time being, this will be a manual process in the next release.\r\n\r\nIn regards to the standards, @eggsurplus – the moving of the entrypoint to the bottom of the license we felt this was the best way forward – keeps the code consistently under the license (where all the code should be).  May not be a standard but felt it should be in our code.\r\n\r\n@pribeiro42  \r\n\r\n- PSR-2 mandates use of 4 spaces, SuiteCRM mandates one tab set at 4 spaces)\r\n\r\nYes, that is correct.  Initially we felt tabs was more beneficial and could specify to use spacing when doing sub-alignment but the consensus is now to use spaces – so we'll update the coding standards to reflect this and going forward with our formatting changes.\r\n\r\n- opening braces for classes (PSR-2 mandates opening brace on new line, SuiteCRM mandates opening brace on same line);\r\n\r\nAgreed.  We'll update the Coding Standards to remove that discrepancy.\r\n\r\nSo guys, hope we've provided you some insight – there are still many things to be done to pull SuiteCRM up to date but we do appreciate your patience and very much value your input."}}
{"actor":{"display_login":"samus-aran"}}