{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/comments/96897209","pull_request_review_id":17494738,"id":96897209,"diff_hunk":"@@ -375,6 +384,7 @@ module.exports = function(req, res, params) {\n \n       // Append `requestedAct` query parameter if possible\n       authEndpoint = appendRequestedPermission(authEndpoint);\n+      console.log(\"sending url\" + authEndpoint);","path":"lib/common/authenticate.js","position":25,"original_position":25,"commit_id":"ed99019fef714648e07afacc69d823dedeb33346","original_commit_id":"ed99019fef714648e07afacc69d823dedeb33346","user":{"login":"fh-qube","id":16801364,"avatar_url":"https://avatars.githubusercontent.com/u/16801364?v=3","gravatar_id":"","url":"https://api.github.com/users/fh-qube","html_url":"https://github.com/fh-qube","followers_url":"https://api.github.com/users/fh-qube/followers","following_url":"https://api.github.com/users/fh-qube/following{/other_user}","gists_url":"https://api.github.com/users/fh-qube/gists{/gist_id}","starred_url":"https://api.github.com/users/fh-qube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fh-qube/subscriptions","organizations_url":"https://api.github.com/users/fh-qube/orgs","repos_url":"https://api.github.com/users/fh-qube/repos","events_url":"https://api.github.com/users/fh-qube/events{/privacy}","received_events_url":"https://api.github.com/users/fh-qube/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Remove this logging statement. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://metrics.skunkhenry.com/coding_rules#rule_key=javascript%3AS2228)\n","created_at":"2017-01-19T16:23:17Z","updated_at":"2017-01-19T16:23:17Z","html_url":"https://github.com/feedhenry/fh-mbaas-express/pull/16#discussion_r96897209","pull_request_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/comments/96897209"},"html":{"href":"https://github.com/feedhenry/fh-mbaas-express/pull/16#discussion_r96897209"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16","id":102299085,"html_url":"https://github.com/feedhenry/fh-mbaas-express/pull/16","diff_url":"https://github.com/feedhenry/fh-mbaas-express/pull/16.diff","patch_url":"https://github.com/feedhenry/fh-mbaas-express/pull/16.patch","issue_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/issues/16","number":16,"state":"open","locked":false,"title":"Rhmap 11610 fix permission cache issue for data browser","user":{"login":"wei-lee","id":912729,"avatar_url":"https://avatars.githubusercontent.com/u/912729?v=3","gravatar_id":"","url":"https://api.github.com/users/wei-lee","html_url":"https://github.com/wei-lee","followers_url":"https://api.github.com/users/wei-lee/followers","following_url":"https://api.github.com/users/wei-lee/following{/other_user}","gists_url":"https://api.github.com/users/wei-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/wei-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wei-lee/subscriptions","organizations_url":"https://api.github.com/users/wei-lee/orgs","repos_url":"https://api.github.com/users/wei-lee/repos","events_url":"https://api.github.com/users/wei-lee/events{/privacy}","received_events_url":"https://api.github.com/users/wei-lee/received_events","type":"User","site_admin":false},"body":"## Motive\r\n\r\nAt the moment, a user without data browser write permission can still perform write operations. This is due to a cache issue in fh-mbaas-express. The \"read\" permission is being cached and used for \"write\" permission checks due to the same cache key is being used.\r\n\r\n## Changes\r\n\r\nInclude the require permission as part of the cache key.\r\n\r\n## JIRA\r\n\r\nhttps://issues.jboss.org/browse/RHMAP-11610","created_at":"2017-01-19T16:22:48Z","updated_at":"2017-01-19T16:23:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06101b6c2b8dcc81b6f2795f745a0f2a49e60d4e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16/commits","review_comments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16/comments","review_comment_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/issues/16/comments","statuses_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/statuses/ed99019fef714648e07afacc69d823dedeb33346","head":{"label":"wei-lee:RHMAP-11610-databrowser-perm-cache","ref":"RHMAP-11610-databrowser-perm-cache","sha":"ed99019fef714648e07afacc69d823dedeb33346","user":{"login":"wei-lee","id":912729,"avatar_url":"https://avatars.githubusercontent.com/u/912729?v=3","gravatar_id":"","url":"https://api.github.com/users/wei-lee","html_url":"https://github.com/wei-lee","followers_url":"https://api.github.com/users/wei-lee/followers","following_url":"https://api.github.com/users/wei-lee/following{/other_user}","gists_url":"https://api.github.com/users/wei-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/wei-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wei-lee/subscriptions","organizations_url":"https://api.github.com/users/wei-lee/orgs","repos_url":"https://api.github.com/users/wei-lee/repos","events_url":"https://api.github.com/users/wei-lee/events{/privacy}","received_events_url":"https://api.github.com/users/wei-lee/received_events","type":"User","site_admin":false},"repo":{"id":79340053,"name":"fh-mbaas-express","full_name":"wei-lee/fh-mbaas-express","owner":{"login":"wei-lee","id":912729,"avatar_url":"https://avatars.githubusercontent.com/u/912729?v=3","gravatar_id":"","url":"https://api.github.com/users/wei-lee","html_url":"https://github.com/wei-lee","followers_url":"https://api.github.com/users/wei-lee/followers","following_url":"https://api.github.com/users/wei-lee/following{/other_user}","gists_url":"https://api.github.com/users/wei-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/wei-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wei-lee/subscriptions","organizations_url":"https://api.github.com/users/wei-lee/orgs","repos_url":"https://api.github.com/users/wei-lee/repos","events_url":"https://api.github.com/users/wei-lee/events{/privacy}","received_events_url":"https://api.github.com/users/wei-lee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wei-lee/fh-mbaas-express","description":null,"fork":true,"url":"https://api.github.com/repos/wei-lee/fh-mbaas-express","forks_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/forks","keys_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/teams","hooks_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/hooks","issue_events_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/issues/events{/number}","events_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/events","assignees_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/assignees{/user}","branches_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/branches{/branch}","tags_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/tags","blobs_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/statuses/{sha}","languages_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/languages","stargazers_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/stargazers","contributors_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/contributors","subscribers_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/subscribers","subscription_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/subscription","commits_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/contents/{+path}","compare_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/merges","archive_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/downloads","issues_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/issues{/number}","pulls_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/pulls{/number}","milestones_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/milestones{/number}","notifications_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/labels{/name}","releases_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/releases{/id}","deployments_url":"https://api.github.com/repos/wei-lee/fh-mbaas-express/deployments","created_at":"2017-01-18T12:57:14Z","updated_at":"2017-01-18T12:57:16Z","pushed_at":"2017-01-19T16:20:06Z","git_url":"git://github.com/wei-lee/fh-mbaas-express.git","ssh_url":"git@github.com:wei-lee/fh-mbaas-express.git","clone_url":"https://github.com/wei-lee/fh-mbaas-express.git","svn_url":"https://github.com/wei-lee/fh-mbaas-express","homepage":null,"size":1440,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"51304bacdec9ec487cb950a32df5449b591fb9a9","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":62570827,"name":"fh-mbaas-express","full_name":"feedhenry/fh-mbaas-express","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/fh-mbaas-express","description":null,"fork":false,"url":"https://api.github.com/repos/feedhenry/fh-mbaas-express","forks_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/forks","keys_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/teams","hooks_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/events","assignees_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/tags","blobs_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/languages","stargazers_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/subscription","commits_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/merges","archive_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/downloads","issues_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-express/deployments","created_at":"2016-07-04T15:09:29Z","updated_at":"2016-12-09T09:42:55Z","pushed_at":"2017-01-19T16:22:49Z","git_url":"git://github.com/feedhenry/fh-mbaas-express.git","ssh_url":"git@github.com:feedhenry/fh-mbaas-express.git","clone_url":"https://github.com/feedhenry/fh-mbaas-express.git","svn_url":"https://github.com/feedhenry/fh-mbaas-express","homepage":null,"size":1448,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16"},"html":{"href":"https://github.com/feedhenry/fh-mbaas-express/pull/16"},"issue":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/issues/16"},"comments":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-express/statuses/ed99019fef714648e07afacc69d823dedeb33346"}}}}
{"actor":{"display_login":"fh-qube"}}