{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments/151765976","pull_request_review_id":77532776,"id":151765976,"diff_hunk":"@@ -43,64 +43,51 @@ class RegionDetails extends Component {\n     }\n     return (\n       <Col md={3} className=\"device-location-conatiner\">\n-        <div>\n-          <h3>\n-            {selectedDeviceGroupName}\n-          </h3>\n-          <div className=\"device-subheading\">\n-            {lang.DEVICES}\n-          </div>\n-          <Row className=\"alarm-warning-container\">\n-            <Col md={6} className=\"total-alarms-container\">\n-              <div className=\"total-alarms\">\n-                {regionDetailsProps.totalAlarmDeviceCount}\n-              </div>\n-              <svg className=\" total triangle\">\n-                <polygon points=\"25,2.5 48.5,49.8 2.5,49.8\" fill=\"#fc540a\" />\n-              </svg>\n-              <div className=\"critical\">\n-                {lang.CRITICAL}\n-              </div>\n-            </Col>\n-            <Col md={6} className=\" total-alarms-container warnings-container\">\n-              <div className=\" total-alarms total-warnings\">\n-                {regionDetailsProps.totalWarningsDeviceCount}\n-              </div>\n-              <svg className=\"triangle rectangle\">\n-                <rect width=\"8\" height=\"8\" fill=\"#FDE870\" />\n-              </svg>\n-              <div className=\" total warnings\">\n-                {lang.WARNINGS}\n-              </div>\n-            </Col>\n-          </Row>\n-          <Row>\n-            <Col md={4} className=\"total-container\">\n-              <div className=\"total\">\n-                {regionDetailsProps.onlineDevicesCount + regionDetailsProps.offlineDevicesCount}\n-              </div>\n-              <div className=\"warnings\">\n-                {lang.TOTAL}\n-              </div>\n-            </Col>\n-            <Col md={4} className=\"total-container total-online-container\">\n-              <div className=\"total-online\">\n-                {regionDetailsProps.onlineDevicesCount}\n-              </div>\n-              <div className=\"online\">\n-                {lang.ONLINE}\n-              </div>\n-            </Col>\n-            <Col md={4} className=\"total-container total-offline-container\">\n-              <div className=\"total-offline\">\n-                {regionDetailsProps.offlineDevicesCount}\n-              </div>\n-              <div className=\"offline\">\n-                {lang.OFFLINE}\n-              </div>\n-            </Col>\n-          </Row>\n-        </div>\n+        <h3>{selectedDeviceGroupName}</h3>\n+        <Row className=\"alarm-warning-container\">\n+          <Col md={6} className=\"total-alarms-container\">\n+            <div className=\"total-alarms\">\n+              {regionDetailsProps.totalAlarmDeviceCount}\n+            </div>\n+            <svg className=\" total triangle\">\n+              <polygon points=\"25,2.5 48.5,49.8 2.5,49.8\" fill=\"#fc540a\" />\n+            </svg>\n+            <div className=\"critical\">{lang.CRITICAL}</div>\n+          </Col>\n+          <Col md={6} className=\" total-alarms-container warnings-container\">\n+            <div className=\" total-alarms total-warnings\">\n+              {regionDetailsProps.totalWarningsDeviceCount}\n+            </div>\n+            <svg className=\"triangle rectangle\">","path":"src/components/deviceMap/regionDetails.js","position":77,"original_position":77,"commit_id":"8457cbf923ebf7cd75069afd96fa3eed009d1ab4","original_commit_id":"8457cbf923ebf7cd75069afd96fa3eed009d1ab4","user":{"login":"spryor","id":1734193,"avatar_url":"https://avatars1.githubusercontent.com/u/1734193?v=4","gravatar_id":"","url":"https://api.github.com/users/spryor","html_url":"https://github.com/spryor","followers_url":"https://api.github.com/users/spryor/followers","following_url":"https://api.github.com/users/spryor/following{/other_user}","gists_url":"https://api.github.com/users/spryor/gists{/gist_id}","starred_url":"https://api.github.com/users/spryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryor/subscriptions","organizations_url":"https://api.github.com/users/spryor/orgs","repos_url":"https://api.github.com/users/spryor/repos","events_url":"https://api.github.com/users/spryor/events{/privacy}","received_events_url":"https://api.github.com/users/spryor/received_events","type":"User","site_admin":false},"body":"Why are these SVGs embedded directly into the markup?","created_at":"2017-11-17T19:09:42Z","updated_at":"2017-11-17T19:10:20Z","html_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/821#discussion_r151765976","pull_request_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments/151765976"},"html":{"href":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/821#discussion_r151765976"},"pull_request":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821","id":152907445,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/821","diff_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/821.diff","patch_url":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/821.patch","issue_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/821","number":821,"state":"open","locked":false,"title":"online to connected","user":{"login":"swetha571","id":16091688,"avatar_url":"https://avatars3.githubusercontent.com/u/16091688?v=4","gravatar_id":"","url":"https://api.github.com/users/swetha571","html_url":"https://github.com/swetha571","followers_url":"https://api.github.com/users/swetha571/followers","following_url":"https://api.github.com/users/swetha571/following{/other_user}","gists_url":"https://api.github.com/users/swetha571/gists{/gist_id}","starred_url":"https://api.github.com/users/swetha571/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swetha571/subscriptions","organizations_url":"https://api.github.com/users/swetha571/orgs","repos_url":"https://api.github.com/users/swetha571/repos","events_url":"https://api.github.com/users/swetha571/events{/privacy}","received_events_url":"https://api.github.com/users/swetha571/received_events","type":"User","site_admin":false},"body":"# Type of change? <!-- [x] all the boxes that apply -->\r\n\r\n- [x] Bug fix\r\n- [ ] New feature\r\n- [ ] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n# Description, Context, Motivation\r\n Online to connected in Dashboard\r\n\r\n...\r\n\r\n**Checklist:**\r\n\r\n- [ ] All tests passed\r\n- [ ] The code follows the code style and conventions of this project\r\n- [ ] The change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n","created_at":"2017-11-15T22:54:42Z","updated_at":"2017-11-17T19:10:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e68bccce328209ab338a3a6f8e9cf634b553c0d2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821/commits","review_comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821/comments","review_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/821/comments","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/8457cbf923ebf7cd75069afd96fa3eed009d1ab4","head":{"label":"Azure:ss.OnlineToConnected","ref":"ss.OnlineToConnected","sha":"8457cbf923ebf7cd75069afd96fa3eed009d1ab4","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89969457,"name":"pcs-remote-monitoring-webui","full_name":"Azure/pcs-remote-monitoring-webui","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui","description":"Azure IoT PCS Remote Monitoring Web UI","fork":false,"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui","forks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/forks","keys_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/events","assignees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/merges","archive_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/deployments","created_at":"2017-05-01T22:47:49Z","updated_at":"2017-11-16T09:23:42Z","pushed_at":"2017-11-17T19:08:41Z","git_url":"git://github.com/Azure/pcs-remote-monitoring-webui.git","ssh_url":"git@github.com:Azure/pcs-remote-monitoring-webui.git","clone_url":"https://github.com/Azure/pcs-remote-monitoring-webui.git","svn_url":"https://github.com/Azure/pcs-remote-monitoring-webui","homepage":null,"size":2017,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":176,"forks":4,"open_issues":176,"watchers":7,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"ca9f5e14f3427def10a4c460530b3090225c60e2","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":89969457,"name":"pcs-remote-monitoring-webui","full_name":"Azure/pcs-remote-monitoring-webui","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/pcs-remote-monitoring-webui","description":"Azure IoT PCS Remote Monitoring Web UI","fork":false,"url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui","forks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/forks","keys_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/teams","hooks_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/hooks","issue_events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/events","assignees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/tags","blobs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/languages","stargazers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/stargazers","contributors_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contributors","subscribers_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscribers","subscription_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/subscription","commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/merges","archive_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/downloads","issues_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/labels{/name}","releases_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/deployments","created_at":"2017-05-01T22:47:49Z","updated_at":"2017-11-16T09:23:42Z","pushed_at":"2017-11-17T19:08:41Z","git_url":"git://github.com/Azure/pcs-remote-monitoring-webui.git","ssh_url":"git@github.com:Azure/pcs-remote-monitoring-webui.git","clone_url":"https://github.com/Azure/pcs-remote-monitoring-webui.git","svn_url":"https://github.com/Azure/pcs-remote-monitoring-webui","homepage":null,"size":2017,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":176,"forks":4,"open_issues":176,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821"},"html":{"href":"https://github.com/Azure/pcs-remote-monitoring-webui/pull/821"},"issue":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/821"},"comments":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/pcs-remote-monitoring-webui/statuses/8457cbf923ebf7cd75069afd96fa3eed009d1ab4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spryor"}}