{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/15283","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/15283/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/15283/comments","events_url":"https://api.github.com/repos/servo/servo/issues/15283/events","html_url":"https://github.com/servo/servo/pull/15283","id":203820908,"number":15283,"title":"Implement the form owner concept","user":{"login":"canaltinova","id":466239,"avatar_url":"https://avatars.githubusercontent.com/u/466239?v=3","gravatar_id":"","url":"https://api.github.com/users/canaltinova","html_url":"https://github.com/canaltinova","followers_url":"https://api.github.com/users/canaltinova/followers","following_url":"https://api.github.com/users/canaltinova/following{/other_user}","gists_url":"https://api.github.com/users/canaltinova/gists{/gist_id}","starred_url":"https://api.github.com/users/canaltinova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canaltinova/subscriptions","organizations_url":"https://api.github.com/users/canaltinova/orgs","repos_url":"https://api.github.com/users/canaltinova/repos","events_url":"https://api.github.com/users/canaltinova/events{/privacy}","received_events_url":"https://api.github.com/users/canaltinova/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false},{"id":152310100,"url":"https://api.github.com/repos/servo/servo/labels/S-tests-failed","name":"S-tests-failed","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-01-28T17:55:37Z","updated_at":"2017-01-28T18:23:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/15283","html_url":"https://github.com/servo/servo/pull/15283","diff_url":"https://github.com/servo/servo/pull/15283.diff","patch_url":"https://github.com/servo/servo/pull/15283.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\nImplemention of the core logic for form owners. It's rebased version of #6613, addressed most of the comments and fixed some of the code. I needed to update the code by hand instead of rebasing old main commit because of the massive merge conflicts over the years.\r\n\r\nThe html5ever PR is here: https://github.com/servo/html5ever/pull/249\r\n\r\nCurrently I'm using my html5ever fork to run the tests. I'll undo the changes in Cargo.toml and Cargo.lock once it gets merged.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #3553 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/15283)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/275865059","html_url":"https://github.com/servo/servo/pull/15283#issuecomment-275865059","issue_url":"https://api.github.com/repos/servo/servo/issues/15283","id":275865059,"user":{"login":"canaltinova","id":466239,"avatar_url":"https://avatars.githubusercontent.com/u/466239?v=3","gravatar_id":"","url":"https://api.github.com/users/canaltinova","html_url":"https://github.com/canaltinova","followers_url":"https://api.github.com/users/canaltinova/followers","following_url":"https://api.github.com/users/canaltinova/following{/other_user}","gists_url":"https://api.github.com/users/canaltinova/gists{/gist_id}","starred_url":"https://api.github.com/users/canaltinova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canaltinova/subscriptions","organizations_url":"https://api.github.com/users/canaltinova/orgs","repos_url":"https://api.github.com/users/canaltinova/repos","events_url":"https://api.github.com/users/canaltinova/events{/privacy}","received_events_url":"https://api.github.com/users/canaltinova/received_events","type":"User","site_admin":false},"created_at":"2017-01-28T18:23:39Z","updated_at":"2017-01-28T18:23:39Z","body":"Running builds: \r\nhttp://build.servo.org/builders/linux-rel-css/builds/2115\r\n"}}
{"actor":{"display_login":"canaltinova"}}