{"action":"closed","number":159,"pull_request":{"url":"https://api.github.com/repos/MetaMask/provider-engine/pulls/159","id":123614653,"html_url":"https://github.com/MetaMask/provider-engine/pull/159","diff_url":"https://github.com/MetaMask/provider-engine/pull/159.diff","patch_url":"https://github.com/MetaMask/provider-engine/pull/159.patch","issue_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/159","number":159,"state":"closed","locked":false,"title":"Fix cache identifier","user":{"login":"flyswatter","id":542863,"avatar_url":"https://avatars3.githubusercontent.com/u/542863?v=3","gravatar_id":"","url":"https://api.github.com/users/flyswatter","html_url":"https://github.com/flyswatter","followers_url":"https://api.github.com/users/flyswatter/followers","following_url":"https://api.github.com/users/flyswatter/following{/other_user}","gists_url":"https://api.github.com/users/flyswatter/gists{/gist_id}","starred_url":"https://api.github.com/users/flyswatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyswatter/subscriptions","organizations_url":"https://api.github.com/users/flyswatter/orgs","repos_url":"https://api.github.com/users/flyswatter/repos","events_url":"https://api.github.com/users/flyswatter/events{/privacy}","received_events_url":"https://api.github.com/users/flyswatter/received_events","type":"User","site_admin":false},"body":"A proposed fix to https://github.com/MetaMask/metamask-plugin/issues/1526\r\n\r\nMakes numeric block requests hit the cache normally (all block tag parameters were previously being stripped).\r\n\r\nViolated two assertions relating to returning cached values on consecutive calls to `getCode`. I think those assertions are not as important as this fix, and so have removed them for current simplicity.","created_at":"2017-06-01T23:28:29Z","updated_at":"2017-06-02T16:04:37Z","closed_at":"2017-06-02T16:04:37Z","merged_at":null,"merge_commit_sha":"bd209920bcd0b95c78eac1b8f702732ce7de53c4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MetaMask/provider-engine/pulls/159/commits","review_comments_url":"https://api.github.com/repos/MetaMask/provider-engine/pulls/159/comments","review_comment_url":"https://api.github.com/repos/MetaMask/provider-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/159/comments","statuses_url":"https://api.github.com/repos/MetaMask/provider-engine/statuses/162678aa4c7ca75cc755c671876943d50dbf5b0a","head":{"label":"MetaMask:FixCacheIdentifier2","ref":"FixCacheIdentifier2","sha":"162678aa4c7ca75cc755c671876943d50dbf5b0a","user":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars1.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"repo":{"id":47658358,"name":"provider-engine","full_name":"MetaMask/provider-engine","owner":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars1.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaMask/provider-engine","description":"zero client provider engine","fork":false,"url":"https://api.github.com/repos/MetaMask/provider-engine","forks_url":"https://api.github.com/repos/MetaMask/provider-engine/forks","keys_url":"https://api.github.com/repos/MetaMask/provider-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaMask/provider-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaMask/provider-engine/teams","hooks_url":"https://api.github.com/repos/MetaMask/provider-engine/hooks","issue_events_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/events{/number}","events_url":"https://api.github.com/repos/MetaMask/provider-engine/events","assignees_url":"https://api.github.com/repos/MetaMask/provider-engine/assignees{/user}","branches_url":"https://api.github.com/repos/MetaMask/provider-engine/branches{/branch}","tags_url":"https://api.github.com/repos/MetaMask/provider-engine/tags","blobs_url":"https://api.github.com/repos/MetaMask/provider-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaMask/provider-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaMask/provider-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaMask/provider-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaMask/provider-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaMask/provider-engine/languages","stargazers_url":"https://api.github.com/repos/MetaMask/provider-engine/stargazers","contributors_url":"https://api.github.com/repos/MetaMask/provider-engine/contributors","subscribers_url":"https://api.github.com/repos/MetaMask/provider-engine/subscribers","subscription_url":"https://api.github.com/repos/MetaMask/provider-engine/subscription","commits_url":"https://api.github.com/repos/MetaMask/provider-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaMask/provider-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaMask/provider-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetaMask/provider-engine/contents/{+path}","compare_url":"https://api.github.com/repos/MetaMask/provider-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaMask/provider-engine/merges","archive_url":"https://api.github.com/repos/MetaMask/provider-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaMask/provider-engine/downloads","issues_url":"https://api.github.com/repos/MetaMask/provider-engine/issues{/number}","pulls_url":"https://api.github.com/repos/MetaMask/provider-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaMask/provider-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaMask/provider-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaMask/provider-engine/labels{/name}","releases_url":"https://api.github.com/repos/MetaMask/provider-engine/releases{/id}","deployments_url":"https://api.github.com/repos/MetaMask/provider-engine/deployments","created_at":"2015-12-09T00:32:36Z","updated_at":"2017-05-30T14:51:37Z","pushed_at":"2017-06-02T07:22:17Z","git_url":"git://github.com/MetaMask/provider-engine.git","ssh_url":"git@github.com:MetaMask/provider-engine.git","clone_url":"https://github.com/MetaMask/provider-engine.git","svn_url":"https://github.com/MetaMask/provider-engine","homepage":null,"size":2166,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":41,"forks":40,"open_issues":41,"watchers":53,"default_branch":"master"}},"base":{"label":"MetaMask:master","ref":"master","sha":"ae5a9ec7afccf9511094eb18b4f98f12e93b7272","user":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars1.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"repo":{"id":47658358,"name":"provider-engine","full_name":"MetaMask/provider-engine","owner":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars1.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaMask/provider-engine","description":"zero client provider engine","fork":false,"url":"https://api.github.com/repos/MetaMask/provider-engine","forks_url":"https://api.github.com/repos/MetaMask/provider-engine/forks","keys_url":"https://api.github.com/repos/MetaMask/provider-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaMask/provider-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaMask/provider-engine/teams","hooks_url":"https://api.github.com/repos/MetaMask/provider-engine/hooks","issue_events_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/events{/number}","events_url":"https://api.github.com/repos/MetaMask/provider-engine/events","assignees_url":"https://api.github.com/repos/MetaMask/provider-engine/assignees{/user}","branches_url":"https://api.github.com/repos/MetaMask/provider-engine/branches{/branch}","tags_url":"https://api.github.com/repos/MetaMask/provider-engine/tags","blobs_url":"https://api.github.com/repos/MetaMask/provider-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaMask/provider-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaMask/provider-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaMask/provider-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaMask/provider-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaMask/provider-engine/languages","stargazers_url":"https://api.github.com/repos/MetaMask/provider-engine/stargazers","contributors_url":"https://api.github.com/repos/MetaMask/provider-engine/contributors","subscribers_url":"https://api.github.com/repos/MetaMask/provider-engine/subscribers","subscription_url":"https://api.github.com/repos/MetaMask/provider-engine/subscription","commits_url":"https://api.github.com/repos/MetaMask/provider-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaMask/provider-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaMask/provider-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetaMask/provider-engine/contents/{+path}","compare_url":"https://api.github.com/repos/MetaMask/provider-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaMask/provider-engine/merges","archive_url":"https://api.github.com/repos/MetaMask/provider-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaMask/provider-engine/downloads","issues_url":"https://api.github.com/repos/MetaMask/provider-engine/issues{/number}","pulls_url":"https://api.github.com/repos/MetaMask/provider-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaMask/provider-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaMask/provider-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaMask/provider-engine/labels{/name}","releases_url":"https://api.github.com/repos/MetaMask/provider-engine/releases{/id}","deployments_url":"https://api.github.com/repos/MetaMask/provider-engine/deployments","created_at":"2015-12-09T00:32:36Z","updated_at":"2017-05-30T14:51:37Z","pushed_at":"2017-06-02T07:22:17Z","git_url":"git://github.com/MetaMask/provider-engine.git","ssh_url":"git@github.com:MetaMask/provider-engine.git","clone_url":"https://github.com/MetaMask/provider-engine.git","svn_url":"https://github.com/MetaMask/provider-engine","homepage":null,"size":2166,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":41,"forks":40,"open_issues":41,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MetaMask/provider-engine/pulls/159"},"html":{"href":"https://github.com/MetaMask/provider-engine/pull/159"},"issue":{"href":"https://api.github.com/repos/MetaMask/provider-engine/issues/159"},"comments":{"href":"https://api.github.com/repos/MetaMask/provider-engine/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/MetaMask/provider-engine/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/MetaMask/provider-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MetaMask/provider-engine/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/MetaMask/provider-engine/statuses/162678aa4c7ca75cc755c671876943d50dbf5b0a"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":2232,"deletions":29,"changed_files":9}}
{"actor":{"display_login":"flyswatter"}}