{"action":"created","issue":{"url":"https://api.github.com/repos/convox/rack/issues/2140","repository_url":"https://api.github.com/repos/convox/rack","labels_url":"https://api.github.com/repos/convox/rack/issues/2140/labels{/name}","comments_url":"https://api.github.com/repos/convox/rack/issues/2140/comments","events_url":"https://api.github.com/repos/convox/rack/issues/2140/events","html_url":"https://github.com/convox/rack/pull/2140","id":220696107,"number":2140,"title":"agent 0.71","user":{"login":"nzoschke","id":147410,"avatar_url":"https://avatars1.githubusercontent.com/u/147410?v=3","gravatar_id":"","url":"https://api.github.com/users/nzoschke","html_url":"https://github.com/nzoschke","followers_url":"https://api.github.com/users/nzoschke/followers","following_url":"https://api.github.com/users/nzoschke/following{/other_user}","gists_url":"https://api.github.com/users/nzoschke/gists{/gist_id}","starred_url":"https://api.github.com/users/nzoschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzoschke/subscriptions","organizations_url":"https://api.github.com/users/nzoschke/orgs","repos_url":"https://api.github.com/users/nzoschke/repos","events_url":"https://api.github.com/users/nzoschke/events{/privacy}","received_events_url":"https://api.github.com/users/nzoschke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-10T16:16:19Z","updated_at":"2017-04-10T18:46:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/2140","html_url":"https://github.com/convox/rack/pull/2140","diff_url":"https://github.com/convox/rack/pull/2140.diff","patch_url":"https://github.com/convox/rack/pull/2140.patch"},"body":"### Description\r\n\r\nAddresses https://github.com/convox/rack/issues/2133\r\n\r\nThis adds a new convox/agent version (PR https://github.com/convox/agent/pull/28), which addresses a performance issue with the recently introduced app `NativeLogging=Yes` parameter (release [20170330004259](https://github.com/convox/rack/releases/tag/20170330004259))\r\n\r\n### Summary for release notes\r\n\r\nThis will cause noticeable instance performance  improvements for apps that use the `NativeLogging` parameter.\r\n\r\nBecause it is a UserData change, this release will trigger an instance replacement. Instance replacement is a standard procedure, and are designed to cause little to no app container interruptions.\r\n\r\n### Guidance for reviewers\r\n\r\n- [x] Create a branch release (20170410163137-native-logging)\r\n- [x] Verify all changes on https://github.com/convox/agent/pull/28 has been released as 0.71 ([DockerHub](https://hub.docker.com/r/convox/agent/tags/))\r\n- [x] Update a rack to `20170330004259` or higher\r\n- [x] Deploy an app\r\n- [x] Set `convox apps params NativeLogging=Yes`\r\n- [x] SSH into an instance running an app container. Observe **high** `agent` CPU usage in `top`\r\n- [ ] Update a rack to this branch release\r\n- [ ] SSH into an instance running an app container. Observe **low** `agent` CPU usage in `top`\r\n- [ ] Verify app logs are still flowing through the native `awslogs` driver path\r\n\r\n### Before Release\r\n\r\n- [ ] Rebase against master\r\n- [ ] Get review approval\r\n- [ ] Confirm test coverage\r\n- [ ] Submit documentation PR for convox/site\r\n"},"comment":{"url":"https://api.github.com/repos/convox/rack/issues/comments/293042686","html_url":"https://github.com/convox/rack/pull/2140#issuecomment-293042686","issue_url":"https://api.github.com/repos/convox/rack/issues/2140","id":293042686,"user":{"login":"nzoschke","id":147410,"avatar_url":"https://avatars1.githubusercontent.com/u/147410?v=3","gravatar_id":"","url":"https://api.github.com/users/nzoschke","html_url":"https://github.com/nzoschke","followers_url":"https://api.github.com/users/nzoschke/followers","following_url":"https://api.github.com/users/nzoschke/following{/other_user}","gists_url":"https://api.github.com/users/nzoschke/gists{/gist_id}","starred_url":"https://api.github.com/users/nzoschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzoschke/subscriptions","organizations_url":"https://api.github.com/users/nzoschke/orgs","repos_url":"https://api.github.com/users/nzoschke/repos","events_url":"https://api.github.com/users/nzoschke/events{/privacy}","received_events_url":"https://api.github.com/users/nzoschke/received_events","type":"User","site_admin":false},"created_at":"2017-04-10T18:46:53Z","updated_at":"2017-04-10T18:46:53Z","body":"On release `20170405220740` with NativeLogging=Yes on an app, I see very high CPU on one instance.\r\n\r\n```\r\n$ convox instances\r\nID                   AGENT  STATUS  STARTED         PS  CPU     MEM\r\ni-0db9e357374805d4c  on     active  26 minutes ago  3   80.55%  12.08%\r\ni-00bc13e2b0fa35587  on     active  14 minutes ago  0   0.37%   0.00%\r\ni-03b0bb447b1e675c2  on     active  23 minutes ago  1   0.97%   6.39%\r\n```\r\n\r\nAfter updating to this release:\r\n\r\n```\r\n$ convox instances\r\nID                   AGENT  STATUS  STARTED         PS  CPU    MEM\r\ni-0862145dd4d1dc597  on     active  17 minutes ago  2   1.53%  9.59%\r\ni-08a6de55b3a7bf98a  on     active  15 minutes ago  1   1.03%  2.50%\r\ni-013022634b170d35c  on     active  13 minutes ago  1   1.14%  6.39%\r\n```"}}
{"actor":{"display_login":"nzoschke"}}