{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/2269","repository_url":"https://api.github.com/repos/palantir/atlasdb","labels_url":"https://api.github.com/repos/palantir/atlasdb/issues/2269/labels{/name}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/2269/comments","events_url":"https://api.github.com/repos/palantir/atlasdb/issues/2269/events","html_url":"https://github.com/palantir/atlasdb/pull/2269","id":251252245,"number":2269,"title":"[Startup Independence] Part 1: Asynchronous Initialization","user":{"login":"hsaraogi","id":20421615,"avatar_url":"https://avatars2.githubusercontent.com/u/20421615?v=4","gravatar_id":"","url":"https://api.github.com/users/hsaraogi","html_url":"https://github.com/hsaraogi","followers_url":"https://api.github.com/users/hsaraogi/followers","following_url":"https://api.github.com/users/hsaraogi/following{/other_user}","gists_url":"https://api.github.com/users/hsaraogi/gists{/gist_id}","starred_url":"https://api.github.com/users/hsaraogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsaraogi/subscriptions","organizations_url":"https://api.github.com/users/hsaraogi/orgs","repos_url":"https://api.github.com/users/hsaraogi/repos","events_url":"https://api.github.com/users/hsaraogi/events{/privacy}","received_events_url":"https://api.github.com/users/hsaraogi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-18T13:53:35Z","updated_at":"2017-09-14T12:31:00Z","closed_at":"2017-09-14T12:31:00Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/2269","html_url":"https://github.com/palantir/atlasdb/pull/2269","diff_url":"https://github.com/palantir/atlasdb/pull/2269.diff","patch_url":"https://github.com/palantir/atlasdb/pull/2269.patch"},"body":"**Goals (and why)**: Fix #930.\r\n\r\n**Implementation Description (bullets)**: \r\n1. Create an initializingWrapper for things that need to be initialized on startup after extracting interfaces.\r\n2. Test that TransactionManager.create passes through without the KVs being up and operations are successful once its up.\r\n\r\n**Concerns (what feedback would you like?)**: \r\n1. Are the error messages sane?\r\n2. Does the approach makes sense.\r\n\r\n**Where should we start reviewing?**: TransactionManagers.create\r\n\r\n**Priority (whenever / two weeks / yesterday)**: one week.\r\n\r\n<!---\r\nPlease remember to:\r\n- Add any necessary release notes (including breaking changes)\r\n- Make sure the documentation is up to date for your change\r\n--->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/2269)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/comments/329467027","html_url":"https://github.com/palantir/atlasdb/pull/2269#issuecomment-329467027","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/2269","id":329467027,"user":{"login":"fsamuel-bs","id":2558069,"avatar_url":"https://avatars0.githubusercontent.com/u/2558069?v=4","gravatar_id":"","url":"https://api.github.com/users/fsamuel-bs","html_url":"https://github.com/fsamuel-bs","followers_url":"https://api.github.com/users/fsamuel-bs/followers","following_url":"https://api.github.com/users/fsamuel-bs/following{/other_user}","gists_url":"https://api.github.com/users/fsamuel-bs/gists{/gist_id}","starred_url":"https://api.github.com/users/fsamuel-bs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsamuel-bs/subscriptions","organizations_url":"https://api.github.com/users/fsamuel-bs/orgs","repos_url":"https://api.github.com/users/fsamuel-bs/repos","events_url":"https://api.github.com/users/fsamuel-bs/events{/privacy}","received_events_url":"https://api.github.com/users/fsamuel-bs/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T12:30:59Z","updated_at":"2017-09-14T12:30:59Z","author_association":"CONTRIBUTOR","body":"Closing in favor of #2300. Part 2 contains all of PRs of Part 1, and it doesn't make sense to review Part 1 by itself, as Part 2 contains tests and refactors of Part 1."}}
{"actor":{"display_login":"fsamuel-bs"}}