{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments/150301031","pull_request_review_id":75836963,"id":150301031,"diff_hunk":"@@ -90,20 +90,29 @@ export default class RushCommandLineParser extends CommandLineParser {\n   }\n \n   private _execute(): void {\n-    this.telemetry = new Telemetry(this.rushConfig);\n+    if (this.rushConfig) {\n+      this.telemetry = new Telemetry(this.rushConfig);\n+    }\n+\n     super.onExecute();\n-    this.flushTelemetry();\n+\n+    if (this.telemetry) {\n+      this.flushTelemetry();\n+    }\n   }\n \n   private _populateActions(): void {\n     try {\n-      this.rushConfig = RushConfiguration.loadFromDefaultLocation();\n+      let  commandLineConfig: CommandLineConfiguration | undefined = undefined;\n+\n+      if (RushConfiguration.tryFindRushJsonLocation()) {","path":"apps/rush-lib/src/cli/actions/RushCommandLineParser.ts","position":null,"original_position":31,"commit_id":"b189d05eebe5f01bcd6ccaf2eba1e34f3b88a9e2","original_commit_id":"957f2d4a0f9153dbfb6103a8e378ce7979b879e9","user":{"login":"pgonzal","id":4673363,"avatar_url":"https://avatars0.githubusercontent.com/u/4673363?v=4","gravatar_id":"","url":"https://api.github.com/users/pgonzal","html_url":"https://github.com/pgonzal","followers_url":"https://api.github.com/users/pgonzal/followers","following_url":"https://api.github.com/users/pgonzal/following{/other_user}","gists_url":"https://api.github.com/users/pgonzal/gists{/gist_id}","starred_url":"https://api.github.com/users/pgonzal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgonzal/subscriptions","organizations_url":"https://api.github.com/users/pgonzal/orgs","repos_url":"https://api.github.com/users/pgonzal/repos","events_url":"https://api.github.com/users/pgonzal/events{/privacy}","received_events_url":"https://api.github.com/users/pgonzal/received_events","type":"User","site_admin":false},"body":"Good idea\r\n\r\n---\r\nIn reply to: [150166540](https://github.com/Microsoft/web-build-tools/pull/437#discussion_r150166540) [](ancestors = 150166540)","created_at":"2017-11-10T18:03:51Z","updated_at":"2017-11-10T18:03:51Z","html_url":"https://github.com/Microsoft/web-build-tools/pull/437#discussion_r150301031","pull_request_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments/150301031"},"html":{"href":"https://github.com/Microsoft/web-build-tools/pull/437#discussion_r150301031"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437"}},"in_reply_to_id":150166540},"pull_request":{"url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437","id":151817568,"html_url":"https://github.com/Microsoft/web-build-tools/pull/437","diff_url":"https://github.com/Microsoft/web-build-tools/pull/437.diff","patch_url":"https://github.com/Microsoft/web-build-tools/pull/437.patch","issue_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/437","number":437,"state":"open","locked":false,"title":"Fix the regression where \"rush -h\" didn't work outside a repo","user":{"login":"pgonzal","id":4673363,"avatar_url":"https://avatars0.githubusercontent.com/u/4673363?v=4","gravatar_id":"","url":"https://api.github.com/users/pgonzal","html_url":"https://github.com/pgonzal","followers_url":"https://api.github.com/users/pgonzal/followers","following_url":"https://api.github.com/users/pgonzal/following{/other_user}","gists_url":"https://api.github.com/users/pgonzal/gists{/gist_id}","starred_url":"https://api.github.com/users/pgonzal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgonzal/subscriptions","organizations_url":"https://api.github.com/users/pgonzal/orgs","repos_url":"https://api.github.com/users/pgonzal/repos","events_url":"https://api.github.com/users/pgonzal/events{/privacy}","received_events_url":"https://api.github.com/users/pgonzal/received_events","type":"User","site_admin":false},"body":"The `rush -h` command was failing when you ran it outside a repo, because code had crept in that assumes there is a RushConfiguration object.\r\n\r\nThis broke our [3 Minute Demo](https://github.com/Microsoft/web-build-tools/wiki/Rush#3-minute-demo).","created_at":"2017-11-10T03:16:30Z","updated_at":"2017-11-10T18:03:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f269f6a4f36e8cfdade72c5bd236d9063ac4637","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iclanton","id":5010588,"avatar_url":"https://avatars1.githubusercontent.com/u/5010588?v=4","gravatar_id":"","url":"https://api.github.com/users/iclanton","html_url":"https://github.com/iclanton","followers_url":"https://api.github.com/users/iclanton/followers","following_url":"https://api.github.com/users/iclanton/following{/other_user}","gists_url":"https://api.github.com/users/iclanton/gists{/gist_id}","starred_url":"https://api.github.com/users/iclanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iclanton/subscriptions","organizations_url":"https://api.github.com/users/iclanton/orgs","repos_url":"https://api.github.com/users/iclanton/repos","events_url":"https://api.github.com/users/iclanton/events{/privacy}","received_events_url":"https://api.github.com/users/iclanton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437/commits","review_comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437/comments","review_comment_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/437/comments","statuses_url":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/b189d05eebe5f01bcd6ccaf2eba1e34f3b88a9e2","head":{"label":"Microsoft:pgonzal/rush-help-broken","ref":"pgonzal/rush-help-broken","sha":"b189d05eebe5f01bcd6ccaf2eba1e34f3b88a9e2","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":69618902,"name":"web-build-tools","full_name":"Microsoft/web-build-tools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/web-build-tools","description":"A tool box for large scale web development","fork":false,"url":"https://api.github.com/repos/Microsoft/web-build-tools","forks_url":"https://api.github.com/repos/Microsoft/web-build-tools/forks","keys_url":"https://api.github.com/repos/Microsoft/web-build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/web-build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/web-build-tools/teams","hooks_url":"https://api.github.com/repos/Microsoft/web-build-tools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/web-build-tools/events","assignees_url":"https://api.github.com/repos/Microsoft/web-build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/web-build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/tags","blobs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/web-build-tools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/web-build-tools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/web-build-tools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscription","commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/web-build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/web-build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/web-build-tools/merges","archive_url":"https://api.github.com/repos/Microsoft/web-build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/web-build-tools/downloads","issues_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/web-build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/web-build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/web-build-tools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/web-build-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/web-build-tools/deployments","created_at":"2016-09-30T00:28:20Z","updated_at":"2017-11-10T16:38:26Z","pushed_at":"2017-11-10T18:03:16Z","git_url":"git://github.com/Microsoft/web-build-tools.git","ssh_url":"git@github.com:Microsoft/web-build-tools.git","clone_url":"https://github.com/Microsoft/web-build-tools.git","svn_url":"https://github.com/Microsoft/web-build-tools","homepage":"","size":9273,"stargazers_count":114,"watchers_count":114,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":32,"forks":38,"open_issues":32,"watchers":114,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"d7e5c1a1020a2c6899d1c99bb3822b91ba8eae0a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":69618902,"name":"web-build-tools","full_name":"Microsoft/web-build-tools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/web-build-tools","description":"A tool box for large scale web development","fork":false,"url":"https://api.github.com/repos/Microsoft/web-build-tools","forks_url":"https://api.github.com/repos/Microsoft/web-build-tools/forks","keys_url":"https://api.github.com/repos/Microsoft/web-build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/web-build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/web-build-tools/teams","hooks_url":"https://api.github.com/repos/Microsoft/web-build-tools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/web-build-tools/events","assignees_url":"https://api.github.com/repos/Microsoft/web-build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/web-build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/tags","blobs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/web-build-tools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/web-build-tools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/web-build-tools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/web-build-tools/subscription","commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/web-build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/web-build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/web-build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/web-build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/web-build-tools/merges","archive_url":"https://api.github.com/repos/Microsoft/web-build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/web-build-tools/downloads","issues_url":"https://api.github.com/repos/Microsoft/web-build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/web-build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/web-build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/web-build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/web-build-tools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/web-build-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/web-build-tools/deployments","created_at":"2016-09-30T00:28:20Z","updated_at":"2017-11-10T16:38:26Z","pushed_at":"2017-11-10T18:03:16Z","git_url":"git://github.com/Microsoft/web-build-tools.git","ssh_url":"git@github.com:Microsoft/web-build-tools.git","clone_url":"https://github.com/Microsoft/web-build-tools.git","svn_url":"https://github.com/Microsoft/web-build-tools","homepage":"","size":9273,"stargazers_count":114,"watchers_count":114,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":32,"forks":38,"open_issues":32,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437"},"html":{"href":"https://github.com/Microsoft/web-build-tools/pull/437"},"issue":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/issues/437"},"comments":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/web-build-tools/statuses/b189d05eebe5f01bcd6ccaf2eba1e34f3b88a9e2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pgonzal"}}