{"action":"closed","number":1985,"pull_request":{"url":"https://api.github.com/repos/HTBox/allReady/pulls/1985","id":118810228,"html_url":"https://github.com/HTBox/allReady/pull/1985","diff_url":"https://github.com/HTBox/allReady/pull/1985.diff","patch_url":"https://github.com/HTBox/allReady/pull/1985.patch","issue_url":"https://api.github.com/repos/HTBox/allReady/issues/1985","number":1985,"state":"closed","locked":false,"title":"Added unit test to cover the SendInProgressStatusToGetASmokeAlarmHandler","user":{"login":"YannickMeeus","id":588607,"avatar_url":"https://avatars3.githubusercontent.com/u/588607?v=3","gravatar_id":"","url":"https://api.github.com/users/YannickMeeus","html_url":"https://github.com/YannickMeeus","followers_url":"https://api.github.com/users/YannickMeeus/followers","following_url":"https://api.github.com/users/YannickMeeus/following{/other_user}","gists_url":"https://api.github.com/users/YannickMeeus/gists{/gist_id}","starred_url":"https://api.github.com/users/YannickMeeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannickMeeus/subscriptions","organizations_url":"https://api.github.com/users/YannickMeeus/orgs","repos_url":"https://api.github.com/users/YannickMeeus/repos","events_url":"https://api.github.com/users/YannickMeeus/events{/privacy}","received_events_url":"https://api.github.com/users/YannickMeeus/received_events","type":"User","site_admin":false},"body":"Fixes #1765.\r\n\r\nI settled on only one Unit Test for this. I'm not 100% convinced about it, but it seemed overkill to cover separate use-cases for a single request *and* multiple requests.\r\n\r\nOne thing I can think of that might be worth covering is a negative case, to verify that if no requests are found then nothing is queued up. One would argue we'd be testing the .NET framework, but at the very least it would verify the behaviour of this particular handler, instead of the implementation. ","created_at":"2017-05-03T17:09:27Z","updated_at":"2017-05-07T14:22:02Z","closed_at":"2017-05-07T14:22:02Z","merged_at":"2017-05-07T14:22:02Z","merge_commit_sha":"4ff6312a4c7049fd4ce9220553de4cd41d92689c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HTBox/allReady/pulls/1985/commits","review_comments_url":"https://api.github.com/repos/HTBox/allReady/pulls/1985/comments","review_comment_url":"https://api.github.com/repos/HTBox/allReady/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HTBox/allReady/issues/1985/comments","statuses_url":"https://api.github.com/repos/HTBox/allReady/statuses/b9f2d8d97f9c7abf746348614e914458dc2629da","head":{"label":"YannickMeeus:SendInProgressStatusToGetASmokeAlarmHandlerUnitTests","ref":"SendInProgressStatusToGetASmokeAlarmHandlerUnitTests","sha":"b9f2d8d97f9c7abf746348614e914458dc2629da","user":{"login":"YannickMeeus","id":588607,"avatar_url":"https://avatars3.githubusercontent.com/u/588607?v=3","gravatar_id":"","url":"https://api.github.com/users/YannickMeeus","html_url":"https://github.com/YannickMeeus","followers_url":"https://api.github.com/users/YannickMeeus/followers","following_url":"https://api.github.com/users/YannickMeeus/following{/other_user}","gists_url":"https://api.github.com/users/YannickMeeus/gists{/gist_id}","starred_url":"https://api.github.com/users/YannickMeeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannickMeeus/subscriptions","organizations_url":"https://api.github.com/users/YannickMeeus/orgs","repos_url":"https://api.github.com/users/YannickMeeus/repos","events_url":"https://api.github.com/users/YannickMeeus/events{/privacy}","received_events_url":"https://api.github.com/users/YannickMeeus/received_events","type":"User","site_admin":false},"repo":{"id":85675558,"name":"allReady","full_name":"YannickMeeus/allReady","owner":{"login":"YannickMeeus","id":588607,"avatar_url":"https://avatars3.githubusercontent.com/u/588607?v=3","gravatar_id":"","url":"https://api.github.com/users/YannickMeeus","html_url":"https://github.com/YannickMeeus","followers_url":"https://api.github.com/users/YannickMeeus/followers","following_url":"https://api.github.com/users/YannickMeeus/following{/other_user}","gists_url":"https://api.github.com/users/YannickMeeus/gists{/gist_id}","starred_url":"https://api.github.com/users/YannickMeeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannickMeeus/subscriptions","organizations_url":"https://api.github.com/users/YannickMeeus/orgs","repos_url":"https://api.github.com/users/YannickMeeus/repos","events_url":"https://api.github.com/users/YannickMeeus/events{/privacy}","received_events_url":"https://api.github.com/users/YannickMeeus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YannickMeeus/allReady","description":"This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.","fork":true,"url":"https://api.github.com/repos/YannickMeeus/allReady","forks_url":"https://api.github.com/repos/YannickMeeus/allReady/forks","keys_url":"https://api.github.com/repos/YannickMeeus/allReady/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YannickMeeus/allReady/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YannickMeeus/allReady/teams","hooks_url":"https://api.github.com/repos/YannickMeeus/allReady/hooks","issue_events_url":"https://api.github.com/repos/YannickMeeus/allReady/issues/events{/number}","events_url":"https://api.github.com/repos/YannickMeeus/allReady/events","assignees_url":"https://api.github.com/repos/YannickMeeus/allReady/assignees{/user}","branches_url":"https://api.github.com/repos/YannickMeeus/allReady/branches{/branch}","tags_url":"https://api.github.com/repos/YannickMeeus/allReady/tags","blobs_url":"https://api.github.com/repos/YannickMeeus/allReady/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YannickMeeus/allReady/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YannickMeeus/allReady/git/refs{/sha}","trees_url":"https://api.github.com/repos/YannickMeeus/allReady/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YannickMeeus/allReady/statuses/{sha}","languages_url":"https://api.github.com/repos/YannickMeeus/allReady/languages","stargazers_url":"https://api.github.com/repos/YannickMeeus/allReady/stargazers","contributors_url":"https://api.github.com/repos/YannickMeeus/allReady/contributors","subscribers_url":"https://api.github.com/repos/YannickMeeus/allReady/subscribers","subscription_url":"https://api.github.com/repos/YannickMeeus/allReady/subscription","commits_url":"https://api.github.com/repos/YannickMeeus/allReady/commits{/sha}","git_commits_url":"https://api.github.com/repos/YannickMeeus/allReady/git/commits{/sha}","comments_url":"https://api.github.com/repos/YannickMeeus/allReady/comments{/number}","issue_comment_url":"https://api.github.com/repos/YannickMeeus/allReady/issues/comments{/number}","contents_url":"https://api.github.com/repos/YannickMeeus/allReady/contents/{+path}","compare_url":"https://api.github.com/repos/YannickMeeus/allReady/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YannickMeeus/allReady/merges","archive_url":"https://api.github.com/repos/YannickMeeus/allReady/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YannickMeeus/allReady/downloads","issues_url":"https://api.github.com/repos/YannickMeeus/allReady/issues{/number}","pulls_url":"https://api.github.com/repos/YannickMeeus/allReady/pulls{/number}","milestones_url":"https://api.github.com/repos/YannickMeeus/allReady/milestones{/number}","notifications_url":"https://api.github.com/repos/YannickMeeus/allReady/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YannickMeeus/allReady/labels{/name}","releases_url":"https://api.github.com/repos/YannickMeeus/allReady/releases{/id}","deployments_url":"https://api.github.com/repos/YannickMeeus/allReady/deployments","created_at":"2017-03-21T08:13:00Z","updated_at":"2017-03-21T08:13:04Z","pushed_at":"2017-05-05T07:56:23Z","git_url":"git://github.com/YannickMeeus/allReady.git","ssh_url":"git@github.com:YannickMeeus/allReady.git","clone_url":"https://github.com/YannickMeeus/allReady.git","svn_url":"https://github.com/YannickMeeus/allReady","homepage":"http://www.htbox.org/projects/allready","size":33123,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HTBox:master","ref":"master","sha":"3cc62abec849769a47017be21ba3af1f2565d3d3","user":{"login":"HTBox","id":5184596,"avatar_url":"https://avatars1.githubusercontent.com/u/5184596?v=3","gravatar_id":"","url":"https://api.github.com/users/HTBox","html_url":"https://github.com/HTBox","followers_url":"https://api.github.com/users/HTBox/followers","following_url":"https://api.github.com/users/HTBox/following{/other_user}","gists_url":"https://api.github.com/users/HTBox/gists{/gist_id}","starred_url":"https://api.github.com/users/HTBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTBox/subscriptions","organizations_url":"https://api.github.com/users/HTBox/orgs","repos_url":"https://api.github.com/users/HTBox/repos","events_url":"https://api.github.com/users/HTBox/events{/privacy}","received_events_url":"https://api.github.com/users/HTBox/received_events","type":"Organization","site_admin":false},"repo":{"id":39270253,"name":"allReady","full_name":"HTBox/allReady","owner":{"login":"HTBox","id":5184596,"avatar_url":"https://avatars1.githubusercontent.com/u/5184596?v=3","gravatar_id":"","url":"https://api.github.com/users/HTBox","html_url":"https://github.com/HTBox","followers_url":"https://api.github.com/users/HTBox/followers","following_url":"https://api.github.com/users/HTBox/following{/other_user}","gists_url":"https://api.github.com/users/HTBox/gists{/gist_id}","starred_url":"https://api.github.com/users/HTBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTBox/subscriptions","organizations_url":"https://api.github.com/users/HTBox/orgs","repos_url":"https://api.github.com/users/HTBox/repos","events_url":"https://api.github.com/users/HTBox/events{/privacy}","received_events_url":"https://api.github.com/users/HTBox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HTBox/allReady","description":"This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.","fork":false,"url":"https://api.github.com/repos/HTBox/allReady","forks_url":"https://api.github.com/repos/HTBox/allReady/forks","keys_url":"https://api.github.com/repos/HTBox/allReady/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HTBox/allReady/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HTBox/allReady/teams","hooks_url":"https://api.github.com/repos/HTBox/allReady/hooks","issue_events_url":"https://api.github.com/repos/HTBox/allReady/issues/events{/number}","events_url":"https://api.github.com/repos/HTBox/allReady/events","assignees_url":"https://api.github.com/repos/HTBox/allReady/assignees{/user}","branches_url":"https://api.github.com/repos/HTBox/allReady/branches{/branch}","tags_url":"https://api.github.com/repos/HTBox/allReady/tags","blobs_url":"https://api.github.com/repos/HTBox/allReady/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HTBox/allReady/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HTBox/allReady/git/refs{/sha}","trees_url":"https://api.github.com/repos/HTBox/allReady/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HTBox/allReady/statuses/{sha}","languages_url":"https://api.github.com/repos/HTBox/allReady/languages","stargazers_url":"https://api.github.com/repos/HTBox/allReady/stargazers","contributors_url":"https://api.github.com/repos/HTBox/allReady/contributors","subscribers_url":"https://api.github.com/repos/HTBox/allReady/subscribers","subscription_url":"https://api.github.com/repos/HTBox/allReady/subscription","commits_url":"https://api.github.com/repos/HTBox/allReady/commits{/sha}","git_commits_url":"https://api.github.com/repos/HTBox/allReady/git/commits{/sha}","comments_url":"https://api.github.com/repos/HTBox/allReady/comments{/number}","issue_comment_url":"https://api.github.com/repos/HTBox/allReady/issues/comments{/number}","contents_url":"https://api.github.com/repos/HTBox/allReady/contents/{+path}","compare_url":"https://api.github.com/repos/HTBox/allReady/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HTBox/allReady/merges","archive_url":"https://api.github.com/repos/HTBox/allReady/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HTBox/allReady/downloads","issues_url":"https://api.github.com/repos/HTBox/allReady/issues{/number}","pulls_url":"https://api.github.com/repos/HTBox/allReady/pulls{/number}","milestones_url":"https://api.github.com/repos/HTBox/allReady/milestones{/number}","notifications_url":"https://api.github.com/repos/HTBox/allReady/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HTBox/allReady/labels{/name}","releases_url":"https://api.github.com/repos/HTBox/allReady/releases{/id}","deployments_url":"https://api.github.com/repos/HTBox/allReady/deployments","created_at":"2015-07-17T18:51:45Z","updated_at":"2017-05-07T06:54:51Z","pushed_at":"2017-05-07T14:22:02Z","git_url":"git://github.com/HTBox/allReady.git","ssh_url":"git@github.com:HTBox/allReady.git","clone_url":"https://github.com/HTBox/allReady.git","svn_url":"https://github.com/HTBox/allReady","homepage":"http://www.htbox.org/projects/allready","size":33105,"stargazers_count":525,"watchers_count":525,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":422,"mirror_url":null,"open_issues_count":208,"forks":422,"open_issues":208,"watchers":525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/1985"},"html":{"href":"https://github.com/HTBox/allReady/pull/1985"},"issue":{"href":"https://api.github.com/repos/HTBox/allReady/issues/1985"},"comments":{"href":"https://api.github.com/repos/HTBox/allReady/issues/1985/comments"},"review_comments":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/1985/comments"},"review_comment":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/1985/commits"},"statuses":{"href":"https://api.github.com/repos/HTBox/allReady/statuses/b9f2d8d97f9c7abf746348614e914458dc2629da"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tonysurma","id":5067595,"avatar_url":"https://avatars2.githubusercontent.com/u/5067595?v=3","gravatar_id":"","url":"https://api.github.com/users/tonysurma","html_url":"https://github.com/tonysurma","followers_url":"https://api.github.com/users/tonysurma/followers","following_url":"https://api.github.com/users/tonysurma/following{/other_user}","gists_url":"https://api.github.com/users/tonysurma/gists{/gist_id}","starred_url":"https://api.github.com/users/tonysurma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonysurma/subscriptions","organizations_url":"https://api.github.com/users/tonysurma/orgs","repos_url":"https://api.github.com/users/tonysurma/repos","events_url":"https://api.github.com/users/tonysurma/events{/privacy}","received_events_url":"https://api.github.com/users/tonysurma/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":46,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"tonysurma"}}