{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/113675152","pull_request_review_id":35082961,"id":113675152,"diff_hunk":"@@ -227,7 +227,7 @@ _SALT_MASTER_ADDRESS=${BS_SALT_MASTER_ADDRESS:-null}\n _SALT_MINION_ID=\"null\"\n # _SIMPLIFY_VERSION is mostly used in Solaris based distributions\n _SIMPLIFY_VERSION=$BS_TRUE\n-_LIBCLOUD_MIN_VERSION=\"0.14.0\"\n+_LIBCLOUD_MIN_VERSION=\"2.0.0\"","path":"salt/cloud/deploy/bootstrap-salt.sh","position":5,"original_position":5,"commit_id":"1ff7ee302aee3a8e6d074a9e9e9553a3a9a47e20","original_commit_id":"1ff7ee302aee3a8e6d074a9e9e9553a3a9a47e20","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars0.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"If it's bootstrap, we want to talk to @rallytime here. :]","created_at":"2017-04-27T11:40:13Z","updated_at":"2017-04-27T11:40:13Z","html_url":"https://github.com/saltstack/salt/pull/40837#discussion_r113675152","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/40837","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/113675152"},"html":{"href":"https://github.com/saltstack/salt/pull/40837#discussion_r113675152"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40837"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/40837","id":117133353,"html_url":"https://github.com/saltstack/salt/pull/40837","diff_url":"https://github.com/saltstack/salt/pull/40837.diff","patch_url":"https://github.com/saltstack/salt/pull/40837.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/40837","number":40837,"state":"open","locked":false,"title":"Upgrade apache-libcloud package dependency for 2.0","user":{"login":"tonybaloney","id":1532417,"avatar_url":"https://avatars2.githubusercontent.com/u/1532417?v=3","gravatar_id":"","url":"https://api.github.com/users/tonybaloney","html_url":"https://github.com/tonybaloney","followers_url":"https://api.github.com/users/tonybaloney/followers","following_url":"https://api.github.com/users/tonybaloney/following{/other_user}","gists_url":"https://api.github.com/users/tonybaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaloney/subscriptions","organizations_url":"https://api.github.com/users/tonybaloney/orgs","repos_url":"https://api.github.com/users/tonybaloney/repos","events_url":"https://api.github.com/users/tonybaloney/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaloney/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nThis package updates the apache-libcloud dependency for salt-cloud to the 2.0 version, from 0.14. \r\n\r\n0.14 is a _very_ old version of libcloud and there have been performance improvements, stability changes and security fixes in the past 2 years that salt-cloud could take advantage of. Most of the salt-cloud modules that use libcloud e.g. GCP and Dimension Data require a newer version anyway, so the user just has to upgrade. \r\n\r\nThe 2.0 release also no longer uses httplib, now uses the `requests` package, which is already a dependency of salt and doesn't require SSL cert configuration for the CA store. The implications are \r\nhttp://libcloud.readthedocs.io/en/latest/other/changes_in_2_0.html\r\n2.0 supports Python 3.6, drops 2.5 and 3.2. Python 2.6 support is still included.\r\n\r\nThis is an open PR for discussion, look at the downstream dependencies and their impact. Also, part of a conversation with @techhat \r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nI've left a comment over the 2.0 build as only rc2 is on PyPi at the moment but the full release comes out this week.","created_at":"2017-04-23T02:21:41Z","updated_at":"2017-04-27T11:40:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bd6bcda329063b8b8239e8870f57aef3fee20d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/40837/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/40837/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/40837/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/1ff7ee302aee3a8e6d074a9e9e9553a3a9a47e20","head":{"label":"tonybaloney:libcloud_2","ref":"libcloud_2","sha":"1ff7ee302aee3a8e6d074a9e9e9553a3a9a47e20","user":{"login":"tonybaloney","id":1532417,"avatar_url":"https://avatars2.githubusercontent.com/u/1532417?v=3","gravatar_id":"","url":"https://api.github.com/users/tonybaloney","html_url":"https://github.com/tonybaloney","followers_url":"https://api.github.com/users/tonybaloney/followers","following_url":"https://api.github.com/users/tonybaloney/following{/other_user}","gists_url":"https://api.github.com/users/tonybaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaloney/subscriptions","organizations_url":"https://api.github.com/users/tonybaloney/orgs","repos_url":"https://api.github.com/users/tonybaloney/repos","events_url":"https://api.github.com/users/tonybaloney/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaloney/received_events","type":"User","site_admin":false},"repo":{"id":87769613,"name":"salt","full_name":"tonybaloney/salt","owner":{"login":"tonybaloney","id":1532417,"avatar_url":"https://avatars2.githubusercontent.com/u/1532417?v=3","gravatar_id":"","url":"https://api.github.com/users/tonybaloney","html_url":"https://github.com/tonybaloney","followers_url":"https://api.github.com/users/tonybaloney/followers","following_url":"https://api.github.com/users/tonybaloney/following{/other_user}","gists_url":"https://api.github.com/users/tonybaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaloney/subscriptions","organizations_url":"https://api.github.com/users/tonybaloney/orgs","repos_url":"https://api.github.com/users/tonybaloney/repos","events_url":"https://api.github.com/users/tonybaloney/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaloney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonybaloney/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/tonybaloney/salt","forks_url":"https://api.github.com/repos/tonybaloney/salt/forks","keys_url":"https://api.github.com/repos/tonybaloney/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonybaloney/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonybaloney/salt/teams","hooks_url":"https://api.github.com/repos/tonybaloney/salt/hooks","issue_events_url":"https://api.github.com/repos/tonybaloney/salt/issues/events{/number}","events_url":"https://api.github.com/repos/tonybaloney/salt/events","assignees_url":"https://api.github.com/repos/tonybaloney/salt/assignees{/user}","branches_url":"https://api.github.com/repos/tonybaloney/salt/branches{/branch}","tags_url":"https://api.github.com/repos/tonybaloney/salt/tags","blobs_url":"https://api.github.com/repos/tonybaloney/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonybaloney/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonybaloney/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonybaloney/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonybaloney/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/tonybaloney/salt/languages","stargazers_url":"https://api.github.com/repos/tonybaloney/salt/stargazers","contributors_url":"https://api.github.com/repos/tonybaloney/salt/contributors","subscribers_url":"https://api.github.com/repos/tonybaloney/salt/subscribers","subscription_url":"https://api.github.com/repos/tonybaloney/salt/subscription","commits_url":"https://api.github.com/repos/tonybaloney/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonybaloney/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonybaloney/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonybaloney/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonybaloney/salt/contents/{+path}","compare_url":"https://api.github.com/repos/tonybaloney/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonybaloney/salt/merges","archive_url":"https://api.github.com/repos/tonybaloney/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonybaloney/salt/downloads","issues_url":"https://api.github.com/repos/tonybaloney/salt/issues{/number}","pulls_url":"https://api.github.com/repos/tonybaloney/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/tonybaloney/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/tonybaloney/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonybaloney/salt/labels{/name}","releases_url":"https://api.github.com/repos/tonybaloney/salt/releases{/id}","deployments_url":"https://api.github.com/repos/tonybaloney/salt/deployments","created_at":"2017-04-10T05:22:38Z","updated_at":"2017-04-24T22:15:02Z","pushed_at":"2017-04-27T01:44:07Z","git_url":"git://github.com/tonybaloney/salt.git","ssh_url":"git@github.com:tonybaloney/salt.git","clone_url":"https://github.com/tonybaloney/salt.git","svn_url":"https://github.com/tonybaloney/salt","homepage":"https://repo.saltstack.com/","size":164252,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"d14def64548712e4f2b5d5c1653f2a8671f89c5c","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars0.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2017-04-27T09:35:34Z","pushed_at":"2017-04-27T11:33:00Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":164753,"stargazers_count":7622,"watchers_count":7622,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3543,"mirror_url":null,"open_issues_count":4474,"forks":3543,"open_issues":4474,"watchers":7622,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40837"},"html":{"href":"https://github.com/saltstack/salt/pull/40837"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/40837"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/40837/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40837/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/40837/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/1ff7ee302aee3a8e6d074a9e9e9553a3a9a47e20"}}}}
{"actor":{"display_login":"cachedout"}}