{"action":"created","comment":{"url":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/comments/96097133","pull_request_review_id":16675958,"id":96097133,"diff_hunk":"@@ -14,11 +15,34 @@\n \n public class OnboardingSection {\n \n-    public OnboardingSection() {}\n+    /**\n+     * These are pre-defined onboarding section identifiers\n+     * that are used to create default helper enums for OnboardingSectionType\n+     */\n+    public static final String LOGIN_IDENTIFIER = \"login\";","path":"backbone/src/main/java/org/researchstack/backbone/onboarding/OnboardingSection.java","position":23,"original_position":23,"commit_id":"fb2fe10e1509251216cbd931c642741ca73731c6","original_commit_id":"fb2fe10e1509251216cbd931c642741ca73731c6","user":{"login":"dephillipsmichael","id":5590748,"avatar_url":"https://avatars.githubusercontent.com/u/5590748?v=3","gravatar_id":"","url":"https://api.github.com/users/dephillipsmichael","html_url":"https://github.com/dephillipsmichael","followers_url":"https://api.github.com/users/dephillipsmichael/followers","following_url":"https://api.github.com/users/dephillipsmichael/following{/other_user}","gists_url":"https://api.github.com/users/dephillipsmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/dephillipsmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dephillipsmichael/subscriptions","organizations_url":"https://api.github.com/users/dephillipsmichael/orgs","repos_url":"https://api.github.com/users/dephillipsmichael/repos","events_url":"https://api.github.com/users/dephillipsmichael/events{/privacy}","received_events_url":"https://api.github.com/users/dephillipsmichael/received_events","type":"User","site_admin":false},"body":"In the past in iOS, Eric and I have needed to access these identifiers, so I think it' valid to make them public.  \r\n\r\nAlso, I had to make OnboardingSectionType.LOGIN.getIdentifier() a protected method, because you shouldn't call it.  You should call getTypeIdentifier() on the OnboardinSection object instead. I changed it to this to support unique custom identifiers per enum.  ","created_at":"2017-01-13T23:57:56Z","updated_at":"2017-01-13T23:57:56Z","html_url":"https://github.com/ResearchStack/ResearchStack/pull/317#discussion_r96097133","pull_request_url":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/comments/96097133"},"html":{"href":"https://github.com/ResearchStack/ResearchStack/pull/317#discussion_r96097133"},"pull_request":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317","id":100487381,"html_url":"https://github.com/ResearchStack/ResearchStack/pull/317","diff_url":"https://github.com/ResearchStack/ResearchStack/pull/317.diff","patch_url":"https://github.com/ResearchStack/ResearchStack/pull/317.patch","issue_url":"https://api.github.com/repos/ResearchStack/ResearchStack/issues/317","number":317,"state":"open","locked":false,"title":"Feature/ma 11 factories","user":{"login":"dephillipsmichael","id":5590748,"avatar_url":"https://avatars.githubusercontent.com/u/5590748?v=3","gravatar_id":"","url":"https://api.github.com/users/dephillipsmichael","html_url":"https://github.com/dephillipsmichael","followers_url":"https://api.github.com/users/dephillipsmichael/followers","following_url":"https://api.github.com/users/dephillipsmichael/following{/other_user}","gists_url":"https://api.github.com/users/dephillipsmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/dephillipsmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dephillipsmichael/subscriptions","organizations_url":"https://api.github.com/users/dephillipsmichael/orgs","repos_url":"https://api.github.com/users/dephillipsmichael/repos","events_url":"https://api.github.com/users/dephillipsmichael/events{/privacy}","received_events_url":"https://api.github.com/users/dephillipsmichael/received_events","type":"User","site_admin":false},"body":"This is a full functional implementation of the Survey Factory and Consent Document Factory.\r\nThe unit tests have verified that it can parse the iOS version of the Onboarding.json, which also parses consent.json and eligibility.json and create a NavigableOrderedTask full of the correct steps that will guide the user correctly through on boarding by using JSON.\r\n\r\nThe SurveyFactory will also be what is used for parsing surveys that come down from the loadTask web call once we get web survey functionality into the app.\r\n\r\nI understand this is a lot of code, but know that most of it was transcribed from the iOS BridgeAppSdk\r\n\r\n","created_at":"2017-01-06T16:43:13Z","updated_at":"2017-01-13T23:57:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"959fb9eb0f3b3f48747a08ab4cd55071c544b75e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317/commits","review_comments_url":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317/comments","review_comment_url":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ResearchStack/ResearchStack/issues/317/comments","statuses_url":"https://api.github.com/repos/ResearchStack/ResearchStack/statuses/fb2fe10e1509251216cbd931c642741ca73731c6","head":{"label":"dephillipsmichael:feature/MA-11-factories","ref":"feature/MA-11-factories","sha":"fb2fe10e1509251216cbd931c642741ca73731c6","user":{"login":"dephillipsmichael","id":5590748,"avatar_url":"https://avatars.githubusercontent.com/u/5590748?v=3","gravatar_id":"","url":"https://api.github.com/users/dephillipsmichael","html_url":"https://github.com/dephillipsmichael","followers_url":"https://api.github.com/users/dephillipsmichael/followers","following_url":"https://api.github.com/users/dephillipsmichael/following{/other_user}","gists_url":"https://api.github.com/users/dephillipsmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/dephillipsmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dephillipsmichael/subscriptions","organizations_url":"https://api.github.com/users/dephillipsmichael/orgs","repos_url":"https://api.github.com/users/dephillipsmichael/repos","events_url":"https://api.github.com/users/dephillipsmichael/events{/privacy}","received_events_url":"https://api.github.com/users/dephillipsmichael/received_events","type":"User","site_admin":false},"repo":{"id":75979890,"name":"ResearchStack-1","full_name":"dephillipsmichael/ResearchStack-1","owner":{"login":"dephillipsmichael","id":5590748,"avatar_url":"https://avatars.githubusercontent.com/u/5590748?v=3","gravatar_id":"","url":"https://api.github.com/users/dephillipsmichael","html_url":"https://github.com/dephillipsmichael","followers_url":"https://api.github.com/users/dephillipsmichael/followers","following_url":"https://api.github.com/users/dephillipsmichael/following{/other_user}","gists_url":"https://api.github.com/users/dephillipsmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/dephillipsmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dephillipsmichael/subscriptions","organizations_url":"https://api.github.com/users/dephillipsmichael/orgs","repos_url":"https://api.github.com/users/dephillipsmichael/repos","events_url":"https://api.github.com/users/dephillipsmichael/events{/privacy}","received_events_url":"https://api.github.com/users/dephillipsmichael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dephillipsmichael/ResearchStack-1","description":"An SDK for building research study apps on Android.","fork":true,"url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1","forks_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/forks","keys_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/teams","hooks_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/hooks","issue_events_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/issues/events{/number}","events_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/events","assignees_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/assignees{/user}","branches_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/branches{/branch}","tags_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/tags","blobs_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/languages","stargazers_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/stargazers","contributors_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/contributors","subscribers_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/subscribers","subscription_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/subscription","commits_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/contents/{+path}","compare_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/merges","archive_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/downloads","issues_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/issues{/number}","pulls_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/labels{/name}","releases_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/releases{/id}","deployments_url":"https://api.github.com/repos/dephillipsmichael/ResearchStack-1/deployments","created_at":"2016-12-08T22:18:47Z","updated_at":"2016-12-08T22:18:49Z","pushed_at":"2017-01-12T19:45:28Z","git_url":"git://github.com/dephillipsmichael/ResearchStack-1.git","ssh_url":"git@github.com:dephillipsmichael/ResearchStack-1.git","clone_url":"https://github.com/dephillipsmichael/ResearchStack-1.git","svn_url":"https://github.com/dephillipsmichael/ResearchStack-1","homepage":"http://researchstack.org","size":16661,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ResearchStack:develop","ref":"develop","sha":"06793603e9c2b6ff690355675e92467ec0cb5499","user":{"login":"ResearchStack","id":15782830,"avatar_url":"https://avatars.githubusercontent.com/u/15782830?v=3","gravatar_id":"","url":"https://api.github.com/users/ResearchStack","html_url":"https://github.com/ResearchStack","followers_url":"https://api.github.com/users/ResearchStack/followers","following_url":"https://api.github.com/users/ResearchStack/following{/other_user}","gists_url":"https://api.github.com/users/ResearchStack/gists{/gist_id}","starred_url":"https://api.github.com/users/ResearchStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResearchStack/subscriptions","organizations_url":"https://api.github.com/users/ResearchStack/orgs","repos_url":"https://api.github.com/users/ResearchStack/repos","events_url":"https://api.github.com/users/ResearchStack/events{/privacy}","received_events_url":"https://api.github.com/users/ResearchStack/received_events","type":"Organization","site_admin":false},"repo":{"id":43707061,"name":"ResearchStack","full_name":"ResearchStack/ResearchStack","owner":{"login":"ResearchStack","id":15782830,"avatar_url":"https://avatars.githubusercontent.com/u/15782830?v=3","gravatar_id":"","url":"https://api.github.com/users/ResearchStack","html_url":"https://github.com/ResearchStack","followers_url":"https://api.github.com/users/ResearchStack/followers","following_url":"https://api.github.com/users/ResearchStack/following{/other_user}","gists_url":"https://api.github.com/users/ResearchStack/gists{/gist_id}","starred_url":"https://api.github.com/users/ResearchStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResearchStack/subscriptions","organizations_url":"https://api.github.com/users/ResearchStack/orgs","repos_url":"https://api.github.com/users/ResearchStack/repos","events_url":"https://api.github.com/users/ResearchStack/events{/privacy}","received_events_url":"https://api.github.com/users/ResearchStack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ResearchStack/ResearchStack","description":"An SDK for building research study apps on Android.","fork":false,"url":"https://api.github.com/repos/ResearchStack/ResearchStack","forks_url":"https://api.github.com/repos/ResearchStack/ResearchStack/forks","keys_url":"https://api.github.com/repos/ResearchStack/ResearchStack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ResearchStack/ResearchStack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ResearchStack/ResearchStack/teams","hooks_url":"https://api.github.com/repos/ResearchStack/ResearchStack/hooks","issue_events_url":"https://api.github.com/repos/ResearchStack/ResearchStack/issues/events{/number}","events_url":"https://api.github.com/repos/ResearchStack/ResearchStack/events","assignees_url":"https://api.github.com/repos/ResearchStack/ResearchStack/assignees{/user}","branches_url":"https://api.github.com/repos/ResearchStack/ResearchStack/branches{/branch}","tags_url":"https://api.github.com/repos/ResearchStack/ResearchStack/tags","blobs_url":"https://api.github.com/repos/ResearchStack/ResearchStack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ResearchStack/ResearchStack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ResearchStack/ResearchStack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ResearchStack/ResearchStack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ResearchStack/ResearchStack/statuses/{sha}","languages_url":"https://api.github.com/repos/ResearchStack/ResearchStack/languages","stargazers_url":"https://api.github.com/repos/ResearchStack/ResearchStack/stargazers","contributors_url":"https://api.github.com/repos/ResearchStack/ResearchStack/contributors","subscribers_url":"https://api.github.com/repos/ResearchStack/ResearchStack/subscribers","subscription_url":"https://api.github.com/repos/ResearchStack/ResearchStack/subscription","commits_url":"https://api.github.com/repos/ResearchStack/ResearchStack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ResearchStack/ResearchStack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ResearchStack/ResearchStack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ResearchStack/ResearchStack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ResearchStack/ResearchStack/contents/{+path}","compare_url":"https://api.github.com/repos/ResearchStack/ResearchStack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ResearchStack/ResearchStack/merges","archive_url":"https://api.github.com/repos/ResearchStack/ResearchStack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ResearchStack/ResearchStack/downloads","issues_url":"https://api.github.com/repos/ResearchStack/ResearchStack/issues{/number}","pulls_url":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls{/number}","milestones_url":"https://api.github.com/repos/ResearchStack/ResearchStack/milestones{/number}","notifications_url":"https://api.github.com/repos/ResearchStack/ResearchStack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ResearchStack/ResearchStack/labels{/name}","releases_url":"https://api.github.com/repos/ResearchStack/ResearchStack/releases{/id}","deployments_url":"https://api.github.com/repos/ResearchStack/ResearchStack/deployments","created_at":"2015-10-05T19:04:26Z","updated_at":"2017-01-09T21:25:20Z","pushed_at":"2017-01-12T19:45:30Z","git_url":"git://github.com/ResearchStack/ResearchStack.git","ssh_url":"git@github.com:ResearchStack/ResearchStack.git","clone_url":"https://github.com/ResearchStack/ResearchStack.git","svn_url":"https://github.com/ResearchStack/ResearchStack","homepage":"http://researchstack.org","size":16477,"stargazers_count":62,"watchers_count":62,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":53,"forks":28,"open_issues":53,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317"},"html":{"href":"https://github.com/ResearchStack/ResearchStack/pull/317"},"issue":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/issues/317"},"comments":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/ResearchStack/ResearchStack/statuses/fb2fe10e1509251216cbd931c642741ca73731c6"}}}}
{"actor":{"display_login":"dephillipsmichael"}}