{"action":"created","comment":{"url":"https://api.github.com/repos/sol/hpack/pulls/comments/97263456","pull_request_review_id":17866525,"id":97263456,"diff_hunk":"@@ -642,6 +642,58 @@ spec = do\n         }\n         )\n \n+    context \"when reading custom-setup section\" $ do\n+      it \"warns on unknown fields\" $ do\n+        withPackageWarnings_ [i|\n+          name: foo\n+          custom-setup:\n+            foo: 1\n+            bar: 2\n+          |]\n+          (`shouldBe` [\n+            \"Ignoring unknown field \\\"bar\\\" in custom-setup section\"\n+          , \"Ignoring unknown field \\\"foo\\\" in custom-setup section\"\n+          ])\n+\n+      it \"warns when build-type is not Custom\" $ do\n+        withPackageWarnings_ [i|\n+          name: foo\n+          build-type: Simple\n+          custom-setup:\n+            dependencies:\n+              - base\n+          |]\n+          (`shouldBe` [\n+            \"Existence of `custom-setup` stanza implies `build-type: Custom`, but package.yaml sets `build-type: Simple`\"\n+          ])","path":"test/Hpack/ConfigSpec.hs","position":27,"original_position":27,"commit_id":"9dcc7be0201aedde3ca62d0225eb2c66e62fcfa2","original_commit_id":"9dcc7be0201aedde3ca62d0225eb2c66e62fcfa2","user":{"login":"sol","id":461132,"avatar_url":"https://avatars.githubusercontent.com/u/461132?v=3","gravatar_id":"","url":"https://api.github.com/users/sol","html_url":"https://github.com/sol","followers_url":"https://api.github.com/users/sol/followers","following_url":"https://api.github.com/users/sol/following{/other_user}","gists_url":"https://api.github.com/users/sol/gists{/gist_id}","starred_url":"https://api.github.com/users/sol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sol/subscriptions","organizations_url":"https://api.github.com/users/sol/orgs","repos_url":"https://api.github.com/users/sol/repos","events_url":"https://api.github.com/users/sol/events{/privacy}","received_events_url":"https://api.github.com/users/sol/received_events","type":"User","site_admin":false},"body":"As stated above, I would remove this test case.","created_at":"2017-01-23T07:28:26Z","updated_at":"2017-01-23T07:28:27Z","html_url":"https://github.com/sol/hpack/pull/148#discussion_r97263456","pull_request_url":"https://api.github.com/repos/sol/hpack/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/sol/hpack/pulls/comments/97263456"},"html":{"href":"https://github.com/sol/hpack/pull/148#discussion_r97263456"},"pull_request":{"href":"https://api.github.com/repos/sol/hpack/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/sol/hpack/pulls/148","id":101622614,"html_url":"https://github.com/sol/hpack/pull/148","diff_url":"https://github.com/sol/hpack/pull/148.diff","patch_url":"https://github.com/sol/hpack/pull/148.patch","issue_url":"https://api.github.com/repos/sol/hpack/issues/148","number":148,"state":"open","locked":false,"title":"Add setup-depends","user":{"login":"mitchellwrosen","id":1074598,"avatar_url":"https://avatars.githubusercontent.com/u/1074598?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellwrosen","html_url":"https://github.com/mitchellwrosen","followers_url":"https://api.github.com/users/mitchellwrosen/followers","following_url":"https://api.github.com/users/mitchellwrosen/following{/other_user}","gists_url":"https://api.github.com/users/mitchellwrosen/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellwrosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellwrosen/subscriptions","organizations_url":"https://api.github.com/users/mitchellwrosen/orgs","repos_url":"https://api.github.com/users/mitchellwrosen/repos","events_url":"https://api.github.com/users/mitchellwrosen/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellwrosen/received_events","type":"User","site_admin":false},"body":"Addresses #147 \r\n\r\nI did this rather quickly, please let me know if you see any problems.\r\n\r\nCouple notes...\r\n\r\n1. `setup-depends` is the only field inside a `custom-setup` stanza (currently), so I just made it a top-level field. Should it go inside a `custom-setup` stanza a la cabal instead?\r\n2. I'm not sure if having a `setup-depends` implies `build-type: Custom` or not.","created_at":"2017-01-16T02:43:16Z","updated_at":"2017-01-23T07:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d3a9ee0b081ee56c0e26633c5baeecc04b11c16","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sol/hpack/pulls/148/commits","review_comments_url":"https://api.github.com/repos/sol/hpack/pulls/148/comments","review_comment_url":"https://api.github.com/repos/sol/hpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sol/hpack/issues/148/comments","statuses_url":"https://api.github.com/repos/sol/hpack/statuses/9dcc7be0201aedde3ca62d0225eb2c66e62fcfa2","head":{"label":"mitchellwrosen:master","ref":"master","sha":"9dcc7be0201aedde3ca62d0225eb2c66e62fcfa2","user":{"login":"mitchellwrosen","id":1074598,"avatar_url":"https://avatars.githubusercontent.com/u/1074598?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellwrosen","html_url":"https://github.com/mitchellwrosen","followers_url":"https://api.github.com/users/mitchellwrosen/followers","following_url":"https://api.github.com/users/mitchellwrosen/following{/other_user}","gists_url":"https://api.github.com/users/mitchellwrosen/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellwrosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellwrosen/subscriptions","organizations_url":"https://api.github.com/users/mitchellwrosen/orgs","repos_url":"https://api.github.com/users/mitchellwrosen/repos","events_url":"https://api.github.com/users/mitchellwrosen/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellwrosen/received_events","type":"User","site_admin":false},"repo":{"id":52292903,"name":"hpack","full_name":"mitchellwrosen/hpack","owner":{"login":"mitchellwrosen","id":1074598,"avatar_url":"https://avatars.githubusercontent.com/u/1074598?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellwrosen","html_url":"https://github.com/mitchellwrosen","followers_url":"https://api.github.com/users/mitchellwrosen/followers","following_url":"https://api.github.com/users/mitchellwrosen/following{/other_user}","gists_url":"https://api.github.com/users/mitchellwrosen/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellwrosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellwrosen/subscriptions","organizations_url":"https://api.github.com/users/mitchellwrosen/orgs","repos_url":"https://api.github.com/users/mitchellwrosen/repos","events_url":"https://api.github.com/users/mitchellwrosen/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellwrosen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellwrosen/hpack","description":"hpack: An alternative format for Haskell packages","fork":true,"url":"https://api.github.com/repos/mitchellwrosen/hpack","forks_url":"https://api.github.com/repos/mitchellwrosen/hpack/forks","keys_url":"https://api.github.com/repos/mitchellwrosen/hpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellwrosen/hpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellwrosen/hpack/teams","hooks_url":"https://api.github.com/repos/mitchellwrosen/hpack/hooks","issue_events_url":"https://api.github.com/repos/mitchellwrosen/hpack/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellwrosen/hpack/events","assignees_url":"https://api.github.com/repos/mitchellwrosen/hpack/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellwrosen/hpack/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellwrosen/hpack/tags","blobs_url":"https://api.github.com/repos/mitchellwrosen/hpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellwrosen/hpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellwrosen/hpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellwrosen/hpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellwrosen/hpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellwrosen/hpack/languages","stargazers_url":"https://api.github.com/repos/mitchellwrosen/hpack/stargazers","contributors_url":"https://api.github.com/repos/mitchellwrosen/hpack/contributors","subscribers_url":"https://api.github.com/repos/mitchellwrosen/hpack/subscribers","subscription_url":"https://api.github.com/repos/mitchellwrosen/hpack/subscription","commits_url":"https://api.github.com/repos/mitchellwrosen/hpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellwrosen/hpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellwrosen/hpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellwrosen/hpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellwrosen/hpack/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellwrosen/hpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellwrosen/hpack/merges","archive_url":"https://api.github.com/repos/mitchellwrosen/hpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellwrosen/hpack/downloads","issues_url":"https://api.github.com/repos/mitchellwrosen/hpack/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellwrosen/hpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellwrosen/hpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellwrosen/hpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellwrosen/hpack/labels{/name}","releases_url":"https://api.github.com/repos/mitchellwrosen/hpack/releases{/id}","deployments_url":"https://api.github.com/repos/mitchellwrosen/hpack/deployments","created_at":"2016-02-22T17:51:33Z","updated_at":"2016-02-22T17:51:34Z","pushed_at":"2017-01-22T17:36:28Z","git_url":"git://github.com/mitchellwrosen/hpack.git","ssh_url":"git@github.com:mitchellwrosen/hpack.git","clone_url":"https://github.com/mitchellwrosen/hpack.git","svn_url":"https://github.com/mitchellwrosen/hpack","homepage":"","size":384,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sol:master","ref":"master","sha":"cb64a0b63fb04fc5bc9a2928ef8b61dfb35b63e9","user":{"login":"sol","id":461132,"avatar_url":"https://avatars.githubusercontent.com/u/461132?v=3","gravatar_id":"","url":"https://api.github.com/users/sol","html_url":"https://github.com/sol","followers_url":"https://api.github.com/users/sol/followers","following_url":"https://api.github.com/users/sol/following{/other_user}","gists_url":"https://api.github.com/users/sol/gists{/gist_id}","starred_url":"https://api.github.com/users/sol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sol/subscriptions","organizations_url":"https://api.github.com/users/sol/orgs","repos_url":"https://api.github.com/users/sol/repos","events_url":"https://api.github.com/users/sol/events{/privacy}","received_events_url":"https://api.github.com/users/sol/received_events","type":"User","site_admin":false},"repo":{"id":26865969,"name":"hpack","full_name":"sol/hpack","owner":{"login":"sol","id":461132,"avatar_url":"https://avatars.githubusercontent.com/u/461132?v=3","gravatar_id":"","url":"https://api.github.com/users/sol","html_url":"https://github.com/sol","followers_url":"https://api.github.com/users/sol/followers","following_url":"https://api.github.com/users/sol/following{/other_user}","gists_url":"https://api.github.com/users/sol/gists{/gist_id}","starred_url":"https://api.github.com/users/sol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sol/subscriptions","organizations_url":"https://api.github.com/users/sol/orgs","repos_url":"https://api.github.com/users/sol/repos","events_url":"https://api.github.com/users/sol/events{/privacy}","received_events_url":"https://api.github.com/users/sol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sol/hpack","description":"hpack: An alternative format for Haskell packages","fork":false,"url":"https://api.github.com/repos/sol/hpack","forks_url":"https://api.github.com/repos/sol/hpack/forks","keys_url":"https://api.github.com/repos/sol/hpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sol/hpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sol/hpack/teams","hooks_url":"https://api.github.com/repos/sol/hpack/hooks","issue_events_url":"https://api.github.com/repos/sol/hpack/issues/events{/number}","events_url":"https://api.github.com/repos/sol/hpack/events","assignees_url":"https://api.github.com/repos/sol/hpack/assignees{/user}","branches_url":"https://api.github.com/repos/sol/hpack/branches{/branch}","tags_url":"https://api.github.com/repos/sol/hpack/tags","blobs_url":"https://api.github.com/repos/sol/hpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sol/hpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sol/hpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/sol/hpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sol/hpack/statuses/{sha}","languages_url":"https://api.github.com/repos/sol/hpack/languages","stargazers_url":"https://api.github.com/repos/sol/hpack/stargazers","contributors_url":"https://api.github.com/repos/sol/hpack/contributors","subscribers_url":"https://api.github.com/repos/sol/hpack/subscribers","subscription_url":"https://api.github.com/repos/sol/hpack/subscription","commits_url":"https://api.github.com/repos/sol/hpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/sol/hpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/sol/hpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/sol/hpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/sol/hpack/contents/{+path}","compare_url":"https://api.github.com/repos/sol/hpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sol/hpack/merges","archive_url":"https://api.github.com/repos/sol/hpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sol/hpack/downloads","issues_url":"https://api.github.com/repos/sol/hpack/issues{/number}","pulls_url":"https://api.github.com/repos/sol/hpack/pulls{/number}","milestones_url":"https://api.github.com/repos/sol/hpack/milestones{/number}","notifications_url":"https://api.github.com/repos/sol/hpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sol/hpack/labels{/name}","releases_url":"https://api.github.com/repos/sol/hpack/releases{/id}","deployments_url":"https://api.github.com/repos/sol/hpack/deployments","created_at":"2014-11-19T14:51:34Z","updated_at":"2017-01-19T04:43:11Z","pushed_at":"2017-01-22T17:36:29Z","git_url":"git://github.com/sol/hpack.git","ssh_url":"git@github.com:sol/hpack.git","clone_url":"https://github.com/sol/hpack.git","svn_url":"https://github.com/sol/hpack","homepage":"","size":374,"stargazers_count":87,"watchers_count":87,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":23,"forks":26,"open_issues":23,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sol/hpack/pulls/148"},"html":{"href":"https://github.com/sol/hpack/pull/148"},"issue":{"href":"https://api.github.com/repos/sol/hpack/issues/148"},"comments":{"href":"https://api.github.com/repos/sol/hpack/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/sol/hpack/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/sol/hpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sol/hpack/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/sol/hpack/statuses/9dcc7be0201aedde3ca62d0225eb2c66e62fcfa2"}}}}
{"actor":{"display_login":"sol"}}