{"action":"created","issue":{"url":"https://api.github.com/repos/jjh42/mock/issues/68","repository_url":"https://api.github.com/repos/jjh42/mock","labels_url":"https://api.github.com/repos/jjh42/mock/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/jjh42/mock/issues/68/comments","events_url":"https://api.github.com/repos/jjh42/mock/issues/68/events","html_url":"https://github.com/jjh42/mock/pull/68","id":250403636,"number":68,"title":"Implement setup_with_mocks","user":{"login":"Olshansk","id":1892194,"avatar_url":"https://avatars1.githubusercontent.com/u/1892194?v=4","gravatar_id":"","url":"https://api.github.com/users/Olshansk","html_url":"https://github.com/Olshansk","followers_url":"https://api.github.com/users/Olshansk/followers","following_url":"https://api.github.com/users/Olshansk/following{/other_user}","gists_url":"https://api.github.com/users/Olshansk/gists{/gist_id}","starred_url":"https://api.github.com/users/Olshansk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olshansk/subscriptions","organizations_url":"https://api.github.com/users/Olshansk/orgs","repos_url":"https://api.github.com/users/Olshansk/repos","events_url":"https://api.github.com/users/Olshansk/events{/privacy}","received_events_url":"https://api.github.com/users/Olshansk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-15T18:51:49Z","updated_at":"2017-08-16T20:58:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jjh42/mock/pulls/68","html_url":"https://github.com/jjh42/mock/pull/68","diff_url":"https://github.com/jjh42/mock/pull/68.diff","patch_url":"https://github.com/jjh42/mock/pull/68.patch"},"body":"A helper macro that'll help avoid copy-pasting the same mock\r\nif it is required for all unit tests in some ExUnit.Case.\r\n\r\nFor simplicity, only add support for mocking multiple modules\r\nin setup without all the shorthand helpers when only one mock\r\nis needed.\r\n\r\nWrapper macro for `setup_all` was not implemented because maintaining\r\nthe mock state across tests is difficult if one of the tests in\r\nthe module needs custom behaviour. For example, assume 9/10 tests\r\nin some file need the same mock, but the one other test, which belongs\r\nin the same file, does not. The one specific test can override the\r\n'global' mock. This is easy to achieve using `setup` but more difficult\r\nusing `setup_all` and provides more developer friendly behaviour.\r\n\r\n- Implement setup_with_mocks with support for when context is\r\n  specified and when it is not\r\n- Unit tests\r\n- Move the logic of mocking multiple modules into a helper macro\r\n- Update the README with an explanation and an example"},"comment":{"url":"https://api.github.com/repos/jjh42/mock/issues/comments/322897231","html_url":"https://github.com/jjh42/mock/pull/68#issuecomment-322897231","issue_url":"https://api.github.com/repos/jjh42/mock/issues/68","id":322897231,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-08-16T20:58:12Z","updated_at":"2017-08-16T20:58:12Z","body":"\n[![Coverage Status](https://coveralls.io/builds/12867038/badge)](https://coveralls.io/builds/12867038)\n\nCoverage remained the same at 100.0% when pulling **ddb03f825274481a8b8f6ecbbff521edc1b98df7 on Olshansk:setup_with_mocks** into **0343d824100722660da0e813e375da63ea4e89eb on jjh42:master**.\n"}}
{"actor":{"display_login":"coveralls"}}