{"action":"closed","issue":{"url":"https://api.github.com/repos/MycroftAI/adapt/issues/7","repository_url":"https://api.github.com/repos/MycroftAI/adapt","labels_url":"https://api.github.com/repos/MycroftAI/adapt/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/MycroftAI/adapt/issues/7/comments","events_url":"https://api.github.com/repos/MycroftAI/adapt/issues/7/events","html_url":"https://github.com/MycroftAI/adapt/issues/7","id":125867664,"number":7,"title":"Adapt is not parsing unknown entities like number","user":{"login":"G10DRAS","id":14088095,"avatar_url":"https://avatars3.githubusercontent.com/u/14088095?v=3","gravatar_id":"","url":"https://api.github.com/users/G10DRAS","html_url":"https://github.com/G10DRAS","followers_url":"https://api.github.com/users/G10DRAS/followers","following_url":"https://api.github.com/users/G10DRAS/following{/other_user}","gists_url":"https://api.github.com/users/G10DRAS/gists{/gist_id}","starred_url":"https://api.github.com/users/G10DRAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G10DRAS/subscriptions","organizations_url":"https://api.github.com/users/G10DRAS/orgs","repos_url":"https://api.github.com/users/G10DRAS/repos","events_url":"https://api.github.com/users/G10DRAS/events{/privacy}","received_events_url":"https://api.github.com/users/G10DRAS/received_events","type":"User","site_admin":false},"labels":[{"id":345973922,"url":"https://api.github.com/repos/MycroftAI/adapt/labels/ready","name":"ready","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-01-11T03:38:04Z","updated_at":"2017-03-20T02:03:25Z","closed_at":"2017-03-20T02:03:25Z","body":"Take this example.\n\nHome Automation Intent Parser.\n\nAutomation Phrases used will be like below:\n\n```\n\"Mycroft Set First floor Office Temperature at Twenty\"\n\"Mycroft Switch On Ground floor Kitchen Table Light\"\n\"Mycroft Switch Off Second floor Bathroom Heater\"\n```\n\nAutomation Intent Parser:\n\n```\naction_keyword = [\"Set\", \"On\", \"Off\"] ---> Require\nfloor_keyword = [\"Ground\", \"First\", \"Second\"] ---> Require\nroom_keyword =[\"Kitchen\",\"Office\",\"Bathroom\"] ---> Require\ndevice_keyword =[\"Heater\", \"Cooler\" \"Ceiling\", \"Table\"] ---> Require\n```\n\nQ:- How Intent Parser will handle \"Temperature at Twenty\" ?\nOther two phrases (2 and 3 ) looks ok, as entities are known.\nQ:- How Automation Skill will get this number Twenty in json before setting office temperature?\n\nTwenty is not a known entity, Do we need to registered another keyword with intent parser ?\n    temperature_keyword = [\"one\", \"two\".........................\"fifty five\"] ---> Require / Optional\n\nIf we make temperature_keyword optional and Automation Intent Parser detect no Temperature Value in phrase, then it will definitely pass null to Skill in json for temperature value.\nSuppose Automation Skill put a check on Temperature value (which is null) and ask again for Temperature,\nuser replied \"set it at Twenty\",\nIn this case do we need another Temperature Intent Parser to parse Temperature Value?\n..........................................................................................\nTake another example :\n\nA Voice Calculator\n\n```\n\"Calculate Five Thousand Divide by Twenty Five\"\n```\n\nCalculator Intent Parser\n    calci_keyword=[\"Calculate\", \"Calci\"] ------> Require\n    operation_keyword=[\"Multiply\",\"Divide\",\"Plus\",\"Minus\"] ---> Require\n\nWhat about \"Five Thousand\" and \" Twenty Five\" ?\nHow Intent Parser will deal with Numbers ?\n..........................................................................................\n\nStock Exchange Intent Parser\n\n```\n\"BUY Thousand Share of APPLE Limit two hundred point five\"\n\"SELL Twenty Lot of ORACLE Market\"\n```\n\nWhat about \"Thousand\" and \" two hundred point five\" ?\nHow Intent Parser will deal with Numbers ?\n"}}
{"actor":{"display_login":"G10DRAS"}}