{"action":"created","comment":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/157064662","pull_request_review_id":83389694,"id":157064662,"diff_hunk":"@@ -0,0 +1,65 @@\n+# opentrons protocol designer makefile\n+\n+# use bash\n+SHELL := bash\n+\n+# use devDependency CLIs with $(bin)/command\n+# set NODE_ENV for a command with $(env)=environment\n+bin := node_modules/.bin\n+env := $(bin)/cross-env NODE_ENV\n+\n+# dev server port\n+port ?= 8082","path":"protocol-designer/Makefile","position":12,"original_position":12,"commit_id":"b3b34129b87d5822f2622f4dfbc0265abdd5c2d3","original_commit_id":"b3b34129b87d5822f2622f4dfbc0265abdd5c2d3","user":{"login":"mcous","id":2963448,"avatar_url":"https://avatars1.githubusercontent.com/u/2963448?v=4","gravatar_id":"","url":"https://api.github.com/users/mcous","html_url":"https://github.com/mcous","followers_url":"https://api.github.com/users/mcous/followers","following_url":"https://api.github.com/users/mcous/following{/other_user}","gists_url":"https://api.github.com/users/mcous/gists{/gist_id}","starred_url":"https://api.github.com/users/mcous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcous/subscriptions","organizations_url":"https://api.github.com/users/mcous/orgs","repos_url":"https://api.github.com/users/mcous/repos","events_url":"https://api.github.com/users/mcous/events{/privacy}","received_events_url":"https://api.github.com/users/mcous/received_events","type":"User","site_admin":false},"body":"Funnily enough, nothing is using 8080 at the moment... (app uses 8090 for some reason)","created_at":"2017-12-14T21:19:53Z","updated_at":"2017-12-14T21:21:38Z","html_url":"https://github.com/Opentrons/opentrons/pull/508#discussion_r157064662","pull_request_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/508","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/157064662"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/508#discussion_r157064662"},"pull_request":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/508"}}},"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/508","id":158257843,"html_url":"https://github.com/Opentrons/opentrons/pull/508","diff_url":"https://github.com/Opentrons/opentrons/pull/508.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/508.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/508","number":508,"state":"open","locked":false,"title":"Pd componentlib deck to lib","user":{"login":"IanLondon","id":11590381,"avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nThis is a big one, sorry! I'm putting this up as a WIP now, it needs work but I hope I can get it in soon so it doesn't drift too far.\r\n\r\nStill WIP but at this stage, you should be able to run a protocol in the App, the deck map responds when you click through the calibration process, but clicking the deckmap itself doesn't do anything.\r\n\r\nAside from taking the SVG Deck out of PD and into complib as `DeckFactory`...:\r\n* Added flow to PD and to App\r\n* Added Makefile to PD, matching complib's Makefile pretty closely\r\n* Parts of `constants.js` and `utils.js` moved into componentlib from PD -- I'm totally open to restructure!\r\n* Typing for `default-containers.json` in `interfaces/`\r\n* Importable reusable types in `types.js` (just a start for I think 1 type)\r\n\r\nStill needs:\r\n* Make sure Travis is running flow via Makefiles, and might need to refine flow setup - I just threw it in there bc types are very helpful for this kind of refactor (eg `flow-types` isn't in the Makefiles)\r\n* Spinner overlay on deck slot\r\n* Still needs actions for clicking labware -- I didn't add dispatchToProps back in LabwareItem/Deck\r\n* Tests for new components\r\n* Updated tests (and snapshots) for modified components\r\n* (!) Icon -- now just uses wifi icon\r\n* Don't hide container name overlay on hover\r\n* \"Confirmed\" slot overlay\r\n\r\nCheck List:\r\n\r\n- [ ] Are there breaking changes in the API and how are they being communicated?\r\n- [x] Who is reviewing your code? @mcous @Kadee80 \r\n","created_at":"2017-12-14T03:02:31Z","updated_at":"2017-12-14T21:21:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31ec9b5bfd303445e5ada0186163e0c0989fa250","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Kadee80","id":3430313,"avatar_url":"https://avatars1.githubusercontent.com/u/3430313?v=4","gravatar_id":"","url":"https://api.github.com/users/Kadee80","html_url":"https://github.com/Kadee80","followers_url":"https://api.github.com/users/Kadee80/followers","following_url":"https://api.github.com/users/Kadee80/following{/other_user}","gists_url":"https://api.github.com/users/Kadee80/gists{/gist_id}","starred_url":"https://api.github.com/users/Kadee80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kadee80/subscriptions","organizations_url":"https://api.github.com/users/Kadee80/orgs","repos_url":"https://api.github.com/users/Kadee80/repos","events_url":"https://api.github.com/users/Kadee80/events{/privacy}","received_events_url":"https://api.github.com/users/Kadee80/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/508/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/508/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/508/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/b3b34129b87d5822f2622f4dfbc0265abdd5c2d3","head":{"label":"Opentrons:pd_componentlib_deck-to-lib","ref":"pd_componentlib_deck-to-lib","sha":"b3b34129b87d5822f2622f4dfbc0265abdd5c2d3","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Python API for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2017-11-16T14:56:28Z","pushed_at":"2017-12-14T20:56:45Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":16304,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":26,"open_issues":50,"watchers":38,"default_branch":"v3a"}},"base":{"label":"Opentrons:v3a","ref":"v3a","sha":"b683d1244532d137c84fa3ec23ce4dcef8395754","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Python API for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2017-11-16T14:56:28Z","pushed_at":"2017-12-14T20:56:45Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":16304,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":26,"open_issues":50,"watchers":38,"default_branch":"v3a"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/508"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/508"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/508"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/508/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/508/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/508/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/b3b34129b87d5822f2622f4dfbc0265abdd5c2d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcous"}}