{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3398","repository_url":"https://api.github.com/repos/ipfs/go-ipfs","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3398/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3398/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3398/events","html_url":"https://github.com/ipfs/go-ipfs/issues/3398","id":190454401,"number":3398,"title":"Bitswap wantlist consistency","user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars0.githubusercontent.com/u/1243164?v=4","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"labels":[{"id":172465030,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/bitswap","name":"bitswap","color":"207de5","default":false},{"id":109732110,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/bug","name":"bug","color":"fc2929","default":true},{"id":247506032,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/discussion","name":"discussion","color":"d4c5f9","default":false},{"id":129070658,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-11-19T00:37:11Z","updated_at":"2017-09-02T22:59:33Z","closed_at":"2017-09-02T22:59:33Z","author_association":"OWNER","body":"I believe we have protocol bug in bitswap related to keeping wantlists in sync:\r\n\r\n- Peer A and B are connected to eachother and are sending and receiving blocks from eachother.\r\n- Peer B restarts their daemon quickly, resetting their knowledge of Peer A's wantlist.\r\n- Peer A receives the new connection from B before they realize the initial connection has dropped\r\n- Peer A was sending a wantlist update to peer B during their restart, this send fails, but simply try to open a new stream to the peer, since we didnt have a 'full disconnect'.\r\n- Peer A assumes that Peer B still has all previous knowledge of their wantlist and does not send a full update, resulting in a hang, as Peer B will not send any blocks to A that are on the missing wantlist.\r\n\r\nMy current proposal to fixing this issue is to record the exact connection used for the last successful wantlist update, and if upon a subsequent send, we are using a different connection, send a full update."},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/326773801","html_url":"https://github.com/ipfs/go-ipfs/issues/3398#issuecomment-326773801","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3398","id":326773801,"user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars0.githubusercontent.com/u/1243164?v=4","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"created_at":"2017-09-02T22:59:33Z","updated_at":"2017-09-02T22:59:33Z","author_association":"OWNER","body":"This issue has been resolved,  The 'full' flag wasnt being sent on outgoing bitswap wantlist messages. meaning we never actually reset wantlists. "}}
{"actor":{"display_login":"whyrusleeping"}}