{"action":"created","comment":{"url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/comments/128014954","pull_request_review_id":50654613,"id":128014954,"diff_hunk":"@@ -32,6 +32,7 @@\n import static org.mockito.Mockito.mock;\n import ru.hh.nab.async.Callbacks;\n import ru.hh.nab.async.GuicyAsyncExecutor;\n+import ru.hh.nab.hibernate.PostCommitHooks;","path":"example-app/src/test/java/ru/hh/nab/example/GuicyAsyncExecutorTest.java","position":null,"original_position":4,"commit_id":"c76b4543a1692bdf8b4645ffe4b41e25adec1f08","original_commit_id":"c8b2932cf9c536d075048ac77c8f8b1e53bcb08f","user":{"login":"kullfar","id":736714,"avatar_url":"https://avatars3.githubusercontent.com/u/736714?v=4","gravatar_id":"","url":"https://api.github.com/users/kullfar","html_url":"https://github.com/kullfar","followers_url":"https://api.github.com/users/kullfar/followers","following_url":"https://api.github.com/users/kullfar/following{/other_user}","gists_url":"https://api.github.com/users/kullfar/gists{/gist_id}","starred_url":"https://api.github.com/users/kullfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kullfar/subscriptions","organizations_url":"https://api.github.com/users/kullfar/orgs","repos_url":"https://api.github.com/users/kullfar/repos","events_url":"https://api.github.com/users/kullfar/events{/privacy}","received_events_url":"https://api.github.com/users/kullfar/received_events","type":"User","site_admin":false},"body":"в этом коммите всё, что ещё можно сделать ДО непосредственно выделения нового модуля, чтобы след. коммит был поменьше","created_at":"2017-07-18T15:44:23Z","updated_at":"2017-07-18T15:44:23Z","html_url":"https://github.com/hhru/nuts-and-bolts/pull/65#discussion_r128014954","pull_request_url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/comments/128014954"},"html":{"href":"https://github.com/hhru/nuts-and-bolts/pull/65#discussion_r128014954"},"pull_request":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65","id":131074389,"html_url":"https://github.com/hhru/nuts-and-bolts/pull/65","diff_url":"https://github.com/hhru/nuts-and-bolts/pull/65.diff","patch_url":"https://github.com/hhru/nuts-and-bolts/pull/65.patch","issue_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/65","number":65,"state":"open","locked":false,"title":"HH-69833 разделить nab и hiber(вся база)","user":{"login":"kullfar","id":736714,"avatar_url":"https://avatars3.githubusercontent.com/u/736714?v=4","gravatar_id":"","url":"https://api.github.com/users/kullfar","html_url":"https://github.com/kullfar","followers_url":"https://api.github.com/users/kullfar/followers","following_url":"https://api.github.com/users/kullfar/following{/other_user}","gists_url":"https://api.github.com/users/kullfar/gists{/gist_id}","starred_url":"https://api.github.com/users/kullfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kullfar/subscriptions","organizations_url":"https://api.github.com/users/kullfar/orgs","repos_url":"https://api.github.com/users/kullfar/repos","events_url":"https://api.github.com/users/kullfar/events{/privacy}","received_events_url":"https://api.github.com/users/kullfar/received_events","type":"User","site_admin":false},"body":"https://jira.hh.ru/browse/HH-69833\r\nвыделить в отдельный мавен модуль всё, что относится к работе с базой\r\n\r\n@Transactional\r\nмониторинг\r\npostgres jdbc\r\nc3p0\r\nудалить dbcp-common\r\nобщее с набом - только guice\r\n\r\nps.общим с набом остался еще hh-metrics (для statsD функциональности в набе и он используется в хибере для мониторинга работы с базой) и cglib(+asm) (нужен хиберу и нужен набу для ru.hh.util.Proxies как минимум, фримаркерМодель через него в набе сделана)\r\n\r\nсмотреть рекомендую покоммитово, постарался \"декомпозировать\" изменения","created_at":"2017-07-18T12:28:29Z","updated_at":"2017-07-18T15:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff1f5c880d4593f30cc0c91b5a2de3e24b712a87","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65/commits","review_comments_url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65/comments","review_comment_url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/65/comments","statuses_url":"https://api.github.com/repos/hhru/nuts-and-bolts/statuses/c76b4543a1692bdf8b4645ffe4b41e25adec1f08","head":{"label":"hhru:HH-69833","ref":"HH-69833","sha":"c76b4543a1692bdf8b4645ffe4b41e25adec1f08","user":{"login":"hhru","id":152753,"avatar_url":"https://avatars2.githubusercontent.com/u/152753?v=4","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"repo":{"id":864122,"name":"nuts-and-bolts","full_name":"hhru/nuts-and-bolts","owner":{"login":"hhru","id":152753,"avatar_url":"https://avatars2.githubusercontent.com/u/152753?v=4","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hhru/nuts-and-bolts","description":"Maintainers: Иванов Антон, web application framework for HeadHunter  internal services","fork":false,"url":"https://api.github.com/repos/hhru/nuts-and-bolts","forks_url":"https://api.github.com/repos/hhru/nuts-and-bolts/forks","keys_url":"https://api.github.com/repos/hhru/nuts-and-bolts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhru/nuts-and-bolts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhru/nuts-and-bolts/teams","hooks_url":"https://api.github.com/repos/hhru/nuts-and-bolts/hooks","issue_events_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/events{/number}","events_url":"https://api.github.com/repos/hhru/nuts-and-bolts/events","assignees_url":"https://api.github.com/repos/hhru/nuts-and-bolts/assignees{/user}","branches_url":"https://api.github.com/repos/hhru/nuts-and-bolts/branches{/branch}","tags_url":"https://api.github.com/repos/hhru/nuts-and-bolts/tags","blobs_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhru/nuts-and-bolts/statuses/{sha}","languages_url":"https://api.github.com/repos/hhru/nuts-and-bolts/languages","stargazers_url":"https://api.github.com/repos/hhru/nuts-and-bolts/stargazers","contributors_url":"https://api.github.com/repos/hhru/nuts-and-bolts/contributors","subscribers_url":"https://api.github.com/repos/hhru/nuts-and-bolts/subscribers","subscription_url":"https://api.github.com/repos/hhru/nuts-and-bolts/subscription","commits_url":"https://api.github.com/repos/hhru/nuts-and-bolts/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhru/nuts-and-bolts/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhru/nuts-and-bolts/contents/{+path}","compare_url":"https://api.github.com/repos/hhru/nuts-and-bolts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhru/nuts-and-bolts/merges","archive_url":"https://api.github.com/repos/hhru/nuts-and-bolts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhru/nuts-and-bolts/downloads","issues_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues{/number}","pulls_url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls{/number}","milestones_url":"https://api.github.com/repos/hhru/nuts-and-bolts/milestones{/number}","notifications_url":"https://api.github.com/repos/hhru/nuts-and-bolts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhru/nuts-and-bolts/labels{/name}","releases_url":"https://api.github.com/repos/hhru/nuts-and-bolts/releases{/id}","deployments_url":"https://api.github.com/repos/hhru/nuts-and-bolts/deployments","created_at":"2010-08-26T14:05:41Z","updated_at":"2017-05-30T12:02:06Z","pushed_at":"2017-07-18T15:14:55Z","git_url":"git://github.com/hhru/nuts-and-bolts.git","ssh_url":"git@github.com:hhru/nuts-and-bolts.git","clone_url":"https://github.com/hhru/nuts-and-bolts.git","svn_url":"https://github.com/hhru/nuts-and-bolts","homepage":"","size":698,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"hhru:master","ref":"master","sha":"05d75f4d4536b19ce268c8b23c6a4568ffc48e4c","user":{"login":"hhru","id":152753,"avatar_url":"https://avatars2.githubusercontent.com/u/152753?v=4","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"repo":{"id":864122,"name":"nuts-and-bolts","full_name":"hhru/nuts-and-bolts","owner":{"login":"hhru","id":152753,"avatar_url":"https://avatars2.githubusercontent.com/u/152753?v=4","gravatar_id":"","url":"https://api.github.com/users/hhru","html_url":"https://github.com/hhru","followers_url":"https://api.github.com/users/hhru/followers","following_url":"https://api.github.com/users/hhru/following{/other_user}","gists_url":"https://api.github.com/users/hhru/gists{/gist_id}","starred_url":"https://api.github.com/users/hhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhru/subscriptions","organizations_url":"https://api.github.com/users/hhru/orgs","repos_url":"https://api.github.com/users/hhru/repos","events_url":"https://api.github.com/users/hhru/events{/privacy}","received_events_url":"https://api.github.com/users/hhru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hhru/nuts-and-bolts","description":"Maintainers: Иванов Антон, web application framework for HeadHunter  internal services","fork":false,"url":"https://api.github.com/repos/hhru/nuts-and-bolts","forks_url":"https://api.github.com/repos/hhru/nuts-and-bolts/forks","keys_url":"https://api.github.com/repos/hhru/nuts-and-bolts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhru/nuts-and-bolts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhru/nuts-and-bolts/teams","hooks_url":"https://api.github.com/repos/hhru/nuts-and-bolts/hooks","issue_events_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/events{/number}","events_url":"https://api.github.com/repos/hhru/nuts-and-bolts/events","assignees_url":"https://api.github.com/repos/hhru/nuts-and-bolts/assignees{/user}","branches_url":"https://api.github.com/repos/hhru/nuts-and-bolts/branches{/branch}","tags_url":"https://api.github.com/repos/hhru/nuts-and-bolts/tags","blobs_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhru/nuts-and-bolts/statuses/{sha}","languages_url":"https://api.github.com/repos/hhru/nuts-and-bolts/languages","stargazers_url":"https://api.github.com/repos/hhru/nuts-and-bolts/stargazers","contributors_url":"https://api.github.com/repos/hhru/nuts-and-bolts/contributors","subscribers_url":"https://api.github.com/repos/hhru/nuts-and-bolts/subscribers","subscription_url":"https://api.github.com/repos/hhru/nuts-and-bolts/subscription","commits_url":"https://api.github.com/repos/hhru/nuts-and-bolts/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhru/nuts-and-bolts/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhru/nuts-and-bolts/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhru/nuts-and-bolts/contents/{+path}","compare_url":"https://api.github.com/repos/hhru/nuts-and-bolts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhru/nuts-and-bolts/merges","archive_url":"https://api.github.com/repos/hhru/nuts-and-bolts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhru/nuts-and-bolts/downloads","issues_url":"https://api.github.com/repos/hhru/nuts-and-bolts/issues{/number}","pulls_url":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls{/number}","milestones_url":"https://api.github.com/repos/hhru/nuts-and-bolts/milestones{/number}","notifications_url":"https://api.github.com/repos/hhru/nuts-and-bolts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhru/nuts-and-bolts/labels{/name}","releases_url":"https://api.github.com/repos/hhru/nuts-and-bolts/releases{/id}","deployments_url":"https://api.github.com/repos/hhru/nuts-and-bolts/deployments","created_at":"2010-08-26T14:05:41Z","updated_at":"2017-05-30T12:02:06Z","pushed_at":"2017-07-18T15:14:55Z","git_url":"git://github.com/hhru/nuts-and-bolts.git","ssh_url":"git@github.com:hhru/nuts-and-bolts.git","clone_url":"https://github.com/hhru/nuts-and-bolts.git","svn_url":"https://github.com/hhru/nuts-and-bolts","homepage":"","size":698,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65"},"html":{"href":"https://github.com/hhru/nuts-and-bolts/pull/65"},"issue":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/65"},"comments":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/hhru/nuts-and-bolts/statuses/c76b4543a1692bdf8b4645ffe4b41e25adec1f08"}}}}
{"actor":{"display_login":"kullfar"}}