{"action":"closed","issue":{"url":"https://api.github.com/repos/mpreiner/bugzilla_migration_test/issues/521","repository_url":"https://api.github.com/repos/mpreiner/bugzilla_migration_test","labels_url":"https://api.github.com/repos/mpreiner/bugzilla_migration_test/issues/521/labels{/name}","comments_url":"https://api.github.com/repos/mpreiner/bugzilla_migration_test/issues/521/comments","events_url":"https://api.github.com/repos/mpreiner/bugzilla_migration_test/issues/521/events","html_url":"https://github.com/mpreiner/bugzilla_migration_test/issues/521","id":251101228,"number":521,"title":"asserts don't get compiled out (Bugzilla #31)","user":{"login":"mpreiner","id":4653598,"avatar_url":"https://avatars0.githubusercontent.com/u/4653598?v=4","gravatar_id":"","url":"https://api.github.com/users/mpreiner","html_url":"https://github.com/mpreiner","followers_url":"https://api.github.com/users/mpreiner/followers","following_url":"https://api.github.com/users/mpreiner/following{/other_user}","gists_url":"https://api.github.com/users/mpreiner/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreiner/subscriptions","organizations_url":"https://api.github.com/users/mpreiner/orgs","repos_url":"https://api.github.com/users/mpreiner/repos","events_url":"https://api.github.com/users/mpreiner/events{/privacy}","received_events_url":"https://api.github.com/users/mpreiner/received_events","type":"User","site_admin":false},"labels":[{"id":669558995,"url":"https://api.github.com/repos/mpreiner/bugzilla_migration_test/labels/major","name":"major","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-17T23:36:28Z","updated_at":"2017-08-17T23:36:28Z","closed_at":"2017-08-17T23:36:28Z","body":"**Imported from Bugzilla**\nReporter: *Dejan Jovanovic*\nStatus: *RESOLVED*\nSeverity: *major*\nAssigned to: *Morgan Deters*\nComponent: *Build system (configure, make, make install)*\nMilestone: *---*\nVersion: *master*\nPlatform: *PC*\nOS: *Linux*\n\nOn 2010-02-16 14:38:33 -0800, Dejan Jovanovic wrote:\n> The Assert.h structure is not conforming to what we agreed at in the meetings. If we are using AlwaysAsserts in code, these should get compiled out in the competition build.\n\nOn 2010-02-17 14:10:58 -0800, Morgan Deters wrote:\n> After a conversation with Dejan 2/17/2010:\n> \n> AlwaysAssert() should always assert, regardless of build, even in competition.  Accordingly, it should test only cheap\\-to\\-test and highly\\-important things.\n> \n> In the case of the parser, another kind of check should be performed on input (rather than an assertion): (1) it doesn't make much sense for bad input to cause an assertion failure (rather than a ParseException or whatever), and (2) it would be possible to provide an \\-\\-assume\\-input\\-well\\-formed flag (or similar) to disable a check if it was thought to be expensive.  (And perhaps the check is compiled out in \"competition\" builds).\n\n"}}
{"actor":{"display_login":"mpreiner"}}