{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/138852946","pull_request_review_id":62703097,"id":138852946,"diff_hunk":"@@ -348,6 +348,10 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,\n \t\tbreak;\n \n \tcase ODP_POOL_PACKET:\n+\t\tif (params->pkt.min_headroom > CONFIG_PACKET_HEADROOM) {\n+\t\t\tODP_ERR(\"Packet headroom size not supported.\");\n+\t\t\treturn ODP_POOL_INVALID;\n+\t\t}\n \t\theadroom    = CONFIG_PACKET_HEADROOM;","path":"platform/linux-generic/odp_pool.c","position":8,"original_position":8,"commit_id":"da2c9afec88b499c1d732e2ae90b8665f4f330fd","original_commit_id":"0d30915e1c54f36b3780aa64c7c30844613699e6","user":{"login":"psavol","id":9589374,"avatar_url":"https://avatars0.githubusercontent.com/u/9589374?v=4","gravatar_id":"","url":"https://api.github.com/users/psavol","html_url":"https://github.com/psavol","followers_url":"https://api.github.com/users/psavol/followers","following_url":"https://api.github.com/users/psavol/following{/other_user}","gists_url":"https://api.github.com/users/psavol/gists{/gist_id}","starred_url":"https://api.github.com/users/psavol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psavol/subscriptions","organizations_url":"https://api.github.com/users/psavol/orgs","repos_url":"https://api.github.com/users/psavol/repos","events_url":"https://api.github.com/users/psavol/events{/privacy}","received_events_url":"https://api.github.com/users/psavol/received_events","type":"User","site_admin":false},"body":"Bala's implementation is correct. Currently, it's much more simpler to always use the default headroom. I'd rather optimize odp-linux for simplicity and performance than for saving memory. When memory usage is a worry, user can rebuild with smaller CONFIG_PACKET_HEADROOM. Also due to data align / cacheline round ups there will be always some headroom - so the potential memory saving in question would be 1 or 2 cachelines per packet, which is not much.\r\n","created_at":"2017-09-14T10:19:29Z","updated_at":"2017-09-14T10:19:29Z","html_url":"https://github.com/Linaro/odp/pull/152#discussion_r138852946","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/152","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/138852946"},"html":{"href":"https://github.com/Linaro/odp/pull/152#discussion_r138852946"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/152"}},"in_reply_to_id":137374488},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/152","id":138196555,"html_url":"https://github.com/Linaro/odp/pull/152","diff_url":"https://github.com/Linaro/odp/pull/152.diff","patch_url":"https://github.com/Linaro/odp/pull/152.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/152","number":152,"state":"open","locked":false,"title":"[PATCH API-NEXT v7] api: pool: add min and max headroom in pool capability","user":{"login":"bala-manoharan","id":25454254,"avatar_url":"https://avatars0.githubusercontent.com/u/25454254?v=4","gravatar_id":"","url":"https://api.github.com/users/bala-manoharan","html_url":"https://github.com/bala-manoharan","followers_url":"https://api.github.com/users/bala-manoharan/followers","following_url":"https://api.github.com/users/bala-manoharan/following{/other_user}","gists_url":"https://api.github.com/users/bala-manoharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bala-manoharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bala-manoharan/subscriptions","organizations_url":"https://api.github.com/users/bala-manoharan/orgs","repos_url":"https://api.github.com/users/bala-manoharan/repos","events_url":"https://api.github.com/users/bala-manoharan/events{/privacy}","received_events_url":"https://api.github.com/users/bala-manoharan/received_events","type":"User","site_admin":false},"body":"V7: This patch is now rebased with updates in api-next.\r\n@psavol could you review and provide feedback to the API definitions","created_at":"2017-08-29T14:29:03Z","updated_at":"2017-09-14T10:19:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6a181de1ce2c8a062ab6738c54fe61d88202434","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/152/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/152/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/152/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/da2c9afec88b499c1d732e2ae90b8665f4f330fd","head":{"label":"bala-manoharan:pool_headroom","ref":"pool_headroom","sha":"da2c9afec88b499c1d732e2ae90b8665f4f330fd","user":{"login":"bala-manoharan","id":25454254,"avatar_url":"https://avatars0.githubusercontent.com/u/25454254?v=4","gravatar_id":"","url":"https://api.github.com/users/bala-manoharan","html_url":"https://github.com/bala-manoharan","followers_url":"https://api.github.com/users/bala-manoharan/followers","following_url":"https://api.github.com/users/bala-manoharan/following{/other_user}","gists_url":"https://api.github.com/users/bala-manoharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bala-manoharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bala-manoharan/subscriptions","organizations_url":"https://api.github.com/users/bala-manoharan/orgs","repos_url":"https://api.github.com/users/bala-manoharan/repos","events_url":"https://api.github.com/users/bala-manoharan/events{/privacy}","received_events_url":"https://api.github.com/users/bala-manoharan/received_events","type":"User","site_admin":false},"repo":{"id":90684593,"name":"odp","full_name":"bala-manoharan/odp","owner":{"login":"bala-manoharan","id":25454254,"avatar_url":"https://avatars0.githubusercontent.com/u/25454254?v=4","gravatar_id":"","url":"https://api.github.com/users/bala-manoharan","html_url":"https://github.com/bala-manoharan","followers_url":"https://api.github.com/users/bala-manoharan/followers","following_url":"https://api.github.com/users/bala-manoharan/following{/other_user}","gists_url":"https://api.github.com/users/bala-manoharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bala-manoharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bala-manoharan/subscriptions","organizations_url":"https://api.github.com/users/bala-manoharan/orgs","repos_url":"https://api.github.com/users/bala-manoharan/repos","events_url":"https://api.github.com/users/bala-manoharan/events{/privacy}","received_events_url":"https://api.github.com/users/bala-manoharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bala-manoharan/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/bala-manoharan/odp","forks_url":"https://api.github.com/repos/bala-manoharan/odp/forks","keys_url":"https://api.github.com/repos/bala-manoharan/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bala-manoharan/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bala-manoharan/odp/teams","hooks_url":"https://api.github.com/repos/bala-manoharan/odp/hooks","issue_events_url":"https://api.github.com/repos/bala-manoharan/odp/issues/events{/number}","events_url":"https://api.github.com/repos/bala-manoharan/odp/events","assignees_url":"https://api.github.com/repos/bala-manoharan/odp/assignees{/user}","branches_url":"https://api.github.com/repos/bala-manoharan/odp/branches{/branch}","tags_url":"https://api.github.com/repos/bala-manoharan/odp/tags","blobs_url":"https://api.github.com/repos/bala-manoharan/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bala-manoharan/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bala-manoharan/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bala-manoharan/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bala-manoharan/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/bala-manoharan/odp/languages","stargazers_url":"https://api.github.com/repos/bala-manoharan/odp/stargazers","contributors_url":"https://api.github.com/repos/bala-manoharan/odp/contributors","subscribers_url":"https://api.github.com/repos/bala-manoharan/odp/subscribers","subscription_url":"https://api.github.com/repos/bala-manoharan/odp/subscription","commits_url":"https://api.github.com/repos/bala-manoharan/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bala-manoharan/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bala-manoharan/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bala-manoharan/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bala-manoharan/odp/contents/{+path}","compare_url":"https://api.github.com/repos/bala-manoharan/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bala-manoharan/odp/merges","archive_url":"https://api.github.com/repos/bala-manoharan/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bala-manoharan/odp/downloads","issues_url":"https://api.github.com/repos/bala-manoharan/odp/issues{/number}","pulls_url":"https://api.github.com/repos/bala-manoharan/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/bala-manoharan/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/bala-manoharan/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bala-manoharan/odp/labels{/name}","releases_url":"https://api.github.com/repos/bala-manoharan/odp/releases{/id}","deployments_url":"https://api.github.com/repos/bala-manoharan/odp/deployments","created_at":"2017-05-09T00:27:18Z","updated_at":"2017-05-09T00:27:21Z","pushed_at":"2017-09-14T08:06:16Z","git_url":"git://github.com/bala-manoharan/odp.git","ssh_url":"git@github.com:bala-manoharan/odp.git","clone_url":"https://github.com/bala-manoharan/odp.git","svn_url":"https://github.com/bala-manoharan/odp","homepage":"http://www.opendataplane.org/","size":7676,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:api-next","ref":"api-next","sha":"6b6253c30f88c80bf632436ff06c1b000860a2f1","user":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2017-09-06T20:07:10Z","pushed_at":"2017-09-14T09:09:29Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":8615,"stargazers_count":22,"watchers_count":22,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":24,"forks":31,"open_issues":24,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/152"},"html":{"href":"https://github.com/Linaro/odp/pull/152"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/152"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/da2c9afec88b499c1d732e2ae90b8665f4f330fd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"psavol"}}