{"action":"closed","number":588,"pull_request":{"url":"https://api.github.com/repos/coralproject/talk/pulls/588","id":120734571,"html_url":"https://github.com/coralproject/talk/pull/588","diff_url":"https://github.com/coralproject/talk/pull/588.diff","patch_url":"https://github.com/coralproject/talk/pull/588.patch","issue_url":"https://api.github.com/repos/coralproject/talk/issues/588","number":588,"state":"closed","locked":false,"title":"Fix for FB login.","user":{"login":"okbel","id":1401559,"avatar_url":"https://avatars1.githubusercontent.com/u/1401559?v=3","gravatar_id":"","url":"https://api.github.com/users/okbel","html_url":"https://github.com/okbel","followers_url":"https://api.github.com/users/okbel/followers","following_url":"https://api.github.com/users/okbel/following{/other_user}","gists_url":"https://api.github.com/users/okbel/gists{/gist_id}","starred_url":"https://api.github.com/users/okbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okbel/subscriptions","organizations_url":"https://api.github.com/users/okbel/orgs","repos_url":"https://api.github.com/users/okbel/repos","events_url":"https://api.github.com/users/okbel/events{/privacy}","received_events_url":"https://api.github.com/users/okbel/received_events","type":"User","site_admin":false},"body":"## What does this PR do?\r\n- Adds fix for FB login. \r\n\r\n## The Problem\r\nThe problem was that we were passing an object as a localStorage value. Also, I added the listeners for auth key localStorage changes.\r\n\r\n<img width=\"324\" alt=\"screen shot 2017-05-15 at 11 14 14 pm\" src=\"https://cloud.githubusercontent.com/assets/1401559/26087776/36fec5f0-39c9-11e7-896c-fa46817aab80.png\">\r\n\r\n","created_at":"2017-05-16T02:50:36Z","updated_at":"2017-05-16T02:57:31Z","closed_at":"2017-05-16T02:57:31Z","merged_at":"2017-05-16T02:57:31Z","merge_commit_sha":"95e770aff8a1b5fb2e9a891e5799f398bcedac5a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wyattjoh","id":633002,"avatar_url":"https://avatars1.githubusercontent.com/u/633002?v=3","gravatar_id":"","url":"https://api.github.com/users/wyattjoh","html_url":"https://github.com/wyattjoh","followers_url":"https://api.github.com/users/wyattjoh/followers","following_url":"https://api.github.com/users/wyattjoh/following{/other_user}","gists_url":"https://api.github.com/users/wyattjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/wyattjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyattjoh/subscriptions","organizations_url":"https://api.github.com/users/wyattjoh/orgs","repos_url":"https://api.github.com/users/wyattjoh/repos","events_url":"https://api.github.com/users/wyattjoh/events{/privacy}","received_events_url":"https://api.github.com/users/wyattjoh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coralproject/talk/pulls/588/commits","review_comments_url":"https://api.github.com/repos/coralproject/talk/pulls/588/comments","review_comment_url":"https://api.github.com/repos/coralproject/talk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coralproject/talk/issues/588/comments","statuses_url":"https://api.github.com/repos/coralproject/talk/statuses/d3252b8c87d092f1d124fe31e7b13d1b17cebaaa","head":{"label":"coralproject:fix","ref":"fix","sha":"d3252b8c87d092f1d124fe31e7b13d1b17cebaaa","user":{"login":"coralproject","id":9255912,"avatar_url":"https://avatars1.githubusercontent.com/u/9255912?v=3","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"repo":{"id":72454242,"name":"talk","full_name":"coralproject/talk","owner":{"login":"coralproject","id":9255912,"avatar_url":"https://avatars1.githubusercontent.com/u/9255912?v=3","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coralproject/talk","description":"A better commenting experience from Mozilla, The New York Times, and the Washington Post.","fork":false,"url":"https://api.github.com/repos/coralproject/talk","forks_url":"https://api.github.com/repos/coralproject/talk/forks","keys_url":"https://api.github.com/repos/coralproject/talk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coralproject/talk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coralproject/talk/teams","hooks_url":"https://api.github.com/repos/coralproject/talk/hooks","issue_events_url":"https://api.github.com/repos/coralproject/talk/issues/events{/number}","events_url":"https://api.github.com/repos/coralproject/talk/events","assignees_url":"https://api.github.com/repos/coralproject/talk/assignees{/user}","branches_url":"https://api.github.com/repos/coralproject/talk/branches{/branch}","tags_url":"https://api.github.com/repos/coralproject/talk/tags","blobs_url":"https://api.github.com/repos/coralproject/talk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coralproject/talk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coralproject/talk/git/refs{/sha}","trees_url":"https://api.github.com/repos/coralproject/talk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coralproject/talk/statuses/{sha}","languages_url":"https://api.github.com/repos/coralproject/talk/languages","stargazers_url":"https://api.github.com/repos/coralproject/talk/stargazers","contributors_url":"https://api.github.com/repos/coralproject/talk/contributors","subscribers_url":"https://api.github.com/repos/coralproject/talk/subscribers","subscription_url":"https://api.github.com/repos/coralproject/talk/subscription","commits_url":"https://api.github.com/repos/coralproject/talk/commits{/sha}","git_commits_url":"https://api.github.com/repos/coralproject/talk/git/commits{/sha}","comments_url":"https://api.github.com/repos/coralproject/talk/comments{/number}","issue_comment_url":"https://api.github.com/repos/coralproject/talk/issues/comments{/number}","contents_url":"https://api.github.com/repos/coralproject/talk/contents/{+path}","compare_url":"https://api.github.com/repos/coralproject/talk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coralproject/talk/merges","archive_url":"https://api.github.com/repos/coralproject/talk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coralproject/talk/downloads","issues_url":"https://api.github.com/repos/coralproject/talk/issues{/number}","pulls_url":"https://api.github.com/repos/coralproject/talk/pulls{/number}","milestones_url":"https://api.github.com/repos/coralproject/talk/milestones{/number}","notifications_url":"https://api.github.com/repos/coralproject/talk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coralproject/talk/labels{/name}","releases_url":"https://api.github.com/repos/coralproject/talk/releases{/id}","deployments_url":"https://api.github.com/repos/coralproject/talk/deployments","created_at":"2016-10-31T16:14:05Z","updated_at":"2017-05-09T13:43:54Z","pushed_at":"2017-05-16T02:57:31Z","git_url":"git://github.com/coralproject/talk.git","ssh_url":"git@github.com:coralproject/talk.git","clone_url":"https://github.com/coralproject/talk.git","svn_url":"https://github.com/coralproject/talk","homepage":"https://coralproject.net/","size":5474,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":63,"default_branch":"master"}},"base":{"label":"coralproject:master","ref":"master","sha":"297dee6da84f7fd1331518b7ee2ff7d8bbcb66da","user":{"login":"coralproject","id":9255912,"avatar_url":"https://avatars1.githubusercontent.com/u/9255912?v=3","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"repo":{"id":72454242,"name":"talk","full_name":"coralproject/talk","owner":{"login":"coralproject","id":9255912,"avatar_url":"https://avatars1.githubusercontent.com/u/9255912?v=3","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coralproject/talk","description":"A better commenting experience from Mozilla, The New York Times, and the Washington Post.","fork":false,"url":"https://api.github.com/repos/coralproject/talk","forks_url":"https://api.github.com/repos/coralproject/talk/forks","keys_url":"https://api.github.com/repos/coralproject/talk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coralproject/talk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coralproject/talk/teams","hooks_url":"https://api.github.com/repos/coralproject/talk/hooks","issue_events_url":"https://api.github.com/repos/coralproject/talk/issues/events{/number}","events_url":"https://api.github.com/repos/coralproject/talk/events","assignees_url":"https://api.github.com/repos/coralproject/talk/assignees{/user}","branches_url":"https://api.github.com/repos/coralproject/talk/branches{/branch}","tags_url":"https://api.github.com/repos/coralproject/talk/tags","blobs_url":"https://api.github.com/repos/coralproject/talk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coralproject/talk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coralproject/talk/git/refs{/sha}","trees_url":"https://api.github.com/repos/coralproject/talk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coralproject/talk/statuses/{sha}","languages_url":"https://api.github.com/repos/coralproject/talk/languages","stargazers_url":"https://api.github.com/repos/coralproject/talk/stargazers","contributors_url":"https://api.github.com/repos/coralproject/talk/contributors","subscribers_url":"https://api.github.com/repos/coralproject/talk/subscribers","subscription_url":"https://api.github.com/repos/coralproject/talk/subscription","commits_url":"https://api.github.com/repos/coralproject/talk/commits{/sha}","git_commits_url":"https://api.github.com/repos/coralproject/talk/git/commits{/sha}","comments_url":"https://api.github.com/repos/coralproject/talk/comments{/number}","issue_comment_url":"https://api.github.com/repos/coralproject/talk/issues/comments{/number}","contents_url":"https://api.github.com/repos/coralproject/talk/contents/{+path}","compare_url":"https://api.github.com/repos/coralproject/talk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coralproject/talk/merges","archive_url":"https://api.github.com/repos/coralproject/talk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coralproject/talk/downloads","issues_url":"https://api.github.com/repos/coralproject/talk/issues{/number}","pulls_url":"https://api.github.com/repos/coralproject/talk/pulls{/number}","milestones_url":"https://api.github.com/repos/coralproject/talk/milestones{/number}","notifications_url":"https://api.github.com/repos/coralproject/talk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coralproject/talk/labels{/name}","releases_url":"https://api.github.com/repos/coralproject/talk/releases{/id}","deployments_url":"https://api.github.com/repos/coralproject/talk/deployments","created_at":"2016-10-31T16:14:05Z","updated_at":"2017-05-09T13:43:54Z","pushed_at":"2017-05-16T02:57:31Z","git_url":"git://github.com/coralproject/talk.git","ssh_url":"git@github.com:coralproject/talk.git","clone_url":"https://github.com/coralproject/talk.git","svn_url":"https://github.com/coralproject/talk","homepage":"https://coralproject.net/","size":5474,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coralproject/talk/pulls/588"},"html":{"href":"https://github.com/coralproject/talk/pull/588"},"issue":{"href":"https://api.github.com/repos/coralproject/talk/issues/588"},"comments":{"href":"https://api.github.com/repos/coralproject/talk/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/coralproject/talk/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/coralproject/talk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coralproject/talk/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/coralproject/talk/statuses/d3252b8c87d092f1d124fe31e7b13d1b17cebaaa"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kgardnr","id":1077300,"avatar_url":"https://avatars1.githubusercontent.com/u/1077300?v=3","gravatar_id":"","url":"https://api.github.com/users/kgardnr","html_url":"https://github.com/kgardnr","followers_url":"https://api.github.com/users/kgardnr/followers","following_url":"https://api.github.com/users/kgardnr/following{/other_user}","gists_url":"https://api.github.com/users/kgardnr/gists{/gist_id}","starred_url":"https://api.github.com/users/kgardnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgardnr/subscriptions","organizations_url":"https://api.github.com/users/kgardnr/orgs","repos_url":"https://api.github.com/users/kgardnr/repos","events_url":"https://api.github.com/users/kgardnr/events{/privacy}","received_events_url":"https://api.github.com/users/kgardnr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":53,"deletions":26,"changed_files":4}}
{"actor":{"display_login":"kgardnr"}}