{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/116378216","pull_request_review_id":37997534,"id":116378216,"diff_hunk":"@@ -328,25 +326,25 @@ bool CBoot::SetupWiiMemory(u64 ios_title_id)\n // Wii Bootstrap 2 HLE:\n // copy the apploader to 0x81200000\n // execute the apploader\n-bool CBoot::EmulatedBS2_Wii()\n+bool CBoot::EmulatedBS2_Wii(const DiscIO::IVolume* volume)","path":"Source/Core/Core/Boot/Boot_BS2Emu.cpp","position":97,"original_position":97,"commit_id":"a082da7c307ad927ee7887f046608dbdcf088e69","original_commit_id":"0a76952a0c1d7519c6db3676f7b91a9e01364676","user":{"login":"leoetlino","id":4209061,"avatar_url":"https://avatars1.githubusercontent.com/u/4209061?v=3","gravatar_id":"","url":"https://api.github.com/users/leoetlino","html_url":"https://github.com/leoetlino","followers_url":"https://api.github.com/users/leoetlino/followers","following_url":"https://api.github.com/users/leoetlino/following{/other_user}","gists_url":"https://api.github.com/users/leoetlino/gists{/gist_id}","starred_url":"https://api.github.com/users/leoetlino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoetlino/subscriptions","organizations_url":"https://api.github.com/users/leoetlino/orgs","repos_url":"https://api.github.com/users/leoetlino/repos","events_url":"https://api.github.com/users/leoetlino/events{/privacy}","received_events_url":"https://api.github.com/users/leoetlino/received_events","type":"User","site_admin":false},"body":"Should this take a ref instead to indicate that EmulatedBS2_Wii should be called with a valid volume, since BS2 technically only runs for discs?","created_at":"2017-05-14T11:12:34Z","updated_at":"2017-05-14T11:15:24Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/4241#discussion_r116378216","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/116378216"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4241#discussion_r116378216"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241","id":86617341,"html_url":"https://github.com/dolphin-emu/dolphin/pull/4241","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4241.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4241.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4241","number":4241,"state":"open","locked":false,"title":"Remove DVDInterface::GetVolume","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars1.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"body":"The commit descriptions explain the reasons for the changes. The end goal is the last commit, which has the following description:\r\n\r\n---\r\n\r\nDVDInterface: Remove GetVolume\r\n\r\nFor thread safety reasons, the currently inserted volume must\r\nonly be accessed by the DVD thread (or by the CPU thread if it\r\ncalls DVDThread::WaitUntilIdle() first). After this commit,\r\nonly DVDThread.cpp can access the volume, which prevents code in\r\nother files from accessing the volume in a non-threadsafe way.\r\n\r\n<!-- Reviewable:start -->\r\n\r\n---\r\n\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4241)\r\n\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-09-24T12:54:20Z","updated_at":"2017-05-14T11:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18c01ebaf074389ee89796238ee16e55e1e7dd6c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4241/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/a082da7c307ad927ee7887f046608dbdcf088e69","head":{"label":"JosJuice:remove-getvolume","ref":"remove-getvolume","sha":"a082da7c307ad927ee7887f046608dbdcf088e69","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars1.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"repo":{"id":26057138,"name":"dolphin","full_name":"JosJuice/dolphin","owner":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars1.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosJuice/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/JosJuice/dolphin","forks_url":"https://api.github.com/repos/JosJuice/dolphin/forks","keys_url":"https://api.github.com/repos/JosJuice/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosJuice/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosJuice/dolphin/teams","hooks_url":"https://api.github.com/repos/JosJuice/dolphin/hooks","issue_events_url":"https://api.github.com/repos/JosJuice/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/JosJuice/dolphin/events","assignees_url":"https://api.github.com/repos/JosJuice/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/JosJuice/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/JosJuice/dolphin/tags","blobs_url":"https://api.github.com/repos/JosJuice/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosJuice/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosJuice/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosJuice/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosJuice/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/JosJuice/dolphin/languages","stargazers_url":"https://api.github.com/repos/JosJuice/dolphin/stargazers","contributors_url":"https://api.github.com/repos/JosJuice/dolphin/contributors","subscribers_url":"https://api.github.com/repos/JosJuice/dolphin/subscribers","subscription_url":"https://api.github.com/repos/JosJuice/dolphin/subscription","commits_url":"https://api.github.com/repos/JosJuice/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosJuice/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosJuice/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosJuice/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosJuice/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/JosJuice/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosJuice/dolphin/merges","archive_url":"https://api.github.com/repos/JosJuice/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosJuice/dolphin/downloads","issues_url":"https://api.github.com/repos/JosJuice/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/JosJuice/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/JosJuice/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/JosJuice/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosJuice/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/JosJuice/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/JosJuice/dolphin/deployments","created_at":"2014-11-01T17:12:40Z","updated_at":"2016-10-24T10:37:02Z","pushed_at":"2017-05-13T21:05:32Z","git_url":"git://github.com/JosJuice/dolphin.git","ssh_url":"git@github.com:JosJuice/dolphin.git","clone_url":"https://github.com/JosJuice/dolphin.git","svn_url":"https://github.com/JosJuice/dolphin","homepage":null,"size":299371,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"0f504e7a846bb3810f2c43549544840bd16e6578","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-05-14T01:57:42Z","pushed_at":"2017-05-14T10:45:27Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":336892,"stargazers_count":3304,"watchers_count":3304,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":862,"mirror_url":null,"open_issues_count":151,"forks":862,"open_issues":151,"watchers":3304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4241"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4241"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4241/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4241/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/a082da7c307ad927ee7887f046608dbdcf088e69"}}}}
{"actor":{"display_login":"leoetlino"}}