{"action":"created","issue":{"url":"https://api.github.com/repos/go-commons/commons/issues/1","repository_url":"https://api.github.com/repos/go-commons/commons","labels_url":"https://api.github.com/repos/go-commons/commons/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/go-commons/commons/issues/1/comments","events_url":"https://api.github.com/repos/go-commons/commons/issues/1/events","html_url":"https://github.com/go-commons/commons/issues/1","id":271558637,"number":1,"title":"Standard logger interface.","user":{"login":"leehambley","id":18952,"avatar_url":"https://avatars0.githubusercontent.com/u/18952?v=4","gravatar_id":"","url":"https://api.github.com/users/leehambley","html_url":"https://github.com/leehambley","followers_url":"https://api.github.com/users/leehambley/followers","following_url":"https://api.github.com/users/leehambley/following{/other_user}","gists_url":"https://api.github.com/users/leehambley/gists{/gist_id}","starred_url":"https://api.github.com/users/leehambley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leehambley/subscriptions","organizations_url":"https://api.github.com/users/leehambley/orgs","repos_url":"https://api.github.com/users/leehambley/repos","events_url":"https://api.github.com/users/leehambley/events{/privacy}","received_events_url":"https://api.github.com/users/leehambley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-11-06T17:33:21Z","updated_at":"2017-11-07T13:26:45Z","closed_at":null,"author_association":"NONE","body":"I'm sitting in the upper balcony and wondered if here was the place to get the new standard logger interface nailed down.\r\n\r\nKeeping interfaces small is something I can stand behind, but logging seems like a nebulous topic.\r\n\r\nI'm going to flesh this out later, first thought is that logging should concern itself with the Printf family of functions, and levels should be implemented by returning a new logger with an internal tags representing the level."},"comment":{"url":"https://api.github.com/repos/go-commons/commons/issues/comments/342481387","html_url":"https://github.com/go-commons/commons/issues/1#issuecomment-342481387","issue_url":"https://api.github.com/repos/go-commons/commons/issues/1","id":342481387,"user":{"login":"ChrisHines","id":1060711,"avatar_url":"https://avatars2.githubusercontent.com/u/1060711?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisHines","html_url":"https://github.com/ChrisHines","followers_url":"https://api.github.com/users/ChrisHines/followers","following_url":"https://api.github.com/users/ChrisHines/following{/other_user}","gists_url":"https://api.github.com/users/ChrisHines/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisHines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisHines/subscriptions","organizations_url":"https://api.github.com/users/ChrisHines/orgs","repos_url":"https://api.github.com/users/ChrisHines/repos","events_url":"https://api.github.com/users/ChrisHines/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisHines/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T13:26:45Z","updated_at":"2017-11-07T13:26:45Z","author_association":"NONE","body":"First, thanks to @aybabtme for perfectly expressing my point of view above.\r\n\r\n@bketelsen said:\r\n\r\n>@peterbourgon I propose that we add your logger interface in a new commons/log package and add implementations as subpackages.\r\n\r\nWhen @peterbourgon and I were working on the Go proposal doc that he linked above, we discussed the idea of moving github.com/go-kit/kit/log/... into their own repo. The argument for doing so was that it would provide more visibility as a stand alone set of packages. We perceived that awareness of the go-kit log package suffered because collections like github.com/avelino/awesome-go focus on code repositories and make it difficult to list \"sub\"-packages. On the other hand github.com/go-kit/kit/log is certainly popular enough that we wouldn't want to break anyone using it. We concluded that we should revisit the question when aliases dropped in Go 1.9 as that might allow us to move the packages without breaking any dependent code. So, now that 1.9 is out and in use, we can have that discussion. Our original idea was simply to move them to github.com/go-kit/log/... and your proposal above raises the obvious idea of moving them into this project instead. I am not opposed to it, but I want to consider the idea deliberately before we decide.\r\n\r\nOne point of friction to discuss is that github.com/go-kit/kit/log imports a couple of things from outside the standard library: github.com/go-stack/stack and github.com/go-logfmt/logfmt. Both of those are mine, but using them would violate the go-commons policy of only depending on the standard library or go-commons packages, and I'm not sure it makes sense to move them here as well.\r\n\r\n@bketelsen also wrote: \r\n\r\n>Would also like to see contextual logger interface and leveled logger interface added.\r\n\r\nIn our formulation contextual logging only needs a: https://godoc.org/github.com/go-kit/kit/log#hdr-Contextual_Loggers.\r\n\r\nLeveled logging is also mostly just functions: https://godoc.org/github.com/go-kit/kit/log/level."}}
{"actor":{"display_login":"ChrisHines"}}