{"action":"created","comment":{"url":"https://api.github.com/repos/lumoslabs/broadside/pulls/comments/99045856","pull_request_review_id":19707913,"id":99045856,"diff_hunk":"@@ -17,6 +17,11 @@ def add_instance_flag(cmd)\n   cmd.flag [:n, :instance], type: Fixnum\n end\n \n+def add_command_flags(cmd)","path":"lib/broadside/cli/gli_commands.rb","position":4,"original_position":4,"commit_id":"5256b890021bebaa178014325353fc77d06a22a7","original_commit_id":"5256b890021bebaa178014325353fc77d06a22a7","user":{"login":"matl33t","id":1761536,"avatar_url":"https://avatars.githubusercontent.com/u/1761536?v=3","gravatar_id":"","url":"https://api.github.com/users/matl33t","html_url":"https://github.com/matl33t","followers_url":"https://api.github.com/users/matl33t/followers","following_url":"https://api.github.com/users/matl33t/following{/other_user}","gists_url":"https://api.github.com/users/matl33t/gists{/gist_id}","starred_url":"https://api.github.com/users/matl33t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matl33t/subscriptions","organizations_url":"https://api.github.com/users/matl33t/orgs","repos_url":"https://api.github.com/users/matl33t/repos","events_url":"https://api.github.com/users/matl33t/events{/privacy}","received_events_url":"https://api.github.com/users/matl33t/received_events","type":"User","site_admin":false},"body":"i still think this is unnecessary ravioli-ing ","created_at":"2017-02-02T03:01:12Z","updated_at":"2017-02-02T03:01:12Z","html_url":"https://github.com/lumoslabs/broadside/pull/58#discussion_r99045856","pull_request_url":"https://api.github.com/repos/lumoslabs/broadside/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/lumoslabs/broadside/pulls/comments/99045856"},"html":{"href":"https://github.com/lumoslabs/broadside/pull/58#discussion_r99045856"},"pull_request":{"href":"https://api.github.com/repos/lumoslabs/broadside/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/lumoslabs/broadside/pulls/58","id":104266719,"html_url":"https://github.com/lumoslabs/broadside/pull/58","diff_url":"https://github.com/lumoslabs/broadside/pull/58.diff","patch_url":"https://github.com/lumoslabs/broadside/pull/58.patch","issue_url":"https://api.github.com/repos/lumoslabs/broadside/issues/58","number":58,"state":"open","locked":false,"title":"WIP: Test some ideas about how an ultimate refactor might look","user":{"login":"apurvis","id":231694,"avatar_url":"https://avatars.githubusercontent.com/u/231694?v=3","gravatar_id":"","url":"https://api.github.com/users/apurvis","html_url":"https://github.com/apurvis","followers_url":"https://api.github.com/users/apurvis/followers","following_url":"https://api.github.com/users/apurvis/following{/other_user}","gists_url":"https://api.github.com/users/apurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvis/subscriptions","organizations_url":"https://api.github.com/users/apurvis/orgs","repos_url":"https://api.github.com/users/apurvis/repos","events_url":"https://api.github.com/users/apurvis/events{/privacy}","received_events_url":"https://api.github.com/users/apurvis/received_events","type":"User","site_admin":false},"body":"@matl33t just wanted to see if we're on the same page here, which i think we mostly are.\r\n\r\nthere's also a few legitimate bugfixes in this PR... given that this PR is speculative/for discussion mostly, those should probably be fixed on master (e.g. you forgot to allow `--tag` for short deploys).\r\n\r\nsome observations:\r\n\r\n1. git didn't do a great job at showing the diffs.  i didn't change `get_running_instance_ip!` at all, i just moved `update_service` to a public method.\r\n1. `Deploy` could ultimately be a module - all the stateful information should live in `Target` and everything else should just be passed in as `options`.  I made this change with `scale` and `rollback` just to see what it would look like.  this also nicely solves the lack of validation on the `Deploy` object - there should be no validation because there should be no state (ultimately)\r\n1. there's not much advantage for `Command` to just pass through the deploy commands until we're in that world, so i just put `EcsDeploy.new` in the GLI code. ","created_at":"2017-02-02T02:53:20Z","updated_at":"2017-02-02T03:01:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1433678654864f47e2b43031be8573e5d9d28ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lumoslabs/broadside/pulls/58/commits","review_comments_url":"https://api.github.com/repos/lumoslabs/broadside/pulls/58/comments","review_comment_url":"https://api.github.com/repos/lumoslabs/broadside/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lumoslabs/broadside/issues/58/comments","statuses_url":"https://api.github.com/repos/lumoslabs/broadside/statuses/5256b890021bebaa178014325353fc77d06a22a7","head":{"label":"lumoslabs:speculative_refactor","ref":"speculative_refactor","sha":"5256b890021bebaa178014325353fc77d06a22a7","user":{"login":"lumoslabs","id":723646,"avatar_url":"https://avatars.githubusercontent.com/u/723646?v=3","gravatar_id":"","url":"https://api.github.com/users/lumoslabs","html_url":"https://github.com/lumoslabs","followers_url":"https://api.github.com/users/lumoslabs/followers","following_url":"https://api.github.com/users/lumoslabs/following{/other_user}","gists_url":"https://api.github.com/users/lumoslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lumoslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumoslabs/subscriptions","organizations_url":"https://api.github.com/users/lumoslabs/orgs","repos_url":"https://api.github.com/users/lumoslabs/repos","events_url":"https://api.github.com/users/lumoslabs/events{/privacy}","received_events_url":"https://api.github.com/users/lumoslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":61584844,"name":"broadside","full_name":"lumoslabs/broadside","owner":{"login":"lumoslabs","id":723646,"avatar_url":"https://avatars.githubusercontent.com/u/723646?v=3","gravatar_id":"","url":"https://api.github.com/users/lumoslabs","html_url":"https://github.com/lumoslabs","followers_url":"https://api.github.com/users/lumoslabs/followers","following_url":"https://api.github.com/users/lumoslabs/following{/other_user}","gists_url":"https://api.github.com/users/lumoslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lumoslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumoslabs/subscriptions","organizations_url":"https://api.github.com/users/lumoslabs/orgs","repos_url":"https://api.github.com/users/lumoslabs/repos","events_url":"https://api.github.com/users/lumoslabs/events{/privacy}","received_events_url":"https://api.github.com/users/lumoslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lumoslabs/broadside","description":"Command-line tool for deploying applications on AWS EC2 Container Service (ECS)","fork":false,"url":"https://api.github.com/repos/lumoslabs/broadside","forks_url":"https://api.github.com/repos/lumoslabs/broadside/forks","keys_url":"https://api.github.com/repos/lumoslabs/broadside/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumoslabs/broadside/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumoslabs/broadside/teams","hooks_url":"https://api.github.com/repos/lumoslabs/broadside/hooks","issue_events_url":"https://api.github.com/repos/lumoslabs/broadside/issues/events{/number}","events_url":"https://api.github.com/repos/lumoslabs/broadside/events","assignees_url":"https://api.github.com/repos/lumoslabs/broadside/assignees{/user}","branches_url":"https://api.github.com/repos/lumoslabs/broadside/branches{/branch}","tags_url":"https://api.github.com/repos/lumoslabs/broadside/tags","blobs_url":"https://api.github.com/repos/lumoslabs/broadside/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumoslabs/broadside/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumoslabs/broadside/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumoslabs/broadside/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumoslabs/broadside/statuses/{sha}","languages_url":"https://api.github.com/repos/lumoslabs/broadside/languages","stargazers_url":"https://api.github.com/repos/lumoslabs/broadside/stargazers","contributors_url":"https://api.github.com/repos/lumoslabs/broadside/contributors","subscribers_url":"https://api.github.com/repos/lumoslabs/broadside/subscribers","subscription_url":"https://api.github.com/repos/lumoslabs/broadside/subscription","commits_url":"https://api.github.com/repos/lumoslabs/broadside/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumoslabs/broadside/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumoslabs/broadside/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumoslabs/broadside/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumoslabs/broadside/contents/{+path}","compare_url":"https://api.github.com/repos/lumoslabs/broadside/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumoslabs/broadside/merges","archive_url":"https://api.github.com/repos/lumoslabs/broadside/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumoslabs/broadside/downloads","issues_url":"https://api.github.com/repos/lumoslabs/broadside/issues{/number}","pulls_url":"https://api.github.com/repos/lumoslabs/broadside/pulls{/number}","milestones_url":"https://api.github.com/repos/lumoslabs/broadside/milestones{/number}","notifications_url":"https://api.github.com/repos/lumoslabs/broadside/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumoslabs/broadside/labels{/name}","releases_url":"https://api.github.com/repos/lumoslabs/broadside/releases{/id}","deployments_url":"https://api.github.com/repos/lumoslabs/broadside/deployments","created_at":"2016-06-20T22:30:48Z","updated_at":"2016-12-06T21:07:23Z","pushed_at":"2017-02-02T02:59:25Z","git_url":"git://github.com/lumoslabs/broadside.git","ssh_url":"git@github.com:lumoslabs/broadside.git","clone_url":"https://github.com/lumoslabs/broadside.git","svn_url":"https://github.com/lumoslabs/broadside","homepage":null,"size":159,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":5,"default_branch":"master"}},"base":{"label":"lumoslabs:master","ref":"master","sha":"cfa3690e0a20cf4bf0e41941e60c7da1780eeb51","user":{"login":"lumoslabs","id":723646,"avatar_url":"https://avatars.githubusercontent.com/u/723646?v=3","gravatar_id":"","url":"https://api.github.com/users/lumoslabs","html_url":"https://github.com/lumoslabs","followers_url":"https://api.github.com/users/lumoslabs/followers","following_url":"https://api.github.com/users/lumoslabs/following{/other_user}","gists_url":"https://api.github.com/users/lumoslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lumoslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumoslabs/subscriptions","organizations_url":"https://api.github.com/users/lumoslabs/orgs","repos_url":"https://api.github.com/users/lumoslabs/repos","events_url":"https://api.github.com/users/lumoslabs/events{/privacy}","received_events_url":"https://api.github.com/users/lumoslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":61584844,"name":"broadside","full_name":"lumoslabs/broadside","owner":{"login":"lumoslabs","id":723646,"avatar_url":"https://avatars.githubusercontent.com/u/723646?v=3","gravatar_id":"","url":"https://api.github.com/users/lumoslabs","html_url":"https://github.com/lumoslabs","followers_url":"https://api.github.com/users/lumoslabs/followers","following_url":"https://api.github.com/users/lumoslabs/following{/other_user}","gists_url":"https://api.github.com/users/lumoslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/lumoslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumoslabs/subscriptions","organizations_url":"https://api.github.com/users/lumoslabs/orgs","repos_url":"https://api.github.com/users/lumoslabs/repos","events_url":"https://api.github.com/users/lumoslabs/events{/privacy}","received_events_url":"https://api.github.com/users/lumoslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lumoslabs/broadside","description":"Command-line tool for deploying applications on AWS EC2 Container Service (ECS)","fork":false,"url":"https://api.github.com/repos/lumoslabs/broadside","forks_url":"https://api.github.com/repos/lumoslabs/broadside/forks","keys_url":"https://api.github.com/repos/lumoslabs/broadside/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumoslabs/broadside/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumoslabs/broadside/teams","hooks_url":"https://api.github.com/repos/lumoslabs/broadside/hooks","issue_events_url":"https://api.github.com/repos/lumoslabs/broadside/issues/events{/number}","events_url":"https://api.github.com/repos/lumoslabs/broadside/events","assignees_url":"https://api.github.com/repos/lumoslabs/broadside/assignees{/user}","branches_url":"https://api.github.com/repos/lumoslabs/broadside/branches{/branch}","tags_url":"https://api.github.com/repos/lumoslabs/broadside/tags","blobs_url":"https://api.github.com/repos/lumoslabs/broadside/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumoslabs/broadside/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumoslabs/broadside/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumoslabs/broadside/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumoslabs/broadside/statuses/{sha}","languages_url":"https://api.github.com/repos/lumoslabs/broadside/languages","stargazers_url":"https://api.github.com/repos/lumoslabs/broadside/stargazers","contributors_url":"https://api.github.com/repos/lumoslabs/broadside/contributors","subscribers_url":"https://api.github.com/repos/lumoslabs/broadside/subscribers","subscription_url":"https://api.github.com/repos/lumoslabs/broadside/subscription","commits_url":"https://api.github.com/repos/lumoslabs/broadside/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumoslabs/broadside/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumoslabs/broadside/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumoslabs/broadside/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumoslabs/broadside/contents/{+path}","compare_url":"https://api.github.com/repos/lumoslabs/broadside/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumoslabs/broadside/merges","archive_url":"https://api.github.com/repos/lumoslabs/broadside/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumoslabs/broadside/downloads","issues_url":"https://api.github.com/repos/lumoslabs/broadside/issues{/number}","pulls_url":"https://api.github.com/repos/lumoslabs/broadside/pulls{/number}","milestones_url":"https://api.github.com/repos/lumoslabs/broadside/milestones{/number}","notifications_url":"https://api.github.com/repos/lumoslabs/broadside/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumoslabs/broadside/labels{/name}","releases_url":"https://api.github.com/repos/lumoslabs/broadside/releases{/id}","deployments_url":"https://api.github.com/repos/lumoslabs/broadside/deployments","created_at":"2016-06-20T22:30:48Z","updated_at":"2016-12-06T21:07:23Z","pushed_at":"2017-02-02T02:59:25Z","git_url":"git://github.com/lumoslabs/broadside.git","ssh_url":"git@github.com:lumoslabs/broadside.git","clone_url":"https://github.com/lumoslabs/broadside.git","svn_url":"https://github.com/lumoslabs/broadside","homepage":null,"size":159,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lumoslabs/broadside/pulls/58"},"html":{"href":"https://github.com/lumoslabs/broadside/pull/58"},"issue":{"href":"https://api.github.com/repos/lumoslabs/broadside/issues/58"},"comments":{"href":"https://api.github.com/repos/lumoslabs/broadside/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/lumoslabs/broadside/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/lumoslabs/broadside/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lumoslabs/broadside/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/lumoslabs/broadside/statuses/5256b890021bebaa178014325353fc77d06a22a7"}}}}
{"actor":{"display_login":"matl33t"}}