{"action":"created","comment":{"url":"https://api.github.com/repos/opentable/design-tokens/pulls/comments/146552856","pull_request_review_id":71510269,"id":146552856,"diff_hunk":"@@ -37,40 +37,40 @@ aliases:\n   # Spacing\n   # #############################################\n   spacing-xsmall:\n-    value: \"0.25rem\"\n+    value: \"4px\"\n   spacing-small:\n-    value: \"0.5rem\"\n+    value: \"8px\"\n   spacing-medium:\n-    value: \"1rem\"\n+    value: \"16px\"\n   spacing-large:\n-    value: \"2rem\"\n+    value: \"32px\"\n   spacing-xlarge:\n-    value: \"4rem\"\n+    value: \"64px\"\n \n   # #############################################\n   # Typography\n   # #############################################\n   font-size-xsmall:\n-    value: \"0.875rem\"\n+    value: \"14px\"\n   font-size-small:\n-    value: \"1rem\"\n+    value: \"16px\"\n   font-size-medium:\n-    value: \"1.125rem\"\n+    value: \"18px\"\n   font-size-large:\n-    value: \"1.5rem\"\n+    value: \"24px\"\n   font-size-xlarge:\n-    value: \"3rem\"\n+    value: \"48px\"\n   # line heights seem arbitrary because they are mapped to specific font sizes\n   line-height-xsmall:\n-    value: \"1.43\"\n+    value: \"16px\"","path":"OTKit/aliases.yml","position":40,"original_position":40,"commit_id":"07c0065c353cfdcef440890215845788dfb5302f","original_commit_id":"07c0065c353cfdcef440890215845788dfb5302f","user":{"login":"karuto","id":1095291,"avatar_url":"https://avatars1.githubusercontent.com/u/1095291?v=4","gravatar_id":"","url":"https://api.github.com/users/karuto","html_url":"https://github.com/karuto","followers_url":"https://api.github.com/users/karuto/followers","following_url":"https://api.github.com/users/karuto/following{/other_user}","gists_url":"https://api.github.com/users/karuto/gists{/gist_id}","starred_url":"https://api.github.com/users/karuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karuto/subscriptions","organizations_url":"https://api.github.com/users/karuto/orgs","repos_url":"https://api.github.com/users/karuto/repos","events_url":"https://api.github.com/users/karuto/events{/privacy}","received_events_url":"https://api.github.com/users/karuto/received_events","type":"User","site_admin":false},"body":"You are changing the behavior of line heights with these changes? These line height values used to be numerical which means they scale (multiply) with the corresponding font size to get the final line height in px value.\r\n\r\nIf you do the line height calculation based on your own pixel values changed above, none of them seem to line up. For example, you set `font-size-xsmall: 14px`, then its line height should be `14px * 1.43 = 20.02px`","created_at":"2017-10-24T13:07:59Z","updated_at":"2017-10-24T13:07:59Z","html_url":"https://github.com/opentable/design-tokens/pull/56#discussion_r146552856","pull_request_url":"https://api.github.com/repos/opentable/design-tokens/pulls/56","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/opentable/design-tokens/pulls/comments/146552856"},"html":{"href":"https://github.com/opentable/design-tokens/pull/56#discussion_r146552856"},"pull_request":{"href":"https://api.github.com/repos/opentable/design-tokens/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/opentable/design-tokens/pulls/56","id":148269833,"html_url":"https://github.com/opentable/design-tokens/pull/56","diff_url":"https://github.com/opentable/design-tokens/pull/56.diff","patch_url":"https://github.com/opentable/design-tokens/pull/56.patch","issue_url":"https://api.github.com/repos/opentable/design-tokens/issues/56","number":56,"state":"open","locked":false,"title":"[MW-1975] Use Pixels for OTKit. (And a few README clean-ups)","user":{"login":"cbeley","id":4041776,"avatar_url":"https://avatars1.githubusercontent.com/u/4041776?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeley","html_url":"https://github.com/cbeley","followers_url":"https://api.github.com/users/cbeley/followers","following_url":"https://api.github.com/users/cbeley/following{/other_user}","gists_url":"https://api.github.com/users/cbeley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeley/subscriptions","organizations_url":"https://api.github.com/users/cbeley/orgs","repos_url":"https://api.github.com/users/cbeley/repos","events_url":"https://api.github.com/users/cbeley/events{/privacy}","received_events_url":"https://api.github.com/users/cbeley/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-24T00:14:02Z","updated_at":"2017-10-24T13:07:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3780df69b20d8c608eb2474fea38179639921717","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentable/design-tokens/pulls/56/commits","review_comments_url":"https://api.github.com/repos/opentable/design-tokens/pulls/56/comments","review_comment_url":"https://api.github.com/repos/opentable/design-tokens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentable/design-tokens/issues/56/comments","statuses_url":"https://api.github.com/repos/opentable/design-tokens/statuses/07c0065c353cfdcef440890215845788dfb5302f","head":{"label":"cbeley:remsToPixels","ref":"remsToPixels","sha":"07c0065c353cfdcef440890215845788dfb5302f","user":{"login":"cbeley","id":4041776,"avatar_url":"https://avatars1.githubusercontent.com/u/4041776?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeley","html_url":"https://github.com/cbeley","followers_url":"https://api.github.com/users/cbeley/followers","following_url":"https://api.github.com/users/cbeley/following{/other_user}","gists_url":"https://api.github.com/users/cbeley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeley/subscriptions","organizations_url":"https://api.github.com/users/cbeley/orgs","repos_url":"https://api.github.com/users/cbeley/repos","events_url":"https://api.github.com/users/cbeley/events{/privacy}","received_events_url":"https://api.github.com/users/cbeley/received_events","type":"User","site_admin":false},"repo":{"id":108052039,"name":"design-tokens","full_name":"cbeley/design-tokens","owner":{"login":"cbeley","id":4041776,"avatar_url":"https://avatars1.githubusercontent.com/u/4041776?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeley","html_url":"https://github.com/cbeley","followers_url":"https://api.github.com/users/cbeley/followers","following_url":"https://api.github.com/users/cbeley/following{/other_user}","gists_url":"https://api.github.com/users/cbeley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeley/subscriptions","organizations_url":"https://api.github.com/users/cbeley/orgs","repos_url":"https://api.github.com/users/cbeley/repos","events_url":"https://api.github.com/users/cbeley/events{/privacy}","received_events_url":"https://api.github.com/users/cbeley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbeley/design-tokens","description":"A place where OpenTable engineers and designers openly work together","fork":true,"url":"https://api.github.com/repos/cbeley/design-tokens","forks_url":"https://api.github.com/repos/cbeley/design-tokens/forks","keys_url":"https://api.github.com/repos/cbeley/design-tokens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbeley/design-tokens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbeley/design-tokens/teams","hooks_url":"https://api.github.com/repos/cbeley/design-tokens/hooks","issue_events_url":"https://api.github.com/repos/cbeley/design-tokens/issues/events{/number}","events_url":"https://api.github.com/repos/cbeley/design-tokens/events","assignees_url":"https://api.github.com/repos/cbeley/design-tokens/assignees{/user}","branches_url":"https://api.github.com/repos/cbeley/design-tokens/branches{/branch}","tags_url":"https://api.github.com/repos/cbeley/design-tokens/tags","blobs_url":"https://api.github.com/repos/cbeley/design-tokens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbeley/design-tokens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbeley/design-tokens/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbeley/design-tokens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbeley/design-tokens/statuses/{sha}","languages_url":"https://api.github.com/repos/cbeley/design-tokens/languages","stargazers_url":"https://api.github.com/repos/cbeley/design-tokens/stargazers","contributors_url":"https://api.github.com/repos/cbeley/design-tokens/contributors","subscribers_url":"https://api.github.com/repos/cbeley/design-tokens/subscribers","subscription_url":"https://api.github.com/repos/cbeley/design-tokens/subscription","commits_url":"https://api.github.com/repos/cbeley/design-tokens/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbeley/design-tokens/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbeley/design-tokens/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbeley/design-tokens/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbeley/design-tokens/contents/{+path}","compare_url":"https://api.github.com/repos/cbeley/design-tokens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbeley/design-tokens/merges","archive_url":"https://api.github.com/repos/cbeley/design-tokens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbeley/design-tokens/downloads","issues_url":"https://api.github.com/repos/cbeley/design-tokens/issues{/number}","pulls_url":"https://api.github.com/repos/cbeley/design-tokens/pulls{/number}","milestones_url":"https://api.github.com/repos/cbeley/design-tokens/milestones{/number}","notifications_url":"https://api.github.com/repos/cbeley/design-tokens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbeley/design-tokens/labels{/name}","releases_url":"https://api.github.com/repos/cbeley/design-tokens/releases{/id}","deployments_url":"https://api.github.com/repos/cbeley/design-tokens/deployments","created_at":"2017-10-23T23:28:54Z","updated_at":"2017-10-23T20:24:28Z","pushed_at":"2017-10-24T00:13:44Z","git_url":"git://github.com/cbeley/design-tokens.git","ssh_url":"git@github.com:cbeley/design-tokens.git","clone_url":"https://github.com/cbeley/design-tokens.git","svn_url":"https://github.com/cbeley/design-tokens","homepage":"","size":112,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentable:master","ref":"master","sha":"1a109b756d664a6bc99124451618cf3ed015eee9","user":{"login":"opentable","id":2653541,"avatar_url":"https://avatars0.githubusercontent.com/u/2653541?v=4","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"repo":{"id":98441172,"name":"design-tokens","full_name":"opentable/design-tokens","owner":{"login":"opentable","id":2653541,"avatar_url":"https://avatars0.githubusercontent.com/u/2653541?v=4","gravatar_id":"","url":"https://api.github.com/users/opentable","html_url":"https://github.com/opentable","followers_url":"https://api.github.com/users/opentable/followers","following_url":"https://api.github.com/users/opentable/following{/other_user}","gists_url":"https://api.github.com/users/opentable/gists{/gist_id}","starred_url":"https://api.github.com/users/opentable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentable/subscriptions","organizations_url":"https://api.github.com/users/opentable/orgs","repos_url":"https://api.github.com/users/opentable/repos","events_url":"https://api.github.com/users/opentable/events{/privacy}","received_events_url":"https://api.github.com/users/opentable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentable/design-tokens","description":"A place where OpenTable engineers and designers openly work together","fork":false,"url":"https://api.github.com/repos/opentable/design-tokens","forks_url":"https://api.github.com/repos/opentable/design-tokens/forks","keys_url":"https://api.github.com/repos/opentable/design-tokens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentable/design-tokens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentable/design-tokens/teams","hooks_url":"https://api.github.com/repos/opentable/design-tokens/hooks","issue_events_url":"https://api.github.com/repos/opentable/design-tokens/issues/events{/number}","events_url":"https://api.github.com/repos/opentable/design-tokens/events","assignees_url":"https://api.github.com/repos/opentable/design-tokens/assignees{/user}","branches_url":"https://api.github.com/repos/opentable/design-tokens/branches{/branch}","tags_url":"https://api.github.com/repos/opentable/design-tokens/tags","blobs_url":"https://api.github.com/repos/opentable/design-tokens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentable/design-tokens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentable/design-tokens/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentable/design-tokens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentable/design-tokens/statuses/{sha}","languages_url":"https://api.github.com/repos/opentable/design-tokens/languages","stargazers_url":"https://api.github.com/repos/opentable/design-tokens/stargazers","contributors_url":"https://api.github.com/repos/opentable/design-tokens/contributors","subscribers_url":"https://api.github.com/repos/opentable/design-tokens/subscribers","subscription_url":"https://api.github.com/repos/opentable/design-tokens/subscription","commits_url":"https://api.github.com/repos/opentable/design-tokens/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentable/design-tokens/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentable/design-tokens/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentable/design-tokens/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentable/design-tokens/contents/{+path}","compare_url":"https://api.github.com/repos/opentable/design-tokens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentable/design-tokens/merges","archive_url":"https://api.github.com/repos/opentable/design-tokens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentable/design-tokens/downloads","issues_url":"https://api.github.com/repos/opentable/design-tokens/issues{/number}","pulls_url":"https://api.github.com/repos/opentable/design-tokens/pulls{/number}","milestones_url":"https://api.github.com/repos/opentable/design-tokens/milestones{/number}","notifications_url":"https://api.github.com/repos/opentable/design-tokens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentable/design-tokens/labels{/name}","releases_url":"https://api.github.com/repos/opentable/design-tokens/releases{/id}","deployments_url":"https://api.github.com/repos/opentable/design-tokens/deployments","created_at":"2017-07-26T15:58:12Z","updated_at":"2017-10-23T20:24:28Z","pushed_at":"2017-10-24T00:14:02Z","git_url":"git://github.com/opentable/design-tokens.git","ssh_url":"git@github.com:opentable/design-tokens.git","clone_url":"https://github.com/opentable/design-tokens.git","svn_url":"https://github.com/opentable/design-tokens","homepage":"","size":109,"stargazers_count":15,"watchers_count":15,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentable/design-tokens/pulls/56"},"html":{"href":"https://github.com/opentable/design-tokens/pull/56"},"issue":{"href":"https://api.github.com/repos/opentable/design-tokens/issues/56"},"comments":{"href":"https://api.github.com/repos/opentable/design-tokens/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/opentable/design-tokens/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/opentable/design-tokens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentable/design-tokens/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/opentable/design-tokens/statuses/07c0065c353cfdcef440890215845788dfb5302f"}},"author_association":"NONE"}}
{"actor":{"display_login":"karuto"}}