{"action":"closed","number":47,"pull_request":{"url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/47","id":135669160,"html_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/47","diff_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/47.diff","patch_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/47.patch","issue_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/47","number":47,"state":"closed","locked":false,"title":"Polish the implementation of the JSON graph (#32)","user":{"login":"ferstl","id":1487727,"avatar_url":"https://avatars1.githubusercontent.com/u/1487727?v=4","gravatar_id":"","url":"https://api.github.com/users/ferstl","html_url":"https://github.com/ferstl","followers_url":"https://api.github.com/users/ferstl/followers","following_url":"https://api.github.com/users/ferstl/following{/other_user}","gists_url":"https://api.github.com/users/ferstl/gists{/gist_id}","starred_url":"https://api.github.com/users/ferstl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferstl/subscriptions","organizations_url":"https://api.github.com/users/ferstl/orgs","repos_url":"https://api.github.com/users/ferstl/repos","events_url":"https://api.github.com/users/ferstl/events{/privacy}","received_events_url":"https://api.github.com/users/ferstl/received_events","type":"User","site_admin":false},"body":"- Add new Mojo-Parameter to show everything in case of the JSON graph (true by default). If the parameter is set to false, users can still chose what to have in the graph. The parameter is completely handled in the `AbstractGraphMojo`. All other Mojos do not need to know about the graph format.\r\n- Use Jackson to create the JSON graph (the library is already used for the style configuration in the Dot graph)\r\n- Add a string node ID (as created by the nodeIdRenderer)\r\n- Generate the numeric ID of the graph nodes in `JsonGraphFormatter` rather than in the node and edge name renderers. The former solution did not work when `includes`/`excludes` were used.\r\n- Add the graph's name to the output (as in the other formats)\r\n- Add `types` to the graph. Similar to the scopes, a node might have more than one type.\r\n- Add some unit tests for the JSON stuff\r\n- The JSON graph will now look like this:\r\n  ```{\r\n  \"graphName\" : \"module-1\",\r\n  \"artifacts\" : [ {\r\n    \"id\" : \"com.github.ferstl:module-1:1.0.0-SNAPSHOT:jar:\",\r\n    \"numericId\" : 1,\r\n    \"groupId\" : \"com.github.ferstl\",\r\n    \"artifactId\" : \"module-1\",\r\n    \"version\" : \"1.0.0-SNAPSHOT\",\r\n    \"scopes\" : [ \"compile\" ],\r\n    \"types\" : [ \"jar\" ]\r\n  }, {\r\n    \"id\" : \"commons-codec:commons-codec:1.10:jar:\",\r\n    \"numericId\" : 2,\r\n    \"groupId\" : \"commons-codec\",\r\n    \"artifactId\" : \"commons-codec\",\r\n    \"version\" : \"1.10\",\r\n    \"scopes\" : [ \"compile\" ],\r\n    \"types\" : [ \"jar\" ]\r\n  }, {\r\n    \"id\" : \"org.apache.commons:commons-lang3:3.1:jar:\",\r\n    \"numericId\" : 3,\r\n    \"groupId\" : \"org.apache.commons\",\r\n    \"artifactId\" : \"commons-lang3\",\r\n    \"version\" : \"3.1\",\r\n    \"scopes\" : [ \"compile\" ],\r\n    \"types\" : [ \"jar\" ]\r\n  }, {\r\n    \"id\" : \"junit:junit:4.12:jar:\",\r\n    \"numericId\" : 4,\r\n    \"groupId\" : \"junit\",\r\n    \"artifactId\" : \"junit\",\r\n    \"version\" : \"4.12\",\r\n    \"scopes\" : [ \"test\" ],\r\n    \"types\" : [ \"jar\" ]\r\n  }, {\r\n    \"id\" : \"org.hamcrest:hamcrest-core:1.3:jar:\",\r\n    \"numericId\" : 5,\r\n    \"groupId\" : \"org.hamcrest\",\r\n    \"artifactId\" : \"hamcrest-core\",\r\n    \"version\" : \"1.3\",\r\n    \"scopes\" : [ \"test\" ],\r\n    \"types\" : [ \"jar\" ]\r\n  } ],\r\n  \"dependencies\" : [ {\r\n    \"from\" : \"com.github.ferstl:module-1:1.0.0-SNAPSHOT:jar:\",\r\n    \"to\" : \"commons-codec:commons-codec:1.10:jar:\",\r\n    \"numericFrom\" : 0,\r\n    \"numericTo\" : 1,\r\n    \"resolution\" : \"INCLUDED\"\r\n  }, {\r\n    \"from\" : \"com.github.ferstl:module-1:1.0.0-SNAPSHOT:jar:\",\r\n    \"to\" : \"org.apache.commons:commons-lang3:3.1:jar:\",\r\n    \"numericFrom\" : 0,\r\n    \"numericTo\" : 2,\r\n    \"resolution\" : \"INCLUDED\"\r\n  }, {\r\n    \"from\" : \"junit:junit:4.12:jar:\",\r\n    \"to\" : \"org.hamcrest:hamcrest-core:1.3:jar:\",\r\n    \"numericFrom\" : 3,\r\n    \"numericTo\" : 4,\r\n    \"resolution\" : \"INCLUDED\"\r\n  }, {\r\n    \"from\" : \"com.github.ferstl:module-1:1.0.0-SNAPSHOT:jar:\",\r\n    \"to\" : \"junit:junit:4.12:jar:\",\r\n    \"numericFrom\" : 0,\r\n    \"numericTo\" : 3,\r\n    \"resolution\" : \"INCLUDED\"\r\n  } ]\r\n}```\r\n\r\n","created_at":"2017-08-14T19:31:26Z","updated_at":"2017-08-16T18:48:45Z","closed_at":"2017-08-16T18:48:45Z","merged_at":"2017-08-16T18:48:45Z","merge_commit_sha":"07f68039959788d7077ad2a1f40cf34c1a084e5a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/47/commits","review_comments_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/47/comments","review_comment_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/47/comments","statuses_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/statuses/6c683a7eb7bd78ec35267bf29dd581d449b5fa88","head":{"label":"ferstl:feature/#32-polish","ref":"feature/#32-polish","sha":"6c683a7eb7bd78ec35267bf29dd581d449b5fa88","user":{"login":"ferstl","id":1487727,"avatar_url":"https://avatars1.githubusercontent.com/u/1487727?v=4","gravatar_id":"","url":"https://api.github.com/users/ferstl","html_url":"https://github.com/ferstl","followers_url":"https://api.github.com/users/ferstl/followers","following_url":"https://api.github.com/users/ferstl/following{/other_user}","gists_url":"https://api.github.com/users/ferstl/gists{/gist_id}","starred_url":"https://api.github.com/users/ferstl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferstl/subscriptions","organizations_url":"https://api.github.com/users/ferstl/orgs","repos_url":"https://api.github.com/users/ferstl/repos","events_url":"https://api.github.com/users/ferstl/events{/privacy}","received_events_url":"https://api.github.com/users/ferstl/received_events","type":"User","site_admin":false},"repo":{"id":16671564,"name":"depgraph-maven-plugin","full_name":"ferstl/depgraph-maven-plugin","owner":{"login":"ferstl","id":1487727,"avatar_url":"https://avatars1.githubusercontent.com/u/1487727?v=4","gravatar_id":"","url":"https://api.github.com/users/ferstl","html_url":"https://github.com/ferstl","followers_url":"https://api.github.com/users/ferstl/followers","following_url":"https://api.github.com/users/ferstl/following{/other_user}","gists_url":"https://api.github.com/users/ferstl/gists{/gist_id}","starred_url":"https://api.github.com/users/ferstl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferstl/subscriptions","organizations_url":"https://api.github.com/users/ferstl/orgs","repos_url":"https://api.github.com/users/ferstl/repos","events_url":"https://api.github.com/users/ferstl/events{/privacy}","received_events_url":"https://api.github.com/users/ferstl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferstl/depgraph-maven-plugin","description":"A Maven plugin that generates dependency graphs","fork":false,"url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin","forks_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/forks","keys_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/teams","hooks_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/events","assignees_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/tags","blobs_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/subscription","commits_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/merges","archive_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/downloads","issues_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/deployments","created_at":"2014-02-09T17:47:18Z","updated_at":"2017-08-06T14:17:26Z","pushed_at":"2017-08-16T18:48:45Z","git_url":"git://github.com/ferstl/depgraph-maven-plugin.git","ssh_url":"git@github.com:ferstl/depgraph-maven-plugin.git","clone_url":"https://github.com/ferstl/depgraph-maven-plugin.git","svn_url":"https://github.com/ferstl/depgraph-maven-plugin","homepage":"","size":1974,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":10,"forks":15,"open_issues":10,"watchers":57,"default_branch":"master"}},"base":{"label":"ferstl:master","ref":"master","sha":"09d7d160e56a716e680e269dd4a15f2fddd42f5e","user":{"login":"ferstl","id":1487727,"avatar_url":"https://avatars1.githubusercontent.com/u/1487727?v=4","gravatar_id":"","url":"https://api.github.com/users/ferstl","html_url":"https://github.com/ferstl","followers_url":"https://api.github.com/users/ferstl/followers","following_url":"https://api.github.com/users/ferstl/following{/other_user}","gists_url":"https://api.github.com/users/ferstl/gists{/gist_id}","starred_url":"https://api.github.com/users/ferstl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferstl/subscriptions","organizations_url":"https://api.github.com/users/ferstl/orgs","repos_url":"https://api.github.com/users/ferstl/repos","events_url":"https://api.github.com/users/ferstl/events{/privacy}","received_events_url":"https://api.github.com/users/ferstl/received_events","type":"User","site_admin":false},"repo":{"id":16671564,"name":"depgraph-maven-plugin","full_name":"ferstl/depgraph-maven-plugin","owner":{"login":"ferstl","id":1487727,"avatar_url":"https://avatars1.githubusercontent.com/u/1487727?v=4","gravatar_id":"","url":"https://api.github.com/users/ferstl","html_url":"https://github.com/ferstl","followers_url":"https://api.github.com/users/ferstl/followers","following_url":"https://api.github.com/users/ferstl/following{/other_user}","gists_url":"https://api.github.com/users/ferstl/gists{/gist_id}","starred_url":"https://api.github.com/users/ferstl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferstl/subscriptions","organizations_url":"https://api.github.com/users/ferstl/orgs","repos_url":"https://api.github.com/users/ferstl/repos","events_url":"https://api.github.com/users/ferstl/events{/privacy}","received_events_url":"https://api.github.com/users/ferstl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferstl/depgraph-maven-plugin","description":"A Maven plugin that generates dependency graphs","fork":false,"url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin","forks_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/forks","keys_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/teams","hooks_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/events","assignees_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/tags","blobs_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/subscription","commits_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/merges","archive_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/downloads","issues_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/deployments","created_at":"2014-02-09T17:47:18Z","updated_at":"2017-08-06T14:17:26Z","pushed_at":"2017-08-16T18:48:45Z","git_url":"git://github.com/ferstl/depgraph-maven-plugin.git","ssh_url":"git@github.com:ferstl/depgraph-maven-plugin.git","clone_url":"https://github.com/ferstl/depgraph-maven-plugin.git","svn_url":"https://github.com/ferstl/depgraph-maven-plugin","homepage":"","size":1974,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":10,"forks":15,"open_issues":10,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/47"},"html":{"href":"https://github.com/ferstl/depgraph-maven-plugin/pull/47"},"issue":{"href":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/47"},"comments":{"href":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/statuses/6c683a7eb7bd78ec35267bf29dd581d449b5fa88"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ferstl","id":1487727,"avatar_url":"https://avatars1.githubusercontent.com/u/1487727?v=4","gravatar_id":"","url":"https://api.github.com/users/ferstl","html_url":"https://github.com/ferstl","followers_url":"https://api.github.com/users/ferstl/followers","following_url":"https://api.github.com/users/ferstl/following{/other_user}","gists_url":"https://api.github.com/users/ferstl/gists{/gist_id}","starred_url":"https://api.github.com/users/ferstl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferstl/subscriptions","organizations_url":"https://api.github.com/users/ferstl/orgs","repos_url":"https://api.github.com/users/ferstl/repos","events_url":"https://api.github.com/users/ferstl/events{/privacy}","received_events_url":"https://api.github.com/users/ferstl/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":26,"additions":1009,"deletions":446,"changed_files":18}}
{"actor":{"display_login":"ferstl"}}