{"action":"created","issue":{"url":"https://api.github.com/repos/HolyLab/ImagineInterface/issues/41","repository_url":"https://api.github.com/repos/HolyLab/ImagineInterface","labels_url":"https://api.github.com/repos/HolyLab/ImagineInterface/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/HolyLab/ImagineInterface/issues/41/comments","events_url":"https://api.github.com/repos/HolyLab/ImagineInterface/issues/41/events","html_url":"https://github.com/HolyLab/ImagineInterface/issues/41","id":257862361,"number":41,"title":"Overly strict validation of digital signals","user":{"login":"Cody-G","id":5176452,"avatar_url":"https://avatars1.githubusercontent.com/u/5176452?v=4","gravatar_id":"","url":"https://api.github.com/users/Cody-G","html_url":"https://github.com/Cody-G","followers_url":"https://api.github.com/users/Cody-G/followers","following_url":"https://api.github.com/users/Cody-G/following{/other_user}","gists_url":"https://api.github.com/users/Cody-G/gists{/gist_id}","starred_url":"https://api.github.com/users/Cody-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cody-G/subscriptions","organizations_url":"https://api.github.com/users/Cody-G/orgs","repos_url":"https://api.github.com/users/Cody-G/repos","events_url":"https://api.github.com/users/Cody-G/events{/privacy}","received_events_url":"https://api.github.com/users/Cody-G/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-14T21:29:21Z","updated_at":"2017-09-14T22:29:56Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"It was brought to my attention that the way we're currently validating digital signals may be too restrictive.  We require that TTL signals begin and end LOW.\r\n\r\nI did it this makes the finding and counting of pulses (like camera and laser triggers) less ambiguous and a big easier to code.  But I don't think Imagine is currently using any such requirement, so maybe it's better to remove that restriction.\r\n\r\n@kdw503 do you see any benefits to forcing digital signals to begin LOW?  One concern I have is that the DAQ might leave the digital line in the same state after the recording is over.  So if the last sample is HIGH then the device will stay triggered.   If that's true it could definitely cause some problems (like an extremely long exposure time on the last camera trigger)"},"comment":{"url":"https://api.github.com/repos/HolyLab/ImagineInterface/issues/comments/329626540","html_url":"https://github.com/HolyLab/ImagineInterface/issues/41#issuecomment-329626540","issue_url":"https://api.github.com/repos/HolyLab/ImagineInterface/issues/41","id":329626540,"user":{"login":"Cody-G","id":5176452,"avatar_url":"https://avatars1.githubusercontent.com/u/5176452?v=4","gravatar_id":"","url":"https://api.github.com/users/Cody-G","html_url":"https://github.com/Cody-G","followers_url":"https://api.github.com/users/Cody-G/followers","following_url":"https://api.github.com/users/Cody-G/following{/other_user}","gists_url":"https://api.github.com/users/Cody-G/gists{/gist_id}","starred_url":"https://api.github.com/users/Cody-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cody-G/subscriptions","organizations_url":"https://api.github.com/users/Cody-G/orgs","repos_url":"https://api.github.com/users/Cody-G/repos","events_url":"https://api.github.com/users/Cody-G/events{/privacy}","received_events_url":"https://api.github.com/users/Cody-G/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T22:29:56Z","updated_at":"2017-09-14T22:29:56Z","author_association":"CONTRIBUTOR","body":"I think that would make sense.  Then I could remove any restrictions on the waveform itself.  We should probably also do something extra for analog outputs.  I think it's okay to leave the DAQ set at the last AO sample, but moving it to the _first_ AO sample could be dangerous if we do it too quickly (i.e. the piezo is at 0um when the user presses \"record\", but the first AO sample in the command is 500um).  Before starting the recording I think we should do a `moveTo` command with the first sample of the AO sequence.  I'm forgetting, maybe that function isn't called `moveTo` but Imagine does have a safe piezo movement function accepting a single sample."}}
{"actor":{"display_login":"Cody-G"}}