{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/comments/102995259","pull_request_review_id":23772690,"id":102995259,"diff_hunk":"@@ -159,13 +159,24 @@\n     end\n \n     context \"when configured to record errors\" do\n-      it \"fails when the body is missing a required property\" do\n+      it \"includes the reasons for failure in the exception's message\" do\n         with_options(record_errors: true) do\n-          create_schema(\"foo_schema\",\n-                        \"type\" => \"object\",\n-                        \"required\" => [\"foo\"])\n-\n-          expect(response_for({})).not_to match_response_schema(\"foo_schema\")\n+          create_schema(\"foo_schema\", {\n+            \"type\" => \"object\",\n+            \"properties\" => {\n+              \"username\" => {\n+                \"allOf\": [\n+                  { \"type\": \"string\" },\n+                  { \"minLength\": 5 }\n+                ]","path":"spec/json_matchers/match_response_schema_spec.rb","position":19,"original_position":19,"commit_id":"ee46320c6333b764f844c4207c04b17e5cb0175b","original_commit_id":"ee46320c6333b764f844c4207c04b17e5cb0175b","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Put a comma after the last item of a multiline hash.","created_at":"2017-02-24T17:54:52Z","updated_at":"2017-02-24T17:54:52Z","html_url":"https://github.com/thoughtbot/json_matchers/pull/52#discussion_r102995259","pull_request_url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/comments/102995259"},"html":{"href":"https://github.com/thoughtbot/json_matchers/pull/52#discussion_r102995259"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52","id":107868185,"html_url":"https://github.com/thoughtbot/json_matchers/pull/52","diff_url":"https://github.com/thoughtbot/json_matchers/pull/52.diff","patch_url":"https://github.com/thoughtbot/json_matchers/pull/52.patch","issue_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues/52","number":52,"state":"open","locked":false,"title":"Configure matcher to `record_errors`","user":{"login":"seanpdoyle","id":2575027,"avatar_url":"https://avatars.githubusercontent.com/u/2575027?v=3","gravatar_id":"","url":"https://api.github.com/users/seanpdoyle","html_url":"https://github.com/seanpdoyle","followers_url":"https://api.github.com/users/seanpdoyle/followers","following_url":"https://api.github.com/users/seanpdoyle/following{/other_user}","gists_url":"https://api.github.com/users/seanpdoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpdoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpdoyle/subscriptions","organizations_url":"https://api.github.com/users/seanpdoyle/orgs","repos_url":"https://api.github.com/users/seanpdoyle/repos","events_url":"https://api.github.com/users/seanpdoyle/events{/privacy}","received_events_url":"https://api.github.com/users/seanpdoyle/received_events","type":"User","site_admin":false},"body":"Closes [#51].\n\nExtract `JsonMatchers::Validator` to encapsulate error reporting\nbehavior.\n\n`JSON::Validator` exposes a `#validate!` method that will raise on\nvalidation failures, and a `#fully_validate!` method that won't raise,\nbut will return an array of error messages instead.\n\nAdditionally, this commit introduces the `#with_options` test helper\nthat scopes configuration options to a given test block.\n\n[#51]: https://github.com/thoughtbot/json_matchers/pull/51","created_at":"2017-02-24T17:01:16Z","updated_at":"2017-02-24T17:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07e01b08695f5997fa574fe0324d789b6caa5e63","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues/52/comments","statuses_url":"https://api.github.com/repos/thoughtbot/json_matchers/statuses/ee46320c6333b764f844c4207c04b17e5cb0175b","head":{"label":"thoughtbot:refactor-bbonifield-pr","ref":"refactor-bbonifield-pr","sha":"ee46320c6333b764f844c4207c04b17e5cb0175b","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":25044521,"name":"json_matchers","full_name":"thoughtbot/json_matchers","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/json_matchers","description":"Validate your JSON APIs","fork":false,"url":"https://api.github.com/repos/thoughtbot/json_matchers","forks_url":"https://api.github.com/repos/thoughtbot/json_matchers/forks","keys_url":"https://api.github.com/repos/thoughtbot/json_matchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/json_matchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/json_matchers/teams","hooks_url":"https://api.github.com/repos/thoughtbot/json_matchers/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/json_matchers/events","assignees_url":"https://api.github.com/repos/thoughtbot/json_matchers/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/json_matchers/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/json_matchers/tags","blobs_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/json_matchers/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/json_matchers/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/json_matchers/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/json_matchers/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/json_matchers/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/json_matchers/subscription","commits_url":"https://api.github.com/repos/thoughtbot/json_matchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/json_matchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/json_matchers/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/json_matchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/json_matchers/merges","archive_url":"https://api.github.com/repos/thoughtbot/json_matchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/json_matchers/downloads","issues_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/json_matchers/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/json_matchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/json_matchers/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/json_matchers/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/json_matchers/deployments","created_at":"2014-10-10T16:51:29Z","updated_at":"2017-02-23T01:40:05Z","pushed_at":"2017-02-24T17:54:43Z","git_url":"git://github.com/thoughtbot/json_matchers.git","ssh_url":"git@github.com:thoughtbot/json_matchers.git","clone_url":"https://github.com/thoughtbot/json_matchers.git","svn_url":"https://github.com/thoughtbot/json_matchers","homepage":"","size":74,"stargazers_count":132,"watchers_count":132,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":8,"forks":22,"open_issues":8,"watchers":132,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"871bb40c0addddaade9abb06b9f8600f1febd441","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":25044521,"name":"json_matchers","full_name":"thoughtbot/json_matchers","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/json_matchers","description":"Validate your JSON APIs","fork":false,"url":"https://api.github.com/repos/thoughtbot/json_matchers","forks_url":"https://api.github.com/repos/thoughtbot/json_matchers/forks","keys_url":"https://api.github.com/repos/thoughtbot/json_matchers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/json_matchers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/json_matchers/teams","hooks_url":"https://api.github.com/repos/thoughtbot/json_matchers/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/json_matchers/events","assignees_url":"https://api.github.com/repos/thoughtbot/json_matchers/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/json_matchers/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/json_matchers/tags","blobs_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/json_matchers/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/json_matchers/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/json_matchers/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/json_matchers/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/json_matchers/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/json_matchers/subscription","commits_url":"https://api.github.com/repos/thoughtbot/json_matchers/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/json_matchers/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/json_matchers/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/json_matchers/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/json_matchers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/json_matchers/merges","archive_url":"https://api.github.com/repos/thoughtbot/json_matchers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/json_matchers/downloads","issues_url":"https://api.github.com/repos/thoughtbot/json_matchers/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/json_matchers/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/json_matchers/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/json_matchers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/json_matchers/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/json_matchers/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/json_matchers/deployments","created_at":"2014-10-10T16:51:29Z","updated_at":"2017-02-23T01:40:05Z","pushed_at":"2017-02-24T17:54:43Z","git_url":"git://github.com/thoughtbot/json_matchers.git","ssh_url":"git@github.com:thoughtbot/json_matchers.git","clone_url":"https://github.com/thoughtbot/json_matchers.git","svn_url":"https://github.com/thoughtbot/json_matchers","homepage":"","size":74,"stargazers_count":132,"watchers_count":132,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":8,"forks":22,"open_issues":8,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52"},"html":{"href":"https://github.com/thoughtbot/json_matchers/pull/52"},"issue":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/issues/52"},"comments":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/json_matchers/statuses/ee46320c6333b764f844c4207c04b17e5cb0175b"}}}}
{"actor":{"display_login":"houndci-bot"}}