{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/141175692","pull_request_review_id":65349308,"id":141175692,"diff_hunk":"@@ -45,7 +45,7 @@ stdenv.mkDerivation {\n       libjpeg libpng libtiff\n     ]\n \n-    ++ lib.optional mesaSupported mesa\n+    ++ lib.optional (mesaSupported && !stdenv.isDarwin) mesa","path":"pkgs/development/libraries/qt-5/5.9/qtbase/default.nix","position":5,"original_position":5,"commit_id":"4e7d3762adc192ff8753219ec1a4ecfac347d084","original_commit_id":"4e7d3762adc192ff8753219ec1a4ecfac347d084","user":{"login":"LnL7","id":689294,"avatar_url":"https://avatars2.githubusercontent.com/u/689294?v=4","gravatar_id":"","url":"https://api.github.com/users/LnL7","html_url":"https://github.com/LnL7","followers_url":"https://api.github.com/users/LnL7/followers","following_url":"https://api.github.com/users/LnL7/following{/other_user}","gists_url":"https://api.github.com/users/LnL7/gists{/gist_id}","starred_url":"https://api.github.com/users/LnL7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LnL7/subscriptions","organizations_url":"https://api.github.com/users/LnL7/orgs","repos_url":"https://api.github.com/users/LnL7/repos","events_url":"https://api.github.com/users/LnL7/events{/privacy}","received_events_url":"https://api.github.com/users/LnL7/received_events","type":"User","site_admin":false},"body":"This already defaults to false on darwin.","created_at":"2017-09-26T20:34:53Z","updated_at":"2017-09-26T20:35:07Z","html_url":"https://github.com/NixOS/nixpkgs/pull/29812#discussion_r141175692","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/141175692"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29812#discussion_r141175692"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812","id":143164579,"html_url":"https://github.com/NixOS/nixpkgs/pull/29812","diff_url":"https://github.com/NixOS/nixpkgs/pull/29812.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/29812.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29812","number":29812,"state":"open","locked":false,"title":"qt59.qtbase: fix darwin build so qtdeclarative can build","user":{"login":"j-hao","id":2193354,"avatar_url":"https://avatars2.githubusercontent.com/u/2193354?v=4","gravatar_id":"","url":"https://api.github.com/users/j-hao","html_url":"https://github.com/j-hao","followers_url":"https://api.github.com/users/j-hao/followers","following_url":"https://api.github.com/users/j-hao/following{/other_user}","gists_url":"https://api.github.com/users/j-hao/gists{/gist_id}","starred_url":"https://api.github.com/users/j-hao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-hao/subscriptions","organizations_url":"https://api.github.com/users/j-hao/orgs","repos_url":"https://api.github.com/users/j-hao/repos","events_url":"https://api.github.com/users/j-hao/events{/privacy}","received_events_url":"https://api.github.com/users/j-hao/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nAll changes are for Darwin: move sed command to patch files; disable mesa; fix OpenGL and AGL header files path. qtdeclarative and qtwebkit can be built\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] macOS\r\n   - [ ] Linux\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-09-26T15:14:19Z","updated_at":"2017-09-26T20:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b0586dd3486bc31bfb3b3a247d895d2d5c0c02a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29812/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4e7d3762adc192ff8753219ec1a4ecfac347d084","head":{"label":"j-hao:master","ref":"master","sha":"4e7d3762adc192ff8753219ec1a4ecfac347d084","user":{"login":"j-hao","id":2193354,"avatar_url":"https://avatars2.githubusercontent.com/u/2193354?v=4","gravatar_id":"","url":"https://api.github.com/users/j-hao","html_url":"https://github.com/j-hao","followers_url":"https://api.github.com/users/j-hao/followers","following_url":"https://api.github.com/users/j-hao/following{/other_user}","gists_url":"https://api.github.com/users/j-hao/gists{/gist_id}","starred_url":"https://api.github.com/users/j-hao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-hao/subscriptions","organizations_url":"https://api.github.com/users/j-hao/orgs","repos_url":"https://api.github.com/users/j-hao/repos","events_url":"https://api.github.com/users/j-hao/events{/privacy}","received_events_url":"https://api.github.com/users/j-hao/received_events","type":"User","site_admin":false},"repo":{"id":60224914,"name":"nixpkgs","full_name":"j-hao/nixpkgs","owner":{"login":"j-hao","id":2193354,"avatar_url":"https://avatars2.githubusercontent.com/u/2193354?v=4","gravatar_id":"","url":"https://api.github.com/users/j-hao","html_url":"https://github.com/j-hao","followers_url":"https://api.github.com/users/j-hao/followers","following_url":"https://api.github.com/users/j-hao/following{/other_user}","gists_url":"https://api.github.com/users/j-hao/gists{/gist_id}","starred_url":"https://api.github.com/users/j-hao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-hao/subscriptions","organizations_url":"https://api.github.com/users/j-hao/orgs","repos_url":"https://api.github.com/users/j-hao/repos","events_url":"https://api.github.com/users/j-hao/events{/privacy}","received_events_url":"https://api.github.com/users/j-hao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j-hao/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/j-hao/nixpkgs","forks_url":"https://api.github.com/repos/j-hao/nixpkgs/forks","keys_url":"https://api.github.com/repos/j-hao/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j-hao/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j-hao/nixpkgs/teams","hooks_url":"https://api.github.com/repos/j-hao/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/j-hao/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/j-hao/nixpkgs/events","assignees_url":"https://api.github.com/repos/j-hao/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/j-hao/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/j-hao/nixpkgs/tags","blobs_url":"https://api.github.com/repos/j-hao/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j-hao/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j-hao/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/j-hao/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j-hao/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/j-hao/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/j-hao/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/j-hao/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/j-hao/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/j-hao/nixpkgs/subscription","commits_url":"https://api.github.com/repos/j-hao/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/j-hao/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/j-hao/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/j-hao/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/j-hao/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/j-hao/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j-hao/nixpkgs/merges","archive_url":"https://api.github.com/repos/j-hao/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j-hao/nixpkgs/downloads","issues_url":"https://api.github.com/repos/j-hao/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/j-hao/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/j-hao/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/j-hao/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j-hao/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/j-hao/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/j-hao/nixpkgs/deployments","created_at":"2016-06-02T02:07:56Z","updated_at":"2016-06-02T02:08:22Z","pushed_at":"2017-09-24T14:47:12Z","git_url":"git://github.com/j-hao/nixpkgs.git","ssh_url":"git@github.com:j-hao/nixpkgs.git","clone_url":"https://github.com/j-hao/nixpkgs.git","svn_url":"https://github.com/j-hao/nixpkgs","homepage":null,"size":558855,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"05d79c03ec36f8d49d1e2bf2b750c3943c348377","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-09-26T20:28:28Z","pushed_at":"2017-09-26T20:31:14Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":594278,"stargazers_count":1896,"watchers_count":1896,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2252,"mirror_url":null,"open_issues_count":2349,"forks":2252,"open_issues":2349,"watchers":1896,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29812"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29812"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29812/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29812/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4e7d3762adc192ff8753219ec1a4ecfac347d084"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LnL7"}}