{"action":"created","issue":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2702","repository_url":"https://api.github.com/repos/STEllAR-GROUP/hpx","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2702/labels{/name}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2702/comments","events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2702/events","html_url":"https://github.com/STEllAR-GROUP/hpx/issues/2702","id":236691139,"number":2702,"title":"STEllAR-GROUP/Vc slower than VCv1 possibly due to wrong instructions generated","user":{"login":"DavidPfander-UniStuttgart","id":13567426,"avatar_url":"https://avatars2.githubusercontent.com/u/13567426?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidPfander-UniStuttgart","html_url":"https://github.com/DavidPfander-UniStuttgart","followers_url":"https://api.github.com/users/DavidPfander-UniStuttgart/followers","following_url":"https://api.github.com/users/DavidPfander-UniStuttgart/following{/other_user}","gists_url":"https://api.github.com/users/DavidPfander-UniStuttgart/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidPfander-UniStuttgart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidPfander-UniStuttgart/subscriptions","organizations_url":"https://api.github.com/users/DavidPfander-UniStuttgart/orgs","repos_url":"https://api.github.com/users/DavidPfander-UniStuttgart/repos","events_url":"https://api.github.com/users/DavidPfander-UniStuttgart/events{/privacy}","received_events_url":"https://api.github.com/users/DavidPfander-UniStuttgart/received_events","type":"User","site_admin":false},"labels":[{"id":11450887,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels/category:%20core","name":"category: core","color":"02e10c","default":false},{"id":12923282,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels/type:%20compatibility%20issue","name":"type: compatibility issue","color":"e10c02","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/26","html_url":"https://github.com/STEllAR-GROUP/hpx/milestone/26","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/26/labels","id":2254928,"number":26,"title":"1.1.0","description":"","creator":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars2.githubusercontent.com/u/568063?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"open_issues":126,"closed_issues":99,"state":"open","created_at":"2017-01-16T14:53:21Z","updated_at":"2017-06-19T18:18:35Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2017-06-18T00:01:40Z","updated_at":"2017-06-20T06:40:48Z","closed_at":null,"body":"I'm observing significantly lower performance with VCv2 than with VCv1, performance of OctoTiger is approximately halved. To me it looks like the wrong instructions are generated as I'm seeing too many scalar mov ops (vmovsd instructions). I enabled AVX1/2 and FMA.\r\n\r\nPossible reason for the observed problem might be that I'm compiling on a AMD Zen machine. I had to add a few lines to make Vc's cmake recognize it. That is in the following path.\r\n\r\n```\r\nFrom 9713208e013c895bc20e02fc9c6b9d583a31608f Mon Sep 17 00:00:00 2001\r\nFrom: fire <fire@element.com>\r\nDate: Sun, 18 Jun 2017 01:47:33 +0200\r\nSubject: [PATCH] Added support switches for AMD Zen (copied from haswell)\r\n\r\n---\r\n cmake/OptimizeForArchitecture.cmake | 13 ++++++++++---\r\n 1 file changed, 10 insertions(+), 3 deletions(-)\r\n\r\ndiff --git a/cmake/OptimizeForArchitecture.cmake b/cmake/OptimizeForArchitecture.cmake\r\nindex 594dfd54..63724a97 100644\r\n--- a/cmake/OptimizeForArchitecture.cmake\r\n+++ b/cmake/OptimizeForArchitecture.cmake\r\n@@ -152,8 +152,10 @@ macro(OFA_AutodetectX86)\r\n             list(APPEND _available_vector_units_list \"sse\" \"sse2\" \"sse3\")\r\n          endif(_cpu_model GREATER 2)\r\n       endif(_cpu_family EQUAL 6)\r\n-   elseif(_vendor_id STREQUAL \"AuthenticAMD\")\r\n-      if(_cpu_family EQUAL 22) # 16h\r\n+    elseif(_vendor_id STREQUAL \"AuthenticAMD\")\r\n+      if(_cpu_family EQUAL 23) # 17h\r\n+         set(TARGET_ARCHITECTURE \"zen\")\r\n+      elseif(_cpu_family EQUAL 22) # 16h\r\n          set(TARGET_ARCHITECTURE \"AMD 16h\")\r\n       elseif(_cpu_family EQUAL 21) # 15h\r\n          if(_cpu_model LESS 2)\r\n@@ -315,6 +317,11 @@ macro(OFA_HandleX86Options)\r\n    elseif(TARGET_ARCHITECTURE STREQUAL \"AMD 14h\")\r\n       list(APPEND _march_flag_list \"btver1\")\r\n       list(APPEND _available_vector_units_list \"sse\" \"sse2\" \"sse3\" \"ssse3\" \"sse4a\")\r\n+   elseif(TARGET_ARCHITECTURE STREQUAL \"zen\")\r\n+      list(APPEND _march_flag_list \"znver1\")\r\n+      list(APPEND _available_vector_units_list \"sse\" \"sse2\" \"sse3\" \"ssse3\" \"sse4.1\" \"sse4.2\" \"avx\")\r\n+      list(APPEND _available_vector_units_list \"rdrnd\" \"f16c\")\r\n+      list(APPEND _available_vector_units_list \"avx2\" \"fma\" \"bmi\" \"bmi2\")\r\n    elseif(TARGET_ARCHITECTURE STREQUAL \"piledriver\")\r\n       list(APPEND _march_flag_list \"bdver2\")\r\n       list(APPEND _march_flag_list \"bdver1\")\r\n@@ -546,7 +553,7 @@ Other supported values are: \\\"none\\\", \\\"generic\\\", \\\"core\\\", \\\"merom\\\" (65nm Cor\r\n \\\"haswell\\\", \\\"broadwell\\\", \\\"skylake\\\", \\\"skylake-xeon\\\", \\\"cannonlake\\\", \\\"silvermont\\\", \\\r\n \\\"goldmont\\\", \\\"knl\\\" (Knights Landing), \\\"atom\\\", \\\"k8\\\", \\\"k8-sse3\\\", \\\"barcelona\\\", \\\r\n \\\"istanbul\\\", \\\"magny-cours\\\", \\\"bulldozer\\\", \\\"interlagos\\\", \\\"piledriver\\\", \\\r\n-\\\"AMD 14h\\\", \\\"AMD 16h\\\".\")\r\n+\\\"AMD 14h\\\", \\\"AMD 16h\\\", \\\"AMD 17h\\\".\")\r\n    elseif(\"${CMAKE_SYSTEM_PROCESSOR}\" MATCHES \"(arm|aarch32|aarch64)\")\r\n       set(TARGET_ARCHITECTURE \"auto\" CACHE STRING \"CPU architecture to optimize for. \\\r\n Using an incorrect setting here can result in crashes of the resulting binary because of invalid instructions used. \\\r\n-- \r\n2.11.0\r\n```"},"comment":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/comments/309659356","html_url":"https://github.com/STEllAR-GROUP/hpx/issues/2702#issuecomment-309659356","issue_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2702","id":309659356,"user":{"login":"mattkretz","id":3306474,"avatar_url":"https://avatars2.githubusercontent.com/u/3306474?v=3","gravatar_id":"","url":"https://api.github.com/users/mattkretz","html_url":"https://github.com/mattkretz","followers_url":"https://api.github.com/users/mattkretz/followers","following_url":"https://api.github.com/users/mattkretz/following{/other_user}","gists_url":"https://api.github.com/users/mattkretz/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkretz/subscriptions","organizations_url":"https://api.github.com/users/mattkretz/orgs","repos_url":"https://api.github.com/users/mattkretz/repos","events_url":"https://api.github.com/users/mattkretz/events{/privacy}","received_events_url":"https://api.github.com/users/mattkretz/received_events","type":"User","site_admin":false},"created_at":"2017-06-20T06:40:48Z","updated_at":"2017-06-20T06:40:48Z","body":"Merged in mkretz/abs_sqrt branch now. After CI gives a green light, I'll merge it back to mkretz/datapar."}}
{"actor":{"display_login":"mattkretz"}}