{"action":"created","issue":{"url":"https://api.github.com/repos/coredns/coredns/issues/1174","repository_url":"https://api.github.com/repos/coredns/coredns","labels_url":"https://api.github.com/repos/coredns/coredns/issues/1174/labels{/name}","comments_url":"https://api.github.com/repos/coredns/coredns/issues/1174/comments","events_url":"https://api.github.com/repos/coredns/coredns/issues/1174/events","html_url":"https://github.com/coredns/coredns/pull/1174","id":268532382,"number":1174,"title":"plugin/dnstap: shadow some constants","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-10-25T20:10:11Z","updated_at":"2017-10-25T20:39:54Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/coredns/coredns/pulls/1174","html_url":"https://github.com/coredns/coredns/pull/1174","diff_url":"https://github.com/coredns/coredns/pull/1174.diff","patch_url":"https://github.com/coredns/coredns/pull/1174.patch"},"body":"This is needed to not reference a vendored package so out-of-tree\r\nplugins don't get type errors when referencing this code, like:\r\n\r\n../../miekg/forward/dnstap.go:27:16: cannot use \"github.com/dnstap/golang-dnstap\".SocketProtocol_UDP (type \"github.com/dnstap/golang-dnstap\".SocketProtocol) as type \"github.com/coredns/coredns/vendor/github.com/dnstap/golang-dnstap\".SocketProtocol in assignment\r\n../../miekg/forward/dnstap.go:28:5: undefined: t\r\n../../miekg/forward/dnstap.go:29:17: cannot use \"github.com/dnstap/golang-dnstap\".SocketProtocol_TCP (type \"github.com/dnstap/golang-dnstap\".SocketProtocol) as type \"github.com/coredns/coredns/vendor/github.com/dnstap/golang-dnstap\".SocketProtocol in assignment\r\n../../miekg/forward/dnstap.go:36:46: cannot use \"github.com/dnstap/golang-dnstap\".Message_FORWARDER_QUERY (type \"github.com/dnstap/golang-dnstap\".Message_Type) as type \"github.com/coredns/coredns/vendor/github.com/dnstap/golang-dnstap\".Message_Type in argument to b.Data.ToOutsideQuery\r\n../../miekg/forward/dnstap.go:46:47: cannot use \"github.com/dnstap/golang-dnstap\".Message_FORWARDER_RESPONSE (type \"github.com/dnstap/golang-dnstap\".Message_Type) as type \"github.com/coredns/coredns/vendor/github.com/dnstap/golang-dnstap\".Message_Type in argument to b.Data.ToOutsideResponse\r\n\r\nAlso had to rename them in CamelCase to make golint happy.\r\n\r\n<!--\r\nThank you for contributing to CoreDNS!\r\n\r\nPlease provide the following information to help us make the most of your pull request:\r\n-->\r\n\r\n### 1. What does this pull request do?\r\n\r\n\r\n### 2. Which issues (if any) are related?\r\n\r\n\r\n### 3. Which documentation changes (if any) need to be made?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/coredns/coredns/issues/comments/339464187","html_url":"https://github.com/coredns/coredns/pull/1174#issuecomment-339464187","issue_url":"https://api.github.com/repos/coredns/coredns/issues/1174","id":339464187,"user":{"login":"johnbelamaric","id":9468083,"avatar_url":"https://avatars2.githubusercontent.com/u/9468083?v=4","gravatar_id":"","url":"https://api.github.com/users/johnbelamaric","html_url":"https://github.com/johnbelamaric","followers_url":"https://api.github.com/users/johnbelamaric/followers","following_url":"https://api.github.com/users/johnbelamaric/following{/other_user}","gists_url":"https://api.github.com/users/johnbelamaric/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbelamaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbelamaric/subscriptions","organizations_url":"https://api.github.com/users/johnbelamaric/orgs","repos_url":"https://api.github.com/users/johnbelamaric/repos","events_url":"https://api.github.com/users/johnbelamaric/events{/privacy}","received_events_url":"https://api.github.com/users/johnbelamaric/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T20:39:54Z","updated_at":"2017-10-25T20:39:54Z","author_association":"OWNER","body":"It's all @chrisohaver not me :)"}}
{"actor":{"display_login":"johnbelamaric"}}