{"action":"created","comment":{"url":"https://api.github.com/repos/hull-ships/hull-sql/pulls/comments/126274115","pull_request_review_id":48748748,"id":126274115,"diff_hunk":"@@ -0,0 +1,40 @@\n+import _ from \"lodash\";\n+\n+export function parseConnectionConfig(settings) {","path":"server/lib/utils/connstr-mssql.js","position":3,"original_position":3,"commit_id":"6a54954afcea92366fe144d104adf172748a5625","original_commit_id":"6a54954afcea92366fe144d104adf172748a5625","user":{"login":"sbellity","id":4250,"avatar_url":"https://avatars2.githubusercontent.com/u/4250?v=3","gravatar_id":"","url":"https://api.github.com/users/sbellity","html_url":"https://github.com/sbellity","followers_url":"https://api.github.com/users/sbellity/followers","following_url":"https://api.github.com/users/sbellity/following{/other_user}","gists_url":"https://api.github.com/users/sbellity/gists{/gist_id}","starred_url":"https://api.github.com/users/sbellity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbellity/subscriptions","organizations_url":"https://api.github.com/users/sbellity/orgs","repos_url":"https://api.github.com/users/sbellity/repos","events_url":"https://api.github.com/users/sbellity/events{/privacy}","received_events_url":"https://api.github.com/users/sbellity/received_events","type":"User","site_admin":false},"body":"I see that the pg adapter uses the `connstr-mysql` which is confusing","created_at":"2017-07-08T04:12:19Z","updated_at":"2017-07-08T04:12:19Z","html_url":"https://github.com/hull-ships/hull-sql/pull/25#discussion_r126274115","pull_request_url":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/hull-ships/hull-sql/pulls/comments/126274115"},"html":{"href":"https://github.com/hull-ships/hull-sql/pull/25#discussion_r126274115"},"pull_request":{"href":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25","id":129515489,"html_url":"https://github.com/hull-ships/hull-sql/pull/25","diff_url":"https://github.com/hull-ships/hull-sql/pull/25.diff","patch_url":"https://github.com/hull-ships/hull-sql/pull/25.patch","issue_url":"https://api.github.com/repos/hull-ships/hull-sql/issues/25","number":25,"state":"open","locked":false,"title":"Feature MSSQL","user":{"login":"SMK1085","id":4313076,"avatar_url":"https://avatars1.githubusercontent.com/u/4313076?v=3","gravatar_id":"","url":"https://api.github.com/users/SMK1085","html_url":"https://github.com/SMK1085","followers_url":"https://api.github.com/users/SMK1085/followers","following_url":"https://api.github.com/users/SMK1085/following{/other_user}","gists_url":"https://api.github.com/users/SMK1085/gists{/gist_id}","starred_url":"https://api.github.com/users/SMK1085/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SMK1085/subscriptions","organizations_url":"https://api.github.com/users/SMK1085/orgs","repos_url":"https://api.github.com/users/SMK1085/repos","events_url":"https://api.github.com/users/SMK1085/events{/privacy}","received_events_url":"https://api.github.com/users/SMK1085/received_events","type":"User","site_admin":false},"body":"@sbellity, I have built the MSSQL adapter based on the develop branch as discussed.\r\nI have also completely overhauled the settings page and the /assets/readme.md to have proper documentation. \r\nThere was a minor issue on the client side code, the `original_query` always returned `undefined` so I was not able to run the `Import everything`. I have wrapped the line of code it in a self-enclosing function which solved the issue.","created_at":"2017-07-08T03:43:27Z","updated_at":"2017-07-08T04:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9f778bd8c6d7653eaf7b40132ef10f6f4227d48","assignee":null,"assignees":[],"requested_reviewers":[{"login":"unity","id":9458,"avatar_url":"https://avatars0.githubusercontent.com/u/9458?v=3","gravatar_id":"","url":"https://api.github.com/users/unity","html_url":"https://github.com/unity","followers_url":"https://api.github.com/users/unity/followers","following_url":"https://api.github.com/users/unity/following{/other_user}","gists_url":"https://api.github.com/users/unity/gists{/gist_id}","starred_url":"https://api.github.com/users/unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unity/subscriptions","organizations_url":"https://api.github.com/users/unity/orgs","repos_url":"https://api.github.com/users/unity/repos","events_url":"https://api.github.com/users/unity/events{/privacy}","received_events_url":"https://api.github.com/users/unity/received_events","type":"User","site_admin":false},{"login":"michaloo","id":1029525,"avatar_url":"https://avatars1.githubusercontent.com/u/1029525?v=3","gravatar_id":"","url":"https://api.github.com/users/michaloo","html_url":"https://github.com/michaloo","followers_url":"https://api.github.com/users/michaloo/followers","following_url":"https://api.github.com/users/michaloo/following{/other_user}","gists_url":"https://api.github.com/users/michaloo/gists{/gist_id}","starred_url":"https://api.github.com/users/michaloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaloo/subscriptions","organizations_url":"https://api.github.com/users/michaloo/orgs","repos_url":"https://api.github.com/users/michaloo/repos","events_url":"https://api.github.com/users/michaloo/events{/privacy}","received_events_url":"https://api.github.com/users/michaloo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25/commits","review_comments_url":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25/comments","review_comment_url":"https://api.github.com/repos/hull-ships/hull-sql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hull-ships/hull-sql/issues/25/comments","statuses_url":"https://api.github.com/repos/hull-ships/hull-sql/statuses/6a54954afcea92366fe144d104adf172748a5625","head":{"label":"hull-ships:feature/mssql2","ref":"feature/mssql2","sha":"6a54954afcea92366fe144d104adf172748a5625","user":{"login":"hull-ships","id":8874713,"avatar_url":"https://avatars1.githubusercontent.com/u/8874713?v=3","gravatar_id":"","url":"https://api.github.com/users/hull-ships","html_url":"https://github.com/hull-ships","followers_url":"https://api.github.com/users/hull-ships/followers","following_url":"https://api.github.com/users/hull-ships/following{/other_user}","gists_url":"https://api.github.com/users/hull-ships/gists{/gist_id}","starred_url":"https://api.github.com/users/hull-ships/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hull-ships/subscriptions","organizations_url":"https://api.github.com/users/hull-ships/orgs","repos_url":"https://api.github.com/users/hull-ships/repos","events_url":"https://api.github.com/users/hull-ships/events{/privacy}","received_events_url":"https://api.github.com/users/hull-ships/received_events","type":"Organization","site_admin":false},"repo":{"id":76575728,"name":"hull-sql","full_name":"hull-ships/hull-sql","owner":{"login":"hull-ships","id":8874713,"avatar_url":"https://avatars1.githubusercontent.com/u/8874713?v=3","gravatar_id":"","url":"https://api.github.com/users/hull-ships","html_url":"https://github.com/hull-ships","followers_url":"https://api.github.com/users/hull-ships/followers","following_url":"https://api.github.com/users/hull-ships/following{/other_user}","gists_url":"https://api.github.com/users/hull-ships/gists{/gist_id}","starred_url":"https://api.github.com/users/hull-ships/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hull-ships/subscriptions","organizations_url":"https://api.github.com/users/hull-ships/orgs","repos_url":"https://api.github.com/users/hull-ships/repos","events_url":"https://api.github.com/users/hull-ships/events{/privacy}","received_events_url":"https://api.github.com/users/hull-ships/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hull-ships/hull-sql","description":"SQL Importer Ship","fork":false,"url":"https://api.github.com/repos/hull-ships/hull-sql","forks_url":"https://api.github.com/repos/hull-ships/hull-sql/forks","keys_url":"https://api.github.com/repos/hull-ships/hull-sql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hull-ships/hull-sql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hull-ships/hull-sql/teams","hooks_url":"https://api.github.com/repos/hull-ships/hull-sql/hooks","issue_events_url":"https://api.github.com/repos/hull-ships/hull-sql/issues/events{/number}","events_url":"https://api.github.com/repos/hull-ships/hull-sql/events","assignees_url":"https://api.github.com/repos/hull-ships/hull-sql/assignees{/user}","branches_url":"https://api.github.com/repos/hull-ships/hull-sql/branches{/branch}","tags_url":"https://api.github.com/repos/hull-ships/hull-sql/tags","blobs_url":"https://api.github.com/repos/hull-ships/hull-sql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hull-ships/hull-sql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hull-ships/hull-sql/git/refs{/sha}","trees_url":"https://api.github.com/repos/hull-ships/hull-sql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hull-ships/hull-sql/statuses/{sha}","languages_url":"https://api.github.com/repos/hull-ships/hull-sql/languages","stargazers_url":"https://api.github.com/repos/hull-ships/hull-sql/stargazers","contributors_url":"https://api.github.com/repos/hull-ships/hull-sql/contributors","subscribers_url":"https://api.github.com/repos/hull-ships/hull-sql/subscribers","subscription_url":"https://api.github.com/repos/hull-ships/hull-sql/subscription","commits_url":"https://api.github.com/repos/hull-ships/hull-sql/commits{/sha}","git_commits_url":"https://api.github.com/repos/hull-ships/hull-sql/git/commits{/sha}","comments_url":"https://api.github.com/repos/hull-ships/hull-sql/comments{/number}","issue_comment_url":"https://api.github.com/repos/hull-ships/hull-sql/issues/comments{/number}","contents_url":"https://api.github.com/repos/hull-ships/hull-sql/contents/{+path}","compare_url":"https://api.github.com/repos/hull-ships/hull-sql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hull-ships/hull-sql/merges","archive_url":"https://api.github.com/repos/hull-ships/hull-sql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hull-ships/hull-sql/downloads","issues_url":"https://api.github.com/repos/hull-ships/hull-sql/issues{/number}","pulls_url":"https://api.github.com/repos/hull-ships/hull-sql/pulls{/number}","milestones_url":"https://api.github.com/repos/hull-ships/hull-sql/milestones{/number}","notifications_url":"https://api.github.com/repos/hull-ships/hull-sql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hull-ships/hull-sql/labels{/name}","releases_url":"https://api.github.com/repos/hull-ships/hull-sql/releases{/id}","deployments_url":"https://api.github.com/repos/hull-ships/hull-sql/deployments","created_at":"2016-12-15T16:18:50Z","updated_at":"2017-01-25T15:37:58Z","pushed_at":"2017-07-08T03:43:27Z","git_url":"git://github.com/hull-ships/hull-sql.git","ssh_url":"git@github.com:hull-ships/hull-sql.git","clone_url":"https://github.com/hull-ships/hull-sql.git","svn_url":"https://github.com/hull-ships/hull-sql","homepage":"https://hull-sql.herokuapp.com","size":999,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"hull-ships:develop","ref":"develop","sha":"12f9c94ff3ceb0d8af8f2611016f9337f17e2ba9","user":{"login":"hull-ships","id":8874713,"avatar_url":"https://avatars1.githubusercontent.com/u/8874713?v=3","gravatar_id":"","url":"https://api.github.com/users/hull-ships","html_url":"https://github.com/hull-ships","followers_url":"https://api.github.com/users/hull-ships/followers","following_url":"https://api.github.com/users/hull-ships/following{/other_user}","gists_url":"https://api.github.com/users/hull-ships/gists{/gist_id}","starred_url":"https://api.github.com/users/hull-ships/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hull-ships/subscriptions","organizations_url":"https://api.github.com/users/hull-ships/orgs","repos_url":"https://api.github.com/users/hull-ships/repos","events_url":"https://api.github.com/users/hull-ships/events{/privacy}","received_events_url":"https://api.github.com/users/hull-ships/received_events","type":"Organization","site_admin":false},"repo":{"id":76575728,"name":"hull-sql","full_name":"hull-ships/hull-sql","owner":{"login":"hull-ships","id":8874713,"avatar_url":"https://avatars1.githubusercontent.com/u/8874713?v=3","gravatar_id":"","url":"https://api.github.com/users/hull-ships","html_url":"https://github.com/hull-ships","followers_url":"https://api.github.com/users/hull-ships/followers","following_url":"https://api.github.com/users/hull-ships/following{/other_user}","gists_url":"https://api.github.com/users/hull-ships/gists{/gist_id}","starred_url":"https://api.github.com/users/hull-ships/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hull-ships/subscriptions","organizations_url":"https://api.github.com/users/hull-ships/orgs","repos_url":"https://api.github.com/users/hull-ships/repos","events_url":"https://api.github.com/users/hull-ships/events{/privacy}","received_events_url":"https://api.github.com/users/hull-ships/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hull-ships/hull-sql","description":"SQL Importer Ship","fork":false,"url":"https://api.github.com/repos/hull-ships/hull-sql","forks_url":"https://api.github.com/repos/hull-ships/hull-sql/forks","keys_url":"https://api.github.com/repos/hull-ships/hull-sql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hull-ships/hull-sql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hull-ships/hull-sql/teams","hooks_url":"https://api.github.com/repos/hull-ships/hull-sql/hooks","issue_events_url":"https://api.github.com/repos/hull-ships/hull-sql/issues/events{/number}","events_url":"https://api.github.com/repos/hull-ships/hull-sql/events","assignees_url":"https://api.github.com/repos/hull-ships/hull-sql/assignees{/user}","branches_url":"https://api.github.com/repos/hull-ships/hull-sql/branches{/branch}","tags_url":"https://api.github.com/repos/hull-ships/hull-sql/tags","blobs_url":"https://api.github.com/repos/hull-ships/hull-sql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hull-ships/hull-sql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hull-ships/hull-sql/git/refs{/sha}","trees_url":"https://api.github.com/repos/hull-ships/hull-sql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hull-ships/hull-sql/statuses/{sha}","languages_url":"https://api.github.com/repos/hull-ships/hull-sql/languages","stargazers_url":"https://api.github.com/repos/hull-ships/hull-sql/stargazers","contributors_url":"https://api.github.com/repos/hull-ships/hull-sql/contributors","subscribers_url":"https://api.github.com/repos/hull-ships/hull-sql/subscribers","subscription_url":"https://api.github.com/repos/hull-ships/hull-sql/subscription","commits_url":"https://api.github.com/repos/hull-ships/hull-sql/commits{/sha}","git_commits_url":"https://api.github.com/repos/hull-ships/hull-sql/git/commits{/sha}","comments_url":"https://api.github.com/repos/hull-ships/hull-sql/comments{/number}","issue_comment_url":"https://api.github.com/repos/hull-ships/hull-sql/issues/comments{/number}","contents_url":"https://api.github.com/repos/hull-ships/hull-sql/contents/{+path}","compare_url":"https://api.github.com/repos/hull-ships/hull-sql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hull-ships/hull-sql/merges","archive_url":"https://api.github.com/repos/hull-ships/hull-sql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hull-ships/hull-sql/downloads","issues_url":"https://api.github.com/repos/hull-ships/hull-sql/issues{/number}","pulls_url":"https://api.github.com/repos/hull-ships/hull-sql/pulls{/number}","milestones_url":"https://api.github.com/repos/hull-ships/hull-sql/milestones{/number}","notifications_url":"https://api.github.com/repos/hull-ships/hull-sql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hull-ships/hull-sql/labels{/name}","releases_url":"https://api.github.com/repos/hull-ships/hull-sql/releases{/id}","deployments_url":"https://api.github.com/repos/hull-ships/hull-sql/deployments","created_at":"2016-12-15T16:18:50Z","updated_at":"2017-01-25T15:37:58Z","pushed_at":"2017-07-08T03:43:27Z","git_url":"git://github.com/hull-ships/hull-sql.git","ssh_url":"git@github.com:hull-ships/hull-sql.git","clone_url":"https://github.com/hull-ships/hull-sql.git","svn_url":"https://github.com/hull-ships/hull-sql","homepage":"https://hull-sql.herokuapp.com","size":999,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25"},"html":{"href":"https://github.com/hull-ships/hull-sql/pull/25"},"issue":{"href":"https://api.github.com/repos/hull-ships/hull-sql/issues/25"},"comments":{"href":"https://api.github.com/repos/hull-ships/hull-sql/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/hull-ships/hull-sql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hull-ships/hull-sql/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/hull-ships/hull-sql/statuses/6a54954afcea92366fe144d104adf172748a5625"}}}}
{"actor":{"display_login":"sbellity"}}