{"action":"created","issue":{"url":"https://api.github.com/repos/mlewe/BlossomV.jl/issues/10","repository_url":"https://api.github.com/repos/mlewe/BlossomV.jl","labels_url":"https://api.github.com/repos/mlewe/BlossomV.jl/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/mlewe/BlossomV.jl/issues/10/comments","events_url":"https://api.github.com/repos/mlewe/BlossomV.jl/issues/10/events","html_url":"https://github.com/mlewe/BlossomV.jl/pull/10","id":231901381,"number":10,"title":"matching with floats","user":{"login":"CarloLucibello","id":7014210,"avatar_url":"https://avatars2.githubusercontent.com/u/7014210?v=3","gravatar_id":"","url":"https://api.github.com/users/CarloLucibello","html_url":"https://github.com/CarloLucibello","followers_url":"https://api.github.com/users/CarloLucibello/followers","following_url":"https://api.github.com/users/CarloLucibello/following{/other_user}","gists_url":"https://api.github.com/users/CarloLucibello/gists{/gist_id}","starred_url":"https://api.github.com/users/CarloLucibello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarloLucibello/subscriptions","organizations_url":"https://api.github.com/users/CarloLucibello/orgs","repos_url":"https://api.github.com/users/CarloLucibello/repos","events_url":"https://api.github.com/users/CarloLucibello/events{/privacy}","received_events_url":"https://api.github.com/users/CarloLucibello/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-05-28T23:10:26Z","updated_at":"2017-06-11T07:41:26Z","closed_at":"2017-06-09T15:11:11Z","pull_request":{"url":"https://api.github.com/repos/mlewe/BlossomV.jl/pulls/10","html_url":"https://github.com/mlewe/BlossomV.jl/pull/10","diff_url":"https://github.com/mlewe/BlossomV.jl/pull/10.diff","patch_url":"https://github.com/mlewe/BlossomV.jl/pull/10.patch"},"body":"Hi @mlewe,\r\nI found myself in need of a matching algorithm for non-integer weights. I implemented in Erdos and LightGraphs a crappy conversion from floats to integers through linear transform and rounding, but sometimes it yields the wrong results. \r\n\r\nBlossomV supports real weights, although it cautions against possible precision errors. It would be possible for BlossomV.jl to compile and support both the integer and the floating versions of BlossomV? A possible solution would be to parametrize with Matching{T}, and dispatch on the base of T to the appropriate ccall\r\n\r\nFor the time being I just switched entirely to the floating point version of the code, to check if it works\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mlewe/BlossomV.jl/issues/comments/307612334","html_url":"https://github.com/mlewe/BlossomV.jl/pull/10#issuecomment-307612334","issue_url":"https://api.github.com/repos/mlewe/BlossomV.jl/issues/10","id":307612334,"user":{"login":"CarloLucibello","id":7014210,"avatar_url":"https://avatars2.githubusercontent.com/u/7014210?v=3","gravatar_id":"","url":"https://api.github.com/users/CarloLucibello","html_url":"https://github.com/CarloLucibello","followers_url":"https://api.github.com/users/CarloLucibello/followers","following_url":"https://api.github.com/users/CarloLucibello/following{/other_user}","gists_url":"https://api.github.com/users/CarloLucibello/gists{/gist_id}","starred_url":"https://api.github.com/users/CarloLucibello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarloLucibello/subscriptions","organizations_url":"https://api.github.com/users/CarloLucibello/orgs","repos_url":"https://api.github.com/users/CarloLucibello/repos","events_url":"https://api.github.com/users/CarloLucibello/events{/privacy}","received_events_url":"https://api.github.com/users/CarloLucibello/received_events","type":"User","site_admin":false},"created_at":"2017-06-11T07:41:26Z","updated_at":"2017-06-11T07:41:26Z","body":"Thanks @mlewe @oxinabox "}}
{"actor":{"display_login":"CarloLucibello"}}