{"action":"opened","number":5912,"pull_request":{"url":"https://api.github.com/repos/owncloud/client/pulls/5912","id":131081031,"html_url":"https://github.com/owncloud/client/pull/5912","diff_url":"https://github.com/owncloud/client/pull/5912.diff","patch_url":"https://github.com/owncloud/client/pull/5912.patch","issue_url":"https://api.github.com/repos/owncloud/client/issues/5912","number":5912,"state":"open","locked":false,"title":"OAuth: Fix refresh of token after expiration","user":{"login":"ogoffart","id":959326,"avatar_url":"https://avatars3.githubusercontent.com/u/959326?v=4","gravatar_id":"","url":"https://api.github.com/users/ogoffart","html_url":"https://github.com/ogoffart","followers_url":"https://api.github.com/users/ogoffart/followers","following_url":"https://api.github.com/users/ogoffart/following{/other_user}","gists_url":"https://api.github.com/users/ogoffart/gists{/gist_id}","starred_url":"https://api.github.com/users/ogoffart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogoffart/subscriptions","organizations_url":"https://api.github.com/users/ogoffart/orgs","repos_url":"https://api.github.com/users/ogoffart/repos","events_url":"https://api.github.com/users/ogoffart/events{/privacy}","received_events_url":"https://api.github.com/users/ogoffart/received_events","type":"User","site_admin":false},"body":"Before commit d3b00532b1dd9f44cc606e6738b53345c37582cf,\r\nfetchFromKeychain was called everytime we detect that the creds are\r\ninvalid (in AccountState::slotInvalidCredentials)\r\nBut since that commit, AccountState was calling askFromUser directly,\r\nbreaking the refresh of the token.\r\n\r\nSo I made sure AccountState::slotInvalidCredentials still calls\r\nrefreshAccessToken.\r\n\r\nAnother change that was made was too be sure to clear the cookies\r\nin HttpCredentials::invalidateToken even when we are only clearing the\r\naccess_token. That's because the session with a cookie may stay valid\r\nlonger than the access_token","created_at":"2017-07-18T13:01:47Z","updated_at":"2017-07-18T13:01:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"ckamm","id":833306,"avatar_url":"https://avatars0.githubusercontent.com/u/833306?v=4","gravatar_id":"","url":"https://api.github.com/users/ckamm","html_url":"https://github.com/ckamm","followers_url":"https://api.github.com/users/ckamm/followers","following_url":"https://api.github.com/users/ckamm/following{/other_user}","gists_url":"https://api.github.com/users/ckamm/gists{/gist_id}","starred_url":"https://api.github.com/users/ckamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckamm/subscriptions","organizations_url":"https://api.github.com/users/ckamm/orgs","repos_url":"https://api.github.com/users/ckamm/repos","events_url":"https://api.github.com/users/ckamm/events{/privacy}","received_events_url":"https://api.github.com/users/ckamm/received_events","type":"User","site_admin":false},{"login":"jturcotte","id":839935,"avatar_url":"https://avatars0.githubusercontent.com/u/839935?v=4","gravatar_id":"","url":"https://api.github.com/users/jturcotte","html_url":"https://github.com/jturcotte","followers_url":"https://api.github.com/users/jturcotte/followers","following_url":"https://api.github.com/users/jturcotte/following{/other_user}","gists_url":"https://api.github.com/users/jturcotte/gists{/gist_id}","starred_url":"https://api.github.com/users/jturcotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jturcotte/subscriptions","organizations_url":"https://api.github.com/users/jturcotte/orgs","repos_url":"https://api.github.com/users/jturcotte/repos","events_url":"https://api.github.com/users/jturcotte/events{/privacy}","received_events_url":"https://api.github.com/users/jturcotte/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/client/pulls/5912/commits","review_comments_url":"https://api.github.com/repos/owncloud/client/pulls/5912/comments","review_comment_url":"https://api.github.com/repos/owncloud/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/client/issues/5912/comments","statuses_url":"https://api.github.com/repos/owncloud/client/statuses/848ae95df393eb44a16f40ffd23dc95321abc48f","head":{"label":"owncloud:oauth2","ref":"oauth2","sha":"848ae95df393eb44a16f40ffd23dc95321abc48f","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550623,"name":"client","full_name":"owncloud/client","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/client","description":":computer: Desktop Syncing Client for ownCloud","fork":false,"url":"https://api.github.com/repos/owncloud/client","forks_url":"https://api.github.com/repos/owncloud/client/forks","keys_url":"https://api.github.com/repos/owncloud/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/client/teams","hooks_url":"https://api.github.com/repos/owncloud/client/hooks","issue_events_url":"https://api.github.com/repos/owncloud/client/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/client/events","assignees_url":"https://api.github.com/repos/owncloud/client/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/client/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/client/tags","blobs_url":"https://api.github.com/repos/owncloud/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/client/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/client/languages","stargazers_url":"https://api.github.com/repos/owncloud/client/stargazers","contributors_url":"https://api.github.com/repos/owncloud/client/contributors","subscribers_url":"https://api.github.com/repos/owncloud/client/subscribers","subscription_url":"https://api.github.com/repos/owncloud/client/subscription","commits_url":"https://api.github.com/repos/owncloud/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/client/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/client/merges","archive_url":"https://api.github.com/repos/owncloud/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/client/downloads","issues_url":"https://api.github.com/repos/owncloud/client/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/client/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/client/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/client/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/client/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/client/deployments","created_at":"2012-08-25T10:44:53Z","updated_at":"2017-07-18T05:02:25Z","pushed_at":"2017-07-18T13:01:13Z","git_url":"git://github.com/owncloud/client.git","ssh_url":"git@github.com:owncloud/client.git","clone_url":"https://github.com/owncloud/client.git","svn_url":"https://github.com/owncloud/client","homepage":"","size":138823,"stargazers_count":847,"watchers_count":847,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":492,"mirror_url":null,"open_issues_count":559,"forks":492,"open_issues":559,"watchers":847,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"d9813dbc90ca6b1f7c14b941f7b1c9aff019ff89","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550623,"name":"client","full_name":"owncloud/client","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/client","description":":computer: Desktop Syncing Client for ownCloud","fork":false,"url":"https://api.github.com/repos/owncloud/client","forks_url":"https://api.github.com/repos/owncloud/client/forks","keys_url":"https://api.github.com/repos/owncloud/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/client/teams","hooks_url":"https://api.github.com/repos/owncloud/client/hooks","issue_events_url":"https://api.github.com/repos/owncloud/client/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/client/events","assignees_url":"https://api.github.com/repos/owncloud/client/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/client/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/client/tags","blobs_url":"https://api.github.com/repos/owncloud/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/client/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/client/languages","stargazers_url":"https://api.github.com/repos/owncloud/client/stargazers","contributors_url":"https://api.github.com/repos/owncloud/client/contributors","subscribers_url":"https://api.github.com/repos/owncloud/client/subscribers","subscription_url":"https://api.github.com/repos/owncloud/client/subscription","commits_url":"https://api.github.com/repos/owncloud/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/client/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/client/merges","archive_url":"https://api.github.com/repos/owncloud/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/client/downloads","issues_url":"https://api.github.com/repos/owncloud/client/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/client/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/client/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/client/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/client/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/client/deployments","created_at":"2012-08-25T10:44:53Z","updated_at":"2017-07-18T05:02:25Z","pushed_at":"2017-07-18T13:01:13Z","git_url":"git://github.com/owncloud/client.git","ssh_url":"git@github.com:owncloud/client.git","clone_url":"https://github.com/owncloud/client.git","svn_url":"https://github.com/owncloud/client","homepage":"","size":138823,"stargazers_count":847,"watchers_count":847,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":492,"mirror_url":null,"open_issues_count":559,"forks":492,"open_issues":559,"watchers":847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/client/pulls/5912"},"html":{"href":"https://github.com/owncloud/client/pull/5912"},"issue":{"href":"https://api.github.com/repos/owncloud/client/issues/5912"},"comments":{"href":"https://api.github.com/repos/owncloud/client/issues/5912/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/client/pulls/5912/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/client/pulls/5912/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/client/statuses/848ae95df393eb44a16f40ffd23dc95321abc48f"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"ogoffart"}}