{"action":"created","issue":{"url":"https://api.github.com/repos/docker/cli/issues/596","repository_url":"https://api.github.com/repos/docker/cli","labels_url":"https://api.github.com/repos/docker/cli/issues/596/labels{/name}","comments_url":"https://api.github.com/repos/docker/cli/issues/596/comments","events_url":"https://api.github.com/repos/docker/cli/issues/596/events","html_url":"https://github.com/docker/cli/pull/596","id":262720971,"number":596,"title":"Display filter json in image-list in debug mode","user":{"login":"ripcurld0","id":2453279,"avatar_url":"https://avatars0.githubusercontent.com/u/2453279?v=4","gravatar_id":"","url":"https://api.github.com/users/ripcurld0","html_url":"https://github.com/ripcurld0","followers_url":"https://api.github.com/users/ripcurld0/followers","following_url":"https://api.github.com/users/ripcurld0/following{/other_user}","gists_url":"https://api.github.com/users/ripcurld0/gists{/gist_id}","starred_url":"https://api.github.com/users/ripcurld0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripcurld0/subscriptions","organizations_url":"https://api.github.com/users/ripcurld0/orgs","repos_url":"https://api.github.com/users/ripcurld0/repos","events_url":"https://api.github.com/users/ripcurld0/events{/privacy}","received_events_url":"https://api.github.com/users/ripcurld0/received_events","type":"User","site_admin":false},"labels":[{"id":585916069,"url":"https://api.github.com/repos/docker/cli/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-04T09:26:21Z","updated_at":"2017-10-04T09:30:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/596","html_url":"https://github.com/docker/cli/pull/596","diff_url":"https://github.com/docker/cli/pull/596.diff","patch_url":"https://github.com/docker/cli/pull/596.patch"},"body":"**- What I did**\r\ncloses #556\r\n\r\nProvide a debug message stating the filter JSON that's going to be sent.\r\n\r\nThis should make it less confusing if someone uses \"docker images\" instead of \"docker image\" as mentioned in #556.\r\n\r\n**- How I did it**\r\n\r\n* Used the `debug` package to determine whether debug mode is true.\r\n* Convert the `filters` argument into JSON using `filters.ToJSON`\r\n* Printing it using `fmt`\r\n\r\n**- How to verify it**\r\n\r\n```\r\n$ docker -D images ls\r\nFILTERS  {\"reference\":{\"ls\":true}}\r\nREPOSITORY          TAG                 IMAGE ID            CREATED             SIZE\r\n```\r\n\r\n**- Description for the changelog**\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/docker/cli/issues/comments/334100565","html_url":"https://github.com/docker/cli/pull/596#issuecomment-334100565","issue_url":"https://api.github.com/repos/docker/cli/issues/596","id":334100565,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-10-04T09:30:14Z","updated_at":"2017-10-04T09:30:14Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/docker/cli/pull/596?src=pr&el=h1) Report\n> Merging [#596](https://codecov.io/gh/docker/cli/pull/596?src=pr&el=desc) into [master](https://codecov.io/gh/docker/cli/commit/f7ef79228ecef5360aa75968fa94ebe13f921f0a?src=pr&el=desc) will **decrease** coverage by `0.01%`.\n> The diff coverage is `45.45%`.\n\n\n\n```diff\n@@            Coverage Diff            @@\n##           master    #596      +/-   ##\n=========================================\n- Coverage   49.41%   49.4%   -0.02%     \n=========================================\n  Files         208     208              \n  Lines       17186   17192       +6     \n=========================================\n  Hits         8493    8493              \n- Misses       8261    8266       +5     \n- Partials      432     433       +1\n```\n\n"}}
{"actor":{"display_login":"codecov-io"}}