{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/154683667","pull_request_review_id":80882345,"id":154683667,"diff_hunk":"@@ -223,10 +223,11 @@ def _wait_for_network(self):\n         logger.info('Network connection established')\n \n     def _inject_snapcraft(self):\n-        if common.is_snap():\n-            # Because of https://bugs.launchpad.net/snappy/+bug/1628289\n-            self._container_run(['apt-get', 'install', 'squashfuse', '-y'])\n+        # Because of https://bugs.launchpad.net/snappy/+bug/1628289\n+        # Needed to run snapcraft as a snap and build-snaps\n+        self._container_run(['apt-get', 'install', 'squashfuse', '-y'])","path":"snapcraft/internal/lxd/_containerbuild.py","position":9,"original_position":9,"commit_id":"3182be60ffe73e7fc8f2a47ac2d2b44fcda6a2ab","original_commit_id":"3182be60ffe73e7fc8f2a47ac2d2b44fcda6a2ab","user":{"login":"elopio","id":617831,"avatar_url":"https://avatars3.githubusercontent.com/u/617831?v=4","gravatar_id":"","url":"https://api.github.com/users/elopio","html_url":"https://github.com/elopio","followers_url":"https://api.github.com/users/elopio/followers","following_url":"https://api.github.com/users/elopio/following{/other_user}","gists_url":"https://api.github.com/users/elopio/gists{/gist_id}","starred_url":"https://api.github.com/users/elopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopio/subscriptions","organizations_url":"https://api.github.com/users/elopio/orgs","repos_url":"https://api.github.com/users/elopio/repos","events_url":"https://api.github.com/users/elopio/events{/privacy}","received_events_url":"https://api.github.com/users/elopio/received_events","type":"User","site_admin":false},"body":"Now this is not only related to snapcraft. Shouldn't we move it to another function? `inject_snapcraft` doesn't sound like the right place for this to be.","created_at":"2017-12-04T15:39:48Z","updated_at":"2017-12-04T15:39:48Z","html_url":"https://github.com/snapcore/snapcraft/pull/1786#discussion_r154683667","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/154683667"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/1786#discussion_r154683667"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786","id":156192310,"html_url":"https://github.com/snapcore/snapcraft/pull/1786","diff_url":"https://github.com/snapcore/snapcraft/pull/1786.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/1786.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/1786","number":1786,"state":"open","locked":false,"title":"lxd: always install squashfuse","user":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?\r\n- [x] Have you successfully run `./runtests.sh static`?\r\n- [x] Have you successfully run `./runtests.sh unit`?\r\n\r\n-----\r\nFixes: [bug 730561](https://bugs.launchpad.net/snapcraft/+bug/1730561)","created_at":"2017-12-04T13:07:46Z","updated_at":"2017-12-04T15:39:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b20ff82a5160407aeeb118a0286f827c8db4af5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/1786/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/3182be60ffe73e7fc8f2a47ac2d2b44fcda6a2ab","head":{"label":"kalikiana:lxd-always-install-squashfuse","ref":"lxd-always-install-squashfuse","sha":"3182be60ffe73e7fc8f2a47ac2d2b44fcda6a2ab","user":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"repo":{"id":73799360,"name":"snapcraft","full_name":"kalikiana/snapcraft","owner":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalikiana/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/kalikiana/snapcraft","forks_url":"https://api.github.com/repos/kalikiana/snapcraft/forks","keys_url":"https://api.github.com/repos/kalikiana/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalikiana/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalikiana/snapcraft/teams","hooks_url":"https://api.github.com/repos/kalikiana/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/kalikiana/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/kalikiana/snapcraft/events","assignees_url":"https://api.github.com/repos/kalikiana/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/kalikiana/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/kalikiana/snapcraft/tags","blobs_url":"https://api.github.com/repos/kalikiana/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalikiana/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalikiana/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalikiana/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalikiana/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/kalikiana/snapcraft/languages","stargazers_url":"https://api.github.com/repos/kalikiana/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/kalikiana/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/kalikiana/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/kalikiana/snapcraft/subscription","commits_url":"https://api.github.com/repos/kalikiana/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalikiana/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalikiana/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalikiana/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalikiana/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/kalikiana/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalikiana/snapcraft/merges","archive_url":"https://api.github.com/repos/kalikiana/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalikiana/snapcraft/downloads","issues_url":"https://api.github.com/repos/kalikiana/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/kalikiana/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/kalikiana/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/kalikiana/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalikiana/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/kalikiana/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/kalikiana/snapcraft/deployments","created_at":"2016-11-15T09:45:46Z","updated_at":"2016-11-15T09:45:48Z","pushed_at":"2017-12-04T13:16:42Z","git_url":"git://github.com/kalikiana/snapcraft.git","ssh_url":"git@github.com:kalikiana/snapcraft.git","clone_url":"https://github.com/kalikiana/snapcraft.git","svn_url":"https://github.com/kalikiana/snapcraft","homepage":null,"size":8660,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"5c76509ffe8f6c3254fe5537010da16c497006f8","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2017-12-04T07:27:21Z","pushed_at":"2017-12-04T14:07:44Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":null,"size":8224,"stargazers_count":451,"watchers_count":451,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":220,"open_issues":100,"watchers":451,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/1786"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/1786"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/1786/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1786/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/3182be60ffe73e7fc8f2a47ac2d2b44fcda6a2ab"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"elopio"}}