{"action":"created","issue":{"url":"https://api.github.com/repos/spring/spring/issues/304","repository_url":"https://api.github.com/repos/spring/spring","labels_url":"https://api.github.com/repos/spring/spring/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/spring/spring/issues/304/comments","events_url":"https://api.github.com/repos/spring/spring/issues/304/events","html_url":"https://github.com/spring/spring/pull/304","id":216715507,"number":304,"title":"Added SetUnitWaterline LUA function","user":{"login":"sanguinariojoe","id":1668392,"avatar_url":"https://avatars1.githubusercontent.com/u/1668392?v=3","gravatar_id":"","url":"https://api.github.com/users/sanguinariojoe","html_url":"https://github.com/sanguinariojoe","followers_url":"https://api.github.com/users/sanguinariojoe/followers","following_url":"https://api.github.com/users/sanguinariojoe/following{/other_user}","gists_url":"https://api.github.com/users/sanguinariojoe/gists{/gist_id}","starred_url":"https://api.github.com/users/sanguinariojoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanguinariojoe/subscriptions","organizations_url":"https://api.github.com/users/sanguinariojoe/orgs","repos_url":"https://api.github.com/users/sanguinariojoe/repos","events_url":"https://api.github.com/users/sanguinariojoe/events{/privacy}","received_events_url":"https://api.github.com/users/sanguinariojoe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-03-24T09:29:58Z","updated_at":"2017-03-27T16:39:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spring/spring/pulls/304","html_url":"https://github.com/spring/spring/pull/304","diff_url":"https://github.com/spring/spring/pull/304.diff","patch_url":"https://github.com/spring/spring/pull/304.patch"},"body":"Right now, in order to create a submarine which may become surfaced, or even submerged at different levels, you must create several objects with different waterline parameters, morphing/replacing the unit each time. Hence, adding the LUA function SetUnitWaterline may become very convenient.\r\n\r\nAs far as I know, this patch should not affect the current games at all (since the waterline parameter is taken from the unit definition at PreInit() method)"},"comment":{"url":"https://api.github.com/repos/spring/spring/issues/comments/289510722","html_url":"https://github.com/spring/spring/pull/304#issuecomment-289510722","issue_url":"https://api.github.com/repos/spring/spring/issues/304","id":289510722,"user":{"login":"rtri","id":13068780,"avatar_url":"https://avatars1.githubusercontent.com/u/13068780?v=3","gravatar_id":"","url":"https://api.github.com/users/rtri","html_url":"https://github.com/rtri","followers_url":"https://api.github.com/users/rtri/followers","following_url":"https://api.github.com/users/rtri/following{/other_user}","gists_url":"https://api.github.com/users/rtri/gists{/gist_id}","starred_url":"https://api.github.com/users/rtri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtri/subscriptions","organizations_url":"https://api.github.com/users/rtri/orgs","repos_url":"https://api.github.com/users/rtri/repos","events_url":"https://api.github.com/users/rtri/events{/privacy}","received_events_url":"https://api.github.com/users/rtri/received_events","type":"User","site_admin":false},"created_at":"2017-03-27T16:39:45Z","updated_at":"2017-03-27T16:39:45Z","body":">> `floatOnWater` has been removed from such function\r\n\r\nNot quite, `floatOnWater` has never been *settable* through these functions.\r\n\r\n>> However `StaticMoveType` cannot be controlled by the methods provided in `MoveCtrl`\r\n\r\nNot really important so long as `waterline` becomes a member of `AMoveType`, you can either add a `SetStaticMoveTypeData` callout or just ignore that for now."}}
{"actor":{"display_login":"rtri"}}