{"action":"closed","issue":{"url":"https://api.github.com/repos/nyaatrap/renpy-utilities/issues/2","repository_url":"https://api.github.com/repos/nyaatrap/renpy-utilities","labels_url":"https://api.github.com/repos/nyaatrap/renpy-utilities/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/nyaatrap/renpy-utilities/issues/2/comments","events_url":"https://api.github.com/repos/nyaatrap/renpy-utilities/issues/2/events","html_url":"https://github.com/nyaatrap/renpy-utilities/issues/2","id":224225950,"number":2,"title":"save seen_events","user":{"login":"Clef777","id":15218404,"avatar_url":"https://avatars2.githubusercontent.com/u/15218404?v=3","gravatar_id":"","url":"https://api.github.com/users/Clef777","html_url":"https://github.com/Clef777","followers_url":"https://api.github.com/users/Clef777/followers","following_url":"https://api.github.com/users/Clef777/following{/other_user}","gists_url":"https://api.github.com/users/Clef777/gists{/gist_id}","starred_url":"https://api.github.com/users/Clef777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clef777/subscriptions","organizations_url":"https://api.github.com/users/Clef777/orgs","repos_url":"https://api.github.com/users/Clef777/repos","events_url":"https://api.github.com/users/Clef777/events{/privacy}","received_events_url":"https://api.github.com/users/Clef777/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-25T18:09:46Z","updated_at":"2017-04-27T01:17:21Z","closed_at":"2017-04-27T01:17:21Z","body":"At the moment the seen_events are saved in the function move_pos().\r\n\r\nBut I think that this is not a good thing to do:\r\n1) I have found a couple of case where I tried to use move_pos before having an event.\r\n2) in the crawl_loop/adventure_loop you use the move_pos after the event is called, this way you save the events seen. But if i jump to another label while inside the called event (for example to exit the dungeon) I will not reach the move_pos() function and so I will not save the event as a \"seen\" event.\r\n3) having the move function work as a save is not inuitive for people that have to use it\r\n\r\nSuggestion: just delete the save line from the move_pos() function and add it in the crawl_loop/adventure_loop before every event call.\r\n"}}
{"actor":{"display_login":"nyaatrap"}}