{"push_id":2038044487,"size":72,"distinct_size":1,"ref":"refs/heads/ggtea","head":"6ae182aa01ec3ef39d5e96f235716848bc136851","before":"e2e800a5d7fb2169e9b58e0641058bc1e4167e9b","commits":[{"sha":"f303a954e68ef47d636c6af109e81caed33ef58c","author":{"name":"Akihiko Odaki","email":"2eea7030d3baafb2788fe259726fa53fed7f8300@stu.hosei.ac.jp"},"message":"Remove aria-label of status content (#5195)\n\naria-label contained body of status with content warning, which should be\r\nhidden by default. Remove the label for the case and other cases due to\r\nconsistency.","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/f303a954e68ef47d636c6af109e81caed33ef58c"},{"sha":"eb6ec3d0689bfb56da7a5889929e16c409144127","author":{"name":"Yamagishi Kazutoshi","email":"7f7d7ef3fe10e12972f6f7b22f1ddc04a8b59ed7@desire.sh"},"message":"Add missing Japanese translations (#5193)\n\n* yarn manage:translations\r\n\r\n* Add Japanese translations for #5170\r\n\r\n* Add Japanese translations for #5123\r\n\r\n* Add Japanese translations for #5046\r\n\r\n* Add Japanese translations for #5099\r\n\r\n* Add Japanese translations for #5161\r\n\r\n* \"項目\" -> \"絵文字\"","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/eb6ec3d0689bfb56da7a5889929e16c409144127"},{"sha":"ecacb15cd50609fb3d749ecac89835a43255fb34","author":{"name":"Yamagishi Kazutoshi","email":"7f7d7ef3fe10e12972f6f7b22f1ddc04a8b59ed7@desire.sh"},"message":"Add placeholder text color to form of media attachments (#5196)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/ecacb15cd50609fb3d749ecac89835a43255fb34"},{"sha":"334a446313d504ef9bb80ce213be32729aa3d2b8","author":{"name":"Nolan Lawson","email":"87a5c04b7295623c6d3f68288c55a08817db7be4@nolanlawson.com"},"message":"Fix emoji sequence bug in substring-trie (#5191)\n\nFixes #5188","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/334a446313d504ef9bb80ce213be32729aa3d2b8"},{"sha":"875d943c189afe9887200f357d916a9f8fd19fe8","author":{"name":"PFM","email":"616e881177e53541ea47e5917a60deb2554e079d@eyesight.jp"},"message":"Add pagination in media modal (#4343)\n\n* Add pagination in media modal\r\n\r\n* Change array name\r\n\r\n* Add an element class\r\n\r\n* Avoid nested class\r\n\r\n* Pull out the active class\r\n\r\n* Use map instead of forEach\r\n\r\n* Remove parentheses","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/875d943c189afe9887200f357d916a9f8fd19fe8"},{"sha":"82d9ade7a6abc663b30b3df4ae08a8980d61e233","author":{"name":"Nolan Lawson","email":"87a5c04b7295623c6d3f68288c55a08817db7be4@nolanlawson.com"},"message":"Compress emoji_data_light.js (#5201)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/82d9ade7a6abc663b30b3df4ae08a8980d61e233"},{"sha":"813c5f2f5283ec21c65a7e8c21146c34664f21c3","author":{"name":"Nolan Lawson","email":"87a5c04b7295623c6d3f68288c55a08817db7be4@nolanlawson.com"},"message":"Add spec for emoji_index_light.js (#5199)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/813c5f2f5283ec21c65a7e8c21146c34664f21c3"},{"sha":"e6543d5fc4d4f6ec7020d104e4d2360ee9bd7679","author":{"name":"m4sk1n","email":"b4a5ea001e047040e8c9075b67a268293138da2c@m4sk.in"},"message":"i18n: Update Polish translation (#5202)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/e6543d5fc4d4f6ec7020d104e4d2360ee9bd7679"},{"sha":"dfaa219f8820224d37cd060d253a507111c63460","author":{"name":"ThibG","email":"5a0119cdfb1d8daf5605565d682d57d9e79ce04e@sitedethib.com"},"message":"Fix HTTP responses for salmon and ActivityPub inbox processing (#5200)\n\n* Return sensible HTTP status for ActivityPub inbox processing\r\n\r\n* Return sensible HTTP status for salmon slap processing\r\n\r\n* Return additional information to debug signature verification failures","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/dfaa219f8820224d37cd060d253a507111c63460"},{"sha":"c743b5e1fdb938d52d8c023bb6ef1bf9b397226c","author":{"name":"Eugen Rochko","email":"5e0a22252c57a82386f1cfcf4856a12387fa25f8@zeonfederated.com"},"message":"Fix possible acct: uri usurpation in ActivityPub account discovery (#5208)\n\nSigned-off-by: Eugen Rochko <eugen@zeonfederated.com>","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/c743b5e1fdb938d52d8c023bb6ef1bf9b397226c"},{"sha":"cdd5ef691bcdb25f8c8367698de7e09301ee3528","author":{"name":"Eugen Rochko","email":"5e0a22252c57a82386f1cfcf4856a12387fa25f8@zeonfederated.com"},"message":"Use separate workers to process imports, retry failures (#5207)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/cdd5ef691bcdb25f8c8367698de7e09301ee3528"},{"sha":"ec13cfa4f940e9f9441ceff1f7389bb0e1bd61fb","author":{"name":"Eugen Rochko","email":"5e0a22252c57a82386f1cfcf4856a12387fa25f8@zeonfederated.com"},"message":"When a streaming API status arrives, sort it into conversations (#5206)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/ec13cfa4f940e9f9441ceff1f7389bb0e1bd61fb"},{"sha":"63f097979990bf5ba9db848b8a253056bad781af","author":{"name":"Akihiko Odaki","email":"2eea7030d3baafb2788fe259726fa53fed7f8300@stu.hosei.ac.jp"},"message":"Validate id of ActivityPub representations (#5114)\n\nAdditionally, ActivityPub::FetchRemoteStatusService no longer parses\r\nactivities.\r\nOStatus::Activity::Creation no longer delegates to ActivityPub because\r\nthe provided ActivityPub representations are not signed while OStatus\r\nrepresentations are.","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/63f097979990bf5ba9db848b8a253056bad781af"},{"sha":"291feba6f113588cce4f06206754b31eba60044b","author":{"name":"Eugen Rochko","email":"5e0a22252c57a82386f1cfcf4856a12387fa25f8@zeonfederated.com"},"message":"Follow up to #5172, clean up notifications after mute like after block (#5198)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/291feba6f113588cce4f06206754b31eba60044b"},{"sha":"632178d7543f48f493a63afce0d3c6243aac5fae","author":{"name":"Eugen Rochko","email":"5e0a22252c57a82386f1cfcf4856a12387fa25f8@zeonfederated.com"},"message":"Use own, shorter relative timestamps (#5171)\n\n* Use own, shorter relative timestamps\r\n\r\n* Add acct to title tooltip of display name in statuses\r\n\r\n* Improve i18n of the relative times","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/632178d7543f48f493a63afce0d3c6243aac5fae"},{"sha":"d40c9140e8c02c63b675d9c9a2a44ee20c5a9f31","author":{"name":"Yamagishi Kazutoshi","email":"7f7d7ef3fe10e12972f6f7b22f1ddc04a8b59ed7@desire.sh"},"message":"Fix undefined local variable (regression from #5114) (#5210)","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/d40c9140e8c02c63b675d9c9a2a44ee20c5a9f31"},{"sha":"2076c557c907e118dbafc92170fc9fb0cba597df","author":{"name":"aschmitz","email":"8896d931626fd71b96530471a08e18aea60621fe@gmail.com"},"message":"Configure webpack to poll for changes in development (#5040)\n\n* Configure webpack to poll for changes in development\r\n\r\nVagrant on Linux/macOS hosts shared files via NFS, which doens't\r\nsupport inotify-based watching of files. This tweak makes webpack\r\ncheck for changes every second, and rebuild if necessary. This\r\nremoves the need to restart Foreman every time a frontend file\r\nchanges. Note that rebuilding is still a relatively lengthy\r\nprocess.\r\n\r\nThe polling frequency can be changed to taste.\r\n\r\n* Only poll in Vagrant\r\n\r\nThis tests for the presence of the VAGRANT environment variable to\r\ndetermine whether or not we're in Vagrant. It is set in .env.vagrant,\r\nwhich is set up to be included in the Vagrantfile.","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/2076c557c907e118dbafc92170fc9fb0cba597df"},{"sha":"468523f4ad85f99d78fd341ca4f5fc96f561a533","author":{"name":"aschmitz","email":"8896d931626fd71b96530471a08e18aea60621fe@gmail.com"},"message":"Non-Serial (\"Snowflake\") IDs (#4801)\n\n* Use non-serial IDs\r\n\r\nThis change makes a number of nontrivial tweaks to the data model in\r\nMastodon:\r\n\r\n* All IDs are now 8 byte integers (rather than mixed 4- and 8-byte)\r\n* IDs are now assigned as:\r\n  * Top 6 bytes: millisecond-resolution time from epoch\r\n  * Bottom 2 bytes: serial (within the millisecond) sequence number\r\n  * See /lib/tasks/db.rake's `define_timestamp_id` for details, but\r\n    note that the purpose of these changes is to make it difficult to\r\n    determine the number of objects in a table from the ID of any\r\n    object.\r\n* The Redis sorted set used for the feed will have values used to look\r\n  up toots, rather than scores. This is almost always the same as the\r\n  existing behavior, except in the case of boosted toots. This change\r\n  was made because Redis stores scores as double-precision floats,\r\n  which cannot store the new ID format exactly. Note that this doesn't\r\n  cause problems with sorting/pagination, because ZREVRANGEBYSCORE\r\n  sorts lexicographically when scores are tied. (This will still cause\r\n  sorting issues when the ID gains a new significant digit, but that's\r\n  extraordinarily uncommon.)\r\n\r\nNote a couple of tradeoffs have been made in this commit:\r\n\r\n* lib/tasks/db.rake is used to enforce many/most column constraints,\r\n  because this commit seems likely to take a while to bring upstream.\r\n  Enforcing a post-migrate hook is an easier way to maintain the code\r\n  in the interim.\r\n* Boosted toots will appear in the timeline as many times as they have\r\n  been boosted. This is a tradeoff due to the way the feed is saved in\r\n  Redis at the moment, but will be handled by a future commit.\r\n\r\nThis would effectively close Mastodon's #1059, as it is a\r\nsnowflake-like system of generating IDs. However, given how involved\r\nthe changes were simply within Mastodon, it may have unexpected\r\ninteractions with some clients, if they store IDs as doubles\r\n(or as 4-byte integers). This was a problem that Twitter ran into with\r\ntheir \"snowflake\" transition, particularly in JavaScript clients that\r\ntreated IDs as JS integers, rather than strings. It therefore would be\r\nuseful to test these changes at least in the web interface and popular\r\nclients before pushing them to all users.\r\n\r\n* Fix JavaScript interface with long IDs\r\n\r\nSomewhat predictably, the JS interface handled IDs as numbers, which in\r\nJS are IEEE double-precision floats. This loses some precision when\r\nworking with numbers as large as those generated by the new ID scheme,\r\nso we instead handle them here as strings. This is relatively simple,\r\nand doesn't appear to have caused any problems, but should definitely\r\nbe tested more thoroughly than the built-in tests. Several days of use\r\nappear to support this working properly.\r\n\r\nBREAKING CHANGE:\r\n\r\nThe major(!) change here is that IDs are now returned as strings by the\r\nREST endpoints, rather than as integers. In practice, relatively few\r\nchanges were required to make the existing JS UI work with this change,\r\nbut it will likely hit API clients pretty hard: it's an entirely\r\ndifferent type to consume. (The one API client I tested, Tusky, handles\r\nthis with no problems, however.)\r\n\r\nTwitter ran into this issue when introducing Snowflake IDs, and decided\r\nto instead introduce an `id_str` field in JSON responses. I have opted\r\nto *not* do that, and instead force all IDs to 64-bit integers\r\nrepresented by strings in one go. (I believe Twitter exacerbated their\r\nproblem by rolling out the changes three times: once for statuses, once\r\nfor DMs, and once for user IDs, as well as by leaving an integer ID\r\nvalue in JSON. As they said, \"If you’re using the `id` field with JSON\r\nin a Javascript-related language, there is a very high likelihood that\r\nthe integers will be silently munged by Javascript interpreters. In most\r\ncases, this will result in behavior such as being unable to load or\r\ndelete a specific direct message, because the ID you're sending to the\r\nAPI is different than the actual identifier associated with the\r\nmessage.\" [1]) However, given that this is a significant change for API\r\nusers, alternatives or a transition time may be appropriate.\r\n\r\n1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html\r\n\r\n* Restructure feed pushes/unpushes\r\n\r\nThis was necessary because the previous behavior used Redis zset scores\r\nto identify statuses, but those are IEEE double-precision floats, so we\r\ncan't actually use them to identify all 64-bit IDs. However, it leaves\r\nthe code in a much better state for refactoring reblog handling /\r\ncoalescing.\r\n\r\nFeed-management code has been consolidated in FeedManager, including:\r\n\r\n* BatchedRemoveStatusService no longer directly manipulates feed zsets\r\n* RemoveStatusService no longer directly manipulates feed zsets\r\n* PrecomputeFeedService has moved its logic to FeedManager#populate_feed\r\n\r\n(PrecomputeFeedService largely made lots of calls to FeedManager, but\r\ndidn't follow the normal adding-to-feed process.)\r\n\r\nThis has the effect of unifying all of the feed push/unpush logic in\r\nFeedManager, making it much more tractable to update it in the future.\r\n\r\nDue to some additional checks that must be made during, for example,\r\nbatch status removals, some Redis pipelining has been removed. It does\r\nnot appear that this should cause significantly increased load, but if\r\nnecessary, some optimizations are possible in batch cases. These were\r\nomitted in the pursuit of simplicity, but a batch_push and batch_unpush\r\nwould be possible in the future.\r\n\r\nTests were added to verify that pushes happen under expected conditions,\r\nand to verify reblog behavior (both on pushing and unpushing). In the\r\ncase of unpushing, this includes testing behavior that currently leads\r\nto confusion such as Mastodon's #2817, but this codifies that the\r\nbehavior is currently expected.\r\n\r\n* Rubocop fixes\r\n\r\nI could swear I made these changes already, but I must have lost them\r\nsomewhere along the line.\r\n\r\n* Address review comments\r\n\r\nThis addresses the first two comments from review of this feature:\r\n\r\nhttps://github.com/tootsuite/mastodon/pull/4801#discussion_r139336735\r\nhttps://github.com/tootsuite/mastodon/pull/4801#discussion_r139336931\r\n\r\nThis adds an optional argument to FeedManager#key, the subtype of feed\r\nkey to generate. It also tests to ensure that FeedManager's settings are\r\nsuch that reblogs won't be tracked forever.\r\n\r\n* Hardcode IdToBigints migration columns\r\n\r\nThis addresses a comment during review:\r\nhttps://github.com/tootsuite/mastodon/pull/4801#discussion_r139337452\r\n\r\nThis means we'll need to make sure that all _id columns going forward\r\nare bigints, but that should happen automatically in most cases.\r\n\r\n* Additional fixes for stringified IDs in JSON\r\n\r\nThese should be the last two. These were identified using eslint to try\r\nto identify any plain casts to JavaScript numbers. (Some such casts are\r\nlegitimate, but these were not.)\r\n\r\nAdding the following to .eslintrc.yml will identify casts to numbers:\r\n\r\n~~~\r\n  no-restricted-syntax:\r\n  - warn\r\n  - selector: UnaryExpression[operator='+'] > :not(Literal)\r\n    message: Avoid the use of unary +\r\n  - selector: CallExpression[callee.name='Number']\r\n    message: Casting with Number() may coerce string IDs to numbers\r\n~~~\r\n\r\nThe remaining three casts appear legitimate: two casts to array indices,\r\none in a server to turn an environment variable into a number.\r\n\r\n* Only implement timestamp IDs for Status IDs\r\n\r\nPer discussion in #4801, this is only being merged in for Status IDs at\r\nthis point. We do this in a migration, as there is no longer use for\r\na post-migration hook. We keep the initialization of the timestamp_id\r\nfunction as a Rake task, as it is also needed after db:schema:load (as\r\ndb/schema.rb doesn't store Postgres functions).\r\n\r\n* Change internal streaming payloads to stringified IDs as well\r\n\r\nThis is equivalent to 591a9af356faf2d5c7e66e3ec715502796c875cd from\r\n#5019, with an extra change for the addition to FeedManager#unpush.\r\n\r\n* Ensure we have a status_id_seq sequence\r\n\r\nApparently this is not a given when specifying a custom ID function,\r\nso now we ensure it gets created. This uses the generic version of this\r\nfunction to more easily support adding additional tables with timestamp\r\nIDs in the future, although it would be possible to cut this down to a\r\nless generic version if necessary. It is only run during db:schema:load\r\nor the relevant migration, so the overhead is extraordinarily minimal.\r\n\r\n* Transition reblogs to new Redis format\r\n\r\nThis provides a one-way migration to transition old Redis reblog entries\r\ninto the new format, with a separate tracking entry for reblogs.\r\n\r\nIt is not invertible because doing so could (if timestamp IDs are used)\r\nrequire a database query for each status in each users' feed, which is\r\nlikely to be a significant toll on major instances.\r\n\r\n* Address review comments from @akihikodaki\r\n\r\nNo functional changes.\r\n\r\n* Additional review changes\r\n\r\n* Heredoc cleanup\r\n\r\n* Run db:schema:load hooks for test in development\r\n\r\nThis matches the behavior in Rails'\r\nActiveRecord::Tasks::DatabaseTasks.each_current_configuration, which\r\nwould otherwise break `rake db:setup` in development.\r\n\r\nIt also moves some functionality out to a library, which will be a good\r\nplace to put additional related functionality in the near future.","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/468523f4ad85f99d78fd341ca4f5fc96f561a533"},{"sha":"0e1b0f2747af373e3d51251337f40bfff13ef160","author":{"name":"ThibG","email":"5a0119cdfb1d8daf5605565d682d57d9e79ce04e@sitedethib.com"},"message":"Check Webfinger-returned author URI even when not redirected (#5213)\n\nThe whole point of verified_webfinger? is to check the WebFinger-discoverable\r\nURI maps back to the known author URI. This was not actually verified if the\r\nfirst Webfinger request was not a redirection.","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/0e1b0f2747af373e3d51251337f40bfff13ef160"},{"sha":"178f718a9b1cab57fbd9df511abe56533f12e129","author":{"name":"Yamagishi Kazutoshi","email":"7f7d7ef3fe10e12972f6f7b22f1ddc04a8b59ed7@desire.sh"},"message":"Separate notifications preferences from general preferences (#4447)\n\n* Separate notifications preferences from general preferences\r\n\r\n* Refine settings/notifications/show\r\n\r\n* remove preferences.notifications","distinct":false,"url":"https://api.github.com/repos/clworld/mastodon/commits/178f718a9b1cab57fbd9df511abe56533f12e129"}]}
{"actor":{"display_login":"clworld"}}