{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments/135273299","pull_request_review_id":58669979,"id":135273299,"diff_hunk":"@@ -1096,19 +1109,29 @@ func (va *ValidationAuthorityImpl) validateCAASet(caaSet *CAASet) (present, vali\n \treturn true, false\n }\n \n+func isIssueSpace(r rune) bool {\n+\treturn r == '\\t' || r == ' '\n+}\n+\n // Given a CAA record, assume that the Value is in the issue/issuewild format,\n // that is, a domain name with zero or more additional key-value parameters.\n // Returns the domain name, which may be \"\" (unsatisfiable).","path":"va/va.go","position":73,"original_position":73,"commit_id":"cdf0a33206b1d31bf7f8a5002f5b08fd02e10b7c","original_commit_id":"cdf0a33206b1d31bf7f8a5002f5b08fd02e10b7c","user":{"login":"cpu","id":292650,"avatar_url":"https://avatars1.githubusercontent.com/u/292650?v=4","gravatar_id":"","url":"https://api.github.com/users/cpu","html_url":"https://github.com/cpu","followers_url":"https://api.github.com/users/cpu/followers","following_url":"https://api.github.com/users/cpu/following{/other_user}","gists_url":"https://api.github.com/users/cpu/gists{/gist_id}","starred_url":"https://api.github.com/users/cpu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpu/subscriptions","organizations_url":"https://api.github.com/users/cpu/orgs","repos_url":"https://api.github.com/users/cpu/repos","events_url":"https://api.github.com/users/cpu/events{/privacy}","received_events_url":"https://api.github.com/users/cpu/received_events","type":"User","site_admin":false},"body":"This comment will need to be updated with the new return value you added.","created_at":"2017-08-25T14:33:59Z","updated_at":"2017-08-25T14:37:02Z","html_url":"https://github.com/letsencrypt/boulder/pull/3003#discussion_r135273299","pull_request_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments/135273299"},"html":{"href":"https://github.com/letsencrypt/boulder/pull/3003#discussion_r135273299"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003","id":137331008,"html_url":"https://github.com/letsencrypt/boulder/pull/3003","diff_url":"https://github.com/letsencrypt/boulder/pull/3003.diff","patch_url":"https://github.com/letsencrypt/boulder/pull/3003.patch","issue_url":"https://api.github.com/repos/letsencrypt/boulder/issues/3003","number":3003,"state":"open","locked":false,"title":"Add CAA parameter to restrict challenge type","user":{"login":"lukaslihotzki","id":10326063,"avatar_url":"https://avatars0.githubusercontent.com/u/10326063?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaslihotzki","html_url":"https://github.com/lukaslihotzki","followers_url":"https://api.github.com/users/lukaslihotzki/followers","following_url":"https://api.github.com/users/lukaslihotzki/following{/other_user}","gists_url":"https://api.github.com/users/lukaslihotzki/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaslihotzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaslihotzki/subscriptions","organizations_url":"https://api.github.com/users/lukaslihotzki/orgs","repos_url":"https://api.github.com/users/lukaslihotzki/repos","events_url":"https://api.github.com/users/lukaslihotzki/events{/privacy}","received_events_url":"https://api.github.com/users/lukaslihotzki/received_events","type":"User","site_admin":false},"body":"This commit adds CAA `issue` paramter parsing and the `challenge` parameter to permit a single challenge type only. By setting `challenge=dns-01`, the nameserver keeps control over every issued certificate.","created_at":"2017-08-23T22:19:40Z","updated_at":"2017-08-25T14:37:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e4206351706a904efd8c3e118a5a5e58d5d7c37","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/issues/3003/comments","statuses_url":"https://api.github.com/repos/letsencrypt/boulder/statuses/cdf0a33206b1d31bf7f8a5002f5b08fd02e10b7c","head":{"label":"lukaslihotzki:master","ref":"master","sha":"cdf0a33206b1d31bf7f8a5002f5b08fd02e10b7c","user":{"login":"lukaslihotzki","id":10326063,"avatar_url":"https://avatars0.githubusercontent.com/u/10326063?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaslihotzki","html_url":"https://github.com/lukaslihotzki","followers_url":"https://api.github.com/users/lukaslihotzki/followers","following_url":"https://api.github.com/users/lukaslihotzki/following{/other_user}","gists_url":"https://api.github.com/users/lukaslihotzki/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaslihotzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaslihotzki/subscriptions","organizations_url":"https://api.github.com/users/lukaslihotzki/orgs","repos_url":"https://api.github.com/users/lukaslihotzki/repos","events_url":"https://api.github.com/users/lukaslihotzki/events{/privacy}","received_events_url":"https://api.github.com/users/lukaslihotzki/received_events","type":"User","site_admin":false},"repo":{"id":101228211,"name":"boulder","full_name":"lukaslihotzki/boulder","owner":{"login":"lukaslihotzki","id":10326063,"avatar_url":"https://avatars0.githubusercontent.com/u/10326063?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaslihotzki","html_url":"https://github.com/lukaslihotzki","followers_url":"https://api.github.com/users/lukaslihotzki/followers","following_url":"https://api.github.com/users/lukaslihotzki/following{/other_user}","gists_url":"https://api.github.com/users/lukaslihotzki/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaslihotzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaslihotzki/subscriptions","organizations_url":"https://api.github.com/users/lukaslihotzki/orgs","repos_url":"https://api.github.com/users/lukaslihotzki/repos","events_url":"https://api.github.com/users/lukaslihotzki/events{/privacy}","received_events_url":"https://api.github.com/users/lukaslihotzki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukaslihotzki/boulder","description":"An ACME-based CA, written in Go.","fork":true,"url":"https://api.github.com/repos/lukaslihotzki/boulder","forks_url":"https://api.github.com/repos/lukaslihotzki/boulder/forks","keys_url":"https://api.github.com/repos/lukaslihotzki/boulder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukaslihotzki/boulder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukaslihotzki/boulder/teams","hooks_url":"https://api.github.com/repos/lukaslihotzki/boulder/hooks","issue_events_url":"https://api.github.com/repos/lukaslihotzki/boulder/issues/events{/number}","events_url":"https://api.github.com/repos/lukaslihotzki/boulder/events","assignees_url":"https://api.github.com/repos/lukaslihotzki/boulder/assignees{/user}","branches_url":"https://api.github.com/repos/lukaslihotzki/boulder/branches{/branch}","tags_url":"https://api.github.com/repos/lukaslihotzki/boulder/tags","blobs_url":"https://api.github.com/repos/lukaslihotzki/boulder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukaslihotzki/boulder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukaslihotzki/boulder/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukaslihotzki/boulder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukaslihotzki/boulder/statuses/{sha}","languages_url":"https://api.github.com/repos/lukaslihotzki/boulder/languages","stargazers_url":"https://api.github.com/repos/lukaslihotzki/boulder/stargazers","contributors_url":"https://api.github.com/repos/lukaslihotzki/boulder/contributors","subscribers_url":"https://api.github.com/repos/lukaslihotzki/boulder/subscribers","subscription_url":"https://api.github.com/repos/lukaslihotzki/boulder/subscription","commits_url":"https://api.github.com/repos/lukaslihotzki/boulder/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukaslihotzki/boulder/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukaslihotzki/boulder/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukaslihotzki/boulder/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukaslihotzki/boulder/contents/{+path}","compare_url":"https://api.github.com/repos/lukaslihotzki/boulder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukaslihotzki/boulder/merges","archive_url":"https://api.github.com/repos/lukaslihotzki/boulder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukaslihotzki/boulder/downloads","issues_url":"https://api.github.com/repos/lukaslihotzki/boulder/issues{/number}","pulls_url":"https://api.github.com/repos/lukaslihotzki/boulder/pulls{/number}","milestones_url":"https://api.github.com/repos/lukaslihotzki/boulder/milestones{/number}","notifications_url":"https://api.github.com/repos/lukaslihotzki/boulder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukaslihotzki/boulder/labels{/name}","releases_url":"https://api.github.com/repos/lukaslihotzki/boulder/releases{/id}","deployments_url":"https://api.github.com/repos/lukaslihotzki/boulder/deployments","created_at":"2017-08-23T21:55:13Z","updated_at":"2017-08-23T21:55:17Z","pushed_at":"2017-08-25T07:11:59Z","git_url":"git://github.com/lukaslihotzki/boulder.git","ssh_url":"git@github.com:lukaslihotzki/boulder.git","clone_url":"https://github.com/lukaslihotzki/boulder.git","svn_url":"https://github.com/lukaslihotzki/boulder","homepage":null,"size":25670,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"d87851076804e23df7fd99d998954bd0da148445","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars0.githubusercontent.com/u/9289019?v=4","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":28283593,"name":"boulder","full_name":"letsencrypt/boulder","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars0.githubusercontent.com/u/9289019?v=4","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/boulder","description":"An ACME-based CA, written in Go.","fork":false,"url":"https://api.github.com/repos/letsencrypt/boulder","forks_url":"https://api.github.com/repos/letsencrypt/boulder/forks","keys_url":"https://api.github.com/repos/letsencrypt/boulder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/boulder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/boulder/teams","hooks_url":"https://api.github.com/repos/letsencrypt/boulder/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/boulder/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/boulder/events","assignees_url":"https://api.github.com/repos/letsencrypt/boulder/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/boulder/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/boulder/tags","blobs_url":"https://api.github.com/repos/letsencrypt/boulder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/boulder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/boulder/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/boulder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/boulder/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/boulder/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/boulder/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/boulder/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/boulder/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/boulder/subscription","commits_url":"https://api.github.com/repos/letsencrypt/boulder/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/boulder/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/boulder/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/boulder/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/boulder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/boulder/merges","archive_url":"https://api.github.com/repos/letsencrypt/boulder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/boulder/downloads","issues_url":"https://api.github.com/repos/letsencrypt/boulder/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/boulder/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/boulder/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/boulder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/boulder/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/boulder/releases{/id}","deployments_url":"https://api.github.com/repos/letsencrypt/boulder/deployments","created_at":"2014-12-21T00:29:54Z","updated_at":"2017-08-24T16:42:59Z","pushed_at":"2017-08-25T07:12:01Z","git_url":"git://github.com/letsencrypt/boulder.git","ssh_url":"git@github.com:letsencrypt/boulder.git","clone_url":"https://github.com/letsencrypt/boulder.git","svn_url":"https://github.com/letsencrypt/boulder","homepage":null,"size":25671,"stargazers_count":1992,"watchers_count":1992,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"open_issues_count":155,"forks":250,"open_issues":155,"watchers":1992,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003"},"html":{"href":"https://github.com/letsencrypt/boulder/pull/3003"},"issue":{"href":"https://api.github.com/repos/letsencrypt/boulder/issues/3003"},"comments":{"href":"https://api.github.com/repos/letsencrypt/boulder/issues/3003/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/3003/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/boulder/statuses/cdf0a33206b1d31bf7f8a5002f5b08fd02e10b7c"}}}}
{"actor":{"display_login":"cpu"}}