{"action":"created","issue":{"url":"https://api.github.com/repos/alimanfoo/zarr/issues/121","repository_url":"https://api.github.com/repos/alimanfoo/zarr","labels_url":"https://api.github.com/repos/alimanfoo/zarr/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/alimanfoo/zarr/issues/121/comments","events_url":"https://api.github.com/repos/alimanfoo/zarr/issues/121/events","html_url":"https://github.com/alimanfoo/zarr/issues/121","id":209535600,"number":121,"title":"Adding attrs arg to create_group and create_dataset","user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/alimanfoo/zarr/milestones/5","html_url":"https://github.com/alimanfoo/zarr/milestone/5","labels_url":"https://api.github.com/repos/alimanfoo/zarr/milestones/5/labels","id":2199042,"number":5,"title":"v2.2","description":"","creator":{"login":"alimanfoo","id":703554,"avatar_url":"https://avatars1.githubusercontent.com/u/703554?v=4","gravatar_id":"","url":"https://api.github.com/users/alimanfoo","html_url":"https://github.com/alimanfoo","followers_url":"https://api.github.com/users/alimanfoo/followers","following_url":"https://api.github.com/users/alimanfoo/following{/other_user}","gists_url":"https://api.github.com/users/alimanfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/alimanfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alimanfoo/subscriptions","organizations_url":"https://api.github.com/users/alimanfoo/orgs","repos_url":"https://api.github.com/users/alimanfoo/repos","events_url":"https://api.github.com/users/alimanfoo/events{/privacy}","received_events_url":"https://api.github.com/users/alimanfoo/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":67,"state":"open","created_at":"2016-12-15T15:55:54Z","updated_at":"2017-11-20T10:54:52Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2017-02-22T18:10:08Z","updated_at":"2017-11-20T14:53:27Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"As it stands now, when one writes a group or dataset, one must write the attributes as a separate operation. This results in creation of `.zattrs` once. Then if one update the attributes, it results in writing `.zattrs` again. With something like a `ZipStore` backed Zarr Group, one gets a warning on writing `.zattrs` the second time, which AFAICT is unavoidable unless someone sets the attributes correctly the first time. So if we include an argument for `attrs` to `create_group` and `create_dataset`, we should be able to avoid this warning by setting the attributes during creation of these Zarr objects."},"comment":{"url":"https://api.github.com/repos/alimanfoo/zarr/issues/comments/345718850","html_url":"https://github.com/alimanfoo/zarr/issues/121#issuecomment-345718850","issue_url":"https://api.github.com/repos/alimanfoo/zarr/issues/121","id":345718850,"user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"created_at":"2017-11-20T14:53:27Z","updated_at":"2017-11-20T14:53:27Z","author_association":"CONTRIBUTOR","body":"Honestly I'd be ok closing this one. While `attrs` certainly could be an optional argument to functions creating datasets and groups, it diverges from `h5py` a bit. I think the problem that I had can be solved better ways. Not to mention, the `copy` suggestion I made above ends up being the same as issue ( https://github.com/alimanfoo/zarr/issues/113 ). Having `copy` would be of significantly more utility than optionally adding `attrs`. Thoughts?"}}
{"actor":{"display_login":"jakirkham"}}