{"action":"created","issue":{"url":"https://api.github.com/repos/andyhu/transliteration/issues/38","repository_url":"https://api.github.com/repos/andyhu/transliteration","labels_url":"https://api.github.com/repos/andyhu/transliteration/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/andyhu/transliteration/issues/38/comments","events_url":"https://api.github.com/repos/andyhu/transliteration/issues/38/events","html_url":"https://github.com/andyhu/transliteration/issues/38","id":220808415,"number":38,"title":"Version 1.5.3 'leaks' ES6 code (let, const) into minified js bundle when built","user":{"login":"spencern","id":1203639,"avatar_url":"https://avatars3.githubusercontent.com/u/1203639?v=3","gravatar_id":"","url":"https://api.github.com/users/spencern","html_url":"https://github.com/spencern","followers_url":"https://api.github.com/users/spencern/followers","following_url":"https://api.github.com/users/spencern/following{/other_user}","gists_url":"https://api.github.com/users/spencern/gists{/gist_id}","starred_url":"https://api.github.com/users/spencern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencern/subscriptions","organizations_url":"https://api.github.com/users/spencern/orgs","repos_url":"https://api.github.com/users/spencern/repos","events_url":"https://api.github.com/users/spencern/events{/privacy}","received_events_url":"https://api.github.com/users/spencern/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-04-11T00:42:01Z","updated_at":"2017-05-15T14:22:19Z","closed_at":null,"body":"I've got an issue that seems related to #28 \r\n\r\nI've got a meteor app (meteor controls the build) that imports `transliteration` - there's a description of the problem and a reproduction based on our app here: https://github.com/reactioncommerce/reaction/pull/2091\r\n\r\nFor versions up to 1.5.2 transliteration bundles a correctly babelified and minified js file. When we got bumped up to 1.5.3, we started seeing `let` and `const` in our minified production bundle. I think this is due to the change for 1.5.3 that removed the `\"browser\": \"lib/browser/transliteration.js\",` line, and the conversation in #28 seems to point that direction as well.\r\n\r\nThis issue only causes problems for us when an older browser such as PhantomJS is used to crawl the site. Unfortunately, the prerendering techniques we use to create cached, google/bing/yahoo crawl friendly pages use PhantomJS, and the `let` and `const` in the js bundle causes them to crash before rendering."},"comment":{"url":"https://api.github.com/repos/andyhu/transliteration/issues/comments/301490275","html_url":"https://github.com/andyhu/transliteration/issues/38#issuecomment-301490275","issue_url":"https://api.github.com/repos/andyhu/transliteration/issues/38","id":301490275,"user":{"login":"spencern","id":1203639,"avatar_url":"https://avatars3.githubusercontent.com/u/1203639?v=3","gravatar_id":"","url":"https://api.github.com/users/spencern","html_url":"https://github.com/spencern","followers_url":"https://api.github.com/users/spencern/followers","following_url":"https://api.github.com/users/spencern/following{/other_user}","gists_url":"https://api.github.com/users/spencern/gists{/gist_id}","starred_url":"https://api.github.com/users/spencern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencern/subscriptions","organizations_url":"https://api.github.com/users/spencern/orgs","repos_url":"https://api.github.com/users/spencern/repos","events_url":"https://api.github.com/users/spencern/events{/privacy}","received_events_url":"https://api.github.com/users/spencern/received_events","type":"User","site_admin":false},"created_at":"2017-05-15T14:22:19Z","updated_at":"2017-05-15T14:22:19Z","body":"I'll do that @andyhu. Thanks"}}
{"actor":{"display_login":"spencern"}}