{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/106536120","pull_request_review_id":27464348,"id":106536120,"diff_hunk":"@@ -2441,6 +2441,10 @@ func (dd *DeploymentDescriber) Describe(namespace, name string, describerSetting\n \t\t\t}\n \t\t\tw.Write(LEVEL_0, \"NewReplicaSet:\\t%s\\n\", printReplicaSetsByLabels(newRSs))\n \t\t}\n+\t\toverlapWith := d.Annotations[deploymentutil.OverlapAnnotation]\n+\t\tif len(overlapWith) > 0 {\n+\t\t\tw.Write(LEVEL_0, \"!!!WARNING!!! This deployment has overlapping label selector with deployment %q and won't behave as expected. Please fix it before continuing.\\n\", overlapWith)","path":"pkg/printers/internalversion/describe.go","position":6,"original_position":6,"commit_id":"fa23729a6d668d812fab228e566cb0ac23f2f2de","original_commit_id":"fa23729a6d668d812fab228e566cb0ac23f2f2de","user":{"login":"enisoc","id":6733629,"avatar_url":"https://avatars0.githubusercontent.com/u/6733629?v=3","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"body":"Why not remove it in `syncDeployment()` where we used to call [handleOverlap()](https://github.com/kubernetes/kubernetes/pull/42175/commits/92d75cbb2338c27a1404a556a2c3b92f52041941#diff-f88c99835d4b2acda532e36123761825L515)? It seems easier to prove that that will do the same thing as the old code would if the selectors no longer overlap.","created_at":"2017-03-16T21:28:41Z","updated_at":"2017-03-16T21:28:41Z","html_url":"https://github.com/kubernetes/kubernetes/pull/43239#discussion_r106536120","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/106536120"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/43239#discussion_r106536120"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239","id":111150451,"html_url":"https://github.com/kubernetes/kubernetes/pull/43239","diff_url":"https://github.com/kubernetes/kubernetes/pull/43239.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/43239.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43239","number":43239,"state":"open","locked":false,"title":"kubectl: Use v1.5-compatible ownership logic when listing dependents.","user":{"login":"enisoc","id":6733629,"avatar_url":"https://avatars0.githubusercontent.com/u/6733629?v=3","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nThis restores compatibility between kubectl 1.6 and clusters running Kubernetes 1.5.x. It introduces transitional ownership logic in which the client considers ControllerRef when it exists, but does not require it to exist.\r\n\r\nIf we were to ignore ControllerRef altogether (pre-1.6 client behavior), we would introduce a new failure mode in v1.6 because controllers that used to get stuck due to selector overlap will now make progress. For example, that means when reaping ReplicaSets of an overlapping Deployment, we would risk deleting ReplicaSets belonging to a different Deployment that we aren't about to delete.\r\n\r\nThis transitional logic avoids such surprises in 1.6 clusters, and does no worse than kubectl 1.5 did in 1.5 clusters. To prevent this when kubectl 1.5 is used against 1.6 clusters, we can cherrypick this change.\r\n\r\n**Which issue this PR fixes**:\r\n\r\nFixes #43159\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\n```\r\n","created_at":"2017-03-16T19:46:13Z","updated_at":"2017-03-16T21:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91cd5c308a76b782bf12dd1a7c4acbe3165b45f9","assignee":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars0.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"kargakis","id":3900799,"avatar_url":"https://avatars0.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars2.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":"","creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars2.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":1240,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2017-03-16T21:21:42Z","due_on":"2017-03-22T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43239/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fa23729a6d668d812fab228e566cb0ac23f2f2de","head":{"label":"enisoc:kubectl-controller-ref","ref":"kubectl-controller-ref","sha":"fa23729a6d668d812fab228e566cb0ac23f2f2de","user":{"login":"enisoc","id":6733629,"avatar_url":"https://avatars0.githubusercontent.com/u/6733629?v=3","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"repo":{"id":29278943,"name":"kubernetes","full_name":"enisoc/kubernetes","owner":{"login":"enisoc","id":6733629,"avatar_url":"https://avatars0.githubusercontent.com/u/6733629?v=3","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enisoc/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/enisoc/kubernetes","forks_url":"https://api.github.com/repos/enisoc/kubernetes/forks","keys_url":"https://api.github.com/repos/enisoc/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enisoc/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enisoc/kubernetes/teams","hooks_url":"https://api.github.com/repos/enisoc/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/enisoc/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/enisoc/kubernetes/events","assignees_url":"https://api.github.com/repos/enisoc/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/enisoc/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/enisoc/kubernetes/tags","blobs_url":"https://api.github.com/repos/enisoc/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enisoc/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enisoc/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/enisoc/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enisoc/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/enisoc/kubernetes/languages","stargazers_url":"https://api.github.com/repos/enisoc/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/enisoc/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/enisoc/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/enisoc/kubernetes/subscription","commits_url":"https://api.github.com/repos/enisoc/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/enisoc/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/enisoc/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/enisoc/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/enisoc/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/enisoc/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enisoc/kubernetes/merges","archive_url":"https://api.github.com/repos/enisoc/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enisoc/kubernetes/downloads","issues_url":"https://api.github.com/repos/enisoc/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/enisoc/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/enisoc/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/enisoc/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enisoc/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/enisoc/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/enisoc/kubernetes/deployments","created_at":"2015-01-15T03:28:42Z","updated_at":"2017-02-04T13:19:13Z","pushed_at":"2017-03-16T19:28:48Z","git_url":"git://github.com/enisoc/kubernetes.git","ssh_url":"git@github.com:enisoc/kubernetes.git","clone_url":"https://github.com/enisoc/kubernetes.git","svn_url":"https://github.com/enisoc/kubernetes","homepage":null,"size":398834,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b2525d43ed7985402582a26a11c4a3c93779ceab","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-03-16T20:55:27Z","pushed_at":"2017-03-16T21:22:42Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":569911,"stargazers_count":21516,"watchers_count":21516,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7400,"mirror_url":null,"open_issues_count":5515,"forks":7400,"open_issues":5515,"watchers":21516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/43239"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/43239"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/43239/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43239/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fa23729a6d668d812fab228e566cb0ac23f2f2de"}}}}
{"actor":{"display_login":"enisoc"}}