{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/129724717","pull_request_review_id":52527813,"id":129724717,"diff_hunk":"@@ -1364,7 +1381,9 @@ class DiagnosticsProperty<T> extends DiagnosticsNode {\n          showName: showName,\n          showSeparator: showSeparator,\n          style: style,\n-       );\n+       ) {\n+    assert(defaultValue == kNoDefaultValue || defaultValue is T);\n+  }","path":"packages/flutter/lib/src/foundation/tree_diagnostics_mixin.dart","position":62,"original_position":62,"commit_id":"dcb119a0671afb7b4abc8425804c3bf3ad4a2acf","original_commit_id":"dcb119a0671afb7b4abc8425804c3bf3ad4a2acf","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"merged. this can be done as an assert in the initializer list, by the way.","created_at":"2017-07-26T23:49:54Z","updated_at":"2017-07-26T23:49:54Z","html_url":"https://github.com/flutter/flutter/pull/11418#discussion_r129724717","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/11418","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/129724717"},"html":{"href":"https://github.com/flutter/flutter/pull/11418#discussion_r129724717"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11418"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/11418","id":132635514,"html_url":"https://github.com/flutter/flutter/pull/11418","diff_url":"https://github.com/flutter/flutter/pull/11418.diff","patch_url":"https://github.com/flutter/flutter/pull/11418.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/11418","number":11418,"state":"open","locked":false,"title":"Add and cleanup some comments for tree_diagnostics_mixin.","user":{"login":"jacob314","id":1226812,"avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-26T23:21:29Z","updated_at":"2017-07-26T23:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e190b2dd6ca12ebaf2de7e87426453e22347018","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/11418/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/11418/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/11418/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/dcb119a0671afb7b4abc8425804c3bf3ad4a2acf","head":{"label":"jacob314:cleanup_comments","ref":"cleanup_comments","sha":"dcb119a0671afb7b4abc8425804c3bf3ad4a2acf","user":{"login":"jacob314","id":1226812,"avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"repo":{"id":80662565,"name":"flutter","full_name":"jacob314/flutter","owner":{"login":"jacob314","id":1226812,"avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacob314/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/jacob314/flutter","forks_url":"https://api.github.com/repos/jacob314/flutter/forks","keys_url":"https://api.github.com/repos/jacob314/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacob314/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacob314/flutter/teams","hooks_url":"https://api.github.com/repos/jacob314/flutter/hooks","issue_events_url":"https://api.github.com/repos/jacob314/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jacob314/flutter/events","assignees_url":"https://api.github.com/repos/jacob314/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jacob314/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jacob314/flutter/tags","blobs_url":"https://api.github.com/repos/jacob314/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacob314/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacob314/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacob314/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacob314/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jacob314/flutter/languages","stargazers_url":"https://api.github.com/repos/jacob314/flutter/stargazers","contributors_url":"https://api.github.com/repos/jacob314/flutter/contributors","subscribers_url":"https://api.github.com/repos/jacob314/flutter/subscribers","subscription_url":"https://api.github.com/repos/jacob314/flutter/subscription","commits_url":"https://api.github.com/repos/jacob314/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacob314/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacob314/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacob314/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacob314/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jacob314/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacob314/flutter/merges","archive_url":"https://api.github.com/repos/jacob314/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacob314/flutter/downloads","issues_url":"https://api.github.com/repos/jacob314/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jacob314/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jacob314/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jacob314/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacob314/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jacob314/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jacob314/flutter/deployments","created_at":"2017-02-01T20:47:00Z","updated_at":"2017-02-01T20:47:04Z","pushed_at":"2017-07-26T23:37:32Z","git_url":"git://github.com/jacob314/flutter.git","ssh_url":"git@github.com:jacob314/flutter.git","clone_url":"https://github.com/jacob314/flutter.git","svn_url":"https://github.com/jacob314/flutter","homepage":"https://flutter.io","size":28739,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"1d8705f3dbcaded73510076baa4fe3e47cbba52f","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-07-26T23:47:35Z","pushed_at":"2017-07-26T23:37:33Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":28598,"stargazers_count":5645,"watchers_count":5645,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":567,"mirror_url":null,"open_issues_count":1725,"forks":567,"open_issues":1725,"watchers":5645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11418"},"html":{"href":"https://github.com/flutter/flutter/pull/11418"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/11418"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/11418/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11418/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11418/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/dcb119a0671afb7b4abc8425804c3bf3ad4a2acf"}}}}
{"actor":{"display_login":"Hixie"}}