{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/97453426","pull_request_review_id":18063768,"id":97453426,"diff_hunk":"@@ -0,0 +1,70 @@\n+<!--\n+\n+/*\n+** Copyright (c) 2017 The Khronos Group Inc.\n+**\n+** Permission is hereby granted, free of charge, to any person obtaining a\n+** copy of this software and/or associated documentation files (the\n+** \"Materials\"), to deal in the Materials without restriction, including\n+** without limitation the rights to use, copy, modify, merge, publish,\n+** distribute, sublicense, and/or sell copies of the Materials, and to\n+** permit persons to whom the Materials are furnished to do so, subject to\n+** the following conditions:\n+**\n+** The above copyright notice and this permission notice shall be included\n+** in all copies or substantial portions of the Materials.\n+**\n+** THE MATERIALS ARE PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+** EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+** MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+** IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY\n+** CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,\n+** TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE\n+** MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.\n+*/\n+\n+-->\n+\n+<!DOCTYPE html>\n+<html>\n+<head>\n+<meta charset=\"utf-8\">\n+<title>WebGL2 Context Resize Bug Test</title>\n+<link rel=\"stylesheet\" href=\"../../resources/js-test-style.css\"/>\n+<script src=\"../../js/js-test-pre.js\"></script>\n+<script src=\"../../js/webgl-test-utils.js\"></script>\n+</head>\n+<body>\n+<div id=\"description\"></div>\n+<div id=\"console\"></div>\n+<canvas id=\"test\"></canvas>\n+<script>\n+\"use strict\";\n+description(\"This test verifies canvas resize does not affect PIXEL_UNPACK_BUFFER binding.\");\n+\n+var wtu = WebGLTestUtils;\n+var canvas = document.getElementById(\"test\");\n+var gl = wtu.create3DContext(canvas, null, 2);\n+if (!gl) {\n+  testFailed(\"context does not exist\");\n+} else {\n+  testPassed(\"context exists\");\n+  var texture1= gl.createTexture();\n+  gl.bindTexture(gl.TEXTURE_3D, texture1);\n+  var buffer0= gl.createBuffer();\n+  gl.bindBuffer(gl.PIXEL_UNPACK_BUFFER, buffer0);\n+\n+  canvas.width = 682;\n+  // Resizing canvas incorrectly cleared the PIXEL_UNPACK_BUFFER binding to 0\n+  // and causeed a crash from the following line in Chrome. crbug.com/673929.","path":"sdk/tests/conformance2/context/context-resize-changes-buffer-binding-bug.html","position":null,"original_position":59,"commit_id":"7d6b6e5eb237f9017c8c77dc8c307b5b78e63418","original_commit_id":"63121d738f2b8da99068b5d7246d4ba898a1a445","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-01-24T00:56:31Z","updated_at":"2017-01-24T00:56:31Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/2271#discussion_r97453426","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/97453426"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2271#discussion_r97453426"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271","id":102829835,"html_url":"https://github.com/KhronosGroup/WebGL/pull/2271","diff_url":"https://github.com/KhronosGroup/WebGL/pull/2271.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/2271.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2271","number":2271,"state":"open","locked":false,"title":"Add a conformance test that caught a chrome crash.","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"body":"The bug is, when resizing a canvas, chrome incorrectly set PIXEL_UNPACK_BUFFER\r\nbinding to 0 without recovering it.","created_at":"2017-01-24T00:25:20Z","updated_at":"2017-01-24T00:56:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"812860ef0c245f7386f9064f2c7313207df132af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2271/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/7d6b6e5eb237f9017c8c77dc8c307b5b78e63418","head":{"label":"zhenyao:bug","ref":"bug","sha":"7d6b6e5eb237f9017c8c77dc8c307b5b78e63418","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"repo":{"id":5252508,"name":"WebGL","full_name":"zhenyao/WebGL","owner":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhenyao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/zhenyao/WebGL","forks_url":"https://api.github.com/repos/zhenyao/WebGL/forks","keys_url":"https://api.github.com/repos/zhenyao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhenyao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhenyao/WebGL/teams","hooks_url":"https://api.github.com/repos/zhenyao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/zhenyao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/zhenyao/WebGL/events","assignees_url":"https://api.github.com/repos/zhenyao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/zhenyao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/zhenyao/WebGL/tags","blobs_url":"https://api.github.com/repos/zhenyao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhenyao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhenyao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhenyao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhenyao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/zhenyao/WebGL/languages","stargazers_url":"https://api.github.com/repos/zhenyao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/zhenyao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/zhenyao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/zhenyao/WebGL/subscription","commits_url":"https://api.github.com/repos/zhenyao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhenyao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhenyao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhenyao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhenyao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/zhenyao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhenyao/WebGL/merges","archive_url":"https://api.github.com/repos/zhenyao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhenyao/WebGL/downloads","issues_url":"https://api.github.com/repos/zhenyao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/zhenyao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/zhenyao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/zhenyao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhenyao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/zhenyao/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/zhenyao/WebGL/deployments","created_at":"2012-07-31T22:49:16Z","updated_at":"2015-05-18T22:29:46Z","pushed_at":"2017-01-24T00:53:31Z","git_url":"git://github.com/zhenyao/WebGL.git","ssh_url":"git@github.com:zhenyao/WebGL.git","clone_url":"https://github.com/zhenyao/WebGL.git","svn_url":"https://github.com/zhenyao/WebGL","homepage":null,"size":29142,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"7444285c126b15faef0768a6d945fcb32b682141","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2017-01-23T22:25:25Z","pushed_at":"2017-01-24T00:53:33Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29074,"stargazers_count":754,"watchers_count":754,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":87,"forks":347,"open_issues":87,"watchers":754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2271"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2271"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2271/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2271/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/7d6b6e5eb237f9017c8c77dc8c307b5b78e63418"}}}}
{"actor":{"display_login":"zhenyao"}}