{"action":"opened","issue":{"url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/1556","repository_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul","labels_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/1556/labels{/name}","comments_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/1556/comments","events_url":"https://api.github.com/repos/KSP-RO/RealismOverhaul/issues/1556/events","html_url":"https://github.com/KSP-RO/RealismOverhaul/issues/1556","id":208412928,"number":1556,"title":"STAR 37 variants","user":{"login":"PhineasFreak","id":14848060,"avatar_url":"https://avatars.githubusercontent.com/u/14848060?v=3","gravatar_id":"","url":"https://api.github.com/users/PhineasFreak","html_url":"https://github.com/PhineasFreak","followers_url":"https://api.github.com/users/PhineasFreak/followers","following_url":"https://api.github.com/users/PhineasFreak/following{/other_user}","gists_url":"https://api.github.com/users/PhineasFreak/gists{/gist_id}","starred_url":"https://api.github.com/users/PhineasFreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhineasFreak/subscriptions","organizations_url":"https://api.github.com/users/PhineasFreak/orgs","repos_url":"https://api.github.com/users/PhineasFreak/repos","events_url":"https://api.github.com/users/PhineasFreak/events{/privacy}","received_events_url":"https://api.github.com/users/PhineasFreak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-17T11:21:15Z","updated_at":"2017-02-17T11:21:15Z","closed_at":null,"body":"Currently we have a global config for the STAR 37 but with a catch: the file (by name) referrs to the baseline STAR 37 but the actual config stats are set for the STAR 37**FM**, two completely different motors.\r\n\r\nI have compiled some data for the original STAR 37 (required by the Coatl Aerospace GroundOps) and that brings me to the question: should we add all the possible STAR 37 variants in a single config or keep them separate?\r\n\r\n* The first option is logical and easy (engine series, both liquid and solid, have their stats defined in the respective config and easy to find/compare/change them between different variants) but it conficts with the option of adding a **ModuleFuelTanks** with the SRM propellant (would have to add an :AFTER[RealismOverhaul] patch for every baseline variant to correct the propellant mass).\r\n\r\n* The second option is more messy (more files, more engine tags, more checks, more everything) but it eliminates the propellant mass addition.\r\n\r\nThoughts?"}}
{"actor":{"display_login":"PhineasFreak"}}