{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25388","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25388/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25388/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25388/events","html_url":"https://github.com/NixOS/nixpkgs/pull/25388","id":225434107,"number":25388,"title":"luasec: Use old 0.6pre version for lua 5.1","user":{"login":"edanaher","id":984691,"avatar_url":"https://avatars2.githubusercontent.com/u/984691?v=3","gravatar_id":"","url":"https://api.github.com/users/edanaher","html_url":"https://github.com/edanaher","followers_url":"https://api.github.com/users/edanaher/followers","following_url":"https://api.github.com/users/edanaher/following{/other_user}","gists_url":"https://api.github.com/users/edanaher/gists{/gist_id}","starred_url":"https://api.github.com/users/edanaher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edanaher/subscriptions","organizations_url":"https://api.github.com/users/edanaher/orgs","repos_url":"https://api.github.com/users/edanaher/repos","events_url":"https://api.github.com/users/edanaher/events{/privacy}","received_events_url":"https://api.github.com/users/edanaher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-01T13:25:48Z","updated_at":"2017-05-01T14:06:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25388","html_url":"https://github.com/NixOS/nixpkgs/pull/25388","diff_url":"https://github.com/NixOS/nixpkgs/pull/25388.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/25388.patch"},"body":"As described at https://github.com/voidlinux/void-packages/issues/3778,\r\nluasec 0.6 requires lua 5.2 or newer.  But prosody still requires lua\r\n5.1, so needs an older version of luasec.\r\n\r\nSince this will affect any package using luasec on lua 5.1, let's solve\r\nthe generic problem.\r\n\r\n(This specific version is taken from the upgrade of luasec that breaks\r\nprosody: 70909be2efb6891bc61960fc725a63d19c08982d .  I don't know if\r\nthis is the best version to use, but it Works For Me.)\r\n\r\n###### Motivation for this change\r\n\r\nSee commit comment above; prosody didn't work with TLS, and now it does, presumably along with anything else still using lua 5.1.  (Though according to nox-review, prosody appears to be the only affected package...)\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/298339121","html_url":"https://github.com/NixOS/nixpkgs/pull/25388#issuecomment-298339121","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25388","id":298339121,"user":{"login":"vcunat","id":1785925,"avatar_url":"https://avatars1.githubusercontent.com/u/1785925?v=3","gravatar_id":"","url":"https://api.github.com/users/vcunat","html_url":"https://github.com/vcunat","followers_url":"https://api.github.com/users/vcunat/followers","following_url":"https://api.github.com/users/vcunat/following{/other_user}","gists_url":"https://api.github.com/users/vcunat/gists{/gist_id}","starred_url":"https://api.github.com/users/vcunat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcunat/subscriptions","organizations_url":"https://api.github.com/users/vcunat/orgs","repos_url":"https://api.github.com/users/vcunat/repos","events_url":"https://api.github.com/users/vcunat/events{/privacy}","received_events_url":"https://api.github.com/users/vcunat/received_events","type":"User","site_admin":false},"created_at":"2017-05-01T14:06:50Z","updated_at":"2017-05-01T14:06:50Z","body":"@edanaher: have you actually tried prosody-0.9.12 that we have in master now? http://blog.prosody.im/prosody-0-9-12-released/ claims that it fixes problems with luasec 0.6."}}
{"actor":{"display_login":"vcunat"}}