{"push_id":1687698963,"size":1,"distinct_size":1,"ref":"refs/heads/200-support-deeper-zoom","head":"6cb107038598aa5448232f333e76fdd33f495e61","before":"74202bc1e0ccad358aac75fdd324475310a2cc79","commits":[{"sha":"6cb107038598aa5448232f333e76fdd33f495e61","author":{"name":"Thomas Buckley-Houston","email":"55bc7b18e460d0d077310393ffbc002e6fe4eaec@tombh.co.uk"},"message":"Support zooming to imagery's highest zoom\n\nEssentially this extends the max zoom on a case by case basis\nwhen an individual imagery layer is selected throught the results pane.\n\nFixes #200.\n\nI had planned to also limit the panning (so the imagery can't leave the\nviewport), however the default behaviour of selecting imagery doesn't\nfocus the map, so there's no consistent entry point for applying new\npanning limits. It could be done alongside the zoom-to-fit button\nbehaviour, but then there is an inconsistency in panning behaviour,\nwhich we be more confusing than helpful. So as it stands this commit\ndoes leave a small UX problem in that you can zoom to a level where the\nmain map layer disappears, but only when individual imagery is selected.\nAs soon as imagery is deselected the default max zoom (18) is reset and\nyou are zoomed back out to the default max zoom if you were browsing\nimagery at a higher zoom level.\n\nNotes:\n  * Imagery's metadata does not contain the max tile zoom. It needs to be\n    fetched separately through the tileJSON manifest, this is somewhat\n    hacky and requires a blocking XHR request. We should look to\n    include at least the maxZoom level from imagery's tileJSON, or\n    perhaps even include the tileJSON by default in the\n    `oin-meta-generator` process.\n  * Mapbox.js version is missing setMaxZoom(), consider upgrading.\n  * The custom DS zoom controls are listening to `layeradd` which gets\n    triggered around 150 times per map movement.\n  * Commit also contains formatting updates, mainly line length.","distinct":true,"url":"https://api.github.com/repos/hotosm/oam-browser/commits/6cb107038598aa5448232f333e76fdd33f495e61"}]}
{"actor":{"display_login":"tombh"}}