{"action":"created","comment":{"url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/comments/128633896","pull_request_review_id":51333648,"id":128633896,"diff_hunk":"@@ -7,11 +7,15 @@ const defaultValue = [];\n export default createClassComputed(\n   [false, true, false],\n   (array, key, value) => {\n-    return computed(normalizeArrayKey(array, [key]), value, (array, value) => {\n+    let args = [normalizeArrayKey(array, [key])];\n+    if (value) {\n+      args.push(value);\n+    }","path":"addon/array/filter-by.js","position":8,"original_position":8,"commit_id":"055219a5d53d2f86ee04eac8c931a60f9b995684","original_commit_id":"055219a5d53d2f86ee04eac8c931a60f9b995684","user":{"login":"buschtoens","id":834636,"avatar_url":"https://avatars0.githubusercontent.com/u/834636?v=4","gravatar_id":"","url":"https://api.github.com/users/buschtoens","html_url":"https://github.com/buschtoens","followers_url":"https://api.github.com/users/buschtoens/followers","following_url":"https://api.github.com/users/buschtoens/following{/other_user}","gists_url":"https://api.github.com/users/buschtoens/gists{/gist_id}","starred_url":"https://api.github.com/users/buschtoens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buschtoens/subscriptions","organizations_url":"https://api.github.com/users/buschtoens/orgs","repos_url":"https://api.github.com/users/buschtoens/repos","events_url":"https://api.github.com/users/buschtoens/events{/privacy}","received_events_url":"https://api.github.com/users/buschtoens/received_events","type":"User","site_admin":false},"body":"The problem with checking `value` for truthiness (or presence even), is that you're not doing 100 % the same as checking the actual length of `arguments`.\r\n\r\nThat's why I wasn't able to finish the PR in the first place: :grinning: \r\n\r\nBut if that is not an issue for you, we can let that nitpick slide and I am :+1: on this.","created_at":"2017-07-20T21:20:31Z","updated_at":"2017-07-20T21:20:31Z","html_url":"https://github.com/kellyselden/ember-awesome-macros/pull/364#discussion_r128633896","pull_request_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/comments/128633896"},"html":{"href":"https://github.com/kellyselden/ember-awesome-macros/pull/364#discussion_r128633896"},"pull_request":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364","id":130737958,"html_url":"https://github.com/kellyselden/ember-awesome-macros/pull/364","diff_url":"https://github.com/kellyselden/ember-awesome-macros/pull/364.diff","patch_url":"https://github.com/kellyselden/ember-awesome-macros/pull/364.patch","issue_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/364","number":364,"state":"open","locked":false,"title":"allow optional args with filterBy and rejectBy","user":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"body":"Closes #363.\r\n\r\ncc @buschtoens\r\n\r\nhttps://github.com/kellyselden/ember-awesome-macros/pull/363#issuecomment-315288517 Is still an issue.","created_at":"2017-07-16T03:46:54Z","updated_at":"2017-07-20T21:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9845abf3d9e9a95bb119ff4bd1b7b66601f214a1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364/commits","review_comments_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364/comments","review_comment_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/364/comments","statuses_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/statuses/055219a5d53d2f86ee04eac8c931a60f9b995684","head":{"label":"kellyselden:optional-param","ref":"optional-param","sha":"055219a5d53d2f86ee04eac8c931a60f9b995684","user":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"repo":{"id":53813953,"name":"ember-awesome-macros","full_name":"kellyselden/ember-awesome-macros","owner":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kellyselden/ember-awesome-macros","description":"A collection of Ember computed macros","fork":false,"url":"https://api.github.com/repos/kellyselden/ember-awesome-macros","forks_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/forks","keys_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/teams","hooks_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/hooks","issue_events_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/events{/number}","events_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/events","assignees_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/assignees{/user}","branches_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/branches{/branch}","tags_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/tags","blobs_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/refs{/sha}","trees_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/statuses/{sha}","languages_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/languages","stargazers_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/stargazers","contributors_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/contributors","subscribers_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/subscribers","subscription_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/subscription","commits_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/commits{/sha}","git_commits_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/commits{/sha}","comments_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/comments{/number}","issue_comment_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/comments{/number}","contents_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/contents/{+path}","compare_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/merges","archive_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/downloads","issues_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues{/number}","pulls_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls{/number}","milestones_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/milestones{/number}","notifications_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/labels{/name}","releases_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/releases{/id}","deployments_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/deployments","created_at":"2016-03-13T23:47:38Z","updated_at":"2017-07-15T07:05:51Z","pushed_at":"2017-07-19T22:01:23Z","git_url":"git://github.com/kellyselden/ember-awesome-macros.git","ssh_url":"git@github.com:kellyselden/ember-awesome-macros.git","clone_url":"https://github.com/kellyselden/ember-awesome-macros.git","svn_url":"https://github.com/kellyselden/ember-awesome-macros","homepage":"","size":482,"stargazers_count":125,"watchers_count":125,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":24,"forks":14,"open_issues":24,"watchers":125,"default_branch":"master"}},"base":{"label":"kellyselden:master","ref":"master","sha":"222dddc57e19aeecd9a2b72d58fa1378e8d38a5d","user":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"repo":{"id":53813953,"name":"ember-awesome-macros","full_name":"kellyselden/ember-awesome-macros","owner":{"login":"kellyselden","id":602423,"avatar_url":"https://avatars1.githubusercontent.com/u/602423?v=4","gravatar_id":"","url":"https://api.github.com/users/kellyselden","html_url":"https://github.com/kellyselden","followers_url":"https://api.github.com/users/kellyselden/followers","following_url":"https://api.github.com/users/kellyselden/following{/other_user}","gists_url":"https://api.github.com/users/kellyselden/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyselden/subscriptions","organizations_url":"https://api.github.com/users/kellyselden/orgs","repos_url":"https://api.github.com/users/kellyselden/repos","events_url":"https://api.github.com/users/kellyselden/events{/privacy}","received_events_url":"https://api.github.com/users/kellyselden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kellyselden/ember-awesome-macros","description":"A collection of Ember computed macros","fork":false,"url":"https://api.github.com/repos/kellyselden/ember-awesome-macros","forks_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/forks","keys_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/teams","hooks_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/hooks","issue_events_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/events{/number}","events_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/events","assignees_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/assignees{/user}","branches_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/branches{/branch}","tags_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/tags","blobs_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/refs{/sha}","trees_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/statuses/{sha}","languages_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/languages","stargazers_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/stargazers","contributors_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/contributors","subscribers_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/subscribers","subscription_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/subscription","commits_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/commits{/sha}","git_commits_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/git/commits{/sha}","comments_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/comments{/number}","issue_comment_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/comments{/number}","contents_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/contents/{+path}","compare_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/merges","archive_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/downloads","issues_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues{/number}","pulls_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls{/number}","milestones_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/milestones{/number}","notifications_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/labels{/name}","releases_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/releases{/id}","deployments_url":"https://api.github.com/repos/kellyselden/ember-awesome-macros/deployments","created_at":"2016-03-13T23:47:38Z","updated_at":"2017-07-15T07:05:51Z","pushed_at":"2017-07-19T22:01:23Z","git_url":"git://github.com/kellyselden/ember-awesome-macros.git","ssh_url":"git@github.com:kellyselden/ember-awesome-macros.git","clone_url":"https://github.com/kellyselden/ember-awesome-macros.git","svn_url":"https://github.com/kellyselden/ember-awesome-macros","homepage":"","size":482,"stargazers_count":125,"watchers_count":125,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":24,"forks":14,"open_issues":24,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364"},"html":{"href":"https://github.com/kellyselden/ember-awesome-macros/pull/364"},"issue":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/364"},"comments":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/kellyselden/ember-awesome-macros/statuses/055219a5d53d2f86ee04eac8c931a60f9b995684"}}}}
{"actor":{"display_login":"buschtoens"}}