{"action":"created","comment":{"url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments/120598629","pull_request_review_id":42573023,"id":120598629,"diff_hunk":"@@ -1,14 +1,24 @@\n FROM nginx:alpine\n \n-ADD nginx.conf /etc/nginx/\n-COPY sites/*.conf /etc/nginx/sites-available/\n-\n RUN apk update \\\n     && apk upgrade \\\n-    && apk add --no-cache bash \\\n+    && apk add --no-cache bash git \\\n     && adduser -D -H -u 1000 -s /bin/bash www-data \\\n     && rm /etc/nginx/conf.d/default.conf \n \n+RUN mkdir -p /usr/app/ \\\n+        && mkdir -p /usr/app/frontend \\\n+        && mkdir -p /usr/app/media \\\n+        && mkdir -p /usr/scripts \\\n+        && mkdir -p /usr/shared\n+\n+WORKDIR /usr/app\n+\n+RUN git clone https://github.com/AEGEE/oms-applications-frontend.git frontend","path":"docker/omsapplications-frontend/Dockerfile","position":21,"original_position":21,"commit_id":"47a3e34a8aead07639cb0b471b2a239b57ac0a52","original_commit_id":"47a3e34a8aead07639cb0b471b2a239b57ac0a52","user":{"login":"blacksph3re","id":7345251,"avatar_url":"https://avatars2.githubusercontent.com/u/7345251?v=3","gravatar_id":"","url":"https://api.github.com/users/blacksph3re","html_url":"https://github.com/blacksph3re","followers_url":"https://api.github.com/users/blacksph3re/followers","following_url":"https://api.github.com/users/blacksph3re/following{/other_user}","gists_url":"https://api.github.com/users/blacksph3re/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksph3re/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksph3re/subscriptions","organizations_url":"https://api.github.com/users/blacksph3re/orgs","repos_url":"https://api.github.com/users/blacksph3re/repos","events_url":"https://api.github.com/users/blacksph3re/events{/privacy}","received_events_url":"https://api.github.com/users/blacksph3re/received_events","type":"User","site_admin":false},"body":"This should not happen in a dev dockerfile. I want to manage my repos outside of docker","created_at":"2017-06-07T11:22:25Z","updated_at":"2017-06-07T11:36:05Z","html_url":"https://github.com/AEGEE/oms-docker/pull/16#discussion_r120598629","pull_request_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments/120598629"},"html":{"href":"https://github.com/AEGEE/oms-docker/pull/16#discussion_r120598629"},"pull_request":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16","id":116367172,"html_url":"https://github.com/AEGEE/oms-docker/pull/16","diff_url":"https://github.com/AEGEE/oms-docker/pull/16.diff","patch_url":"https://github.com/AEGEE/oms-docker/pull/16.patch","issue_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/16","number":16,"state":"closed","locked":false,"title":"Improve \"Add Traefik as API gateway/reverse proxy\"","user":{"login":"linuxbandit","id":3695704,"avatar_url":"https://avatars3.githubusercontent.com/u/3695704?v=3","gravatar_id":"","url":"https://api.github.com/users/linuxbandit","html_url":"https://github.com/linuxbandit","followers_url":"https://api.github.com/users/linuxbandit/followers","following_url":"https://api.github.com/users/linuxbandit/following{/other_user}","gists_url":"https://api.github.com/users/linuxbandit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxbandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxbandit/subscriptions","organizations_url":"https://api.github.com/users/linuxbandit/orgs","repos_url":"https://api.github.com/users/linuxbandit/repos","events_url":"https://api.github.com/users/linuxbandit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxbandit/received_events","type":"User","site_admin":false},"body":"Add repos for submodules that were forgotten :D\r\nMake it work for Vagrant as well (README)\r\nAdd utility makefile to not type always same things\r\n\r\n@i3anaan you are assigned because it is better to test also with Vagrant env (since nico and sergey still use pure docker)","created_at":"2017-04-18T16:22:15Z","updated_at":"2017-06-07T11:36:05Z","closed_at":"2017-06-06T17:08:40Z","merged_at":"2017-06-06T17:08:40Z","merge_commit_sha":"d0e52b728a77dfbe3be749e50e5c024e5b52337a","assignee":{"login":"i3anaan","id":2911348,"avatar_url":"https://avatars0.githubusercontent.com/u/2911348?v=3","gravatar_id":"","url":"https://api.github.com/users/i3anaan","html_url":"https://github.com/i3anaan","followers_url":"https://api.github.com/users/i3anaan/followers","following_url":"https://api.github.com/users/i3anaan/following{/other_user}","gists_url":"https://api.github.com/users/i3anaan/gists{/gist_id}","starred_url":"https://api.github.com/users/i3anaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3anaan/subscriptions","organizations_url":"https://api.github.com/users/i3anaan/orgs","repos_url":"https://api.github.com/users/i3anaan/repos","events_url":"https://api.github.com/users/i3anaan/events{/privacy}","received_events_url":"https://api.github.com/users/i3anaan/received_events","type":"User","site_admin":false},"assignees":[{"login":"i3anaan","id":2911348,"avatar_url":"https://avatars0.githubusercontent.com/u/2911348?v=3","gravatar_id":"","url":"https://api.github.com/users/i3anaan","html_url":"https://github.com/i3anaan","followers_url":"https://api.github.com/users/i3anaan/followers","following_url":"https://api.github.com/users/i3anaan/following{/other_user}","gists_url":"https://api.github.com/users/i3anaan/gists{/gist_id}","starred_url":"https://api.github.com/users/i3anaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3anaan/subscriptions","organizations_url":"https://api.github.com/users/i3anaan/orgs","repos_url":"https://api.github.com/users/i3anaan/repos","events_url":"https://api.github.com/users/i3anaan/events{/privacy}","received_events_url":"https://api.github.com/users/i3anaan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"serge1peshcoff","id":1060257,"avatar_url":"https://avatars0.githubusercontent.com/u/1060257?v=3","gravatar_id":"","url":"https://api.github.com/users/serge1peshcoff","html_url":"https://github.com/serge1peshcoff","followers_url":"https://api.github.com/users/serge1peshcoff/followers","following_url":"https://api.github.com/users/serge1peshcoff/following{/other_user}","gists_url":"https://api.github.com/users/serge1peshcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/serge1peshcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge1peshcoff/subscriptions","organizations_url":"https://api.github.com/users/serge1peshcoff/orgs","repos_url":"https://api.github.com/users/serge1peshcoff/repos","events_url":"https://api.github.com/users/serge1peshcoff/events{/privacy}","received_events_url":"https://api.github.com/users/serge1peshcoff/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16/commits","review_comments_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16/comments","review_comment_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/16/comments","statuses_url":"https://api.github.com/repos/AEGEE/oms-docker/statuses/47a3e34a8aead07639cb0b471b2a239b57ac0a52","head":{"label":"linuxbandit:traefik","ref":"traefik","sha":"47a3e34a8aead07639cb0b471b2a239b57ac0a52","user":{"login":"linuxbandit","id":3695704,"avatar_url":"https://avatars3.githubusercontent.com/u/3695704?v=3","gravatar_id":"","url":"https://api.github.com/users/linuxbandit","html_url":"https://github.com/linuxbandit","followers_url":"https://api.github.com/users/linuxbandit/followers","following_url":"https://api.github.com/users/linuxbandit/following{/other_user}","gists_url":"https://api.github.com/users/linuxbandit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxbandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxbandit/subscriptions","organizations_url":"https://api.github.com/users/linuxbandit/orgs","repos_url":"https://api.github.com/users/linuxbandit/repos","events_url":"https://api.github.com/users/linuxbandit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxbandit/received_events","type":"User","site_admin":false},"repo":{"id":87643372,"name":"oms-docker","full_name":"linuxbandit/oms-docker","owner":{"login":"linuxbandit","id":3695704,"avatar_url":"https://avatars3.githubusercontent.com/u/3695704?v=3","gravatar_id":"","url":"https://api.github.com/users/linuxbandit","html_url":"https://github.com/linuxbandit","followers_url":"https://api.github.com/users/linuxbandit/followers","following_url":"https://api.github.com/users/linuxbandit/following{/other_user}","gists_url":"https://api.github.com/users/linuxbandit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxbandit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxbandit/subscriptions","organizations_url":"https://api.github.com/users/linuxbandit/orgs","repos_url":"https://api.github.com/users/linuxbandit/repos","events_url":"https://api.github.com/users/linuxbandit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxbandit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linuxbandit/oms-docker","description":"A docker environment as an alternative to the homestead virtualization","fork":true,"url":"https://api.github.com/repos/linuxbandit/oms-docker","forks_url":"https://api.github.com/repos/linuxbandit/oms-docker/forks","keys_url":"https://api.github.com/repos/linuxbandit/oms-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxbandit/oms-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxbandit/oms-docker/teams","hooks_url":"https://api.github.com/repos/linuxbandit/oms-docker/hooks","issue_events_url":"https://api.github.com/repos/linuxbandit/oms-docker/issues/events{/number}","events_url":"https://api.github.com/repos/linuxbandit/oms-docker/events","assignees_url":"https://api.github.com/repos/linuxbandit/oms-docker/assignees{/user}","branches_url":"https://api.github.com/repos/linuxbandit/oms-docker/branches{/branch}","tags_url":"https://api.github.com/repos/linuxbandit/oms-docker/tags","blobs_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxbandit/oms-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxbandit/oms-docker/languages","stargazers_url":"https://api.github.com/repos/linuxbandit/oms-docker/stargazers","contributors_url":"https://api.github.com/repos/linuxbandit/oms-docker/contributors","subscribers_url":"https://api.github.com/repos/linuxbandit/oms-docker/subscribers","subscription_url":"https://api.github.com/repos/linuxbandit/oms-docker/subscription","commits_url":"https://api.github.com/repos/linuxbandit/oms-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxbandit/oms-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxbandit/oms-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxbandit/oms-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxbandit/oms-docker/contents/{+path}","compare_url":"https://api.github.com/repos/linuxbandit/oms-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxbandit/oms-docker/merges","archive_url":"https://api.github.com/repos/linuxbandit/oms-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxbandit/oms-docker/downloads","issues_url":"https://api.github.com/repos/linuxbandit/oms-docker/issues{/number}","pulls_url":"https://api.github.com/repos/linuxbandit/oms-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxbandit/oms-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxbandit/oms-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxbandit/oms-docker/labels{/name}","releases_url":"https://api.github.com/repos/linuxbandit/oms-docker/releases{/id}","deployments_url":"https://api.github.com/repos/linuxbandit/oms-docker/deployments","created_at":"2017-04-08T15:22:25Z","updated_at":"2017-04-08T15:22:27Z","pushed_at":"2017-06-06T19:21:30Z","git_url":"git://github.com/linuxbandit/oms-docker.git","ssh_url":"git@github.com:linuxbandit/oms-docker.git","clone_url":"https://github.com/linuxbandit/oms-docker.git","svn_url":"https://github.com/linuxbandit/oms-docker","homepage":null,"size":68,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AEGEE:traefik","ref":"traefik","sha":"cf3ac230cbedfb4ed416e8a6ec2a0230fdedfa91","user":{"login":"AEGEE","id":15609497,"avatar_url":"https://avatars1.githubusercontent.com/u/15609497?v=3","gravatar_id":"","url":"https://api.github.com/users/AEGEE","html_url":"https://github.com/AEGEE","followers_url":"https://api.github.com/users/AEGEE/followers","following_url":"https://api.github.com/users/AEGEE/following{/other_user}","gists_url":"https://api.github.com/users/AEGEE/gists{/gist_id}","starred_url":"https://api.github.com/users/AEGEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEGEE/subscriptions","organizations_url":"https://api.github.com/users/AEGEE/orgs","repos_url":"https://api.github.com/users/AEGEE/repos","events_url":"https://api.github.com/users/AEGEE/events{/privacy}","received_events_url":"https://api.github.com/users/AEGEE/received_events","type":"Organization","site_admin":false},"repo":{"id":73822546,"name":"oms-docker","full_name":"AEGEE/oms-docker","owner":{"login":"AEGEE","id":15609497,"avatar_url":"https://avatars1.githubusercontent.com/u/15609497?v=3","gravatar_id":"","url":"https://api.github.com/users/AEGEE","html_url":"https://github.com/AEGEE","followers_url":"https://api.github.com/users/AEGEE/followers","following_url":"https://api.github.com/users/AEGEE/following{/other_user}","gists_url":"https://api.github.com/users/AEGEE/gists{/gist_id}","starred_url":"https://api.github.com/users/AEGEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEGEE/subscriptions","organizations_url":"https://api.github.com/users/AEGEE/orgs","repos_url":"https://api.github.com/users/AEGEE/repos","events_url":"https://api.github.com/users/AEGEE/events{/privacy}","received_events_url":"https://api.github.com/users/AEGEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AEGEE/oms-docker","description":"A docker environment as an alternative to the homestead virtualization","fork":false,"url":"https://api.github.com/repos/AEGEE/oms-docker","forks_url":"https://api.github.com/repos/AEGEE/oms-docker/forks","keys_url":"https://api.github.com/repos/AEGEE/oms-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AEGEE/oms-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AEGEE/oms-docker/teams","hooks_url":"https://api.github.com/repos/AEGEE/oms-docker/hooks","issue_events_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/events{/number}","events_url":"https://api.github.com/repos/AEGEE/oms-docker/events","assignees_url":"https://api.github.com/repos/AEGEE/oms-docker/assignees{/user}","branches_url":"https://api.github.com/repos/AEGEE/oms-docker/branches{/branch}","tags_url":"https://api.github.com/repos/AEGEE/oms-docker/tags","blobs_url":"https://api.github.com/repos/AEGEE/oms-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AEGEE/oms-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AEGEE/oms-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/AEGEE/oms-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AEGEE/oms-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/AEGEE/oms-docker/languages","stargazers_url":"https://api.github.com/repos/AEGEE/oms-docker/stargazers","contributors_url":"https://api.github.com/repos/AEGEE/oms-docker/contributors","subscribers_url":"https://api.github.com/repos/AEGEE/oms-docker/subscribers","subscription_url":"https://api.github.com/repos/AEGEE/oms-docker/subscription","commits_url":"https://api.github.com/repos/AEGEE/oms-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/AEGEE/oms-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/AEGEE/oms-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/AEGEE/oms-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/AEGEE/oms-docker/contents/{+path}","compare_url":"https://api.github.com/repos/AEGEE/oms-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AEGEE/oms-docker/merges","archive_url":"https://api.github.com/repos/AEGEE/oms-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AEGEE/oms-docker/downloads","issues_url":"https://api.github.com/repos/AEGEE/oms-docker/issues{/number}","pulls_url":"https://api.github.com/repos/AEGEE/oms-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/AEGEE/oms-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/AEGEE/oms-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AEGEE/oms-docker/labels{/name}","releases_url":"https://api.github.com/repos/AEGEE/oms-docker/releases{/id}","deployments_url":"https://api.github.com/repos/AEGEE/oms-docker/deployments","created_at":"2016-11-15T14:42:00Z","updated_at":"2017-04-18T15:41:28Z","pushed_at":"2017-06-07T11:35:09Z","git_url":"git://github.com/AEGEE/oms-docker.git","ssh_url":"git@github.com:AEGEE/oms-docker.git","clone_url":"https://github.com/AEGEE/oms-docker.git","svn_url":"https://github.com/AEGEE/oms-docker","homepage":null,"size":69,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16"},"html":{"href":"https://github.com/AEGEE/oms-docker/pull/16"},"issue":{"href":"https://api.github.com/repos/AEGEE/oms-docker/issues/16"},"comments":{"href":"https://api.github.com/repos/AEGEE/oms-docker/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AEGEE/oms-docker/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/AEGEE/oms-docker/statuses/47a3e34a8aead07639cb0b471b2a239b57ac0a52"}}}}
{"actor":{"display_login":"blacksph3re"}}