{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/2557","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/2557/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/2557/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/2557/events","html_url":"https://github.com/triplea-game/triplea/pull/2557","id":270192049,"number":2557,"title":"BattleCalculator simplification - remove needless default to WeakAI","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars2.githubusercontent.com/u/12397753?v=4","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-01T04:42:15Z","updated_at":"2017-11-01T04:48:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/2557","html_url":"https://github.com/triplea-game/triplea/pull/2557","diff_url":"https://github.com/triplea-game/triplea/pull/2557.diff","patch_url":"https://github.com/triplea-game/triplea/pull/2557.patch"},"body":"Going through a debugger it looks like the remote bridge player is always non-null. This update removes what should be a dead code branch where a null player defaults to WeakAI.\r\n\r\nTesting:\r\n- checked human and AI player cases\r\n- check save and new game cases\r\n\r\n<!--\r\n\r\nAll PRs should follow the standards outlined at:\r\nhttps://github.com/triplea-game/triplea/blob/master/docs/dev/code_standards.md\r\n\r\nMore about those standards here: \r\nhttps://github.com/triplea-game/triplea/blob/master/docs/dev/code_format.md\r\n\r\nTo learn more about the process of reviewing PRs, see: \r\nhttps://github.com/triplea-game/triplea/blob/master/docs/dev/code_reviews.md\r\n\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/340977305","html_url":"https://github.com/triplea-game/triplea/pull/2557#issuecomment-340977305","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/2557","id":340977305,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-11-01T04:48:13Z","updated_at":"2017-11-01T04:48:13Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=h1) Report\n> Merging [#2557](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=desc) into [master](https://codecov.io/gh/triplea-game/triplea/commit/719d5644d88472b0e73aa2b126bca84d6ac19748?src=pr&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/triplea-game/triplea/pull/2557/graphs/tree.svg?token=QPS14q4xnG&src=pr&width=650&height=150)](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #2557      +/-   ##\n============================================\n- Coverage     20.86%   20.84%   -0.03%     \n+ Complexity     5917     5912       -5     \n============================================\n  Files           832      832              \n  Lines         73649    73645       -4     \n  Branches      12394    12393       -1     \n============================================\n- Hits          15368    15350      -18     \n- Misses        56122    56138      +16     \n+ Partials       2159     2157       -2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...es/strategy/triplea/delegate/BattleCalculator.java](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS90cmlwbGVhL2RlbGVnYXRlL0JhdHRsZUNhbGN1bGF0b3IuamF2YQ==) | `52.44% <100%> (+0.01%)` | `80 <0> (ø)` | :arrow_down: |\n| [...engine/framework/map/download/FileSizeWatcher.java](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9lbmdpbmUvZnJhbWV3b3JrL21hcC9kb3dubG9hZC9GaWxlU2l6ZVdhdGNoZXIuamF2YQ==) | `0% <0%> (-71.43%)` | `0% <0%> (-4%)` | |\n| [...gy/engine/framework/map/download/DownloadFile.java](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9lbmdpbmUvZnJhbWV3b3JrL21hcC9kb3dubG9hZC9Eb3dubG9hZEZpbGUuamF2YQ==) | `34.69% <0%> (-12.25%)` | `8% <0%> (-1%)` | |\n| [.../games/strategy/engine/ClientFileSystemHelper.java](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9lbmdpbmUvQ2xpZW50RmlsZVN5c3RlbUhlbHBlci5qYXZh) | `18.96% <0%> (-1.73%)` | `5% <0%> (-1%)` | |\n| [src/main/java/games/strategy/net/nio/Decoder.java](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9uZXQvbmlvL0RlY29kZXIuamF2YQ==) | `67.3% <0%> (+0.96%)` | `25% <0%> (+1%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=footer). Last update [719d564...a1e408e](https://codecov.io/gh/triplea-game/triplea/pull/2557?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}