{"action":"closed","number":456,"pull_request":{"url":"https://api.github.com/repos/moderntribe/tribe-common/pulls/456","id":131859265,"html_url":"https://github.com/moderntribe/tribe-common/pull/456","diff_url":"https://github.com/moderntribe/tribe-common/pull/456.diff","patch_url":"https://github.com/moderntribe/tribe-common/pull/456.patch","issue_url":"https://api.github.com/repos/moderntribe/tribe-common/issues/456","number":456,"state":"closed","locked":false,"title":"Cleaner/safer handling of settings in a mu network | #79728","user":{"login":"barryhughes","id":3594411,"avatar_url":"https://avatars1.githubusercontent.com/u/3594411?v=4","gravatar_id":"","url":"https://api.github.com/users/barryhughes","html_url":"https://github.com/barryhughes","followers_url":"https://api.github.com/users/barryhughes/followers","following_url":"https://api.github.com/users/barryhughes/following{/other_user}","gists_url":"https://api.github.com/users/barryhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/barryhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barryhughes/subscriptions","organizations_url":"https://api.github.com/users/barryhughes/orgs","repos_url":"https://api.github.com/users/barryhughes/repos","events_url":"https://api.github.com/users/barryhughes/events{/privacy}","received_events_url":"https://api.github.com/users/barryhughes/received_events","type":"User","site_admin":false},"body":"The decision to pull from regular options or network level options should hinge on whether we're inside the network admin environment or not.\r\n\r\nBefore this change we based the decision on whether the option being saved was `'tribe_events_calendar_options'` or not, which doesn't seem to make sense generally and even less sense if we're trying to save Community Events settings, which are stored in a different option.\r\n\r\n:ticket: [#79728](https://central.tri.be/issues/79728)","created_at":"2017-07-21T21:10:03Z","updated_at":"2017-07-24T15:20:57Z","closed_at":"2017-07-24T15:20:57Z","merged_at":"2017-07-24T15:20:57Z","merge_commit_sha":"1485e81908def5be4efa39562a2cd8169f45f1c5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/moderntribe/tribe-common/pulls/456/commits","review_comments_url":"https://api.github.com/repos/moderntribe/tribe-common/pulls/456/comments","review_comment_url":"https://api.github.com/repos/moderntribe/tribe-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moderntribe/tribe-common/issues/456/comments","statuses_url":"https://api.github.com/repos/moderntribe/tribe-common/statuses/ed0426da632316ab1810adf27f9e4e6e95bf2419","head":{"label":"moderntribe:fix/79728/mu-settings","ref":"fix/79728/mu-settings","sha":"ed0426da632316ab1810adf27f9e4e6e95bf2419","user":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"repo":{"id":41689794,"name":"tribe-common","full_name":"moderntribe/tribe-common","owner":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moderntribe/tribe-common","description":"Common classes and functions used in our plugins","fork":false,"url":"https://api.github.com/repos/moderntribe/tribe-common","forks_url":"https://api.github.com/repos/moderntribe/tribe-common/forks","keys_url":"https://api.github.com/repos/moderntribe/tribe-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moderntribe/tribe-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moderntribe/tribe-common/teams","hooks_url":"https://api.github.com/repos/moderntribe/tribe-common/hooks","issue_events_url":"https://api.github.com/repos/moderntribe/tribe-common/issues/events{/number}","events_url":"https://api.github.com/repos/moderntribe/tribe-common/events","assignees_url":"https://api.github.com/repos/moderntribe/tribe-common/assignees{/user}","branches_url":"https://api.github.com/repos/moderntribe/tribe-common/branches{/branch}","tags_url":"https://api.github.com/repos/moderntribe/tribe-common/tags","blobs_url":"https://api.github.com/repos/moderntribe/tribe-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moderntribe/tribe-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moderntribe/tribe-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/moderntribe/tribe-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moderntribe/tribe-common/statuses/{sha}","languages_url":"https://api.github.com/repos/moderntribe/tribe-common/languages","stargazers_url":"https://api.github.com/repos/moderntribe/tribe-common/stargazers","contributors_url":"https://api.github.com/repos/moderntribe/tribe-common/contributors","subscribers_url":"https://api.github.com/repos/moderntribe/tribe-common/subscribers","subscription_url":"https://api.github.com/repos/moderntribe/tribe-common/subscription","commits_url":"https://api.github.com/repos/moderntribe/tribe-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/moderntribe/tribe-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/moderntribe/tribe-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/moderntribe/tribe-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/moderntribe/tribe-common/contents/{+path}","compare_url":"https://api.github.com/repos/moderntribe/tribe-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moderntribe/tribe-common/merges","archive_url":"https://api.github.com/repos/moderntribe/tribe-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moderntribe/tribe-common/downloads","issues_url":"https://api.github.com/repos/moderntribe/tribe-common/issues{/number}","pulls_url":"https://api.github.com/repos/moderntribe/tribe-common/pulls{/number}","milestones_url":"https://api.github.com/repos/moderntribe/tribe-common/milestones{/number}","notifications_url":"https://api.github.com/repos/moderntribe/tribe-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moderntribe/tribe-common/labels{/name}","releases_url":"https://api.github.com/repos/moderntribe/tribe-common/releases{/id}","deployments_url":"https://api.github.com/repos/moderntribe/tribe-common/deployments","created_at":"2015-08-31T17:22:40Z","updated_at":"2017-05-29T19:39:46Z","pushed_at":"2017-07-24T15:20:57Z","git_url":"git://github.com/moderntribe/tribe-common.git","ssh_url":"git@github.com:moderntribe/tribe-common.git","clone_url":"https://github.com/moderntribe/tribe-common.git","svn_url":"https://github.com/moderntribe/tribe-common","homepage":null,"size":22285,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"moderntribe:release/M17.14","ref":"release/M17.14","sha":"0ff800a34782bb2730477b8fbc33559e97a77e21","user":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"repo":{"id":41689794,"name":"tribe-common","full_name":"moderntribe/tribe-common","owner":{"login":"moderntribe","id":2279551,"avatar_url":"https://avatars1.githubusercontent.com/u/2279551?v=4","gravatar_id":"","url":"https://api.github.com/users/moderntribe","html_url":"https://github.com/moderntribe","followers_url":"https://api.github.com/users/moderntribe/followers","following_url":"https://api.github.com/users/moderntribe/following{/other_user}","gists_url":"https://api.github.com/users/moderntribe/gists{/gist_id}","starred_url":"https://api.github.com/users/moderntribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moderntribe/subscriptions","organizations_url":"https://api.github.com/users/moderntribe/orgs","repos_url":"https://api.github.com/users/moderntribe/repos","events_url":"https://api.github.com/users/moderntribe/events{/privacy}","received_events_url":"https://api.github.com/users/moderntribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moderntribe/tribe-common","description":"Common classes and functions used in our plugins","fork":false,"url":"https://api.github.com/repos/moderntribe/tribe-common","forks_url":"https://api.github.com/repos/moderntribe/tribe-common/forks","keys_url":"https://api.github.com/repos/moderntribe/tribe-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moderntribe/tribe-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moderntribe/tribe-common/teams","hooks_url":"https://api.github.com/repos/moderntribe/tribe-common/hooks","issue_events_url":"https://api.github.com/repos/moderntribe/tribe-common/issues/events{/number}","events_url":"https://api.github.com/repos/moderntribe/tribe-common/events","assignees_url":"https://api.github.com/repos/moderntribe/tribe-common/assignees{/user}","branches_url":"https://api.github.com/repos/moderntribe/tribe-common/branches{/branch}","tags_url":"https://api.github.com/repos/moderntribe/tribe-common/tags","blobs_url":"https://api.github.com/repos/moderntribe/tribe-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moderntribe/tribe-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moderntribe/tribe-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/moderntribe/tribe-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moderntribe/tribe-common/statuses/{sha}","languages_url":"https://api.github.com/repos/moderntribe/tribe-common/languages","stargazers_url":"https://api.github.com/repos/moderntribe/tribe-common/stargazers","contributors_url":"https://api.github.com/repos/moderntribe/tribe-common/contributors","subscribers_url":"https://api.github.com/repos/moderntribe/tribe-common/subscribers","subscription_url":"https://api.github.com/repos/moderntribe/tribe-common/subscription","commits_url":"https://api.github.com/repos/moderntribe/tribe-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/moderntribe/tribe-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/moderntribe/tribe-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/moderntribe/tribe-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/moderntribe/tribe-common/contents/{+path}","compare_url":"https://api.github.com/repos/moderntribe/tribe-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moderntribe/tribe-common/merges","archive_url":"https://api.github.com/repos/moderntribe/tribe-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moderntribe/tribe-common/downloads","issues_url":"https://api.github.com/repos/moderntribe/tribe-common/issues{/number}","pulls_url":"https://api.github.com/repos/moderntribe/tribe-common/pulls{/number}","milestones_url":"https://api.github.com/repos/moderntribe/tribe-common/milestones{/number}","notifications_url":"https://api.github.com/repos/moderntribe/tribe-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moderntribe/tribe-common/labels{/name}","releases_url":"https://api.github.com/repos/moderntribe/tribe-common/releases{/id}","deployments_url":"https://api.github.com/repos/moderntribe/tribe-common/deployments","created_at":"2015-08-31T17:22:40Z","updated_at":"2017-05-29T19:39:46Z","pushed_at":"2017-07-24T15:20:57Z","git_url":"git://github.com/moderntribe/tribe-common.git","ssh_url":"git@github.com:moderntribe/tribe-common.git","clone_url":"https://github.com/moderntribe/tribe-common.git","svn_url":"https://github.com/moderntribe/tribe-common","homepage":null,"size":22285,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moderntribe/tribe-common/pulls/456"},"html":{"href":"https://github.com/moderntribe/tribe-common/pull/456"},"issue":{"href":"https://api.github.com/repos/moderntribe/tribe-common/issues/456"},"comments":{"href":"https://api.github.com/repos/moderntribe/tribe-common/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/moderntribe/tribe-common/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/moderntribe/tribe-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moderntribe/tribe-common/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/moderntribe/tribe-common/statuses/ed0426da632316ab1810adf27f9e4e6e95bf2419"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"barryhughes","id":3594411,"avatar_url":"https://avatars1.githubusercontent.com/u/3594411?v=4","gravatar_id":"","url":"https://api.github.com/users/barryhughes","html_url":"https://github.com/barryhughes","followers_url":"https://api.github.com/users/barryhughes/followers","following_url":"https://api.github.com/users/barryhughes/following{/other_user}","gists_url":"https://api.github.com/users/barryhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/barryhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barryhughes/subscriptions","organizations_url":"https://api.github.com/users/barryhughes/orgs","repos_url":"https://api.github.com/users/barryhughes/repos","events_url":"https://api.github.com/users/barryhughes/events{/privacy}","received_events_url":"https://api.github.com/users/barryhughes/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"barryhughes"}}