{"action":"created","comment":{"url":"https://api.github.com/repos/01org/libva/pulls/comments/150919880","pull_request_review_id":76543611,"id":150919880,"diff_hunk":"@@ -140,7 +140,9 @@ struct VADriverVTable\n \t\tunsigned int size,\t\t/* in */\n \t\tunsigned int num_elements,\t/* in */\n \t\tvoid *data,\t\t\t/* in */\n-\t\tVABufferID *buf_id\t\t/* out */\n+                unsigned int *unit_size,\n+                unsigned int *pitch,\n+                VABufferID *buf_id","path":"va/va_backend.h","position":7,"original_position":7,"commit_id":"c17ee19bcdc4cd5e6615fb0026361da3350f3893","original_commit_id":"c17ee19bcdc4cd5e6615fb0026361da3350f3893","user":{"login":"xhaihao","id":24284137,"avatar_url":"https://avatars0.githubusercontent.com/u/24284137?v=4","gravatar_id":"","url":"https://api.github.com/users/xhaihao","html_url":"https://github.com/xhaihao","followers_url":"https://api.github.com/users/xhaihao/followers","following_url":"https://api.github.com/users/xhaihao/following{/other_user}","gists_url":"https://api.github.com/users/xhaihao/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaihao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaihao/subscriptions","organizations_url":"https://api.github.com/users/xhaihao/orgs","repos_url":"https://api.github.com/users/xhaihao/repos","events_url":"https://api.github.com/users/xhaihao/events{/privacy}","received_events_url":"https://api.github.com/users/xhaihao/received_events","type":"User","site_admin":false},"body":"Yes, you should add another function pointer at the end of  the vtable.  your change breaks the compiling of other vaapi backend drivers ","created_at":"2017-11-14T18:23:10Z","updated_at":"2017-11-14T18:23:10Z","html_url":"https://github.com/01org/libva/pull/86#discussion_r150919880","pull_request_url":"https://api.github.com/repos/01org/libva/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/01org/libva/pulls/comments/150919880"},"html":{"href":"https://github.com/01org/libva/pull/86#discussion_r150919880"},"pull_request":{"href":"https://api.github.com/repos/01org/libva/pulls/86"}},"in_reply_to_id":139650116},"pull_request":{"url":"https://api.github.com/repos/01org/libva/pulls/86","id":130792503,"html_url":"https://github.com/01org/libva/pull/86","diff_url":"https://github.com/01org/libva/pull/86.diff","patch_url":"https://github.com/01org/libva/pull/86.patch","issue_url":"https://api.github.com/repos/01org/libva/issues/86","number":86,"state":"open","locked":false,"title":"add 2D buffer support","user":{"login":"xfengcarl","id":28858250,"avatar_url":"https://avatars2.githubusercontent.com/u/28858250?v=4","gravatar_id":"","url":"https://api.github.com/users/xfengcarl","html_url":"https://github.com/xfengcarl","followers_url":"https://api.github.com/users/xfengcarl/followers","following_url":"https://api.github.com/users/xfengcarl/following{/other_user}","gists_url":"https://api.github.com/users/xfengcarl/gists{/gist_id}","starred_url":"https://api.github.com/users/xfengcarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfengcarl/subscriptions","organizations_url":"https://api.github.com/users/xfengcarl/orgs","repos_url":"https://api.github.com/users/xfengcarl/repos","events_url":"https://api.github.com/users/xfengcarl/events{/privacy}","received_events_url":"https://api.github.com/users/xfengcarl/received_events","type":"User","site_admin":false},"body":"standard usage: permb  control buffer, it is always a 2D buffer related with MB Postion\r\n\r\nSigned-off-by: Carl.Zhang <carl.zhang@intel.com>","created_at":"2017-07-17T06:47:53Z","updated_at":"2017-11-14T18:23:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d9003dcf5b966b5d8dd66650f7f7d70097b0a4d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/libva/pulls/86/commits","review_comments_url":"https://api.github.com/repos/01org/libva/pulls/86/comments","review_comment_url":"https://api.github.com/repos/01org/libva/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/libva/issues/86/comments","statuses_url":"https://api.github.com/repos/01org/libva/statuses/c17ee19bcdc4cd5e6615fb0026361da3350f3893","head":{"label":"xfengcarl:buffer2d","ref":"buffer2d","sha":"c17ee19bcdc4cd5e6615fb0026361da3350f3893","user":{"login":"xfengcarl","id":28858250,"avatar_url":"https://avatars2.githubusercontent.com/u/28858250?v=4","gravatar_id":"","url":"https://api.github.com/users/xfengcarl","html_url":"https://github.com/xfengcarl","followers_url":"https://api.github.com/users/xfengcarl/followers","following_url":"https://api.github.com/users/xfengcarl/following{/other_user}","gists_url":"https://api.github.com/users/xfengcarl/gists{/gist_id}","starred_url":"https://api.github.com/users/xfengcarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfengcarl/subscriptions","organizations_url":"https://api.github.com/users/xfengcarl/orgs","repos_url":"https://api.github.com/users/xfengcarl/repos","events_url":"https://api.github.com/users/xfengcarl/events{/privacy}","received_events_url":"https://api.github.com/users/xfengcarl/received_events","type":"User","site_admin":false},"repo":{"id":92026571,"name":"libva","full_name":"xfengcarl/libva","owner":{"login":"xfengcarl","id":28858250,"avatar_url":"https://avatars2.githubusercontent.com/u/28858250?v=4","gravatar_id":"","url":"https://api.github.com/users/xfengcarl","html_url":"https://github.com/xfengcarl","followers_url":"https://api.github.com/users/xfengcarl/followers","following_url":"https://api.github.com/users/xfengcarl/following{/other_user}","gists_url":"https://api.github.com/users/xfengcarl/gists{/gist_id}","starred_url":"https://api.github.com/users/xfengcarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfengcarl/subscriptions","organizations_url":"https://api.github.com/users/xfengcarl/orgs","repos_url":"https://api.github.com/users/xfengcarl/repos","events_url":"https://api.github.com/users/xfengcarl/events{/privacy}","received_events_url":"https://api.github.com/users/xfengcarl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xfengcarl/libva","description":"Libva is an implementation for VA-API (VIdeo Acceleration API)","fork":true,"url":"https://api.github.com/repos/xfengcarl/libva","forks_url":"https://api.github.com/repos/xfengcarl/libva/forks","keys_url":"https://api.github.com/repos/xfengcarl/libva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xfengcarl/libva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xfengcarl/libva/teams","hooks_url":"https://api.github.com/repos/xfengcarl/libva/hooks","issue_events_url":"https://api.github.com/repos/xfengcarl/libva/issues/events{/number}","events_url":"https://api.github.com/repos/xfengcarl/libva/events","assignees_url":"https://api.github.com/repos/xfengcarl/libva/assignees{/user}","branches_url":"https://api.github.com/repos/xfengcarl/libva/branches{/branch}","tags_url":"https://api.github.com/repos/xfengcarl/libva/tags","blobs_url":"https://api.github.com/repos/xfengcarl/libva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xfengcarl/libva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xfengcarl/libva/git/refs{/sha}","trees_url":"https://api.github.com/repos/xfengcarl/libva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xfengcarl/libva/statuses/{sha}","languages_url":"https://api.github.com/repos/xfengcarl/libva/languages","stargazers_url":"https://api.github.com/repos/xfengcarl/libva/stargazers","contributors_url":"https://api.github.com/repos/xfengcarl/libva/contributors","subscribers_url":"https://api.github.com/repos/xfengcarl/libva/subscribers","subscription_url":"https://api.github.com/repos/xfengcarl/libva/subscription","commits_url":"https://api.github.com/repos/xfengcarl/libva/commits{/sha}","git_commits_url":"https://api.github.com/repos/xfengcarl/libva/git/commits{/sha}","comments_url":"https://api.github.com/repos/xfengcarl/libva/comments{/number}","issue_comment_url":"https://api.github.com/repos/xfengcarl/libva/issues/comments{/number}","contents_url":"https://api.github.com/repos/xfengcarl/libva/contents/{+path}","compare_url":"https://api.github.com/repos/xfengcarl/libva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xfengcarl/libva/merges","archive_url":"https://api.github.com/repos/xfengcarl/libva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xfengcarl/libva/downloads","issues_url":"https://api.github.com/repos/xfengcarl/libva/issues{/number}","pulls_url":"https://api.github.com/repos/xfengcarl/libva/pulls{/number}","milestones_url":"https://api.github.com/repos/xfengcarl/libva/milestones{/number}","notifications_url":"https://api.github.com/repos/xfengcarl/libva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xfengcarl/libva/labels{/name}","releases_url":"https://api.github.com/repos/xfengcarl/libva/releases{/id}","deployments_url":"https://api.github.com/repos/xfengcarl/libva/deployments","created_at":"2017-05-22T07:51:43Z","updated_at":"2017-05-22T07:51:45Z","pushed_at":"2017-11-14T08:39:38Z","git_url":"git://github.com/xfengcarl/libva.git","ssh_url":"git@github.com:xfengcarl/libva.git","clone_url":"https://github.com/xfengcarl/libva.git","svn_url":"https://github.com/xfengcarl/libva","homepage":"https://01.org/linuxmedia","size":3984,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"b65a3d9deacb72bd9f96d3e023d4f8ed58bd8d0a","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars1.githubusercontent.com/u/1635439?v=4","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":16745233,"name":"libva","full_name":"01org/libva","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars1.githubusercontent.com/u/1635439?v=4","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/libva","description":"Libva is an implementation for VA-API (VIdeo Acceleration API)","fork":false,"url":"https://api.github.com/repos/01org/libva","forks_url":"https://api.github.com/repos/01org/libva/forks","keys_url":"https://api.github.com/repos/01org/libva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/libva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/libva/teams","hooks_url":"https://api.github.com/repos/01org/libva/hooks","issue_events_url":"https://api.github.com/repos/01org/libva/issues/events{/number}","events_url":"https://api.github.com/repos/01org/libva/events","assignees_url":"https://api.github.com/repos/01org/libva/assignees{/user}","branches_url":"https://api.github.com/repos/01org/libva/branches{/branch}","tags_url":"https://api.github.com/repos/01org/libva/tags","blobs_url":"https://api.github.com/repos/01org/libva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/libva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/libva/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/libva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/libva/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/libva/languages","stargazers_url":"https://api.github.com/repos/01org/libva/stargazers","contributors_url":"https://api.github.com/repos/01org/libva/contributors","subscribers_url":"https://api.github.com/repos/01org/libva/subscribers","subscription_url":"https://api.github.com/repos/01org/libva/subscription","commits_url":"https://api.github.com/repos/01org/libva/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/libva/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/libva/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/libva/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/libva/contents/{+path}","compare_url":"https://api.github.com/repos/01org/libva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/libva/merges","archive_url":"https://api.github.com/repos/01org/libva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/libva/downloads","issues_url":"https://api.github.com/repos/01org/libva/issues{/number}","pulls_url":"https://api.github.com/repos/01org/libva/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/libva/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/libva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/libva/labels{/name}","releases_url":"https://api.github.com/repos/01org/libva/releases{/id}","deployments_url":"https://api.github.com/repos/01org/libva/deployments","created_at":"2014-02-11T20:57:42Z","updated_at":"2017-11-11T18:55:52Z","pushed_at":"2017-11-14T08:39:41Z","git_url":"git://github.com/01org/libva.git","ssh_url":"git@github.com:01org/libva.git","clone_url":"https://github.com/01org/libva.git","svn_url":"https://github.com/01org/libva","homepage":"https://01.org/linuxmedia","size":3856,"stargazers_count":49,"watchers_count":49,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":29,"forks":56,"open_issues":29,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/libva/pulls/86"},"html":{"href":"https://github.com/01org/libva/pull/86"},"issue":{"href":"https://api.github.com/repos/01org/libva/issues/86"},"comments":{"href":"https://api.github.com/repos/01org/libva/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/libva/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/libva/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/libva/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/01org/libva/statuses/c17ee19bcdc4cd5e6615fb0026361da3350f3893"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"xhaihao"}}