{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/comments/114426285","pull_request_review_id":35891613,"id":114426285,"diff_hunk":"@@ -87,13 +87,18 @@ polymer-bundler as a library has two exported function.\n \n `polymer-bundler` constructor takes an object of options similar to the command line options:\n \n-- `excludes`: URLs to exclude from inlining. URLs may represent files or folders. HTML tags referencing excluded URLs are preserved.\n-- `inlineCss`: Inline external stylesheets.\n-- `inlineScripts`: Inline external scripts.\n-- `sourcemaps`: Honor (or create) sourcemaps for inline scripts\n-- `stripComments`: Remove non-license HTML comments.\n+- `analyzer`: An instance of `Analyzer` (from `polymer-analyzer` package) which provides analysis of and access to files to operate on.\n+- `excludes`: Array of URLs to exclude from inlining. URLs may represent files or folders. HTML tags referencing excluded URLs are preserved.\n+- `inlineCss`: Inlines content of external stylesheets, i.e. `<link rel=\"stylesheet\" href=\"...\">`, into `<style>` tags in the bundled html.  Defaults to `true`.\n+- `inlineScripts`: Inline content of external scripts, i.e. `<script src=\"...\">`, into `<script>` tags in the bundled html.  Defaults to `true`.","path":"README.md","position":25,"original_position":25,"commit_id":"71587b19e72963b5cc42110c315ee2395a06e873","original_commit_id":"71587b19e72963b5cc42110c315ee2395a06e873","user":{"login":"FredKSchott","id":622227,"avatar_url":"https://avatars2.githubusercontent.com/u/622227?v=3","gravatar_id":"","url":"https://api.github.com/users/FredKSchott","html_url":"https://github.com/FredKSchott","followers_url":"https://api.github.com/users/FredKSchott/followers","following_url":"https://api.github.com/users/FredKSchott/following{/other_user}","gists_url":"https://api.github.com/users/FredKSchott/gists{/gist_id}","starred_url":"https://api.github.com/users/FredKSchott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredKSchott/subscriptions","organizations_url":"https://api.github.com/users/FredKSchott/orgs","repos_url":"https://api.github.com/users/FredKSchott/repos","events_url":"https://api.github.com/users/FredKSchott/events{/privacy}","received_events_url":"https://api.github.com/users/FredKSchott/received_events","type":"User","site_admin":false},"body":"> i.e. `<script src=\"...\">`, into `<script>` tags in the bundled html.\r\n\r\nI don't understand this sentence :/","created_at":"2017-05-02T21:11:16Z","updated_at":"2017-05-02T21:20:39Z","html_url":"https://github.com/Polymer/polymer-bundler/pull/492#discussion_r114426285","pull_request_url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/comments/114426285"},"html":{"href":"https://github.com/Polymer/polymer-bundler/pull/492#discussion_r114426285"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492","id":118643081,"html_url":"https://github.com/Polymer/polymer-bundler/pull/492","diff_url":"https://github.com/Polymer/polymer-bundler/pull/492.diff","patch_url":"https://github.com/Polymer/polymer-bundler/pull/492.patch","issue_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues/492","number":492,"state":"open","locked":false,"title":"Updated README with more details on options supported.","user":{"login":"usergenic","id":578,"avatar_url":"https://avatars1.githubusercontent.com/u/578?v=3","gravatar_id":"","url":"https://api.github.com/users/usergenic","html_url":"https://github.com/usergenic","followers_url":"https://api.github.com/users/usergenic/followers","following_url":"https://api.github.com/users/usergenic/following{/other_user}","gists_url":"https://api.github.com/users/usergenic/gists{/gist_id}","starred_url":"https://api.github.com/users/usergenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usergenic/subscriptions","organizations_url":"https://api.github.com/users/usergenic/orgs","repos_url":"https://api.github.com/users/usergenic/repos","events_url":"https://api.github.com/users/usergenic/events{/privacy}","received_events_url":"https://api.github.com/users/usergenic/received_events","type":"User","site_admin":false},"body":"Wanted to give a little better guidance on the options for bundler.  I'm linking to this from build readme","created_at":"2017-05-02T20:48:26Z","updated_at":"2017-05-02T21:20:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3958608cab56ed8c081adf62b76daf4d7b42560","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues/492/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer-bundler/statuses/71587b19e72963b5cc42110c315ee2395a06e873","head":{"label":"Polymer:update-readme","ref":"update-readme","sha":"71587b19e72963b5cc42110c315ee2395a06e873","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":13599100,"name":"polymer-bundler","full_name":"Polymer/polymer-bundler","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-bundler","description":"Build tool for HTMLImports and Web Components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-bundler","forks_url":"https://api.github.com/repos/Polymer/polymer-bundler/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-bundler/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-bundler/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-bundler/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-bundler/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-bundler/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-bundler/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-bundler/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-bundler/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-bundler/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-bundler/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-bundler/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-bundler/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-bundler/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-bundler/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-bundler/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-bundler/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-bundler/deployments","created_at":"2013-10-15T18:56:20Z","updated_at":"2017-04-24T13:16:20Z","pushed_at":"2017-05-02T20:48:26Z","git_url":"git://github.com/Polymer/polymer-bundler.git","ssh_url":"git@github.com:Polymer/polymer-bundler.git","clone_url":"https://github.com/Polymer/polymer-bundler.git","svn_url":"https://github.com/Polymer/polymer-bundler","homepage":"","size":1440,"stargazers_count":1198,"watchers_count":1198,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":91,"forks":130,"open_issues":91,"watchers":1198,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"52bc7824ea5965b3d2cbdfe994d0a7e626e51c62","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":13599100,"name":"polymer-bundler","full_name":"Polymer/polymer-bundler","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-bundler","description":"Build tool for HTMLImports and Web Components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-bundler","forks_url":"https://api.github.com/repos/Polymer/polymer-bundler/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-bundler/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-bundler/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-bundler/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-bundler/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-bundler/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-bundler/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-bundler/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-bundler/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-bundler/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-bundler/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-bundler/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-bundler/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-bundler/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-bundler/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-bundler/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-bundler/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-bundler/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-bundler/deployments","created_at":"2013-10-15T18:56:20Z","updated_at":"2017-04-24T13:16:20Z","pushed_at":"2017-05-02T20:48:26Z","git_url":"git://github.com/Polymer/polymer-bundler.git","ssh_url":"git@github.com:Polymer/polymer-bundler.git","clone_url":"https://github.com/Polymer/polymer-bundler.git","svn_url":"https://github.com/Polymer/polymer-bundler","homepage":"","size":1440,"stargazers_count":1198,"watchers_count":1198,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":91,"forks":130,"open_issues":91,"watchers":1198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492"},"html":{"href":"https://github.com/Polymer/polymer-bundler/pull/492"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/issues/492"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/issues/492/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/pulls/492/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer-bundler/statuses/71587b19e72963b5cc42110c315ee2395a06e873"}}}}
{"actor":{"display_login":"FredKSchott"}}