{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/128387043","pull_request_review_id":51059016,"id":128387043,"diff_hunk":"@@ -0,0 +1,68 @@\n+###############################################################################\n+#\n+# (c) Copyright IBM Corp. 2017, 2017\n+#\n+#  This program and the accompanying materials are made available\n+#  under the terms of the Eclipse Public License v1.0 and\n+#  Apache License v2.0 which accompanies this distribution.\n+#\n+#      The Eclipse Public License is available at\n+#      http://www.eclipse.org/legal/epl-v10.html\n+#\n+#      The Apache License v2.0 is available at\n+#      http://www.opensource.org/licenses/apache2.0.php\n+#\n+# Contributors:\n+#    Multiple authors (IBM Corp.) - initial implementation and documentation\n+###############################################################################\n+\n+\n+compiler_library(x \n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/BinaryCommutativeAnalyser.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/BinaryEvaluator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/CompareAnalyser.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/ConstantDataSnippet.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/ControlFlowEvaluator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/DataSnippet.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/DivideCheckSnippet.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/FPBinaryArithmeticAnalyser.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/FPCompareAnalyser.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/FPTreeEvaluator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/SIMDTreeEvaluator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/HelperCallSnippet.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/IA32LinkageUtils.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/IntegerMultiplyDecomposer.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRMemoryReference.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OpBinary.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OpNames.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OutlinedInstructions.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/RegisterRematerialization.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/SubtractAnalyser.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/Trampoline.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRTreeEvaluator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/UnaryEvaluator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/X86BinaryEncoding.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/X86Debug.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/X86FPConversionSnippet.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRInstruction.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRX86Instruction.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRMachine.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRLinkage.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRRegister.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRRealRegister.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRRegisterDependency.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRSnippet.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/X86SystemLinkage.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/XMMBinaryArithmeticAnalyser.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRCodeGenerator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/codegen/OMRRegisterIterator.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/env/OMRCPU.cpp\n+\t${CMAKE_CURRENT_SOURCE_DIR}/env/OMRDebugEnv.cpp\n+\t$<$<EQUAL:${OMR_TARGET_DATASIZE},64>: ${CMAKE_CURRENT_SOURCE_DIR}/amd64/codegen/OMRCodeGenerator.cpp> ","path":"compiler/x/CMakeLists.txt","position":61,"original_position":61,"commit_id":"42f79c2f077ca19c87d27fd7fbcf0bd535deef29","original_commit_id":"42f79c2f077ca19c87d27fd7fbcf0bd535deef29","user":{"login":"dnakamura","id":12418336,"avatar_url":"https://avatars1.githubusercontent.com/u/12418336?v=4","gravatar_id":"","url":"https://api.github.com/users/dnakamura","html_url":"https://github.com/dnakamura","followers_url":"https://api.github.com/users/dnakamura/followers","following_url":"https://api.github.com/users/dnakamura/following{/other_user}","gists_url":"https://api.github.com/users/dnakamura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnakamura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnakamura/subscriptions","organizations_url":"https://api.github.com/users/dnakamura/orgs","repos_url":"https://api.github.com/users/dnakamura/repos","events_url":"https://api.github.com/users/dnakamura/events{/privacy}","received_events_url":"https://api.github.com/users/dnakamura/received_events","type":"User","site_admin":false},"body":"due to the way generator expressions work, I dont think this will play nice with your object filtering mechanism.","created_at":"2017-07-19T22:44:31Z","updated_at":"2017-07-19T22:52:31Z","html_url":"https://github.com/eclipse/omr/pull/1372#discussion_r128387043","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/1372","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/128387043"},"html":{"href":"https://github.com/eclipse/omr/pull/1372#discussion_r128387043"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1372"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/1372","id":131165964,"html_url":"https://github.com/eclipse/omr/pull/1372","diff_url":"https://github.com/eclipse/omr/pull/1372.diff","patch_url":"https://github.com/eclipse/omr/pull/1372.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/1372","number":1372,"state":"open","locked":false,"title":"Initial support for building compiler with CMake","user":{"login":"mgaudet","id":2906003,"avatar_url":"https://avatars3.githubusercontent.com/u/2906003?v=4","gravatar_id":"","url":"https://api.github.com/users/mgaudet","html_url":"https://github.com/mgaudet","followers_url":"https://api.github.com/users/mgaudet/followers","following_url":"https://api.github.com/users/mgaudet/following{/other_user}","gists_url":"https://api.github.com/users/mgaudet/gists{/gist_id}","starred_url":"https://api.github.com/users/mgaudet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgaudet/subscriptions","organizations_url":"https://api.github.com/users/mgaudet/orgs","repos_url":"https://api.github.com/users/mgaudet/repos","events_url":"https://api.github.com/users/mgaudet/events{/privacy}","received_events_url":"https://api.github.com/users/mgaudet/received_events","type":"User","site_admin":false},"body":"As well as a small number of changes to the existing CMake support. ","created_at":"2017-07-18T19:18:59Z","updated_at":"2017-07-19T22:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90f7e7678642f60c13b1b88616b7027539f4ad8e","assignee":{"login":"0xdaryl","id":17713611,"avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false},"assignees":[{"login":"0xdaryl","id":17713611,"avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/1372/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/1372/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/1372/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/42f79c2f077ca19c87d27fd7fbcf0bd535deef29","head":{"label":"mgaudet:CmakeDelivery","ref":"CmakeDelivery","sha":"42f79c2f077ca19c87d27fd7fbcf0bd535deef29","user":{"login":"mgaudet","id":2906003,"avatar_url":"https://avatars3.githubusercontent.com/u/2906003?v=4","gravatar_id":"","url":"https://api.github.com/users/mgaudet","html_url":"https://github.com/mgaudet","followers_url":"https://api.github.com/users/mgaudet/followers","following_url":"https://api.github.com/users/mgaudet/following{/other_user}","gists_url":"https://api.github.com/users/mgaudet/gists{/gist_id}","starred_url":"https://api.github.com/users/mgaudet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgaudet/subscriptions","organizations_url":"https://api.github.com/users/mgaudet/orgs","repos_url":"https://api.github.com/users/mgaudet/repos","events_url":"https://api.github.com/users/mgaudet/events{/privacy}","received_events_url":"https://api.github.com/users/mgaudet/received_events","type":"User","site_admin":false},"repo":{"id":53355334,"name":"omr","full_name":"mgaudet/omr","owner":{"login":"mgaudet","id":2906003,"avatar_url":"https://avatars3.githubusercontent.com/u/2906003?v=4","gravatar_id":"","url":"https://api.github.com/users/mgaudet","html_url":"https://github.com/mgaudet","followers_url":"https://api.github.com/users/mgaudet/followers","following_url":"https://api.github.com/users/mgaudet/following{/other_user}","gists_url":"https://api.github.com/users/mgaudet/gists{/gist_id}","starred_url":"https://api.github.com/users/mgaudet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgaudet/subscriptions","organizations_url":"https://api.github.com/users/mgaudet/orgs","repos_url":"https://api.github.com/users/mgaudet/repos","events_url":"https://api.github.com/users/mgaudet/events{/privacy}","received_events_url":"https://api.github.com/users/mgaudet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgaudet/omr","description":"OMR project","fork":true,"url":"https://api.github.com/repos/mgaudet/omr","forks_url":"https://api.github.com/repos/mgaudet/omr/forks","keys_url":"https://api.github.com/repos/mgaudet/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgaudet/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgaudet/omr/teams","hooks_url":"https://api.github.com/repos/mgaudet/omr/hooks","issue_events_url":"https://api.github.com/repos/mgaudet/omr/issues/events{/number}","events_url":"https://api.github.com/repos/mgaudet/omr/events","assignees_url":"https://api.github.com/repos/mgaudet/omr/assignees{/user}","branches_url":"https://api.github.com/repos/mgaudet/omr/branches{/branch}","tags_url":"https://api.github.com/repos/mgaudet/omr/tags","blobs_url":"https://api.github.com/repos/mgaudet/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgaudet/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgaudet/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgaudet/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgaudet/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/mgaudet/omr/languages","stargazers_url":"https://api.github.com/repos/mgaudet/omr/stargazers","contributors_url":"https://api.github.com/repos/mgaudet/omr/contributors","subscribers_url":"https://api.github.com/repos/mgaudet/omr/subscribers","subscription_url":"https://api.github.com/repos/mgaudet/omr/subscription","commits_url":"https://api.github.com/repos/mgaudet/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgaudet/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgaudet/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgaudet/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgaudet/omr/contents/{+path}","compare_url":"https://api.github.com/repos/mgaudet/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgaudet/omr/merges","archive_url":"https://api.github.com/repos/mgaudet/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgaudet/omr/downloads","issues_url":"https://api.github.com/repos/mgaudet/omr/issues{/number}","pulls_url":"https://api.github.com/repos/mgaudet/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/mgaudet/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/mgaudet/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgaudet/omr/labels{/name}","releases_url":"https://api.github.com/repos/mgaudet/omr/releases{/id}","deployments_url":"https://api.github.com/repos/mgaudet/omr/deployments","created_at":"2016-03-07T20:07:15Z","updated_at":"2016-10-18T14:28:46Z","pushed_at":"2017-07-19T20:45:54Z","git_url":"git://github.com/mgaudet/omr.git","ssh_url":"git@github.com:mgaudet/omr.git","clone_url":"https://github.com/mgaudet/omr.git","svn_url":"https://github.com/mgaudet/omr","homepage":null,"size":25451,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"cebe4b7dbd0a4682b8c27ed5e0eeb39310619b95","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2017-07-07T00:27:04Z","pushed_at":"2017-07-19T22:45:49Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":14934,"stargazers_count":344,"watchers_count":344,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":180,"forks":146,"open_issues":180,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1372"},"html":{"href":"https://github.com/eclipse/omr/pull/1372"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/1372"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/1372/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1372/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1372/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/42f79c2f077ca19c87d27fd7fbcf0bd535deef29"}}}}
{"actor":{"display_login":"dnakamura"}}