{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/13466","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/13466/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/13466/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/13466/events","html_url":"https://github.com/facebook/react-native/pull/13466","id":221228466,"number":13466,"title":"Removed RCTLogWarn about \"Required dispatch_sync ... that my lead to deadlocks\"","user":{"login":"atkit","id":660472,"avatar_url":"https://avatars2.githubusercontent.com/u/660472?v=3","gravatar_id":"","url":"https://api.github.com/users/atkit","html_url":"https://github.com/atkit","followers_url":"https://api.github.com/users/atkit/followers","following_url":"https://api.github.com/users/atkit/following{/other_user}","gists_url":"https://api.github.com/users/atkit/gists{/gist_id}","starred_url":"https://api.github.com/users/atkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atkit/subscriptions","organizations_url":"https://api.github.com/users/atkit/orgs","repos_url":"https://api.github.com/users/atkit/repos","events_url":"https://api.github.com/users/atkit/events{/privacy}","received_events_url":"https://api.github.com/users/atkit/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":172176599,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-12T11:10:29Z","updated_at":"2017-04-12T11:47:19Z","closed_at":"2017-04-12T11:47:19Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/13466","html_url":"https://github.com/facebook/react-native/pull/13466","diff_url":"https://github.com/facebook/react-native/pull/13466.diff","patch_url":"https://github.com/facebook/react-native/pull/13466.patch"},"body":"As the next line calls RCTUnsafeExecuteOnMainQueueSync which checks RCTIsMainQueue as well and calls block as is if it is on main queue.\r\n\r\n## Motivation (required)\r\n\r\nWhat existing problem does the pull request solve?\r\n\r\nCurrently in master when method gatherConstants is called we check RCTIsMainQueue and show warning about possible issues, but later we call RCTUnsafeExecuteOnMainQueueSync which in its turn check RCTIsMainQueue again can if it is true handles the case by calling block as is (without dispatch).\r\n\r\nI found this warning useless and misleading.\r\n\r\n## Test Plan (required)\r\n\r\n1. This simple change that removes warning message and does not affect functionality, \r\n2. All tests are passed.\r\n3. Additionally we can create Module which prepares constants and load it into ReactNative to see that it is still works and does not produce any Warnings. \r\n\r\n## Next Steps\r\n\r\nSigned CLA"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/293552612","html_url":"https://github.com/facebook/react-native/pull/13466#issuecomment-293552612","issue_url":"https://api.github.com/repos/facebook/react-native/issues/13466","id":293552612,"user":{"login":"javache","id":5676,"avatar_url":"https://avatars0.githubusercontent.com/u/5676?v=3","gravatar_id":"","url":"https://api.github.com/users/javache","html_url":"https://github.com/javache","followers_url":"https://api.github.com/users/javache/followers","following_url":"https://api.github.com/users/javache/following{/other_user}","gists_url":"https://api.github.com/users/javache/gists{/gist_id}","starred_url":"https://api.github.com/users/javache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javache/subscriptions","organizations_url":"https://api.github.com/users/javache/orgs","repos_url":"https://api.github.com/users/javache/repos","events_url":"https://api.github.com/users/javache/events{/privacy}","received_events_url":"https://api.github.com/users/javache/received_events","type":"User","site_admin":false},"created_at":"2017-04-12T11:47:19Z","updated_at":"2017-04-12T11:47:19Z","body":"This is currently an issue with the BatchedBridge that is fixed in the new implementation (CxxBridge). The warning is useful as it reveals a real issue with the current implementation."}}
{"actor":{"display_login":"javache"}}