{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41924","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41924/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41924/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41924/events","html_url":"https://github.com/kubernetes/kubernetes/pull/41924","id":209583261,"number":41924,"title":"make edit respect --save-config","user":{"login":"ymqytw","id":2589105,"avatar_url":"https://avatars2.githubusercontent.com/u/2589105?v=3","gravatar_id":"","url":"https://api.github.com/users/ymqytw","html_url":"https://github.com/ymqytw","followers_url":"https://api.github.com/users/ymqytw/followers","following_url":"https://api.github.com/users/ymqytw/following{/other_user}","gists_url":"https://api.github.com/users/ymqytw/gists{/gist_id}","starred_url":"https://api.github.com/users/ymqytw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymqytw/subscriptions","organizations_url":"https://api.github.com/users/ymqytw/orgs","repos_url":"https://api.github.com/users/ymqytw/repos","events_url":"https://api.github.com/users/ymqytw/events{/privacy}","received_events_url":"https://api.github.com/users/ymqytw/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars3.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"assignees":[{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars3.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":"","creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars2.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":262,"closed_issues":571,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2017-03-02T15:40:04Z","due_on":"2017-03-22T07:00:00Z","closed_at":null},"comments":28,"created_at":"2017-02-22T21:15:19Z","updated_at":"2017-03-02T16:41:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41924","html_url":"https://github.com/kubernetes/kubernetes/pull/41924","diff_url":"https://github.com/kubernetes/kubernetes/pull/41924.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/41924.patch"},"body":"New behavior:\r\n\r\nedit:\r\n1) the flag is set to true: it will create or update the last-applied-config annotation\r\n2) the flag is set to false or is unspecified: NOP\r\n\r\nreplace:\r\n1) If saveConfig is true, create or update the annotation.\r\n2) If saveConfig is false and the local config file doesn't have the annotation, we save the annotation from the live object if there is one (Try to not surprise the users).\r\n3) If saveConfig is false and the local config file has the annotation, we use the annotation in the config file.\r\n4) Same behavior for force replacing\r\n\r\nfixes #40626\r\n\r\n```release-note\r\nstop kubectl edit from updating the last-applied-configuration annotation when --save-config is unspecified or false.\r\n```\r\n\r\n@pwittrock @liggitt \r\n\r\nThis is a bug fix that prevented `edit` from being respected by `apply`"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/283707064","html_url":"https://github.com/kubernetes/kubernetes/pull/41924#issuecomment-283707064","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41924","id":283707064,"user":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars3.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"created_at":"2017-03-02T16:41:55Z","updated_at":"2017-03-02T16:41:55Z","body":"/approve"}}
{"actor":{"display_login":"pwittrock"}}