{"action":"created","comment":{"url":"https://api.github.com/repos/kete/kete/pulls/comments/124500310","pull_request_review_id":46792670,"id":124500310,"diff_hunk":"@@ -1449,61 +1396,61 @@ def show_privacy_controls?(basket = @current_basket)\n   def show_privacy_search_controls?\n     if @current_basket == @site_basket\n       # note that it has to be \"== true\" in combination with ||, or you will get unexpected results when show_privacy_controls is not nil and == false\n-      (@site_basket.show_privacy_controls == true or Basket.privacy_exists)\n+      ((@site_basket.show_privacy_controls == true) || Basket.privacy_exists)\n     else\n       @current_basket.show_privacy_controls_with_inheritance?\n     end\n   end\n \n   # Check whether to show privacy controls for an item\n-  def show_privacy_controls_for?(item, basket=nil)\n+  def show_privacy_controls_for?(item, basket = nil)\n     basket = (basket || item.basket)\n     show_privacy_controls_for_basket?(basket) &&\n-      ( item.new_record? ||\n+      (item.new_record? ||\n         current_user_can_see_private_files_in_basket?(basket) ||\n-        @current_user == item.creator )\n+        @current_user == item.creator)\n   end\n \n   # Controls for search sorting on pages like basket list and basket members list\n-  def search_sorting_controls_for(sort_text, sort_type, main_sort_order=false, default_direction='asc', remote_link = false)\n+  def search_sorting_controls_for(sort_text, sort_type, main_sort_order = false, default_direction = 'asc', remote_link = false)\n     # if searching, get the current sort direction else use the default order\n     direction = (params[:order] == sort_type ? params[:direction] : nil) || default_direction\n \n     # using the current sort direction, create the image we'll use display\n     if direction == 'desc'\n-      direction_image = image_tag('arrow_down.gif', :alt => t('application_helper.search_sorting_controls_for.descending'), :class => 'sorting_control', :width => 16, :height => 7)\n+      direction_image = image_tag('arrow_down.gif', alt: t('application_helper.search_sorting_controls_for.descending'), class: 'sorting_control', width: 16, height: 7)","path":"app/helpers/application_helper.rb","position":1637,"original_position":1637,"commit_id":"a91f98790ed4b251a53b8baf999e9142983b8c34","original_commit_id":"a91f98790ed4b251a53b8baf999e9142983b8c34","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long. [168/120]","created_at":"2017-06-28T10:00:43Z","updated_at":"2017-06-28T10:00:44Z","html_url":"https://github.com/kete/kete/pull/115#discussion_r124500310","pull_request_url":"https://api.github.com/repos/kete/kete/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/kete/kete/pulls/comments/124500310"},"html":{"href":"https://github.com/kete/kete/pull/115#discussion_r124500310"},"pull_request":{"href":"https://api.github.com/repos/kete/kete/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/kete/kete/pulls/115","id":127885265,"html_url":"https://github.com/kete/kete/pull/115","diff_url":"https://github.com/kete/kete/pull/115.diff","patch_url":"https://github.com/kete/kete/pull/115.patch","issue_url":"https://api.github.com/repos/kete/kete/issues/115","number":115,"state":"open","locked":false,"title":"Cleaned up lots of the application helper","user":{"login":"Br3nda","id":12266,"avatar_url":"https://avatars3.githubusercontent.com/u/12266?v=3","gravatar_id":"","url":"https://api.github.com/users/Br3nda","html_url":"https://github.com/Br3nda","followers_url":"https://api.github.com/users/Br3nda/followers","following_url":"https://api.github.com/users/Br3nda/following{/other_user}","gists_url":"https://api.github.com/users/Br3nda/gists{/gist_id}","starred_url":"https://api.github.com/users/Br3nda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Br3nda/subscriptions","organizations_url":"https://api.github.com/users/Br3nda/orgs","repos_url":"https://api.github.com/users/Br3nda/repos","events_url":"https://api.github.com/users/Br3nda/events{/privacy}","received_events_url":"https://api.github.com/users/Br3nda/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-28T10:00:35Z","updated_at":"2017-06-28T10:00:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4d964cb4eaa7851740b7451c28d8f8877596fc1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kete/kete/pulls/115/commits","review_comments_url":"https://api.github.com/repos/kete/kete/pulls/115/comments","review_comment_url":"https://api.github.com/repos/kete/kete/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kete/kete/issues/115/comments","statuses_url":"https://api.github.com/repos/kete/kete/statuses/a91f98790ed4b251a53b8baf999e9142983b8c34","head":{"label":"Br3nda:cleanup/application-helper","ref":"cleanup/application-helper","sha":"a91f98790ed4b251a53b8baf999e9142983b8c34","user":{"login":"Br3nda","id":12266,"avatar_url":"https://avatars3.githubusercontent.com/u/12266?v=3","gravatar_id":"","url":"https://api.github.com/users/Br3nda","html_url":"https://github.com/Br3nda","followers_url":"https://api.github.com/users/Br3nda/followers","following_url":"https://api.github.com/users/Br3nda/following{/other_user}","gists_url":"https://api.github.com/users/Br3nda/gists{/gist_id}","starred_url":"https://api.github.com/users/Br3nda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Br3nda/subscriptions","organizations_url":"https://api.github.com/users/Br3nda/orgs","repos_url":"https://api.github.com/users/Br3nda/repos","events_url":"https://api.github.com/users/Br3nda/events{/privacy}","received_events_url":"https://api.github.com/users/Br3nda/received_events","type":"User","site_admin":false},"repo":{"id":79742972,"name":"kete","full_name":"Br3nda/kete","owner":{"login":"Br3nda","id":12266,"avatar_url":"https://avatars3.githubusercontent.com/u/12266?v=3","gravatar_id":"","url":"https://api.github.com/users/Br3nda","html_url":"https://github.com/Br3nda","followers_url":"https://api.github.com/users/Br3nda/followers","following_url":"https://api.github.com/users/Br3nda/following{/other_user}","gists_url":"https://api.github.com/users/Br3nda/gists{/gist_id}","starred_url":"https://api.github.com/users/Br3nda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Br3nda/subscriptions","organizations_url":"https://api.github.com/users/Br3nda/orgs","repos_url":"https://api.github.com/users/Br3nda/repos","events_url":"https://api.github.com/users/Br3nda/events{/privacy}","received_events_url":"https://api.github.com/users/Br3nda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Br3nda/kete","description":"Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.","fork":true,"url":"https://api.github.com/repos/Br3nda/kete","forks_url":"https://api.github.com/repos/Br3nda/kete/forks","keys_url":"https://api.github.com/repos/Br3nda/kete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Br3nda/kete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Br3nda/kete/teams","hooks_url":"https://api.github.com/repos/Br3nda/kete/hooks","issue_events_url":"https://api.github.com/repos/Br3nda/kete/issues/events{/number}","events_url":"https://api.github.com/repos/Br3nda/kete/events","assignees_url":"https://api.github.com/repos/Br3nda/kete/assignees{/user}","branches_url":"https://api.github.com/repos/Br3nda/kete/branches{/branch}","tags_url":"https://api.github.com/repos/Br3nda/kete/tags","blobs_url":"https://api.github.com/repos/Br3nda/kete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Br3nda/kete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Br3nda/kete/git/refs{/sha}","trees_url":"https://api.github.com/repos/Br3nda/kete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Br3nda/kete/statuses/{sha}","languages_url":"https://api.github.com/repos/Br3nda/kete/languages","stargazers_url":"https://api.github.com/repos/Br3nda/kete/stargazers","contributors_url":"https://api.github.com/repos/Br3nda/kete/contributors","subscribers_url":"https://api.github.com/repos/Br3nda/kete/subscribers","subscription_url":"https://api.github.com/repos/Br3nda/kete/subscription","commits_url":"https://api.github.com/repos/Br3nda/kete/commits{/sha}","git_commits_url":"https://api.github.com/repos/Br3nda/kete/git/commits{/sha}","comments_url":"https://api.github.com/repos/Br3nda/kete/comments{/number}","issue_comment_url":"https://api.github.com/repos/Br3nda/kete/issues/comments{/number}","contents_url":"https://api.github.com/repos/Br3nda/kete/contents/{+path}","compare_url":"https://api.github.com/repos/Br3nda/kete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Br3nda/kete/merges","archive_url":"https://api.github.com/repos/Br3nda/kete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Br3nda/kete/downloads","issues_url":"https://api.github.com/repos/Br3nda/kete/issues{/number}","pulls_url":"https://api.github.com/repos/Br3nda/kete/pulls{/number}","milestones_url":"https://api.github.com/repos/Br3nda/kete/milestones{/number}","notifications_url":"https://api.github.com/repos/Br3nda/kete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Br3nda/kete/labels{/name}","releases_url":"https://api.github.com/repos/Br3nda/kete/releases{/id}","deployments_url":"https://api.github.com/repos/Br3nda/kete/deployments","created_at":"2017-01-22T20:18:47Z","updated_at":"2017-01-22T20:18:51Z","pushed_at":"2017-06-28T09:59:32Z","git_url":"git://github.com/Br3nda/kete.git","ssh_url":"git@github.com:Br3nda/kete.git","clone_url":"https://github.com/Br3nda/kete.git","svn_url":"https://github.com/Br3nda/kete","homepage":"http://kete.net.nz/","size":25977,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kete2"}},"base":{"label":"kete:master","ref":"master","sha":"3d0c604620b3bb09929bc7324cc89e43f6b64d87","user":{"login":"kete","id":16226,"avatar_url":"https://avatars3.githubusercontent.com/u/16226?v=3","gravatar_id":"","url":"https://api.github.com/users/kete","html_url":"https://github.com/kete","followers_url":"https://api.github.com/users/kete/followers","following_url":"https://api.github.com/users/kete/following{/other_user}","gists_url":"https://api.github.com/users/kete/gists{/gist_id}","starred_url":"https://api.github.com/users/kete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kete/subscriptions","organizations_url":"https://api.github.com/users/kete/orgs","repos_url":"https://api.github.com/users/kete/repos","events_url":"https://api.github.com/users/kete/events{/privacy}","received_events_url":"https://api.github.com/users/kete/received_events","type":"Organization","site_admin":false},"repo":{"id":33876,"name":"kete","full_name":"kete/kete","owner":{"login":"kete","id":16226,"avatar_url":"https://avatars3.githubusercontent.com/u/16226?v=3","gravatar_id":"","url":"https://api.github.com/users/kete","html_url":"https://github.com/kete","followers_url":"https://api.github.com/users/kete/followers","following_url":"https://api.github.com/users/kete/following{/other_user}","gists_url":"https://api.github.com/users/kete/gists{/gist_id}","starred_url":"https://api.github.com/users/kete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kete/subscriptions","organizations_url":"https://api.github.com/users/kete/orgs","repos_url":"https://api.github.com/users/kete/repos","events_url":"https://api.github.com/users/kete/events{/privacy}","received_events_url":"https://api.github.com/users/kete/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kete/kete","description":"Kete was developed by Horowhenua Library Trust and Katipo Communications Ltd. to build a digital library of Horowhenua material.","fork":false,"url":"https://api.github.com/repos/kete/kete","forks_url":"https://api.github.com/repos/kete/kete/forks","keys_url":"https://api.github.com/repos/kete/kete/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kete/kete/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kete/kete/teams","hooks_url":"https://api.github.com/repos/kete/kete/hooks","issue_events_url":"https://api.github.com/repos/kete/kete/issues/events{/number}","events_url":"https://api.github.com/repos/kete/kete/events","assignees_url":"https://api.github.com/repos/kete/kete/assignees{/user}","branches_url":"https://api.github.com/repos/kete/kete/branches{/branch}","tags_url":"https://api.github.com/repos/kete/kete/tags","blobs_url":"https://api.github.com/repos/kete/kete/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kete/kete/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kete/kete/git/refs{/sha}","trees_url":"https://api.github.com/repos/kete/kete/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kete/kete/statuses/{sha}","languages_url":"https://api.github.com/repos/kete/kete/languages","stargazers_url":"https://api.github.com/repos/kete/kete/stargazers","contributors_url":"https://api.github.com/repos/kete/kete/contributors","subscribers_url":"https://api.github.com/repos/kete/kete/subscribers","subscription_url":"https://api.github.com/repos/kete/kete/subscription","commits_url":"https://api.github.com/repos/kete/kete/commits{/sha}","git_commits_url":"https://api.github.com/repos/kete/kete/git/commits{/sha}","comments_url":"https://api.github.com/repos/kete/kete/comments{/number}","issue_comment_url":"https://api.github.com/repos/kete/kete/issues/comments{/number}","contents_url":"https://api.github.com/repos/kete/kete/contents/{+path}","compare_url":"https://api.github.com/repos/kete/kete/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kete/kete/merges","archive_url":"https://api.github.com/repos/kete/kete/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kete/kete/downloads","issues_url":"https://api.github.com/repos/kete/kete/issues{/number}","pulls_url":"https://api.github.com/repos/kete/kete/pulls{/number}","milestones_url":"https://api.github.com/repos/kete/kete/milestones{/number}","notifications_url":"https://api.github.com/repos/kete/kete/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kete/kete/labels{/name}","releases_url":"https://api.github.com/repos/kete/kete/releases{/id}","deployments_url":"https://api.github.com/repos/kete/kete/deployments","created_at":"2008-07-14T07:19:24Z","updated_at":"2017-06-13T22:16:35Z","pushed_at":"2017-06-28T10:00:36Z","git_url":"git://github.com/kete/kete.git","ssh_url":"git@github.com:kete/kete.git","clone_url":"https://github.com/kete/kete.git","svn_url":"https://github.com/kete/kete","homepage":"http://kete.net.nz/","size":25961,"stargazers_count":58,"watchers_count":58,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kete/kete/pulls/115"},"html":{"href":"https://github.com/kete/kete/pull/115"},"issue":{"href":"https://api.github.com/repos/kete/kete/issues/115"},"comments":{"href":"https://api.github.com/repos/kete/kete/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/kete/kete/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/kete/kete/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kete/kete/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/kete/kete/statuses/a91f98790ed4b251a53b8baf999e9142983b8c34"}}}}
{"actor":{"display_login":"houndci-bot"}}