{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/154705613","pull_request_review_id":80908562,"id":154705613,"diff_hunk":"@@ -53,6 +53,11 @@ define( [\n \t\tdiv = null;\n \t}\n \n+\t// Rounding up the exact checking match values\n+\tfunction roundPixelMeasures( measure ) {\n+\t\treturn Math.round( parseFloat( measure ) ) + \"px\";","path":"src/css/support.js","position":26,"original_position":26,"commit_id":"4dfb299253d769fafe12f33265f17f40059a0553","original_commit_id":"4dfb299253d769fafe12f33265f17f40059a0553","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars3.githubusercontent.com/u/1199584?v=4","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"Adding \"px\" seems pointless, we should just return and compare against the numeric value (saving a few bytes).","created_at":"2017-12-04T16:48:44Z","updated_at":"2017-12-04T16:56:04Z","html_url":"https://github.com/jquery/jquery/pull/3872#discussion_r154705613","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/3872","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/154705613"},"html":{"href":"https://github.com/jquery/jquery/pull/3872#discussion_r154705613"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3872"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/3872","id":156148712,"html_url":"https://github.com/jquery/jquery/pull/3872","diff_url":"https://github.com/jquery/jquery/pull/3872.diff","patch_url":"https://github.com/jquery/jquery/pull/3872.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/3872","number":3872,"state":"open","locked":false,"title":"Fix the width calculation of border-box due to browser zoom","user":{"login":"SaptakS","id":9530293,"avatar_url":"https://avatars2.githubusercontent.com/u/9530293?v=4","gravatar_id":"","url":"https://api.github.com/users/SaptakS","html_url":"https://github.com/SaptakS","followers_url":"https://api.github.com/users/SaptakS/followers","following_url":"https://api.github.com/users/SaptakS/following{/other_user}","gists_url":"https://api.github.com/users/SaptakS/gists{/gist_id}","starred_url":"https://api.github.com/users/SaptakS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaptakS/subscriptions","organizations_url":"https://api.github.com/users/SaptakS/orgs","repos_url":"https://api.github.com/users/SaptakS/repos","events_url":"https://api.github.com/users/SaptakS/events{/privacy}","received_events_url":"https://api.github.com/users/SaptakS/received_events","type":"User","site_admin":false},"body":"### Summary ###\r\nThe pull request mainly has two tasks done:\r\n- Test for the issue (#3808 )\r\n- Fixing the issue by rounding off the measure to unit place.\r\n\r\nHowever the test for the issue isn't working. I used an iframe test to check for the border-box width at `html {zoom: 1.1}`. Though opening the html file separately recreates the issue, but via the unittest code, it doesn't. \r\n\r\nSome help in fixing the unittest will be really helpful.\r\n\r\n### Checklist ###\r\n<!--\r\nMark an `[x]` for completed items, if you're not sure leave them unchecked and we can assist.\r\n-->\r\n\r\n* [x] All authors have signed the CLA at https://cla.js.foundation/jquery/jquery\r\n* [ ] New tests have been added to show the fix or feature works\r\n* [x] Grunt build and unit tests pass locally with these changes\r\n* [ ] If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com\r\n\r\n<!--\r\nThanks! Bots and humans will be around shortly to check it out.\r\n-->\r\n","created_at":"2017-12-04T09:40:12Z","updated_at":"2017-12-04T16:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc5e772b93444b9211a131463d04a656e22f3570","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/3872/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/3872/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/3872/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/4dfb299253d769fafe12f33265f17f40059a0553","head":{"label":"SaptakS:css/width","ref":"css/width","sha":"4dfb299253d769fafe12f33265f17f40059a0553","user":{"login":"SaptakS","id":9530293,"avatar_url":"https://avatars2.githubusercontent.com/u/9530293?v=4","gravatar_id":"","url":"https://api.github.com/users/SaptakS","html_url":"https://github.com/SaptakS","followers_url":"https://api.github.com/users/SaptakS/followers","following_url":"https://api.github.com/users/SaptakS/following{/other_user}","gists_url":"https://api.github.com/users/SaptakS/gists{/gist_id}","starred_url":"https://api.github.com/users/SaptakS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaptakS/subscriptions","organizations_url":"https://api.github.com/users/SaptakS/orgs","repos_url":"https://api.github.com/users/SaptakS/repos","events_url":"https://api.github.com/users/SaptakS/events{/privacy}","received_events_url":"https://api.github.com/users/SaptakS/received_events","type":"User","site_admin":false},"repo":{"id":110240146,"name":"jquery","full_name":"SaptakS/jquery","owner":{"login":"SaptakS","id":9530293,"avatar_url":"https://avatars2.githubusercontent.com/u/9530293?v=4","gravatar_id":"","url":"https://api.github.com/users/SaptakS","html_url":"https://github.com/SaptakS","followers_url":"https://api.github.com/users/SaptakS/followers","following_url":"https://api.github.com/users/SaptakS/following{/other_user}","gists_url":"https://api.github.com/users/SaptakS/gists{/gist_id}","starred_url":"https://api.github.com/users/SaptakS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaptakS/subscriptions","organizations_url":"https://api.github.com/users/SaptakS/orgs","repos_url":"https://api.github.com/users/SaptakS/repos","events_url":"https://api.github.com/users/SaptakS/events{/privacy}","received_events_url":"https://api.github.com/users/SaptakS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SaptakS/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/SaptakS/jquery","forks_url":"https://api.github.com/repos/SaptakS/jquery/forks","keys_url":"https://api.github.com/repos/SaptakS/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SaptakS/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SaptakS/jquery/teams","hooks_url":"https://api.github.com/repos/SaptakS/jquery/hooks","issue_events_url":"https://api.github.com/repos/SaptakS/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/SaptakS/jquery/events","assignees_url":"https://api.github.com/repos/SaptakS/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/SaptakS/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/SaptakS/jquery/tags","blobs_url":"https://api.github.com/repos/SaptakS/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SaptakS/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SaptakS/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SaptakS/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SaptakS/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/SaptakS/jquery/languages","stargazers_url":"https://api.github.com/repos/SaptakS/jquery/stargazers","contributors_url":"https://api.github.com/repos/SaptakS/jquery/contributors","subscribers_url":"https://api.github.com/repos/SaptakS/jquery/subscribers","subscription_url":"https://api.github.com/repos/SaptakS/jquery/subscription","commits_url":"https://api.github.com/repos/SaptakS/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SaptakS/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SaptakS/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SaptakS/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SaptakS/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/SaptakS/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SaptakS/jquery/merges","archive_url":"https://api.github.com/repos/SaptakS/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SaptakS/jquery/downloads","issues_url":"https://api.github.com/repos/SaptakS/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/SaptakS/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/SaptakS/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/SaptakS/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SaptakS/jquery/labels{/name}","releases_url":"https://api.github.com/repos/SaptakS/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/SaptakS/jquery/deployments","created_at":"2017-11-10T11:31:58Z","updated_at":"2017-11-10T11:32:12Z","pushed_at":"2017-12-04T09:35:22Z","git_url":"git://github.com/SaptakS/jquery.git","ssh_url":"git@github.com:SaptakS/jquery.git","clone_url":"https://github.com/SaptakS/jquery.git","svn_url":"https://github.com/SaptakS/jquery","homepage":"https://jquery.com/","size":27431,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"0aa832afec04215ed5e14b1cc5fc287ad7939792","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars1.githubusercontent.com/u/70142?v=4","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars1.githubusercontent.com/u/70142?v=4","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/jquery/jquery/deployments","created_at":"2009-04-03T15:20:14Z","updated_at":"2017-12-04T16:14:34Z","pushed_at":"2017-12-04T09:40:13Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"https://jquery.com/","size":27430,"stargazers_count":47268,"watchers_count":47268,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":13913,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13913,"open_issues":99,"watchers":47268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3872"},"html":{"href":"https://github.com/jquery/jquery/pull/3872"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/3872"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/3872/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3872/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3872/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/4dfb299253d769fafe12f33265f17f40059a0553"}},"author_association":"NONE"}}
{"actor":{"display_login":"gibson042"}}