{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/104849097","pull_request_review_id":25702444,"id":104849097,"diff_hunk":"@@ -36,4 +37,10 @@\n    * Use the {@code binder} to create an instance of {@code StateT} appropriate for this address.\n    */\n   StateT bind(String id, StateBinder<? extends K> binder);\n+\n+  /**\n+   * Given {code coders} are inferred from type arguments defined for this class.\n+   * @param coders Array of coders indexed by the type arguments order.\n+   */\n+  void offerCoders(Coder[] coders);","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateSpec.java","position":17,"original_position":17,"commit_id":"e5d4539809b594a6d5a233d916f0403f2f9b3e04","original_commit_id":"e5d4539809b594a6d5a233d916f0403f2f9b3e04","user":{"login":"aviemzur","id":5708714,"avatar_url":"https://avatars1.githubusercontent.com/u/5708714?v=3","gravatar_id":"","url":"https://api.github.com/users/aviemzur","html_url":"https://github.com/aviemzur","followers_url":"https://api.github.com/users/aviemzur/followers","following_url":"https://api.github.com/users/aviemzur/following{/other_user}","gists_url":"https://api.github.com/users/aviemzur/gists{/gist_id}","starred_url":"https://api.github.com/users/aviemzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviemzur/subscriptions","organizations_url":"https://api.github.com/users/aviemzur/orgs","repos_url":"https://api.github.com/users/aviemzur/repos","events_url":"https://api.github.com/users/aviemzur/events{/privacy}","received_events_url":"https://api.github.com/users/aviemzur/received_events","type":"User","site_admin":false},"body":"So, as I saw it, coders that are already set take precedence, which is why implementations of this method check for coder references which are `null` coders and only set them. This is why I named the method `offerCoders` and not something like `setCoders`. I can improve the javadoc to explain this (Is there a better name for this method?).\r\n\r\nIf some coders cannot be provided and the coder is needed, the client which uses the coder will throw an exception notifying the user that a coder should have been set but was not. The user should then change their code to specify a coder explicitly using the `StateSpec` factory method which takes `Coder` arguments.\r\nI'm not sure all clients will throw an exception which explains this (I made sure that the exceptions I added to direct runner explain why you are receiving this exception) but I think this holds true for many references to coders across the project.","created_at":"2017-03-08T05:47:56Z","updated_at":"2017-03-08T05:47:56Z","html_url":"https://github.com/apache/beam/pull/2133#discussion_r104849097","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/2133","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/104849097"},"html":{"href":"https://github.com/apache/beam/pull/2133#discussion_r104849097"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/2133"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/2133","id":108470232,"html_url":"https://github.com/apache/beam/pull/2133","diff_url":"https://github.com/apache/beam/pull/2133.diff","patch_url":"https://github.com/apache/beam/pull/2133.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/2133","number":2133,"state":"open","locked":false,"title":"[BEAM-1337] Infer state coders","user":{"login":"aviemzur","id":5708714,"avatar_url":"https://avatars1.githubusercontent.com/u/5708714?v=3","gravatar_id":"","url":"https://api.github.com/users/aviemzur","html_url":"https://github.com/aviemzur","followers_url":"https://api.github.com/users/aviemzur/followers","following_url":"https://api.github.com/users/aviemzur/following{/other_user}","gists_url":"https://api.github.com/users/aviemzur/gists{/gist_id}","starred_url":"https://api.github.com/users/aviemzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviemzur/subscriptions","organizations_url":"https://api.github.com/users/aviemzur/orgs","repos_url":"https://api.github.com/users/aviemzur/repos","events_url":"https://api.github.com/users/aviemzur/events{/privacy}","received_events_url":"https://api.github.com/users/aviemzur/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n","created_at":"2017-03-01T05:28:37Z","updated_at":"2017-03-08T05:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e58fe23230297a59aca097405e9ec3c15582758","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/2133/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/2133/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/2133/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/e5d4539809b594a6d5a233d916f0403f2f9b3e04","head":{"label":"aviemzur:infer-state-coders","ref":"infer-state-coders","sha":"e5d4539809b594a6d5a233d916f0403f2f9b3e04","user":{"login":"aviemzur","id":5708714,"avatar_url":"https://avatars1.githubusercontent.com/u/5708714?v=3","gravatar_id":"","url":"https://api.github.com/users/aviemzur","html_url":"https://github.com/aviemzur","followers_url":"https://api.github.com/users/aviemzur/followers","following_url":"https://api.github.com/users/aviemzur/following{/other_user}","gists_url":"https://api.github.com/users/aviemzur/gists{/gist_id}","starred_url":"https://api.github.com/users/aviemzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviemzur/subscriptions","organizations_url":"https://api.github.com/users/aviemzur/orgs","repos_url":"https://api.github.com/users/aviemzur/repos","events_url":"https://api.github.com/users/aviemzur/events{/privacy}","received_events_url":"https://api.github.com/users/aviemzur/received_events","type":"User","site_admin":false},"repo":{"id":66561709,"name":"beam","full_name":"aviemzur/beam","owner":{"login":"aviemzur","id":5708714,"avatar_url":"https://avatars1.githubusercontent.com/u/5708714?v=3","gravatar_id":"","url":"https://api.github.com/users/aviemzur","html_url":"https://github.com/aviemzur","followers_url":"https://api.github.com/users/aviemzur/followers","following_url":"https://api.github.com/users/aviemzur/following{/other_user}","gists_url":"https://api.github.com/users/aviemzur/gists{/gist_id}","starred_url":"https://api.github.com/users/aviemzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviemzur/subscriptions","organizations_url":"https://api.github.com/users/aviemzur/orgs","repos_url":"https://api.github.com/users/aviemzur/repos","events_url":"https://api.github.com/users/aviemzur/events{/privacy}","received_events_url":"https://api.github.com/users/aviemzur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aviemzur/beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/aviemzur/beam","forks_url":"https://api.github.com/repos/aviemzur/beam/forks","keys_url":"https://api.github.com/repos/aviemzur/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aviemzur/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aviemzur/beam/teams","hooks_url":"https://api.github.com/repos/aviemzur/beam/hooks","issue_events_url":"https://api.github.com/repos/aviemzur/beam/issues/events{/number}","events_url":"https://api.github.com/repos/aviemzur/beam/events","assignees_url":"https://api.github.com/repos/aviemzur/beam/assignees{/user}","branches_url":"https://api.github.com/repos/aviemzur/beam/branches{/branch}","tags_url":"https://api.github.com/repos/aviemzur/beam/tags","blobs_url":"https://api.github.com/repos/aviemzur/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aviemzur/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aviemzur/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/aviemzur/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aviemzur/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/aviemzur/beam/languages","stargazers_url":"https://api.github.com/repos/aviemzur/beam/stargazers","contributors_url":"https://api.github.com/repos/aviemzur/beam/contributors","subscribers_url":"https://api.github.com/repos/aviemzur/beam/subscribers","subscription_url":"https://api.github.com/repos/aviemzur/beam/subscription","commits_url":"https://api.github.com/repos/aviemzur/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/aviemzur/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/aviemzur/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/aviemzur/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/aviemzur/beam/contents/{+path}","compare_url":"https://api.github.com/repos/aviemzur/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aviemzur/beam/merges","archive_url":"https://api.github.com/repos/aviemzur/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aviemzur/beam/downloads","issues_url":"https://api.github.com/repos/aviemzur/beam/issues{/number}","pulls_url":"https://api.github.com/repos/aviemzur/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/aviemzur/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/aviemzur/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aviemzur/beam/labels{/name}","releases_url":"https://api.github.com/repos/aviemzur/beam/releases{/id}","deployments_url":"https://api.github.com/repos/aviemzur/beam/deployments","created_at":"2016-08-25T13:48:02Z","updated_at":"2017-02-06T18:31:17Z","pushed_at":"2017-03-07T13:43:13Z","git_url":"git://github.com/aviemzur/beam.git","ssh_url":"git@github.com:aviemzur/beam.git","clone_url":"https://github.com/aviemzur/beam.git","svn_url":"https://github.com/aviemzur/beam","homepage":null,"size":29342,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d66029cafde152c0a46ebd276ddfa4c3e7fd3433","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Mirror of Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2017-03-08T02:51:50Z","pushed_at":"2017-03-08T05:28:45Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":29547,"stargazers_count":952,"watchers_count":952,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":504,"mirror_url":"git://git.apache.org/beam.git","open_issues_count":73,"forks":504,"open_issues":73,"watchers":952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/2133"},"html":{"href":"https://github.com/apache/beam/pull/2133"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/2133"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/2133/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/2133/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/2133/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/e5d4539809b594a6d5a233d916f0403f2f9b3e04"}}}}
{"actor":{"display_login":"aviemzur"}}