{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/106511047","pull_request_review_id":27437462,"id":106511047,"diff_hunk":"@@ -0,0 +1,150 @@\n+{ config, lib, pkgs, ... }:\n+\n+with lib;\n+\n+let\n+  cfg = config.services.xrdp;\n+  confDir = pkgs.runCommand \"xrdp.conf\" { } ''\n+    mkdir $out\n+\n+    cp ${cfg.package}/etc/xrdp/{km-*,xrdp,sesman,xrdp_keyboard}.ini $out\n+\n+    ${cfg.package}/bin/xrdp-keygen xrdp $out/rsakeys.ini\n+\n+    cat > $out/startwm.sh <<EOF\n+    #!/bin/sh\n+    . /etc/profile\n+    ${cfg.defaultWindowManager}\n+    EOF\n+    chmod +x $out/startwm.sh\n+    \n+    substituteInPlace $out/xrdp.ini \\\n+      --replace \"certificate=\" \"certificate=${cfg.sslCert}\" \\\n+      --replace \"key_file=\" \"key_file=${cfg.sslKey}\" \\\n+      --replace LogFile=xrdp.log LogFile=/dev/null \\\n+      --replace EnableSyslog=true EnableSyslog=false\n+\n+    substituteInPlace $out/sesman.ini \\\n+      --replace LogFile=xrdp-sesman.log LogFile=/dev/null \\\n+      --replace EnableSyslog=1 EnableSyslog=0","path":"nixos/modules/services/networking/xrdp.nix","position":29,"original_position":29,"commit_id":"8fb64c8f6028e0d01aa18430ff04d6533a245564","original_commit_id":"8fb64c8f6028e0d01aa18430ff04d6533a245564","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars0.githubusercontent.com/u/96200?v=3","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"Why is syslog disabled? Are logs in journald not useful?","created_at":"2017-03-16T19:31:01Z","updated_at":"2017-03-16T19:31:01Z","html_url":"https://github.com/NixOS/nixpkgs/pull/23865#discussion_r106511047","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/106511047"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/23865#discussion_r106511047"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865","id":110506693,"html_url":"https://github.com/NixOS/nixpkgs/pull/23865","diff_url":"https://github.com/NixOS/nixpkgs/pull/23865.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/23865.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/23865","number":23865,"state":"open","locked":false,"title":"xrdp: init at 0.9.1","user":{"login":"volth","id":508305,"avatar_url":"https://avatars0.githubusercontent.com/u/508305?v=3","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nRDP server (remote desktop which is good for high latency connections).\r\nnix package + nixos module + test script\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-03-13T21:57:00Z","updated_at":"2017-03-16T19:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfda0e550317b1a601865afe177f896e7c925c38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/23865/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8fb64c8f6028e0d01aa18430ff04d6533a245564","head":{"label":"volth:xrdp-tests","ref":"xrdp-tests","sha":"8fb64c8f6028e0d01aa18430ff04d6533a245564","user":{"login":"volth","id":508305,"avatar_url":"https://avatars0.githubusercontent.com/u/508305?v=3","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"repo":{"id":77714826,"name":"nixpkgs","full_name":"volth/nixpkgs","owner":{"login":"volth","id":508305,"avatar_url":"https://avatars0.githubusercontent.com/u/508305?v=3","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/volth/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/volth/nixpkgs","forks_url":"https://api.github.com/repos/volth/nixpkgs/forks","keys_url":"https://api.github.com/repos/volth/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/volth/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/volth/nixpkgs/teams","hooks_url":"https://api.github.com/repos/volth/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/volth/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/volth/nixpkgs/events","assignees_url":"https://api.github.com/repos/volth/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/volth/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/volth/nixpkgs/tags","blobs_url":"https://api.github.com/repos/volth/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/volth/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/volth/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/volth/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/volth/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/volth/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/volth/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/volth/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/volth/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/volth/nixpkgs/subscription","commits_url":"https://api.github.com/repos/volth/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/volth/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/volth/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/volth/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/volth/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/volth/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/volth/nixpkgs/merges","archive_url":"https://api.github.com/repos/volth/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/volth/nixpkgs/downloads","issues_url":"https://api.github.com/repos/volth/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/volth/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/volth/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/volth/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/volth/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/volth/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/volth/nixpkgs/deployments","created_at":"2016-12-30T23:01:45Z","updated_at":"2016-12-30T23:02:09Z","pushed_at":"2017-03-16T18:26:22Z","git_url":"git://github.com/volth/nixpkgs.git","ssh_url":"git@github.com:volth/nixpkgs.git","clone_url":"https://github.com/volth/nixpkgs.git","svn_url":"https://github.com/volth/nixpkgs","homepage":null,"size":419652,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"18684a4892bc202590a51a8bee251dc1b4fcf3b7","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-03-16T18:01:03Z","pushed_at":"2017-03-16T19:20:59Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":423379,"stargazers_count":1562,"watchers_count":1562,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1929,"mirror_url":null,"open_issues_count":1892,"forks":1929,"open_issues":1892,"watchers":1562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/23865"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/23865"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/23865/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/23865/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/8fb64c8f6028e0d01aa18430ff04d6533a245564"}}}}
{"actor":{"display_login":"Mic92"}}