{"action":"created","issue":{"url":"https://api.github.com/repos/rpgmaker/NetJSON/issues/162","repository_url":"https://api.github.com/repos/rpgmaker/NetJSON","labels_url":"https://api.github.com/repos/rpgmaker/NetJSON/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/rpgmaker/NetJSON/issues/162/comments","events_url":"https://api.github.com/repos/rpgmaker/NetJSON/issues/162/events","html_url":"https://github.com/rpgmaker/NetJSON/issues/162","id":223678329,"number":162,"title":"can't deserialize default(DateTime)","user":{"login":"physhi","id":7017345,"avatar_url":"https://avatars2.githubusercontent.com/u/7017345?v=3","gravatar_id":"","url":"https://api.github.com/users/physhi","html_url":"https://github.com/physhi","followers_url":"https://api.github.com/users/physhi/followers","following_url":"https://api.github.com/users/physhi/following{/other_user}","gists_url":"https://api.github.com/users/physhi/gists{/gist_id}","starred_url":"https://api.github.com/users/physhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/physhi/subscriptions","organizations_url":"https://api.github.com/users/physhi/orgs","repos_url":"https://api.github.com/users/physhi/repos","events_url":"https://api.github.com/users/physhi/events{/privacy}","received_events_url":"https://api.github.com/users/physhi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-24T00:12:45Z","updated_at":"2017-04-24T00:25:59Z","closed_at":null,"body":"The problem is that the format of the date in text is \"1-01-01 00:00:00.0\". The code assumes that the year portion will be 4 characters.\r\n\r\nTest case NetJson.DeSerialize(NetJson.Serialize(default(DateTime))"},"comment":{"url":"https://api.github.com/repos/rpgmaker/NetJSON/issues/comments/296499985","html_url":"https://github.com/rpgmaker/NetJSON/issues/162#issuecomment-296499985","issue_url":"https://api.github.com/repos/rpgmaker/NetJSON/issues/162","id":296499985,"user":{"login":"physhi","id":7017345,"avatar_url":"https://avatars2.githubusercontent.com/u/7017345?v=3","gravatar_id":"","url":"https://api.github.com/users/physhi","html_url":"https://github.com/physhi","followers_url":"https://api.github.com/users/physhi/followers","following_url":"https://api.github.com/users/physhi/following{/other_user}","gists_url":"https://api.github.com/users/physhi/gists{/gist_id}","starred_url":"https://api.github.com/users/physhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/physhi/subscriptions","organizations_url":"https://api.github.com/users/physhi/orgs","repos_url":"https://api.github.com/users/physhi/repos","events_url":"https://api.github.com/users/physhi/events{/privacy}","received_events_url":"https://api.github.com/users/physhi/received_events","type":"User","site_admin":false},"created_at":"2017-04-24T00:25:59Z","updated_at":"2017-04-24T00:25:59Z","body":"The problem is not really with just default(DateTime) but also with\ndefault(DateTime).AddMinutes(1).\n\nBut I guess, I should use different dateTime serialization as they will be\nmuch faster than string serializations (the main reason of using NetJson is\nspeed).\n\nAnyways, great work, with the speed. Even though the code is a bit complex\n(you are literally working with IL and it becomes hard to follow, but I\nguess that's the only way to gurantee performance).\n\nOn Sun, Apr 23, 2017 at 5:15 PM, Rpgmaker <notifications@github.com> wrote:\n\n> You need to use\n>\n> NetJSONSetting.DateStringFormat = default: Null\n> - This allows customization of date formatting and ignore other formatting\n> option when specified.\n>\n> It allows you to customize the serialization and deserialization of custom\n> dates.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/rpgmaker/NetJSON/issues/162#issuecomment-296499368>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AGsTgXpPACEaEDLFn74rKoWqgsPH1b8sks5ry-mXgaJpZM4NFlf0>\n> .\n>\n"}}
{"actor":{"display_login":"physhi"}}