{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/117058906","pull_request_review_id":38731097,"id":117058906,"diff_hunk":"@@ -43,15 +45,18 @@\n             \"--cql\"}, required = false, description = \"OGC CQL statement to query the persistence store. Not specifying returns all entries. More information on CQL is available at: http://docs.geoserver.org/stable/en/user/tutorials/cql/cql_tutorial.html\", multiValued = false)\n     protected String cql;\n \n+    @Reference\n+    BundleContext bundleContext;\n+\n     @Override\n-    protected Object doExecute() {\n+    public Object execute() {\n \n         ServiceReference<PersistentStore> persistentStoreRef =\n-                getBundleContext().getServiceReference(PersistentStore.class);\n+                bundleContext.getServiceReference(PersistentStore.class);\n \n         try {\n             if (persistentStoreRef != null) {\n-                persistentStore = getBundleContext().getService(persistentStoreRef);\n+                persistentStore = bundleContext.getService(persistentStoreRef);","path":"platform/persistence/platform-persistence-commands/src/main/java/org/codice/ddf/persistence/commands/AbstractStoreCommand.java","position":42,"original_position":42,"commit_id":"4fb6edcd27513741024ef8e326bd56a229c54396","original_commit_id":"4fb6edcd27513741024ef8e326bd56a229c54396","user":{"login":"emmberk","id":8041246,"avatar_url":"https://avatars0.githubusercontent.com/u/8041246?v=3","gravatar_id":"","url":"https://api.github.com/users/emmberk","html_url":"https://github.com/emmberk","followers_url":"https://api.github.com/users/emmberk/followers","following_url":"https://api.github.com/users/emmberk/following{/other_user}","gists_url":"https://api.github.com/users/emmberk/gists{/gist_id}","starred_url":"https://api.github.com/users/emmberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmberk/subscriptions","organizations_url":"https://api.github.com/users/emmberk/orgs","repos_url":"https://api.github.com/users/emmberk/repos","events_url":"https://api.github.com/users/emmberk/events{/privacy}","received_events_url":"https://api.github.com/users/emmberk/received_events","type":"User","site_admin":false},"body":"What do `bundleContext.getService` and `bundleContext.ungetService` do? Could you use\r\n```java\r\n@Reference\r\nPersistentStore persistentStore;\r\n```\r\ninstead?\r\n","created_at":"2017-05-17T17:07:45Z","updated_at":"2017-05-17T17:12:52Z","html_url":"https://github.com/codice/ddf/pull/1991#discussion_r117058906","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/1991","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/117058906"},"html":{"href":"https://github.com/codice/ddf/pull/1991#discussion_r117058906"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/1991"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1991","id":121107327,"html_url":"https://github.com/codice/ddf/pull/1991","diff_url":"https://github.com/codice/ddf/pull/1991.diff","patch_url":"https://github.com/codice/ddf/pull/1991.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/1991","number":1991,"state":"open","locked":false,"title":"DDF-3019 Update persistence-core-commands to use Karaf command annotations","user":{"login":"josephthweatt","id":11358088,"avatar_url":"https://avatars1.githubusercontent.com/u/11358088?v=3","gravatar_id":"","url":"https://api.github.com/users/josephthweatt","html_url":"https://github.com/josephthweatt","followers_url":"https://api.github.com/users/josephthweatt/followers","following_url":"https://api.github.com/users/josephthweatt/following{/other_user}","gists_url":"https://api.github.com/users/josephthweatt/gists{/gist_id}","starred_url":"https://api.github.com/users/josephthweatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephthweatt/subscriptions","organizations_url":"https://api.github.com/users/josephthweatt/orgs","repos_url":"https://api.github.com/users/josephthweatt/repos","events_url":"https://api.github.com/users/josephthweatt/events{/privacy}","received_events_url":"https://api.github.com/users/josephthweatt/received_events","type":"User","site_admin":false},"body":"\r\nUpdated pom\r\n\r\nAbstractStoreCommand implements Action instead of extending OsgiCommandSupport\r\n\r\nDeleted persistence-core-commands blueprints\r\n\r\n#### What does this PR do?\r\nUpdates persistence-core-commands to use the new Karaf annotations\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?\r\n@vinamartin \r\n@emmberk \r\n#### Select at least one member from relevant component team(s) from below (at least one component team member needs to approve the PR).\r\n[Core APIs](https://github.com/orgs/codice/teams/core-apis)\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@clockard\r\n@shaundmorris \r\n#### How should this be tested? (List steps with links to updated documentation)\r\nRun store:list and store:delete commands. See that commands still output the right results\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-3019](https://codice.atlassian.net/browse/)\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Change Log Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n","created_at":"2017-05-17T17:04:39Z","updated_at":"2017-05-17T17:12:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cade2f8a8c44d6fefb1fceddb6a35d88056efa37","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/1991/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/1991/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1991/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/4fb6edcd27513741024ef8e326bd56a229c54396","head":{"label":"josephthweatt:DDF-3019","ref":"DDF-3019","sha":"4fb6edcd27513741024ef8e326bd56a229c54396","user":{"login":"josephthweatt","id":11358088,"avatar_url":"https://avatars1.githubusercontent.com/u/11358088?v=3","gravatar_id":"","url":"https://api.github.com/users/josephthweatt","html_url":"https://github.com/josephthweatt","followers_url":"https://api.github.com/users/josephthweatt/followers","following_url":"https://api.github.com/users/josephthweatt/following{/other_user}","gists_url":"https://api.github.com/users/josephthweatt/gists{/gist_id}","starred_url":"https://api.github.com/users/josephthweatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephthweatt/subscriptions","organizations_url":"https://api.github.com/users/josephthweatt/orgs","repos_url":"https://api.github.com/users/josephthweatt/repos","events_url":"https://api.github.com/users/josephthweatt/events{/privacy}","received_events_url":"https://api.github.com/users/josephthweatt/received_events","type":"User","site_admin":false},"repo":{"id":91392135,"name":"ddf","full_name":"josephthweatt/ddf","owner":{"login":"josephthweatt","id":11358088,"avatar_url":"https://avatars1.githubusercontent.com/u/11358088?v=3","gravatar_id":"","url":"https://api.github.com/users/josephthweatt","html_url":"https://github.com/josephthweatt","followers_url":"https://api.github.com/users/josephthweatt/followers","following_url":"https://api.github.com/users/josephthweatt/following{/other_user}","gists_url":"https://api.github.com/users/josephthweatt/gists{/gist_id}","starred_url":"https://api.github.com/users/josephthweatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephthweatt/subscriptions","organizations_url":"https://api.github.com/users/josephthweatt/orgs","repos_url":"https://api.github.com/users/josephthweatt/repos","events_url":"https://api.github.com/users/josephthweatt/events{/privacy}","received_events_url":"https://api.github.com/users/josephthweatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josephthweatt/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/josephthweatt/ddf","forks_url":"https://api.github.com/repos/josephthweatt/ddf/forks","keys_url":"https://api.github.com/repos/josephthweatt/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephthweatt/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephthweatt/ddf/teams","hooks_url":"https://api.github.com/repos/josephthweatt/ddf/hooks","issue_events_url":"https://api.github.com/repos/josephthweatt/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/josephthweatt/ddf/events","assignees_url":"https://api.github.com/repos/josephthweatt/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/josephthweatt/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/josephthweatt/ddf/tags","blobs_url":"https://api.github.com/repos/josephthweatt/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephthweatt/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephthweatt/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephthweatt/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephthweatt/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/josephthweatt/ddf/languages","stargazers_url":"https://api.github.com/repos/josephthweatt/ddf/stargazers","contributors_url":"https://api.github.com/repos/josephthweatt/ddf/contributors","subscribers_url":"https://api.github.com/repos/josephthweatt/ddf/subscribers","subscription_url":"https://api.github.com/repos/josephthweatt/ddf/subscription","commits_url":"https://api.github.com/repos/josephthweatt/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephthweatt/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephthweatt/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephthweatt/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephthweatt/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/josephthweatt/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephthweatt/ddf/merges","archive_url":"https://api.github.com/repos/josephthweatt/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephthweatt/ddf/downloads","issues_url":"https://api.github.com/repos/josephthweatt/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/josephthweatt/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/josephthweatt/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/josephthweatt/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephthweatt/ddf/labels{/name}","releases_url":"https://api.github.com/repos/josephthweatt/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/josephthweatt/ddf/deployments","created_at":"2017-05-15T23:03:07Z","updated_at":"2017-05-15T23:03:25Z","pushed_at":"2017-05-17T16:57:54Z","git_url":"git://github.com/josephthweatt/ddf.git","ssh_url":"git@github.com:josephthweatt/ddf.git","clone_url":"https://github.com/josephthweatt/ddf.git","svn_url":"https://github.com/josephthweatt/ddf","homepage":"http://ddf.codice.org","size":318442,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"0c142dece2cdcca4a1d08f5f7b53e535c050363d","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2017-04-12T02:00:28Z","pushed_at":"2017-05-17T17:04:40Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":320745,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":107,"mirror_url":null,"open_issues_count":33,"forks":107,"open_issues":33,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/1991"},"html":{"href":"https://github.com/codice/ddf/pull/1991"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/1991"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/1991/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/1991/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/1991/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/4fb6edcd27513741024ef8e326bd56a229c54396"}}}}
{"actor":{"display_login":"emmberk"}}