{"action":"created","comment":{"url":"https://api.github.com/repos/dvehrs/podget/pulls/comments/112607782","pull_request_review_id":33936075,"id":112607782,"diff_hunk":"@@ -1142,7 +1142,8 @@ PLAYLIST_ConvertToASX() {\n \n      # Removing unix2dos dependency. Converting to sed statement with in-place editing of the file in question.\n      # ctrl-v ctrl-m for windows line end.\n-     sed -i 's/$/\r/' \"${DIR_LIBRARY}\"/\"${ASX_PLAYLISTNAME}\"\n+     sed -i 's/$/\n+/' \"${DIR_LIBRARY}\"/\"${ASX_PLAYLISTNAME}\"","path":"podget","position":15,"original_position":15,"commit_id":"427104fb4d265292dc7e9e7456f0be1fe18a8848","original_commit_id":"427104fb4d265292dc7e9e7456f0be1fe18a8848","user":{"login":"dvehrs","id":1733372,"avatar_url":"https://avatars2.githubusercontent.com/u/1733372?v=3","gravatar_id":"","url":"https://api.github.com/users/dvehrs","html_url":"https://github.com/dvehrs","followers_url":"https://api.github.com/users/dvehrs/followers","following_url":"https://api.github.com/users/dvehrs/following{/other_user}","gists_url":"https://api.github.com/users/dvehrs/gists{/gist_id}","starred_url":"https://api.github.com/users/dvehrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvehrs/subscriptions","organizations_url":"https://api.github.com/users/dvehrs/orgs","repos_url":"https://api.github.com/users/dvehrs/repos","events_url":"https://api.github.com/users/dvehrs/events{/privacy}","received_events_url":"https://api.github.com/users/dvehrs/received_events","type":"User","site_admin":false},"body":"Is this change needed?  It's been a little while since I tested dos file to unix conversions but as I recall the ctrl-M was the way to go....","created_at":"2017-04-21T04:37:38Z","updated_at":"2017-04-21T04:37:38Z","html_url":"https://github.com/dvehrs/podget/pull/26#discussion_r112607782","pull_request_url":"https://api.github.com/repos/dvehrs/podget/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/dvehrs/podget/pulls/comments/112607782"},"html":{"href":"https://github.com/dvehrs/podget/pull/26#discussion_r112607782"},"pull_request":{"href":"https://api.github.com/repos/dvehrs/podget/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/dvehrs/podget/pulls/26","id":116200516,"html_url":"https://github.com/dvehrs/podget/pull/26","diff_url":"https://github.com/dvehrs/podget/pull/26.diff","patch_url":"https://github.com/dvehrs/podget/pull/26.patch","issue_url":"https://api.github.com/repos/dvehrs/podget/issues/26","number":26,"state":"open","locked":false,"title":"Make opml import favor xmlUrl over htmlUrl","user":{"login":"kuba-orlik","id":2697916,"avatar_url":"https://avatars2.githubusercontent.com/u/2697916?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba-orlik","html_url":"https://github.com/kuba-orlik","followers_url":"https://api.github.com/users/kuba-orlik/followers","following_url":"https://api.github.com/users/kuba-orlik/following{/other_user}","gists_url":"https://api.github.com/users/kuba-orlik/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba-orlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba-orlik/subscriptions","organizations_url":"https://api.github.com/users/kuba-orlik/orgs","repos_url":"https://api.github.com/users/kuba-orlik/repos","events_url":"https://api.github.com/users/kuba-orlik/events{/privacy}","received_events_url":"https://api.github.com/users/kuba-orlik/received_events","type":"User","site_admin":false},"body":"When importing this opml file: \r\n\r\n```\r\n<?xml version='1.0' encoding='UTF-8' standalone='no' ?>\r\n<opml version=\"2.0\">\r\n  <head>\r\n    <title>AntennaPod Subscriptions</title>\r\n    <dateCreated>17 Apr 17 12:52:03 +0200</dateCreated>\r\n  </head>\r\n  <body>\r\n    <outline text=\"Developer Tea\" title=\"Developer Tea\" type=\"rss\" xmlUrl=\"http://feeds.feedburner.com/DeveloperTea\" htmlUrl=\"http://www.developertea.com\" />\r\n  </body>\r\n</opml>\r\n```\r\n\r\nThe resulting serverlist looked like so: \r\n\r\n```\r\nhttp://www.developertea.com OPML_Import_2017-04-17 Developer Tea\r\n```\r\n\r\nThe podcast download didn't work, because the url in the serverlist is the htmlUrl, not the xmlUrl which leads to the rss/atom feed. \r\n\r\nThis simple change in a regexp fixes this.","created_at":"2017-04-17T20:49:14Z","updated_at":"2017-04-21T04:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d632ee1b3d39934f0aa3a6a91f43abd658af24ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvehrs/podget/pulls/26/commits","review_comments_url":"https://api.github.com/repos/dvehrs/podget/pulls/26/comments","review_comment_url":"https://api.github.com/repos/dvehrs/podget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvehrs/podget/issues/26/comments","statuses_url":"https://api.github.com/repos/dvehrs/podget/statuses/427104fb4d265292dc7e9e7456f0be1fe18a8848","head":{"label":"kuba-orlik:master","ref":"master","sha":"427104fb4d265292dc7e9e7456f0be1fe18a8848","user":{"login":"kuba-orlik","id":2697916,"avatar_url":"https://avatars2.githubusercontent.com/u/2697916?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba-orlik","html_url":"https://github.com/kuba-orlik","followers_url":"https://api.github.com/users/kuba-orlik/followers","following_url":"https://api.github.com/users/kuba-orlik/following{/other_user}","gists_url":"https://api.github.com/users/kuba-orlik/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba-orlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba-orlik/subscriptions","organizations_url":"https://api.github.com/users/kuba-orlik/orgs","repos_url":"https://api.github.com/users/kuba-orlik/repos","events_url":"https://api.github.com/users/kuba-orlik/events{/privacy}","received_events_url":"https://api.github.com/users/kuba-orlik/received_events","type":"User","site_admin":false},"repo":{"id":88548928,"name":"podget","full_name":"kuba-orlik/podget","owner":{"login":"kuba-orlik","id":2697916,"avatar_url":"https://avatars2.githubusercontent.com/u/2697916?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba-orlik","html_url":"https://github.com/kuba-orlik","followers_url":"https://api.github.com/users/kuba-orlik/followers","following_url":"https://api.github.com/users/kuba-orlik/following{/other_user}","gists_url":"https://api.github.com/users/kuba-orlik/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba-orlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba-orlik/subscriptions","organizations_url":"https://api.github.com/users/kuba-orlik/orgs","repos_url":"https://api.github.com/users/kuba-orlik/repos","events_url":"https://api.github.com/users/kuba-orlik/events{/privacy}","received_events_url":"https://api.github.com/users/kuba-orlik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kuba-orlik/podget","description":"Podcast aggregator optimized for running as a scheduled job (i.e. cron) on Linux","fork":true,"url":"https://api.github.com/repos/kuba-orlik/podget","forks_url":"https://api.github.com/repos/kuba-orlik/podget/forks","keys_url":"https://api.github.com/repos/kuba-orlik/podget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuba-orlik/podget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuba-orlik/podget/teams","hooks_url":"https://api.github.com/repos/kuba-orlik/podget/hooks","issue_events_url":"https://api.github.com/repos/kuba-orlik/podget/issues/events{/number}","events_url":"https://api.github.com/repos/kuba-orlik/podget/events","assignees_url":"https://api.github.com/repos/kuba-orlik/podget/assignees{/user}","branches_url":"https://api.github.com/repos/kuba-orlik/podget/branches{/branch}","tags_url":"https://api.github.com/repos/kuba-orlik/podget/tags","blobs_url":"https://api.github.com/repos/kuba-orlik/podget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuba-orlik/podget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuba-orlik/podget/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuba-orlik/podget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuba-orlik/podget/statuses/{sha}","languages_url":"https://api.github.com/repos/kuba-orlik/podget/languages","stargazers_url":"https://api.github.com/repos/kuba-orlik/podget/stargazers","contributors_url":"https://api.github.com/repos/kuba-orlik/podget/contributors","subscribers_url":"https://api.github.com/repos/kuba-orlik/podget/subscribers","subscription_url":"https://api.github.com/repos/kuba-orlik/podget/subscription","commits_url":"https://api.github.com/repos/kuba-orlik/podget/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuba-orlik/podget/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuba-orlik/podget/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuba-orlik/podget/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuba-orlik/podget/contents/{+path}","compare_url":"https://api.github.com/repos/kuba-orlik/podget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuba-orlik/podget/merges","archive_url":"https://api.github.com/repos/kuba-orlik/podget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuba-orlik/podget/downloads","issues_url":"https://api.github.com/repos/kuba-orlik/podget/issues{/number}","pulls_url":"https://api.github.com/repos/kuba-orlik/podget/pulls{/number}","milestones_url":"https://api.github.com/repos/kuba-orlik/podget/milestones{/number}","notifications_url":"https://api.github.com/repos/kuba-orlik/podget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuba-orlik/podget/labels{/name}","releases_url":"https://api.github.com/repos/kuba-orlik/podget/releases{/id}","deployments_url":"https://api.github.com/repos/kuba-orlik/podget/deployments","created_at":"2017-04-17T20:41:54Z","updated_at":"2017-04-17T20:41:56Z","pushed_at":"2017-04-17T20:59:45Z","git_url":"git://github.com/kuba-orlik/podget.git","ssh_url":"git@github.com:kuba-orlik/podget.git","clone_url":"https://github.com/kuba-orlik/podget.git","svn_url":"https://github.com/kuba-orlik/podget","homepage":null,"size":365,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dvehrs:master","ref":"master","sha":"0fe1bd7ec5594e1c30eaaa9028049088f014e76a","user":{"login":"dvehrs","id":1733372,"avatar_url":"https://avatars2.githubusercontent.com/u/1733372?v=3","gravatar_id":"","url":"https://api.github.com/users/dvehrs","html_url":"https://github.com/dvehrs","followers_url":"https://api.github.com/users/dvehrs/followers","following_url":"https://api.github.com/users/dvehrs/following{/other_user}","gists_url":"https://api.github.com/users/dvehrs/gists{/gist_id}","starred_url":"https://api.github.com/users/dvehrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvehrs/subscriptions","organizations_url":"https://api.github.com/users/dvehrs/orgs","repos_url":"https://api.github.com/users/dvehrs/repos","events_url":"https://api.github.com/users/dvehrs/events{/privacy}","received_events_url":"https://api.github.com/users/dvehrs/received_events","type":"User","site_admin":false},"repo":{"id":45873268,"name":"podget","full_name":"dvehrs/podget","owner":{"login":"dvehrs","id":1733372,"avatar_url":"https://avatars2.githubusercontent.com/u/1733372?v=3","gravatar_id":"","url":"https://api.github.com/users/dvehrs","html_url":"https://github.com/dvehrs","followers_url":"https://api.github.com/users/dvehrs/followers","following_url":"https://api.github.com/users/dvehrs/following{/other_user}","gists_url":"https://api.github.com/users/dvehrs/gists{/gist_id}","starred_url":"https://api.github.com/users/dvehrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvehrs/subscriptions","organizations_url":"https://api.github.com/users/dvehrs/orgs","repos_url":"https://api.github.com/users/dvehrs/repos","events_url":"https://api.github.com/users/dvehrs/events{/privacy}","received_events_url":"https://api.github.com/users/dvehrs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dvehrs/podget","description":"Podcast aggregator optimized for running as a scheduled job (i.e. cron) on Linux","fork":false,"url":"https://api.github.com/repos/dvehrs/podget","forks_url":"https://api.github.com/repos/dvehrs/podget/forks","keys_url":"https://api.github.com/repos/dvehrs/podget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvehrs/podget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvehrs/podget/teams","hooks_url":"https://api.github.com/repos/dvehrs/podget/hooks","issue_events_url":"https://api.github.com/repos/dvehrs/podget/issues/events{/number}","events_url":"https://api.github.com/repos/dvehrs/podget/events","assignees_url":"https://api.github.com/repos/dvehrs/podget/assignees{/user}","branches_url":"https://api.github.com/repos/dvehrs/podget/branches{/branch}","tags_url":"https://api.github.com/repos/dvehrs/podget/tags","blobs_url":"https://api.github.com/repos/dvehrs/podget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvehrs/podget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvehrs/podget/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvehrs/podget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvehrs/podget/statuses/{sha}","languages_url":"https://api.github.com/repos/dvehrs/podget/languages","stargazers_url":"https://api.github.com/repos/dvehrs/podget/stargazers","contributors_url":"https://api.github.com/repos/dvehrs/podget/contributors","subscribers_url":"https://api.github.com/repos/dvehrs/podget/subscribers","subscription_url":"https://api.github.com/repos/dvehrs/podget/subscription","commits_url":"https://api.github.com/repos/dvehrs/podget/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvehrs/podget/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvehrs/podget/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvehrs/podget/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvehrs/podget/contents/{+path}","compare_url":"https://api.github.com/repos/dvehrs/podget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvehrs/podget/merges","archive_url":"https://api.github.com/repos/dvehrs/podget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvehrs/podget/downloads","issues_url":"https://api.github.com/repos/dvehrs/podget/issues{/number}","pulls_url":"https://api.github.com/repos/dvehrs/podget/pulls{/number}","milestones_url":"https://api.github.com/repos/dvehrs/podget/milestones{/number}","notifications_url":"https://api.github.com/repos/dvehrs/podget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvehrs/podget/labels{/name}","releases_url":"https://api.github.com/repos/dvehrs/podget/releases{/id}","deployments_url":"https://api.github.com/repos/dvehrs/podget/deployments","created_at":"2015-11-09T23:15:23Z","updated_at":"2017-04-18T12:13:06Z","pushed_at":"2017-04-21T03:57:51Z","git_url":"git://github.com/dvehrs/podget.git","ssh_url":"git@github.com:dvehrs/podget.git","clone_url":"https://github.com/dvehrs/podget.git","svn_url":"https://github.com/dvehrs/podget","homepage":null,"size":328,"stargazers_count":25,"watchers_count":25,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dvehrs/podget/pulls/26"},"html":{"href":"https://github.com/dvehrs/podget/pull/26"},"issue":{"href":"https://api.github.com/repos/dvehrs/podget/issues/26"},"comments":{"href":"https://api.github.com/repos/dvehrs/podget/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/dvehrs/podget/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/dvehrs/podget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvehrs/podget/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/dvehrs/podget/statuses/427104fb4d265292dc7e9e7456f0be1fe18a8848"}}}}
{"actor":{"display_login":"dvehrs"}}