{"action":"created","comment":{"url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/comments/132061769","pull_request_review_id":55103490,"id":132061769,"diff_hunk":"@@ -137,13 +137,15 @@ int extract_token_and_version_from_header(apr_pool_t *pool, apr_table_t *headers\n     if (header_value) {\n         char *rest;\n         char *header_cpy = apr_pstrdup(pool, header_value);\n-        const char *version = apr_strtok(header_cpy, \":\", &rest);\n-        if (version == NULL) {\n+        const char *prefix = apr_strtok(header_cpy, \":\", &rest);","path":"src/px_utils.c","position":6,"original_position":6,"commit_id":"fb4f89ff3619c0c714558db2d2e0b05229effa37","original_commit_id":"fb4f89ff3619c0c714558db2d2e0b05229effa37","user":{"login":"pxaviad","id":16173996,"avatar_url":"https://avatars3.githubusercontent.com/u/16173996?v=4","gravatar_id":"","url":"https://api.github.com/users/pxaviad","html_url":"https://github.com/pxaviad","followers_url":"https://api.github.com/users/pxaviad/followers","following_url":"https://api.github.com/users/pxaviad/following{/other_user}","gists_url":"https://api.github.com/users/pxaviad/gists{/gist_id}","starred_url":"https://api.github.com/users/pxaviad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pxaviad/subscriptions","organizations_url":"https://api.github.com/users/pxaviad/orgs","repos_url":"https://api.github.com/users/pxaviad/repos","events_url":"https://api.github.com/users/pxaviad/events{/privacy}","received_events_url":"https://api.github.com/users/pxaviad/received_events","type":"User","site_admin":false},"body":"we are using token variable for two different purposes, source of confusion and bugs. we need to separate the two.. ","created_at":"2017-08-08T23:53:34Z","updated_at":"2017-08-08T23:54:41Z","html_url":"https://github.com/PerimeterX/mod_perimeterx/pull/68#discussion_r132061769","pull_request_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/comments/132061769"},"html":{"href":"https://github.com/PerimeterX/mod_perimeterx/pull/68#discussion_r132061769"},"pull_request":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68","id":134668724,"html_url":"https://github.com/PerimeterX/mod_perimeterx/pull/68","diff_url":"https://github.com/PerimeterX/mod_perimeterx/pull/68.diff","patch_url":"https://github.com/PerimeterX/mod_perimeterx/pull/68.patch","issue_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/68","number":68,"state":"open","locked":false,"title":"EN-4114 sending connection_error when token value is 2","user":{"login":"nitzanpx","id":25718404,"avatar_url":"https://avatars1.githubusercontent.com/u/25718404?v=4","gravatar_id":"","url":"https://api.github.com/users/nitzanpx","html_url":"https://github.com/nitzanpx","followers_url":"https://api.github.com/users/nitzanpx/followers","following_url":"https://api.github.com/users/nitzanpx/following{/other_user}","gists_url":"https://api.github.com/users/nitzanpx/gists{/gist_id}","starred_url":"https://api.github.com/users/nitzanpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitzanpx/subscriptions","organizations_url":"https://api.github.com/users/nitzanpx/orgs","repos_url":"https://api.github.com/users/nitzanpx/repos","events_url":"https://api.github.com/users/nitzanpx/events{/privacy}","received_events_url":"https://api.github.com/users/nitzanpx/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-08T14:04:07Z","updated_at":"2017-08-08T23:54:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b07a10443bb41240408942a5eafdac96948830f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68/commits","review_comments_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68/comments","review_comment_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/68/comments","statuses_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/statuses/fb4f89ff3619c0c714558db2d2e0b05229effa37","head":{"label":"PerimeterX:dev-add_s2s_call_reason_for_connection_error_mobile_sdk","ref":"dev-add_s2s_call_reason_for_connection_error_mobile_sdk","sha":"fb4f89ff3619c0c714558db2d2e0b05229effa37","user":{"login":"PerimeterX","id":10051748,"avatar_url":"https://avatars3.githubusercontent.com/u/10051748?v=4","gravatar_id":"","url":"https://api.github.com/users/PerimeterX","html_url":"https://github.com/PerimeterX","followers_url":"https://api.github.com/users/PerimeterX/followers","following_url":"https://api.github.com/users/PerimeterX/following{/other_user}","gists_url":"https://api.github.com/users/PerimeterX/gists{/gist_id}","starred_url":"https://api.github.com/users/PerimeterX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerimeterX/subscriptions","organizations_url":"https://api.github.com/users/PerimeterX/orgs","repos_url":"https://api.github.com/users/PerimeterX/repos","events_url":"https://api.github.com/users/PerimeterX/events{/privacy}","received_events_url":"https://api.github.com/users/PerimeterX/received_events","type":"Organization","site_admin":false},"repo":{"id":64302066,"name":"mod_perimeterx","full_name":"PerimeterX/mod_perimeterx","owner":{"login":"PerimeterX","id":10051748,"avatar_url":"https://avatars3.githubusercontent.com/u/10051748?v=4","gravatar_id":"","url":"https://api.github.com/users/PerimeterX","html_url":"https://github.com/PerimeterX","followers_url":"https://api.github.com/users/PerimeterX/followers","following_url":"https://api.github.com/users/PerimeterX/following{/other_user}","gists_url":"https://api.github.com/users/PerimeterX/gists{/gist_id}","starred_url":"https://api.github.com/users/PerimeterX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerimeterX/subscriptions","organizations_url":"https://api.github.com/users/PerimeterX/orgs","repos_url":"https://api.github.com/users/PerimeterX/repos","events_url":"https://api.github.com/users/PerimeterX/events{/privacy}","received_events_url":"https://api.github.com/users/PerimeterX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PerimeterX/mod_perimeterx","description":"PerimeterX Apache Module","fork":false,"url":"https://api.github.com/repos/PerimeterX/mod_perimeterx","forks_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/forks","keys_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/teams","hooks_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/hooks","issue_events_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/events{/number}","events_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/events","assignees_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/assignees{/user}","branches_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/branches{/branch}","tags_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/tags","blobs_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/refs{/sha}","trees_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/statuses/{sha}","languages_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/languages","stargazers_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/stargazers","contributors_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/contributors","subscribers_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/subscribers","subscription_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/subscription","commits_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/commits{/sha}","git_commits_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/commits{/sha}","comments_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/comments{/number}","issue_comment_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/comments{/number}","contents_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/contents/{+path}","compare_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/merges","archive_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/downloads","issues_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues{/number}","pulls_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls{/number}","milestones_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/milestones{/number}","notifications_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/labels{/name}","releases_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/releases{/id}","deployments_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/deployments","created_at":"2016-07-27T11:12:19Z","updated_at":"2017-03-01T11:57:50Z","pushed_at":"2017-08-08T23:45:28Z","git_url":"git://github.com/PerimeterX/mod_perimeterx.git","ssh_url":"git@github.com:PerimeterX/mod_perimeterx.git","clone_url":"https://github.com/PerimeterX/mod_perimeterx.git","svn_url":"https://github.com/PerimeterX/mod_perimeterx","homepage":null,"size":523,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":10,"default_branch":"master"}},"base":{"label":"PerimeterX:dev","ref":"dev","sha":"ee43471cc45d572d8a6972b68dd75df29f7cfbb3","user":{"login":"PerimeterX","id":10051748,"avatar_url":"https://avatars3.githubusercontent.com/u/10051748?v=4","gravatar_id":"","url":"https://api.github.com/users/PerimeterX","html_url":"https://github.com/PerimeterX","followers_url":"https://api.github.com/users/PerimeterX/followers","following_url":"https://api.github.com/users/PerimeterX/following{/other_user}","gists_url":"https://api.github.com/users/PerimeterX/gists{/gist_id}","starred_url":"https://api.github.com/users/PerimeterX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerimeterX/subscriptions","organizations_url":"https://api.github.com/users/PerimeterX/orgs","repos_url":"https://api.github.com/users/PerimeterX/repos","events_url":"https://api.github.com/users/PerimeterX/events{/privacy}","received_events_url":"https://api.github.com/users/PerimeterX/received_events","type":"Organization","site_admin":false},"repo":{"id":64302066,"name":"mod_perimeterx","full_name":"PerimeterX/mod_perimeterx","owner":{"login":"PerimeterX","id":10051748,"avatar_url":"https://avatars3.githubusercontent.com/u/10051748?v=4","gravatar_id":"","url":"https://api.github.com/users/PerimeterX","html_url":"https://github.com/PerimeterX","followers_url":"https://api.github.com/users/PerimeterX/followers","following_url":"https://api.github.com/users/PerimeterX/following{/other_user}","gists_url":"https://api.github.com/users/PerimeterX/gists{/gist_id}","starred_url":"https://api.github.com/users/PerimeterX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerimeterX/subscriptions","organizations_url":"https://api.github.com/users/PerimeterX/orgs","repos_url":"https://api.github.com/users/PerimeterX/repos","events_url":"https://api.github.com/users/PerimeterX/events{/privacy}","received_events_url":"https://api.github.com/users/PerimeterX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PerimeterX/mod_perimeterx","description":"PerimeterX Apache Module","fork":false,"url":"https://api.github.com/repos/PerimeterX/mod_perimeterx","forks_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/forks","keys_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/teams","hooks_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/hooks","issue_events_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/events{/number}","events_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/events","assignees_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/assignees{/user}","branches_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/branches{/branch}","tags_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/tags","blobs_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/refs{/sha}","trees_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/statuses/{sha}","languages_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/languages","stargazers_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/stargazers","contributors_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/contributors","subscribers_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/subscribers","subscription_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/subscription","commits_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/commits{/sha}","git_commits_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/git/commits{/sha}","comments_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/comments{/number}","issue_comment_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/comments{/number}","contents_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/contents/{+path}","compare_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/merges","archive_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/downloads","issues_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues{/number}","pulls_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls{/number}","milestones_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/milestones{/number}","notifications_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/labels{/name}","releases_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/releases{/id}","deployments_url":"https://api.github.com/repos/PerimeterX/mod_perimeterx/deployments","created_at":"2016-07-27T11:12:19Z","updated_at":"2017-03-01T11:57:50Z","pushed_at":"2017-08-08T23:45:28Z","git_url":"git://github.com/PerimeterX/mod_perimeterx.git","ssh_url":"git@github.com:PerimeterX/mod_perimeterx.git","clone_url":"https://github.com/PerimeterX/mod_perimeterx.git","svn_url":"https://github.com/PerimeterX/mod_perimeterx","homepage":null,"size":523,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68"},"html":{"href":"https://github.com/PerimeterX/mod_perimeterx/pull/68"},"issue":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/68"},"comments":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/PerimeterX/mod_perimeterx/statuses/fb4f89ff3619c0c714558db2d2e0b05229effa37"}}}}
{"actor":{"display_login":"pxaviad"}}