{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/148957114","pull_request_review_id":74281197,"id":148957114,"diff_hunk":"@@ -484,22 +544,31 @@ static void InitializeWithVersion(Interface* self) {\n \n     ASSERT_MSG(recv_buffer_memory->size == sharedmem_size, \"Invalid shared memory size.\");\n \n+    if (auto room_member = Network::GetRoomMember().lock()) {\n+        wifi_packet_received = room_member->BindOnWifiPacketReceived(OnWifiPacketReceived);\n+    } else {\n+        LOG_ERROR(Service_NWM, \"Network isn't initalized\");\n+        IPC::RequestBuilder rb = rp.MakeBuilder(1, 0);\n+        // TODO(B3N30): Find the correct error code and return it;\n+        rb.Push<u32>(-1);\n+        return;\n+    }\n+\n     {\n         std::lock_guard<std::mutex> lock(connection_status_mutex);\n \n         // Reset the connection status, it contains all zeros after initialization,\n         // except for the actual status value.\n         connection_status = {};\n         connection_status.status = static_cast<u32>(NetworkStatus::NotConnected);\n+        node_info.clear();\n+        node_info.push_back(NodeInfo{});","path":"src/core/hle/service/nwm/nwm_uds.cpp","position":177,"original_position":177,"commit_id":"bbcf800b5948577dd9fb2e6d097db89f8918b3bb","original_commit_id":"bbcf800b5948577dd9fb2e6d097db89f8918b3bb","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars2.githubusercontent.com/u/357072?v=4","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"The self node? Then add it directly (current_node) instead of adding a dummy NodeInfo","created_at":"2017-11-05T13:23:31Z","updated_at":"2017-11-05T13:23:31Z","html_url":"https://github.com/citra-emu/citra/pull/3070#discussion_r148957114","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/3070","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/148957114"},"html":{"href":"https://github.com/citra-emu/citra/pull/3070#discussion_r148957114"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3070"}},"in_reply_to_id":148944923},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/3070","id":150691646,"html_url":"https://github.com/citra-emu/citra/pull/3070","diff_url":"https://github.com/citra-emu/citra/pull/3070.diff","patch_url":"https://github.com/citra-emu/citra/pull/3070.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/3070","number":3070,"state":"open","locked":false,"title":"NWM_UDS: add ConnectToNetwork and DisconnectNetwork","user":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars0.githubusercontent.com/u/26032316?v=4","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"body":"add NWM_UDS::ConnectToNetwork and NWM_UDS::DisconnectNetwork\r\n\r\nthis PR also ties UDS to libnetwork\r\n\r\nThis PR requires #2968 to get merged first\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/citra-emu/citra/3070)\n<!-- Reviewable:end -->\n","created_at":"2017-11-04T19:40:24Z","updated_at":"2017-11-05T13:23:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47cfba9c84b2d3fb72f058af5c095fc92e537e3d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/3070/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/3070/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/3070/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/bbcf800b5948577dd9fb2e6d097db89f8918b3bb","head":{"label":"B3n30:uds_connect_disconnect","ref":"uds_connect_disconnect","sha":"bbcf800b5948577dd9fb2e6d097db89f8918b3bb","user":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars0.githubusercontent.com/u/26032316?v=4","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"repo":{"id":83169439,"name":"citra-1","full_name":"B3n30/citra-1","owner":{"login":"B3n30","id":26032316,"avatar_url":"https://avatars0.githubusercontent.com/u/26032316?v=4","gravatar_id":"","url":"https://api.github.com/users/B3n30","html_url":"https://github.com/B3n30","followers_url":"https://api.github.com/users/B3n30/followers","following_url":"https://api.github.com/users/B3n30/following{/other_user}","gists_url":"https://api.github.com/users/B3n30/gists{/gist_id}","starred_url":"https://api.github.com/users/B3n30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B3n30/subscriptions","organizations_url":"https://api.github.com/users/B3n30/orgs","repos_url":"https://api.github.com/users/B3n30/repos","events_url":"https://api.github.com/users/B3n30/events{/privacy}","received_events_url":"https://api.github.com/users/B3n30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/B3n30/citra-1","description":"A Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/B3n30/citra-1","forks_url":"https://api.github.com/repos/B3n30/citra-1/forks","keys_url":"https://api.github.com/repos/B3n30/citra-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/B3n30/citra-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/B3n30/citra-1/teams","hooks_url":"https://api.github.com/repos/B3n30/citra-1/hooks","issue_events_url":"https://api.github.com/repos/B3n30/citra-1/issues/events{/number}","events_url":"https://api.github.com/repos/B3n30/citra-1/events","assignees_url":"https://api.github.com/repos/B3n30/citra-1/assignees{/user}","branches_url":"https://api.github.com/repos/B3n30/citra-1/branches{/branch}","tags_url":"https://api.github.com/repos/B3n30/citra-1/tags","blobs_url":"https://api.github.com/repos/B3n30/citra-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/B3n30/citra-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/B3n30/citra-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/B3n30/citra-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/B3n30/citra-1/statuses/{sha}","languages_url":"https://api.github.com/repos/B3n30/citra-1/languages","stargazers_url":"https://api.github.com/repos/B3n30/citra-1/stargazers","contributors_url":"https://api.github.com/repos/B3n30/citra-1/contributors","subscribers_url":"https://api.github.com/repos/B3n30/citra-1/subscribers","subscription_url":"https://api.github.com/repos/B3n30/citra-1/subscription","commits_url":"https://api.github.com/repos/B3n30/citra-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/B3n30/citra-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/B3n30/citra-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/B3n30/citra-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/B3n30/citra-1/contents/{+path}","compare_url":"https://api.github.com/repos/B3n30/citra-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/B3n30/citra-1/merges","archive_url":"https://api.github.com/repos/B3n30/citra-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/B3n30/citra-1/downloads","issues_url":"https://api.github.com/repos/B3n30/citra-1/issues{/number}","pulls_url":"https://api.github.com/repos/B3n30/citra-1/pulls{/number}","milestones_url":"https://api.github.com/repos/B3n30/citra-1/milestones{/number}","notifications_url":"https://api.github.com/repos/B3n30/citra-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/B3n30/citra-1/labels{/name}","releases_url":"https://api.github.com/repos/B3n30/citra-1/releases{/id}","deployments_url":"https://api.github.com/repos/B3n30/citra-1/deployments","created_at":"2017-02-25T23:14:59Z","updated_at":"2017-10-20T07:10:25Z","pushed_at":"2017-11-04T19:56:48Z","git_url":"git://github.com/B3n30/citra-1.git","ssh_url":"git@github.com:B3n30/citra-1.git","clone_url":"https://github.com/B3n30/citra-1.git","svn_url":"https://github.com/B3n30/citra-1","homepage":"https://citra-emu.org","size":19342,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"ee5aecee3f80f934cc3d2837fa4a908c7f4c8f2d","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"A Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2017-11-05T02:00:44Z","pushed_at":"2017-11-05T09:32:47Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":21360,"stargazers_count":3387,"watchers_count":3387,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":819,"mirror_url":null,"archived":false,"open_issues_count":249,"forks":819,"open_issues":249,"watchers":3387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3070"},"html":{"href":"https://github.com/citra-emu/citra/pull/3070"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/3070"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/3070/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3070/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/3070/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/bbcf800b5948577dd9fb2e6d097db89f8918b3bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Subv"}}