{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/14","id":109321436,"html_url":"https://github.com/vlio20/ng2-date-picker/pull/14","diff_url":"https://github.com/vlio20/ng2-date-picker/pull/14.diff","patch_url":"https://github.com/vlio20/ng2-date-picker/pull/14.patch","issue_url":"https://api.github.com/repos/vlio20/ng2-date-picker/issues/14","number":14,"state":"closed","locked":false,"title":"feat(multiselect): Add the ability to select multiple dates","user":{"login":"isaacplmann","id":861504,"avatar_url":"https://avatars3.githubusercontent.com/u/861504?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacplmann","html_url":"https://github.com/isaacplmann","followers_url":"https://api.github.com/users/isaacplmann/followers","following_url":"https://api.github.com/users/isaacplmann/following{/other_user}","gists_url":"https://api.github.com/users/isaacplmann/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacplmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacplmann/subscriptions","organizations_url":"https://api.github.com/users/isaacplmann/orgs","repos_url":"https://api.github.com/users/isaacplmann/repos","events_url":"https://api.github.com/users/isaacplmann/events{/privacy}","received_events_url":"https://api.github.com/users/isaacplmann/received_events","type":"User","site_admin":false},"body":"For issue #11.\r\n\r\n`dp-calendar` expects the `selected` input to always be a `Moment[]`.\r\n`dp-day-picker` handles `ngModel` input as `string | Moment | Moment[]`.\r\n \r\nThe value that is returned by `ngModelChange` corresponds to the `userValue` that was passed in.\r\n\r\nOnce I finish my check list, I don't think this will cause any breaking changes.\r\n\r\nI still need to:\r\n\r\n- [x] disable multiselect by default\r\n- [x] write better tests to ensure that the output is always in the format you pass in\r\n- [x] squash commits into one commit\r\n\r\nThere are 2 ways I could control whether multiselect is enabled:\r\n1. Check to see if the initial `userValue` is an array (to get multiselect with no initial value users will need to pass `[]` instead of `undefined`)\r\n2. Add an `allowMultiSelect` boolean value on the `IDayPickerConfig`.\r\n\r\nAlso, should I work on `minSelections` and `maxSelections` in this PR?  Those would take the place of `allowMultiSelect`.\r\n","created_at":"2017-03-06T18:39:57Z","updated_at":"2017-03-07T19:45:55Z","closed_at":"2017-03-07T19:45:55Z","merged_at":"2017-03-07T19:45:55Z","merge_commit_sha":"c626bfc68f258a6ed9bf7add0729cbdc0ee81ffb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/14/commits","review_comments_url":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/14/comments","review_comment_url":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vlio20/ng2-date-picker/issues/14/comments","statuses_url":"https://api.github.com/repos/vlio20/ng2-date-picker/statuses/064205a850c5dae11f3587792d38ff933bcf868c","head":{"label":"isaacplmann:multiselect","ref":"multiselect","sha":"064205a850c5dae11f3587792d38ff933bcf868c","user":{"login":"isaacplmann","id":861504,"avatar_url":"https://avatars3.githubusercontent.com/u/861504?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacplmann","html_url":"https://github.com/isaacplmann","followers_url":"https://api.github.com/users/isaacplmann/followers","following_url":"https://api.github.com/users/isaacplmann/following{/other_user}","gists_url":"https://api.github.com/users/isaacplmann/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacplmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacplmann/subscriptions","organizations_url":"https://api.github.com/users/isaacplmann/orgs","repos_url":"https://api.github.com/users/isaacplmann/repos","events_url":"https://api.github.com/users/isaacplmann/events{/privacy}","received_events_url":"https://api.github.com/users/isaacplmann/received_events","type":"User","site_admin":false},"repo":{"id":83832787,"name":"ng2-date-picker","full_name":"isaacplmann/ng2-date-picker","owner":{"login":"isaacplmann","id":861504,"avatar_url":"https://avatars3.githubusercontent.com/u/861504?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacplmann","html_url":"https://github.com/isaacplmann","followers_url":"https://api.github.com/users/isaacplmann/followers","following_url":"https://api.github.com/users/isaacplmann/following{/other_user}","gists_url":"https://api.github.com/users/isaacplmann/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacplmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacplmann/subscriptions","organizations_url":"https://api.github.com/users/isaacplmann/orgs","repos_url":"https://api.github.com/users/isaacplmann/repos","events_url":"https://api.github.com/users/isaacplmann/events{/privacy}","received_events_url":"https://api.github.com/users/isaacplmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacplmann/ng2-date-picker","description":"Highly configurable date picker built for Angular 2 applications","fork":true,"url":"https://api.github.com/repos/isaacplmann/ng2-date-picker","forks_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/forks","keys_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/teams","hooks_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/hooks","issue_events_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/issues/events{/number}","events_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/events","assignees_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/assignees{/user}","branches_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/branches{/branch}","tags_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/tags","blobs_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/languages","stargazers_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/stargazers","contributors_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/contributors","subscribers_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/subscribers","subscription_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/subscription","commits_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/contents/{+path}","compare_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/merges","archive_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/downloads","issues_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/issues{/number}","pulls_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/labels{/name}","releases_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/releases{/id}","deployments_url":"https://api.github.com/repos/isaacplmann/ng2-date-picker/deployments","created_at":"2017-03-03T19:17:09Z","updated_at":"2017-03-03T19:17:10Z","pushed_at":"2017-03-07T19:36:13Z","git_url":"git://github.com/isaacplmann/ng2-date-picker.git","ssh_url":"git@github.com:isaacplmann/ng2-date-picker.git","clone_url":"https://github.com/isaacplmann/ng2-date-picker.git","svn_url":"https://github.com/isaacplmann/ng2-date-picker","homepage":"https://vlio20.github.io/ng2-date-picker/","size":3532,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vlio20:master","ref":"master","sha":"b22635aeb77cb219442b475780f8c31a93f52b04","user":{"login":"vlio20","id":4542641,"avatar_url":"https://avatars3.githubusercontent.com/u/4542641?v=3","gravatar_id":"","url":"https://api.github.com/users/vlio20","html_url":"https://github.com/vlio20","followers_url":"https://api.github.com/users/vlio20/followers","following_url":"https://api.github.com/users/vlio20/following{/other_user}","gists_url":"https://api.github.com/users/vlio20/gists{/gist_id}","starred_url":"https://api.github.com/users/vlio20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlio20/subscriptions","organizations_url":"https://api.github.com/users/vlio20/orgs","repos_url":"https://api.github.com/users/vlio20/repos","events_url":"https://api.github.com/users/vlio20/events{/privacy}","received_events_url":"https://api.github.com/users/vlio20/received_events","type":"User","site_admin":false},"repo":{"id":72844349,"name":"ng2-date-picker","full_name":"vlio20/ng2-date-picker","owner":{"login":"vlio20","id":4542641,"avatar_url":"https://avatars3.githubusercontent.com/u/4542641?v=3","gravatar_id":"","url":"https://api.github.com/users/vlio20","html_url":"https://github.com/vlio20","followers_url":"https://api.github.com/users/vlio20/followers","following_url":"https://api.github.com/users/vlio20/following{/other_user}","gists_url":"https://api.github.com/users/vlio20/gists{/gist_id}","starred_url":"https://api.github.com/users/vlio20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlio20/subscriptions","organizations_url":"https://api.github.com/users/vlio20/orgs","repos_url":"https://api.github.com/users/vlio20/repos","events_url":"https://api.github.com/users/vlio20/events{/privacy}","received_events_url":"https://api.github.com/users/vlio20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlio20/ng2-date-picker","description":"Highly configurable date picker built for Angular 2 applications","fork":false,"url":"https://api.github.com/repos/vlio20/ng2-date-picker","forks_url":"https://api.github.com/repos/vlio20/ng2-date-picker/forks","keys_url":"https://api.github.com/repos/vlio20/ng2-date-picker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlio20/ng2-date-picker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlio20/ng2-date-picker/teams","hooks_url":"https://api.github.com/repos/vlio20/ng2-date-picker/hooks","issue_events_url":"https://api.github.com/repos/vlio20/ng2-date-picker/issues/events{/number}","events_url":"https://api.github.com/repos/vlio20/ng2-date-picker/events","assignees_url":"https://api.github.com/repos/vlio20/ng2-date-picker/assignees{/user}","branches_url":"https://api.github.com/repos/vlio20/ng2-date-picker/branches{/branch}","tags_url":"https://api.github.com/repos/vlio20/ng2-date-picker/tags","blobs_url":"https://api.github.com/repos/vlio20/ng2-date-picker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlio20/ng2-date-picker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlio20/ng2-date-picker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlio20/ng2-date-picker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlio20/ng2-date-picker/statuses/{sha}","languages_url":"https://api.github.com/repos/vlio20/ng2-date-picker/languages","stargazers_url":"https://api.github.com/repos/vlio20/ng2-date-picker/stargazers","contributors_url":"https://api.github.com/repos/vlio20/ng2-date-picker/contributors","subscribers_url":"https://api.github.com/repos/vlio20/ng2-date-picker/subscribers","subscription_url":"https://api.github.com/repos/vlio20/ng2-date-picker/subscription","commits_url":"https://api.github.com/repos/vlio20/ng2-date-picker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlio20/ng2-date-picker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlio20/ng2-date-picker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlio20/ng2-date-picker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlio20/ng2-date-picker/contents/{+path}","compare_url":"https://api.github.com/repos/vlio20/ng2-date-picker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlio20/ng2-date-picker/merges","archive_url":"https://api.github.com/repos/vlio20/ng2-date-picker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlio20/ng2-date-picker/downloads","issues_url":"https://api.github.com/repos/vlio20/ng2-date-picker/issues{/number}","pulls_url":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls{/number}","milestones_url":"https://api.github.com/repos/vlio20/ng2-date-picker/milestones{/number}","notifications_url":"https://api.github.com/repos/vlio20/ng2-date-picker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlio20/ng2-date-picker/labels{/name}","releases_url":"https://api.github.com/repos/vlio20/ng2-date-picker/releases{/id}","deployments_url":"https://api.github.com/repos/vlio20/ng2-date-picker/deployments","created_at":"2016-11-04T12:07:27Z","updated_at":"2017-03-07T18:34:01Z","pushed_at":"2017-03-07T19:45:55Z","git_url":"git://github.com/vlio20/ng2-date-picker.git","ssh_url":"git@github.com:vlio20/ng2-date-picker.git","clone_url":"https://github.com/vlio20/ng2-date-picker.git","svn_url":"https://github.com/vlio20/ng2-date-picker","homepage":"https://vlio20.github.io/ng2-date-picker/","size":3521,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/14"},"html":{"href":"https://github.com/vlio20/ng2-date-picker/pull/14"},"issue":{"href":"https://api.github.com/repos/vlio20/ng2-date-picker/issues/14"},"comments":{"href":"https://api.github.com/repos/vlio20/ng2-date-picker/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vlio20/ng2-date-picker/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/vlio20/ng2-date-picker/statuses/064205a850c5dae11f3587792d38ff933bcf868c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vlio20","id":4542641,"avatar_url":"https://avatars3.githubusercontent.com/u/4542641?v=3","gravatar_id":"","url":"https://api.github.com/users/vlio20","html_url":"https://github.com/vlio20","followers_url":"https://api.github.com/users/vlio20/followers","following_url":"https://api.github.com/users/vlio20/following{/other_user}","gists_url":"https://api.github.com/users/vlio20/gists{/gist_id}","starred_url":"https://api.github.com/users/vlio20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlio20/subscriptions","organizations_url":"https://api.github.com/users/vlio20/orgs","repos_url":"https://api.github.com/users/vlio20/repos","events_url":"https://api.github.com/users/vlio20/events{/privacy}","received_events_url":"https://api.github.com/users/vlio20/received_events","type":"User","site_admin":false},"comments":12,"review_comments":9,"maintainer_can_modify":false,"commits":1,"additions":828,"deletions":71,"changed_files":23}}
{"actor":{"display_login":"vlio20"}}