{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/135260818","pull_request_review_id":58653819,"id":135260818,"diff_hunk":"@@ -111,45 +130,74 @@ - (void)updatePlaceholder {\n   }\n \n   UIEdgeInsets textInsets = [self textInsets:UIEdgeInsetsZero];\n-  CGFloat underlineYConstant = textInsets.top + [self estimatedTextHeight] +\n+  CGFloat underlineBottomConstant = textInsets.top + [self estimatedTextHeight] +\n       [self beneathInputPadding];\n   // When floating placeholders are turned off, the underline will drift up unless this is set. Even\n   // tho it is redundant when floating is on, we just keep it on always for simplicity.\n   // Note: This is an issue only on singleline text fields.\n-  if (![self.textInput isKindOfClass:[MDCMultilineTextField class]] && !self.underlineY) {\n-    self.underlineY = [NSLayoutConstraint constraintWithItem:self.textInput.underline\n-                                                   attribute:NSLayoutAttributeBottom\n-                                                   relatedBy:NSLayoutRelationEqual\n-                                                      toItem:self.textInput\n-                                                   attribute:NSLayoutAttributeTop\n-                                                  multiplier:1\n-                                                    constant:underlineYConstant];\n-    self.underlineY.active = YES;\n+  if (!self.underlineBottom) {\n+    if (![self.textInput isKindOfClass:[MDCMultilineTextField class]]) {","path":"components/TextFields/src/MDCTextInputControllerTextFieldBox.m","position":85,"original_position":85,"commit_id":"9c1e6eb920013d24faea480edd3f529e6d42195e","original_commit_id":"9c1e6eb920013d24faea480edd3f529e6d42195e","user":{"login":"ianegordon","id":1121006,"avatar_url":"https://avatars1.githubusercontent.com/u/1121006?v=4","gravatar_id":"","url":"https://api.github.com/users/ianegordon","html_url":"https://github.com/ianegordon","followers_url":"https://api.github.com/users/ianegordon/followers","following_url":"https://api.github.com/users/ianegordon/following{/other_user}","gists_url":"https://api.github.com/users/ianegordon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianegordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianegordon/subscriptions","organizations_url":"https://api.github.com/users/ianegordon/orgs","repos_url":"https://api.github.com/users/ianegordon/repos","events_url":"https://api.github.com/users/ianegordon/events{/privacy}","received_events_url":"https://api.github.com/users/ianegordon/received_events","type":"User","site_admin":false},"body":"super-super-nit / consider:\r\nIf I am reading an if statement, I usually find it easier to parse\r\nif (Statement) {\r\n} else {\r\n}\r\n-OVER-\r\nif (!Statement) {\r\n} else {\r\n}\r\n\r\nPrefer the first clause being the positive / true outcome.  This may not be useful / helpful / applicable.","created_at":"2017-08-25T13:40:15Z","updated_at":"2017-08-25T13:42:08Z","html_url":"https://github.com/material-components/material-components-ios/pull/1902#discussion_r135260818","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/135260818"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/1902#discussion_r135260818"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902","id":137584106,"html_url":"https://github.com/material-components/material-components-ios/pull/1902","diff_url":"https://github.com/material-components/material-components-ios/pull/1902.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/1902.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1902","number":1902,"state":"open","locked":false,"title":"[TextFields] Updating controllers for new text inset logic","user":{"login":"willlarche","id":1271525,"avatar_url":"https://avatars1.githubusercontent.com/u/1271525?v=4","gravatar_id":"","url":"https://api.github.com/users/willlarche","html_url":"https://github.com/willlarche","followers_url":"https://api.github.com/users/willlarche/followers","following_url":"https://api.github.com/users/willlarche/following{/other_user}","gists_url":"https://api.github.com/users/willlarche/gists{/gist_id}","starred_url":"https://api.github.com/users/willlarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willlarche/subscriptions","organizations_url":"https://api.github.com/users/willlarche/orgs","repos_url":"https://api.github.com/users/willlarche/repos","events_url":"https://api.github.com/users/willlarche/events{/privacy}","received_events_url":"https://api.github.com/users/willlarche/received_events","type":"User","site_admin":false},"body":"And a little bit of cleanup.","created_at":"2017-08-25T01:32:58Z","updated_at":"2017-08-25T13:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7499e198f15d5c2b40987e3be2017d6999e5926","assignee":{"login":"ianegordon","id":1121006,"avatar_url":"https://avatars1.githubusercontent.com/u/1121006?v=4","gravatar_id":"","url":"https://api.github.com/users/ianegordon","html_url":"https://github.com/ianegordon","followers_url":"https://api.github.com/users/ianegordon/followers","following_url":"https://api.github.com/users/ianegordon/following{/other_user}","gists_url":"https://api.github.com/users/ianegordon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianegordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianegordon/subscriptions","organizations_url":"https://api.github.com/users/ianegordon/orgs","repos_url":"https://api.github.com/users/ianegordon/repos","events_url":"https://api.github.com/users/ianegordon/events{/privacy}","received_events_url":"https://api.github.com/users/ianegordon/received_events","type":"User","site_admin":false},"assignees":[{"login":"ianegordon","id":1121006,"avatar_url":"https://avatars1.githubusercontent.com/u/1121006?v=4","gravatar_id":"","url":"https://api.github.com/users/ianegordon","html_url":"https://github.com/ianegordon","followers_url":"https://api.github.com/users/ianegordon/followers","following_url":"https://api.github.com/users/ianegordon/following{/other_user}","gists_url":"https://api.github.com/users/ianegordon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianegordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianegordon/subscriptions","organizations_url":"https://api.github.com/users/ianegordon/orgs","repos_url":"https://api.github.com/users/ianegordon/repos","events_url":"https://api.github.com/users/ianegordon/events{/privacy}","received_events_url":"https://api.github.com/users/ianegordon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/1902/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/9c1e6eb920013d24faea480edd3f529e6d42195e","head":{"label":"willlarche:feature-textFields-newStyles-inputInsets-controllers","ref":"feature-textFields-newStyles-inputInsets-controllers","sha":"9c1e6eb920013d24faea480edd3f529e6d42195e","user":{"login":"willlarche","id":1271525,"avatar_url":"https://avatars1.githubusercontent.com/u/1271525?v=4","gravatar_id":"","url":"https://api.github.com/users/willlarche","html_url":"https://github.com/willlarche","followers_url":"https://api.github.com/users/willlarche/followers","following_url":"https://api.github.com/users/willlarche/following{/other_user}","gists_url":"https://api.github.com/users/willlarche/gists{/gist_id}","starred_url":"https://api.github.com/users/willlarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willlarche/subscriptions","organizations_url":"https://api.github.com/users/willlarche/orgs","repos_url":"https://api.github.com/users/willlarche/repos","events_url":"https://api.github.com/users/willlarche/events{/privacy}","received_events_url":"https://api.github.com/users/willlarche/received_events","type":"User","site_admin":false},"repo":{"id":77475957,"name":"material-components-ios","full_name":"willlarche/material-components-ios","owner":{"login":"willlarche","id":1271525,"avatar_url":"https://avatars1.githubusercontent.com/u/1271525?v=4","gravatar_id":"","url":"https://api.github.com/users/willlarche","html_url":"https://github.com/willlarche","followers_url":"https://api.github.com/users/willlarche/followers","following_url":"https://api.github.com/users/willlarche/following{/other_user}","gists_url":"https://api.github.com/users/willlarche/gists{/gist_id}","starred_url":"https://api.github.com/users/willlarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willlarche/subscriptions","organizations_url":"https://api.github.com/users/willlarche/orgs","repos_url":"https://api.github.com/users/willlarche/repos","events_url":"https://api.github.com/users/willlarche/events{/privacy}","received_events_url":"https://api.github.com/users/willlarche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willlarche/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/willlarche/material-components-ios","forks_url":"https://api.github.com/repos/willlarche/material-components-ios/forks","keys_url":"https://api.github.com/repos/willlarche/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willlarche/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willlarche/material-components-ios/teams","hooks_url":"https://api.github.com/repos/willlarche/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/willlarche/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/willlarche/material-components-ios/events","assignees_url":"https://api.github.com/repos/willlarche/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/willlarche/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/willlarche/material-components-ios/tags","blobs_url":"https://api.github.com/repos/willlarche/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willlarche/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willlarche/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/willlarche/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willlarche/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/willlarche/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/willlarche/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/willlarche/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/willlarche/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/willlarche/material-components-ios/subscription","commits_url":"https://api.github.com/repos/willlarche/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/willlarche/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/willlarche/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/willlarche/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/willlarche/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/willlarche/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willlarche/material-components-ios/merges","archive_url":"https://api.github.com/repos/willlarche/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willlarche/material-components-ios/downloads","issues_url":"https://api.github.com/repos/willlarche/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/willlarche/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/willlarche/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/willlarche/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willlarche/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/willlarche/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/willlarche/material-components-ios/deployments","created_at":"2016-12-27T18:47:40Z","updated_at":"2017-05-25T09:42:48Z","pushed_at":"2017-08-25T01:42:00Z","git_url":"git://github.com/willlarche/material-components-ios.git","ssh_url":"git@github.com:willlarche/material-components-ios.git","clone_url":"https://github.com/willlarche/material-components-ios.git","svn_url":"https://github.com/willlarche/material-components-ios","homepage":"","size":436986,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"material-components:feature-textFields-newStyles","ref":"feature-textFields-newStyles","sha":"38eb0c7110422411bd45f9e9dcc215225c722620","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2017-08-24T15:54:00Z","pushed_at":"2017-08-25T13:09:53Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":436451,"stargazers_count":1458,"watchers_count":1458,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":332,"forks":182,"open_issues":332,"watchers":1458,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/1902"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/1902"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/1902/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/1902/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/9c1e6eb920013d24faea480edd3f529e6d42195e"}}}}
{"actor":{"display_login":"ianegordon"}}