{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/vic/issues/4171","repository_url":"https://api.github.com/repos/vmware/vic","labels_url":"https://api.github.com/repos/vmware/vic/issues/4171/labels{/name}","comments_url":"https://api.github.com/repos/vmware/vic/issues/4171/comments","events_url":"https://api.github.com/repos/vmware/vic/issues/4171/events","html_url":"https://github.com/vmware/vic/issues/4171","id":212599834,"number":4171,"title":"container output handler doesn't release output stream","user":{"login":"cgtexmex","id":726112,"avatar_url":"https://avatars1.githubusercontent.com/u/726112?v=3","gravatar_id":"","url":"https://api.github.com/users/cgtexmex","html_url":"https://github.com/cgtexmex","followers_url":"https://api.github.com/users/cgtexmex/followers","following_url":"https://api.github.com/users/cgtexmex/following{/other_user}","gists_url":"https://api.github.com/users/cgtexmex/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtexmex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtexmex/subscriptions","organizations_url":"https://api.github.com/users/cgtexmex/orgs","repos_url":"https://api.github.com/users/cgtexmex/repos","events_url":"https://api.github.com/users/cgtexmex/events{/privacy}","received_events_url":"https://api.github.com/users/cgtexmex/received_events","type":"User","site_admin":false},"labels":[{"id":392119587,"url":"https://api.github.com/repos/vmware/vic/labels/component/portlayer","name":"component/portlayer","color":"d4c5f9","default":false},{"id":310959982,"url":"https://api.github.com/repos/vmware/vic/labels/kind/bug","name":"kind/bug","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-08T00:15:41Z","updated_at":"2017-03-09T15:11:15Z","closed_at":null,"body":"The portLayer makes use of a custom handler to facilitate streaming to the client.  This [ContainerOutputHandler's](https://github.com/vmware/vic/blob/master/lib/apiservers/portlayer/restapi/handlers/interaction_handlers.go#L488) `WriteResponse` func will never release the output stream.  Even if the client closes the transport. This will eventually cause issues for the portLayer API.\r\n\r\nThe [EventHandler](https://github.com/vmware/vic/blob/master/lib/apiservers/portlayer/restapi/handlers/event_handlers.go#L114) makes use of a similar custom handler that will release the output stream when the client closes the transport.  \r\n\r\nI suggest we refactor this bit of code to create a reusable streaming handler that that will be available to any portLayer handler that needs to stream data.  At a minimum the ContainerOutputHandler should be updated to release the stream.\r\n\r\n "},"comment":{"url":"https://api.github.com/repos/vmware/vic/issues/comments/285378009","html_url":"https://github.com/vmware/vic/issues/4171#issuecomment-285378009","issue_url":"https://api.github.com/repos/vmware/vic/issues/4171","id":285378009,"user":{"login":"mhagen-vmware","id":19393273,"avatar_url":"https://avatars3.githubusercontent.com/u/19393273?v=3","gravatar_id":"","url":"https://api.github.com/users/mhagen-vmware","html_url":"https://github.com/mhagen-vmware","followers_url":"https://api.github.com/users/mhagen-vmware/followers","following_url":"https://api.github.com/users/mhagen-vmware/following{/other_user}","gists_url":"https://api.github.com/users/mhagen-vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/mhagen-vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhagen-vmware/subscriptions","organizations_url":"https://api.github.com/users/mhagen-vmware/orgs","repos_url":"https://api.github.com/users/mhagen-vmware/repos","events_url":"https://api.github.com/users/mhagen-vmware/events{/privacy}","received_events_url":"https://api.github.com/users/mhagen-vmware/received_events","type":"User","site_admin":false},"created_at":"2017-03-09T15:11:15Z","updated_at":"2017-03-09T15:11:15Z","body":"Please prioritize and move to backlog when ready."}}
{"actor":{"display_login":"mhagen-vmware"}}