{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/119060445","pull_request_review_id":40904971,"id":119060445,"diff_hunk":"@@ -256,7 +283,7 @@ class CommandRequestImpl : public CommandImpl,\n    * interface that returns response.\n    * @return resulting code for sending to mobile application.\n    */\n-  mobile_apis::Result::eType PrepareResultCodeForResponse(\n+  virtual mobile_apis::Result::eType PrepareResultCodeForResponse(","path":"src/components/application_manager/include/application_manager/commands/command_request_impl.h","position":null,"original_position":50,"commit_id":"9e2ce859407b0ff871832e4f6e99254cc2eb4a8f","original_commit_id":"9b902f45d86543319ab7f6aa12375feb5fa18d5f","user":{"login":"AKalinich-Luxoft","id":5848997,"avatar_url":"https://avatars0.githubusercontent.com/u/5848997?v=3","gravatar_id":"","url":"https://api.github.com/users/AKalinich-Luxoft","html_url":"https://github.com/AKalinich-Luxoft","followers_url":"https://api.github.com/users/AKalinich-Luxoft/followers","following_url":"https://api.github.com/users/AKalinich-Luxoft/following{/other_user}","gists_url":"https://api.github.com/users/AKalinich-Luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/AKalinich-Luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKalinich-Luxoft/subscriptions","organizations_url":"https://api.github.com/users/AKalinich-Luxoft/orgs","repos_url":"https://api.github.com/users/AKalinich-Luxoft/repos","events_url":"https://api.github.com/users/AKalinich-Luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/AKalinich-Luxoft/received_events","type":"User","site_admin":false},"body":"@AByzhynar done in https://github.com/smartdevicelink/sdl_core/pull/1567/commits/9e2ce859407b0ff871832e4f6e99254cc2eb4a8f","created_at":"2017-05-30T10:09:46Z","updated_at":"2017-05-30T10:09:46Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/1567#discussion_r119060445","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/119060445"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/1567#discussion_r119060445"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567","id":122607438,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/1567","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/1567.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/1567.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1567","number":1567,"state":"open","locked":false,"title":"Fix AlertManeuver success result in case of UNSUPPORTED_RESOURCE","user":{"login":"AKalinich-Luxoft","id":5848997,"avatar_url":"https://avatars0.githubusercontent.com/u/5848997?v=3","gravatar_id":"","url":"https://api.github.com/users/AKalinich-Luxoft","html_url":"https://github.com/AKalinich-Luxoft","followers_url":"https://api.github.com/users/AKalinich-Luxoft/followers","following_url":"https://api.github.com/users/AKalinich-Luxoft/following{/other_user}","gists_url":"https://api.github.com/users/AKalinich-Luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/AKalinich-Luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKalinich-Luxoft/subscriptions","organizations_url":"https://api.github.com/users/AKalinich-Luxoft/orgs","repos_url":"https://api.github.com/users/AKalinich-Luxoft/repos","events_url":"https://api.github.com/users/AKalinich-Luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/AKalinich-Luxoft/received_events","type":"User","site_admin":false},"body":"Fixed `AlertManeuver` success result in case of `UNSUPPORTED_RESOURCE`.\r\nThe problem was that SDL does not check success result in this specific case.\r\n\r\nIn this pull request:\r\n- Added check for `UNSUPPORTED_RESOURCE` case\r\n- All specific checks were moved to `PrepareResultForMobileResponse` function\r\n- `PrepareResultForMobileResponse` is currently virtual","created_at":"2017-05-26T09:43:45Z","updated_at":"2017-05-30T10:09:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd1d2fcaf56fcc84b522cac0f2c91ebaea989ac0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1567/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/9e2ce859407b0ff871832e4f6e99254cc2eb4a8f","head":{"label":"AKalinich-Luxoft:fix/fix_alert_maneuer_result_code","ref":"fix/fix_alert_maneuer_result_code","sha":"9e2ce859407b0ff871832e4f6e99254cc2eb4a8f","user":{"login":"AKalinich-Luxoft","id":5848997,"avatar_url":"https://avatars0.githubusercontent.com/u/5848997?v=3","gravatar_id":"","url":"https://api.github.com/users/AKalinich-Luxoft","html_url":"https://github.com/AKalinich-Luxoft","followers_url":"https://api.github.com/users/AKalinich-Luxoft/followers","following_url":"https://api.github.com/users/AKalinich-Luxoft/following{/other_user}","gists_url":"https://api.github.com/users/AKalinich-Luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/AKalinich-Luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKalinich-Luxoft/subscriptions","organizations_url":"https://api.github.com/users/AKalinich-Luxoft/orgs","repos_url":"https://api.github.com/users/AKalinich-Luxoft/repos","events_url":"https://api.github.com/users/AKalinich-Luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/AKalinich-Luxoft/received_events","type":"User","site_admin":false},"repo":{"id":92272405,"name":"sdl_core","full_name":"AKalinich-Luxoft/sdl_core","owner":{"login":"AKalinich-Luxoft","id":5848997,"avatar_url":"https://avatars0.githubusercontent.com/u/5848997?v=3","gravatar_id":"","url":"https://api.github.com/users/AKalinich-Luxoft","html_url":"https://github.com/AKalinich-Luxoft","followers_url":"https://api.github.com/users/AKalinich-Luxoft/followers","following_url":"https://api.github.com/users/AKalinich-Luxoft/following{/other_user}","gists_url":"https://api.github.com/users/AKalinich-Luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/AKalinich-Luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKalinich-Luxoft/subscriptions","organizations_url":"https://api.github.com/users/AKalinich-Luxoft/orgs","repos_url":"https://api.github.com/users/AKalinich-Luxoft/repos","events_url":"https://api.github.com/users/AKalinich-Luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/AKalinich-Luxoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AKalinich-Luxoft/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core","forks_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/forks","keys_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/teams","hooks_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/events","assignees_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/tags","blobs_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/languages","stargazers_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/subscription","commits_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/merges","archive_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/downloads","issues_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/deployments","created_at":"2017-05-24T09:05:16Z","updated_at":"2017-05-24T09:05:27Z","pushed_at":"2017-05-30T10:06:40Z","git_url":"git://github.com/AKalinich-Luxoft/sdl_core.git","ssh_url":"git@github.com:AKalinich-Luxoft/sdl_core.git","clone_url":"https://github.com/AKalinich-Luxoft/sdl_core.git","svn_url":"https://github.com/AKalinich-Luxoft/sdl_core","homepage":"","size":305772,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"09e4eac5a4f176eba8f98dbb9525f07acccd330f","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars0.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars0.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2017-05-25T06:48:49Z","pushed_at":"2017-05-30T10:06:42Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":305755,"stargazers_count":118,"watchers_count":118,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":273,"forks":136,"open_issues":273,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/1567"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1567"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1567/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1567/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/9e2ce859407b0ff871832e4f6e99254cc2eb4a8f"}}}}
{"actor":{"display_login":"AKalinich-Luxoft"}}