{"action":"created","comment":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/106789190","pull_request_review_id":27732350,"id":106789190,"diff_hunk":"@@ -109,14 +116,13 @@ describe('Matchmaker', function () {\n \t\tassert.strictEqual(matchmaker.searches.get(formatid).size, 0);\n \t});\n \n-\t// FIXME: a race condition in battles and sockets breaks this test\n-\tit.skip('should create a new battle room after matchmaking', function () {\n+\tit('should create a new battle room after matchmaking', function () {\n \t\tlet formatid = 'gen7ou';\n \t\tlet {startBattle} = matchmaker;\n \t\tmatchmaker.startBattle = (...args) => {\n \t\t\tmatchmaker.startBattle = startBattle;\n-\t\t\tlet room = matchmaker.startBattle(...args);\n-\t\t\tassert.ok(room instanceof Rooms.BattleRoom);\n+\t\t\tthis.room = matchmaker.startBattle(...args);","path":"test/application/ladders-matchmaker.js","position":43,"original_position":43,"commit_id":"7db58eab3f0d368915c03895be9cdd6c68229044","original_commit_id":"7db58eab3f0d368915c03895be9cdd6c68229044","user":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars0.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"body":"The room can't be destroyed outside of `afterEach`'s callback without making the test asynchronous. `this.room` may end up showing up again if bugs related to `Matchmaker#startBattle` pop up to merit more tests","created_at":"2017-03-18T19:38:12Z","updated_at":"2017-03-18T19:38:12Z","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3365#discussion_r106789190","pull_request_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365","_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/106789190"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/3365#discussion_r106789190"},"pull_request":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365"}}},"pull_request":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365","id":111149069,"html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3365","diff_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3365.diff","patch_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3365.patch","issue_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3365","number":3365,"state":"open","locked":false,"title":"Rooms: fix race condition in BattleRoom#onJoin","user":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars0.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"body":"When a battle is first started, it has a habit of setting up its\r\nsubchannels in workers out of order, broadcasting to subchannels before\r\nany sockets have been moved to any yet. Delaying updating the room\r\nuntil after `GlobalRoom#startBattle` has finished joining the players to\r\nthe room stops this.","created_at":"2017-03-16T19:38:52Z","updated_at":"2017-03-18T19:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7077cbfa366e8fbfe48f44b064d6cb390117a360","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365/commits","review_comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365/comments","review_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3365/comments","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/7db58eab3f0d368915c03895be9cdd6c68229044","head":{"label":"Morfent:roomrace","ref":"roomrace","sha":"7db58eab3f0d368915c03895be9cdd6c68229044","user":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars0.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"repo":{"id":43088955,"name":"Pokemon-Showdown","full_name":"Morfent/Pokemon-Showdown","owner":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars0.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Morfent/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/Morfent/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/deployments","created_at":"2015-09-24T19:42:35Z","updated_at":"2016-05-25T17:23:44Z","pushed_at":"2017-03-18T07:40:50Z","git_url":"git://github.com/Morfent/Pokemon-Showdown.git","ssh_url":"git@github.com:Morfent/Pokemon-Showdown.git","clone_url":"https://github.com/Morfent/Pokemon-Showdown.git","svn_url":"https://github.com/Morfent/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":46815,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zarel:master","ref":"master","sha":"b8df1b365a1420823803e3cb50338b637ef28c25","user":{"login":"Zarel","id":551184,"avatar_url":"https://avatars0.githubusercontent.com/u/551184?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"repo":{"id":3038446,"name":"Pokemon-Showdown","full_name":"Zarel/Pokemon-Showdown","owner":{"login":"Zarel","id":551184,"avatar_url":"https://avatars0.githubusercontent.com/u/551184?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zarel/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":false,"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/deployments","created_at":"2011-12-23T04:52:33Z","updated_at":"2017-03-15T06:04:09Z","pushed_at":"2017-03-18T19:16:04Z","git_url":"git://github.com/Zarel/Pokemon-Showdown.git","ssh_url":"git@github.com:Zarel/Pokemon-Showdown.git","clone_url":"https://github.com/Zarel/Pokemon-Showdown.git","svn_url":"https://github.com/Zarel/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":46891,"stargazers_count":1115,"watchers_count":1115,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1138,"mirror_url":null,"open_issues_count":53,"forks":1138,"open_issues":53,"watchers":1115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/3365"},"issue":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3365"},"comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3365/comments"},"review_comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365/comments"},"review_comment":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3365/commits"},"statuses":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/7db58eab3f0d368915c03895be9cdd6c68229044"}}}}
{"actor":{"display_login":"Morfent"}}