{"action":"created","comment":{"url":"https://api.github.com/repos/gnosis/olympia-interface/pulls/comments/147190162","pull_request_review_id":72249949,"id":147190162,"diff_hunk":"@@ -22,23 +23,18 @@ class Uport extends InjectedWeb3 {\n    */\n   async initialize(opts) {\n     super.initialize(opts)\n-    this.runProviderRegister(this, { priority: Uport.providerPriority })\n \n+    this.runProviderRegister(this, { priority: Uport.providerPriority })\n \n     const uport = new Connect('GnosisOlympia')\n     this.web3 = await uport.getWeb3()\n+\n     this.provider = await uport.getProvider()\n-    this.walletEnabled = true\n-    if (this.walletEnabled) {\n-      this.network = await this.getNetwork()\n-      this.account = await this.getAccount()\n-      this.balance = await this.getBalance()\n-    }\n+    this.network = await this.getNetwork()\n+\n     return this.runProviderUpdate(this, {\n-      available: this.walletEnabled && this.account != null,\n+      available: true,\n       network: this.network,\n-      account: this.account,\n-      balance: this.balance,","path":"src/integrations/uport/index.js","position":36,"original_position":36,"commit_id":"f46b4b995d5d690d7b502aa2c65c2db6bf9d247e","original_commit_id":"f46b4b995d5d690d7b502aa2c65c2db6bf9d247e","user":{"login":"cag","id":298447,"avatar_url":"https://avatars1.githubusercontent.com/u/298447?v=4","gravatar_id":"","url":"https://api.github.com/users/cag","html_url":"https://github.com/cag","followers_url":"https://api.github.com/users/cag/followers","following_url":"https://api.github.com/users/cag/following{/other_user}","gists_url":"https://api.github.com/users/cag/gists{/gist_id}","starred_url":"https://api.github.com/users/cag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cag/subscriptions","organizations_url":"https://api.github.com/users/cag/orgs","repos_url":"https://api.github.com/users/cag/repos","events_url":"https://api.github.com/users/cag/events{/privacy}","received_events_url":"https://api.github.com/users/cag/received_events","type":"User","site_admin":false},"body":"UPort guarantees an account?","created_at":"2017-10-26T16:04:30Z","updated_at":"2017-10-26T16:10:00Z","html_url":"https://github.com/gnosis/olympia-interface/pull/5#discussion_r147190162","pull_request_url":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gnosis/olympia-interface/pulls/comments/147190162"},"html":{"href":"https://github.com/gnosis/olympia-interface/pull/5#discussion_r147190162"},"pull_request":{"href":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5","id":148973665,"html_url":"https://github.com/gnosis/olympia-interface/pull/5","diff_url":"https://github.com/gnosis/olympia-interface/pull/5.diff","patch_url":"https://github.com/gnosis/olympia-interface/pull/5.patch","issue_url":"https://api.github.com/repos/gnosis/olympia-interface/issues/5","number":5,"state":"open","locked":false,"title":"Feature PM-98 Show account info from uPort","user":{"login":"apanizo","id":4266059,"avatar_url":"https://avatars3.githubusercontent.com/u/4266059?v=4","gravatar_id":"","url":"https://api.github.com/users/apanizo","html_url":"https://github.com/apanizo","followers_url":"https://api.github.com/users/apanizo/followers","following_url":"https://api.github.com/users/apanizo/following{/other_user}","gists_url":"https://api.github.com/users/apanizo/gists{/gist_id}","starred_url":"https://api.github.com/users/apanizo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apanizo/subscriptions","organizations_url":"https://api.github.com/users/apanizo/orgs","repos_url":"https://api.github.com/users/apanizo/repos","events_url":"https://api.github.com/users/apanizo/events{/privacy}","received_events_url":"https://api.github.com/users/apanizo/received_events","type":"User","site_admin":false},"body":"**Due Diligence**\r\n- [ ] Affects database\r\n- [ ] Breaking change\r\n- [x] Tests\r\n- [ ] Documentation\r\n\r\n**Description**\r\nThis PR improves the UPort behavior on the app. And shows the account info on the top right-hand side of all pages updated.\r\n\r\n![screenshot 2017-10-26 17 51 55](https://user-images.githubusercontent.com/4266059/32063032-7acc286c-ba76-11e7-8c0f-a45070b6ad18.png)\r\n\r\n","created_at":"2017-10-26T15:46:49Z","updated_at":"2017-10-26T16:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7be90631a2efc634ab01246ae159df8476e7ca6d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andre-meyer","id":969493,"avatar_url":"https://avatars3.githubusercontent.com/u/969493?v=4","gravatar_id":"","url":"https://api.github.com/users/andre-meyer","html_url":"https://github.com/andre-meyer","followers_url":"https://api.github.com/users/andre-meyer/followers","following_url":"https://api.github.com/users/andre-meyer/following{/other_user}","gists_url":"https://api.github.com/users/andre-meyer/gists{/gist_id}","starred_url":"https://api.github.com/users/andre-meyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre-meyer/subscriptions","organizations_url":"https://api.github.com/users/andre-meyer/orgs","repos_url":"https://api.github.com/users/andre-meyer/repos","events_url":"https://api.github.com/users/andre-meyer/events{/privacy}","received_events_url":"https://api.github.com/users/andre-meyer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5/commits","review_comments_url":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5/comments","review_comment_url":"https://api.github.com/repos/gnosis/olympia-interface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnosis/olympia-interface/issues/5/comments","statuses_url":"https://api.github.com/repos/gnosis/olympia-interface/statuses/f46b4b995d5d690d7b502aa2c65c2db6bf9d247e","head":{"label":"gnosis:feature/PM-98-show-account-info-from-uport","ref":"feature/PM-98-show-account-info-from-uport","sha":"f46b4b995d5d690d7b502aa2c65c2db6bf9d247e","user":{"login":"gnosis","id":24954468,"avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":107691912,"name":"olympia-interface","full_name":"gnosis/olympia-interface","owner":{"login":"gnosis","id":24954468,"avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnosis/olympia-interface","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/olympia-interface","forks_url":"https://api.github.com/repos/gnosis/olympia-interface/forks","keys_url":"https://api.github.com/repos/gnosis/olympia-interface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/olympia-interface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/olympia-interface/teams","hooks_url":"https://api.github.com/repos/gnosis/olympia-interface/hooks","issue_events_url":"https://api.github.com/repos/gnosis/olympia-interface/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/olympia-interface/events","assignees_url":"https://api.github.com/repos/gnosis/olympia-interface/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/olympia-interface/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/olympia-interface/tags","blobs_url":"https://api.github.com/repos/gnosis/olympia-interface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/olympia-interface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/olympia-interface/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/olympia-interface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/olympia-interface/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/olympia-interface/languages","stargazers_url":"https://api.github.com/repos/gnosis/olympia-interface/stargazers","contributors_url":"https://api.github.com/repos/gnosis/olympia-interface/contributors","subscribers_url":"https://api.github.com/repos/gnosis/olympia-interface/subscribers","subscription_url":"https://api.github.com/repos/gnosis/olympia-interface/subscription","commits_url":"https://api.github.com/repos/gnosis/olympia-interface/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/olympia-interface/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/olympia-interface/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/olympia-interface/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/olympia-interface/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/olympia-interface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/olympia-interface/merges","archive_url":"https://api.github.com/repos/gnosis/olympia-interface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/olympia-interface/downloads","issues_url":"https://api.github.com/repos/gnosis/olympia-interface/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/olympia-interface/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/olympia-interface/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/olympia-interface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/olympia-interface/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/olympia-interface/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/olympia-interface/deployments","created_at":"2017-10-20T15:01:49Z","updated_at":"2017-10-20T15:04:06Z","pushed_at":"2017-10-26T15:46:50Z","git_url":"git://github.com/gnosis/olympia-interface.git","ssh_url":"git@github.com:gnosis/olympia-interface.git","clone_url":"https://github.com/gnosis/olympia-interface.git","svn_url":"https://github.com/gnosis/olympia-interface","homepage":null,"size":1277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gnosis:development","ref":"development","sha":"e3a158b764f612dafaecbc9a6b5cf726733052f8","user":{"login":"gnosis","id":24954468,"avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"repo":{"id":107691912,"name":"olympia-interface","full_name":"gnosis/olympia-interface","owner":{"login":"gnosis","id":24954468,"avatar_url":"https://avatars1.githubusercontent.com/u/24954468?v=4","gravatar_id":"","url":"https://api.github.com/users/gnosis","html_url":"https://github.com/gnosis","followers_url":"https://api.github.com/users/gnosis/followers","following_url":"https://api.github.com/users/gnosis/following{/other_user}","gists_url":"https://api.github.com/users/gnosis/gists{/gist_id}","starred_url":"https://api.github.com/users/gnosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnosis/subscriptions","organizations_url":"https://api.github.com/users/gnosis/orgs","repos_url":"https://api.github.com/users/gnosis/repos","events_url":"https://api.github.com/users/gnosis/events{/privacy}","received_events_url":"https://api.github.com/users/gnosis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnosis/olympia-interface","description":null,"fork":false,"url":"https://api.github.com/repos/gnosis/olympia-interface","forks_url":"https://api.github.com/repos/gnosis/olympia-interface/forks","keys_url":"https://api.github.com/repos/gnosis/olympia-interface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnosis/olympia-interface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnosis/olympia-interface/teams","hooks_url":"https://api.github.com/repos/gnosis/olympia-interface/hooks","issue_events_url":"https://api.github.com/repos/gnosis/olympia-interface/issues/events{/number}","events_url":"https://api.github.com/repos/gnosis/olympia-interface/events","assignees_url":"https://api.github.com/repos/gnosis/olympia-interface/assignees{/user}","branches_url":"https://api.github.com/repos/gnosis/olympia-interface/branches{/branch}","tags_url":"https://api.github.com/repos/gnosis/olympia-interface/tags","blobs_url":"https://api.github.com/repos/gnosis/olympia-interface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnosis/olympia-interface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnosis/olympia-interface/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnosis/olympia-interface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnosis/olympia-interface/statuses/{sha}","languages_url":"https://api.github.com/repos/gnosis/olympia-interface/languages","stargazers_url":"https://api.github.com/repos/gnosis/olympia-interface/stargazers","contributors_url":"https://api.github.com/repos/gnosis/olympia-interface/contributors","subscribers_url":"https://api.github.com/repos/gnosis/olympia-interface/subscribers","subscription_url":"https://api.github.com/repos/gnosis/olympia-interface/subscription","commits_url":"https://api.github.com/repos/gnosis/olympia-interface/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnosis/olympia-interface/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnosis/olympia-interface/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnosis/olympia-interface/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnosis/olympia-interface/contents/{+path}","compare_url":"https://api.github.com/repos/gnosis/olympia-interface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnosis/olympia-interface/merges","archive_url":"https://api.github.com/repos/gnosis/olympia-interface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnosis/olympia-interface/downloads","issues_url":"https://api.github.com/repos/gnosis/olympia-interface/issues{/number}","pulls_url":"https://api.github.com/repos/gnosis/olympia-interface/pulls{/number}","milestones_url":"https://api.github.com/repos/gnosis/olympia-interface/milestones{/number}","notifications_url":"https://api.github.com/repos/gnosis/olympia-interface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnosis/olympia-interface/labels{/name}","releases_url":"https://api.github.com/repos/gnosis/olympia-interface/releases{/id}","deployments_url":"https://api.github.com/repos/gnosis/olympia-interface/deployments","created_at":"2017-10-20T15:01:49Z","updated_at":"2017-10-20T15:04:06Z","pushed_at":"2017-10-26T15:46:50Z","git_url":"git://github.com/gnosis/olympia-interface.git","ssh_url":"git@github.com:gnosis/olympia-interface.git","clone_url":"https://github.com/gnosis/olympia-interface.git","svn_url":"https://github.com/gnosis/olympia-interface","homepage":null,"size":1277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5"},"html":{"href":"https://github.com/gnosis/olympia-interface/pull/5"},"issue":{"href":"https://api.github.com/repos/gnosis/olympia-interface/issues/5"},"comments":{"href":"https://api.github.com/repos/gnosis/olympia-interface/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/gnosis/olympia-interface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnosis/olympia-interface/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/gnosis/olympia-interface/statuses/f46b4b995d5d690d7b502aa2c65c2db6bf9d247e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cag"}}