{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/50291","repository_url":"https://api.github.com/repos/brianchandotcom/liferay-portal","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/50291/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/50291/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/50291/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/50291","id":242776715,"number":50291,"title":"LPS-72919","user":{"login":"bawachhe","id":2798161,"avatar_url":"https://avatars0.githubusercontent.com/u/2798161?v=4","gravatar_id":"","url":"https://api.github.com/users/bawachhe","html_url":"https://github.com/bawachhe","followers_url":"https://api.github.com/users/bawachhe/followers","following_url":"https://api.github.com/users/bawachhe/following{/other_user}","gists_url":"https://api.github.com/users/bawachhe/gists{/gist_id}","starred_url":"https://api.github.com/users/bawachhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bawachhe/subscriptions","organizations_url":"https://api.github.com/users/bawachhe/orgs","repos_url":"https://api.github.com/users/bawachhe/repos","events_url":"https://api.github.com/users/bawachhe/events{/privacy}","received_events_url":"https://api.github.com/users/bawachhe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-13T17:36:35Z","updated_at":"2017-07-17T21:30:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/50291","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/50291","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/50291.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/50291.patch"},"body":"https://issues.liferay.com/browse/LPS-72919\r\n\r\nRe: https://github.com/brianchandotcom/liferay-portal/pull/50107#issuecomment-313229686\r\nChanged `deploy-excludes` for tasks-portlet to make it consistent like you asked; tasks-portlet was actually supposed to have `deploy-excludes` as well.\r\nAutomating it probably requires that the `BaseDeployer` or `PluginsEnvironmentBuilder` or something like that knows about what plugins are in the war, and what portal has available.  `BaseDeployer` handles the `deploy-excludes` `liferay-plugin-package.properties` line, and so with all exclusions; `PluginsEnvironmentBuilder` is the one that reads the `ivy.xml` file, which maybe could be used as our clue as to what jars to auto-exclude.\r\nBut so far, it seems like neither is aware of what portal has available, so that doesn't seem like a straightforward task.\r\n\r\nI'm also digging around in portal's `build*.xml` and `*.gradle` files a little more to see if I can figure something out, before I defer to Hugo about fixing SF inconsistencies.\r\nEdit: actually I think he might have sorted out the main inconsistency here: https://github.com/liferay/liferay-portal/commit/2e8c89364facbe52026d1ce7295dd94dd75fc2f6"},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/315890741","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/50291#issuecomment-315890741","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/50291","id":315890741,"user":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars2.githubusercontent.com/u/282080?v=4","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T21:30:06Z","updated_at":"2017-07-17T21:30:06Z","body":"Merged. Thank you.\nView total diff: https://github.com/brianchandotcom/liferay-portal/compare/0510ca11ad...5514a4ca1e"}}
{"actor":{"display_login":"brianchandotcom"}}