{"action":"opened","number":1643,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1643","id":103423574,"html_url":"https://github.com/greenplum-db/gpdb/pull/1643","diff_url":"https://github.com/greenplum-db/gpdb/pull/1643.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1643.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1643","number":1643,"state":"open","locked":false,"title":"Cleanup comments for `remove_dbtablespaces()`","user":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars.githubusercontent.com/u/723898?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"body":"In Postgres, `remove_dbtablespaces()` are used for both `createdb()` failure, and\r\n`dropdb()` commit.\r\n\r\nIn GPDB, persistent tables are used to track the state of the objects, like\r\ntable space, database files, etc., and properly clean them up at the end of\r\ntransaction (either commit or abort). That's handled by `AtEOXact_smgr()`.\r\n\r\nWe can safely delete `remove_dbtablespaces()` function. We put the deadcode\r\nunder `#if 0` to make future merge easier.\r\n\r\nSigned-off-by: Xin Zhang <xzhang@pivotal.io>","created_at":"2017-01-27T01:16:28Z","updated_at":"2017-01-27T01:16:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1643/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1643/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1643/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/4f56157b6711bc29a89fe554cbeba41844d45aff","head":{"label":"xinzweb:137737543_remove_dbtablespaces","ref":"137737543_remove_dbtablespaces","sha":"4f56157b6711bc29a89fe554cbeba41844d45aff","user":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars.githubusercontent.com/u/723898?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"repo":{"id":45497539,"name":"gpdb","full_name":"xinzweb/gpdb","owner":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars.githubusercontent.com/u/723898?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xinzweb/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/xinzweb/gpdb","forks_url":"https://api.github.com/repos/xinzweb/gpdb/forks","keys_url":"https://api.github.com/repos/xinzweb/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xinzweb/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xinzweb/gpdb/teams","hooks_url":"https://api.github.com/repos/xinzweb/gpdb/hooks","issue_events_url":"https://api.github.com/repos/xinzweb/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/xinzweb/gpdb/events","assignees_url":"https://api.github.com/repos/xinzweb/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/xinzweb/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/xinzweb/gpdb/tags","blobs_url":"https://api.github.com/repos/xinzweb/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xinzweb/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xinzweb/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/xinzweb/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xinzweb/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/xinzweb/gpdb/languages","stargazers_url":"https://api.github.com/repos/xinzweb/gpdb/stargazers","contributors_url":"https://api.github.com/repos/xinzweb/gpdb/contributors","subscribers_url":"https://api.github.com/repos/xinzweb/gpdb/subscribers","subscription_url":"https://api.github.com/repos/xinzweb/gpdb/subscription","commits_url":"https://api.github.com/repos/xinzweb/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/xinzweb/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/xinzweb/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/xinzweb/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/xinzweb/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/xinzweb/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xinzweb/gpdb/merges","archive_url":"https://api.github.com/repos/xinzweb/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xinzweb/gpdb/downloads","issues_url":"https://api.github.com/repos/xinzweb/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/xinzweb/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/xinzweb/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/xinzweb/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xinzweb/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/xinzweb/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/xinzweb/gpdb/deployments","created_at":"2015-11-03T21:41:51Z","updated_at":"2017-01-25T01:33:25Z","pushed_at":"2017-01-27T01:15:02Z","git_url":"git://github.com/xinzweb/gpdb.git","ssh_url":"git@github.com:xinzweb/gpdb.git","clone_url":"https://github.com/xinzweb/gpdb.git","svn_url":"https://github.com/xinzweb/gpdb","homepage":"http://greenplum.org","size":204785,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"3e1fae2cf2940e1369ef7433214ae15fae5a01e7","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2017-01-26T20:46:38Z","pushed_at":"2017-01-27T01:09:59Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":204173,"stargazers_count":1779,"watchers_count":1779,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":534,"mirror_url":null,"open_issues_count":113,"forks":534,"open_issues":113,"watchers":1779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1643"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1643"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1643"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1643/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1643/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1643/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/4f56157b6711bc29a89fe554cbeba41844d45aff"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"xinzweb"}}