{"action":"created","issue":{"url":"https://api.github.com/repos/vector-im/riot-web/issues/5616","repository_url":"https://api.github.com/repos/vector-im/riot-web","labels_url":"https://api.github.com/repos/vector-im/riot-web/issues/5616/labels{/name}","comments_url":"https://api.github.com/repos/vector-im/riot-web/issues/5616/comments","events_url":"https://api.github.com/repos/vector-im/riot-web/issues/5616/events","html_url":"https://github.com/vector-im/riot-web/pull/5616","id":274473737,"number":5616,"title":"Upgrade to webpack 3 and add webpack-dashboard.","user":{"login":"rxl881","id":6763606,"avatar_url":"https://avatars2.githubusercontent.com/u/6763606?v=4","gravatar_id":"","url":"https://api.github.com/users/rxl881","html_url":"https://github.com/rxl881","followers_url":"https://api.github.com/users/rxl881/followers","following_url":"https://api.github.com/users/rxl881/following{/other_user}","gists_url":"https://api.github.com/users/rxl881/gists{/gist_id}","starred_url":"https://api.github.com/users/rxl881/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxl881/subscriptions","organizations_url":"https://api.github.com/users/rxl881/orgs","repos_url":"https://api.github.com/users/rxl881/repos","events_url":"https://api.github.com/users/rxl881/events{/privacy}","received_events_url":"https://api.github.com/users/rxl881/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ara4n","id":1294269,"avatar_url":"https://avatars2.githubusercontent.com/u/1294269?v=4","gravatar_id":"","url":"https://api.github.com/users/ara4n","html_url":"https://github.com/ara4n","followers_url":"https://api.github.com/users/ara4n/followers","following_url":"https://api.github.com/users/ara4n/following{/other_user}","gists_url":"https://api.github.com/users/ara4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ara4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ara4n/subscriptions","organizations_url":"https://api.github.com/users/ara4n/orgs","repos_url":"https://api.github.com/users/ara4n/repos","events_url":"https://api.github.com/users/ara4n/events{/privacy}","received_events_url":"https://api.github.com/users/ara4n/received_events","type":"User","site_admin":false},"assignees":[{"login":"ara4n","id":1294269,"avatar_url":"https://avatars2.githubusercontent.com/u/1294269?v=4","gravatar_id":"","url":"https://api.github.com/users/ara4n","html_url":"https://github.com/ara4n","followers_url":"https://api.github.com/users/ara4n/followers","following_url":"https://api.github.com/users/ara4n/following{/other_user}","gists_url":"https://api.github.com/users/ara4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ara4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ara4n/subscriptions","organizations_url":"https://api.github.com/users/ara4n/orgs","repos_url":"https://api.github.com/users/ara4n/repos","events_url":"https://api.github.com/users/ara4n/events{/privacy}","received_events_url":"https://api.github.com/users/ara4n/received_events","type":"User","site_admin":false},{"login":"rxl881","id":6763606,"avatar_url":"https://avatars2.githubusercontent.com/u/6763606?v=4","gravatar_id":"","url":"https://api.github.com/users/rxl881","html_url":"https://github.com/rxl881","followers_url":"https://api.github.com/users/rxl881/followers","following_url":"https://api.github.com/users/rxl881/following{/other_user}","gists_url":"https://api.github.com/users/rxl881/gists{/gist_id}","starred_url":"https://api.github.com/users/rxl881/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxl881/subscriptions","organizations_url":"https://api.github.com/users/rxl881/orgs","repos_url":"https://api.github.com/users/rxl881/repos","events_url":"https://api.github.com/users/rxl881/events{/privacy}","received_events_url":"https://api.github.com/users/rxl881/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-11-16T10:55:21Z","updated_at":"2017-11-21T17:13:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vector-im/riot-web/pulls/5616","html_url":"https://github.com/vector-im/riot-web/pull/5616","diff_url":"https://github.com/vector-im/riot-web/pull/5616.diff","patch_url":"https://github.com/vector-im/riot-web/pull/5616.patch"},"body":"... I was getting annoyed with the ancient version of webpack 1 that we are currently using, especially the interminable \"optimising asset chunks\", and wondered if we could either speed things up or get a better insight in to what webpack is doing by upgrading to a more recent version and some webpack bundle analysis tools.\r\n\r\nIn this PR I have upgraded webpack from \"^1.12.14\" to latest stable (\"^3.8.1\").\r\n\r\nI have also added support for webpack-dashboard (https://github.com/FormidableLabs/webpack-dashboard), which appears to give some reasonable insight in to the webpack build process, bundle size and any potential problems.\r\n\r\nBy default the PR does not introduce any changes to the build / run process. However, if desired, you can run in dashboard mode with \"npm/yarn run dashboard\".\r\n\r\nAs this is a fairly major increase in webpack versions / dependencies, it probably needs some fairly rigorous testing by other devs. before choosing if we want to merge it to /develop. @dbkr, @ara4n, can you have a quick play when you have a sec.? Thanks.\r\n\r\nSome screenshots of webpack-dashboard running riot-web:\r\n\r\n<img width=\"1639\" alt=\"screen shot 2017-11-16 at 10 18 58\" src=\"https://user-images.githubusercontent.com/6763606/32887628-741b9736-cabc-11e7-9501-d8014429637a.png\">\r\n<img width=\"1640\" alt=\"screen shot 2017-11-16 at 10 19 29\" src=\"https://user-images.githubusercontent.com/6763606/32887632-7a8fa2e2-cabc-11e7-8830-bd1d2dac755b.png\">\r\n<img width=\"1637\" alt=\"screen shot 2017-11-16 at 10 21 15\" src=\"https://user-images.githubusercontent.com/6763606/32887641-8124218c-cabc-11e7-8f57-9127ff59fcf5.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/vector-im/riot-web/issues/comments/346096046","html_url":"https://github.com/vector-im/riot-web/pull/5616#issuecomment-346096046","issue_url":"https://api.github.com/repos/vector-im/riot-web/issues/5616","id":346096046,"user":{"login":"rxl881","id":6763606,"avatar_url":"https://avatars2.githubusercontent.com/u/6763606?v=4","gravatar_id":"","url":"https://api.github.com/users/rxl881","html_url":"https://github.com/rxl881","followers_url":"https://api.github.com/users/rxl881/followers","following_url":"https://api.github.com/users/rxl881/following{/other_user}","gists_url":"https://api.github.com/users/rxl881/gists{/gist_id}","starred_url":"https://api.github.com/users/rxl881/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxl881/subscriptions","organizations_url":"https://api.github.com/users/rxl881/orgs","repos_url":"https://api.github.com/users/rxl881/repos","events_url":"https://api.github.com/users/rxl881/events{/privacy}","received_events_url":"https://api.github.com/users/rxl881/received_events","type":"User","site_admin":false},"created_at":"2017-11-21T17:13:06Z","updated_at":"2017-11-21T17:13:06Z","author_association":"CONTRIBUTOR","body":"Thanks @MTRNord - I tried re-running the tests on against your PR a couple of times to see if I could get them to fail ... they didn't! Weird, as I really can't see the obvious difference."}}
{"actor":{"display_login":"rxl881"}}