{"action":"created","issue":{"url":"https://api.github.com/repos/mickmcc/node-caltime/issues/3","repository_url":"https://api.github.com/repos/mickmcc/node-caltime","labels_url":"https://api.github.com/repos/mickmcc/node-caltime/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/mickmcc/node-caltime/issues/3/comments","events_url":"https://api.github.com/repos/mickmcc/node-caltime/issues/3/events","html_url":"https://github.com/mickmcc/node-caltime/issues/3","id":283564591,"number":3,"title":"TimeRule#generateDateSpans() incorrectly handles seconds and milliseconds","user":{"login":"mickmcc","id":26903053,"avatar_url":"https://avatars2.githubusercontent.com/u/26903053?v=4","gravatar_id":"","url":"https://api.github.com/users/mickmcc","html_url":"https://github.com/mickmcc","followers_url":"https://api.github.com/users/mickmcc/followers","following_url":"https://api.github.com/users/mickmcc/following{/other_user}","gists_url":"https://api.github.com/users/mickmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/mickmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickmcc/subscriptions","organizations_url":"https://api.github.com/users/mickmcc/orgs","repos_url":"https://api.github.com/users/mickmcc/repos","events_url":"https://api.github.com/users/mickmcc/events{/privacy}","received_events_url":"https://api.github.com/users/mickmcc/received_events","type":"User","site_admin":false},"labels":[{"id":746455748,"url":"https://api.github.com/repos/mickmcc/node-caltime/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"mickmcc","id":26903053,"avatar_url":"https://avatars2.githubusercontent.com/u/26903053?v=4","gravatar_id":"","url":"https://api.github.com/users/mickmcc","html_url":"https://github.com/mickmcc","followers_url":"https://api.github.com/users/mickmcc/followers","following_url":"https://api.github.com/users/mickmcc/following{/other_user}","gists_url":"https://api.github.com/users/mickmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/mickmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickmcc/subscriptions","organizations_url":"https://api.github.com/users/mickmcc/orgs","repos_url":"https://api.github.com/users/mickmcc/repos","events_url":"https://api.github.com/users/mickmcc/events{/privacy}","received_events_url":"https://api.github.com/users/mickmcc/received_events","type":"User","site_admin":false},"assignees":[{"login":"mickmcc","id":26903053,"avatar_url":"https://avatars2.githubusercontent.com/u/26903053?v=4","gravatar_id":"","url":"https://api.github.com/users/mickmcc","html_url":"https://github.com/mickmcc","followers_url":"https://api.github.com/users/mickmcc/followers","following_url":"https://api.github.com/users/mickmcc/following{/other_user}","gists_url":"https://api.github.com/users/mickmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/mickmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickmcc/subscriptions","organizations_url":"https://api.github.com/users/mickmcc/orgs","repos_url":"https://api.github.com/users/mickmcc/repos","events_url":"https://api.github.com/users/mickmcc/events{/privacy}","received_events_url":"https://api.github.com/users/mickmcc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-12-20T13:36:05Z","updated_at":"2017-12-20T15:39:16Z","closed_at":null,"author_association":"OWNER","body":"### Observed Behaviour\r\n\r\nWhen the defined TimeSpan of a TimeRule contains a seconds and/or milliseconds component, we expect the generated DateSpan objects to have this seconds/milliseconds component.  A new unit test which was added for TimeRule discovered that the seconds/milliseconds components are not respected by the generateDateSpans() function.\r\n\r\nExample:\r\nTimeSpan passed to TimeRule constructor is [9:00:00:000 - 10:00:04:200]\r\nTimeSpan has components of 4 seconds and 200 milliseconds.\r\nGenerated DateSpan is [9:00:00:000 - 10:00:00:000]\r\n\r\n### Expected Behaviour\r\n\r\nGenerated DateSpan must include the seconds and milliseconds components of the TimeSpan.\r\n\r\nExample:\r\nGenerated DateSpan should be [9:00:00:000 - 10:00:04:200].\r\n\r\n### Steps to Reproduce\r\n\r\nCreate a unit test case with a TimeSpan which has seconds and milliseconds.\r\n\r\n### System Configuration\r\n\r\ncaltime version: 1.4.0\r\nNode.js version: v8.9.1\r\nNPM version: 5.6.0\r\nlodash version: 4.17.4\r\nmoment-timezone version:  0.5.14"},"comment":{"url":"https://api.github.com/repos/mickmcc/node-caltime/issues/comments/353097050","html_url":"https://github.com/mickmcc/node-caltime/issues/3#issuecomment-353097050","issue_url":"https://api.github.com/repos/mickmcc/node-caltime/issues/3","id":353097050,"user":{"login":"mickmcc","id":26903053,"avatar_url":"https://avatars2.githubusercontent.com/u/26903053?v=4","gravatar_id":"","url":"https://api.github.com/users/mickmcc","html_url":"https://github.com/mickmcc","followers_url":"https://api.github.com/users/mickmcc/followers","following_url":"https://api.github.com/users/mickmcc/following{/other_user}","gists_url":"https://api.github.com/users/mickmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/mickmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickmcc/subscriptions","organizations_url":"https://api.github.com/users/mickmcc/orgs","repos_url":"https://api.github.com/users/mickmcc/repos","events_url":"https://api.github.com/users/mickmcc/events{/privacy}","received_events_url":"https://api.github.com/users/mickmcc/received_events","type":"User","site_admin":false},"created_at":"2017-12-20T15:39:16Z","updated_at":"2017-12-20T15:39:16Z","author_association":"OWNER","body":"Problem found in the functional constructor of the `DateSpan` object.  The Minutes, Seconds and Milliseconds components of the duration were not set correctly when the End Date was passed to the function.\r\nFixed in commit 87bd255c9c8665e49f703b5405e33f18f0c3f762 and published to NPM in v1.4.1 of `caltime`."}}
{"actor":{"display_login":"mickmcc"}}