{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/comments/152198919","pull_request_review_id":78022487,"id":152198919,"diff_hunk":"@@ -87,7 +103,7 @@ The used method has the following API:\n \n .. code:: python\n \n-   add_interface(config, interface_name=\"desktop\", interface_type=INTERFACE_TYPE_NGEO, **kwargs)\n+   add_interface(config, interface_name=\"<interface>\", interface_type=<INTERFACE_TYPE_NGEO>, **kwargs)","path":"doc/integrator/ngeo_new_interface.rst","position":72,"original_position":72,"commit_id":"78a1b32a37c837b306223ac4c2c0638ac7fe3655","original_commit_id":"78a1b32a37c837b306223ac4c2c0638ac7fe3655","user":{"login":"sbrunner","id":353872,"avatar_url":"https://avatars3.githubusercontent.com/u/353872?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrunner","html_url":"https://github.com/sbrunner","followers_url":"https://api.github.com/users/sbrunner/followers","following_url":"https://api.github.com/users/sbrunner/following{/other_user}","gists_url":"https://api.github.com/users/sbrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrunner/subscriptions","organizations_url":"https://api.github.com/users/sbrunner/orgs","repos_url":"https://api.github.com/users/sbrunner/repos","events_url":"https://api.github.com/users/sbrunner/events{/privacy}","received_events_url":"https://api.github.com/users/sbrunner/received_events","type":"User","site_admin":false},"body":"why `<>` around `INTERFACE_TYPE_NGEO`?","created_at":"2017-11-21T07:56:01Z","updated_at":"2017-11-21T08:00:34Z","html_url":"https://github.com/camptocamp/c2cgeoportal/pull/3275#discussion_r152198919","pull_request_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/comments/152198919"},"html":{"href":"https://github.com/camptocamp/c2cgeoportal/pull/3275#discussion_r152198919"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275","id":153669159,"html_url":"https://github.com/camptocamp/c2cgeoportal/pull/3275","diff_url":"https://github.com/camptocamp/c2cgeoportal/pull/3275.diff","patch_url":"https://github.com/camptocamp/c2cgeoportal/pull/3275.patch","issue_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/3275","number":3275,"state":"open","locked":false,"title":"[doc] improve description of how to add new interface","user":{"login":"jwkaltz","id":9261252,"avatar_url":"https://avatars1.githubusercontent.com/u/9261252?v=4","gravatar_id":"","url":"https://api.github.com/users/jwkaltz","html_url":"https://github.com/jwkaltz","followers_url":"https://api.github.com/users/jwkaltz/followers","following_url":"https://api.github.com/users/jwkaltz/following{/other_user}","gists_url":"https://api.github.com/users/jwkaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/jwkaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwkaltz/subscriptions","organizations_url":"https://api.github.com/users/jwkaltz/orgs","repos_url":"https://api.github.com/users/jwkaltz/repos","events_url":"https://api.github.com/users/jwkaltz/events{/privacy}","received_events_url":"https://api.github.com/users/jwkaltz/received_events","type":"User","site_admin":false},"body":"Corrections as found by @marionb when doing https://jira.camptocamp.com/browse/GSSZ2-4","created_at":"2017-11-20T16:07:59Z","updated_at":"2017-11-21T08:00:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfaeec68b6714d6153e91e7804af6642b77c3a6c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marionb","id":1460598,"avatar_url":"https://avatars1.githubusercontent.com/u/1460598?v=4","gravatar_id":"","url":"https://api.github.com/users/marionb","html_url":"https://github.com/marionb","followers_url":"https://api.github.com/users/marionb/followers","following_url":"https://api.github.com/users/marionb/following{/other_user}","gists_url":"https://api.github.com/users/marionb/gists{/gist_id}","starred_url":"https://api.github.com/users/marionb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionb/subscriptions","organizations_url":"https://api.github.com/users/marionb/orgs","repos_url":"https://api.github.com/users/marionb/repos","events_url":"https://api.github.com/users/marionb/events{/privacy}","received_events_url":"https://api.github.com/users/marionb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275/commits","review_comments_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275/comments","review_comment_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/3275/comments","statuses_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/statuses/78a1b32a37c837b306223ac4c2c0638ac7fe3655","head":{"label":"camptocamp:doc_improve_add_new_interface","ref":"doc_improve_add_new_interface","sha":"78a1b32a37c837b306223ac4c2c0638ac7fe3655","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars0.githubusercontent.com/u/28109?v=4","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":2932773,"name":"c2cgeoportal","full_name":"camptocamp/c2cgeoportal","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars0.githubusercontent.com/u/28109?v=4","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/c2cgeoportal","description":"c2cgeoportal application","fork":false,"url":"https://api.github.com/repos/camptocamp/c2cgeoportal","forks_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/forks","keys_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/teams","hooks_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/events","assignees_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/tags","blobs_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/languages","stargazers_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/subscription","commits_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/merges","archive_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/downloads","issues_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/releases{/id}","deployments_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/deployments","created_at":"2011-12-07T13:42:59Z","updated_at":"2017-11-16T12:43:15Z","pushed_at":"2017-11-21T07:48:19Z","git_url":"git://github.com/camptocamp/c2cgeoportal.git","ssh_url":"git@github.com:camptocamp/c2cgeoportal.git","clone_url":"https://github.com/camptocamp/c2cgeoportal.git","svn_url":"https://github.com/camptocamp/c2cgeoportal","homepage":"http://geomapfish.org","size":368464,"stargazers_count":32,"watchers_count":32,"language":"PLpgSQL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":73,"forks":34,"open_issues":73,"watchers":32,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"13a42b20cc78e2a3be9772280a6816f6b3462e1c","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars0.githubusercontent.com/u/28109?v=4","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":2932773,"name":"c2cgeoportal","full_name":"camptocamp/c2cgeoportal","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars0.githubusercontent.com/u/28109?v=4","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/c2cgeoportal","description":"c2cgeoportal application","fork":false,"url":"https://api.github.com/repos/camptocamp/c2cgeoportal","forks_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/forks","keys_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/teams","hooks_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/events","assignees_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/tags","blobs_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/languages","stargazers_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/subscription","commits_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/merges","archive_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/downloads","issues_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/releases{/id}","deployments_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/deployments","created_at":"2011-12-07T13:42:59Z","updated_at":"2017-11-16T12:43:15Z","pushed_at":"2017-11-21T07:48:19Z","git_url":"git://github.com/camptocamp/c2cgeoportal.git","ssh_url":"git@github.com:camptocamp/c2cgeoportal.git","clone_url":"https://github.com/camptocamp/c2cgeoportal.git","svn_url":"https://github.com/camptocamp/c2cgeoportal","homepage":"http://geomapfish.org","size":368464,"stargazers_count":32,"watchers_count":32,"language":"PLpgSQL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":73,"forks":34,"open_issues":73,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275"},"html":{"href":"https://github.com/camptocamp/c2cgeoportal/pull/3275"},"issue":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/3275"},"comments":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/issues/3275/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/3275/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/statuses/78a1b32a37c837b306223ac4c2c0638ac7fe3655"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sbrunner"}}