{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/20242","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/20242/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20242/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/20242/events","html_url":"https://github.com/symfony/symfony/pull/20242","id":183894558,"number":20242,"title":"[Form] [Extension] [FormTypeCsrfExtension] Make the csrf field options extensible","user":{"login":"esserj","id":1032205,"avatar_url":"https://avatars1.githubusercontent.com/u/1032205?v=3","gravatar_id":"","url":"https://api.github.com/users/esserj","html_url":"https://github.com/esserj","followers_url":"https://api.github.com/users/esserj/followers","following_url":"https://api.github.com/users/esserj/following{/other_user}","gists_url":"https://api.github.com/users/esserj/gists{/gist_id}","starred_url":"https://api.github.com/users/esserj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esserj/subscriptions","organizations_url":"https://api.github.com/users/esserj/orgs","repos_url":"https://api.github.com/users/esserj/repos","events_url":"https://api.github.com/users/esserj/events{/privacy}","received_events_url":"https://api.github.com/users/esserj/received_events","type":"User","site_admin":false},"labels":[{"id":100378,"url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.x","description":"New features and deprecations go here. Since Symfony versions are time based, this milestone has no due date.","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars0.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":118,"closed_issues":125,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2017-03-04T19:13:11Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2016-10-19T08:14:18Z","updated_at":"2017-03-05T14:17:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20242","html_url":"https://github.com/symfony/symfony/pull/20242","diff_url":"https://github.com/symfony/symfony/pull/20242.diff","patch_url":"https://github.com/symfony/symfony/pull/20242.patch"},"body":"| Q | A |\r\n| --- | --- |\r\n| Branch? | \"master\" |\r\n| Bug fix? | no |\r\n| New feature? | yes |\r\n| BC breaks? | no |\r\n| Deprecations? | no |\r\n| Tests pass? | yes |\r\n| Fixed tickets | none |\r\n| License | MIT |\r\n| Doc PR | none |\r\n\r\nIf you wana decorate the FormTypeCsrfExtension you have no control over options set by the extension, forcing you to reimplement the entire finishView. this way you have a bit more control over it. We required this approach to define custom options declared by another extension\r\n"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/284230764","html_url":"https://github.com/symfony/symfony/pull/20242#issuecomment-284230764","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20242","id":284230764,"user":{"login":"HeahDude","id":10107633,"avatar_url":"https://avatars3.githubusercontent.com/u/10107633?v=3","gravatar_id":"","url":"https://api.github.com/users/HeahDude","html_url":"https://github.com/HeahDude","followers_url":"https://api.github.com/users/HeahDude/followers","following_url":"https://api.github.com/users/HeahDude/following{/other_user}","gists_url":"https://api.github.com/users/HeahDude/gists{/gist_id}","starred_url":"https://api.github.com/users/HeahDude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeahDude/subscriptions","organizations_url":"https://api.github.com/users/HeahDude/orgs","repos_url":"https://api.github.com/users/HeahDude/repos","events_url":"https://api.github.com/users/HeahDude/events{/privacy}","received_events_url":"https://api.github.com/users/HeahDude/received_events","type":"User","site_admin":false},"created_at":"2017-03-05T14:17:36Z","updated_at":"2017-03-05T14:17:36Z","body":"Hi @esserj,  thank you for proposing this change, but the use case it supported can already be solved.\r\n\r\n>If you wana decorate the FormTypeCsrfExtension you have no control over options set by the extension,\r\n\r\nSince 3.2 it is possible to handle priorities on form type extension when registering them as services, this feature has been added so it can be easier to rely on other extensions definitions.\r\n\r\nHence I don't think we need to add yet another option to handle this, you could easily override options from another type extension now. Using the Form component stand alone should already provide full control on the registration order of different type extensions.\r\n\r\nIf there is no other concrete use cases, I'm 👎 for now."}}
{"actor":{"display_login":"HeahDude"}}