{"action":"created","comment":{"url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/comments/121071496","pull_request_review_id":42832549,"id":121071496,"diff_hunk":"@@ -0,0 +1,100 @@\n+/* -*- mode: C++; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */\n+// vim:sts=4:sw=4:ts=4:noet:sr:cino=>s,f0,{0,g0,(0,\\:0,t0,+0,=s\n+\n+\n+/* Copyright (c) FFLAS-FFPACK\n+ * Written by Clément Pernet <clement.pernet@imag.fr>\n+ * ========LICENCE========\n+ * This file is part of the library FFLAS-FFPACK.\n+ *\n+ * FFLAS-FFPACK is free software: you can redistribute it and/or modify\n+ * it under the terms of the  GNU Lesser General Public\n+ * License as published by the Free Software Foundation; either\n+ * version 2.1 of the License, or (at your option) any later version.\n+ *\n+ * This library is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this library; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA\n+ * ========LICENCE========\n+ */\n+\n+#include \"fflas-ffpack/fflas-ffpack-config.h\"\n+#include <iostream>\n+#include <givaro/modular.h>\n+\n+#include \"fflas-ffpack/fflas-ffpack.h\"\n+#include \"fflas-ffpack/utils/timer.h\"\n+#include \"fflas-ffpack/utils/Matio.h\"\n+#include \"fflas-ffpack/utils/args-parser.h\"\n+\n+\n+using namespace std;\n+using namespace FFLAS;\n+using namespace FFPACK;\n+int main(int argc, char** argv) {\n+  \n+  size_t iter      = 3;\n+  int    q         = 131071;\n+  size_t rows      = 1000;\n+  size_t cols      = 1000;\n+  double a         = 1.0;\n+  size_t threshold = 64;\n+  std::string file = \"\";\n+  \n+  Argument as[] = {\n+    { 'q', \"-q Q\", \"Set the field characteristic (-1 for random).\",         TYPE_INT , &q },\n+\t{ 'm', \"-m M\", \"Set the row dimension of the matrix C.\",                TYPE_INT , &rows },\n+\t{ 'n', \"-n N\", \"Set the column dimension of the matrix C.\",             TYPE_INT , &cols },\n+    { 'a', \"-a A\", \"Set the value of the coefficient alpha for alpha * B.\", TYPE_DOUBLE , &a},\n+    { 'i', \"-i R\", \"Set number of repetitions.\",                            TYPE_INT , &iter },\n+    END_OF_ARGUMENTS\n+  };\n+\n+  FFLAS::parseArguments(argc,argv,as);\n+\t\n+  typedef Givaro::ModularBalanced<double> Field;\n+  typedef Field::Element Element;\n+\t\n+  Field F(q);\n+  Field::Element_ptr A, B;\n+  Field::Element_ptr C;\n+  Element alpha;\n+  F.init(alpha, a);\n+\n+\t\n+  FFLAS::Timer chrono;\n+  double time=0.0;\n+\t\n+  for (size_t i=0;i<=iter;++i){\n+\tA = fflas_new(F, rows, cols);\n+    size_t lda = cols;","path":"benchmarks/benchmark-fadd-lvl2.C","position":75,"original_position":75,"commit_id":"a747a44250d3e6540b8ef346b0d72064eeefdf87","original_commit_id":"a747a44250d3e6540b8ef346b0d72064eeefdf87","user":{"login":"ClementPernet","id":10073220,"avatar_url":"https://avatars0.githubusercontent.com/u/10073220?v=3","gravatar_id":"","url":"https://api.github.com/users/ClementPernet","html_url":"https://github.com/ClementPernet","followers_url":"https://api.github.com/users/ClementPernet/followers","following_url":"https://api.github.com/users/ClementPernet/following{/other_user}","gists_url":"https://api.github.com/users/ClementPernet/gists{/gist_id}","starred_url":"https://api.github.com/users/ClementPernet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClementPernet/subscriptions","organizations_url":"https://api.github.com/users/ClementPernet/orgs","repos_url":"https://api.github.com/users/ClementPernet/repos","events_url":"https://api.github.com/users/ClementPernet/events{/privacy}","received_events_url":"https://api.github.com/users/ClementPernet/received_events","type":"User","site_admin":false},"body":"Indentation (4 spaces as the first line after the \"for\")","created_at":"2017-06-09T08:15:52Z","updated_at":"2017-06-09T08:18:30Z","html_url":"https://github.com/linbox-team/fflas-ffpack/pull/104#discussion_r121071496","pull_request_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/comments/121071496"},"html":{"href":"https://github.com/linbox-team/fflas-ffpack/pull/104#discussion_r121071496"},"pull_request":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104","id":124583999,"html_url":"https://github.com/linbox-team/fflas-ffpack/pull/104","diff_url":"https://github.com/linbox-team/fflas-ffpack/pull/104.diff","patch_url":"https://github.com/linbox-team/fflas-ffpack/pull/104.patch","issue_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/104","number":104,"state":"open","locked":false,"title":"New benchmark for fadd lvl2","user":{"login":"ledentp","id":24563831,"avatar_url":"https://avatars2.githubusercontent.com/u/24563831?v=3","gravatar_id":"","url":"https://api.github.com/users/ledentp","html_url":"https://github.com/ledentp","followers_url":"https://api.github.com/users/ledentp/followers","following_url":"https://api.github.com/users/ledentp/following{/other_user}","gists_url":"https://api.github.com/users/ledentp/gists{/gist_id}","starred_url":"https://api.github.com/users/ledentp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledentp/subscriptions","organizations_url":"https://api.github.com/users/ledentp/orgs","repos_url":"https://api.github.com/users/ledentp/repos","events_url":"https://api.github.com/users/ledentp/events{/privacy}","received_events_url":"https://api.github.com/users/ledentp/received_events","type":"User","site_admin":false},"body":"This PR proposes an implementation of a benchmark for the matrix/matrix addition. ","created_at":"2017-06-08T07:28:34Z","updated_at":"2017-06-09T08:18:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6f217bd34f9e2977acc9dbc33c7c1e9effaeceb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104/commits","review_comments_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104/comments","review_comment_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/104/comments","statuses_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/statuses/a747a44250d3e6540b8ef346b0d72064eeefdf87","head":{"label":"linbox-team:benchmark-fadd-lvl2","ref":"benchmark-fadd-lvl2","sha":"a747a44250d3e6540b8ef346b0d72064eeefdf87","user":{"login":"linbox-team","id":13101892,"avatar_url":"https://avatars2.githubusercontent.com/u/13101892?v=3","gravatar_id":"","url":"https://api.github.com/users/linbox-team","html_url":"https://github.com/linbox-team","followers_url":"https://api.github.com/users/linbox-team/followers","following_url":"https://api.github.com/users/linbox-team/following{/other_user}","gists_url":"https://api.github.com/users/linbox-team/gists{/gist_id}","starred_url":"https://api.github.com/users/linbox-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linbox-team/subscriptions","organizations_url":"https://api.github.com/users/linbox-team/orgs","repos_url":"https://api.github.com/users/linbox-team/repos","events_url":"https://api.github.com/users/linbox-team/events{/privacy}","received_events_url":"https://api.github.com/users/linbox-team/received_events","type":"Organization","site_admin":false},"repo":{"id":38369187,"name":"fflas-ffpack","full_name":"linbox-team/fflas-ffpack","owner":{"login":"linbox-team","id":13101892,"avatar_url":"https://avatars2.githubusercontent.com/u/13101892?v=3","gravatar_id":"","url":"https://api.github.com/users/linbox-team","html_url":"https://github.com/linbox-team","followers_url":"https://api.github.com/users/linbox-team/followers","following_url":"https://api.github.com/users/linbox-team/following{/other_user}","gists_url":"https://api.github.com/users/linbox-team/gists{/gist_id}","starred_url":"https://api.github.com/users/linbox-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linbox-team/subscriptions","organizations_url":"https://api.github.com/users/linbox-team/orgs","repos_url":"https://api.github.com/users/linbox-team/repos","events_url":"https://api.github.com/users/linbox-team/events{/privacy}","received_events_url":"https://api.github.com/users/linbox-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linbox-team/fflas-ffpack","description":"FFLAS-FFPACK - Finite Field Linear Algebra Subroutines / Package","fork":false,"url":"https://api.github.com/repos/linbox-team/fflas-ffpack","forks_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/forks","keys_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/teams","hooks_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/hooks","issue_events_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/events{/number}","events_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/events","assignees_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/assignees{/user}","branches_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/branches{/branch}","tags_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/tags","blobs_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/statuses/{sha}","languages_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/languages","stargazers_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/stargazers","contributors_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/contributors","subscribers_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/subscribers","subscription_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/subscription","commits_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/contents/{+path}","compare_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/merges","archive_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/downloads","issues_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues{/number}","pulls_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls{/number}","milestones_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/milestones{/number}","notifications_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/labels{/name}","releases_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/releases{/id}","deployments_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/deployments","created_at":"2015-07-01T12:09:57Z","updated_at":"2017-05-29T08:21:25Z","pushed_at":"2017-06-08T13:07:12Z","git_url":"git://github.com/linbox-team/fflas-ffpack.git","ssh_url":"git@github.com:linbox-team/fflas-ffpack.git","clone_url":"https://github.com/linbox-team/fflas-ffpack.git","svn_url":"https://github.com/linbox-team/fflas-ffpack","homepage":"http://linbox-team.github.io/fflas-ffpack/","size":5815,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":22,"forks":6,"open_issues":22,"watchers":12,"default_branch":"master"}},"base":{"label":"linbox-team:master","ref":"master","sha":"18b36a92767a90e6a0a60629e1287105da02bc38","user":{"login":"linbox-team","id":13101892,"avatar_url":"https://avatars2.githubusercontent.com/u/13101892?v=3","gravatar_id":"","url":"https://api.github.com/users/linbox-team","html_url":"https://github.com/linbox-team","followers_url":"https://api.github.com/users/linbox-team/followers","following_url":"https://api.github.com/users/linbox-team/following{/other_user}","gists_url":"https://api.github.com/users/linbox-team/gists{/gist_id}","starred_url":"https://api.github.com/users/linbox-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linbox-team/subscriptions","organizations_url":"https://api.github.com/users/linbox-team/orgs","repos_url":"https://api.github.com/users/linbox-team/repos","events_url":"https://api.github.com/users/linbox-team/events{/privacy}","received_events_url":"https://api.github.com/users/linbox-team/received_events","type":"Organization","site_admin":false},"repo":{"id":38369187,"name":"fflas-ffpack","full_name":"linbox-team/fflas-ffpack","owner":{"login":"linbox-team","id":13101892,"avatar_url":"https://avatars2.githubusercontent.com/u/13101892?v=3","gravatar_id":"","url":"https://api.github.com/users/linbox-team","html_url":"https://github.com/linbox-team","followers_url":"https://api.github.com/users/linbox-team/followers","following_url":"https://api.github.com/users/linbox-team/following{/other_user}","gists_url":"https://api.github.com/users/linbox-team/gists{/gist_id}","starred_url":"https://api.github.com/users/linbox-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linbox-team/subscriptions","organizations_url":"https://api.github.com/users/linbox-team/orgs","repos_url":"https://api.github.com/users/linbox-team/repos","events_url":"https://api.github.com/users/linbox-team/events{/privacy}","received_events_url":"https://api.github.com/users/linbox-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linbox-team/fflas-ffpack","description":"FFLAS-FFPACK - Finite Field Linear Algebra Subroutines / Package","fork":false,"url":"https://api.github.com/repos/linbox-team/fflas-ffpack","forks_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/forks","keys_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/teams","hooks_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/hooks","issue_events_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/events{/number}","events_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/events","assignees_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/assignees{/user}","branches_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/branches{/branch}","tags_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/tags","blobs_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/statuses/{sha}","languages_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/languages","stargazers_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/stargazers","contributors_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/contributors","subscribers_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/subscribers","subscription_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/subscription","commits_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/contents/{+path}","compare_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/merges","archive_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/downloads","issues_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues{/number}","pulls_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls{/number}","milestones_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/milestones{/number}","notifications_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/labels{/name}","releases_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/releases{/id}","deployments_url":"https://api.github.com/repos/linbox-team/fflas-ffpack/deployments","created_at":"2015-07-01T12:09:57Z","updated_at":"2017-05-29T08:21:25Z","pushed_at":"2017-06-08T13:07:12Z","git_url":"git://github.com/linbox-team/fflas-ffpack.git","ssh_url":"git@github.com:linbox-team/fflas-ffpack.git","clone_url":"https://github.com/linbox-team/fflas-ffpack.git","svn_url":"https://github.com/linbox-team/fflas-ffpack","homepage":"http://linbox-team.github.io/fflas-ffpack/","size":5815,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":22,"forks":6,"open_issues":22,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104"},"html":{"href":"https://github.com/linbox-team/fflas-ffpack/pull/104"},"issue":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/104"},"comments":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/linbox-team/fflas-ffpack/statuses/a747a44250d3e6540b8ef346b0d72064eeefdf87"}}}}
{"actor":{"display_login":"ClementPernet"}}