{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/100817872","pull_request_review_id":21533309,"id":100817872,"diff_hunk":"@@ -1239,28 +1243,26 @@ def _subject_panel_default(self):\n         return SubjectSelectorPanel(model=self.model.mri.subject_source)\n \n     def _fid_panel_default(self):\n-        panel = FiducialsPanel(model=self.model.mri, headview=self.headview)\n-        return panel\n+        return FiducialsPanel(model=self.model.mri, headview=self.headview)\n \n     def _coreg_panel_default(self):\n-        panel = CoregPanel(model=self.model)\n-        return panel\n+        return CoregPanel(model=self.model)\n \n     def _headview_default(self):\n         return HeadViewController(scene=self.scene, system='RAS')\n \n     def __init__(self, raw=None, subject=None, subjects_dir=None,\n                  guess_mri_subject=True, head_opacity=1.,\n-                 head_high_res=True):  # noqa: D102\n+                 head_high_res=True, prepare_bem=True):  # noqa: D102\n         super(CoregFrame, self).__init__(guess_mri_subject=guess_mri_subject)\n         self.subject_panel.model.use_high_res_head = head_high_res\n+        self.model.prepare_bem_model = prepare_bem\n         if not 0 <= head_opacity <= 1:\n             raise ValueError(\n                 \"head_opacity needs to be a floating point number between 0 \"\n                 \"and 1, got %r\" % (head_opacity,))\n         self._initial_head_opacity = head_opacity\n \n-        subjects_dir = get_subjects_dir(subjects_dir)","path":"mne/gui/_coreg_gui.py","position":64,"original_position":64,"commit_id":"391d31349738f4dcf5521d90de8af28456192a47","original_commit_id":"391d31349738f4dcf5521d90de8af28456192a47","user":{"login":"christianbrodbeck","id":145771,"avatar_url":"https://avatars.githubusercontent.com/u/145771?v=3","gravatar_id":"","url":"https://api.github.com/users/christianbrodbeck","html_url":"https://github.com/christianbrodbeck","followers_url":"https://api.github.com/users/christianbrodbeck/followers","following_url":"https://api.github.com/users/christianbrodbeck/following{/other_user}","gists_url":"https://api.github.com/users/christianbrodbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbrodbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbrodbeck/subscriptions","organizations_url":"https://api.github.com/users/christianbrodbeck/orgs","repos_url":"https://api.github.com/users/christianbrodbeck/repos","events_url":"https://api.github.com/users/christianbrodbeck/events{/privacy}","received_events_url":"https://api.github.com/users/christianbrodbeck/received_events","type":"User","site_admin":false},"body":"Yes, through `get_config()` at https://github.com/mne-tools/mne-python/pull/3948/files#diff-90122ae70dd23f9bc9beb448067743f4R111","created_at":"2017-02-13T15:26:15Z","updated_at":"2017-02-13T15:26:15Z","html_url":"https://github.com/mne-tools/mne-python/pull/3948#discussion_r100817872","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/100817872"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3948#discussion_r100817872"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948","id":104010228,"html_url":"https://github.com/mne-tools/mne-python/pull/3948","diff_url":"https://github.com/mne-tools/mne-python/pull/3948.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3948.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3948","number":3948,"state":"open","locked":false,"title":"ENH guis:  store config options","user":{"login":"christianbrodbeck","id":145771,"avatar_url":"https://avatars.githubusercontent.com/u/145771?v=3","gravatar_id":"","url":"https://api.github.com/users/christianbrodbeck","html_url":"https://github.com/christianbrodbeck","followers_url":"https://api.github.com/users/christianbrodbeck/followers","following_url":"https://api.github.com/users/christianbrodbeck/following{/other_user}","gists_url":"https://api.github.com/users/christianbrodbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbrodbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbrodbeck/subscriptions","organizations_url":"https://api.github.com/users/christianbrodbeck/orgs","repos_url":"https://api.github.com/users/christianbrodbeck/repos","events_url":"https://api.github.com/users/christianbrodbeck/events{/privacy}","received_events_url":"https://api.github.com/users/christianbrodbeck/received_events","type":"User","site_admin":false},"body":"@Eric89GXL This uses `get_config` and `set_config` to restore some options across GUI sessions. I can add other options that would be useful. From a cursory search I did not find where to retrieve the view size.\r\n\r\nThis reads and writes the config file multiple times; I assume that's not a huge deal but maybe we could make getting/setting of multiple keys more efficient. Reading with `get_config()` has the disadvantage that environment variables are ignored.","created_at":"2017-01-31T19:53:31Z","updated_at":"2017-02-13T15:26:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2d18e46c1f2ca0d14f0721b6095c9690eb65c12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3948/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/391d31349738f4dcf5521d90de8af28456192a47","head":{"label":"christianbrodbeck:coreg-gui","ref":"coreg-gui","sha":"391d31349738f4dcf5521d90de8af28456192a47","user":{"login":"christianbrodbeck","id":145771,"avatar_url":"https://avatars.githubusercontent.com/u/145771?v=3","gravatar_id":"","url":"https://api.github.com/users/christianbrodbeck","html_url":"https://github.com/christianbrodbeck","followers_url":"https://api.github.com/users/christianbrodbeck/followers","following_url":"https://api.github.com/users/christianbrodbeck/following{/other_user}","gists_url":"https://api.github.com/users/christianbrodbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbrodbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbrodbeck/subscriptions","organizations_url":"https://api.github.com/users/christianbrodbeck/orgs","repos_url":"https://api.github.com/users/christianbrodbeck/repos","events_url":"https://api.github.com/users/christianbrodbeck/events{/privacy}","received_events_url":"https://api.github.com/users/christianbrodbeck/received_events","type":"User","site_admin":false},"repo":{"id":4607869,"name":"mne-python","full_name":"christianbrodbeck/mne-python","owner":{"login":"christianbrodbeck","id":145771,"avatar_url":"https://avatars.githubusercontent.com/u/145771?v=3","gravatar_id":"","url":"https://api.github.com/users/christianbrodbeck","html_url":"https://github.com/christianbrodbeck","followers_url":"https://api.github.com/users/christianbrodbeck/followers","following_url":"https://api.github.com/users/christianbrodbeck/following{/other_user}","gists_url":"https://api.github.com/users/christianbrodbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbrodbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbrodbeck/subscriptions","organizations_url":"https://api.github.com/users/christianbrodbeck/orgs","repos_url":"https://api.github.com/users/christianbrodbeck/repos","events_url":"https://api.github.com/users/christianbrodbeck/events{/privacy}","received_events_url":"https://api.github.com/users/christianbrodbeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christianbrodbeck/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/christianbrodbeck/mne-python","forks_url":"https://api.github.com/repos/christianbrodbeck/mne-python/forks","keys_url":"https://api.github.com/repos/christianbrodbeck/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christianbrodbeck/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christianbrodbeck/mne-python/teams","hooks_url":"https://api.github.com/repos/christianbrodbeck/mne-python/hooks","issue_events_url":"https://api.github.com/repos/christianbrodbeck/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/christianbrodbeck/mne-python/events","assignees_url":"https://api.github.com/repos/christianbrodbeck/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/christianbrodbeck/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/christianbrodbeck/mne-python/tags","blobs_url":"https://api.github.com/repos/christianbrodbeck/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christianbrodbeck/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christianbrodbeck/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/christianbrodbeck/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christianbrodbeck/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/christianbrodbeck/mne-python/languages","stargazers_url":"https://api.github.com/repos/christianbrodbeck/mne-python/stargazers","contributors_url":"https://api.github.com/repos/christianbrodbeck/mne-python/contributors","subscribers_url":"https://api.github.com/repos/christianbrodbeck/mne-python/subscribers","subscription_url":"https://api.github.com/repos/christianbrodbeck/mne-python/subscription","commits_url":"https://api.github.com/repos/christianbrodbeck/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/christianbrodbeck/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/christianbrodbeck/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/christianbrodbeck/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/christianbrodbeck/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/christianbrodbeck/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christianbrodbeck/mne-python/merges","archive_url":"https://api.github.com/repos/christianbrodbeck/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christianbrodbeck/mne-python/downloads","issues_url":"https://api.github.com/repos/christianbrodbeck/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/christianbrodbeck/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/christianbrodbeck/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/christianbrodbeck/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christianbrodbeck/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/christianbrodbeck/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/christianbrodbeck/mne-python/deployments","created_at":"2012-06-09T14:36:03Z","updated_at":"2015-11-09T23:21:26Z","pushed_at":"2017-02-12T23:22:19Z","git_url":"git://github.com/christianbrodbeck/mne-python.git","ssh_url":"git@github.com:christianbrodbeck/mne-python.git","clone_url":"https://github.com/christianbrodbeck/mne-python.git","svn_url":"https://github.com/christianbrodbeck/mne-python","homepage":"http://martinos.org/mne/","size":91804,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"bba62a5e3b2d71ef0027e91fe1ba9530cc653e27","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2017-02-11T05:47:00Z","pushed_at":"2017-02-13T15:02:04Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":91439,"stargazers_count":272,"watchers_count":272,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":236,"forks":239,"open_issues":236,"watchers":272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3948"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3948"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3948/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3948/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/391d31349738f4dcf5521d90de8af28456192a47"}}}}
{"actor":{"display_login":"christianbrodbeck"}}