{"action":"created","comment":{"url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/comments/146929513","pull_request_review_id":71946393,"id":146929513,"diff_hunk":"@@ -201,10 +201,10 @@ class OLEDDisplay : public Print {\n     void normalDisplay(void);\n \n     // Set display contrast\n-    void setContrast(char contrast);\n+\tvoid setContrast(char contrast, char precharge = 241, char comdetect = 64);\n \n     // Turn the display upside down\n-    void flipScreenVertically();\n+    void flipScreenVertically(bool mirror = false, bool turn = false);\n \n     // Write the buffer to the display memory\n     virtual void display(void) = 0;","path":"OLEDDisplay.h","position":12,"original_position":12,"commit_id":"2aefeb96c74afac0bc98b9712ad053d930b97418","original_commit_id":"2aefeb96c74afac0bc98b9712ad053d930b97418","user":{"login":"reivaxy","id":3592991,"avatar_url":"https://avatars3.githubusercontent.com/u/3592991?v=4","gravatar_id":"","url":"https://api.github.com/users/reivaxy","html_url":"https://github.com/reivaxy","followers_url":"https://api.github.com/users/reivaxy/followers","following_url":"https://api.github.com/users/reivaxy/following{/other_user}","gists_url":"https://api.github.com/users/reivaxy/gists{/gist_id}","starred_url":"https://api.github.com/users/reivaxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reivaxy/subscriptions","organizations_url":"https://api.github.com/users/reivaxy/orgs","repos_url":"https://api.github.com/users/reivaxy/repos","events_url":"https://api.github.com/users/reivaxy/events{/privacy}","received_events_url":"https://api.github.com/users/reivaxy/received_events","type":"User","site_admin":false},"body":"Hi and thanks @lorol \r\n\r\nI'd rather have a PR only for the glyphEditor.html file changes, can you do that ?\r\n\r\nAlso, do you know why the full file glyphEditor.html looks new here, there is no diff with mine ?  I'm somewhat puzzled...","created_at":"2017-10-25T17:29:59Z","updated_at":"2017-10-25T17:29:59Z","html_url":"https://github.com/reivaxy/esp8266-oled-ssd1306/pull/2#discussion_r146929513","pull_request_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/comments/146929513"},"html":{"href":"https://github.com/reivaxy/esp8266-oled-ssd1306/pull/2#discussion_r146929513"},"pull_request":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2","id":148652328,"html_url":"https://github.com/reivaxy/esp8266-oled-ssd1306/pull/2","diff_url":"https://github.com/reivaxy/esp8266-oled-ssd1306/pull/2.diff","patch_url":"https://github.com/reivaxy/esp8266-oled-ssd1306/pull/2.patch","issue_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/issues/2","number":2,"state":"open","locked":false,"title":"Added SSD1305. Interested to work on reviaxy's glyphEditor.","user":{"login":"lorol","id":4274080,"avatar_url":"https://avatars2.githubusercontent.com/u/4274080?v=4","gravatar_id":"","url":"https://api.github.com/users/lorol","html_url":"https://github.com/lorol","followers_url":"https://api.github.com/users/lorol/followers","following_url":"https://api.github.com/users/lorol/following{/other_user}","gists_url":"https://api.github.com/users/lorol/gists{/gist_id}","starred_url":"https://api.github.com/users/lorol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorol/subscriptions","organizations_url":"https://api.github.com/users/lorol/orgs","repos_url":"https://api.github.com/users/lorol/repos","events_url":"https://api.github.com/users/lorol/events{/privacy}","received_events_url":"https://api.github.com/users/lorol/received_events","type":"User","site_admin":false},"body":"Adapted for (an obsolete) SSD1305 2.7 inch 128x64 SPI Graphic OLED module CFAL12864xx-x of Crystalfontz by extended with optional parameters mirroring and contrast functions.","created_at":"2017-10-25T12:24:58Z","updated_at":"2017-10-25T17:29:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5eadf4c8db8072e1a21bec758e2bafc584e54905","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2/commits","review_comments_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2/comments","review_comment_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/issues/2/comments","statuses_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/statuses/2aefeb96c74afac0bc98b9712ad053d930b97418","head":{"label":"lorol:master","ref":"master","sha":"2aefeb96c74afac0bc98b9712ad053d930b97418","user":{"login":"lorol","id":4274080,"avatar_url":"https://avatars2.githubusercontent.com/u/4274080?v=4","gravatar_id":"","url":"https://api.github.com/users/lorol","html_url":"https://github.com/lorol","followers_url":"https://api.github.com/users/lorol/followers","following_url":"https://api.github.com/users/lorol/following{/other_user}","gists_url":"https://api.github.com/users/lorol/gists{/gist_id}","starred_url":"https://api.github.com/users/lorol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorol/subscriptions","organizations_url":"https://api.github.com/users/lorol/orgs","repos_url":"https://api.github.com/users/lorol/repos","events_url":"https://api.github.com/users/lorol/events{/privacy}","received_events_url":"https://api.github.com/users/lorol/received_events","type":"User","site_admin":false},"repo":{"id":105412342,"name":"esp8266-oled-ssd1306","full_name":"lorol/esp8266-oled-ssd1306","owner":{"login":"lorol","id":4274080,"avatar_url":"https://avatars2.githubusercontent.com/u/4274080?v=4","gravatar_id":"","url":"https://api.github.com/users/lorol","html_url":"https://github.com/lorol","followers_url":"https://api.github.com/users/lorol/followers","following_url":"https://api.github.com/users/lorol/following{/other_user}","gists_url":"https://api.github.com/users/lorol/gists{/gist_id}","starred_url":"https://api.github.com/users/lorol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorol/subscriptions","organizations_url":"https://api.github.com/users/lorol/orgs","repos_url":"https://api.github.com/users/lorol/repos","events_url":"https://api.github.com/users/lorol/events{/privacy}","received_events_url":"https://api.github.com/users/lorol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorol/esp8266-oled-ssd1306","description":"Driver for the SSD1306 and SH1106 based 128x64 pixel OLED display running on the Arduino/ESP8266 platform","fork":true,"url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306","forks_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/forks","keys_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/teams","hooks_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/hooks","issue_events_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/issues/events{/number}","events_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/events","assignees_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/assignees{/user}","branches_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/branches{/branch}","tags_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/tags","blobs_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/statuses/{sha}","languages_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/languages","stargazers_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/stargazers","contributors_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/contributors","subscribers_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/subscribers","subscription_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/subscription","commits_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/contents/{+path}","compare_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/merges","archive_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/downloads","issues_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/issues{/number}","pulls_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/pulls{/number}","milestones_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/milestones{/number}","notifications_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/labels{/name}","releases_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/releases{/id}","deployments_url":"https://api.github.com/repos/lorol/esp8266-oled-ssd1306/deployments","created_at":"2017-10-01T01:40:42Z","updated_at":"2017-10-01T01:40:44Z","pushed_at":"2017-10-25T15:33:12Z","git_url":"git://github.com/lorol/esp8266-oled-ssd1306.git","ssh_url":"git@github.com:lorol/esp8266-oled-ssd1306.git","clone_url":"https://github.com/lorol/esp8266-oled-ssd1306.git","svn_url":"https://github.com/lorol/esp8266-oled-ssd1306","homepage":"http://blog.squix.ch","size":1102,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reivaxy:master","ref":"master","sha":"6b2134517be00d50e3c60fa58576b705c0783e55","user":{"login":"reivaxy","id":3592991,"avatar_url":"https://avatars3.githubusercontent.com/u/3592991?v=4","gravatar_id":"","url":"https://api.github.com/users/reivaxy","html_url":"https://github.com/reivaxy","followers_url":"https://api.github.com/users/reivaxy/followers","following_url":"https://api.github.com/users/reivaxy/following{/other_user}","gists_url":"https://api.github.com/users/reivaxy/gists{/gist_id}","starred_url":"https://api.github.com/users/reivaxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reivaxy/subscriptions","organizations_url":"https://api.github.com/users/reivaxy/orgs","repos_url":"https://api.github.com/users/reivaxy/repos","events_url":"https://api.github.com/users/reivaxy/events{/privacy}","received_events_url":"https://api.github.com/users/reivaxy/received_events","type":"User","site_admin":false},"repo":{"id":107697268,"name":"esp8266-oled-ssd1306","full_name":"reivaxy/esp8266-oled-ssd1306","owner":{"login":"reivaxy","id":3592991,"avatar_url":"https://avatars3.githubusercontent.com/u/3592991?v=4","gravatar_id":"","url":"https://api.github.com/users/reivaxy","html_url":"https://github.com/reivaxy","followers_url":"https://api.github.com/users/reivaxy/followers","following_url":"https://api.github.com/users/reivaxy/following{/other_user}","gists_url":"https://api.github.com/users/reivaxy/gists{/gist_id}","starred_url":"https://api.github.com/users/reivaxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reivaxy/subscriptions","organizations_url":"https://api.github.com/users/reivaxy/orgs","repos_url":"https://api.github.com/users/reivaxy/repos","events_url":"https://api.github.com/users/reivaxy/events{/privacy}","received_events_url":"https://api.github.com/users/reivaxy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reivaxy/esp8266-oled-ssd1306","description":"Driver for the SSD1306 and SH1106 based 128x64 pixel OLED display running on the Arduino/ESP8266 platform","fork":true,"url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306","forks_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/forks","keys_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/teams","hooks_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/hooks","issue_events_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/issues/events{/number}","events_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/events","assignees_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/assignees{/user}","branches_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/branches{/branch}","tags_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/tags","blobs_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/git/refs{/sha}","trees_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/statuses/{sha}","languages_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/languages","stargazers_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/stargazers","contributors_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/contributors","subscribers_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/subscribers","subscription_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/subscription","commits_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/commits{/sha}","git_commits_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/git/commits{/sha}","comments_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/comments{/number}","issue_comment_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/issues/comments{/number}","contents_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/contents/{+path}","compare_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/merges","archive_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/downloads","issues_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/issues{/number}","pulls_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls{/number}","milestones_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/milestones{/number}","notifications_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/labels{/name}","releases_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/releases{/id}","deployments_url":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/deployments","created_at":"2017-10-20T15:52:17Z","updated_at":"2017-10-21T10:57:19Z","pushed_at":"2017-10-25T15:33:13Z","git_url":"git://github.com/reivaxy/esp8266-oled-ssd1306.git","ssh_url":"git@github.com:reivaxy/esp8266-oled-ssd1306.git","clone_url":"https://github.com/reivaxy/esp8266-oled-ssd1306.git","svn_url":"https://github.com/reivaxy/esp8266-oled-ssd1306","homepage":"http://blog.squix.ch","size":1239,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2"},"html":{"href":"https://github.com/reivaxy/esp8266-oled-ssd1306/pull/2"},"issue":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/issues/2"},"comments":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/reivaxy/esp8266-oled-ssd1306/statuses/2aefeb96c74afac0bc98b9712ad053d930b97418"}},"author_association":"NONE"}}
{"actor":{"display_login":"reivaxy"}}