{"action":"created","comment":{"url":"https://api.github.com/repos/pkp/ojs/pulls/comments/119162869","pull_request_review_id":41017824,"id":119162869,"diff_hunk":"@@ -0,0 +1,142 @@\n+<?php\n+\n+/**\n+ * @file api/v1/submission/SubmissionHandler.inc.php\n+ *\n+ * Copyright (c) 2014-2016 Simon Fraser University Library\n+ * Copyright (c) 2003-2016 John Willinsky\n+ * Distributed under the GNU GPL v2. For full terms see the file docs/COPYING.\n+ *\n+ * @class SubmissionHandler\n+ * @ingroup api_v1_submission\n+ *\n+ * @brief Handle API requests for submission operations.\n+ *\n+ */\n+\n+import('lib.pkp.classes.handler.APIHandler');\n+\n+class SubmissionHandler extends APIHandler {\n+\n+\t/**\n+\t * The unique endpoint string for this handler\n+\t *\n+\t * @param string\n+\t */\n+\tprotected $_handlerPath = 'submissions';","path":"api/v1/submissions/SubmissionHandler.inc.php","position":26,"original_position":26,"commit_id":"1e6071fecb23138b6b55f9c7ef3e0bc62d50b752","original_commit_id":"55dcbb965ce573a74d00821cbb1de43b369dc052","user":{"login":"kaschioudi","id":4896270,"avatar_url":"https://avatars3.githubusercontent.com/u/4896270?v=3","gravatar_id":"","url":"https://api.github.com/users/kaschioudi","html_url":"https://github.com/kaschioudi","followers_url":"https://api.github.com/users/kaschioudi/followers","following_url":"https://api.github.com/users/kaschioudi/following{/other_user}","gists_url":"https://api.github.com/users/kaschioudi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaschioudi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaschioudi/subscriptions","organizations_url":"https://api.github.com/users/kaschioudi/orgs","repos_url":"https://api.github.com/users/kaschioudi/repos","events_url":"https://api.github.com/users/kaschioudi/events{/privacy}","received_events_url":"https://api.github.com/users/kaschioudi/received_events","type":"User","site_admin":false},"body":"`$_handlerPath` property was already defined in APIHandler class; its value should be set in the constructor. \r\nAlso `APIHandler::getEndpointPattern()` is not an abstract class and uses `$_ handlerPath` (which will be initialized by a subclass). In APIHandler::__constructor() , I suggest to check whether `$_handlerPath` was set and raise and exception if not. \r\n","created_at":"2017-05-30T17:24:23Z","updated_at":"2017-05-30T17:24:23Z","html_url":"https://github.com/pkp/ojs/pull/1337#discussion_r119162869","pull_request_url":"https://api.github.com/repos/pkp/ojs/pulls/1337","_links":{"self":{"href":"https://api.github.com/repos/pkp/ojs/pulls/comments/119162869"},"html":{"href":"https://github.com/pkp/ojs/pull/1337#discussion_r119162869"},"pull_request":{"href":"https://api.github.com/repos/pkp/ojs/pulls/1337"}}},"pull_request":{"url":"https://api.github.com/repos/pkp/ojs/pulls/1337","id":113401905,"html_url":"https://github.com/pkp/ojs/pull/1337","diff_url":"https://github.com/pkp/ojs/pull/1337.diff","patch_url":"https://github.com/pkp/ojs/pull/1337.patch","issue_url":"https://api.github.com/repos/pkp/ojs/issues/1337","number":1337,"state":"open","locked":false,"title":"pkp/pkp-lib#2163 Vue.js submission list and REST API","user":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars1.githubusercontent.com/u/2306629?v=3","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"body":"This PR is just for doing some easy code review to get a sense of the changes.","created_at":"2017-03-30T11:05:18Z","updated_at":"2017-05-30T17:24:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d452ae066a82bce0feb7f2d3d25ac500b415807","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pkp/ojs/pulls/1337/commits","review_comments_url":"https://api.github.com/repos/pkp/ojs/pulls/1337/comments","review_comment_url":"https://api.github.com/repos/pkp/ojs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pkp/ojs/issues/1337/comments","statuses_url":"https://api.github.com/repos/pkp/ojs/statuses/1e6071fecb23138b6b55f9c7ef3e0bc62d50b752","head":{"label":"NateWr:i2163_js_with_api","ref":"i2163_js_with_api","sha":"1e6071fecb23138b6b55f9c7ef3e0bc62d50b752","user":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars1.githubusercontent.com/u/2306629?v=3","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"repo":{"id":78214658,"name":"ojs","full_name":"NateWr/ojs","owner":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars1.githubusercontent.com/u/2306629?v=3","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NateWr/ojs","description":"Open Journal Systems","fork":true,"url":"https://api.github.com/repos/NateWr/ojs","forks_url":"https://api.github.com/repos/NateWr/ojs/forks","keys_url":"https://api.github.com/repos/NateWr/ojs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NateWr/ojs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NateWr/ojs/teams","hooks_url":"https://api.github.com/repos/NateWr/ojs/hooks","issue_events_url":"https://api.github.com/repos/NateWr/ojs/issues/events{/number}","events_url":"https://api.github.com/repos/NateWr/ojs/events","assignees_url":"https://api.github.com/repos/NateWr/ojs/assignees{/user}","branches_url":"https://api.github.com/repos/NateWr/ojs/branches{/branch}","tags_url":"https://api.github.com/repos/NateWr/ojs/tags","blobs_url":"https://api.github.com/repos/NateWr/ojs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NateWr/ojs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NateWr/ojs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NateWr/ojs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NateWr/ojs/statuses/{sha}","languages_url":"https://api.github.com/repos/NateWr/ojs/languages","stargazers_url":"https://api.github.com/repos/NateWr/ojs/stargazers","contributors_url":"https://api.github.com/repos/NateWr/ojs/contributors","subscribers_url":"https://api.github.com/repos/NateWr/ojs/subscribers","subscription_url":"https://api.github.com/repos/NateWr/ojs/subscription","commits_url":"https://api.github.com/repos/NateWr/ojs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NateWr/ojs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NateWr/ojs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NateWr/ojs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NateWr/ojs/contents/{+path}","compare_url":"https://api.github.com/repos/NateWr/ojs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NateWr/ojs/merges","archive_url":"https://api.github.com/repos/NateWr/ojs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NateWr/ojs/downloads","issues_url":"https://api.github.com/repos/NateWr/ojs/issues{/number}","pulls_url":"https://api.github.com/repos/NateWr/ojs/pulls{/number}","milestones_url":"https://api.github.com/repos/NateWr/ojs/milestones{/number}","notifications_url":"https://api.github.com/repos/NateWr/ojs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NateWr/ojs/labels{/name}","releases_url":"https://api.github.com/repos/NateWr/ojs/releases{/id}","deployments_url":"https://api.github.com/repos/NateWr/ojs/deployments","created_at":"2017-01-06T15:04:13Z","updated_at":"2017-01-06T15:04:22Z","pushed_at":"2017-05-30T13:42:00Z","git_url":"git://github.com/NateWr/ojs.git","ssh_url":"git@github.com:NateWr/ojs.git","clone_url":"https://github.com/NateWr/ojs.git","svn_url":"https://github.com/NateWr/ojs","homepage":"http://pkp.sfu.ca/ojs","size":156442,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pkp:master","ref":"master","sha":"431d3d5514ad048e386bd4c53add38a64d5c6507","user":{"login":"pkp","id":130896,"avatar_url":"https://avatars0.githubusercontent.com/u/130896?v=3","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"repo":{"id":375152,"name":"ojs","full_name":"pkp/ojs","owner":{"login":"pkp","id":130896,"avatar_url":"https://avatars0.githubusercontent.com/u/130896?v=3","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pkp/ojs","description":"Open Journal Systems","fork":false,"url":"https://api.github.com/repos/pkp/ojs","forks_url":"https://api.github.com/repos/pkp/ojs/forks","keys_url":"https://api.github.com/repos/pkp/ojs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkp/ojs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkp/ojs/teams","hooks_url":"https://api.github.com/repos/pkp/ojs/hooks","issue_events_url":"https://api.github.com/repos/pkp/ojs/issues/events{/number}","events_url":"https://api.github.com/repos/pkp/ojs/events","assignees_url":"https://api.github.com/repos/pkp/ojs/assignees{/user}","branches_url":"https://api.github.com/repos/pkp/ojs/branches{/branch}","tags_url":"https://api.github.com/repos/pkp/ojs/tags","blobs_url":"https://api.github.com/repos/pkp/ojs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkp/ojs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkp/ojs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkp/ojs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkp/ojs/statuses/{sha}","languages_url":"https://api.github.com/repos/pkp/ojs/languages","stargazers_url":"https://api.github.com/repos/pkp/ojs/stargazers","contributors_url":"https://api.github.com/repos/pkp/ojs/contributors","subscribers_url":"https://api.github.com/repos/pkp/ojs/subscribers","subscription_url":"https://api.github.com/repos/pkp/ojs/subscription","commits_url":"https://api.github.com/repos/pkp/ojs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkp/ojs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkp/ojs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkp/ojs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkp/ojs/contents/{+path}","compare_url":"https://api.github.com/repos/pkp/ojs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkp/ojs/merges","archive_url":"https://api.github.com/repos/pkp/ojs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkp/ojs/downloads","issues_url":"https://api.github.com/repos/pkp/ojs/issues{/number}","pulls_url":"https://api.github.com/repos/pkp/ojs/pulls{/number}","milestones_url":"https://api.github.com/repos/pkp/ojs/milestones{/number}","notifications_url":"https://api.github.com/repos/pkp/ojs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkp/ojs/labels{/name}","releases_url":"https://api.github.com/repos/pkp/ojs/releases{/id}","deployments_url":"https://api.github.com/repos/pkp/ojs/deployments","created_at":"2009-11-16T21:19:14Z","updated_at":"2017-05-25T13:45:20Z","pushed_at":"2017-05-30T15:24:28Z","git_url":"git://github.com/pkp/ojs.git","ssh_url":"git@github.com:pkp/ojs.git","clone_url":"https://github.com/pkp/ojs.git","svn_url":"https://github.com/pkp/ojs","homepage":"http://pkp.sfu.ca/ojs","size":161384,"stargazers_count":321,"watchers_count":321,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"open_issues_count":43,"forks":394,"open_issues":43,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pkp/ojs/pulls/1337"},"html":{"href":"https://github.com/pkp/ojs/pull/1337"},"issue":{"href":"https://api.github.com/repos/pkp/ojs/issues/1337"},"comments":{"href":"https://api.github.com/repos/pkp/ojs/issues/1337/comments"},"review_comments":{"href":"https://api.github.com/repos/pkp/ojs/pulls/1337/comments"},"review_comment":{"href":"https://api.github.com/repos/pkp/ojs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pkp/ojs/pulls/1337/commits"},"statuses":{"href":"https://api.github.com/repos/pkp/ojs/statuses/1e6071fecb23138b6b55f9c7ef3e0bc62d50b752"}}}}
{"actor":{"display_login":"kaschioudi"}}