{"action":"opened","number":50806,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50806","id":136139202,"html_url":"https://github.com/kubernetes/kubernetes/pull/50806","diff_url":"https://github.com/kubernetes/kubernetes/pull/50806.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50806.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50806","number":50806,"state":"open","locked":false,"title":"On AttachDetachController node status update, do not retry when node …","user":{"login":"verult","id":1689416,"avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"body":"…doesn't exist but keep the node entry in cache.\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**: An alternative fix for https://github.com/kubernetes/kubernetes/issues/42438 which also fixes #50721.\r\n\r\nInstead of removing the node entry entirely from the node status update cache (which prevents the node from ever being updated even when it recovers), here the node status updater does nothing, so that there won't be an update retry until the node is re-added, where the cache entry is set to true.\r\n\r\nWill cherry pick to prior versions after this is merged.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50721 \r\n\r\n/assign @jingxu97 \r\n/cc @saad-ali \r\n/sig storage","created_at":"2017-08-16T22:48:20Z","updated_at":"2017-08-16T22:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars3.githubusercontent.com/u/19172805?v=4","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50806/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50806/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50806/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1234d2f500c63bf4d61f17f05e3c35a9da11d257","head":{"label":"verult:VolumeNotYetAttached","ref":"VolumeNotYetAttached","sha":"1234d2f500c63bf4d61f17f05e3c35a9da11d257","user":{"login":"verult","id":1689416,"avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"repo":{"id":88203879,"name":"kubernetes","full_name":"verult/kubernetes","owner":{"login":"verult","id":1689416,"avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/verult/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/verult/kubernetes","forks_url":"https://api.github.com/repos/verult/kubernetes/forks","keys_url":"https://api.github.com/repos/verult/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verult/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verult/kubernetes/teams","hooks_url":"https://api.github.com/repos/verult/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/verult/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/verult/kubernetes/events","assignees_url":"https://api.github.com/repos/verult/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/verult/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/verult/kubernetes/tags","blobs_url":"https://api.github.com/repos/verult/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verult/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verult/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/verult/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verult/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/verult/kubernetes/languages","stargazers_url":"https://api.github.com/repos/verult/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/verult/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/verult/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/verult/kubernetes/subscription","commits_url":"https://api.github.com/repos/verult/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/verult/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/verult/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/verult/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/verult/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/verult/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verult/kubernetes/merges","archive_url":"https://api.github.com/repos/verult/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verult/kubernetes/downloads","issues_url":"https://api.github.com/repos/verult/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/verult/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/verult/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/verult/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verult/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/verult/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/verult/kubernetes/deployments","created_at":"2017-04-13T20:30:00Z","updated_at":"2017-04-13T20:30:33Z","pushed_at":"2017-08-16T22:42:24Z","git_url":"git://github.com/verult/kubernetes.git","ssh_url":"git@github.com:verult/kubernetes.git","clone_url":"https://github.com/verult/kubernetes.git","svn_url":"https://github.com/verult/kubernetes","homepage":"http://kubernetes.io","size":456829,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5c558ddb185a7c120e147f24d69b7470bf7457e2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-08-16T22:44:05Z","pushed_at":"2017-08-16T22:40:24Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":675961,"stargazers_count":25953,"watchers_count":25953,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9252,"mirror_url":null,"open_issues_count":5250,"forks":9252,"open_issues":5250,"watchers":25953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50806"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50806"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50806"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50806/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50806/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50806/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1234d2f500c63bf4d61f17f05e3c35a9da11d257"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":103,"changed_files":3}}
{"actor":{"display_login":"verult"}}