{"action":"created","comment":{"url":"https://api.github.com/repos/chef-cookbooks/iis/pulls/comments/120806427","pull_request_review_id":42798933,"id":120806427,"diff_hunk":"@@ -34,10 +34,12 @@\n default_action :add\n \n load_current_value do |desired|\n-  application_name application_cleanname(desired.application_name).end_with?('/') ? application_cleanname(desired.application_name) : application_cleanname(desired.application_name) + '/'\n+  # Sanitize Application Name\n+  desired.application_name = application_cleanname(desired.application_name)\n+  # Sanitize Physical Path\n+  desired.physical_path = windows_cleanpath(desired.physical_path)","path":"resources/vdir.rb","position":8,"original_position":8,"commit_id":"9eaac9e94c80a197aac8dcec0d0deb3a05ef067b","original_commit_id":"9eaac9e94c80a197aac8dcec0d0deb3a05ef067b","user":{"login":"EasyAsABC123","id":1851104,"avatar_url":"https://avatars1.githubusercontent.com/u/1851104?v=3","gravatar_id":"","url":"https://api.github.com/users/EasyAsABC123","html_url":"https://github.com/EasyAsABC123","followers_url":"https://api.github.com/users/EasyAsABC123/followers","following_url":"https://api.github.com/users/EasyAsABC123/following{/other_user}","gists_url":"https://api.github.com/users/EasyAsABC123/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyAsABC123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyAsABC123/subscriptions","organizations_url":"https://api.github.com/users/EasyAsABC123/orgs","repos_url":"https://api.github.com/users/EasyAsABC123/repos","events_url":"https://api.github.com/users/EasyAsABC123/events{/privacy}","received_events_url":"https://api.github.com/users/EasyAsABC123/received_events","type":"User","site_admin":false},"body":"clean windows file path in `load_current_value`\r\n","created_at":"2017-06-08T06:11:03Z","updated_at":"2017-06-08T06:11:03Z","html_url":"https://github.com/chef-cookbooks/iis/pull/375#discussion_r120806427","pull_request_url":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375","_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/iis/pulls/comments/120806427"},"html":{"href":"https://github.com/chef-cookbooks/iis/pull/375#discussion_r120806427"},"pull_request":{"href":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375","id":123653036,"html_url":"https://github.com/chef-cookbooks/iis/pull/375","diff_url":"https://github.com/chef-cookbooks/iis/pull/375.diff","patch_url":"https://github.com/chef-cookbooks/iis/pull/375.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/iis/issues/375","number":375,"state":"open","locked":false,"title":"fix multiple bugs with iis_vdir iis_root iis_app for idempotency","user":{"login":"EasyAsABC123","id":1851104,"avatar_url":"https://avatars1.githubusercontent.com/u/1851104?v=3","gravatar_id":"","url":"https://api.github.com/users/EasyAsABC123","html_url":"https://github.com/EasyAsABC123","followers_url":"https://api.github.com/users/EasyAsABC123/followers","following_url":"https://api.github.com/users/EasyAsABC123/following{/other_user}","gists_url":"https://api.github.com/users/EasyAsABC123/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyAsABC123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyAsABC123/subscriptions","organizations_url":"https://api.github.com/users/EasyAsABC123/orgs","repos_url":"https://api.github.com/users/EasyAsABC123/repos","events_url":"https://api.github.com/users/EasyAsABC123/events{/privacy}","received_events_url":"https://api.github.com/users/EasyAsABC123/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Justin Schuhmann <jmschu02@gmail.com>\r\n\r\n### Description\r\n\r\n- idempotency issue with `iis_app`\r\n- idempotency issue with `iis_root`\r\n- idempotency issue with `iis_vdir`\r\n\r\n### Issues Resolved\r\n\r\n#374 \r\n\r\n### Check List\r\n\r\n- [x] All tests pass. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD>\r\n- [x] New functionality includes testing.\r\n- [x] New functionality has been documented in the README if applicable\r\n- [x] All commits have been signed for the Developer Certificate of Origin. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD>\r\n","created_at":"2017-06-02T06:54:43Z","updated_at":"2017-06-08T06:11:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbdddd45870c6626416c77187730ef5c8ef4c8c4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iennae","id":1592404,"avatar_url":"https://avatars1.githubusercontent.com/u/1592404?v=3","gravatar_id":"","url":"https://api.github.com/users/iennae","html_url":"https://github.com/iennae","followers_url":"https://api.github.com/users/iennae/followers","following_url":"https://api.github.com/users/iennae/following{/other_user}","gists_url":"https://api.github.com/users/iennae/gists{/gist_id}","starred_url":"https://api.github.com/users/iennae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iennae/subscriptions","organizations_url":"https://api.github.com/users/iennae/orgs","repos_url":"https://api.github.com/users/iennae/repos","events_url":"https://api.github.com/users/iennae/events{/privacy}","received_events_url":"https://api.github.com/users/iennae/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/iis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/iis/issues/375/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/iis/statuses/9eaac9e94c80a197aac8dcec0d0deb3a05ef067b","head":{"label":"chef-cookbooks:bug-idempotency_vdir_app_root","ref":"bug-idempotency_vdir_app_root","sha":"9eaac9e94c80a197aac8dcec0d0deb3a05ef067b","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars1.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":3720838,"name":"iis","full_name":"chef-cookbooks/iis","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars1.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/iis","description":"Development repository for Chef Cookbook iis","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/iis","forks_url":"https://api.github.com/repos/chef-cookbooks/iis/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/iis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/iis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/iis/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/iis/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/iis/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/iis/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/iis/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/iis/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/iis/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/iis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/iis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/iis/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/iis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/iis/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/iis/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/iis/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/iis/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/iis/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/iis/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/iis/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/iis/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/iis/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/iis/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/iis/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/iis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/iis/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/iis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/iis/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/iis/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/iis/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/iis/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/iis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/iis/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/iis/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/iis/deployments","created_at":"2012-03-14T18:32:50Z","updated_at":"2017-05-16T03:04:48Z","pushed_at":"2017-06-07T21:52:32Z","git_url":"git://github.com/chef-cookbooks/iis.git","ssh_url":"git@github.com:chef-cookbooks/iis.git","clone_url":"https://github.com/chef-cookbooks/iis.git","svn_url":"https://github.com/chef-cookbooks/iis","homepage":"https://supermarket.chef.io/cookbooks/iis","size":753,"stargazers_count":64,"watchers_count":64,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":12,"forks":162,"open_issues":12,"watchers":64,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"da84b5dc7f64c3638a3fd9e428dc1c1caef61ca4","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars1.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":3720838,"name":"iis","full_name":"chef-cookbooks/iis","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars1.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/iis","description":"Development repository for Chef Cookbook iis","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/iis","forks_url":"https://api.github.com/repos/chef-cookbooks/iis/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/iis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/iis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/iis/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/iis/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/iis/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/iis/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/iis/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/iis/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/iis/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/iis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/iis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/iis/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/iis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/iis/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/iis/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/iis/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/iis/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/iis/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/iis/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/iis/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/iis/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/iis/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/iis/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/iis/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/iis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/iis/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/iis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/iis/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/iis/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/iis/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/iis/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/iis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/iis/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/iis/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/iis/deployments","created_at":"2012-03-14T18:32:50Z","updated_at":"2017-05-16T03:04:48Z","pushed_at":"2017-06-07T21:52:32Z","git_url":"git://github.com/chef-cookbooks/iis.git","ssh_url":"git@github.com:chef-cookbooks/iis.git","clone_url":"https://github.com/chef-cookbooks/iis.git","svn_url":"https://github.com/chef-cookbooks/iis","homepage":"https://supermarket.chef.io/cookbooks/iis","size":753,"stargazers_count":64,"watchers_count":64,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":12,"forks":162,"open_issues":12,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375"},"html":{"href":"https://github.com/chef-cookbooks/iis/pull/375"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/iis/issues/375"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/iis/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/iis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/iis/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/iis/statuses/9eaac9e94c80a197aac8dcec0d0deb3a05ef067b"}}}}
{"actor":{"display_login":"EasyAsABC123"}}