{"action":"created","comment":{"url":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments/96411228","pull_request_review_id":16990687,"id":96411228,"diff_hunk":"@@ -28,7 +28,7 @@ func testNicCreate(t *testing.T, f fixture.F) {\n \t\tf.ResGroupName,\n \t\tf.Location,\n \t)\n-\t_ = azure.NewNsg(f)\n+\tazure.NewNsg(f)","path":"tests/azure/nic_test.go","position":null,"original_position":5,"commit_id":"3e8a54c0d6b10aeac7c06d14921ec49c4328ea9e","original_commit_id":"3e8a54c0d6b10aeac7c06d14921ec49c4328ea9e","user":{"login":"katcipis","id":157634,"avatar_url":"https://avatars.githubusercontent.com/u/157634?v=3","gravatar_id":"","url":"https://api.github.com/users/katcipis","html_url":"https://github.com/katcipis","followers_url":"https://api.github.com/users/katcipis/followers","following_url":"https://api.github.com/users/katcipis/following{/other_user}","gists_url":"https://api.github.com/users/katcipis/gists{/gist_id}","starred_url":"https://api.github.com/users/katcipis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katcipis/subscriptions","organizations_url":"https://api.github.com/users/katcipis/orgs","repos_url":"https://api.github.com/users/katcipis/repos","events_url":"https://api.github.com/users/katcipis/events{/privacy}","received_events_url":"https://api.github.com/users/katcipis/received_events","type":"User","site_admin":false},"body":"I was hinting that you dont need to call any New* methods if you are not going to use the return value. New functions are usually constructors, they dont have side effects (or should not at least), just calling it and ignoring the return is odd, and in this case I checked out the New functions and they do almost nothing. No need to call them here ;-)","created_at":"2017-01-17T13:32:51Z","updated_at":"2017-01-17T13:33:35Z","html_url":"https://github.com/NeowayLabs/klb/pull/51#discussion_r96411228","pull_request_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments/96411228"},"html":{"href":"https://github.com/NeowayLabs/klb/pull/51#discussion_r96411228"},"pull_request":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/NeowayLabs/klb/pulls/51","id":101854856,"html_url":"https://github.com/NeowayLabs/klb/pull/51","diff_url":"https://github.com/NeowayLabs/klb/pull/51.diff","patch_url":"https://github.com/NeowayLabs/klb/pull/51.patch","issue_url":"https://api.github.com/repos/NeowayLabs/klb/issues/51","number":51,"state":"open","locked":false,"title":"Add test to nic","user":{"login":"matheusvill","id":827415,"avatar_url":"https://avatars.githubusercontent.com/u/827415?v=3","gravatar_id":"","url":"https://api.github.com/users/matheusvill","html_url":"https://github.com/matheusvill","followers_url":"https://api.github.com/users/matheusvill/followers","following_url":"https://api.github.com/users/matheusvill/following{/other_user}","gists_url":"https://api.github.com/users/matheusvill/gists{/gist_id}","starred_url":"https://api.github.com/users/matheusvill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matheusvill/subscriptions","organizations_url":"https://api.github.com/users/matheusvill/orgs","repos_url":"https://api.github.com/users/matheusvill/repos","events_url":"https://api.github.com/users/matheusvill/events{/privacy}","received_events_url":"https://api.github.com/users/matheusvill/received_events","type":"User","site_admin":false},"body":"Closes #33 ","created_at":"2017-01-17T12:34:14Z","updated_at":"2017-01-17T13:33:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"katcipis","id":157634,"avatar_url":"https://avatars.githubusercontent.com/u/157634?v=3","gravatar_id":"","url":"https://api.github.com/users/katcipis","html_url":"https://github.com/katcipis","followers_url":"https://api.github.com/users/katcipis/followers","following_url":"https://api.github.com/users/katcipis/following{/other_user}","gists_url":"https://api.github.com/users/katcipis/gists{/gist_id}","starred_url":"https://api.github.com/users/katcipis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katcipis/subscriptions","organizations_url":"https://api.github.com/users/katcipis/orgs","repos_url":"https://api.github.com/users/katcipis/repos","events_url":"https://api.github.com/users/katcipis/events{/privacy}","received_events_url":"https://api.github.com/users/katcipis/received_events","type":"User","site_admin":false},"assignees":[{"login":"katcipis","id":157634,"avatar_url":"https://avatars.githubusercontent.com/u/157634?v=3","gravatar_id":"","url":"https://api.github.com/users/katcipis","html_url":"https://github.com/katcipis","followers_url":"https://api.github.com/users/katcipis/followers","following_url":"https://api.github.com/users/katcipis/following{/other_user}","gists_url":"https://api.github.com/users/katcipis/gists{/gist_id}","starred_url":"https://api.github.com/users/katcipis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katcipis/subscriptions","organizations_url":"https://api.github.com/users/katcipis/orgs","repos_url":"https://api.github.com/users/katcipis/repos","events_url":"https://api.github.com/users/katcipis/events{/privacy}","received_events_url":"https://api.github.com/users/katcipis/received_events","type":"User","site_admin":false},{"login":"kamilash","id":7937849,"avatar_url":"https://avatars.githubusercontent.com/u/7937849?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilash","html_url":"https://github.com/kamilash","followers_url":"https://api.github.com/users/kamilash/followers","following_url":"https://api.github.com/users/kamilash/following{/other_user}","gists_url":"https://api.github.com/users/kamilash/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilash/subscriptions","organizations_url":"https://api.github.com/users/kamilash/orgs","repos_url":"https://api.github.com/users/kamilash/repos","events_url":"https://api.github.com/users/kamilash/events{/privacy}","received_events_url":"https://api.github.com/users/kamilash/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/51/commits","review_comments_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/51/comments","review_comment_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NeowayLabs/klb/issues/51/comments","statuses_url":"https://api.github.com/repos/NeowayLabs/klb/statuses/3e8a54c0d6b10aeac7c06d14921ec49c4328ea9e","head":{"label":"NeowayLabs:addTestToNic","ref":"addTestToNic","sha":"3e8a54c0d6b10aeac7c06d14921ec49c4328ea9e","user":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66672315,"name":"klb","full_name":"NeowayLabs/klb","owner":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NeowayLabs/klb","description":"Nash library to automate your cloud infrastructure (AWS/Azure)","fork":false,"url":"https://api.github.com/repos/NeowayLabs/klb","forks_url":"https://api.github.com/repos/NeowayLabs/klb/forks","keys_url":"https://api.github.com/repos/NeowayLabs/klb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NeowayLabs/klb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NeowayLabs/klb/teams","hooks_url":"https://api.github.com/repos/NeowayLabs/klb/hooks","issue_events_url":"https://api.github.com/repos/NeowayLabs/klb/issues/events{/number}","events_url":"https://api.github.com/repos/NeowayLabs/klb/events","assignees_url":"https://api.github.com/repos/NeowayLabs/klb/assignees{/user}","branches_url":"https://api.github.com/repos/NeowayLabs/klb/branches{/branch}","tags_url":"https://api.github.com/repos/NeowayLabs/klb/tags","blobs_url":"https://api.github.com/repos/NeowayLabs/klb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NeowayLabs/klb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NeowayLabs/klb/git/refs{/sha}","trees_url":"https://api.github.com/repos/NeowayLabs/klb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NeowayLabs/klb/statuses/{sha}","languages_url":"https://api.github.com/repos/NeowayLabs/klb/languages","stargazers_url":"https://api.github.com/repos/NeowayLabs/klb/stargazers","contributors_url":"https://api.github.com/repos/NeowayLabs/klb/contributors","subscribers_url":"https://api.github.com/repos/NeowayLabs/klb/subscribers","subscription_url":"https://api.github.com/repos/NeowayLabs/klb/subscription","commits_url":"https://api.github.com/repos/NeowayLabs/klb/commits{/sha}","git_commits_url":"https://api.github.com/repos/NeowayLabs/klb/git/commits{/sha}","comments_url":"https://api.github.com/repos/NeowayLabs/klb/comments{/number}","issue_comment_url":"https://api.github.com/repos/NeowayLabs/klb/issues/comments{/number}","contents_url":"https://api.github.com/repos/NeowayLabs/klb/contents/{+path}","compare_url":"https://api.github.com/repos/NeowayLabs/klb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NeowayLabs/klb/merges","archive_url":"https://api.github.com/repos/NeowayLabs/klb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NeowayLabs/klb/downloads","issues_url":"https://api.github.com/repos/NeowayLabs/klb/issues{/number}","pulls_url":"https://api.github.com/repos/NeowayLabs/klb/pulls{/number}","milestones_url":"https://api.github.com/repos/NeowayLabs/klb/milestones{/number}","notifications_url":"https://api.github.com/repos/NeowayLabs/klb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NeowayLabs/klb/labels{/name}","releases_url":"https://api.github.com/repos/NeowayLabs/klb/releases{/id}","deployments_url":"https://api.github.com/repos/NeowayLabs/klb/deployments","created_at":"2016-08-26T18:58:07Z","updated_at":"2016-11-21T13:07:14Z","pushed_at":"2017-01-17T13:26:04Z","git_url":"git://github.com/NeowayLabs/klb.git","ssh_url":"git@github.com:NeowayLabs/klb.git","clone_url":"https://github.com/NeowayLabs/klb.git","svn_url":"https://github.com/NeowayLabs/klb","homepage":"","size":2517,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":6,"default_branch":"master"}},"base":{"label":"NeowayLabs:master","ref":"master","sha":"09a5630a9c44f05d8aaca18d0953f8a08d782605","user":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66672315,"name":"klb","full_name":"NeowayLabs/klb","owner":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NeowayLabs/klb","description":"Nash library to automate your cloud infrastructure (AWS/Azure)","fork":false,"url":"https://api.github.com/repos/NeowayLabs/klb","forks_url":"https://api.github.com/repos/NeowayLabs/klb/forks","keys_url":"https://api.github.com/repos/NeowayLabs/klb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NeowayLabs/klb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NeowayLabs/klb/teams","hooks_url":"https://api.github.com/repos/NeowayLabs/klb/hooks","issue_events_url":"https://api.github.com/repos/NeowayLabs/klb/issues/events{/number}","events_url":"https://api.github.com/repos/NeowayLabs/klb/events","assignees_url":"https://api.github.com/repos/NeowayLabs/klb/assignees{/user}","branches_url":"https://api.github.com/repos/NeowayLabs/klb/branches{/branch}","tags_url":"https://api.github.com/repos/NeowayLabs/klb/tags","blobs_url":"https://api.github.com/repos/NeowayLabs/klb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NeowayLabs/klb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NeowayLabs/klb/git/refs{/sha}","trees_url":"https://api.github.com/repos/NeowayLabs/klb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NeowayLabs/klb/statuses/{sha}","languages_url":"https://api.github.com/repos/NeowayLabs/klb/languages","stargazers_url":"https://api.github.com/repos/NeowayLabs/klb/stargazers","contributors_url":"https://api.github.com/repos/NeowayLabs/klb/contributors","subscribers_url":"https://api.github.com/repos/NeowayLabs/klb/subscribers","subscription_url":"https://api.github.com/repos/NeowayLabs/klb/subscription","commits_url":"https://api.github.com/repos/NeowayLabs/klb/commits{/sha}","git_commits_url":"https://api.github.com/repos/NeowayLabs/klb/git/commits{/sha}","comments_url":"https://api.github.com/repos/NeowayLabs/klb/comments{/number}","issue_comment_url":"https://api.github.com/repos/NeowayLabs/klb/issues/comments{/number}","contents_url":"https://api.github.com/repos/NeowayLabs/klb/contents/{+path}","compare_url":"https://api.github.com/repos/NeowayLabs/klb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NeowayLabs/klb/merges","archive_url":"https://api.github.com/repos/NeowayLabs/klb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NeowayLabs/klb/downloads","issues_url":"https://api.github.com/repos/NeowayLabs/klb/issues{/number}","pulls_url":"https://api.github.com/repos/NeowayLabs/klb/pulls{/number}","milestones_url":"https://api.github.com/repos/NeowayLabs/klb/milestones{/number}","notifications_url":"https://api.github.com/repos/NeowayLabs/klb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NeowayLabs/klb/labels{/name}","releases_url":"https://api.github.com/repos/NeowayLabs/klb/releases{/id}","deployments_url":"https://api.github.com/repos/NeowayLabs/klb/deployments","created_at":"2016-08-26T18:58:07Z","updated_at":"2016-11-21T13:07:14Z","pushed_at":"2017-01-17T13:26:04Z","git_url":"git://github.com/NeowayLabs/klb.git","ssh_url":"git@github.com:NeowayLabs/klb.git","clone_url":"https://github.com/NeowayLabs/klb.git","svn_url":"https://github.com/NeowayLabs/klb","homepage":"","size":2517,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/51"},"html":{"href":"https://github.com/NeowayLabs/klb/pull/51"},"issue":{"href":"https://api.github.com/repos/NeowayLabs/klb/issues/51"},"comments":{"href":"https://api.github.com/repos/NeowayLabs/klb/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/NeowayLabs/klb/statuses/3e8a54c0d6b10aeac7c06d14921ec49c4328ea9e"}}}}
{"actor":{"display_login":"katcipis"}}