{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/103261194","pull_request_review_id":24042284,"id":103261194,"diff_hunk":"@@ -3,7 +3,7 @@\n   \"dependencies\": {\n     \"Microsoft.NETCore.App\": {\n       \"type\": \"platform\",\n-      \"version\": \"1.0.0\"\n+      \"version\": \"1.1.0\"","path":"test/HostActivationTests/project.json","position":5,"original_position":5,"commit_id":"c009f5f6cf967724baa5375beea86382fdf7b42d","original_commit_id":"c009f5f6cf967724baa5375beea86382fdf7b42d","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"This was already existing, but we are depending on Microsoft.NETCore.App version `1.1.0`, but using TFM \"netcoreapp2.0\".  This seems incorrect.","created_at":"2017-02-27T17:18:37Z","updated_at":"2017-02-27T17:18:37Z","html_url":"https://github.com/dotnet/core-setup/pull/1587#discussion_r103261194","pull_request_url":"https://api.github.com/repos/dotnet/core-setup/pulls/1587","_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/103261194"},"html":{"href":"https://github.com/dotnet/core-setup/pull/1587#discussion_r103261194"},"pull_request":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/1587"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/1587","id":107912403,"html_url":"https://github.com/dotnet/core-setup/pull/1587","diff_url":"https://github.com/dotnet/core-setup/pull/1587.diff","patch_url":"https://github.com/dotnet/core-setup/pull/1587.patch","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/1587","number":1587,"state":"open","locked":false,"title":"Moving core-setup to be msbuild based using buildtools","user":{"login":"AlfredoMS","id":6474954,"avatar_url":"https://avatars.githubusercontent.com/u/6474954?v=3","gravatar_id":"","url":"https://api.github.com/users/AlfredoMS","html_url":"https://github.com/AlfredoMS","followers_url":"https://api.github.com/users/AlfredoMS/followers","following_url":"https://api.github.com/users/AlfredoMS/following{/other_user}","gists_url":"https://api.github.com/users/AlfredoMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlfredoMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlfredoMS/subscriptions","organizations_url":"https://api.github.com/users/AlfredoMS/orgs","repos_url":"https://api.github.com/users/AlfredoMS/repos","events_url":"https://api.github.com/users/AlfredoMS/events{/privacy}","received_events_url":"https://api.github.com/users/AlfredoMS/received_events","type":"User","site_admin":false},"body":"** DO NOT MERGE **\r\nThis is a \"beta\" version for everyone to use and test.\r\nBranch was rebased using master on 2/23, latest changes may not be included\r\n\r\nIssue: https://github.com/dotnet/core-setup/issues/283\r\n\r\nThis change replaces the cli/c# based build with an msbuild/buildtools based system to be aligned with the other dotnet code repositories.\r\n\r\nHow to use:\r\n1. clone it from this pr or from https://github.com/AlfredoMS/core-setup/tree/build-eng\r\n\r\nWindows:\r\n- run build.cmd\r\nMac and Linux\r\n- run build.sh -- /p:TargetRid= [your desired target rid, e.g. osx.10.10-x64  or ubuntu.16.04-x64\r\n\r\nyou can use -verbose for msbuild verbose logging and -SkipTests=true to skip test that are broken*\r\n\r\nTo run the build step by step you can use this commands just add .sh or .cmd according to your os\r\n\r\nsync\r\nrun build-custom -verbose -- src/corehost/build.proj\r\nrun build-custom -verbose -- pkg/dirs.proj\r\nrun build-custom -verbose -- src/dirs.proj\r\nrun build-custom -verbose -- test/dirs.proj\r\nrun build-custom -verbose -- packaging/dirs.proj\r\n\r\nfor mac and linux specify the os and TargetRid\r\nexample:\r\nrun build-custom -verbose -OSGroup=OSX -- src/corehost/build.proj /p:TargetRid=osx.10.10-x64\r\nrun build-custom -verbose -OSGroup=Linux -- src/corehost/build.proj /p:TargetRid=ubuntu.16.04-x64\r\n\r\n\r\nIf you are planning on making new changes you should get familiar with the new build and bin structure.\r\nKnown issues:\r\n- Publishing is not ready\r\n- Tests are broken. I have a workaround but it still depends on the old build system. Use flag \"-SkipTest=true\"\r\n- Build.sh needs improvements to generated targetrid or accept one as parameter\r\n- checked in build definitions for jenkins and vsts have not been updated\r\n- upgrade version tool has not been updated.\r\n- generated packages will have the version suffix 0009999, this is intentional to help identify built binaries while testing the branch, will be changed for the final version.\r\n------\r\n@gkhanna79 @ellismg  @weshaggard @ericstj @wtgodbe @eerhardt @dagood @jyoungyun","created_at":"2017-02-24T21:29:44Z","updated_at":"2017-02-27T17:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"090d3dd2226b3c6b31a7ea1db3f15827c88d8ef6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/core-setup/pulls/1587/commits","review_comments_url":"https://api.github.com/repos/dotnet/core-setup/pulls/1587/comments","review_comment_url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/1587/comments","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/c009f5f6cf967724baa5375beea86382fdf7b42d","head":{"label":"AlfredoMS:build-eng","ref":"build-eng","sha":"c009f5f6cf967724baa5375beea86382fdf7b42d","user":{"login":"AlfredoMS","id":6474954,"avatar_url":"https://avatars.githubusercontent.com/u/6474954?v=3","gravatar_id":"","url":"https://api.github.com/users/AlfredoMS","html_url":"https://github.com/AlfredoMS","followers_url":"https://api.github.com/users/AlfredoMS/followers","following_url":"https://api.github.com/users/AlfredoMS/following{/other_user}","gists_url":"https://api.github.com/users/AlfredoMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlfredoMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlfredoMS/subscriptions","organizations_url":"https://api.github.com/users/AlfredoMS/orgs","repos_url":"https://api.github.com/users/AlfredoMS/repos","events_url":"https://api.github.com/users/AlfredoMS/events{/privacy}","received_events_url":"https://api.github.com/users/AlfredoMS/received_events","type":"User","site_admin":false},"repo":{"id":75673338,"name":"core-setup","full_name":"AlfredoMS/core-setup","owner":{"login":"AlfredoMS","id":6474954,"avatar_url":"https://avatars.githubusercontent.com/u/6474954?v=3","gravatar_id":"","url":"https://api.github.com/users/AlfredoMS","html_url":"https://github.com/AlfredoMS","followers_url":"https://api.github.com/users/AlfredoMS/followers","following_url":"https://api.github.com/users/AlfredoMS/following{/other_user}","gists_url":"https://api.github.com/users/AlfredoMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlfredoMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlfredoMS/subscriptions","organizations_url":"https://api.github.com/users/AlfredoMS/orgs","repos_url":"https://api.github.com/users/AlfredoMS/repos","events_url":"https://api.github.com/users/AlfredoMS/events{/privacy}","received_events_url":"https://api.github.com/users/AlfredoMS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlfredoMS/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":true,"url":"https://api.github.com/repos/AlfredoMS/core-setup","forks_url":"https://api.github.com/repos/AlfredoMS/core-setup/forks","keys_url":"https://api.github.com/repos/AlfredoMS/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlfredoMS/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlfredoMS/core-setup/teams","hooks_url":"https://api.github.com/repos/AlfredoMS/core-setup/hooks","issue_events_url":"https://api.github.com/repos/AlfredoMS/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/AlfredoMS/core-setup/events","assignees_url":"https://api.github.com/repos/AlfredoMS/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/AlfredoMS/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/AlfredoMS/core-setup/tags","blobs_url":"https://api.github.com/repos/AlfredoMS/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlfredoMS/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlfredoMS/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlfredoMS/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlfredoMS/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/AlfredoMS/core-setup/languages","stargazers_url":"https://api.github.com/repos/AlfredoMS/core-setup/stargazers","contributors_url":"https://api.github.com/repos/AlfredoMS/core-setup/contributors","subscribers_url":"https://api.github.com/repos/AlfredoMS/core-setup/subscribers","subscription_url":"https://api.github.com/repos/AlfredoMS/core-setup/subscription","commits_url":"https://api.github.com/repos/AlfredoMS/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlfredoMS/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlfredoMS/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlfredoMS/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlfredoMS/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/AlfredoMS/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlfredoMS/core-setup/merges","archive_url":"https://api.github.com/repos/AlfredoMS/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlfredoMS/core-setup/downloads","issues_url":"https://api.github.com/repos/AlfredoMS/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/AlfredoMS/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/AlfredoMS/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/AlfredoMS/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlfredoMS/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/AlfredoMS/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/AlfredoMS/core-setup/deployments","created_at":"2016-12-05T22:49:09Z","updated_at":"2017-01-03T22:15:18Z","pushed_at":"2017-02-24T20:09:18Z","git_url":"git://github.com/AlfredoMS/core-setup.git","ssh_url":"git@github.com:AlfredoMS/core-setup.git","clone_url":"https://github.com/AlfredoMS/core-setup.git","svn_url":"https://github.com/AlfredoMS/core-setup","homepage":"","size":2372,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"abafdd5161f9a0fd0fdec61cae208e253356419b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":59249196,"name":"core-setup","full_name":"dotnet/core-setup","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":false,"url":"https://api.github.com/repos/dotnet/core-setup","forks_url":"https://api.github.com/repos/dotnet/core-setup/forks","keys_url":"https://api.github.com/repos/dotnet/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/core-setup/teams","hooks_url":"https://api.github.com/repos/dotnet/core-setup/hooks","issue_events_url":"https://api.github.com/repos/dotnet/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/core-setup/events","assignees_url":"https://api.github.com/repos/dotnet/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/core-setup/tags","blobs_url":"https://api.github.com/repos/dotnet/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/core-setup/languages","stargazers_url":"https://api.github.com/repos/dotnet/core-setup/stargazers","contributors_url":"https://api.github.com/repos/dotnet/core-setup/contributors","subscribers_url":"https://api.github.com/repos/dotnet/core-setup/subscribers","subscription_url":"https://api.github.com/repos/dotnet/core-setup/subscription","commits_url":"https://api.github.com/repos/dotnet/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/core-setup/merges","archive_url":"https://api.github.com/repos/dotnet/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/core-setup/downloads","issues_url":"https://api.github.com/repos/dotnet/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/core-setup/deployments","created_at":"2016-05-19T23:07:13Z","updated_at":"2017-02-22T20:01:51Z","pushed_at":"2017-02-25T14:03:31Z","git_url":"git://github.com/dotnet/core-setup.git","ssh_url":"git@github.com:dotnet/core-setup.git","clone_url":"https://github.com/dotnet/core-setup.git","svn_url":"https://github.com/dotnet/core-setup","homepage":"","size":2453,"stargazers_count":47,"watchers_count":47,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":119,"forks":72,"open_issues":119,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/1587"},"html":{"href":"https://github.com/dotnet/core-setup/pull/1587"},"issue":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/1587"},"comments":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/1587/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/1587/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/1587/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/core-setup/statuses/c009f5f6cf967724baa5375beea86382fdf7b42d"}}}}
{"actor":{"display_login":"eerhardt"}}