{"action":"opened","number":87,"pull_request":{"url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/87","id":158332684,"html_url":"https://github.com/webpack-contrib/compression-webpack-plugin/pull/87","diff_url":"https://github.com/webpack-contrib/compression-webpack-plugin/pull/87.diff","patch_url":"https://github.com/webpack-contrib/compression-webpack-plugin/pull/87.patch","issue_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/87","number":87,"state":"open","locked":false,"title":"fix: `cache` option behavior","user":{"login":"evilebottnawi","id":4567934,"avatar_url":"https://avatars3.githubusercontent.com/u/4567934?v=4","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. [Read and sign the CLA](https://cla.js.foundation/webpack/webpack.js.org). This needs to be done only once. PRs that haven't signed it won't be accepted.\r\n2. Check out the [development guide](https://webpack.js.org/development/) for the API and development guidelines.\r\n3. Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.\r\n-->\r\n\r\nWe should avoid using `JSON.stringify` because `data` is buffer and after get from cache we return `{type: 'Buffer', data: [...]}` and this object don't have `length` (because it is now not `Buffer` it is just plain object with properties) - `minRation` doesn't work.\r\n\r\nOther cached package also can contain error. I investigate this right now.","created_at":"2017-12-14T11:28:25Z","updated_at":"2017-12-14T11:28:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/87/commits","review_comments_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/87/comments","review_comment_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/87/comments","statuses_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/statuses/cbb59b1c7d916f30563d2e1641ddb0da157633a6","head":{"label":"webpack-contrib:fix-cache","ref":"fix-cache","sha":"cbb59b1c7d916f30563d2e1641ddb0da157633a6","user":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":11895397,"name":"compression-webpack-plugin","full_name":"webpack-contrib/compression-webpack-plugin","owner":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/compression-webpack-plugin","description":"Prepare compressed versions of assets to serve them with Content-Encoding","fork":false,"url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin","forks_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/forks","keys_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/events","assignees_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/merges","archive_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/deployments","created_at":"2013-08-05T10:07:57Z","updated_at":"2017-12-13T20:52:52Z","pushed_at":"2017-12-14T11:25:21Z","git_url":"git://github.com/webpack-contrib/compression-webpack-plugin.git","ssh_url":"git@github.com:webpack-contrib/compression-webpack-plugin.git","clone_url":"https://github.com/webpack-contrib/compression-webpack-plugin.git","svn_url":"https://github.com/webpack-contrib/compression-webpack-plugin","homepage":null,"size":197,"stargazers_count":526,"watchers_count":526,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":47,"open_issues":6,"watchers":526,"default_branch":"master"}},"base":{"label":"webpack-contrib:master","ref":"master","sha":"bed4d76c0b034b301ab56b2ecef7709cff78e5eb","user":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":11895397,"name":"compression-webpack-plugin","full_name":"webpack-contrib/compression-webpack-plugin","owner":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/compression-webpack-plugin","description":"Prepare compressed versions of assets to serve them with Content-Encoding","fork":false,"url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin","forks_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/forks","keys_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/events","assignees_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/merges","archive_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/deployments","created_at":"2013-08-05T10:07:57Z","updated_at":"2017-12-13T20:52:52Z","pushed_at":"2017-12-14T11:25:21Z","git_url":"git://github.com/webpack-contrib/compression-webpack-plugin.git","ssh_url":"git@github.com:webpack-contrib/compression-webpack-plugin.git","clone_url":"https://github.com/webpack-contrib/compression-webpack-plugin.git","svn_url":"https://github.com/webpack-contrib/compression-webpack-plugin","homepage":null,"size":197,"stargazers_count":526,"watchers_count":526,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":47,"open_issues":6,"watchers":526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/87"},"html":{"href":"https://github.com/webpack-contrib/compression-webpack-plugin/pull/87"},"issue":{"href":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/87"},"comments":{"href":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/webpack-contrib/compression-webpack-plugin/statuses/cbb59b1c7d916f30563d2e1641ddb0da157633a6"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"evilebottnawi"}}