{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/94867603","pull_request_review_id":15409122,"id":94867603,"diff_hunk":"@@ -35,22 +35,63 @@ class ChiSqSelectorSuite extends SparkFunSuite with MLlibTestSparkContext\n \n     // Toy dataset, including the top feature for a chi-squared test.\n     // These data are chosen such that each feature's test has a distinct p-value.\n-    /*  To verify the results with R, run:\n-      library(stats)\n-      x1 <- c(8.0, 0.0, 0.0, 7.0, 8.0)\n-      x2 <- c(7.0, 9.0, 9.0, 9.0, 7.0)\n-      x3 <- c(0.0, 6.0, 8.0, 5.0, 3.0)\n-      y <- c(0.0, 1.0, 1.0, 2.0, 2.0)\n-      chisq.test(x1,y)\n-      chisq.test(x2,y)\n-      chisq.test(x3,y)\n+    /*\n+     *  Contingency tables","path":"mllib/src/test/scala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala","position":14,"original_position":14,"commit_id":"2d87dd35d3acf003d13618cea03bcc5ffd5419e2","original_commit_id":"2d87dd35d3acf003d13618cea03bcc5ffd5419e2","user":{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars.githubusercontent.com/u/5084283?v=3","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false},"body":"It's kind of nice seeing these tables, but for validation, it's much easier for users to check using R.  Could you please include a section for verifying the results with R, like there was before?","created_at":"2017-01-05T22:40:48Z","updated_at":"2017-01-05T22:40:48Z","html_url":"https://github.com/apache/spark/pull/16434#discussion_r94867603","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16434","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/94867603"},"html":{"href":"https://github.com/apache/spark/pull/16434#discussion_r94867603"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16434"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16434","id":99667527,"html_url":"https://github.com/apache/spark/pull/16434","diff_url":"https://github.com/apache/spark/pull/16434.diff","patch_url":"https://github.com/apache/spark/pull/16434.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16434","number":16434,"state":"open","locked":false,"title":"[SPARK-17645][MLLIB][ML][FOLLOW-UP] document minor change","user":{"login":"mpjlu","id":13826327,"avatar_url":"https://avatars.githubusercontent.com/u/13826327?v=3","gravatar_id":"","url":"https://api.github.com/users/mpjlu","html_url":"https://github.com/mpjlu","followers_url":"https://api.github.com/users/mpjlu/followers","following_url":"https://api.github.com/users/mpjlu/following{/other_user}","gists_url":"https://api.github.com/users/mpjlu/gists{/gist_id}","starred_url":"https://api.github.com/users/mpjlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpjlu/subscriptions","organizations_url":"https://api.github.com/users/mpjlu/orgs","repos_url":"https://api.github.com/users/mpjlu/repos","events_url":"https://api.github.com/users/mpjlu/events{/privacy}","received_events_url":"https://api.github.com/users/mpjlu/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nAdd FDR test case in ml/feature/ChiSqSelectorSuite.\r\nImprove some comments in the code.\r\nThis is a follow-up pr for #15212.\r\n\r\n## How was this patch tested?\r\nut","created_at":"2016-12-29T15:28:40Z","updated_at":"2017-01-05T22:40:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6379f0f5e3dc0f49176206d2cc23c5eb4b4b3c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16434/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16434/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16434/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/2d87dd35d3acf003d13618cea03bcc5ffd5419e2","head":{"label":"mpjlu:fdr_fwe_update","ref":"fdr_fwe_update","sha":"2d87dd35d3acf003d13618cea03bcc5ffd5419e2","user":{"login":"mpjlu","id":13826327,"avatar_url":"https://avatars.githubusercontent.com/u/13826327?v=3","gravatar_id":"","url":"https://api.github.com/users/mpjlu","html_url":"https://github.com/mpjlu","followers_url":"https://api.github.com/users/mpjlu/followers","following_url":"https://api.github.com/users/mpjlu/following{/other_user}","gists_url":"https://api.github.com/users/mpjlu/gists{/gist_id}","starred_url":"https://api.github.com/users/mpjlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpjlu/subscriptions","organizations_url":"https://api.github.com/users/mpjlu/orgs","repos_url":"https://api.github.com/users/mpjlu/repos","events_url":"https://api.github.com/users/mpjlu/events{/privacy}","received_events_url":"https://api.github.com/users/mpjlu/received_events","type":"User","site_admin":false},"repo":{"id":64218821,"name":"spark","full_name":"mpjlu/spark","owner":{"login":"mpjlu","id":13826327,"avatar_url":"https://avatars.githubusercontent.com/u/13826327?v=3","gravatar_id":"","url":"https://api.github.com/users/mpjlu","html_url":"https://github.com/mpjlu","followers_url":"https://api.github.com/users/mpjlu/followers","following_url":"https://api.github.com/users/mpjlu/following{/other_user}","gists_url":"https://api.github.com/users/mpjlu/gists{/gist_id}","starred_url":"https://api.github.com/users/mpjlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpjlu/subscriptions","organizations_url":"https://api.github.com/users/mpjlu/orgs","repos_url":"https://api.github.com/users/mpjlu/repos","events_url":"https://api.github.com/users/mpjlu/events{/privacy}","received_events_url":"https://api.github.com/users/mpjlu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpjlu/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/mpjlu/spark","forks_url":"https://api.github.com/repos/mpjlu/spark/forks","keys_url":"https://api.github.com/repos/mpjlu/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpjlu/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpjlu/spark/teams","hooks_url":"https://api.github.com/repos/mpjlu/spark/hooks","issue_events_url":"https://api.github.com/repos/mpjlu/spark/issues/events{/number}","events_url":"https://api.github.com/repos/mpjlu/spark/events","assignees_url":"https://api.github.com/repos/mpjlu/spark/assignees{/user}","branches_url":"https://api.github.com/repos/mpjlu/spark/branches{/branch}","tags_url":"https://api.github.com/repos/mpjlu/spark/tags","blobs_url":"https://api.github.com/repos/mpjlu/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpjlu/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpjlu/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpjlu/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpjlu/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/mpjlu/spark/languages","stargazers_url":"https://api.github.com/repos/mpjlu/spark/stargazers","contributors_url":"https://api.github.com/repos/mpjlu/spark/contributors","subscribers_url":"https://api.github.com/repos/mpjlu/spark/subscribers","subscription_url":"https://api.github.com/repos/mpjlu/spark/subscription","commits_url":"https://api.github.com/repos/mpjlu/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpjlu/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpjlu/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpjlu/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpjlu/spark/contents/{+path}","compare_url":"https://api.github.com/repos/mpjlu/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpjlu/spark/merges","archive_url":"https://api.github.com/repos/mpjlu/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpjlu/spark/downloads","issues_url":"https://api.github.com/repos/mpjlu/spark/issues{/number}","pulls_url":"https://api.github.com/repos/mpjlu/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/mpjlu/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/mpjlu/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpjlu/spark/labels{/name}","releases_url":"https://api.github.com/repos/mpjlu/spark/releases{/id}","deployments_url":"https://api.github.com/repos/mpjlu/spark/deployments","created_at":"2016-07-26T12:17:42Z","updated_at":"2016-07-26T12:18:08Z","pushed_at":"2017-01-03T04:16:56Z","git_url":"git://github.com/mpjlu/spark.git","ssh_url":"git@github.com:mpjlu/spark.git","clone_url":"https://github.com/mpjlu/spark.git","svn_url":"https://github.com/mpjlu/spark","homepage":null,"size":254596,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7d19b6ab7d75b95d9eb1c7e1f228d23fd482306e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-01-05T16:59:58Z","pushed_at":"2017-01-05T21:45:49Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":260175,"stargazers_count":11318,"watchers_count":11318,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10598,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":445,"forks":10598,"open_issues":445,"watchers":11318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16434"},"html":{"href":"https://github.com/apache/spark/pull/16434"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16434"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16434/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16434/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16434/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/2d87dd35d3acf003d13618cea03bcc5ffd5419e2"}}}}
{"actor":{"display_login":"jkbradley"}}