{"action":"created","issue":{"url":"https://api.github.com/repos/openfaas/faas-cli/issues/227","repository_url":"https://api.github.com/repos/openfaas/faas-cli","labels_url":"https://api.github.com/repos/openfaas/faas-cli/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/faas-cli/issues/227/comments","events_url":"https://api.github.com/repos/openfaas/faas-cli/issues/227/events","html_url":"https://github.com/openfaas/faas-cli/issues/227","id":275219355,"number":227,"title":"faas-cli when used with stack.yml should pick up secrets","user":{"login":"ericstoekl","id":1483261,"avatar_url":"https://avatars2.githubusercontent.com/u/1483261?v=4","gravatar_id":"","url":"https://api.github.com/users/ericstoekl","html_url":"https://github.com/ericstoekl","followers_url":"https://api.github.com/users/ericstoekl/followers","following_url":"https://api.github.com/users/ericstoekl/following{/other_user}","gists_url":"https://api.github.com/users/ericstoekl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstoekl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstoekl/subscriptions","organizations_url":"https://api.github.com/users/ericstoekl/orgs","repos_url":"https://api.github.com/users/ericstoekl/repos","events_url":"https://api.github.com/users/ericstoekl/events{/privacy}","received_events_url":"https://api.github.com/users/ericstoekl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-20T02:24:36Z","updated_at":"2017-11-20T04:07:40Z","closed_at":null,"author_association":"MEMBER","body":"<!--- Provide a general summary of the issue in the Title above -->\r\n\r\nSecrets could be put into a stack.yml file like so:\r\n\r\n```\r\nprovider:\r\n  name: faas\r\n  gateway: http://localhost:8080\r\n\r\nfunctions:\r\n  secrettest:\r\n    lang: node\r\n    handler: ./secrettest\r\n    image: ems5311/secrettest:0.1\r\n    secrets:\r\n      - db-user-pass\r\n```\r\n\r\nCurrently, the secret list in this situation would not be picked up by `faas-cli`\r\n\r\n## Expected Behaviour\r\n<!--- If you're describing a bug, tell us what should happen -->\r\n<!--- If you're suggesting a change/improvement, tell us how it should work -->\r\nSecrets can be applied via the stack.yml file.\r\n\r\n## Current Behaviour\r\n<!--- If describing a bug, tell us what happens instead of the expected behavior -->\r\n<!--- If suggesting a change/improvement, explain the difference from current behavior -->\r\nSecrets must be set via the `--secrets` command line parameter.\r\n\r\n## Possible Solution\r\n<!--- Not obligatory, but suggest a fix/reason for the bug, -->\r\n<!--- or ideas how to implement the addition or change -->\r\nhttps://github.com/ericstoekl/faas-cli/commit/97110be8511b1f2fba699398d4ede7cbff82ee14\r\n\r\n\r\n## Steps to Reproduce (for bugs)\r\n<!--- Provide a link to a live example, or an unambiguous set of steps to -->\r\n<!--- reproduce this bug. Include code to reproduce, if relevant -->\r\n1. Add a `secrets:` object to a function in the stack yaml\r\n2. `faas-cli deploy`\r\n3. Observe that the secret was not picked up\r\n4.\r\n\r\n## Context\r\n<!--- How has this issue affected you? What are you trying to accomplish? -->\r\n<!--- Providing context helps us come up with a solution that is most useful in the real world -->\r\nWhile testing secrets proposed change:\r\nhttps://github.com/openfaas/faas-netes/pull/86#issuecomment-345498646\r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the environment you experienced the bug in -->\r\n* Docker version `docker version` (e.g. Docker 17.0.05 ):\r\nDocker version 17.11.0-ce-rc2, build d7062e5\r\n* Are you using Docker Swarm or Kubernetes (FaaS-netes)?\r\nkubernete 1.8.3 via minikube\r\n* Operating System and version (e.g. Linux, Windows, MacOS):\r\nubuntu 1604\r\n* Link to your project or a code example to reproduce issue:\r\n"},"comment":{"url":"https://api.github.com/repos/openfaas/faas-cli/issues/comments/345586595","html_url":"https://github.com/openfaas/faas-cli/issues/227#issuecomment-345586595","issue_url":"https://api.github.com/repos/openfaas/faas-cli/issues/227","id":345586595,"user":{"login":"ericstoekl","id":1483261,"avatar_url":"https://avatars2.githubusercontent.com/u/1483261?v=4","gravatar_id":"","url":"https://api.github.com/users/ericstoekl","html_url":"https://github.com/ericstoekl","followers_url":"https://api.github.com/users/ericstoekl/followers","following_url":"https://api.github.com/users/ericstoekl/following{/other_user}","gists_url":"https://api.github.com/users/ericstoekl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstoekl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstoekl/subscriptions","organizations_url":"https://api.github.com/users/ericstoekl/orgs","repos_url":"https://api.github.com/users/ericstoekl/repos","events_url":"https://api.github.com/users/ericstoekl/events{/privacy}","received_events_url":"https://api.github.com/users/ericstoekl/received_events","type":"User","site_admin":false},"created_at":"2017-11-20T04:07:40Z","updated_at":"2017-11-20T04:07:40Z","author_association":"MEMBER","body":"Derek add label: proposal"}}
{"actor":{"display_login":"ericstoekl"}}