{"action":"created","comment":{"url":"https://api.github.com/repos/embulk/embulk/pulls/comments/118189288","pull_request_review_id":39943432,"id":118189288,"diff_hunk":"@@ -0,0 +1,112 @@\n+package org.embulk.spi.time;\n+\n+import org.jruby.runtime.ThreadContext;\n+\n+import java.util.HashMap;\n+import java.util.List;\n+\n+import static org.embulk.spi.time.StrptimeParser.FormatBag.has;\n+import static org.jruby.RubyRational.newRationalCanonicalize;\n+\n+/**\n+ * This class has {@code StrptimeParser} and provides methods that are calls from JRuby.\n+ */\n+public class RubyDateParser","path":"embulk-jruby-strptime/src/main/java/org/embulk/spi/time/RubyDateParser.java","position":14,"original_position":14,"commit_id":"6dcc30fddee4437f8b94a20a25b1d48226525be5","original_commit_id":"6dcc30fddee4437f8b94a20a25b1d48226525be5","user":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars1.githubusercontent.com/u/723722?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"body":"IIUC, this `RubyDateParser` is not called within Embulk?\r\n\r\nIf so, and we don't need this immediately, what do you think delaying to merge this?","created_at":"2017-05-24T08:15:40Z","updated_at":"2017-05-24T08:20:45Z","html_url":"https://github.com/embulk/embulk/pull/611#discussion_r118189288","pull_request_url":"https://api.github.com/repos/embulk/embulk/pulls/611","_links":{"self":{"href":"https://api.github.com/repos/embulk/embulk/pulls/comments/118189288"},"html":{"href":"https://github.com/embulk/embulk/pull/611#discussion_r118189288"},"pull_request":{"href":"https://api.github.com/repos/embulk/embulk/pulls/611"}}},"pull_request":{"url":"https://api.github.com/repos/embulk/embulk/pulls/611","id":119328974,"html_url":"https://github.com/embulk/embulk/pull/611","diff_url":"https://github.com/embulk/embulk/pull/611.diff","patch_url":"https://github.com/embulk/embulk/pull/611.patch","issue_url":"https://api.github.com/repos/embulk/embulk/issues/611","number":611,"state":"open","locked":false,"title":"Java timestamp parser and RubyDateParser v2","user":{"login":"muga","id":127959,"avatar_url":"https://avatars0.githubusercontent.com/u/127959?v=3","gravatar_id":"","url":"https://api.github.com/users/muga","html_url":"https://github.com/muga","followers_url":"https://api.github.com/users/muga/followers","following_url":"https://api.github.com/users/muga/following{/other_user}","gists_url":"https://api.github.com/users/muga/gists{/gist_id}","starred_url":"https://api.github.com/users/muga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muga/subscriptions","organizations_url":"https://api.github.com/users/muga/orgs","repos_url":"https://api.github.com/users/muga/repos","events_url":"https://api.github.com/users/muga/events{/privacy}","received_events_url":"https://api.github.com/users/muga/received_events","type":"User","site_admin":false},"body":"To improve the performance of parsing timestamp values, this PR introduces Java timestamp parser. It implements RubyDateParser, which is compatible with Ruby's strptime parser. The parser parses timestamp values by strptime tokens pre-tokenized by strptime lexer.\r\n\r\nThis PR is a replacement of #608. #608 will be closed.","created_at":"2017-05-07T07:14:16Z","updated_at":"2017-05-24T08:20:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f14d99f9a1ee4a9da1bf1e70f705c3a5f08475d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/embulk/embulk/pulls/611/commits","review_comments_url":"https://api.github.com/repos/embulk/embulk/pulls/611/comments","review_comment_url":"https://api.github.com/repos/embulk/embulk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/embulk/embulk/issues/611/comments","statuses_url":"https://api.github.com/repos/embulk/embulk/statuses/6dcc30fddee4437f8b94a20a25b1d48226525be5","head":{"label":"muga:java_timestamp_parser_separateding_ruby_date_parser","ref":"java_timestamp_parser_separateding_ruby_date_parser","sha":"6dcc30fddee4437f8b94a20a25b1d48226525be5","user":{"login":"muga","id":127959,"avatar_url":"https://avatars0.githubusercontent.com/u/127959?v=3","gravatar_id":"","url":"https://api.github.com/users/muga","html_url":"https://github.com/muga","followers_url":"https://api.github.com/users/muga/followers","following_url":"https://api.github.com/users/muga/following{/other_user}","gists_url":"https://api.github.com/users/muga/gists{/gist_id}","starred_url":"https://api.github.com/users/muga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muga/subscriptions","organizations_url":"https://api.github.com/users/muga/orgs","repos_url":"https://api.github.com/users/muga/repos","events_url":"https://api.github.com/users/muga/events{/privacy}","received_events_url":"https://api.github.com/users/muga/received_events","type":"User","site_admin":false},"repo":{"id":34023194,"name":"embulk","full_name":"muga/embulk","owner":{"login":"muga","id":127959,"avatar_url":"https://avatars0.githubusercontent.com/u/127959?v=3","gravatar_id":"","url":"https://api.github.com/users/muga","html_url":"https://github.com/muga","followers_url":"https://api.github.com/users/muga/followers","following_url":"https://api.github.com/users/muga/following{/other_user}","gists_url":"https://api.github.com/users/muga/gists{/gist_id}","starred_url":"https://api.github.com/users/muga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muga/subscriptions","organizations_url":"https://api.github.com/users/muga/orgs","repos_url":"https://api.github.com/users/muga/repos","events_url":"https://api.github.com/users/muga/events{/privacy}","received_events_url":"https://api.github.com/users/muga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muga/embulk","description":"Embulk: Pluggable Bulk Data Loader. http://www.embulk.org","fork":true,"url":"https://api.github.com/repos/muga/embulk","forks_url":"https://api.github.com/repos/muga/embulk/forks","keys_url":"https://api.github.com/repos/muga/embulk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muga/embulk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muga/embulk/teams","hooks_url":"https://api.github.com/repos/muga/embulk/hooks","issue_events_url":"https://api.github.com/repos/muga/embulk/issues/events{/number}","events_url":"https://api.github.com/repos/muga/embulk/events","assignees_url":"https://api.github.com/repos/muga/embulk/assignees{/user}","branches_url":"https://api.github.com/repos/muga/embulk/branches{/branch}","tags_url":"https://api.github.com/repos/muga/embulk/tags","blobs_url":"https://api.github.com/repos/muga/embulk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muga/embulk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muga/embulk/git/refs{/sha}","trees_url":"https://api.github.com/repos/muga/embulk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muga/embulk/statuses/{sha}","languages_url":"https://api.github.com/repos/muga/embulk/languages","stargazers_url":"https://api.github.com/repos/muga/embulk/stargazers","contributors_url":"https://api.github.com/repos/muga/embulk/contributors","subscribers_url":"https://api.github.com/repos/muga/embulk/subscribers","subscription_url":"https://api.github.com/repos/muga/embulk/subscription","commits_url":"https://api.github.com/repos/muga/embulk/commits{/sha}","git_commits_url":"https://api.github.com/repos/muga/embulk/git/commits{/sha}","comments_url":"https://api.github.com/repos/muga/embulk/comments{/number}","issue_comment_url":"https://api.github.com/repos/muga/embulk/issues/comments{/number}","contents_url":"https://api.github.com/repos/muga/embulk/contents/{+path}","compare_url":"https://api.github.com/repos/muga/embulk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muga/embulk/merges","archive_url":"https://api.github.com/repos/muga/embulk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muga/embulk/downloads","issues_url":"https://api.github.com/repos/muga/embulk/issues{/number}","pulls_url":"https://api.github.com/repos/muga/embulk/pulls{/number}","milestones_url":"https://api.github.com/repos/muga/embulk/milestones{/number}","notifications_url":"https://api.github.com/repos/muga/embulk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muga/embulk/labels{/name}","releases_url":"https://api.github.com/repos/muga/embulk/releases{/id}","deployments_url":"https://api.github.com/repos/muga/embulk/deployments","created_at":"2015-04-15T23:10:33Z","updated_at":"2016-07-02T07:03:53Z","pushed_at":"2017-05-21T14:30:06Z","git_url":"git://github.com/muga/embulk.git","ssh_url":"git@github.com:muga/embulk.git","clone_url":"https://github.com/muga/embulk.git","svn_url":"https://github.com/muga/embulk","homepage":"","size":3361,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"embulk:master","ref":"master","sha":"7bf539d6d947855d34eb0fcf02a2fdd64087d832","user":{"login":"embulk","id":10171516,"avatar_url":"https://avatars3.githubusercontent.com/u/10171516?v=3","gravatar_id":"","url":"https://api.github.com/users/embulk","html_url":"https://github.com/embulk","followers_url":"https://api.github.com/users/embulk/followers","following_url":"https://api.github.com/users/embulk/following{/other_user}","gists_url":"https://api.github.com/users/embulk/gists{/gist_id}","starred_url":"https://api.github.com/users/embulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embulk/subscriptions","organizations_url":"https://api.github.com/users/embulk/orgs","repos_url":"https://api.github.com/users/embulk/repos","events_url":"https://api.github.com/users/embulk/events{/privacy}","received_events_url":"https://api.github.com/users/embulk/received_events","type":"Organization","site_admin":false},"repo":{"id":24084730,"name":"embulk","full_name":"embulk/embulk","owner":{"login":"embulk","id":10171516,"avatar_url":"https://avatars3.githubusercontent.com/u/10171516?v=3","gravatar_id":"","url":"https://api.github.com/users/embulk","html_url":"https://github.com/embulk","followers_url":"https://api.github.com/users/embulk/followers","following_url":"https://api.github.com/users/embulk/following{/other_user}","gists_url":"https://api.github.com/users/embulk/gists{/gist_id}","starred_url":"https://api.github.com/users/embulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embulk/subscriptions","organizations_url":"https://api.github.com/users/embulk/orgs","repos_url":"https://api.github.com/users/embulk/repos","events_url":"https://api.github.com/users/embulk/events{/privacy}","received_events_url":"https://api.github.com/users/embulk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embulk/embulk","description":"Embulk: Pluggable Bulk Data Loader. http://www.embulk.org","fork":false,"url":"https://api.github.com/repos/embulk/embulk","forks_url":"https://api.github.com/repos/embulk/embulk/forks","keys_url":"https://api.github.com/repos/embulk/embulk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embulk/embulk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embulk/embulk/teams","hooks_url":"https://api.github.com/repos/embulk/embulk/hooks","issue_events_url":"https://api.github.com/repos/embulk/embulk/issues/events{/number}","events_url":"https://api.github.com/repos/embulk/embulk/events","assignees_url":"https://api.github.com/repos/embulk/embulk/assignees{/user}","branches_url":"https://api.github.com/repos/embulk/embulk/branches{/branch}","tags_url":"https://api.github.com/repos/embulk/embulk/tags","blobs_url":"https://api.github.com/repos/embulk/embulk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embulk/embulk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embulk/embulk/git/refs{/sha}","trees_url":"https://api.github.com/repos/embulk/embulk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embulk/embulk/statuses/{sha}","languages_url":"https://api.github.com/repos/embulk/embulk/languages","stargazers_url":"https://api.github.com/repos/embulk/embulk/stargazers","contributors_url":"https://api.github.com/repos/embulk/embulk/contributors","subscribers_url":"https://api.github.com/repos/embulk/embulk/subscribers","subscription_url":"https://api.github.com/repos/embulk/embulk/subscription","commits_url":"https://api.github.com/repos/embulk/embulk/commits{/sha}","git_commits_url":"https://api.github.com/repos/embulk/embulk/git/commits{/sha}","comments_url":"https://api.github.com/repos/embulk/embulk/comments{/number}","issue_comment_url":"https://api.github.com/repos/embulk/embulk/issues/comments{/number}","contents_url":"https://api.github.com/repos/embulk/embulk/contents/{+path}","compare_url":"https://api.github.com/repos/embulk/embulk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embulk/embulk/merges","archive_url":"https://api.github.com/repos/embulk/embulk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embulk/embulk/downloads","issues_url":"https://api.github.com/repos/embulk/embulk/issues{/number}","pulls_url":"https://api.github.com/repos/embulk/embulk/pulls{/number}","milestones_url":"https://api.github.com/repos/embulk/embulk/milestones{/number}","notifications_url":"https://api.github.com/repos/embulk/embulk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embulk/embulk/labels{/name}","releases_url":"https://api.github.com/repos/embulk/embulk/releases{/id}","deployments_url":"https://api.github.com/repos/embulk/embulk/deployments","created_at":"2014-09-16T03:58:52Z","updated_at":"2017-05-24T02:54:24Z","pushed_at":"2017-05-24T02:48:56Z","git_url":"git://github.com/embulk/embulk.git","ssh_url":"git@github.com:embulk/embulk.git","clone_url":"https://github.com/embulk/embulk.git","svn_url":"https://github.com/embulk/embulk","homepage":"","size":3350,"stargazers_count":884,"watchers_count":884,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":111,"forks":109,"open_issues":111,"watchers":884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/embulk/embulk/pulls/611"},"html":{"href":"https://github.com/embulk/embulk/pull/611"},"issue":{"href":"https://api.github.com/repos/embulk/embulk/issues/611"},"comments":{"href":"https://api.github.com/repos/embulk/embulk/issues/611/comments"},"review_comments":{"href":"https://api.github.com/repos/embulk/embulk/pulls/611/comments"},"review_comment":{"href":"https://api.github.com/repos/embulk/embulk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/embulk/embulk/pulls/611/commits"},"statuses":{"href":"https://api.github.com/repos/embulk/embulk/statuses/6dcc30fddee4437f8b94a20a25b1d48226525be5"}}}}
{"actor":{"display_login":"dmikurube"}}