{"action":"created","comment":{"url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/comments/126022187","pull_request_review_id":48469837,"id":126022187,"diff_hunk":"@@ -1,38 +1,44 @@\n+\"\"\"Reader without using the wait call.\"\"\"\n ##############################################################################\n # Copyright (c) 2005-2015 Real-Time Innovations, Inc. All rights reserved.\n # Permission to modify and use for internal purposes granted.\n # This software is provided \"as is\", without warranty, express or implied.\n ##############################################################################\n \n-import sys\n-import os\n-filepath = os.path.dirname(os.path.realpath(__file__))\n-sys.path.append(filepath + \"/../../../\");\n-import time\n+from sys import path as sysPath\n+from os import path as osPath\n+from time import sleep\n import rticonnextdds_connector as rti\n \n+filepath = osPath.dirname(osPath.realpath(__file__))\n+sysPath.append(filepath + \"/../../../\")\n \n-connector = rti.Connector(\"MyParticipantLibrary::Zero\",filepath + \"/../Mixed.xml\");\n-input = connector.getInput(\"MySubscriber::MySquareReader\");\n+connector = rti.Connector(\"MyParticipantLibrary::Zero\",\n+                          filepath + \"/../Mixed.xml\")\n+inputDDS = connector.getInput(\"MySubscriber::MySquareReader\")","path":"examples/python/mixed/reader.py","position":25,"original_position":25,"commit_id":"b00726970659069fb93073ca8afb3ee6c1e09002","original_commit_id":"b00726970659069fb93073ca8afb3ee6c1e09002","user":{"login":"gianpiero","id":1449875,"avatar_url":"https://avatars2.githubusercontent.com/u/1449875?v=3","gravatar_id":"","url":"https://api.github.com/users/gianpiero","html_url":"https://github.com/gianpiero","followers_url":"https://api.github.com/users/gianpiero/followers","following_url":"https://api.github.com/users/gianpiero/following{/other_user}","gists_url":"https://api.github.com/users/gianpiero/gists{/gist_id}","starred_url":"https://api.github.com/users/gianpiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianpiero/subscriptions","organizations_url":"https://api.github.com/users/gianpiero/orgs","repos_url":"https://api.github.com/users/gianpiero/repos","events_url":"https://api.github.com/users/gianpiero/events{/privacy}","received_events_url":"https://api.github.com/users/gianpiero/received_events","type":"User","site_admin":false},"body":"we want to keep input (or output) as names for the variables. This are the names we use in the docuement and they represent a concept. So i wouldn't rename them. The example is here to teach how to use connector.. so naming is important","created_at":"2017-07-06T21:35:06Z","updated_at":"2017-07-06T21:37:15Z","html_url":"https://github.com/rticommunity/rticonnextdds-connector/pull/50#discussion_r126022187","pull_request_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/comments/126022187"},"html":{"href":"https://github.com/rticommunity/rticonnextdds-connector/pull/50#discussion_r126022187"},"pull_request":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50","id":129132043,"html_url":"https://github.com/rticommunity/rticonnextdds-connector/pull/50","diff_url":"https://github.com/rticommunity/rticonnextdds-connector/pull/50.diff","patch_url":"https://github.com/rticommunity/rticonnextdds-connector/pull/50.patch","issue_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/issues/50","number":50,"state":"open","locked":false,"title":"Remove warnings","user":{"login":"iblancasa","id":4806311,"avatar_url":"https://avatars1.githubusercontent.com/u/4806311?v=3","gravatar_id":"","url":"https://api.github.com/users/iblancasa","html_url":"https://github.com/iblancasa","followers_url":"https://api.github.com/users/iblancasa/followers","following_url":"https://api.github.com/users/iblancasa/following{/other_user}","gists_url":"https://api.github.com/users/iblancasa/gists{/gist_id}","starred_url":"https://api.github.com/users/iblancasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iblancasa/subscriptions","organizations_url":"https://api.github.com/users/iblancasa/orgs","repos_url":"https://api.github.com/users/iblancasa/repos","events_url":"https://api.github.com/users/iblancasa/events{/privacy}","received_events_url":"https://api.github.com/users/iblancasa/received_events","type":"User","site_admin":false},"body":"Fixing warnings in the Python examples.","created_at":"2017-07-06T08:44:05Z","updated_at":"2017-07-06T21:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f8e848045932df4b727fc2cd0c18fd8088c9f48","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50/commits","review_comments_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50/comments","review_comment_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/issues/50/comments","statuses_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/statuses/b00726970659069fb93073ca8afb3ee6c1e09002","head":{"label":"iblancasa:remove-warnings","ref":"remove-warnings","sha":"b00726970659069fb93073ca8afb3ee6c1e09002","user":{"login":"iblancasa","id":4806311,"avatar_url":"https://avatars1.githubusercontent.com/u/4806311?v=3","gravatar_id":"","url":"https://api.github.com/users/iblancasa","html_url":"https://github.com/iblancasa","followers_url":"https://api.github.com/users/iblancasa/followers","following_url":"https://api.github.com/users/iblancasa/following{/other_user}","gists_url":"https://api.github.com/users/iblancasa/gists{/gist_id}","starred_url":"https://api.github.com/users/iblancasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iblancasa/subscriptions","organizations_url":"https://api.github.com/users/iblancasa/orgs","repos_url":"https://api.github.com/users/iblancasa/repos","events_url":"https://api.github.com/users/iblancasa/events{/privacy}","received_events_url":"https://api.github.com/users/iblancasa/received_events","type":"User","site_admin":false},"repo":{"id":96135843,"name":"rticonnextdds-connector","full_name":"iblancasa/rticonnextdds-connector","owner":{"login":"iblancasa","id":4806311,"avatar_url":"https://avatars1.githubusercontent.com/u/4806311?v=3","gravatar_id":"","url":"https://api.github.com/users/iblancasa","html_url":"https://github.com/iblancasa","followers_url":"https://api.github.com/users/iblancasa/followers","following_url":"https://api.github.com/users/iblancasa/following{/other_user}","gists_url":"https://api.github.com/users/iblancasa/gists{/gist_id}","starred_url":"https://api.github.com/users/iblancasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iblancasa/subscriptions","organizations_url":"https://api.github.com/users/iblancasa/orgs","repos_url":"https://api.github.com/users/iblancasa/repos","events_url":"https://api.github.com/users/iblancasa/events{/privacy}","received_events_url":"https://api.github.com/users/iblancasa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iblancasa/rticonnextdds-connector","description":"RTI Connector for Connext DDS is a lightweight connector technology that enables DDS data to be accessed with Javascript (Node.js), Python, and Lua.","fork":true,"url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector","forks_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/forks","keys_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/teams","hooks_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/hooks","issue_events_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/issues/events{/number}","events_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/events","assignees_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/assignees{/user}","branches_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/branches{/branch}","tags_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/tags","blobs_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/languages","stargazers_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/stargazers","contributors_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/contributors","subscribers_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/subscribers","subscription_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/subscription","commits_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/contents/{+path}","compare_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/merges","archive_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/downloads","issues_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/issues{/number}","pulls_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/labels{/name}","releases_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/releases{/id}","deployments_url":"https://api.github.com/repos/iblancasa/rticonnextdds-connector/deployments","created_at":"2017-07-03T17:40:34Z","updated_at":"2017-07-03T17:40:37Z","pushed_at":"2017-07-06T08:38:13Z","git_url":"git://github.com/iblancasa/rticonnextdds-connector.git","ssh_url":"git@github.com:iblancasa/rticonnextdds-connector.git","clone_url":"https://github.com/iblancasa/rticonnextdds-connector.git","svn_url":"https://github.com/iblancasa/rticonnextdds-connector","homepage":"https://community.rti.com/downloads/experimental/rticonnextdds-connector","size":233834,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rticommunity:master","ref":"master","sha":"4552ca9a1316a02bda6265ba786c96199be74266","user":{"login":"rticommunity","id":3244894,"avatar_url":"https://avatars1.githubusercontent.com/u/3244894?v=3","gravatar_id":"","url":"https://api.github.com/users/rticommunity","html_url":"https://github.com/rticommunity","followers_url":"https://api.github.com/users/rticommunity/followers","following_url":"https://api.github.com/users/rticommunity/following{/other_user}","gists_url":"https://api.github.com/users/rticommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/rticommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rticommunity/subscriptions","organizations_url":"https://api.github.com/users/rticommunity/orgs","repos_url":"https://api.github.com/users/rticommunity/repos","events_url":"https://api.github.com/users/rticommunity/events{/privacy}","received_events_url":"https://api.github.com/users/rticommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":23449150,"name":"rticonnextdds-connector","full_name":"rticommunity/rticonnextdds-connector","owner":{"login":"rticommunity","id":3244894,"avatar_url":"https://avatars1.githubusercontent.com/u/3244894?v=3","gravatar_id":"","url":"https://api.github.com/users/rticommunity","html_url":"https://github.com/rticommunity","followers_url":"https://api.github.com/users/rticommunity/followers","following_url":"https://api.github.com/users/rticommunity/following{/other_user}","gists_url":"https://api.github.com/users/rticommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/rticommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rticommunity/subscriptions","organizations_url":"https://api.github.com/users/rticommunity/orgs","repos_url":"https://api.github.com/users/rticommunity/repos","events_url":"https://api.github.com/users/rticommunity/events{/privacy}","received_events_url":"https://api.github.com/users/rticommunity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rticommunity/rticonnextdds-connector","description":"RTI Connector for Connext DDS is a lightweight connector technology that enables DDS data to be accessed with Javascript (Node.js), Python, and Lua.","fork":false,"url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector","forks_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/forks","keys_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/teams","hooks_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/hooks","issue_events_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/issues/events{/number}","events_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/events","assignees_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/assignees{/user}","branches_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/branches{/branch}","tags_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/tags","blobs_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/languages","stargazers_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/stargazers","contributors_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/contributors","subscribers_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/subscribers","subscription_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/subscription","commits_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/contents/{+path}","compare_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/merges","archive_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/downloads","issues_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/issues{/number}","pulls_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/labels{/name}","releases_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/releases{/id}","deployments_url":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/deployments","created_at":"2014-08-29T01:52:42Z","updated_at":"2017-06-29T23:02:58Z","pushed_at":"2017-07-06T08:44:06Z","git_url":"git://github.com/rticommunity/rticonnextdds-connector.git","ssh_url":"git@github.com:rticommunity/rticonnextdds-connector.git","clone_url":"https://github.com/rticommunity/rticonnextdds-connector.git","svn_url":"https://github.com/rticommunity/rticonnextdds-connector","homepage":"https://community.rti.com/downloads/experimental/rticonnextdds-connector","size":233827,"stargazers_count":16,"watchers_count":16,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":7,"forks":20,"open_issues":7,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50"},"html":{"href":"https://github.com/rticommunity/rticonnextdds-connector/pull/50"},"issue":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/issues/50"},"comments":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/rticommunity/rticonnextdds-connector/statuses/b00726970659069fb93073ca8afb3ee6c1e09002"}}}}
{"actor":{"display_login":"gianpiero"}}