{"action":"opened","issue":{"url":"https://api.github.com/repos/istio/istio/issues/220","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/220/comments","events_url":"https://api.github.com/repos/istio/istio/issues/220/events","html_url":"https://github.com/istio/istio/issues/220","id":227515758,"number":220,"title":"updateVersion problems","user":{"login":"frankbu","id":2752495,"avatar_url":"https://avatars1.githubusercontent.com/u/2752495?v=3","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-09T22:23:44Z","updated_at":"2017-05-09T22:23:44Z","closed_at":null,"body":"1. `updateVersion.sh -c` doesn't work\r\n\r\n2. `updateVersion.sh` has been moved out of the `tests` directory, but `tests/README.md` is still the doc for it.\r\n\r\n3. The generated comment in `istio.INSTALL` also refers to `tests/updateVersion.sh` and `tests/README.md`\r\n\r\nPR #209 fixes these problems, and also simplifies the design to remove the files in `install/kubernetes/templates` and instead just update istio.yaml and istio-auth.yaml in place. This is a necessary simplification IMO, since the current design is very confusing. When you call updateVersion.sh, it not only updates the expected files (istio.VERSION, istio.yaml, and istio-auth.yaml) but it also updates 8 other template files, so the resulting git commit has 10 updated files. The fact that there are 10, instead of just 2 yaml files in the install directory is also confusing. The small benefit of not needing to make the same update to 2 files when there are non-image changes, which is fairly rare, is not worth the complexity.\r\n\r\nIf, however, we don't want to merge #209 before alpha, the above 3 problems need to be fixed in the current version."}}
{"actor":{"display_login":"frankbu"}}