{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/140416282","pull_request_review_id":64487148,"id":140416282,"diff_hunk":"@@ -1523,7 +1523,7 @@ def disk_attach(vmdk_path, vm):\n         if kv_status_attached:\n             # KV  claims we are attached to a different VM'.\n             msg += \" disk {0} already attached to VM={1}\".format(vmdk_path,\n-                                                                 kv_uuid)\n+                                                                 vm_uuid2name(kv_uuid))","path":"esx_service/vmdk_ops.py","position":null,"original_position":5,"commit_id":"e1d6c4d62a220492ecbd85b1d0d046583b56e5b0","original_commit_id":"acfa3ca8eaf04eb4a0bc0490e639bd50710d42e8","user":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars1.githubusercontent.com/u/22988730?v=4","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"body":"@govint  by comparing the information mentioned at https://github.com/vmware/docker-volume-vsphere/issues/1702#issue-248217743 logs is improved and no more UUID and this time with correct vm name\r\n\r\nwithout the proposed change:\r\n```\r\ndocker: Error response from daemon: error while mounting volume '/var/lib/docker/plugins/07edacf1891edd3b20bd2a3cc91439b73cc449822d4df431b7c14bc5212c3cef/rootfs/mnt/vmdk/mark': VolumeDriver.Mount: Failed to add disk 'scsi1:0'. disk /vmfs/volumes/sp-sys-docker/dockvols/_DEFAULT/mark.vmdk already attached to VM=5010dd5f-26b8-3719-2032-f8a8432a106c.\r\n```\r\n\r\nAfter the proposed code change:\r\n\r\n```\r\ndocker: Error response from daemon: error while mounting volume '/var/lib/docker/plugins/43587bbd4e6a3bdf06089bcfc677e76167baa3859c701157b6be797991a6d425/rootfs': VolumeDriver.Mount: Failed to add disk scsi1:0. disk /vmfs/volumes/datastore1/dockvols/11111111-1111-1111-1111-111111111111/createME.vmdk already attached to VM=ubuntu.\r\n```","created_at":"2017-09-22T05:49:57Z","updated_at":"2017-09-22T05:49:57Z","html_url":"https://github.com/vmware/docker-volume-vsphere/pull/1890#discussion_r140416282","pull_request_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/140416282"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/1890#discussion_r140416282"},"pull_request":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890"}},"in_reply_to_id":140233647},"pull_request":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890","id":142020632,"html_url":"https://github.com/vmware/docker-volume-vsphere/pull/1890","diff_url":"https://github.com/vmware/docker-volume-vsphere/pull/1890.diff","patch_url":"https://github.com/vmware/docker-volume-vsphere/pull/1890.patch","issue_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1890","number":1890,"state":"open","locked":false,"title":"Improving error message to show VM name instead of VM UUID (#1702)","user":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars1.githubusercontent.com/u/22988730?v=4","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"body":"A trivial change to improve error message to show VM name instead of VM UUID (Fixes #1702)\r\n\r\nTested: Locally\r\n\r\nVIB is built correctly and deployed\r\n\r\n```\r\n=> Deploying to ESX root@10.20.105.97 Tue Sep 19 23:29:40 PDT 2017\r\n\r\n\r\nInstallation Result:\r\n   Message: Operation finished successfully.\r\n   Reboot Required: false\r\n   VIBs Installed: VMWare_bootbank_esx-vmdkops-service_0.17.547c9c4-0.0.1\r\n   VIBs Removed:\r\n   VIBs Skipped:\r\nwatchdog-hostd: Terminating watchdog process with PID 5345329\r\nhostd stopped.\r\nRamdisk 'hostd' with estimated size of 387MB already exists\r\nhostd started.\r\nvmdkops-opsd is running pid=6869722\r\n6869752\r\n```","created_at":"2017-09-20T06:38:35Z","updated_at":"2017-09-22T05:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0396fb7015c466d6754e7bf772359c2f3d87173","assignee":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars1.githubusercontent.com/u/22988730?v=4","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"assignees":[{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars1.githubusercontent.com/u/22988730?v=4","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890/commits","review_comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890/comments","review_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1890/comments","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/e1d6c4d62a220492ecbd85b1d0d046583b56e5b0","head":{"label":"shuklanirdesh82:vmUUID2NameErrMsg.shuklanirdesh82","ref":"vmUUID2NameErrMsg.shuklanirdesh82","sha":"e1d6c4d62a220492ecbd85b1d0d046583b56e5b0","user":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars1.githubusercontent.com/u/22988730?v=4","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"repo":{"id":72140364,"name":"docker-volume-vsphere","full_name":"shuklanirdesh82/docker-volume-vsphere","owner":{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars1.githubusercontent.com/u/22988730?v=4","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuklanirdesh82/docker-volume-vsphere","description":"Docker Volume Driver for vSphere.","fork":true,"url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere","forks_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/shuklanirdesh82/docker-volume-vsphere/deployments","created_at":"2016-10-27T19:18:41Z","updated_at":"2017-08-18T21:55:07Z","pushed_at":"2017-09-22T05:38:06Z","git_url":"git://github.com/shuklanirdesh82/docker-volume-vsphere.git","ssh_url":"git@github.com:shuklanirdesh82/docker-volume-vsphere.git","clone_url":"https://github.com/shuklanirdesh82/docker-volume-vsphere.git","svn_url":"https://github.com/shuklanirdesh82/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":16103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"547c9c40821c887704521115129098b0185ffd46","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49599693,"name":"docker-volume-vsphere","full_name":"vmware/docker-volume-vsphere","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/docker-volume-vsphere","description":"vSphere Docker Volume Service","fork":false,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere","forks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/deployments","created_at":"2016-01-13T20:25:36Z","updated_at":"2017-09-08T05:07:22Z","pushed_at":"2017-09-22T05:38:07Z","git_url":"git://github.com/vmware/docker-volume-vsphere.git","ssh_url":"git@github.com:vmware/docker-volume-vsphere.git","clone_url":"https://github.com/vmware/docker-volume-vsphere.git","svn_url":"https://github.com/vmware/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":21311,"stargazers_count":160,"watchers_count":160,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"open_issues_count":182,"forks":52,"open_issues":182,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/1890"},"issue":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1890"},"comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1890/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1890/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/e1d6c4d62a220492ecbd85b1d0d046583b56e5b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shuklanirdesh82"}}