{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/16401","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/16401/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16401/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/16401/events","html_url":"https://github.com/nodejs/node/pull/16401","id":267554671,"number":16401,"title":"lib: improve the usage of TypeError[INVALID_ARG_TYPE]","user":{"login":"starkwang","id":10933333,"avatar_url":"https://avatars0.githubusercontent.com/u/10933333?v=4","gravatar_id":"","url":"https://api.github.com/users/starkwang","html_url":"https://github.com/starkwang","followers_url":"https://api.github.com/users/starkwang/followers","following_url":"https://api.github.com/users/starkwang/following{/other_user}","gists_url":"https://api.github.com/users/starkwang/gists{/gist_id}","starred_url":"https://api.github.com/users/starkwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkwang/subscriptions","organizations_url":"https://api.github.com/users/starkwang/orgs","repos_url":"https://api.github.com/users/starkwang/repos","events_url":"https://api.github.com/users/starkwang/events{/privacy}","received_events_url":"https://api.github.com/users/starkwang/received_events","type":"User","site_admin":false},"labels":[{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"assignees":[{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2017-10-23T06:31:51Z","updated_at":"2017-11-12T07:07:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16401","html_url":"https://github.com/nodejs/node/pull/16401","diff_url":"https://github.com/nodejs/node/pull/16401.diff","patch_url":"https://github.com/nodejs/node/pull/16401.patch"},"body":"The initials of `expected` in `TypeError[ERR_INVALID_ARG_TYPE]` are inconsistent.\r\n\r\nThis PR is to:\r\n- Unify the initial usage of `TypeError[INVALID_ARG_TYPE]`\r\n- Add an argument check before construct an error\r\n- Revise some inappropriate usage of `INVALID_ARG_TYPE`\r\n\r\nFixes: https://github.com/nodejs/node/issues/16383\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nlib"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/343717979","html_url":"https://github.com/nodejs/node/pull/16401#issuecomment-343717979","issue_url":"https://api.github.com/repos/nodejs/node/issues/16401","id":343717979,"user":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"created_at":"2017-11-12T07:07:42Z","updated_at":"2017-11-12T07:07:42Z","author_association":"CONTRIBUTOR","body":"CI before landing: https://ci.nodejs.org/job/node-test-pull-request/11369/"}}
{"actor":{"display_login":"joyeecheung"}}