{"action":"created","issue":{"url":"https://api.github.com/repos/google/ci_edit/issues/91","repository_url":"https://api.github.com/repos/google/ci_edit","labels_url":"https://api.github.com/repos/google/ci_edit/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/google/ci_edit/issues/91/comments","events_url":"https://api.github.com/repos/google/ci_edit/issues/91/events","html_url":"https://github.com/google/ci_edit/pull/91","id":265667257,"number":91,"title":"Fix pasting from breaking the redo chain","user":{"login":"aaxu","id":19481525,"avatar_url":"https://avatars2.githubusercontent.com/u/19481525?v=4","gravatar_id":"","url":"https://api.github.com/users/aaxu","html_url":"https://github.com/aaxu","followers_url":"https://api.github.com/users/aaxu/followers","following_url":"https://api.github.com/users/aaxu/following{/other_user}","gists_url":"https://api.github.com/users/aaxu/gists{/gist_id}","starred_url":"https://api.github.com/users/aaxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaxu/subscriptions","organizations_url":"https://api.github.com/users/aaxu/orgs","repos_url":"https://api.github.com/users/aaxu/repos","events_url":"https://api.github.com/users/aaxu/events{/privacy}","received_events_url":"https://api.github.com/users/aaxu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-10-16T07:11:52Z","updated_at":"2017-10-18T17:08:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/google/ci_edit/pulls/91","html_url":"https://github.com/google/ci_edit/pull/91","diff_url":"https://github.com/google/ci_edit/pull/91.diff","patch_url":"https://github.com/google/ci_edit/pull/91.patch"},"body":"I think when you removed that line `len(self.redoChain) != self.redoIndex`, it might've caused this bug. The bug was caused because pasting consisted of an `insertLines` part and then a `cursorMove` part. However, I think removing that line caused the `cursorMove` part to become a `tempChange`. tempChange is not saved/restored in user history, so that sometimes caused an issue when reopening the file.\r\n\r\nI combined the `insertLines` and the `cursorMove` part into one `paste` change, so this should fix the bug.\r\nThere probably could have been other fixes like saving tempChange, but that would mean trivial actions would also get saved and I don't know if that would be useful or annoying. We could also probably redo the logic and keep the paste change as 2 separate parts, but I thought this would be cleaner."},"comment":{"url":"https://api.github.com/repos/google/ci_edit/issues/comments/337660269","html_url":"https://github.com/google/ci_edit/pull/91#issuecomment-337660269","issue_url":"https://api.github.com/repos/google/ci_edit/issues/91","id":337660269,"user":{"login":"dschuyler","id":13840539,"avatar_url":"https://avatars2.githubusercontent.com/u/13840539?v=4","gravatar_id":"","url":"https://api.github.com/users/dschuyler","html_url":"https://github.com/dschuyler","followers_url":"https://api.github.com/users/dschuyler/followers","following_url":"https://api.github.com/users/dschuyler/following{/other_user}","gists_url":"https://api.github.com/users/dschuyler/gists{/gist_id}","starred_url":"https://api.github.com/users/dschuyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschuyler/subscriptions","organizations_url":"https://api.github.com/users/dschuyler/orgs","repos_url":"https://api.github.com/users/dschuyler/repos","events_url":"https://api.github.com/users/dschuyler/events{/privacy}","received_events_url":"https://api.github.com/users/dschuyler/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T17:08:03Z","updated_at":"2017-10-18T17:08:03Z","author_association":"COLLABORATOR","body":"That sounds like it would work."}}
{"actor":{"display_login":"dschuyler"}}