{"action":"created","issue":{"url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/92","repository_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail","labels_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/92/comments","events_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/92/events","html_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/92","id":261915580,"number":92,"title":"fix encoding and decoding of attachment filenames","user":{"login":"MattSkala","id":1122874,"avatar_url":"https://avatars1.githubusercontent.com/u/1122874?v=4","gravatar_id":"","url":"https://api.github.com/users/MattSkala","html_url":"https://github.com/MattSkala","followers_url":"https://api.github.com/users/MattSkala/followers","following_url":"https://api.github.com/users/MattSkala/following{/other_user}","gists_url":"https://api.github.com/users/MattSkala/gists{/gist_id}","starred_url":"https://api.github.com/users/MattSkala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattSkala/subscriptions","organizations_url":"https://api.github.com/users/MattSkala/orgs","repos_url":"https://api.github.com/users/MattSkala/repos","events_url":"https://api.github.com/users/MattSkala/events{/privacy}","received_events_url":"https://api.github.com/users/MattSkala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-01T13:18:58Z","updated_at":"2017-10-07T04:31:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/pulls/92","html_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/92","diff_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/92.diff","patch_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/92.patch"},"body":"- I removed filename encoding, as it's something that nodemailer does automatically and it resulted in filename being encoded twice when sending attachments. Fixes #91.\r\n- When decoding filename of received attachment, we should use parseMimeWords function instead of decodeMimeWord, because longer names can be composed of multiple encoded-words. Fixes #41.\r\n- When filename is not present in Content-Disposition header, we can use name in Content-Type as a fallback. Fixes #10.\r\n- I also updated nodemailer to the latest version. There should not be any BC breaks except adjusted oauth smtp config."},"comment":{"url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/comments/334909738","html_url":"https://github.com/nylas-mail-lives/nylas-mail/pull/92#issuecomment-334909738","issue_url":"https://api.github.com/repos/nylas-mail-lives/nylas-mail/issues/92","id":334909738,"user":{"login":"dweremeichik","id":4079608,"avatar_url":"https://avatars0.githubusercontent.com/u/4079608?v=4","gravatar_id":"","url":"https://api.github.com/users/dweremeichik","html_url":"https://github.com/dweremeichik","followers_url":"https://api.github.com/users/dweremeichik/followers","following_url":"https://api.github.com/users/dweremeichik/following{/other_user}","gists_url":"https://api.github.com/users/dweremeichik/gists{/gist_id}","starred_url":"https://api.github.com/users/dweremeichik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweremeichik/subscriptions","organizations_url":"https://api.github.com/users/dweremeichik/orgs","repos_url":"https://api.github.com/users/dweremeichik/repos","events_url":"https://api.github.com/users/dweremeichik/events{/privacy}","received_events_url":"https://api.github.com/users/dweremeichik/received_events","type":"User","site_admin":false},"created_at":"2017-10-07T04:31:43Z","updated_at":"2017-10-07T04:31:43Z","author_association":"OWNER","body":"See the following commits for previous concerns:\r\nRollback: https://github.com/nylas-mail-lives/nylas-mail/commit/34d6505058a465f1b30c0b002c7fedbe7ca34c45\r\nUpgrade: https://github.com/nylas-mail-lives/nylas-mail/commit/e3e3cd20e54ec351442862a0d6af2a01467251a7\r\n\r\nIt appears that they did try to bump > 3.0 previously and ran into issues."}}
{"actor":{"display_login":"dweremeichik"}}