{"action":"created","issue":{"url":"https://api.github.com/repos/openscad/openscad/issues/2099","repository_url":"https://api.github.com/repos/openscad/openscad","labels_url":"https://api.github.com/repos/openscad/openscad/issues/2099/labels{/name}","comments_url":"https://api.github.com/repos/openscad/openscad/issues/2099/comments","events_url":"https://api.github.com/repos/openscad/openscad/issues/2099/events","html_url":"https://github.com/openscad/openscad/pull/2099","id":251810567,"number":2099,"title":"DPI Normalized Wireframe Rendering","user":{"login":"deckar01","id":3108007,"avatar_url":"https://avatars1.githubusercontent.com/u/3108007?v=4","gravatar_id":"","url":"https://api.github.com/users/deckar01","html_url":"https://github.com/deckar01","followers_url":"https://api.github.com/users/deckar01/followers","following_url":"https://api.github.com/users/deckar01/following{/other_user}","gists_url":"https://api.github.com/users/deckar01/gists{/gist_id}","starred_url":"https://api.github.com/users/deckar01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deckar01/subscriptions","organizations_url":"https://api.github.com/users/deckar01/orgs","repos_url":"https://api.github.com/users/deckar01/repos","events_url":"https://api.github.com/users/deckar01/events{/privacy}","received_events_url":"https://api.github.com/users/deckar01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-22T01:13:15Z","updated_at":"2017-08-22T04:26:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openscad/openscad/pulls/2099","html_url":"https://github.com/openscad/openscad/pull/2099","diff_url":"https://github.com/openscad/openscad/pull/2099.diff","patch_url":"https://github.com/openscad/openscad/pull/2099.patch"},"body":"Use the screen's DPI when calculating the line width and point size of wireframes.\r\n\r\nSee #2091 \r\n\r\nThis improves upon #2096 by passing the DPI from `MainWindow::qglview::getDPI()` to `CGALRenderer::setDPI()` to `Polyhedron::set_dpi()` to address the concerns raised in https://github.com/openscad/openscad/pull/2096#issuecomment-323648424.\r\n\r\nIn response to https://github.com/openscad/openscad/pull/2096#issuecomment-323868456 I opted to \"minimize how much we touch [OGL_helpers]\", because \"rewriting it completely\" seems disproportionate to the scope of the issue (and my familiarity with the code base :wink:).\r\n\r\n<details>\r\n<summary>1x DPI Wireframe</summary>\r\n\r\n![screen shot 2017-08-19 at 9 47 33 pm](https://user-images.githubusercontent.com/3108007/29491697-be1b1304-8528-11e7-8525-1d08acd0b8a3.png)\r\n\r\n\r\n> Note: The \"DPR\" value in this screenshot was for debugging and is not included in the PR.\r\n</details>\r\n\r\n<details>\r\n<summary>2x DPI Wireframe</summary>\r\n\r\n![screen shot 2017-08-19 at 9 47 33 pm](https://user-images.githubusercontent.com/3108007/29491696-b67d8ab4-8528-11e7-82e4-0580027c1a6b.png)\r\n\r\n\r\n> Note: The \"DPR\" value in this screenshot was for debugging and is not included in the PR.\r\n</details>"},"comment":{"url":"https://api.github.com/repos/openscad/openscad/issues/comments/323915826","html_url":"https://github.com/openscad/openscad/pull/2099#issuecomment-323915826","issue_url":"https://api.github.com/repos/openscad/openscad/issues/2099","id":323915826,"user":{"login":"kintel","id":186094,"avatar_url":"https://avatars2.githubusercontent.com/u/186094?v=4","gravatar_id":"","url":"https://api.github.com/users/kintel","html_url":"https://github.com/kintel","followers_url":"https://api.github.com/users/kintel/followers","following_url":"https://api.github.com/users/kintel/following{/other_user}","gists_url":"https://api.github.com/users/kintel/gists{/gist_id}","starred_url":"https://api.github.com/users/kintel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kintel/subscriptions","organizations_url":"https://api.github.com/users/kintel/orgs","repos_url":"https://api.github.com/users/kintel/repos","events_url":"https://api.github.com/users/kintel/events{/privacy}","received_events_url":"https://api.github.com/users/kintel/received_events","type":"User","site_admin":false},"created_at":"2017-08-22T04:26:14Z","updated_at":"2017-08-22T04:26:14Z","body":"Better :)\r\n\r\nTwo questions:\r\n* What should we do with offscreen-rendering? https://github.com/openscad/openscad/blob/master/src/export_png.cc#L32\r\n* How should we handle preview rendering with visible edges?\r\n\r\n"}}
{"actor":{"display_login":"kintel"}}