{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/157122658","pull_request_review_id":83714726,"id":157122658,"diff_hunk":"@@ -4358,7 +4358,8 @@ static int connect_to_master(THD* thd, MYSQL* mysql, Master_info* mi,\n     mysql_options(mysql, MYSQL_PLUGIN_DIR, opt_plugin_dir_ptr);\n \n   /* we disallow empty users */\n-  if (mi->user == NULL || mi->user[0] == 0)\n+  compile_time_assert(sizeof(mi->user)/sizeof(void*)>1);","path":"sql/slave.cc","position":16,"original_position":16,"commit_id":"d0613c6472c19004e6d5a9d8192ed95db3be1bbb","original_commit_id":"d0613c6472c19004e6d5a9d8192ed95db3be1bbb","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars3.githubusercontent.com/u/58894?v=4","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"body":"Likewise","created_at":"2017-12-15T04:37:26Z","updated_at":"2017-12-15T04:43:38Z","html_url":"https://github.com/percona/percona-server/pull/2022#discussion_r157122658","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/2022","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/157122658"},"html":{"href":"https://github.com/percona/percona-server/pull/2022#discussion_r157122658"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2022"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/2022","id":158342028,"html_url":"https://github.com/percona/percona-server/pull/2022","diff_url":"https://github.com/percona/percona-server/pull/2022.diff","patch_url":"https://github.com/percona/percona-server/pull/2022.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/2022","number":2022,"state":"open","locked":false,"title":"Fixed clang 4/5 warnings.","user":{"login":"dutow","id":489009,"avatar_url":"https://avatars3.githubusercontent.com/u/489009?v=4","gravatar_id":"","url":"https://api.github.com/users/dutow","html_url":"https://github.com/dutow","followers_url":"https://api.github.com/users/dutow/followers","following_url":"https://api.github.com/users/dutow/following{/other_user}","gists_url":"https://api.github.com/users/dutow/gists{/gist_id}","starred_url":"https://api.github.com/users/dutow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutow/subscriptions","organizations_url":"https://api.github.com/users/dutow/orgs","repos_url":"https://api.github.com/users/dutow/repos","events_url":"https://api.github.com/users/dutow/events{/privacy}","received_events_url":"https://api.github.com/users/dutow/received_events","type":"User","site_admin":false},"body":"* Removed unneccessary parantheses from conditions\r\n* Disabled the tautological constant out of range warning (static asserts would require c++11)\r\n* Fixed a const char* -> char* conversion\r\n* Restricted some GCC ifdefs: now they ignore clang (resulted in unsupported pragma warnings)\r\n* Changed null checks of arrays to compile time assertions that they are arrays\r\n* Added some explicit casts\r\n* Removed unused functions / variables\r\n* Marked functions which are only used in some configurations as possibly unused","created_at":"2017-12-14T12:15:27Z","updated_at":"2017-12-15T04:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69346944355e552d96b871f4b782884a767da00f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/2022/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/2022/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/2022/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/d0613c6472c19004e6d5a9d8192ed95db3be1bbb","head":{"label":"dutow:ps-55-clang-support","ref":"ps-55-clang-support","sha":"d0613c6472c19004e6d5a9d8192ed95db3be1bbb","user":{"login":"dutow","id":489009,"avatar_url":"https://avatars3.githubusercontent.com/u/489009?v=4","gravatar_id":"","url":"https://api.github.com/users/dutow","html_url":"https://github.com/dutow","followers_url":"https://api.github.com/users/dutow/followers","following_url":"https://api.github.com/users/dutow/following{/other_user}","gists_url":"https://api.github.com/users/dutow/gists{/gist_id}","starred_url":"https://api.github.com/users/dutow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutow/subscriptions","organizations_url":"https://api.github.com/users/dutow/orgs","repos_url":"https://api.github.com/users/dutow/repos","events_url":"https://api.github.com/users/dutow/events{/privacy}","received_events_url":"https://api.github.com/users/dutow/received_events","type":"User","site_admin":false},"repo":{"id":111694230,"name":"percona-server","full_name":"dutow/percona-server","owner":{"login":"dutow","id":489009,"avatar_url":"https://avatars3.githubusercontent.com/u/489009?v=4","gravatar_id":"","url":"https://api.github.com/users/dutow","html_url":"https://github.com/dutow","followers_url":"https://api.github.com/users/dutow/followers","following_url":"https://api.github.com/users/dutow/following{/other_user}","gists_url":"https://api.github.com/users/dutow/gists{/gist_id}","starred_url":"https://api.github.com/users/dutow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutow/subscriptions","organizations_url":"https://api.github.com/users/dutow/orgs","repos_url":"https://api.github.com/users/dutow/repos","events_url":"https://api.github.com/users/dutow/events{/privacy}","received_events_url":"https://api.github.com/users/dutow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dutow/percona-server","description":"Percona Server","fork":true,"url":"https://api.github.com/repos/dutow/percona-server","forks_url":"https://api.github.com/repos/dutow/percona-server/forks","keys_url":"https://api.github.com/repos/dutow/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dutow/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dutow/percona-server/teams","hooks_url":"https://api.github.com/repos/dutow/percona-server/hooks","issue_events_url":"https://api.github.com/repos/dutow/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/dutow/percona-server/events","assignees_url":"https://api.github.com/repos/dutow/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/dutow/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/dutow/percona-server/tags","blobs_url":"https://api.github.com/repos/dutow/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dutow/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dutow/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/dutow/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dutow/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/dutow/percona-server/languages","stargazers_url":"https://api.github.com/repos/dutow/percona-server/stargazers","contributors_url":"https://api.github.com/repos/dutow/percona-server/contributors","subscribers_url":"https://api.github.com/repos/dutow/percona-server/subscribers","subscription_url":"https://api.github.com/repos/dutow/percona-server/subscription","commits_url":"https://api.github.com/repos/dutow/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/dutow/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/dutow/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/dutow/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/dutow/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/dutow/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dutow/percona-server/merges","archive_url":"https://api.github.com/repos/dutow/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dutow/percona-server/downloads","issues_url":"https://api.github.com/repos/dutow/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/dutow/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/dutow/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/dutow/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dutow/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/dutow/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/dutow/percona-server/deployments","created_at":"2017-11-22T14:27:07Z","updated_at":"2017-11-22T14:28:36Z","pushed_at":"2017-12-14T12:02:44Z","git_url":"git://github.com/dutow/percona-server.git","ssh_url":"git@github.com:dutow/percona-server.git","clone_url":"https://github.com/dutow/percona-server.git","svn_url":"https://github.com/dutow/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":572233,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.5","ref":"5.5","sha":"a6098a6879613264ec9b933f547b353b1eae9bc5","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2017-12-05T07:35:24Z","pushed_at":"2017-12-14T23:57:00Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":573122,"stargazers_count":374,"watchers_count":374,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":49,"license":null,"forks":156,"open_issues":49,"watchers":374,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2022"},"html":{"href":"https://github.com/percona/percona-server/pull/2022"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/2022"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/2022/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2022/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2022/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/d0613c6472c19004e6d5a9d8192ed95db3be1bbb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laurynas-biveinis"}}