{"action":"created","issue":{"url":"https://api.github.com/repos/rize/UriTemplate/issues/10","repository_url":"https://api.github.com/repos/rize/UriTemplate","labels_url":"https://api.github.com/repos/rize/UriTemplate/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/rize/UriTemplate/issues/10/comments","events_url":"https://api.github.com/repos/rize/UriTemplate/issues/10/events","html_url":"https://github.com/rize/UriTemplate/pull/10","id":234029842,"number":10,"title":"allow trailing zero in extract while using strict mode","user":{"login":"copynpaste","id":2058825,"avatar_url":"https://avatars3.githubusercontent.com/u/2058825?v=3","gravatar_id":"","url":"https://api.github.com/users/copynpaste","html_url":"https://github.com/copynpaste","followers_url":"https://api.github.com/users/copynpaste/followers","following_url":"https://api.github.com/users/copynpaste/following{/other_user}","gists_url":"https://api.github.com/users/copynpaste/gists{/gist_id}","starred_url":"https://api.github.com/users/copynpaste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copynpaste/subscriptions","organizations_url":"https://api.github.com/users/copynpaste/orgs","repos_url":"https://api.github.com/users/copynpaste/repos","events_url":"https://api.github.com/users/copynpaste/events{/privacy}","received_events_url":"https://api.github.com/users/copynpaste/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-06T21:26:31Z","updated_at":"2017-06-14T04:16:53Z","closed_at":"2017-06-14T03:57:53Z","pull_request":{"url":"https://api.github.com/repos/rize/UriTemplate/pulls/10","html_url":"https://github.com/rize/UriTemplate/pull/10","diff_url":"https://github.com/rize/UriTemplate/pull/10.diff","patch_url":"https://github.com/rize/UriTemplate/pull/10.patch"},"body":"If we are in strict mode we can't have a trailing parameter with the value of _0_ using the extract method. This is because of [PHP string 0 == false](https://3v4l.org/qQkXC), which happens in the matching part. For this I added a testcase where you can see what I mean. I fixed it by using strlen instead of the plain 'is not' check.\r\n\r\nI think having a trailing zero param is not too common, I just ran in there while testing stuff, but it could be a feature blocker."},"comment":{"url":"https://api.github.com/repos/rize/UriTemplate/issues/comments/308315210","html_url":"https://github.com/rize/UriTemplate/pull/10#issuecomment-308315210","issue_url":"https://api.github.com/repos/rize/UriTemplate/issues/10","id":308315210,"user":{"login":"rezigned","id":562145,"avatar_url":"https://avatars1.githubusercontent.com/u/562145?v=3","gravatar_id":"","url":"https://api.github.com/users/rezigned","html_url":"https://github.com/rezigned","followers_url":"https://api.github.com/users/rezigned/followers","following_url":"https://api.github.com/users/rezigned/following{/other_user}","gists_url":"https://api.github.com/users/rezigned/gists{/gist_id}","starred_url":"https://api.github.com/users/rezigned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rezigned/subscriptions","organizations_url":"https://api.github.com/users/rezigned/orgs","repos_url":"https://api.github.com/users/rezigned/repos","events_url":"https://api.github.com/users/rezigned/events{/privacy}","received_events_url":"https://api.github.com/users/rezigned/received_events","type":"User","site_admin":false},"created_at":"2017-06-14T04:16:53Z","updated_at":"2017-06-14T04:16:53Z","body":"Merged :) Thank you"}}
{"actor":{"display_login":"rezigned"}}