{"action":"created","comment":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/119636176","pull_request_review_id":41534043,"id":119636176,"diff_hunk":"@@ -67,47 +60,61 @@ class KryoLazyDensityCoprocessor extends KryoLazyDensityService with Coprocessor\n   def getDensity(controller: RpcController,\n                  request: KryoLazyDensityProto.DensityRequest,\n                  done: RpcCallback[KryoLazyDensityProto.DensityResponse]): Unit = {\n-    var scanner : InternalScanner = null\n-    var filterList : FilterList = new FilterList()\n \n-    val response: DensityResponse = try {\n-      val options: Map[String, String] = deserializeOptions(request.getOptions.toByteArray)\n-      val sft = SimpleFeatureTypes.createType(\"input\", options(SFT_OPT))\n-      var scanList : List[Scan] = List()\n+    val options: Map[String, String] = deserializeOptions(request.getOptions.toByteArray)\n+    val sft = SimpleFeatureTypes.createType(\"input\", options(SFT_OPT))\n \n-      if (options.containsKey(SCAN_OPT)) {\n+    def aggregateResult(sf: SimpleFeature, result: DensityResult): Unit = writeGeom(sf, result)\n \n+    val response: DensityResponse = try {\n+\n+      val scanList: List[Scan] = if (options.containsKey(SCAN_OPT)) {\n         val decoded = org.apache.hadoop.hbase.util.Base64.decode(options(SCAN_OPT))\n         val clientScan = ClientProtos.Scan.parseFrom(decoded)\n-        val scan = ProtobufUtil.toScan(clientScan)\n-        scanList ::= scan\n-\n+        List(ProtobufUtil.toScan(clientScan))\n       } else {\n-        scanList ::= new Scan()\n+        List(new Scan())\n       }\n \n-      if (options.containsKey(FILTER_OPT)) {\n-        filterList = FilterList.parseFrom(Base64.decode(options(FILTER_OPT)))\n+      val filterList: FilterList = if (options.containsKey(FILTER_OPT)) {\n+        FilterList.parseFrom(Base64.decode(options(FILTER_OPT)))\n+      } else {\n+        new FilterList()\n       }\n \n       val serializer = new KryoFeatureSerializer(sft, SerializationOptions.withoutId)\n-      val densityResult: DensityResult = this.init(options, sft)\n+      val densityResult: DensityResult = initialize(options, sft)","path":"geomesa-hbase/geomesa-hbase-datastore/src/main/scala/org/locationtech/geomesa/hbase/coprocessor/KryoLazyDensityCoprocessor.scala","position":80,"original_position":80,"commit_id":"0a3ba85f1e2dc6afc4d18f8d643de59e5ac319dd","original_commit_id":"0a3ba85f1e2dc6afc4d18f8d643de59e5ac319dd","user":{"login":"elahrvivaz","id":7715322,"avatar_url":"https://avatars3.githubusercontent.com/u/7715322?v=3","gravatar_id":"","url":"https://api.github.com/users/elahrvivaz","html_url":"https://github.com/elahrvivaz","followers_url":"https://api.github.com/users/elahrvivaz/followers","following_url":"https://api.github.com/users/elahrvivaz/following{/other_user}","gists_url":"https://api.github.com/users/elahrvivaz/gists{/gist_id}","starred_url":"https://api.github.com/users/elahrvivaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elahrvivaz/subscriptions","organizations_url":"https://api.github.com/users/elahrvivaz/orgs","repos_url":"https://api.github.com/users/elahrvivaz/repos","events_url":"https://api.github.com/users/elahrvivaz/events{/privacy}","received_events_url":"https://api.github.com/users/elahrvivaz/received_events","type":"User","site_admin":false},"body":"think we need to instantiate a new KryoLazyDensityUtils to use here - and the main coprocessor class shouldn't extend it any more","created_at":"2017-06-01T14:51:47Z","updated_at":"2017-06-01T14:51:47Z","html_url":"https://github.com/locationtech/geomesa/pull/1545#discussion_r119636176","pull_request_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1545","_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/119636176"},"html":{"href":"https://github.com/locationtech/geomesa/pull/1545#discussion_r119636176"},"pull_request":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1545"}}},"pull_request":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/1545","id":123126299,"html_url":"https://github.com/locationtech/geomesa/pull/1545","diff_url":"https://github.com/locationtech/geomesa/pull/1545.diff","patch_url":"https://github.com/locationtech/geomesa/pull/1545.patch","issue_url":"https://api.github.com/repos/locationtech/geomesa/issues/1545","number":1545,"state":"open","locked":false,"title":"GEOMESA-1853 Allow for autoregistration of coprocessors on table crea…","user":{"login":"aheyne","id":20668140,"avatar_url":"https://avatars2.githubusercontent.com/u/20668140?v=3","gravatar_id":"","url":"https://api.github.com/users/aheyne","html_url":"https://github.com/aheyne","followers_url":"https://api.github.com/users/aheyne/followers","following_url":"https://api.github.com/users/aheyne/following{/other_user}","gists_url":"https://api.github.com/users/aheyne/gists{/gist_id}","starred_url":"https://api.github.com/users/aheyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheyne/subscriptions","organizations_url":"https://api.github.com/users/aheyne/orgs","repos_url":"https://api.github.com/users/aheyne/repos","events_url":"https://api.github.com/users/aheyne/events{/privacy}","received_events_url":"https://api.github.com/users/aheyne/received_events","type":"User","site_admin":false},"body":"…tion.\r\n\r\nAdded in ability to read coprocessor configurtaion from geomesa-site, system property, datastore param or classpath.\r\n\r\nSigned-off-by: Austin Heyne <aheyne@ccri.com>","created_at":"2017-05-30T19:34:33Z","updated_at":"2017-06-01T14:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6883526af71af7a6c654b42734b60dcebaf3841d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1545/commits","review_comments_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1545/comments","review_comment_url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/locationtech/geomesa/issues/1545/comments","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/0a3ba85f1e2dc6afc4d18f8d643de59e5ac319dd","head":{"label":"aheyne:fcr_hbase_distributed_runtime_deploy2","ref":"fcr_hbase_distributed_runtime_deploy2","sha":"0a3ba85f1e2dc6afc4d18f8d643de59e5ac319dd","user":{"login":"aheyne","id":20668140,"avatar_url":"https://avatars2.githubusercontent.com/u/20668140?v=3","gravatar_id":"","url":"https://api.github.com/users/aheyne","html_url":"https://github.com/aheyne","followers_url":"https://api.github.com/users/aheyne/followers","following_url":"https://api.github.com/users/aheyne/following{/other_user}","gists_url":"https://api.github.com/users/aheyne/gists{/gist_id}","starred_url":"https://api.github.com/users/aheyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheyne/subscriptions","organizations_url":"https://api.github.com/users/aheyne/orgs","repos_url":"https://api.github.com/users/aheyne/repos","events_url":"https://api.github.com/users/aheyne/events{/privacy}","received_events_url":"https://api.github.com/users/aheyne/received_events","type":"User","site_admin":false},"repo":{"id":64691348,"name":"geomesa","full_name":"aheyne/geomesa","owner":{"login":"aheyne","id":20668140,"avatar_url":"https://avatars2.githubusercontent.com/u/20668140?v=3","gravatar_id":"","url":"https://api.github.com/users/aheyne","html_url":"https://github.com/aheyne","followers_url":"https://api.github.com/users/aheyne/followers","following_url":"https://api.github.com/users/aheyne/following{/other_user}","gists_url":"https://api.github.com/users/aheyne/gists{/gist_id}","starred_url":"https://api.github.com/users/aheyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheyne/subscriptions","organizations_url":"https://api.github.com/users/aheyne/orgs","repos_url":"https://api.github.com/users/aheyne/repos","events_url":"https://api.github.com/users/aheyne/events{/privacy}","received_events_url":"https://api.github.com/users/aheyne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aheyne/geomesa","description":"GeoMesa is a suite of tools for working with big geo-spatial data in a distributed fashion.","fork":true,"url":"https://api.github.com/repos/aheyne/geomesa","forks_url":"https://api.github.com/repos/aheyne/geomesa/forks","keys_url":"https://api.github.com/repos/aheyne/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aheyne/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aheyne/geomesa/teams","hooks_url":"https://api.github.com/repos/aheyne/geomesa/hooks","issue_events_url":"https://api.github.com/repos/aheyne/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/aheyne/geomesa/events","assignees_url":"https://api.github.com/repos/aheyne/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/aheyne/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/aheyne/geomesa/tags","blobs_url":"https://api.github.com/repos/aheyne/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aheyne/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aheyne/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/aheyne/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aheyne/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/aheyne/geomesa/languages","stargazers_url":"https://api.github.com/repos/aheyne/geomesa/stargazers","contributors_url":"https://api.github.com/repos/aheyne/geomesa/contributors","subscribers_url":"https://api.github.com/repos/aheyne/geomesa/subscribers","subscription_url":"https://api.github.com/repos/aheyne/geomesa/subscription","commits_url":"https://api.github.com/repos/aheyne/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/aheyne/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/aheyne/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/aheyne/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/aheyne/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/aheyne/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aheyne/geomesa/merges","archive_url":"https://api.github.com/repos/aheyne/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aheyne/geomesa/downloads","issues_url":"https://api.github.com/repos/aheyne/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/aheyne/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/aheyne/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/aheyne/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aheyne/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/aheyne/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/aheyne/geomesa/deployments","created_at":"2016-08-01T18:27:18Z","updated_at":"2016-08-01T18:27:22Z","pushed_at":"2017-06-01T14:47:08Z","git_url":"git://github.com/aheyne/geomesa.git","ssh_url":"git@github.com:aheyne/geomesa.git","clone_url":"https://github.com/aheyne/geomesa.git","svn_url":"https://github.com/aheyne/geomesa","homepage":"https://www.locationtech.org/projects/technology.geomesa","size":42062,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"locationtech:master","ref":"master","sha":"e0089f95e49e2318bf9655ce7724f9f4a0bb2270","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars1.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":13226069,"name":"geomesa","full_name":"locationtech/geomesa","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars1.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geomesa","description":"GeoMesa is a suite of tools for working with big geo-spatial data in a distributed fashion.","fork":false,"url":"https://api.github.com/repos/locationtech/geomesa","forks_url":"https://api.github.com/repos/locationtech/geomesa/forks","keys_url":"https://api.github.com/repos/locationtech/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geomesa/teams","hooks_url":"https://api.github.com/repos/locationtech/geomesa/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geomesa/events","assignees_url":"https://api.github.com/repos/locationtech/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geomesa/tags","blobs_url":"https://api.github.com/repos/locationtech/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geomesa/languages","stargazers_url":"https://api.github.com/repos/locationtech/geomesa/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geomesa/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geomesa/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geomesa/subscription","commits_url":"https://api.github.com/repos/locationtech/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/locationtech/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geomesa/merges","archive_url":"https://api.github.com/repos/locationtech/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geomesa/downloads","issues_url":"https://api.github.com/repos/locationtech/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/locationtech/geomesa/deployments","created_at":"2013-09-30T20:13:46Z","updated_at":"2017-05-30T16:03:50Z","pushed_at":"2017-06-01T14:47:11Z","git_url":"git://github.com/locationtech/geomesa.git","ssh_url":"git@github.com:locationtech/geomesa.git","clone_url":"https://github.com/locationtech/geomesa.git","svn_url":"https://github.com/locationtech/geomesa","homepage":"https://www.locationtech.org/projects/technology.geomesa","size":41537,"stargazers_count":307,"watchers_count":307,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":10,"forks":142,"open_issues":10,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1545"},"html":{"href":"https://github.com/locationtech/geomesa/pull/1545"},"issue":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/1545"},"comments":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/1545/comments"},"review_comments":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1545/comments"},"review_comment":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1545/commits"},"statuses":{"href":"https://api.github.com/repos/locationtech/geomesa/statuses/0a3ba85f1e2dc6afc4d18f8d643de59e5ac319dd"}}}}
{"actor":{"display_login":"elahrvivaz"}}