{"action":"reopened","number":92,"pull_request":{"url":"https://api.github.com/repos/siimon/prom-client/pulls/92","id":113773501,"html_url":"https://github.com/siimon/prom-client/pull/92","diff_url":"https://github.com/siimon/prom-client/pull/92.diff","patch_url":"https://github.com/siimon/prom-client/pull/92.patch","issue_url":"https://api.github.com/repos/siimon/prom-client/issues/92","number":92,"state":"open","locked":false,"title":"Throw if there are duplicate default metric names","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars2.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"body":"See #86 \r\n\r\nThis currently errors out, because of what #86 is trying to fix. So merging first that then rebasing this should make it green.\r\n\r\nI never considered the case where the included metrics could clash when adding the throw...\r\nThis change makes the first run add all, and only on subsequent invocations of the function will it clean out the old metric","created_at":"2017-04-01T10:10:39Z","updated_at":"2017-04-03T21:09:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd3c4008d3791a3344520e1c874fae8f3023db64","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/siimon/prom-client/pulls/92/commits","review_comments_url":"https://api.github.com/repos/siimon/prom-client/pulls/92/comments","review_comment_url":"https://api.github.com/repos/siimon/prom-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/siimon/prom-client/issues/92/comments","statuses_url":"https://api.github.com/repos/siimon/prom-client/statuses/6a01ba5730a6be2ac57cef020b2d381f11bbe15f","head":{"label":"SimenB:throw-on-default-clashing-metrics","ref":"throw-on-default-clashing-metrics","sha":"6a01ba5730a6be2ac57cef020b2d381f11bbe15f","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars2.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"repo":{"id":67042129,"name":"prom-client","full_name":"SimenB/prom-client","owner":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars2.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimenB/prom-client","description":"Prometheus client for node.js","fork":true,"url":"https://api.github.com/repos/SimenB/prom-client","forks_url":"https://api.github.com/repos/SimenB/prom-client/forks","keys_url":"https://api.github.com/repos/SimenB/prom-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimenB/prom-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimenB/prom-client/teams","hooks_url":"https://api.github.com/repos/SimenB/prom-client/hooks","issue_events_url":"https://api.github.com/repos/SimenB/prom-client/issues/events{/number}","events_url":"https://api.github.com/repos/SimenB/prom-client/events","assignees_url":"https://api.github.com/repos/SimenB/prom-client/assignees{/user}","branches_url":"https://api.github.com/repos/SimenB/prom-client/branches{/branch}","tags_url":"https://api.github.com/repos/SimenB/prom-client/tags","blobs_url":"https://api.github.com/repos/SimenB/prom-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimenB/prom-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimenB/prom-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimenB/prom-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimenB/prom-client/statuses/{sha}","languages_url":"https://api.github.com/repos/SimenB/prom-client/languages","stargazers_url":"https://api.github.com/repos/SimenB/prom-client/stargazers","contributors_url":"https://api.github.com/repos/SimenB/prom-client/contributors","subscribers_url":"https://api.github.com/repos/SimenB/prom-client/subscribers","subscription_url":"https://api.github.com/repos/SimenB/prom-client/subscription","commits_url":"https://api.github.com/repos/SimenB/prom-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimenB/prom-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimenB/prom-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimenB/prom-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimenB/prom-client/contents/{+path}","compare_url":"https://api.github.com/repos/SimenB/prom-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimenB/prom-client/merges","archive_url":"https://api.github.com/repos/SimenB/prom-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimenB/prom-client/downloads","issues_url":"https://api.github.com/repos/SimenB/prom-client/issues{/number}","pulls_url":"https://api.github.com/repos/SimenB/prom-client/pulls{/number}","milestones_url":"https://api.github.com/repos/SimenB/prom-client/milestones{/number}","notifications_url":"https://api.github.com/repos/SimenB/prom-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimenB/prom-client/labels{/name}","releases_url":"https://api.github.com/repos/SimenB/prom-client/releases{/id}","deployments_url":"https://api.github.com/repos/SimenB/prom-client/deployments","created_at":"2016-08-31T13:55:53Z","updated_at":"2016-08-31T13:55:54Z","pushed_at":"2017-04-02T10:34:27Z","git_url":"git://github.com/SimenB/prom-client.git","ssh_url":"git@github.com:SimenB/prom-client.git","clone_url":"https://github.com/SimenB/prom-client.git","svn_url":"https://github.com/SimenB/prom-client","homepage":null,"size":688,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"siimon:master","ref":"master","sha":"582f03860033cd94de5435bb2ca86aabe740ed51","user":{"login":"siimon","id":566235,"avatar_url":"https://avatars2.githubusercontent.com/u/566235?v=3","gravatar_id":"","url":"https://api.github.com/users/siimon","html_url":"https://github.com/siimon","followers_url":"https://api.github.com/users/siimon/followers","following_url":"https://api.github.com/users/siimon/following{/other_user}","gists_url":"https://api.github.com/users/siimon/gists{/gist_id}","starred_url":"https://api.github.com/users/siimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siimon/subscriptions","organizations_url":"https://api.github.com/users/siimon/orgs","repos_url":"https://api.github.com/users/siimon/repos","events_url":"https://api.github.com/users/siimon/events{/privacy}","received_events_url":"https://api.github.com/users/siimon/received_events","type":"User","site_admin":false},"repo":{"id":46582024,"name":"prom-client","full_name":"siimon/prom-client","owner":{"login":"siimon","id":566235,"avatar_url":"https://avatars2.githubusercontent.com/u/566235?v=3","gravatar_id":"","url":"https://api.github.com/users/siimon","html_url":"https://github.com/siimon","followers_url":"https://api.github.com/users/siimon/followers","following_url":"https://api.github.com/users/siimon/following{/other_user}","gists_url":"https://api.github.com/users/siimon/gists{/gist_id}","starred_url":"https://api.github.com/users/siimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siimon/subscriptions","organizations_url":"https://api.github.com/users/siimon/orgs","repos_url":"https://api.github.com/users/siimon/repos","events_url":"https://api.github.com/users/siimon/events{/privacy}","received_events_url":"https://api.github.com/users/siimon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siimon/prom-client","description":"Prometheus client for node.js","fork":false,"url":"https://api.github.com/repos/siimon/prom-client","forks_url":"https://api.github.com/repos/siimon/prom-client/forks","keys_url":"https://api.github.com/repos/siimon/prom-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siimon/prom-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siimon/prom-client/teams","hooks_url":"https://api.github.com/repos/siimon/prom-client/hooks","issue_events_url":"https://api.github.com/repos/siimon/prom-client/issues/events{/number}","events_url":"https://api.github.com/repos/siimon/prom-client/events","assignees_url":"https://api.github.com/repos/siimon/prom-client/assignees{/user}","branches_url":"https://api.github.com/repos/siimon/prom-client/branches{/branch}","tags_url":"https://api.github.com/repos/siimon/prom-client/tags","blobs_url":"https://api.github.com/repos/siimon/prom-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siimon/prom-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siimon/prom-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/siimon/prom-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siimon/prom-client/statuses/{sha}","languages_url":"https://api.github.com/repos/siimon/prom-client/languages","stargazers_url":"https://api.github.com/repos/siimon/prom-client/stargazers","contributors_url":"https://api.github.com/repos/siimon/prom-client/contributors","subscribers_url":"https://api.github.com/repos/siimon/prom-client/subscribers","subscription_url":"https://api.github.com/repos/siimon/prom-client/subscription","commits_url":"https://api.github.com/repos/siimon/prom-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/siimon/prom-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/siimon/prom-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/siimon/prom-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/siimon/prom-client/contents/{+path}","compare_url":"https://api.github.com/repos/siimon/prom-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siimon/prom-client/merges","archive_url":"https://api.github.com/repos/siimon/prom-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siimon/prom-client/downloads","issues_url":"https://api.github.com/repos/siimon/prom-client/issues{/number}","pulls_url":"https://api.github.com/repos/siimon/prom-client/pulls{/number}","milestones_url":"https://api.github.com/repos/siimon/prom-client/milestones{/number}","notifications_url":"https://api.github.com/repos/siimon/prom-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siimon/prom-client/labels{/name}","releases_url":"https://api.github.com/repos/siimon/prom-client/releases{/id}","deployments_url":"https://api.github.com/repos/siimon/prom-client/deployments","created_at":"2015-11-20T19:23:13Z","updated_at":"2017-03-30T19:13:00Z","pushed_at":"2017-04-03T21:06:40Z","git_url":"git://github.com/siimon/prom-client.git","ssh_url":"git@github.com:siimon/prom-client.git","clone_url":"https://github.com/siimon/prom-client.git","svn_url":"https://github.com/siimon/prom-client","homepage":null,"size":687,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":5,"forks":28,"open_issues":5,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/siimon/prom-client/pulls/92"},"html":{"href":"https://github.com/siimon/prom-client/pull/92"},"issue":{"href":"https://api.github.com/repos/siimon/prom-client/issues/92"},"comments":{"href":"https://api.github.com/repos/siimon/prom-client/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/siimon/prom-client/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/siimon/prom-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/siimon/prom-client/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/siimon/prom-client/statuses/6a01ba5730a6be2ac57cef020b2d381f11bbe15f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":2,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"siimon"}}