{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments/95710806","pull_request_review_id":16275297,"id":95710806,"diff_hunk":"@@ -134,19 +128,55 @@ - (void)safariViewControllerLoginWithProvider:(NSString *)provider\n     });\n }\n \n+- (BOOL)initializePkceStateWithProvider:(NSString *)provider\n+                            urlScheme:(NSString *)urlScheme\n+                           parameters:(nullable NSDictionary *)parameters\n+                             animated:(BOOL)animated\n+                           completion:(nullable MSClientLoginBlock)completion\n+{\n+    // Fail if self.pkceState has already been initialized\n+    if (self.pkceState) {","path":"sdk/src/MSLoginSafariViewController.m","position":80,"original_position":80,"commit_id":"7b13a14a8dfc6e563f8dcbe613c16666347419eb","original_commit_id":"7b13a14a8dfc6e563f8dcbe613c16666347419eb","user":{"login":"shrishrirang","id":11167859,"avatar_url":"https://avatars.githubusercontent.com/u/11167859?v=3","gravatar_id":"","url":"https://api.github.com/users/shrishrirang","html_url":"https://github.com/shrishrirang","followers_url":"https://api.github.com/users/shrishrirang/followers","following_url":"https://api.github.com/users/shrishrirang/following{/other_user}","gists_url":"https://api.github.com/users/shrishrirang/gists{/gist_id}","starred_url":"https://api.github.com/users/shrishrirang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrishrirang/subscriptions","organizations_url":"https://api.github.com/users/shrishrirang/orgs","repos_url":"https://api.github.com/users/shrishrirang/repos","events_url":"https://api.github.com/users/shrishrirang/events{/privacy}","received_events_url":"https://api.github.com/users/shrishrirang/received_events","type":"User","site_admin":false},"body":">pkceState [](start = 13, length = 9)\r\n\r\nI have a related comment in resumeWithUrl. What if it is not handled. How we handle that might have some bearing on this implementation of synchronization. Let us talk about this after you decide about resumeWithUrl.","created_at":"2017-01-12T01:34:32Z","updated_at":"2017-01-12T01:34:32Z","html_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/122#discussion_r95710806","pull_request_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments/95710806"},"html":{"href":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/122#discussion_r95710806"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122","id":101170064,"html_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/122","diff_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/122.diff","patch_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/122.patch","issue_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/122","number":122,"state":"open","locked":false,"title":"Improvement of SafariViewController login flow","user":{"login":"dhei","id":4079255,"avatar_url":"https://avatars.githubusercontent.com/u/4079255?v=3","gravatar_id":"","url":"https://api.github.com/users/dhei","html_url":"https://github.com/dhei","followers_url":"https://api.github.com/users/dhei/followers","following_url":"https://api.github.com/users/dhei/following{/other_user}","gists_url":"https://api.github.com/users/dhei/gists{/gist_id}","starred_url":"https://api.github.com/users/dhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhei/subscriptions","organizations_url":"https://api.github.com/users/dhei/orgs","repos_url":"https://api.github.com/users/dhei/repos","events_url":"https://api.github.com/users/dhei/events{/privacy}","received_events_url":"https://api.github.com/users/dhei/received_events","type":"User","site_admin":false},"body":"- allow no more than one login at a time\r\n- improve login unit tests","created_at":"2017-01-11T23:41:33Z","updated_at":"2017-01-12T01:34:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b063b46359f8938f271bc74ee44f541450183f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/122/comments","statuses_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/statuses/7b13a14a8dfc6e563f8dcbe613c16666347419eb","head":{"label":"dhei:master","ref":"master","sha":"7b13a14a8dfc6e563f8dcbe613c16666347419eb","user":{"login":"dhei","id":4079255,"avatar_url":"https://avatars.githubusercontent.com/u/4079255?v=3","gravatar_id":"","url":"https://api.github.com/users/dhei","html_url":"https://github.com/dhei","followers_url":"https://api.github.com/users/dhei/followers","following_url":"https://api.github.com/users/dhei/following{/other_user}","gists_url":"https://api.github.com/users/dhei/gists{/gist_id}","starred_url":"https://api.github.com/users/dhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhei/subscriptions","organizations_url":"https://api.github.com/users/dhei/orgs","repos_url":"https://api.github.com/users/dhei/repos","events_url":"https://api.github.com/users/dhei/events{/privacy}","received_events_url":"https://api.github.com/users/dhei/received_events","type":"User","site_admin":false},"repo":{"id":52987285,"name":"azure-mobile-apps-ios-client","full_name":"dhei/azure-mobile-apps-ios-client","owner":{"login":"dhei","id":4079255,"avatar_url":"https://avatars.githubusercontent.com/u/4079255?v=3","gravatar_id":"","url":"https://api.github.com/users/dhei","html_url":"https://github.com/dhei","followers_url":"https://api.github.com/users/dhei/followers","following_url":"https://api.github.com/users/dhei/following{/other_user}","gists_url":"https://api.github.com/users/dhei/gists{/gist_id}","starred_url":"https://api.github.com/users/dhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhei/subscriptions","organizations_url":"https://api.github.com/users/dhei/orgs","repos_url":"https://api.github.com/users/dhei/repos","events_url":"https://api.github.com/users/dhei/events{/privacy}","received_events_url":"https://api.github.com/users/dhei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhei/azure-mobile-apps-ios-client","description":"iOS Client SDK for Azure Mobile Apps","fork":true,"url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client","forks_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/forks","keys_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/teams","hooks_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/hooks","issue_events_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/issues/events{/number}","events_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/events","assignees_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/assignees{/user}","branches_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/branches{/branch}","tags_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/tags","blobs_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/statuses/{sha}","languages_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/languages","stargazers_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/stargazers","contributors_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/contributors","subscribers_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/subscribers","subscription_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/subscription","commits_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/contents/{+path}","compare_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/merges","archive_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/downloads","issues_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/issues{/number}","pulls_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/pulls{/number}","milestones_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/milestones{/number}","notifications_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/labels{/name}","releases_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/releases{/id}","deployments_url":"https://api.github.com/repos/dhei/azure-mobile-apps-ios-client/deployments","created_at":"2016-03-02T18:44:27Z","updated_at":"2017-01-10T22:35:39Z","pushed_at":"2017-01-11T23:36:41Z","git_url":"git://github.com/dhei/azure-mobile-apps-ios-client.git","ssh_url":"git@github.com:dhei/azure-mobile-apps-ios-client.git","clone_url":"https://github.com/dhei/azure-mobile-apps-ios-client.git","svn_url":"https://github.com/dhei/azure-mobile-apps-ios-client","homepage":"","size":3504,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"8417b390aaa5fe56e7207195aa4dd49b00227d9d","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":45963582,"name":"azure-mobile-apps-ios-client","full_name":"Azure/azure-mobile-apps-ios-client","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-mobile-apps-ios-client","description":"iOS Client SDK for Azure Mobile Apps","fork":false,"url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client","forks_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/forks","keys_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/teams","hooks_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/events","assignees_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/tags","blobs_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/subscription","commits_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/merges","archive_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/downloads","issues_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/deployments","created_at":"2015-11-11T06:17:48Z","updated_at":"2017-01-11T01:48:09Z","pushed_at":"2017-01-11T23:41:33Z","git_url":"git://github.com/Azure/azure-mobile-apps-ios-client.git","ssh_url":"git@github.com:Azure/azure-mobile-apps-ios-client.git","clone_url":"https://github.com/Azure/azure-mobile-apps-ios-client.git","svn_url":"https://github.com/Azure/azure-mobile-apps-ios-client","homepage":null,"size":3494,"stargazers_count":22,"watchers_count":22,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":29,"forks":17,"open_issues":29,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122"},"html":{"href":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/122"},"issue":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/122"},"comments":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/statuses/7b13a14a8dfc6e563f8dcbe613c16666347419eb"}}}}
{"actor":{"display_login":"shrishrirang"}}