{"action":"created","issue":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1030","repository_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit","labels_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1030/labels{/name}","comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1030/comments","events_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1030/events","html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1030","id":233959113,"number":1030,"title":"Simpler support for differential serving, non-root-path deployments","user":{"login":"graynorton","id":32065,"avatar_url":"https://avatars0.githubusercontent.com/u/32065?v=3","gravatar_id":"","url":"https://api.github.com/users/graynorton","html_url":"https://github.com/graynorton","followers_url":"https://api.github.com/users/graynorton/followers","following_url":"https://api.github.com/users/graynorton/following{/other_user}","gists_url":"https://api.github.com/users/graynorton/gists{/gist_id}","starred_url":"https://api.github.com/users/graynorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graynorton/subscriptions","organizations_url":"https://api.github.com/users/graynorton/orgs","repos_url":"https://api.github.com/users/graynorton/repos","events_url":"https://api.github.com/users/graynorton/events{/privacy}","received_events_url":"https://api.github.com/users/graynorton/received_events","type":"User","site_admin":false},"labels":[{"id":284939210,"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/labels/cla:%20yes","name":"cla: yes","color":"00ff00","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-06-06T16:59:23Z","updated_at":"2017-06-07T18:44:04Z","closed_at":"2017-06-07T18:42:02Z","pull_request":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/1030","html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1030","diff_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1030.diff","patch_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1030.patch"},"body":"This PR, based on @arthurevans's comments on #1008, is a simpler implementation of support for differential serving and non-root-path deployments.\r\n\r\nThe key difference is that we set `Polymer.rootPath` to a server-relative path with a leading slash, instead of mimicking its \"natural\" form (a full URL). We default to `/`, which works for differential serving and for standard, single-build deployments from the server root. For non-root-path deployments, devs will manually edit it to specify the path from which they'll serve (e.g. `/my-app/`).\r\n\r\nThis eliminates the need for the computed `rootPattern` property, since that property was just massaging `rootPath` into the form that we're now using directly.\r\n\r\nAlso: added `url-space-regex` property to `<app-location>` to filter out URL changes not beneath the app's root path, so that the app's router won't hijack navigations attempting to move outside the app.\r\n\r\nWould still like to provide more detailed info in the README, but saving that for a separate PR.\r\n\r\nThis PR should supersede #1019.\r\n\r\ncc @jsilvermist"},"comment":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/comments/306888416","html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/1030#issuecomment-306888416","issue_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/1030","id":306888416,"user":{"login":"abdonrd","id":1007051,"avatar_url":"https://avatars2.githubusercontent.com/u/1007051?v=3","gravatar_id":"","url":"https://api.github.com/users/abdonrd","html_url":"https://github.com/abdonrd","followers_url":"https://api.github.com/users/abdonrd/followers","following_url":"https://api.github.com/users/abdonrd/following{/other_user}","gists_url":"https://api.github.com/users/abdonrd/gists{/gist_id}","starred_url":"https://api.github.com/users/abdonrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdonrd/subscriptions","organizations_url":"https://api.github.com/users/abdonrd/orgs","repos_url":"https://api.github.com/users/abdonrd/repos","events_url":"https://api.github.com/users/abdonrd/events{/privacy}","received_events_url":"https://api.github.com/users/abdonrd/received_events","type":"User","site_admin":false},"created_at":"2017-06-07T18:44:04Z","updated_at":"2017-06-07T18:44:04Z","body":"@graynorton do you want to send another PR to master? To get the relative paths working in the Polymer v1 version."}}
{"actor":{"display_login":"abdonrd"}}