{"action":"created","comment":{"url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments/122929504","pull_request_review_id":45084864,"id":122929504,"diff_hunk":"@@ -44,16 +45,20 @@ void MassSlices::algorithmB(float userPPM,int rtStep) {\n \tthis->_precursorPPM=userPPM;\n \n     int totalScans = 0,currentScans = 0;\n+\n+//Calculate the total number of scans\n     for(unsigned int i=0; i < samples.size(); i++) totalScans += samples[i]->scans.size();\n \n+//Calculating the rt window using average distance between rts and mutiplying it with 20\n     if (samples.size() > 0 and rtStep > 0) rtWindow = (samples[0]->getAverageFullScanTime()*rtStep);\n \n     sendSignal(\"Status\", 0 , 1);\n \n-// #pragma omp parallel for ordered","path":"libmaven/mzMassSlicer.cpp","position":29,"original_position":29,"commit_id":"e5ecd999723efe041c967b9c79dc5f6306963c56","original_commit_id":"e5ecd999723efe041c967b9c79dc5f6306963c56","user":{"login":"GeorgeSabu","id":22674403,"avatar_url":"https://avatars2.githubusercontent.com/u/22674403?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgeSabu","html_url":"https://github.com/GeorgeSabu","followers_url":"https://api.github.com/users/GeorgeSabu/followers","following_url":"https://api.github.com/users/GeorgeSabu/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSabu/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSabu/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSabu/orgs","repos_url":"https://api.github.com/users/GeorgeSabu/repos","events_url":"https://api.github.com/users/GeorgeSabu/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSabu/received_events","type":"User","site_admin":false},"body":"@Raghavdata Dont comment out this part. That part of the code is useful when we are parallel processing the things. Its just that we are not using it but it will be need in the future. So do not remove this line. And there are more entries like this re add those parts of the code too.  ","created_at":"2017-06-20T09:48:44Z","updated_at":"2017-06-20T09:55:55Z","html_url":"https://github.com/ElucidataInc/ElMaven/pull/263#discussion_r122929504","pull_request_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments/122929504"},"html":{"href":"https://github.com/ElucidataInc/ElMaven/pull/263#discussion_r122929504"},"pull_request":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263","id":126454349,"html_url":"https://github.com/ElucidataInc/ElMaven/pull/263","diff_url":"https://github.com/ElucidataInc/ElMaven/pull/263.diff","patch_url":"https://github.com/ElucidataInc/ElMaven/pull/263.patch","issue_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/263","number":263,"state":"open","locked":false,"title":"Documenting Mass slicing algorithmB used when no compound DB is given","user":{"login":"Raghavdata","id":16893466,"avatar_url":"https://avatars1.githubusercontent.com/u/16893466?v=3","gravatar_id":"","url":"https://api.github.com/users/Raghavdata","html_url":"https://github.com/Raghavdata","followers_url":"https://api.github.com/users/Raghavdata/followers","following_url":"https://api.github.com/users/Raghavdata/following{/other_user}","gists_url":"https://api.github.com/users/Raghavdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Raghavdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raghavdata/subscriptions","organizations_url":"https://api.github.com/users/Raghavdata/orgs","repos_url":"https://api.github.com/users/Raghavdata/repos","events_url":"https://api.github.com/users/Raghavdata/events{/privacy}","received_events_url":"https://api.github.com/users/Raghavdata/received_events","type":"User","site_admin":false},"body":"Mass slicing in the absence of a compound DB is not understood\r\ncompletely. This commit is an attempt to understand algorithmB\r\ncalled by processMassSlices in PeakDetector.cpp. The code workflow\r\ndiagram will also be available on the Github page of Maven.","created_at":"2017-06-20T06:14:59Z","updated_at":"2017-06-20T09:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f387002f1711ede1467e71ebec238e82d0cd115","assignee":{"login":"sahil21","id":21240516,"avatar_url":"https://avatars3.githubusercontent.com/u/21240516?v=3","gravatar_id":"","url":"https://api.github.com/users/sahil21","html_url":"https://github.com/sahil21","followers_url":"https://api.github.com/users/sahil21/followers","following_url":"https://api.github.com/users/sahil21/following{/other_user}","gists_url":"https://api.github.com/users/sahil21/gists{/gist_id}","starred_url":"https://api.github.com/users/sahil21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahil21/subscriptions","organizations_url":"https://api.github.com/users/sahil21/orgs","repos_url":"https://api.github.com/users/sahil21/repos","events_url":"https://api.github.com/users/sahil21/events{/privacy}","received_events_url":"https://api.github.com/users/sahil21/received_events","type":"User","site_admin":false},"assignees":[{"login":"sahil21","id":21240516,"avatar_url":"https://avatars3.githubusercontent.com/u/21240516?v=3","gravatar_id":"","url":"https://api.github.com/users/sahil21","html_url":"https://github.com/sahil21","followers_url":"https://api.github.com/users/sahil21/followers","following_url":"https://api.github.com/users/sahil21/following{/other_user}","gists_url":"https://api.github.com/users/sahil21/gists{/gist_id}","starred_url":"https://api.github.com/users/sahil21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahil21/subscriptions","organizations_url":"https://api.github.com/users/sahil21/orgs","repos_url":"https://api.github.com/users/sahil21/repos","events_url":"https://api.github.com/users/sahil21/events{/privacy}","received_events_url":"https://api.github.com/users/sahil21/received_events","type":"User","site_admin":false},{"login":"GeorgeSabu","id":22674403,"avatar_url":"https://avatars2.githubusercontent.com/u/22674403?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgeSabu","html_url":"https://github.com/GeorgeSabu","followers_url":"https://api.github.com/users/GeorgeSabu/followers","following_url":"https://api.github.com/users/GeorgeSabu/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSabu/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSabu/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSabu/orgs","repos_url":"https://api.github.com/users/GeorgeSabu/repos","events_url":"https://api.github.com/users/GeorgeSabu/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSabu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263/commits","review_comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263/comments","review_comment_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/263/comments","statuses_url":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/e5ecd999723efe041c967b9c79dc5f6306963c56","head":{"label":"ElucidataInc:doc_massSlicing","ref":"doc_massSlicing","sha":"e5ecd999723efe041c967b9c79dc5f6306963c56","user":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars1.githubusercontent.com/u/22674262?v=3","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":70220005,"name":"ElMaven","full_name":"ElucidataInc/ElMaven","owner":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars1.githubusercontent.com/u/22674262?v=3","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElucidataInc/ElMaven","description":"LC-MS data processing engine for large-scale metabolomic experiments.","fork":false,"url":"https://api.github.com/repos/ElucidataInc/ElMaven","forks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/forks","keys_url":"https://api.github.com/repos/ElucidataInc/ElMaven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElucidataInc/ElMaven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElucidataInc/ElMaven/teams","hooks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/hooks","issue_events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/events{/number}","events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/events","assignees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/assignees{/user}","branches_url":"https://api.github.com/repos/ElucidataInc/ElMaven/branches{/branch}","tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/tags","blobs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/{sha}","languages_url":"https://api.github.com/repos/ElucidataInc/ElMaven/languages","stargazers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/stargazers","contributors_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contributors","subscribers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscribers","subscription_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscription","commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contents/{+path}","compare_url":"https://api.github.com/repos/ElucidataInc/ElMaven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElucidataInc/ElMaven/merges","archive_url":"https://api.github.com/repos/ElucidataInc/ElMaven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElucidataInc/ElMaven/downloads","issues_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues{/number}","pulls_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls{/number}","milestones_url":"https://api.github.com/repos/ElucidataInc/ElMaven/milestones{/number}","notifications_url":"https://api.github.com/repos/ElucidataInc/ElMaven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElucidataInc/ElMaven/labels{/name}","releases_url":"https://api.github.com/repos/ElucidataInc/ElMaven/releases{/id}","deployments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/deployments","created_at":"2016-10-07T06:06:47Z","updated_at":"2017-06-19T07:25:47Z","pushed_at":"2017-06-20T09:45:41Z","git_url":"git://github.com/ElucidataInc/ElMaven.git","ssh_url":"git@github.com:ElucidataInc/ElMaven.git","clone_url":"https://github.com/ElucidataInc/ElMaven.git","svn_url":"https://github.com/ElucidataInc/ElMaven","homepage":"https://elucidatainc.github.io/ElMaven/","size":20622,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":119,"forks":3,"open_issues":119,"watchers":16,"default_branch":"develop"}},"base":{"label":"ElucidataInc:develop","ref":"develop","sha":"5c39b8fbe0957434963e05c195601c966ac5c5a4","user":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars1.githubusercontent.com/u/22674262?v=3","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":70220005,"name":"ElMaven","full_name":"ElucidataInc/ElMaven","owner":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars1.githubusercontent.com/u/22674262?v=3","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElucidataInc/ElMaven","description":"LC-MS data processing engine for large-scale metabolomic experiments.","fork":false,"url":"https://api.github.com/repos/ElucidataInc/ElMaven","forks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/forks","keys_url":"https://api.github.com/repos/ElucidataInc/ElMaven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElucidataInc/ElMaven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElucidataInc/ElMaven/teams","hooks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/hooks","issue_events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/events{/number}","events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/events","assignees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/assignees{/user}","branches_url":"https://api.github.com/repos/ElucidataInc/ElMaven/branches{/branch}","tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/tags","blobs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/{sha}","languages_url":"https://api.github.com/repos/ElucidataInc/ElMaven/languages","stargazers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/stargazers","contributors_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contributors","subscribers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscribers","subscription_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscription","commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contents/{+path}","compare_url":"https://api.github.com/repos/ElucidataInc/ElMaven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElucidataInc/ElMaven/merges","archive_url":"https://api.github.com/repos/ElucidataInc/ElMaven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElucidataInc/ElMaven/downloads","issues_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues{/number}","pulls_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls{/number}","milestones_url":"https://api.github.com/repos/ElucidataInc/ElMaven/milestones{/number}","notifications_url":"https://api.github.com/repos/ElucidataInc/ElMaven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElucidataInc/ElMaven/labels{/name}","releases_url":"https://api.github.com/repos/ElucidataInc/ElMaven/releases{/id}","deployments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/deployments","created_at":"2016-10-07T06:06:47Z","updated_at":"2017-06-19T07:25:47Z","pushed_at":"2017-06-20T09:45:41Z","git_url":"git://github.com/ElucidataInc/ElMaven.git","ssh_url":"git@github.com:ElucidataInc/ElMaven.git","clone_url":"https://github.com/ElucidataInc/ElMaven.git","svn_url":"https://github.com/ElucidataInc/ElMaven","homepage":"https://elucidatainc.github.io/ElMaven/","size":20622,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":119,"forks":3,"open_issues":119,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263"},"html":{"href":"https://github.com/ElucidataInc/ElMaven/pull/263"},"issue":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/263"},"comments":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/e5ecd999723efe041c967b9c79dc5f6306963c56"}}}}
{"actor":{"display_login":"GeorgeSabu"}}