{"action":"closed","issue":{"url":"https://api.github.com/repos/transloadit/jquery-sdk/issues/55","repository_url":"https://api.github.com/repos/transloadit/jquery-sdk","labels_url":"https://api.github.com/repos/transloadit/jquery-sdk/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/transloadit/jquery-sdk/issues/55/comments","events_url":"https://api.github.com/repos/transloadit/jquery-sdk/issues/55/events","html_url":"https://github.com/transloadit/jquery-sdk/issues/55","id":226303469,"number":55,"title":"V3: this._modal.renderCancelling() is still invoked when modal is set to false.","user":{"login":"rveitch","id":12876929,"avatar_url":"https://avatars2.githubusercontent.com/u/12876929?v=3","gravatar_id":"","url":"https://api.github.com/users/rveitch","html_url":"https://github.com/rveitch","followers_url":"https://api.github.com/users/rveitch/followers","following_url":"https://api.github.com/users/rveitch/following{/other_user}","gists_url":"https://api.github.com/users/rveitch/gists{/gist_id}","starred_url":"https://api.github.com/users/rveitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rveitch/subscriptions","organizations_url":"https://api.github.com/users/rveitch/orgs","repos_url":"https://api.github.com/users/rveitch/repos","events_url":"https://api.github.com/users/rveitch/events{/privacy}","received_events_url":"https://api.github.com/users/rveitch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-04T14:40:22Z","updated_at":"2017-05-04T14:51:11Z","closed_at":"2017-05-04T14:51:11Z","body":"We've encountered a breaking issue in v3 of the SDK that occurs when cancelling an upload if the `modal` parameter is set to `false` for custom progress rendering.  An error will be thrown by [`this._modal.renderCancelling()`](https://github.com/transloadit/jquery-sdk/blob/master/js/lib/jquery.transloadit.js#L571) as it is not wrapped in a conditional to prevent it from being invoked when modal is false, and the modal object will then be undefined.\r\n\r\nI've submitted PR #53 to resolve the issue, but until it is merged we'll need to continue using a forked custom build of the SDK with this hotfix included.\r\n\r\nThanks in advance!"}}
{"actor":{"display_login":"tim-kos"}}