{"action":"created","comment":{"url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/comments/114333629","pull_request_review_id":35790524,"id":114333629,"diff_hunk":"@@ -124,6 +126,7 @@ my %allservices = (\n \t\"zmconfigd\" => \"/opt/zimbra/bin/zmconfigdctl\",\n \t\"cbpolicyd\" => \"/opt/zimbra/bin/zmcbpolicydctl\",\n \t\"vmware-ha\" => \"/opt/zimbra/bin/zmhactl\",\n+\t\"imap\" => \"/opt/zimbra/bin/zmimapdctl\",","path":"src/bin/zmcontrol","position":22,"original_position":22,"commit_id":"393f4c55c8408fb006b2ce91a3c53c1ea55ab8e8","original_commit_id":"393f4c55c8408fb006b2ce91a3c53c1ea55ab8e8","user":{"login":"fatkudu","id":3739542,"avatar_url":"https://avatars3.githubusercontent.com/u/3739542?v=3","gravatar_id":"","url":"https://api.github.com/users/fatkudu","html_url":"https://github.com/fatkudu","followers_url":"https://api.github.com/users/fatkudu/followers","following_url":"https://api.github.com/users/fatkudu/following{/other_user}","gists_url":"https://api.github.com/users/fatkudu/gists{/gist_id}","starred_url":"https://api.github.com/users/fatkudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatkudu/subscriptions","organizations_url":"https://api.github.com/users/fatkudu/orgs","repos_url":"https://api.github.com/users/fatkudu/repos","events_url":"https://api.github.com/users/fatkudu/events{/privacy}","received_events_url":"https://api.github.com/users/fatkudu/received_events","type":"User","site_admin":false},"body":"s/\"imap\"/\"imapd\"/ ?","created_at":"2017-05-02T14:37:26Z","updated_at":"2017-05-02T14:42:36Z","html_url":"https://github.com/Zimbra/zm-core-utils/pull/1#discussion_r114333629","pull_request_url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/comments/114333629"},"html":{"href":"https://github.com/Zimbra/zm-core-utils/pull/1#discussion_r114333629"},"pull_request":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1","id":117983663,"html_url":"https://github.com/Zimbra/zm-core-utils/pull/1","diff_url":"https://github.com/Zimbra/zm-core-utils/pull/1.diff","patch_url":"https://github.com/Zimbra/zm-core-utils/pull/1.patch","issue_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/1","number":1,"state":"open","locked":false,"title":"feature/zms-38 updates","user":{"login":"gordyt","id":503635,"avatar_url":"https://avatars3.githubusercontent.com/u/503635?v=3","gravatar_id":"","url":"https://api.github.com/users/gordyt","html_url":"https://github.com/gordyt","followers_url":"https://api.github.com/users/gordyt/followers","following_url":"https://api.github.com/users/gordyt/following{/other_user}","gists_url":"https://api.github.com/users/gordyt/gists{/gist_id}","starred_url":"https://api.github.com/users/gordyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordyt/subscriptions","organizations_url":"https://api.github.com/users/gordyt/orgs","repos_url":"https://api.github.com/users/gordyt/repos","events_url":"https://api.github.com/users/gordyt/events{/privacy}","received_events_url":"https://api.github.com/users/gordyt/received_events","type":"User","site_admin":false},"body":"## zm-core-utils\r\n\r\n### zmimapdctl\r\n\r\nThis is the new bash script that is used to start and stop the _zimbra-imap_ service.\r\n\r\n#### TODO - JVM configuration\r\n\r\nThe script needs to be able to supply appropriate JVM configuration options.  I have sent out an email to the team to solicit some feedback.  My current idea is to add the following _localconfig_ options:\r\n\r\n* `imap_java_options`\r\n  * Include this but perhaps leave empty for now until we can do some testing.\r\n* `imap_java_heap_size`\r\n  * If installing on a node that is NOT running mailboxd, use same value as `mailboxd_java_heap_size`, else use some smaller value\r\n  * TODO - determine appropriate value\r\n  * TODO - should we adjust `mailboxd_java_heap_size` down if installing `zimbra-imap` on same node as `mailboxd`?\r\n* `imap_java_heap_new_size_percent`\r\n  * Same value as `mailboxd_java_heap_new_size_percent` (at least initially)\r\n\r\n#### TODO - Improved JVM startup monitoring\r\n\r\nCurrently the script is sleeping for 2 seconds after starting the _ImapDaemon_, via `nohup`, backgrounded.  So that call returns immediately.  The sleep allows some time to see if _ImapDaemon_ stated so that the appropriate exit code may be provided.\r\n\r\nLooking to see if there is a better way to do this than via a sleep.\r\n\r\n### zmcertmgr\r\n\r\nThe new IMAP servers look for a keystore at `/opt/zimbra/conf/keystore`.  Updates were made so that `deploycrt` creates the keystore.\r\n\r\n### zmcontrol\r\n\r\nAdded the new IMAP service so that it may be started and stopped via `zmcontrol`\r\n\r\nPlease also see related pull requests for:\r\n\r\n* `zm-zcs-lib`\r\n* `zm-nginx-lookup-store`\r\n* `zm-mailbox`\r\n* `zm-build`\r\n\r\n","created_at":"2017-04-27T16:47:16Z","updated_at":"2017-05-02T14:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cee88fe6380c095dec19349cf6cb15bfb734963","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/1/comments","statuses_url":"https://api.github.com/repos/Zimbra/zm-core-utils/statuses/393f4c55c8408fb006b2ce91a3c53c1ea55ab8e8","head":{"label":"Zimbra:feature/zms-38","ref":"feature/zms-38","sha":"393f4c55c8408fb006b2ce91a3c53c1ea55ab8e8","user":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars1.githubusercontent.com/u/8135764?v=3","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"repo":{"id":85609797,"name":"zm-core-utils","full_name":"Zimbra/zm-core-utils","owner":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars1.githubusercontent.com/u/8135764?v=3","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zimbra/zm-core-utils","description":"zm-core-utils for Zimbra Collaboration Suite, FOSS Edition","fork":false,"url":"https://api.github.com/repos/Zimbra/zm-core-utils","forks_url":"https://api.github.com/repos/Zimbra/zm-core-utils/forks","keys_url":"https://api.github.com/repos/Zimbra/zm-core-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zimbra/zm-core-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zimbra/zm-core-utils/teams","hooks_url":"https://api.github.com/repos/Zimbra/zm-core-utils/hooks","issue_events_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/events{/number}","events_url":"https://api.github.com/repos/Zimbra/zm-core-utils/events","assignees_url":"https://api.github.com/repos/Zimbra/zm-core-utils/assignees{/user}","branches_url":"https://api.github.com/repos/Zimbra/zm-core-utils/branches{/branch}","tags_url":"https://api.github.com/repos/Zimbra/zm-core-utils/tags","blobs_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zimbra/zm-core-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/Zimbra/zm-core-utils/languages","stargazers_url":"https://api.github.com/repos/Zimbra/zm-core-utils/stargazers","contributors_url":"https://api.github.com/repos/Zimbra/zm-core-utils/contributors","subscribers_url":"https://api.github.com/repos/Zimbra/zm-core-utils/subscribers","subscription_url":"https://api.github.com/repos/Zimbra/zm-core-utils/subscription","commits_url":"https://api.github.com/repos/Zimbra/zm-core-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zimbra/zm-core-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zimbra/zm-core-utils/contents/{+path}","compare_url":"https://api.github.com/repos/Zimbra/zm-core-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zimbra/zm-core-utils/merges","archive_url":"https://api.github.com/repos/Zimbra/zm-core-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zimbra/zm-core-utils/downloads","issues_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues{/number}","pulls_url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/Zimbra/zm-core-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/Zimbra/zm-core-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zimbra/zm-core-utils/labels{/name}","releases_url":"https://api.github.com/repos/Zimbra/zm-core-utils/releases{/id}","deployments_url":"https://api.github.com/repos/Zimbra/zm-core-utils/deployments","created_at":"2017-03-20T18:06:44Z","updated_at":"2017-03-24T14:35:54Z","pushed_at":"2017-05-01T19:38:19Z","git_url":"git://github.com/Zimbra/zm-core-utils.git","ssh_url":"git@github.com:Zimbra/zm-core-utils.git","clone_url":"https://github.com/Zimbra/zm-core-utils.git","svn_url":"https://github.com/Zimbra/zm-core-utils","homepage":null,"size":7840,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"Zimbra:feature/imap","ref":"feature/imap","sha":"e841cd4b6968793dd13a5e21bb26c3d7eef9c64c","user":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars1.githubusercontent.com/u/8135764?v=3","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"repo":{"id":85609797,"name":"zm-core-utils","full_name":"Zimbra/zm-core-utils","owner":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars1.githubusercontent.com/u/8135764?v=3","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zimbra/zm-core-utils","description":"zm-core-utils for Zimbra Collaboration Suite, FOSS Edition","fork":false,"url":"https://api.github.com/repos/Zimbra/zm-core-utils","forks_url":"https://api.github.com/repos/Zimbra/zm-core-utils/forks","keys_url":"https://api.github.com/repos/Zimbra/zm-core-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zimbra/zm-core-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zimbra/zm-core-utils/teams","hooks_url":"https://api.github.com/repos/Zimbra/zm-core-utils/hooks","issue_events_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/events{/number}","events_url":"https://api.github.com/repos/Zimbra/zm-core-utils/events","assignees_url":"https://api.github.com/repos/Zimbra/zm-core-utils/assignees{/user}","branches_url":"https://api.github.com/repos/Zimbra/zm-core-utils/branches{/branch}","tags_url":"https://api.github.com/repos/Zimbra/zm-core-utils/tags","blobs_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zimbra/zm-core-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/Zimbra/zm-core-utils/languages","stargazers_url":"https://api.github.com/repos/Zimbra/zm-core-utils/stargazers","contributors_url":"https://api.github.com/repos/Zimbra/zm-core-utils/contributors","subscribers_url":"https://api.github.com/repos/Zimbra/zm-core-utils/subscribers","subscription_url":"https://api.github.com/repos/Zimbra/zm-core-utils/subscription","commits_url":"https://api.github.com/repos/Zimbra/zm-core-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zimbra/zm-core-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zimbra/zm-core-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zimbra/zm-core-utils/contents/{+path}","compare_url":"https://api.github.com/repos/Zimbra/zm-core-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zimbra/zm-core-utils/merges","archive_url":"https://api.github.com/repos/Zimbra/zm-core-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zimbra/zm-core-utils/downloads","issues_url":"https://api.github.com/repos/Zimbra/zm-core-utils/issues{/number}","pulls_url":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/Zimbra/zm-core-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/Zimbra/zm-core-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zimbra/zm-core-utils/labels{/name}","releases_url":"https://api.github.com/repos/Zimbra/zm-core-utils/releases{/id}","deployments_url":"https://api.github.com/repos/Zimbra/zm-core-utils/deployments","created_at":"2017-03-20T18:06:44Z","updated_at":"2017-03-24T14:35:54Z","pushed_at":"2017-05-01T19:38:19Z","git_url":"git://github.com/Zimbra/zm-core-utils.git","ssh_url":"git@github.com:Zimbra/zm-core-utils.git","clone_url":"https://github.com/Zimbra/zm-core-utils.git","svn_url":"https://github.com/Zimbra/zm-core-utils","homepage":null,"size":7840,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1"},"html":{"href":"https://github.com/Zimbra/zm-core-utils/pull/1"},"issue":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/1"},"comments":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Zimbra/zm-core-utils/statuses/393f4c55c8408fb006b2ce91a3c53c1ea55ab8e8"}}}}
{"actor":{"display_login":"fatkudu"}}