{"action":"closed","number":340,"pull_request":{"url":"https://api.github.com/repos/twitter/secureheaders/pulls/340","id":130216684,"html_url":"https://github.com/twitter/secureheaders/pull/340","diff_url":"https://github.com/twitter/secureheaders/pull/340.diff","patch_url":"https://github.com/twitter/secureheaders/pull/340.patch","issue_url":"https://api.github.com/repos/twitter/secureheaders/issues/340","number":340,"state":"closed","locked":false,"title":"[4.x prep] Require a script-src, change default CSP","user":{"login":"oreoshake","id":448516,"avatar_url":"https://avatars2.githubusercontent.com/u/448516?v=4","gravatar_id":"","url":"https://api.github.com/users/oreoshake","html_url":"https://github.com/oreoshake","followers_url":"https://api.github.com/users/oreoshake/followers","following_url":"https://api.github.com/users/oreoshake/following{/other_user}","gists_url":"https://api.github.com/users/oreoshake/gists{/gist_id}","starred_url":"https://api.github.com/users/oreoshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oreoshake/subscriptions","organizations_url":"https://api.github.com/users/oreoshake/orgs","repos_url":"https://api.github.com/users/oreoshake/repos","events_url":"https://api.github.com/users/oreoshake/events{/privacy}","received_events_url":"https://api.github.com/users/oreoshake/received_events","type":"User","site_admin":true},"body":"This handles the first two items from https://github.com/twitter/secureheaders/issues/286\r\n\r\n> - Require `script-src` to be set. Missing `script-src`s inherit from `default-src`. In general `default-src` lists are far too permissive for something like `script-src`.\r\n> - Require `object-src` to be set. See ⬆️ \r\n\r\n/cc @stve @jacobbednarz\r\n\r\nCI isn't green yet, but it works on my machine","created_at":"2017-07-12T19:24:22Z","updated_at":"2017-07-18T19:42:09Z","closed_at":"2017-07-18T19:42:08Z","merged_at":"2017-07-18T19:42:08Z","merge_commit_sha":"b23ef8f840c948faa8ebb6c834a1922972ddee76","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/secureheaders/pulls/340/commits","review_comments_url":"https://api.github.com/repos/twitter/secureheaders/pulls/340/comments","review_comment_url":"https://api.github.com/repos/twitter/secureheaders/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/secureheaders/issues/340/comments","statuses_url":"https://api.github.com/repos/twitter/secureheaders/statuses/17a1677993aab1d057c8a8da61ddd5bf3c69e8e0","head":{"label":"twitter:default-csp","ref":"default-csp","sha":"17a1677993aab1d057c8a8da61ddd5bf3c69e8e0","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":7122663,"name":"secureheaders","full_name":"twitter/secureheaders","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/secureheaders","description":"Manages application of security headers with many safe defaults","fork":false,"url":"https://api.github.com/repos/twitter/secureheaders","forks_url":"https://api.github.com/repos/twitter/secureheaders/forks","keys_url":"https://api.github.com/repos/twitter/secureheaders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/secureheaders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/secureheaders/teams","hooks_url":"https://api.github.com/repos/twitter/secureheaders/hooks","issue_events_url":"https://api.github.com/repos/twitter/secureheaders/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/secureheaders/events","assignees_url":"https://api.github.com/repos/twitter/secureheaders/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/secureheaders/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/secureheaders/tags","blobs_url":"https://api.github.com/repos/twitter/secureheaders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/secureheaders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/secureheaders/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/secureheaders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/secureheaders/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/secureheaders/languages","stargazers_url":"https://api.github.com/repos/twitter/secureheaders/stargazers","contributors_url":"https://api.github.com/repos/twitter/secureheaders/contributors","subscribers_url":"https://api.github.com/repos/twitter/secureheaders/subscribers","subscription_url":"https://api.github.com/repos/twitter/secureheaders/subscription","commits_url":"https://api.github.com/repos/twitter/secureheaders/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/secureheaders/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/secureheaders/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/secureheaders/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/secureheaders/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/secureheaders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/secureheaders/merges","archive_url":"https://api.github.com/repos/twitter/secureheaders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/secureheaders/downloads","issues_url":"https://api.github.com/repos/twitter/secureheaders/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/secureheaders/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/secureheaders/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/secureheaders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/secureheaders/labels{/name}","releases_url":"https://api.github.com/repos/twitter/secureheaders/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/secureheaders/deployments","created_at":"2012-12-12T01:41:57Z","updated_at":"2017-07-18T00:50:50Z","pushed_at":"2017-07-18T19:42:08Z","git_url":"git://github.com/twitter/secureheaders.git","ssh_url":"git@github.com:twitter/secureheaders.git","clone_url":"https://github.com/twitter/secureheaders.git","svn_url":"https://github.com/twitter/secureheaders","homepage":"","size":1158,"stargazers_count":2269,"watchers_count":2269,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":158,"mirror_url":null,"open_issues_count":21,"forks":158,"open_issues":21,"watchers":2269,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"30d0582e3a89a81c0b91012781d30e6b7483d15b","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":7122663,"name":"secureheaders","full_name":"twitter/secureheaders","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/secureheaders","description":"Manages application of security headers with many safe defaults","fork":false,"url":"https://api.github.com/repos/twitter/secureheaders","forks_url":"https://api.github.com/repos/twitter/secureheaders/forks","keys_url":"https://api.github.com/repos/twitter/secureheaders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/secureheaders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/secureheaders/teams","hooks_url":"https://api.github.com/repos/twitter/secureheaders/hooks","issue_events_url":"https://api.github.com/repos/twitter/secureheaders/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/secureheaders/events","assignees_url":"https://api.github.com/repos/twitter/secureheaders/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/secureheaders/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/secureheaders/tags","blobs_url":"https://api.github.com/repos/twitter/secureheaders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/secureheaders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/secureheaders/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/secureheaders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/secureheaders/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/secureheaders/languages","stargazers_url":"https://api.github.com/repos/twitter/secureheaders/stargazers","contributors_url":"https://api.github.com/repos/twitter/secureheaders/contributors","subscribers_url":"https://api.github.com/repos/twitter/secureheaders/subscribers","subscription_url":"https://api.github.com/repos/twitter/secureheaders/subscription","commits_url":"https://api.github.com/repos/twitter/secureheaders/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/secureheaders/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/secureheaders/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/secureheaders/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/secureheaders/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/secureheaders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/secureheaders/merges","archive_url":"https://api.github.com/repos/twitter/secureheaders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/secureheaders/downloads","issues_url":"https://api.github.com/repos/twitter/secureheaders/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/secureheaders/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/secureheaders/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/secureheaders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/secureheaders/labels{/name}","releases_url":"https://api.github.com/repos/twitter/secureheaders/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/secureheaders/deployments","created_at":"2012-12-12T01:41:57Z","updated_at":"2017-07-18T00:50:50Z","pushed_at":"2017-07-18T19:42:08Z","git_url":"git://github.com/twitter/secureheaders.git","ssh_url":"git@github.com:twitter/secureheaders.git","clone_url":"https://github.com/twitter/secureheaders.git","svn_url":"https://github.com/twitter/secureheaders","homepage":"","size":1158,"stargazers_count":2269,"watchers_count":2269,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":158,"mirror_url":null,"open_issues_count":21,"forks":158,"open_issues":21,"watchers":2269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/340"},"html":{"href":"https://github.com/twitter/secureheaders/pull/340"},"issue":{"href":"https://api.github.com/repos/twitter/secureheaders/issues/340"},"comments":{"href":"https://api.github.com/repos/twitter/secureheaders/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/secureheaders/statuses/17a1677993aab1d057c8a8da61ddd5bf3c69e8e0"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"oreoshake","id":448516,"avatar_url":"https://avatars2.githubusercontent.com/u/448516?v=4","gravatar_id":"","url":"https://api.github.com/users/oreoshake","html_url":"https://github.com/oreoshake","followers_url":"https://api.github.com/users/oreoshake/followers","following_url":"https://api.github.com/users/oreoshake/following{/other_user}","gists_url":"https://api.github.com/users/oreoshake/gists{/gist_id}","starred_url":"https://api.github.com/users/oreoshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oreoshake/subscriptions","organizations_url":"https://api.github.com/users/oreoshake/orgs","repos_url":"https://api.github.com/users/oreoshake/repos","events_url":"https://api.github.com/users/oreoshake/events{/privacy}","received_events_url":"https://api.github.com/users/oreoshake/received_events","type":"User","site_admin":true},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":100,"deletions":55,"changed_files":8}}
{"actor":{"display_login":"oreoshake"}}