{"action":"created","comment":{"url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/comments/106298706","pull_request_review_id":27212854,"id":106298706,"diff_hunk":"@@ -0,0 +1,58 @@\n+# --------------------------------------------------------------------------------------------\n+# Copyright (c) Microsoft Corporation. All rights reserved.\n+# Licensed under the MIT License. See License.txt in the project root for license information.\n+# --------------------------------------------------------------------------------------------\n+\n+import json\n+from azure.cli.command_modules.lab.validators import (validate_authentication_type, validate_image_argument,\n+                                                      validate_network_parameters, validate_location)\n+\n+from ._util import ParametersContext\n+\n+\n+with ParametersContext(command='lab vm create') as c:\n+    c.register_alias('resource_group', ('--resource-group', '-g'))\n+\n+    # Authentication related arguments\n+    authentication_group_name = 'Authentication'\n+    c.argument('admin_username', arg_group=authentication_group_name)\n+    c.argument('admin_password', arg_group=authentication_group_name)\n+    c.argument('authentication_type', arg_group=authentication_group_name, validator=validate_authentication_type)\n+    c.argument('ssh_key', arg_group=authentication_group_name)\n+    c.argument('generate_ssh_keys', action='store_true', arg_group=authentication_group_name)\n+    c.ignore('is_authentication_with_ssh_key')\n+    c.ignore('user_name')\n+    c.ignore('password')\n+\n+    # Add Artifacts from json object\n+    c.register('artifacts', ('--artifacts',), type=json.loads)","path":"src/command_modules/azure-cli-lab/azure/cli/command_modules/lab/params.py","position":28,"original_position":28,"commit_id":"74636a9e19568f4fbd2026978eee1b0475dc15ee","original_commit_id":"0fd3cbd1fd2b7770ab18ef453caa83f9ab3a7c51","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars1.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"You don't need to specify the options list if it is the same as the dest (which this definitely is).","created_at":"2017-03-15T22:27:41Z","updated_at":"2017-03-15T22:40:32Z","html_url":"https://github.com/vishrutshah/azure-cli/pull/7#discussion_r106298706","pull_request_url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/comments/106298706"},"html":{"href":"https://github.com/vishrutshah/azure-cli/pull/7#discussion_r106298706"},"pull_request":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7","id":110952457,"html_url":"https://github.com/vishrutshah/azure-cli/pull/7","diff_url":"https://github.com/vishrutshah/azure-cli/pull/7.diff","patch_url":"https://github.com/vishrutshah/azure-cli/pull/7.patch","issue_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues/7","number":7,"state":"open","locked":false,"title":"Adding Azure DevTest Lab command module in CLI","user":{"login":"vishrutshah","id":8782776,"avatar_url":"https://avatars3.githubusercontent.com/u/8782776?v=3","gravatar_id":"","url":"https://api.github.com/users/vishrutshah","html_url":"https://github.com/vishrutshah","followers_url":"https://api.github.com/users/vishrutshah/followers","following_url":"https://api.github.com/users/vishrutshah/following{/other_user}","gists_url":"https://api.github.com/users/vishrutshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vishrutshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishrutshah/subscriptions","organizations_url":"https://api.github.com/users/vishrutshah/orgs","repos_url":"https://api.github.com/users/vishrutshah/repos","events_url":"https://api.github.com/users/vishrutshah/events{/privacy}","received_events_url":"https://api.github.com/users/vishrutshah/received_events","type":"User","site_admin":false},"body":"Following scenarios is being incorporated in this PR:\r\n\r\n**Azure DevTest Lab's Virtual Machine**\r\n- [ ] Create a VM from a marketplace image `az lab vm create -h`\r\n- [ ] Create a VM from a custom image already in the Lab  `az lab vm create -h`\r\n- [ ] List all VMs `az lab vm list -h`\r\n- [ ] List my all VMs `az lab vm list --lab-name {} -g {} --my-vms`\r\n- [ ] List my claimable VMs `az lab vm list --lab-name {} -g {} --my-claimable-vms`\r\n- [ ] Start a VM `az lab vm start -h`\r\n- [ ] Stop a VM `az lab vm stop -h`\r\n\r\n**Azure DevTest Lab's Artifacts**\r\n- [ ] List artifacts `az lab artifact list -h`\r\n\r\n**Azure DevTest Lab's Gallery Image**\r\n- [ ] List gallery images of the lab `az lab gallery-image list -h`\r\n\r\n**Azure DevTest Lab's Custom Image**\r\n- [ ] List custom image of the lab `az lab custom-image list -h`\r\n\r\n**Azure DevTest Lab's Virtual Network**\r\n- [ ] List virtual networks of the lab `az lab vnet list -h`\r\n- [ ] Get virtual network of the lab `az lab vnet get -h`\r\n\r\n@ericame @troydai @yugangw-msft @tjprescott @derekbekoe Please review the PR when you get a chance. Thanks!\r\n\r\n","created_at":"2017-03-15T22:04:05Z","updated_at":"2017-03-15T22:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"811740eb5fab3b477a07809fb67f1553bc4b510a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7/commits","review_comments_url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7/comments","review_comment_url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues/7/comments","statuses_url":"https://api.github.com/repos/vishrutshah/azure-cli/statuses/74636a9e19568f4fbd2026978eee1b0475dc15ee","head":{"label":"vishrutshah:devtestlab-preview-pr","ref":"devtestlab-preview-pr","sha":"74636a9e19568f4fbd2026978eee1b0475dc15ee","user":{"login":"vishrutshah","id":8782776,"avatar_url":"https://avatars3.githubusercontent.com/u/8782776?v=3","gravatar_id":"","url":"https://api.github.com/users/vishrutshah","html_url":"https://github.com/vishrutshah","followers_url":"https://api.github.com/users/vishrutshah/followers","following_url":"https://api.github.com/users/vishrutshah/following{/other_user}","gists_url":"https://api.github.com/users/vishrutshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vishrutshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishrutshah/subscriptions","organizations_url":"https://api.github.com/users/vishrutshah/orgs","repos_url":"https://api.github.com/users/vishrutshah/repos","events_url":"https://api.github.com/users/vishrutshah/events{/privacy}","received_events_url":"https://api.github.com/users/vishrutshah/received_events","type":"User","site_admin":false},"repo":{"id":77966922,"name":"azure-cli","full_name":"vishrutshah/azure-cli","owner":{"login":"vishrutshah","id":8782776,"avatar_url":"https://avatars3.githubusercontent.com/u/8782776?v=3","gravatar_id":"","url":"https://api.github.com/users/vishrutshah","html_url":"https://github.com/vishrutshah","followers_url":"https://api.github.com/users/vishrutshah/followers","following_url":"https://api.github.com/users/vishrutshah/following{/other_user}","gists_url":"https://api.github.com/users/vishrutshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vishrutshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishrutshah/subscriptions","organizations_url":"https://api.github.com/users/vishrutshah/orgs","repos_url":"https://api.github.com/users/vishrutshah/repos","events_url":"https://api.github.com/users/vishrutshah/events{/privacy}","received_events_url":"https://api.github.com/users/vishrutshah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vishrutshah/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/vishrutshah/azure-cli","forks_url":"https://api.github.com/repos/vishrutshah/azure-cli/forks","keys_url":"https://api.github.com/repos/vishrutshah/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vishrutshah/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vishrutshah/azure-cli/teams","hooks_url":"https://api.github.com/repos/vishrutshah/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/vishrutshah/azure-cli/events","assignees_url":"https://api.github.com/repos/vishrutshah/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/vishrutshah/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/vishrutshah/azure-cli/tags","blobs_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vishrutshah/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/vishrutshah/azure-cli/languages","stargazers_url":"https://api.github.com/repos/vishrutshah/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/vishrutshah/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/vishrutshah/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/vishrutshah/azure-cli/subscription","commits_url":"https://api.github.com/repos/vishrutshah/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/vishrutshah/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/vishrutshah/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/vishrutshah/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vishrutshah/azure-cli/merges","archive_url":"https://api.github.com/repos/vishrutshah/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vishrutshah/azure-cli/downloads","issues_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/vishrutshah/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/vishrutshah/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vishrutshah/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/vishrutshah/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/vishrutshah/azure-cli/deployments","created_at":"2017-01-04T01:05:40Z","updated_at":"2017-01-04T01:05:46Z","pushed_at":"2017-03-15T22:20:08Z","git_url":"git://github.com/vishrutshah/azure-cli.git","ssh_url":"git@github.com:vishrutshah/azure-cli.git","clone_url":"https://github.com/vishrutshah/azure-cli.git","svn_url":"https://github.com/vishrutshah/azure-cli","homepage":null,"size":16390,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vishrutshah:devtestlab-preview","ref":"devtestlab-preview","sha":"96fd150a68b6f81444df6c6aa0f1e8bd4e9874e1","user":{"login":"vishrutshah","id":8782776,"avatar_url":"https://avatars3.githubusercontent.com/u/8782776?v=3","gravatar_id":"","url":"https://api.github.com/users/vishrutshah","html_url":"https://github.com/vishrutshah","followers_url":"https://api.github.com/users/vishrutshah/followers","following_url":"https://api.github.com/users/vishrutshah/following{/other_user}","gists_url":"https://api.github.com/users/vishrutshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vishrutshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishrutshah/subscriptions","organizations_url":"https://api.github.com/users/vishrutshah/orgs","repos_url":"https://api.github.com/users/vishrutshah/repos","events_url":"https://api.github.com/users/vishrutshah/events{/privacy}","received_events_url":"https://api.github.com/users/vishrutshah/received_events","type":"User","site_admin":false},"repo":{"id":77966922,"name":"azure-cli","full_name":"vishrutshah/azure-cli","owner":{"login":"vishrutshah","id":8782776,"avatar_url":"https://avatars3.githubusercontent.com/u/8782776?v=3","gravatar_id":"","url":"https://api.github.com/users/vishrutshah","html_url":"https://github.com/vishrutshah","followers_url":"https://api.github.com/users/vishrutshah/followers","following_url":"https://api.github.com/users/vishrutshah/following{/other_user}","gists_url":"https://api.github.com/users/vishrutshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vishrutshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishrutshah/subscriptions","organizations_url":"https://api.github.com/users/vishrutshah/orgs","repos_url":"https://api.github.com/users/vishrutshah/repos","events_url":"https://api.github.com/users/vishrutshah/events{/privacy}","received_events_url":"https://api.github.com/users/vishrutshah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vishrutshah/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/vishrutshah/azure-cli","forks_url":"https://api.github.com/repos/vishrutshah/azure-cli/forks","keys_url":"https://api.github.com/repos/vishrutshah/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vishrutshah/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vishrutshah/azure-cli/teams","hooks_url":"https://api.github.com/repos/vishrutshah/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/vishrutshah/azure-cli/events","assignees_url":"https://api.github.com/repos/vishrutshah/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/vishrutshah/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/vishrutshah/azure-cli/tags","blobs_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vishrutshah/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/vishrutshah/azure-cli/languages","stargazers_url":"https://api.github.com/repos/vishrutshah/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/vishrutshah/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/vishrutshah/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/vishrutshah/azure-cli/subscription","commits_url":"https://api.github.com/repos/vishrutshah/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/vishrutshah/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/vishrutshah/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/vishrutshah/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/vishrutshah/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vishrutshah/azure-cli/merges","archive_url":"https://api.github.com/repos/vishrutshah/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vishrutshah/azure-cli/downloads","issues_url":"https://api.github.com/repos/vishrutshah/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/vishrutshah/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/vishrutshah/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/vishrutshah/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vishrutshah/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/vishrutshah/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/vishrutshah/azure-cli/deployments","created_at":"2017-01-04T01:05:40Z","updated_at":"2017-01-04T01:05:46Z","pushed_at":"2017-03-15T22:20:08Z","git_url":"git://github.com/vishrutshah/azure-cli.git","ssh_url":"git@github.com:vishrutshah/azure-cli.git","clone_url":"https://github.com/vishrutshah/azure-cli.git","svn_url":"https://github.com/vishrutshah/azure-cli","homepage":null,"size":16390,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7"},"html":{"href":"https://github.com/vishrutshah/azure-cli/pull/7"},"issue":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/issues/7"},"comments":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/vishrutshah/azure-cli/statuses/74636a9e19568f4fbd2026978eee1b0475dc15ee"}}}}
{"actor":{"display_login":"tjprescott"}}