{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/4786","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/4786/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/4786/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/4786/events","html_url":"https://github.com/theforeman/foreman/pull/4786","id":252836757,"number":4786,"title":"Fixes #20736 - improve bookmark permissions","user":{"login":"ares","id":109773,"avatar_url":"https://avatars0.githubusercontent.com/u/109773?v=4","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"labels":[{"id":79040689,"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":79040085,"url":"https://api.github.com/repos/theforeman/foreman/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-25T08:51:37Z","updated_at":"2017-08-28T10:28:25Z","closed_at":"2017-08-28T10:27:13Z","pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/4786","html_url":"https://github.com/theforeman/foreman/pull/4786","diff_url":"https://github.com/theforeman/foreman/pull/4786.diff","patch_url":"https://github.com/theforeman/foreman/pull/4786.patch"},"body":"Adds a new role \"Bookmark user\" granting all bookmarks permissions. This is useful for users to be able to bookmark searches. This also fixes the bug that we show \"Bookmark this search\" for users without \"create_bookmarks\" permission.\r\n\r\nSteps to reproduce:\r\n1. create a user with Viewer role\r\n2. login as that user, navigate to hosts page\r\n3. use some filter, e.g. name ~ *\r\n4. on search button, click the down arrow and select \"Bookmark this search\"\r\n5. empty modal window opens, submitting does not work\r\n\r\nTesting the fix\r\n6. user should not see \"Bookmark this search\" item\r\n7. rake db:seed\r\n8. assign Bookmark user role to the same user\r\n9. retry step 4, now the user can see the link and is able to submit the form which creates the bookmark"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/325318479","html_url":"https://github.com/theforeman/foreman/pull/4786#issuecomment-325318479","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/4786","id":325318479,"user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars3.githubusercontent.com/u/190443?v=4","gravatar_id":"","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"created_at":"2017-08-28T10:28:25Z","updated_at":"2017-08-28T10:28:25Z","body":"test failures unrelated"}}
{"actor":{"display_login":"iNecas"}}