{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/149710731","pull_request_review_id":75147419,"id":149710731,"diff_hunk":"@@ -80,11 +81,14 @@ script:\n       if [[ \"${WITH_ETCD}\" == \"true\" ]]; then\n         export ETCD_DIR=\"${GOPATH}/bin\"\n       fi\n-  - ./integration/integration_test.sh\n-  - cd \"$HOME/gopath/src/github.com/google/certificate-transparency-go\"\n-  - ./trillian/integration/integration_test.sh\n-  - cd $HOME/gopath/src/github.com/google/trillian\n-  - HAMMER_OPTS=\"--operations=50\" ./integration/maphammer.sh 3\n+  - |\n+      if [[ -n \"${TRILLIAN_SQL_DRIVER}\" && \"${TRILLIAN_SQL_DRIVER}\" != sqlite3 ]]; then","path":".travis.yml","position":28,"original_position":28,"commit_id":"51f13a527fd5869dbf5c83724a92f906b3085c47","original_commit_id":"51f13a527fd5869dbf5c83724a92f906b3085c47","user":{"login":"codingllama","id":12500300,"avatar_url":"https://avatars3.githubusercontent.com/u/12500300?v=4","gravatar_id":"","url":"https://api.github.com/users/codingllama","html_url":"https://github.com/codingllama","followers_url":"https://api.github.com/users/codingllama/followers","following_url":"https://api.github.com/users/codingllama/following{/other_user}","gists_url":"https://api.github.com/users/codingllama/gists{/gist_id}","starred_url":"https://api.github.com/users/codingllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingllama/subscriptions","organizations_url":"https://api.github.com/users/codingllama/orgs","repos_url":"https://api.github.com/users/codingllama/repos","events_url":"https://api.github.com/users/codingllama/events{/privacy}","received_events_url":"https://api.github.com/users/codingllama/received_events","type":"User","site_admin":false},"body":"Flipped and quoted.","created_at":"2017-11-08T15:55:45Z","updated_at":"2017-11-08T15:55:45Z","html_url":"https://github.com/google/trillian/pull/886#discussion_r149710731","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/886","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/149710731"},"html":{"href":"https://github.com/google/trillian/pull/886#discussion_r149710731"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/886"}},"in_reply_to_id":149706954},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/886","id":150371753,"html_url":"https://github.com/google/trillian/pull/886","diff_url":"https://github.com/google/trillian/pull/886.diff","patch_url":"https://github.com/google/trillian/pull/886.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/886","number":886,"state":"open","locked":false,"title":"Use sqlite3 as the default driver for unit tests","user":{"login":"codingllama","id":12500300,"avatar_url":"https://avatars3.githubusercontent.com/u/12500300?v=4","gravatar_id":"","url":"https://api.github.com/users/codingllama","html_url":"https://github.com/codingllama","followers_url":"https://api.github.com/users/codingllama/followers","following_url":"https://api.github.com/users/codingllama/following{/other_user}","gists_url":"https://api.github.com/users/codingllama/gists{/gist_id}","starred_url":"https://api.github.com/users/codingllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingllama/subscriptions","organizations_url":"https://api.github.com/users/codingllama/orgs","repos_url":"https://api.github.com/users/codingllama/repos","events_url":"https://api.github.com/users/codingllama/events{/privacy}","received_events_url":"https://api.github.com/users/codingllama/received_events","type":"User","site_admin":false},"body":"The testdb package adds utilities to create test databases for different \r\ndrivers. Currently, it supports sqlite3 (default) and mysql. The default driver \r\ncan be specified by the TRILLIAN_SQL_DRIVER environment variable, allowing tests\r\nto transparently execute against different databases/drivers.\r\n\r\nAdjustments done to existing code:\r\n\r\n* storage.sql declares unique constraints separately from the table declaration\r\n  (functionally equivalent, but more portable)\r\n* A few constants in query strings are now quoted (eg, 'false' instead of \r\n  false, otherwise SQLite interprets the constant as a column name)\r\n* Duplicate handling (isDuplicateErr) handles both MySQL and SQLite error codes\r\n* map_storage.go no longer distinguishes between empty and nil mapper metadata\r\n  (SQLite writes []byte{} as NULL). (This is a positive change in many ways, as \r\n  an empty Any proto is not valid due to having no type_url.)\r\n\r\nA few test loops that defer-close resources had their scope reduced (using \r\nanonymous functions), as doing so greatly reduces test duration on SQLite.\r\n\r\nFinally, integration.GetTestDB has been completely replaced by \r\ntestdb.NewTrillianDB.\r\n","created_at":"2017-11-02T18:36:15Z","updated_at":"2017-11-08T15:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23226280b93ecb3de38513295b54933fab947642","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/886/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/886/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/886/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/51f13a527fd5869dbf5c83724a92f906b3085c47","head":{"label":"codingllama:sqlite","ref":"sqlite","sha":"51f13a527fd5869dbf5c83724a92f906b3085c47","user":{"login":"codingllama","id":12500300,"avatar_url":"https://avatars3.githubusercontent.com/u/12500300?v=4","gravatar_id":"","url":"https://api.github.com/users/codingllama","html_url":"https://github.com/codingllama","followers_url":"https://api.github.com/users/codingllama/followers","following_url":"https://api.github.com/users/codingllama/following{/other_user}","gists_url":"https://api.github.com/users/codingllama/gists{/gist_id}","starred_url":"https://api.github.com/users/codingllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingllama/subscriptions","organizations_url":"https://api.github.com/users/codingllama/orgs","repos_url":"https://api.github.com/users/codingllama/repos","events_url":"https://api.github.com/users/codingllama/events{/privacy}","received_events_url":"https://api.github.com/users/codingllama/received_events","type":"User","site_admin":false},"repo":{"id":75955988,"name":"trillian","full_name":"codingllama/trillian","owner":{"login":"codingllama","id":12500300,"avatar_url":"https://avatars3.githubusercontent.com/u/12500300?v=4","gravatar_id":"","url":"https://api.github.com/users/codingllama","html_url":"https://github.com/codingllama","followers_url":"https://api.github.com/users/codingllama/followers","following_url":"https://api.github.com/users/codingllama/following{/other_user}","gists_url":"https://api.github.com/users/codingllama/gists{/gist_id}","starred_url":"https://api.github.com/users/codingllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingllama/subscriptions","organizations_url":"https://api.github.com/users/codingllama/orgs","repos_url":"https://api.github.com/users/codingllama/repos","events_url":"https://api.github.com/users/codingllama/events{/privacy}","received_events_url":"https://api.github.com/users/codingllama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codingllama/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/codingllama/trillian","forks_url":"https://api.github.com/repos/codingllama/trillian/forks","keys_url":"https://api.github.com/repos/codingllama/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codingllama/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codingllama/trillian/teams","hooks_url":"https://api.github.com/repos/codingllama/trillian/hooks","issue_events_url":"https://api.github.com/repos/codingllama/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/codingllama/trillian/events","assignees_url":"https://api.github.com/repos/codingllama/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/codingllama/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/codingllama/trillian/tags","blobs_url":"https://api.github.com/repos/codingllama/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codingllama/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codingllama/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/codingllama/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codingllama/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/codingllama/trillian/languages","stargazers_url":"https://api.github.com/repos/codingllama/trillian/stargazers","contributors_url":"https://api.github.com/repos/codingllama/trillian/contributors","subscribers_url":"https://api.github.com/repos/codingllama/trillian/subscribers","subscription_url":"https://api.github.com/repos/codingllama/trillian/subscription","commits_url":"https://api.github.com/repos/codingllama/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/codingllama/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/codingllama/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/codingllama/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/codingllama/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/codingllama/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codingllama/trillian/merges","archive_url":"https://api.github.com/repos/codingllama/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codingllama/trillian/downloads","issues_url":"https://api.github.com/repos/codingllama/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/codingllama/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/codingllama/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/codingllama/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codingllama/trillian/labels{/name}","releases_url":"https://api.github.com/repos/codingllama/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/codingllama/trillian/deployments","created_at":"2016-12-08T16:36:46Z","updated_at":"2016-12-08T16:36:48Z","pushed_at":"2017-11-08T12:45:20Z","git_url":"git://github.com/codingllama/trillian.git","ssh_url":"git@github.com:codingllama/trillian.git","clone_url":"https://github.com/codingllama/trillian.git","svn_url":"https://github.com/codingllama/trillian","homepage":null,"size":7677,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d07ec476b82641f27e8f3910dd0664b23144ec0a","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2017-11-07T05:25:15Z","pushed_at":"2017-11-08T15:27:37Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":"","size":7685,"stargazers_count":687,"watchers_count":687,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":48,"forks":96,"open_issues":48,"watchers":687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/886"},"html":{"href":"https://github.com/google/trillian/pull/886"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/886"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/886/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/886/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/886/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/51f13a527fd5869dbf5c83724a92f906b3085c47"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codingllama"}}