{"action":"created","issue":{"url":"https://api.github.com/repos/randombit/botan/issues/966","repository_url":"https://api.github.com/repos/randombit/botan","labels_url":"https://api.github.com/repos/randombit/botan/issues/966/labels{/name}","comments_url":"https://api.github.com/repos/randombit/botan/issues/966/comments","events_url":"https://api.github.com/repos/randombit/botan/issues/966/events","html_url":"https://github.com/randombit/botan/pull/966","id":218804483,"number":966,"title":"Add SM3 hash function","user":{"login":"dewyatt","id":711649,"avatar_url":"https://avatars1.githubusercontent.com/u/711649?v=3","gravatar_id":"","url":"https://api.github.com/users/dewyatt","html_url":"https://github.com/dewyatt","followers_url":"https://api.github.com/users/dewyatt/followers","following_url":"https://api.github.com/users/dewyatt/following{/other_user}","gists_url":"https://api.github.com/users/dewyatt/gists{/gist_id}","starred_url":"https://api.github.com/users/dewyatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dewyatt/subscriptions","organizations_url":"https://api.github.com/users/dewyatt/orgs","repos_url":"https://api.github.com/users/dewyatt/repos","events_url":"https://api.github.com/users/dewyatt/events{/privacy}","received_events_url":"https://api.github.com/users/dewyatt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-03T00:02:12Z","updated_at":"2017-04-03T06:39:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/randombit/botan/pulls/966","html_url":"https://github.com/randombit/botan/pull/966","diff_url":"https://github.com/randombit/botan/pull/966.diff","patch_url":"https://github.com/randombit/botan/pull/966.patch"},"body":"There is some small code duplication here but it is intentional.\r\n\r\nI have run a fair amount of random data of varying size through this and 3 other implementations, and everything is matching up perfectly.\r\n\r\nSources:\r\n* https://tools.ietf.org/html/draft-shen-sm3-hash-00\r\n* https://tools.ietf.org/html/draft-shen-sm3-hash-01\r\n* http://www.oscca.gov.cn/UpFile/20101222141857786.pdf\r\n* http://ris.sic.gov.cn/EN/abstract/abstract191.shtml\r\n"},"comment":{"url":"https://api.github.com/repos/randombit/botan/issues/comments/291060201","html_url":"https://github.com/randombit/botan/pull/966#issuecomment-291060201","issue_url":"https://api.github.com/repos/randombit/botan/issues/966","id":291060201,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars3.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-04-03T06:39:50Z","updated_at":"2017-04-03T06:39:50Z","body":"# [Codecov](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=h1) Report\n> Merging [#966](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=desc) into [master](https://codecov.io/gh/randombit/botan/commit/c8bec4132b1b7937438263fee14bd8e039d4c0b7?src=pr&el=desc) will **increase** coverage by `0.04%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/randombit/botan/pull/966/graphs/tree.svg?src=pr&token=VR6iYmSPH8&width=650&height=150)](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #966      +/-   ##\n==========================================\n+ Coverage   90.04%   90.09%   +0.04%     \n==========================================\n  Files         675      677       +2     \n  Lines       42132    42209      +77     \n  Branches     4735     4742       +7     \n==========================================\n+ Hits        37939    38027      +88     \n+ Misses       4165     4154      -11     \n  Partials       28       28\n```\n\n\n| [Impacted Files](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/lib/hash/sm3/sm3.h](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi9oYXNoL3NtMy9zbTMuaA==) | `100% <100%> (ø)` | |\n| [src/lib/hash/hash.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi9oYXNoL2hhc2guY3Bw) | `93.67% <100%> (+0.16%)` | :arrow_up: |\n| [src/lib/hash/sm3/sm3.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi9oYXNoL3NtMy9zbTMuY3Bw) | `100% <100%> (ø)` | |\n| [src/lib/asn1/asn1\\_obj.h](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi9hc24xL2FzbjFfb2JqLmg=) | `80% <0%> (-20%)` | :arrow_down: |\n| [src/lib/asn1/asn1\\_obj.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi9hc24xL2FzbjFfb2JqLmNwcA==) | `70% <0%> (-10%)` | :arrow_down: |\n| [src/lib/tls/tls\\_session\\_key.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi90bHMvdGxzX3Nlc3Npb25fa2V5LmNwcA==) | `92.85% <0%> (-7.15%)` | :arrow_down: |\n| [src/lib/tls/msg\\_certificate.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi90bHMvbXNnX2NlcnRpZmljYXRlLmNwcA==) | `91.42% <0%> (-2.86%)` | :arrow_down: |\n| [src/lib/math/numbertheory/make\\_prm.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi9tYXRoL251bWJlcnRoZW9yeS9tYWtlX3BybS5jcHA=) | `92.72% <0%> (-1.82%)` | :arrow_down: |\n| [src/lib/asn1/asn1\\_oid.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi9hc24xL2FzbjFfb2lkLmNwcA==) | `82.75% <0%> (-1.15%)` | :arrow_down: |\n| [src/lib/tls/tls\\_extensions.cpp](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree#diff-c3JjL2xpYi90bHMvdGxzX2V4dGVuc2lvbnMuY3Bw) | `86.06% <0%> (-0.62%)` | :arrow_down: |\n| ... and [16 more](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=footer). Last update [c8bec41...3d60ecc](https://codecov.io/gh/randombit/botan/pull/966?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments)."}}
{"actor":{"display_login":"codecov-io"}}