{"action":"created","issue":{"url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak/issues/408","repository_url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak","labels_url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak/issues/408/labels{/name}","comments_url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak/issues/408/comments","events_url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak/issues/408/events","html_url":"https://github.com/LouisBarranqueiro/hexo-theme-tranquilpeak/pull/408","id":223970657,"number":408,"title":"Improve accessibility by adding descriptions to icon links","user":{"login":"darekkay","id":3101914,"avatar_url":"https://avatars3.githubusercontent.com/u/3101914?v=3","gravatar_id":"","url":"https://api.github.com/users/darekkay","html_url":"https://github.com/darekkay","followers_url":"https://api.github.com/users/darekkay/followers","following_url":"https://api.github.com/users/darekkay/following{/other_user}","gists_url":"https://api.github.com/users/darekkay/gists{/gist_id}","starred_url":"https://api.github.com/users/darekkay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darekkay/subscriptions","organizations_url":"https://api.github.com/users/darekkay/orgs","repos_url":"https://api.github.com/users/darekkay/repos","events_url":"https://api.github.com/users/darekkay/events{/privacy}","received_events_url":"https://api.github.com/users/darekkay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-24T22:34:21Z","updated_at":"2017-05-01T20:43:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak/pulls/408","html_url":"https://github.com/LouisBarranqueiro/hexo-theme-tranquilpeak/pull/408","diff_url":"https://github.com/LouisBarranqueiro/hexo-theme-tranquilpeak/pull/408.diff","patch_url":"https://github.com/LouisBarranqueiro/hexo-theme-tranquilpeak/pull/408.patch"},"body":"### Configuration\r\n\r\n - **Operating system with version** : Windows 7\r\n - **Node version** : 6.9.1\r\n - **Hexo version** : 3.2.2\r\n - **Hexo-cli version** : 1.0.2\r\n \r\n### Changes proposed\r\nIcon-only links are a huge problem for visually impaired people who rely on a screen reader. Without a description, a screen reader user won't know the purpose of links such as \"Share\" or \"Comment\". See the Font Awesome [Guide](http://fontawesome.io/accessibility/#accessibility-manual) for more information.\r\n\r\nI reused labels where possible, but had to add 3 new labels. I translated those into German, too.\r\n\r\nI have tested all changes using the NVDA screen reader."},"comment":{"url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak/issues/comments/298427471","html_url":"https://github.com/LouisBarranqueiro/hexo-theme-tranquilpeak/pull/408#issuecomment-298427471","issue_url":"https://api.github.com/repos/LouisBarranqueiro/hexo-theme-tranquilpeak/issues/408","id":298427471,"user":{"login":"darekkay","id":3101914,"avatar_url":"https://avatars3.githubusercontent.com/u/3101914?v=3","gravatar_id":"","url":"https://api.github.com/users/darekkay","html_url":"https://github.com/darekkay","followers_url":"https://api.github.com/users/darekkay/followers","following_url":"https://api.github.com/users/darekkay/following{/other_user}","gists_url":"https://api.github.com/users/darekkay/gists{/gist_id}","starred_url":"https://api.github.com/users/darekkay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darekkay/subscriptions","organizations_url":"https://api.github.com/users/darekkay/orgs","repos_url":"https://api.github.com/users/darekkay/repos","events_url":"https://api.github.com/users/darekkay/events{/privacy}","received_events_url":"https://api.github.com/users/darekkay/received_events","type":"User","site_admin":false},"created_at":"2017-05-01T20:43:52Z","updated_at":"2017-05-01T20:43:52Z","body":"Making the post footer invisible to screen reader users contradicts the whole purpose of accessibility. Visually impaired people should get the same information as sighted people, so only elements that don't contain any meaningful information (like decoration images or [font-awesome icons](http://fontawesome.io/accessibility/#accessibility-manual)) should be hidden. Adding `title` or `aria-label` (depending on the context) to an element makes the screen reader announce it to the user. \r\n\r\nYou can already use the post actions (like sharing the post) without the mouse, using `tab` + `return`. But without a proper description, only \"link\" will be announced via the screen reader. My PR solves this problem ;)"}}
{"actor":{"display_login":"darekkay"}}