{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/111732467","pull_request_review_id":32993267,"id":111732467,"diff_hunk":"@@ -32,19 +32,29 @@ public void TestEnvironmentProperty()\n \n             IDictionary<string, string> environment = psi.Environment;\n \n-            Assert.NotEqual(environment.Count, 0);\n+            Assert.NotEqual(0, environment.Count);\n \n-            int CountItems = environment.Count;\n+            int countItems = environment.Count;\n \n             environment.Add(\"NewKey\", \"NewValue\");\n             environment.Add(\"NewKey2\", \"NewValue2\");\n \n-            Assert.Equal(CountItems + 2, environment.Count);\n+            Assert.Equal(countItems + 2, environment.Count);\n             environment.Remove(\"NewKey\");\n-            Assert.Equal(CountItems + 1, environment.Count);\n+            Assert.Equal(countItems + 1, environment.Count);\n \n-            //Exception not thrown with invalid key\n-            Assert.Throws<ArgumentException>(() => { environment.Add(\"NewKey2\", \"NewValue2\"); });\n+            // The full .NET framework represents Environment with StringDictionary. On .NET Core we use\n+            // use Dictionary<string, string>, because we need to have case sensitive behaviour on Unix.","path":"src/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs","position":22,"original_position":22,"commit_id":"6fd2751688f68c93e09a0f56ba08b9c32c18bf58","original_commit_id":"6fd2751688f68c93e09a0f56ba08b9c32c18bf58","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars3.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"If this is the reason, why don't we construct the Dictionary with a case-insensitive comparer on Windows so as to keep the behavior consistent?\r\ncc: @Priya91 ","created_at":"2017-04-17T11:31:26Z","updated_at":"2017-04-17T11:31:27Z","html_url":"https://github.com/dotnet/corefx/pull/18467#discussion_r111732467","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/18467","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/111732467"},"html":{"href":"https://github.com/dotnet/corefx/pull/18467#discussion_r111732467"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18467"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/18467","id":116088100,"html_url":"https://github.com/dotnet/corefx/pull/18467","diff_url":"https://github.com/dotnet/corefx/pull/18467.diff","patch_url":"https://github.com/dotnet/corefx/pull/18467.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/18467","number":18467,"state":"open","locked":false,"title":"Fix process product code and tests for netfx","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars3.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"Fixes #18262\r\nFixes #18470\r\nFixes #18471\r\nFixes #18472\r\nFixes #18473\r\n\r\n@safern","created_at":"2017-04-17T03:59:07Z","updated_at":"2017-04-17T11:31:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb08b65410190decaf665b6eb62f581c744bec6e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/18467/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/18467/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/18467/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/6fd2751688f68c93e09a0f56ba08b9c32c18bf58","head":{"label":"hughbe:process-netfx","ref":"process-netfx","sha":"6fd2751688f68c93e09a0f56ba08b9c32c18bf58","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars3.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"repo":{"id":47085914,"name":"corefx","full_name":"hughbe/corefx","owner":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars3.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughbe/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/hughbe/corefx","forks_url":"https://api.github.com/repos/hughbe/corefx/forks","keys_url":"https://api.github.com/repos/hughbe/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughbe/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughbe/corefx/teams","hooks_url":"https://api.github.com/repos/hughbe/corefx/hooks","issue_events_url":"https://api.github.com/repos/hughbe/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/hughbe/corefx/events","assignees_url":"https://api.github.com/repos/hughbe/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/hughbe/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/hughbe/corefx/tags","blobs_url":"https://api.github.com/repos/hughbe/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughbe/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughbe/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughbe/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughbe/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/hughbe/corefx/languages","stargazers_url":"https://api.github.com/repos/hughbe/corefx/stargazers","contributors_url":"https://api.github.com/repos/hughbe/corefx/contributors","subscribers_url":"https://api.github.com/repos/hughbe/corefx/subscribers","subscription_url":"https://api.github.com/repos/hughbe/corefx/subscription","commits_url":"https://api.github.com/repos/hughbe/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughbe/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughbe/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughbe/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughbe/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/hughbe/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughbe/corefx/merges","archive_url":"https://api.github.com/repos/hughbe/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughbe/corefx/downloads","issues_url":"https://api.github.com/repos/hughbe/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/hughbe/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/hughbe/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/hughbe/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughbe/corefx/labels{/name}","releases_url":"https://api.github.com/repos/hughbe/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/hughbe/corefx/deployments","created_at":"2015-11-30T00:15:59Z","updated_at":"2016-10-22T11:02:30Z","pushed_at":"2017-04-17T05:04:54Z","git_url":"git://github.com/hughbe/corefx.git","ssh_url":"git@github.com:hughbe/corefx.git","clone_url":"https://github.com/hughbe/corefx.git","svn_url":"https://github.com/hughbe/corefx","homepage":"http://dotnet.github.io/","size":135581,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6c48e0c13ffc5eea49bb70e40920f80b5e1d3d0c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-04-17T11:25:02Z","pushed_at":"2017-04-17T10:35:01Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":140446,"stargazers_count":11598,"watchers_count":11598,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3055,"mirror_url":null,"open_issues_count":1435,"forks":3055,"open_issues":1435,"watchers":11598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18467"},"html":{"href":"https://github.com/dotnet/corefx/pull/18467"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18467"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18467/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18467/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18467/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/6fd2751688f68c93e09a0f56ba08b9c32c18bf58"}}}}
{"actor":{"display_login":"stephentoub"}}