{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/blueprint/issues/761","repository_url":"https://api.github.com/repos/palantir/blueprint","labels_url":"https://api.github.com/repos/palantir/blueprint/issues/761/labels{/name}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/761/comments","events_url":"https://api.github.com/repos/palantir/blueprint/issues/761/events","html_url":"https://github.com/palantir/blueprint/pull/761","id":211537912,"number":761,"title":"Remove PureRender and default to detect truncation","user":{"login":"michael-yx-wu","id":3681045,"avatar_url":"https://avatars2.githubusercontent.com/u/3681045?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-yx-wu","html_url":"https://github.com/michael-yx-wu","followers_url":"https://api.github.com/users/michael-yx-wu/followers","following_url":"https://api.github.com/users/michael-yx-wu/following{/other_user}","gists_url":"https://api.github.com/users/michael-yx-wu/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-yx-wu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-yx-wu/subscriptions","organizations_url":"https://api.github.com/users/michael-yx-wu/orgs","repos_url":"https://api.github.com/users/michael-yx-wu/repos","events_url":"https://api.github.com/users/michael-yx-wu/events{/privacy}","received_events_url":"https://api.github.com/users/michael-yx-wu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-02T22:27:08Z","updated_at":"2017-03-02T22:46:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/761","html_url":"https://github.com/palantir/blueprint/pull/761","diff_url":"https://github.com/palantir/blueprint/pull/761.diff","patch_url":"https://github.com/palantir/blueprint/pull/761.patch"},"body":"#### Fixes #760 \r\n\r\n#### Changes proposed in this pull request:\r\n\r\nRemove `PureRender` and change the default props to detect truncation.\r\n\r\n#### Reviewers should focus on:\r\n\r\nI left JSONFormat alone when first implementing the detect truncation feature because I thought people might prefer to just always show the popover to view JSON and manually truncate. Are the default props changes okay?\r\n\r\n#### Screenshot\r\nJSONFormat now properly detects truncation \r\n\r\n![screen shot 2017-03-02 at 5 26 43 pm](https://cloud.githubusercontent.com/assets/3681045/23529900/6cd9726a-ff6d-11e6-8d2d-f761710ee15f.png)\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/blueprint/issues/comments/283807482","html_url":"https://github.com/palantir/blueprint/pull/761#issuecomment-283807482","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/761","id":283807482,"user":{"login":"gscshoyru","id":2463526,"avatar_url":"https://avatars2.githubusercontent.com/u/2463526?v=3","gravatar_id":"","url":"https://api.github.com/users/gscshoyru","html_url":"https://github.com/gscshoyru","followers_url":"https://api.github.com/users/gscshoyru/followers","following_url":"https://api.github.com/users/gscshoyru/following{/other_user}","gists_url":"https://api.github.com/users/gscshoyru/gists{/gist_id}","starred_url":"https://api.github.com/users/gscshoyru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gscshoyru/subscriptions","organizations_url":"https://api.github.com/users/gscshoyru/orgs","repos_url":"https://api.github.com/users/gscshoyru/repos","events_url":"https://api.github.com/users/gscshoyru/events{/privacy}","received_events_url":"https://api.github.com/users/gscshoyru/received_events","type":"User","site_admin":false},"created_at":"2017-03-02T22:46:03Z","updated_at":"2017-03-02T22:46:03Z","body":"Cool -- just wasn't sure how we handled that kind of backcompat. Sounds good to me :) 👍 "}}
{"actor":{"display_login":"gscshoyru"}}