{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/16381","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/16381/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/16381/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/16381/events","html_url":"https://github.com/ceph/ceph/pull/16381","id":243609147,"number":16381,"title":"common: bench test get incorrect iops result ","user":{"login":"PCzhangPC","id":30252267,"avatar_url":"https://avatars3.githubusercontent.com/u/30252267?v=4","gravatar_id":"","url":"https://api.github.com/users/PCzhangPC","html_url":"https://github.com/PCzhangPC","followers_url":"https://api.github.com/users/PCzhangPC/followers","following_url":"https://api.github.com/users/PCzhangPC/following{/other_user}","gists_url":"https://api.github.com/users/PCzhangPC/gists{/gist_id}","starred_url":"https://api.github.com/users/PCzhangPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCzhangPC/subscriptions","organizations_url":"https://api.github.com/users/PCzhangPC/orgs","repos_url":"https://api.github.com/users/PCzhangPC/repos","events_url":"https://api.github.com/users/PCzhangPC/events{/privacy}","received_events_url":"https://api.github.com/users/PCzhangPC/received_events","type":"User","site_admin":false},"labels":[{"id":134774049,"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":199292951,"url":"https://api.github.com/repos/ceph/ceph/labels/common","name":"common","color":"006b75","default":false},{"id":144329561,"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-07-18T06:08:34Z","updated_at":"2017-08-08T04:20:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/16381","html_url":"https://github.com/ceph/ceph/pull/16381","diff_url":"https://github.com/ceph/ceph/pull/16381.diff","patch_url":"https://github.com/ceph/ceph/pull/16381.patch"},"body":"when running : rados -p test bench 20 seq(rand), if the running time of this command is too short,the info would be incorrect as below:  \r\n Average IOPS:         180\r\nStddev IOPS:          0\r\nMax IOPS:             0\r\nMin IOPS:             2147483647\r\n    and if the runtime is less than 2s, the average iops may be bigger than max iops,which is incorrect too.\r\nAverage IOPS:         249\r\nStddev IOPS:          0\r\nMax IOPS:             247\r\nMin IOPS:             247\r\nSigned-off-by: PCzhangPC <pengcheng.zhang@easystack.cn>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/320846052","html_url":"https://github.com/ceph/ceph/pull/16381#issuecomment-320846052","issue_url":"https://api.github.com/repos/ceph/ceph/issues/16381","id":320846052,"user":{"login":"PCzhangPC","id":30252267,"avatar_url":"https://avatars3.githubusercontent.com/u/30252267?v=4","gravatar_id":"","url":"https://api.github.com/users/PCzhangPC","html_url":"https://github.com/PCzhangPC","followers_url":"https://api.github.com/users/PCzhangPC/followers","following_url":"https://api.github.com/users/PCzhangPC/following{/other_user}","gists_url":"https://api.github.com/users/PCzhangPC/gists{/gist_id}","starred_url":"https://api.github.com/users/PCzhangPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCzhangPC/subscriptions","organizations_url":"https://api.github.com/users/PCzhangPC/orgs","repos_url":"https://api.github.com/users/PCzhangPC/repos","events_url":"https://api.github.com/users/PCzhangPC/events{/privacy}","received_events_url":"https://api.github.com/users/PCzhangPC/received_events","type":"User","site_admin":false},"created_at":"2017-08-08T04:20:55Z","updated_at":"2017-08-08T04:20:55Z","body":"      there is something wrong in my last commit, and i remove the (1<runtime<2) part. \r\n      The max_iops is initialized as 0 and the min_iops is initialized as MAX_INT. If the command finishes less than 1s, the function `void *ObjBencher::status_printer` will not update the value of max/min_iops because the variable `cyclesinceChange` is alwawy 0.  so the result will be 0 and MAX_INT.\r\n     as for `(1<runtime<2)` part, for example ,if the runtime is 1.2s , the max_iops and min_iops is updated in the first second. but in the last 0.2s , there are orther write/read to finish but we don't  calculate the max/min_iops again. so the average_iops is lager than max_iops. In last commit, i added an condition to handle this situation, which was not approprate. so in this pr, i remove this part.\r\n    any suggestion?"}}
{"actor":{"display_login":"PCzhangPC"}}