{"action":"created","issue":{"url":"https://api.github.com/repos/ably/docs/issues/254","repository_url":"https://api.github.com/repos/ably/docs","labels_url":"https://api.github.com/repos/ably/docs/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/ably/docs/issues/254/comments","events_url":"https://api.github.com/repos/ably/docs/issues/254/events","html_url":"https://github.com/ably/docs/pull/254","id":201638925,"number":254,"title":"Various spec fixes","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-01-18T17:24:54Z","updated_at":"2017-01-19T09:59:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ably/docs/pulls/254","html_url":"https://github.com/ably/docs/pull/254","diff_url":"https://github.com/ably/docs/pull/254.diff","patch_url":"https://github.com/ably/docs/pull/254.patch"},"body":"@tcard @paddybyers @SimonWoolf a few small fixes for issues created recently."},"comment":{"url":"https://api.github.com/repos/ably/docs/issues/comments/273729968","html_url":"https://github.com/ably/docs/pull/254#issuecomment-273729968","issue_url":"https://api.github.com/repos/ably/docs/issues/254","id":273729968,"user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"created_at":"2017-01-19T09:59:01Z","updated_at":"2017-01-19T09:59:01Z","body":"I don't feel strongly enough one way or the other to be honest so would be happy to go with a function. However, I do think that `syncComplete` is really just a state, and all `state` fields are attributes as opposed to functions, so if we applied the same thinking then `channel.state` should be a function too.  In fact in Ruby my `RealtimePresence` members map object has a state, see https://github.com/ably/ably-ruby/blob/4008873524411d368321bd489fff90e9118c3132/lib/ably/realtime/presence/members_map.rb#L21-L28.  I'm not proposing we introduce that, but just saying that the attribute is analogous to a state.\r\n\r\n> do we really want a worry that people might mistake functions for attributes to drive our api design?\r\n\r\nWe do use attributes already so not sure I understand the point.  This discussion was specifically around whether we should be changing a function in JS to an attribute and the implications of that.\r\n\r\nAs above though, I don't feel strongly enough about it one way or the other, so let's just vote.\r\n\r\nMatt +1 for an attribute (rationale being that it's just a state attribute like `errorReason` or `state`)"}}
{"actor":{"display_login":"mattheworiordan"}}