{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/comments/133700653","pull_request_review_id":56911345,"id":133700653,"diff_hunk":"@@ -0,0 +1,46 @@\n+/*\n+ * Copyright 2017 HM Revenue & Customs\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package uk.gov.hmrc.agentservicesaccount.services\n+\n+import java.net.URL\n+import javax.inject.{Inject, Singleton}\n+\n+import uk.gov.hmrc.agentservicesaccount.AppConfig\n+import uk.gov.hmrc.agentservicesaccount.connectors.SsoConnector\n+import uk.gov.hmrc.play.binders.ContinueUrl\n+import uk.gov.hmrc.play.http.HeaderCarrier\n+\n+import scala.concurrent.Future\n+import scala.util.Try\n+\n+@Singleton\n+class HostnameWhiteListService @Inject()(appConfig: AppConfig, ssoConnector: SsoConnector) {","path":"app/uk/gov/hmrc/agentservicesaccount/services/HostnameWhiteListService.scala","position":31,"original_position":31,"commit_id":"d2fef90ea250efac041fccfe6150416b86842951","original_commit_id":"d2fef90ea250efac041fccfe6150416b86842951","user":{"login":"arturopala","id":250927,"avatar_url":"https://avatars1.githubusercontent.com/u/250927?v=4","gravatar_id":"","url":"https://api.github.com/users/arturopala","html_url":"https://github.com/arturopala","followers_url":"https://api.github.com/users/arturopala/followers","following_url":"https://api.github.com/users/arturopala/following{/other_user}","gists_url":"https://api.github.com/users/arturopala/gists{/gist_id}","starred_url":"https://api.github.com/users/arturopala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturopala/subscriptions","organizations_url":"https://api.github.com/users/arturopala/orgs","repos_url":"https://api.github.com/users/arturopala/repos","events_url":"https://api.github.com/users/arturopala/events{/privacy}","received_events_url":"https://api.github.com/users/arturopala/received_events","type":"User","site_admin":false},"body":"same here: we check only against `Host` part of URL","created_at":"2017-08-17T12:40:56Z","updated_at":"2017-08-17T12:40:56Z","html_url":"https://github.com/hmrc/agent-services-account-frontend/pull/13#discussion_r133700653","pull_request_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/comments/133700653"},"html":{"href":"https://github.com/hmrc/agent-services-account-frontend/pull/13#discussion_r133700653"},"pull_request":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13","id":136214074,"html_url":"https://github.com/hmrc/agent-services-account-frontend/pull/13","diff_url":"https://github.com/hmrc/agent-services-account-frontend/pull/13.diff","patch_url":"https://github.com/hmrc/agent-services-account-frontend/pull/13.patch","issue_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/13","number":13,"state":"open","locked":false,"title":"[APB-1130][ZF,AO] validate continue url and display continue button on agent's account page","user":{"login":"arturopala","id":250927,"avatar_url":"https://avatars1.githubusercontent.com/u/250927?v=4","gravatar_id":"","url":"https://api.github.com/users/arturopala","html_url":"https://github.com/arturopala","followers_url":"https://api.github.com/users/arturopala/followers","following_url":"https://api.github.com/users/arturopala/following{/other_user}","gists_url":"https://api.github.com/users/arturopala/gists{/gist_id}","starred_url":"https://api.github.com/users/arturopala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturopala/subscriptions","organizations_url":"https://api.github.com/users/arturopala/orgs","repos_url":"https://api.github.com/users/arturopala/repos","events_url":"https://api.github.com/users/arturopala/events{/privacy}","received_events_url":"https://api.github.com/users/arturopala/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-17T09:43:21Z","updated_at":"2017-08-17T12:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ea4ad28fb948a060e41de6ff4a06489fce5c26a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13/commits","review_comments_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13/comments","review_comment_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/13/comments","statuses_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/statuses/d2fef90ea250efac041fccfe6150416b86842951","head":{"label":"hmrc:APB-1130","ref":"APB-1130","sha":"d2fef90ea250efac041fccfe6150416b86842951","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":99590845,"name":"agent-services-account-frontend","full_name":"hmrc/agent-services-account-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/agent-services-account-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/agent-services-account-frontend","forks_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/deployments","created_at":"2017-08-07T15:09:47Z","updated_at":"2017-08-07T15:10:05Z","pushed_at":"2017-08-17T09:43:21Z","git_url":"git://github.com/hmrc/agent-services-account-frontend.git","ssh_url":"git@github.com:hmrc/agent-services-account-frontend.git","clone_url":"https://github.com/hmrc/agent-services-account-frontend.git","svn_url":"https://github.com/hmrc/agent-services-account-frontend","homepage":"","size":98,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"fa96b2e3aa8233454440a480994c52d95f28cb4b","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":99590845,"name":"agent-services-account-frontend","full_name":"hmrc/agent-services-account-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/agent-services-account-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/agent-services-account-frontend","forks_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/agent-services-account-frontend/deployments","created_at":"2017-08-07T15:09:47Z","updated_at":"2017-08-07T15:10:05Z","pushed_at":"2017-08-17T09:43:21Z","git_url":"git://github.com/hmrc/agent-services-account-frontend.git","ssh_url":"git@github.com:hmrc/agent-services-account-frontend.git","clone_url":"https://github.com/hmrc/agent-services-account-frontend.git","svn_url":"https://github.com/hmrc/agent-services-account-frontend","homepage":"","size":98,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13"},"html":{"href":"https://github.com/hmrc/agent-services-account-frontend/pull/13"},"issue":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/13"},"comments":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/agent-services-account-frontend/statuses/d2fef90ea250efac041fccfe6150416b86842951"}}}}
{"actor":{"display_login":"arturopala"}}