{"action":"created","issue":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/486","repository_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/486/labels{/name}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/486/comments","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/486/events","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/486","id":259905313,"number":486,"title":"[WIP] Implement transaction broadcasting and propagation 3 ways","user":{"login":"nopara73","id":9156103,"avatar_url":"https://avatars0.githubusercontent.com/u/9156103?v=4","gravatar_id":"","url":"https://api.github.com/users/nopara73","html_url":"https://github.com/nopara73","followers_url":"https://api.github.com/users/nopara73/followers","following_url":"https://api.github.com/users/nopara73/following{/other_user}","gists_url":"https://api.github.com/users/nopara73/gists{/gist_id}","starred_url":"https://api.github.com/users/nopara73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nopara73/subscriptions","organizations_url":"https://api.github.com/users/nopara73/orgs","repos_url":"https://api.github.com/users/nopara73/repos","events_url":"https://api.github.com/users/nopara73/events{/privacy}","received_events_url":"https://api.github.com/users/nopara73/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-22T18:52:10Z","updated_at":"2017-09-27T23:48:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/486","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/486","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/486.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/486.patch"},"body":"Superseeds: https://github.com/stratisproject/StratisBitcoinFullNode/pull/470\r\n\r\nToDo:  \r\n@dev0tion We need to resolve this issue before it gets merged: https://github.com/stratisproject/Breeze/issues/207  \r\n@bokobza Please sort out the tests. Because from now on we don't get false positive results testing without real network is impossible. In `WalletControllerTests` `SendTransactionFailedReturnsBadRequest` and `SendTransactionWithExceptionReturnsBadRequest` are failing.  \r\nFurthermore please remove the WalletManager's sendtransaction, because the wallet is not the one who broadcasts and propagates the transaction. At least not anymore. I don't remove it because, many more tests would fail."},"comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments/332687060","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/486#issuecomment-332687060","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/486","id":332687060,"user":{"login":"dangershony","id":7487930,"avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"created_at":"2017-09-27T23:48:04Z","updated_at":"2017-09-27T23:48:04Z","author_association":"CONTRIBUTOR","body":"Generally we need to separate such PR so one does not depend on the other.\r\n"}}
{"actor":{"display_login":"dangershony"}}