{"action":"created","comment":{"url":"https://api.github.com/repos/koreader/koreader/pulls/comments/109471730","pull_request_review_id":30576101,"id":109471730,"diff_hunk":"@@ -1,9 +1,12 @@\n #!/usr/bin/env bash\n \n CI_DIR=\"$(cd \"$(dirname \"${BASH_SOURCE[0]}\")\" && pwd)\"\n+# shellcheck source=/dev/null\n source \"${CI_DIR}/common.sh\"\n \n travis_retry make fetchthirdparty\n make all\n make testfront\n-luajit $(which luacheck) --no-color -q {reader,setupkoenv,datastorage}.lua frontend plugins\n+luajit \"$(which luacheck)\" --no-color -q {reader,setupkoenv,datastorage}.lua frontend plugins\n+find . -type f -name '*.sh' -not -path \"./base/*\" -not -path \"./luajit-rocks/*\" -print0 | xargs --null shellcheck","path":".ci/script.sh","position":null,"original_position":12,"commit_id":"d0edeebbbb98e31d1a38db15e3078d42703ed7b9","original_commit_id":"3a63da0f40fae61d605568f683094da8e1b9d1eb","user":{"login":"houqp","id":670302,"avatar_url":"https://avatars3.githubusercontent.com/u/670302?v=3","gravatar_id":"","url":"https://api.github.com/users/houqp","html_url":"https://github.com/houqp","followers_url":"https://api.github.com/users/houqp/followers","following_url":"https://api.github.com/users/houqp/following{/other_user}","gists_url":"https://api.github.com/users/houqp/gists{/gist_id}","starred_url":"https://api.github.com/users/houqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houqp/subscriptions","organizations_url":"https://api.github.com/users/houqp/orgs","repos_url":"https://api.github.com/users/houqp/repos","events_url":"https://api.github.com/users/houqp/events{/privacy}","received_events_url":"https://api.github.com/users/houqp/received_events","type":"User","site_admin":false},"body":"I was thinking about the same thing! Yes, makes total sense to not fun tests if static analysis is not even passing.","created_at":"2017-04-03T17:08:57Z","updated_at":"2017-04-03T17:08:57Z","html_url":"https://github.com/koreader/koreader/pull/2712#discussion_r109471730","pull_request_url":"https://api.github.com/repos/koreader/koreader/pulls/2712","_links":{"self":{"href":"https://api.github.com/repos/koreader/koreader/pulls/comments/109471730"},"html":{"href":"https://github.com/koreader/koreader/pull/2712#discussion_r109471730"},"pull_request":{"href":"https://api.github.com/repos/koreader/koreader/pulls/2712"}}},"pull_request":{"url":"https://api.github.com/repos/koreader/koreader/pulls/2712","id":113830705,"html_url":"https://github.com/koreader/koreader/pull/2712","diff_url":"https://github.com/koreader/koreader/pull/2712.diff","patch_url":"https://github.com/koreader/koreader/pull/2712.patch","issue_url":"https://api.github.com/repos/koreader/koreader/issues/2712","number":2712,"state":"open","locked":false,"title":"Add ShellCheck and shfmt shell code quality analysis","user":{"login":"Frenzie","id":202757,"avatar_url":"https://avatars1.githubusercontent.com/u/202757?v=3","gravatar_id":"","url":"https://api.github.com/users/Frenzie","html_url":"https://github.com/Frenzie","followers_url":"https://api.github.com/users/Frenzie/followers","following_url":"https://api.github.com/users/Frenzie/following{/other_user}","gists_url":"https://api.github.com/users/Frenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/Frenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frenzie/subscriptions","organizations_url":"https://api.github.com/users/Frenzie/orgs","repos_url":"https://api.github.com/users/Frenzie/repos","events_url":"https://api.github.com/users/Frenzie/events{/privacy}","received_events_url":"https://api.github.com/users/Frenzie/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-02T19:14:34Z","updated_at":"2017-04-03T17:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f2edc19d3825fc364396bfcb6d9f59efdb81a2d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/koreader/koreader/pulls/2712/commits","review_comments_url":"https://api.github.com/repos/koreader/koreader/pulls/2712/comments","review_comment_url":"https://api.github.com/repos/koreader/koreader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koreader/koreader/issues/2712/comments","statuses_url":"https://api.github.com/repos/koreader/koreader/statuses/d0edeebbbb98e31d1a38db15e3078d42703ed7b9","head":{"label":"Frenzie:shellcheck","ref":"shellcheck","sha":"d0edeebbbb98e31d1a38db15e3078d42703ed7b9","user":{"login":"Frenzie","id":202757,"avatar_url":"https://avatars1.githubusercontent.com/u/202757?v=3","gravatar_id":"","url":"https://api.github.com/users/Frenzie","html_url":"https://github.com/Frenzie","followers_url":"https://api.github.com/users/Frenzie/followers","following_url":"https://api.github.com/users/Frenzie/following{/other_user}","gists_url":"https://api.github.com/users/Frenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/Frenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frenzie/subscriptions","organizations_url":"https://api.github.com/users/Frenzie/orgs","repos_url":"https://api.github.com/users/Frenzie/repos","events_url":"https://api.github.com/users/Frenzie/events{/privacy}","received_events_url":"https://api.github.com/users/Frenzie/received_events","type":"User","site_admin":false},"repo":{"id":76361762,"name":"koreader","full_name":"Frenzie/koreader","owner":{"login":"Frenzie","id":202757,"avatar_url":"https://avatars1.githubusercontent.com/u/202757?v=3","gravatar_id":"","url":"https://api.github.com/users/Frenzie","html_url":"https://github.com/Frenzie","followers_url":"https://api.github.com/users/Frenzie/followers","following_url":"https://api.github.com/users/Frenzie/following{/other_user}","gists_url":"https://api.github.com/users/Frenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/Frenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frenzie/subscriptions","organizations_url":"https://api.github.com/users/Frenzie/orgs","repos_url":"https://api.github.com/users/Frenzie/repos","events_url":"https://api.github.com/users/Frenzie/events{/privacy}","received_events_url":"https://api.github.com/users/Frenzie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Frenzie/koreader","description":"An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Kindle, Kobo, PocketBook, Ubuntu Touch and Android devices","fork":true,"url":"https://api.github.com/repos/Frenzie/koreader","forks_url":"https://api.github.com/repos/Frenzie/koreader/forks","keys_url":"https://api.github.com/repos/Frenzie/koreader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Frenzie/koreader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Frenzie/koreader/teams","hooks_url":"https://api.github.com/repos/Frenzie/koreader/hooks","issue_events_url":"https://api.github.com/repos/Frenzie/koreader/issues/events{/number}","events_url":"https://api.github.com/repos/Frenzie/koreader/events","assignees_url":"https://api.github.com/repos/Frenzie/koreader/assignees{/user}","branches_url":"https://api.github.com/repos/Frenzie/koreader/branches{/branch}","tags_url":"https://api.github.com/repos/Frenzie/koreader/tags","blobs_url":"https://api.github.com/repos/Frenzie/koreader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Frenzie/koreader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Frenzie/koreader/git/refs{/sha}","trees_url":"https://api.github.com/repos/Frenzie/koreader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Frenzie/koreader/statuses/{sha}","languages_url":"https://api.github.com/repos/Frenzie/koreader/languages","stargazers_url":"https://api.github.com/repos/Frenzie/koreader/stargazers","contributors_url":"https://api.github.com/repos/Frenzie/koreader/contributors","subscribers_url":"https://api.github.com/repos/Frenzie/koreader/subscribers","subscription_url":"https://api.github.com/repos/Frenzie/koreader/subscription","commits_url":"https://api.github.com/repos/Frenzie/koreader/commits{/sha}","git_commits_url":"https://api.github.com/repos/Frenzie/koreader/git/commits{/sha}","comments_url":"https://api.github.com/repos/Frenzie/koreader/comments{/number}","issue_comment_url":"https://api.github.com/repos/Frenzie/koreader/issues/comments{/number}","contents_url":"https://api.github.com/repos/Frenzie/koreader/contents/{+path}","compare_url":"https://api.github.com/repos/Frenzie/koreader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Frenzie/koreader/merges","archive_url":"https://api.github.com/repos/Frenzie/koreader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Frenzie/koreader/downloads","issues_url":"https://api.github.com/repos/Frenzie/koreader/issues{/number}","pulls_url":"https://api.github.com/repos/Frenzie/koreader/pulls{/number}","milestones_url":"https://api.github.com/repos/Frenzie/koreader/milestones{/number}","notifications_url":"https://api.github.com/repos/Frenzie/koreader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Frenzie/koreader/labels{/name}","releases_url":"https://api.github.com/repos/Frenzie/koreader/releases{/id}","deployments_url":"https://api.github.com/repos/Frenzie/koreader/deployments","created_at":"2016-12-13T13:36:46Z","updated_at":"2016-12-13T13:36:49Z","pushed_at":"2017-04-03T16:35:10Z","git_url":"git://github.com/Frenzie/koreader.git","ssh_url":"git@github.com:Frenzie/koreader.git","clone_url":"https://github.com/Frenzie/koreader.git","svn_url":"https://github.com/Frenzie/koreader","homepage":"","size":35982,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"koreader:master","ref":"master","sha":"d91bd91840342168130ef58ebb8fa3a58ebce98d","user":{"login":"koreader","id":3957564,"avatar_url":"https://avatars3.githubusercontent.com/u/3957564?v=3","gravatar_id":"","url":"https://api.github.com/users/koreader","html_url":"https://github.com/koreader","followers_url":"https://api.github.com/users/koreader/followers","following_url":"https://api.github.com/users/koreader/following{/other_user}","gists_url":"https://api.github.com/users/koreader/gists{/gist_id}","starred_url":"https://api.github.com/users/koreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koreader/subscriptions","organizations_url":"https://api.github.com/users/koreader/orgs","repos_url":"https://api.github.com/users/koreader/repos","events_url":"https://api.github.com/users/koreader/events{/privacy}","received_events_url":"https://api.github.com/users/koreader/received_events","type":"Organization","site_admin":false},"repo":{"id":8986217,"name":"koreader","full_name":"koreader/koreader","owner":{"login":"koreader","id":3957564,"avatar_url":"https://avatars3.githubusercontent.com/u/3957564?v=3","gravatar_id":"","url":"https://api.github.com/users/koreader","html_url":"https://github.com/koreader","followers_url":"https://api.github.com/users/koreader/followers","following_url":"https://api.github.com/users/koreader/following{/other_user}","gists_url":"https://api.github.com/users/koreader/gists{/gist_id}","starred_url":"https://api.github.com/users/koreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koreader/subscriptions","organizations_url":"https://api.github.com/users/koreader/orgs","repos_url":"https://api.github.com/users/koreader/repos","events_url":"https://api.github.com/users/koreader/events{/privacy}","received_events_url":"https://api.github.com/users/koreader/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koreader/koreader","description":"An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Kindle, Kobo, PocketBook, Ubuntu Touch and Android devices","fork":false,"url":"https://api.github.com/repos/koreader/koreader","forks_url":"https://api.github.com/repos/koreader/koreader/forks","keys_url":"https://api.github.com/repos/koreader/koreader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koreader/koreader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koreader/koreader/teams","hooks_url":"https://api.github.com/repos/koreader/koreader/hooks","issue_events_url":"https://api.github.com/repos/koreader/koreader/issues/events{/number}","events_url":"https://api.github.com/repos/koreader/koreader/events","assignees_url":"https://api.github.com/repos/koreader/koreader/assignees{/user}","branches_url":"https://api.github.com/repos/koreader/koreader/branches{/branch}","tags_url":"https://api.github.com/repos/koreader/koreader/tags","blobs_url":"https://api.github.com/repos/koreader/koreader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koreader/koreader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koreader/koreader/git/refs{/sha}","trees_url":"https://api.github.com/repos/koreader/koreader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koreader/koreader/statuses/{sha}","languages_url":"https://api.github.com/repos/koreader/koreader/languages","stargazers_url":"https://api.github.com/repos/koreader/koreader/stargazers","contributors_url":"https://api.github.com/repos/koreader/koreader/contributors","subscribers_url":"https://api.github.com/repos/koreader/koreader/subscribers","subscription_url":"https://api.github.com/repos/koreader/koreader/subscription","commits_url":"https://api.github.com/repos/koreader/koreader/commits{/sha}","git_commits_url":"https://api.github.com/repos/koreader/koreader/git/commits{/sha}","comments_url":"https://api.github.com/repos/koreader/koreader/comments{/number}","issue_comment_url":"https://api.github.com/repos/koreader/koreader/issues/comments{/number}","contents_url":"https://api.github.com/repos/koreader/koreader/contents/{+path}","compare_url":"https://api.github.com/repos/koreader/koreader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koreader/koreader/merges","archive_url":"https://api.github.com/repos/koreader/koreader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koreader/koreader/downloads","issues_url":"https://api.github.com/repos/koreader/koreader/issues{/number}","pulls_url":"https://api.github.com/repos/koreader/koreader/pulls{/number}","milestones_url":"https://api.github.com/repos/koreader/koreader/milestones{/number}","notifications_url":"https://api.github.com/repos/koreader/koreader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koreader/koreader/labels{/name}","releases_url":"https://api.github.com/repos/koreader/koreader/releases{/id}","deployments_url":"https://api.github.com/repos/koreader/koreader/deployments","created_at":"2013-03-24T13:09:42Z","updated_at":"2017-04-03T08:48:05Z","pushed_at":"2017-04-03T13:02:39Z","git_url":"git://github.com/koreader/koreader.git","ssh_url":"git@github.com:koreader/koreader.git","clone_url":"https://github.com/koreader/koreader.git","svn_url":"https://github.com/koreader/koreader","homepage":"","size":35969,"stargazers_count":2803,"watchers_count":2803,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"open_issues_count":274,"forks":425,"open_issues":274,"watchers":2803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koreader/koreader/pulls/2712"},"html":{"href":"https://github.com/koreader/koreader/pull/2712"},"issue":{"href":"https://api.github.com/repos/koreader/koreader/issues/2712"},"comments":{"href":"https://api.github.com/repos/koreader/koreader/issues/2712/comments"},"review_comments":{"href":"https://api.github.com/repos/koreader/koreader/pulls/2712/comments"},"review_comment":{"href":"https://api.github.com/repos/koreader/koreader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koreader/koreader/pulls/2712/commits"},"statuses":{"href":"https://api.github.com/repos/koreader/koreader/statuses/d0edeebbbb98e31d1a38db15e3078d42703ed7b9"}}}}
{"actor":{"display_login":"houqp"}}