{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/97169432","pull_request_review_id":17778979,"id":97169432,"diff_hunk":"@@ -0,0 +1,294 @@\n+/**\n+* \\copyright\n+* Copyright (c) 2012-2017, OpenGeoSys Community (http://www.opengeosys.org)\n+*            Distributed under a Modified BSD License.\n+*              See accompanying file LICENSE.txt or\n+*              http://www.opengeosys.org/project/license\n+*\n+*/\n+\n+#include \"TwoPhaseFlowWithPrhoMaterialProperties.h\"\n+#include <logog/include/logog.hpp>\n+#include \"BaseLib/reorderVector.h\"\n+#include \"MaterialLib/Fluid/FluidProperty.h\"\n+#include \"MaterialLib/PorousMedium/Porosity/Porosity.h\"\n+#include \"MaterialLib/PorousMedium/Storage/Storage.h\"\n+#include \"MaterialLib/PorousMedium/UnsaturatedProperty/CapillaryPressure/CapillaryPressureSaturation.h\"\n+#include \"MaterialLib/PorousMedium/UnsaturatedProperty/CapillaryPressure/CreateCapillaryPressureModel.h\"\n+#include \"MaterialLib/PorousMedium/UnsaturatedProperty/RelativePermeability/CreateRelativePermeabilityModel.h\"\n+#include \"MaterialLib/PorousMedium/UnsaturatedProperty/RelativePermeability/RelativePermeability.h\"\n+#include \"MathLib/InterpolationAlgorithms/PiecewiseLinearInterpolation.h\"\n+#include \"MeshLib/Mesh.h\"\n+#include \"MeshLib/PropertyVector.h\"\n+#include \"NumLib/NewtonRaphson.h\"\n+#include \"ProcessLib/Parameter/Parameter.h\"\n+#include \"ProcessLib/Parameter/SpatialPosition.h\"\n+namespace ProcessLib\n+{\n+namespace TwoPhaseFlowWithPrho\n+{\n+TwoPhaseFlowWithPrhoMaterialProperties::TwoPhaseFlowWithPrhoMaterialProperties(\n+    bool const has_material_ids,\n+    MeshLib::PropertyVector<int> const& material_ids,\n+    std::unique_ptr<MaterialLib::Fluid::FluidProperty>\n+        liquid_density,\n+    std::unique_ptr<MaterialLib::Fluid::FluidProperty>\n+        viscosity,\n+    std::unique_ptr<MaterialLib::Fluid::FluidProperty>\n+        gas_density,\n+    std::unique_ptr<MaterialLib::Fluid::FluidProperty>\n+        gas_viscosity,\n+    std::vector<Eigen::MatrixXd>\n+        intrinsic_permeability_models,\n+    std::vector<std::unique_ptr<MaterialLib::PorousMedium::Porosity>>&&\n+        porosity_models,\n+    std::vector<std::unique_ptr<MaterialLib::PorousMedium::Storage>>&&\n+        storage_models,\n+    std::vector<std::unique_ptr<\n+        MaterialLib::PorousMedium::CapillaryPressureSaturation>>&&\n+        capillary_pressure_models,\n+    std::vector<\n+        std::unique_ptr<MaterialLib::PorousMedium::RelativePermeability>>&&\n+        relative_permeability_models)\n+    : _has_material_ids(has_material_ids),\n+      _liquid_density(std::move(liquid_density)),\n+      _viscosity(std::move(viscosity)),\n+      _gas_density(std::move(gas_density)),\n+      _gas_viscosity(std::move(gas_viscosity)),\n+      _material_ids(material_ids),\n+      _intrinsic_permeability_models(intrinsic_permeability_models),\n+      _porosity_models(std::move(porosity_models)),\n+      _storage_models(std::move(storage_models)),\n+      _capillary_pressure_models(std::move(capillary_pressure_models)),\n+      _relative_permeability_models(std::move(relative_permeability_models))\n+{\n+    DBUG(\"Create material properties for Two-Phase flow with PP model.\");\n+}\n+\n+void TwoPhaseFlowWithPrhoMaterialProperties::setMaterialID(\n+    const ProcessLib::SpatialPosition& pos)","path":"ProcessLib/TwoPhaseFlowWithPrho/TwoPhaseFlowWithPrhoMaterialProperties.cpp","position":69,"original_position":69,"commit_id":"262a37ad9a5682a99c9803e357fb157fdd362a3e","original_commit_id":"262a37ad9a5682a99c9803e357fb157fdd362a3e","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"body":"I think it would be better to pass the material id here. Spatial position might not have the element id set, which is not checked in the function's body.","created_at":"2017-01-20T22:33:08Z","updated_at":"2017-01-20T22:33:08Z","html_url":"https://github.com/ufz/ogs/pull/1613#discussion_r97169432","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1613","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/97169432"},"html":{"href":"https://github.com/ufz/ogs/pull/1613#discussion_r97169432"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1613"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1613","id":97870149,"html_url":"https://github.com/ufz/ogs/pull/1613","diff_url":"https://github.com/ufz/ogs/pull/1613.diff","patch_url":"https://github.com/ufz/ogs/pull/1613.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1613","number":1613,"state":"open","locked":false,"title":"Create two phase flow process with total mass density model(WIP)","user":{"login":"Yonghui56","id":6373576,"avatar_url":"https://avatars.githubusercontent.com/u/6373576?v=3","gravatar_id":"","url":"https://api.github.com/users/Yonghui56","html_url":"https://github.com/Yonghui56","followers_url":"https://api.github.com/users/Yonghui56/followers","following_url":"https://api.github.com/users/Yonghui56/following{/other_user}","gists_url":"https://api.github.com/users/Yonghui56/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonghui56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonghui56/subscriptions","organizations_url":"https://api.github.com/users/Yonghui56/orgs","repos_url":"https://api.github.com/users/Yonghui56/repos","events_url":"https://api.github.com/users/Yonghui56/events{/privacy}","received_events_url":"https://api.github.com/users/Yonghui56/received_events","type":"User","site_admin":false},"body":"As titled, this pr creates a process aiming to handle two phase multi-component process. The wetting phase pressure and total mass density are selected as primary variables. Local constitutive relations are based on Henry law and Ideal gas law and local Newton is applied for the nonlinearity. Regularized van Genuchten PC-S model is complemented to the original vG model.\r\n(@endJunction could you please help me to add a WIP label)","created_at":"2016-12-14T01:19:26Z","updated_at":"2017-01-20T22:33:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"812eb91142caf952b9308c83e90c5107e46c5a58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1613/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1613/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1613/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/262a37ad9a5682a99c9803e357fb157fdd362a3e","head":{"label":"Yonghui56:pr_2phase_totalmassdensity_pl_wip","ref":"pr_2phase_totalmassdensity_pl_wip","sha":"262a37ad9a5682a99c9803e357fb157fdd362a3e","user":{"login":"Yonghui56","id":6373576,"avatar_url":"https://avatars.githubusercontent.com/u/6373576?v=3","gravatar_id":"","url":"https://api.github.com/users/Yonghui56","html_url":"https://github.com/Yonghui56","followers_url":"https://api.github.com/users/Yonghui56/followers","following_url":"https://api.github.com/users/Yonghui56/following{/other_user}","gists_url":"https://api.github.com/users/Yonghui56/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonghui56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonghui56/subscriptions","organizations_url":"https://api.github.com/users/Yonghui56/orgs","repos_url":"https://api.github.com/users/Yonghui56/repos","events_url":"https://api.github.com/users/Yonghui56/events{/privacy}","received_events_url":"https://api.github.com/users/Yonghui56/received_events","type":"User","site_admin":false},"repo":{"id":59653351,"name":"ogs","full_name":"Yonghui56/ogs","owner":{"login":"Yonghui56","id":6373576,"avatar_url":"https://avatars.githubusercontent.com/u/6373576?v=3","gravatar_id":"","url":"https://api.github.com/users/Yonghui56","html_url":"https://github.com/Yonghui56","followers_url":"https://api.github.com/users/Yonghui56/followers","following_url":"https://api.github.com/users/Yonghui56/following{/other_user}","gists_url":"https://api.github.com/users/Yonghui56/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonghui56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonghui56/subscriptions","organizations_url":"https://api.github.com/users/Yonghui56/orgs","repos_url":"https://api.github.com/users/Yonghui56/repos","events_url":"https://api.github.com/users/Yonghui56/events{/privacy}","received_events_url":"https://api.github.com/users/Yonghui56/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yonghui56/ogs","description":"Experimental OGS-6 source code","fork":true,"url":"https://api.github.com/repos/Yonghui56/ogs","forks_url":"https://api.github.com/repos/Yonghui56/ogs/forks","keys_url":"https://api.github.com/repos/Yonghui56/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yonghui56/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yonghui56/ogs/teams","hooks_url":"https://api.github.com/repos/Yonghui56/ogs/hooks","issue_events_url":"https://api.github.com/repos/Yonghui56/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/Yonghui56/ogs/events","assignees_url":"https://api.github.com/repos/Yonghui56/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/Yonghui56/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/Yonghui56/ogs/tags","blobs_url":"https://api.github.com/repos/Yonghui56/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yonghui56/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yonghui56/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yonghui56/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yonghui56/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/Yonghui56/ogs/languages","stargazers_url":"https://api.github.com/repos/Yonghui56/ogs/stargazers","contributors_url":"https://api.github.com/repos/Yonghui56/ogs/contributors","subscribers_url":"https://api.github.com/repos/Yonghui56/ogs/subscribers","subscription_url":"https://api.github.com/repos/Yonghui56/ogs/subscription","commits_url":"https://api.github.com/repos/Yonghui56/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yonghui56/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yonghui56/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yonghui56/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yonghui56/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/Yonghui56/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yonghui56/ogs/merges","archive_url":"https://api.github.com/repos/Yonghui56/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yonghui56/ogs/downloads","issues_url":"https://api.github.com/repos/Yonghui56/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/Yonghui56/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/Yonghui56/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/Yonghui56/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yonghui56/ogs/labels{/name}","releases_url":"https://api.github.com/repos/Yonghui56/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/Yonghui56/ogs/deployments","created_at":"2016-05-25T10:15:44Z","updated_at":"2016-06-29T01:05:24Z","pushed_at":"2017-01-20T18:28:00Z","git_url":"git://github.com/Yonghui56/ogs.git","ssh_url":"git@github.com:Yonghui56/ogs.git","clone_url":"https://github.com/Yonghui56/ogs.git","svn_url":"https://github.com/Yonghui56/ogs","homepage":"www.opengeosys.org","size":17485,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"373a18ab29af5ce980e87fd721e34a297b6a7ea3","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2017-01-11T10:38:46Z","pushed_at":"2017-01-20T18:28:02Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":17090,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":114,"forks":60,"open_issues":114,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1613"},"html":{"href":"https://github.com/ufz/ogs/pull/1613"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1613"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1613/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1613/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1613/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/262a37ad9a5682a99c9803e357fb157fdd362a3e"}}}}
{"actor":{"display_login":"endJunction"}}