{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2729","repository_url":"https://api.github.com/repos/openmicroscopy/bioformats","labels_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2729/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2729/comments","events_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2729/events","html_url":"https://github.com/openmicroscopy/bioformats/pull/2729","id":201272430,"number":2729,"title":"Correct order of frames for tilescan with timeseries","user":{"login":"michaelgoelzer","id":18674959,"avatar_url":"https://avatars.githubusercontent.com/u/18674959?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelgoelzer","html_url":"https://github.com/michaelgoelzer","followers_url":"https://api.github.com/users/michaelgoelzer/followers","following_url":"https://api.github.com/users/michaelgoelzer/following{/other_user}","gists_url":"https://api.github.com/users/michaelgoelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgoelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgoelzer/subscriptions","organizations_url":"https://api.github.com/users/michaelgoelzer/orgs","repos_url":"https://api.github.com/users/michaelgoelzer/repos","events_url":"https://api.github.com/users/michaelgoelzer/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgoelzer/received_events","type":"User","site_admin":false},"labels":[{"id":29522976,"url":"https://api.github.com/repos/openmicroscopy/bioformats/labels/include","name":"include","color":"aabbcc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-17T12:51:21Z","updated_at":"2017-01-30T08:19:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2729","html_url":"https://github.com/openmicroscopy/bioformats/pull/2729","diff_url":"https://github.com/openmicroscopy/bioformats/pull/2729.diff","patch_url":"https://github.com/openmicroscopy/bioformats/pull/2729.patch"},"body":"We previously assumed tiles are always the outermost dimension. This is\r\nnot always the case, resulting in mixed up frames for certain scan\r\ntypes."},"comment":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/comments/276002342","html_url":"https://github.com/openmicroscopy/bioformats/pull/2729#issuecomment-276002342","issue_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2729","id":276002342,"user":{"login":"michaelgoelzer","id":18674959,"avatar_url":"https://avatars.githubusercontent.com/u/18674959?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelgoelzer","html_url":"https://github.com/michaelgoelzer","followers_url":"https://api.github.com/users/michaelgoelzer/followers","following_url":"https://api.github.com/users/michaelgoelzer/following{/other_user}","gists_url":"https://api.github.com/users/michaelgoelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgoelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgoelzer/subscriptions","organizations_url":"https://api.github.com/users/michaelgoelzer/orgs","repos_url":"https://api.github.com/users/michaelgoelzer/repos","events_url":"https://api.github.com/users/michaelgoelzer/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgoelzer/received_events","type":"User","site_admin":false},"created_at":"2017-01-30T08:19:31Z","updated_at":"2017-01-30T08:19:31Z","body":"Well, I don't know much about the nature of the tests, so forgive me if this is not a practical test to add.\r\n\r\nA rather straightforward test is that when looking at the OME Metadata after importing the attached file, checking whether all \"Plane\" nodes that have the same parent\r\n* have the same value for the \"PositionX\" attribute\r\n* have the same value for \"PositionY\" attribute\r\n(There are 4 \"Image\" nodes with each 1 \"Pixels\" subnode with each 12 \"Plane\" subnodes)\r\nI think that should cover almost all possible regressions. For slightly better test coverage one could additionally check the order/values of \"TheC\", \"TheT\", \"TheZ\" and \"DeltaT\".\r\n\r\n[PR2729_frameOrderCombinedScanTypes.zip](https://github.com/openmicroscopy/bioformats/files/738358/PR2729_frameOrderCombinedScanTypes.zip)"}}
{"actor":{"display_login":"michaelgoelzer"}}