{"action":"created","comment":{"url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/comments/97658928","pull_request_review_id":18275825,"id":97658928,"diff_hunk":"@@ -152,6 +154,10 @@ struct EnterpriseActiveAuthInteractor: DatabaseAuthenticatable, Loggable {\n             self.logger.error(\"The password of user <\\(self.identifier)> was leaked\")\n             callback(.passwordLeaked)\n             self.dispatcher.dispatch(result: .error(DatabaseAuthenticatableError.passwordLeaked))\n+        case .failure(let cause as AuthenticationError) where cause.code == \"invalid_request\" && cause.description.lowercased().contains(\"oidc conformant\"):","path":"Lock/EnterpriseActiveAuthInteractor.swift","position":20,"original_position":20,"commit_id":"624354172cea931e2b4bae5b1a266f8440139344","original_commit_id":"624354172cea931e2b4bae5b1a266f8440139344","user":{"login":"hzalaz","id":895992,"avatar_url":"https://avatars.githubusercontent.com/u/895992?v=3","gravatar_id":"","url":"https://api.github.com/users/hzalaz","html_url":"https://github.com/hzalaz","followers_url":"https://api.github.com/users/hzalaz/followers","following_url":"https://api.github.com/users/hzalaz/following{/other_user}","gists_url":"https://api.github.com/users/hzalaz/gists{/gist_id}","starred_url":"https://api.github.com/users/hzalaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzalaz/subscriptions","organizations_url":"https://api.github.com/users/hzalaz/orgs","repos_url":"https://api.github.com/users/hzalaz/repos","events_url":"https://api.github.com/users/hzalaz/events{/privacy}","received_events_url":"https://api.github.com/users/hzalaz/received_events","type":"User","site_admin":false},"body":"It's still wrong, and is a log statement and if the library is properly coded you won't be able to trigger this behavior. There is no need to even have a specific error message if we only log it as we want ","created_at":"2017-01-24T21:47:33Z","updated_at":"2017-01-24T21:47:33Z","html_url":"https://github.com/auth0/Lock.iOS-OSX/pull/380#discussion_r97658928","pull_request_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380","_links":{"self":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/comments/97658928"},"html":{"href":"https://github.com/auth0/Lock.iOS-OSX/pull/380#discussion_r97658928"},"pull_request":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380","id":103007509,"html_url":"https://github.com/auth0/Lock.iOS-OSX/pull/380","diff_url":"https://github.com/auth0/Lock.iOS-OSX/pull/380.diff","patch_url":"https://github.com/auth0/Lock.iOS-OSX/pull/380.patch","issue_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/380","number":380,"state":"open","locked":false,"title":"Centralize DatabaseAuthenticable result and error  handling","user":{"login":"cocojoe","id":928115,"avatar_url":"https://avatars.githubusercontent.com/u/928115?v=3","gravatar_id":"","url":"https://api.github.com/users/cocojoe","html_url":"https://github.com/cocojoe","followers_url":"https://api.github.com/users/cocojoe/followers","following_url":"https://api.github.com/users/cocojoe/following{/other_user}","gists_url":"https://api.github.com/users/cocojoe/gists{/gist_id}","starred_url":"https://api.github.com/users/cocojoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocojoe/subscriptions","organizations_url":"https://api.github.com/users/cocojoe/orgs","repos_url":"https://api.github.com/users/cocojoe/repos","events_url":"https://api.github.com/users/cocojoe/events{/privacy}","received_events_url":"https://api.github.com/users/cocojoe/received_events","type":"User","site_admin":false},"body":"Add error for non-OIDC flow when OIDC conformant enabled","created_at":"2017-01-24T21:29:48Z","updated_at":"2017-01-24T21:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9cbd28a34068bdc4c590b9991e4605dd4650939","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380/commits","review_comments_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380/comments","review_comment_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/380/comments","statuses_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/statuses/624354172cea931e2b4bae5b1a266f8440139344","head":{"label":"auth0:feature_oidc_warnings","ref":"feature_oidc_warnings","sha":"624354172cea931e2b4bae5b1a266f8440139344","user":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":12659010,"name":"Lock.iOS-OSX","full_name":"auth0/Lock.iOS-OSX","owner":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/Lock.iOS-OSX","description":"A iOS/OSX framework to authenticate using Auth0 and with a Native Look & Feel","fork":false,"url":"https://api.github.com/repos/auth0/Lock.iOS-OSX","forks_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/forks","keys_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/teams","hooks_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/hooks","issue_events_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/events","assignees_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/tags","blobs_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/languages","stargazers_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/stargazers","contributors_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/contributors","subscribers_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/subscribers","subscription_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/subscription","commits_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/merges","archive_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/downloads","issues_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/labels{/name}","releases_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/releases{/id}","deployments_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/deployments","created_at":"2013-09-07T02:58:43Z","updated_at":"2017-01-11T20:32:33Z","pushed_at":"2017-01-24T21:29:49Z","git_url":"git://github.com/auth0/Lock.iOS-OSX.git","ssh_url":"git@github.com:auth0/Lock.iOS-OSX.git","clone_url":"https://github.com/auth0/Lock.iOS-OSX.git","svn_url":"https://github.com/auth0/Lock.iOS-OSX","homepage":"https://auth0.com/lock","size":10925,"stargazers_count":127,"watchers_count":127,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":9,"forks":60,"open_issues":9,"watchers":127,"default_branch":"master"}},"base":{"label":"auth0:v2","ref":"v2","sha":"8ab2b5ea0bce3fafd98b1dcda5b9eb2a690c088a","user":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":12659010,"name":"Lock.iOS-OSX","full_name":"auth0/Lock.iOS-OSX","owner":{"login":"auth0","id":2824157,"avatar_url":"https://avatars.githubusercontent.com/u/2824157?v=3","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/Lock.iOS-OSX","description":"A iOS/OSX framework to authenticate using Auth0 and with a Native Look & Feel","fork":false,"url":"https://api.github.com/repos/auth0/Lock.iOS-OSX","forks_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/forks","keys_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/teams","hooks_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/hooks","issue_events_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/events","assignees_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/tags","blobs_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/languages","stargazers_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/stargazers","contributors_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/contributors","subscribers_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/subscribers","subscription_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/subscription","commits_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/merges","archive_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/downloads","issues_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/labels{/name}","releases_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/releases{/id}","deployments_url":"https://api.github.com/repos/auth0/Lock.iOS-OSX/deployments","created_at":"2013-09-07T02:58:43Z","updated_at":"2017-01-11T20:32:33Z","pushed_at":"2017-01-24T21:29:49Z","git_url":"git://github.com/auth0/Lock.iOS-OSX.git","ssh_url":"git@github.com:auth0/Lock.iOS-OSX.git","clone_url":"https://github.com/auth0/Lock.iOS-OSX.git","svn_url":"https://github.com/auth0/Lock.iOS-OSX","homepage":"https://auth0.com/lock","size":10925,"stargazers_count":127,"watchers_count":127,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":9,"forks":60,"open_issues":9,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380"},"html":{"href":"https://github.com/auth0/Lock.iOS-OSX/pull/380"},"issue":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/380"},"comments":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/auth0/Lock.iOS-OSX/statuses/624354172cea931e2b4bae5b1a266f8440139344"}}}}
{"actor":{"display_login":"hzalaz"}}