{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/38585","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/38585/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/38585/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/38585/events","html_url":"https://github.com/saltstack/salt/pull/38585","id":198985305,"number":38585,"title":"Follow up to PR #38527","user":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"labels":[{"id":77737132,"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-05T15:41:22Z","updated_at":"2017-01-09T23:47:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/38585","html_url":"https://github.com/saltstack/salt/pull/38585","diff_url":"https://github.com/saltstack/salt/pull/38585.diff","patch_url":"https://github.com/saltstack/salt/pull/38585.patch"},"body":"### What does this PR do?\r\nThis PR back-ports the changes made by @rbjorklin in #38527 to the 2016.3 branch and also adds back in the `log_file` and `pidfile`value settings.\r\n\r\nThis ensures that if `rest_timeout` values are set in the master config file, the value defined in the `DEFAULT_API_OPTS` will not overwrite the value defined in the master config file. (This will also be the case for any additions API default opts that get added to `config/__init__.py` down the line.)\r\n\r\nThis change also ensures that that the `log_file` and `pidfile` values *are* overwritten by the values specified by `api_logfile` and `api_pidfile`, respectively, either explicitly by the user in the master config file or by the values defined by `DEFAULT_API_OPTS`.\r\n\r\nI would like to write a test case for this as well, but I wanted to get some feedback on this approach first.\r\n\r\nThis approach should be covering both the `rest_timeout` setting bug as well as the `log_file` bugs that have been filed recently against this area of the code. The relevant PRs and bug reports are linked below. A more detailed discussion of this change is in #38527.\r\n\r\nI would love it if @whiteinge could review this change as well.\r\n\r\n### What issues does this PR fix or reference?\r\nPRs:\r\n- #38527\r\n- #38560\r\n- #38570\r\n\r\nIssues:\r\n- #38479\r\n- #38524 \r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/271444302","html_url":"https://github.com/saltstack/salt/pull/38585#issuecomment-271444302","issue_url":"https://api.github.com/repos/saltstack/salt/issues/38585","id":271444302,"user":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"created_at":"2017-01-09T23:47:26Z","updated_at":"2017-01-09T23:47:26Z","body":"OK @cachedout and @whiteinge this should be good to go now, depending on the test run."}}
{"actor":{"display_login":"rallytime"}}