{"action":"created","comment":{"url":"https://api.github.com/repos/google/tie/pulls/comments/140370478","pull_request_review_id":64435384,"id":140370478,"diff_hunk":"@@ -489,19 +499,19 @@ tie.directive('learnerView', [function() {\n       </style>\n     `,\n     controller: [\n-      '$scope', '$interval', '$timeout', '$location', 'SolutionHandlerService',\n-      'QuestionDataService', 'LANGUAGE_PYTHON', 'FeedbackObjectFactory',\n-      'ReinforcementObjectFactory', 'LocalStorageService',\n-      'ServerHandlerService', 'SECONDS_TO_MILLISECONDS',\n+      '$scope', '$interval', '$timeout', '$location', '$cookies',","path":"client/question/components/LearnerViewDirective.js","position":51,"original_position":51,"commit_id":"5d55de79c8d151a78ed2aaac59097db7769ab822","original_commit_id":"5d55de79c8d151a78ed2aaac59097db7769ab822","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"Move dependency on $cookies to a separate service, as discussed.","created_at":"2017-09-21T22:00:28Z","updated_at":"2017-09-21T22:09:07Z","html_url":"https://github.com/google/tie/pull/406#discussion_r140370478","pull_request_url":"https://api.github.com/repos/google/tie/pulls/406","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/tie/pulls/comments/140370478"},"html":{"href":"https://github.com/google/tie/pull/406#discussion_r140370478"},"pull_request":{"href":"https://api.github.com/repos/google/tie/pulls/406"}}},"pull_request":{"url":"https://api.github.com/repos/google/tie/pulls/406","id":142239446,"html_url":"https://github.com/google/tie/pull/406","diff_url":"https://github.com/google/tie/pull/406.diff","patch_url":"https://github.com/google/tie/pull/406.patch","issue_url":"https://api.github.com/repos/google/tie/issues/406","number":406,"state":"open","locked":false,"title":"Privacy Modal","user":{"login":"theresa-lee","id":4167437,"avatar_url":"https://avatars1.githubusercontent.com/u/4167437?v=4","gravatar_id":"","url":"https://api.github.com/users/theresa-lee","html_url":"https://github.com/theresa-lee","followers_url":"https://api.github.com/users/theresa-lee/followers","following_url":"https://api.github.com/users/theresa-lee/following{/other_user}","gists_url":"https://api.github.com/users/theresa-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/theresa-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theresa-lee/subscriptions","organizations_url":"https://api.github.com/users/theresa-lee/orgs","repos_url":"https://api.github.com/users/theresa-lee/repos","events_url":"https://api.github.com/users/theresa-lee/events{/privacy}","received_events_url":"https://api.github.com/users/theresa-lee/received_events","type":"User","site_admin":false},"body":"This modal has different behavior for the client and server version:\r\n\r\nFor the client version, this will not show up on page load, but will give a popup if you click on the 'Privacy' text. It's just text and an okay button. \r\n\r\nFor the server version, this will show up on page load (unless you have accepted beforehand), and if the user accepts and it's not a shared computer, the cookie will last for 1 year. If it is a shared computer, it will last for the session. If the user rejects, it will bring them back to the menu page.\r\n\r\nCookies don't work for local files so you won't be able to test that locally I think. If you toggle the 2 instances of \"SERVER_URL\" in LearnerView, then you should be able to see the modal change (however, it still won't remember your decision).","created_at":"2017-09-21T01:47:13Z","updated_at":"2017-09-21T22:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76cb53be3b291f93d8546503fb289bdbdefce689","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/tie/pulls/406/commits","review_comments_url":"https://api.github.com/repos/google/tie/pulls/406/comments","review_comment_url":"https://api.github.com/repos/google/tie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/tie/issues/406/comments","statuses_url":"https://api.github.com/repos/google/tie/statuses/5d55de79c8d151a78ed2aaac59097db7769ab822","head":{"label":"google:privacy-modal","ref":"privacy-modal","sha":"5d55de79c8d151a78ed2aaac59097db7769ab822","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81500046,"name":"tie","full_name":"google/tie","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/tie","description":null,"fork":false,"url":"https://api.github.com/repos/google/tie","forks_url":"https://api.github.com/repos/google/tie/forks","keys_url":"https://api.github.com/repos/google/tie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/tie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/tie/teams","hooks_url":"https://api.github.com/repos/google/tie/hooks","issue_events_url":"https://api.github.com/repos/google/tie/issues/events{/number}","events_url":"https://api.github.com/repos/google/tie/events","assignees_url":"https://api.github.com/repos/google/tie/assignees{/user}","branches_url":"https://api.github.com/repos/google/tie/branches{/branch}","tags_url":"https://api.github.com/repos/google/tie/tags","blobs_url":"https://api.github.com/repos/google/tie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/tie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/tie/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/tie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/tie/statuses/{sha}","languages_url":"https://api.github.com/repos/google/tie/languages","stargazers_url":"https://api.github.com/repos/google/tie/stargazers","contributors_url":"https://api.github.com/repos/google/tie/contributors","subscribers_url":"https://api.github.com/repos/google/tie/subscribers","subscription_url":"https://api.github.com/repos/google/tie/subscription","commits_url":"https://api.github.com/repos/google/tie/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/tie/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/tie/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/tie/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/tie/contents/{+path}","compare_url":"https://api.github.com/repos/google/tie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/tie/merges","archive_url":"https://api.github.com/repos/google/tie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/tie/downloads","issues_url":"https://api.github.com/repos/google/tie/issues{/number}","pulls_url":"https://api.github.com/repos/google/tie/pulls{/number}","milestones_url":"https://api.github.com/repos/google/tie/milestones{/number}","notifications_url":"https://api.github.com/repos/google/tie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/tie/labels{/name}","releases_url":"https://api.github.com/repos/google/tie/releases{/id}","deployments_url":"https://api.github.com/repos/google/tie/deployments","created_at":"2017-02-09T22:11:24Z","updated_at":"2017-09-18T19:52:15Z","pushed_at":"2017-09-21T21:06:23Z","git_url":"git://github.com/google/tie.git","ssh_url":"git@github.com:google/tie.git","clone_url":"https://github.com/google/tie.git","svn_url":"https://github.com/google/tie","homepage":null,"size":1649,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":31,"forks":35,"open_issues":31,"watchers":155,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"bc4c0dedc6c18c2d8dc5a34fc95a3e30946aad39","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81500046,"name":"tie","full_name":"google/tie","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/tie","description":null,"fork":false,"url":"https://api.github.com/repos/google/tie","forks_url":"https://api.github.com/repos/google/tie/forks","keys_url":"https://api.github.com/repos/google/tie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/tie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/tie/teams","hooks_url":"https://api.github.com/repos/google/tie/hooks","issue_events_url":"https://api.github.com/repos/google/tie/issues/events{/number}","events_url":"https://api.github.com/repos/google/tie/events","assignees_url":"https://api.github.com/repos/google/tie/assignees{/user}","branches_url":"https://api.github.com/repos/google/tie/branches{/branch}","tags_url":"https://api.github.com/repos/google/tie/tags","blobs_url":"https://api.github.com/repos/google/tie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/tie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/tie/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/tie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/tie/statuses/{sha}","languages_url":"https://api.github.com/repos/google/tie/languages","stargazers_url":"https://api.github.com/repos/google/tie/stargazers","contributors_url":"https://api.github.com/repos/google/tie/contributors","subscribers_url":"https://api.github.com/repos/google/tie/subscribers","subscription_url":"https://api.github.com/repos/google/tie/subscription","commits_url":"https://api.github.com/repos/google/tie/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/tie/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/tie/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/tie/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/tie/contents/{+path}","compare_url":"https://api.github.com/repos/google/tie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/tie/merges","archive_url":"https://api.github.com/repos/google/tie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/tie/downloads","issues_url":"https://api.github.com/repos/google/tie/issues{/number}","pulls_url":"https://api.github.com/repos/google/tie/pulls{/number}","milestones_url":"https://api.github.com/repos/google/tie/milestones{/number}","notifications_url":"https://api.github.com/repos/google/tie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/tie/labels{/name}","releases_url":"https://api.github.com/repos/google/tie/releases{/id}","deployments_url":"https://api.github.com/repos/google/tie/deployments","created_at":"2017-02-09T22:11:24Z","updated_at":"2017-09-18T19:52:15Z","pushed_at":"2017-09-21T21:06:23Z","git_url":"git://github.com/google/tie.git","ssh_url":"git@github.com:google/tie.git","clone_url":"https://github.com/google/tie.git","svn_url":"https://github.com/google/tie","homepage":null,"size":1649,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":31,"forks":35,"open_issues":31,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/tie/pulls/406"},"html":{"href":"https://github.com/google/tie/pull/406"},"issue":{"href":"https://api.github.com/repos/google/tie/issues/406"},"comments":{"href":"https://api.github.com/repos/google/tie/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/google/tie/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/google/tie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/tie/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/google/tie/statuses/5d55de79c8d151a78ed2aaac59097db7769ab822"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"seanlip"}}