{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-installation/pulls/comments/101547682","pull_request_review_id":22279460,"id":101547682,"diff_hunk":"@@ -18,13 +18,25 @@ def run\n       # helpful when testing all manually on a running system\n       Yast::Wizard.CreateDialog if separate_wizard_needed?\n \n-      ret = Yast::CWM.show(\n-        content,\n-        caption: _(\"Computer Role\")\n-      )\n+      ret = nil\n+      loop do\n+        ret = Yast::CWM.show(\n+          content,\n+          caption: _(\"Computer Role\"),\n+          skip_store_for: [:redraw]\n+        )\n+        break if ret != :redraw\n+      end\n \n       Yast::Wizard.CloseDialog if separate_wizard_needed?\n \n+      # support passing addon as cmd argument, openQA use it for testing\n+      if !Yast::Linuxrc.InstallInf(\"addon\").nil?","path":"src/lib/installation/dialogs/desktop_roles.rb","position":null,"original_position":29,"commit_id":"1d005be6cf507e4555db4e2bb40997da29d87efa","original_commit_id":"1d005be6cf507e4555db4e2bb40997da29d87efa","user":{"login":"lslezak","id":907998,"avatar_url":"https://avatars.githubusercontent.com/u/907998?v=3","gravatar_id":"","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"I prefer to use the condition without the negative operator when the `if` contains both branches.","created_at":"2017-02-16T15:38:43Z","updated_at":"2017-02-16T15:41:05Z","html_url":"https://github.com/yast/yast-installation/pull/515#discussion_r101547682","pull_request_url":"https://api.github.com/repos/yast/yast-installation/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-installation/pulls/comments/101547682"},"html":{"href":"https://github.com/yast/yast-installation/pull/515#discussion_r101547682"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-installation/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-installation/pulls/515","id":104969967,"html_url":"https://github.com/yast/yast-installation/pull/515","diff_url":"https://github.com/yast/yast-installation/pull/515.diff","patch_url":"https://github.com/yast/yast-installation/pull/515.patch","issue_url":"https://api.github.com/repos/yast/yast-installation/issues/515","number":515,"state":"open","locked":false,"title":"new desktop selection","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?v=3","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-07T09:55:47Z","updated_at":"2017-02-16T15:41:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e6db8a73371990b84fcf66cf5f7107483b4f768","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-installation/pulls/515/commits","review_comments_url":"https://api.github.com/repos/yast/yast-installation/pulls/515/comments","review_comment_url":"https://api.github.com/repos/yast/yast-installation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-installation/issues/515/comments","statuses_url":"https://api.github.com/repos/yast/yast-installation/statuses/1d005be6cf507e4555db4e2bb40997da29d87efa","head":{"label":"yast:new_desktop_selection","ref":"new_desktop_selection","sha":"1d005be6cf507e4555db4e2bb40997da29d87efa","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368120,"name":"yast-installation","full_name":"yast/yast-installation","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-installation","description":"YaST module installation","fork":false,"url":"https://api.github.com/repos/yast/yast-installation","forks_url":"https://api.github.com/repos/yast/yast-installation/forks","keys_url":"https://api.github.com/repos/yast/yast-installation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-installation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-installation/teams","hooks_url":"https://api.github.com/repos/yast/yast-installation/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-installation/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-installation/events","assignees_url":"https://api.github.com/repos/yast/yast-installation/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-installation/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-installation/tags","blobs_url":"https://api.github.com/repos/yast/yast-installation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-installation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-installation/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-installation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-installation/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-installation/languages","stargazers_url":"https://api.github.com/repos/yast/yast-installation/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-installation/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-installation/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-installation/subscription","commits_url":"https://api.github.com/repos/yast/yast-installation/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-installation/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-installation/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-installation/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-installation/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-installation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-installation/merges","archive_url":"https://api.github.com/repos/yast/yast-installation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-installation/downloads","issues_url":"https://api.github.com/repos/yast/yast-installation/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-installation/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-installation/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-installation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-installation/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-installation/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-installation/deployments","created_at":"2012-05-18T10:23:52Z","updated_at":"2016-08-24T15:00:52Z","pushed_at":"2017-02-16T14:53:50Z","git_url":"git://github.com/yast/yast-installation.git","ssh_url":"git@github.com:yast/yast-installation.git","clone_url":"https://github.com/yast/yast-installation.git","svn_url":"https://github.com/yast/yast-installation","homepage":"http://en.opensuse.org/Portal:YaST","size":31569,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":3,"forks":24,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"0640ed0a110f59033f9f80f8702115b90bd40617","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368120,"name":"yast-installation","full_name":"yast/yast-installation","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-installation","description":"YaST module installation","fork":false,"url":"https://api.github.com/repos/yast/yast-installation","forks_url":"https://api.github.com/repos/yast/yast-installation/forks","keys_url":"https://api.github.com/repos/yast/yast-installation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-installation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-installation/teams","hooks_url":"https://api.github.com/repos/yast/yast-installation/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-installation/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-installation/events","assignees_url":"https://api.github.com/repos/yast/yast-installation/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-installation/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-installation/tags","blobs_url":"https://api.github.com/repos/yast/yast-installation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-installation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-installation/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-installation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-installation/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-installation/languages","stargazers_url":"https://api.github.com/repos/yast/yast-installation/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-installation/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-installation/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-installation/subscription","commits_url":"https://api.github.com/repos/yast/yast-installation/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-installation/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-installation/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-installation/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-installation/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-installation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-installation/merges","archive_url":"https://api.github.com/repos/yast/yast-installation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-installation/downloads","issues_url":"https://api.github.com/repos/yast/yast-installation/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-installation/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-installation/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-installation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-installation/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-installation/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-installation/deployments","created_at":"2012-05-18T10:23:52Z","updated_at":"2016-08-24T15:00:52Z","pushed_at":"2017-02-16T14:53:50Z","git_url":"git://github.com/yast/yast-installation.git","ssh_url":"git@github.com:yast/yast-installation.git","clone_url":"https://github.com/yast/yast-installation.git","svn_url":"https://github.com/yast/yast-installation","homepage":"http://en.opensuse.org/Portal:YaST","size":31569,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":3,"forks":24,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-installation/pulls/515"},"html":{"href":"https://github.com/yast/yast-installation/pull/515"},"issue":{"href":"https://api.github.com/repos/yast/yast-installation/issues/515"},"comments":{"href":"https://api.github.com/repos/yast/yast-installation/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-installation/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-installation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-installation/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-installation/statuses/1d005be6cf507e4555db4e2bb40997da29d87efa"}}}}
{"actor":{"display_login":"lslezak"}}