{"action":"closed","number":605,"pull_request":{"url":"https://api.github.com/repos/reactor/reactor-core/pulls/605","id":120662357,"html_url":"https://github.com/reactor/reactor-core/pull/605","diff_url":"https://github.com/reactor/reactor-core/pull/605.diff","patch_url":"https://github.com/reactor/reactor-core/pull/605.patch","issue_url":"https://api.github.com/repos/reactor/reactor-core/issues/605","number":605,"state":"closed","locked":false,"title":"fix #566 Simplify Mono.subscribe, move the old behavior in toProcessor","user":{"login":"simonbasle","id":6986166,"avatar_url":"https://avatars3.githubusercontent.com/u/6986166?v=3","gravatar_id":"","url":"https://api.github.com/users/simonbasle","html_url":"https://github.com/simonbasle","followers_url":"https://api.github.com/users/simonbasle/followers","following_url":"https://api.github.com/users/simonbasle/following{/other_user}","gists_url":"https://api.github.com/users/simonbasle/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbasle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbasle/subscriptions","organizations_url":"https://api.github.com/users/simonbasle/orgs","repos_url":"https://api.github.com/users/simonbasle/repos","events_url":"https://api.github.com/users/simonbasle/events{/privacy}","received_events_url":"https://api.github.com/users/simonbasle/received_events","type":"User","site_admin":false},"body":"This commit simplifies the `subscribe()` method of Mono to align it with\nFlux, returning a Disposable (that is actually a no-callback subscriber\nsimilar to the one returned in callback-based subscribe methods).\n\nIf the current instance is a MonoProcessor, connect that MonoProcessor\nlike before.\n\nThe wrapping into a returned MonoProcessor is now accessible in the\n`toProcessor` method. However to exactly reproduce the previous behavior\none will need to call .toProcessor() then .subscribe(). This won't\nalways be hinted at by a compilation error.","created_at":"2017-05-15T18:16:18Z","updated_at":"2017-05-22T16:30:03Z","closed_at":"2017-05-22T16:30:03Z","merged_at":"2017-05-22T16:30:03Z","merge_commit_sha":"798edd34091c0a589669bc480b5922d2fe91177f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/reactor/reactor-core/milestones/17","html_url":"https://github.com/reactor/reactor-core/milestone/17","labels_url":"https://api.github.com/repos/reactor/reactor-core/milestones/17/labels","id":2457081,"number":17,"title":"3.1.0.M2","description":"","creator":{"login":"smaldini","id":76718,"avatar_url":"https://avatars1.githubusercontent.com/u/76718?v=3","gravatar_id":"","url":"https://api.github.com/users/smaldini","html_url":"https://github.com/smaldini","followers_url":"https://api.github.com/users/smaldini/followers","following_url":"https://api.github.com/users/smaldini/following{/other_user}","gists_url":"https://api.github.com/users/smaldini/gists{/gist_id}","starred_url":"https://api.github.com/users/smaldini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaldini/subscriptions","organizations_url":"https://api.github.com/users/smaldini/orgs","repos_url":"https://api.github.com/users/smaldini/repos","events_url":"https://api.github.com/users/smaldini/events{/privacy}","received_events_url":"https://api.github.com/users/smaldini/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":16,"state":"open","created_at":"2017-04-14T10:10:51Z","updated_at":"2017-05-22T16:30:03Z","due_on":"2017-05-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/reactor/reactor-core/pulls/605/commits","review_comments_url":"https://api.github.com/repos/reactor/reactor-core/pulls/605/comments","review_comment_url":"https://api.github.com/repos/reactor/reactor-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactor/reactor-core/issues/605/comments","statuses_url":"https://api.github.com/repos/reactor/reactor-core/statuses/119b3de6d55a1abd6123ce49feec02fdf12ede39","head":{"label":"reactor:566-monoSubscribeDisposable","ref":"566-monoSubscribeDisposable","sha":"119b3de6d55a1abd6123ce49feec02fdf12ede39","user":{"login":"reactor","id":4201559,"avatar_url":"https://avatars0.githubusercontent.com/u/4201559?v=3","gravatar_id":"","url":"https://api.github.com/users/reactor","html_url":"https://github.com/reactor","followers_url":"https://api.github.com/users/reactor/followers","following_url":"https://api.github.com/users/reactor/following{/other_user}","gists_url":"https://api.github.com/users/reactor/gists{/gist_id}","starred_url":"https://api.github.com/users/reactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactor/subscriptions","organizations_url":"https://api.github.com/users/reactor/orgs","repos_url":"https://api.github.com/users/reactor/repos","events_url":"https://api.github.com/users/reactor/events{/privacy}","received_events_url":"https://api.github.com/users/reactor/received_events","type":"Organization","site_admin":false},"repo":{"id":45903621,"name":"reactor-core","full_name":"reactor/reactor-core","owner":{"login":"reactor","id":4201559,"avatar_url":"https://avatars0.githubusercontent.com/u/4201559?v=3","gravatar_id":"","url":"https://api.github.com/users/reactor","html_url":"https://github.com/reactor","followers_url":"https://api.github.com/users/reactor/followers","following_url":"https://api.github.com/users/reactor/following{/other_user}","gists_url":"https://api.github.com/users/reactor/gists{/gist_id}","starred_url":"https://api.github.com/users/reactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactor/subscriptions","organizations_url":"https://api.github.com/users/reactor/orgs","repos_url":"https://api.github.com/users/reactor/repos","events_url":"https://api.github.com/users/reactor/events{/privacy}","received_events_url":"https://api.github.com/users/reactor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactor/reactor-core","description":"Non-Blocking Reactive Foundation for the JVM","fork":false,"url":"https://api.github.com/repos/reactor/reactor-core","forks_url":"https://api.github.com/repos/reactor/reactor-core/forks","keys_url":"https://api.github.com/repos/reactor/reactor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactor/reactor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactor/reactor-core/teams","hooks_url":"https://api.github.com/repos/reactor/reactor-core/hooks","issue_events_url":"https://api.github.com/repos/reactor/reactor-core/issues/events{/number}","events_url":"https://api.github.com/repos/reactor/reactor-core/events","assignees_url":"https://api.github.com/repos/reactor/reactor-core/assignees{/user}","branches_url":"https://api.github.com/repos/reactor/reactor-core/branches{/branch}","tags_url":"https://api.github.com/repos/reactor/reactor-core/tags","blobs_url":"https://api.github.com/repos/reactor/reactor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactor/reactor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactor/reactor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactor/reactor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactor/reactor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/reactor/reactor-core/languages","stargazers_url":"https://api.github.com/repos/reactor/reactor-core/stargazers","contributors_url":"https://api.github.com/repos/reactor/reactor-core/contributors","subscribers_url":"https://api.github.com/repos/reactor/reactor-core/subscribers","subscription_url":"https://api.github.com/repos/reactor/reactor-core/subscription","commits_url":"https://api.github.com/repos/reactor/reactor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactor/reactor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactor/reactor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactor/reactor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactor/reactor-core/contents/{+path}","compare_url":"https://api.github.com/repos/reactor/reactor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactor/reactor-core/merges","archive_url":"https://api.github.com/repos/reactor/reactor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactor/reactor-core/downloads","issues_url":"https://api.github.com/repos/reactor/reactor-core/issues{/number}","pulls_url":"https://api.github.com/repos/reactor/reactor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/reactor/reactor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/reactor/reactor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactor/reactor-core/labels{/name}","releases_url":"https://api.github.com/repos/reactor/reactor-core/releases{/id}","deployments_url":"https://api.github.com/repos/reactor/reactor-core/deployments","created_at":"2015-11-10T10:06:40Z","updated_at":"2017-05-22T12:35:44Z","pushed_at":"2017-05-22T16:30:03Z","git_url":"git://github.com/reactor/reactor-core.git","ssh_url":"git@github.com:reactor/reactor-core.git","clone_url":"https://github.com/reactor/reactor-core.git","svn_url":"https://github.com/reactor/reactor-core","homepage":"http://projectreactor.io","size":43078,"stargazers_count":677,"watchers_count":677,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":49,"forks":122,"open_issues":49,"watchers":677,"default_branch":"master"}},"base":{"label":"reactor:master","ref":"master","sha":"8f819ae57c615cb384633fea0636052368a7e3e5","user":{"login":"reactor","id":4201559,"avatar_url":"https://avatars0.githubusercontent.com/u/4201559?v=3","gravatar_id":"","url":"https://api.github.com/users/reactor","html_url":"https://github.com/reactor","followers_url":"https://api.github.com/users/reactor/followers","following_url":"https://api.github.com/users/reactor/following{/other_user}","gists_url":"https://api.github.com/users/reactor/gists{/gist_id}","starred_url":"https://api.github.com/users/reactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactor/subscriptions","organizations_url":"https://api.github.com/users/reactor/orgs","repos_url":"https://api.github.com/users/reactor/repos","events_url":"https://api.github.com/users/reactor/events{/privacy}","received_events_url":"https://api.github.com/users/reactor/received_events","type":"Organization","site_admin":false},"repo":{"id":45903621,"name":"reactor-core","full_name":"reactor/reactor-core","owner":{"login":"reactor","id":4201559,"avatar_url":"https://avatars0.githubusercontent.com/u/4201559?v=3","gravatar_id":"","url":"https://api.github.com/users/reactor","html_url":"https://github.com/reactor","followers_url":"https://api.github.com/users/reactor/followers","following_url":"https://api.github.com/users/reactor/following{/other_user}","gists_url":"https://api.github.com/users/reactor/gists{/gist_id}","starred_url":"https://api.github.com/users/reactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactor/subscriptions","organizations_url":"https://api.github.com/users/reactor/orgs","repos_url":"https://api.github.com/users/reactor/repos","events_url":"https://api.github.com/users/reactor/events{/privacy}","received_events_url":"https://api.github.com/users/reactor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactor/reactor-core","description":"Non-Blocking Reactive Foundation for the JVM","fork":false,"url":"https://api.github.com/repos/reactor/reactor-core","forks_url":"https://api.github.com/repos/reactor/reactor-core/forks","keys_url":"https://api.github.com/repos/reactor/reactor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactor/reactor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactor/reactor-core/teams","hooks_url":"https://api.github.com/repos/reactor/reactor-core/hooks","issue_events_url":"https://api.github.com/repos/reactor/reactor-core/issues/events{/number}","events_url":"https://api.github.com/repos/reactor/reactor-core/events","assignees_url":"https://api.github.com/repos/reactor/reactor-core/assignees{/user}","branches_url":"https://api.github.com/repos/reactor/reactor-core/branches{/branch}","tags_url":"https://api.github.com/repos/reactor/reactor-core/tags","blobs_url":"https://api.github.com/repos/reactor/reactor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactor/reactor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactor/reactor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactor/reactor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactor/reactor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/reactor/reactor-core/languages","stargazers_url":"https://api.github.com/repos/reactor/reactor-core/stargazers","contributors_url":"https://api.github.com/repos/reactor/reactor-core/contributors","subscribers_url":"https://api.github.com/repos/reactor/reactor-core/subscribers","subscription_url":"https://api.github.com/repos/reactor/reactor-core/subscription","commits_url":"https://api.github.com/repos/reactor/reactor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactor/reactor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactor/reactor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactor/reactor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactor/reactor-core/contents/{+path}","compare_url":"https://api.github.com/repos/reactor/reactor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactor/reactor-core/merges","archive_url":"https://api.github.com/repos/reactor/reactor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactor/reactor-core/downloads","issues_url":"https://api.github.com/repos/reactor/reactor-core/issues{/number}","pulls_url":"https://api.github.com/repos/reactor/reactor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/reactor/reactor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/reactor/reactor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactor/reactor-core/labels{/name}","releases_url":"https://api.github.com/repos/reactor/reactor-core/releases{/id}","deployments_url":"https://api.github.com/repos/reactor/reactor-core/deployments","created_at":"2015-11-10T10:06:40Z","updated_at":"2017-05-22T12:35:44Z","pushed_at":"2017-05-22T16:30:03Z","git_url":"git://github.com/reactor/reactor-core.git","ssh_url":"git@github.com:reactor/reactor-core.git","clone_url":"https://github.com/reactor/reactor-core.git","svn_url":"https://github.com/reactor/reactor-core","homepage":"http://projectreactor.io","size":43078,"stargazers_count":677,"watchers_count":677,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":49,"forks":122,"open_issues":49,"watchers":677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactor/reactor-core/pulls/605"},"html":{"href":"https://github.com/reactor/reactor-core/pull/605"},"issue":{"href":"https://api.github.com/repos/reactor/reactor-core/issues/605"},"comments":{"href":"https://api.github.com/repos/reactor/reactor-core/issues/605/comments"},"review_comments":{"href":"https://api.github.com/repos/reactor/reactor-core/pulls/605/comments"},"review_comment":{"href":"https://api.github.com/repos/reactor/reactor-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactor/reactor-core/pulls/605/commits"},"statuses":{"href":"https://api.github.com/repos/reactor/reactor-core/statuses/119b3de6d55a1abd6123ce49feec02fdf12ede39"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"simonbasle","id":6986166,"avatar_url":"https://avatars3.githubusercontent.com/u/6986166?v=3","gravatar_id":"","url":"https://api.github.com/users/simonbasle","html_url":"https://github.com/simonbasle","followers_url":"https://api.github.com/users/simonbasle/followers","following_url":"https://api.github.com/users/simonbasle/following{/other_user}","gists_url":"https://api.github.com/users/simonbasle/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbasle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbasle/subscriptions","organizations_url":"https://api.github.com/users/simonbasle/orgs","repos_url":"https://api.github.com/users/simonbasle/repos","events_url":"https://api.github.com/users/simonbasle/events{/privacy}","received_events_url":"https://api.github.com/users/simonbasle/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":92,"deletions":56,"changed_files":14}}
{"actor":{"display_login":"simonbasle"}}