{"action":"created","issue":{"url":"https://api.github.com/repos/spatialillusions/milsymbol/issues/97","repository_url":"https://api.github.com/repos/spatialillusions/milsymbol","labels_url":"https://api.github.com/repos/spatialillusions/milsymbol/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/spatialillusions/milsymbol/issues/97/comments","events_url":"https://api.github.com/repos/spatialillusions/milsymbol/issues/97/events","html_url":"https://github.com/spatialillusions/milsymbol/issues/97","id":220554287,"number":97,"title":"JavaScript Coding Standards","user":{"login":"okwolf","id":3735164,"avatar_url":"https://avatars0.githubusercontent.com/u/3735164?v=3","gravatar_id":"","url":"https://api.github.com/users/okwolf","html_url":"https://github.com/okwolf","followers_url":"https://api.github.com/users/okwolf/followers","following_url":"https://api.github.com/users/okwolf/following{/other_user}","gists_url":"https://api.github.com/users/okwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/okwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okwolf/subscriptions","organizations_url":"https://api.github.com/users/okwolf/orgs","repos_url":"https://api.github.com/users/okwolf/repos","events_url":"https://api.github.com/users/okwolf/events{/privacy}","received_events_url":"https://api.github.com/users/okwolf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-04-10T07:02:09Z","updated_at":"2017-04-16T10:28:40Z","closed_at":null,"body":"I couldn't find reference to any specific code standards on this repo, so I'm curious what your preferences (if any) are.\r\n\r\nThe best and most popular JavaScript static analysis/code quality tool around (I've used it on all my projects in the past six months) is [ESLint](http://eslint.org). It comes with a set of recommended rules (eslint:recommended) but is highly configurable and extendable from existing configs and plugins. It also plugs in nicely with webpack to automate the enforcement of whatever rules you decide to abide by in all code that gets bundled.\r\n\r\nOn the subject of formatting, ESLint does come with some basic formatting rules related to spacing and newlines, but the better solution there I've started using more recently is known as [prettier](https://github.com/prettier/prettier). It has the unique advantage that it knows how to fix all formatting related issues and can also play nicely with ESLint.\r\n\r\nWould you be interested in including any of this as part of the build process?"},"comment":{"url":"https://api.github.com/repos/spatialillusions/milsymbol/issues/comments/294344687","html_url":"https://github.com/spatialillusions/milsymbol/issues/97#issuecomment-294344687","issue_url":"https://api.github.com/repos/spatialillusions/milsymbol/issues/97","id":294344687,"user":{"login":"spatialillusions","id":8155542,"avatar_url":"https://avatars1.githubusercontent.com/u/8155542?v=3","gravatar_id":"","url":"https://api.github.com/users/spatialillusions","html_url":"https://github.com/spatialillusions","followers_url":"https://api.github.com/users/spatialillusions/followers","following_url":"https://api.github.com/users/spatialillusions/following{/other_user}","gists_url":"https://api.github.com/users/spatialillusions/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialillusions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialillusions/subscriptions","organizations_url":"https://api.github.com/users/spatialillusions/orgs","repos_url":"https://api.github.com/users/spatialillusions/repos","events_url":"https://api.github.com/users/spatialillusions/events{/privacy}","received_events_url":"https://api.github.com/users/spatialillusions/received_events","type":"User","site_admin":false},"created_at":"2017-04-16T10:28:39Z","updated_at":"2017-04-16T10:28:39Z","body":"@okwolf I did some testing and ran prettier on all files using default settings, and I think the result is really nice. But like you mentioned before it might be a good idea to combine it with some eslint to validate the code as well. Have you any ideas of the best way to move forward on this to make sure all code looks good and is correct?"}}
{"actor":{"display_login":"spatialillusions"}}