{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/158009208","pull_request_review_id":84745974,"id":158009208,"diff_hunk":"@@ -2,6 +2,7 @@ dist: trusty\n \n before_install:\n   - sudo apt-get install coreutils realpath doxygen graphviz python-lesscpy cppcheck coccinelle pcregrep python3-flake8\n+  - which flake8","path":".travis.yml","position":4,"original_position":4,"commit_id":"a5fd0f760a12502c5e5a71c73c5ee02b5e8980b7","original_commit_id":"a5fd0f760a12502c5e5a71c73c5ee02b5e8980b7","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"yes, it doesn't work because python 2 flake8. I'm trying to understand what's going on there.","created_at":"2017-12-20T12:22:37Z","updated_at":"2017-12-20T12:22:37Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/8301#discussion_r158009208","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/158009208"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8301#discussion_r158009208"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301"}},"in_reply_to_id":158009041},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301","id":159400292,"html_url":"https://github.com/RIOT-OS/RIOT/pull/8301","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8301.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8301.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8301","number":8301,"state":"open","locked":false,"title":"dist/tools/testrunner: fix flake8 remaining issues","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\n\r\nThis PR make the testrunner script compliant with RIOT's [Python coding conventions](https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions#python-coding-convention).\r\n\r\n<!--\r\nPut here the description of your contribution:\r\n- describe which part(s) of RIOT is (are) involved\r\n- if it's a bug fix, describe the bug that it solves and how it is solved\r\n- you can also give more information to reviewers about how to test your changes\r\n-->\r\n\r\n\r\n### Issues/PRs references\r\n\r\nNone\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->","created_at":"2017-12-20T12:04:37Z","updated_at":"2017-12-20T12:22:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6bc3e2c52650a84310203044b36c802cad28199","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cladmi","id":241401,"avatar_url":"https://avatars3.githubusercontent.com/u/241401?v=4","gravatar_id":"","url":"https://api.github.com/users/cladmi","html_url":"https://github.com/cladmi","followers_url":"https://api.github.com/users/cladmi/followers","following_url":"https://api.github.com/users/cladmi/following{/other_user}","gists_url":"https://api.github.com/users/cladmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cladmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cladmi/subscriptions","organizations_url":"https://api.github.com/users/cladmi/orgs","repos_url":"https://api.github.com/users/cladmi/repos","events_url":"https://api.github.com/users/cladmi/events{/privacy}","received_events_url":"https://api.github.com/users/cladmi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8301/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/a5fd0f760a12502c5e5a71c73c5ee02b5e8980b7","head":{"label":"aabadie:pr/flake8/testrunner","ref":"pr/flake8/testrunner","sha":"a5fd0f760a12502c5e5a71c73c5ee02b5e8980b7","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"repo":{"id":44016379,"name":"RIOT","full_name":"aabadie/RIOT","owner":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aabadie/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/aabadie/RIOT","forks_url":"https://api.github.com/repos/aabadie/RIOT/forks","keys_url":"https://api.github.com/repos/aabadie/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aabadie/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aabadie/RIOT/teams","hooks_url":"https://api.github.com/repos/aabadie/RIOT/hooks","issue_events_url":"https://api.github.com/repos/aabadie/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/aabadie/RIOT/events","assignees_url":"https://api.github.com/repos/aabadie/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/aabadie/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/aabadie/RIOT/tags","blobs_url":"https://api.github.com/repos/aabadie/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aabadie/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aabadie/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/aabadie/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aabadie/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/aabadie/RIOT/languages","stargazers_url":"https://api.github.com/repos/aabadie/RIOT/stargazers","contributors_url":"https://api.github.com/repos/aabadie/RIOT/contributors","subscribers_url":"https://api.github.com/repos/aabadie/RIOT/subscribers","subscription_url":"https://api.github.com/repos/aabadie/RIOT/subscription","commits_url":"https://api.github.com/repos/aabadie/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/aabadie/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/aabadie/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/aabadie/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/aabadie/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/aabadie/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aabadie/RIOT/merges","archive_url":"https://api.github.com/repos/aabadie/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aabadie/RIOT/downloads","issues_url":"https://api.github.com/repos/aabadie/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/aabadie/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/aabadie/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/aabadie/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aabadie/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/aabadie/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/aabadie/RIOT/deployments","created_at":"2015-10-10T15:36:27Z","updated_at":"2016-10-29T18:27:28Z","pushed_at":"2017-12-20T12:20:14Z","git_url":"git://github.com/aabadie/RIOT.git","ssh_url":"git@github.com:aabadie/RIOT.git","clone_url":"https://github.com/aabadie/RIOT.git","svn_url":"https://github.com/aabadie/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":47761,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"90c81f6de67dff7a4bf2ba6abf544d3460becdf1","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2017-12-20T02:41:01Z","pushed_at":"2017-12-20T12:20:16Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":46894,"stargazers_count":1548,"watchers_count":1548,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":903,"mirror_url":null,"archived":false,"open_issues_count":659,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":903,"open_issues":659,"watchers":1548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8301"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8301"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8301/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8301/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/a5fd0f760a12502c5e5a71c73c5ee02b5e8980b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aabadie"}}