{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/2","id":118351754,"html_url":"https://github.com/furyu-suzuki/Java_SE_8_study/pull/2","diff_url":"https://github.com/furyu-suzuki/Java_SE_8_study/pull/2.diff","patch_url":"https://github.com/furyu-suzuki/Java_SE_8_study/pull/2.patch","issue_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/issues/2","number":2,"state":"open","locked":false,"title":"Chapter1レビュー by araki","user":{"login":"furyu-araki","id":11768207,"avatar_url":"https://avatars3.githubusercontent.com/u/11768207?v=3","gravatar_id":"","url":"https://api.github.com/users/furyu-araki","html_url":"https://github.com/furyu-araki","followers_url":"https://api.github.com/users/furyu-araki/followers","following_url":"https://api.github.com/users/furyu-araki/following{/other_user}","gists_url":"https://api.github.com/users/furyu-araki/gists{/gist_id}","starred_url":"https://api.github.com/users/furyu-araki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furyu-araki/subscriptions","organizations_url":"https://api.github.com/users/furyu-araki/orgs","repos_url":"https://api.github.com/users/furyu-araki/repos","events_url":"https://api.github.com/users/furyu-araki/events{/privacy}","received_events_url":"https://api.github.com/users/furyu-araki/received_events","type":"User","site_admin":false},"body":"## .gitignore\r\neeab503 acca9d6\r\n- out フォルダにはビルドの成果物が入るので、ignoreした方が良さそう\r\n- プロジェクトを開くと intellij 関係のファイルが差分で入ってしまったのでこれもignore\r\n\r\n参考：プロジェクトや開発環境ごとのgitignoreをまとめたリポジトリがあります。\r\nhttps://github.com/github/gitignore\r\nIntelliJ：https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore\r\n\r\n## Labmda2\r\n13d56d3\r\nメソッドを書きなさいとあったので、処理をメソッドに切り出してみました。\r\n\r\n## Lambda3\r\n課題としては問題なし 👍 \r\ne0d560a fdbf1d0\r\n- 練習用コードなのでそこまで厳密にする必要はないが、意味のわかりやすい命名を心がけると良いと思います。list→files, name→file にリネームしました。\r\n- 他の課題でもそうですが、コードの整形をすると自分も他人も見やすくなります。IntelliJなら、Ctrl（MacはCommand） + Alt + L で整形ができます。\r\n\r\n## Lambda4\r\n11ef0ab\r\nソートした結果が出力されていなかったので修正。\r\n```\r\ndirs.stream().sorted( comparing(File::getName) );\r\n```\r\nのsortedメソッドは、dirs自体をソートするわけではなく、dirsをソートした結果を返すメソッドです。\r\nメソッドの細かい仕様を知りたい場合はjavadocを読むと良いと思います。\r\n\r\n## Lambda9\r\n別解的なやつです。課題自体は問題ないです。\r\n\r\n## Lambda10\r\nList以外にもMapやSetも考慮した方が良さそうに思いました。","created_at":"2017-05-01T06:54:01Z","updated_at":"2017-05-01T06:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/2/commits","review_comments_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/2/comments","review_comment_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/comments{/number}","comments_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/issues/2/comments","statuses_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/statuses/87a93d2a0032567dda438c85e56529c3881222b7","head":{"label":"furyu-araki:chapter1_review_araki","ref":"chapter1_review_araki","sha":"87a93d2a0032567dda438c85e56529c3881222b7","user":{"login":"furyu-araki","id":11768207,"avatar_url":"https://avatars3.githubusercontent.com/u/11768207?v=3","gravatar_id":"","url":"https://api.github.com/users/furyu-araki","html_url":"https://github.com/furyu-araki","followers_url":"https://api.github.com/users/furyu-araki/followers","following_url":"https://api.github.com/users/furyu-araki/following{/other_user}","gists_url":"https://api.github.com/users/furyu-araki/gists{/gist_id}","starred_url":"https://api.github.com/users/furyu-araki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furyu-araki/subscriptions","organizations_url":"https://api.github.com/users/furyu-araki/orgs","repos_url":"https://api.github.com/users/furyu-araki/repos","events_url":"https://api.github.com/users/furyu-araki/events{/privacy}","received_events_url":"https://api.github.com/users/furyu-araki/received_events","type":"User","site_admin":false},"repo":{"id":89902682,"name":"Java_SE_8_study","full_name":"furyu-araki/Java_SE_8_study","owner":{"login":"furyu-araki","id":11768207,"avatar_url":"https://avatars3.githubusercontent.com/u/11768207?v=3","gravatar_id":"","url":"https://api.github.com/users/furyu-araki","html_url":"https://github.com/furyu-araki","followers_url":"https://api.github.com/users/furyu-araki/followers","following_url":"https://api.github.com/users/furyu-araki/following{/other_user}","gists_url":"https://api.github.com/users/furyu-araki/gists{/gist_id}","starred_url":"https://api.github.com/users/furyu-araki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furyu-araki/subscriptions","organizations_url":"https://api.github.com/users/furyu-araki/orgs","repos_url":"https://api.github.com/users/furyu-araki/repos","events_url":"https://api.github.com/users/furyu-araki/events{/privacy}","received_events_url":"https://api.github.com/users/furyu-araki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/furyu-araki/Java_SE_8_study","description":"「Java SE 8実践プログラミング」の演習課題を解いてみたものです。","fork":true,"url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study","forks_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/forks","keys_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/keys{/key_id}","collaborators_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/teams","hooks_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/hooks","issue_events_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/issues/events{/number}","events_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/events","assignees_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/assignees{/user}","branches_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/branches{/branch}","tags_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/tags","blobs_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/git/refs{/sha}","trees_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/git/trees{/sha}","statuses_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/statuses/{sha}","languages_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/languages","stargazers_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/stargazers","contributors_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/contributors","subscribers_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/subscribers","subscription_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/subscription","commits_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/commits{/sha}","git_commits_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/git/commits{/sha}","comments_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/comments{/number}","issue_comment_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/issues/comments{/number}","contents_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/contents/{+path}","compare_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/compare/{base}...{head}","merges_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/merges","archive_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/downloads","issues_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/issues{/number}","pulls_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/pulls{/number}","milestones_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/milestones{/number}","notifications_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/labels{/name}","releases_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/releases{/id}","deployments_url":"https://api.github.com/repos/furyu-araki/Java_SE_8_study/deployments","created_at":"2017-05-01T06:29:19Z","updated_at":"2017-05-01T06:29:20Z","pushed_at":"2017-05-01T06:30:28Z","git_url":"git://github.com/furyu-araki/Java_SE_8_study.git","ssh_url":"git@github.com:furyu-araki/Java_SE_8_study.git","clone_url":"https://github.com/furyu-araki/Java_SE_8_study.git","svn_url":"https://github.com/furyu-araki/Java_SE_8_study","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"furyu-suzuki:master","ref":"master","sha":"bef62da2096e0eab3df77cb620d5ce7139eaf4b0","user":{"login":"furyu-suzuki","id":26866999,"avatar_url":"https://avatars0.githubusercontent.com/u/26866999?v=3","gravatar_id":"","url":"https://api.github.com/users/furyu-suzuki","html_url":"https://github.com/furyu-suzuki","followers_url":"https://api.github.com/users/furyu-suzuki/followers","following_url":"https://api.github.com/users/furyu-suzuki/following{/other_user}","gists_url":"https://api.github.com/users/furyu-suzuki/gists{/gist_id}","starred_url":"https://api.github.com/users/furyu-suzuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furyu-suzuki/subscriptions","organizations_url":"https://api.github.com/users/furyu-suzuki/orgs","repos_url":"https://api.github.com/users/furyu-suzuki/repos","events_url":"https://api.github.com/users/furyu-suzuki/events{/privacy}","received_events_url":"https://api.github.com/users/furyu-suzuki/received_events","type":"User","site_admin":false},"repo":{"id":89660333,"name":"Java_SE_8_study","full_name":"furyu-suzuki/Java_SE_8_study","owner":{"login":"furyu-suzuki","id":26866999,"avatar_url":"https://avatars0.githubusercontent.com/u/26866999?v=3","gravatar_id":"","url":"https://api.github.com/users/furyu-suzuki","html_url":"https://github.com/furyu-suzuki","followers_url":"https://api.github.com/users/furyu-suzuki/followers","following_url":"https://api.github.com/users/furyu-suzuki/following{/other_user}","gists_url":"https://api.github.com/users/furyu-suzuki/gists{/gist_id}","starred_url":"https://api.github.com/users/furyu-suzuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furyu-suzuki/subscriptions","organizations_url":"https://api.github.com/users/furyu-suzuki/orgs","repos_url":"https://api.github.com/users/furyu-suzuki/repos","events_url":"https://api.github.com/users/furyu-suzuki/events{/privacy}","received_events_url":"https://api.github.com/users/furyu-suzuki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/furyu-suzuki/Java_SE_8_study","description":"「Java SE 8実践プログラミング」の演習課題を解いてみたものです。","fork":false,"url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study","forks_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/forks","keys_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/keys{/key_id}","collaborators_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/teams","hooks_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/hooks","issue_events_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/issues/events{/number}","events_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/events","assignees_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/assignees{/user}","branches_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/branches{/branch}","tags_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/tags","blobs_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/git/refs{/sha}","trees_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/git/trees{/sha}","statuses_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/statuses/{sha}","languages_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/languages","stargazers_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/stargazers","contributors_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/contributors","subscribers_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/subscribers","subscription_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/subscription","commits_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/commits{/sha}","git_commits_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/git/commits{/sha}","comments_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/comments{/number}","issue_comment_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/issues/comments{/number}","contents_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/contents/{+path}","compare_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/compare/{base}...{head}","merges_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/merges","archive_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/downloads","issues_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/issues{/number}","pulls_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls{/number}","milestones_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/milestones{/number}","notifications_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/labels{/name}","releases_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/releases{/id}","deployments_url":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/deployments","created_at":"2017-04-28T02:41:57Z","updated_at":"2017-04-28T03:46:26Z","pushed_at":"2017-04-28T07:47:48Z","git_url":"git://github.com/furyu-suzuki/Java_SE_8_study.git","ssh_url":"git@github.com:furyu-suzuki/Java_SE_8_study.git","clone_url":"https://github.com/furyu-suzuki/Java_SE_8_study.git","svn_url":"https://github.com/furyu-suzuki/Java_SE_8_study","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/2"},"html":{"href":"https://github.com/furyu-suzuki/Java_SE_8_study/pull/2"},"issue":{"href":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/issues/2"},"comments":{"href":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/furyu-suzuki/Java_SE_8_study/statuses/87a93d2a0032567dda438c85e56529c3881222b7"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":8,"additions":55,"deletions":1006,"changed_files":8}}
{"actor":{"display_login":"furyu-araki"}}