{"action":"created","comment":{"url":"https://api.github.com/repos/clappr/clappr/pulls/comments/156184770","pull_request_review_id":82621706,"id":156184770,"diff_hunk":"@@ -48,7 +48,21 @@ export default class Loader extends BaseObject {\n   constructor(externalPlugins, playerId) {\n     super()\n     this.playerId = playerId\n-    this.playbackPlugins = [HLSVideoPlayback, HTML5VideoPlayback, HTML5AudioPlayback, FlashVideoPlayback, FlasHLSVideoPlayback, HTMLImgPlayback, NoOp]\n+    this.playbackPlugins = [\n+      HTML5VideoPlayback,\n+      HTML5AudioPlayback,\n+      HTMLImgPlayback,\n+      NoOp\n+    ]\n+\n+    if (!PLAIN_HTML5_ONLY === 'yes') {","path":"src/components/loader/loader.js","position":12,"original_position":12,"commit_id":"dad4aee8753daf7e6385b2202700d04fe95eed05","original_commit_id":"dad4aee8753daf7e6385b2202700d04fe95eed05","user":{"login":"tchakabam","id":1480052,"avatar_url":"https://avatars2.githubusercontent.com/u/1480052?v=4","gravatar_id":"","url":"https://api.github.com/users/tchakabam","html_url":"https://github.com/tchakabam","followers_url":"https://api.github.com/users/tchakabam/followers","following_url":"https://api.github.com/users/tchakabam/following{/other_user}","gists_url":"https://api.github.com/users/tchakabam/gists{/gist_id}","starred_url":"https://api.github.com/users/tchakabam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchakabam/subscriptions","organizations_url":"https://api.github.com/users/tchakabam/orgs","repos_url":"https://api.github.com/users/tchakabam/repos","events_url":"https://api.github.com/users/tchakabam/events{/privacy}","received_events_url":"https://api.github.com/users/tchakabam/received_events","type":"User","site_admin":false},"body":"OK, totally agreeing! :+1: ","created_at":"2017-12-11T20:07:02Z","updated_at":"2017-12-11T20:07:03Z","html_url":"https://github.com/clappr/clappr/pull/1545#discussion_r156184770","pull_request_url":"https://api.github.com/repos/clappr/clappr/pulls/1545","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr/pulls/comments/156184770"},"html":{"href":"https://github.com/clappr/clappr/pull/1545#discussion_r156184770"},"pull_request":{"href":"https://api.github.com/repos/clappr/clappr/pulls/1545"}},"in_reply_to_id":155614269},"pull_request":{"url":"https://api.github.com/repos/clappr/clappr/pulls/1545","id":156872690,"html_url":"https://github.com/clappr/clappr/pull/1545","diff_url":"https://github.com/clappr/clappr/pull/1545.diff","patch_url":"https://github.com/clappr/clappr/pull/1545.patch","issue_url":"https://api.github.com/repos/clappr/clappr/issues/1545","number":1545,"state":"open","locked":false,"title":"\"Lighther\" build only with plain html5 plugins","user":{"login":"tchakabam","id":1480052,"avatar_url":"https://avatars2.githubusercontent.com/u/1480052?v=4","gravatar_id":"","url":"https://api.github.com/users/tchakabam","html_url":"https://github.com/tchakabam","followers_url":"https://api.github.com/users/tchakabam/followers","following_url":"https://api.github.com/users/tchakabam/following{/other_user}","gists_url":"https://api.github.com/users/tchakabam/gists{/gist_id}","starred_url":"https://api.github.com/users/tchakabam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchakabam/subscriptions","organizations_url":"https://api.github.com/users/tchakabam/orgs","repos_url":"https://api.github.com/users/tchakabam/repos","events_url":"https://api.github.com/users/tchakabam/events{/privacy}","received_events_url":"https://api.github.com/users/tchakabam/received_events","type":"User","site_admin":false},"body":"In our product we are using a fork where we do something like this in order to get a lighter build :)\r\n\r\nWe don't always need Hlsjs, and we don't need all the Flash stuff.\r\n\r\nWe are lowering the Clappr non-minified build from > 1Mb to ~400 Kbytes.\r\n\r\nMinified goes down to from ~500 to ~200Kbytes.\r\n\r\nWe already load a lot of stuff on the frontend, and people are really unhappy about such a big library full of stuff that we don't necessarilly use.\r\n\r\nSo it would be great if such a build option could be integrated into our build system.\r\n\r\nIt's a proposal on how to do it, all open for discussion, as long as we hit the goal of being able to produce easily a build without all \"non-essential\" playback plugins :)\r\n\r\nBTW my personal opinion is that all these plugins:\r\n\r\n1) Yes can be shipped in the main Clappr git repo, it has a lot of advantages of having the core and the plugins in one repo (for example CI / testing)\r\n\r\n2) but should not be shipped as individually built modules, that one can include or not into the page, or load on demand\r\n\r\n","created_at":"2017-12-07T00:05:41Z","updated_at":"2017-12-11T20:07:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04ffb82a6f0ec908bda036f0ddff5d8207bbc391","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/clappr/clappr/pulls/1545/commits","review_comments_url":"https://api.github.com/repos/clappr/clappr/pulls/1545/comments","review_comment_url":"https://api.github.com/repos/clappr/clappr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clappr/clappr/issues/1545/comments","statuses_url":"https://api.github.com/repos/clappr/clappr/statuses/dad4aee8753daf7e6385b2202700d04fe95eed05","head":{"label":"tchakabam:feature/build-only-with-plain-html5-plugins","ref":"feature/build-only-with-plain-html5-plugins","sha":"dad4aee8753daf7e6385b2202700d04fe95eed05","user":{"login":"tchakabam","id":1480052,"avatar_url":"https://avatars2.githubusercontent.com/u/1480052?v=4","gravatar_id":"","url":"https://api.github.com/users/tchakabam","html_url":"https://github.com/tchakabam","followers_url":"https://api.github.com/users/tchakabam/followers","following_url":"https://api.github.com/users/tchakabam/following{/other_user}","gists_url":"https://api.github.com/users/tchakabam/gists{/gist_id}","starred_url":"https://api.github.com/users/tchakabam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchakabam/subscriptions","organizations_url":"https://api.github.com/users/tchakabam/orgs","repos_url":"https://api.github.com/users/tchakabam/repos","events_url":"https://api.github.com/users/tchakabam/events{/privacy}","received_events_url":"https://api.github.com/users/tchakabam/received_events","type":"User","site_admin":false},"repo":{"id":102762005,"name":"clappr","full_name":"tchakabam/clappr","owner":{"login":"tchakabam","id":1480052,"avatar_url":"https://avatars2.githubusercontent.com/u/1480052?v=4","gravatar_id":"","url":"https://api.github.com/users/tchakabam","html_url":"https://github.com/tchakabam","followers_url":"https://api.github.com/users/tchakabam/followers","following_url":"https://api.github.com/users/tchakabam/following{/other_user}","gists_url":"https://api.github.com/users/tchakabam/gists{/gist_id}","starred_url":"https://api.github.com/users/tchakabam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchakabam/subscriptions","organizations_url":"https://api.github.com/users/tchakabam/orgs","repos_url":"https://api.github.com/users/tchakabam/repos","events_url":"https://api.github.com/users/tchakabam/events{/privacy}","received_events_url":"https://api.github.com/users/tchakabam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tchakabam/clappr","description":":clapper: An extensible media player for the web.","fork":true,"url":"https://api.github.com/repos/tchakabam/clappr","forks_url":"https://api.github.com/repos/tchakabam/clappr/forks","keys_url":"https://api.github.com/repos/tchakabam/clappr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tchakabam/clappr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tchakabam/clappr/teams","hooks_url":"https://api.github.com/repos/tchakabam/clappr/hooks","issue_events_url":"https://api.github.com/repos/tchakabam/clappr/issues/events{/number}","events_url":"https://api.github.com/repos/tchakabam/clappr/events","assignees_url":"https://api.github.com/repos/tchakabam/clappr/assignees{/user}","branches_url":"https://api.github.com/repos/tchakabam/clappr/branches{/branch}","tags_url":"https://api.github.com/repos/tchakabam/clappr/tags","blobs_url":"https://api.github.com/repos/tchakabam/clappr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tchakabam/clappr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tchakabam/clappr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tchakabam/clappr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tchakabam/clappr/statuses/{sha}","languages_url":"https://api.github.com/repos/tchakabam/clappr/languages","stargazers_url":"https://api.github.com/repos/tchakabam/clappr/stargazers","contributors_url":"https://api.github.com/repos/tchakabam/clappr/contributors","subscribers_url":"https://api.github.com/repos/tchakabam/clappr/subscribers","subscription_url":"https://api.github.com/repos/tchakabam/clappr/subscription","commits_url":"https://api.github.com/repos/tchakabam/clappr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tchakabam/clappr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tchakabam/clappr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tchakabam/clappr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tchakabam/clappr/contents/{+path}","compare_url":"https://api.github.com/repos/tchakabam/clappr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tchakabam/clappr/merges","archive_url":"https://api.github.com/repos/tchakabam/clappr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tchakabam/clappr/downloads","issues_url":"https://api.github.com/repos/tchakabam/clappr/issues{/number}","pulls_url":"https://api.github.com/repos/tchakabam/clappr/pulls{/number}","milestones_url":"https://api.github.com/repos/tchakabam/clappr/milestones{/number}","notifications_url":"https://api.github.com/repos/tchakabam/clappr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tchakabam/clappr/labels{/name}","releases_url":"https://api.github.com/repos/tchakabam/clappr/releases{/id}","deployments_url":"https://api.github.com/repos/tchakabam/clappr/deployments","created_at":"2017-09-07T16:42:45Z","updated_at":"2017-09-07T16:42:48Z","pushed_at":"2017-12-07T16:10:11Z","git_url":"git://github.com/tchakabam/clappr.git","ssh_url":"git@github.com:tchakabam/clappr.git","clone_url":"https://github.com/tchakabam/clappr.git","svn_url":"https://github.com/tchakabam/clappr","homepage":"http://clappr.io","size":33152,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clappr:master","ref":"master","sha":"a7a1d923891ec84151ae30c4349f20f72e404f3a","user":{"login":"clappr","id":10685859,"avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":16844474,"name":"clappr","full_name":"clappr/clappr","owner":{"login":"clappr","id":10685859,"avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clappr/clappr","description":":clapper: An extensible media player for the web.","fork":false,"url":"https://api.github.com/repos/clappr/clappr","forks_url":"https://api.github.com/repos/clappr/clappr/forks","keys_url":"https://api.github.com/repos/clappr/clappr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr/teams","hooks_url":"https://api.github.com/repos/clappr/clappr/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr/events","assignees_url":"https://api.github.com/repos/clappr/clappr/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr/tags","blobs_url":"https://api.github.com/repos/clappr/clappr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr/subscription","commits_url":"https://api.github.com/repos/clappr/clappr/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr/merges","archive_url":"https://api.github.com/repos/clappr/clappr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr/downloads","issues_url":"https://api.github.com/repos/clappr/clappr/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr/releases{/id}","deployments_url":"https://api.github.com/repos/clappr/clappr/deployments","created_at":"2014-02-14T17:36:40Z","updated_at":"2017-12-11T07:16:38Z","pushed_at":"2017-12-11T20:02:00Z","git_url":"git://github.com/clappr/clappr.git","ssh_url":"git@github.com:clappr/clappr.git","clone_url":"https://github.com/clappr/clappr.git","svn_url":"https://github.com/clappr/clappr","homepage":"http://clappr.io","size":32731,"stargazers_count":3908,"watchers_count":3908,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":511,"mirror_url":null,"archived":false,"open_issues_count":184,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":511,"open_issues":184,"watchers":3908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr/pulls/1545"},"html":{"href":"https://github.com/clappr/clappr/pull/1545"},"issue":{"href":"https://api.github.com/repos/clappr/clappr/issues/1545"},"comments":{"href":"https://api.github.com/repos/clappr/clappr/issues/1545/comments"},"review_comments":{"href":"https://api.github.com/repos/clappr/clappr/pulls/1545/comments"},"review_comment":{"href":"https://api.github.com/repos/clappr/clappr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clappr/clappr/pulls/1545/commits"},"statuses":{"href":"https://api.github.com/repos/clappr/clappr/statuses/dad4aee8753daf7e6385b2202700d04fe95eed05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tchakabam"}}