{"action":"created","issue":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/457","repository_url":"https://api.github.com/repos/tbeu/Modelica","labels_url":"https://api.github.com/repos/tbeu/Modelica/issues/457/labels{/name}","comments_url":"https://api.github.com/repos/tbeu/Modelica/issues/457/comments","events_url":"https://api.github.com/repos/tbeu/Modelica/issues/457/events","html_url":"https://github.com/tbeu/Modelica/issues/457","id":200006730,"number":457,"title":"Garbage in a lot of annotations in MSL 3.2 and MSL 3.1.","user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":515527754,"url":"https://api.github.com/repos/tbeu/Modelica/labels/bug","name":"bug","color":"ee0701","default":true},{"id":515540092,"url":"https://api.github.com/repos/tbeu/Modelica/labels/P:%20high","name":"P: high","color":"ff6666","default":false}],"state":"open","locked":false,"assignee":{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false},"assignees":[{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tbeu/Modelica/milestones/47","html_url":"https://github.com/tbeu/Modelica/milestone/47","labels_url":"https://api.github.com/repos/tbeu/Modelica/milestones/47/labels","id":2241914,"number":47,"title":"MSL3.2.1","description":"Backward compatible bug-fix release.","creator":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"closed","created_at":"2017-01-10T20:30:26Z","updated_at":"2017-01-11T05:30:07Z","due_on":"2013-03-31T07:00:00Z","closed_at":"2017-01-10T20:30:26Z"},"comments":13,"created_at":"2017-01-11T05:28:28Z","updated_at":"2017-01-11T05:31:58Z","closed_at":null,"body":"**Reported by adrpo on 17 Nov 2010 12:17 UTC**\nJust search for \"extent=[\" and you will find plenty of this garbage. The problem is that this garbage makes annotations not correct. Example:\nModelica.Electrical.Analog.Basic.M_Transformer:\n```\nannotation (extent=[-80,-40; -62,40], Placement(transformation(\n          extent={{-80,-40},{-62,40}}, rotation=0)));\nor below, in:\nannotation(Icon(..., graphics={...},\n      Ellipse(extent=[-36,24; -18,42]),\n      Ellipse(extent=[18,24; 36,42]),\n      Ellipse(extent=[0,24; 18,42]),\n      Ellipse(extent=[-18,24; 0,42]),\n...);\n```\n\nHowever, Icon annotation CANNOT contain Ellipses, they can\nonly be part of the graphics component.\n\nThere are 353 occurrences of such garbage, see the attached file.\n\n----\n\nMigrated-From: https://trac.modelica.org/Modelica/ticket/457"},"comment":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/comments/271782191","html_url":"https://github.com/tbeu/Modelica/issues/457#issuecomment-271782191","issue_url":"https://api.github.com/repos/tbeu/Modelica/issues/457","id":271782191,"user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"created_at":"2017-01-11T05:31:58Z","updated_at":"2017-01-11T05:31:58Z","body":"**Comment by hansolsson on 25 May 2012 08:10 UTC**\nReplying to [comment:13 dietmarw]:\n> Replying to [comment:12 hansolsson]:\n> > The Error-annotations are only introduced when you switch from a class with syntax errors in it. \n> But surely Dymola should remove those again (and call them `__Dymola_Error`) once the class syntax is fine again.\n\nOh, I realized that the cause was different:\n\nThe \"Error\" tag is as far as I can understand introduced when some parsing issues are found (and of course reported); basically there was \"garbage\"/incorrect text in the input file and \"Error\" was introduced to not stop the parsing of the rest of the text.\nIf the error had been corrected and reparsed the \"Error\" tag would be gone.\n\nThe problem is the lost incorrect text - and not the \"Error\"-tag.\n\n\nThe tag for keeping syntax error in the text-editor is actually called something else (and I agree that it should be cleared out once the error is corrected).\n"}}
{"actor":{"display_login":"modelica-trac-importer"}}