{"push_id":1697761189,"size":3,"distinct_size":3,"ref":"refs/heads/try","head":"66d3401389f6fae291e87cd229b6e249284c624b","before":"733820583e41778b8e30faa4ba120ab0b0390073","commits":[{"sha":"6543616ba4f07a6788763726d39c9fa21422f9db","author":{"name":"Jeremy Chen","email":"bb86a78a546c5e5dd0cc1d9443c33355ffee46d1@mozilla.com"},"message":"Stylo: update bindings for -moz-border-*-colors support","distinct":true,"url":"https://api.github.com/repos/servo/servo/commits/6543616ba4f07a6788763726d39c9fa21422f9db"},{"sha":"98d949ee753b9e69ea5d7f8524fca47b9aff7085","author":{"name":"Jeremy Chen","email":"bb86a78a546c5e5dd0cc1d9443c33355ffee46d1@mozilla.com"},"message":"Stylo: add -moz-border-*-colors support\n\nIn Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors.\nWe can simplify the implementation of computed value in Servo by using Option<Vec>.\nAs to passing computed values from Servo to Gecko, we might need to use some\nbinding functions (pre-added in the same Gecko bug, see Bug 1348173).\n\nNote that we added -moz-border-*-colors as sub_properties of the 'border'\nshorthand, so we can make the 'border' shorthand reset -moz-border-*-colors\n(See Gecko Bug 482692). However, since they are Gecko only non-standard properties,\nwe should skip these sub_properties while doing unit testing in Servo. The test part\nshould be convered by Stylo/Gecko already.\n\nA bit refactoring of replacing all [\"top\", \"right\", \"bottom\", \"left\"] with PHYSICAL_SIDES\nis included in this patch, since we've already had PHYSICAL_SIDES for a while.","distinct":true,"url":"https://api.github.com/repos/servo/servo/commits/98d949ee753b9e69ea5d7f8524fca47b9aff7085"},{"sha":"66d3401389f6fae291e87cd229b6e249284c624b","author":{"name":"bors-servo","email":"b09d4f4a3e19bc290c035b624e2133ac70195a90@mozilla.com"},"message":"Auto merge of #16586 - chenpighead:stylo-moz-border-colors-support, r=<try>\n\nStylo: add -moz-border-*-colors support\n\nIn Gecko, we use double pointers to nsBorderColors to store -moz-border-*-colors.\nWe can simplify the implementation of computed value in Servo by using Option<Vec>.\nAs to passing computed values from Servo to Gecko, we might need to use some\nbinding functions (pre-added in the same Gecko bug, see Bug 1348173).\n\nNote that we also added -moz-border-*-colors as sub_properties of the 'border'\nshorthand, so we can make the 'border' shorthand reset -moz-border-*-colors\n(See Gecko Bug 482692).\n\nA bit refactoring of replacing all [\"top\", \"right\", \"bottom\", \"left\"] with PHYSICAL_SIDES\nis included in this patch, since we've already had PHYSICAL_SIDES for a while.\n\n<!-- Please describe your changes on the following line: -->\n\n---\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\n- [X] `./mach build -d` does not report any errors\n- [X] `./mach test-tidy` does not report any errors\n- [ ] These changes fix #__ (github issue number if applicable).\n\n<!-- Either: -->\n- [ ] There are tests for these changes OR\n- [ ] These changes do not require tests because _____\n\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\n\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/16586)\n<!-- Reviewable:end -->","distinct":true,"url":"https://api.github.com/repos/servo/servo/commits/66d3401389f6fae291e87cd229b6e249284c624b"}]}
{"actor":{"display_login":"bors-servo"}}