{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments/104171591","pull_request_review_id":24993408,"id":104171591,"diff_hunk":"@@ -41,34 +45,6 @@ public function process(ContainerBuilder $container)\n \n     /**\n      * @param ContainerBuilder $container\n-     *\n-     * @return array\n-     */\n-    public function fixSettings(ContainerBuilder $container)","path":"DependencyInjection/Compiler/AddProviderCompilerPass.php","position":27,"original_position":27,"commit_id":"ae822fe44c0059d3667048aadbc1c0394e7cb32e","original_commit_id":"ae822fe44c0059d3667048aadbc1c0394e7cb32e","user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars0.githubusercontent.com/u/1137485?v=3","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"body":"OK, will fix it","created_at":"2017-03-03T15:12:25Z","updated_at":"2017-03-03T15:12:25Z","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1218#discussion_r104171591","pull_request_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments/104171591"},"html":{"href":"https://github.com/sonata-project/SonataMediaBundle/pull/1218#discussion_r104171591"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218","id":108859811,"html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1218","diff_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1218.diff","patch_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1218.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1218","number":1218,"state":"open","locked":false,"title":"Changed how we retrieve configuration on AddProviderCompilerPass","user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars0.githubusercontent.com/u/1137485?v=3","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"body":"\r\n<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataMediaBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targetting this branch, because this is BC.\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Removed\r\n- Removed an ugly hack to retrieve configuration on `AddProviderCompilerPass`\r\n```\r\n\r\n## To do\r\n\r\n<!--\r\n    If this is a work in progress, COMPLETE and ADD needed tasks.\r\n    You can add as many tasks as you want.\r\n    If some are not relevant, just REMOVE them.\r\n-->\r\n\r\n- [ ] Update the tests\r\n\r\n## Subject\r\n\r\n<!-- Describe your Pull Request content here -->\r\nwe were previously using an ugly hack that was relying on changing a definition\r\non the Extension class and then recovering it (and removing it after all) on the\r\ncompiler pass.\r\n","created_at":"2017-03-02T21:54:07Z","updated_at":"2017-03-03T15:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5af4534f5f50f7fe73e8815ef0573d8f09373564","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1218/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/statuses/ae822fe44c0059d3667048aadbc1c0394e7cb32e","head":{"label":"jordisala1991:feature/remove_hack","ref":"feature/remove_hack","sha":"ae822fe44c0059d3667048aadbc1c0394e7cb32e","user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars0.githubusercontent.com/u/1137485?v=3","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"repo":{"id":59611311,"name":"SonataMediaBundle","full_name":"jordisala1991/SonataMediaBundle","owner":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars0.githubusercontent.com/u/1137485?v=3","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordisala1991/SonataMediaBundle","description":"Media management bundle on steroid for Symfony2","fork":true,"url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle","forks_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/forks","keys_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/teams","hooks_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/hooks","issue_events_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/issues/events{/number}","events_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/events","assignees_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/assignees{/user}","branches_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/branches{/branch}","tags_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/tags","blobs_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/languages","stargazers_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/stargazers","contributors_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/contributors","subscribers_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/subscribers","subscription_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/subscription","commits_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/contents/{+path}","compare_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/merges","archive_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/downloads","issues_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/issues{/number}","pulls_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/labels{/name}","releases_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/releases{/id}","deployments_url":"https://api.github.com/repos/jordisala1991/SonataMediaBundle/deployments","created_at":"2016-05-24T21:54:29Z","updated_at":"2016-05-24T21:54:31Z","pushed_at":"2017-03-03T06:52:11Z","git_url":"git://github.com/jordisala1991/SonataMediaBundle.git","ssh_url":"git@github.com:jordisala1991/SonataMediaBundle.git","clone_url":"https://github.com/jordisala1991/SonataMediaBundle.git","svn_url":"https://github.com/jordisala1991/SonataMediaBundle","homepage":"http://sonata-project.org/bundles/media","size":3136,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"ffcde0f3318449b8649594eadc3223424495ef0c","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars3.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1059291,"name":"SonataMediaBundle","full_name":"sonata-project/SonataMediaBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars3.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataMediaBundle","description":"Media management bundle on steroid for Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/deployments","created_at":"2010-11-07T14:41:46Z","updated_at":"2017-02-11T10:26:00Z","pushed_at":"2017-03-03T06:50:37Z","git_url":"git://github.com/sonata-project/SonataMediaBundle.git","ssh_url":"git@github.com:sonata-project/SonataMediaBundle.git","clone_url":"https://github.com/sonata-project/SonataMediaBundle.git","svn_url":"https://github.com/sonata-project/SonataMediaBundle","homepage":"http://sonata-project.org/bundles/media","size":3148,"stargazers_count":316,"watchers_count":316,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":407,"mirror_url":null,"open_issues_count":105,"forks":407,"open_issues":105,"watchers":316,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218"},"html":{"href":"https://github.com/sonata-project/SonataMediaBundle/pull/1218"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1218"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataMediaBundle/statuses/ae822fe44c0059d3667048aadbc1c0394e7cb32e"}}}}
{"actor":{"display_login":"jordisala1991"}}