{"action":"created","issue":{"url":"https://api.github.com/repos/LLK/scratch-blocks/issues/1188","repository_url":"https://api.github.com/repos/LLK/scratch-blocks","labels_url":"https://api.github.com/repos/LLK/scratch-blocks/issues/1188/labels{/name}","comments_url":"https://api.github.com/repos/LLK/scratch-blocks/issues/1188/comments","events_url":"https://api.github.com/repos/LLK/scratch-blocks/issues/1188/events","html_url":"https://github.com/LLK/scratch-blocks/issues/1188","id":269220203,"number":1188,"title":"glowStack() causes executing stack to hide until glow is removed","user":{"login":"msintov","id":1221526,"avatar_url":"https://avatars2.githubusercontent.com/u/1221526?v=4","gravatar_id":"","url":"https://api.github.com/users/msintov","html_url":"https://github.com/msintov","followers_url":"https://api.github.com/users/msintov/followers","following_url":"https://api.github.com/users/msintov/following{/other_user}","gists_url":"https://api.github.com/users/msintov/gists{/gist_id}","starred_url":"https://api.github.com/users/msintov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msintov/subscriptions","organizations_url":"https://api.github.com/users/msintov/orgs","repos_url":"https://api.github.com/users/msintov/repos","events_url":"https://api.github.com/users/msintov/events{/privacy}","received_events_url":"https://api.github.com/users/msintov/received_events","type":"User","site_admin":false},"labels":[{"id":308224270,"url":"https://api.github.com/repos/LLK/scratch-blocks/labels/bug","name":"bug","color":"fc2929","default":true},{"id":719006258,"url":"https://api.github.com/repos/LLK/scratch-blocks/labels/help%20wanted","name":"help wanted","color":"fbca04","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/LLK/scratch-blocks/milestones/2","html_url":"https://github.com/LLK/scratch-blocks/milestone/2","labels_url":"https://api.github.com/repos/LLK/scratch-blocks/milestones/2/labels","id":1515187,"number":2,"title":"Backlog","description":"","creator":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars3.githubusercontent.com/u/747641?v=4","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"open_issues":162,"closed_issues":188,"state":"open","created_at":"2016-01-19T14:14:51Z","updated_at":"2017-12-20T18:03:09Z","due_on":"2020-01-01T08:00:00Z","closed_at":null},"comments":8,"created_at":"2017-10-27T20:04:44Z","updated_at":"2017-12-21T16:18:29Z","closed_at":null,"author_association":"NONE","body":"### Expected Behavior\r\n\r\nThe executing script should have a yellow outline.\r\n\r\n### Actual Behavior\r\n\r\nThe executing script disappears.\r\n\r\n### Steps to Reproduce\r\n\r\nWe have observed this behavior on iOS and Android for scripts small and large, but in my reproducible case here, this behavior occurs for a very large script in the iOS simulator.\r\n\r\n1. Open the vertical playground in iOS simulator (I've tried iOS 9.3 and iOS 10.0. I believe it also repros on iOS 10.3. Perhaps also iOS 11).\r\n2. Paste this xml in the text box for importing: \r\n[xml_for_long_script.txt](https://github.com/LLK/scratch-blocks/files/1423307/xml_for_long_script.txt)\r\n3. Import the script by tapping \"Import from XML\"\r\n4. Tap the green flag block, which is the first block of the long script\r\n5. Tap \"Stack glow last clicked block\" button\r\n\r\nNote: If you remove the last block at the very bottom of the stack and then repeat steps 4 and 5, the script will not disappear, but notice that the glow outside is not yellow but instead is the color of the blocks it surrounds (as you can see if you page down through the stack).\r\n\r\n### Operating System and Browser\r\n\r\nXcode iOS simulator 9.3 and 10.0 on macOS 10.11.6\r\n"},"comment":{"url":"https://api.github.com/repos/LLK/scratch-blocks/issues/comments/353392242","html_url":"https://github.com/LLK/scratch-blocks/issues/1188#issuecomment-353392242","issue_url":"https://api.github.com/repos/LLK/scratch-blocks/issues/1188","id":353392242,"user":{"login":"paulkaplan","id":654102,"avatar_url":"https://avatars1.githubusercontent.com/u/654102?v=4","gravatar_id":"","url":"https://api.github.com/users/paulkaplan","html_url":"https://github.com/paulkaplan","followers_url":"https://api.github.com/users/paulkaplan/followers","following_url":"https://api.github.com/users/paulkaplan/following{/other_user}","gists_url":"https://api.github.com/users/paulkaplan/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkaplan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkaplan/subscriptions","organizations_url":"https://api.github.com/users/paulkaplan/orgs","repos_url":"https://api.github.com/users/paulkaplan/repos","events_url":"https://api.github.com/users/paulkaplan/events{/privacy}","received_events_url":"https://api.github.com/users/paulkaplan/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T16:18:28Z","updated_at":"2017-12-21T16:18:28Z","author_association":"OWNER","body":"@rachel-fenichel @thisandagain one option would be to not applying the glow filter for stacks above a certain size / for certain browsers. For example, in https://github.com/LLK/scratch-blocks/blob/develop/core/block_svg.js#L226-L232 we could check the BBox height of the svg against some constant we determine through experimentation. We might want to try this approach because gaussian blurs on giant SVG elements are a huge performance hit, even if they do render correctly.\r\n\r\nAnother way would be to change the glow to something that doesn't break, or if it isn't the same, provide some kind of graceful fallback in the event of a large stack. However, I tried the other related SVG filters (feMorphology + dilate, for example) and they suffer from the same scaling problem. Anyone have other ideas for implementing that kind of blur?"}}
{"actor":{"display_login":"paulkaplan"}}