{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/143280565","pull_request_review_id":67775777,"id":143280565,"diff_hunk":"@@ -79,5 +82,15 @@ public static ISiloHostBuilder ConfigureLogging(this ISiloHostBuilder builder, A\n         {\n             return builder.ConfigureServices(collection => collection.AddLogging(loggingBuilder => configureLogging(loggingBuilder)));\n         }\n+\n+        /// <summary>\n+        /// Configure silo to use GrainBasedMembership\n+        /// </summary>\n+        /// <param name=\"builder\"></param>\n+        /// <returns></returns>\n+        public static ISiloHostBuilder UseGrainBasedMembership(this ISiloHostBuilder builder)","path":"src/OrleansRuntime/Hosting/SiloHostBuilderExtensions.cs","position":21,"original_position":21,"commit_id":"2c85cb47adb1ddfffa594c51e63079b4199505b4","original_commit_id":"2c85cb47adb1ddfffa594c51e63079b4199505b4","user":{"login":"jdom","id":1361686,"avatar_url":"https://avatars3.githubusercontent.com/u/1361686?v=4","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false},"body":"As we talked about, it's currently confusing, but this class is for extension methods that also exist in the generic host builder, and are not Orleans specific. There's another one for Orleans specific configuration","created_at":"2017-10-06T19:49:40Z","updated_at":"2017-10-06T19:49:40Z","html_url":"https://github.com/dotnet/orleans/pull/3490#discussion_r143280565","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/3490","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/143280565"},"html":{"href":"https://github.com/dotnet/orleans/pull/3490#discussion_r143280565"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3490"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/3490","id":144551560,"html_url":"https://github.com/dotnet/orleans/pull/3490","diff_url":"https://github.com/dotnet/orleans/pull/3490.diff","patch_url":"https://github.com/dotnet/orleans/pull/3490.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/3490","number":3490,"state":"open","locked":false,"title":"Migrate MembershipTables to use Options for its configuration","user":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars3.githubusercontent.com/u/20803801?v=4","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"body":"- migrate IMembershipTable to use Options as configuration object. \r\n- MembershipTableFactory now use DI to create IMembershiptable, instead of reflection\r\n- split IGatewayListProvider implementation from IMembershupTable implementation if these two share the same class. Have to do this for correct initialization of GatewayListProvider in the client side\r\n-migrate tests to use the new way of configure membership tables. Some tests still use the legacy ways just to test out the legacy config still works ","created_at":"2017-10-03T23:20:29Z","updated_at":"2017-10-06T19:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd0e718eb46107b04f0e8f5d51bb33c8cc67990d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/dotnet/orleans/milestones/20","html_url":"https://github.com/dotnet/orleans/milestone/20","labels_url":"https://api.github.com/repos/dotnet/orleans/milestones/20/labels","id":2757603,"number":20,"title":"2.0.0-beta","description":"","creator":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars1.githubusercontent.com/u/8248806?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":18,"state":"open","created_at":"2017-09-11T15:32:03Z","updated_at":"2017-10-05T22:59:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/3490/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/3490/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/3490/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/2c85cb47adb1ddfffa594c51e63079b4199505b4","head":{"label":"xiazen:membership-config","ref":"membership-config","sha":"2c85cb47adb1ddfffa594c51e63079b4199505b4","user":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars3.githubusercontent.com/u/20803801?v=4","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"repo":{"id":66402876,"name":"orleans","full_name":"xiazen/orleans","owner":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars3.githubusercontent.com/u/20803801?v=4","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiazen/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/xiazen/orleans","forks_url":"https://api.github.com/repos/xiazen/orleans/forks","keys_url":"https://api.github.com/repos/xiazen/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiazen/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiazen/orleans/teams","hooks_url":"https://api.github.com/repos/xiazen/orleans/hooks","issue_events_url":"https://api.github.com/repos/xiazen/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/xiazen/orleans/events","assignees_url":"https://api.github.com/repos/xiazen/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/xiazen/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/xiazen/orleans/tags","blobs_url":"https://api.github.com/repos/xiazen/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiazen/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiazen/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiazen/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiazen/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/xiazen/orleans/languages","stargazers_url":"https://api.github.com/repos/xiazen/orleans/stargazers","contributors_url":"https://api.github.com/repos/xiazen/orleans/contributors","subscribers_url":"https://api.github.com/repos/xiazen/orleans/subscribers","subscription_url":"https://api.github.com/repos/xiazen/orleans/subscription","commits_url":"https://api.github.com/repos/xiazen/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiazen/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiazen/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiazen/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiazen/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/xiazen/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiazen/orleans/merges","archive_url":"https://api.github.com/repos/xiazen/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiazen/orleans/downloads","issues_url":"https://api.github.com/repos/xiazen/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/xiazen/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/xiazen/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/xiazen/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiazen/orleans/labels{/name}","releases_url":"https://api.github.com/repos/xiazen/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/xiazen/orleans/deployments","created_at":"2016-08-23T20:59:50Z","updated_at":"2016-11-03T01:51:16Z","pushed_at":"2017-10-05T23:16:26Z","git_url":"git://github.com/xiazen/orleans.git","ssh_url":"git@github.com:xiazen/orleans.git","clone_url":"https://github.com/xiazen/orleans.git","svn_url":"https://github.com/xiazen/orleans","homepage":"http://dotnet.github.io/orleans","size":21101,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"db5acaab74026adff99403c8458607b2c8b4a2d8","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2017-10-06T07:53:43Z","pushed_at":"2017-10-06T19:49:16Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":41198,"stargazers_count":3150,"watchers_count":3150,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":783,"mirror_url":null,"open_issues_count":319,"forks":783,"open_issues":319,"watchers":3150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3490"},"html":{"href":"https://github.com/dotnet/orleans/pull/3490"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3490"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3490/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3490/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3490/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/2c85cb47adb1ddfffa594c51e63079b4199505b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdom"}}