{"action":"created","comment":{"url":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments/95600740","pull_request_review_id":16161009,"id":95600740,"diff_hunk":"@@ -71,4 +71,4 @@ RUN mkdir /bzt-configs \\\n   && rm -rf /tmp/*\n \n WORKDIR /bzt-configs\n-CMD bzt -l /tmp/artifacts/bzt.log /bzt-configs/*.yml\n+ENTRYPOINT [\"sh\", \"-c\", \"bzt /bzt-configs/*.yml -l /tmp/artifacts/bzt.log \\\"$@\\\"\", \"ignored\"]","path":"Dockerfile","position":5,"original_position":5,"commit_id":"d880b8f0504b689dcee3487472e21b5f630fd4c5","original_commit_id":"d880b8f0504b689dcee3487472e21b5f630fd4c5","user":{"login":"thompsnm","id":5762421,"avatar_url":"https://avatars.githubusercontent.com/u/5762421?v=3","gravatar_id":"","url":"https://api.github.com/users/thompsnm","html_url":"https://github.com/thompsnm","followers_url":"https://api.github.com/users/thompsnm/followers","following_url":"https://api.github.com/users/thompsnm/following{/other_user}","gists_url":"https://api.github.com/users/thompsnm/gists{/gist_id}","starred_url":"https://api.github.com/users/thompsnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thompsnm/subscriptions","organizations_url":"https://api.github.com/users/thompsnm/orgs","repos_url":"https://api.github.com/users/thompsnm/repos","events_url":"https://api.github.com/users/thompsnm/events{/privacy}","received_events_url":"https://api.github.com/users/thompsnm/received_events","type":"User","site_admin":false},"body":"Ah, so you are thinking that the user should just pass the config files in as additional `docker run` command line arguments? Something like this:\r\n\r\n    docker run undera/taurus myConfig1.yml myConfig2.yml\r\n\r\nThat would certainly simplify the Docker file, and it would also allow using .json config files. It is worth noting though that configuring the ENTRYPOINT like that would definitely be a breaking change, and would need a new major version if you're following SemVer. I'll go ahead and make that change to this PR and then you can decide if it's worth keeping.\r\n\r\nI'm glad I can help!","created_at":"2017-01-11T15:26:57Z","updated_at":"2017-01-11T15:26:57Z","html_url":"https://github.com/Blazemeter/taurus/pull/456#discussion_r95600740","pull_request_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/456","_links":{"self":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments/95600740"},"html":{"href":"https://github.com/Blazemeter/taurus/pull/456#discussion_r95600740"},"pull_request":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/Blazemeter/taurus/pulls/456","id":100780441,"html_url":"https://github.com/Blazemeter/taurus/pull/456","diff_url":"https://github.com/Blazemeter/taurus/pull/456.diff","patch_url":"https://github.com/Blazemeter/taurus/pull/456.patch","issue_url":"https://api.github.com/repos/Blazemeter/taurus/issues/456","number":456,"state":"open","locked":false,"title":"Allow options overrides as provided by the bzt cli","user":{"login":"thompsnm","id":5762421,"avatar_url":"https://avatars.githubusercontent.com/u/5762421?v=3","gravatar_id":"","url":"https://api.github.com/users/thompsnm","html_url":"https://github.com/thompsnm","followers_url":"https://api.github.com/users/thompsnm/followers","following_url":"https://api.github.com/users/thompsnm/following{/other_user}","gists_url":"https://api.github.com/users/thompsnm/gists{/gist_id}","starred_url":"https://api.github.com/users/thompsnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thompsnm/subscriptions","organizations_url":"https://api.github.com/users/thompsnm/orgs","repos_url":"https://api.github.com/users/thompsnm/repos","events_url":"https://api.github.com/users/thompsnm/events{/privacy}","received_events_url":"https://api.github.com/users/thompsnm/received_events","type":"User","site_admin":false},"body":"## Background:\r\nI have an application where users are able to schedule events and then have other users register for those events. I want to load test our event registration endpoints using the [undera/taurus/](https://hub.docker.com/r/undera/taurus/) Docker image in my Jenkins environment. I want the tests to run against a new event each time, which means I have to be able to dynamically pass the registration URL for the event under test to the Docker run.\r\n\r\n## What this PR does:\r\nUsers will be able to pass an arbitrary number of option overrides to the Docker run. Since [Docker environment variable only support simple values](https://github.com/docker/docker/issues/20169#issuecomment-268548383), I configured the Dockerfile CMD to look for a file named `overrides.txt` in the `/bzt-configs` directory that will contain an option override on each line. If that file exists, the CMD will parse each line and include it as a `-o` argument to the `bzt` command.","created_at":"2017-01-09T23:14:30Z","updated_at":"2017-01-11T15:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"833d4cdd3f60bc2a30e60936667d1db1be9139b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/456/commits","review_comments_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/456/comments","review_comment_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/issues/456/comments","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/d880b8f0504b689dcee3487472e21b5f630fd4c5","head":{"label":"thompsnm:master","ref":"master","sha":"d880b8f0504b689dcee3487472e21b5f630fd4c5","user":{"login":"thompsnm","id":5762421,"avatar_url":"https://avatars.githubusercontent.com/u/5762421?v=3","gravatar_id":"","url":"https://api.github.com/users/thompsnm","html_url":"https://github.com/thompsnm","followers_url":"https://api.github.com/users/thompsnm/followers","following_url":"https://api.github.com/users/thompsnm/following{/other_user}","gists_url":"https://api.github.com/users/thompsnm/gists{/gist_id}","starred_url":"https://api.github.com/users/thompsnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thompsnm/subscriptions","organizations_url":"https://api.github.com/users/thompsnm/orgs","repos_url":"https://api.github.com/users/thompsnm/repos","events_url":"https://api.github.com/users/thompsnm/events{/privacy}","received_events_url":"https://api.github.com/users/thompsnm/received_events","type":"User","site_admin":false},"repo":{"id":78361288,"name":"taurus","full_name":"thompsnm/taurus","owner":{"login":"thompsnm","id":5762421,"avatar_url":"https://avatars.githubusercontent.com/u/5762421?v=3","gravatar_id":"","url":"https://api.github.com/users/thompsnm","html_url":"https://github.com/thompsnm","followers_url":"https://api.github.com/users/thompsnm/followers","following_url":"https://api.github.com/users/thompsnm/following{/other_user}","gists_url":"https://api.github.com/users/thompsnm/gists{/gist_id}","starred_url":"https://api.github.com/users/thompsnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thompsnm/subscriptions","organizations_url":"https://api.github.com/users/thompsnm/orgs","repos_url":"https://api.github.com/users/thompsnm/repos","events_url":"https://api.github.com/users/thompsnm/events{/privacy}","received_events_url":"https://api.github.com/users/thompsnm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thompsnm/taurus","description":"Automation-friendly framework for Continuous Testing by","fork":true,"url":"https://api.github.com/repos/thompsnm/taurus","forks_url":"https://api.github.com/repos/thompsnm/taurus/forks","keys_url":"https://api.github.com/repos/thompsnm/taurus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thompsnm/taurus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thompsnm/taurus/teams","hooks_url":"https://api.github.com/repos/thompsnm/taurus/hooks","issue_events_url":"https://api.github.com/repos/thompsnm/taurus/issues/events{/number}","events_url":"https://api.github.com/repos/thompsnm/taurus/events","assignees_url":"https://api.github.com/repos/thompsnm/taurus/assignees{/user}","branches_url":"https://api.github.com/repos/thompsnm/taurus/branches{/branch}","tags_url":"https://api.github.com/repos/thompsnm/taurus/tags","blobs_url":"https://api.github.com/repos/thompsnm/taurus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thompsnm/taurus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thompsnm/taurus/git/refs{/sha}","trees_url":"https://api.github.com/repos/thompsnm/taurus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thompsnm/taurus/statuses/{sha}","languages_url":"https://api.github.com/repos/thompsnm/taurus/languages","stargazers_url":"https://api.github.com/repos/thompsnm/taurus/stargazers","contributors_url":"https://api.github.com/repos/thompsnm/taurus/contributors","subscribers_url":"https://api.github.com/repos/thompsnm/taurus/subscribers","subscription_url":"https://api.github.com/repos/thompsnm/taurus/subscription","commits_url":"https://api.github.com/repos/thompsnm/taurus/commits{/sha}","git_commits_url":"https://api.github.com/repos/thompsnm/taurus/git/commits{/sha}","comments_url":"https://api.github.com/repos/thompsnm/taurus/comments{/number}","issue_comment_url":"https://api.github.com/repos/thompsnm/taurus/issues/comments{/number}","contents_url":"https://api.github.com/repos/thompsnm/taurus/contents/{+path}","compare_url":"https://api.github.com/repos/thompsnm/taurus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thompsnm/taurus/merges","archive_url":"https://api.github.com/repos/thompsnm/taurus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thompsnm/taurus/downloads","issues_url":"https://api.github.com/repos/thompsnm/taurus/issues{/number}","pulls_url":"https://api.github.com/repos/thompsnm/taurus/pulls{/number}","milestones_url":"https://api.github.com/repos/thompsnm/taurus/milestones{/number}","notifications_url":"https://api.github.com/repos/thompsnm/taurus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thompsnm/taurus/labels{/name}","releases_url":"https://api.github.com/repos/thompsnm/taurus/releases{/id}","deployments_url":"https://api.github.com/repos/thompsnm/taurus/deployments","created_at":"2017-01-08T18:11:40Z","updated_at":"2017-01-08T18:11:45Z","pushed_at":"2017-01-10T18:38:39Z","git_url":"git://github.com/thompsnm/taurus.git","ssh_url":"git@github.com:thompsnm/taurus.git","clone_url":"https://github.com/thompsnm/taurus.git","svn_url":"https://github.com/thompsnm/taurus","homepage":"http://gettaurus.org","size":11012,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Blazemeter:master","ref":"master","sha":"f607a0d4386e58a413b818c07d960326266ab50d","user":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"repo":{"id":30940272,"name":"taurus","full_name":"Blazemeter/taurus","owner":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blazemeter/taurus","description":"Automation-friendly framework for Continuous Testing by","fork":false,"url":"https://api.github.com/repos/Blazemeter/taurus","forks_url":"https://api.github.com/repos/Blazemeter/taurus/forks","keys_url":"https://api.github.com/repos/Blazemeter/taurus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blazemeter/taurus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blazemeter/taurus/teams","hooks_url":"https://api.github.com/repos/Blazemeter/taurus/hooks","issue_events_url":"https://api.github.com/repos/Blazemeter/taurus/issues/events{/number}","events_url":"https://api.github.com/repos/Blazemeter/taurus/events","assignees_url":"https://api.github.com/repos/Blazemeter/taurus/assignees{/user}","branches_url":"https://api.github.com/repos/Blazemeter/taurus/branches{/branch}","tags_url":"https://api.github.com/repos/Blazemeter/taurus/tags","blobs_url":"https://api.github.com/repos/Blazemeter/taurus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blazemeter/taurus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blazemeter/taurus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blazemeter/taurus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/{sha}","languages_url":"https://api.github.com/repos/Blazemeter/taurus/languages","stargazers_url":"https://api.github.com/repos/Blazemeter/taurus/stargazers","contributors_url":"https://api.github.com/repos/Blazemeter/taurus/contributors","subscribers_url":"https://api.github.com/repos/Blazemeter/taurus/subscribers","subscription_url":"https://api.github.com/repos/Blazemeter/taurus/subscription","commits_url":"https://api.github.com/repos/Blazemeter/taurus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blazemeter/taurus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blazemeter/taurus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blazemeter/taurus/contents/{+path}","compare_url":"https://api.github.com/repos/Blazemeter/taurus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blazemeter/taurus/merges","archive_url":"https://api.github.com/repos/Blazemeter/taurus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blazemeter/taurus/downloads","issues_url":"https://api.github.com/repos/Blazemeter/taurus/issues{/number}","pulls_url":"https://api.github.com/repos/Blazemeter/taurus/pulls{/number}","milestones_url":"https://api.github.com/repos/Blazemeter/taurus/milestones{/number}","notifications_url":"https://api.github.com/repos/Blazemeter/taurus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blazemeter/taurus/labels{/name}","releases_url":"https://api.github.com/repos/Blazemeter/taurus/releases{/id}","deployments_url":"https://api.github.com/repos/Blazemeter/taurus/deployments","created_at":"2015-02-17T22:05:08Z","updated_at":"2017-01-11T06:34:10Z","pushed_at":"2017-01-11T10:08:39Z","git_url":"git://github.com/Blazemeter/taurus.git","ssh_url":"git@github.com:Blazemeter/taurus.git","clone_url":"https://github.com/Blazemeter/taurus.git","svn_url":"https://github.com/Blazemeter/taurus","homepage":"http://gettaurus.org","size":11090,"stargazers_count":295,"watchers_count":295,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":6,"forks":65,"open_issues":6,"watchers":295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/456"},"html":{"href":"https://github.com/Blazemeter/taurus/pull/456"},"issue":{"href":"https://api.github.com/repos/Blazemeter/taurus/issues/456"},"comments":{"href":"https://api.github.com/repos/Blazemeter/taurus/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/Blazemeter/taurus/statuses/d880b8f0504b689dcee3487472e21b5f630fd4c5"}}}}
{"actor":{"display_login":"thompsnm"}}