{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/1951","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/1951/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/1951/comments","events_url":"https://api.github.com/repos/istio/istio/issues/1951/events","html_url":"https://github.com/istio/istio/pull/1951","id":278348793,"number":1951,"title":"add service controller for identity registry support","user":{"login":"crazytan","id":9136175,"avatar_url":"https://avatars2.githubusercontent.com/u/9136175?v=4","gravatar_id":"","url":"https://api.github.com/users/crazytan","html_url":"https://github.com/crazytan","followers_url":"https://api.github.com/users/crazytan/followers","following_url":"https://api.github.com/users/crazytan/following{/other_user}","gists_url":"https://api.github.com/users/crazytan/gists{/gist_id}","starred_url":"https://api.github.com/users/crazytan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazytan/subscriptions","organizations_url":"https://api.github.com/users/crazytan/orgs","repos_url":"https://api.github.com/users/crazytan/repos","events_url":"https://api.github.com/users/crazytan/events{/privacy}","received_events_url":"https://api.github.com/users/crazytan/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":660556986,"url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"c2e0c6","default":false},{"id":660558399,"url":"https://api.github.com/repos/istio/istio/labels/release-note-none","name":"release-note-none","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"wattli","id":24381542,"avatar_url":"https://avatars1.githubusercontent.com/u/24381542?v=4","gravatar_id":"","url":"https://api.github.com/users/wattli","html_url":"https://github.com/wattli","followers_url":"https://api.github.com/users/wattli/followers","following_url":"https://api.github.com/users/wattli/following{/other_user}","gists_url":"https://api.github.com/users/wattli/gists{/gist_id}","starred_url":"https://api.github.com/users/wattli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wattli/subscriptions","organizations_url":"https://api.github.com/users/wattli/orgs","repos_url":"https://api.github.com/users/wattli/repos","events_url":"https://api.github.com/users/wattli/events{/privacy}","received_events_url":"https://api.github.com/users/wattli/received_events","type":"User","site_admin":false},"assignees":[{"login":"wattli","id":24381542,"avatar_url":"https://avatars1.githubusercontent.com/u/24381542?v=4","gravatar_id":"","url":"https://api.github.com/users/wattli","html_url":"https://github.com/wattli","followers_url":"https://api.github.com/users/wattli/followers","following_url":"https://api.github.com/users/wattli/following{/other_user}","gists_url":"https://api.github.com/users/wattli/gists{/gist_id}","starred_url":"https://api.github.com/users/wattli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wattli/subscriptions","organizations_url":"https://api.github.com/users/wattli/orgs","repos_url":"https://api.github.com/users/wattli/repos","events_url":"https://api.github.com/users/wattli/events{/privacy}","received_events_url":"https://api.github.com/users/wattli/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-12-01T03:44:46Z","updated_at":"2017-12-04T17:55:36Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/1951","html_url":"https://github.com/istio/istio/pull/1951","diff_url":"https://github.com/istio/istio/pull/1951.diff","patch_url":"https://github.com/istio/istio/pull/1951.patch"},"body":"**What this PR does / why we need it**:\r\nIt adds a service controller, that is similar to secret controller and listens for events related to Service objects. Therefore another goroutine is started in CA which does nothing currently. `service_test.go` demonstrates how a very simple registry should work with the controller.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/istio/old_auth_repo/issues/293\r\n\r\n**Special notes for your reviewer**:\r\nI also removed unreachable code at the end of `main()`.\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/349046792","html_url":"https://github.com/istio/istio/pull/1951#issuecomment-349046792","issue_url":"https://api.github.com/repos/istio/istio/issues/1951","id":349046792,"user":{"login":"istio-merge-robot","id":30445278,"avatar_url":"https://avatars2.githubusercontent.com/u/30445278?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-merge-robot","html_url":"https://github.com/istio-merge-robot","followers_url":"https://api.github.com/users/istio-merge-robot/followers","following_url":"https://api.github.com/users/istio-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/istio-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/istio-merge-robot/orgs","repos_url":"https://api.github.com/users/istio-merge-robot/repos","events_url":"https://api.github.com/users/istio-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/istio-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-12-04T17:55:36Z","updated_at":"2017-12-04T17:55:36Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/1951#issuecomment-349046547\" title=\"Approved\">wattli</a>*\n\n\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[security/OWNERS](https://github.com/istio/istio/blob/master/security/OWNERS)~~ [wattli]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"istio-merge-robot"}}