{"action":"created","comment":{"url":"https://api.github.com/repos/marko-js/marko/pulls/comments/132501698","pull_request_review_id":55589618,"id":132501698,"diff_hunk":"@@ -74,6 +74,11 @@ function attachBubbleEventListeners(doc) {\n             var curNode = event.target;\n             if (!curNode) {\n                 return;\n+            } else if (typeof SVGElementInstance !== 'undefined' && curNode instanceof SVGElementInstance) {\n+                // event.target of an SVGElementInstance does not have a\n+                // `getAttribute` function in IE 11.\n+                // See https://github.com/marko-js/marko/issues/796\n+                curNode = curNode.correspondingUseElement || curNode;","path":"src/components/event-delegation.js","position":null,"original_position":8,"commit_id":"f5ebf16579e8731ece2bce3bdc95fa2dbcd395f0","original_commit_id":"f697728e6ad210bb98163d0a41e7b7151d089299","user":{"login":"austinkelleher","id":3771924,"avatar_url":"https://avatars0.githubusercontent.com/u/3771924?v=4","gravatar_id":"","url":"https://api.github.com/users/austinkelleher","html_url":"https://github.com/austinkelleher","followers_url":"https://api.github.com/users/austinkelleher/followers","following_url":"https://api.github.com/users/austinkelleher/following{/other_user}","gists_url":"https://api.github.com/users/austinkelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/austinkelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinkelleher/subscriptions","organizations_url":"https://api.github.com/users/austinkelleher/orgs","repos_url":"https://api.github.com/users/austinkelleher/repos","events_url":"https://api.github.com/users/austinkelleher/events{/privacy}","received_events_url":"https://api.github.com/users/austinkelleher/received_events","type":"User","site_admin":false},"body":"@patrick-steele-idem Updated. Thanks for the suggestion.","created_at":"2017-08-10T16:22:00Z","updated_at":"2017-08-10T16:22:00Z","html_url":"https://github.com/marko-js/marko/pull/797#discussion_r132501698","pull_request_url":"https://api.github.com/repos/marko-js/marko/pulls/797","_links":{"self":{"href":"https://api.github.com/repos/marko-js/marko/pulls/comments/132501698"},"html":{"href":"https://github.com/marko-js/marko/pull/797#discussion_r132501698"},"pull_request":{"href":"https://api.github.com/repos/marko-js/marko/pulls/797"}}},"pull_request":{"url":"https://api.github.com/repos/marko-js/marko/pulls/797","id":135156822,"html_url":"https://github.com/marko-js/marko/pull/797","diff_url":"https://github.com/marko-js/marko/pull/797.diff","patch_url":"https://github.com/marko-js/marko/pull/797.patch","issue_url":"https://api.github.com/repos/marko-js/marko/issues/797","number":797,"state":"open","locked":false,"title":"Fixes #796 - Fix events for event targets that are SVGElementInstance…","user":{"login":"austinkelleher","id":3771924,"avatar_url":"https://avatars0.githubusercontent.com/u/3771924?v=4","gravatar_id":"","url":"https://api.github.com/users/austinkelleher","html_url":"https://github.com/austinkelleher","followers_url":"https://api.github.com/users/austinkelleher/followers","following_url":"https://api.github.com/users/austinkelleher/following{/other_user}","gists_url":"https://api.github.com/users/austinkelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/austinkelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinkelleher/subscriptions","organizations_url":"https://api.github.com/users/austinkelleher/orgs","repos_url":"https://api.github.com/users/austinkelleher/repos","events_url":"https://api.github.com/users/austinkelleher/events{/privacy}","received_events_url":"https://api.github.com/users/austinkelleher/received_events","type":"User","site_admin":false},"body":"… types in IE11.\r\n\r\nNot sure of a great way to test this since it only happens in IE11 and `SVGElementInstance` only exists in IE. I manually tested this fix in IE and Edge and validated that it does not break Chrome.","created_at":"2017-08-10T15:37:30Z","updated_at":"2017-08-10T16:22:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3018464cdc6900f9cb44f5c18aa490de9db7d7a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mlrawlings","id":1958812,"avatar_url":"https://avatars1.githubusercontent.com/u/1958812?v=4","gravatar_id":"","url":"https://api.github.com/users/mlrawlings","html_url":"https://github.com/mlrawlings","followers_url":"https://api.github.com/users/mlrawlings/followers","following_url":"https://api.github.com/users/mlrawlings/following{/other_user}","gists_url":"https://api.github.com/users/mlrawlings/gists{/gist_id}","starred_url":"https://api.github.com/users/mlrawlings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlrawlings/subscriptions","organizations_url":"https://api.github.com/users/mlrawlings/orgs","repos_url":"https://api.github.com/users/mlrawlings/repos","events_url":"https://api.github.com/users/mlrawlings/events{/privacy}","received_events_url":"https://api.github.com/users/mlrawlings/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/marko-js/marko/pulls/797/commits","review_comments_url":"https://api.github.com/repos/marko-js/marko/pulls/797/comments","review_comment_url":"https://api.github.com/repos/marko-js/marko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marko-js/marko/issues/797/comments","statuses_url":"https://api.github.com/repos/marko-js/marko/statuses/f5ebf16579e8731ece2bce3bdc95fa2dbcd395f0","head":{"label":"marko-js:796-svg-symbol-event","ref":"796-svg-symbol-event","sha":"f5ebf16579e8731ece2bce3bdc95fa2dbcd395f0","user":{"login":"marko-js","id":11873696,"avatar_url":"https://avatars3.githubusercontent.com/u/11873696?v=4","gravatar_id":"","url":"https://api.github.com/users/marko-js","html_url":"https://github.com/marko-js","followers_url":"https://api.github.com/users/marko-js/followers","following_url":"https://api.github.com/users/marko-js/following{/other_user}","gists_url":"https://api.github.com/users/marko-js/gists{/gist_id}","starred_url":"https://api.github.com/users/marko-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marko-js/subscriptions","organizations_url":"https://api.github.com/users/marko-js/orgs","repos_url":"https://api.github.com/users/marko-js/repos","events_url":"https://api.github.com/users/marko-js/events{/privacy}","received_events_url":"https://api.github.com/users/marko-js/received_events","type":"Organization","site_admin":false},"repo":{"id":15720445,"name":"marko","full_name":"marko-js/marko","owner":{"login":"marko-js","id":11873696,"avatar_url":"https://avatars3.githubusercontent.com/u/11873696?v=4","gravatar_id":"","url":"https://api.github.com/users/marko-js","html_url":"https://github.com/marko-js","followers_url":"https://api.github.com/users/marko-js/followers","following_url":"https://api.github.com/users/marko-js/following{/other_user}","gists_url":"https://api.github.com/users/marko-js/gists{/gist_id}","starred_url":"https://api.github.com/users/marko-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marko-js/subscriptions","organizations_url":"https://api.github.com/users/marko-js/orgs","repos_url":"https://api.github.com/users/marko-js/repos","events_url":"https://api.github.com/users/marko-js/events{/privacy}","received_events_url":"https://api.github.com/users/marko-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marko-js/marko","description":"A friendly (and fast!) UI library from eBay that makes building web apps fun","fork":false,"url":"https://api.github.com/repos/marko-js/marko","forks_url":"https://api.github.com/repos/marko-js/marko/forks","keys_url":"https://api.github.com/repos/marko-js/marko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marko-js/marko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marko-js/marko/teams","hooks_url":"https://api.github.com/repos/marko-js/marko/hooks","issue_events_url":"https://api.github.com/repos/marko-js/marko/issues/events{/number}","events_url":"https://api.github.com/repos/marko-js/marko/events","assignees_url":"https://api.github.com/repos/marko-js/marko/assignees{/user}","branches_url":"https://api.github.com/repos/marko-js/marko/branches{/branch}","tags_url":"https://api.github.com/repos/marko-js/marko/tags","blobs_url":"https://api.github.com/repos/marko-js/marko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marko-js/marko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marko-js/marko/git/refs{/sha}","trees_url":"https://api.github.com/repos/marko-js/marko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marko-js/marko/statuses/{sha}","languages_url":"https://api.github.com/repos/marko-js/marko/languages","stargazers_url":"https://api.github.com/repos/marko-js/marko/stargazers","contributors_url":"https://api.github.com/repos/marko-js/marko/contributors","subscribers_url":"https://api.github.com/repos/marko-js/marko/subscribers","subscription_url":"https://api.github.com/repos/marko-js/marko/subscription","commits_url":"https://api.github.com/repos/marko-js/marko/commits{/sha}","git_commits_url":"https://api.github.com/repos/marko-js/marko/git/commits{/sha}","comments_url":"https://api.github.com/repos/marko-js/marko/comments{/number}","issue_comment_url":"https://api.github.com/repos/marko-js/marko/issues/comments{/number}","contents_url":"https://api.github.com/repos/marko-js/marko/contents/{+path}","compare_url":"https://api.github.com/repos/marko-js/marko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marko-js/marko/merges","archive_url":"https://api.github.com/repos/marko-js/marko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marko-js/marko/downloads","issues_url":"https://api.github.com/repos/marko-js/marko/issues{/number}","pulls_url":"https://api.github.com/repos/marko-js/marko/pulls{/number}","milestones_url":"https://api.github.com/repos/marko-js/marko/milestones{/number}","notifications_url":"https://api.github.com/repos/marko-js/marko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marko-js/marko/labels{/name}","releases_url":"https://api.github.com/repos/marko-js/marko/releases{/id}","deployments_url":"https://api.github.com/repos/marko-js/marko/deployments","created_at":"2014-01-07T23:58:21Z","updated_at":"2017-08-10T08:33:03Z","pushed_at":"2017-08-10T16:21:22Z","git_url":"git://github.com/marko-js/marko.git","ssh_url":"git@github.com:marko-js/marko.git","clone_url":"https://github.com/marko-js/marko.git","svn_url":"https://github.com/marko-js/marko","homepage":"http://markojs.com/","size":6193,"stargazers_count":3193,"watchers_count":3193,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":115,"forks":179,"open_issues":115,"watchers":3193,"default_branch":"master"}},"base":{"label":"marko-js:master","ref":"master","sha":"b16e16a556c88a2b9b5b78ee3a1bf37b9d708317","user":{"login":"marko-js","id":11873696,"avatar_url":"https://avatars3.githubusercontent.com/u/11873696?v=4","gravatar_id":"","url":"https://api.github.com/users/marko-js","html_url":"https://github.com/marko-js","followers_url":"https://api.github.com/users/marko-js/followers","following_url":"https://api.github.com/users/marko-js/following{/other_user}","gists_url":"https://api.github.com/users/marko-js/gists{/gist_id}","starred_url":"https://api.github.com/users/marko-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marko-js/subscriptions","organizations_url":"https://api.github.com/users/marko-js/orgs","repos_url":"https://api.github.com/users/marko-js/repos","events_url":"https://api.github.com/users/marko-js/events{/privacy}","received_events_url":"https://api.github.com/users/marko-js/received_events","type":"Organization","site_admin":false},"repo":{"id":15720445,"name":"marko","full_name":"marko-js/marko","owner":{"login":"marko-js","id":11873696,"avatar_url":"https://avatars3.githubusercontent.com/u/11873696?v=4","gravatar_id":"","url":"https://api.github.com/users/marko-js","html_url":"https://github.com/marko-js","followers_url":"https://api.github.com/users/marko-js/followers","following_url":"https://api.github.com/users/marko-js/following{/other_user}","gists_url":"https://api.github.com/users/marko-js/gists{/gist_id}","starred_url":"https://api.github.com/users/marko-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marko-js/subscriptions","organizations_url":"https://api.github.com/users/marko-js/orgs","repos_url":"https://api.github.com/users/marko-js/repos","events_url":"https://api.github.com/users/marko-js/events{/privacy}","received_events_url":"https://api.github.com/users/marko-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marko-js/marko","description":"A friendly (and fast!) UI library from eBay that makes building web apps fun","fork":false,"url":"https://api.github.com/repos/marko-js/marko","forks_url":"https://api.github.com/repos/marko-js/marko/forks","keys_url":"https://api.github.com/repos/marko-js/marko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marko-js/marko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marko-js/marko/teams","hooks_url":"https://api.github.com/repos/marko-js/marko/hooks","issue_events_url":"https://api.github.com/repos/marko-js/marko/issues/events{/number}","events_url":"https://api.github.com/repos/marko-js/marko/events","assignees_url":"https://api.github.com/repos/marko-js/marko/assignees{/user}","branches_url":"https://api.github.com/repos/marko-js/marko/branches{/branch}","tags_url":"https://api.github.com/repos/marko-js/marko/tags","blobs_url":"https://api.github.com/repos/marko-js/marko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marko-js/marko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marko-js/marko/git/refs{/sha}","trees_url":"https://api.github.com/repos/marko-js/marko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marko-js/marko/statuses/{sha}","languages_url":"https://api.github.com/repos/marko-js/marko/languages","stargazers_url":"https://api.github.com/repos/marko-js/marko/stargazers","contributors_url":"https://api.github.com/repos/marko-js/marko/contributors","subscribers_url":"https://api.github.com/repos/marko-js/marko/subscribers","subscription_url":"https://api.github.com/repos/marko-js/marko/subscription","commits_url":"https://api.github.com/repos/marko-js/marko/commits{/sha}","git_commits_url":"https://api.github.com/repos/marko-js/marko/git/commits{/sha}","comments_url":"https://api.github.com/repos/marko-js/marko/comments{/number}","issue_comment_url":"https://api.github.com/repos/marko-js/marko/issues/comments{/number}","contents_url":"https://api.github.com/repos/marko-js/marko/contents/{+path}","compare_url":"https://api.github.com/repos/marko-js/marko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marko-js/marko/merges","archive_url":"https://api.github.com/repos/marko-js/marko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marko-js/marko/downloads","issues_url":"https://api.github.com/repos/marko-js/marko/issues{/number}","pulls_url":"https://api.github.com/repos/marko-js/marko/pulls{/number}","milestones_url":"https://api.github.com/repos/marko-js/marko/milestones{/number}","notifications_url":"https://api.github.com/repos/marko-js/marko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marko-js/marko/labels{/name}","releases_url":"https://api.github.com/repos/marko-js/marko/releases{/id}","deployments_url":"https://api.github.com/repos/marko-js/marko/deployments","created_at":"2014-01-07T23:58:21Z","updated_at":"2017-08-10T08:33:03Z","pushed_at":"2017-08-10T16:21:22Z","git_url":"git://github.com/marko-js/marko.git","ssh_url":"git@github.com:marko-js/marko.git","clone_url":"https://github.com/marko-js/marko.git","svn_url":"https://github.com/marko-js/marko","homepage":"http://markojs.com/","size":6193,"stargazers_count":3193,"watchers_count":3193,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":115,"forks":179,"open_issues":115,"watchers":3193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marko-js/marko/pulls/797"},"html":{"href":"https://github.com/marko-js/marko/pull/797"},"issue":{"href":"https://api.github.com/repos/marko-js/marko/issues/797"},"comments":{"href":"https://api.github.com/repos/marko-js/marko/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/marko-js/marko/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/marko-js/marko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marko-js/marko/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/marko-js/marko/statuses/f5ebf16579e8731ece2bce3bdc95fa2dbcd395f0"}}}}
{"actor":{"display_login":"austinkelleher"}}