{"action":"closed","number":1329,"pull_request":{"url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1329","id":119251406,"html_url":"https://github.com/rsim/oracle-enhanced/pull/1329","diff_url":"https://github.com/rsim/oracle-enhanced/pull/1329.diff","patch_url":"https://github.com/rsim/oracle-enhanced/pull/1329.patch","issue_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1329","number":1329,"state":"closed","locked":false,"title":"Drop trigger based primary key support","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars0.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"body":"`:primary_key_trigger` option will not work:\r\n\r\n```ruby\r\ncreate_table :users, :primary_key_trigger => true\r\n...\r\nend\r\n```\r\n\r\nUsers using Oracle enhanced adapter 2.0 or later\r\nwill need to migrate identity type based primary key support.","created_at":"2017-05-05T20:21:41Z","updated_at":"2017-05-05T20:30:18Z","closed_at":"2017-05-05T20:30:18Z","merged_at":"2017-05-05T20:30:18Z","merge_commit_sha":"3a8794c62ff7682c648dc56c64b84cb7192b51b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1329/commits","review_comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1329/comments","review_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1329/comments","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/ef321a156c3ffd5aee5476631f5a929c2ea8f6f8","head":{"label":"yahonda:nextval_drop_trigger_based_primary_key_support","ref":"nextval_drop_trigger_based_primary_key_support","sha":"ef321a156c3ffd5aee5476631f5a929c2ea8f6f8","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars0.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"repo":{"id":1907066,"name":"oracle-enhanced","full_name":"yahonda/oracle-enhanced","owner":{"login":"yahonda","id":73684,"avatar_url":"https://avatars0.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yahonda/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":true,"url":"https://api.github.com/repos/yahonda/oracle-enhanced","forks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/yahonda/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahonda/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahonda/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/yahonda/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahonda/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/yahonda/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/yahonda/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahonda/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/yahonda/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahonda/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/yahonda/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/yahonda/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/yahonda/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahonda/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/yahonda/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/deployments","created_at":"2011-06-16T18:02:51Z","updated_at":"2016-12-11T17:48:08Z","pushed_at":"2017-05-05T20:20:29Z","git_url":"git://github.com/yahonda/oracle-enhanced.git","ssh_url":"git@github.com:yahonda/oracle-enhanced.git","clone_url":"https://github.com/yahonda/oracle-enhanced.git","svn_url":"https://github.com/yahonda/oracle-enhanced","homepage":"","size":5161,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rsim:nextval","ref":"nextval","sha":"09de9c4fc2bd8e18f15848a374398c1d89b90003","user":{"login":"rsim","id":4736,"avatar_url":"https://avatars0.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"repo":{"id":14507,"name":"oracle-enhanced","full_name":"rsim/oracle-enhanced","owner":{"login":"rsim","id":4736,"avatar_url":"https://avatars0.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsim/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":false,"url":"https://api.github.com/repos/rsim/oracle-enhanced","forks_url":"https://api.github.com/repos/rsim/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/rsim/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsim/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsim/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/rsim/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/rsim/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/rsim/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/rsim/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/rsim/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/rsim/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/rsim/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsim/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/rsim/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsim/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/rsim/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsim/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/rsim/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/rsim/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsim/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/rsim/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/rsim/oracle-enhanced/deployments","created_at":"2008-05-04T22:02:14Z","updated_at":"2017-04-24T12:40:21Z","pushed_at":"2017-05-05T20:30:18Z","git_url":"git://github.com/rsim/oracle-enhanced.git","ssh_url":"git@github.com:rsim/oracle-enhanced.git","clone_url":"https://github.com/rsim/oracle-enhanced.git","svn_url":"https://github.com/rsim/oracle-enhanced","homepage":"","size":5153,"stargazers_count":457,"watchers_count":457,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":244,"mirror_url":null,"open_issues_count":38,"forks":244,"open_issues":38,"watchers":457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1329"},"html":{"href":"https://github.com/rsim/oracle-enhanced/pull/1329"},"issue":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1329"},"comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1329/comments"},"review_comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1329/comments"},"review_comment":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1329/commits"},"statuses":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/ef321a156c3ffd5aee5476631f5a929c2ea8f6f8"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"yahonda","id":73684,"avatar_url":"https://avatars0.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":271,"changed_files":6}}
{"actor":{"display_login":"yahonda"}}