{"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/comments/105554755","pull_request_review_id":26442578,"id":105554755,"diff_hunk":"@@ -28,7 +29,6 @@ def init_app(self, app):\n \n     def init_config(self, app):\n         \"\"\"Initialize configuration.\"\"\"\n-        app.config.setdefault(\n-            \"{{ cookiecutter.config_prefix}}_BASE_TEMPLATE\",\n-            app.config.get(\"BASE_TEMPLATE\",","path":"{{ cookiecutter.project_shortname }}/{{ cookiecutter.package_name }}/ext.py","position":14,"original_position":14,"commit_id":"3002f11d846d59a776bcbdd3b64be201bdda0fda","original_commit_id":"3002f11d846d59a776bcbdd3b64be201bdda0fda","user":{"login":"remileduc","id":2204024,"avatar_url":"https://avatars1.githubusercontent.com/u/2204024?v=3","gravatar_id":"","url":"https://api.github.com/users/remileduc","html_url":"https://github.com/remileduc","followers_url":"https://api.github.com/users/remileduc/followers","following_url":"https://api.github.com/users/remileduc/following{/other_user}","gists_url":"https://api.github.com/users/remileduc/gists{/gist_id}","starred_url":"https://api.github.com/users/remileduc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remileduc/subscriptions","organizations_url":"https://api.github.com/users/remileduc/orgs","repos_url":"https://api.github.com/users/remileduc/repos","events_url":"https://api.github.com/users/remileduc/events{/privacy}","received_events_url":"https://api.github.com/users/remileduc/received_events","type":"User","site_admin":false},"body":"good point!","created_at":"2017-03-12T11:15:30Z","updated_at":"2017-03-12T11:15:30Z","html_url":"https://github.com/inveniosoftware/cookiecutter-invenio-module/pull/99#discussion_r105554755","pull_request_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/comments/105554755"},"html":{"href":"https://github.com/inveniosoftware/cookiecutter-invenio-module/pull/99#discussion_r105554755"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99","id":110142209,"html_url":"https://github.com/inveniosoftware/cookiecutter-invenio-module/pull/99","diff_url":"https://github.com/inveniosoftware/cookiecutter-invenio-module/pull/99.diff","patch_url":"https://github.com/inveniosoftware/cookiecutter-invenio-module/pull/99.patch","issue_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/issues/99","number":99,"state":"open","locked":false,"title":"config: use of variables from config.py in ext.py","user":{"login":"remileduc","id":2204024,"avatar_url":"https://avatars1.githubusercontent.com/u/2204024?v=3","gravatar_id":"","url":"https://api.github.com/users/remileduc","html_url":"https://github.com/remileduc","followers_url":"https://api.github.com/users/remileduc/followers","following_url":"https://api.github.com/users/remileduc/following{/other_user}","gists_url":"https://api.github.com/users/remileduc/gists{/gist_id}","starred_url":"https://api.github.com/users/remileduc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remileduc/subscriptions","organizations_url":"https://api.github.com/users/remileduc/orgs","repos_url":"https://api.github.com/users/remileduc/repos","events_url":"https://api.github.com/users/remileduc/events{/privacy}","received_events_url":"https://api.github.com/users/remileduc/received_events","type":"User","site_admin":false},"body":"* Updates ext.py so it uses variables from config.py\r\n\r\nSigned-off-by: Rémi Ducceschi <remi.ducceschi@gmail.com>\r\n\r\nThis represents the new way of using config variables in modules. You can see examples here:\r\n- https://github.com/inveniosoftware/invenio-access/blob/master/invenio_access/ext.py#L149\r\n- https://github.com/inveniosoftware/invenio-accounts/blob/master/invenio_accounts/ext.py#L190\r\n\r\nIf you're OK with it, it may be useful that this PR gets merged before the IUGW2017.","created_at":"2017-03-10T14:49:26Z","updated_at":"2017-03-12T11:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42573030766fd48cb222c0163b3393cb37e350f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/issues/99/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/statuses/3002f11d846d59a776bcbdd3b64be201bdda0fda","head":{"label":"remileduc:config_variables","ref":"config_variables","sha":"3002f11d846d59a776bcbdd3b64be201bdda0fda","user":{"login":"remileduc","id":2204024,"avatar_url":"https://avatars1.githubusercontent.com/u/2204024?v=3","gravatar_id":"","url":"https://api.github.com/users/remileduc","html_url":"https://github.com/remileduc","followers_url":"https://api.github.com/users/remileduc/followers","following_url":"https://api.github.com/users/remileduc/following{/other_user}","gists_url":"https://api.github.com/users/remileduc/gists{/gist_id}","starred_url":"https://api.github.com/users/remileduc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remileduc/subscriptions","organizations_url":"https://api.github.com/users/remileduc/orgs","repos_url":"https://api.github.com/users/remileduc/repos","events_url":"https://api.github.com/users/remileduc/events{/privacy}","received_events_url":"https://api.github.com/users/remileduc/received_events","type":"User","site_admin":false},"repo":{"id":80408729,"name":"cookiecutter-invenio-module","full_name":"remileduc/cookiecutter-invenio-module","owner":{"login":"remileduc","id":2204024,"avatar_url":"https://avatars1.githubusercontent.com/u/2204024?v=3","gravatar_id":"","url":"https://api.github.com/users/remileduc","html_url":"https://github.com/remileduc","followers_url":"https://api.github.com/users/remileduc/followers","following_url":"https://api.github.com/users/remileduc/following{/other_user}","gists_url":"https://api.github.com/users/remileduc/gists{/gist_id}","starred_url":"https://api.github.com/users/remileduc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remileduc/subscriptions","organizations_url":"https://api.github.com/users/remileduc/orgs","repos_url":"https://api.github.com/users/remileduc/repos","events_url":"https://api.github.com/users/remileduc/events{/privacy}","received_events_url":"https://api.github.com/users/remileduc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remileduc/cookiecutter-invenio-module","description":"Cookiecutter - Invenio Module Template","fork":true,"url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module","forks_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/forks","keys_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/teams","hooks_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/hooks","issue_events_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/issues/events{/number}","events_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/events","assignees_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/assignees{/user}","branches_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/branches{/branch}","tags_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/tags","blobs_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/statuses/{sha}","languages_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/languages","stargazers_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/stargazers","contributors_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/contributors","subscribers_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/subscribers","subscription_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/subscription","commits_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/contents/{+path}","compare_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/merges","archive_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/downloads","issues_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/issues{/number}","pulls_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/pulls{/number}","milestones_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/milestones{/number}","notifications_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/labels{/name}","releases_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/releases{/id}","deployments_url":"https://api.github.com/repos/remileduc/cookiecutter-invenio-module/deployments","created_at":"2017-01-30T09:40:17Z","updated_at":"2017-01-30T09:40:18Z","pushed_at":"2017-03-10T14:47:25Z","git_url":"git://github.com/remileduc/cookiecutter-invenio-module.git","ssh_url":"git@github.com:remileduc/cookiecutter-invenio-module.git","clone_url":"https://github.com/remileduc/cookiecutter-invenio-module.git","svn_url":"https://github.com/remileduc/cookiecutter-invenio-module","homepage":"https://cookiecutter-invenio-module.readthedocs.io/","size":148,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inveniosoftware:master","ref":"master","sha":"85fed058e1ba5c57139b5ed7998bd8866c0e9106","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars2.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":35095498,"name":"cookiecutter-invenio-module","full_name":"inveniosoftware/cookiecutter-invenio-module","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars2.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/cookiecutter-invenio-module","description":"Cookiecutter - Invenio Module Template","fork":false,"url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module","forks_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/forks","keys_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/events","assignees_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/merges","archive_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/releases{/id}","deployments_url":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/deployments","created_at":"2015-05-05T11:34:12Z","updated_at":"2017-01-30T12:25:04Z","pushed_at":"2017-03-10T14:49:27Z","git_url":"git://github.com/inveniosoftware/cookiecutter-invenio-module.git","ssh_url":"git@github.com:inveniosoftware/cookiecutter-invenio-module.git","clone_url":"https://github.com/inveniosoftware/cookiecutter-invenio-module.git","svn_url":"https://github.com/inveniosoftware/cookiecutter-invenio-module","homepage":"https://cookiecutter-invenio-module.readthedocs.io/","size":144,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":10,"forks":18,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99"},"html":{"href":"https://github.com/inveniosoftware/cookiecutter-invenio-module/pull/99"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/issues/99"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/cookiecutter-invenio-module/statuses/3002f11d846d59a776bcbdd3b64be201bdda0fda"}}}}
{"actor":{"display_login":"remileduc"}}