{"action":"created","comment":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/comments/140590721","pull_request_review_id":64692160,"id":140590721,"diff_hunk":"@@ -114,6 +115,18 @@ def invalid_auth_token\n     redirect_to root_url\n   end\n \n+  def invalid_phone_number(exception)\n+    flash[:error] = case exception.code.to_s\n+                    when  Figaro.env.twilio_sms_error","path":"app/controllers/application_controller.rb","position":14,"original_position":14,"commit_id":"fae8f4021be6659d93ae4e88141944f785a2feaf","original_commit_id":"fae8f4021be6659d93ae4e88141944f785a2feaf","user":{"login":"zachmargolis","id":458784,"avatar_url":"https://avatars0.githubusercontent.com/u/458784?v=4","gravatar_id":"","url":"https://api.github.com/users/zachmargolis","html_url":"https://github.com/zachmargolis","followers_url":"https://api.github.com/users/zachmargolis/followers","following_url":"https://api.github.com/users/zachmargolis/following{/other_user}","gists_url":"https://api.github.com/users/zachmargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmargolis/subscriptions","organizations_url":"https://api.github.com/users/zachmargolis/orgs","repos_url":"https://api.github.com/users/zachmargolis/repos","events_url":"https://api.github.com/users/zachmargolis/events{/privacy}","received_events_url":"https://api.github.com/users/zachmargolis/received_events","type":"User","site_admin":false},"body":"let's pull these into constants on `TwilioService` and not make them envs --- they're not going to change per-environment or anything","created_at":"2017-09-22T20:34:02Z","updated_at":"2017-09-22T20:37:42Z","html_url":"https://github.com/18F/identity-idp/pull/1681#discussion_r140590721","pull_request_url":"https://api.github.com/repos/18F/identity-idp/pulls/1681","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments/140590721"},"html":{"href":"https://github.com/18F/identity-idp/pull/1681#discussion_r140590721"},"pull_request":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1681"}}},"pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/1681","id":141961052,"html_url":"https://github.com/18F/identity-idp/pull/1681","diff_url":"https://github.com/18F/identity-idp/pull/1681.diff","patch_url":"https://github.com/18F/identity-idp/pull/1681.patch","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/1681","number":1681,"state":"open","locked":false,"title":"Verify phone number with twilio before saving to user[wip]","user":{"login":"nickbristow","id":5296248,"avatar_url":"https://avatars2.githubusercontent.com/u/5296248?v=4","gravatar_id":"","url":"https://api.github.com/users/nickbristow","html_url":"https://github.com/nickbristow","followers_url":"https://api.github.com/users/nickbristow/followers","following_url":"https://api.github.com/users/nickbristow/following{/other_user}","gists_url":"https://api.github.com/users/nickbristow/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbristow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbristow/subscriptions","organizations_url":"https://api.github.com/users/nickbristow/orgs","repos_url":"https://api.github.com/users/nickbristow/repos","events_url":"https://api.github.com/users/nickbristow/events{/privacy}","received_events_url":"https://api.github.com/users/nickbristow/received_events","type":"User","site_admin":false},"body":"**Why**:\r\nUsers received no indication if a number was invalid\r\nwhen setting up OTP.","created_at":"2017-09-19T21:26:46Z","updated_at":"2017-09-22T20:37:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9c9c9a7ac53f00d5b56f5ce41ffddcd26906c14","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/identity-idp/pulls/1681/commits","review_comments_url":"https://api.github.com/repos/18F/identity-idp/pulls/1681/comments","review_comment_url":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/1681/comments","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/fae8f4021be6659d93ae4e88141944f785a2feaf","head":{"label":"18F:verify_numbers_on_setup","ref":"verify_numbers_on_setup","sha":"fae8f4021be6659d93ae4e88141944f785a2feaf","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2017-09-20T20:08:30Z","pushed_at":"2017-09-22T20:35:55Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://secure.login.gov/","size":10821,"stargazers_count":124,"watchers_count":124,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":11,"forks":24,"open_issues":11,"watchers":124,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"9081acf90cc7cac71d8016352747e6243f50f42a","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2017-09-20T20:08:30Z","pushed_at":"2017-09-22T20:35:55Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"git@github.com:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://secure.login.gov/","size":10821,"stargazers_count":124,"watchers_count":124,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":11,"forks":24,"open_issues":11,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1681"},"html":{"href":"https://github.com/18F/identity-idp/pull/1681"},"issue":{"href":"https://api.github.com/repos/18F/identity-idp/issues/1681"},"comments":{"href":"https://api.github.com/repos/18F/identity-idp/issues/1681/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1681/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1681/commits"},"statuses":{"href":"https://api.github.com/repos/18F/identity-idp/statuses/fae8f4021be6659d93ae4e88141944f785a2feaf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zachmargolis"}}