{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/43667","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/43667/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/43667/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/43667/events","html_url":"https://github.com/saltstack/salt/pull/43667","id":259450205,"number":43667,"title":"Fix #43664 pip module is not working under windows.","user":{"login":"hristozv","id":5427512,"avatar_url":"https://avatars2.githubusercontent.com/u/5427512?v=4","gravatar_id":"","url":"https://api.github.com/users/hristozv","html_url":"https://github.com/hristozv","followers_url":"https://api.github.com/users/hristozv/followers","following_url":"https://api.github.com/users/hristozv/following{/other_user}","gists_url":"https://api.github.com/users/hristozv/gists{/gist_id}","starred_url":"https://api.github.com/users/hristozv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hristozv/subscriptions","organizations_url":"https://api.github.com/users/hristozv/orgs","repos_url":"https://api.github.com/users/hristozv/repos","events_url":"https://api.github.com/users/hristozv/events{/privacy}","received_events_url":"https://api.github.com/users/hristozv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-09-21T10:32:47Z","updated_at":"2017-09-21T13:31:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/43667","html_url":"https://github.com/saltstack/salt/pull/43667","diff_url":"https://github.com/saltstack/salt/pull/43667.diff","patch_url":"https://github.com/saltstack/salt/pull/43667.patch"},"body":"### What does this PR do?\r\nFix a bug in salt-minion installer for windows\r\n### What issues does this PR fix or reference?\r\nFix #43664 issue.\r\n### Previous Behavior\r\nWhen salt minion is trying to execute pip module it fails. So pip.installed module cannot be used under Windows.\r\n\r\n### New Behavior\r\nSalt minion now can execute pip correctly, so new Python modules can be installed/upgraded/removed under Windows\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/331156892","html_url":"https://github.com/saltstack/salt/pull/43667#issuecomment-331156892","issue_url":"https://api.github.com/repos/saltstack/salt/issues/43667","id":331156892,"user":{"login":"hristozv","id":5427512,"avatar_url":"https://avatars2.githubusercontent.com/u/5427512?v=4","gravatar_id":"","url":"https://api.github.com/users/hristozv","html_url":"https://github.com/hristozv","followers_url":"https://api.github.com/users/hristozv/followers","following_url":"https://api.github.com/users/hristozv/following{/other_user}","gists_url":"https://api.github.com/users/hristozv/gists{/gist_id}","starred_url":"https://api.github.com/users/hristozv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hristozv/subscriptions","organizations_url":"https://api.github.com/users/hristozv/orgs","repos_url":"https://api.github.com/users/hristozv/repos","events_url":"https://api.github.com/users/hristozv/events{/privacy}","received_events_url":"https://api.github.com/users/hristozv/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T13:31:08Z","updated_at":"2017-09-21T13:31:08Z","author_association":"NONE","body":"What about if portable.py is used once again during the installation to replace those `..\\` with the correct $INSTDIR and be deleted after that? Does it sounds better?\r\nIf yes, please close this PR, I will open another once with such fix.\r\n"}}
{"actor":{"display_login":"hristozv"}}