{"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/126864788","pull_request_review_id":49389534,"id":126864788,"diff_hunk":"@@ -56,7 +56,7 @@ prefix_install: installables\n \tmkdir -p \"$(PREFIX)/Frameworks\" \"$(PREFIX)/bin\"\n \tcp -Rf \"$(TEMPORARY_FOLDER)$(FRAMEWORKS_FOLDER)/$(OUTPUT_FRAMEWORK)\" \"$(PREFIX)/Frameworks/\"\n \tcp -f \"$(TEMPORARY_FOLDER)$(BINARIES_FOLDER)/carthage\" \"$(PREFIX)/bin/\"\n-\tinstall_name_tool -add_rpath \"@executable_path/../Frameworks/$(OUTPUT_FRAMEWORK)/Versions/Current/Frameworks/\"  \"$(PREFIX)/bin/carthage\"\n+\tinstall_name_tool -rpath \"/Library/Frameworks\" \"@executable_path/../Frameworks/$(OUTPUT_FRAMEWORK)/Versions/Current/Frameworks/\"  \"$(PREFIX)/bin/carthage\"","path":"Makefile","position":5,"original_position":5,"commit_id":"6f6702147a4090e96ee5852b5aade85d474174d2","original_commit_id":"6f6702147a4090e96ee5852b5aade85d474174d2","user":{"login":"ikesyo","id":909674,"avatar_url":"https://avatars3.githubusercontent.com/u/909674?v=3","gravatar_id":"","url":"https://api.github.com/users/ikesyo","html_url":"https://github.com/ikesyo","followers_url":"https://api.github.com/users/ikesyo/followers","following_url":"https://api.github.com/users/ikesyo/following{/other_user}","gists_url":"https://api.github.com/users/ikesyo/gists{/gist_id}","starred_url":"https://api.github.com/users/ikesyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikesyo/subscriptions","organizations_url":"https://api.github.com/users/ikesyo/orgs","repos_url":"https://api.github.com/users/ikesyo/repos","events_url":"https://api.github.com/users/ikesyo/events{/privacy}","received_events_url":"https://api.github.com/users/ikesyo/received_events","type":"User","site_admin":false},"body":"This seems a bit odd to me. We should have `@executable_path/../Frameworks` in rpaths as well, right? So following how SwiftLint handles rpaths will be good: https://github.com/realm/SwiftLint/blob/0.20.1/Makefile#L62-L76.","created_at":"2017-07-12T05:02:34Z","updated_at":"2017-07-12T05:02:38Z","html_url":"https://github.com/Carthage/Carthage/pull/2055#discussion_r126864788","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2055","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/126864788"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2055#discussion_r126864788"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2055"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/2055","id":129545928,"html_url":"https://github.com/Carthage/Carthage/pull/2055","diff_url":"https://github.com/Carthage/Carthage/pull/2055.diff","patch_url":"https://github.com/Carthage/Carthage/pull/2055.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/2055","number":2055,"state":"closed","locked":false,"title":"cli-prog used old dylib from /Library/Frameworks","user":{"login":"waffleboot","id":828018,"avatar_url":"https://avatars3.githubusercontent.com/u/828018?v=3","gravatar_id":"","url":"https://api.github.com/users/waffleboot","html_url":"https://github.com/waffleboot","followers_url":"https://api.github.com/users/waffleboot/followers","following_url":"https://api.github.com/users/waffleboot/following{/other_user}","gists_url":"https://api.github.com/users/waffleboot/gists{/gist_id}","starred_url":"https://api.github.com/users/waffleboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waffleboot/subscriptions","organizations_url":"https://api.github.com/users/waffleboot/orgs","repos_url":"https://api.github.com/users/waffleboot/repos","events_url":"https://api.github.com/users/waffleboot/events{/privacy}","received_events_url":"https://api.github.com/users/waffleboot/received_events","type":"User","site_admin":false},"body":"'add_rpath' doesn't work as it adds new rpath to the end of rpaths list and program will use old dylib from /Library/Frameworks instead of prefix-dir. I have production version of Carthage and developed version in prefix dir.\r\n\r\nIf I made incompatibility changes in my own Carthage version and install it to prefix dir then\r\n\r\n$./carthage build\r\n\r\ndyld: lazy symbol binding failed: Symbol not found: __TIFV11CarthageKit12BuildOptionscFT13configurationSS9platformsGVs3SetO6XCDBLD8Platform_9toolchainGSqSS_15derivedDataPathGSqSS_11cacheBuildsSb6activeSb_S0_A4_\r\n  Referenced from: /Users/yangand/Downloads/MyCarthage/bin/./carthage\r\n  Expected in: /Library/Frameworks/CarthageKit.framework/CarthageKit\r\n\r\ndyld: Symbol not found: __TIFV11CarthageKit12BuildOptionscFT13configurationSS9platformsGVs3SetO6XCDBLD8Platform_9toolchainGSqSS_15derivedDataPathGSqSS_11cacheBuildsSb6activeSb_S0_A4_\r\n  Referenced from: /Users/yangand/Downloads/MyCarthage/bin/./carthage\r\n  Expected in: /Library/Frameworks/CarthageKit.framework/CarthageKit\r\n\r\nAbort trap: 6\r\n\r\nBecause carthage still uses /Library/Frameworks dylib because -add_rpath addes prefix dir to the end of list","created_at":"2017-07-08T23:43:57Z","updated_at":"2017-07-12T05:02:38Z","closed_at":"2017-07-10T11:58:08Z","merged_at":"2017-07-10T11:58:08Z","merge_commit_sha":"e5de4b9f8c7c4d6d3ea9809a99ba9ef08a09c658","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2055/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2055/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/2055/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/6f6702147a4090e96ee5852b5aade85d474174d2","head":{"label":"waffleboot:prefix_install_rpath","ref":"prefix_install_rpath","sha":"6f6702147a4090e96ee5852b5aade85d474174d2","user":{"login":"waffleboot","id":828018,"avatar_url":"https://avatars3.githubusercontent.com/u/828018?v=3","gravatar_id":"","url":"https://api.github.com/users/waffleboot","html_url":"https://github.com/waffleboot","followers_url":"https://api.github.com/users/waffleboot/followers","following_url":"https://api.github.com/users/waffleboot/following{/other_user}","gists_url":"https://api.github.com/users/waffleboot/gists{/gist_id}","starred_url":"https://api.github.com/users/waffleboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waffleboot/subscriptions","organizations_url":"https://api.github.com/users/waffleboot/orgs","repos_url":"https://api.github.com/users/waffleboot/repos","events_url":"https://api.github.com/users/waffleboot/events{/privacy}","received_events_url":"https://api.github.com/users/waffleboot/received_events","type":"User","site_admin":false},"repo":{"id":96649057,"name":"Carthage","full_name":"waffleboot/Carthage","owner":{"login":"waffleboot","id":828018,"avatar_url":"https://avatars3.githubusercontent.com/u/828018?v=3","gravatar_id":"","url":"https://api.github.com/users/waffleboot","html_url":"https://github.com/waffleboot","followers_url":"https://api.github.com/users/waffleboot/followers","following_url":"https://api.github.com/users/waffleboot/following{/other_user}","gists_url":"https://api.github.com/users/waffleboot/gists{/gist_id}","starred_url":"https://api.github.com/users/waffleboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waffleboot/subscriptions","organizations_url":"https://api.github.com/users/waffleboot/orgs","repos_url":"https://api.github.com/users/waffleboot/repos","events_url":"https://api.github.com/users/waffleboot/events{/privacy}","received_events_url":"https://api.github.com/users/waffleboot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waffleboot/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/waffleboot/Carthage","forks_url":"https://api.github.com/repos/waffleboot/Carthage/forks","keys_url":"https://api.github.com/repos/waffleboot/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waffleboot/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waffleboot/Carthage/teams","hooks_url":"https://api.github.com/repos/waffleboot/Carthage/hooks","issue_events_url":"https://api.github.com/repos/waffleboot/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/waffleboot/Carthage/events","assignees_url":"https://api.github.com/repos/waffleboot/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/waffleboot/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/waffleboot/Carthage/tags","blobs_url":"https://api.github.com/repos/waffleboot/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waffleboot/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waffleboot/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/waffleboot/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waffleboot/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/waffleboot/Carthage/languages","stargazers_url":"https://api.github.com/repos/waffleboot/Carthage/stargazers","contributors_url":"https://api.github.com/repos/waffleboot/Carthage/contributors","subscribers_url":"https://api.github.com/repos/waffleboot/Carthage/subscribers","subscription_url":"https://api.github.com/repos/waffleboot/Carthage/subscription","commits_url":"https://api.github.com/repos/waffleboot/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/waffleboot/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/waffleboot/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/waffleboot/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/waffleboot/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/waffleboot/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waffleboot/Carthage/merges","archive_url":"https://api.github.com/repos/waffleboot/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waffleboot/Carthage/downloads","issues_url":"https://api.github.com/repos/waffleboot/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/waffleboot/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/waffleboot/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/waffleboot/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waffleboot/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/waffleboot/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/waffleboot/Carthage/deployments","created_at":"2017-07-08T23:12:59Z","updated_at":"2017-07-08T23:13:01Z","pushed_at":"2017-07-11T20:41:54Z","git_url":"git://github.com/waffleboot/Carthage.git","ssh_url":"git@github.com:waffleboot/Carthage.git","clone_url":"https://github.com/waffleboot/Carthage.git","svn_url":"https://github.com/waffleboot/Carthage","homepage":"","size":13531,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"d74abca7c18f92c8df94d6ec6709ac45e1a2f193","user":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars2.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"name":"Carthage","full_name":"Carthage/Carthage","owner":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars2.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/Carthage/Carthage/deployments","created_at":"2014-10-10T19:54:55Z","updated_at":"2017-07-12T02:17:20Z","pushed_at":"2017-07-11T12:56:28Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"git@github.com:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":13546,"stargazers_count":9746,"watchers_count":9746,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":872,"mirror_url":null,"open_issues_count":145,"forks":872,"open_issues":145,"watchers":9746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2055"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2055"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2055"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2055/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2055/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2055/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/6f6702147a4090e96ee5852b5aade85d474174d2"}}}}
{"actor":{"display_login":"ikesyo"}}