{"action":"created","comment":{"url":"https://api.github.com/repos/intermezzOS/kernel/pulls/comments/94288399","pull_request_review_id":14817118,"id":94288399,"diff_hunk":"@@ -93,17 +108,19 @@ impl IdtRef {\n \n         // This block is safe because by referencing IDT above, we know that we've constructed an\n         // IDT.\n-        unsafe {\n-            dtables::lidt(&r.ptr)\n-        };\n+        unsafe { dtables::lidt(&r.ptr) };\n \n         r\n     }\n \n+    /// Sets an IdtEntry as a handler for interrupt specified by `index`\n+    ///\n     pub fn set_handler(&self, index: usize, entry: IdtEntry) {\n         self.idt.lock()[index] = entry;\n     }\n \n+    /// Enables interrupts","path":"interrupts/src/lib.rs","position":60,"original_position":60,"commit_id":"6881f51fe3551692f72d55219cebf6413fa1b77a","original_commit_id":"6881f51fe3551692f72d55219cebf6413fa1b77a","user":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"body":"need a period at the end of this sentence","created_at":"2017-01-01T20:15:35Z","updated_at":"2017-01-01T20:16:04Z","html_url":"https://github.com/intermezzOS/kernel/pull/97#discussion_r94288399","pull_request_url":"https://api.github.com/repos/intermezzOS/kernel/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/comments/94288399"},"html":{"href":"https://github.com/intermezzOS/kernel/pull/97#discussion_r94288399"},"pull_request":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/intermezzOS/kernel/pulls/97","id":89521724,"html_url":"https://github.com/intermezzOS/kernel/pull/97","diff_url":"https://github.com/intermezzOS/kernel/pull/97.diff","patch_url":"https://github.com/intermezzOS/kernel/pull/97.patch","issue_url":"https://api.github.com/repos/intermezzOS/kernel/issues/97","number":97,"state":"open","locked":false,"title":"Added docs to the interrupts crate","user":{"login":"nabeelomer","id":11234616,"avatar_url":"https://avatars.githubusercontent.com/u/11234616?v=3","gravatar_id":"","url":"https://api.github.com/users/nabeelomer","html_url":"https://github.com/nabeelomer","followers_url":"https://api.github.com/users/nabeelomer/followers","following_url":"https://api.github.com/users/nabeelomer/following{/other_user}","gists_url":"https://api.github.com/users/nabeelomer/gists{/gist_id}","starred_url":"https://api.github.com/users/nabeelomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabeelomer/subscriptions","organizations_url":"https://api.github.com/users/nabeelomer/orgs","repos_url":"https://api.github.com/users/nabeelomer/repos","events_url":"https://api.github.com/users/nabeelomer/events{/privacy}","received_events_url":"https://api.github.com/users/nabeelomer/received_events","type":"User","site_admin":false},"body":"This should fix https://github.com/intermezzOS/kernel/issues/77.\r\nThis is my first time writing docs from scratch, please let me know what you think.\r\n","created_at":"2016-10-16T10:11:23Z","updated_at":"2017-01-01T20:16:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff986500523488c9f7e05327223820a07885b660","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intermezzOS/kernel/pulls/97/commits","review_comments_url":"https://api.github.com/repos/intermezzOS/kernel/pulls/97/comments","review_comment_url":"https://api.github.com/repos/intermezzOS/kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intermezzOS/kernel/issues/97/comments","statuses_url":"https://api.github.com/repos/intermezzOS/kernel/statuses/6881f51fe3551692f72d55219cebf6413fa1b77a","head":{"label":"nabeelomer:master","ref":"master","sha":"6881f51fe3551692f72d55219cebf6413fa1b77a","user":{"login":"nabeelomer","id":11234616,"avatar_url":"https://avatars.githubusercontent.com/u/11234616?v=3","gravatar_id":"","url":"https://api.github.com/users/nabeelomer","html_url":"https://github.com/nabeelomer","followers_url":"https://api.github.com/users/nabeelomer/followers","following_url":"https://api.github.com/users/nabeelomer/following{/other_user}","gists_url":"https://api.github.com/users/nabeelomer/gists{/gist_id}","starred_url":"https://api.github.com/users/nabeelomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabeelomer/subscriptions","organizations_url":"https://api.github.com/users/nabeelomer/orgs","repos_url":"https://api.github.com/users/nabeelomer/repos","events_url":"https://api.github.com/users/nabeelomer/events{/privacy}","received_events_url":"https://api.github.com/users/nabeelomer/received_events","type":"User","site_admin":false},"repo":{"id":71042477,"name":"kernel","full_name":"nabeelomer/kernel","owner":{"login":"nabeelomer","id":11234616,"avatar_url":"https://avatars.githubusercontent.com/u/11234616?v=3","gravatar_id":"","url":"https://api.github.com/users/nabeelomer","html_url":"https://github.com/nabeelomer","followers_url":"https://api.github.com/users/nabeelomer/followers","following_url":"https://api.github.com/users/nabeelomer/following{/other_user}","gists_url":"https://api.github.com/users/nabeelomer/gists{/gist_id}","starred_url":"https://api.github.com/users/nabeelomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabeelomer/subscriptions","organizations_url":"https://api.github.com/users/nabeelomer/orgs","repos_url":"https://api.github.com/users/nabeelomer/repos","events_url":"https://api.github.com/users/nabeelomer/events{/privacy}","received_events_url":"https://api.github.com/users/nabeelomer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nabeelomer/kernel","description":"A hobby operating system, in Rust","fork":true,"url":"https://api.github.com/repos/nabeelomer/kernel","forks_url":"https://api.github.com/repos/nabeelomer/kernel/forks","keys_url":"https://api.github.com/repos/nabeelomer/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nabeelomer/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nabeelomer/kernel/teams","hooks_url":"https://api.github.com/repos/nabeelomer/kernel/hooks","issue_events_url":"https://api.github.com/repos/nabeelomer/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/nabeelomer/kernel/events","assignees_url":"https://api.github.com/repos/nabeelomer/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/nabeelomer/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/nabeelomer/kernel/tags","blobs_url":"https://api.github.com/repos/nabeelomer/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nabeelomer/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nabeelomer/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/nabeelomer/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nabeelomer/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/nabeelomer/kernel/languages","stargazers_url":"https://api.github.com/repos/nabeelomer/kernel/stargazers","contributors_url":"https://api.github.com/repos/nabeelomer/kernel/contributors","subscribers_url":"https://api.github.com/repos/nabeelomer/kernel/subscribers","subscription_url":"https://api.github.com/repos/nabeelomer/kernel/subscription","commits_url":"https://api.github.com/repos/nabeelomer/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/nabeelomer/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/nabeelomer/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/nabeelomer/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/nabeelomer/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/nabeelomer/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nabeelomer/kernel/merges","archive_url":"https://api.github.com/repos/nabeelomer/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nabeelomer/kernel/downloads","issues_url":"https://api.github.com/repos/nabeelomer/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/nabeelomer/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/nabeelomer/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/nabeelomer/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nabeelomer/kernel/labels{/name}","releases_url":"https://api.github.com/repos/nabeelomer/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/nabeelomer/kernel/deployments","created_at":"2016-10-16T10:06:03Z","updated_at":"2016-10-16T10:06:04Z","pushed_at":"2016-10-19T04:22:37Z","git_url":"git://github.com/nabeelomer/kernel.git","ssh_url":"git@github.com:nabeelomer/kernel.git","clone_url":"https://github.com/nabeelomer/kernel.git","svn_url":"https://github.com/nabeelomer/kernel","homepage":"http://intermezzos.github.io/","size":235,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intermezzOS:master","ref":"master","sha":"b5bbb3f23f4b65b01a6d8f2734ea6c447c9906e1","user":{"login":"intermezzOS","id":16422108,"avatar_url":"https://avatars.githubusercontent.com/u/16422108?v=3","gravatar_id":"","url":"https://api.github.com/users/intermezzOS","html_url":"https://github.com/intermezzOS","followers_url":"https://api.github.com/users/intermezzOS/followers","following_url":"https://api.github.com/users/intermezzOS/following{/other_user}","gists_url":"https://api.github.com/users/intermezzOS/gists{/gist_id}","starred_url":"https://api.github.com/users/intermezzOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intermezzOS/subscriptions","organizations_url":"https://api.github.com/users/intermezzOS/orgs","repos_url":"https://api.github.com/users/intermezzOS/repos","events_url":"https://api.github.com/users/intermezzOS/events{/privacy}","received_events_url":"https://api.github.com/users/intermezzOS/received_events","type":"Organization","site_admin":false},"repo":{"id":44892115,"name":"kernel","full_name":"intermezzOS/kernel","owner":{"login":"intermezzOS","id":16422108,"avatar_url":"https://avatars.githubusercontent.com/u/16422108?v=3","gravatar_id":"","url":"https://api.github.com/users/intermezzOS","html_url":"https://github.com/intermezzOS","followers_url":"https://api.github.com/users/intermezzOS/followers","following_url":"https://api.github.com/users/intermezzOS/following{/other_user}","gists_url":"https://api.github.com/users/intermezzOS/gists{/gist_id}","starred_url":"https://api.github.com/users/intermezzOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intermezzOS/subscriptions","organizations_url":"https://api.github.com/users/intermezzOS/orgs","repos_url":"https://api.github.com/users/intermezzOS/repos","events_url":"https://api.github.com/users/intermezzOS/events{/privacy}","received_events_url":"https://api.github.com/users/intermezzOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intermezzOS/kernel","description":"A hobby operating system, in Rust","fork":false,"url":"https://api.github.com/repos/intermezzOS/kernel","forks_url":"https://api.github.com/repos/intermezzOS/kernel/forks","keys_url":"https://api.github.com/repos/intermezzOS/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intermezzOS/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intermezzOS/kernel/teams","hooks_url":"https://api.github.com/repos/intermezzOS/kernel/hooks","issue_events_url":"https://api.github.com/repos/intermezzOS/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/intermezzOS/kernel/events","assignees_url":"https://api.github.com/repos/intermezzOS/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/intermezzOS/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/intermezzOS/kernel/tags","blobs_url":"https://api.github.com/repos/intermezzOS/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intermezzOS/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intermezzOS/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/intermezzOS/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intermezzOS/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/intermezzOS/kernel/languages","stargazers_url":"https://api.github.com/repos/intermezzOS/kernel/stargazers","contributors_url":"https://api.github.com/repos/intermezzOS/kernel/contributors","subscribers_url":"https://api.github.com/repos/intermezzOS/kernel/subscribers","subscription_url":"https://api.github.com/repos/intermezzOS/kernel/subscription","commits_url":"https://api.github.com/repos/intermezzOS/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/intermezzOS/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/intermezzOS/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/intermezzOS/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/intermezzOS/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/intermezzOS/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intermezzOS/kernel/merges","archive_url":"https://api.github.com/repos/intermezzOS/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intermezzOS/kernel/downloads","issues_url":"https://api.github.com/repos/intermezzOS/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/intermezzOS/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/intermezzOS/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/intermezzOS/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intermezzOS/kernel/labels{/name}","releases_url":"https://api.github.com/repos/intermezzOS/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/intermezzOS/kernel/deployments","created_at":"2015-10-25T01:36:53Z","updated_at":"2017-01-01T18:52:10Z","pushed_at":"2017-01-01T20:13:48Z","git_url":"git://github.com/intermezzOS/kernel.git","ssh_url":"git@github.com:intermezzOS/kernel.git","clone_url":"https://github.com/intermezzOS/kernel.git","svn_url":"https://github.com/intermezzOS/kernel","homepage":"http://intermezzos.github.io/","size":235,"stargazers_count":605,"watchers_count":605,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":31,"forks":46,"open_issues":31,"watchers":605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/97"},"html":{"href":"https://github.com/intermezzOS/kernel/pull/97"},"issue":{"href":"https://api.github.com/repos/intermezzOS/kernel/issues/97"},"comments":{"href":"https://api.github.com/repos/intermezzOS/kernel/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/intermezzOS/kernel/statuses/6881f51fe3551692f72d55219cebf6413fa1b77a"}}}}
{"actor":{"display_login":"steveklabnik"}}