{"action":"created","issue":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9407","repository_url":"https://api.github.com/repos/qooxdoo/qooxdoo","labels_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9407/labels{/name}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9407/comments","events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9407/events","html_url":"https://github.com/qooxdoo/qooxdoo/issues/9407","id":266100286,"number":9407,"title":"qx.event.Timer: false as default for \"enabled\" property","user":{"login":"sbhtw","id":16120246,"avatar_url":"https://avatars3.githubusercontent.com/u/16120246?v=4","gravatar_id":"","url":"https://api.github.com/users/sbhtw","html_url":"https://github.com/sbhtw","followers_url":"https://api.github.com/users/sbhtw/followers","following_url":"https://api.github.com/users/sbhtw/following{/other_user}","gists_url":"https://api.github.com/users/sbhtw/gists{/gist_id}","starred_url":"https://api.github.com/users/sbhtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbhtw/subscriptions","organizations_url":"https://api.github.com/users/sbhtw/orgs","repos_url":"https://api.github.com/users/sbhtw/repos","events_url":"https://api.github.com/users/sbhtw/events{/privacy}","received_events_url":"https://api.github.com/users/sbhtw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-10-17T12:10:45Z","updated_at":"2017-10-18T11:25:51Z","closed_at":null,"author_association":"NONE","body":"The `enabled` property of class `qx.event.Timer` is set to `true` in property definition and then set to `false` in constructor\r\n\r\nProperty definition:\r\n\r\n```javascript\r\n    enabled :\r\n    {\r\n      init : true,\r\n      check : \"Boolean\",\r\n      apply : \"_applyEnabled\"\r\n    },\r\n```\r\n\r\nConstructor:\r\n\r\n```javascript\r\n  construct : function(interval)\r\n  {\r\n    this.base(arguments);\r\n\r\n    this.setEnabled(false);\r\n\r\n    // ...\r\n```\r\n\r\nWhy not just remove `setEnabled(false)` from constructor and specify `init: false` in property definition?\r\n\r\nThis would also fix the auto-generated documentation for the `enabled` property, which states `true` as default.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/comments/337560073","html_url":"https://github.com/qooxdoo/qooxdoo/issues/9407#issuecomment-337560073","issue_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9407","id":337560073,"user":{"login":"level420","id":210674,"avatar_url":"https://avatars3.githubusercontent.com/u/210674?v=4","gravatar_id":"","url":"https://api.github.com/users/level420","html_url":"https://github.com/level420","followers_url":"https://api.github.com/users/level420/followers","following_url":"https://api.github.com/users/level420/following{/other_user}","gists_url":"https://api.github.com/users/level420/gists{/gist_id}","starred_url":"https://api.github.com/users/level420/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/level420/subscriptions","organizations_url":"https://api.github.com/users/level420/orgs","repos_url":"https://api.github.com/users/level420/repos","events_url":"https://api.github.com/users/level420/events{/privacy}","received_events_url":"https://api.github.com/users/level420/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T11:25:51Z","updated_at":"2017-10-18T11:25:51Z","author_association":"MEMBER","body":"@sbhtw here is a short description on how you can create a PR as fast and as simple as possible. All in the browser, no installation locally needed. Give it a try:\r\nhttps://github.com/qooxdoo/qooxdoo/issues/9340#issuecomment-308094551"}}
{"actor":{"display_login":"level420"}}