{"action":"created","issue":{"url":"https://api.github.com/repos/dropbox/pyannotate/issues/26","repository_url":"https://api.github.com/repos/dropbox/pyannotate","labels_url":"https://api.github.com/repos/dropbox/pyannotate/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/dropbox/pyannotate/issues/26/comments","events_url":"https://api.github.com/repos/dropbox/pyannotate/issues/26/events","html_url":"https://github.com/dropbox/pyannotate/pull/26","id":275648934,"number":26,"title":"NamedTemporaryFile works different on Windows","user":{"login":"NeonGraal","id":189015,"avatar_url":"https://avatars3.githubusercontent.com/u/189015?v=4","gravatar_id":"","url":"https://api.github.com/users/NeonGraal","html_url":"https://github.com/NeonGraal","followers_url":"https://api.github.com/users/NeonGraal/followers","following_url":"https://api.github.com/users/NeonGraal/following{/other_user}","gists_url":"https://api.github.com/users/NeonGraal/gists{/gist_id}","starred_url":"https://api.github.com/users/NeonGraal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeonGraal/subscriptions","organizations_url":"https://api.github.com/users/NeonGraal/orgs","repos_url":"https://api.github.com/users/NeonGraal/repos","events_url":"https://api.github.com/users/NeonGraal/events{/privacy}","received_events_url":"https://api.github.com/users/NeonGraal/received_events","type":"User","site_admin":false},"labels":[{"id":753713938,"url":"https://api.github.com/repos/dropbox/pyannotate/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-21T09:56:07Z","updated_at":"2017-11-22T21:48:59Z","closed_at":"2017-11-22T17:14:54Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dropbox/pyannotate/pulls/26","html_url":"https://github.com/dropbox/pyannotate/pull/26","diff_url":"https://github.com/dropbox/pyannotate/pull/26.diff","patch_url":"https://github.com/dropbox/pyannotate/pull/26.patch"},"body":"Add optional stream parameters to generate_annotation_json and parse_json.\r\n\r\nHopefully fixes #25 but unable to run all tests due to lib2to3 quirks on Windows and Ubuntu"},"comment":{"url":"https://api.github.com/repos/dropbox/pyannotate/issues/comments/346482263","html_url":"https://github.com/dropbox/pyannotate/pull/26#issuecomment-346482263","issue_url":"https://api.github.com/repos/dropbox/pyannotate/issues/26","id":346482263,"user":{"login":"rowillia","id":808798,"avatar_url":"https://avatars1.githubusercontent.com/u/808798?v=4","gravatar_id":"","url":"https://api.github.com/users/rowillia","html_url":"https://github.com/rowillia","followers_url":"https://api.github.com/users/rowillia/followers","following_url":"https://api.github.com/users/rowillia/following{/other_user}","gists_url":"https://api.github.com/users/rowillia/gists{/gist_id}","starred_url":"https://api.github.com/users/rowillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowillia/subscriptions","organizations_url":"https://api.github.com/users/rowillia/orgs","repos_url":"https://api.github.com/users/rowillia/repos","events_url":"https://api.github.com/users/rowillia/events{/privacy}","received_events_url":"https://api.github.com/users/rowillia/received_events","type":"User","site_admin":false},"created_at":"2017-11-22T21:48:59Z","updated_at":"2017-11-22T21:48:59Z","author_association":"CONTRIBUTOR","body":"This PR appears to have broken Python 3 - \r\n\r\n```bash\r\n$ pyannotate -w --type-info ./annotations.json $file\r\nTraceback (most recent call last):\r\n  File \"/Users/rwilliams/src/oss/pyannotate/venv/bin/pyannotate\", line 11, in <module>\r\n    load_entry_point('pyannotate==1.0.2', 'console_scripts', 'pyannotate')()\r\n  File \"/Users/rwilliams/src/oss/pyannotate/venv/lib/python3.6/site-packages/pyannotate-1.0.2-py3.6.egg/pyannotate_tools/annotations/__main__.py\", line 45, in main\r\n  File \"/Users/rwilliams/src/oss/pyannotate/venv/lib/python3.6/site-packages/pyannotate-1.0.2-py3.6.egg/pyannotate_tools/annotations/main.py\", line 59, in generate_annotations_json\r\n  File \"/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/json/__init__.py\", line 180, in dump\r\n    fp.write(chunk)\r\n  File \"/Users/rwilliams/src/oss/pyannotate/venv/lib/python3.6/tempfile.py\", line 483, in func_wrapper\r\n    return func(*args, **kwargs)\r\nTypeError: a bytes-like object is required, not 'str'\r\n```\r\n\r\nWe should probably write a test that exercises `main`, perhaps just run through the example?"}}
{"actor":{"display_login":"rowillia"}}