{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/liveDVR/pulls/comments/105653552","pull_request_review_id":26542153,"id":105653552,"diff_hunk":"@@ -33,8 +33,14 @@ var qResolved = Q.resolve();\n  interrupt in-progress playback\n  * */\n const hlsWindowProtectionFactor = 3;\n+// nginx vod module limits (hard coded), the size of the play window to 25 hrs.\n+// It was decided to limit the max play window (DVR/VOD) to 24 hrs, living at the least, 1 hour margin.\n+const hlsMaxAllowedWindowSizeMilliseconds = 24 * 60 * 60 * 1000;","path":"lib/playlistGenerator/PlaylistGenerator.js","position":6,"original_position":6,"commit_id":"1f8e759059cac1289e39304aa8b108df2550fcc3","original_commit_id":"1f8e759059cac1289e39304aa8b108df2550fcc3","user":{"login":"kalturaguy","id":7511565,"avatar_url":"https://avatars0.githubusercontent.com/u/7511565?v=3","gravatar_id":"","url":"https://api.github.com/users/kalturaguy","html_url":"https://github.com/kalturaguy","followers_url":"https://api.github.com/users/kalturaguy/followers","following_url":"https://api.github.com/users/kalturaguy/following{/other_user}","gists_url":"https://api.github.com/users/kalturaguy/gists{/gist_id}","starred_url":"https://api.github.com/users/kalturaguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalturaguy/subscriptions","organizations_url":"https://api.github.com/users/kalturaguy/orgs","repos_url":"https://api.github.com/users/kalturaguy/repos","events_url":"https://api.github.com/users/kalturaguy/events{/privacy}","received_events_url":"https://api.github.com/users/kalturaguy/received_events","type":"User","site_admin":false},"body":"should be in config.json (probably there is such value)","created_at":"2017-03-13T13:00:11Z","updated_at":"2017-03-13T13:00:11Z","html_url":"https://github.com/kaltura/liveDVR/pull/430#discussion_r105653552","pull_request_url":"https://api.github.com/repos/kaltura/liveDVR/pulls/430","_links":{"self":{"href":"https://api.github.com/repos/kaltura/liveDVR/pulls/comments/105653552"},"html":{"href":"https://github.com/kaltura/liveDVR/pull/430#discussion_r105653552"},"pull_request":{"href":"https://api.github.com/repos/kaltura/liveDVR/pulls/430"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/liveDVR/pulls/430","id":110398237,"html_url":"https://github.com/kaltura/liveDVR/pull/430","diff_url":"https://github.com/kaltura/liveDVR/pull/430.diff","patch_url":"https://github.com/kaltura/liveDVR/pull/430.patch","issue_url":"https://api.github.com/repos/kaltura/liveDVR/issues/430","number":430,"state":"open","locked":false,"title":"plat-7138_duration_too_large","user":{"login":"lilachmaliniak","id":19250879,"avatar_url":"https://avatars1.githubusercontent.com/u/19250879?v=3","gravatar_id":"","url":"https://api.github.com/users/lilachmaliniak","html_url":"https://github.com/lilachmaliniak","followers_url":"https://api.github.com/users/lilachmaliniak/followers","following_url":"https://api.github.com/users/lilachmaliniak/following{/other_user}","gists_url":"https://api.github.com/users/lilachmaliniak/gists{/gist_id}","starred_url":"https://api.github.com/users/lilachmaliniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilachmaliniak/subscriptions","organizations_url":"https://api.github.com/users/lilachmaliniak/orgs","repos_url":"https://api.github.com/users/lilachmaliniak/repos","events_url":"https://api.github.com/users/lilachmaliniak/events{/privacy}","received_events_url":"https://api.github.com/users/lilachmaliniak/received_events","type":"User","site_admin":false},"body":"limit max play window DVR/VOD to 24 hours.\nrequires nginx-vod-module upgrade to release supporting 25 hours window\nsize.","created_at":"2017-03-13T12:58:12Z","updated_at":"2017-03-13T13:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c2a4a68c7e409636491768fe27f6c4c7904ddc6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/liveDVR/pulls/430/commits","review_comments_url":"https://api.github.com/repos/kaltura/liveDVR/pulls/430/comments","review_comment_url":"https://api.github.com/repos/kaltura/liveDVR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/liveDVR/issues/430/comments","statuses_url":"https://api.github.com/repos/kaltura/liveDVR/statuses/1f8e759059cac1289e39304aa8b108df2550fcc3","head":{"label":"kaltura:1.9-PLAT-7138_duration_too_large","ref":"1.9-PLAT-7138_duration_too_large","sha":"1f8e759059cac1289e39304aa8b108df2550fcc3","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":40581240,"name":"liveDVR","full_name":"kaltura/liveDVR","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/liveDVR","description":"DVR implementation built on top of live streams","fork":false,"url":"https://api.github.com/repos/kaltura/liveDVR","forks_url":"https://api.github.com/repos/kaltura/liveDVR/forks","keys_url":"https://api.github.com/repos/kaltura/liveDVR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/liveDVR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/liveDVR/teams","hooks_url":"https://api.github.com/repos/kaltura/liveDVR/hooks","issue_events_url":"https://api.github.com/repos/kaltura/liveDVR/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/liveDVR/events","assignees_url":"https://api.github.com/repos/kaltura/liveDVR/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/liveDVR/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/liveDVR/tags","blobs_url":"https://api.github.com/repos/kaltura/liveDVR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/liveDVR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/liveDVR/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/liveDVR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/liveDVR/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/liveDVR/languages","stargazers_url":"https://api.github.com/repos/kaltura/liveDVR/stargazers","contributors_url":"https://api.github.com/repos/kaltura/liveDVR/contributors","subscribers_url":"https://api.github.com/repos/kaltura/liveDVR/subscribers","subscription_url":"https://api.github.com/repos/kaltura/liveDVR/subscription","commits_url":"https://api.github.com/repos/kaltura/liveDVR/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/liveDVR/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/liveDVR/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/liveDVR/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/liveDVR/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/liveDVR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/liveDVR/merges","archive_url":"https://api.github.com/repos/kaltura/liveDVR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/liveDVR/downloads","issues_url":"https://api.github.com/repos/kaltura/liveDVR/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/liveDVR/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/liveDVR/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/liveDVR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/liveDVR/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/liveDVR/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/liveDVR/deployments","created_at":"2015-08-12T05:08:28Z","updated_at":"2017-02-07T09:00:13Z","pushed_at":"2017-03-13T12:58:12Z","git_url":"git://github.com/kaltura/liveDVR.git","ssh_url":"git@github.com:kaltura/liveDVR.git","clone_url":"https://github.com/kaltura/liveDVR.git","svn_url":"https://github.com/kaltura/liveDVR","homepage":null,"size":208599,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":5,"default_branch":"1.9"}},"base":{"label":"kaltura:1.9","ref":"1.9","sha":"7e1ffbe779d607118ae4ecb0da750afd628b0ff6","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":40581240,"name":"liveDVR","full_name":"kaltura/liveDVR","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars3.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/liveDVR","description":"DVR implementation built on top of live streams","fork":false,"url":"https://api.github.com/repos/kaltura/liveDVR","forks_url":"https://api.github.com/repos/kaltura/liveDVR/forks","keys_url":"https://api.github.com/repos/kaltura/liveDVR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/liveDVR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/liveDVR/teams","hooks_url":"https://api.github.com/repos/kaltura/liveDVR/hooks","issue_events_url":"https://api.github.com/repos/kaltura/liveDVR/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/liveDVR/events","assignees_url":"https://api.github.com/repos/kaltura/liveDVR/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/liveDVR/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/liveDVR/tags","blobs_url":"https://api.github.com/repos/kaltura/liveDVR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/liveDVR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/liveDVR/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/liveDVR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/liveDVR/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/liveDVR/languages","stargazers_url":"https://api.github.com/repos/kaltura/liveDVR/stargazers","contributors_url":"https://api.github.com/repos/kaltura/liveDVR/contributors","subscribers_url":"https://api.github.com/repos/kaltura/liveDVR/subscribers","subscription_url":"https://api.github.com/repos/kaltura/liveDVR/subscription","commits_url":"https://api.github.com/repos/kaltura/liveDVR/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/liveDVR/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/liveDVR/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/liveDVR/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/liveDVR/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/liveDVR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/liveDVR/merges","archive_url":"https://api.github.com/repos/kaltura/liveDVR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/liveDVR/downloads","issues_url":"https://api.github.com/repos/kaltura/liveDVR/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/liveDVR/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/liveDVR/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/liveDVR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/liveDVR/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/liveDVR/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/liveDVR/deployments","created_at":"2015-08-12T05:08:28Z","updated_at":"2017-02-07T09:00:13Z","pushed_at":"2017-03-13T12:58:12Z","git_url":"git://github.com/kaltura/liveDVR.git","ssh_url":"git@github.com:kaltura/liveDVR.git","clone_url":"https://github.com/kaltura/liveDVR.git","svn_url":"https://github.com/kaltura/liveDVR","homepage":null,"size":208599,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":5,"default_branch":"1.9"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/liveDVR/pulls/430"},"html":{"href":"https://github.com/kaltura/liveDVR/pull/430"},"issue":{"href":"https://api.github.com/repos/kaltura/liveDVR/issues/430"},"comments":{"href":"https://api.github.com/repos/kaltura/liveDVR/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/liveDVR/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/liveDVR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/liveDVR/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/liveDVR/statuses/1f8e759059cac1289e39304aa8b108df2550fcc3"}}}}
{"actor":{"display_login":"kalturaguy"}}