{"action":"created","issue":{"url":"https://api.github.com/repos/Mirantis/virtlet/issues/532","repository_url":"https://api.github.com/repos/Mirantis/virtlet","labels_url":"https://api.github.com/repos/Mirantis/virtlet/issues/532/labels{/name}","comments_url":"https://api.github.com/repos/Mirantis/virtlet/issues/532/comments","events_url":"https://api.github.com/repos/Mirantis/virtlet/issues/532/events","html_url":"https://github.com/Mirantis/virtlet/pull/532","id":282819794,"number":532,"title":"Add minikube installation documentation","user":{"login":"jorgesece","id":1101022,"avatar_url":"https://avatars0.githubusercontent.com/u/1101022?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgesece","html_url":"https://github.com/jorgesece","followers_url":"https://api.github.com/users/jorgesece/followers","following_url":"https://api.github.com/users/jorgesece/following{/other_user}","gists_url":"https://api.github.com/users/jorgesece/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgesece/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgesece/subscriptions","organizations_url":"https://api.github.com/users/jorgesece/orgs","repos_url":"https://api.github.com/users/jorgesece/repos","events_url":"https://api.github.com/users/jorgesece/events{/privacy}","received_events_url":"https://api.github.com/users/jorgesece/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-18T09:52:11Z","updated_at":"2017-12-18T11:19:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Mirantis/virtlet/pulls/532","html_url":"https://github.com/Mirantis/virtlet/pull/532","diff_url":"https://github.com/Mirantis/virtlet/pull/532.diff","patch_url":"https://github.com/Mirantis/virtlet/pull/532.patch"},"body":"Documented minikube configuration for virtlet.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mirantis/virtlet/532)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Mirantis/virtlet/issues/comments/352398301","html_url":"https://github.com/Mirantis/virtlet/pull/532#issuecomment-352398301","issue_url":"https://api.github.com/repos/Mirantis/virtlet/issues/532","id":352398301,"user":{"login":"jellonek","id":658436,"avatar_url":"https://avatars3.githubusercontent.com/u/658436?v=4","gravatar_id":"","url":"https://api.github.com/users/jellonek","html_url":"https://github.com/jellonek","followers_url":"https://api.github.com/users/jellonek/followers","following_url":"https://api.github.com/users/jellonek/following{/other_user}","gists_url":"https://api.github.com/users/jellonek/gists{/gist_id}","starred_url":"https://api.github.com/users/jellonek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jellonek/subscriptions","organizations_url":"https://api.github.com/users/jellonek/orgs","repos_url":"https://api.github.com/users/jellonek/repos","events_url":"https://api.github.com/users/jellonek/events{/privacy}","received_events_url":"https://api.github.com/users/jellonek/received_events","type":"User","site_admin":false},"created_at":"2017-12-18T11:19:47Z","updated_at":"2017-12-18T11:19:47Z","author_association":"MEMBER","body":"You should also add an entry in `docs/devel/README.md` for this file.\n\n---\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, 5 unresolved discussions.\n\n---\n\n*[README.md, line 5 at r1](https://reviewable.io:443/reviews/mirantis/virtlet/532#-L0dI_WXmj0uoHjh6FVs:-L0dKQgAAH0AEnRR_AVh:b-mg4m8j) ([raw file](https://github.com/mirantis/virtlet/blob/6e33aca607d98669f663ff25f360fa8ff7172d93/README.md#L5)):*\n<details><summary><i>Previously, pigmej (Jędrzej Nowak) wrote…</i></summary><blockquote>\n\n> [Deploy using minikube]\n\nI think `running on minikube` sounds way better and more correct in this situation.\n</blockquote></details>\n\n+1. \"deploy using minikube\" suggest a normal deployment, while that instruction should not be used for anything more than a dev setup.\n\n---\n\n*[docs/devel/running-minikube.md, line 1 at r1](https://reviewable.io:443/reviews/mirantis/virtlet/532#-L0dINDg85akgewkqc-Q:-L0dINDg85akgewkqc-R:b-zejcnr) ([raw file](https://github.com/mirantis/virtlet/blob/6e33aca607d98669f663ff25f360fa8ff7172d93/docs/devel/running-minikube.md#L1)):*\n> ```Markdown\n> # Running local environment for Virtlet\n> ```\n\ns/local environment for/minikube environment with/\n\n---\n\n*[docs/devel/running-minikube.md, line 11 at r1](https://reviewable.io:443/reviews/mirantis/virtlet/532#-L0dITIO-rR6K9rU9NCn:-L0dITIO-rR6K9rU9NCo:bqkpype) ([raw file](https://github.com/mirantis/virtlet/blob/6e33aca607d98669f663ff25f360fa8ff7172d93/docs/devel/running-minikube.md#L11)):*\n> ```Markdown\n> * [docker](https://www.docker.com) should be installed on host and user account on which Virtlet will be built and run - should be properly configured to use this docker installation (possibly adding user's account into group in which docker deamon is running should be enough, but please follow docker documentation for your host Linux distribution),\n> * [CRI-Proxy](https://github.com/Mirantis/criproxy) needs to be installed in the host.\n> * [minikube](https://github.com/kubernetes/minikube) has to be installed in the host machine.\n> ```\n\nIt's listed as prerequisite, but later there is info how to download it. It's inconsistent.\n\n---\n\n*[docs/devel/running-minikube.md, line 33 at r1](https://reviewable.io:443/reviews/mirantis/virtlet/532#-L0dJ4zwT6i5SbFE-3G6:-L0dJ4zwT6i5SbFE-3G7:b3g9dh0) ([raw file](https://github.com/mirantis/virtlet/blob/6e33aca607d98669f663ff25f360fa8ff7172d93/docs/devel/running-minikube.md#L33)):*\n> ```Markdown\n> kubectl create configmap -n kube-system virtlet-image-translations --from-file images.yaml\n> kubectl apply -f virtlet-ds.yaml\n> kubectl create configmap -n kube-system virtlet-config --from-literal=disable_kvm=y\n> ```\n\nThis line should be executed before applying virtlet-ds, where created by it CM is used.\n\nIMO that also needs explanation why there is degradation of performance because of simplification used in starting of minikube node/image.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/mirantis/virtlet/532#-:-L0dKw9iJ4qmdn4eyoYL:b-3nuitw)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jellonek"}}