{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/129204539","pull_request_review_id":51951624,"id":129204539,"diff_hunk":"@@ -349,7 +351,13 @@ def main():\n             systemorgid=dict(default=None, required=False),\n             enable_eus=dict(default=False, type='bool'),\n             channels=dict(default=[], type='list'),\n-        )\n+        ),\n+        # username/password is required for state=absent, or if channels is not empty","path":"lib/ansible/modules/packaging/os/rhn_register.py","position":17,"original_position":17,"commit_id":"57cf604488ed3051fa111a288f008fe6c3444d06","original_commit_id":"57cf604488ed3051fa111a288f008fe6c3444d06","user":{"login":"pilou-","id":1356830,"avatar_url":"https://avatars1.githubusercontent.com/u/1356830?v=4","gravatar_id":"","url":"https://api.github.com/users/pilou-","html_url":"https://github.com/pilou-","followers_url":"https://api.github.com/users/pilou-/followers","following_url":"https://api.github.com/users/pilou-/following{/other_user}","gists_url":"https://api.github.com/users/pilou-/gists{/gist_id}","starred_url":"https://api.github.com/users/pilou-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilou-/subscriptions","organizations_url":"https://api.github.com/users/pilou-/orgs","repos_url":"https://api.github.com/users/pilou-/repos","events_url":"https://api.github.com/users/pilou-/events{/privacy}","received_events_url":"https://api.github.com/users/pilou-/received_events","type":"User","site_admin":false},"body":"when `state` is `present`: either (`username` and `password`) or `activation_key` are required in [`register`](https://github.com/WhyIsThisOpen/ansible/blob/57cf604488ed3051fa111a288f008fe6c3444d06/lib/ansible/modules/packaging/os/rhn_register.py#L252) method. `register` method is called independently from `channels` value.","created_at":"2017-07-25T03:23:59Z","updated_at":"2017-07-25T03:23:59Z","html_url":"https://github.com/ansible/ansible/pull/25079#discussion_r129204539","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/25079","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/129204539"},"html":{"href":"https://github.com/ansible/ansible/pull/25079#discussion_r129204539"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/25079"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/25079","id":122680334,"html_url":"https://github.com/ansible/ansible/pull/25079","diff_url":"https://github.com/ansible/ansible/pull/25079.diff","patch_url":"https://github.com/ansible/ansible/pull/25079.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/25079","number":25079,"state":"open","locked":false,"title":"rhn_register fixes for #24997 and #22300","user":{"login":"WhyIsThisOpen","id":4153640,"avatar_url":"https://avatars3.githubusercontent.com/u/4153640?v=4","gravatar_id":"","url":"https://api.github.com/users/WhyIsThisOpen","html_url":"https://github.com/WhyIsThisOpen","followers_url":"https://api.github.com/users/WhyIsThisOpen/followers","following_url":"https://api.github.com/users/WhyIsThisOpen/following{/other_user}","gists_url":"https://api.github.com/users/WhyIsThisOpen/gists{/gist_id}","starred_url":"https://api.github.com/users/WhyIsThisOpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhyIsThisOpen/subscriptions","organizations_url":"https://api.github.com/users/WhyIsThisOpen/orgs","repos_url":"https://api.github.com/users/WhyIsThisOpen/repos","events_url":"https://api.github.com/users/WhyIsThisOpen/events{/privacy}","received_events_url":"https://api.github.com/users/WhyIsThisOpen/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n\r\nRequire username and password for unregistering and avoid \"cannot marshal None unless allow_none is enabled\" error when using an activationkey and no channels specified.\r\n\r\nFixes for #24997 and #22300, including the changes from ansible/ansible@4f8dc60 and ansible/ansible@a4b69c1.\r\n\r\n##### ISSUE TYPE\r\n\r\n - Bugfix Pull Request\r\n\r\n\r\n##### COMPONENT NAME\r\n\r\n    rhn_register.py\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\n    ansible 2.3.0.0\r\n      config file = /home/ansible/ansible.cfg\r\n      configured module search path = Default w/o overrides\r\n      python version = 2.7.5 (default, Aug  2 2016, 04:20:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nUndoes ansible/ansible@7faef2c.\r\n","created_at":"2017-05-26T16:46:07Z","updated_at":"2017-07-25T03:23:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15951c28d28f96a7da6ccdccee8ef79af8099354","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samdoran","id":4047861,"avatar_url":"https://avatars2.githubusercontent.com/u/4047861?v=4","gravatar_id":"","url":"https://api.github.com/users/samdoran","html_url":"https://github.com/samdoran","followers_url":"https://api.github.com/users/samdoran/followers","following_url":"https://api.github.com/users/samdoran/following{/other_user}","gists_url":"https://api.github.com/users/samdoran/gists{/gist_id}","starred_url":"https://api.github.com/users/samdoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdoran/subscriptions","organizations_url":"https://api.github.com/users/samdoran/orgs","repos_url":"https://api.github.com/users/samdoran/repos","events_url":"https://api.github.com/users/samdoran/events{/privacy}","received_events_url":"https://api.github.com/users/samdoran/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/25079/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/25079/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/25079/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/57cf604488ed3051fa111a288f008fe6c3444d06","head":{"label":"WhyIsThisOpen:rhn_register","ref":"rhn_register","sha":"57cf604488ed3051fa111a288f008fe6c3444d06","user":{"login":"WhyIsThisOpen","id":4153640,"avatar_url":"https://avatars3.githubusercontent.com/u/4153640?v=4","gravatar_id":"","url":"https://api.github.com/users/WhyIsThisOpen","html_url":"https://github.com/WhyIsThisOpen","followers_url":"https://api.github.com/users/WhyIsThisOpen/followers","following_url":"https://api.github.com/users/WhyIsThisOpen/following{/other_user}","gists_url":"https://api.github.com/users/WhyIsThisOpen/gists{/gist_id}","starred_url":"https://api.github.com/users/WhyIsThisOpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhyIsThisOpen/subscriptions","organizations_url":"https://api.github.com/users/WhyIsThisOpen/orgs","repos_url":"https://api.github.com/users/WhyIsThisOpen/repos","events_url":"https://api.github.com/users/WhyIsThisOpen/events{/privacy}","received_events_url":"https://api.github.com/users/WhyIsThisOpen/received_events","type":"User","site_admin":false},"repo":{"id":92526195,"name":"ansible","full_name":"WhyIsThisOpen/ansible","owner":{"login":"WhyIsThisOpen","id":4153640,"avatar_url":"https://avatars3.githubusercontent.com/u/4153640?v=4","gravatar_id":"","url":"https://api.github.com/users/WhyIsThisOpen","html_url":"https://github.com/WhyIsThisOpen","followers_url":"https://api.github.com/users/WhyIsThisOpen/followers","following_url":"https://api.github.com/users/WhyIsThisOpen/following{/other_user}","gists_url":"https://api.github.com/users/WhyIsThisOpen/gists{/gist_id}","starred_url":"https://api.github.com/users/WhyIsThisOpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhyIsThisOpen/subscriptions","organizations_url":"https://api.github.com/users/WhyIsThisOpen/orgs","repos_url":"https://api.github.com/users/WhyIsThisOpen/repos","events_url":"https://api.github.com/users/WhyIsThisOpen/events{/privacy}","received_events_url":"https://api.github.com/users/WhyIsThisOpen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WhyIsThisOpen/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/WhyIsThisOpen/ansible","forks_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/forks","keys_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/teams","hooks_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/hooks","issue_events_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/events","assignees_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/tags","blobs_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/languages","stargazers_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/stargazers","contributors_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/contributors","subscribers_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/subscribers","subscription_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/subscription","commits_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/merges","archive_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/downloads","issues_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/labels{/name}","releases_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/WhyIsThisOpen/ansible/deployments","created_at":"2017-05-26T15:51:29Z","updated_at":"2017-05-26T15:51:51Z","pushed_at":"2017-05-26T16:35:28Z","git_url":"git://github.com/WhyIsThisOpen/ansible.git","ssh_url":"git@github.com:WhyIsThisOpen/ansible.git","clone_url":"https://github.com/WhyIsThisOpen/ansible.git","svn_url":"https://github.com/WhyIsThisOpen/ansible","homepage":"http://ansible.com/","size":77109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"603366863fdc393f48e5b067fa20e51a566b400e","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-07-25T02:57:58Z","pushed_at":"2017-07-25T03:23:40Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":83587,"stargazers_count":24392,"watchers_count":24392,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8396,"mirror_url":null,"open_issues_count":3585,"forks":8396,"open_issues":3585,"watchers":24392,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/25079"},"html":{"href":"https://github.com/ansible/ansible/pull/25079"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/25079"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/25079/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/25079/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/25079/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/57cf604488ed3051fa111a288f008fe6c3444d06"}}}}
{"actor":{"display_login":"pilou-"}}