{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/135450235","pull_request_review_id":58862149,"id":135450235,"diff_hunk":"@@ -54,19 +55,15 @@ default PlanNode resolve(PlanNode node)\n     static Lookup noLookup()\n     {\n         return node -> {\n-            verify(!(node instanceof GroupReference), \"Unexpected GroupReference\");\n-            return ImmutableList.of(node);\n+            throw new UnsupportedOperationException();\n         };\n     }\n \n     static Lookup from(Function<GroupReference, List<PlanNode>> resolver)\n     {\n         return node -> {\n-            if (node instanceof GroupReference) {\n-                return resolver.apply((GroupReference) node);\n-            }\n-\n-            return ImmutableList.of(node);\n+            checkArgument(node instanceof GroupReference, \"Node is not a GroupReference\");","path":"presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/Lookup.java","position":53,"original_position":53,"commit_id":"553d67c3b7cba34a2fbb39e3e2fdcff09ec4160c","original_commit_id":"553d67c3b7cba34a2fbb39e3e2fdcff09ec4160c","user":{"login":"findepi","id":144328,"avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false},"body":"Quote `node` in exc","created_at":"2017-08-28T06:35:11Z","updated_at":"2017-08-28T06:36:58Z","html_url":"https://github.com/prestodb/presto/pull/8850#discussion_r135450235","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/8850","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/135450235"},"html":{"href":"https://github.com/prestodb/presto/pull/8850#discussion_r135450235"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/8850"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/8850","id":137845822,"html_url":"https://github.com/prestodb/presto/pull/8850","diff_url":"https://github.com/prestodb/presto/pull/8850.diff","patch_url":"https://github.com/prestodb/presto/pull/8850.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/8850","number":8850,"state":"open","locked":false,"title":"Make resolveGroup to accept only GroupReference","user":{"login":"kokosing","id":7569403,"avatar_url":"https://avatars2.githubusercontent.com/u/7569403?v=4","gravatar_id":"","url":"https://api.github.com/users/kokosing","html_url":"https://github.com/kokosing","followers_url":"https://api.github.com/users/kokosing/followers","following_url":"https://api.github.com/users/kokosing/following{/other_user}","gists_url":"https://api.github.com/users/kokosing/gists{/gist_id}","starred_url":"https://api.github.com/users/kokosing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokosing/subscriptions","organizations_url":"https://api.github.com/users/kokosing/orgs","repos_url":"https://api.github.com/users/kokosing/repos","events_url":"https://api.github.com/users/kokosing/events{/privacy}","received_events_url":"https://api.github.com/users/kokosing/received_events","type":"User","site_admin":false},"body":"Make resolveGroup to accept only GroupReference\n\nresolveGroup suggests that it resolves groups (GroupReference`s).\nAccepting regular plan nodes is error-prone, because:\n - it returns proper node even if the node is not stored within a Memo\n - it is not defensive as it does not matter what caller pass there,\n method is going to work anyway\n - resolving regular plan nodes does not make much sense\n","created_at":"2017-08-27T19:52:21Z","updated_at":"2017-08-28T06:36:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4574e9d6c088469b6344ae8edc856dbef4946b87","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sopel39","id":5989165,"avatar_url":"https://avatars1.githubusercontent.com/u/5989165?v=4","gravatar_id":"","url":"https://api.github.com/users/sopel39","html_url":"https://github.com/sopel39","followers_url":"https://api.github.com/users/sopel39/followers","following_url":"https://api.github.com/users/sopel39/following{/other_user}","gists_url":"https://api.github.com/users/sopel39/gists{/gist_id}","starred_url":"https://api.github.com/users/sopel39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sopel39/subscriptions","organizations_url":"https://api.github.com/users/sopel39/orgs","repos_url":"https://api.github.com/users/sopel39/repos","events_url":"https://api.github.com/users/sopel39/events{/privacy}","received_events_url":"https://api.github.com/users/sopel39/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/8850/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/8850/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/8850/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/553d67c3b7cba34a2fbb39e3e2fdcff09ec4160c","head":{"label":"kokosing:origin/master/resolve_group","ref":"origin/master/resolve_group","sha":"553d67c3b7cba34a2fbb39e3e2fdcff09ec4160c","user":{"login":"kokosing","id":7569403,"avatar_url":"https://avatars2.githubusercontent.com/u/7569403?v=4","gravatar_id":"","url":"https://api.github.com/users/kokosing","html_url":"https://github.com/kokosing","followers_url":"https://api.github.com/users/kokosing/followers","following_url":"https://api.github.com/users/kokosing/following{/other_user}","gists_url":"https://api.github.com/users/kokosing/gists{/gist_id}","starred_url":"https://api.github.com/users/kokosing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokosing/subscriptions","organizations_url":"https://api.github.com/users/kokosing/orgs","repos_url":"https://api.github.com/users/kokosing/repos","events_url":"https://api.github.com/users/kokosing/events{/privacy}","received_events_url":"https://api.github.com/users/kokosing/received_events","type":"User","site_admin":false},"repo":{"id":55942614,"name":"presto","full_name":"kokosing/presto","owner":{"login":"kokosing","id":7569403,"avatar_url":"https://avatars2.githubusercontent.com/u/7569403?v=4","gravatar_id":"","url":"https://api.github.com/users/kokosing","html_url":"https://github.com/kokosing","followers_url":"https://api.github.com/users/kokosing/followers","following_url":"https://api.github.com/users/kokosing/following{/other_user}","gists_url":"https://api.github.com/users/kokosing/gists{/gist_id}","starred_url":"https://api.github.com/users/kokosing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokosing/subscriptions","organizations_url":"https://api.github.com/users/kokosing/orgs","repos_url":"https://api.github.com/users/kokosing/repos","events_url":"https://api.github.com/users/kokosing/events{/privacy}","received_events_url":"https://api.github.com/users/kokosing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kokosing/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/kokosing/presto","forks_url":"https://api.github.com/repos/kokosing/presto/forks","keys_url":"https://api.github.com/repos/kokosing/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokosing/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokosing/presto/teams","hooks_url":"https://api.github.com/repos/kokosing/presto/hooks","issue_events_url":"https://api.github.com/repos/kokosing/presto/issues/events{/number}","events_url":"https://api.github.com/repos/kokosing/presto/events","assignees_url":"https://api.github.com/repos/kokosing/presto/assignees{/user}","branches_url":"https://api.github.com/repos/kokosing/presto/branches{/branch}","tags_url":"https://api.github.com/repos/kokosing/presto/tags","blobs_url":"https://api.github.com/repos/kokosing/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokosing/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokosing/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokosing/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokosing/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/kokosing/presto/languages","stargazers_url":"https://api.github.com/repos/kokosing/presto/stargazers","contributors_url":"https://api.github.com/repos/kokosing/presto/contributors","subscribers_url":"https://api.github.com/repos/kokosing/presto/subscribers","subscription_url":"https://api.github.com/repos/kokosing/presto/subscription","commits_url":"https://api.github.com/repos/kokosing/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokosing/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokosing/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokosing/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokosing/presto/contents/{+path}","compare_url":"https://api.github.com/repos/kokosing/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokosing/presto/merges","archive_url":"https://api.github.com/repos/kokosing/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokosing/presto/downloads","issues_url":"https://api.github.com/repos/kokosing/presto/issues{/number}","pulls_url":"https://api.github.com/repos/kokosing/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/kokosing/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/kokosing/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokosing/presto/labels{/name}","releases_url":"https://api.github.com/repos/kokosing/presto/releases{/id}","deployments_url":"https://api.github.com/repos/kokosing/presto/deployments","created_at":"2016-04-11T04:52:12Z","updated_at":"2016-04-11T04:52:24Z","pushed_at":"2017-08-28T05:46:56Z","git_url":"git://github.com/kokosing/presto.git","ssh_url":"git@github.com:kokosing/presto.git","clone_url":"https://github.com/kokosing/presto.git","svn_url":"https://github.com/kokosing/presto","homepage":"https://prestodb.io","size":82862,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"c364cd73454e2f787ce4b02536da309e1a2ccba6","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2017-08-28T02:47:58Z","pushed_at":"2017-08-28T05:48:03Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":79094,"stargazers_count":6397,"watchers_count":6397,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2095,"mirror_url":null,"open_issues_count":1044,"forks":2095,"open_issues":1044,"watchers":6397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/8850"},"html":{"href":"https://github.com/prestodb/presto/pull/8850"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/8850"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/8850/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/8850/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/8850/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/553d67c3b7cba34a2fbb39e3e2fdcff09ec4160c"}}}}
{"actor":{"display_login":"findepi"}}