{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/113642420","pull_request_review_id":35046792,"id":113642420,"diff_hunk":"@@ -0,0 +1,25 @@\n+// Copyright 2016 Twitter. All rights reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//    http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package com.twitter.heron.api.state;\n+\n+import java.io.Serializable;\n+import java.util.HashMap;\n+\n+/**\n+ * A State backed up by HashMap\n+ */\n+public class HashMapState extends HashMap<Serializable, Serializable> implements State {","path":"heron/api/src/java/com/twitter/heron/api/state/HashMapState.java","position":23,"original_position":23,"commit_id":"ed319a29efd039842cecc97a7c026f6003b665ae","original_commit_id":"19066064332faa2d21e027f4cfc75a5db9471957","user":{"login":"huijunwu","id":4208547,"avatar_url":"https://avatars3.githubusercontent.com/u/4208547?v=3","gravatar_id":"","url":"https://api.github.com/users/huijunwu","html_url":"https://github.com/huijunwu","followers_url":"https://api.github.com/users/huijunwu/followers","following_url":"https://api.github.com/users/huijunwu/following{/other_user}","gists_url":"https://api.github.com/users/huijunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huijunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huijunwu/subscriptions","organizations_url":"https://api.github.com/users/huijunwu/orgs","repos_url":"https://api.github.com/users/huijunwu/repos","events_url":"https://api.github.com/users/huijunwu/events{/privacy}","received_events_url":"https://api.github.com/users/huijunwu/received_events","type":"User","site_admin":false},"body":"interface State is already a map. If a hashmap member placed here, it leads to nested map.","created_at":"2017-04-27T08:36:01Z","updated_at":"2017-04-27T08:36:01Z","html_url":"https://github.com/twitter/heron/pull/1820#discussion_r113642420","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/1820","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/113642420"},"html":{"href":"https://github.com/twitter/heron/pull/1820#discussion_r113642420"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/1820"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1820","id":117822099,"html_url":"https://github.com/twitter/heron/pull/1820","diff_url":"https://github.com/twitter/heron/pull/1820.diff","patch_url":"https://github.com/twitter/heron/pull/1820.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/1820","number":1820,"state":"open","locked":false,"title":"Added Stateful spout/bolt interfaces and State interface for exactly once","user":{"login":"srkukarni","id":2530234,"avatar_url":"https://avatars3.githubusercontent.com/u/2530234?v=3","gravatar_id":"","url":"https://api.github.com/users/srkukarni","html_url":"https://github.com/srkukarni","followers_url":"https://api.github.com/users/srkukarni/followers","following_url":"https://api.github.com/users/srkukarni/following{/other_user}","gists_url":"https://api.github.com/users/srkukarni/gists{/gist_id}","starred_url":"https://api.github.com/users/srkukarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srkukarni/subscriptions","organizations_url":"https://api.github.com/users/srkukarni/orgs","repos_url":"https://api.github.com/users/srkukarni/repos","events_url":"https://api.github.com/users/srkukarni/events{/privacy}","received_events_url":"https://api.github.com/users/srkukarni/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-26T22:16:35Z","updated_at":"2017-04-27T08:36:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afe280f702480beee30954fabb9440bec88088c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/1820/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/1820/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1820/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/ed319a29efd039842cecc97a7c026f6003b665ae","head":{"label":"streamlio:sanjeevk/ext1_api","ref":"sanjeevk/ext1_api","sha":"ed319a29efd039842cecc97a7c026f6003b665ae","user":{"login":"streamlio","id":21353322,"avatar_url":"https://avatars1.githubusercontent.com/u/21353322?v=3","gravatar_id":"","url":"https://api.github.com/users/streamlio","html_url":"https://github.com/streamlio","followers_url":"https://api.github.com/users/streamlio/followers","following_url":"https://api.github.com/users/streamlio/following{/other_user}","gists_url":"https://api.github.com/users/streamlio/gists{/gist_id}","starred_url":"https://api.github.com/users/streamlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamlio/subscriptions","organizations_url":"https://api.github.com/users/streamlio/orgs","repos_url":"https://api.github.com/users/streamlio/repos","events_url":"https://api.github.com/users/streamlio/events{/privacy}","received_events_url":"https://api.github.com/users/streamlio/received_events","type":"Organization","site_admin":false},"repo":{"id":67003283,"name":"heron","full_name":"streamlio/heron","owner":{"login":"streamlio","id":21353322,"avatar_url":"https://avatars1.githubusercontent.com/u/21353322?v=3","gravatar_id":"","url":"https://api.github.com/users/streamlio","html_url":"https://github.com/streamlio","followers_url":"https://api.github.com/users/streamlio/followers","following_url":"https://api.github.com/users/streamlio/following{/other_user}","gists_url":"https://api.github.com/users/streamlio/gists{/gist_id}","starred_url":"https://api.github.com/users/streamlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamlio/subscriptions","organizations_url":"https://api.github.com/users/streamlio/orgs","repos_url":"https://api.github.com/users/streamlio/repos","events_url":"https://api.github.com/users/streamlio/events{/privacy}","received_events_url":"https://api.github.com/users/streamlio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamlio/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/streamlio/heron","forks_url":"https://api.github.com/repos/streamlio/heron/forks","keys_url":"https://api.github.com/repos/streamlio/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamlio/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamlio/heron/teams","hooks_url":"https://api.github.com/repos/streamlio/heron/hooks","issue_events_url":"https://api.github.com/repos/streamlio/heron/issues/events{/number}","events_url":"https://api.github.com/repos/streamlio/heron/events","assignees_url":"https://api.github.com/repos/streamlio/heron/assignees{/user}","branches_url":"https://api.github.com/repos/streamlio/heron/branches{/branch}","tags_url":"https://api.github.com/repos/streamlio/heron/tags","blobs_url":"https://api.github.com/repos/streamlio/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamlio/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamlio/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamlio/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamlio/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/streamlio/heron/languages","stargazers_url":"https://api.github.com/repos/streamlio/heron/stargazers","contributors_url":"https://api.github.com/repos/streamlio/heron/contributors","subscribers_url":"https://api.github.com/repos/streamlio/heron/subscribers","subscription_url":"https://api.github.com/repos/streamlio/heron/subscription","commits_url":"https://api.github.com/repos/streamlio/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamlio/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamlio/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamlio/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamlio/heron/contents/{+path}","compare_url":"https://api.github.com/repos/streamlio/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamlio/heron/merges","archive_url":"https://api.github.com/repos/streamlio/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamlio/heron/downloads","issues_url":"https://api.github.com/repos/streamlio/heron/issues{/number}","pulls_url":"https://api.github.com/repos/streamlio/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/streamlio/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/streamlio/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamlio/heron/labels{/name}","releases_url":"https://api.github.com/repos/streamlio/heron/releases{/id}","deployments_url":"https://api.github.com/repos/streamlio/heron/deployments","created_at":"2016-08-31T04:28:57Z","updated_at":"2016-08-31T04:29:01Z","pushed_at":"2017-04-26T23:51:44Z","git_url":"git://github.com/streamlio/heron.git","ssh_url":"git@github.com:streamlio/heron.git","clone_url":"https://github.com/streamlio/heron.git","svn_url":"https://github.com/streamlio/heron","homepage":"http://heronstreaming.io","size":123685,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"3f7933d1c86a3767f088b6dae8bf18b623540849","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2017-04-27T08:29:30Z","pushed_at":"2017-04-27T02:26:51Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":129512,"stargazers_count":2682,"watchers_count":2682,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":470,"mirror_url":null,"open_issues_count":251,"forks":470,"open_issues":251,"watchers":2682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/1820"},"html":{"href":"https://github.com/twitter/heron/pull/1820"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/1820"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/1820/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/1820/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/1820/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/ed319a29efd039842cecc97a7c026f6003b665ae"}}}}
{"actor":{"display_login":"huijunwu"}}