{"action":"created","issue":{"url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/398","repository_url":"https://api.github.com/repos/gjtorikian/html-proofer","labels_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/398/labels{/name}","comments_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/398/comments","events_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/398/events","html_url":"https://github.com/gjtorikian/html-proofer/pull/398","id":212187665,"number":398,"title":"Remove chomp URL from debug output","user":{"login":"mattclegg","id":303487,"avatar_url":"https://avatars1.githubusercontent.com/u/303487?v=4","gravatar_id":"","url":"https://api.github.com/users/mattclegg","html_url":"https://github.com/mattclegg","followers_url":"https://api.github.com/users/mattclegg/followers","following_url":"https://api.github.com/users/mattclegg/following{/other_user}","gists_url":"https://api.github.com/users/mattclegg/gists{/gist_id}","starred_url":"https://api.github.com/users/mattclegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattclegg/subscriptions","organizations_url":"https://api.github.com/users/mattclegg/orgs","repos_url":"https://api.github.com/users/mattclegg/repos","events_url":"https://api.github.com/users/mattclegg/events{/privacy}","received_events_url":"https://api.github.com/users/mattclegg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-03-06T17:08:05Z","updated_at":"2017-07-19T05:47:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/398","html_url":"https://github.com/gjtorikian/html-proofer/pull/398","diff_url":"https://github.com/gjtorikian/html-proofer/pull/398.diff","patch_url":"https://github.com/gjtorikian/html-proofer/pull/398.patch"},"body":"It doesn't seem to make much sense to `chomp` the URL in the debug output.\r\n\r\nIf I'm looking at the debug logs and it's saying that a particular URL has an error. I expect it to tell me the exact string of the URL that has the error -not a string that has been manipulated."},"comment":{"url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/comments/316279392","html_url":"https://github.com/gjtorikian/html-proofer/pull/398#issuecomment-316279392","issue_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/398","id":316279392,"user":{"login":"stephengroat","id":1159138,"avatar_url":"https://avatars2.githubusercontent.com/u/1159138?v=4","gravatar_id":"","url":"https://api.github.com/users/stephengroat","html_url":"https://github.com/stephengroat","followers_url":"https://api.github.com/users/stephengroat/followers","following_url":"https://api.github.com/users/stephengroat/following{/other_user}","gists_url":"https://api.github.com/users/stephengroat/gists{/gist_id}","starred_url":"https://api.github.com/users/stephengroat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephengroat/subscriptions","organizations_url":"https://api.github.com/users/stephengroat/orgs","repos_url":"https://api.github.com/users/stephengroat/repos","events_url":"https://api.github.com/users/stephengroat/events{/privacy}","received_events_url":"https://api.github.com/users/stephengroat/received_events","type":"User","site_admin":false},"created_at":"2017-07-19T05:47:41Z","updated_at":"2017-07-19T05:47:41Z","body":"@gjtorikian i would love to say that this is something new to this code base, but I'm not sure :-)\r\n\r\nhttps://github.com/gjtorikian/html-proofer/pull/398/files#diff-db64cd8e435373dfc8fe51ef1099183cL126\r\n\r\nif @mattclegg could just return the normalized url all of the time and remove the `if else`, it should work (remove commented lines, other than obvious comment)\r\n\r\n```ruby\r\n     def clean_url(href)\r\n       # catch any obvious issues, like strings in port numbers\r\n       parsed = Addressable::URI.parse(href)\r\n       #if href !~ %r{^([!#$&-;=?-\\[\\]_a-z~]|%[0-9a-fA-F]{2})+$}\r\n         parsed.normalize\r\n       #else\r\n       #  href\r\n       #end\r\n     end\r\n```"}}
{"actor":{"display_login":"stephengroat"}}