{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/107906758","pull_request_review_id":28907856,"id":107906758,"diff_hunk":"@@ -1 +1,9 @@\n nested-class-with-user-defined-constructor-1.chpl:4: error: constructor for class 'inner' requires a generic argument called 'outer'\n+nested-class-with-user-defined-constructor-1.chpl:4: In initializer 'inner':\n+nested-class-with-user-defined-constructor-1.chpl:4: internal error: EXPnnnn chpl Version mmmm\n+\n+Internal errors indicate a bug in the Chapel compiler (\"It's us, not you\"),\n+and we're sorry for the hassle.  We would appreciate your reporting this bug -- \n+please see http://chapel.cray.com/bugs.html for instructions.  In the meantime,\n+the filename + line number above may be useful in working around the issue.","path":"test/classes/vass/nested-class-with-user-defined-constructor-1.bad","position":8,"original_position":8,"commit_id":"3c893cc509de9784b385777d6a051a8133c84b16","original_commit_id":"3c893cc509de9784b385777d6a051a8133c84b16","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars0.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"body":"It is surprising to me that this .bad file changed to an internal error. Could you investigate more and/or explain why this isn't indicative of a greater problem? I.e. are other tests/user codes now going to run into an internal error?","created_at":"2017-03-24T13:54:51Z","updated_at":"2017-03-24T13:54:51Z","html_url":"https://github.com/chapel-lang/chapel/pull/5814#discussion_r107906758","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/107906758"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/5814#discussion_r107906758"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814","id":112384755,"html_url":"https://github.com/chapel-lang/chapel/pull/5814","diff_url":"https://github.com/chapel-lang/chapel/pull/5814.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/5814.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/5814","number":5814,"state":"open","locked":false,"title":"Strengthen \"illegal cast to non-type\" error","user":{"login":"vasslitvinov","id":8039635,"avatar_url":"https://avatars3.githubusercontent.com/u/8039635?v=3","gravatar_id":"","url":"https://api.github.com/users/vasslitvinov","html_url":"https://github.com/vasslitvinov","followers_url":"https://api.github.com/users/vasslitvinov/followers","following_url":"https://api.github.com/users/vasslitvinov/following{/other_user}","gists_url":"https://api.github.com/users/vasslitvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/vasslitvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasslitvinov/subscriptions","organizations_url":"https://api.github.com/users/vasslitvinov/orgs","repos_url":"https://api.github.com/users/vasslitvinov/repos","events_url":"https://api.github.com/users/vasslitvinov/events{/privacy}","received_events_url":"https://api.github.com/users/vasslitvinov/received_events","type":"User","site_admin":false},"body":"Fixes #5691\r\n\r\nI aimed at making the compiler take essentially the same code path\r\nwith my change as it did before. That is, it now creates a symexpr\r\nover a type whereas before it did over a non-type variable, for the\r\ncast-to argument of the cast call. The next time the compiler looks\r\nat the argument, it looks at that symexpr's type. I added an assertion\r\nthat this type is the same before my change and with my change.\r\n\r\nI avoided more extensive changes given proximity to code freeze.\r\nAfter the release branch is cut, we may want to rejigger this code\r\nmore deeply, for example:\r\n\r\n* Rename 'sym' and 'var' to indicate whether they are the \"from\"\r\nor the \"to\".\r\n\r\n* Bail out early if \"to\" is not a SymExpr - because the current code\r\ndoes nothing in such case. Maybe same w.r.t. \"from\".\r\n\r\n* If \"to\" is not a type, replace the whole cast with the \"to\"\r\nexpression. Otherwise the \"illegal cast to non-type\" error currently\r\nmay be reported twice.\r\n\r\n* Ignore the case where \"to\" is a type - instead of branching to the\r\n\"illegal cast to non-type\" error in printResolutionErrorUnresolved() -\r\nbecause such error has already been reported.\r\n\r\n* Instead of the above two bullets - in such case yes, report \"illegal\r\ncast to non-type\" (of course), and in addition report that a cast\r\nto the corresponding *type* would be illegal.\r\n\r\nWhile there, touched up on tests:\r\n\r\n* Clarified types/tuple/marybeth/tuplecast.chpl\r\nfollowing a brief discussion on the internal mailing list.\r\n\r\n* With Brad's approval, fixed smallIntBoolTests/realBool2.chpl\r\n\r\n* Tightened up, using --verify, nested-class-with-user-defined-constructor-1.chpl\r\n\r\nTesting: linux64 --verify\r\n\r\n","created_at":"2017-03-24T04:08:25Z","updated_at":"2017-03-24T13:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"770d709df79bdb15d37189ffb6d617af8f149913","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/5814/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/3c893cc509de9784b385777d6a051a8133c84b16","head":{"label":"vasslitvinov:strengthen-illegal-cast-to-non-type-error","ref":"strengthen-illegal-cast-to-non-type-error","sha":"3c893cc509de9784b385777d6a051a8133c84b16","user":{"login":"vasslitvinov","id":8039635,"avatar_url":"https://avatars3.githubusercontent.com/u/8039635?v=3","gravatar_id":"","url":"https://api.github.com/users/vasslitvinov","html_url":"https://github.com/vasslitvinov","followers_url":"https://api.github.com/users/vasslitvinov/followers","following_url":"https://api.github.com/users/vasslitvinov/following{/other_user}","gists_url":"https://api.github.com/users/vasslitvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/vasslitvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasslitvinov/subscriptions","organizations_url":"https://api.github.com/users/vasslitvinov/orgs","repos_url":"https://api.github.com/users/vasslitvinov/repos","events_url":"https://api.github.com/users/vasslitvinov/events{/privacy}","received_events_url":"https://api.github.com/users/vasslitvinov/received_events","type":"User","site_admin":false},"repo":{"id":21914674,"name":"chapel","full_name":"vasslitvinov/chapel","owner":{"login":"vasslitvinov","id":8039635,"avatar_url":"https://avatars3.githubusercontent.com/u/8039635?v=3","gravatar_id":"","url":"https://api.github.com/users/vasslitvinov","html_url":"https://github.com/vasslitvinov","followers_url":"https://api.github.com/users/vasslitvinov/followers","following_url":"https://api.github.com/users/vasslitvinov/following{/other_user}","gists_url":"https://api.github.com/users/vasslitvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/vasslitvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasslitvinov/subscriptions","organizations_url":"https://api.github.com/users/vasslitvinov/orgs","repos_url":"https://api.github.com/users/vasslitvinov/repos","events_url":"https://api.github.com/users/vasslitvinov/events{/privacy}","received_events_url":"https://api.github.com/users/vasslitvinov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vasslitvinov/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/vasslitvinov/chapel","forks_url":"https://api.github.com/repos/vasslitvinov/chapel/forks","keys_url":"https://api.github.com/repos/vasslitvinov/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vasslitvinov/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vasslitvinov/chapel/teams","hooks_url":"https://api.github.com/repos/vasslitvinov/chapel/hooks","issue_events_url":"https://api.github.com/repos/vasslitvinov/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/vasslitvinov/chapel/events","assignees_url":"https://api.github.com/repos/vasslitvinov/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/vasslitvinov/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/vasslitvinov/chapel/tags","blobs_url":"https://api.github.com/repos/vasslitvinov/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vasslitvinov/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vasslitvinov/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/vasslitvinov/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vasslitvinov/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/vasslitvinov/chapel/languages","stargazers_url":"https://api.github.com/repos/vasslitvinov/chapel/stargazers","contributors_url":"https://api.github.com/repos/vasslitvinov/chapel/contributors","subscribers_url":"https://api.github.com/repos/vasslitvinov/chapel/subscribers","subscription_url":"https://api.github.com/repos/vasslitvinov/chapel/subscription","commits_url":"https://api.github.com/repos/vasslitvinov/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/vasslitvinov/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/vasslitvinov/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/vasslitvinov/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/vasslitvinov/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/vasslitvinov/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vasslitvinov/chapel/merges","archive_url":"https://api.github.com/repos/vasslitvinov/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vasslitvinov/chapel/downloads","issues_url":"https://api.github.com/repos/vasslitvinov/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/vasslitvinov/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/vasslitvinov/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/vasslitvinov/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vasslitvinov/chapel/labels{/name}","releases_url":"https://api.github.com/repos/vasslitvinov/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/vasslitvinov/chapel/deployments","created_at":"2014-07-16T19:46:44Z","updated_at":"2016-03-08T21:35:20Z","pushed_at":"2017-03-24T04:04:48Z","git_url":"git://github.com/vasslitvinov/chapel.git","ssh_url":"git@github.com:vasslitvinov/chapel.git","clone_url":"https://github.com/vasslitvinov/chapel.git","svn_url":"https://github.com/vasslitvinov/chapel","homepage":"http://chapel.cray.com/","size":401426,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"ba7553e43e345b3ea52a238571954a425c8d949d","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars1.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars1.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2017-03-23T17:22:39Z","pushed_at":"2017-03-24T13:20:17Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":408727,"stargazers_count":411,"watchers_count":411,"language":"Chapel","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":202,"forks":135,"open_issues":202,"watchers":411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/5814"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/5814"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/5814/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/5814/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/3c893cc509de9784b385777d6a051a8133c84b16"}}}}
{"actor":{"display_login":"mppf"}}