{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/154154099","pull_request_review_id":80274445,"id":154154099,"diff_hunk":"@@ -148,32 +164,39 @@ private static ValidationTask registerTask(String name, ValidationTask task) {\n     return task;\n   }\n \n-  private static boolean validateRemote(List<String> nodes, String target, String name)\n-      throws InterruptedException {\n+  private static boolean validateRemote(List<String> nodes, String target, String name,\n+      String[] args) throws InterruptedException {\n     if (nodes == null) {\n       return false;\n     }\n \n     boolean success = true;\n     for (String node : nodes) {\n-      success &= validateRemote(node, target, name);\n+      success &= validateRemote(node, target, name, args);\n     }\n \n     return success;\n   }\n \n   // validates environment on remote node\n-  private static boolean validateRemote(String node, String target, String name)\n+  private static boolean validateRemote(String node, String target, String name, String[] args)\n       throws InterruptedException {\n     System.out.format(\"Validating %s environment on %s...%n\", target, node);\n     if (!Utils.isAddressReachable(node, 22)) {\n       System.err.format(\"Unable to reach ssh port 22 on node %s.%n\", node);\n       return false;\n     }\n \n+    String argStr;\n+    if (args != null) {","path":"core/server/common/src/main/java/alluxio/cli/ValidateEnv.java","position":105,"original_position":105,"commit_id":"3872f9da6f360a8ff22326ed54aa66372598fc6c","original_commit_id":"3872f9da6f360a8ff22326ed54aa66372598fc6c","user":{"login":"riversand963","id":20094703,"avatar_url":"https://avatars0.githubusercontent.com/u/20094703?v=4","gravatar_id":"","url":"https://api.github.com/users/riversand963","html_url":"https://github.com/riversand963","followers_url":"https://api.github.com/users/riversand963/followers","following_url":"https://api.github.com/users/riversand963/following{/other_user}","gists_url":"https://api.github.com/users/riversand963/gists{/gist_id}","starred_url":"https://api.github.com/users/riversand963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversand963/subscriptions","organizations_url":"https://api.github.com/users/riversand963/orgs","repos_url":"https://api.github.com/users/riversand963/repos","events_url":"https://api.github.com/users/riversand963/events{/privacy}","received_events_url":"https://api.github.com/users/riversand963/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-11-30T18:00:54Z","updated_at":"2017-11-30T18:00:54Z","html_url":"https://github.com/Alluxio/alluxio/pull/6471#discussion_r154154099","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/154154099"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/6471#discussion_r154154099"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471"}},"in_reply_to_id":153972486},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471","id":153430185,"html_url":"https://github.com/Alluxio/alluxio/pull/6471","diff_url":"https://github.com/Alluxio/alluxio/pull/6471.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/6471.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/6471","number":6471,"state":"open","locked":false,"title":"[ALLUXIO-3034] Validating Alluxio Properties for Secure HDFS as UnderFS","user":{"login":"riversand963","id":20094703,"avatar_url":"https://avatars0.githubusercontent.com/u/20094703?v=4","gravatar_id":"","url":"https://api.github.com/users/riversand963","html_url":"https://github.com/riversand963","followers_url":"https://api.github.com/users/riversand963/followers","following_url":"https://api.github.com/users/riversand963/following{/other_user}","gists_url":"https://api.github.com/users/riversand963/gists{/gist_id}","starred_url":"https://api.github.com/users/riversand963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversand963/subscriptions","organizations_url":"https://api.github.com/users/riversand963/orgs","repos_url":"https://api.github.com/users/riversand963/repos","events_url":"https://api.github.com/users/riversand963/events{/privacy}","received_events_url":"https://api.github.com/users/riversand963/received_events","type":"User","site_admin":false},"body":"Addressing https://tachyonnexus.atlassian.net/projects/OSD/issues/OSD-3034.\r\n@bf8086 \r\nCan you take a look at this simple validation task? Thanks!","created_at":"2017-11-18T02:23:22Z","updated_at":"2017-11-30T18:00:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69db62a5a15a0cbe9a60bbc7c629f053854a56ec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/6471/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/3872f9da6f360a8ff22326ed54aa66372598fc6c","head":{"label":"riversand963:security_validation","ref":"security_validation","sha":"3872f9da6f360a8ff22326ed54aa66372598fc6c","user":{"login":"riversand963","id":20094703,"avatar_url":"https://avatars0.githubusercontent.com/u/20094703?v=4","gravatar_id":"","url":"https://api.github.com/users/riversand963","html_url":"https://github.com/riversand963","followers_url":"https://api.github.com/users/riversand963/followers","following_url":"https://api.github.com/users/riversand963/following{/other_user}","gists_url":"https://api.github.com/users/riversand963/gists{/gist_id}","starred_url":"https://api.github.com/users/riversand963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversand963/subscriptions","organizations_url":"https://api.github.com/users/riversand963/orgs","repos_url":"https://api.github.com/users/riversand963/repos","events_url":"https://api.github.com/users/riversand963/events{/privacy}","received_events_url":"https://api.github.com/users/riversand963/received_events","type":"User","site_admin":false},"repo":{"id":92904337,"name":"alluxio","full_name":"riversand963/alluxio","owner":{"login":"riversand963","id":20094703,"avatar_url":"https://avatars0.githubusercontent.com/u/20094703?v=4","gravatar_id":"","url":"https://api.github.com/users/riversand963","html_url":"https://github.com/riversand963","followers_url":"https://api.github.com/users/riversand963/followers","following_url":"https://api.github.com/users/riversand963/following{/other_user}","gists_url":"https://api.github.com/users/riversand963/gists{/gist_id}","starred_url":"https://api.github.com/users/riversand963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riversand963/subscriptions","organizations_url":"https://api.github.com/users/riversand963/orgs","repos_url":"https://api.github.com/users/riversand963/repos","events_url":"https://api.github.com/users/riversand963/events{/privacy}","received_events_url":"https://api.github.com/users/riversand963/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/riversand963/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/riversand963/alluxio","forks_url":"https://api.github.com/repos/riversand963/alluxio/forks","keys_url":"https://api.github.com/repos/riversand963/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riversand963/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riversand963/alluxio/teams","hooks_url":"https://api.github.com/repos/riversand963/alluxio/hooks","issue_events_url":"https://api.github.com/repos/riversand963/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/riversand963/alluxio/events","assignees_url":"https://api.github.com/repos/riversand963/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/riversand963/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/riversand963/alluxio/tags","blobs_url":"https://api.github.com/repos/riversand963/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riversand963/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riversand963/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/riversand963/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riversand963/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/riversand963/alluxio/languages","stargazers_url":"https://api.github.com/repos/riversand963/alluxio/stargazers","contributors_url":"https://api.github.com/repos/riversand963/alluxio/contributors","subscribers_url":"https://api.github.com/repos/riversand963/alluxio/subscribers","subscription_url":"https://api.github.com/repos/riversand963/alluxio/subscription","commits_url":"https://api.github.com/repos/riversand963/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/riversand963/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/riversand963/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/riversand963/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/riversand963/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/riversand963/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riversand963/alluxio/merges","archive_url":"https://api.github.com/repos/riversand963/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riversand963/alluxio/downloads","issues_url":"https://api.github.com/repos/riversand963/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/riversand963/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/riversand963/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/riversand963/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riversand963/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/riversand963/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/riversand963/alluxio/deployments","created_at":"2017-05-31T04:29:58Z","updated_at":"2017-05-31T04:30:05Z","pushed_at":"2017-11-30T00:46:57Z","git_url":"git://github.com/riversand963/alluxio.git","ssh_url":"git@github.com:riversand963/alluxio.git","clone_url":"https://github.com/riversand963/alluxio.git","svn_url":"https://github.com/riversand963/alluxio","homepage":"http://www.alluxio.org/","size":83426,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"a5feaaa37f58ad4d6482021fde1a43da75fc5936","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2017-11-30T11:21:18Z","pushed_at":"2017-11-30T15:42:46Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":83591,"stargazers_count":3237,"watchers_count":3237,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1714,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1714,"open_issues":26,"watchers":3237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/6471"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/6471"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/6471/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6471/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/3872f9da6f360a8ff22326ed54aa66372598fc6c"}},"author_association":"NONE"}}
{"actor":{"display_login":"riversand963"}}