{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/117875005","pull_request_review_id":39617020,"id":117875005,"diff_hunk":"@@ -910,6 +911,35 @@ extern (C++) Expression semanticTraits(TraitsExp e, Scope* sc)\n         auto tup = new TupleExp(e.loc, mods);\n         return tup.semantic(sc);\n     }\n+    if (e.ident == Id.getLinkage)\n+    {\n+        // get symbol linkage as a string\n+        if (dim != 1)\n+            return dimError(1);\n+\n+        auto o = (*e.args)[0];\n+        auto s = getDsymbol(o);\n+        Declaration d;\n+        if (!s || (d = s.isDeclaration()) is null)\n+        {\n+            e.error(\"argument to `__traits(getLinkage, %s)` is not a declaration\", o.toChars());\n+            return new ErrorExp();\n+        }\n+        string linkage;\n+        switch (d.linkage)\n+        {","path":"src/ddmd/traits.d","position":28,"original_position":28,"commit_id":"3cf13badaf4abc6a4d23518db7c8636881ec4942","original_commit_id":"3cf13badaf4abc6a4d23518db7c8636881ec4942","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars3.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"body":"Won't work because of `C++` and `Objective-C`","created_at":"2017-05-23T00:31:32Z","updated_at":"2017-05-23T00:31:32Z","html_url":"https://github.com/dlang/dmd/pull/6822#discussion_r117875005","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/6822","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/117875005"},"html":{"href":"https://github.com/dlang/dmd/pull/6822#discussion_r117875005"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/6822"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/6822","id":121885812,"html_url":"https://github.com/dlang/dmd/pull/6822","diff_url":"https://github.com/dlang/dmd/pull/6822.diff","patch_url":"https://github.com/dlang/dmd/pull/6822.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/6822","number":6822,"state":"open","locked":false,"title":"fix Issue 17419 - add __traits(getLinkage, s) to the the linkage of s…","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars3.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"body":"…ymbol s\r\n\r\nThe use of name mangling in std.traits is slow, unreliable and brittle. Should be replaced with __traits(). This is a start.","created_at":"2017-05-22T23:33:00Z","updated_at":"2017-05-23T00:31:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb72aefbcbddf781b356dd546e705b9df6dcfbdf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/6822/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/6822/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/6822/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/3cf13badaf4abc6a4d23518db7c8636881ec4942","head":{"label":"WalterBright:fix17419","ref":"fix17419","sha":"3cf13badaf4abc6a4d23518db7c8636881ec4942","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars3.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"repo":{"id":7849157,"name":"dmd","full_name":"WalterBright/dmd","owner":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars3.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WalterBright/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/WalterBright/dmd","forks_url":"https://api.github.com/repos/WalterBright/dmd/forks","keys_url":"https://api.github.com/repos/WalterBright/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WalterBright/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WalterBright/dmd/teams","hooks_url":"https://api.github.com/repos/WalterBright/dmd/hooks","issue_events_url":"https://api.github.com/repos/WalterBright/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/WalterBright/dmd/events","assignees_url":"https://api.github.com/repos/WalterBright/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/WalterBright/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/WalterBright/dmd/tags","blobs_url":"https://api.github.com/repos/WalterBright/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WalterBright/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WalterBright/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/WalterBright/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WalterBright/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/WalterBright/dmd/languages","stargazers_url":"https://api.github.com/repos/WalterBright/dmd/stargazers","contributors_url":"https://api.github.com/repos/WalterBright/dmd/contributors","subscribers_url":"https://api.github.com/repos/WalterBright/dmd/subscribers","subscription_url":"https://api.github.com/repos/WalterBright/dmd/subscription","commits_url":"https://api.github.com/repos/WalterBright/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/WalterBright/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/WalterBright/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/WalterBright/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/WalterBright/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/WalterBright/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WalterBright/dmd/merges","archive_url":"https://api.github.com/repos/WalterBright/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WalterBright/dmd/downloads","issues_url":"https://api.github.com/repos/WalterBright/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/WalterBright/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/WalterBright/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/WalterBright/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WalterBright/dmd/labels{/name}","releases_url":"https://api.github.com/repos/WalterBright/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/WalterBright/dmd/deployments","created_at":"2013-01-27T06:45:40Z","updated_at":"2015-08-23T08:04:14Z","pushed_at":"2017-05-22T23:36:37Z","git_url":"git://github.com/WalterBright/dmd.git","ssh_url":"git@github.com:WalterBright/dmd.git","clone_url":"https://github.com/WalterBright/dmd.git","svn_url":"https://github.com/WalterBright/dmd","homepage":"d-programming-language.org","size":70121,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"a9b92acd6660ca9217a5602d979514c1fe6fb39c","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars0.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars0.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2017-05-22T09:27:28Z","pushed_at":"2017-05-23T00:11:41Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":72250,"stargazers_count":1586,"watchers_count":1586,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":411,"mirror_url":null,"open_issues_count":171,"forks":411,"open_issues":171,"watchers":1586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/6822"},"html":{"href":"https://github.com/dlang/dmd/pull/6822"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/6822"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/6822/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/6822/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/6822/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/3cf13badaf4abc6a4d23518db7c8636881ec4942"}}}}
{"actor":{"display_login":"WalterBright"}}