{"action":"created","issue":{"url":"https://api.github.com/repos/kennethreitz/pipenv/issues/619","repository_url":"https://api.github.com/repos/kennethreitz/pipenv","labels_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/619/labels{/name}","comments_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/619/comments","events_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/619/events","html_url":"https://github.com/kennethreitz/pipenv/pull/619","id":259363430,"number":619,"title":"Windows concurrency","user":{"login":"techalchemy","id":954310,"avatar_url":"https://avatars0.githubusercontent.com/u/954310?v=4","gravatar_id":"","url":"https://api.github.com/users/techalchemy","html_url":"https://github.com/techalchemy","followers_url":"https://api.github.com/users/techalchemy/followers","following_url":"https://api.github.com/users/techalchemy/following{/other_user}","gists_url":"https://api.github.com/users/techalchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/techalchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techalchemy/subscriptions","organizations_url":"https://api.github.com/users/techalchemy/orgs","repos_url":"https://api.github.com/users/techalchemy/repos","events_url":"https://api.github.com/users/techalchemy/events{/privacy}","received_events_url":"https://api.github.com/users/techalchemy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-09-21T03:16:28Z","updated_at":"2017-09-21T14:54:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kennethreitz/pipenv/pulls/619","html_url":"https://github.com/kennethreitz/pipenv/pull/619","diff_url":"https://github.com/kennethreitz/pipenv/pull/619.diff","patch_url":"https://github.com/kennethreitz/pipenv/pull/619.patch"},"body":"* I added some helper functions but essential the issue on windows boiled down to a problem with paths\r\n* I don't think it's safe to explicitly use forward or backward slashes rather than `os.path.join()`\r\n* There are places where we are currently using `os.sep` and concatenating -- is there a reason? Should we switch to `os.path.join`?\r\n* `Project` objects currently resolve virtualenv locations using forward slashes on windows, but `os.path.join` just appends the remaining items with the normal path separator, so we can use `os.path.normpath` to normalize\r\n* However this pre-escapes the path for us which means we can't drop the command into a double-quoted string and pass it to delegator, so instead I am shellquoting everything that isn't handled this way now\r\n\r\nLets see if it passes tests."},"comment":{"url":"https://api.github.com/repos/kennethreitz/pipenv/issues/comments/331182022","html_url":"https://github.com/kennethreitz/pipenv/pull/619#issuecomment-331182022","issue_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/619","id":331182022,"user":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars2.githubusercontent.com/u/119893?v=4","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T14:54:37Z","updated_at":"2017-09-21T14:54:37Z","author_association":"OWNER","body":"e.g. they're still running non-concurrently. "}}
{"actor":{"display_login":"kennethreitz"}}