{"action":"created","comment":{"url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/comments/107129447","pull_request_review_id":28081410,"id":107129447,"diff_hunk":"@@ -302,98 +298,98 @@ class Tracker(emitters: Seq[TEmitter], namespace: String, appId: String, encodeB\n     timestamp: Option[Timestamp] = None): Tracker = {\n \n     val payload = new Payload()\n+    payload.add(pageUrlKey, pageUrl)\n \n-    payload.add(\"e\", \"ti\")\n-    payload.add(\"ti_id\", orderId)\n-    payload.add(\"ti_sk\", sku)\n-    payload.add(\"ti_nm\", name)\n-    payload.add(\"ti_ca\", category)\n-    payload.add(\"ti_pr\", price.toString)\n-    payload.add(\"ti_qu\", quantity.toString)\n-    payload.add(\"ti_cu\", currency)\n+    payload.add(eventTypeKey, transactionItemType)\n+    payload.add(transactionItemKey(idSuffix), orderId)\n+    payload.add(transactionItemKey(skuSuffix), sku)\n+    payload.add(transactionItemKey(priceSuffix), price.toString)\n+    payload.add(transactionItemKey(quantitySuffix), quantity.toString)\n \n-    track(completePayload(payload, contexts, timestamp))\n+    payload.add(transactionItemKey(categorySuffix), category)\n+    payload.add(transactionItemKey(currencySuffix), currency)\n+    payload.add(transactionItemKey(nameSuffix), name)\n \n+    track(completePayload(payload, contexts, timestamp))\n     this\n   }\n \n   /**\n-   * Track an add-to-cart event\n-   *\n-   * @param sku Required. Item's SKU code.\n-   * @param name Optional. Product name.\n-   * @param category Optional. Product category.\n-   * @param unitPrice Optional. Product price.\n-   * @param quantity Required. Quantity added.\n-   * @param currency Optional. Product price currency.\n-   * @param context Optional. Context relating to the event.\n-   * @param timestamp optional user-provided timestamp (ms) for the event\n-   * @return the tracker instance\n-   */\n+    * Tracks an Add-To-Cart event.\n+    *\n+    * @param pageUrl optional url of resource\n+    * @param sku Required. Item's SKU code.\n+    * @param name Optional. Product name.\n+    * @param category Optional. Product category.\n+    * @param unitPrice Optional. Product price.\n+    * @param quantity Required. Quantity added.\n+    * @param currency Optional. Product price currency.\n+    * @param contexts list of additional contexts\n+    * @param timestamp optional user-provided timestamp (ms) for the event\n+    * @return the tracker instance\n+    */\n   def trackAddToCart(\n+    pageUrl: Option[String] = None,","path":"src/main/scala/com.snowplowanalytics.snowplow/scalatracker/Tracker.scala","position":264,"original_position":264,"commit_id":"c94344b6a20f268e4e672211bf4325bb1fe0e5bb","original_commit_id":"c94344b6a20f268e4e672211bf4325bb1fe0e5bb","user":{"login":"christoph-buente","id":36998,"avatar_url":"https://avatars1.githubusercontent.com/u/36998?v=3","gravatar_id":"","url":"https://api.github.com/users/christoph-buente","html_url":"https://github.com/christoph-buente","followers_url":"https://api.github.com/users/christoph-buente/followers","following_url":"https://api.github.com/users/christoph-buente/following{/other_user}","gists_url":"https://api.github.com/users/christoph-buente/gists{/gist_id}","starred_url":"https://api.github.com/users/christoph-buente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christoph-buente/subscriptions","organizations_url":"https://api.github.com/users/christoph-buente/orgs","repos_url":"https://api.github.com/users/christoph-buente/repos","events_url":"https://api.github.com/users/christoph-buente/events{/privacy}","received_events_url":"https://api.github.com/users/christoph-buente/received_events","type":"User","site_admin":false},"body":"I would rather extend the \"setSubject\" method: https://github.com/snowplow/snowplow/wiki/Scala-Tracker#subject","created_at":"2017-03-21T11:20:18Z","updated_at":"2017-03-21T11:20:18Z","html_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker/pull/1#discussion_r107129447","pull_request_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/comments/107129447"},"html":{"href":"https://github.com/liveintent-berlin/snowplow-scala-tracker/pull/1#discussion_r107129447"},"pull_request":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1","id":110860109,"html_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker/pull/1","diff_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker/pull/1.diff","patch_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker/pull/1.patch","issue_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/1","number":1,"state":"open","locked":false,"title":"Fixes TB-563, missing page_url in Transaction Events","user":{"login":"mehmeteking","id":1706323,"avatar_url":"https://avatars0.githubusercontent.com/u/1706323?v=3","gravatar_id":"","url":"https://api.github.com/users/mehmeteking","html_url":"https://github.com/mehmeteking","followers_url":"https://api.github.com/users/mehmeteking/followers","following_url":"https://api.github.com/users/mehmeteking/following{/other_user}","gists_url":"https://api.github.com/users/mehmeteking/gists{/gist_id}","starred_url":"https://api.github.com/users/mehmeteking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehmeteking/subscriptions","organizations_url":"https://api.github.com/users/mehmeteking/orgs","repos_url":"https://api.github.com/users/mehmeteking/repos","events_url":"https://api.github.com/users/mehmeteking/events{/privacy}","received_events_url":"https://api.github.com/users/mehmeteking/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-15T14:44:19Z","updated_at":"2017-03-21T11:20:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afdf64dc11b05d514b759c0762dd220d9bff29dd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1/commits","review_comments_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1/comments","review_comment_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/1/comments","statuses_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/statuses/c94344b6a20f268e4e672211bf4325bb1fe0e5bb","head":{"label":"liveintent-berlin:TB-563-missing-url-in-transaction-events","ref":"TB-563-missing-url-in-transaction-events","sha":"c94344b6a20f268e4e672211bf4325bb1fe0e5bb","user":{"login":"liveintent-berlin","id":8297624,"avatar_url":"https://avatars3.githubusercontent.com/u/8297624?v=3","gravatar_id":"","url":"https://api.github.com/users/liveintent-berlin","html_url":"https://github.com/liveintent-berlin","followers_url":"https://api.github.com/users/liveintent-berlin/followers","following_url":"https://api.github.com/users/liveintent-berlin/following{/other_user}","gists_url":"https://api.github.com/users/liveintent-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/liveintent-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveintent-berlin/subscriptions","organizations_url":"https://api.github.com/users/liveintent-berlin/orgs","repos_url":"https://api.github.com/users/liveintent-berlin/repos","events_url":"https://api.github.com/users/liveintent-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/liveintent-berlin/received_events","type":"Organization","site_admin":false},"repo":{"id":80619968,"name":"snowplow-scala-tracker","full_name":"liveintent-berlin/snowplow-scala-tracker","owner":{"login":"liveintent-berlin","id":8297624,"avatar_url":"https://avatars3.githubusercontent.com/u/8297624?v=3","gravatar_id":"","url":"https://api.github.com/users/liveintent-berlin","html_url":"https://github.com/liveintent-berlin","followers_url":"https://api.github.com/users/liveintent-berlin/followers","following_url":"https://api.github.com/users/liveintent-berlin/following{/other_user}","gists_url":"https://api.github.com/users/liveintent-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/liveintent-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveintent-berlin/subscriptions","organizations_url":"https://api.github.com/users/liveintent-berlin/orgs","repos_url":"https://api.github.com/users/liveintent-berlin/repos","events_url":"https://api.github.com/users/liveintent-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/liveintent-berlin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker","description":"Snowplow event tracker for Scala. Add analytics to your Scala, Akka and Play apps and servers","fork":true,"url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker","forks_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/forks","keys_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/teams","hooks_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/hooks","issue_events_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/events","assignees_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/tags","blobs_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/languages","stargazers_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/stargazers","contributors_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/contributors","subscribers_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/subscribers","subscription_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/subscription","commits_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/merges","archive_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/downloads","issues_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/labels{/name}","releases_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/deployments","created_at":"2017-02-01T12:57:24Z","updated_at":"2017-02-01T12:57:26Z","pushed_at":"2017-03-17T13:16:46Z","git_url":"git://github.com/liveintent-berlin/snowplow-scala-tracker.git","ssh_url":"git@github.com:liveintent-berlin/snowplow-scala-tracker.git","clone_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker.git","svn_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker","homepage":"http://snowplowanalytics.com","size":83,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"liveintent-berlin:add-transactions","ref":"add-transactions","sha":"ae0680819e6d3721a7b2b24b0ed79b70e5c16684","user":{"login":"liveintent-berlin","id":8297624,"avatar_url":"https://avatars3.githubusercontent.com/u/8297624?v=3","gravatar_id":"","url":"https://api.github.com/users/liveintent-berlin","html_url":"https://github.com/liveintent-berlin","followers_url":"https://api.github.com/users/liveintent-berlin/followers","following_url":"https://api.github.com/users/liveintent-berlin/following{/other_user}","gists_url":"https://api.github.com/users/liveintent-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/liveintent-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveintent-berlin/subscriptions","organizations_url":"https://api.github.com/users/liveintent-berlin/orgs","repos_url":"https://api.github.com/users/liveintent-berlin/repos","events_url":"https://api.github.com/users/liveintent-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/liveintent-berlin/received_events","type":"Organization","site_admin":false},"repo":{"id":80619968,"name":"snowplow-scala-tracker","full_name":"liveintent-berlin/snowplow-scala-tracker","owner":{"login":"liveintent-berlin","id":8297624,"avatar_url":"https://avatars3.githubusercontent.com/u/8297624?v=3","gravatar_id":"","url":"https://api.github.com/users/liveintent-berlin","html_url":"https://github.com/liveintent-berlin","followers_url":"https://api.github.com/users/liveintent-berlin/followers","following_url":"https://api.github.com/users/liveintent-berlin/following{/other_user}","gists_url":"https://api.github.com/users/liveintent-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/liveintent-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveintent-berlin/subscriptions","organizations_url":"https://api.github.com/users/liveintent-berlin/orgs","repos_url":"https://api.github.com/users/liveintent-berlin/repos","events_url":"https://api.github.com/users/liveintent-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/liveintent-berlin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker","description":"Snowplow event tracker for Scala. Add analytics to your Scala, Akka and Play apps and servers","fork":true,"url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker","forks_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/forks","keys_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/teams","hooks_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/hooks","issue_events_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/events","assignees_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/tags","blobs_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/languages","stargazers_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/stargazers","contributors_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/contributors","subscribers_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/subscribers","subscription_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/subscription","commits_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/merges","archive_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/downloads","issues_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/labels{/name}","releases_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/deployments","created_at":"2017-02-01T12:57:24Z","updated_at":"2017-02-01T12:57:26Z","pushed_at":"2017-03-17T13:16:46Z","git_url":"git://github.com/liveintent-berlin/snowplow-scala-tracker.git","ssh_url":"git@github.com:liveintent-berlin/snowplow-scala-tracker.git","clone_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker.git","svn_url":"https://github.com/liveintent-berlin/snowplow-scala-tracker","homepage":"http://snowplowanalytics.com","size":83,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1"},"html":{"href":"https://github.com/liveintent-berlin/snowplow-scala-tracker/pull/1"},"issue":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/1"},"comments":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/liveintent-berlin/snowplow-scala-tracker/statuses/c94344b6a20f268e4e672211bf4325bb1fe0e5bb"}}}}
{"actor":{"display_login":"christoph-buente"}}