{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/124662735","pull_request_review_id":46974822,"id":124662735,"diff_hunk":"@@ -447,12 +447,14 @@ def worker_loop(batch_size, batch_delay)\n       shutdown_requested |= signal.shutdown? # latch on shutdown signal\n \n       batch = @filter_queue_client.read_batch # metrics are started in read_batch","path":"logstash-core/lib/logstash/pipeline.rb","position":3,"original_position":3,"commit_id":"fcdb2af66b4df06d9afca8938eed411062673771","original_commit_id":"fcdb2af66b4df06d9afca8938eed411062673771","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars1.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"There is a timeout when waiting to fulfill a batch. Yields a short or empty batch. Also, due to conditionals or cancellations batches can become effectively empty. HTH","created_at":"2017-06-28T21:33:41Z","updated_at":"2017-06-28T21:33:41Z","html_url":"https://github.com/elastic/logstash/pull/7559#discussion_r124662735","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/7559","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/124662735"},"html":{"href":"https://github.com/elastic/logstash/pull/7559#discussion_r124662735"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/7559"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/7559","id":127977769,"html_url":"https://github.com/elastic/logstash/pull/7559","diff_url":"https://github.com/elastic/logstash/pull/7559.diff","patch_url":"https://github.com/elastic/logstash/pull/7559.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/7559","number":7559,"state":"open","locked":false,"title":"Minor bug fix: While idle, metrics objects are initialized but effect…","user":{"login":"jakelandis","id":976291,"avatar_url":"https://avatars1.githubusercontent.com/u/976291?v=3","gravatar_id":"","url":"https://api.github.com/users/jakelandis","html_url":"https://github.com/jakelandis","followers_url":"https://api.github.com/users/jakelandis/followers","following_url":"https://api.github.com/users/jakelandis/following{/other_user}","gists_url":"https://api.github.com/users/jakelandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelandis/subscriptions","organizations_url":"https://api.github.com/users/jakelandis/orgs","repos_url":"https://api.github.com/users/jakelandis/repos","events_url":"https://api.github.com/users/jakelandis/events{/privacy}","received_events_url":"https://api.github.com/users/jakelandis/received_events","type":"User","site_admin":false},"body":"…ively unused\r\n\r\nThe change here is to exclude work from being done if the batch size is zero or less.\r\n\r\nThis change makes me a bit nervous since I am not familiar enough with the pipeline code to know if this will cause any downstream effects. \r\n\r\nFixes #7558","created_at":"2017-06-28T17:30:40Z","updated_at":"2017-06-28T21:33:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c3ea67ddea4516f6ef6dd4a21e7927012d1ff55","assignee":{"login":"elasticsearch-bot","id":9386276,"avatar_url":"https://avatars0.githubusercontent.com/u/9386276?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch-bot","html_url":"https://github.com/elasticsearch-bot","followers_url":"https://api.github.com/users/elasticsearch-bot/followers","following_url":"https://api.github.com/users/elasticsearch-bot/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch-bot/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch-bot/orgs","repos_url":"https://api.github.com/users/elasticsearch-bot/repos","events_url":"https://api.github.com/users/elasticsearch-bot/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch-bot/received_events","type":"User","site_admin":false},"assignees":[{"login":"elasticsearch-bot","id":9386276,"avatar_url":"https://avatars0.githubusercontent.com/u/9386276?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch-bot","html_url":"https://github.com/elasticsearch-bot","followers_url":"https://api.github.com/users/elasticsearch-bot/followers","following_url":"https://api.github.com/users/elasticsearch-bot/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch-bot/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch-bot/orgs","repos_url":"https://api.github.com/users/elasticsearch-bot/repos","events_url":"https://api.github.com/users/elasticsearch-bot/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch-bot/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/7559/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/7559/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/7559/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/fcdb2af66b4df06d9afca8938eed411062673771","head":{"label":"jakelandis:fix/7558","ref":"fix/7558","sha":"fcdb2af66b4df06d9afca8938eed411062673771","user":{"login":"jakelandis","id":976291,"avatar_url":"https://avatars1.githubusercontent.com/u/976291?v=3","gravatar_id":"","url":"https://api.github.com/users/jakelandis","html_url":"https://github.com/jakelandis","followers_url":"https://api.github.com/users/jakelandis/followers","following_url":"https://api.github.com/users/jakelandis/following{/other_user}","gists_url":"https://api.github.com/users/jakelandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelandis/subscriptions","organizations_url":"https://api.github.com/users/jakelandis/orgs","repos_url":"https://api.github.com/users/jakelandis/repos","events_url":"https://api.github.com/users/jakelandis/events{/privacy}","received_events_url":"https://api.github.com/users/jakelandis/received_events","type":"User","site_admin":false},"repo":{"id":92552196,"name":"logstash","full_name":"jakelandis/logstash","owner":{"login":"jakelandis","id":976291,"avatar_url":"https://avatars1.githubusercontent.com/u/976291?v=3","gravatar_id":"","url":"https://api.github.com/users/jakelandis","html_url":"https://github.com/jakelandis","followers_url":"https://api.github.com/users/jakelandis/followers","following_url":"https://api.github.com/users/jakelandis/following{/other_user}","gists_url":"https://api.github.com/users/jakelandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelandis/subscriptions","organizations_url":"https://api.github.com/users/jakelandis/orgs","repos_url":"https://api.github.com/users/jakelandis/repos","events_url":"https://api.github.com/users/jakelandis/events{/privacy}","received_events_url":"https://api.github.com/users/jakelandis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakelandis/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/jakelandis/logstash","forks_url":"https://api.github.com/repos/jakelandis/logstash/forks","keys_url":"https://api.github.com/repos/jakelandis/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakelandis/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakelandis/logstash/teams","hooks_url":"https://api.github.com/repos/jakelandis/logstash/hooks","issue_events_url":"https://api.github.com/repos/jakelandis/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/jakelandis/logstash/events","assignees_url":"https://api.github.com/repos/jakelandis/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/jakelandis/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/jakelandis/logstash/tags","blobs_url":"https://api.github.com/repos/jakelandis/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakelandis/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakelandis/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakelandis/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakelandis/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/jakelandis/logstash/languages","stargazers_url":"https://api.github.com/repos/jakelandis/logstash/stargazers","contributors_url":"https://api.github.com/repos/jakelandis/logstash/contributors","subscribers_url":"https://api.github.com/repos/jakelandis/logstash/subscribers","subscription_url":"https://api.github.com/repos/jakelandis/logstash/subscription","commits_url":"https://api.github.com/repos/jakelandis/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakelandis/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakelandis/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakelandis/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakelandis/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/jakelandis/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakelandis/logstash/merges","archive_url":"https://api.github.com/repos/jakelandis/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakelandis/logstash/downloads","issues_url":"https://api.github.com/repos/jakelandis/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/jakelandis/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/jakelandis/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/jakelandis/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakelandis/logstash/labels{/name}","releases_url":"https://api.github.com/repos/jakelandis/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/jakelandis/logstash/deployments","created_at":"2017-05-26T22:12:28Z","updated_at":"2017-05-26T22:12:33Z","pushed_at":"2017-06-28T17:29:08Z","git_url":"git://github.com/jakelandis/logstash.git","ssh_url":"git@github.com:jakelandis/logstash.git","clone_url":"https://github.com/jakelandis/logstash.git","svn_url":"https://github.com/jakelandis/logstash","homepage":"https://www.elastic.co/products/logstash","size":90477,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"b06767b71e9d37ce686d4c3773256b7a7cd18513","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2017-06-28T10:48:02Z","pushed_at":"2017-06-28T20:05:47Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":90824,"stargazers_count":7655,"watchers_count":7655,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2194,"mirror_url":null,"open_issues_count":879,"forks":2194,"open_issues":879,"watchers":7655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/7559"},"html":{"href":"https://github.com/elastic/logstash/pull/7559"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/7559"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/7559/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/7559/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/7559/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/fcdb2af66b4df06d9afca8938eed411062673771"}}}}
{"actor":{"display_login":"guyboertje"}}