{"action":"created","issue":{"url":"https://api.github.com/repos/rcjsuen/dockerfile-language-server-nodejs/issues/135","repository_url":"https://api.github.com/repos/rcjsuen/dockerfile-language-server-nodejs","labels_url":"https://api.github.com/repos/rcjsuen/dockerfile-language-server-nodejs/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/rcjsuen/dockerfile-language-server-nodejs/issues/135/comments","events_url":"https://api.github.com/repos/rcjsuen/dockerfile-language-server-nodejs/issues/135/events","html_url":"https://github.com/rcjsuen/dockerfile-language-server-nodejs/issues/135","id":248227006,"number":135,"title":"add insertText for completion items","user":{"login":"prabirshrestha","id":287744,"avatar_url":"https://avatars3.githubusercontent.com/u/287744?v=4","gravatar_id":"","url":"https://api.github.com/users/prabirshrestha","html_url":"https://github.com/prabirshrestha","followers_url":"https://api.github.com/users/prabirshrestha/followers","following_url":"https://api.github.com/users/prabirshrestha/following{/other_user}","gists_url":"https://api.github.com/users/prabirshrestha/gists{/gist_id}","starred_url":"https://api.github.com/users/prabirshrestha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabirshrestha/subscriptions","organizations_url":"https://api.github.com/users/prabirshrestha/orgs","repos_url":"https://api.github.com/users/prabirshrestha/repos","events_url":"https://api.github.com/users/prabirshrestha/events{/privacy}","received_events_url":"https://api.github.com/users/prabirshrestha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-08-06T05:35:02Z","updated_at":"2017-08-06T21:46:10Z","closed_at":null,"body":"Currently my [asyncomplete-lsp.vim](https://github.com/prabirshrestha/asyncomplete-lsp.vim) plugin doesn't support `textEdits` for completions. Would it be possible to add `insertText` for the completion items?\r\n\r\nAccording to the spec `CompletionItem` can contain an optional `insertText` which is used instead of label if it exists but ignored when `textEdit` is present. https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#completion-request\r\n\r\n```typescript\r\n/**\r\n* A string that should be inserted a document when selecting\r\n* this completion. When `falsy` the label is used.\r\n*/\r\ninsertText?: string;\r\n\r\n/**\r\n * An edit which is applied to a document when selecting this completion. When an edit is provided the value of\r\n * `insertText` is ignored.\r\n *\r\n * *Note:* The range of the edit must be a single line range and it must contain the position at which completion\r\n * has been requested.\r\n */\r\ntextEdit?: TextEdit;\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/rcjsuen/dockerfile-language-server-nodejs/issues/comments/320534930","html_url":"https://github.com/rcjsuen/dockerfile-language-server-nodejs/issues/135#issuecomment-320534930","issue_url":"https://api.github.com/repos/rcjsuen/dockerfile-language-server-nodejs/issues/135","id":320534930,"user":{"login":"prabirshrestha","id":287744,"avatar_url":"https://avatars3.githubusercontent.com/u/287744?v=4","gravatar_id":"","url":"https://api.github.com/users/prabirshrestha","html_url":"https://github.com/prabirshrestha","followers_url":"https://api.github.com/users/prabirshrestha/followers","following_url":"https://api.github.com/users/prabirshrestha/following{/other_user}","gists_url":"https://api.github.com/users/prabirshrestha/gists{/gist_id}","starred_url":"https://api.github.com/users/prabirshrestha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabirshrestha/subscriptions","organizations_url":"https://api.github.com/users/prabirshrestha/orgs","repos_url":"https://api.github.com/users/prabirshrestha/repos","events_url":"https://api.github.com/users/prabirshrestha/events{/privacy}","received_events_url":"https://api.github.com/users/prabirshrestha/received_events","type":"User","site_admin":false},"created_at":"2017-08-06T21:46:10Z","updated_at":"2017-08-06T21:46:10Z","body":"I don't have snippet support. Also shouldn't the server look at `TextDocumentClientCapabilities` and `completion.completionItem.snippetSupport`? Currently `vim-lsp` send clientCapabilities as `{}`."}}
{"actor":{"display_login":"prabirshrestha"}}