{"action":"created","comment":{"url":"https://api.github.com/repos/chevah/pocket-lint/pulls/comments/115116305","pull_request_review_id":36640165,"id":115116305,"diff_hunk":"@@ -939,6 +945,7 @@ def check_lines(self):\n         for line_no, line in enumerate(self.lines):\n             line_no += 1\n             self.check_length(line_no, line)\n+            self.check_semantic_newline()","path":"pocketlint/formatcheck.py","position":17,"original_position":17,"commit_id":"e34c3bafc1738c8984dc41969b99eccae50ced97","original_commit_id":"e34c3bafc1738c8984dc41969b99eccae50ced97","user":{"login":"adiroiban","id":204609,"avatar_url":"https://avatars0.githubusercontent.com/u/204609?v=3","gravatar_id":"","url":"https://api.github.com/users/adiroiban","html_url":"https://github.com/adiroiban","followers_url":"https://api.github.com/users/adiroiban/followers","following_url":"https://api.github.com/users/adiroiban/following{/other_user}","gists_url":"https://api.github.com/users/adiroiban/gists{/gist_id}","starred_url":"https://api.github.com/users/adiroiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiroiban/subscriptions","organizations_url":"https://api.github.com/users/adiroiban/orgs","repos_url":"https://api.github.com/users/adiroiban/repos","events_url":"https://api.github.com/users/adiroiban/events{/privacy}","received_events_url":"https://api.github.com/users/adiroiban/received_events","type":"User","site_admin":false},"body":"this is fine, but don't forget to pass the `line_no, line` arguments to this check.\r\n\r\nline_no is important so that the error report will pin-point the place with the error","created_at":"2017-05-06T08:56:44Z","updated_at":"2017-05-06T08:56:44Z","html_url":"https://github.com/chevah/pocket-lint/pull/2#discussion_r115116305","pull_request_url":"https://api.github.com/repos/chevah/pocket-lint/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/chevah/pocket-lint/pulls/comments/115116305"},"html":{"href":"https://github.com/chevah/pocket-lint/pull/2#discussion_r115116305"},"pull_request":{"href":"https://api.github.com/repos/chevah/pocket-lint/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/chevah/pocket-lint/pulls/2","id":119279017,"html_url":"https://github.com/chevah/pocket-lint/pull/2","diff_url":"https://github.com/chevah/pocket-lint/pull/2.diff","patch_url":"https://github.com/chevah/pocket-lint/pull/2.patch","issue_url":"https://api.github.com/repos/chevah/pocket-lint/issues/2","number":2,"state":"open","locked":false,"title":"[#4044] Add semantic newline checker in lint","user":{"login":"hcs0","id":5868781,"avatar_url":"https://avatars2.githubusercontent.com/u/5868781?v=3","gravatar_id":"","url":"https://api.github.com/users/hcs0","html_url":"https://github.com/hcs0","followers_url":"https://api.github.com/users/hcs0/followers","following_url":"https://api.github.com/users/hcs0/following{/other_user}","gists_url":"https://api.github.com/users/hcs0/gists{/gist_id}","starred_url":"https://api.github.com/users/hcs0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcs0/subscriptions","organizations_url":"https://api.github.com/users/hcs0/orgs","repos_url":"https://api.github.com/users/hcs0/repos","events_url":"https://api.github.com/users/hcs0/events{/privacy}","received_events_url":"https://api.github.com/users/hcs0/received_events","type":"User","site_admin":false},"body":"PR description to be updated","created_at":"2017-05-06T00:24:06Z","updated_at":"2017-05-06T08:56:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd8ef96b3d3c326ccf2b08eb05a51b468f744d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chevah/pocket-lint/pulls/2/commits","review_comments_url":"https://api.github.com/repos/chevah/pocket-lint/pulls/2/comments","review_comment_url":"https://api.github.com/repos/chevah/pocket-lint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chevah/pocket-lint/issues/2/comments","statuses_url":"https://api.github.com/repos/chevah/pocket-lint/statuses/e34c3bafc1738c8984dc41969b99eccae50ced97","head":{"label":"hcs0:4044-semantic-newline","ref":"4044-semantic-newline","sha":"e34c3bafc1738c8984dc41969b99eccae50ced97","user":{"login":"hcs0","id":5868781,"avatar_url":"https://avatars2.githubusercontent.com/u/5868781?v=3","gravatar_id":"","url":"https://api.github.com/users/hcs0","html_url":"https://github.com/hcs0","followers_url":"https://api.github.com/users/hcs0/followers","following_url":"https://api.github.com/users/hcs0/following{/other_user}","gists_url":"https://api.github.com/users/hcs0/gists{/gist_id}","starred_url":"https://api.github.com/users/hcs0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcs0/subscriptions","organizations_url":"https://api.github.com/users/hcs0/orgs","repos_url":"https://api.github.com/users/hcs0/repos","events_url":"https://api.github.com/users/hcs0/events{/privacy}","received_events_url":"https://api.github.com/users/hcs0/received_events","type":"User","site_admin":false},"repo":{"id":90425722,"name":"pocket-lint","full_name":"hcs0/pocket-lint","owner":{"login":"hcs0","id":5868781,"avatar_url":"https://avatars2.githubusercontent.com/u/5868781?v=3","gravatar_id":"","url":"https://api.github.com/users/hcs0","html_url":"https://github.com/hcs0","followers_url":"https://api.github.com/users/hcs0/followers","following_url":"https://api.github.com/users/hcs0/following{/other_user}","gists_url":"https://api.github.com/users/hcs0/gists{/gist_id}","starred_url":"https://api.github.com/users/hcs0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcs0/subscriptions","organizations_url":"https://api.github.com/users/hcs0/orgs","repos_url":"https://api.github.com/users/hcs0/repos","events_url":"https://api.github.com/users/hcs0/events{/privacy}","received_events_url":"https://api.github.com/users/hcs0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hcs0/pocket-lint","description":"GitHub Mirror of pocket-lint","fork":true,"url":"https://api.github.com/repos/hcs0/pocket-lint","forks_url":"https://api.github.com/repos/hcs0/pocket-lint/forks","keys_url":"https://api.github.com/repos/hcs0/pocket-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hcs0/pocket-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hcs0/pocket-lint/teams","hooks_url":"https://api.github.com/repos/hcs0/pocket-lint/hooks","issue_events_url":"https://api.github.com/repos/hcs0/pocket-lint/issues/events{/number}","events_url":"https://api.github.com/repos/hcs0/pocket-lint/events","assignees_url":"https://api.github.com/repos/hcs0/pocket-lint/assignees{/user}","branches_url":"https://api.github.com/repos/hcs0/pocket-lint/branches{/branch}","tags_url":"https://api.github.com/repos/hcs0/pocket-lint/tags","blobs_url":"https://api.github.com/repos/hcs0/pocket-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hcs0/pocket-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hcs0/pocket-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/hcs0/pocket-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hcs0/pocket-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/hcs0/pocket-lint/languages","stargazers_url":"https://api.github.com/repos/hcs0/pocket-lint/stargazers","contributors_url":"https://api.github.com/repos/hcs0/pocket-lint/contributors","subscribers_url":"https://api.github.com/repos/hcs0/pocket-lint/subscribers","subscription_url":"https://api.github.com/repos/hcs0/pocket-lint/subscription","commits_url":"https://api.github.com/repos/hcs0/pocket-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/hcs0/pocket-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/hcs0/pocket-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/hcs0/pocket-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/hcs0/pocket-lint/contents/{+path}","compare_url":"https://api.github.com/repos/hcs0/pocket-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hcs0/pocket-lint/merges","archive_url":"https://api.github.com/repos/hcs0/pocket-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hcs0/pocket-lint/downloads","issues_url":"https://api.github.com/repos/hcs0/pocket-lint/issues{/number}","pulls_url":"https://api.github.com/repos/hcs0/pocket-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/hcs0/pocket-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/hcs0/pocket-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hcs0/pocket-lint/labels{/name}","releases_url":"https://api.github.com/repos/hcs0/pocket-lint/releases{/id}","deployments_url":"https://api.github.com/repos/hcs0/pocket-lint/deployments","created_at":"2017-05-06T00:04:21Z","updated_at":"2017-05-06T00:04:23Z","pushed_at":"2017-05-06T00:24:58Z","git_url":"git://github.com/hcs0/pocket-lint.git","ssh_url":"git@github.com:hcs0/pocket-lint.git","clone_url":"https://github.com/hcs0/pocket-lint.git","svn_url":"https://github.com/hcs0/pocket-lint","homepage":"https://launchpad.net/pocket-lint","size":2884,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"chevah:trunk","ref":"trunk","sha":"3c4f080b45bd084cb65a602cbfccfb9d2e73b526","user":{"login":"chevah","id":1153635,"avatar_url":"https://avatars2.githubusercontent.com/u/1153635?v=3","gravatar_id":"","url":"https://api.github.com/users/chevah","html_url":"https://github.com/chevah","followers_url":"https://api.github.com/users/chevah/followers","following_url":"https://api.github.com/users/chevah/following{/other_user}","gists_url":"https://api.github.com/users/chevah/gists{/gist_id}","starred_url":"https://api.github.com/users/chevah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevah/subscriptions","organizations_url":"https://api.github.com/users/chevah/orgs","repos_url":"https://api.github.com/users/chevah/repos","events_url":"https://api.github.com/users/chevah/events{/privacy}","received_events_url":"https://api.github.com/users/chevah/received_events","type":"Organization","site_admin":false},"repo":{"id":13883510,"name":"pocket-lint","full_name":"chevah/pocket-lint","owner":{"login":"chevah","id":1153635,"avatar_url":"https://avatars2.githubusercontent.com/u/1153635?v=3","gravatar_id":"","url":"https://api.github.com/users/chevah","html_url":"https://github.com/chevah","followers_url":"https://api.github.com/users/chevah/followers","following_url":"https://api.github.com/users/chevah/following{/other_user}","gists_url":"https://api.github.com/users/chevah/gists{/gist_id}","starred_url":"https://api.github.com/users/chevah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevah/subscriptions","organizations_url":"https://api.github.com/users/chevah/orgs","repos_url":"https://api.github.com/users/chevah/repos","events_url":"https://api.github.com/users/chevah/events{/privacy}","received_events_url":"https://api.github.com/users/chevah/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chevah/pocket-lint","description":"GitHub Mirror of pocket-lint","fork":false,"url":"https://api.github.com/repos/chevah/pocket-lint","forks_url":"https://api.github.com/repos/chevah/pocket-lint/forks","keys_url":"https://api.github.com/repos/chevah/pocket-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chevah/pocket-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chevah/pocket-lint/teams","hooks_url":"https://api.github.com/repos/chevah/pocket-lint/hooks","issue_events_url":"https://api.github.com/repos/chevah/pocket-lint/issues/events{/number}","events_url":"https://api.github.com/repos/chevah/pocket-lint/events","assignees_url":"https://api.github.com/repos/chevah/pocket-lint/assignees{/user}","branches_url":"https://api.github.com/repos/chevah/pocket-lint/branches{/branch}","tags_url":"https://api.github.com/repos/chevah/pocket-lint/tags","blobs_url":"https://api.github.com/repos/chevah/pocket-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chevah/pocket-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chevah/pocket-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/chevah/pocket-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chevah/pocket-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/chevah/pocket-lint/languages","stargazers_url":"https://api.github.com/repos/chevah/pocket-lint/stargazers","contributors_url":"https://api.github.com/repos/chevah/pocket-lint/contributors","subscribers_url":"https://api.github.com/repos/chevah/pocket-lint/subscribers","subscription_url":"https://api.github.com/repos/chevah/pocket-lint/subscription","commits_url":"https://api.github.com/repos/chevah/pocket-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/chevah/pocket-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/chevah/pocket-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/chevah/pocket-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/chevah/pocket-lint/contents/{+path}","compare_url":"https://api.github.com/repos/chevah/pocket-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chevah/pocket-lint/merges","archive_url":"https://api.github.com/repos/chevah/pocket-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chevah/pocket-lint/downloads","issues_url":"https://api.github.com/repos/chevah/pocket-lint/issues{/number}","pulls_url":"https://api.github.com/repos/chevah/pocket-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/chevah/pocket-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/chevah/pocket-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chevah/pocket-lint/labels{/name}","releases_url":"https://api.github.com/repos/chevah/pocket-lint/releases{/id}","deployments_url":"https://api.github.com/repos/chevah/pocket-lint/deployments","created_at":"2013-10-26T13:01:07Z","updated_at":"2017-05-06T08:56:44Z","pushed_at":"2017-05-06T00:24:06Z","git_url":"git://github.com/chevah/pocket-lint.git","ssh_url":"git@github.com:chevah/pocket-lint.git","clone_url":"https://github.com/chevah/pocket-lint.git","svn_url":"https://github.com/chevah/pocket-lint","homepage":"https://launchpad.net/pocket-lint","size":3352,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/chevah/pocket-lint/pulls/2"},"html":{"href":"https://github.com/chevah/pocket-lint/pull/2"},"issue":{"href":"https://api.github.com/repos/chevah/pocket-lint/issues/2"},"comments":{"href":"https://api.github.com/repos/chevah/pocket-lint/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/chevah/pocket-lint/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/chevah/pocket-lint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chevah/pocket-lint/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/chevah/pocket-lint/statuses/e34c3bafc1738c8984dc41969b99eccae50ced97"}}}}
{"actor":{"display_login":"adiroiban"}}