{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/122065037","pull_request_review_id":44148703,"id":122065037,"diff_hunk":"@@ -41,7 +41,7 @@\n      * Return a map from ACL bindings to futures which can be used to check the status of the creation of each ACL\n      * binding.\n      */\n-    public Map<AclBinding, KafkaFuture<Void>> results() {\n+    public Map<AclBinding, KafkaFuture<Void>> value() {","path":"clients/src/main/java/org/apache/kafka/clients/admin/CreateAclsResult.java","position":5,"original_position":5,"commit_id":"7f66ed25c20223f73fb3643606454a71bb004d05","original_commit_id":"faeadbad3f726625ac6beeaef3a7edcfe6190cb2","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars2.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"body":"For example, if you had a method which returned an array of message objects, you would probably call that `messages` rather than `message`, even though technically the array you returned is a single object.  The important thing is that that array contains multiple values.","created_at":"2017-06-14T21:08:04Z","updated_at":"2017-06-14T21:08:04Z","html_url":"https://github.com/apache/kafka/pull/3339#discussion_r122065037","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/3339","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/122065037"},"html":{"href":"https://github.com/apache/kafka/pull/3339#discussion_r122065037"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/3339"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/3339","id":125627675,"html_url":"https://github.com/apache/kafka/pull/3339","diff_url":"https://github.com/apache/kafka/pull/3339.diff","patch_url":"https://github.com/apache/kafka/pull/3339.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/3339","number":3339,"state":"open","locked":false,"title":"KAFKA-5275: AdminClient API consistency","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars1.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-14T15:37:40Z","updated_at":"2017-06-14T21:08:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf0ea04d376265ba82da50479916f5b431f4fa83","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/3339/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/3339/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/3339/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/7f66ed25c20223f73fb3643606454a71bb004d05","head":{"label":"ijuma:kafka-5275-admin-client-api-consistency","ref":"kafka-5275-admin-client-api-consistency","sha":"7f66ed25c20223f73fb3643606454a71bb004d05","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars1.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"repo":{"id":32646946,"name":"kafka","full_name":"ijuma/kafka","owner":{"login":"ijuma","id":24747,"avatar_url":"https://avatars1.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ijuma/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/ijuma/kafka","forks_url":"https://api.github.com/repos/ijuma/kafka/forks","keys_url":"https://api.github.com/repos/ijuma/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijuma/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijuma/kafka/teams","hooks_url":"https://api.github.com/repos/ijuma/kafka/hooks","issue_events_url":"https://api.github.com/repos/ijuma/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ijuma/kafka/events","assignees_url":"https://api.github.com/repos/ijuma/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ijuma/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ijuma/kafka/tags","blobs_url":"https://api.github.com/repos/ijuma/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijuma/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijuma/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijuma/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijuma/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ijuma/kafka/languages","stargazers_url":"https://api.github.com/repos/ijuma/kafka/stargazers","contributors_url":"https://api.github.com/repos/ijuma/kafka/contributors","subscribers_url":"https://api.github.com/repos/ijuma/kafka/subscribers","subscription_url":"https://api.github.com/repos/ijuma/kafka/subscription","commits_url":"https://api.github.com/repos/ijuma/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijuma/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijuma/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijuma/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijuma/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ijuma/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijuma/kafka/merges","archive_url":"https://api.github.com/repos/ijuma/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijuma/kafka/downloads","issues_url":"https://api.github.com/repos/ijuma/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ijuma/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ijuma/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ijuma/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijuma/kafka/labels{/name}","releases_url":"https://api.github.com/repos/ijuma/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/ijuma/kafka/deployments","created_at":"2015-03-21T19:33:59Z","updated_at":"2016-04-15T07:38:43Z","pushed_at":"2017-06-14T20:21:59Z","git_url":"git://github.com/ijuma/kafka.git","ssh_url":"git@github.com:ijuma/kafka.git","clone_url":"https://github.com/ijuma/kafka.git","svn_url":"https://github.com/ijuma/kafka","homepage":null,"size":52129,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"65e36895f5cf91afcf785857ebff4c0fce8d1d9c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-06-14T20:05:01Z","pushed_at":"2017-06-14T21:06:22Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":50817,"stargazers_count":5400,"watchers_count":5400,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3343,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":383,"forks":3343,"open_issues":383,"watchers":5400,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/3339"},"html":{"href":"https://github.com/apache/kafka/pull/3339"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/3339"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/3339/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/3339/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/3339/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/7f66ed25c20223f73fb3643606454a71bb004d05"}}}}
{"actor":{"display_login":"cmccabe"}}