{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/127865906","pull_request_review_id":50490576,"id":127865906,"diff_hunk":"@@ -155,7 +154,7 @@ uint32_t SceneUpdateContext::GenerateTextureIfNeeded(\n     return 0u;\n   }\n \n-  auto session_image_id = surface->GetSessionImageID();\n+  auto session_image_id = surface->image()->id();","path":"flow/scene_update_context.cc","position":null,"original_position":13,"commit_id":"e12166839b5f1e57c4f97821feae35aa07d0d1b3","original_commit_id":"e12166839b5f1e57c4f97821feae35aa07d0d1b3","user":{"login":"j9brown","id":102276,"avatar_url":"https://avatars1.githubusercontent.com/u/102276?v=4","gravatar_id":"","url":"https://api.github.com/users/j9brown","html_url":"https://github.com/j9brown","followers_url":"https://api.github.com/users/j9brown/followers","following_url":"https://api.github.com/users/j9brown/following{/other_user}","gists_url":"https://api.github.com/users/j9brown/gists{/gist_id}","starred_url":"https://api.github.com/users/j9brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j9brown/subscriptions","organizations_url":"https://api.github.com/users/j9brown/orgs","repos_url":"https://api.github.com/users/j9brown/repos","events_url":"https://api.github.com/users/j9brown/events{/privacy}","received_events_url":"https://api.github.com/users/j9brown/received_events","type":"User","site_admin":false},"body":"Return the Image* from this function instead.","created_at":"2017-07-18T01:38:01Z","updated_at":"2017-07-18T01:39:31Z","html_url":"https://github.com/flutter/engine/pull/3887#discussion_r127865906","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/3887","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/127865906"},"html":{"href":"https://github.com/flutter/engine/pull/3887#discussion_r127865906"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/3887"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/3887","id":130965960,"html_url":"https://github.com/flutter/engine/pull/3887","diff_url":"https://github.com/flutter/engine/pull/3887.diff","patch_url":"https://github.com/flutter/engine/pull/3887.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/3887","number":3887,"state":"open","locked":false,"title":"Update the content handler to use the Mozart session API.","user":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars1.githubusercontent.com/u/44085?v=4","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"body":"This patch contains the following commits from `chinmaygarde/flutter_engine/tree/session`.\r\n\r\n* Fix erroneous call to restoreToCount(0).\r\n* Always include child paint bounds in container layer.\r\n* Trace skia resource cache usage and bytes in available surfaces.\r\n* Add surface pool stats.\r\n* Fix the canvas clear operation that was removed due to an incorrect rebase.\r\n* Do a single flush with a idle wait.\r\n* Initial commit of the vulkan surface pool in the content handler.\r\n* Optimize texture creation for frames.\r\n* Use new view manager API.\r\n* We only need scale factors on Fuchsia.\r\n* Set the correct transformation for clipping.\r\n* Render at most one frame at a time, really.\r\n* Always draw full-sized shape textures.\r\n* Generate at most one texture per physical layer.\r\n* Only draw when needed.\r\n* Correctly save/restore the canvas state.\r\n* Rasterize images to the containing physical model layer.\r\n* Fix several issues related to paint bounds calculations.\r\n* Don't bother setting paint bounds when using system compositing.\r\n* Plum through hit testing behavior.\r\n* Implement child scene embedding.\r\n* Simplify propagation of session through the layers.\r\n* Use mozart::client::ContainerNode.\r\n* Only compile SceneUpdateContext for Fuchsia builds.\r\n* Remove unwanted dependencies.\r\n* WIP: Update flow layers to use the new Session interface.\r\n","created_at":"2017-07-17T22:30:16Z","updated_at":"2017-07-18T01:39:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"000300328bb1886938ab733aa9c961f9ebfff6e0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"konkers","id":90946,"avatar_url":"https://avatars0.githubusercontent.com/u/90946?v=4","gravatar_id":"","url":"https://api.github.com/users/konkers","html_url":"https://github.com/konkers","followers_url":"https://api.github.com/users/konkers/followers","following_url":"https://api.github.com/users/konkers/following{/other_user}","gists_url":"https://api.github.com/users/konkers/gists{/gist_id}","starred_url":"https://api.github.com/users/konkers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konkers/subscriptions","organizations_url":"https://api.github.com/users/konkers/orgs","repos_url":"https://api.github.com/users/konkers/repos","events_url":"https://api.github.com/users/konkers/events{/privacy}","received_events_url":"https://api.github.com/users/konkers/received_events","type":"User","site_admin":false},{"login":"abarth","id":112007,"avatar_url":"https://avatars3.githubusercontent.com/u/112007?v=4","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},{"login":"mikejurka","id":440407,"avatar_url":"https://avatars2.githubusercontent.com/u/440407?v=4","gravatar_id":"","url":"https://api.github.com/users/mikejurka","html_url":"https://github.com/mikejurka","followers_url":"https://api.github.com/users/mikejurka/followers","following_url":"https://api.github.com/users/mikejurka/following{/other_user}","gists_url":"https://api.github.com/users/mikejurka/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejurka/subscriptions","organizations_url":"https://api.github.com/users/mikejurka/orgs","repos_url":"https://api.github.com/users/mikejurka/repos","events_url":"https://api.github.com/users/mikejurka/events{/privacy}","received_events_url":"https://api.github.com/users/mikejurka/received_events","type":"User","site_admin":false},{"login":"schwa423","id":542548,"avatar_url":"https://avatars2.githubusercontent.com/u/542548?v=4","gravatar_id":"","url":"https://api.github.com/users/schwa423","html_url":"https://github.com/schwa423","followers_url":"https://api.github.com/users/schwa423/followers","following_url":"https://api.github.com/users/schwa423/following{/other_user}","gists_url":"https://api.github.com/users/schwa423/gists{/gist_id}","starred_url":"https://api.github.com/users/schwa423/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwa423/subscriptions","organizations_url":"https://api.github.com/users/schwa423/orgs","repos_url":"https://api.github.com/users/schwa423/repos","events_url":"https://api.github.com/users/schwa423/events{/privacy}","received_events_url":"https://api.github.com/users/schwa423/received_events","type":"User","site_admin":false},{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars3.githubusercontent.com/u/14226037?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},{"login":"freiling","id":15037099,"avatar_url":"https://avatars0.githubusercontent.com/u/15037099?v=4","gravatar_id":"","url":"https://api.github.com/users/freiling","html_url":"https://github.com/freiling","followers_url":"https://api.github.com/users/freiling/followers","following_url":"https://api.github.com/users/freiling/following{/other_user}","gists_url":"https://api.github.com/users/freiling/gists{/gist_id}","starred_url":"https://api.github.com/users/freiling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freiling/subscriptions","organizations_url":"https://api.github.com/users/freiling/orgs","repos_url":"https://api.github.com/users/freiling/repos","events_url":"https://api.github.com/users/freiling/events{/privacy}","received_events_url":"https://api.github.com/users/freiling/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/3887/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/3887/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/3887/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/e12166839b5f1e57c4f97821feae35aa07d0d1b3","head":{"label":"chinmaygarde:session_review","ref":"session_review","sha":"e12166839b5f1e57c4f97821feae35aa07d0d1b3","user":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars1.githubusercontent.com/u/44085?v=4","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"repo":{"id":39225162,"name":"flutter_engine","full_name":"chinmaygarde/flutter_engine","owner":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars1.githubusercontent.com/u/44085?v=4","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chinmaygarde/flutter_engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/chinmaygarde/flutter_engine","forks_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/forks","keys_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/teams","hooks_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/hooks","issue_events_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues/events{/number}","events_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/events","assignees_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/assignees{/user}","branches_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/branches{/branch}","tags_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/tags","blobs_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/languages","stargazers_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/stargazers","contributors_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/contributors","subscribers_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/subscribers","subscription_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/subscription","commits_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/contents/{+path}","compare_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/merges","archive_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/downloads","issues_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues{/number}","pulls_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/labels{/name}","releases_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/releases{/id}","deployments_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/deployments","created_at":"2015-07-16T23:24:34Z","updated_at":"2017-01-27T19:39:21Z","pushed_at":"2017-07-18T01:30:25Z","git_url":"git://github.com/chinmaygarde/flutter_engine.git","ssh_url":"git@github.com:chinmaygarde/flutter_engine.git","clone_url":"https://github.com/chinmaygarde/flutter_engine.git","svn_url":"https://github.com/chinmaygarde/flutter_engine","homepage":"","size":87667,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"03e642bc8940441bbad5c2fb7d3ca868c1fdad54","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2017-07-17T05:46:29Z","pushed_at":"2017-07-18T01:30:26Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":87594,"stargazers_count":1001,"watchers_count":1001,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":14,"forks":218,"open_issues":14,"watchers":1001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/3887"},"html":{"href":"https://github.com/flutter/engine/pull/3887"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/3887"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/3887/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/3887/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/3887/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/e12166839b5f1e57c4f97821feae35aa07d0d1b3"}}}}
{"actor":{"display_login":"j9brown"}}