{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/125526567","pull_request_review_id":47922939,"id":125526567,"diff_hunk":"@@ -1,13 +1,77 @@\n-all: push\n+# Copyright 2017 The Kubernetes Authors. All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n \n-test-webserver: test-webserver.go\n-\tCGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -ldflags '-w' ./test-webserver.go\n+.PHONY: all all-container all-push all-push clean\n \n-container: test-webserver\n-\tsudo docker build --pull -t gcr.io/google_containers/test-webserver .\n+TAG ?= e2e\n \n-push: container\n-\tgcloud docker -- push gcr.io/google_containers/test-webserver\n+REGISTRY ?= gcr.io/google-containers\n+TEST_REGISTRY ?= gcr.io/k8s-authenticated-test","path":"for-demos/test-webserver/Makefile","position":27,"original_position":27,"commit_id":"776ced30c40558a6b71fb957bd986bfcc48fd14b","original_commit_id":"776ced30c40558a6b71fb957bd986bfcc48fd14b","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars2.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"@ixdy Do we even need this code? I don't think so.","created_at":"2017-07-04T20:22:50Z","updated_at":"2017-07-04T20:23:43Z","html_url":"https://github.com/kubernetes/contrib/pull/2544#discussion_r125526567","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2544","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/125526567"},"html":{"href":"https://github.com/kubernetes/contrib/pull/2544#discussion_r125526567"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2544"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/2544","id":115491229,"html_url":"https://github.com/kubernetes/contrib/pull/2544","diff_url":"https://github.com/kubernetes/contrib/pull/2544.diff","patch_url":"https://github.com/kubernetes/contrib/pull/2544.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/2544","number":2544,"state":"open","locked":false,"title":"Multi architecture test-webserver image","user":{"login":"mkumatag","id":12646029,"avatar_url":"https://avatars3.githubusercontent.com/u/12646029?v=3","gravatar_id":"","url":"https://api.github.com/users/mkumatag","html_url":"https://github.com/mkumatag","followers_url":"https://api.github.com/users/mkumatag/followers","following_url":"https://api.github.com/users/mkumatag/following{/other_user}","gists_url":"https://api.github.com/users/mkumatag/gists{/gist_id}","starred_url":"https://api.github.com/users/mkumatag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkumatag/subscriptions","organizations_url":"https://api.github.com/users/mkumatag/orgs","repos_url":"https://api.github.com/users/mkumatag/repos","events_url":"https://api.github.com/users/mkumatag/events{/privacy}","received_events_url":"https://api.github.com/users/mkumatag/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Manjunath A Kumatagi <mkumatag@in.ibm.com>\r\n\r\nThis PR will enable to build test-webserver image for different architecture like amd64, ppc64le, arm etc..","created_at":"2017-04-12T08:44:21Z","updated_at":"2017-07-04T20:23:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d80761c0e312d7795b729c29a3501776122dbe1","assignee":{"login":"eparis","id":8093535,"avatar_url":"https://avatars0.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"assignees":[{"login":"eparis","id":8093535,"avatar_url":"https://avatars0.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars3.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},{"login":"eparis","id":8093535,"avatar_url":"https://avatars0.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2544/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/2544/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/2544/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/776ced30c40558a6b71fb957bd986bfcc48fd14b","head":{"label":"mkumatag:multi_arch_image","ref":"multi_arch_image","sha":"776ced30c40558a6b71fb957bd986bfcc48fd14b","user":{"login":"mkumatag","id":12646029,"avatar_url":"https://avatars3.githubusercontent.com/u/12646029?v=3","gravatar_id":"","url":"https://api.github.com/users/mkumatag","html_url":"https://github.com/mkumatag","followers_url":"https://api.github.com/users/mkumatag/followers","following_url":"https://api.github.com/users/mkumatag/following{/other_user}","gists_url":"https://api.github.com/users/mkumatag/gists{/gist_id}","starred_url":"https://api.github.com/users/mkumatag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkumatag/subscriptions","organizations_url":"https://api.github.com/users/mkumatag/orgs","repos_url":"https://api.github.com/users/mkumatag/repos","events_url":"https://api.github.com/users/mkumatag/events{/privacy}","received_events_url":"https://api.github.com/users/mkumatag/received_events","type":"User","site_admin":false},"repo":{"id":67490629,"name":"contrib","full_name":"mkumatag/contrib","owner":{"login":"mkumatag","id":12646029,"avatar_url":"https://avatars3.githubusercontent.com/u/12646029?v=3","gravatar_id":"","url":"https://api.github.com/users/mkumatag","html_url":"https://github.com/mkumatag","followers_url":"https://api.github.com/users/mkumatag/followers","following_url":"https://api.github.com/users/mkumatag/following{/other_user}","gists_url":"https://api.github.com/users/mkumatag/gists{/gist_id}","starred_url":"https://api.github.com/users/mkumatag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkumatag/subscriptions","organizations_url":"https://api.github.com/users/mkumatag/orgs","repos_url":"https://api.github.com/users/mkumatag/repos","events_url":"https://api.github.com/users/mkumatag/events{/privacy}","received_events_url":"https://api.github.com/users/mkumatag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkumatag/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":true,"url":"https://api.github.com/repos/mkumatag/contrib","forks_url":"https://api.github.com/repos/mkumatag/contrib/forks","keys_url":"https://api.github.com/repos/mkumatag/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkumatag/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkumatag/contrib/teams","hooks_url":"https://api.github.com/repos/mkumatag/contrib/hooks","issue_events_url":"https://api.github.com/repos/mkumatag/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/mkumatag/contrib/events","assignees_url":"https://api.github.com/repos/mkumatag/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/mkumatag/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/mkumatag/contrib/tags","blobs_url":"https://api.github.com/repos/mkumatag/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkumatag/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkumatag/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkumatag/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkumatag/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/mkumatag/contrib/languages","stargazers_url":"https://api.github.com/repos/mkumatag/contrib/stargazers","contributors_url":"https://api.github.com/repos/mkumatag/contrib/contributors","subscribers_url":"https://api.github.com/repos/mkumatag/contrib/subscribers","subscription_url":"https://api.github.com/repos/mkumatag/contrib/subscription","commits_url":"https://api.github.com/repos/mkumatag/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkumatag/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkumatag/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkumatag/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkumatag/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/mkumatag/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkumatag/contrib/merges","archive_url":"https://api.github.com/repos/mkumatag/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkumatag/contrib/downloads","issues_url":"https://api.github.com/repos/mkumatag/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/mkumatag/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/mkumatag/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/mkumatag/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkumatag/contrib/labels{/name}","releases_url":"https://api.github.com/repos/mkumatag/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/mkumatag/contrib/deployments","created_at":"2016-09-06T08:47:27Z","updated_at":"2016-09-06T08:47:31Z","pushed_at":"2017-06-11T11:05:16Z","git_url":"git://github.com/mkumatag/contrib.git","ssh_url":"git@github.com:mkumatag/contrib.git","clone_url":"https://github.com/mkumatag/contrib.git","svn_url":"https://github.com/mkumatag/contrib","homepage":"","size":47966,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"bd74e4acd8cd336d04f10d23c1936bcd10f4c77c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2017-07-04T16:50:57Z","pushed_at":"2017-07-03T07:46:38Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":83932,"stargazers_count":1106,"watchers_count":1106,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1025,"mirror_url":null,"open_issues_count":398,"forks":1025,"open_issues":398,"watchers":1106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2544"},"html":{"href":"https://github.com/kubernetes/contrib/pull/2544"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/2544"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/2544/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2544/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/2544/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/776ced30c40558a6b71fb957bd986bfcc48fd14b"}}}}
{"actor":{"display_login":"luxas"}}