{"action":"created","comment":{"url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/comments/144466190","pull_request_review_id":69125879,"id":144466190,"diff_hunk":"@@ -89,28 +97,24 @@ class BasicDataBridge(object):\n \n     def __init__(self, config):\n         super(BasicDataBridge, self).__init__()\n-        self.config = config\n+        DEFAULTS.update(config['main'])","path":"openprocurement/bridge/basic/databridge.py","position":126,"original_position":126,"commit_id":"c913d8d7de5f334db719263fc84aac08ab54f85c","original_commit_id":"c913d8d7de5f334db719263fc84aac08ab54f85c","user":{"login":"VDigitall","id":6977678,"avatar_url":"https://avatars1.githubusercontent.com/u/6977678?v=4","gravatar_id":"","url":"https://api.github.com/users/VDigitall","html_url":"https://github.com/VDigitall","followers_url":"https://api.github.com/users/VDigitall/followers","following_url":"https://api.github.com/users/VDigitall/following{/other_user}","gists_url":"https://api.github.com/users/VDigitall/gists{/gist_id}","starred_url":"https://api.github.com/users/VDigitall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDigitall/subscriptions","organizations_url":"https://api.github.com/users/VDigitall/orgs","repos_url":"https://api.github.com/users/VDigitall/repos","events_url":"https://api.github.com/users/VDigitall/events{/privacy}","received_events_url":"https://api.github.com/users/VDigitall/received_events","type":"User","site_admin":false},"body":"Ідея така що, всі обовязкові параметри які необхідні для роботи моста, знаходяться у словнику `DEFAULTS` i якщо ми змінною `config` принесемо значення відмінні від дефолтних то ними оновляться дефолтні і не потрібно буде робити додаткового `get` \r\n```\r\nfor key in DEFAULTS:\r\n    setattr(self, key, self.config.get(key, DEFAULTS[key]))\r\n```\r\nтому що кожен ключ завжди має значення","created_at":"2017-10-13T04:58:51Z","updated_at":"2017-10-13T04:58:51Z","html_url":"https://github.com/openprocurement/openprocurement.bridge.basic/pull/2#discussion_r144466190","pull_request_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/comments/144466190"},"html":{"href":"https://github.com/openprocurement/openprocurement.bridge.basic/pull/2#discussion_r144466190"},"pull_request":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2"}},"in_reply_to_id":144293970},"pull_request":{"url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2","id":145634395,"html_url":"https://github.com/openprocurement/openprocurement.bridge.basic/pull/2","diff_url":"https://github.com/openprocurement/openprocurement.bridge.basic/pull/2.diff","patch_url":"https://github.com/openprocurement/openprocurement.bridge.basic/pull/2.patch","issue_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/issues/2","number":2,"state":"open","locked":false,"title":"Add brigde storage plugins support","user":{"login":"VDigitall","id":6977678,"avatar_url":"https://avatars1.githubusercontent.com/u/6977678?v=4","gravatar_id":"","url":"https://api.github.com/users/VDigitall","html_url":"https://github.com/VDigitall","followers_url":"https://api.github.com/users/VDigitall/followers","following_url":"https://api.github.com/users/VDigitall/following{/other_user}","gists_url":"https://api.github.com/users/VDigitall/gists{/gist_id}","starred_url":"https://api.github.com/users/VDigitall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDigitall/subscriptions","organizations_url":"https://api.github.com/users/VDigitall/orgs","repos_url":"https://api.github.com/users/VDigitall/repos","events_url":"https://api.github.com/users/VDigitall/events{/privacy}","received_events_url":"https://api.github.com/users/VDigitall/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-10T09:00:02Z","updated_at":"2017-10-13T04:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27ed370987fc0f17e289ec14eff29bfa43a2ddb7","assignee":{"login":"Leits","id":12017826,"avatar_url":"https://avatars0.githubusercontent.com/u/12017826?v=4","gravatar_id":"","url":"https://api.github.com/users/Leits","html_url":"https://github.com/Leits","followers_url":"https://api.github.com/users/Leits/followers","following_url":"https://api.github.com/users/Leits/following{/other_user}","gists_url":"https://api.github.com/users/Leits/gists{/gist_id}","starred_url":"https://api.github.com/users/Leits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leits/subscriptions","organizations_url":"https://api.github.com/users/Leits/orgs","repos_url":"https://api.github.com/users/Leits/repos","events_url":"https://api.github.com/users/Leits/events{/privacy}","received_events_url":"https://api.github.com/users/Leits/received_events","type":"User","site_admin":false},"assignees":[{"login":"Leits","id":12017826,"avatar_url":"https://avatars0.githubusercontent.com/u/12017826?v=4","gravatar_id":"","url":"https://api.github.com/users/Leits","html_url":"https://github.com/Leits","followers_url":"https://api.github.com/users/Leits/followers","following_url":"https://api.github.com/users/Leits/following{/other_user}","gists_url":"https://api.github.com/users/Leits/gists{/gist_id}","starred_url":"https://api.github.com/users/Leits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leits/subscriptions","organizations_url":"https://api.github.com/users/Leits/orgs","repos_url":"https://api.github.com/users/Leits/repos","events_url":"https://api.github.com/users/Leits/events{/privacy}","received_events_url":"https://api.github.com/users/Leits/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2/commits","review_comments_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2/comments","review_comment_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/issues/2/comments","statuses_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/statuses/c913d8d7de5f334db719263fc84aac08ab54f85c","head":{"label":"VDigitall:master","ref":"master","sha":"c913d8d7de5f334db719263fc84aac08ab54f85c","user":{"login":"VDigitall","id":6977678,"avatar_url":"https://avatars1.githubusercontent.com/u/6977678?v=4","gravatar_id":"","url":"https://api.github.com/users/VDigitall","html_url":"https://github.com/VDigitall","followers_url":"https://api.github.com/users/VDigitall/followers","following_url":"https://api.github.com/users/VDigitall/following{/other_user}","gists_url":"https://api.github.com/users/VDigitall/gists{/gist_id}","starred_url":"https://api.github.com/users/VDigitall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDigitall/subscriptions","organizations_url":"https://api.github.com/users/VDigitall/orgs","repos_url":"https://api.github.com/users/VDigitall/repos","events_url":"https://api.github.com/users/VDigitall/events{/privacy}","received_events_url":"https://api.github.com/users/VDigitall/received_events","type":"User","site_admin":false},"repo":{"id":106378009,"name":"openprocurement.bridge.basic","full_name":"VDigitall/openprocurement.bridge.basic","owner":{"login":"VDigitall","id":6977678,"avatar_url":"https://avatars1.githubusercontent.com/u/6977678?v=4","gravatar_id":"","url":"https://api.github.com/users/VDigitall","html_url":"https://github.com/VDigitall","followers_url":"https://api.github.com/users/VDigitall/followers","following_url":"https://api.github.com/users/VDigitall/following{/other_user}","gists_url":"https://api.github.com/users/VDigitall/gists{/gist_id}","starred_url":"https://api.github.com/users/VDigitall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDigitall/subscriptions","organizations_url":"https://api.github.com/users/VDigitall/orgs","repos_url":"https://api.github.com/users/VDigitall/repos","events_url":"https://api.github.com/users/VDigitall/events{/privacy}","received_events_url":"https://api.github.com/users/VDigitall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VDigitall/openprocurement.bridge.basic","description":null,"fork":true,"url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic","forks_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/forks","keys_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/teams","hooks_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/hooks","issue_events_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/issues/events{/number}","events_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/events","assignees_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/assignees{/user}","branches_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/branches{/branch}","tags_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/tags","blobs_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/git/refs{/sha}","trees_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/statuses/{sha}","languages_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/languages","stargazers_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/stargazers","contributors_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/contributors","subscribers_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/subscribers","subscription_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/subscription","commits_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/commits{/sha}","git_commits_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/git/commits{/sha}","comments_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/comments{/number}","issue_comment_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/issues/comments{/number}","contents_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/contents/{+path}","compare_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/merges","archive_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/downloads","issues_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/issues{/number}","pulls_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/pulls{/number}","milestones_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/milestones{/number}","notifications_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/labels{/name}","releases_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/releases{/id}","deployments_url":"https://api.github.com/repos/VDigitall/openprocurement.bridge.basic/deployments","created_at":"2017-10-10T06:37:49Z","updated_at":"2017-10-10T06:37:51Z","pushed_at":"2017-10-12T13:30:20Z","git_url":"git://github.com/VDigitall/openprocurement.bridge.basic.git","ssh_url":"git@github.com:VDigitall/openprocurement.bridge.basic.git","clone_url":"https://github.com/VDigitall/openprocurement.bridge.basic.git","svn_url":"https://github.com/VDigitall/openprocurement.bridge.basic","homepage":null,"size":64,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openprocurement:master","ref":"master","sha":"3068a376538ea0ac90e6f5a93a3e7cdb6b1b6f0b","user":{"login":"openprocurement","id":8692431,"avatar_url":"https://avatars2.githubusercontent.com/u/8692431?v=4","gravatar_id":"","url":"https://api.github.com/users/openprocurement","html_url":"https://github.com/openprocurement","followers_url":"https://api.github.com/users/openprocurement/followers","following_url":"https://api.github.com/users/openprocurement/following{/other_user}","gists_url":"https://api.github.com/users/openprocurement/gists{/gist_id}","starred_url":"https://api.github.com/users/openprocurement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openprocurement/subscriptions","organizations_url":"https://api.github.com/users/openprocurement/orgs","repos_url":"https://api.github.com/users/openprocurement/repos","events_url":"https://api.github.com/users/openprocurement/events{/privacy}","received_events_url":"https://api.github.com/users/openprocurement/received_events","type":"Organization","site_admin":false},"repo":{"id":102836708,"name":"openprocurement.bridge.basic","full_name":"openprocurement/openprocurement.bridge.basic","owner":{"login":"openprocurement","id":8692431,"avatar_url":"https://avatars2.githubusercontent.com/u/8692431?v=4","gravatar_id":"","url":"https://api.github.com/users/openprocurement","html_url":"https://github.com/openprocurement","followers_url":"https://api.github.com/users/openprocurement/followers","following_url":"https://api.github.com/users/openprocurement/following{/other_user}","gists_url":"https://api.github.com/users/openprocurement/gists{/gist_id}","starred_url":"https://api.github.com/users/openprocurement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openprocurement/subscriptions","organizations_url":"https://api.github.com/users/openprocurement/orgs","repos_url":"https://api.github.com/users/openprocurement/repos","events_url":"https://api.github.com/users/openprocurement/events{/privacy}","received_events_url":"https://api.github.com/users/openprocurement/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openprocurement/openprocurement.bridge.basic","description":null,"fork":false,"url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic","forks_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/forks","keys_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/teams","hooks_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/hooks","issue_events_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/issues/events{/number}","events_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/events","assignees_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/assignees{/user}","branches_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/branches{/branch}","tags_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/tags","blobs_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/git/refs{/sha}","trees_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/statuses/{sha}","languages_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/languages","stargazers_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/stargazers","contributors_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/contributors","subscribers_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/subscribers","subscription_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/subscription","commits_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/commits{/sha}","git_commits_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/git/commits{/sha}","comments_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/comments{/number}","issue_comment_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/issues/comments{/number}","contents_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/contents/{+path}","compare_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/merges","archive_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/downloads","issues_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/issues{/number}","pulls_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls{/number}","milestones_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/milestones{/number}","notifications_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/labels{/name}","releases_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/releases{/id}","deployments_url":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/deployments","created_at":"2017-09-08T08:15:32Z","updated_at":"2017-09-08T08:28:25Z","pushed_at":"2017-10-12T13:30:22Z","git_url":"git://github.com/openprocurement/openprocurement.bridge.basic.git","ssh_url":"git@github.com:openprocurement/openprocurement.bridge.basic.git","clone_url":"https://github.com/openprocurement/openprocurement.bridge.basic.git","svn_url":"https://github.com/openprocurement/openprocurement.bridge.basic","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2"},"html":{"href":"https://github.com/openprocurement/openprocurement.bridge.basic/pull/2"},"issue":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/issues/2"},"comments":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/openprocurement/openprocurement.bridge.basic/statuses/c913d8d7de5f334db719263fc84aac08ab54f85c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"VDigitall"}}