{"action":"created","issue":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/143","repository_url":"https://api.github.com/repos/sillsdev/web-languageforge","labels_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/143/comments","events_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/143/events","html_url":"https://github.com/sillsdev/web-languageforge/pull/143","id":245348730,"number":143,"title":"New feature: can hide other users' responses","user":{"login":"rmunn","id":90762,"avatar_url":"https://avatars2.githubusercontent.com/u/90762?v=4","gravatar_id":"","url":"https://api.github.com/users/rmunn","html_url":"https://github.com/rmunn","followers_url":"https://api.github.com/users/rmunn/followers","following_url":"https://api.github.com/users/rmunn/following{/other_user}","gists_url":"https://api.github.com/users/rmunn/gists{/gist_id}","starred_url":"https://api.github.com/users/rmunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmunn/subscriptions","organizations_url":"https://api.github.com/users/rmunn/orgs","repos_url":"https://api.github.com/users/rmunn/repos","events_url":"https://api.github.com/users/rmunn/events{/privacy}","received_events_url":"https://api.github.com/users/rmunn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-07-25T09:59:14Z","updated_at":"2017-07-27T03:30:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/143","html_url":"https://github.com/sillsdev/web-languageforge/pull/143","diff_url":"https://github.com/sillsdev/web-languageforge/pull/143.diff","patch_url":"https://github.com/sillsdev/web-languageforge/pull/143.patch"},"body":"This adds a project setting, \"users can see each others' answers\", which defaults to ON (true). If turned off, then users will only be able to see their own responses (answers and comments) in the question view and in response counts. Other users' responses will also be hidden in the activity view, since otherwise this could become a \"back door\" way of seeing what other users have responded.\r\n\r\nAlso, if a project used to allow users to see (and therefore comment on) each others' answers, and then the setting is turned off, users will no longer be able to see the comments they had previously left on other users' answers.\r\n\r\nThis feature includes a migration script to add this setting to all projects that don't have it already, setting it to \"true\" so that existing projects will have their current behavior unchanged.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sillsdev/web-languageforge/143)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/comments/318248875","html_url":"https://github.com/sillsdev/web-languageforge/pull/143#issuecomment-318248875","issue_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/143","id":318248875,"user":{"login":"rmunn","id":90762,"avatar_url":"https://avatars2.githubusercontent.com/u/90762?v=4","gravatar_id":"","url":"https://api.github.com/users/rmunn","html_url":"https://github.com/rmunn","followers_url":"https://api.github.com/users/rmunn/followers","following_url":"https://api.github.com/users/rmunn/following{/other_user}","gists_url":"https://api.github.com/users/rmunn/gists{/gist_id}","starred_url":"https://api.github.com/users/rmunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmunn/subscriptions","organizations_url":"https://api.github.com/users/rmunn/orgs","repos_url":"https://api.github.com/users/rmunn/repos","events_url":"https://api.github.com/users/rmunn/events{/privacy}","received_events_url":"https://api.github.com/users/rmunn/received_events","type":"User","site_admin":false},"created_at":"2017-07-27T03:30:52Z","updated_at":"2017-07-27T03:30:52Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 19 unresolved discussions.\n\n---\n\n*[src/Api/Model/Scriptureforge/Sfchecks/SfchecksProjectModel.php, line 29 at r1](https://reviewable.io:443/reviews/sillsdev/web-languageforge/143#-KpxfHj0LZm0V62IY9wD:-Kq14CXgUQ-fuvt1F44_:b-1lyi2z) ([raw file](https://github.com/sillsdev/web-languageforge/blob/b16d8257181fb9b90b925f66c30de8cd4607f8b2/src/Api/Model/Scriptureforge/Sfchecks/SfchecksProjectModel.php#L29)):*\n<details><summary><i>Previously, irahopkinson (Ira Hopkinson) wrote…</i></summary><blockquote>\n\nIf this property was **usersOnlySeeOwnResponses** then I think migration would not be necessary.\n</blockquote></details>\n\nChris and I discussed what the name of the feature should be, and decided that \"users can see each others' responses\" was a better name for the setting -- and that it would be less confusing overall to have the setting name in Mongo be the same wording as what the project managers see in the Project Settings view.\n\nSo for this one review, I'll say \"[stet](https://en.wikipedia.org/wiki/Stet)\".\n\n---\n\n*[test/php/model/scriptureforge/Sfchecks/command/QuestionCommandsTest.php, line 212 at r1](https://reviewable.io:443/reviews/sillsdev/web-languageforge/143#-KpyHvUhrNG_WvXoLwDd:-Kq14pPldADIrNthmF2-:b-vxv09w) ([raw file](https://github.com/sillsdev/web-languageforge/blob/b16d8257181fb9b90b925f66c30de8cd4607f8b2/test/php/model/scriptureforge/Sfchecks/command/QuestionCommandsTest.php#L212)):*\n<details><summary><i>Previously, irahopkinson (Ira Hopkinson) wrote…</i></summary><blockquote>\n\nUserVoteTestEnvironment should inherit from MongoTestEnvironment then you don't need two $environs. I realise the code was already like that.\n</blockquote></details>\n\nI think I'll defer this one change to a future PR, so that I don't get bogged down in OO design. (Does UserVoteTestEnvironment get used elsewhere? What are the implications of changing its inheritance structure? These questions might take me a little while to answer). It's a good suggestion, but I think I'd like to call it out-of-scope for this particular PR and do it later.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/sillsdev/web-languageforge/143)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"rmunn"}}