{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/11449","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/11449/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/11449/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/11449/events","html_url":"https://github.com/nodejs/node/pull/11449","id":208586847,"number":11449,"title":"test: print call checks when a test times out","user":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars2.githubusercontent.com/u/1084056?v=4","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"labels":[{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false},{"id":237979054,"url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-02-17T23:42:16Z","updated_at":"2017-10-02T11:24:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/11449","html_url":"https://github.com/nodejs/node/pull/11449","diff_url":"https://github.com/nodejs/node/pull/11449.diff","patch_url":"https://github.com/nodejs/node/pull/11449.patch"},"body":"The `mustCall` failures when a test times out are not printed because\r\nthe test runner kills the node process, so the `runCallChecks` never\r\nprints anything. This failures can provide very useful information when\r\ninvestigating flaky tests.\r\nOne solution could be adding a signal handler, but this solution would\r\nnot work on `Windows`.\r\nAnother option, implemented in this commit, is creating a pipe between\r\nthe test runner and the test process so when the test runner considers\r\nthat a test has timed out, it sends a message to the test process using\r\nthis pipe so it can exit gracefully printing the `mustCall` failures.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/333507328","html_url":"https://github.com/nodejs/node/pull/11449#issuecomment-333507328","issue_url":"https://api.github.com/repos/nodejs/node/issues/11449","id":333507328,"user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"created_at":"2017-10-02T11:24:19Z","updated_at":"2017-10-02T11:24:19Z","author_association":"MEMBER","body":"@nodejs/collaborators this needs some LGs. The PR is around since February without much attention.\r\n\r\n@santigimeno would you be so kind and rebase this?"}}
{"actor":{"display_login":"BridgeAR"}}