{"action":"opened","number":420,"pull_request":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/420","id":136507336,"html_url":"https://github.com/blockchain/My-Wallet-V3/pull/420","diff_url":"https://github.com/blockchain/My-Wallet-V3/pull/420.diff","patch_url":"https://github.com/blockchain/My-Wallet-V3/pull/420.patch","issue_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/420","number":420,"state":"open","locked":false,"title":"StableSocket","user":{"login":"jtormey","id":8642682,"avatar_url":"https://avatars3.githubusercontent.com/u/8642682?v=4","gravatar_id":"","url":"https://api.github.com/users/jtormey","html_url":"https://github.com/jtormey","followers_url":"https://api.github.com/users/jtormey/followers","following_url":"https://api.github.com/users/jtormey/following{/other_user}","gists_url":"https://api.github.com/users/jtormey/gists{/gist_id}","starred_url":"https://api.github.com/users/jtormey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtormey/subscriptions","organizations_url":"https://api.github.com/users/jtormey/orgs","repos_url":"https://api.github.com/users/jtormey/repos","events_url":"https://api.github.com/users/jtormey/events{/privacy}","received_events_url":"https://api.github.com/users/jtormey/received_events","type":"User","site_admin":false},"body":"Moves ping / reconnect logic into StableSocket, which both BlockchainSocket and EthSocket extend from. This will make adding new, reliable sockets very easy. All child sockets need to do is implement static methods for constructing message payloads and decide how to handle incoming messages.","created_at":"2017-08-18T15:34:53Z","updated_at":"2017-08-18T15:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"mpfluger","id":4841563,"avatar_url":"https://avatars1.githubusercontent.com/u/4841563?v=4","gravatar_id":"","url":"https://api.github.com/users/mpfluger","html_url":"https://github.com/mpfluger","followers_url":"https://api.github.com/users/mpfluger/followers","following_url":"https://api.github.com/users/mpfluger/following{/other_user}","gists_url":"https://api.github.com/users/mpfluger/gists{/gist_id}","starred_url":"https://api.github.com/users/mpfluger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpfluger/subscriptions","organizations_url":"https://api.github.com/users/mpfluger/orgs","repos_url":"https://api.github.com/users/mpfluger/repos","events_url":"https://api.github.com/users/mpfluger/events{/privacy}","received_events_url":"https://api.github.com/users/mpfluger/received_events","type":"User","site_admin":false},{"login":"pernas","id":6686893,"avatar_url":"https://avatars3.githubusercontent.com/u/6686893?v=4","gravatar_id":"","url":"https://api.github.com/users/pernas","html_url":"https://github.com/pernas","followers_url":"https://api.github.com/users/pernas/followers","following_url":"https://api.github.com/users/pernas/following{/other_user}","gists_url":"https://api.github.com/users/pernas/gists{/gist_id}","starred_url":"https://api.github.com/users/pernas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pernas/subscriptions","organizations_url":"https://api.github.com/users/pernas/orgs","repos_url":"https://api.github.com/users/pernas/repos","events_url":"https://api.github.com/users/pernas/events{/privacy}","received_events_url":"https://api.github.com/users/pernas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/420/commits","review_comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/420/comments","review_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/420/comments","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/statuses/10a67b4adb82794675be56d0225a49861a849358","head":{"label":"blockchain:improve-socket","ref":"improve-socket","sha":"10a67b4adb82794675be56d0225a49861a849358","user":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":24322737,"name":"My-Wallet-V3","full_name":"blockchain/My-Wallet-V3","owner":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3","description":"Blockchain Wallet - https://support.blockchain.com","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/deployments","created_at":"2014-09-22T09:38:24Z","updated_at":"2017-08-17T16:27:59Z","pushed_at":"2017-08-18T15:31:32Z","git_url":"git://github.com/blockchain/My-Wallet-V3.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3.git","clone_url":"https://github.com/blockchain/My-Wallet-V3.git","svn_url":"https://github.com/blockchain/My-Wallet-V3","homepage":"","size":6245,"stargazers_count":142,"watchers_count":142,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":8,"forks":135,"open_issues":8,"watchers":142,"default_branch":"master"}},"base":{"label":"blockchain:v3.34-release","ref":"v3.34-release","sha":"9a38a374c767c9fecbf2568eb0eb7880a8395fb9","user":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":24322737,"name":"My-Wallet-V3","full_name":"blockchain/My-Wallet-V3","owner":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/My-Wallet-V3","description":"Blockchain Wallet - https://support.blockchain.com","fork":false,"url":"https://api.github.com/repos/blockchain/My-Wallet-V3","forks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/forks","keys_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/teams","hooks_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/hooks","issue_events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/events","assignees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/tags","blobs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/languages","stargazers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/stargazers","contributors_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/contributors","subscribers_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/subscribers","subscription_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/subscription","commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/merges","archive_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/downloads","issues_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3/deployments","created_at":"2014-09-22T09:38:24Z","updated_at":"2017-08-17T16:27:59Z","pushed_at":"2017-08-18T15:31:32Z","git_url":"git://github.com/blockchain/My-Wallet-V3.git","ssh_url":"git@github.com:blockchain/My-Wallet-V3.git","clone_url":"https://github.com/blockchain/My-Wallet-V3.git","svn_url":"https://github.com/blockchain/My-Wallet-V3","homepage":"","size":6245,"stargazers_count":142,"watchers_count":142,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":8,"forks":135,"open_issues":8,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/420"},"html":{"href":"https://github.com/blockchain/My-Wallet-V3/pull/420"},"issue":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/420"},"comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/blockchain/My-Wallet-V3/statuses/10a67b4adb82794675be56d0225a49861a849358"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":463,"deletions":272,"changed_files":11}}
{"actor":{"display_login":"jtormey"}}