{"action":"closed","number":11377,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/11377","id":102897225,"html_url":"https://github.com/hashicorp/terraform/pull/11377","diff_url":"https://github.com/hashicorp/terraform/pull/11377.diff","patch_url":"https://github.com/hashicorp/terraform/pull/11377.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/11377","number":11377,"state":"closed","locked":false,"title":"provider/aws: Fix acceptance tests w/ missing values","user":{"login":"radeksimko","id":287584,"avatar_url":"https://avatars.githubusercontent.com/u/287584?v=3","gravatar_id":"","url":"https://api.github.com/users/radeksimko","html_url":"https://github.com/radeksimko","followers_url":"https://api.github.com/users/radeksimko/followers","following_url":"https://api.github.com/users/radeksimko/following{/other_user}","gists_url":"https://api.github.com/users/radeksimko/gists{/gist_id}","starred_url":"https://api.github.com/users/radeksimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeksimko/subscriptions","organizations_url":"https://api.github.com/users/radeksimko/orgs","repos_url":"https://api.github.com/users/radeksimko/repos","events_url":"https://api.github.com/users/radeksimko/events{/privacy}","received_events_url":"https://api.github.com/users/radeksimko/received_events","type":"User","site_admin":false},"body":"```\r\n$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=\"(AWSAPIGatewayIntegration_basic|AWSAPIGatewayRestApi_basic|AWSAPIGatewayIntegrat\r\nionResponse_basic|AWSAutoScalingGroup_enablingMetrics|AWSCodeCommitRepository_create_and_update_default_branch|AWSAccessKey_encrypted|AWSKinesisStream_shardLevelMetrics|AWSLambdaFunction_envVariables|AWSLightsailKeyPair_imported|AWSLightsailKeyPair_encrypted|AWSS3Bucket_basic)\"'\r\n```\r\n```\r\n==> Checking that code complies with gofmt requirements...\r\ngo generate $(go list ./... | grep -v /terraform/vendor/)\r\n2017/01/24 10:52:50 Generated command/internal_plugin_list.go\r\nTF_ACC=1 go test ./builtin/providers/aws -v -run=\"(AWSAPIGatewayIntegration_basic|AWSAPIGatewayRestApi_basic|AWSAPIGatewayIntegrationResponse_basic|AWSAutoScalingGroup_enablingMetrics|AWSCodeCommitRepository_create_and_update_default_branch|AWSAccessKey_encrypted|AWSKinesisStream_shardLevelMetrics|AWSLambdaFunction_envVariables|AWSLightsailKeyPair_imported|AWSLightsailKeyPair_encrypted|AWSS3Bucket_basic)\" -timeout 120m\r\n=== RUN   TestAccAWSAPIGatewayIntegrationResponse_basic\r\n--- PASS: TestAccAWSAPIGatewayIntegrationResponse_basic (53.14s)\r\n=== RUN   TestAccAWSAPIGatewayIntegration_basic\r\n--- PASS: TestAccAWSAPIGatewayIntegration_basic (46.95s)\r\n=== RUN   TestAccAWSAPIGatewayRestApi_basic\r\n--- PASS: TestAccAWSAPIGatewayRestApi_basic (44.05s)\r\n=== RUN   TestAccAWSAutoScalingGroup_enablingMetrics\r\n--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (171.70s)\r\n=== RUN   TestAccAWSCodeCommitRepository_create_and_update_default_branch\r\n--- PASS: TestAccAWSCodeCommitRepository_create_and_update_default_branch (35.67s)\r\n=== RUN   TestAccAWSAccessKey_encrypted\r\n--- PASS: TestAccAWSAccessKey_encrypted (18.79s)\r\n=== RUN   TestAccAWSKinesisStream_shardLevelMetrics\r\n--- PASS: TestAccAWSKinesisStream_shardLevelMetrics (181.25s)\r\n=== RUN   TestAccAWSLambdaFunction_envVariables\r\n--- PASS: TestAccAWSLambdaFunction_envVariables (132.92s)\r\n=== RUN   TestAccAWSLightsailKeyPair_imported\r\n--- PASS: TestAccAWSLightsailKeyPair_imported (29.98s)\r\n=== RUN   TestAccAWSLightsailKeyPair_encrypted\r\n--- PASS: TestAccAWSLightsailKeyPair_encrypted (29.63s)\r\n=== RUN   TestAccAWSS3Bucket_basic\r\n--- PASS: TestAccAWSS3Bucket_basic (46.27s)\r\nPASS\r\nok  \tgithub.com/hashicorp/terraform/builtin/providers/aws\t790.381s\r\n```\r\n\r\nRelated to #11218","created_at":"2017-01-24T11:11:13Z","updated_at":"2017-01-24T12:09:30Z","closed_at":"2017-01-24T12:09:30Z","merged_at":"2017-01-24T12:09:30Z","merge_commit_sha":"cbaf051af53b6e2a13e0c0f982b908158c2af10a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/11377/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/11377/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/11377/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/55f610b452127b18a4bc3eba289712d43ff832c3","head":{"label":"radeksimko:b-aws-fix-acc-tests","ref":"b-aws-fix-acc-tests","sha":"55f610b452127b18a4bc3eba289712d43ff832c3","user":{"login":"radeksimko","id":287584,"avatar_url":"https://avatars.githubusercontent.com/u/287584?v=3","gravatar_id":"","url":"https://api.github.com/users/radeksimko","html_url":"https://github.com/radeksimko","followers_url":"https://api.github.com/users/radeksimko/followers","following_url":"https://api.github.com/users/radeksimko/following{/other_user}","gists_url":"https://api.github.com/users/radeksimko/gists{/gist_id}","starred_url":"https://api.github.com/users/radeksimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeksimko/subscriptions","organizations_url":"https://api.github.com/users/radeksimko/orgs","repos_url":"https://api.github.com/users/radeksimko/repos","events_url":"https://api.github.com/users/radeksimko/events{/privacy}","received_events_url":"https://api.github.com/users/radeksimko/received_events","type":"User","site_admin":false},"repo":{"id":29994078,"name":"terraform","full_name":"radeksimko/terraform","owner":{"login":"radeksimko","id":287584,"avatar_url":"https://avatars.githubusercontent.com/u/287584?v=3","gravatar_id":"","url":"https://api.github.com/users/radeksimko","html_url":"https://github.com/radeksimko","followers_url":"https://api.github.com/users/radeksimko/followers","following_url":"https://api.github.com/users/radeksimko/following{/other_user}","gists_url":"https://api.github.com/users/radeksimko/gists{/gist_id}","starred_url":"https://api.github.com/users/radeksimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeksimko/subscriptions","organizations_url":"https://api.github.com/users/radeksimko/orgs","repos_url":"https://api.github.com/users/radeksimko/repos","events_url":"https://api.github.com/users/radeksimko/events{/privacy}","received_events_url":"https://api.github.com/users/radeksimko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radeksimko/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":true,"url":"https://api.github.com/repos/radeksimko/terraform","forks_url":"https://api.github.com/repos/radeksimko/terraform/forks","keys_url":"https://api.github.com/repos/radeksimko/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radeksimko/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radeksimko/terraform/teams","hooks_url":"https://api.github.com/repos/radeksimko/terraform/hooks","issue_events_url":"https://api.github.com/repos/radeksimko/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/radeksimko/terraform/events","assignees_url":"https://api.github.com/repos/radeksimko/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/radeksimko/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/radeksimko/terraform/tags","blobs_url":"https://api.github.com/repos/radeksimko/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radeksimko/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radeksimko/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/radeksimko/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radeksimko/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/radeksimko/terraform/languages","stargazers_url":"https://api.github.com/repos/radeksimko/terraform/stargazers","contributors_url":"https://api.github.com/repos/radeksimko/terraform/contributors","subscribers_url":"https://api.github.com/repos/radeksimko/terraform/subscribers","subscription_url":"https://api.github.com/repos/radeksimko/terraform/subscription","commits_url":"https://api.github.com/repos/radeksimko/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/radeksimko/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/radeksimko/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/radeksimko/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/radeksimko/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/radeksimko/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radeksimko/terraform/merges","archive_url":"https://api.github.com/repos/radeksimko/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radeksimko/terraform/downloads","issues_url":"https://api.github.com/repos/radeksimko/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/radeksimko/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/radeksimko/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/radeksimko/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radeksimko/terraform/labels{/name}","releases_url":"https://api.github.com/repos/radeksimko/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/radeksimko/terraform/deployments","created_at":"2015-01-28T23:42:08Z","updated_at":"2017-01-12T10:18:51Z","pushed_at":"2017-01-24T11:09:55Z","git_url":"git://github.com/radeksimko/terraform.git","ssh_url":"git@github.com:radeksimko/terraform.git","clone_url":"https://github.com/radeksimko/terraform.git","svn_url":"https://github.com/radeksimko/terraform","homepage":"http://www.terraform.io","size":74266,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"e81d09669997886e16a4bb7bcb7193fe9ee2899e","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform/deployments","created_at":"2014-03-13T22:25:48Z","updated_at":"2017-01-24T11:31:21Z","pushed_at":"2017-01-24T12:09:30Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"https://www.terraform.io/","size":75273,"stargazers_count":6839,"watchers_count":6839,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2462,"mirror_url":null,"open_issues_count":1697,"forks":2462,"open_issues":1697,"watchers":6839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/11377"},"html":{"href":"https://github.com/hashicorp/terraform/pull/11377"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/11377"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/11377/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/11377/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/11377/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/55f610b452127b18a4bc3eba289712d43ff832c3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stack72","id":227823,"avatar_url":"https://avatars.githubusercontent.com/u/227823?v=3","gravatar_id":"","url":"https://api.github.com/users/stack72","html_url":"https://github.com/stack72","followers_url":"https://api.github.com/users/stack72/followers","following_url":"https://api.github.com/users/stack72/following{/other_user}","gists_url":"https://api.github.com/users/stack72/gists{/gist_id}","starred_url":"https://api.github.com/users/stack72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack72/subscriptions","organizations_url":"https://api.github.com/users/stack72/orgs","repos_url":"https://api.github.com/users/stack72/repos","events_url":"https://api.github.com/users/stack72/events{/privacy}","received_events_url":"https://api.github.com/users/stack72/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":23,"changed_files":10}}
{"actor":{"display_login":"stack72"}}