{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/153956188","pull_request_review_id":80044906,"id":153956188,"diff_hunk":"@@ -0,0 +1,165 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for additional information regarding\n+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License. You may obtain a\n+ * copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package org.apache.geode.management.internal.cli.commands;\n+\n+import static org.apache.geode.distributed.ConfigurationProperties.DISTRIBUTED_SYSTEM_ID;\n+import static org.apache.geode.distributed.ConfigurationProperties.REMOTE_LOCATORS;\n+\n+import java.util.Properties;\n+\n+import org.junit.BeforeClass;\n+import org.junit.ClassRule;\n+import org.junit.Test;\n+import org.junit.experimental.categories.Category;\n+\n+import org.apache.geode.cache.Cache;\n+import org.apache.geode.cache.CacheFactory;\n+import org.apache.geode.cache.EvictionAction;\n+import org.apache.geode.cache.EvictionAttributes;\n+import org.apache.geode.cache.FixedPartitionAttributes;\n+import org.apache.geode.cache.PartitionAttributes;\n+import org.apache.geode.cache.PartitionAttributesFactory;\n+import org.apache.geode.cache.Region;\n+import org.apache.geode.cache.RegionFactory;\n+import org.apache.geode.cache.RegionShortcut;\n+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;\n+import org.apache.geode.test.dunit.rules.MemberVM;\n+import org.apache.geode.test.junit.categories.DistributedTest;\n+import org.apache.geode.test.junit.rules.GfshCommandRule;\n+\n+@Category(DistributedTest.class)","path":"geode-wan/src/test/java/org/apache/geode/management/internal/cli/commands/DescribeRegionDUnitTest.java","position":31,"original_position":42,"commit_id":"3bc9a0214813f60d34a0bc06abedf1b16f16bb88","original_commit_id":"5b7b1ed26ee42e29ad4581e76c133aa79e36f468","user":{"login":"PurelyApplied","id":7175687,"avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},"body":"Oh, that makes more sense.\r\n\r\nEspecially since most of the test is done via `gfsh.executeAndAssertThat`, it should be a pretty simple thing to convert this into a `GfshScript.of(...)`.  The only thing I wouldn't know how to convert is the guards that wait until the async event queues and the gateway senders are live.  I don't know that those checks could work in an `AcceptanceTest`, since that would belong to a separate process.\r\n\r\nOther than the \"sleep for a while\" anti-pattern, I don't see how to safely guarantee that the AEQ and Gateway are live before proceeding.","created_at":"2017-11-30T00:26:59Z","updated_at":"2017-11-30T00:27:00Z","html_url":"https://github.com/apache/geode/pull/1099#discussion_r153956188","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/1099","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/153956188"},"html":{"href":"https://github.com/apache/geode/pull/1099#discussion_r153956188"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/1099"}},"in_reply_to_id":153876439},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/1099","id":155219716,"html_url":"https://github.com/apache/geode/pull/1099","diff_url":"https://github.com/apache/geode/pull/1099.diff","patch_url":"https://github.com/apache/geode/pull/1099.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/1099","number":1099,"state":"open","locked":false,"title":"GEODE-3955: Add AEQ and Gateway Sender information to 'describe region' output.","user":{"login":"PurelyApplied","id":7175687,"avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},"body":"I feel like the non-trivial refactoring deserves its own commit, if only for ease of review in this pull request.\r\n\r\nMy inexperience with `Mockito` is showing through and I got a little carried away in the `RegionDescriptionJUnitTest`.  I don't know if the `spy` on its consumption in `DescribeRegionCommand` is beyond the scope of a reasonable JUnit and/or if we have (or should have) proper coverage of that in wider-scope tests.  I don't really like how I dug into the command output JSON.  So on the one hand, I don't really like those tests and could see them getting deleted.  But on the other hand, it is more test coverage in the cheap JUnit category.  Thoughts?\r\n\r\n-----\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n- [x] Does `gradlew build` run cleanly?\r\n\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n","created_at":"2017-11-29T00:26:15Z","updated_at":"2017-11-30T00:27:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c01ccb53be7ea1d0d0bf3cd2b6535522c1718ef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jdeppe-pivotal","id":5313410,"avatar_url":"https://avatars0.githubusercontent.com/u/5313410?v=4","gravatar_id":"","url":"https://api.github.com/users/jdeppe-pivotal","html_url":"https://github.com/jdeppe-pivotal","followers_url":"https://api.github.com/users/jdeppe-pivotal/followers","following_url":"https://api.github.com/users/jdeppe-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/jdeppe-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/jdeppe-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdeppe-pivotal/subscriptions","organizations_url":"https://api.github.com/users/jdeppe-pivotal/orgs","repos_url":"https://api.github.com/users/jdeppe-pivotal/repos","events_url":"https://api.github.com/users/jdeppe-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/jdeppe-pivotal/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/1099/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/1099/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/1099/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/3bc9a0214813f60d34a0bc06abedf1b16f16bb88","head":{"label":"PurelyApplied:geode-3955","ref":"geode-3955","sha":"3bc9a0214813f60d34a0bc06abedf1b16f16bb88","user":{"login":"PurelyApplied","id":7175687,"avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},"repo":{"id":85762855,"name":"geode","full_name":"PurelyApplied/geode","owner":{"login":"PurelyApplied","id":7175687,"avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PurelyApplied/geode","description":"Mirror of Apache Geode","fork":true,"url":"https://api.github.com/repos/PurelyApplied/geode","forks_url":"https://api.github.com/repos/PurelyApplied/geode/forks","keys_url":"https://api.github.com/repos/PurelyApplied/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PurelyApplied/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PurelyApplied/geode/teams","hooks_url":"https://api.github.com/repos/PurelyApplied/geode/hooks","issue_events_url":"https://api.github.com/repos/PurelyApplied/geode/issues/events{/number}","events_url":"https://api.github.com/repos/PurelyApplied/geode/events","assignees_url":"https://api.github.com/repos/PurelyApplied/geode/assignees{/user}","branches_url":"https://api.github.com/repos/PurelyApplied/geode/branches{/branch}","tags_url":"https://api.github.com/repos/PurelyApplied/geode/tags","blobs_url":"https://api.github.com/repos/PurelyApplied/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PurelyApplied/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PurelyApplied/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/PurelyApplied/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PurelyApplied/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/PurelyApplied/geode/languages","stargazers_url":"https://api.github.com/repos/PurelyApplied/geode/stargazers","contributors_url":"https://api.github.com/repos/PurelyApplied/geode/contributors","subscribers_url":"https://api.github.com/repos/PurelyApplied/geode/subscribers","subscription_url":"https://api.github.com/repos/PurelyApplied/geode/subscription","commits_url":"https://api.github.com/repos/PurelyApplied/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/PurelyApplied/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/PurelyApplied/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/PurelyApplied/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/PurelyApplied/geode/contents/{+path}","compare_url":"https://api.github.com/repos/PurelyApplied/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PurelyApplied/geode/merges","archive_url":"https://api.github.com/repos/PurelyApplied/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PurelyApplied/geode/downloads","issues_url":"https://api.github.com/repos/PurelyApplied/geode/issues{/number}","pulls_url":"https://api.github.com/repos/PurelyApplied/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/PurelyApplied/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/PurelyApplied/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PurelyApplied/geode/labels{/name}","releases_url":"https://api.github.com/repos/PurelyApplied/geode/releases{/id}","deployments_url":"https://api.github.com/repos/PurelyApplied/geode/deployments","created_at":"2017-03-21T23:11:29Z","updated_at":"2017-03-21T23:11:47Z","pushed_at":"2017-11-30T00:15:12Z","git_url":"git://github.com/PurelyApplied/geode.git","ssh_url":"git@github.com:PurelyApplied/geode.git","clone_url":"https://github.com/PurelyApplied/geode.git","svn_url":"https://github.com/PurelyApplied/geode","homepage":"","size":118951,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"375a8f6c330b4f985a0fb88ce080c7691aacad41","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2017-11-29T08:30:47Z","pushed_at":"2017-11-30T00:15:14Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":142988,"stargazers_count":1108,"watchers_count":1108,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":399,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":399,"open_issues":20,"watchers":1108,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/1099"},"html":{"href":"https://github.com/apache/geode/pull/1099"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/1099"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/1099/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/1099/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/1099/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/3bc9a0214813f60d34a0bc06abedf1b16f16bb88"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"PurelyApplied"}}