{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/99665143","pull_request_review_id":20349033,"id":99665143,"diff_hunk":"@@ -0,0 +1,1193 @@\n+﻿// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System.Collections.Generic;\n+using System.Diagnostics.CodeAnalysis;\n+using System.Diagnostics.Contracts;\n+using System.Globalization;\n+using System.IO;\n+using System.Net.Http.Headers;\n+using System.Net.Security;\n+using System.Runtime.CompilerServices;\n+using System.Security;\n+using System.Security.Authentication;\n+using System.Security.Cryptography.X509Certificates;\n+using System.Security.Principal;\n+using System.Security.Permissions;\n+using System.Threading;\n+using System.Threading.Tasks;\n+\n+namespace System.Net.Http\n+{\n+    public class HttpClientHandler : HttpMessageHandler\n+    {\n+        #region Fields\n+\n+        private static readonly Action<object> s_onCancel = OnCancel;\n+\n+        private readonly Action<object> _startRequest;\n+        private readonly AsyncCallback _getRequestStreamCallback;\n+        private readonly AsyncCallback _getResponseCallback;\n+\n+        private volatile bool _operationStarted;\n+        private volatile bool _disposed;\n+\n+        private long _maxRequestContentBufferSize;\n+        private int _maxResponseHeadersLength;\n+        private CookieContainer _cookieContainer;\n+        private bool _useCookies;\n+        private DecompressionMethods _automaticDecompression;\n+        private IWebProxy _proxy;\n+        private bool _useProxy;\n+        private ICredentials _defaultProxyCredentials;\n+        private bool _preAuthenticate;\n+        private bool _useDefaultCredentials;\n+        private ICredentials _credentials;\n+        private bool _allowAutoRedirect;\n+        private int _maxAutomaticRedirections;\n+        private string _connectionGroupName;\n+        private ClientCertificateOption _clientCertOptions;\n+        private X509Certificate2Collection _clientCertificates;\n+        private IDictionary<String, Object> _properties;\n+        private int _maxConnectionsPerServer;\n+        private Func<\n+            HttpRequestMessage,\n+            X509Certificate2,\n+            X509Chain,\n+            SslPolicyErrors,\n+            bool> _serverCertificateCustomValidationCallback;\n+\n+        #endregion Fields\n+\n+        #region Properties\n+\n+        public bool AllowAutoRedirect\n+        {\n+            get\n+            {\n+                return _allowAutoRedirect;\n+            }\n+\n+            set\n+            {\n+                CheckDisposedOrStarted();\n+                _allowAutoRedirect = value;\n+            }\n+        }\n+\n+        public DecompressionMethods AutomaticDecompression\n+        {\n+            get\n+            {\n+                return _automaticDecompression;\n+            }\n+\n+            set\n+            {\n+                CheckDisposedOrStarted();\n+                _automaticDecompression = value;\n+            }\n+        }\n+\n+        public bool CheckCertificateRevocationList\n+        {\n+            // TODO: Issue #11100.\n+            get\n+            {\n+                throw new PlatformNotSupportedException();","path":"src/System.Net.Http/src/System/Net/Http/HttpClientHandler.Net46.cs","position":98,"original_position":98,"commit_id":"801525525add13d5ef03226bbf6a5be53b08e18c","original_commit_id":"801525525add13d5ef03226bbf6a5be53b08e18c","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Why is it we can't implement the getter?  Is it because this might be tweaked on a servicepoint-by-servicepoint basis and thus there's no one right answer for the whole handler?","created_at":"2017-02-06T19:34:31Z","updated_at":"2017-02-06T19:34:31Z","html_url":"https://github.com/dotnet/corefx/pull/15659#discussion_r99665143","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/15659","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/99665143"},"html":{"href":"https://github.com/dotnet/corefx/pull/15659#discussion_r99665143"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15659"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/15659","id":103992409,"html_url":"https://github.com/dotnet/corefx/pull/15659","diff_url":"https://github.com/dotnet/corefx/pull/15659.diff","patch_url":"https://github.com/dotnet/corefx/pull/15659.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/15659","number":15659,"state":"open","locked":false,"title":"[Port 1.1] Fix System.Net.Http.HttpClientHandler for net46 build","user":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"body":"Porting fix from: #15036.\r\n","created_at":"2017-01-31T18:15:28Z","updated_at":"2017-02-06T19:34:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"787c257d9d7f2a104feafb57032ddad6dfe13326","assignee":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/11","html_url":"https://github.com/dotnet/corefx/milestone/11","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/11/labels","id":2172408,"number":11,"title":"1.1.x","description":".NET Core 1.1 Servicing Updates\r\nhttps://github.com/dotnet/core/tree/master/release-notes","creator":{"login":"karelz","id":5776068,"avatar_url":"https://avatars.githubusercontent.com/u/5776068?v=3","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":93,"state":"open","created_at":"2016-12-02T23:48:10Z","updated_at":"2017-02-05T03:45:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/15659/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/15659/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/15659/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/801525525add13d5ef03226bbf6a5be53b08e18c","head":{"label":"davidsh:net46http_port110","ref":"net46http_port110","sha":"801525525add13d5ef03226bbf6a5be53b08e18c","user":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"repo":{"id":56272270,"name":"corefx","full_name":"davidsh/corefx","owner":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidsh/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/davidsh/corefx","forks_url":"https://api.github.com/repos/davidsh/corefx/forks","keys_url":"https://api.github.com/repos/davidsh/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidsh/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidsh/corefx/teams","hooks_url":"https://api.github.com/repos/davidsh/corefx/hooks","issue_events_url":"https://api.github.com/repos/davidsh/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/davidsh/corefx/events","assignees_url":"https://api.github.com/repos/davidsh/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/davidsh/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/davidsh/corefx/tags","blobs_url":"https://api.github.com/repos/davidsh/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidsh/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidsh/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidsh/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidsh/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/davidsh/corefx/languages","stargazers_url":"https://api.github.com/repos/davidsh/corefx/stargazers","contributors_url":"https://api.github.com/repos/davidsh/corefx/contributors","subscribers_url":"https://api.github.com/repos/davidsh/corefx/subscribers","subscription_url":"https://api.github.com/repos/davidsh/corefx/subscription","commits_url":"https://api.github.com/repos/davidsh/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidsh/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidsh/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidsh/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidsh/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/davidsh/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidsh/corefx/merges","archive_url":"https://api.github.com/repos/davidsh/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidsh/corefx/downloads","issues_url":"https://api.github.com/repos/davidsh/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/davidsh/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/davidsh/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/davidsh/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidsh/corefx/labels{/name}","releases_url":"https://api.github.com/repos/davidsh/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/davidsh/corefx/deployments","created_at":"2016-04-14T21:52:27Z","updated_at":"2016-04-14T21:52:51Z","pushed_at":"2017-01-31T21:11:00Z","git_url":"git://github.com/davidsh/corefx.git","ssh_url":"git@github.com:davidsh/corefx.git","clone_url":"https://github.com/davidsh/corefx.git","svn_url":"https://github.com/davidsh/corefx","homepage":"http://dotnet.github.io/","size":131276,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:release/1.1.0","ref":"release/1.1.0","sha":"6b4e02597596d8f6ff12f78f533b09448af86524","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-02-06T14:13:35Z","pushed_at":"2017-02-06T19:25:10Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":132327,"stargazers_count":11203,"watchers_count":11203,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2904,"mirror_url":null,"open_issues_count":1390,"forks":2904,"open_issues":1390,"watchers":11203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15659"},"html":{"href":"https://github.com/dotnet/corefx/pull/15659"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/15659"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/15659/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15659/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15659/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/801525525add13d5ef03226bbf6a5be53b08e18c"}}}}
{"actor":{"display_login":"stephentoub"}}