{"action":"created","comment":{"url":"https://api.github.com/repos/linkerd/linkerd/pulls/comments/119282744","pull_request_review_id":41146186,"id":119282744,"diff_hunk":"@@ -15,7 +15,7 @@ enum Enumeration {\n \n message Message {\n   enum Enumeration {\n-    ZERO = 0;\n+    zero = 0;","path":"grpc/eg/src/main/protobuf/eg.proto","position":5,"original_position":5,"commit_id":"84993a8208ba064001d9edcdba0bd364d52dace8","original_commit_id":"e8991d5414bec32a8e45c310c540ff6c172e8756","user":{"login":"nvartolomei","id":543193,"avatar_url":"https://avatars3.githubusercontent.com/u/543193?v=3","gravatar_id":"","url":"https://api.github.com/users/nvartolomei","html_url":"https://github.com/nvartolomei","followers_url":"https://api.github.com/users/nvartolomei/followers","following_url":"https://api.github.com/users/nvartolomei/following{/other_user}","gists_url":"https://api.github.com/users/nvartolomei/gists{/gist_id}","starred_url":"https://api.github.com/users/nvartolomei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvartolomei/subscriptions","organizations_url":"https://api.github.com/users/nvartolomei/orgs","repos_url":"https://api.github.com/users/nvartolomei/repos","events_url":"https://api.github.com/users/nvartolomei/events{/privacy}","received_events_url":"https://api.github.com/users/nvartolomei/received_events","type":"User","site_admin":false},"body":"What do you mean? This is here to break previous tests, which are fixed by adding backticks.\r\n\r\nCLA signed.","created_at":"2017-05-31T06:57:53Z","updated_at":"2017-05-31T06:57:53Z","html_url":"https://github.com/linkerd/linkerd/pull/1351#discussion_r119282744","pull_request_url":"https://api.github.com/repos/linkerd/linkerd/pulls/1351","_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/comments/119282744"},"html":{"href":"https://github.com/linkerd/linkerd/pull/1351#discussion_r119282744"},"pull_request":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1351"}}},"pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd/pulls/1351","id":122887492,"html_url":"https://github.com/linkerd/linkerd/pull/1351","diff_url":"https://github.com/linkerd/linkerd/pull/1351.diff","patch_url":"https://github.com/linkerd/linkerd/pull/1351.patch","issue_url":"https://api.github.com/repos/linkerd/linkerd/issues/1351","number":1351,"state":"open","locked":false,"title":"Use backticks when matching proto enum values","user":{"login":"nvartolomei","id":543193,"avatar_url":"https://avatars3.githubusercontent.com/u/543193?v=3","gravatar_id":"","url":"https://api.github.com/users/nvartolomei","html_url":"https://github.com/nvartolomei","followers_url":"https://api.github.com/users/nvartolomei/followers","following_url":"https://api.github.com/users/nvartolomei/following{/other_user}","gists_url":"https://api.github.com/users/nvartolomei/gists{/gist_id}","starred_url":"https://api.github.com/users/nvartolomei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvartolomei/subscriptions","organizations_url":"https://api.github.com/users/nvartolomei/orgs","repos_url":"https://api.github.com/users/nvartolomei/repos","events_url":"https://api.github.com/users/nvartolomei/events{/privacy}","received_events_url":"https://api.github.com/users/nvartolomei/received_events","type":"User","site_admin":false},"body":"Using lowercase/snakecase enum values generates variable pattern\r\nmatch.\r\n\r\nScala 2.11 compiles the code with a warning, Scala 2.12 will throw an\r\nerror. Although proto3 style guide says to use CAPITALS_WITH_UNDERSCORES\r\nthis is not an enforced rule across proto ecosystem.\r\n\r\nUsing backticks in generated code matches variable name.","created_at":"2017-05-29T12:40:10Z","updated_at":"2017-05-31T06:57:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf58daad063c9faf68e939c23f09caa20c0cafa3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkerd/linkerd/pulls/1351/commits","review_comments_url":"https://api.github.com/repos/linkerd/linkerd/pulls/1351/comments","review_comment_url":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkerd/linkerd/issues/1351/comments","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/84993a8208ba064001d9edcdba0bd364d52dace8","head":{"label":"nvartolomei:enum-values-matching-backticks","ref":"enum-values-matching-backticks","sha":"84993a8208ba064001d9edcdba0bd364d52dace8","user":{"login":"nvartolomei","id":543193,"avatar_url":"https://avatars3.githubusercontent.com/u/543193?v=3","gravatar_id":"","url":"https://api.github.com/users/nvartolomei","html_url":"https://github.com/nvartolomei","followers_url":"https://api.github.com/users/nvartolomei/followers","following_url":"https://api.github.com/users/nvartolomei/following{/other_user}","gists_url":"https://api.github.com/users/nvartolomei/gists{/gist_id}","starred_url":"https://api.github.com/users/nvartolomei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvartolomei/subscriptions","organizations_url":"https://api.github.com/users/nvartolomei/orgs","repos_url":"https://api.github.com/users/nvartolomei/repos","events_url":"https://api.github.com/users/nvartolomei/events{/privacy}","received_events_url":"https://api.github.com/users/nvartolomei/received_events","type":"User","site_admin":false},"repo":{"id":92735234,"name":"linkerd","full_name":"nvartolomei/linkerd","owner":{"login":"nvartolomei","id":543193,"avatar_url":"https://avatars3.githubusercontent.com/u/543193?v=3","gravatar_id":"","url":"https://api.github.com/users/nvartolomei","html_url":"https://github.com/nvartolomei","followers_url":"https://api.github.com/users/nvartolomei/followers","following_url":"https://api.github.com/users/nvartolomei/following{/other_user}","gists_url":"https://api.github.com/users/nvartolomei/gists{/gist_id}","starred_url":"https://api.github.com/users/nvartolomei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvartolomei/subscriptions","organizations_url":"https://api.github.com/users/nvartolomei/orgs","repos_url":"https://api.github.com/users/nvartolomei/repos","events_url":"https://api.github.com/users/nvartolomei/events{/privacy}","received_events_url":"https://api.github.com/users/nvartolomei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nvartolomei/linkerd","description":"Resilient service mesh for cloud native apps","fork":true,"url":"https://api.github.com/repos/nvartolomei/linkerd","forks_url":"https://api.github.com/repos/nvartolomei/linkerd/forks","keys_url":"https://api.github.com/repos/nvartolomei/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvartolomei/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvartolomei/linkerd/teams","hooks_url":"https://api.github.com/repos/nvartolomei/linkerd/hooks","issue_events_url":"https://api.github.com/repos/nvartolomei/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/nvartolomei/linkerd/events","assignees_url":"https://api.github.com/repos/nvartolomei/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/nvartolomei/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/nvartolomei/linkerd/tags","blobs_url":"https://api.github.com/repos/nvartolomei/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvartolomei/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvartolomei/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvartolomei/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvartolomei/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/nvartolomei/linkerd/languages","stargazers_url":"https://api.github.com/repos/nvartolomei/linkerd/stargazers","contributors_url":"https://api.github.com/repos/nvartolomei/linkerd/contributors","subscribers_url":"https://api.github.com/repos/nvartolomei/linkerd/subscribers","subscription_url":"https://api.github.com/repos/nvartolomei/linkerd/subscription","commits_url":"https://api.github.com/repos/nvartolomei/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvartolomei/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvartolomei/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvartolomei/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvartolomei/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/nvartolomei/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvartolomei/linkerd/merges","archive_url":"https://api.github.com/repos/nvartolomei/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvartolomei/linkerd/downloads","issues_url":"https://api.github.com/repos/nvartolomei/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/nvartolomei/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/nvartolomei/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/nvartolomei/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvartolomei/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/nvartolomei/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/nvartolomei/linkerd/deployments","created_at":"2017-05-29T11:51:40Z","updated_at":"2017-05-29T11:51:43Z","pushed_at":"2017-05-31T06:53:03Z","git_url":"git://github.com/nvartolomei/linkerd.git","ssh_url":"git@github.com:nvartolomei/linkerd.git","clone_url":"https://github.com/nvartolomei/linkerd.git","svn_url":"https://github.com/nvartolomei/linkerd","homepage":"https://linkerd.io","size":5011,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkerd:master","ref":"master","sha":"de2642813da09f1fcaa4706ca47c269af4a1d391","user":{"login":"linkerd","id":25301026,"avatar_url":"https://avatars0.githubusercontent.com/u/25301026?v=3","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"name":"linkerd","full_name":"linkerd/linkerd","owner":{"login":"linkerd","id":25301026,"avatar_url":"https://avatars0.githubusercontent.com/u/25301026?v=3","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkerd/linkerd","description":"Resilient service mesh for cloud native apps","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd","forks_url":"https://api.github.com/repos/linkerd/linkerd/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2017-05-31T06:06:34Z","pushed_at":"2017-05-31T06:53:05Z","git_url":"git://github.com/linkerd/linkerd.git","ssh_url":"git@github.com:linkerd/linkerd.git","clone_url":"https://github.com/linkerd/linkerd.git","svn_url":"https://github.com/linkerd/linkerd","homepage":"https://linkerd.io","size":5001,"stargazers_count":2185,"watchers_count":2185,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":127,"forks":187,"open_issues":127,"watchers":2185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1351"},"html":{"href":"https://github.com/linkerd/linkerd/pull/1351"},"issue":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/1351"},"comments":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/1351/comments"},"review_comments":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1351/comments"},"review_comment":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1351/commits"},"statuses":{"href":"https://api.github.com/repos/linkerd/linkerd/statuses/84993a8208ba064001d9edcdba0bd364d52dace8"}}}}
{"actor":{"display_login":"nvartolomei"}}