{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/126377771","pull_request_review_id":48850849,"id":126377771,"diff_hunk":"@@ -111,12 +111,17 @@ updateTeam (zusr::: zcon ::: tid ::: req ::: _) = do\n     push1 $ newPush1 zusr (TeamEvent e) r & pushConn .~ Just zcon\n     pure empty\n \n-deleteTeam :: UserId ::: ConnId ::: TeamId ::: JSON -> Galley Response\n-deleteTeam (zusr::: zcon ::: tid ::: _) = do\n-    alive <- Data.isTeamAlive tid\n-    membs <- Data.teamMembers tid\n-    when alive $\n-        void $ permissionCheck zusr DeleteTeam membs\n+deleteTeam :: UserId ::: ConnId ::: TeamId ::: Request ::: Maybe JSON ::: JSON -> Galley Response\n+deleteTeam (zusr::: zcon ::: tid ::: req ::: _ ::: _) = do\n+    team <- Data.team tid\n+    case team of\n+        Just t | Data.tdDeleted t == False -> do","path":"services/galley/src/Galley/API/Teams.hs","position":14,"original_position":14,"commit_id":"379ea1f278429c94b19c49ce8dafe9ca0edbcd1b","original_commit_id":"379ea1f278429c94b19c49ce8dafe9ca0edbcd1b","user":{"login":"jschaul","id":2112744,"avatar_url":"https://avatars1.githubusercontent.com/u/2112744?v=3","gravatar_id":"","url":"https://api.github.com/users/jschaul","html_url":"https://github.com/jschaul","followers_url":"https://api.github.com/users/jschaul/followers","following_url":"https://api.github.com/users/jschaul/following{/other_user}","gists_url":"https://api.github.com/users/jschaul/gists{/gist_id}","starred_url":"https://api.github.com/users/jschaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschaul/subscriptions","organizations_url":"https://api.github.com/users/jschaul/orgs","repos_url":"https://api.github.com/users/jschaul/repos","events_url":"https://api.github.com/users/jschaul/events{/privacy}","received_events_url":"https://api.github.com/users/jschaul/received_events","type":"User","site_admin":false},"body":"By changing this code you removed the \r\n```haskell\r\ncase tdDeleted <$> t of\r\n    Nothing    -> pure False\r\n```\r\ncase. Is that intentional?","created_at":"2017-07-10T09:47:57Z","updated_at":"2017-07-10T09:54:43Z","html_url":"https://github.com/wireapp/wire-server/pull/33#discussion_r126377771","pull_request_url":"https://api.github.com/repos/wireapp/wire-server/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/126377771"},"html":{"href":"https://github.com/wireapp/wire-server/pull/33#discussion_r126377771"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/33","id":129456105,"html_url":"https://github.com/wireapp/wire-server/pull/33","diff_url":"https://github.com/wireapp/wire-server/pull/33.diff","patch_url":"https://github.com/wireapp/wire-server/pull/33.patch","issue_url":"https://api.github.com/repos/wireapp/wire-server/issues/33","number":33,"state":"open","locked":false,"title":"Feature/delete account when removing members from binding teams","user":{"login":"tiago-loureiro","id":1105323,"avatar_url":"https://avatars0.githubusercontent.com/u/1105323?v=3","gravatar_id":"","url":"https://api.github.com/users/tiago-loureiro","html_url":"https://github.com/tiago-loureiro","followers_url":"https://api.github.com/users/tiago-loureiro/followers","following_url":"https://api.github.com/users/tiago-loureiro/following{/other_user}","gists_url":"https://api.github.com/users/tiago-loureiro/gists{/gist_id}","starred_url":"https://api.github.com/users/tiago-loureiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiago-loureiro/subscriptions","organizations_url":"https://api.github.com/users/tiago-loureiro/orgs","repos_url":"https://api.github.com/users/tiago-loureiro/repos","events_url":"https://api.github.com/users/tiago-loureiro/events{/privacy}","received_events_url":"https://api.github.com/users/tiago-loureiro/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-07T17:56:22Z","updated_at":"2017-07-10T09:54:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"946560b627441be501190687f6cbeffb0d9360ef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-server/pulls/33/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-server/pulls/33/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-server/issues/33/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/379ea1f278429c94b19c49ce8dafe9ca0edbcd1b","head":{"label":"wireapp:feature/delete-account-binding-teams","ref":"feature/delete-account-binding-teams","sha":"379ea1f278429c94b19c49ce8dafe9ca0edbcd1b","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"name":"wire-server","full_name":"wireapp/wire-server","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2017-07-09T22:01:11Z","pushed_at":"2017-07-07T17:56:22Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":606,"stargazers_count":779,"watchers_count":779,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":2,"forks":86,"open_issues":2,"watchers":779,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"f7274e1ea535e9bc38f8d6eb458a6b62b6b4e539","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"name":"wire-server","full_name":"wireapp/wire-server","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars0.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2017-07-09T22:01:11Z","pushed_at":"2017-07-07T17:56:22Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":606,"stargazers_count":779,"watchers_count":779,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":2,"forks":86,"open_issues":2,"watchers":779,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/33"},"html":{"href":"https://github.com/wireapp/wire-server/pull/33"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/33"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-server/statuses/379ea1f278429c94b19c49ce8dafe9ca0edbcd1b"}}}}
{"actor":{"display_login":"jschaul"}}