{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/comments/124712097","pull_request_review_id":47026641,"id":124712097,"diff_hunk":"@@ -283,4 +278,15 @@\n   <!-- This target collects all the resolved references that are used to actually compile. -->\n   <Target Name=\"CollectResolvedCompilationReferencesDesignTime\" DependsOnTargets=\"CompileDesignTime\" Returns=\"@(ReferencePathWithRefAssemblies)\" />\n \n+  <!-- This target collects all up-to-date file additions. -->\n+  <Target Name=\"CollectUpToDateInputsDesignTime\" DependsOnTargets=\"CompileDesignTime\" Returns=\"@(UpToDateCheckInput)\">\n+    <!-- If the project we're compiling has a ruleset, make sure we check it for up-to-date checks. -->\n+    <ItemGroup Condition=\"'$(ResolvedCodeAnalysisRuleSet)' != ''\">\n+      <UpToDateCheckInput Include=\"$([System.IO.Path]::GetFullPath($(ResolvedCodeAnalysisRuleSet)))\" />","path":"src/Targets/Microsoft.Managed.DesignTime.targets","position":20,"original_position":20,"commit_id":"38e298c8c9b207d600d02d27d3c923b35aef15dd","original_commit_id":"38e298c8c9b207d600d02d27d3c923b35aef15dd","user":{"login":"davkean","id":1103906,"avatar_url":"https://avatars2.githubusercontent.com/u/1103906?v=3","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"body":"Ah, I also see that ResolvedCodeAnalysisRuleSet isn't just something you can root with the project, it's literally resolved like a reference.","created_at":"2017-06-29T04:57:18Z","updated_at":"2017-06-29T04:57:18Z","html_url":"https://github.com/dotnet/project-system/pull/2519#discussion_r124712097","pull_request_url":"https://api.github.com/repos/dotnet/project-system/pulls/2519","_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments/124712097"},"html":{"href":"https://github.com/dotnet/project-system/pull/2519#discussion_r124712097"},"pull_request":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/2519"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/2519","id":128047257,"html_url":"https://github.com/dotnet/project-system/pull/2519","diff_url":"https://github.com/dotnet/project-system/pull/2519.diff","patch_url":"https://github.com/dotnet/project-system/pull/2519.patch","issue_url":"https://api.github.com/repos/dotnet/project-system/issues/2519","number":2519,"state":"open","locked":false,"title":"Fix up to date check in old/new project system for non-absolute path rulesets","user":{"login":"panopticoncentral","id":684792,"avatar_url":"https://avatars3.githubusercontent.com/u/684792?v=3","gravatar_id":"","url":"https://api.github.com/users/panopticoncentral","html_url":"https://github.com/panopticoncentral","followers_url":"https://api.github.com/users/panopticoncentral/followers","following_url":"https://api.github.com/users/panopticoncentral/following{/other_user}","gists_url":"https://api.github.com/users/panopticoncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/panopticoncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panopticoncentral/subscriptions","organizations_url":"https://api.github.com/users/panopticoncentral/orgs","repos_url":"https://api.github.com/users/panopticoncentral/repos","events_url":"https://api.github.com/users/panopticoncentral/events{/privacy}","received_events_url":"https://api.github.com/users/panopticoncentral/received_events","type":"User","site_admin":false},"body":"**Customer scenario**\r\n\r\nA project with a ruleset (CodeAnalysisRuleSet) that is specified with a non-absolute path does not correctly resolve and so is always considered out of date. Besides being a bug in the new and old project system, this causes RPS regressions for the old project system.\r\n\r\n**Bugs this fixes:** \r\n\r\nhttps://devdiv.visualstudio.com/DevDiv/_workitems?id=455562\r\n\r\n**Workarounds, if any**\r\n\r\nOnly workaround to avoid regression is to remove the ruleset from the project file (losing the ruleset functionality).\r\n\r\n**Risk**\r\n\r\nLow, this is removing an incorrect item from the up to date check.\r\n\r\n**Performance impact**\r\n\r\nImproves performance for projects that use rulesets by doing correct up to date check.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nNo.\r\n\r\n**Root cause analysis:**\r\n\r\nWe are adding integration tests to catch this kind of problem.\r\n\r\n**How was the bug found?**\r\n\r\nRPS tests.\r\n\r\n** NOTES **\r\n\r\nThis looks like a big change, but most of the diff involves removing entries from files that are localized, so there are a lot of duplicates.\r\n","created_at":"2017-06-29T00:25:40Z","updated_at":"2017-06-29T04:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c73537364266b24e0cad965fb579701631854ee8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/project-system/pulls/2519/commits","review_comments_url":"https://api.github.com/repos/dotnet/project-system/pulls/2519/comments","review_comment_url":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/project-system/issues/2519/comments","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/38e298c8c9b207d600d02d27d3c923b35aef15dd","head":{"label":"panopticoncentral:uptodaterps","ref":"uptodaterps","sha":"38e298c8c9b207d600d02d27d3c923b35aef15dd","user":{"login":"panopticoncentral","id":684792,"avatar_url":"https://avatars3.githubusercontent.com/u/684792?v=3","gravatar_id":"","url":"https://api.github.com/users/panopticoncentral","html_url":"https://github.com/panopticoncentral","followers_url":"https://api.github.com/users/panopticoncentral/followers","following_url":"https://api.github.com/users/panopticoncentral/following{/other_user}","gists_url":"https://api.github.com/users/panopticoncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/panopticoncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panopticoncentral/subscriptions","organizations_url":"https://api.github.com/users/panopticoncentral/orgs","repos_url":"https://api.github.com/users/panopticoncentral/repos","events_url":"https://api.github.com/users/panopticoncentral/events{/privacy}","received_events_url":"https://api.github.com/users/panopticoncentral/received_events","type":"User","site_admin":false},"repo":{"id":81486170,"name":"project-system","full_name":"panopticoncentral/project-system","owner":{"login":"panopticoncentral","id":684792,"avatar_url":"https://avatars3.githubusercontent.com/u/684792?v=3","gravatar_id":"","url":"https://api.github.com/users/panopticoncentral","html_url":"https://github.com/panopticoncentral","followers_url":"https://api.github.com/users/panopticoncentral/followers","following_url":"https://api.github.com/users/panopticoncentral/following{/other_user}","gists_url":"https://api.github.com/users/panopticoncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/panopticoncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panopticoncentral/subscriptions","organizations_url":"https://api.github.com/users/panopticoncentral/orgs","repos_url":"https://api.github.com/users/panopticoncentral/repos","events_url":"https://api.github.com/users/panopticoncentral/events{/privacy}","received_events_url":"https://api.github.com/users/panopticoncentral/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/panopticoncentral/project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":true,"url":"https://api.github.com/repos/panopticoncentral/project-system","forks_url":"https://api.github.com/repos/panopticoncentral/project-system/forks","keys_url":"https://api.github.com/repos/panopticoncentral/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panopticoncentral/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panopticoncentral/project-system/teams","hooks_url":"https://api.github.com/repos/panopticoncentral/project-system/hooks","issue_events_url":"https://api.github.com/repos/panopticoncentral/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/panopticoncentral/project-system/events","assignees_url":"https://api.github.com/repos/panopticoncentral/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/panopticoncentral/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/panopticoncentral/project-system/tags","blobs_url":"https://api.github.com/repos/panopticoncentral/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panopticoncentral/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panopticoncentral/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/panopticoncentral/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panopticoncentral/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/panopticoncentral/project-system/languages","stargazers_url":"https://api.github.com/repos/panopticoncentral/project-system/stargazers","contributors_url":"https://api.github.com/repos/panopticoncentral/project-system/contributors","subscribers_url":"https://api.github.com/repos/panopticoncentral/project-system/subscribers","subscription_url":"https://api.github.com/repos/panopticoncentral/project-system/subscription","commits_url":"https://api.github.com/repos/panopticoncentral/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/panopticoncentral/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/panopticoncentral/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/panopticoncentral/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/panopticoncentral/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/panopticoncentral/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panopticoncentral/project-system/merges","archive_url":"https://api.github.com/repos/panopticoncentral/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panopticoncentral/project-system/downloads","issues_url":"https://api.github.com/repos/panopticoncentral/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/panopticoncentral/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/panopticoncentral/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/panopticoncentral/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panopticoncentral/project-system/labels{/name}","releases_url":"https://api.github.com/repos/panopticoncentral/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/panopticoncentral/project-system/deployments","created_at":"2017-02-09T19:22:10Z","updated_at":"2017-04-04T21:12:29Z","pushed_at":"2017-06-29T00:49:58Z","git_url":"git://github.com/panopticoncentral/project-system.git","ssh_url":"git@github.com:panopticoncentral/project-system.git","clone_url":"https://github.com/panopticoncentral/project-system.git","svn_url":"https://github.com/panopticoncentral/project-system","homepage":null,"size":15245,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a8d1b92f14ce3113a8d27ac6bdcc20bab366d749","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"name":"project-system","full_name":"dotnet/project-system","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/project-system","description":"The C#, F# and Visual Basic project system for Visual Studio","fork":false,"url":"https://api.github.com/repos/dotnet/project-system","forks_url":"https://api.github.com/repos/dotnet/project-system/forks","keys_url":"https://api.github.com/repos/dotnet/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/project-system/events","assignees_url":"https://api.github.com/repos/dotnet/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/project-system/merges","archive_url":"https://api.github.com/repos/dotnet/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2017-06-28T20:20:27Z","pushed_at":"2017-06-29T01:08:29Z","git_url":"git://github.com/dotnet/project-system.git","ssh_url":"git@github.com:dotnet/project-system.git","clone_url":"https://github.com/dotnet/project-system.git","svn_url":"https://github.com/dotnet/project-system","homepage":"","size":15264,"stargazers_count":247,"watchers_count":247,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":421,"forks":88,"open_issues":421,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/2519"},"html":{"href":"https://github.com/dotnet/project-system/pull/2519"},"issue":{"href":"https://api.github.com/repos/dotnet/project-system/issues/2519"},"comments":{"href":"https://api.github.com/repos/dotnet/project-system/issues/2519/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/2519/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/2519/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/project-system/statuses/38e298c8c9b207d600d02d27d3c923b35aef15dd"}}}}
{"actor":{"display_login":"davkean"}}