{"action":"closed","number":5777,"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/5777","id":146715808,"html_url":"https://github.com/LLNL/spack/pull/5777","diff_url":"https://github.com/LLNL/spack/pull/5777.diff","patch_url":"https://github.com/LLNL/spack/pull/5777.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/5777","number":5777,"state":"closed","locked":false,"title":"armadillo: use libs to provide arpack and superlu libraries","user":{"login":"mfherbst","id":11157893,"avatar_url":"https://avatars0.githubusercontent.com/u/11157893?v=4","gravatar_id":"","url":"https://api.github.com/users/mfherbst","html_url":"https://github.com/mfherbst","followers_url":"https://api.github.com/users/mfherbst/followers","following_url":"https://api.github.com/users/mfherbst/following{/other_user}","gists_url":"https://api.github.com/users/mfherbst/gists{/gist_id}","starred_url":"https://api.github.com/users/mfherbst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfherbst/subscriptions","organizations_url":"https://api.github.com/users/mfherbst/orgs","repos_url":"https://api.github.com/users/mfherbst/repos","events_url":"https://api.github.com/users/mfherbst/events{/privacy}","received_events_url":"https://api.github.com/users/mfherbst/received_events","type":"User","site_admin":false},"body":"Currently the `find` function and hence `find_libraries` as well as `find_system_libraries` raise an `OSError` if the `root` path of their search does not exist. In my opinion it makes more sense to return an empty dictionary instead.\r\n\r\nNote, that this probably affects many packages which use `find`, `find_libraries` or variants thereof. I initially encountered the error while installing `armadillo` on an Ubuntu 14.04 machine, where arpack is placed in a `lib` subfolder and not `lib64` as the `armadillo` Spack package expects it.\r\n\r\nI fix that issue in the second commit. My point is, that this requires the extra explicit check whether the returned `LibraryList` is not empty. I am not really happy about this boilerplate, so please point me in a proper direction if you have a better idea how to fix this issue without potentially silently breaking the installation process of other packages.","created_at":"2017-10-16T07:43:25Z","updated_at":"2017-10-16T10:57:02Z","closed_at":"2017-10-16T10:57:02Z","merged_at":"2017-10-16T10:57:02Z","merge_commit_sha":"d0cf3db46e708497f5c8970d9e3f9b1787a93da4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars2.githubusercontent.com/u/12021217?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/5777/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/5777/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/5777/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/9899fe32a2e96ff903b0b2f503bddf08f6533789","head":{"label":"mfherbst:filesystem-dir-not-found","ref":"filesystem-dir-not-found","sha":"9899fe32a2e96ff903b0b2f503bddf08f6533789","user":{"login":"mfherbst","id":11157893,"avatar_url":"https://avatars0.githubusercontent.com/u/11157893?v=4","gravatar_id":"","url":"https://api.github.com/users/mfherbst","html_url":"https://github.com/mfherbst","followers_url":"https://api.github.com/users/mfherbst/followers","following_url":"https://api.github.com/users/mfherbst/following{/other_user}","gists_url":"https://api.github.com/users/mfherbst/gists{/gist_id}","starred_url":"https://api.github.com/users/mfherbst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfherbst/subscriptions","organizations_url":"https://api.github.com/users/mfherbst/orgs","repos_url":"https://api.github.com/users/mfherbst/repos","events_url":"https://api.github.com/users/mfherbst/events{/privacy}","received_events_url":"https://api.github.com/users/mfherbst/received_events","type":"User","site_admin":false},"repo":{"id":107010047,"name":"spack","full_name":"mfherbst/spack","owner":{"login":"mfherbst","id":11157893,"avatar_url":"https://avatars0.githubusercontent.com/u/11157893?v=4","gravatar_id":"","url":"https://api.github.com/users/mfherbst","html_url":"https://github.com/mfherbst","followers_url":"https://api.github.com/users/mfherbst/followers","following_url":"https://api.github.com/users/mfherbst/following{/other_user}","gists_url":"https://api.github.com/users/mfherbst/gists{/gist_id}","starred_url":"https://api.github.com/users/mfherbst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfherbst/subscriptions","organizations_url":"https://api.github.com/users/mfherbst/orgs","repos_url":"https://api.github.com/users/mfherbst/repos","events_url":"https://api.github.com/users/mfherbst/events{/privacy}","received_events_url":"https://api.github.com/users/mfherbst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfherbst/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/mfherbst/spack","forks_url":"https://api.github.com/repos/mfherbst/spack/forks","keys_url":"https://api.github.com/repos/mfherbst/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfherbst/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfherbst/spack/teams","hooks_url":"https://api.github.com/repos/mfherbst/spack/hooks","issue_events_url":"https://api.github.com/repos/mfherbst/spack/issues/events{/number}","events_url":"https://api.github.com/repos/mfherbst/spack/events","assignees_url":"https://api.github.com/repos/mfherbst/spack/assignees{/user}","branches_url":"https://api.github.com/repos/mfherbst/spack/branches{/branch}","tags_url":"https://api.github.com/repos/mfherbst/spack/tags","blobs_url":"https://api.github.com/repos/mfherbst/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfherbst/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfherbst/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfherbst/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfherbst/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/mfherbst/spack/languages","stargazers_url":"https://api.github.com/repos/mfherbst/spack/stargazers","contributors_url":"https://api.github.com/repos/mfherbst/spack/contributors","subscribers_url":"https://api.github.com/repos/mfherbst/spack/subscribers","subscription_url":"https://api.github.com/repos/mfherbst/spack/subscription","commits_url":"https://api.github.com/repos/mfherbst/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfherbst/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfherbst/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfherbst/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfherbst/spack/contents/{+path}","compare_url":"https://api.github.com/repos/mfherbst/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfherbst/spack/merges","archive_url":"https://api.github.com/repos/mfherbst/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfherbst/spack/downloads","issues_url":"https://api.github.com/repos/mfherbst/spack/issues{/number}","pulls_url":"https://api.github.com/repos/mfherbst/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/mfherbst/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/mfherbst/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfherbst/spack/labels{/name}","releases_url":"https://api.github.com/repos/mfherbst/spack/releases{/id}","deployments_url":"https://api.github.com/repos/mfherbst/spack/deployments","created_at":"2017-10-15T12:27:03Z","updated_at":"2017-10-15T12:27:10Z","pushed_at":"2017-10-16T09:18:58Z","git_url":"git://github.com/mfherbst/spack.git","ssh_url":"git@github.com:mfherbst/spack.git","clone_url":"https://github.com/mfherbst/spack.git","svn_url":"https://github.com/mfherbst/spack","homepage":"https://spack.io","size":31074,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"6c67de48e87b8301be10a2b89549eaabbed1a1da","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2017-10-15T14:53:25Z","pushed_at":"2017-10-16T10:57:02Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"https://spack.io","size":31078,"stargazers_count":374,"watchers_count":374,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"open_issues_count":758,"forks":310,"open_issues":758,"watchers":374,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/5777"},"html":{"href":"https://github.com/LLNL/spack/pull/5777"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/5777"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/5777/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/5777/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/5777/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/9899fe32a2e96ff903b0b2f503bddf08f6533789"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alalazo","id":4199709,"avatar_url":"https://avatars0.githubusercontent.com/u/4199709?v=4","gravatar_id":"","url":"https://api.github.com/users/alalazo","html_url":"https://github.com/alalazo","followers_url":"https://api.github.com/users/alalazo/followers","following_url":"https://api.github.com/users/alalazo/following{/other_user}","gists_url":"https://api.github.com/users/alalazo/gists{/gist_id}","starred_url":"https://api.github.com/users/alalazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalazo/subscriptions","organizations_url":"https://api.github.com/users/alalazo/orgs","repos_url":"https://api.github.com/users/alalazo/repos","events_url":"https://api.github.com/users/alalazo/events{/privacy}","received_events_url":"https://api.github.com/users/alalazo/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"maintainer_can_modify":false,"commits":7,"additions":4,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"alalazo"}}