{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip/pulls/comments/133496598","pull_request_review_id":56684005,"id":133496598,"diff_hunk":"@@ -81,6 +81,11 @@ def redirect_to_subdomain_login_url():\n     redirect_url = login_url + '?subdomain=1'\n     return HttpResponseRedirect(redirect_url)\n \n+def redirect_to_config_error():\n+    # type: () -> HttpResponseRedirect\n+    redirect_url = reverse('configuration-error', args=(\"google\",))\n+    return HttpResponseRedirect(redirect_url)","path":"zerver/views/auth.py","position":7,"original_position":7,"commit_id":"3761e92fbbe2a45b44be73150f3fbb2671d75c83","original_commit_id":"3761e92fbbe2a45b44be73150f3fbb2671d75c83","user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars0.githubusercontent.com/u/2746074?v=4","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"body":"I redid this in a way that should work better.","created_at":"2017-08-16T16:13:56Z","updated_at":"2017-08-16T16:17:52Z","html_url":"https://github.com/zulip/zulip/pull/6047#discussion_r133496598","pull_request_url":"https://api.github.com/repos/zulip/zulip/pulls/6047","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments/133496598"},"html":{"href":"https://github.com/zulip/zulip/pull/6047#discussion_r133496598"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6047"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/6047","id":134467866,"html_url":"https://github.com/zulip/zulip/pull/6047","diff_url":"https://github.com/zulip/zulip/pull/6047.diff","patch_url":"https://github.com/zulip/zulip/pull/6047.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/6047","number":6047,"state":"open","locked":false,"title":"auth.py: Add warning for misconfigured github/google auth.","user":{"login":"vaidap","id":13666710,"avatar_url":"https://avatars3.githubusercontent.com/u/13666710?v=4","gravatar_id":"","url":"https://api.github.com/users/vaidap","html_url":"https://github.com/vaidap","followers_url":"https://api.github.com/users/vaidap/followers","following_url":"https://api.github.com/users/vaidap/following{/other_user}","gists_url":"https://api.github.com/users/vaidap/gists{/gist_id}","starred_url":"https://api.github.com/users/vaidap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaidap/subscriptions","organizations_url":"https://api.github.com/users/vaidap/orgs","repos_url":"https://api.github.com/users/vaidap/repos","events_url":"https://api.github.com/users/vaidap/events{/privacy}","received_events_url":"https://api.github.com/users/vaidap/received_events","type":"User","site_admin":false},"body":"Continuation of #5883 -- adding a warning for devs that they haven't configured the google/github auths correctly for the case where they forget to restart the dev environment.\r\n\r\nNot sure whether in what form the error message should appear-- as an appended text in the buttons, or as a new page that the user gets redirected to? ","created_at":"2017-08-07T15:41:34Z","updated_at":"2017-08-16T16:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05642c0d913948c16b56ff4f78a98332a51d709b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/6047/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/6047/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/6047/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/3761e92fbbe2a45b44be73150f3fbb2671d75c83","head":{"label":"vaidap:5883-2","ref":"5883-2","sha":"3761e92fbbe2a45b44be73150f3fbb2671d75c83","user":{"login":"vaidap","id":13666710,"avatar_url":"https://avatars3.githubusercontent.com/u/13666710?v=4","gravatar_id":"","url":"https://api.github.com/users/vaidap","html_url":"https://github.com/vaidap","followers_url":"https://api.github.com/users/vaidap/followers","following_url":"https://api.github.com/users/vaidap/following{/other_user}","gists_url":"https://api.github.com/users/vaidap/gists{/gist_id}","starred_url":"https://api.github.com/users/vaidap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaidap/subscriptions","organizations_url":"https://api.github.com/users/vaidap/orgs","repos_url":"https://api.github.com/users/vaidap/repos","events_url":"https://api.github.com/users/vaidap/events{/privacy}","received_events_url":"https://api.github.com/users/vaidap/received_events","type":"User","site_admin":false},"repo":{"id":84660987,"name":"zulip","full_name":"vaidap/zulip","owner":{"login":"vaidap","id":13666710,"avatar_url":"https://avatars3.githubusercontent.com/u/13666710?v=4","gravatar_id":"","url":"https://api.github.com/users/vaidap","html_url":"https://github.com/vaidap","followers_url":"https://api.github.com/users/vaidap/followers","following_url":"https://api.github.com/users/vaidap/following{/other_user}","gists_url":"https://api.github.com/users/vaidap/gists{/gist_id}","starred_url":"https://api.github.com/users/vaidap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaidap/subscriptions","organizations_url":"https://api.github.com/users/vaidap/orgs","repos_url":"https://api.github.com/users/vaidap/repos","events_url":"https://api.github.com/users/vaidap/events{/privacy}","received_events_url":"https://api.github.com/users/vaidap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vaidap/zulip","description":"Zulip server - powerful open source group chat","fork":true,"url":"https://api.github.com/repos/vaidap/zulip","forks_url":"https://api.github.com/repos/vaidap/zulip/forks","keys_url":"https://api.github.com/repos/vaidap/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaidap/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaidap/zulip/teams","hooks_url":"https://api.github.com/repos/vaidap/zulip/hooks","issue_events_url":"https://api.github.com/repos/vaidap/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/vaidap/zulip/events","assignees_url":"https://api.github.com/repos/vaidap/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/vaidap/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/vaidap/zulip/tags","blobs_url":"https://api.github.com/repos/vaidap/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaidap/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaidap/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaidap/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaidap/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/vaidap/zulip/languages","stargazers_url":"https://api.github.com/repos/vaidap/zulip/stargazers","contributors_url":"https://api.github.com/repos/vaidap/zulip/contributors","subscribers_url":"https://api.github.com/repos/vaidap/zulip/subscribers","subscription_url":"https://api.github.com/repos/vaidap/zulip/subscription","commits_url":"https://api.github.com/repos/vaidap/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaidap/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaidap/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaidap/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaidap/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/vaidap/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaidap/zulip/merges","archive_url":"https://api.github.com/repos/vaidap/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaidap/zulip/downloads","issues_url":"https://api.github.com/repos/vaidap/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/vaidap/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/vaidap/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/vaidap/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaidap/zulip/labels{/name}","releases_url":"https://api.github.com/repos/vaidap/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/vaidap/zulip/deployments","created_at":"2017-03-11T15:46:44Z","updated_at":"2017-03-11T15:46:51Z","pushed_at":"2017-08-16T16:15:37Z","git_url":"git://github.com/vaidap/zulip.git","ssh_url":"git@github.com:vaidap/zulip.git","clone_url":"https://github.com/vaidap/zulip.git","svn_url":"https://github.com/vaidap/zulip","homepage":"","size":167949,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"84da22da67058b1c1e87a254ffecae6487bdbd7f","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"name":"zulip","full_name":"zulip/zulip","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source group chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2017-08-16T12:34:19Z","pushed_at":"2017-08-16T16:15:40Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"","size":167377,"stargazers_count":5116,"watchers_count":5116,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1436,"mirror_url":null,"open_issues_count":858,"forks":1436,"open_issues":858,"watchers":5116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6047"},"html":{"href":"https://github.com/zulip/zulip/pull/6047"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/6047"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/6047/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6047/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6047/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/3761e92fbbe2a45b44be73150f3fbb2671d75c83"}}}}
{"actor":{"display_login":"timabbott"}}