{"action":"created","issue":{"url":"https://api.github.com/repos/walmartlabs/lacinia/issues/82","repository_url":"https://api.github.com/repos/walmartlabs/lacinia","labels_url":"https://api.github.com/repos/walmartlabs/lacinia/issues/82/labels{/name}","comments_url":"https://api.github.com/repos/walmartlabs/lacinia/issues/82/comments","events_url":"https://api.github.com/repos/walmartlabs/lacinia/issues/82/events","html_url":"https://github.com/walmartlabs/lacinia/issues/82","id":235731193,"number":82,"title":"Exception catching is too aggressive","user":{"login":"geremih","id":1194396,"avatar_url":"https://avatars2.githubusercontent.com/u/1194396?v=3","gravatar_id":"","url":"https://api.github.com/users/geremih","html_url":"https://github.com/geremih","followers_url":"https://api.github.com/users/geremih/followers","following_url":"https://api.github.com/users/geremih/following{/other_user}","gists_url":"https://api.github.com/users/geremih/gists{/gist_id}","starred_url":"https://api.github.com/users/geremih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geremih/subscriptions","organizations_url":"https://api.github.com/users/geremih/orgs","repos_url":"https://api.github.com/users/geremih/repos","events_url":"https://api.github.com/users/geremih/events{/privacy}","received_events_url":"https://api.github.com/users/geremih/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-14T00:40:22Z","updated_at":"2017-06-16T22:55:51Z","closed_at":null,"body":"In the current implementation, any exception thrown by a field-resolver is caught by `execute` and only the message is passed through. I had to checkout the repo and remove all the catch statement  to find the issue in my code.  Would it be possible to have an option to toggle the verbosity of the errors, or whether to throw them or not?\r\n\r\nThe error in my case was because the keys in the `variables` I was passing in were strings and lacinia was expecting keywords, which led to NullPointer exceptions down the line."},"comment":{"url":"https://api.github.com/repos/walmartlabs/lacinia/issues/comments/309157497","html_url":"https://github.com/walmartlabs/lacinia/issues/82#issuecomment-309157497","issue_url":"https://api.github.com/repos/walmartlabs/lacinia/issues/82","id":309157497,"user":{"login":"geremih","id":1194396,"avatar_url":"https://avatars2.githubusercontent.com/u/1194396?v=3","gravatar_id":"","url":"https://api.github.com/users/geremih","html_url":"https://github.com/geremih","followers_url":"https://api.github.com/users/geremih/followers","following_url":"https://api.github.com/users/geremih/following{/other_user}","gists_url":"https://api.github.com/users/geremih/gists{/gist_id}","starred_url":"https://api.github.com/users/geremih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geremih/subscriptions","organizations_url":"https://api.github.com/users/geremih/orgs","repos_url":"https://api.github.com/users/geremih/repos","events_url":"https://api.github.com/users/geremih/events{/privacy}","received_events_url":"https://api.github.com/users/geremih/received_events","type":"User","site_admin":false},"created_at":"2017-06-16T22:55:51Z","updated_at":"2017-06-16T22:55:51Z","body":"@hlship\r\nWhat's the reason behind not liking  exception callbacks? It allows the user to specify how to handle exceptions and at the same time lets lacinia return errors that conform to the spec.\r\nCheaper alternatives would be to not catch the exceptions and have the user handle it along with  spec compliance, as implementation details are already being leaked in the form of exception messages (less insecure than a full blown trace, but still).\r\n\r\n"}}
{"actor":{"display_login":"geremih"}}