{"push_id":1713488462,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"3791abd6288c49b2ea9083d4e5edb23beb4d8fd4","before":"29f37fde3e52810aa88231a2c6ec1f29e0be7c39","commits":[{"sha":"f73e3cbb30bdfa8a8cb7d513231d29d6b513b82f","author":{"name":"Jeff Grafton","email":"37780e769b84e50aeec1ef2668f6dba1732f01bc@google.com"},"message":"Use munged semantic version for side-loaded docker tag","distinct":true,"url":"https://api.github.com/repos/kubernetes/kubernetes/commits/f73e3cbb30bdfa8a8cb7d513231d29d6b513b82f"},{"sha":"3791abd6288c49b2ea9083d4e5edb23beb4d8fd4","author":{"name":"Kubernetes Submit Queue","email":"260061d766fe633e5411cb223defd984f1ece7b6@users.noreply.github.com"},"message":"Merge pull request #44981 from ixdy/version-docker-tag\n\nAutomatic merge from submit-queue\n\nUse munged semantic version for side-loaded docker tag\n\n**What this PR does / why we need it**: rather than using the md5sum of the dockerized binary for each side-loaded docker image, use the semantic version (with `+`s replaced with `_`s) for the side-loaded docker images.\r\n\r\nThe use of the md5sum for the docker tag dates to #6326 2 years ago. I'm not sure why that was chosen, short of it being fairly unique.\r\n\r\nMy main motivation for changing this is that it makes building the docker images using Bazel's docker rules easier, since the semantic version doesn't depend on the build output.\r\n\r\nAn added benefit is that the list of images on a running kubernetes cluster is also more straightfoward; rather than a list of opaque, meaningless hexadecimal strings, you get something that indicates the provenance of the image. It'd also be clearer that all of the images came from the same build.\r\n\r\nI was able to start a cluster with this change on GCE using both `make quick-release` and `make bazel-release`.\r\n\r\nNote that this change has no effect on the tag that's pushed to gcr.io during releases; that's still controlled via `KUBE_IMAGE_DOCKER_TAG`, though we may want to merge this functionality at some point.\r\n\r\n@kubernetes/sig-node-pr-reviews is there any reason to stick with using the md5sum strategy? @dchen1107 do you remember why we went with md5sums originally?\r\ncc @spxtr @mikedanese \r\n\r\n**Release note**:\r\n\r\n```release-note\r\n```","distinct":true,"url":"https://api.github.com/repos/kubernetes/kubernetes/commits/3791abd6288c49b2ea9083d4e5edb23beb4d8fd4"}]}
{"actor":{"display_login":"k8s-merge-robot"}}