{"action":"opened","number":797,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/797","id":141233493,"html_url":"https://github.com/GoogleChrome/puppeteer/pull/797","diff_url":"https://github.com/GoogleChrome/puppeteer/pull/797.diff","patch_url":"https://github.com/GoogleChrome/puppeteer/pull/797.patch","issue_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/797","number":797,"state":"open","locked":false,"title":"doc: add `await` to `browser.close` in usage examples","user":{"login":"cohesively","id":9100299,"avatar_url":"https://avatars0.githubusercontent.com/u/9100299?v=4","gravatar_id":"","url":"https://api.github.com/users/cohesively","html_url":"https://github.com/cohesively","followers_url":"https://api.github.com/users/cohesively/followers","following_url":"https://api.github.com/users/cohesively/following{/other_user}","gists_url":"https://api.github.com/users/cohesively/gists{/gist_id}","starred_url":"https://api.github.com/users/cohesively/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cohesively/subscriptions","organizations_url":"https://api.github.com/users/cohesively/orgs","repos_url":"https://api.github.com/users/cohesively/repos","events_url":"https://api.github.com/users/cohesively/events{/privacy}","received_events_url":"https://api.github.com/users/cohesively/received_events","type":"User","site_admin":false},"body":"Since f398e69dbbedf1d0d20274a79d31bca24e5a7b2d updated `browser.close` to return a promise, the usage examples should be updated to reflect the new signature.","created_at":"2017-09-15T05:53:22Z","updated_at":"2017-09-15T05:53:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/797/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/797/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/797/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/puppeteer/statuses/206040a51263e0afbe60480ddd98e2b174df56ba","head":{"label":"cohesively:update-doc-browser_close","ref":"update-doc-browser_close","sha":"206040a51263e0afbe60480ddd98e2b174df56ba","user":{"login":"cohesively","id":9100299,"avatar_url":"https://avatars0.githubusercontent.com/u/9100299?v=4","gravatar_id":"","url":"https://api.github.com/users/cohesively","html_url":"https://github.com/cohesively","followers_url":"https://api.github.com/users/cohesively/followers","following_url":"https://api.github.com/users/cohesively/following{/other_user}","gists_url":"https://api.github.com/users/cohesively/gists{/gist_id}","starred_url":"https://api.github.com/users/cohesively/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cohesively/subscriptions","organizations_url":"https://api.github.com/users/cohesively/orgs","repos_url":"https://api.github.com/users/cohesively/repos","events_url":"https://api.github.com/users/cohesively/events{/privacy}","received_events_url":"https://api.github.com/users/cohesively/received_events","type":"User","site_admin":false},"repo":{"id":103618914,"name":"puppeteer","full_name":"cohesively/puppeteer","owner":{"login":"cohesively","id":9100299,"avatar_url":"https://avatars0.githubusercontent.com/u/9100299?v=4","gravatar_id":"","url":"https://api.github.com/users/cohesively","html_url":"https://github.com/cohesively","followers_url":"https://api.github.com/users/cohesively/followers","following_url":"https://api.github.com/users/cohesively/following{/other_user}","gists_url":"https://api.github.com/users/cohesively/gists{/gist_id}","starred_url":"https://api.github.com/users/cohesively/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cohesively/subscriptions","organizations_url":"https://api.github.com/users/cohesively/orgs","repos_url":"https://api.github.com/users/cohesively/repos","events_url":"https://api.github.com/users/cohesively/events{/privacy}","received_events_url":"https://api.github.com/users/cohesively/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cohesively/puppeteer","description":"Headless Chrome Node API","fork":true,"url":"https://api.github.com/repos/cohesively/puppeteer","forks_url":"https://api.github.com/repos/cohesively/puppeteer/forks","keys_url":"https://api.github.com/repos/cohesively/puppeteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cohesively/puppeteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cohesively/puppeteer/teams","hooks_url":"https://api.github.com/repos/cohesively/puppeteer/hooks","issue_events_url":"https://api.github.com/repos/cohesively/puppeteer/issues/events{/number}","events_url":"https://api.github.com/repos/cohesively/puppeteer/events","assignees_url":"https://api.github.com/repos/cohesively/puppeteer/assignees{/user}","branches_url":"https://api.github.com/repos/cohesively/puppeteer/branches{/branch}","tags_url":"https://api.github.com/repos/cohesively/puppeteer/tags","blobs_url":"https://api.github.com/repos/cohesively/puppeteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cohesively/puppeteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cohesively/puppeteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cohesively/puppeteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cohesively/puppeteer/statuses/{sha}","languages_url":"https://api.github.com/repos/cohesively/puppeteer/languages","stargazers_url":"https://api.github.com/repos/cohesively/puppeteer/stargazers","contributors_url":"https://api.github.com/repos/cohesively/puppeteer/contributors","subscribers_url":"https://api.github.com/repos/cohesively/puppeteer/subscribers","subscription_url":"https://api.github.com/repos/cohesively/puppeteer/subscription","commits_url":"https://api.github.com/repos/cohesively/puppeteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cohesively/puppeteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cohesively/puppeteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cohesively/puppeteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cohesively/puppeteer/contents/{+path}","compare_url":"https://api.github.com/repos/cohesively/puppeteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cohesively/puppeteer/merges","archive_url":"https://api.github.com/repos/cohesively/puppeteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cohesively/puppeteer/downloads","issues_url":"https://api.github.com/repos/cohesively/puppeteer/issues{/number}","pulls_url":"https://api.github.com/repos/cohesively/puppeteer/pulls{/number}","milestones_url":"https://api.github.com/repos/cohesively/puppeteer/milestones{/number}","notifications_url":"https://api.github.com/repos/cohesively/puppeteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cohesively/puppeteer/labels{/name}","releases_url":"https://api.github.com/repos/cohesively/puppeteer/releases{/id}","deployments_url":"https://api.github.com/repos/cohesively/puppeteer/deployments","created_at":"2017-09-15T05:48:01Z","updated_at":"2017-09-15T05:48:03Z","pushed_at":"2017-09-15T05:52:44Z","git_url":"git://github.com/cohesively/puppeteer.git","ssh_url":"git@github.com:cohesively/puppeteer.git","clone_url":"https://github.com/cohesively/puppeteer.git","svn_url":"https://github.com/cohesively/puppeteer","homepage":null,"size":1822,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"d562db31403a703cbb7db6d206d6ea6c8c3463b4","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":90796663,"name":"puppeteer","full_name":"GoogleChrome/puppeteer","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/puppeteer","description":"Headless Chrome Node API","fork":false,"url":"https://api.github.com/repos/GoogleChrome/puppeteer","forks_url":"https://api.github.com/repos/GoogleChrome/puppeteer/forks","keys_url":"https://api.github.com/repos/GoogleChrome/puppeteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/puppeteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/puppeteer/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/puppeteer/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/puppeteer/events","assignees_url":"https://api.github.com/repos/GoogleChrome/puppeteer/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/puppeteer/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/puppeteer/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/puppeteer/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/puppeteer/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/puppeteer/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/puppeteer/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/puppeteer/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/puppeteer/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/puppeteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/puppeteer/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/puppeteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/puppeteer/merges","archive_url":"https://api.github.com/repos/GoogleChrome/puppeteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/puppeteer/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/puppeteer/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/puppeteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/puppeteer/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/puppeteer/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/deployments","created_at":"2017-05-09T22:16:13Z","updated_at":"2017-09-15T05:51:24Z","pushed_at":"2017-09-15T05:24:50Z","git_url":"git://github.com/GoogleChrome/puppeteer.git","ssh_url":"git@github.com:GoogleChrome/puppeteer.git","clone_url":"https://github.com/GoogleChrome/puppeteer.git","svn_url":"https://github.com/GoogleChrome/puppeteer","homepage":null,"size":1822,"stargazers_count":13757,"watchers_count":13757,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":459,"mirror_url":null,"open_issues_count":106,"forks":459,"open_issues":106,"watchers":13757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/797"},"html":{"href":"https://github.com/GoogleChrome/puppeteer/pull/797"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/797"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/statuses/206040a51263e0afbe60480ddd98e2b174df56ba"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":24,"deletions":24,"changed_files":10}}
{"actor":{"display_login":"cohesively"}}