{"action":"created","comment":{"url":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/comments/110159608","pull_request_review_id":31310448,"id":110159608,"diff_hunk":"@@ -28,7 +28,7 @@ spec:\n     spec:\n       restartPolicy: OnFailure\n       nodeSelector:\n-        {{ .Values.labels.control_node_selector_key }}: {{ .Values.labels.control_node_selector_value }}\n+        {{ .Values.labels.job.node_selector_key }}: {{ .Values.labels.job.node_selector_value }}","path":"nova/templates/job-db-sync.yaml","position":5,"original_position":5,"commit_id":"fd953d82f3dcbd26500455b5194eeeff11c0d1d8","original_commit_id":"fd953d82f3dcbd26500455b5194eeeff11c0d1d8","user":{"login":"intlabs","id":3317808,"avatar_url":"https://avatars2.githubusercontent.com/u/3317808?v=3","gravatar_id":"","url":"https://api.github.com/users/intlabs","html_url":"https://github.com/intlabs","followers_url":"https://api.github.com/users/intlabs/followers","following_url":"https://api.github.com/users/intlabs/following{/other_user}","gists_url":"https://api.github.com/users/intlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/intlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intlabs/subscriptions","organizations_url":"https://api.github.com/users/intlabs/orgs","repos_url":"https://api.github.com/users/intlabs/repos","events_url":"https://api.github.com/users/intlabs/events{/privacy}","received_events_url":"https://api.github.com/users/intlabs/received_events","type":"User","site_admin":false},"body":"Though unlikely there is a small possibility that some people may want to do this; as these pods will contain things like root db creds that the wider control-plane population will never see.","created_at":"2017-04-06T13:23:52Z","updated_at":"2017-04-06T13:23:52Z","html_url":"https://github.com/att-comdev/openstack-helm/pull/302#discussion_r110159608","pull_request_url":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/comments/110159608"},"html":{"href":"https://github.com/att-comdev/openstack-helm/pull/302#discussion_r110159608"},"pull_request":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302","id":112160228,"html_url":"https://github.com/att-comdev/openstack-helm/pull/302","diff_url":"https://github.com/att-comdev/openstack-helm/pull/302.diff","patch_url":"https://github.com/att-comdev/openstack-helm/pull/302.patch","issue_url":"https://api.github.com/repos/att-comdev/openstack-helm/issues/302","number":302,"state":"open","locked":false,"title":"Issue #207 Stnd control plane node issue","user":{"login":"renmak","id":1091673,"avatar_url":"https://avatars3.githubusercontent.com/u/1091673?v=3","gravatar_id":"","url":"https://api.github.com/users/renmak","html_url":"https://github.com/renmak","followers_url":"https://api.github.com/users/renmak/followers","following_url":"https://api.github.com/users/renmak/following{/other_user}","gists_url":"https://api.github.com/users/renmak/gists{/gist_id}","starred_url":"https://api.github.com/users/renmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renmak/subscriptions","organizations_url":"https://api.github.com/users/renmak/orgs","repos_url":"https://api.github.com/users/renmak/repos","events_url":"https://api.github.com/users/renmak/events{/privacy}","received_events_url":"https://api.github.com/users/renmak/received_events","type":"User","site_admin":false},"body":"<!--  \r\n      Thanks for contributing to OpenStack-Helm!  Please be thorough\r\n      when filling out your pull request. If the purpose for your pull\r\n      request is not clear, we may close your pull request and ask you\r\n      to resubmit.\r\n-->\r\n\r\n**What is the purpose of this pull request?**: Updating Nova label name and value to align with how labels are used in Neutron\r\n\r\n**What issue does this pull request address?**: Fixes issue #207. Also this new PR replaces previous PR #285\r\n\r\n**Notes for reviewers to consider**: Please look at comment from Allan in PR #285. My new changes in this PR are based on his comment. \r\n\r\n**Specific reviewers for pull request**: @alanmeadows @v1k0d3n\r\n","created_at":"2017-03-23T04:24:41Z","updated_at":"2017-04-06T13:23:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d55a26cc7c2d2f8299da0f2cd504932905fbf99","assignee":{"login":"renmak","id":1091673,"avatar_url":"https://avatars3.githubusercontent.com/u/1091673?v=3","gravatar_id":"","url":"https://api.github.com/users/renmak","html_url":"https://github.com/renmak","followers_url":"https://api.github.com/users/renmak/followers","following_url":"https://api.github.com/users/renmak/following{/other_user}","gists_url":"https://api.github.com/users/renmak/gists{/gist_id}","starred_url":"https://api.github.com/users/renmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renmak/subscriptions","organizations_url":"https://api.github.com/users/renmak/orgs","repos_url":"https://api.github.com/users/renmak/repos","events_url":"https://api.github.com/users/renmak/events{/privacy}","received_events_url":"https://api.github.com/users/renmak/received_events","type":"User","site_admin":false},"assignees":[{"login":"renmak","id":1091673,"avatar_url":"https://avatars3.githubusercontent.com/u/1091673?v=3","gravatar_id":"","url":"https://api.github.com/users/renmak","html_url":"https://github.com/renmak","followers_url":"https://api.github.com/users/renmak/followers","following_url":"https://api.github.com/users/renmak/following{/other_user}","gists_url":"https://api.github.com/users/renmak/gists{/gist_id}","starred_url":"https://api.github.com/users/renmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renmak/subscriptions","organizations_url":"https://api.github.com/users/renmak/orgs","repos_url":"https://api.github.com/users/renmak/repos","events_url":"https://api.github.com/users/renmak/events{/privacy}","received_events_url":"https://api.github.com/users/renmak/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/att-comdev/openstack-helm/milestones/3","html_url":"https://github.com/att-comdev/openstack-helm/milestone/3","labels_url":"https://api.github.com/repos/att-comdev/openstack-helm/milestones/3/labels","id":2272116,"number":3,"title":"0.3.0","description":"","creator":{"login":"v1k0d3n","id":7780945,"avatar_url":"https://avatars3.githubusercontent.com/u/7780945?v=3","gravatar_id":"","url":"https://api.github.com/users/v1k0d3n","html_url":"https://github.com/v1k0d3n","followers_url":"https://api.github.com/users/v1k0d3n/followers","following_url":"https://api.github.com/users/v1k0d3n/following{/other_user}","gists_url":"https://api.github.com/users/v1k0d3n/gists{/gist_id}","starred_url":"https://api.github.com/users/v1k0d3n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v1k0d3n/subscriptions","organizations_url":"https://api.github.com/users/v1k0d3n/orgs","repos_url":"https://api.github.com/users/v1k0d3n/repos","events_url":"https://api.github.com/users/v1k0d3n/events{/privacy}","received_events_url":"https://api.github.com/users/v1k0d3n/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":41,"state":"open","created_at":"2017-01-23T17:53:54Z","updated_at":"2017-04-06T12:32:58Z","due_on":"2017-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302/commits","review_comments_url":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302/comments","review_comment_url":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/att-comdev/openstack-helm/issues/302/comments","statuses_url":"https://api.github.com/repos/att-comdev/openstack-helm/statuses/fd953d82f3dcbd26500455b5194eeeff11c0d1d8","head":{"label":"renmak:stnd_control_plane_node_issue_207","ref":"stnd_control_plane_node_issue_207","sha":"fd953d82f3dcbd26500455b5194eeeff11c0d1d8","user":{"login":"renmak","id":1091673,"avatar_url":"https://avatars3.githubusercontent.com/u/1091673?v=3","gravatar_id":"","url":"https://api.github.com/users/renmak","html_url":"https://github.com/renmak","followers_url":"https://api.github.com/users/renmak/followers","following_url":"https://api.github.com/users/renmak/following{/other_user}","gists_url":"https://api.github.com/users/renmak/gists{/gist_id}","starred_url":"https://api.github.com/users/renmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renmak/subscriptions","organizations_url":"https://api.github.com/users/renmak/orgs","repos_url":"https://api.github.com/users/renmak/repos","events_url":"https://api.github.com/users/renmak/events{/privacy}","received_events_url":"https://api.github.com/users/renmak/received_events","type":"User","site_admin":false},"repo":{"id":84980394,"name":"openstack-helm","full_name":"renmak/openstack-helm","owner":{"login":"renmak","id":1091673,"avatar_url":"https://avatars3.githubusercontent.com/u/1091673?v=3","gravatar_id":"","url":"https://api.github.com/users/renmak","html_url":"https://github.com/renmak","followers_url":"https://api.github.com/users/renmak/followers","following_url":"https://api.github.com/users/renmak/following{/other_user}","gists_url":"https://api.github.com/users/renmak/gists{/gist_id}","starred_url":"https://api.github.com/users/renmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renmak/subscriptions","organizations_url":"https://api.github.com/users/renmak/orgs","repos_url":"https://api.github.com/users/renmak/repos","events_url":"https://api.github.com/users/renmak/events{/privacy}","received_events_url":"https://api.github.com/users/renmak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renmak/openstack-helm","description":"A collection of community-provided Kubernetes/Helm charts, for the deployment and continued development lifecycle of containerized Openstack services on Kubernetes.","fork":true,"url":"https://api.github.com/repos/renmak/openstack-helm","forks_url":"https://api.github.com/repos/renmak/openstack-helm/forks","keys_url":"https://api.github.com/repos/renmak/openstack-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renmak/openstack-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renmak/openstack-helm/teams","hooks_url":"https://api.github.com/repos/renmak/openstack-helm/hooks","issue_events_url":"https://api.github.com/repos/renmak/openstack-helm/issues/events{/number}","events_url":"https://api.github.com/repos/renmak/openstack-helm/events","assignees_url":"https://api.github.com/repos/renmak/openstack-helm/assignees{/user}","branches_url":"https://api.github.com/repos/renmak/openstack-helm/branches{/branch}","tags_url":"https://api.github.com/repos/renmak/openstack-helm/tags","blobs_url":"https://api.github.com/repos/renmak/openstack-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renmak/openstack-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renmak/openstack-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/renmak/openstack-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renmak/openstack-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/renmak/openstack-helm/languages","stargazers_url":"https://api.github.com/repos/renmak/openstack-helm/stargazers","contributors_url":"https://api.github.com/repos/renmak/openstack-helm/contributors","subscribers_url":"https://api.github.com/repos/renmak/openstack-helm/subscribers","subscription_url":"https://api.github.com/repos/renmak/openstack-helm/subscription","commits_url":"https://api.github.com/repos/renmak/openstack-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/renmak/openstack-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/renmak/openstack-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/renmak/openstack-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/renmak/openstack-helm/contents/{+path}","compare_url":"https://api.github.com/repos/renmak/openstack-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renmak/openstack-helm/merges","archive_url":"https://api.github.com/repos/renmak/openstack-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renmak/openstack-helm/downloads","issues_url":"https://api.github.com/repos/renmak/openstack-helm/issues{/number}","pulls_url":"https://api.github.com/repos/renmak/openstack-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/renmak/openstack-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/renmak/openstack-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renmak/openstack-helm/labels{/name}","releases_url":"https://api.github.com/repos/renmak/openstack-helm/releases{/id}","deployments_url":"https://api.github.com/repos/renmak/openstack-helm/deployments","created_at":"2017-03-14T17:53:00Z","updated_at":"2017-03-14T17:53:02Z","pushed_at":"2017-03-29T18:58:45Z","git_url":"git://github.com/renmak/openstack-helm.git","ssh_url":"git@github.com:renmak/openstack-helm.git","clone_url":"https://github.com/renmak/openstack-helm.git","svn_url":"https://github.com/renmak/openstack-helm","homepage":"","size":831,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"att-comdev:master","ref":"master","sha":"e1665cb1938482b60ae60f8392dfee5b026fd0a2","user":{"login":"att-comdev","id":21696220,"avatar_url":"https://avatars1.githubusercontent.com/u/21696220?v=3","gravatar_id":"","url":"https://api.github.com/users/att-comdev","html_url":"https://github.com/att-comdev","followers_url":"https://api.github.com/users/att-comdev/followers","following_url":"https://api.github.com/users/att-comdev/following{/other_user}","gists_url":"https://api.github.com/users/att-comdev/gists{/gist_id}","starred_url":"https://api.github.com/users/att-comdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/att-comdev/subscriptions","organizations_url":"https://api.github.com/users/att-comdev/orgs","repos_url":"https://api.github.com/users/att-comdev/repos","events_url":"https://api.github.com/users/att-comdev/events{/privacy}","received_events_url":"https://api.github.com/users/att-comdev/received_events","type":"Organization","site_admin":false},"repo":{"id":73573528,"name":"openstack-helm","full_name":"att-comdev/openstack-helm","owner":{"login":"att-comdev","id":21696220,"avatar_url":"https://avatars1.githubusercontent.com/u/21696220?v=3","gravatar_id":"","url":"https://api.github.com/users/att-comdev","html_url":"https://github.com/att-comdev","followers_url":"https://api.github.com/users/att-comdev/followers","following_url":"https://api.github.com/users/att-comdev/following{/other_user}","gists_url":"https://api.github.com/users/att-comdev/gists{/gist_id}","starred_url":"https://api.github.com/users/att-comdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/att-comdev/subscriptions","organizations_url":"https://api.github.com/users/att-comdev/orgs","repos_url":"https://api.github.com/users/att-comdev/repos","events_url":"https://api.github.com/users/att-comdev/events{/privacy}","received_events_url":"https://api.github.com/users/att-comdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/att-comdev/openstack-helm","description":"A collection of community-provided Kubernetes/Helm charts, for the deployment and continued development lifecycle of containerized Openstack services on Kubernetes.","fork":false,"url":"https://api.github.com/repos/att-comdev/openstack-helm","forks_url":"https://api.github.com/repos/att-comdev/openstack-helm/forks","keys_url":"https://api.github.com/repos/att-comdev/openstack-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/att-comdev/openstack-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/att-comdev/openstack-helm/teams","hooks_url":"https://api.github.com/repos/att-comdev/openstack-helm/hooks","issue_events_url":"https://api.github.com/repos/att-comdev/openstack-helm/issues/events{/number}","events_url":"https://api.github.com/repos/att-comdev/openstack-helm/events","assignees_url":"https://api.github.com/repos/att-comdev/openstack-helm/assignees{/user}","branches_url":"https://api.github.com/repos/att-comdev/openstack-helm/branches{/branch}","tags_url":"https://api.github.com/repos/att-comdev/openstack-helm/tags","blobs_url":"https://api.github.com/repos/att-comdev/openstack-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/att-comdev/openstack-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/att-comdev/openstack-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/att-comdev/openstack-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/att-comdev/openstack-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/att-comdev/openstack-helm/languages","stargazers_url":"https://api.github.com/repos/att-comdev/openstack-helm/stargazers","contributors_url":"https://api.github.com/repos/att-comdev/openstack-helm/contributors","subscribers_url":"https://api.github.com/repos/att-comdev/openstack-helm/subscribers","subscription_url":"https://api.github.com/repos/att-comdev/openstack-helm/subscription","commits_url":"https://api.github.com/repos/att-comdev/openstack-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/att-comdev/openstack-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/att-comdev/openstack-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/att-comdev/openstack-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/att-comdev/openstack-helm/contents/{+path}","compare_url":"https://api.github.com/repos/att-comdev/openstack-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/att-comdev/openstack-helm/merges","archive_url":"https://api.github.com/repos/att-comdev/openstack-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/att-comdev/openstack-helm/downloads","issues_url":"https://api.github.com/repos/att-comdev/openstack-helm/issues{/number}","pulls_url":"https://api.github.com/repos/att-comdev/openstack-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/att-comdev/openstack-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/att-comdev/openstack-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/att-comdev/openstack-helm/labels{/name}","releases_url":"https://api.github.com/repos/att-comdev/openstack-helm/releases{/id}","deployments_url":"https://api.github.com/repos/att-comdev/openstack-helm/deployments","created_at":"2016-11-12T19:26:57Z","updated_at":"2017-04-06T02:23:23Z","pushed_at":"2017-04-05T22:06:41Z","git_url":"git://github.com/att-comdev/openstack-helm.git","ssh_url":"git@github.com:att-comdev/openstack-helm.git","clone_url":"https://github.com/att-comdev/openstack-helm.git","svn_url":"https://github.com/att-comdev/openstack-helm","homepage":"","size":1242,"stargazers_count":70,"watchers_count":70,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":49,"forks":46,"open_issues":49,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302"},"html":{"href":"https://github.com/att-comdev/openstack-helm/pull/302"},"issue":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/issues/302"},"comments":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/att-comdev/openstack-helm/statuses/fd953d82f3dcbd26500455b5194eeeff11c0d1d8"}}}}
{"actor":{"display_login":"intlabs"}}