{"action":"created","issue":{"url":"https://api.github.com/repos/NoRedInk/rubocop-nri/issues/1","repository_url":"https://api.github.com/repos/NoRedInk/rubocop-nri","labels_url":"https://api.github.com/repos/NoRedInk/rubocop-nri/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/NoRedInk/rubocop-nri/issues/1/comments","events_url":"https://api.github.com/repos/NoRedInk/rubocop-nri/issues/1/events","html_url":"https://github.com/NoRedInk/rubocop-nri/issues/1","id":251374787,"number":1,"title":"MoreRollbarInformation: Rollbar.scope.error doesn't get caught","user":{"login":"ento","id":21108,"avatar_url":"https://avatars3.githubusercontent.com/u/21108?v=4","gravatar_id":"","url":"https://api.github.com/users/ento","html_url":"https://github.com/ento","followers_url":"https://api.github.com/users/ento/followers","following_url":"https://api.github.com/users/ento/following{/other_user}","gists_url":"https://api.github.com/users/ento/gists{/gist_id}","starred_url":"https://api.github.com/users/ento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ento/subscriptions","organizations_url":"https://api.github.com/users/ento/orgs","repos_url":"https://api.github.com/users/ento/repos","events_url":"https://api.github.com/users/ento/events{/privacy}","received_events_url":"https://api.github.com/users/ento/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-18T22:39:39Z","updated_at":"2017-09-22T23:58:38Z","closed_at":null,"author_association":"OWNER","body":"```ruby\r\nRollbar\r\n  .scope(fingerprint: \"some fingerprint\")\r\n  .critical(\"some message\")\r\n```"},"comment":{"url":"https://api.github.com/repos/NoRedInk/rubocop-nri/issues/comments/331585570","html_url":"https://github.com/NoRedInk/rubocop-nri/issues/1#issuecomment-331585570","issue_url":"https://api.github.com/repos/NoRedInk/rubocop-nri/issues/1","id":331585570,"user":{"login":"joneshf","id":1356417,"avatar_url":"https://avatars2.githubusercontent.com/u/1356417?v=4","gravatar_id":"","url":"https://api.github.com/users/joneshf","html_url":"https://github.com/joneshf","followers_url":"https://api.github.com/users/joneshf/followers","following_url":"https://api.github.com/users/joneshf/following{/other_user}","gists_url":"https://api.github.com/users/joneshf/gists{/gist_id}","starred_url":"https://api.github.com/users/joneshf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneshf/subscriptions","organizations_url":"https://api.github.com/users/joneshf/orgs","repos_url":"https://api.github.com/users/joneshf/repos","events_url":"https://api.github.com/users/joneshf/events{/privacy}","received_events_url":"https://api.github.com/users/joneshf/received_events","type":"User","site_admin":false},"created_at":"2017-09-22T23:58:38Z","updated_at":"2017-09-22T23:58:38Z","author_association":"MEMBER","body":"I don't want to be the only committer to this repo so I'm going to outline one way to implement this.  You don't have to be the one to implement it, Marica. I think this should be straight forward to do though (famous last words).\r\n\r\n---\r\n\r\nThe syntax of this DSL isn't straight forward. I don't fully understand it, but I'm happy to answer questions.\r\n\r\nWe need another case here that includes `:scope`.\r\n\r\nThis case should have a `send` of `:scope` followed by the `send` of one of `:critical` or `:error`. Something like\r\n\r\n```ruby\r\n(send (send (const nil :Rollbar) :scope) {:critical :error} )\r\n#                                                          ^\r\n#                                                          |\r\n#                                      Put the rest of the matching stuff here\r\n```\r\n\r\nWe would need two more cases in `:missing_hash?`:\r\n\r\nhttps://github.com/NoRedInk/rubocop-nri/blob/0e389e6e81c36904193c5070c7a61a3958319b3b/lib/rubocop/cop/nri/more_rollbar_information.rb#L11-L16\r\n\r\nand to convert `:hash` to have different cases (by surrounding with curly braces) and add a case for scope:\r\n\r\nhttps://github.com/NoRedInk/rubocop-nri/blob/0e389e6e81c36904193c5070c7a61a3958319b3b/lib/rubocop/cop/nri/more_rollbar_information.rb#L18-L20\r\n\r\n---\r\n\r\nMight be easiest to TDD this though.\r\n"}}
{"actor":{"display_login":"joneshf"}}