{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42406","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42406/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42406/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42406/events","html_url":"https://github.com/kubernetes/kubernetes/pull/42406","id":211328272,"number":42406,"title":"Use NoSchedule taint in Node controller instead of filter node in scheduler","user":{"login":"resouer","id":1701782,"avatar_url":"https://avatars0.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"aveshagarwal","id":3596412,"avatar_url":"https://avatars3.githubusercontent.com/u/3596412?v=3","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false},"assignees":[{"login":"aveshagarwal","id":3596412,"avatar_url":"https://avatars3.githubusercontent.com/u/3596412?v=3","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-03-02T09:01:29Z","updated_at":"2017-03-02T09:43:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42406","html_url":"https://github.com/kubernetes/kubernetes/pull/42406","diff_url":"https://github.com/kubernetes/kubernetes/pull/42406.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/42406.patch"},"body":"**What this PR does / why we need it**:\r\nUse NoSchedule taint in Node controller instead of filter node in scheduler\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #42001\r\n\r\n**Special notes for your reviewer**:\r\nI did not use a NoSchedule taint control loop to do this because I found that we can maintain this behaviour based on condition change. cc @gmarek \r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/283605349","html_url":"https://github.com/kubernetes/kubernetes/pull/42406#issuecomment-283605349","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42406","id":283605349,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars3.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-03-02T09:43:00Z","updated_at":"2017-03-02T09:43:00Z","body":"@resouer: The following test(s) **failed**:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nJenkins Bazel Build | 0b0e7b18b321880b2eff10c5530045d1b373a6f2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42406/pull-kubernetes-bazel/8502/) | `@k8s-bot bazel test this`\nJenkins unit/integration | 0b0e7b18b321880b2eff10c5530045d1b373a6f2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42406/pull-kubernetes-unit/21198/) | `@k8s-bot unit test this`\nJenkins GKE smoke e2e | 0b0e7b18b321880b2eff10c5530045d1b373a6f2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42406/pull-kubernetes-e2e-gke/20798/) | `@k8s-bot cvm gke e2e test this`\nJenkins GCI GKE smoke e2e | 0b0e7b18b321880b2eff10c5530045d1b373a6f2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42406/pull-kubernetes-e2e-gke-gci/20599/) | `@k8s-bot gci gke e2e test this`\nJenkins GCE Node e2e | 0b0e7b18b321880b2eff10c5530045d1b373a6f2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42406/pull-kubernetes-node-e2e/20675/) | `@k8s-bot node e2e test this`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/42406). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/resouer). Please help us cut down on flakes by linking to an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-request-commands.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/prow/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}