{"action":"created","comment":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/145056677","pull_request_review_id":69798078,"id":145056677,"diff_hunk":"@@ -238,8 +238,8 @@ std::set<int> Universe::EmpireVisibleObjectIDs(int empire_id/* = ALL_EMPIRES*/)\n     // if an empire has visibility of it\n     for (auto obj_it = m_objects.const_begin(); obj_it != m_objects.const_end(); ++obj_it) {\n         int id = obj_it->ID();\n-        for (int empire_id : empire_ids) {\n-            Visibility vis = GetObjectVisibilityByEmpire(id, empire_id);\n+        for (int next_empire_id : empire_ids) {","path":"universe/Universe.cpp","position":6,"original_position":6,"commit_id":"b45b41aec66c770a33a429d47358d175abe4b9cb","original_commit_id":"b45b41aec66c770a33a429d47358d175abe4b9cb","user":{"login":"geoffthemedio","id":11386908,"avatar_url":"https://avatars1.githubusercontent.com/u/11386908?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffthemedio","html_url":"https://github.com/geoffthemedio","followers_url":"https://api.github.com/users/geoffthemedio/followers","following_url":"https://api.github.com/users/geoffthemedio/following{/other_user}","gists_url":"https://api.github.com/users/geoffthemedio/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffthemedio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffthemedio/subscriptions","organizations_url":"https://api.github.com/users/geoffthemedio/orgs","repos_url":"https://api.github.com/users/geoffthemedio/repos","events_url":"https://api.github.com/users/geoffthemedio/events{/privacy}","received_events_url":"https://api.github.com/users/geoffthemedio/received_events","type":"User","site_admin":false},"body":"`detector_empire_id`","created_at":"2017-10-17T08:14:51Z","updated_at":"2017-10-17T08:14:51Z","html_url":"https://github.com/freeorion/freeorion/pull/1817#discussion_r145056677","pull_request_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1817","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/145056677"},"html":{"href":"https://github.com/freeorion/freeorion/pull/1817#discussion_r145056677"},"pull_request":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1817"}}},"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/1817","id":146886846,"html_url":"https://github.com/freeorion/freeorion/pull/1817","diff_url":"https://github.com/freeorion/freeorion/pull/1817.diff","patch_url":"https://github.com/freeorion/freeorion/pull/1817.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/1817","number":1817,"state":"open","locked":false,"title":"Replace shadowed/shadowing variables","user":{"login":"dbenage-cx","id":17205519,"avatar_url":"https://avatars2.githubusercontent.com/u/17205519?v=4","gravatar_id":"","url":"https://api.github.com/users/dbenage-cx","html_url":"https://github.com/dbenage-cx","followers_url":"https://api.github.com/users/dbenage-cx/followers","following_url":"https://api.github.com/users/dbenage-cx/following{/other_user}","gists_url":"https://api.github.com/users/dbenage-cx/gists{/gist_id}","starred_url":"https://api.github.com/users/dbenage-cx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbenage-cx/subscriptions","organizations_url":"https://api.github.com/users/dbenage-cx/orgs","repos_url":"https://api.github.com/users/dbenage-cx/repos","events_url":"https://api.github.com/users/dbenage-cx/events{/privacy}","received_events_url":"https://api.github.com/users/dbenage-cx/received_events","type":"User","site_admin":false},"body":"Majority are renames, a few cases were dropped where they matched the previous definition.\r\n\r\nThe last commit attempts to resolve an issue with `GraphicalSummary::parent`, while the resolution works on my machine, I'm cautious it is not correct.\r\n\r\nOnly remaining noted warnings for `-Wshadow` are for utf8/checked, I left those for a potential update of library.","created_at":"2017-10-16T20:57:34Z","updated_at":"2017-10-17T08:14:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d31987d4f9130cd177544f9d0aedbfc9e4e517c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/freeorion/freeorion/milestones/18","html_url":"https://github.com/freeorion/freeorion/milestone/18","labels_url":"https://api.github.com/repos/freeorion/freeorion/milestones/18/labels","id":2316533,"number":18,"title":"v0.4.8","description":"Bugs, features and pull requests that should be fixed/finalized for the 0.4.8 release.","creator":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars2.githubusercontent.com/u/10279417?v=4","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"open_issues":181,"closed_issues":230,"state":"open","created_at":"2017-02-12T13:01:43Z","updated_at":"2017-10-17T08:07:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1817/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1817/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/1817/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/b45b41aec66c770a33a429d47358d175abe4b9cb","head":{"label":"dbenage-cx:fixup-shadow-vars","ref":"fixup-shadow-vars","sha":"b45b41aec66c770a33a429d47358d175abe4b9cb","user":{"login":"dbenage-cx","id":17205519,"avatar_url":"https://avatars2.githubusercontent.com/u/17205519?v=4","gravatar_id":"","url":"https://api.github.com/users/dbenage-cx","html_url":"https://github.com/dbenage-cx","followers_url":"https://api.github.com/users/dbenage-cx/followers","following_url":"https://api.github.com/users/dbenage-cx/following{/other_user}","gists_url":"https://api.github.com/users/dbenage-cx/gists{/gist_id}","starred_url":"https://api.github.com/users/dbenage-cx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbenage-cx/subscriptions","organizations_url":"https://api.github.com/users/dbenage-cx/orgs","repos_url":"https://api.github.com/users/dbenage-cx/repos","events_url":"https://api.github.com/users/dbenage-cx/events{/privacy}","received_events_url":"https://api.github.com/users/dbenage-cx/received_events","type":"User","site_admin":false},"repo":{"id":51614976,"name":"freeorion","full_name":"dbenage-cx/freeorion","owner":{"login":"dbenage-cx","id":17205519,"avatar_url":"https://avatars2.githubusercontent.com/u/17205519?v=4","gravatar_id":"","url":"https://api.github.com/users/dbenage-cx","html_url":"https://github.com/dbenage-cx","followers_url":"https://api.github.com/users/dbenage-cx/followers","following_url":"https://api.github.com/users/dbenage-cx/following{/other_user}","gists_url":"https://api.github.com/users/dbenage-cx/gists{/gist_id}","starred_url":"https://api.github.com/users/dbenage-cx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbenage-cx/subscriptions","organizations_url":"https://api.github.com/users/dbenage-cx/orgs","repos_url":"https://api.github.com/users/dbenage-cx/repos","events_url":"https://api.github.com/users/dbenage-cx/events{/privacy}","received_events_url":"https://api.github.com/users/dbenage-cx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbenage-cx/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/dbenage-cx/freeorion","forks_url":"https://api.github.com/repos/dbenage-cx/freeorion/forks","keys_url":"https://api.github.com/repos/dbenage-cx/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbenage-cx/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbenage-cx/freeorion/teams","hooks_url":"https://api.github.com/repos/dbenage-cx/freeorion/hooks","issue_events_url":"https://api.github.com/repos/dbenage-cx/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/dbenage-cx/freeorion/events","assignees_url":"https://api.github.com/repos/dbenage-cx/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/dbenage-cx/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/dbenage-cx/freeorion/tags","blobs_url":"https://api.github.com/repos/dbenage-cx/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbenage-cx/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbenage-cx/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbenage-cx/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbenage-cx/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/dbenage-cx/freeorion/languages","stargazers_url":"https://api.github.com/repos/dbenage-cx/freeorion/stargazers","contributors_url":"https://api.github.com/repos/dbenage-cx/freeorion/contributors","subscribers_url":"https://api.github.com/repos/dbenage-cx/freeorion/subscribers","subscription_url":"https://api.github.com/repos/dbenage-cx/freeorion/subscription","commits_url":"https://api.github.com/repos/dbenage-cx/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbenage-cx/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbenage-cx/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbenage-cx/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbenage-cx/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/dbenage-cx/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbenage-cx/freeorion/merges","archive_url":"https://api.github.com/repos/dbenage-cx/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbenage-cx/freeorion/downloads","issues_url":"https://api.github.com/repos/dbenage-cx/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/dbenage-cx/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/dbenage-cx/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/dbenage-cx/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbenage-cx/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/dbenage-cx/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/dbenage-cx/freeorion/deployments","created_at":"2016-02-12T20:39:41Z","updated_at":"2016-02-12T20:39:47Z","pushed_at":"2017-10-17T03:51:03Z","git_url":"git://github.com/dbenage-cx/freeorion.git","ssh_url":"git@github.com:dbenage-cx/freeorion.git","clone_url":"https://github.com/dbenage-cx/freeorion.git","svn_url":"https://github.com/dbenage-cx/freeorion","homepage":"http://www.freeorion.org/","size":541349,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"e3039cad6cec05b46dcd05f1bf4255e3e2999ae9","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2017-10-16T19:11:33Z","pushed_at":"2017-10-17T03:51:05Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":540678,"stargazers_count":244,"watchers_count":244,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":194,"forks":87,"open_issues":194,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1817"},"html":{"href":"https://github.com/freeorion/freeorion/pull/1817"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/1817"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/1817/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1817/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1817/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/b45b41aec66c770a33a429d47358d175abe4b9cb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"geoffthemedio"}}