{"action":"created","issue":{"url":"https://api.github.com/repos/shoyer/h5netcdf/issues/29","repository_url":"https://api.github.com/repos/shoyer/h5netcdf","labels_url":"https://api.github.com/repos/shoyer/h5netcdf/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/shoyer/h5netcdf/issues/29/comments","events_url":"https://api.github.com/repos/shoyer/h5netcdf/issues/29/events","html_url":"https://github.com/shoyer/h5netcdf/pull/29","id":253790921,"number":29,"title":"Warnings when using invalid netCDF features","user":{"login":"shoyer","id":1217238,"avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-29T20:19:41Z","updated_at":"2017-08-30T00:03:55Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/shoyer/h5netcdf/pulls/29","html_url":"https://github.com/shoyer/h5netcdf/pull/29","diff_url":"https://github.com/shoyer/h5netcdf/pull/29.diff","patch_url":"https://github.com/shoyer/h5netcdf/pull/29.patch"},"body":"Fixes #28\r\nxref pydata/xarray#1536\r\n\r\nNew behavior:\r\n```\r\nIn [1]: import h5netcdf\r\n\r\nIn [2]: f = h5netcdf.File('warning.h5')\r\n\r\nIn [3]: f.attrs['foo'] = 1j\r\n/Users/shoyer/conda/envs/h5netcdf-dev/bin/ipython:1: FutureWarning: complex dtypes\r\nare supported by h5py, but not part of the NetCDF API. You are writing an HDF5\r\nfile that is not a valid NetCDF file! In the future, this will be an error, unless\r\nyou set invalid_netcdf=True.\r\n  #!/bin/bash /Users/shoyer/conda/envs/h5netcdf-dev/bin/python.app\r\n\r\nIn [4]: f = h5netcdf.File('error.h5', invalid_netcdf=False)\r\n\r\nIn [5]: f.attrs['foo'] = 1j\r\nCompatibilityError: complex dtypes are not a supported NetCDF feature, and are not\r\nallowed by h5netcdf unless invalid_netcdf=True.\r\n```\r\n\r\nCC @dopplershift -- I would appreciate any feedback you might have on the error/warning message and the new README."},"comment":{"url":"https://api.github.com/repos/shoyer/h5netcdf/issues/comments/325838738","html_url":"https://github.com/shoyer/h5netcdf/pull/29#issuecomment-325838738","issue_url":"https://api.github.com/repos/shoyer/h5netcdf/issues/29","id":325838738,"user":{"login":"dopplershift","id":221526,"avatar_url":"https://avatars2.githubusercontent.com/u/221526?v=4","gravatar_id":"","url":"https://api.github.com/users/dopplershift","html_url":"https://github.com/dopplershift","followers_url":"https://api.github.com/users/dopplershift/followers","following_url":"https://api.github.com/users/dopplershift/following{/other_user}","gists_url":"https://api.github.com/users/dopplershift/gists{/gist_id}","starred_url":"https://api.github.com/users/dopplershift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopplershift/subscriptions","organizations_url":"https://api.github.com/users/dopplershift/orgs","repos_url":"https://api.github.com/users/dopplershift/repos","events_url":"https://api.github.com/users/dopplershift/events{/privacy}","received_events_url":"https://api.github.com/users/dopplershift/received_events","type":"User","site_admin":false},"created_at":"2017-08-30T00:03:55Z","updated_at":"2017-08-30T00:03:55Z","author_association":"NONE","body":"Sure, and that makes sense."}}
{"actor":{"display_login":"dopplershift"}}