{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3213","repository_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3213/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3213/comments","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3213/events","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3213","id":260359347,"number":3213,"title":"Bug 1387616: Stop toolbar from showing at bottom","user":{"login":"garvankeeley","id":5495083,"avatar_url":"https://avatars1.githubusercontent.com/u/5495083?v=4","gravatar_id":"","url":"https://api.github.com/users/garvankeeley","html_url":"https://github.com/garvankeeley","followers_url":"https://api.github.com/users/garvankeeley/followers","following_url":"https://api.github.com/users/garvankeeley/following{/other_user}","gists_url":"https://api.github.com/users/garvankeeley/gists{/gist_id}","starred_url":"https://api.github.com/users/garvankeeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garvankeeley/subscriptions","organizations_url":"https://api.github.com/users/garvankeeley/orgs","repos_url":"https://api.github.com/users/garvankeeley/repos","events_url":"https://api.github.com/users/garvankeeley/events{/privacy}","received_events_url":"https://api.github.com/users/garvankeeley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-25T17:43:22Z","updated_at":"2017-09-26T21:54:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3213","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3213","diff_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3213.diff","patch_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3213.patch"},"body":"This behaviour matches Focus iOS and Chrome iOS.\r\n\r\nI think we tried to match Safari here however our toolbar show/hide has no other matching behaviour to Safari (which has different scroll up logic, also has a tap-at-bottom to show bottom toolbar).\r\n\r\nI suspect this class is in need of a cleanup, for instance `scrollViewWillEndDragging` was being used which is for modifying the drag completion target (otherwise didEnd is the one to use). "},"comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments/332347522","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3213#issuecomment-332347522","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3213","id":332347522,"user":{"login":"farhanpatel","id":522281,"avatar_url":"https://avatars0.githubusercontent.com/u/522281?v=4","gravatar_id":"","url":"https://api.github.com/users/farhanpatel","html_url":"https://github.com/farhanpatel","followers_url":"https://api.github.com/users/farhanpatel/followers","following_url":"https://api.github.com/users/farhanpatel/following{/other_user}","gists_url":"https://api.github.com/users/farhanpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/farhanpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farhanpatel/subscriptions","organizations_url":"https://api.github.com/users/farhanpatel/orgs","repos_url":"https://api.github.com/users/farhanpatel/repos","events_url":"https://api.github.com/users/farhanpatel/events{/privacy}","received_events_url":"https://api.github.com/users/farhanpatel/received_events","type":"User","site_admin":false},"created_at":"2017-09-26T21:54:24Z","updated_at":"2017-09-26T21:54:24Z","author_association":"CONTRIBUTOR","body":"The issue I mentioned also happens if you scroll back up to the top of imgur and try scrolling back down again. Even though the content is loaded it appears to still trigger the URLbar. They must be doing something weird. Curious if this will hurt other sites too.\r\n\r\nAlso our behavior is slightly different than chrome and focus. \r\nIn Focus, Tapping the iPhone statusbar brings back the UI but doesnt scroll the page to the top. Tapping the status bar again scrolls the page to the top\r\nIn Chrome, Dragging even slightly animates the urlbar back in while in Firefox you have to flick it up with the right velocity.\r\n\r\nI really like Chrome's behavior of showing the urlbar as you scroll up without having to \"flick up\". But I think matching either Focus/Chrome exactly would be great. "}}
{"actor":{"display_login":"farhanpatel"}}