{"action":"created","comment":{"url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/comments/105560424","pull_request_review_id":26447492,"id":105560424,"diff_hunk":"@@ -580,8 +683,23 @@ encode_r(R)\n     R.\n \n decode_r(?OPT_R_N) ->\n-    {r, n};\n+    n;\n decode_r(?OPT_R_DEFAULT) ->\n-    {r, default};\n-decode_r(R) ->\n-    {r, R}.\n+    default;\n+decode_r(R) when is_integer(R), R > 0 ->\n+    R.\n+\n+-type aggr_bin() :: <<_:40,_:_*8>>.","path":"src/dproto_tcp.erl","position":237,"original_position":237,"commit_id":"a9afc13280b64ae00f1244904b473fbfba182a94","original_commit_id":"a9afc13280b64ae00f1244904b473fbfba182a94","user":{"login":"elvisci","id":8136322,"avatar_url":"https://avatars3.githubusercontent.com/u/8136322?v=3","gravatar_id":"","url":"https://api.github.com/users/elvisci","html_url":"https://github.com/elvisci","followers_url":"https://api.github.com/users/elvisci/followers","following_url":"https://api.github.com/users/elvisci/following{/other_user}","gists_url":"https://api.github.com/users/elvisci/gists{/gist_id}","starred_url":"https://api.github.com/users/elvisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvisci/subscriptions","organizations_url":"https://api.github.com/users/elvisci/orgs","repos_url":"https://api.github.com/users/elvisci/repos","events_url":"https://api.github.com/users/elvisci/events{/privacy}","received_events_url":"https://api.github.com/users/elvisci/received_events","type":"User","site_admin":false},"body":"Missing space right \",\" on line 692","created_at":"2017-03-12T15:33:52Z","updated_at":"2017-03-12T15:33:52Z","html_url":"https://github.com/dalmatinerdb/dproto/pull/9#discussion_r105560424","pull_request_url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/comments/105560424"},"html":{"href":"https://github.com/dalmatinerdb/dproto/pull/9#discussion_r105560424"},"pull_request":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9","id":110299497,"html_url":"https://github.com/dalmatinerdb/dproto/pull/9","diff_url":"https://github.com/dalmatinerdb/dproto/pull/9.diff","patch_url":"https://github.com/dalmatinerdb/dproto/pull/9.patch","issue_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues/9","number":9,"state":"open","locked":false,"title":"Add aggregate read option","user":{"login":"Licenser","id":119093,"avatar_url":"https://avatars2.githubusercontent.com/u/119093?v=3","gravatar_id":"","url":"https://api.github.com/users/Licenser","html_url":"https://github.com/Licenser","followers_url":"https://api.github.com/users/Licenser/followers","following_url":"https://api.github.com/users/Licenser/following{/other_user}","gists_url":"https://api.github.com/users/Licenser/gists{/gist_id}","starred_url":"https://api.github.com/users/Licenser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Licenser/subscriptions","organizations_url":"https://api.github.com/users/Licenser/orgs","repos_url":"https://api.github.com/users/Licenser/repos","events_url":"https://api.github.com/users/Licenser/events{/privacy}","received_events_url":"https://api.github.com/users/Licenser/received_events","type":"User","site_admin":false},"body":"Adds a read option that passes the aggregate.","created_at":"2017-03-12T13:54:41Z","updated_at":"2017-03-12T15:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94db235d19944b82cb93604cc9ee3f15274d92d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9/commits","review_comments_url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9/comments","review_comment_url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues/9/comments","statuses_url":"https://api.github.com/repos/dalmatinerdb/dproto/statuses/a9afc13280b64ae00f1244904b473fbfba182a94","head":{"label":"dalmatinerdb:aggregated-get","ref":"aggregated-get","sha":"a9afc13280b64ae00f1244904b473fbfba182a94","user":{"login":"dalmatinerdb","id":8044415,"avatar_url":"https://avatars1.githubusercontent.com/u/8044415?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmatinerdb","html_url":"https://github.com/dalmatinerdb","followers_url":"https://api.github.com/users/dalmatinerdb/followers","following_url":"https://api.github.com/users/dalmatinerdb/following{/other_user}","gists_url":"https://api.github.com/users/dalmatinerdb/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmatinerdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmatinerdb/subscriptions","organizations_url":"https://api.github.com/users/dalmatinerdb/orgs","repos_url":"https://api.github.com/users/dalmatinerdb/repos","events_url":"https://api.github.com/users/dalmatinerdb/events{/privacy}","received_events_url":"https://api.github.com/users/dalmatinerdb/received_events","type":"Organization","site_admin":false},"repo":{"id":21312673,"name":"dproto","full_name":"dalmatinerdb/dproto","owner":{"login":"dalmatinerdb","id":8044415,"avatar_url":"https://avatars1.githubusercontent.com/u/8044415?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmatinerdb","html_url":"https://github.com/dalmatinerdb","followers_url":"https://api.github.com/users/dalmatinerdb/followers","following_url":"https://api.github.com/users/dalmatinerdb/following{/other_user}","gists_url":"https://api.github.com/users/dalmatinerdb/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmatinerdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmatinerdb/subscriptions","organizations_url":"https://api.github.com/users/dalmatinerdb/orgs","repos_url":"https://api.github.com/users/dalmatinerdb/repos","events_url":"https://api.github.com/users/dalmatinerdb/events{/privacy}","received_events_url":"https://api.github.com/users/dalmatinerdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dalmatinerdb/dproto","description":"Protocols for dalmatinadb","fork":false,"url":"https://api.github.com/repos/dalmatinerdb/dproto","forks_url":"https://api.github.com/repos/dalmatinerdb/dproto/forks","keys_url":"https://api.github.com/repos/dalmatinerdb/dproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalmatinerdb/dproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalmatinerdb/dproto/teams","hooks_url":"https://api.github.com/repos/dalmatinerdb/dproto/hooks","issue_events_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues/events{/number}","events_url":"https://api.github.com/repos/dalmatinerdb/dproto/events","assignees_url":"https://api.github.com/repos/dalmatinerdb/dproto/assignees{/user}","branches_url":"https://api.github.com/repos/dalmatinerdb/dproto/branches{/branch}","tags_url":"https://api.github.com/repos/dalmatinerdb/dproto/tags","blobs_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalmatinerdb/dproto/statuses/{sha}","languages_url":"https://api.github.com/repos/dalmatinerdb/dproto/languages","stargazers_url":"https://api.github.com/repos/dalmatinerdb/dproto/stargazers","contributors_url":"https://api.github.com/repos/dalmatinerdb/dproto/contributors","subscribers_url":"https://api.github.com/repos/dalmatinerdb/dproto/subscribers","subscription_url":"https://api.github.com/repos/dalmatinerdb/dproto/subscription","commits_url":"https://api.github.com/repos/dalmatinerdb/dproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalmatinerdb/dproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalmatinerdb/dproto/contents/{+path}","compare_url":"https://api.github.com/repos/dalmatinerdb/dproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalmatinerdb/dproto/merges","archive_url":"https://api.github.com/repos/dalmatinerdb/dproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalmatinerdb/dproto/downloads","issues_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues{/number}","pulls_url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls{/number}","milestones_url":"https://api.github.com/repos/dalmatinerdb/dproto/milestones{/number}","notifications_url":"https://api.github.com/repos/dalmatinerdb/dproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalmatinerdb/dproto/labels{/name}","releases_url":"https://api.github.com/repos/dalmatinerdb/dproto/releases{/id}","deployments_url":"https://api.github.com/repos/dalmatinerdb/dproto/deployments","created_at":"2014-06-28T23:05:26Z","updated_at":"2016-11-12T09:47:19Z","pushed_at":"2017-03-12T15:33:50Z","git_url":"git://github.com/dalmatinerdb/dproto.git","ssh_url":"git@github.com:dalmatinerdb/dproto.git","clone_url":"https://github.com/dalmatinerdb/dproto.git","svn_url":"https://github.com/dalmatinerdb/dproto","homepage":null,"size":2076,"stargazers_count":1,"watchers_count":1,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"dalmatinerdb:master","ref":"master","sha":"a962659b6fdfbf1028c1e7fa1cf25e805552a86b","user":{"login":"dalmatinerdb","id":8044415,"avatar_url":"https://avatars1.githubusercontent.com/u/8044415?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmatinerdb","html_url":"https://github.com/dalmatinerdb","followers_url":"https://api.github.com/users/dalmatinerdb/followers","following_url":"https://api.github.com/users/dalmatinerdb/following{/other_user}","gists_url":"https://api.github.com/users/dalmatinerdb/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmatinerdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmatinerdb/subscriptions","organizations_url":"https://api.github.com/users/dalmatinerdb/orgs","repos_url":"https://api.github.com/users/dalmatinerdb/repos","events_url":"https://api.github.com/users/dalmatinerdb/events{/privacy}","received_events_url":"https://api.github.com/users/dalmatinerdb/received_events","type":"Organization","site_admin":false},"repo":{"id":21312673,"name":"dproto","full_name":"dalmatinerdb/dproto","owner":{"login":"dalmatinerdb","id":8044415,"avatar_url":"https://avatars1.githubusercontent.com/u/8044415?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmatinerdb","html_url":"https://github.com/dalmatinerdb","followers_url":"https://api.github.com/users/dalmatinerdb/followers","following_url":"https://api.github.com/users/dalmatinerdb/following{/other_user}","gists_url":"https://api.github.com/users/dalmatinerdb/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmatinerdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmatinerdb/subscriptions","organizations_url":"https://api.github.com/users/dalmatinerdb/orgs","repos_url":"https://api.github.com/users/dalmatinerdb/repos","events_url":"https://api.github.com/users/dalmatinerdb/events{/privacy}","received_events_url":"https://api.github.com/users/dalmatinerdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dalmatinerdb/dproto","description":"Protocols for dalmatinadb","fork":false,"url":"https://api.github.com/repos/dalmatinerdb/dproto","forks_url":"https://api.github.com/repos/dalmatinerdb/dproto/forks","keys_url":"https://api.github.com/repos/dalmatinerdb/dproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalmatinerdb/dproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalmatinerdb/dproto/teams","hooks_url":"https://api.github.com/repos/dalmatinerdb/dproto/hooks","issue_events_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues/events{/number}","events_url":"https://api.github.com/repos/dalmatinerdb/dproto/events","assignees_url":"https://api.github.com/repos/dalmatinerdb/dproto/assignees{/user}","branches_url":"https://api.github.com/repos/dalmatinerdb/dproto/branches{/branch}","tags_url":"https://api.github.com/repos/dalmatinerdb/dproto/tags","blobs_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalmatinerdb/dproto/statuses/{sha}","languages_url":"https://api.github.com/repos/dalmatinerdb/dproto/languages","stargazers_url":"https://api.github.com/repos/dalmatinerdb/dproto/stargazers","contributors_url":"https://api.github.com/repos/dalmatinerdb/dproto/contributors","subscribers_url":"https://api.github.com/repos/dalmatinerdb/dproto/subscribers","subscription_url":"https://api.github.com/repos/dalmatinerdb/dproto/subscription","commits_url":"https://api.github.com/repos/dalmatinerdb/dproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalmatinerdb/dproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalmatinerdb/dproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalmatinerdb/dproto/contents/{+path}","compare_url":"https://api.github.com/repos/dalmatinerdb/dproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalmatinerdb/dproto/merges","archive_url":"https://api.github.com/repos/dalmatinerdb/dproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalmatinerdb/dproto/downloads","issues_url":"https://api.github.com/repos/dalmatinerdb/dproto/issues{/number}","pulls_url":"https://api.github.com/repos/dalmatinerdb/dproto/pulls{/number}","milestones_url":"https://api.github.com/repos/dalmatinerdb/dproto/milestones{/number}","notifications_url":"https://api.github.com/repos/dalmatinerdb/dproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalmatinerdb/dproto/labels{/name}","releases_url":"https://api.github.com/repos/dalmatinerdb/dproto/releases{/id}","deployments_url":"https://api.github.com/repos/dalmatinerdb/dproto/deployments","created_at":"2014-06-28T23:05:26Z","updated_at":"2016-11-12T09:47:19Z","pushed_at":"2017-03-12T15:33:50Z","git_url":"git://github.com/dalmatinerdb/dproto.git","ssh_url":"git@github.com:dalmatinerdb/dproto.git","clone_url":"https://github.com/dalmatinerdb/dproto.git","svn_url":"https://github.com/dalmatinerdb/dproto","homepage":null,"size":2076,"stargazers_count":1,"watchers_count":1,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9"},"html":{"href":"https://github.com/dalmatinerdb/dproto/pull/9"},"issue":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/issues/9"},"comments":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/dalmatinerdb/dproto/statuses/a9afc13280b64ae00f1244904b473fbfba182a94"}}}}
{"actor":{"display_login":"elvisci"}}