{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18524","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18524/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18524/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18524/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18524","id":246795381,"number":18524,"title":"Add title types to some react-bootstrap elements to allow JSX","user":{"login":"heatherbooker","id":12223751,"avatar_url":"https://avatars3.githubusercontent.com/u/12223751?v=4","gravatar_id":"","url":"https://api.github.com/users/heatherbooker","html_url":"https://github.com/heatherbooker","followers_url":"https://api.github.com/users/heatherbooker/followers","following_url":"https://api.github.com/users/heatherbooker/following{/other_user}","gists_url":"https://api.github.com/users/heatherbooker/gists{/gist_id}","starred_url":"https://api.github.com/users/heatherbooker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heatherbooker/subscriptions","organizations_url":"https://api.github.com/users/heatherbooker/orgs","repos_url":"https://api.github.com/users/heatherbooker/repos","events_url":"https://api.github.com/users/heatherbooker/events{/privacy}","received_events_url":"https://api.github.com/users/heatherbooker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-31T15:23:55Z","updated_at":"2017-07-31T15:23:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18524","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18524","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18524.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18524.patch"},"body":"Some elements are listed in the documentation of react-bootstrap as accepting a node, but their types definitions don't mention it and in fact extend `React.HTMLProps` which has a conflicting title type (`string | undefined`). \r\n\r\nThis isn't an ideal solution but it does prevent the errors from cropping up when trying to pass a node as a title. This sort of solution was suggested [here](https://github.com/DefinitelyTyped/DefinitelyTyped/issues/14934#issuecomment-284471494).\r\n\r\nI changed the tests and compiled them but not sure how to actually run them beyond `node react-bootstrap-tests.js`.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present __<-- ran tsc__).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <<https://github.com/DefinitelyTyped/DefinitelyTyped/issues/12085>>, <<https://github.com/DefinitelyTyped/DefinitelyTyped/issues/12086>>\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/319101229","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18524#issuecomment-319101229","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18524","id":319101229,"user":{"login":"dt-bot","id":7585416,"avatar_url":"https://avatars2.githubusercontent.com/u/7585416?v=4","gravatar_id":"","url":"https://api.github.com/users/dt-bot","html_url":"https://github.com/dt-bot","followers_url":"https://api.github.com/users/dt-bot/followers","following_url":"https://api.github.com/users/dt-bot/following{/other_user}","gists_url":"https://api.github.com/users/dt-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dt-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt-bot/subscriptions","organizations_url":"https://api.github.com/users/dt-bot/orgs","repos_url":"https://api.github.com/users/dt-bot/repos","events_url":"https://api.github.com/users/dt-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dt-bot/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T15:23:57Z","updated_at":"2017-07-31T15:23:57Z","body":"*types/react-bootstrap/index.d.ts*\n\nto authors (@walkerburgin @vsiao @danilojrr @Batbold-Gansukh @octatone @chengsieuly @katbusch). Could you review this PR?\n:+1: or :-1:?\n\nChecklist\n\n* [ ] pass the Travis CI test?"}}
{"actor":{"display_login":"dt-bot"}}