{"action":"created","comment":{"url":"https://api.github.com/repos/open-craft/courses/pulls/comments/154597849","pull_request_review_id":80778480,"id":154597849,"diff_hunk":"@@ -25,6 +23,6 @@ <h3>\n     and not per-epic, the labelling itself is not too much admin overhead.\n   </p>\n   <p>\n-    <a href=\"https://github.com/open-craft/documentation/blob/onboarding-feedback-10-17/images/braden-time-tracking.png\" target=\"_blank\"><img src=\"https://github.com/open-craft/documentation/raw/onboarding-feedback-10-17/images/braden-time-tracking.png\" alt=\"\" /></a>\n+    <a href=\"https://github.com/open-craft/documentation/blob/master/images/braden-time-tracking.png\" target=\"_blank\"><img src=\"https://github.com/open-craft/documentation/raw/master/images/braden-time-tracking.png\" alt=\"\" /></a>","path":"html/time_management_and_invoices_tips_from_the_team_members_3.html","position":13,"original_position":13,"commit_id":"9e77ed5a53e53b7e2bbb17f6c316e75d5973fee1","original_commit_id":"9e77ed5a53e53b7e2bbb17f6c316e75d5973fee1","user":{"login":"pomegranited","id":7556571,"avatar_url":"https://avatars3.githubusercontent.com/u/7556571?v=4","gravatar_id":"","url":"https://api.github.com/users/pomegranited","html_url":"https://github.com/pomegranited","followers_url":"https://api.github.com/users/pomegranited/followers","following_url":"https://api.github.com/users/pomegranited/following{/other_user}","gists_url":"https://api.github.com/users/pomegranited/gists{/gist_id}","starred_url":"https://api.github.com/users/pomegranited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomegranited/subscriptions","organizations_url":"https://api.github.com/users/pomegranited/orgs","repos_url":"https://api.github.com/users/pomegranited/repos","events_url":"https://api.github.com/users/pomegranited/events{/privacy}","received_events_url":"https://api.github.com/users/pomegranited/received_events","type":"User","site_admin":false},"body":"a11y nit: this image needs a descriptive alt tag, e.g.\r\n> Screenshot of Braden's gmail with automatically-added tags.","created_at":"2017-12-04T09:42:30Z","updated_at":"2017-12-04T09:47:47Z","html_url":"https://github.com/open-craft/courses/pull/7#discussion_r154597849","pull_request_url":"https://api.github.com/repos/open-craft/courses/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/open-craft/courses/pulls/comments/154597849"},"html":{"href":"https://github.com/open-craft/courses/pull/7#discussion_r154597849"},"pull_request":{"href":"https://api.github.com/repos/open-craft/courses/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/open-craft/courses/pulls/7","id":155503552,"html_url":"https://github.com/open-craft/courses/pull/7","diff_url":"https://github.com/open-craft/courses/pull/7.diff","patch_url":"https://github.com/open-craft/courses/pull/7.patch","issue_url":"https://api.github.com/repos/open-craft/courses/issues/7","number":7,"state":"open","locked":false,"title":"Address some feedback comments: notifications, test. And rename section","user":{"login":"clemente","id":132703,"avatar_url":"https://avatars3.githubusercontent.com/u/132703?v=4","gravatar_id":"","url":"https://api.github.com/users/clemente","html_url":"https://github.com/clemente","followers_url":"https://api.github.com/users/clemente/followers","following_url":"https://api.github.com/users/clemente/following{/other_user}","gists_url":"https://api.github.com/users/clemente/gists{/gist_id}","starred_url":"https://api.github.com/users/clemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clemente/subscriptions","organizations_url":"https://api.github.com/users/clemente/orgs","repos_url":"https://api.github.com/users/clemente/repos","events_url":"https://api.github.com/users/clemente/events{/privacy}","received_events_url":"https://api.github.com/users/clemente/received_events","type":"User","site_admin":false},"body":"This includes some comments from OC-3352.\r\n\r\n# Testing\r\n1. check the diff. HTML shouldn't be broken\r\n2. Create .tar.gz and import it into Studio, into a course with the following data: course:„onboarding“, org:„OpenCraft“, run:„course“\r\n3. follow the course. Check that there's a new section about notifications, and that the section „configuring your opencraft e-mail“ was renamed to a longer name\r\n4. check that the internal link added in „first technical task“ to „code quality“ works\r\n5. check the content, it must address:\r\n  - types of tests, how to run each, some are slow\r\n  - handle notification overflow; synchronous/asynchronous and times\r\n  - over-commiting; how to take tasks progressively during the week\r\n  - communication about non-task related work\r\n  - and in addition, the issues requested as part of the review in github\r\n","created_at":"2017-11-30T02:26:28Z","updated_at":"2017-12-04T09:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3209ddf340d03dd61455dbfa84fae64d6ecc59ff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-craft/courses/pulls/7/commits","review_comments_url":"https://api.github.com/repos/open-craft/courses/pulls/7/comments","review_comment_url":"https://api.github.com/repos/open-craft/courses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-craft/courses/issues/7/comments","statuses_url":"https://api.github.com/repos/open-craft/courses/statuses/9e77ed5a53e53b7e2bbb17f6c316e75d5973fee1","head":{"label":"open-craft:clemente/onboarding-comments-michael","ref":"clemente/onboarding-comments-michael","sha":"9e77ed5a53e53b7e2bbb17f6c316e75d5973fee1","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":108395771,"name":"courses","full_name":"open-craft/courses","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/courses","description":"Courses that are present and available on courses.opencraft.com","fork":false,"url":"https://api.github.com/repos/open-craft/courses","forks_url":"https://api.github.com/repos/open-craft/courses/forks","keys_url":"https://api.github.com/repos/open-craft/courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/courses/teams","hooks_url":"https://api.github.com/repos/open-craft/courses/hooks","issue_events_url":"https://api.github.com/repos/open-craft/courses/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/courses/events","assignees_url":"https://api.github.com/repos/open-craft/courses/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/courses/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/courses/tags","blobs_url":"https://api.github.com/repos/open-craft/courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/courses/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/courses/languages","stargazers_url":"https://api.github.com/repos/open-craft/courses/stargazers","contributors_url":"https://api.github.com/repos/open-craft/courses/contributors","subscribers_url":"https://api.github.com/repos/open-craft/courses/subscribers","subscription_url":"https://api.github.com/repos/open-craft/courses/subscription","commits_url":"https://api.github.com/repos/open-craft/courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/courses/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/courses/merges","archive_url":"https://api.github.com/repos/open-craft/courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/courses/downloads","issues_url":"https://api.github.com/repos/open-craft/courses/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/courses/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/courses/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/courses/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/courses/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/courses/deployments","created_at":"2017-10-26T10:15:55Z","updated_at":"2017-11-27T12:43:12Z","pushed_at":"2017-12-04T09:27:07Z","git_url":"git://github.com/open-craft/courses.git","ssh_url":"git@github.com:open-craft/courses.git","clone_url":"https://github.com/open-craft/courses.git","svn_url":"https://github.com/open-craft/courses","homepage":null,"size":177,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"open-craft:onboarding","ref":"onboarding","sha":"4cff22b829b0fb87fc4c69eca4ef95eefa891da7","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":108395771,"name":"courses","full_name":"open-craft/courses","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/courses","description":"Courses that are present and available on courses.opencraft.com","fork":false,"url":"https://api.github.com/repos/open-craft/courses","forks_url":"https://api.github.com/repos/open-craft/courses/forks","keys_url":"https://api.github.com/repos/open-craft/courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/courses/teams","hooks_url":"https://api.github.com/repos/open-craft/courses/hooks","issue_events_url":"https://api.github.com/repos/open-craft/courses/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/courses/events","assignees_url":"https://api.github.com/repos/open-craft/courses/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/courses/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/courses/tags","blobs_url":"https://api.github.com/repos/open-craft/courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/courses/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/courses/languages","stargazers_url":"https://api.github.com/repos/open-craft/courses/stargazers","contributors_url":"https://api.github.com/repos/open-craft/courses/contributors","subscribers_url":"https://api.github.com/repos/open-craft/courses/subscribers","subscription_url":"https://api.github.com/repos/open-craft/courses/subscription","commits_url":"https://api.github.com/repos/open-craft/courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/courses/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/courses/merges","archive_url":"https://api.github.com/repos/open-craft/courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/courses/downloads","issues_url":"https://api.github.com/repos/open-craft/courses/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/courses/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/courses/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/courses/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/courses/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/courses/deployments","created_at":"2017-10-26T10:15:55Z","updated_at":"2017-11-27T12:43:12Z","pushed_at":"2017-12-04T09:27:07Z","git_url":"git://github.com/open-craft/courses.git","ssh_url":"git@github.com:open-craft/courses.git","clone_url":"https://github.com/open-craft/courses.git","svn_url":"https://github.com/open-craft/courses","homepage":null,"size":177,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-craft/courses/pulls/7"},"html":{"href":"https://github.com/open-craft/courses/pull/7"},"issue":{"href":"https://api.github.com/repos/open-craft/courses/issues/7"},"comments":{"href":"https://api.github.com/repos/open-craft/courses/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/open-craft/courses/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/open-craft/courses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-craft/courses/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/open-craft/courses/statuses/9e77ed5a53e53b7e2bbb17f6c316e75d5973fee1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pomegranited"}}