{"action":"created","issue":{"url":"https://api.github.com/repos/singularityware/singularity/issues/1084","repository_url":"https://api.github.com/repos/singularityware/singularity","labels_url":"https://api.github.com/repos/singularityware/singularity/issues/1084/labels{/name}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/1084/comments","events_url":"https://api.github.com/repos/singularityware/singularity/issues/1084/events","html_url":"https://github.com/singularityware/singularity/pull/1084","id":267490790,"number":1084,"title":"always use 'try' for overlayfs functionality.","user":{"login":"olifre","id":166759,"avatar_url":"https://avatars0.githubusercontent.com/u/166759?v=4","gravatar_id":"","url":"https://api.github.com/users/olifre","html_url":"https://github.com/olifre","followers_url":"https://api.github.com/users/olifre/followers","following_url":"https://api.github.com/users/olifre/following{/other_user}","gists_url":"https://api.github.com/users/olifre/gists{/gist_id}","starred_url":"https://api.github.com/users/olifre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifre/subscriptions","organizations_url":"https://api.github.com/users/olifre/orgs","repos_url":"https://api.github.com/users/olifre/repos","events_url":"https://api.github.com/users/olifre/events{/privacy}","received_events_url":"https://api.github.com/users/olifre/received_events","type":"User","site_admin":false},"labels":[{"id":271060103,"url":"https://api.github.com/repos/singularityware/singularity/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-22T19:17:38Z","updated_at":"2017-10-31T14:41:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/1084","html_url":"https://github.com/singularityware/singularity/pull/1084","diff_url":"https://github.com/singularityware/singularity/pull/1084.diff","patch_url":"https://github.com/singularityware/singularity/pull/1084.patch"},"body":"Finding the module on build host is neither a guarantee it will\r\nexist in the runtime environment, nor is absence of the module\r\na guarantee overlayfs is not supported (may be compiled into\r\nkernel).\r\nSo don't deduce runtime environment from build host,\r\nbut always use the new 'try' feature.\r\nFor testing, activate that if the module is found.\r\n\r\nSigned-off-by: Oliver Freyermuth <o.freyermuth@googlemail.com>\r\n\r\n**This fixes or addresses the following GitHub issues:**\r\n\r\n- Ref: #1044\r\n\r\n\r\n**Checkoff for all PRs:**\r\n\r\n- [x] I have read the [Guidelines for Contributing](https://github.com/singularityware/singularity/blob/master/CONTRIBUTING.md), and this PR conforms to the stated requirements.\r\n- [ ] I have tested this PR locally with a `make test`\r\n- [x] This PR is NOT against the project's master branch\r\n- [x] I have added myself as a contributor to the [contributors's file](https://github.com/singularityware/singularity/blob/master/CONTRIBUTORS.md)\r\n- [x] This PR is ready for review and/or merge\r\n\r\n\r\nAttn: @singularityware-admin\r\n\r\nNote: I did not run `make test`, that makes no sense on my machine, since I have overlayfs support compiled in. "},"comment":{"url":"https://api.github.com/repos/singularityware/singularity/issues/comments/340783602","html_url":"https://github.com/singularityware/singularity/pull/1084#issuecomment-340783602","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/1084","id":340783602,"user":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"created_at":"2017-10-31T14:41:20Z","updated_at":"2017-10-31T14:41:20Z","author_association":"OWNER","body":":bug: :spider: "}}
{"actor":{"display_login":"vsoch"}}