{"action":"created","issue":{"url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/68","repository_url":"https://api.github.com/repos/opentracing/opentracing-javascript","labels_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/68/comments","events_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/68/events","html_url":"https://github.com/opentracing/opentracing-javascript/pull/68","id":218758460,"number":68,"title":"Use TypeScript","user":{"login":"felixfbecker","id":10532611,"avatar_url":"https://avatars3.githubusercontent.com/u/10532611?v=3","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2017-04-02T11:28:07Z","updated_at":"2017-04-23T20:19:20Z","closed_at":"2017-04-23T20:07:27Z","pull_request":{"url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/68","html_url":"https://github.com/opentracing/opentracing-javascript/pull/68","diff_url":"https://github.com/opentracing/opentracing-javascript/pull/68.diff","patch_url":"https://github.com/opentracing/opentracing-javascript/pull/68.patch"},"body":"This is a PR to change the implementation from transpiled ES6 code to transpiled TypeScript code.\r\n\r\nThe biggest advantage is type safety for properties, call signatures, return types and object interfaces, for the code in this repo, implementations and consumers.\r\nCode is transpiled to ES5 code just like before, so for JavaScript consumers nothing changes.\r\nTypeScript users can now use the package with TypeScript and get generated definition files (.d.ts) for free.\r\n\r\nAs TypeScript is a superset of JavaScript, the actual changes are pretty small. All that's added is a few type declarations and visibilities for `protected` methods that are intended to be overridden by implementations.\r\n\r\nTODO:\r\n- [x] Adapt code\r\n- [x] Adapt tests\r\n- [x] Add TSLint\r\n- [x] Remove Babel\r\n- [x] Configure webpack\r\n- [x] Add generated documentation with tsdoc\r\n- [x] Update README"},"comment":{"url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/comments/296485687","html_url":"https://github.com/opentracing/opentracing-javascript/pull/68#issuecomment-296485687","issue_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/68","id":296485687,"user":{"login":"bhs","id":2251553,"avatar_url":"https://avatars1.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bhs","html_url":"https://github.com/bhs","followers_url":"https://api.github.com/users/bhs/followers","following_url":"https://api.github.com/users/bhs/following{/other_user}","gists_url":"https://api.github.com/users/bhs/gists{/gist_id}","starred_url":"https://api.github.com/users/bhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhs/subscriptions","organizations_url":"https://api.github.com/users/bhs/orgs","repos_url":"https://api.github.com/users/bhs/repos","events_url":"https://api.github.com/users/bhs/events{/privacy}","received_events_url":"https://api.github.com/users/bhs/received_events","type":"User","site_admin":false},"created_at":"2017-04-23T20:19:20Z","updated_at":"2017-04-23T20:19:20Z","body":"@felixfbecker well, I probably effed that up nicely then – I really only had about 30 mins to do all of this in the midst of a bunch of other stuff. For better or worse I was successful at everything in https://github.com/opentracing/opentracing-javascript/pull/68#issuecomment-296284685 and also the minor version bump. :-/\r\n\r\nSee http://opentracing-javascript.surge.sh/ and let me know if you need help fixing anything that's broken."}}
{"actor":{"display_login":"bhs"}}