{"push_id":1527064679,"size":3,"distinct_size":3,"ref":"refs/heads/checkstyle","head":"5e2eeba3d62f2b13c181f83a50d7f0dcc963b615","before":"d5255031768f183d68c4e6628f22154f1af48520","commits":[{"sha":"79fd6d0bf024aa0ccded5f9bb8fd9459c25676ea","author":{"name":"chao1995","email":"e8823178cae16b1dabaf7381c8b0518c6a8057d8@gmail.com"},"message":"Check overloaded methods are grouped together in checkstyle\n\nThis new checkstyle rule improves the readability of the code as it\nallows developers to see all the variations of a method at one place\nwith no other code in between.\n\nHowever, note that there is a potential loophole in checkstyle\nOverloadMethodsDeclarationOrder module which permits out-of-order\noverloaded methods when they are separated by a nested class or\ninterface.\n\ne.g. the following code in ModelManager.java will still pass the check,\neven though there is a nested interface between the two\n`updateFilteredPersonList()` method definitions:\n\n    private void updateFilteredPersonList(Expression expression) {\n        filteredPersons.setPredicate(expression::satisfies);\n    }\n\n    //========== Inner classes/interfaces ==================\n    interface Expression {\n        boolean satisfies(ReadOnlyPerson person);\n        String toString();\n    }\n\n    public void updateFilteredPersonList(String keyword, boolean someRandomBool) {\n        // do nothing\n    }","distinct":true,"url":"https://api.github.com/repos/CS2103R-Eugene-Peh/addressbook-level4/commits/79fd6d0bf024aa0ccded5f9bb8fd9459c25676ea"},{"sha":"9321a79e2fc882fbfce56d31d2f8df32f11bd16c","author":{"name":"Paul Tan","email":"47694dae389453634f0f8d3a618ffe16016d5f4c@gmail.com"},"message":"[#229] checkstyle: ensure overloaded methods are grouped together (#251)\n\nEnable a new checkstyle rule to check that overloaded methods are\ngrouped together.\n\n* 229-checkstyle-overloaded-methods-order:\n  Check overloaded methods are grouped together in checkstyle","distinct":true,"url":"https://api.github.com/repos/CS2103R-Eugene-Peh/addressbook-level4/commits/9321a79e2fc882fbfce56d31d2f8df32f11bd16c"},{"sha":"5e2eeba3d62f2b13c181f83a50d7f0dcc963b615","author":{"name":"Eugene Peh","email":"ca2692c0d19844439865875c52b6ac413ffabe6f@users.noreply.github.com"},"message":"Merge branch 'master' into checkstyle","distinct":true,"url":"https://api.github.com/repos/CS2103R-Eugene-Peh/addressbook-level4/commits/5e2eeba3d62f2b13c181f83a50d7f0dcc963b615"}]}
{"actor":{"display_login":"eugenepeh"}}