{"action":"created","issue":{"url":"https://api.github.com/repos/postfixadmin/postfixadmin/issues/49","repository_url":"https://api.github.com/repos/postfixadmin/postfixadmin","labels_url":"https://api.github.com/repos/postfixadmin/postfixadmin/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/postfixadmin/postfixadmin/issues/49/comments","events_url":"https://api.github.com/repos/postfixadmin/postfixadmin/issues/49/events","html_url":"https://github.com/postfixadmin/postfixadmin/pull/49","id":235852923,"number":49,"title":" Updated version of virtual vacation script with Email::Sender","user":{"login":"gianlucagiacometti","id":52405,"avatar_url":"https://avatars0.githubusercontent.com/u/52405?v=3","gravatar_id":"","url":"https://api.github.com/users/gianlucagiacometti","html_url":"https://github.com/gianlucagiacometti","followers_url":"https://api.github.com/users/gianlucagiacometti/followers","following_url":"https://api.github.com/users/gianlucagiacometti/following{/other_user}","gists_url":"https://api.github.com/users/gianlucagiacometti/gists{/gist_id}","starred_url":"https://api.github.com/users/gianlucagiacometti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianlucagiacometti/subscriptions","organizations_url":"https://api.github.com/users/gianlucagiacometti/orgs","repos_url":"https://api.github.com/users/gianlucagiacometti/repos","events_url":"https://api.github.com/users/gianlucagiacometti/events{/privacy}","received_events_url":"https://api.github.com/users/gianlucagiacometti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-14T11:49:08Z","updated_at":"2017-06-14T14:47:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/postfixadmin/postfixadmin/pulls/49","html_url":"https://github.com/postfixadmin/postfixadmin/pull/49","diff_url":"https://github.com/postfixadmin/postfixadmin/pull/49.diff","patch_url":"https://github.com/postfixadmin/postfixadmin/pull/49.patch"},"body":"Mail::Server  ==> Email::Server\r\nMain update.\r\nMAIL::Server is deprecated and the script neeeded the new library.\r\n\r\nGetOpt::Std ==> GetOpt::Long\r\nOn my Ubuntu 16.04 servers with Perl 5.22 I had problems to install GetOpt::Std, cpan request was to force update to Perl 5.26, which I didn't want to.\r\nI changed the usage syntax, which now is: vacation.pl [-t] -f {sender} -d {recipient}\r\n\r\nLogger initialization\r\nI changed the logger initialization and put it into the config section\r\n\r\nVersion update\r\nI choosed to start a version 5.0 of the script since the updates are rather deep."},"comment":{"url":"https://api.github.com/repos/postfixadmin/postfixadmin/issues/comments/308454859","html_url":"https://github.com/postfixadmin/postfixadmin/pull/49#issuecomment-308454859","issue_url":"https://api.github.com/repos/postfixadmin/postfixadmin/issues/49","id":308454859,"user":{"login":"gianlucagiacometti","id":52405,"avatar_url":"https://avatars0.githubusercontent.com/u/52405?v=3","gravatar_id":"","url":"https://api.github.com/users/gianlucagiacometti","html_url":"https://github.com/gianlucagiacometti","followers_url":"https://api.github.com/users/gianlucagiacometti/followers","following_url":"https://api.github.com/users/gianlucagiacometti/following{/other_user}","gists_url":"https://api.github.com/users/gianlucagiacometti/gists{/gist_id}","starred_url":"https://api.github.com/users/gianlucagiacometti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianlucagiacometti/subscriptions","organizations_url":"https://api.github.com/users/gianlucagiacometti/orgs","repos_url":"https://api.github.com/users/gianlucagiacometti/repos","events_url":"https://api.github.com/users/gianlucagiacometti/events{/privacy}","received_events_url":"https://api.github.com/users/gianlucagiacometti/received_events","type":"User","site_admin":false},"created_at":"2017-06-14T14:47:30Z","updated_at":"2017-06-14T14:47:30Z","body":"@cboltz \r\nI totally agree with you.\r\nPlease consider that I have no confidence at all with perl and all your concerns are related to my lack of knowledge.\r\n\r\n- I was not able with Getopt::Long to reproduce the old usage syntax. Anyway, I checked better and realised that it's Getopt::Std and not GetOpt::Std, so we can go back to the old way avoiding syntax changes and complaints. I would suggest anyway a syntax change in your new release because it seems more standard without that 'strange' -- (if we can say so).\r\n\r\n- I unsuccessfully tried to pass variables to my $conf = q(. I agree that would be better to separate code and config. So I moved that code as is under the config section.\r\n\r\n- Same thing for the parameters of the transport. It would be much better to prepare a hash and pass it to the transport, being careful that, if I got well, Email::Sender::Transport::SMTPS is a little bit picky with such parameters (i.e. if ssl != '' then all parameters related to authentications are required and expected). So it should be well stated in the config comments 'you should know what you're doing', hoping Email::Sender documentation to become more clear and deep in future.\r\n\r\nThanks again to you both"}}
{"actor":{"display_login":"gianlucagiacometti"}}