{"action":"created","comment":{"url":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/comments/100661443","pull_request_review_id":21380415,"id":100661443,"diff_hunk":"@@ -0,0 +1,60 @@\n+// Package osm provides common types for OpneStreetMap used by various providers","path":"osm/osm.go","position":1,"original_position":1,"commit_id":"a6c1fa23a1b35675099d003a89a3939ab1212d4d","original_commit_id":"a6c1fa23a1b35675099d003a89a3939ab1212d4d","user":{"login":"codingsince1985","id":8470763,"avatar_url":"https://avatars.githubusercontent.com/u/8470763?v=3","gravatar_id":"","url":"https://api.github.com/users/codingsince1985","html_url":"https://github.com/codingsince1985","followers_url":"https://api.github.com/users/codingsince1985/followers","following_url":"https://api.github.com/users/codingsince1985/following{/other_user}","gists_url":"https://api.github.com/users/codingsince1985/gists{/gist_id}","starred_url":"https://api.github.com/users/codingsince1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingsince1985/subscriptions","organizations_url":"https://api.github.com/users/codingsince1985/orgs","repos_url":"https://api.github.com/users/codingsince1985/repos","events_url":"https://api.github.com/users/codingsince1985/events{/privacy}","received_events_url":"https://api.github.com/users/codingsince1985/received_events","type":"User","site_admin":false},"body":"typo 'OpneStreetMap'","created_at":"2017-02-11T06:27:08Z","updated_at":"2017-02-11T06:27:08Z","html_url":"https://github.com/codingsince1985/geo-golang/pull/34#discussion_r100661443","pull_request_url":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/comments/100661443"},"html":{"href":"https://github.com/codingsince1985/geo-golang/pull/34#discussion_r100661443"},"pull_request":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34","id":105583352,"html_url":"https://github.com/codingsince1985/geo-golang/pull/34","diff_url":"https://github.com/codingsince1985/geo-golang/pull/34.diff","patch_url":"https://github.com/codingsince1985/geo-golang/pull/34.patch","issue_url":"https://api.github.com/repos/codingsince1985/geo-golang/issues/34","number":34,"state":"open","locked":false,"title":"Add structured address","user":{"login":"manolovl","id":19901080,"avatar_url":"https://avatars.githubusercontent.com/u/19901080?v=3","gravatar_id":"","url":"https://api.github.com/users/manolovl","html_url":"https://github.com/manolovl","followers_url":"https://api.github.com/users/manolovl/followers","following_url":"https://api.github.com/users/manolovl/following{/other_user}","gists_url":"https://api.github.com/users/manolovl/gists{/gist_id}","starred_url":"https://api.github.com/users/manolovl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolovl/subscriptions","organizations_url":"https://api.github.com/users/manolovl/orgs","repos_url":"https://api.github.com/users/manolovl/repos","events_url":"https://api.github.com/users/manolovl/events{/privacy}","received_events_url":"https://api.github.com/users/manolovl/received_events","type":"User","site_admin":false},"body":"PR to solve [issue #29](https://github.com/codingsince1985/geo-golang/issues/29) \r\n\r\nIt's been a while, but with Christmas, work and family added to the fact I had to sign up for many of the providers, the library supports, look into the documentation of their API, etc...\r\n\r\nTo sum up the major changes I made:\r\n\r\n- use `context.Context` with a timeout instead of `time.After` with the benefit of cleaning up / releasing resources in case the deadline has been reached\r\n- moved the structures `geo.Location` and `geo.Address` to `geocoder.go`, where the definition of the interface is placed, since these are part of the interface's contract and also to reduce the LOC in `http_geocoder.go`\r\n- no longer using `ErrNoResults`, this can be now deduced if the returned values are `nil, nil`; in case an error has been returned by the provider (only few really do so) it's then translated in the second return value\r\n- moved the examples code from `geocoder_test.go` to `examples/geocoder_example.go` to not be mistaken with unit tests, because of language specific conventions\r\n\r\nIn case of further questions / concerns, I'll be glad to discuss them.\r\n\r\nCheers","created_at":"2017-02-10T08:14:52Z","updated_at":"2017-02-11T06:27:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a9e3e5b4d5391ab9e54a868f9274e137aba1fd2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34/commits","review_comments_url":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34/comments","review_comment_url":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codingsince1985/geo-golang/issues/34/comments","statuses_url":"https://api.github.com/repos/codingsince1985/geo-golang/statuses/a6c1fa23a1b35675099d003a89a3939ab1212d4d","head":{"label":"manolovl:add-structured-address","ref":"add-structured-address","sha":"a6c1fa23a1b35675099d003a89a3939ab1212d4d","user":{"login":"manolovl","id":19901080,"avatar_url":"https://avatars.githubusercontent.com/u/19901080?v=3","gravatar_id":"","url":"https://api.github.com/users/manolovl","html_url":"https://github.com/manolovl","followers_url":"https://api.github.com/users/manolovl/followers","following_url":"https://api.github.com/users/manolovl/following{/other_user}","gists_url":"https://api.github.com/users/manolovl/gists{/gist_id}","starred_url":"https://api.github.com/users/manolovl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolovl/subscriptions","organizations_url":"https://api.github.com/users/manolovl/orgs","repos_url":"https://api.github.com/users/manolovl/repos","events_url":"https://api.github.com/users/manolovl/events{/privacy}","received_events_url":"https://api.github.com/users/manolovl/received_events","type":"User","site_admin":false},"repo":{"id":76556782,"name":"geo-golang","full_name":"manolovl/geo-golang","owner":{"login":"manolovl","id":19901080,"avatar_url":"https://avatars.githubusercontent.com/u/19901080?v=3","gravatar_id":"","url":"https://api.github.com/users/manolovl","html_url":"https://github.com/manolovl","followers_url":"https://api.github.com/users/manolovl/followers","following_url":"https://api.github.com/users/manolovl/following{/other_user}","gists_url":"https://api.github.com/users/manolovl/gists{/gist_id}","starred_url":"https://api.github.com/users/manolovl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolovl/subscriptions","organizations_url":"https://api.github.com/users/manolovl/orgs","repos_url":"https://api.github.com/users/manolovl/repos","events_url":"https://api.github.com/users/manolovl/events{/privacy}","received_events_url":"https://api.github.com/users/manolovl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manolovl/geo-golang","description":"(reverse) geocoding service in Go","fork":true,"url":"https://api.github.com/repos/manolovl/geo-golang","forks_url":"https://api.github.com/repos/manolovl/geo-golang/forks","keys_url":"https://api.github.com/repos/manolovl/geo-golang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manolovl/geo-golang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manolovl/geo-golang/teams","hooks_url":"https://api.github.com/repos/manolovl/geo-golang/hooks","issue_events_url":"https://api.github.com/repos/manolovl/geo-golang/issues/events{/number}","events_url":"https://api.github.com/repos/manolovl/geo-golang/events","assignees_url":"https://api.github.com/repos/manolovl/geo-golang/assignees{/user}","branches_url":"https://api.github.com/repos/manolovl/geo-golang/branches{/branch}","tags_url":"https://api.github.com/repos/manolovl/geo-golang/tags","blobs_url":"https://api.github.com/repos/manolovl/geo-golang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manolovl/geo-golang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manolovl/geo-golang/git/refs{/sha}","trees_url":"https://api.github.com/repos/manolovl/geo-golang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manolovl/geo-golang/statuses/{sha}","languages_url":"https://api.github.com/repos/manolovl/geo-golang/languages","stargazers_url":"https://api.github.com/repos/manolovl/geo-golang/stargazers","contributors_url":"https://api.github.com/repos/manolovl/geo-golang/contributors","subscribers_url":"https://api.github.com/repos/manolovl/geo-golang/subscribers","subscription_url":"https://api.github.com/repos/manolovl/geo-golang/subscription","commits_url":"https://api.github.com/repos/manolovl/geo-golang/commits{/sha}","git_commits_url":"https://api.github.com/repos/manolovl/geo-golang/git/commits{/sha}","comments_url":"https://api.github.com/repos/manolovl/geo-golang/comments{/number}","issue_comment_url":"https://api.github.com/repos/manolovl/geo-golang/issues/comments{/number}","contents_url":"https://api.github.com/repos/manolovl/geo-golang/contents/{+path}","compare_url":"https://api.github.com/repos/manolovl/geo-golang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manolovl/geo-golang/merges","archive_url":"https://api.github.com/repos/manolovl/geo-golang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manolovl/geo-golang/downloads","issues_url":"https://api.github.com/repos/manolovl/geo-golang/issues{/number}","pulls_url":"https://api.github.com/repos/manolovl/geo-golang/pulls{/number}","milestones_url":"https://api.github.com/repos/manolovl/geo-golang/milestones{/number}","notifications_url":"https://api.github.com/repos/manolovl/geo-golang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manolovl/geo-golang/labels{/name}","releases_url":"https://api.github.com/repos/manolovl/geo-golang/releases{/id}","deployments_url":"https://api.github.com/repos/manolovl/geo-golang/deployments","created_at":"2016-12-15T12:12:18Z","updated_at":"2016-12-15T12:12:19Z","pushed_at":"2017-02-10T13:15:12Z","git_url":"git://github.com/manolovl/geo-golang.git","ssh_url":"git@github.com:manolovl/geo-golang.git","clone_url":"https://github.com/manolovl/geo-golang.git","svn_url":"https://github.com/manolovl/geo-golang","homepage":"","size":555,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codingsince1985:master","ref":"master","sha":"f44149a9c385c8dea776f8bf406d2404d23ec490","user":{"login":"codingsince1985","id":8470763,"avatar_url":"https://avatars.githubusercontent.com/u/8470763?v=3","gravatar_id":"","url":"https://api.github.com/users/codingsince1985","html_url":"https://github.com/codingsince1985","followers_url":"https://api.github.com/users/codingsince1985/followers","following_url":"https://api.github.com/users/codingsince1985/following{/other_user}","gists_url":"https://api.github.com/users/codingsince1985/gists{/gist_id}","starred_url":"https://api.github.com/users/codingsince1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingsince1985/subscriptions","organizations_url":"https://api.github.com/users/codingsince1985/orgs","repos_url":"https://api.github.com/users/codingsince1985/repos","events_url":"https://api.github.com/users/codingsince1985/events{/privacy}","received_events_url":"https://api.github.com/users/codingsince1985/received_events","type":"User","site_admin":false},"repo":{"id":27530442,"name":"geo-golang","full_name":"codingsince1985/geo-golang","owner":{"login":"codingsince1985","id":8470763,"avatar_url":"https://avatars.githubusercontent.com/u/8470763?v=3","gravatar_id":"","url":"https://api.github.com/users/codingsince1985","html_url":"https://github.com/codingsince1985","followers_url":"https://api.github.com/users/codingsince1985/followers","following_url":"https://api.github.com/users/codingsince1985/following{/other_user}","gists_url":"https://api.github.com/users/codingsince1985/gists{/gist_id}","starred_url":"https://api.github.com/users/codingsince1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingsince1985/subscriptions","organizations_url":"https://api.github.com/users/codingsince1985/orgs","repos_url":"https://api.github.com/users/codingsince1985/repos","events_url":"https://api.github.com/users/codingsince1985/events{/privacy}","received_events_url":"https://api.github.com/users/codingsince1985/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codingsince1985/geo-golang","description":"Go library to access geocoding and reverse geocoding APIs","fork":false,"url":"https://api.github.com/repos/codingsince1985/geo-golang","forks_url":"https://api.github.com/repos/codingsince1985/geo-golang/forks","keys_url":"https://api.github.com/repos/codingsince1985/geo-golang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codingsince1985/geo-golang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codingsince1985/geo-golang/teams","hooks_url":"https://api.github.com/repos/codingsince1985/geo-golang/hooks","issue_events_url":"https://api.github.com/repos/codingsince1985/geo-golang/issues/events{/number}","events_url":"https://api.github.com/repos/codingsince1985/geo-golang/events","assignees_url":"https://api.github.com/repos/codingsince1985/geo-golang/assignees{/user}","branches_url":"https://api.github.com/repos/codingsince1985/geo-golang/branches{/branch}","tags_url":"https://api.github.com/repos/codingsince1985/geo-golang/tags","blobs_url":"https://api.github.com/repos/codingsince1985/geo-golang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codingsince1985/geo-golang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codingsince1985/geo-golang/git/refs{/sha}","trees_url":"https://api.github.com/repos/codingsince1985/geo-golang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codingsince1985/geo-golang/statuses/{sha}","languages_url":"https://api.github.com/repos/codingsince1985/geo-golang/languages","stargazers_url":"https://api.github.com/repos/codingsince1985/geo-golang/stargazers","contributors_url":"https://api.github.com/repos/codingsince1985/geo-golang/contributors","subscribers_url":"https://api.github.com/repos/codingsince1985/geo-golang/subscribers","subscription_url":"https://api.github.com/repos/codingsince1985/geo-golang/subscription","commits_url":"https://api.github.com/repos/codingsince1985/geo-golang/commits{/sha}","git_commits_url":"https://api.github.com/repos/codingsince1985/geo-golang/git/commits{/sha}","comments_url":"https://api.github.com/repos/codingsince1985/geo-golang/comments{/number}","issue_comment_url":"https://api.github.com/repos/codingsince1985/geo-golang/issues/comments{/number}","contents_url":"https://api.github.com/repos/codingsince1985/geo-golang/contents/{+path}","compare_url":"https://api.github.com/repos/codingsince1985/geo-golang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codingsince1985/geo-golang/merges","archive_url":"https://api.github.com/repos/codingsince1985/geo-golang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codingsince1985/geo-golang/downloads","issues_url":"https://api.github.com/repos/codingsince1985/geo-golang/issues{/number}","pulls_url":"https://api.github.com/repos/codingsince1985/geo-golang/pulls{/number}","milestones_url":"https://api.github.com/repos/codingsince1985/geo-golang/milestones{/number}","notifications_url":"https://api.github.com/repos/codingsince1985/geo-golang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codingsince1985/geo-golang/labels{/name}","releases_url":"https://api.github.com/repos/codingsince1985/geo-golang/releases{/id}","deployments_url":"https://api.github.com/repos/codingsince1985/geo-golang/deployments","created_at":"2014-12-04T08:18:31Z","updated_at":"2017-02-08T20:26:08Z","pushed_at":"2017-02-10T13:15:15Z","git_url":"git://github.com/codingsince1985/geo-golang.git","ssh_url":"git@github.com:codingsince1985/geo-golang.git","clone_url":"https://github.com/codingsince1985/geo-golang.git","svn_url":"https://github.com/codingsince1985/geo-golang","homepage":"","size":512,"stargazers_count":152,"watchers_count":152,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34"},"html":{"href":"https://github.com/codingsince1985/geo-golang/pull/34"},"issue":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/issues/34"},"comments":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/codingsince1985/geo-golang/statuses/a6c1fa23a1b35675099d003a89a3939ab1212d4d"}}}}
{"actor":{"display_login":"codingsince1985"}}