{"action":"closed","number":6098,"pull_request":{"url":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/6098","id":98440524,"html_url":"https://github.com/linuxmint/Cinnamon/pull/6098","diff_url":"https://github.com/linuxmint/Cinnamon/pull/6098.diff","patch_url":"https://github.com/linuxmint/Cinnamon/pull/6098.patch","issue_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/6098","number":6098,"state":"closed","locked":false,"title":"Code improvements","user":{"login":"germanfr","id":10391266,"avatar_url":"https://avatars2.githubusercontent.com/u/10391266?v=3","gravatar_id":"","url":"https://api.github.com/users/germanfr","html_url":"https://github.com/germanfr","followers_url":"https://api.github.com/users/germanfr/followers","following_url":"https://api.github.com/users/germanfr/following{/other_user}","gists_url":"https://api.github.com/users/germanfr/gists{/gist_id}","starred_url":"https://api.github.com/users/germanfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanfr/subscriptions","organizations_url":"https://api.github.com/users/germanfr/orgs","repos_url":"https://api.github.com/users/germanfr/repos","events_url":"https://api.github.com/users/germanfr/events{/privacy}","received_events_url":"https://api.github.com/users/germanfr/received_events","type":"User","site_admin":false},"body":"Remove some unnecessary if checks, because some things can't happen at the same time (if/else).\r\n\r\nAdded method `isHorizontal` because there are lots of repetitions of the same check. Improves readability removing the need of parenthesis and long/broken lines. (It does not necessarily need to be part of the panel interface).","created_at":"2016-12-17T10:38:28Z","updated_at":"2017-04-02T17:52:39Z","closed_at":"2017-04-02T17:52:39Z","merged_at":null,"merge_commit_sha":"c21282af8cffdf88c57a81a18f425c132a48fb98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/6098/commits","review_comments_url":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/6098/comments","review_comment_url":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/6098/comments","statuses_url":"https://api.github.com/repos/linuxmint/Cinnamon/statuses/1d744823a4ea4423249f1272ba817e02bebe342a","head":{"label":"germanfr:if-xes","ref":"if-xes","sha":"1d744823a4ea4423249f1272ba817e02bebe342a","user":{"login":"germanfr","id":10391266,"avatar_url":"https://avatars2.githubusercontent.com/u/10391266?v=3","gravatar_id":"","url":"https://api.github.com/users/germanfr","html_url":"https://github.com/germanfr","followers_url":"https://api.github.com/users/germanfr/followers","following_url":"https://api.github.com/users/germanfr/following{/other_user}","gists_url":"https://api.github.com/users/germanfr/gists{/gist_id}","starred_url":"https://api.github.com/users/germanfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanfr/subscriptions","organizations_url":"https://api.github.com/users/germanfr/orgs","repos_url":"https://api.github.com/users/germanfr/repos","events_url":"https://api.github.com/users/germanfr/events{/privacy}","received_events_url":"https://api.github.com/users/germanfr/received_events","type":"User","site_admin":false},"repo":{"id":71630511,"name":"Cinnamon","full_name":"germanfr/Cinnamon","owner":{"login":"germanfr","id":10391266,"avatar_url":"https://avatars2.githubusercontent.com/u/10391266?v=3","gravatar_id":"","url":"https://api.github.com/users/germanfr","html_url":"https://github.com/germanfr","followers_url":"https://api.github.com/users/germanfr/followers","following_url":"https://api.github.com/users/germanfr/following{/other_user}","gists_url":"https://api.github.com/users/germanfr/gists{/gist_id}","starred_url":"https://api.github.com/users/germanfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanfr/subscriptions","organizations_url":"https://api.github.com/users/germanfr/orgs","repos_url":"https://api.github.com/users/germanfr/repos","events_url":"https://api.github.com/users/germanfr/events{/privacy}","received_events_url":"https://api.github.com/users/germanfr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/germanfr/Cinnamon","description":"A Linux Desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features. ","fork":true,"url":"https://api.github.com/repos/germanfr/Cinnamon","forks_url":"https://api.github.com/repos/germanfr/Cinnamon/forks","keys_url":"https://api.github.com/repos/germanfr/Cinnamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/germanfr/Cinnamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/germanfr/Cinnamon/teams","hooks_url":"https://api.github.com/repos/germanfr/Cinnamon/hooks","issue_events_url":"https://api.github.com/repos/germanfr/Cinnamon/issues/events{/number}","events_url":"https://api.github.com/repos/germanfr/Cinnamon/events","assignees_url":"https://api.github.com/repos/germanfr/Cinnamon/assignees{/user}","branches_url":"https://api.github.com/repos/germanfr/Cinnamon/branches{/branch}","tags_url":"https://api.github.com/repos/germanfr/Cinnamon/tags","blobs_url":"https://api.github.com/repos/germanfr/Cinnamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/germanfr/Cinnamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/germanfr/Cinnamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/germanfr/Cinnamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/germanfr/Cinnamon/statuses/{sha}","languages_url":"https://api.github.com/repos/germanfr/Cinnamon/languages","stargazers_url":"https://api.github.com/repos/germanfr/Cinnamon/stargazers","contributors_url":"https://api.github.com/repos/germanfr/Cinnamon/contributors","subscribers_url":"https://api.github.com/repos/germanfr/Cinnamon/subscribers","subscription_url":"https://api.github.com/repos/germanfr/Cinnamon/subscription","commits_url":"https://api.github.com/repos/germanfr/Cinnamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/germanfr/Cinnamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/germanfr/Cinnamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/germanfr/Cinnamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/germanfr/Cinnamon/contents/{+path}","compare_url":"https://api.github.com/repos/germanfr/Cinnamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/germanfr/Cinnamon/merges","archive_url":"https://api.github.com/repos/germanfr/Cinnamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/germanfr/Cinnamon/downloads","issues_url":"https://api.github.com/repos/germanfr/Cinnamon/issues{/number}","pulls_url":"https://api.github.com/repos/germanfr/Cinnamon/pulls{/number}","milestones_url":"https://api.github.com/repos/germanfr/Cinnamon/milestones{/number}","notifications_url":"https://api.github.com/repos/germanfr/Cinnamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/germanfr/Cinnamon/labels{/name}","releases_url":"https://api.github.com/repos/germanfr/Cinnamon/releases{/id}","deployments_url":"https://api.github.com/repos/germanfr/Cinnamon/deployments","created_at":"2016-10-22T09:49:26Z","updated_at":"2016-10-22T09:49:31Z","pushed_at":"2017-01-07T13:30:53Z","git_url":"git://github.com/germanfr/Cinnamon.git","ssh_url":"git@github.com:germanfr/Cinnamon.git","clone_url":"https://github.com/germanfr/Cinnamon.git","svn_url":"https://github.com/germanfr/Cinnamon","homepage":"","size":24290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linuxmint:master","ref":"master","sha":"44bd23b73d0722dd13e9741af311cc61f774a935","user":{"login":"linuxmint","id":107184,"avatar_url":"https://avatars2.githubusercontent.com/u/107184?v=3","gravatar_id":"","url":"https://api.github.com/users/linuxmint","html_url":"https://github.com/linuxmint","followers_url":"https://api.github.com/users/linuxmint/followers","following_url":"https://api.github.com/users/linuxmint/following{/other_user}","gists_url":"https://api.github.com/users/linuxmint/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxmint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxmint/subscriptions","organizations_url":"https://api.github.com/users/linuxmint/orgs","repos_url":"https://api.github.com/users/linuxmint/repos","events_url":"https://api.github.com/users/linuxmint/events{/privacy}","received_events_url":"https://api.github.com/users/linuxmint/received_events","type":"Organization","site_admin":false},"repo":{"id":3019537,"name":"Cinnamon","full_name":"linuxmint/Cinnamon","owner":{"login":"linuxmint","id":107184,"avatar_url":"https://avatars2.githubusercontent.com/u/107184?v=3","gravatar_id":"","url":"https://api.github.com/users/linuxmint","html_url":"https://github.com/linuxmint","followers_url":"https://api.github.com/users/linuxmint/followers","following_url":"https://api.github.com/users/linuxmint/following{/other_user}","gists_url":"https://api.github.com/users/linuxmint/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxmint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxmint/subscriptions","organizations_url":"https://api.github.com/users/linuxmint/orgs","repos_url":"https://api.github.com/users/linuxmint/repos","events_url":"https://api.github.com/users/linuxmint/events{/privacy}","received_events_url":"https://api.github.com/users/linuxmint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linuxmint/Cinnamon","description":"A Linux Desktop featuring a traditional layout, built from modern technology and introducing brand new innovative features. ","fork":false,"url":"https://api.github.com/repos/linuxmint/Cinnamon","forks_url":"https://api.github.com/repos/linuxmint/Cinnamon/forks","keys_url":"https://api.github.com/repos/linuxmint/Cinnamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxmint/Cinnamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxmint/Cinnamon/teams","hooks_url":"https://api.github.com/repos/linuxmint/Cinnamon/hooks","issue_events_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/events{/number}","events_url":"https://api.github.com/repos/linuxmint/Cinnamon/events","assignees_url":"https://api.github.com/repos/linuxmint/Cinnamon/assignees{/user}","branches_url":"https://api.github.com/repos/linuxmint/Cinnamon/branches{/branch}","tags_url":"https://api.github.com/repos/linuxmint/Cinnamon/tags","blobs_url":"https://api.github.com/repos/linuxmint/Cinnamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxmint/Cinnamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxmint/Cinnamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxmint/Cinnamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxmint/Cinnamon/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxmint/Cinnamon/languages","stargazers_url":"https://api.github.com/repos/linuxmint/Cinnamon/stargazers","contributors_url":"https://api.github.com/repos/linuxmint/Cinnamon/contributors","subscribers_url":"https://api.github.com/repos/linuxmint/Cinnamon/subscribers","subscription_url":"https://api.github.com/repos/linuxmint/Cinnamon/subscription","commits_url":"https://api.github.com/repos/linuxmint/Cinnamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxmint/Cinnamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxmint/Cinnamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxmint/Cinnamon/contents/{+path}","compare_url":"https://api.github.com/repos/linuxmint/Cinnamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxmint/Cinnamon/merges","archive_url":"https://api.github.com/repos/linuxmint/Cinnamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxmint/Cinnamon/downloads","issues_url":"https://api.github.com/repos/linuxmint/Cinnamon/issues{/number}","pulls_url":"https://api.github.com/repos/linuxmint/Cinnamon/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxmint/Cinnamon/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxmint/Cinnamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxmint/Cinnamon/labels{/name}","releases_url":"https://api.github.com/repos/linuxmint/Cinnamon/releases{/id}","deployments_url":"https://api.github.com/repos/linuxmint/Cinnamon/deployments","created_at":"2011-12-20T13:15:22Z","updated_at":"2017-04-02T16:19:30Z","pushed_at":"2017-04-02T16:43:17Z","git_url":"git://github.com/linuxmint/Cinnamon.git","ssh_url":"git@github.com:linuxmint/Cinnamon.git","clone_url":"https://github.com/linuxmint/Cinnamon.git","svn_url":"https://github.com/linuxmint/Cinnamon","homepage":"","size":24379,"stargazers_count":2000,"watchers_count":2000,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"open_issues_count":899,"forks":419,"open_issues":899,"watchers":2000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/6098"},"html":{"href":"https://github.com/linuxmint/Cinnamon/pull/6098"},"issue":{"href":"https://api.github.com/repos/linuxmint/Cinnamon/issues/6098"},"comments":{"href":"https://api.github.com/repos/linuxmint/Cinnamon/issues/6098/comments"},"review_comments":{"href":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/6098/comments"},"review_comment":{"href":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linuxmint/Cinnamon/pulls/6098/commits"},"statuses":{"href":"https://api.github.com/repos/linuxmint/Cinnamon/statuses/1d744823a4ea4423249f1272ba817e02bebe342a"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":33,"deletions":30,"changed_files":3}}
{"actor":{"display_login":"germanfr"}}