{"action":"closed","number":928,"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/928","id":116016355,"html_url":"https://github.com/kubernetes/charts/pull/928","diff_url":"https://github.com/kubernetes/charts/pull/928.diff","patch_url":"https://github.com/kubernetes/charts/pull/928.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/928","number":928,"state":"closed","locked":false,"title":"stable/coredns: Add a configuration to choose serviceProtocol","user":{"login":"shashidharatd","id":8734900,"avatar_url":"https://avatars0.githubusercontent.com/u/8734900?v=3","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},"body":"This is to fix the issue  #924 \r\nIt is found that when serviceType is \"LoadBalancer\", on some cloud environments CoreDNS fails to deploy.\r\nCoreDNS listens on both \"UDP\" and \"TCP\", but due to limitations some cloud environment does not support external loadbalancers with both \"UDP\" & \"TCP\" protocols. \r\nTo fix the issue, this pr adds a configurable parameter `serviceProtocol` to choose protocol for the service and the values could be one of \"UDP\", \"TCP\" or \"UDPNTCP\" (default). By default the service listens on both \"UDP\" and \"TCP\"","created_at":"2017-04-15T06:41:07Z","updated_at":"2017-05-04T03:13:55Z","closed_at":"2017-05-04T03:13:55Z","merged_at":"2017-05-04T03:13:55Z","merge_commit_sha":"2c355ece5a84c6650755595a00335097df7a0159","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/928/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/928/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/928/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/1dc4297376bbc817453285a615f227b5c2255006","head":{"label":"shashidharatd:coredns","ref":"coredns","sha":"1dc4297376bbc817453285a615f227b5c2255006","user":{"login":"shashidharatd","id":8734900,"avatar_url":"https://avatars0.githubusercontent.com/u/8734900?v=3","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},"repo":{"id":83867995,"name":"charts","full_name":"shashidharatd/charts","owner":{"login":"shashidharatd","id":8734900,"avatar_url":"https://avatars0.githubusercontent.com/u/8734900?v=3","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shashidharatd/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/shashidharatd/charts","forks_url":"https://api.github.com/repos/shashidharatd/charts/forks","keys_url":"https://api.github.com/repos/shashidharatd/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shashidharatd/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shashidharatd/charts/teams","hooks_url":"https://api.github.com/repos/shashidharatd/charts/hooks","issue_events_url":"https://api.github.com/repos/shashidharatd/charts/issues/events{/number}","events_url":"https://api.github.com/repos/shashidharatd/charts/events","assignees_url":"https://api.github.com/repos/shashidharatd/charts/assignees{/user}","branches_url":"https://api.github.com/repos/shashidharatd/charts/branches{/branch}","tags_url":"https://api.github.com/repos/shashidharatd/charts/tags","blobs_url":"https://api.github.com/repos/shashidharatd/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shashidharatd/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shashidharatd/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/shashidharatd/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shashidharatd/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/shashidharatd/charts/languages","stargazers_url":"https://api.github.com/repos/shashidharatd/charts/stargazers","contributors_url":"https://api.github.com/repos/shashidharatd/charts/contributors","subscribers_url":"https://api.github.com/repos/shashidharatd/charts/subscribers","subscription_url":"https://api.github.com/repos/shashidharatd/charts/subscription","commits_url":"https://api.github.com/repos/shashidharatd/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/shashidharatd/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/shashidharatd/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/shashidharatd/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/shashidharatd/charts/contents/{+path}","compare_url":"https://api.github.com/repos/shashidharatd/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shashidharatd/charts/merges","archive_url":"https://api.github.com/repos/shashidharatd/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shashidharatd/charts/downloads","issues_url":"https://api.github.com/repos/shashidharatd/charts/issues{/number}","pulls_url":"https://api.github.com/repos/shashidharatd/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/shashidharatd/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/shashidharatd/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shashidharatd/charts/labels{/name}","releases_url":"https://api.github.com/repos/shashidharatd/charts/releases{/id}","deployments_url":"https://api.github.com/repos/shashidharatd/charts/deployments","created_at":"2017-03-04T05:35:38Z","updated_at":"2017-03-04T05:35:41Z","pushed_at":"2017-04-19T18:17:05Z","git_url":"git://github.com/shashidharatd/charts.git","ssh_url":"git@github.com:shashidharatd/charts.git","clone_url":"https://github.com/shashidharatd/charts.git","svn_url":"https://github.com/shashidharatd/charts","homepage":"","size":1156,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"85a9b912332a126101c312738e793948ac0c9fd3","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2017-05-04T00:20:11Z","pushed_at":"2017-05-04T03:13:55Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":1204,"stargazers_count":565,"watchers_count":565,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":399,"mirror_url":null,"open_issues_count":195,"forks":399,"open_issues":195,"watchers":565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/928"},"html":{"href":"https://github.com/kubernetes/charts/pull/928"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/928"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/928/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/928/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/928/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/1dc4297376bbc817453285a615f227b5c2255006"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"seanknox","id":1231630,"avatar_url":"https://avatars2.githubusercontent.com/u/1231630?v=3","gravatar_id":"","url":"https://api.github.com/users/seanknox","html_url":"https://github.com/seanknox","followers_url":"https://api.github.com/users/seanknox/followers","following_url":"https://api.github.com/users/seanknox/following{/other_user}","gists_url":"https://api.github.com/users/seanknox/gists{/gist_id}","starred_url":"https://api.github.com/users/seanknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanknox/subscriptions","organizations_url":"https://api.github.com/users/seanknox/orgs","repos_url":"https://api.github.com/users/seanknox/repos","events_url":"https://api.github.com/users/seanknox/events{/privacy}","received_events_url":"https://api.github.com/users/seanknox/received_events","type":"User","site_admin":false},"comments":3,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":30,"deletions":2,"changed_files":6}}
{"actor":{"display_login":"seanknox"}}