{"action":"created","comment":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/comments/130983637","pull_request_review_id":53918414,"id":130983637,"diff_hunk":"@@ -54,10 +54,12 @@\n     \"site\": \"bundle exec jekyll serve\",\n \n     \"lint\": \"tslint --project tsconfig.json -c tslint.json --type-check\",\n-    \"test\": \"npm run tsc && npm run test:only && npm run lint\",\n+    \"test\": \"npm run build:only && npm run test:only && npm run test:runtime && npm run lint\",\n     \"posttest\": \"npm run schema && npm run data && npm run mocha:examples\",\n-    \"test:nocompile\": \"npm run test:only && npm run lint && npm run mocha:examples\",\n+    \"test:nocompile\": \"npm run test:only && npm run test:runtime && npm run lint && npm run mocha:examples\",\n     \"test:only\": \"nyc --reporter=html --reporter=text-summary npm run mocha:test\",\n+    \"test:runtime\": \"TZ=America/Los_Angeles wdio wdio.conf.js\",\n+    \"test:runtime:generate\": \"rm -Rf test-runtime/resources && VL_GENERATE_TESTS=true npm run test:runtime\",","path":"package.json","position":11,"original_position":11,"commit_id":"9f82014845171708e6c0577285719be1c0fe2823","original_commit_id":"9f82014845171708e6c0577285719be1c0fe2823","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars1.githubusercontent.com/u/111269?v=4","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"So I assume this is an equivalent to `build:examples` for the runtime test infrastructure right?","created_at":"2017-08-02T20:13:50Z","updated_at":"2017-08-02T20:13:50Z","html_url":"https://github.com/vega/vega-lite/pull/2724#discussion_r130983637","pull_request_url":"https://api.github.com/repos/vega/vega-lite/pulls/2724","_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments/130983637"},"html":{"href":"https://github.com/vega/vega-lite/pull/2724#discussion_r130983637"},"pull_request":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/2724"}}},"pull_request":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/2724","id":133330527,"html_url":"https://github.com/vega/vega-lite/pull/2724","diff_url":"https://github.com/vega/vega-lite/pull/2724.diff","patch_url":"https://github.com/vega/vega-lite/pull/2724.patch","issue_url":"https://api.github.com/repos/vega/vega-lite/issues/2724","number":2724,"state":"open","locked":false,"title":"[WIP] Runtime/integration tests for selections","user":{"login":"arvind","id":42262,"avatar_url":"https://avatars3.githubusercontent.com/u/42262?v=4","gravatar_id":"","url":"https://api.github.com/users/arvind","html_url":"https://github.com/arvind","followers_url":"https://api.github.com/users/arvind/followers","following_url":"https://api.github.com/users/arvind/following{/other_user}","gists_url":"https://api.github.com/users/arvind/gists{/gist_id}","starred_url":"https://api.github.com/users/arvind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvind/subscriptions","organizations_url":"https://api.github.com/users/arvind/orgs","repos_url":"https://api.github.com/users/arvind/repos","events_url":"https://api.github.com/users/arvind/events{/privacy}","received_events_url":"https://api.github.com/users/arvind/received_events","type":"User","site_admin":false},"body":"This PR adds runtime/integration tests using Chrome via webdriver.io. A Vega-Lite spec is rendered, a variety of interactions are performed, and assertions are run against the interactive state as well as a snapshot of the SVG string.\r\n\r\nTests can be run via `npm run test:runtime` and is set to automatically run with `npm run test` as well as `npm run test:nocompile`. To generate new SVG string snapshots, run `npm run test:runtime:generate` instead. \r\n\r\nThe generated SVG strings are current to Vega-Lite master 9f82014 but requires Vega 3.0.0-rc5 tuple ID changes as well several open vega-parser PRs to be merged. Although this PR is complete, I've marked it as WIP until the necessary Vega version is released.","created_at":"2017-07-31T20:32:49Z","updated_at":"2017-08-02T20:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e22ad10217c7b1229a51a58652f9c682aae1988a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"domoritz","id":589034,"avatar_url":"https://avatars2.githubusercontent.com/u/589034?v=4","gravatar_id":"","url":"https://api.github.com/users/domoritz","html_url":"https://github.com/domoritz","followers_url":"https://api.github.com/users/domoritz/followers","following_url":"https://api.github.com/users/domoritz/following{/other_user}","gists_url":"https://api.github.com/users/domoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoritz/subscriptions","organizations_url":"https://api.github.com/users/domoritz/orgs","repos_url":"https://api.github.com/users/domoritz/repos","events_url":"https://api.github.com/users/domoritz/events{/privacy}","received_events_url":"https://api.github.com/users/domoritz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-lite/pulls/2724/commits","review_comments_url":"https://api.github.com/repos/vega/vega-lite/pulls/2724/comments","review_comment_url":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-lite/issues/2724/comments","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/9f82014845171708e6c0577285719be1c0fe2823","head":{"label":"vega:as/runtimeTests","ref":"as/runtimeTests","sha":"9f82014845171708e6c0577285719be1c0fe2823","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A high-level grammar for visual analysis, built on top of Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2017-08-02T09:15:29Z","pushed_at":"2017-08-02T20:07:59Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":38970,"stargazers_count":816,"watchers_count":816,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":185,"forks":95,"open_issues":185,"watchers":816,"default_branch":"master"}},"base":{"label":"vega:master","ref":"master","sha":"d5f21e0ac671bdd970457c197703ab3f942b6510","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A high-level grammar for visual analysis, built on top of Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2017-08-02T09:15:29Z","pushed_at":"2017-08-02T20:07:59Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":38970,"stargazers_count":816,"watchers_count":816,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":185,"forks":95,"open_issues":185,"watchers":816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/2724"},"html":{"href":"https://github.com/vega/vega-lite/pull/2724"},"issue":{"href":"https://api.github.com/repos/vega/vega-lite/issues/2724"},"comments":{"href":"https://api.github.com/repos/vega/vega-lite/issues/2724/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/2724/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/2724/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-lite/statuses/9f82014845171708e6c0577285719be1c0fe2823"}}}}
{"actor":{"display_login":"kanitw"}}