{"action":"created","issue":{"url":"https://api.github.com/repos/freshOS/Stevia/issues/42","repository_url":"https://api.github.com/repos/freshOS/Stevia","labels_url":"https://api.github.com/repos/freshOS/Stevia/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/freshOS/Stevia/issues/42/comments","events_url":"https://api.github.com/repos/freshOS/Stevia/issues/42/events","html_url":"https://github.com/freshOS/Stevia/issues/42","id":160439283,"number":42,"title":"Memory leask: '.tap' helper retains view in memory even after remove from superview","user":{"login":"maximkhatskevich","id":2624646,"avatar_url":"https://avatars2.githubusercontent.com/u/2624646?v=3","gravatar_id":"","url":"https://api.github.com/users/maximkhatskevich","html_url":"https://github.com/maximkhatskevich","followers_url":"https://api.github.com/users/maximkhatskevich/followers","following_url":"https://api.github.com/users/maximkhatskevich/following{/other_user}","gists_url":"https://api.github.com/users/maximkhatskevich/gists{/gist_id}","starred_url":"https://api.github.com/users/maximkhatskevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximkhatskevich/subscriptions","organizations_url":"https://api.github.com/users/maximkhatskevich/orgs","repos_url":"https://api.github.com/users/maximkhatskevich/repos","events_url":"https://api.github.com/users/maximkhatskevich/events{/privacy}","received_events_url":"https://api.github.com/users/maximkhatskevich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-15T14:40:21Z","updated_at":"2017-04-02T19:12:23Z","closed_at":null,"body":"The problem (and solution) is described here http://www.klundberg.com/blog/capturing-objects-weakly-in-instance-method-references-in-swift/\n"},"comment":{"url":"https://api.github.com/repos/freshOS/Stevia/issues/comments/291007787","html_url":"https://github.com/freshOS/Stevia/issues/42#issuecomment-291007787","issue_url":"https://api.github.com/repos/freshOS/Stevia/issues/42","id":291007787,"user":{"login":"s4cha","id":1812953,"avatar_url":"https://avatars2.githubusercontent.com/u/1812953?v=3","gravatar_id":"","url":"https://api.github.com/users/s4cha","html_url":"https://github.com/s4cha","followers_url":"https://api.github.com/users/s4cha/followers","following_url":"https://api.github.com/users/s4cha/following{/other_user}","gists_url":"https://api.github.com/users/s4cha/gists{/gist_id}","starred_url":"https://api.github.com/users/s4cha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s4cha/subscriptions","organizations_url":"https://api.github.com/users/s4cha/orgs","repos_url":"https://api.github.com/users/s4cha/repos","events_url":"https://api.github.com/users/s4cha/events{/privacy}","received_events_url":"https://api.github.com/users/s4cha/received_events","type":"User","site_admin":false},"created_at":"2017-04-02T19:12:23Z","updated_at":"2017-04-02T19:12:23Z","body":"@maximkhatskevich Sorry for taking so long to reply.\r\nWe need to deprecate this indeed, I was attracted by the simplicity at the time but it causes a retain cycle as you mentioned.\r\nSince this is not part of the layout per-se. I think we should remove the `tap` helper all together.\r\n\r\nWe have a fallback solution, using selectors, cleaner and not producing retain cycles, that we could provide on the side for the ones wanting to opt out from the soon-to-be-deprecated `tap` function.\r\n\r\nWhat do you think ?\r\nBy the way if you have a helper that you're using that you want to share, please do :)"}}
{"actor":{"display_login":"s4cha"}}