{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/118625430","pull_request_review_id":40436052,"id":118625430,"diff_hunk":"@@ -46,10 +46,6 @@ KillMode=process\n IgnoreSIGPIPE=no\n SendSIGHUP=yes\n \n-# Unset locale for the console getty since the console has problems\n-# displaying some internationalized messages.\n-Environment=LANG= LANGUAGE= LC_CTYPE= LC_NUMERIC= LC_TIME= LC_COLLATE= LC_MONETARY= LC_MESSAGES= LC_PAPER= LC_NAME= LC_ADDRESS= LC_TELEPHONE= LC_MEASUREMENT= LC_IDENTIFICATION=","path":"units/getty@.service.m4","position":15,"original_position":6,"commit_id":"7df6838a8f9cd441d09be6cf0df5fcbd8b877e75","original_commit_id":"b8cbd4367147eda44ecf28b0ab879e86583ffa88","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars2.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"Right. We go to some effort to set the font and utf8 mode on the console, so the removed comment most likely hasn't been true for a long time.","created_at":"2017-05-26T02:49:28Z","updated_at":"2017-05-26T02:55:29Z","html_url":"https://github.com/systemd/systemd/pull/6023#discussion_r118625430","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/6023","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/118625430"},"html":{"href":"https://github.com/systemd/systemd/pull/6023#discussion_r118625430"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6023"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/6023","id":122212988,"html_url":"https://github.com/systemd/systemd/pull/6023","diff_url":"https://github.com/systemd/systemd/pull/6023.diff","patch_url":"https://github.com/systemd/systemd/pull/6023.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/6023","number":6023,"state":"open","locked":false,"title":"units: Pass environment to login shells","user":{"login":"spbnick","id":549246,"avatar_url":"https://avatars0.githubusercontent.com/u/549246?v=3","gravatar_id":"","url":"https://api.github.com/users/spbnick","html_url":"https://github.com/spbnick","followers_url":"https://api.github.com/users/spbnick/followers","following_url":"https://api.github.com/users/spbnick/following{/other_user}","gists_url":"https://api.github.com/users/spbnick/gists{/gist_id}","starred_url":"https://api.github.com/users/spbnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spbnick/subscriptions","organizations_url":"https://api.github.com/users/spbnick/orgs","repos_url":"https://api.github.com/users/spbnick/repos","events_url":"https://api.github.com/users/spbnick/events{/privacy}","received_events_url":"https://api.github.com/users/spbnick/received_events","type":"User","site_admin":false},"body":"These two commits enable passing environment from systemd to shells for all \\*getty\\* services.\r\n\r\nThis is needed to let the locale environment variables through to programs which are specified as user shells, and can't get it from anywhere else.\r\n\r\nSee also: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/37B7RLKU5JYKUK46ANTUADNRGELW6U7O/","created_at":"2017-05-24T12:11:05Z","updated_at":"2017-05-26T02:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a766ec112a8fcfe4a8ba41aa60efb097df1c139","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/6023/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/6023/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/6023/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/7df6838a8f9cd441d09be6cf0df5fcbd8b877e75","head":{"label":"spbnick:pass_env_to_login","ref":"pass_env_to_login","sha":"7df6838a8f9cd441d09be6cf0df5fcbd8b877e75","user":{"login":"spbnick","id":549246,"avatar_url":"https://avatars0.githubusercontent.com/u/549246?v=3","gravatar_id":"","url":"https://api.github.com/users/spbnick","html_url":"https://github.com/spbnick","followers_url":"https://api.github.com/users/spbnick/followers","following_url":"https://api.github.com/users/spbnick/following{/other_user}","gists_url":"https://api.github.com/users/spbnick/gists{/gist_id}","starred_url":"https://api.github.com/users/spbnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spbnick/subscriptions","organizations_url":"https://api.github.com/users/spbnick/orgs","repos_url":"https://api.github.com/users/spbnick/repos","events_url":"https://api.github.com/users/spbnick/events{/privacy}","received_events_url":"https://api.github.com/users/spbnick/received_events","type":"User","site_admin":false},"repo":{"id":92287577,"name":"systemd","full_name":"spbnick/systemd","owner":{"login":"spbnick","id":549246,"avatar_url":"https://avatars0.githubusercontent.com/u/549246?v=3","gravatar_id":"","url":"https://api.github.com/users/spbnick","html_url":"https://github.com/spbnick","followers_url":"https://api.github.com/users/spbnick/followers","following_url":"https://api.github.com/users/spbnick/following{/other_user}","gists_url":"https://api.github.com/users/spbnick/gists{/gist_id}","starred_url":"https://api.github.com/users/spbnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spbnick/subscriptions","organizations_url":"https://api.github.com/users/spbnick/orgs","repos_url":"https://api.github.com/users/spbnick/repos","events_url":"https://api.github.com/users/spbnick/events{/privacy}","received_events_url":"https://api.github.com/users/spbnick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spbnick/systemd","description":"systemd System and Service Manager","fork":true,"url":"https://api.github.com/repos/spbnick/systemd","forks_url":"https://api.github.com/repos/spbnick/systemd/forks","keys_url":"https://api.github.com/repos/spbnick/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spbnick/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spbnick/systemd/teams","hooks_url":"https://api.github.com/repos/spbnick/systemd/hooks","issue_events_url":"https://api.github.com/repos/spbnick/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/spbnick/systemd/events","assignees_url":"https://api.github.com/repos/spbnick/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/spbnick/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/spbnick/systemd/tags","blobs_url":"https://api.github.com/repos/spbnick/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spbnick/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spbnick/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spbnick/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spbnick/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/spbnick/systemd/languages","stargazers_url":"https://api.github.com/repos/spbnick/systemd/stargazers","contributors_url":"https://api.github.com/repos/spbnick/systemd/contributors","subscribers_url":"https://api.github.com/repos/spbnick/systemd/subscribers","subscription_url":"https://api.github.com/repos/spbnick/systemd/subscription","commits_url":"https://api.github.com/repos/spbnick/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spbnick/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spbnick/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spbnick/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/spbnick/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/spbnick/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spbnick/systemd/merges","archive_url":"https://api.github.com/repos/spbnick/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spbnick/systemd/downloads","issues_url":"https://api.github.com/repos/spbnick/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/spbnick/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/spbnick/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/spbnick/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spbnick/systemd/labels{/name}","releases_url":"https://api.github.com/repos/spbnick/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/spbnick/systemd/deployments","created_at":"2017-05-24T12:02:04Z","updated_at":"2017-05-24T12:02:13Z","pushed_at":"2017-05-24T12:03:39Z","git_url":"git://github.com/spbnick/systemd.git","ssh_url":"git@github.com:spbnick/systemd.git","clone_url":"https://github.com/spbnick/systemd.git","svn_url":"https://github.com/spbnick/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":70541,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"b23aec0d6b98bc99998786506a8769e1a1ea1841","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars3.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars3.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd System and Service Manager","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2017-05-25T13:49:29Z","pushed_at":"2017-05-26T02:13:51Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":70857,"stargazers_count":1888,"watchers_count":1888,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":807,"mirror_url":null,"open_issues_count":668,"forks":807,"open_issues":668,"watchers":1888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6023"},"html":{"href":"https://github.com/systemd/systemd/pull/6023"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/6023"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/6023/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6023/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/6023/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/7df6838a8f9cd441d09be6cf0df5fcbd8b877e75"}}}}
{"actor":{"display_login":"keszybz"}}