{"action":"closed","number":5313,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5313","id":117204532,"html_url":"https://github.com/dolphin-emu/dolphin/pull/5313","diff_url":"https://github.com/dolphin-emu/dolphin/pull/5313.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/5313.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5313","number":5313,"state":"closed","locked":false,"title":"Add CubebStream output backend and replace PortAudio for microphones","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars1.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"body":"Extracted from #5256: Replace all audio backends with Cubeb.\r\n\r\n> Cubeb is the cross-platform real-time audio backend [developed for and used by Firefox](https://blog.mozilla.org/webrtc/firefoxs-audio-backend/). It gets exposure across the entire Firefox user base, works on every major platform, supports both input and output, and is available as [an independent library](https://github.com/kinetiknz/cubeb).\r\n>\r\n> **Pros:**\r\n> - Volume control and DPL2 decoder supported on all platforms.\r\n> - No more bundling/linking to PortAudio.\r\n> - Defaults to using WASAPI on Windows, which is callback-based, lower-level than XAudio2 (no audio effects graph), and available since Vista.\r\n> - Loads PulseAudio (and JACK, if you're into that) at runtime on Linux. If the shared library isn't found, it seamlessly falls back to ALSA.\r\n> - Also supports JACK and OpenBSD's sndio.\r\n> - Larger pool of people working on improvements and bug fixes for Cubeb, instead of relatively siloed Dolphin audio development.\r\n> - Net removal of ~60,000 LOC from the repository. Faster IntelliSense, shallow clones, and what-have-you.\r\n>\r\n> **Cons:**\r\n> - No guarantee of a stable API/ABI, since Cubeb is built in-tree by Firefox and they can change it whenever they want.\r\n> - Cubeb internal code is more complex than Dolphin's current audio code, due to additional features they support (multichannel on every backend, full-duplex streams, software resampling on WASAPI, etc.).\r\n> - The ALSA backend is not a Mozilla priority (they stopped shipping it in Firefox), so may not receive updates or as many fixes.\r\n\r\nThe main idea of this PR is to get rid of PortAudio (yuck) and get a cubeb backend running (WASAPI support, PulseAudio input on Unix (if you don't like PulseAudio, bluetooth microphones?), more testing, etc).","created_at":"2017-04-24T07:38:04Z","updated_at":"2017-05-28T01:39:03Z","closed_at":"2017-05-28T01:39:03Z","merged_at":"2017-05-28T01:39:03Z","merge_commit_sha":"905232fd2b0f0545e524c4c34859bf62576e43f5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5313/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5313/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5313/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/d416cbd9ed5efb391ad65c36ded74c17ab713622","head":{"label":"ligfx:addcubeb","ref":"addcubeb","sha":"d416cbd9ed5efb391ad65c36ded74c17ab713622","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars1.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"repo":{"id":65220721,"name":"dolphin","full_name":"ligfx/dolphin","owner":{"login":"ligfx","id":594093,"avatar_url":"https://avatars1.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ligfx/dolphin","description":"Personal development branch of dolphin-emu/dolphin.","fork":true,"url":"https://api.github.com/repos/ligfx/dolphin","forks_url":"https://api.github.com/repos/ligfx/dolphin/forks","keys_url":"https://api.github.com/repos/ligfx/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligfx/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligfx/dolphin/teams","hooks_url":"https://api.github.com/repos/ligfx/dolphin/hooks","issue_events_url":"https://api.github.com/repos/ligfx/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/ligfx/dolphin/events","assignees_url":"https://api.github.com/repos/ligfx/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/ligfx/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/ligfx/dolphin/tags","blobs_url":"https://api.github.com/repos/ligfx/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligfx/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligfx/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligfx/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligfx/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/ligfx/dolphin/languages","stargazers_url":"https://api.github.com/repos/ligfx/dolphin/stargazers","contributors_url":"https://api.github.com/repos/ligfx/dolphin/contributors","subscribers_url":"https://api.github.com/repos/ligfx/dolphin/subscribers","subscription_url":"https://api.github.com/repos/ligfx/dolphin/subscription","commits_url":"https://api.github.com/repos/ligfx/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligfx/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligfx/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligfx/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligfx/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/ligfx/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligfx/dolphin/merges","archive_url":"https://api.github.com/repos/ligfx/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligfx/dolphin/downloads","issues_url":"https://api.github.com/repos/ligfx/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/ligfx/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/ligfx/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/ligfx/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligfx/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/ligfx/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/ligfx/dolphin/deployments","created_at":"2016-08-08T16:31:32Z","updated_at":"2017-05-17T22:06:54Z","pushed_at":"2017-05-28T01:29:03Z","git_url":"git://github.com/ligfx/dolphin.git","ssh_url":"git@github.com:ligfx/dolphin.git","clone_url":"https://github.com/ligfx/dolphin.git","svn_url":"https://github.com/ligfx/dolphin","homepage":"https://github.com/dolphin-emu/dolphin","size":301404,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ligfx"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"d4faa099d95edcc408d90fefb601999b1481d308","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-05-27T22:22:07Z","pushed_at":"2017-05-28T01:39:03Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":338440,"stargazers_count":3341,"watchers_count":3341,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":872,"mirror_url":null,"open_issues_count":147,"forks":872,"open_issues":147,"watchers":3341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5313"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5313"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5313"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5313/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5313/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5313/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/d416cbd9ed5efb391ad65c36ded74c17ab713622"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lioncash","id":712067,"avatar_url":"https://avatars2.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"comments":5,"review_comments":18,"maintainer_can_modify":false,"commits":6,"additions":22187,"deletions":82592,"changed_files":190}}
{"actor":{"display_login":"lioncash"}}