{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/131719961","pull_request_review_id":54726588,"id":131719961,"diff_hunk":"@@ -123,9 +123,10 @@ export class AmpImg extends BaseElement {\n     // only read \"Graphic\" when using only 'alt'.\n     if (this.element.getAttribute('role') == 'img') {\n       this.element.removeAttribute('role');\n-      user().error('AMP-IMG', 'Setting role=img on amp-img elements breaks ' +\n-        'screen readers please just set alt or ARIA attributes, they will ' +\n-        'be correctly propagated for the underlying <img> element.');\n+      user(this.element).error('AMP-IMG',","path":"builtins/amp-img.js","position":7,"original_position":7,"commit_id":"fa293b1a6f13ed4f4fbbbfa3119b94c51b7345bf","original_commit_id":"000f6baf77ddf5305bf5b1008c56cf36e1d832ce","user":{"login":"tiendt","id":11670843,"avatar_url":"https://avatars0.githubusercontent.com/u/11670843?v=4","gravatar_id":"","url":"https://api.github.com/users/tiendt","html_url":"https://github.com/tiendt","followers_url":"https://api.github.com/users/tiendt/followers","following_url":"https://api.github.com/users/tiendt/following{/other_user}","gists_url":"https://api.github.com/users/tiendt/gists{/gist_id}","starred_url":"https://api.github.com/users/tiendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiendt/subscriptions","organizations_url":"https://api.github.com/users/tiendt/orgs","repos_url":"https://api.github.com/users/tiendt/repos","events_url":"https://api.github.com/users/tiendt/events{/privacy}","received_events_url":"https://api.github.com/users/tiendt/received_events","type":"User","site_admin":false},"body":"@zhouyx I need that change to amp-img.js to do the test, but the whole migration to use(opt_element) would be in a separate PR. Is that ok? ","created_at":"2017-08-07T17:48:44Z","updated_at":"2017-08-07T17:48:44Z","html_url":"https://github.com/ampproject/amphtml/pull/10562#discussion_r131719961","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/10562","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/131719961"},"html":{"href":"https://github.com/ampproject/amphtml/pull/10562#discussion_r131719961"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10562"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/10562","id":131661855,"html_url":"https://github.com/ampproject/amphtml/pull/10562","diff_url":"https://github.com/ampproject/amphtml/pull/10562.diff","patch_url":"https://github.com/ampproject/amphtml/pull/10562.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/10562","number":10562,"state":"open","locked":false,"title":"Exclude errors generated from A4A iframe","user":{"login":"tiendt","id":11670843,"avatar_url":"https://avatars0.githubusercontent.com/u/11670843?v=4","gravatar_id":"","url":"https://api.github.com/users/tiendt","html_url":"https://github.com/tiendt","followers_url":"https://api.github.com/users/tiendt/followers","following_url":"https://api.github.com/users/tiendt/following{/other_user}","gists_url":"https://api.github.com/users/tiendt/gists{/gist_id}","starred_url":"https://api.github.com/users/tiendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiendt/subscriptions","organizations_url":"https://api.github.com/users/tiendt/orgs","repos_url":"https://api.github.com/users/tiendt/repos","events_url":"https://api.github.com/users/tiendt/events{/privacy}","received_events_url":"https://api.github.com/users/tiendt/received_events","type":"User","site_admin":false},"body":"User error Reporting:\r\nFilter out errors generated from A4A iframe embed","created_at":"2017-07-20T22:15:20Z","updated_at":"2017-08-07T17:48:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aab2c23ff347c331ed9aee994a39acc4c57f9f99","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/10562/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/10562/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/10562/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/fa293b1a6f13ed4f4fbbbfa3119b94c51b7345bf","head":{"label":"tiendt:exclude-a4a","ref":"exclude-a4a","sha":"fa293b1a6f13ed4f4fbbbfa3119b94c51b7345bf","user":{"login":"tiendt","id":11670843,"avatar_url":"https://avatars0.githubusercontent.com/u/11670843?v=4","gravatar_id":"","url":"https://api.github.com/users/tiendt","html_url":"https://github.com/tiendt","followers_url":"https://api.github.com/users/tiendt/followers","following_url":"https://api.github.com/users/tiendt/following{/other_user}","gists_url":"https://api.github.com/users/tiendt/gists{/gist_id}","starred_url":"https://api.github.com/users/tiendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiendt/subscriptions","organizations_url":"https://api.github.com/users/tiendt/orgs","repos_url":"https://api.github.com/users/tiendt/repos","events_url":"https://api.github.com/users/tiendt/events{/privacy}","received_events_url":"https://api.github.com/users/tiendt/received_events","type":"User","site_admin":false},"repo":{"id":93900256,"name":"amphtml","full_name":"tiendt/amphtml","owner":{"login":"tiendt","id":11670843,"avatar_url":"https://avatars0.githubusercontent.com/u/11670843?v=4","gravatar_id":"","url":"https://api.github.com/users/tiendt","html_url":"https://github.com/tiendt","followers_url":"https://api.github.com/users/tiendt/followers","following_url":"https://api.github.com/users/tiendt/following{/other_user}","gists_url":"https://api.github.com/users/tiendt/gists{/gist_id}","starred_url":"https://api.github.com/users/tiendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiendt/subscriptions","organizations_url":"https://api.github.com/users/tiendt/orgs","repos_url":"https://api.github.com/users/tiendt/repos","events_url":"https://api.github.com/users/tiendt/events{/privacy}","received_events_url":"https://api.github.com/users/tiendt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiendt/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/tiendt/amphtml","forks_url":"https://api.github.com/repos/tiendt/amphtml/forks","keys_url":"https://api.github.com/repos/tiendt/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiendt/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiendt/amphtml/teams","hooks_url":"https://api.github.com/repos/tiendt/amphtml/hooks","issue_events_url":"https://api.github.com/repos/tiendt/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/tiendt/amphtml/events","assignees_url":"https://api.github.com/repos/tiendt/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/tiendt/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/tiendt/amphtml/tags","blobs_url":"https://api.github.com/repos/tiendt/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiendt/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiendt/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiendt/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiendt/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/tiendt/amphtml/languages","stargazers_url":"https://api.github.com/repos/tiendt/amphtml/stargazers","contributors_url":"https://api.github.com/repos/tiendt/amphtml/contributors","subscribers_url":"https://api.github.com/repos/tiendt/amphtml/subscribers","subscription_url":"https://api.github.com/repos/tiendt/amphtml/subscription","commits_url":"https://api.github.com/repos/tiendt/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiendt/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiendt/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiendt/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiendt/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/tiendt/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiendt/amphtml/merges","archive_url":"https://api.github.com/repos/tiendt/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiendt/amphtml/downloads","issues_url":"https://api.github.com/repos/tiendt/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/tiendt/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/tiendt/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/tiendt/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiendt/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/tiendt/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/tiendt/amphtml/deployments","created_at":"2017-06-09T22:07:16Z","updated_at":"2017-06-09T22:07:24Z","pushed_at":"2017-08-07T17:43:39Z","git_url":"git://github.com/tiendt/amphtml.git","ssh_url":"git@github.com:tiendt/amphtml.git","clone_url":"https://github.com/tiendt/amphtml.git","svn_url":"https://github.com/tiendt/amphtml","homepage":"https://www.ampproject.org","size":241829,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"59a7afe462d00a74e74e36e0d8e9e50cdd636f57","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-08-07T14:03:57Z","pushed_at":"2017-08-07T17:47:53Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":241705,"stargazers_count":10354,"watchers_count":10354,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1867,"mirror_url":null,"open_issues_count":897,"forks":1867,"open_issues":897,"watchers":10354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10562"},"html":{"href":"https://github.com/ampproject/amphtml/pull/10562"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/10562"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/10562/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10562/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/10562/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/fa293b1a6f13ed4f4fbbbfa3119b94c51b7345bf"}}}}
{"actor":{"display_login":"tiendt"}}