{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/125188289","pull_request_review_id":47554997,"id":125188289,"diff_hunk":"@@ -0,0 +1,200 @@\n+let\n+  lib = import ./default.nix;\n+in rec {\n+\n+  # Extend a derivation with checks for brokenness, license, etc.\n+  # Throw a descriptive error when the check fails; return derivaitonArg otherwise.\n+  # Note: no dependencies are checked in this step.\n+  addMetaChecks = { config, platform, meta, derivationArg, mkDerivationArg }: let\n+    attrs = mkDerivationArg; # TODO: probably get rid of passing this one\n+\n+    # See discussion at https://github.com/NixOS/nixpkgs/pull/25304#issuecomment-298385426\n+    # for why this defaults to false, but I (@copumpkin) want to default it to true soon.","path":"lib/check-meta.nix","position":12,"original_position":12,"commit_id":"f4eacca44cba670e8cbf3940cdc2a8935b225e5a","original_commit_id":"f4eacca44cba670e8cbf3940cdc2a8935b225e5a","user":{"login":"vcunat","id":1785925,"avatar_url":"https://avatars1.githubusercontent.com/u/1785925?v=3","gravatar_id":"","url":"https://api.github.com/users/vcunat","html_url":"https://github.com/vcunat","followers_url":"https://api.github.com/users/vcunat/followers","following_url":"https://api.github.com/users/vcunat/following{/other_user}","gists_url":"https://api.github.com/users/vcunat/gists{/gist_id}","starred_url":"https://api.github.com/users/vcunat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcunat/subscriptions","organizations_url":"https://api.github.com/users/vcunat/orgs","repos_url":"https://api.github.com/users/vcunat/repos","events_url":"https://api.github.com/users/vcunat/events{/privacy}","received_events_url":"https://api.github.com/users/vcunat/received_events","type":"User","site_admin":false},"body":"We'd have to ask @copumpkin about that.","created_at":"2017-07-02T17:31:36Z","updated_at":"2017-07-02T17:31:37Z","html_url":"https://github.com/NixOS/nixpkgs/pull/27045#discussion_r125188289","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/125188289"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/27045#discussion_r125188289"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045","id":128519566,"html_url":"https://github.com/NixOS/nixpkgs/pull/27045","diff_url":"https://github.com/NixOS/nixpkgs/pull/27045.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/27045.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/27045","number":27045,"state":"open","locked":false,"title":"stdenv: refactor meta checks","user":{"login":"vcunat","id":1785925,"avatar_url":"https://avatars1.githubusercontent.com/u/1785925?v=3","gravatar_id":"","url":"https://api.github.com/users/vcunat","html_url":"https://github.com/vcunat","followers_url":"https://api.github.com/users/vcunat/followers","following_url":"https://api.github.com/users/vcunat/following{/other_user}","gists_url":"https://api.github.com/users/vcunat/gists{/gist_id}","starred_url":"https://api.github.com/users/vcunat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcunat/subscriptions","organizations_url":"https://api.github.com/users/vcunat/orgs","repos_url":"https://api.github.com/users/vcunat/repos","events_url":"https://api.github.com/users/vcunat/events{/privacy}","received_events_url":"https://api.github.com/users/vcunat/received_events","type":"User","site_admin":false},"body":"Just a first stage of #22277 ATM, doing almost nothing but separating the meta-checking code.\r\n\r\nI think I now understand why the previous PR and this one have a slight performance regression, and I'll look into fixing it, hopefully before we merge this.\r\n\r\n@Ericson2314: I assume you don't want to change the meta-checking code significantly for now and just want it out of the way.  Still, the performance fixes will need some small changes to stdenv's `default.nix`.","created_at":"2017-07-02T12:46:31Z","updated_at":"2017-07-02T17:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b150d8196b78bd780208af53f935229935e8d1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/27045/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f4eacca44cba670e8cbf3940cdc2a8935b225e5a","head":{"label":"vcunat:meta-refactor-2-rebased","ref":"meta-refactor-2-rebased","sha":"f4eacca44cba670e8cbf3940cdc2a8935b225e5a","user":{"login":"vcunat","id":1785925,"avatar_url":"https://avatars1.githubusercontent.com/u/1785925?v=3","gravatar_id":"","url":"https://api.github.com/users/vcunat","html_url":"https://github.com/vcunat","followers_url":"https://api.github.com/users/vcunat/followers","following_url":"https://api.github.com/users/vcunat/following{/other_user}","gists_url":"https://api.github.com/users/vcunat/gists{/gist_id}","starred_url":"https://api.github.com/users/vcunat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcunat/subscriptions","organizations_url":"https://api.github.com/users/vcunat/orgs","repos_url":"https://api.github.com/users/vcunat/repos","events_url":"https://api.github.com/users/vcunat/events{/privacy}","received_events_url":"https://api.github.com/users/vcunat/received_events","type":"User","site_admin":false},"repo":{"id":5157084,"name":"nixpkgs","full_name":"vcunat/nixpkgs","owner":{"login":"vcunat","id":1785925,"avatar_url":"https://avatars1.githubusercontent.com/u/1785925?v=3","gravatar_id":"","url":"https://api.github.com/users/vcunat","html_url":"https://github.com/vcunat","followers_url":"https://api.github.com/users/vcunat/followers","following_url":"https://api.github.com/users/vcunat/following{/other_user}","gists_url":"https://api.github.com/users/vcunat/gists{/gist_id}","starred_url":"https://api.github.com/users/vcunat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcunat/subscriptions","organizations_url":"https://api.github.com/users/vcunat/orgs","repos_url":"https://api.github.com/users/vcunat/repos","events_url":"https://api.github.com/users/vcunat/events{/privacy}","received_events_url":"https://api.github.com/users/vcunat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vcunat/nixpkgs","description":"Nix Packages collection; mostly unused mirror now.","fork":true,"url":"https://api.github.com/repos/vcunat/nixpkgs","forks_url":"https://api.github.com/repos/vcunat/nixpkgs/forks","keys_url":"https://api.github.com/repos/vcunat/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcunat/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcunat/nixpkgs/teams","hooks_url":"https://api.github.com/repos/vcunat/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/vcunat/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/vcunat/nixpkgs/events","assignees_url":"https://api.github.com/repos/vcunat/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/vcunat/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/vcunat/nixpkgs/tags","blobs_url":"https://api.github.com/repos/vcunat/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcunat/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcunat/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcunat/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcunat/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/vcunat/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/vcunat/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/vcunat/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/vcunat/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/vcunat/nixpkgs/subscription","commits_url":"https://api.github.com/repos/vcunat/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcunat/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcunat/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcunat/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcunat/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/vcunat/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcunat/nixpkgs/merges","archive_url":"https://api.github.com/repos/vcunat/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcunat/nixpkgs/downloads","issues_url":"https://api.github.com/repos/vcunat/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/vcunat/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/vcunat/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/vcunat/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcunat/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/vcunat/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/vcunat/nixpkgs/deployments","created_at":"2012-07-23T20:30:45Z","updated_at":"2017-01-03T12:52:17Z","pushed_at":"2017-07-02T12:37:22Z","git_url":"git://github.com/vcunat/nixpkgs.git","ssh_url":"git@github.com:vcunat/nixpkgs.git","clone_url":"https://github.com/vcunat/nixpkgs.git","svn_url":"https://github.com/vcunat/nixpkgs","homepage":"","size":536600,"stargazers_count":1,"watchers_count":1,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"b084b93faa725ccbf86634965e443d1e667a066f","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-07-02T14:43:53Z","pushed_at":"2017-07-02T17:29:23Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":504421,"stargazers_count":1758,"watchers_count":1758,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2114,"mirror_url":null,"open_issues_count":2123,"forks":2114,"open_issues":2123,"watchers":1758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/27045"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/27045"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/27045/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/27045/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f4eacca44cba670e8cbf3940cdc2a8935b225e5a"}}}}
{"actor":{"display_login":"vcunat"}}