{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/138949722","pull_request_review_id":62815488,"id":138949722,"diff_hunk":"@@ -31,6 +33,16 @@ proc getEnv(name: string): string {\n }\n \n \n+/* Retrieves the compilation flags from lock file */\n+proc getCompopts(lock: Toml) {\n+  if lock.pathExists('root.compopts') {\n+    var compopts = lock['root']['compopts'].s;","path":"tools/mason/MasonUtils.chpl","position":19,"original_position":19,"commit_id":"2745497694a50d52c7a9585714a6744073a991be","original_commit_id":"2745497694a50d52c7a9585714a6744073a991be","user":{"login":"benharsh","id":1883119,"avatar_url":"https://avatars0.githubusercontent.com/u/1883119?v=4","gravatar_id":"","url":"https://api.github.com/users/benharsh","html_url":"https://github.com/benharsh","followers_url":"https://api.github.com/users/benharsh/followers","following_url":"https://api.github.com/users/benharsh/following{/other_user}","gists_url":"https://api.github.com/users/benharsh/gists{/gist_id}","starred_url":"https://api.github.com/users/benharsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benharsh/subscriptions","organizations_url":"https://api.github.com/users/benharsh/orgs","repos_url":"https://api.github.com/users/benharsh/repos","events_url":"https://api.github.com/users/benharsh/events{/privacy}","received_events_url":"https://api.github.com/users/benharsh/received_events","type":"User","site_admin":false},"body":"I don't think you need the temporary 'compopts' here.","created_at":"2017-09-14T16:49:25Z","updated_at":"2017-09-14T16:49:25Z","html_url":"https://github.com/chapel-lang/chapel/pull/7313#discussion_r138949722","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/138949722"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/7313#discussion_r138949722"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313","id":141123377,"html_url":"https://github.com/chapel-lang/chapel/pull/7313","diff_url":"https://github.com/chapel-lang/chapel/pull/7313.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/7313.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/7313","number":7313,"state":"open","locked":false,"title":"Mason: Compile options in toml file","user":{"login":"Spartee","id":13009163,"avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"body":"This PR is a feature for mason that allows users to put their compopts right in the ``Mason.toml`` file as listed in issue #7106. When this feature is used, the format for the ``Mason.toml`` will be a follows:\r\n\r\n``` toml\r\n[brick]\r\nname = \"MyProject\"\r\nversion = \"0.1.0\"\r\ncompopts = \"-M /test/somePackage\"\r\n\r\n[dependencies]\r\n```\r\n\r\nThis is a step towards being able to support C dependencies. I do not believe this will conflict with the changes that @daviditen is proposing in #7310 but I am mentioning him in this just in case. \r\n\r\nThis change has passed testing on my linux64 machine. ","created_at":"2017-09-14T16:39:52Z","updated_at":"2017-09-14T16:49:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda15b111bbea3f955f6189c9b7d3535e18da553","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/7313/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/2745497694a50d52c7a9585714a6744073a991be","head":{"label":"Spartee:mason-compopts","ref":"mason-compopts","sha":"2745497694a50d52c7a9585714a6744073a991be","user":{"login":"Spartee","id":13009163,"avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"repo":{"id":93550185,"name":"chapel","full_name":"Spartee/chapel","owner":{"login":"Spartee","id":13009163,"avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Spartee/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/Spartee/chapel","forks_url":"https://api.github.com/repos/Spartee/chapel/forks","keys_url":"https://api.github.com/repos/Spartee/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spartee/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spartee/chapel/teams","hooks_url":"https://api.github.com/repos/Spartee/chapel/hooks","issue_events_url":"https://api.github.com/repos/Spartee/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/Spartee/chapel/events","assignees_url":"https://api.github.com/repos/Spartee/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/Spartee/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/Spartee/chapel/tags","blobs_url":"https://api.github.com/repos/Spartee/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spartee/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spartee/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spartee/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spartee/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/Spartee/chapel/languages","stargazers_url":"https://api.github.com/repos/Spartee/chapel/stargazers","contributors_url":"https://api.github.com/repos/Spartee/chapel/contributors","subscribers_url":"https://api.github.com/repos/Spartee/chapel/subscribers","subscription_url":"https://api.github.com/repos/Spartee/chapel/subscription","commits_url":"https://api.github.com/repos/Spartee/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spartee/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spartee/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spartee/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spartee/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/Spartee/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spartee/chapel/merges","archive_url":"https://api.github.com/repos/Spartee/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spartee/chapel/downloads","issues_url":"https://api.github.com/repos/Spartee/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/Spartee/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/Spartee/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/Spartee/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spartee/chapel/labels{/name}","releases_url":"https://api.github.com/repos/Spartee/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/Spartee/chapel/deployments","created_at":"2017-06-06T18:23:35Z","updated_at":"2017-06-06T18:23:59Z","pushed_at":"2017-09-14T15:53:01Z","git_url":"git://github.com/Spartee/chapel.git","ssh_url":"git@github.com:Spartee/chapel.git","clone_url":"https://github.com/Spartee/chapel.git","svn_url":"https://github.com/Spartee/chapel","homepage":"http://chapel.cray.com/","size":447685,"stargazers_count":0,"watchers_count":0,"language":"Chapel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"76ae17c9c11e94a57a19958302116bf06f2cd5cd","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2017-09-13T17:05:32Z","pushed_at":"2017-09-14T16:43:47Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":460614,"stargazers_count":505,"watchers_count":505,"language":"Chapel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":408,"forks":144,"open_issues":408,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/7313"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/7313"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/7313/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/7313/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/2745497694a50d52c7a9585714a6744073a991be"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benharsh"}}