{"action":"created","comment":{"url":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments/124551522","pull_request_review_id":46850511,"id":124551522,"diff_hunk":"@@ -0,0 +1,14 @@\n+unmount_backup_drive:\n+  mount.unmounted:\n+    - name: /backups\n+    - device: /dev/xvdb\n+\n+detach_backup_volume:\n+  cloud.action:\n+    - func: boto_ec2.detach_volume\n+    - kwargs:\n+        tags:\n+          Name: {{ backup_volume_name }}","path":"salt/backups/unmount_drive.sls","position":11,"original_position":11,"commit_id":"233d4adc9c1fbf8333450daff4fd33ad6d73582b","original_commit_id":"233d4adc9c1fbf8333450daff4fd33ad6d73582b","user":{"login":"blarghmatey","id":479088,"avatar_url":"https://avatars0.githubusercontent.com/u/479088?v=3","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false},"body":"This needs to be set somewhere. Right now it will throw an error for an undefined variable.","created_at":"2017-06-28T14:11:35Z","updated_at":"2017-06-28T14:12:14Z","html_url":"https://github.com/mitodl/salt-ops/pull/345#discussion_r124551522","pull_request_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments/124551522"},"html":{"href":"https://github.com/mitodl/salt-ops/pull/345#discussion_r124551522"},"pull_request":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/mitodl/salt-ops/pulls/345","id":127916960,"html_url":"https://github.com/mitodl/salt-ops/pull/345","diff_url":"https://github.com/mitodl/salt-ops/pull/345.diff","patch_url":"https://github.com/mitodl/salt-ops/pull/345.patch","issue_url":"https://api.github.com/repos/mitodl/salt-ops/issues/345","number":345,"state":"open","locked":false,"title":"Changes based on comments in Issue#260","user":{"login":"shaidar","id":1447295,"avatar_url":"https://avatars2.githubusercontent.com/u/1447295?v=3","gravatar_id":"","url":"https://api.github.com/users/shaidar","html_url":"https://github.com/shaidar","followers_url":"https://api.github.com/users/shaidar/followers","following_url":"https://api.github.com/users/shaidar/following{/other_user}","gists_url":"https://api.github.com/users/shaidar/gists{/gist_id}","starred_url":"https://api.github.com/users/shaidar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaidar/subscriptions","organizations_url":"https://api.github.com/users/shaidar/orgs","repos_url":"https://api.github.com/users/shaidar/repos","events_url":"https://api.github.com/users/shaidar/events{/privacy}","received_events_url":"https://api.github.com/users/shaidar/received_events","type":"User","site_admin":false},"body":"[Issue#230](https://github.com/mitodl/salt-ops/issues/260#issuecomment-311486746) comments addressed and two files files have been created to prepare backup volume and then once backup scripts have completed, unmount and detach volume.","created_at":"2017-06-28T13:01:47Z","updated_at":"2017-06-28T14:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6ea486832b139ee4892440d18c5828f42de7b38","assignee":{"login":"blarghmatey","id":479088,"avatar_url":"https://avatars0.githubusercontent.com/u/479088?v=3","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false},"assignees":[{"login":"blarghmatey","id":479088,"avatar_url":"https://avatars0.githubusercontent.com/u/479088?v=3","gravatar_id":"","url":"https://api.github.com/users/blarghmatey","html_url":"https://github.com/blarghmatey","followers_url":"https://api.github.com/users/blarghmatey/followers","following_url":"https://api.github.com/users/blarghmatey/following{/other_user}","gists_url":"https://api.github.com/users/blarghmatey/gists{/gist_id}","starred_url":"https://api.github.com/users/blarghmatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blarghmatey/subscriptions","organizations_url":"https://api.github.com/users/blarghmatey/orgs","repos_url":"https://api.github.com/users/blarghmatey/repos","events_url":"https://api.github.com/users/blarghmatey/events{/privacy}","received_events_url":"https://api.github.com/users/blarghmatey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/345/commits","review_comments_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/345/comments","review_comment_url":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitodl/salt-ops/issues/345/comments","statuses_url":"https://api.github.com/repos/mitodl/salt-ops/statuses/233d4adc9c1fbf8333450daff4fd33ad6d73582b","head":{"label":"mitodl:sar/bu_mitx","ref":"sar/bu_mitx","sha":"233d4adc9c1fbf8333450daff4fd33ad6d73582b","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars1.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":52479140,"name":"salt-ops","full_name":"mitodl/salt-ops","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars1.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/salt-ops","description":"Repository for building, managing and deploying salt-based infrastructure","fork":false,"url":"https://api.github.com/repos/mitodl/salt-ops","forks_url":"https://api.github.com/repos/mitodl/salt-ops/forks","keys_url":"https://api.github.com/repos/mitodl/salt-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/salt-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/salt-ops/teams","hooks_url":"https://api.github.com/repos/mitodl/salt-ops/hooks","issue_events_url":"https://api.github.com/repos/mitodl/salt-ops/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/salt-ops/events","assignees_url":"https://api.github.com/repos/mitodl/salt-ops/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/salt-ops/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/salt-ops/tags","blobs_url":"https://api.github.com/repos/mitodl/salt-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/salt-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/salt-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/salt-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/salt-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/salt-ops/languages","stargazers_url":"https://api.github.com/repos/mitodl/salt-ops/stargazers","contributors_url":"https://api.github.com/repos/mitodl/salt-ops/contributors","subscribers_url":"https://api.github.com/repos/mitodl/salt-ops/subscribers","subscription_url":"https://api.github.com/repos/mitodl/salt-ops/subscription","commits_url":"https://api.github.com/repos/mitodl/salt-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/salt-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/salt-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/salt-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/salt-ops/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/salt-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/salt-ops/merges","archive_url":"https://api.github.com/repos/mitodl/salt-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/salt-ops/downloads","issues_url":"https://api.github.com/repos/mitodl/salt-ops/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/salt-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/salt-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/salt-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/salt-ops/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/salt-ops/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/salt-ops/deployments","created_at":"2016-02-24T22:30:34Z","updated_at":"2017-05-04T07:49:12Z","pushed_at":"2017-06-28T13:01:47Z","git_url":"git://github.com/mitodl/salt-ops.git","ssh_url":"git@github.com:mitodl/salt-ops.git","clone_url":"https://github.com/mitodl/salt-ops.git","svn_url":"https://github.com/mitodl/salt-ops","homepage":null,"size":536,"stargazers_count":6,"watchers_count":6,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":71,"forks":2,"open_issues":71,"watchers":6,"default_branch":"master"}},"base":{"label":"mitodl:master","ref":"master","sha":"055c9241ce259991e1752e26636082604dcf7ccb","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars1.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":52479140,"name":"salt-ops","full_name":"mitodl/salt-ops","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars1.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/salt-ops","description":"Repository for building, managing and deploying salt-based infrastructure","fork":false,"url":"https://api.github.com/repos/mitodl/salt-ops","forks_url":"https://api.github.com/repos/mitodl/salt-ops/forks","keys_url":"https://api.github.com/repos/mitodl/salt-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/salt-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/salt-ops/teams","hooks_url":"https://api.github.com/repos/mitodl/salt-ops/hooks","issue_events_url":"https://api.github.com/repos/mitodl/salt-ops/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/salt-ops/events","assignees_url":"https://api.github.com/repos/mitodl/salt-ops/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/salt-ops/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/salt-ops/tags","blobs_url":"https://api.github.com/repos/mitodl/salt-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/salt-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/salt-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/salt-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/salt-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/salt-ops/languages","stargazers_url":"https://api.github.com/repos/mitodl/salt-ops/stargazers","contributors_url":"https://api.github.com/repos/mitodl/salt-ops/contributors","subscribers_url":"https://api.github.com/repos/mitodl/salt-ops/subscribers","subscription_url":"https://api.github.com/repos/mitodl/salt-ops/subscription","commits_url":"https://api.github.com/repos/mitodl/salt-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/salt-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/salt-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/salt-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/salt-ops/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/salt-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/salt-ops/merges","archive_url":"https://api.github.com/repos/mitodl/salt-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/salt-ops/downloads","issues_url":"https://api.github.com/repos/mitodl/salt-ops/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/salt-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/salt-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/salt-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/salt-ops/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/salt-ops/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/salt-ops/deployments","created_at":"2016-02-24T22:30:34Z","updated_at":"2017-05-04T07:49:12Z","pushed_at":"2017-06-28T13:01:47Z","git_url":"git://github.com/mitodl/salt-ops.git","ssh_url":"git@github.com:mitodl/salt-ops.git","clone_url":"https://github.com/mitodl/salt-ops.git","svn_url":"https://github.com/mitodl/salt-ops","homepage":null,"size":536,"stargazers_count":6,"watchers_count":6,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":71,"forks":2,"open_issues":71,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/345"},"html":{"href":"https://github.com/mitodl/salt-ops/pull/345"},"issue":{"href":"https://api.github.com/repos/mitodl/salt-ops/issues/345"},"comments":{"href":"https://api.github.com/repos/mitodl/salt-ops/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitodl/salt-ops/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/mitodl/salt-ops/statuses/233d4adc9c1fbf8333450daff4fd33ad6d73582b"}}}}
{"actor":{"display_login":"blarghmatey"}}