{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/1","id":160542930,"html_url":"https://github.com/Wesley-souza/PMSConnector-v2.7/pull/1","diff_url":"https://github.com/Wesley-souza/PMSConnector-v2.7/pull/1.diff","patch_url":"https://github.com/Wesley-souza/PMSConnector-v2.7/pull/1.patch","issue_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/issues/1","number":1,"state":"open","locked":false,"title":"fix mysql port, salt crypt and logout option","user":{"login":"thiagobruno","id":6922953,"avatar_url":"https://avatars1.githubusercontent.com/u/6922953?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagobruno","html_url":"https://github.com/thiagobruno","followers_url":"https://api.github.com/users/thiagobruno/followers","following_url":"https://api.github.com/users/thiagobruno/following{/other_user}","gists_url":"https://api.github.com/users/thiagobruno/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagobruno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagobruno/subscriptions","organizations_url":"https://api.github.com/users/thiagobruno/orgs","repos_url":"https://api.github.com/users/thiagobruno/repos","events_url":"https://api.github.com/users/thiagobruno/events{/privacy}","received_events_url":"https://api.github.com/users/thiagobruno/received_events","type":"User","site_admin":false},"body":"Olá Jonas, \r\nPrimeiramente meus parabéns pela iniciativa do projeto, achei que ficou bem legal e bem limpo, e principalmente muito útil!\r\n\r\nEstou subindo algumas sugestões pelo que ocorreu comigo na hora de configurar o server e talvez aconteça com outros usuários.\r\n\r\n1 - Ao tentar criar o arquivo, como no meu server não tinha a pasta ```res\\server-config``` coloquei um script para criar o diretório caso não exista.\r\n\r\n2 - Coloquei uma opção de gerar um ```salt``` randômico para crypt(), embora seja opcional esse parâmetro, não é muito recomendado utilizar crypt() sem ```salt``` então, é quase o mesmo que não usar nada.\r\n\r\n3 - Coloquei um parâmetro a mais para a conexão com o mysql, ```PORT``` conectando na padrão ok, mas muitos como eu podem estar usando o mysql em portas diferentes.\r\n\r\n4 - Coloquei um logout na main.php\r\n\r\n----\r\n##### Como sugestão para uma próxima versão, até por já estar sendo feito em PHP, seria interessante utilizar um framework como o Laravel, ou até mesmo o Lumen que é uma versão light, tem uma estrutura muito boa e limpa para API REST, com tokenização, eloquent entre outros recursos, etc.\r\nDepois da uma olhadinha: https://lumen.laravel.com/\r\n\r\n##### O bom de utilizar um framework desse, é que tem uma excelente comunidade e documentação, e não se preocupar com a parte básica da API, como segurança, rotas, etc, etc, etc, da pra focar somente nas funcionalidades.","created_at":"2017-12-29T17:43:58Z","updated_at":"2017-12-29T17:43:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/issues/1/comments","statuses_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/statuses/ab6302765d2b702dea414aa53b2bc792b2e00453","head":{"label":"geracaoweb:thiagobruno","ref":"thiagobruno","sha":"ab6302765d2b702dea414aa53b2bc792b2e00453","user":{"login":"geracaoweb","id":8669279,"avatar_url":"https://avatars0.githubusercontent.com/u/8669279?v=4","gravatar_id":"","url":"https://api.github.com/users/geracaoweb","html_url":"https://github.com/geracaoweb","followers_url":"https://api.github.com/users/geracaoweb/followers","following_url":"https://api.github.com/users/geracaoweb/following{/other_user}","gists_url":"https://api.github.com/users/geracaoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/geracaoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geracaoweb/subscriptions","organizations_url":"https://api.github.com/users/geracaoweb/orgs","repos_url":"https://api.github.com/users/geracaoweb/repos","events_url":"https://api.github.com/users/geracaoweb/events{/privacy}","received_events_url":"https://api.github.com/users/geracaoweb/received_events","type":"Organization","site_admin":false},"repo":{"id":115732255,"name":"PMSConnector-v2.7","full_name":"geracaoweb/PMSConnector-v2.7","owner":{"login":"geracaoweb","id":8669279,"avatar_url":"https://avatars0.githubusercontent.com/u/8669279?v=4","gravatar_id":"","url":"https://api.github.com/users/geracaoweb","html_url":"https://github.com/geracaoweb","followers_url":"https://api.github.com/users/geracaoweb/followers","following_url":"https://api.github.com/users/geracaoweb/following{/other_user}","gists_url":"https://api.github.com/users/geracaoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/geracaoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geracaoweb/subscriptions","organizations_url":"https://api.github.com/users/geracaoweb/orgs","repos_url":"https://api.github.com/users/geracaoweb/repos","events_url":"https://api.github.com/users/geracaoweb/events{/privacy}","received_events_url":"https://api.github.com/users/geracaoweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geracaoweb/PMSConnector-v2.7","description":"Godot server connections.","fork":true,"url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7","forks_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/forks","keys_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/teams","hooks_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/hooks","issue_events_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/issues/events{/number}","events_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/events","assignees_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/assignees{/user}","branches_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/branches{/branch}","tags_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/tags","blobs_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/git/refs{/sha}","trees_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/statuses/{sha}","languages_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/languages","stargazers_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/stargazers","contributors_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/contributors","subscribers_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/subscribers","subscription_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/subscription","commits_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/commits{/sha}","git_commits_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/git/commits{/sha}","comments_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/comments{/number}","issue_comment_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/issues/comments{/number}","contents_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/contents/{+path}","compare_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/merges","archive_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/downloads","issues_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/issues{/number}","pulls_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/pulls{/number}","milestones_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/milestones{/number}","notifications_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/labels{/name}","releases_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/releases{/id}","deployments_url":"https://api.github.com/repos/geracaoweb/PMSConnector-v2.7/deployments","created_at":"2017-12-29T15:16:35Z","updated_at":"2017-12-29T15:16:37Z","pushed_at":"2017-12-29T17:25:57Z","git_url":"git://github.com/geracaoweb/PMSConnector-v2.7.git","ssh_url":"git@github.com:geracaoweb/PMSConnector-v2.7.git","clone_url":"https://github.com/geracaoweb/PMSConnector-v2.7.git","svn_url":"https://github.com/geracaoweb/PMSConnector-v2.7","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Wesley-souza:master","ref":"master","sha":"43e165725553f223ea5948881f63534f0e72bdf7","user":{"login":"Wesley-souza","id":28987288,"avatar_url":"https://avatars0.githubusercontent.com/u/28987288?v=4","gravatar_id":"","url":"https://api.github.com/users/Wesley-souza","html_url":"https://github.com/Wesley-souza","followers_url":"https://api.github.com/users/Wesley-souza/followers","following_url":"https://api.github.com/users/Wesley-souza/following{/other_user}","gists_url":"https://api.github.com/users/Wesley-souza/gists{/gist_id}","starred_url":"https://api.github.com/users/Wesley-souza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wesley-souza/subscriptions","organizations_url":"https://api.github.com/users/Wesley-souza/orgs","repos_url":"https://api.github.com/users/Wesley-souza/repos","events_url":"https://api.github.com/users/Wesley-souza/events{/privacy}","received_events_url":"https://api.github.com/users/Wesley-souza/received_events","type":"User","site_admin":false},"repo":{"id":115731288,"name":"PMSConnector-v2.7","full_name":"Wesley-souza/PMSConnector-v2.7","owner":{"login":"Wesley-souza","id":28987288,"avatar_url":"https://avatars0.githubusercontent.com/u/28987288?v=4","gravatar_id":"","url":"https://api.github.com/users/Wesley-souza","html_url":"https://github.com/Wesley-souza","followers_url":"https://api.github.com/users/Wesley-souza/followers","following_url":"https://api.github.com/users/Wesley-souza/following{/other_user}","gists_url":"https://api.github.com/users/Wesley-souza/gists{/gist_id}","starred_url":"https://api.github.com/users/Wesley-souza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wesley-souza/subscriptions","organizations_url":"https://api.github.com/users/Wesley-souza/orgs","repos_url":"https://api.github.com/users/Wesley-souza/repos","events_url":"https://api.github.com/users/Wesley-souza/events{/privacy}","received_events_url":"https://api.github.com/users/Wesley-souza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wesley-souza/PMSConnector-v2.7","description":"Godot server connections.","fork":false,"url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7","forks_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/forks","keys_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/teams","hooks_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/hooks","issue_events_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/issues/events{/number}","events_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/events","assignees_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/assignees{/user}","branches_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/branches{/branch}","tags_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/tags","blobs_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/statuses/{sha}","languages_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/languages","stargazers_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/stargazers","contributors_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/contributors","subscribers_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/subscribers","subscription_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/subscription","commits_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/contents/{+path}","compare_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/merges","archive_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/downloads","issues_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/issues{/number}","pulls_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls{/number}","milestones_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/milestones{/number}","notifications_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/labels{/name}","releases_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/releases{/id}","deployments_url":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/deployments","created_at":"2017-12-29T15:03:24Z","updated_at":"2017-12-29T15:18:56Z","pushed_at":"2017-12-29T17:41:32Z","git_url":"git://github.com/Wesley-souza/PMSConnector-v2.7.git","ssh_url":"git@github.com:Wesley-souza/PMSConnector-v2.7.git","clone_url":"https://github.com/Wesley-souza/PMSConnector-v2.7.git","svn_url":"https://github.com/Wesley-souza/PMSConnector-v2.7","homepage":null,"size":55,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/1"},"html":{"href":"https://github.com/Wesley-souza/PMSConnector-v2.7/pull/1"},"issue":{"href":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/issues/1"},"comments":{"href":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Wesley-souza/PMSConnector-v2.7/statuses/ab6302765d2b702dea414aa53b2bc792b2e00453"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":41,"deletions":8,"changed_files":6}}
{"actor":{"display_login":"thiagobruno"}}