{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments/97899933","pull_request_review_id":18525300,"id":97899933,"diff_hunk":"@@ -261,6 +266,14 @@ private bool TryGetPositionInfo(IList list, string segment, out PositionInfo pos\n                     errorMessage = null;\n                     return true;\n                 }\n+                // As per JSON Patch spec, for Add operation the index value representing the number of elements is valid,\n+                // where as for other operations like Remove, Replace, Move and Copy the target index MUST exist.\n+                else if (position == list.Count && operationType == OperationType.Add)\n+                {\n+                    positionInfo = new PositionInfo(PositionType.EndOfList, -1);","path":"src/Microsoft.AspNetCore.JsonPatch/Internal/ListAdapter.cs","position":58,"original_position":58,"commit_id":"2d0c79d6f13ca4f477e66bd5de7add1370c58fe9","original_commit_id":"2d0c79d6f13ca4f477e66bd5de7add1370c58fe9","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"Will this muck anything else up? Since we've now *lost* the fact that the index was provided, and the index was the end of the list, not `-1`","created_at":"2017-01-25T22:59:28Z","updated_at":"2017-01-25T23:00:35Z","html_url":"https://github.com/aspnet/JsonPatch/pull/55#discussion_r97899933","pull_request_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments/97899933"},"html":{"href":"https://github.com/aspnet/JsonPatch/pull/55#discussion_r97899933"},"pull_request":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55","id":102981315,"html_url":"https://github.com/aspnet/JsonPatch/pull/55","diff_url":"https://github.com/aspnet/JsonPatch/pull/55.diff","patch_url":"https://github.com/aspnet/JsonPatch/pull/55.patch","issue_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/55","number":55,"state":"open","locked":false,"title":"[Fixes #48] Regression: List add must support adding items where index is same as count of elements","user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"body":"…x is same as count of elements\r\n\r\nNOTE: this fix is for 1.1.1 branch","created_at":"2017-01-24T18:57:55Z","updated_at":"2017-01-25T23:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bc624e9541a2df430e177445bcf88e01918ce3f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55/commits","review_comments_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55/comments","review_comment_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/55/comments","statuses_url":"https://api.github.com/repos/aspnet/JsonPatch/statuses/2d0c79d6f13ca4f477e66bd5de7add1370c58fe9","head":{"label":"aspnet:kichalla/list-number-of-elements","ref":"kichalla/list-number-of-elements","sha":"2d0c79d6f13ca4f477e66bd5de7add1370c58fe9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42667889,"name":"JsonPatch","full_name":"aspnet/JsonPatch","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/JsonPatch","description":"JSON PATCH library","fork":false,"url":"https://api.github.com/repos/aspnet/JsonPatch","forks_url":"https://api.github.com/repos/aspnet/JsonPatch/forks","keys_url":"https://api.github.com/repos/aspnet/JsonPatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/JsonPatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/JsonPatch/teams","hooks_url":"https://api.github.com/repos/aspnet/JsonPatch/hooks","issue_events_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/JsonPatch/events","assignees_url":"https://api.github.com/repos/aspnet/JsonPatch/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/JsonPatch/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/JsonPatch/tags","blobs_url":"https://api.github.com/repos/aspnet/JsonPatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/JsonPatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/JsonPatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/JsonPatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/JsonPatch/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/JsonPatch/languages","stargazers_url":"https://api.github.com/repos/aspnet/JsonPatch/stargazers","contributors_url":"https://api.github.com/repos/aspnet/JsonPatch/contributors","subscribers_url":"https://api.github.com/repos/aspnet/JsonPatch/subscribers","subscription_url":"https://api.github.com/repos/aspnet/JsonPatch/subscription","commits_url":"https://api.github.com/repos/aspnet/JsonPatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/JsonPatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/JsonPatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/JsonPatch/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/JsonPatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/JsonPatch/merges","archive_url":"https://api.github.com/repos/aspnet/JsonPatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/JsonPatch/downloads","issues_url":"https://api.github.com/repos/aspnet/JsonPatch/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/JsonPatch/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/JsonPatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/JsonPatch/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/JsonPatch/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/JsonPatch/deployments","created_at":"2015-09-17T16:32:18Z","updated_at":"2017-01-17T10:18:14Z","pushed_at":"2017-01-25T22:44:10Z","git_url":"git://github.com/aspnet/JsonPatch.git","ssh_url":"git@github.com:aspnet/JsonPatch.git","clone_url":"https://github.com/aspnet/JsonPatch.git","svn_url":"https://github.com/aspnet/JsonPatch","homepage":null,"size":236,"stargazers_count":33,"watchers_count":33,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":13,"forks":12,"open_issues":13,"watchers":33,"default_branch":"dev"}},"base":{"label":"aspnet:rel/1.1.1","ref":"rel/1.1.1","sha":"4faf89030c47e5ee5c7193a26d810a50862a3cf4","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42667889,"name":"JsonPatch","full_name":"aspnet/JsonPatch","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/JsonPatch","description":"JSON PATCH library","fork":false,"url":"https://api.github.com/repos/aspnet/JsonPatch","forks_url":"https://api.github.com/repos/aspnet/JsonPatch/forks","keys_url":"https://api.github.com/repos/aspnet/JsonPatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/JsonPatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/JsonPatch/teams","hooks_url":"https://api.github.com/repos/aspnet/JsonPatch/hooks","issue_events_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/JsonPatch/events","assignees_url":"https://api.github.com/repos/aspnet/JsonPatch/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/JsonPatch/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/JsonPatch/tags","blobs_url":"https://api.github.com/repos/aspnet/JsonPatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/JsonPatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/JsonPatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/JsonPatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/JsonPatch/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/JsonPatch/languages","stargazers_url":"https://api.github.com/repos/aspnet/JsonPatch/stargazers","contributors_url":"https://api.github.com/repos/aspnet/JsonPatch/contributors","subscribers_url":"https://api.github.com/repos/aspnet/JsonPatch/subscribers","subscription_url":"https://api.github.com/repos/aspnet/JsonPatch/subscription","commits_url":"https://api.github.com/repos/aspnet/JsonPatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/JsonPatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/JsonPatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/JsonPatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/JsonPatch/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/JsonPatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/JsonPatch/merges","archive_url":"https://api.github.com/repos/aspnet/JsonPatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/JsonPatch/downloads","issues_url":"https://api.github.com/repos/aspnet/JsonPatch/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/JsonPatch/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/JsonPatch/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/JsonPatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/JsonPatch/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/JsonPatch/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/JsonPatch/deployments","created_at":"2015-09-17T16:32:18Z","updated_at":"2017-01-17T10:18:14Z","pushed_at":"2017-01-25T22:44:10Z","git_url":"git://github.com/aspnet/JsonPatch.git","ssh_url":"git@github.com:aspnet/JsonPatch.git","clone_url":"https://github.com/aspnet/JsonPatch.git","svn_url":"https://github.com/aspnet/JsonPatch","homepage":null,"size":236,"stargazers_count":33,"watchers_count":33,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":13,"forks":12,"open_issues":13,"watchers":33,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55"},"html":{"href":"https://github.com/aspnet/JsonPatch/pull/55"},"issue":{"href":"https://api.github.com/repos/aspnet/JsonPatch/issues/55"},"comments":{"href":"https://api.github.com/repos/aspnet/JsonPatch/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/JsonPatch/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/JsonPatch/statuses/2d0c79d6f13ca4f477e66bd5de7add1370c58fe9"}}}}
{"actor":{"display_login":"rynowak"}}