{"action":"closed","number":344,"pull_request":{"url":"https://api.github.com/repos/vmware/kubernetes/pulls/344","id":148758955,"html_url":"https://github.com/vmware/kubernetes/pull/344","diff_url":"https://github.com/vmware/kubernetes/pull/344.diff","patch_url":"https://github.com/vmware/kubernetes/pull/344.patch","issue_url":"https://api.github.com/repos/vmware/kubernetes/issues/344","number":344,"state":"closed","locked":false,"title":"Using ClientBuilder to listen Node events","user":{"login":"rohitjogvmw","id":28635780,"avatar_url":"https://avatars3.githubusercontent.com/u/28635780?v=4","gravatar_id":"","url":"https://api.github.com/users/rohitjogvmw","html_url":"https://github.com/rohitjogvmw","followers_url":"https://api.github.com/users/rohitjogvmw/followers","following_url":"https://api.github.com/users/rohitjogvmw/following{/other_user}","gists_url":"https://api.github.com/users/rohitjogvmw/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitjogvmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitjogvmw/subscriptions","organizations_url":"https://api.github.com/users/rohitjogvmw/orgs","repos_url":"https://api.github.com/users/rohitjogvmw/repos","events_url":"https://api.github.com/users/rohitjogvmw/events{/privacy}","received_events_url":"https://api.github.com/users/rohitjogvmw/received_events","type":"User","site_admin":false},"body":"After discussion with community people, it was decided to to modify vsphere cloud provider to make use of passed ClientBuilder for listening to Node Events (added, deleted).\r\n\r\nThis change removes earlier added NodeRegistered, NodeUnregistered APIs in all cloud-providers and node_controller and uses ClientBuilder in vSphere::Initialize() method to get access to NodeInformer.\r\nUsing NodeInformer  VCP gets required node notifications.\r\n\r\nAlso fixed vsphere_test.go.\r\nmake test now passes for vsphere \r\n\r\nTesting done:\r\n- Created hyperkube image and deployed it. Checked controller logs for Node added notifications.\r\n- Removed (powered-off and deleted from inventory) k8s worker node and using kubectl removed node from the k8s cluster. Verified in the logs that Node deleted event is seen.\r\n\r\nThis will fix: https://github.com/vmware/kubernetes/issues/334\r\n\r\n@abrarshivani, @SandeepPissay Please review the PR.\r\n","created_at":"2017-10-25T19:27:45Z","updated_at":"2017-10-26T20:51:34Z","closed_at":"2017-10-26T20:51:33Z","merged_at":"2017-10-26T20:51:33Z","merge_commit_sha":"5316048c09cb9c06ce2e694d5271f08dbaf36c64","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars0.githubusercontent.com/u/1269660?v=4","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/kubernetes/pulls/344/commits","review_comments_url":"https://api.github.com/repos/vmware/kubernetes/pulls/344/comments","review_comment_url":"https://api.github.com/repos/vmware/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/kubernetes/issues/344/comments","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/f90e1f6fb76444daa167f73a1754daee2ee1d436","head":{"label":"vmware:multi-vc-NodeEventListener","ref":"multi-vc-NodeEventListener","sha":"f90e1f6fb76444daa167f73a1754daee2ee1d436","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49536898,"name":"kubernetes","full_name":"vmware/kubernetes","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/vmware/kubernetes","forks_url":"https://api.github.com/repos/vmware/kubernetes/forks","keys_url":"https://api.github.com/repos/vmware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/kubernetes/events","assignees_url":"https://api.github.com/repos/vmware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmware/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/kubernetes/merges","archive_url":"https://api.github.com/repos/vmware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/kubernetes/deployments","created_at":"2016-01-12T23:58:29Z","updated_at":"2017-10-25T21:57:07Z","pushed_at":"2017-10-26T20:51:33Z","git_url":"git://github.com/vmware/kubernetes.git","ssh_url":"git@github.com:vmware/kubernetes.git","clone_url":"https://github.com/vmware/kubernetes.git","svn_url":"https://github.com/vmware/kubernetes","homepage":"http://kubernetes.io","size":516007,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":111,"forks":8,"open_issues":111,"watchers":13,"default_branch":"master"}},"base":{"label":"vmware:multi-vc","ref":"multi-vc","sha":"dc5e38bc01cb6d54bbc23b3acd7f2407afd62078","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49536898,"name":"kubernetes","full_name":"vmware/kubernetes","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/vmware/kubernetes","forks_url":"https://api.github.com/repos/vmware/kubernetes/forks","keys_url":"https://api.github.com/repos/vmware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/kubernetes/events","assignees_url":"https://api.github.com/repos/vmware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmware/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/kubernetes/merges","archive_url":"https://api.github.com/repos/vmware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/kubernetes/deployments","created_at":"2016-01-12T23:58:29Z","updated_at":"2017-10-25T21:57:07Z","pushed_at":"2017-10-26T20:51:33Z","git_url":"git://github.com/vmware/kubernetes.git","ssh_url":"git@github.com:vmware/kubernetes.git","clone_url":"https://github.com/vmware/kubernetes.git","svn_url":"https://github.com/vmware/kubernetes","homepage":"http://kubernetes.io","size":516007,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":111,"forks":8,"open_issues":111,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/344"},"html":{"href":"https://github.com/vmware/kubernetes/pull/344"},"issue":{"href":"https://api.github.com/repos/vmware/kubernetes/issues/344"},"comments":{"href":"https://api.github.com/repos/vmware/kubernetes/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/kubernetes/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/kubernetes/statuses/f90e1f6fb76444daa167f73a1754daee2ee1d436"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rohitjogvmw","id":28635780,"avatar_url":"https://avatars3.githubusercontent.com/u/28635780?v=4","gravatar_id":"","url":"https://api.github.com/users/rohitjogvmw","html_url":"https://github.com/rohitjogvmw","followers_url":"https://api.github.com/users/rohitjogvmw/followers","following_url":"https://api.github.com/users/rohitjogvmw/following{/other_user}","gists_url":"https://api.github.com/users/rohitjogvmw/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitjogvmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitjogvmw/subscriptions","organizations_url":"https://api.github.com/users/rohitjogvmw/orgs","repos_url":"https://api.github.com/users/rohitjogvmw/repos","events_url":"https://api.github.com/users/rohitjogvmw/events{/privacy}","received_events_url":"https://api.github.com/users/rohitjogvmw/received_events","type":"User","site_admin":false},"comments":2,"review_comments":30,"maintainer_can_modify":false,"commits":1,"additions":70,"deletions":153,"changed_files":15}}
{"actor":{"display_login":"rohitjogvmw"}}