{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/118608169","pull_request_review_id":40416896,"id":118608169,"diff_hunk":"@@ -309,6 +309,21 @@ pass a dictionary mapping field names to errors::\n         'pub_date': ValidationError(_('Invalid date.'), code='invalid'),\n     })\n \n+.. note::\n+   If the model is used in a model form anywhere on your site, you\n+   must only use field names in your dictionary that will exist on all\n+   forms, otherwise Django will raise a ``ValueError`` exception because\n+   it will be unable to tie the errors to their fields.\n+\n+   The ``clean_fields()`` method receives the list of fields that should\n+   be excluded from validation. Look into overriding this method and","path":"docs/ref/models/instances.txt","position":11,"original_position":11,"commit_id":"d8a974346a87900f6cd254bae2e28f2a4703da23","original_commit_id":"d8a974346a87900f6cd254bae2e28f2a4703da23","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars0.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"When you say \"Look into overriding\", is this meant as a way to workaround the issue described in the previous paragraph? If so, I would make the wording more explicit about that.\r\n\r\nA code example could be quite useful to help illustrate the ideas you've described.","created_at":"2017-05-25T23:33:59Z","updated_at":"2017-05-25T23:34:53Z","html_url":"https://github.com/django/django/pull/8394#discussion_r118608169","pull_request_url":"https://api.github.com/repos/django/django/pulls/8394","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/118608169"},"html":{"href":"https://github.com/django/django/pull/8394#discussion_r118608169"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/8394"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/8394","id":117144798,"html_url":"https://github.com/django/django/pull/8394","diff_url":"https://github.com/django/django/pull/8394.diff","patch_url":"https://github.com/django/django/pull/8394.patch","issue_url":"https://api.github.com/repos/django/django/issues/8394","number":8394,"state":"open","locked":false,"title":"Refs #27434: Added a note about raising validation errors with dicts","user":{"login":"matthiask","id":2627,"avatar_url":"https://avatars2.githubusercontent.com/u/2627?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiask","html_url":"https://github.com/matthiask","followers_url":"https://api.github.com/users/matthiask/followers","following_url":"https://api.github.com/users/matthiask/following{/other_user}","gists_url":"https://api.github.com/users/matthiask/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiask/subscriptions","organizations_url":"https://api.github.com/users/matthiask/orgs","repos_url":"https://api.github.com/users/matthiask/repos","events_url":"https://api.github.com/users/matthiask/events{/privacy}","received_events_url":"https://api.github.com/users/matthiask/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-23T10:56:38Z","updated_at":"2017-05-25T23:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee3a4fa03292fa11bc4d229be3490bce3afe8353","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/8394/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/8394/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/8394/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/d8a974346a87900f6cd254bae2e28f2a4703da23","head":{"label":"matthiask:ticket27434","ref":"ticket27434","sha":"d8a974346a87900f6cd254bae2e28f2a4703da23","user":{"login":"matthiask","id":2627,"avatar_url":"https://avatars2.githubusercontent.com/u/2627?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiask","html_url":"https://github.com/matthiask","followers_url":"https://api.github.com/users/matthiask/followers","following_url":"https://api.github.com/users/matthiask/following{/other_user}","gists_url":"https://api.github.com/users/matthiask/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiask/subscriptions","organizations_url":"https://api.github.com/users/matthiask/orgs","repos_url":"https://api.github.com/users/matthiask/repos","events_url":"https://api.github.com/users/matthiask/events{/privacy}","received_events_url":"https://api.github.com/users/matthiask/received_events","type":"User","site_admin":false},"repo":{"id":14679649,"name":"django","full_name":"matthiask/django","owner":{"login":"matthiask","id":2627,"avatar_url":"https://avatars2.githubusercontent.com/u/2627?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiask","html_url":"https://github.com/matthiask","followers_url":"https://api.github.com/users/matthiask/followers","following_url":"https://api.github.com/users/matthiask/following{/other_user}","gists_url":"https://api.github.com/users/matthiask/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiask/subscriptions","organizations_url":"https://api.github.com/users/matthiask/orgs","repos_url":"https://api.github.com/users/matthiask/repos","events_url":"https://api.github.com/users/matthiask/events{/privacy}","received_events_url":"https://api.github.com/users/matthiask/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthiask/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/matthiask/django","forks_url":"https://api.github.com/repos/matthiask/django/forks","keys_url":"https://api.github.com/repos/matthiask/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthiask/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthiask/django/teams","hooks_url":"https://api.github.com/repos/matthiask/django/hooks","issue_events_url":"https://api.github.com/repos/matthiask/django/issues/events{/number}","events_url":"https://api.github.com/repos/matthiask/django/events","assignees_url":"https://api.github.com/repos/matthiask/django/assignees{/user}","branches_url":"https://api.github.com/repos/matthiask/django/branches{/branch}","tags_url":"https://api.github.com/repos/matthiask/django/tags","blobs_url":"https://api.github.com/repos/matthiask/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthiask/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthiask/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthiask/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthiask/django/statuses/{sha}","languages_url":"https://api.github.com/repos/matthiask/django/languages","stargazers_url":"https://api.github.com/repos/matthiask/django/stargazers","contributors_url":"https://api.github.com/repos/matthiask/django/contributors","subscribers_url":"https://api.github.com/repos/matthiask/django/subscribers","subscription_url":"https://api.github.com/repos/matthiask/django/subscription","commits_url":"https://api.github.com/repos/matthiask/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthiask/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthiask/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthiask/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthiask/django/contents/{+path}","compare_url":"https://api.github.com/repos/matthiask/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthiask/django/merges","archive_url":"https://api.github.com/repos/matthiask/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthiask/django/downloads","issues_url":"https://api.github.com/repos/matthiask/django/issues{/number}","pulls_url":"https://api.github.com/repos/matthiask/django/pulls{/number}","milestones_url":"https://api.github.com/repos/matthiask/django/milestones{/number}","notifications_url":"https://api.github.com/repos/matthiask/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthiask/django/labels{/name}","releases_url":"https://api.github.com/repos/matthiask/django/releases{/id}","deployments_url":"https://api.github.com/repos/matthiask/django/deployments","created_at":"2013-11-25T08:00:09Z","updated_at":"2015-03-10T00:45:00Z","pushed_at":"2017-04-23T17:20:29Z","git_url":"git://github.com/matthiask/django.git","ssh_url":"git@github.com:matthiask/django.git","clone_url":"https://github.com/matthiask/django.git","svn_url":"https://github.com/matthiask/django","homepage":"http://www.djangoproject.com/","size":151483,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"8ef35468b660e1c25af67a8299202b8bc108679f","user":{"login":"django","id":27804,"avatar_url":"https://avatars1.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars1.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2017-05-25T23:29:29Z","pushed_at":"2017-05-25T22:19:40Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":163972,"stargazers_count":25875,"watchers_count":25875,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10637,"mirror_url":null,"open_issues_count":169,"forks":10637,"open_issues":169,"watchers":25875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/8394"},"html":{"href":"https://github.com/django/django/pull/8394"},"issue":{"href":"https://api.github.com/repos/django/django/issues/8394"},"comments":{"href":"https://api.github.com/repos/django/django/issues/8394/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/8394/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/8394/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/d8a974346a87900f6cd254bae2e28f2a4703da23"}}}}
{"actor":{"display_login":"timgraham"}}