{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/134081433","pull_request_review_id":57340579,"id":134081433,"diff_hunk":"@@ -28,13 +28,13 @@ import (\n \tapiserveroptions \"k8s.io/apiserver/pkg/server/options\"\n \t\"k8s.io/apiserver/pkg/storage/storagebackend\"\n \tutilconfig \"k8s.io/apiserver/pkg/util/flag\"\n+\trestclient \"k8s.io/client-go/rest\"\n \tkapi \"k8s.io/kubernetes/pkg/api\"\n \tkubeoptions \"k8s.io/kubernetes/pkg/kubeapiserver/options\"\n \tkubeletclient \"k8s.io/kubernetes/pkg/kubelet/client\"\n )\n \n func TestAddFlagsFlag(t *testing.T) {","path":"cmd/kube-apiserver/app/options/options_test.go","position":10,"original_position":10,"commit_id":"4fc69ecc3a300d3e50c31d93a3f8f4d09b7deeef","original_commit_id":"4fc69ecc3a300d3e50c31d93a3f8f4d09b7deeef","user":{"login":"wackxu","id":30396467,"avatar_url":"https://avatars1.githubusercontent.com/u/30396467?v=4","gravatar_id":"","url":"https://api.github.com/users/wackxu","html_url":"https://github.com/wackxu","followers_url":"https://api.github.com/users/wackxu/followers","following_url":"https://api.github.com/users/wackxu/following{/other_user}","gists_url":"https://api.github.com/users/wackxu/gists{/gist_id}","starred_url":"https://api.github.com/users/wackxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wackxu/subscriptions","organizations_url":"https://api.github.com/users/wackxu/orgs","repos_url":"https://api.github.com/users/wackxu/repos","events_url":"https://api.github.com/users/wackxu/events{/privacy}","received_events_url":"https://api.github.com/users/wackxu/received_events","type":"User","site_admin":false},"body":"I agree with you. It looks like a typo and I will fix it.","created_at":"2017-08-19T03:09:27Z","updated_at":"2017-08-19T03:09:27Z","html_url":"https://github.com/kubernetes/kubernetes/pull/50848#discussion_r134081433","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/134081433"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50848#discussion_r134081433"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848","id":136261952,"html_url":"https://github.com/kubernetes/kubernetes/pull/50848","diff_url":"https://github.com/kubernetes/kubernetes/pull/50848.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50848.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50848","number":50848,"state":"open","locked":false,"title":"Expand the test to include other flags as well","user":{"login":"wackxu","id":30396467,"avatar_url":"https://avatars1.githubusercontent.com/u/30396467?v=4","gravatar_id":"","url":"https://api.github.com/users/wackxu","html_url":"https://github.com/wackxu","followers_url":"https://api.github.com/users/wackxu/followers","following_url":"https://api.github.com/users/wackxu/following{/other_user}","gists_url":"https://api.github.com/users/wackxu/gists{/gist_id}","starred_url":"https://api.github.com/users/wackxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wackxu/subscriptions","organizations_url":"https://api.github.com/users/wackxu/orgs","repos_url":"https://api.github.com/users/wackxu/repos","events_url":"https://api.github.com/users/wackxu/events{/privacy}","received_events_url":"https://api.github.com/users/wackxu/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nExpand the test to include other flags as well\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n `NONE`","created_at":"2017-08-17T13:50:19Z","updated_at":"2017-08-19T03:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbffe1ccb19b1451f6067e3734fe4ecbfcec48e9","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ncdc","id":354,"avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50848/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4fc69ecc3a300d3e50c31d93a3f8f4d09b7deeef","head":{"label":"wackxu:addTest","ref":"addTest","sha":"4fc69ecc3a300d3e50c31d93a3f8f4d09b7deeef","user":{"login":"wackxu","id":30396467,"avatar_url":"https://avatars1.githubusercontent.com/u/30396467?v=4","gravatar_id":"","url":"https://api.github.com/users/wackxu","html_url":"https://github.com/wackxu","followers_url":"https://api.github.com/users/wackxu/followers","following_url":"https://api.github.com/users/wackxu/following{/other_user}","gists_url":"https://api.github.com/users/wackxu/gists{/gist_id}","starred_url":"https://api.github.com/users/wackxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wackxu/subscriptions","organizations_url":"https://api.github.com/users/wackxu/orgs","repos_url":"https://api.github.com/users/wackxu/repos","events_url":"https://api.github.com/users/wackxu/events{/privacy}","received_events_url":"https://api.github.com/users/wackxu/received_events","type":"User","site_admin":false},"repo":{"id":98251349,"name":"kubernetes","full_name":"wackxu/kubernetes","owner":{"login":"wackxu","id":30396467,"avatar_url":"https://avatars1.githubusercontent.com/u/30396467?v=4","gravatar_id":"","url":"https://api.github.com/users/wackxu","html_url":"https://github.com/wackxu","followers_url":"https://api.github.com/users/wackxu/followers","following_url":"https://api.github.com/users/wackxu/following{/other_user}","gists_url":"https://api.github.com/users/wackxu/gists{/gist_id}","starred_url":"https://api.github.com/users/wackxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wackxu/subscriptions","organizations_url":"https://api.github.com/users/wackxu/orgs","repos_url":"https://api.github.com/users/wackxu/repos","events_url":"https://api.github.com/users/wackxu/events{/privacy}","received_events_url":"https://api.github.com/users/wackxu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wackxu/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/wackxu/kubernetes","forks_url":"https://api.github.com/repos/wackxu/kubernetes/forks","keys_url":"https://api.github.com/repos/wackxu/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wackxu/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wackxu/kubernetes/teams","hooks_url":"https://api.github.com/repos/wackxu/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wackxu/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wackxu/kubernetes/events","assignees_url":"https://api.github.com/repos/wackxu/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wackxu/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wackxu/kubernetes/tags","blobs_url":"https://api.github.com/repos/wackxu/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wackxu/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wackxu/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wackxu/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wackxu/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wackxu/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wackxu/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wackxu/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wackxu/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wackxu/kubernetes/subscription","commits_url":"https://api.github.com/repos/wackxu/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wackxu/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wackxu/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wackxu/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wackxu/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wackxu/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wackxu/kubernetes/merges","archive_url":"https://api.github.com/repos/wackxu/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wackxu/kubernetes/downloads","issues_url":"https://api.github.com/repos/wackxu/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wackxu/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wackxu/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wackxu/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wackxu/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wackxu/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wackxu/kubernetes/deployments","created_at":"2017-07-25T01:42:08Z","updated_at":"2017-07-25T01:42:48Z","pushed_at":"2017-08-18T07:26:25Z","git_url":"git://github.com/wackxu/kubernetes.git","ssh_url":"git@github.com:wackxu/kubernetes.git","clone_url":"https://github.com/wackxu/kubernetes.git","svn_url":"https://github.com/wackxu/kubernetes","homepage":"http://kubernetes.io","size":460308,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"38053c3e4486e6a7fafd00b2784a1e67e0357f45","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-08-19T02:23:38Z","pushed_at":"2017-08-19T02:49:46Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":676881,"stargazers_count":26059,"watchers_count":26059,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9293,"mirror_url":null,"open_issues_count":5262,"forks":9293,"open_issues":5262,"watchers":26059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50848"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50848"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50848/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50848/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4fc69ecc3a300d3e50c31d93a3f8f4d09b7deeef"}}}}
{"actor":{"display_login":"wackxu"}}