{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/903","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/903/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/903/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/903/events","html_url":"https://github.com/vufind-org/vufind/pull/903","id":204576682,"number":903,"title":"Fav action direct download 3.1.2","user":{"login":"mbeh-ub","id":7057099,"avatar_url":"https://avatars.githubusercontent.com/u/7057099?v=3","gravatar_id":"","url":"https://api.github.com/users/mbeh-ub","html_url":"https://github.com/mbeh-ub","followers_url":"https://api.github.com/users/mbeh-ub/followers","following_url":"https://api.github.com/users/mbeh-ub/following{/other_user}","gists_url":"https://api.github.com/users/mbeh-ub/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeh-ub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeh-ub/subscriptions","organizations_url":"https://api.github.com/users/mbeh-ub/orgs","repos_url":"https://api.github.com/users/mbeh-ub/repos","events_url":"https://api.github.com/users/mbeh-ub/events{/privacy}","received_events_url":"https://api.github.com/users/mbeh-ub/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-02-01T12:55:56Z","updated_at":"2017-02-06T14:45:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/903","html_url":"https://github.com/vufind-org/vufind/pull/903","diff_url":"https://github.com/vufind-org/vufind/pull/903.diff","patch_url":"https://github.com/vufind-org/vufind/pull/903.patch"},"body":"Hello Demian,\r\n\r\nsince the new lighbox code has been introduced the option defaultType = download in \r\nthe [BulkExport]-Section of config.ini seems to stop working.\r\n\r\nI fixed this an hope you add this fix to the vufind base code.\r\n\r\nNotice: I have created an separate theme where I keep the changes files. Therefor you cannot sadly see the changes directly but have to compare the file lightbox.js with the one in the bootstrap theme.\r\nThis branch is based on the vufind 3.1.2 code.\r\n\r\nGreetings \r\nMarkus\r\n\r\nTODO\r\n- [ ] Backport to release-3.1\r\n"},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/277702890","html_url":"https://github.com/vufind-org/vufind/pull/903#issuecomment-277702890","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/903","id":277702890,"user":{"login":"crhallberg","id":451107,"avatar_url":"https://avatars.githubusercontent.com/u/451107?v=3","gravatar_id":"","url":"https://api.github.com/users/crhallberg","html_url":"https://github.com/crhallberg","followers_url":"https://api.github.com/users/crhallberg/followers","following_url":"https://api.github.com/users/crhallberg/following{/other_user}","gists_url":"https://api.github.com/users/crhallberg/gists{/gist_id}","starred_url":"https://api.github.com/users/crhallberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crhallberg/subscriptions","organizations_url":"https://api.github.com/users/crhallberg/orgs","repos_url":"https://api.github.com/users/crhallberg/repos","events_url":"https://api.github.com/users/crhallberg/events{/privacy}","received_events_url":"https://api.github.com/users/crhallberg/received_events","type":"User","site_admin":false},"created_at":"2017-02-06T14:45:19Z","updated_at":"2017-02-06T14:45:19Z","body":"Well that's generous of the browser. Since that's the case, I agree with your solution. Thank you for removing the other feature code.\r\n\r\nIt looks like there are still a few Javascript style issues. You can run `phing eslint-fix` to repair some of the problems and see the remaining ones."}}
{"actor":{"display_login":"crhallberg"}}