{"action":"created","comment":{"url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/comments/154710551","pull_request_review_id":80914225,"id":154710551,"diff_hunk":"@@ -0,0 +1,11 @@\n+'use strict';\n+\n+var getInferredName;\n+try {\n+\t// eslint-disable-next-line no-new-func\n+\tgetInferredName = Function('s', 'return { [s]() {} }[s].name;');","path":"helpers/getInferredName.js","position":6,"original_position":6,"commit_id":"10f4fa2f8d6102ef8f5a07b23438d6a793c65c6b","original_commit_id":"10f4fa2f8d6102ef8f5a07b23438d6a793c65c6b","user":{"login":"michaelficarra","id":218840,"avatar_url":"https://avatars1.githubusercontent.com/u/218840?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelficarra","html_url":"https://github.com/michaelficarra","followers_url":"https://api.github.com/users/michaelficarra/followers","following_url":"https://api.github.com/users/michaelficarra/following{/other_user}","gists_url":"https://api.github.com/users/michaelficarra/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelficarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelficarra/subscriptions","organizations_url":"https://api.github.com/users/michaelficarra/orgs","repos_url":"https://api.github.com/users/michaelficarra/repos","events_url":"https://api.github.com/users/michaelficarra/events{/privacy}","received_events_url":"https://api.github.com/users/michaelficarra/received_events","type":"User","site_admin":false},"body":"Why does this use the Function constructor on strings instead of just a function expression?","created_at":"2017-12-04T17:04:33Z","updated_at":"2017-12-04T17:04:33Z","html_url":"https://github.com/es-shims/Symbol.prototype.description/pull/2#discussion_r154710551","pull_request_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/comments/154710551"},"html":{"href":"https://github.com/es-shims/Symbol.prototype.description/pull/2#discussion_r154710551"},"pull_request":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2","id":155809047,"html_url":"https://github.com/es-shims/Symbol.prototype.description/pull/2","diff_url":"https://github.com/es-shims/Symbol.prototype.description/pull/2.diff","patch_url":"https://github.com/es-shims/Symbol.prototype.description/pull/2.patch","issue_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/2","number":2,"state":"open","locked":false,"title":"[Fix] use function name inference and computed properties to distinguish `Symbol()` from `Symbol(‘’)`, when available","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars1.githubusercontent.com/u/45469?v=4","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Fixes #1.\r\n\r\ncc @bakkot @michaelficarra","created_at":"2017-12-01T08:41:39Z","updated_at":"2017-12-04T17:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bc6f6da26539e26115c536908370b5d4fc294e8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2/commits","review_comments_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2/comments","review_comment_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/comments{/number}","comments_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/2/comments","statuses_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/statuses/10f4fa2f8d6102ef8f5a07b23438d6a793c65c6b","head":{"label":"es-shims:name_inference","ref":"name_inference","sha":"10f4fa2f8d6102ef8f5a07b23438d6a793c65c6b","user":{"login":"es-shims","id":6288429,"avatar_url":"https://avatars1.githubusercontent.com/u/6288429?v=4","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"repo":{"id":98338800,"name":"Symbol.prototype.description","full_name":"es-shims/Symbol.prototype.description","owner":{"login":"es-shims","id":6288429,"avatar_url":"https://avatars1.githubusercontent.com/u/6288429?v=4","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/es-shims/Symbol.prototype.description","description":"Spec-compliant shim for Symbol.prototype.description proposal.","fork":false,"url":"https://api.github.com/repos/es-shims/Symbol.prototype.description","forks_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/forks","keys_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/keys{/key_id}","collaborators_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/teams","hooks_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/hooks","issue_events_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/events{/number}","events_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/events","assignees_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/assignees{/user}","branches_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/branches{/branch}","tags_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/tags","blobs_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/refs{/sha}","trees_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/trees{/sha}","statuses_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/statuses/{sha}","languages_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/languages","stargazers_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/stargazers","contributors_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/contributors","subscribers_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/subscribers","subscription_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/subscription","commits_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/commits{/sha}","git_commits_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/commits{/sha}","comments_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/comments{/number}","issue_comment_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/comments{/number}","contents_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/contents/{+path}","compare_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/compare/{base}...{head}","merges_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/merges","archive_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/downloads","issues_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues{/number}","pulls_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls{/number}","milestones_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/milestones{/number}","notifications_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/labels{/name}","releases_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/releases{/id}","deployments_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/deployments","created_at":"2017-07-25T18:42:05Z","updated_at":"2017-07-28T16:36:00Z","pushed_at":"2017-12-01T21:33:49Z","git_url":"git://github.com/es-shims/Symbol.prototype.description.git","ssh_url":"git@github.com:es-shims/Symbol.prototype.description.git","clone_url":"https://github.com/es-shims/Symbol.prototype.description.git","svn_url":"https://github.com/es-shims/Symbol.prototype.description","homepage":null,"size":17,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"es-shims:master","ref":"master","sha":"c6d18077067a5fc2835a0d38bbc90b28fb98e8e4","user":{"login":"es-shims","id":6288429,"avatar_url":"https://avatars1.githubusercontent.com/u/6288429?v=4","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"repo":{"id":98338800,"name":"Symbol.prototype.description","full_name":"es-shims/Symbol.prototype.description","owner":{"login":"es-shims","id":6288429,"avatar_url":"https://avatars1.githubusercontent.com/u/6288429?v=4","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/es-shims/Symbol.prototype.description","description":"Spec-compliant shim for Symbol.prototype.description proposal.","fork":false,"url":"https://api.github.com/repos/es-shims/Symbol.prototype.description","forks_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/forks","keys_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/keys{/key_id}","collaborators_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/teams","hooks_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/hooks","issue_events_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/events{/number}","events_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/events","assignees_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/assignees{/user}","branches_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/branches{/branch}","tags_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/tags","blobs_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/refs{/sha}","trees_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/trees{/sha}","statuses_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/statuses/{sha}","languages_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/languages","stargazers_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/stargazers","contributors_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/contributors","subscribers_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/subscribers","subscription_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/subscription","commits_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/commits{/sha}","git_commits_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/git/commits{/sha}","comments_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/comments{/number}","issue_comment_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/comments{/number}","contents_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/contents/{+path}","compare_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/compare/{base}...{head}","merges_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/merges","archive_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/downloads","issues_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues{/number}","pulls_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls{/number}","milestones_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/milestones{/number}","notifications_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/labels{/name}","releases_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/releases{/id}","deployments_url":"https://api.github.com/repos/es-shims/Symbol.prototype.description/deployments","created_at":"2017-07-25T18:42:05Z","updated_at":"2017-07-28T16:36:00Z","pushed_at":"2017-12-01T21:33:49Z","git_url":"git://github.com/es-shims/Symbol.prototype.description.git","ssh_url":"git@github.com:es-shims/Symbol.prototype.description.git","clone_url":"https://github.com/es-shims/Symbol.prototype.description.git","svn_url":"https://github.com/es-shims/Symbol.prototype.description","homepage":null,"size":17,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2"},"html":{"href":"https://github.com/es-shims/Symbol.prototype.description/pull/2"},"issue":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/2"},"comments":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/es-shims/Symbol.prototype.description/statuses/10f4fa2f8d6102ef8f5a07b23438d6a793c65c6b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"michaelficarra"}}