{"action":"created","comment":{"url":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/comments/124688079","pull_request_review_id":47001924,"id":124688079,"diff_hunk":"@@ -21,6 +21,10 @@ set_conf() {\n if [ ! -z \"$HOST\" ] && [ ! -z \"$PORT0\" ] && [ -z \"$SDC_CONF_SDC_BASE_HTTP_URL\" ]; then\n   export SDC_CONF_SDC_BASE_HTTP_URL=\"http://${HOST}:${PORT0}\"\n fi\n+# if SDC_CONF_HTTP_PORT hasn't already been defined but PORT0, use PORT0\n+if [ ! -z \"$PORT0\" ] && [ -z \"$SDC_CONF_HTTP_PORT\" ]; then\n+  export SDC_CONF_HTTP_PORT=$PORT0\n+fi","path":"docker-entrypoint.sh","position":7,"original_position":7,"commit_id":"2016f79b1410481e8b8e7e92e25b76088907c58b","original_commit_id":"2016f79b1410481e8b8e7e92e25b76088907c58b","user":{"login":"kunickiaj","id":746474,"avatar_url":"https://avatars1.githubusercontent.com/u/746474?v=3","gravatar_id":"","url":"https://api.github.com/users/kunickiaj","html_url":"https://github.com/kunickiaj","followers_url":"https://api.github.com/users/kunickiaj/followers","following_url":"https://api.github.com/users/kunickiaj/following{/other_user}","gists_url":"https://api.github.com/users/kunickiaj/gists{/gist_id}","starred_url":"https://api.github.com/users/kunickiaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunickiaj/subscriptions","organizations_url":"https://api.github.com/users/kunickiaj/orgs","repos_url":"https://api.github.com/users/kunickiaj/repos","events_url":"https://api.github.com/users/kunickiaj/events{/privacy}","received_events_url":"https://api.github.com/users/kunickiaj/received_events","type":"User","site_admin":false},"body":"I believe this is only correct behavior in BRIDGE networking mode. In the default HOST networking mode, $PORT0 is the host port and SDC_CONF_HTTP_PORT should not be changed.","created_at":"2017-06-29T00:21:55Z","updated_at":"2017-06-29T00:22:48Z","html_url":"https://github.com/streamsets/datacollector-docker/pull/7#discussion_r124688079","pull_request_url":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/comments/124688079"},"html":{"href":"https://github.com/streamsets/datacollector-docker/pull/7#discussion_r124688079"},"pull_request":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7","id":128017633,"html_url":"https://github.com/streamsets/datacollector-docker/pull/7","diff_url":"https://github.com/streamsets/datacollector-docker/pull/7.diff","patch_url":"https://github.com/streamsets/datacollector-docker/pull/7.patch","issue_url":"https://api.github.com/repos/streamsets/datacollector-docker/issues/7","number":7,"state":"open","locked":false,"title":"Adding Marathon compatibility and update to lastest","user":{"login":"mswimmer","id":219845,"avatar_url":"https://avatars0.githubusercontent.com/u/219845?v=3","gravatar_id":"","url":"https://api.github.com/users/mswimmer","html_url":"https://github.com/mswimmer","followers_url":"https://api.github.com/users/mswimmer/followers","following_url":"https://api.github.com/users/mswimmer/following{/other_user}","gists_url":"https://api.github.com/users/mswimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mswimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mswimmer/subscriptions","organizations_url":"https://api.github.com/users/mswimmer/orgs","repos_url":"https://api.github.com/users/mswimmer/repos","events_url":"https://api.github.com/users/mswimmer/events{/privacy}","received_events_url":"https://api.github.com/users/mswimmer/received_events","type":"User","site_admin":false},"body":"Hi, I've modified the Dockerfile so that it picks up the lastest version of Streamsets and changed docker-entrypoint.sh so that it correctly sets the port when in a Mesos Marathon environment.","created_at":"2017-06-28T20:53:24Z","updated_at":"2017-06-29T00:22:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d437c56820b5c269b6ffd5e3c11a18e1df7e8318","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7/commits","review_comments_url":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7/comments","review_comment_url":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/streamsets/datacollector-docker/issues/7/comments","statuses_url":"https://api.github.com/repos/streamsets/datacollector-docker/statuses/2016f79b1410481e8b8e7e92e25b76088907c58b","head":{"label":"mswimmer:master","ref":"master","sha":"2016f79b1410481e8b8e7e92e25b76088907c58b","user":{"login":"mswimmer","id":219845,"avatar_url":"https://avatars0.githubusercontent.com/u/219845?v=3","gravatar_id":"","url":"https://api.github.com/users/mswimmer","html_url":"https://github.com/mswimmer","followers_url":"https://api.github.com/users/mswimmer/followers","following_url":"https://api.github.com/users/mswimmer/following{/other_user}","gists_url":"https://api.github.com/users/mswimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mswimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mswimmer/subscriptions","organizations_url":"https://api.github.com/users/mswimmer/orgs","repos_url":"https://api.github.com/users/mswimmer/repos","events_url":"https://api.github.com/users/mswimmer/events{/privacy}","received_events_url":"https://api.github.com/users/mswimmer/received_events","type":"User","site_admin":false},"repo":{"id":47395075,"name":"datacollector","full_name":"mswimmer/datacollector","owner":{"login":"mswimmer","id":219845,"avatar_url":"https://avatars0.githubusercontent.com/u/219845?v=3","gravatar_id":"","url":"https://api.github.com/users/mswimmer","html_url":"https://github.com/mswimmer","followers_url":"https://api.github.com/users/mswimmer/followers","following_url":"https://api.github.com/users/mswimmer/following{/other_user}","gists_url":"https://api.github.com/users/mswimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mswimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mswimmer/subscriptions","organizations_url":"https://api.github.com/users/mswimmer/orgs","repos_url":"https://api.github.com/users/mswimmer/repos","events_url":"https://api.github.com/users/mswimmer/events{/privacy}","received_events_url":"https://api.github.com/users/mswimmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mswimmer/datacollector","description":"Dockerfiles for StreamSets Data Collector","fork":true,"url":"https://api.github.com/repos/mswimmer/datacollector","forks_url":"https://api.github.com/repos/mswimmer/datacollector/forks","keys_url":"https://api.github.com/repos/mswimmer/datacollector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mswimmer/datacollector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mswimmer/datacollector/teams","hooks_url":"https://api.github.com/repos/mswimmer/datacollector/hooks","issue_events_url":"https://api.github.com/repos/mswimmer/datacollector/issues/events{/number}","events_url":"https://api.github.com/repos/mswimmer/datacollector/events","assignees_url":"https://api.github.com/repos/mswimmer/datacollector/assignees{/user}","branches_url":"https://api.github.com/repos/mswimmer/datacollector/branches{/branch}","tags_url":"https://api.github.com/repos/mswimmer/datacollector/tags","blobs_url":"https://api.github.com/repos/mswimmer/datacollector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mswimmer/datacollector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mswimmer/datacollector/git/refs{/sha}","trees_url":"https://api.github.com/repos/mswimmer/datacollector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mswimmer/datacollector/statuses/{sha}","languages_url":"https://api.github.com/repos/mswimmer/datacollector/languages","stargazers_url":"https://api.github.com/repos/mswimmer/datacollector/stargazers","contributors_url":"https://api.github.com/repos/mswimmer/datacollector/contributors","subscribers_url":"https://api.github.com/repos/mswimmer/datacollector/subscribers","subscription_url":"https://api.github.com/repos/mswimmer/datacollector/subscription","commits_url":"https://api.github.com/repos/mswimmer/datacollector/commits{/sha}","git_commits_url":"https://api.github.com/repos/mswimmer/datacollector/git/commits{/sha}","comments_url":"https://api.github.com/repos/mswimmer/datacollector/comments{/number}","issue_comment_url":"https://api.github.com/repos/mswimmer/datacollector/issues/comments{/number}","contents_url":"https://api.github.com/repos/mswimmer/datacollector/contents/{+path}","compare_url":"https://api.github.com/repos/mswimmer/datacollector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mswimmer/datacollector/merges","archive_url":"https://api.github.com/repos/mswimmer/datacollector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mswimmer/datacollector/downloads","issues_url":"https://api.github.com/repos/mswimmer/datacollector/issues{/number}","pulls_url":"https://api.github.com/repos/mswimmer/datacollector/pulls{/number}","milestones_url":"https://api.github.com/repos/mswimmer/datacollector/milestones{/number}","notifications_url":"https://api.github.com/repos/mswimmer/datacollector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mswimmer/datacollector/labels{/name}","releases_url":"https://api.github.com/repos/mswimmer/datacollector/releases{/id}","deployments_url":"https://api.github.com/repos/mswimmer/datacollector/deployments","created_at":"2015-12-04T09:42:01Z","updated_at":"2017-06-28T20:04:19Z","pushed_at":"2017-06-28T20:38:09Z","git_url":"git://github.com/mswimmer/datacollector.git","ssh_url":"git@github.com:mswimmer/datacollector.git","clone_url":"https://github.com/mswimmer/datacollector.git","svn_url":"https://github.com/mswimmer/datacollector","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"streamsets:master","ref":"master","sha":"18d03cf9b56785b72a9e5eb870d134c9c7baa6b5","user":{"login":"streamsets","id":14020362,"avatar_url":"https://avatars0.githubusercontent.com/u/14020362?v=3","gravatar_id":"","url":"https://api.github.com/users/streamsets","html_url":"https://github.com/streamsets","followers_url":"https://api.github.com/users/streamsets/followers","following_url":"https://api.github.com/users/streamsets/following{/other_user}","gists_url":"https://api.github.com/users/streamsets/gists{/gist_id}","starred_url":"https://api.github.com/users/streamsets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamsets/subscriptions","organizations_url":"https://api.github.com/users/streamsets/orgs","repos_url":"https://api.github.com/users/streamsets/repos","events_url":"https://api.github.com/users/streamsets/events{/privacy}","received_events_url":"https://api.github.com/users/streamsets/received_events","type":"Organization","site_admin":false},"repo":{"id":42328095,"name":"datacollector-docker","full_name":"streamsets/datacollector-docker","owner":{"login":"streamsets","id":14020362,"avatar_url":"https://avatars0.githubusercontent.com/u/14020362?v=3","gravatar_id":"","url":"https://api.github.com/users/streamsets","html_url":"https://github.com/streamsets","followers_url":"https://api.github.com/users/streamsets/followers","following_url":"https://api.github.com/users/streamsets/following{/other_user}","gists_url":"https://api.github.com/users/streamsets/gists{/gist_id}","starred_url":"https://api.github.com/users/streamsets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamsets/subscriptions","organizations_url":"https://api.github.com/users/streamsets/orgs","repos_url":"https://api.github.com/users/streamsets/repos","events_url":"https://api.github.com/users/streamsets/events{/privacy}","received_events_url":"https://api.github.com/users/streamsets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamsets/datacollector-docker","description":"Dockerfiles for StreamSets Data Collector","fork":false,"url":"https://api.github.com/repos/streamsets/datacollector-docker","forks_url":"https://api.github.com/repos/streamsets/datacollector-docker/forks","keys_url":"https://api.github.com/repos/streamsets/datacollector-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamsets/datacollector-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamsets/datacollector-docker/teams","hooks_url":"https://api.github.com/repos/streamsets/datacollector-docker/hooks","issue_events_url":"https://api.github.com/repos/streamsets/datacollector-docker/issues/events{/number}","events_url":"https://api.github.com/repos/streamsets/datacollector-docker/events","assignees_url":"https://api.github.com/repos/streamsets/datacollector-docker/assignees{/user}","branches_url":"https://api.github.com/repos/streamsets/datacollector-docker/branches{/branch}","tags_url":"https://api.github.com/repos/streamsets/datacollector-docker/tags","blobs_url":"https://api.github.com/repos/streamsets/datacollector-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamsets/datacollector-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamsets/datacollector-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamsets/datacollector-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamsets/datacollector-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/streamsets/datacollector-docker/languages","stargazers_url":"https://api.github.com/repos/streamsets/datacollector-docker/stargazers","contributors_url":"https://api.github.com/repos/streamsets/datacollector-docker/contributors","subscribers_url":"https://api.github.com/repos/streamsets/datacollector-docker/subscribers","subscription_url":"https://api.github.com/repos/streamsets/datacollector-docker/subscription","commits_url":"https://api.github.com/repos/streamsets/datacollector-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamsets/datacollector-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamsets/datacollector-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamsets/datacollector-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamsets/datacollector-docker/contents/{+path}","compare_url":"https://api.github.com/repos/streamsets/datacollector-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamsets/datacollector-docker/merges","archive_url":"https://api.github.com/repos/streamsets/datacollector-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamsets/datacollector-docker/downloads","issues_url":"https://api.github.com/repos/streamsets/datacollector-docker/issues{/number}","pulls_url":"https://api.github.com/repos/streamsets/datacollector-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/streamsets/datacollector-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/streamsets/datacollector-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamsets/datacollector-docker/labels{/name}","releases_url":"https://api.github.com/repos/streamsets/datacollector-docker/releases{/id}","deployments_url":"https://api.github.com/repos/streamsets/datacollector-docker/deployments","created_at":"2015-09-11T19:27:25Z","updated_at":"2017-05-27T11:05:45Z","pushed_at":"2017-06-28T20:53:24Z","git_url":"git://github.com/streamsets/datacollector-docker.git","ssh_url":"git@github.com:streamsets/datacollector-docker.git","clone_url":"https://github.com/streamsets/datacollector-docker.git","svn_url":"https://github.com/streamsets/datacollector-docker","homepage":null,"size":47,"stargazers_count":19,"watchers_count":19,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":1,"forks":16,"open_issues":1,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7"},"html":{"href":"https://github.com/streamsets/datacollector-docker/pull/7"},"issue":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/issues/7"},"comments":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/streamsets/datacollector-docker/statuses/2016f79b1410481e8b8e7e92e25b76088907c58b"}}}}
{"actor":{"display_login":"kunickiaj"}}