{"action":"created","comment":{"url":"https://api.github.com/repos/CCI-MOC/hil/pulls/comments/110037799","pull_request_review_id":31180737,"id":110037799,"diff_hunk":"@@ -326,12 +326,12 @@ def test_node_connect_network_error(self):\n \n     def test_node_detach_network(self):\n         C.node.connect_network('node-04', 'eth0', 'net-04', 'vlan/native')\n-        time.sleep(1)\n+        time.sleep(2)  # To avoid a potential race condition\n         assert C.node.detach_network('node-04', 'eth0', 'net-04') is None\n \n     def test_node_detach_network_error(self):\n         C.node.connect_network('node-04', 'eth0', 'net-04', 'vlan/native')\n-        time.sleep(1)\n+        time.sleep(2)  # To avoid a potential race condition","path":"tests/unit/client.py","position":null,"original_position":11,"commit_id":"d6e0247f389fb89225bb427ade07d704ff4f0c67","original_commit_id":"d6e0247f389fb89225bb427ade07d704ff4f0c67","user":{"login":"zenhack","id":883774,"avatar_url":"https://avatars1.githubusercontent.com/u/883774?v=3","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"body":"Clarification: Nothing you pass to sleep is going to eliminate the race condition. What I'm looking for is (1) a value that's big enough that failures will be rare, and (2) a comment that calls attention to the fact that there *is* a race condition. This seems to imply that the race condition is elimnated by the call to sleep, which is not true.","created_at":"2017-04-05T21:57:00Z","updated_at":"2017-04-05T21:57:00Z","html_url":"https://github.com/CCI-MOC/hil/pull/617#discussion_r110037799","pull_request_url":"https://api.github.com/repos/CCI-MOC/hil/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/CCI-MOC/hil/pulls/comments/110037799"},"html":{"href":"https://github.com/CCI-MOC/hil/pull/617#discussion_r110037799"},"pull_request":{"href":"https://api.github.com/repos/CCI-MOC/hil/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/CCI-MOC/hil/pulls/617","id":74405271,"html_url":"https://github.com/CCI-MOC/hil/pull/617","diff_url":"https://github.com/CCI-MOC/hil/pull/617.diff","patch_url":"https://github.com/CCI-MOC/hil/pull/617.patch","issue_url":"https://api.github.com/repos/CCI-MOC/hil/issues/617","number":617,"state":"open","locked":false,"title":"Client Library HIL | query calls","user":{"login":"SahilTikale","id":2398718,"avatar_url":"https://avatars2.githubusercontent.com/u/2398718?v=3","gravatar_id":"","url":"https://api.github.com/users/SahilTikale","html_url":"https://github.com/SahilTikale","followers_url":"https://api.github.com/users/SahilTikale/followers","following_url":"https://api.github.com/users/SahilTikale/following{/other_user}","gists_url":"https://api.github.com/users/SahilTikale/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTikale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTikale/subscriptions","organizations_url":"https://api.github.com/users/SahilTikale/orgs","repos_url":"https://api.github.com/users/SahilTikale/repos","events_url":"https://api.github.com/users/SahilTikale/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTikale/received_events","type":"User","site_admin":false},"body":"Current PR, includes the basic code structure required to built a client library for HIL.\nIt also includes client library support for all query calls.\n\nStill pending:\nUnit tests for the new code.\nMaking correspondng cli calls to go via Client library. \n","created_at":"2016-06-20T08:23:16Z","updated_at":"2017-04-05T21:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3d0ae2d77566baa5b41613b13aecb92f471fec5","assignee":{"login":"SahilTikale","id":2398718,"avatar_url":"https://avatars2.githubusercontent.com/u/2398718?v=3","gravatar_id":"","url":"https://api.github.com/users/SahilTikale","html_url":"https://github.com/SahilTikale","followers_url":"https://api.github.com/users/SahilTikale/followers","following_url":"https://api.github.com/users/SahilTikale/following{/other_user}","gists_url":"https://api.github.com/users/SahilTikale/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTikale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTikale/subscriptions","organizations_url":"https://api.github.com/users/SahilTikale/orgs","repos_url":"https://api.github.com/users/SahilTikale/repos","events_url":"https://api.github.com/users/SahilTikale/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTikale/received_events","type":"User","site_admin":false},"assignees":[{"login":"SahilTikale","id":2398718,"avatar_url":"https://avatars2.githubusercontent.com/u/2398718?v=3","gravatar_id":"","url":"https://api.github.com/users/SahilTikale","html_url":"https://github.com/SahilTikale","followers_url":"https://api.github.com/users/SahilTikale/followers","following_url":"https://api.github.com/users/SahilTikale/following{/other_user}","gists_url":"https://api.github.com/users/SahilTikale/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTikale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTikale/subscriptions","organizations_url":"https://api.github.com/users/SahilTikale/orgs","repos_url":"https://api.github.com/users/SahilTikale/repos","events_url":"https://api.github.com/users/SahilTikale/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTikale/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CCI-MOC/hil/pulls/617/commits","review_comments_url":"https://api.github.com/repos/CCI-MOC/hil/pulls/617/comments","review_comment_url":"https://api.github.com/repos/CCI-MOC/hil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CCI-MOC/hil/issues/617/comments","statuses_url":"https://api.github.com/repos/CCI-MOC/hil/statuses/d6e0247f389fb89225bb427ade07d704ff4f0c67","head":{"label":"SahilTikale:HILclientlib-querycalls","ref":"HILclientlib-querycalls","sha":"d6e0247f389fb89225bb427ade07d704ff4f0c67","user":{"login":"SahilTikale","id":2398718,"avatar_url":"https://avatars2.githubusercontent.com/u/2398718?v=3","gravatar_id":"","url":"https://api.github.com/users/SahilTikale","html_url":"https://github.com/SahilTikale","followers_url":"https://api.github.com/users/SahilTikale/followers","following_url":"https://api.github.com/users/SahilTikale/following{/other_user}","gists_url":"https://api.github.com/users/SahilTikale/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTikale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTikale/subscriptions","organizations_url":"https://api.github.com/users/SahilTikale/orgs","repos_url":"https://api.github.com/users/SahilTikale/repos","events_url":"https://api.github.com/users/SahilTikale/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTikale/received_events","type":"User","site_admin":false},"repo":{"id":35552937,"name":"hil","full_name":"SahilTikale/hil","owner":{"login":"SahilTikale","id":2398718,"avatar_url":"https://avatars2.githubusercontent.com/u/2398718?v=3","gravatar_id":"","url":"https://api.github.com/users/SahilTikale","html_url":"https://github.com/SahilTikale","followers_url":"https://api.github.com/users/SahilTikale/followers","following_url":"https://api.github.com/users/SahilTikale/following{/other_user}","gists_url":"https://api.github.com/users/SahilTikale/gists{/gist_id}","starred_url":"https://api.github.com/users/SahilTikale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SahilTikale/subscriptions","organizations_url":"https://api.github.com/users/SahilTikale/orgs","repos_url":"https://api.github.com/users/SahilTikale/repos","events_url":"https://api.github.com/users/SahilTikale/events{/privacy}","received_events_url":"https://api.github.com/users/SahilTikale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SahilTikale/hil","description":null,"fork":true,"url":"https://api.github.com/repos/SahilTikale/hil","forks_url":"https://api.github.com/repos/SahilTikale/hil/forks","keys_url":"https://api.github.com/repos/SahilTikale/hil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SahilTikale/hil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SahilTikale/hil/teams","hooks_url":"https://api.github.com/repos/SahilTikale/hil/hooks","issue_events_url":"https://api.github.com/repos/SahilTikale/hil/issues/events{/number}","events_url":"https://api.github.com/repos/SahilTikale/hil/events","assignees_url":"https://api.github.com/repos/SahilTikale/hil/assignees{/user}","branches_url":"https://api.github.com/repos/SahilTikale/hil/branches{/branch}","tags_url":"https://api.github.com/repos/SahilTikale/hil/tags","blobs_url":"https://api.github.com/repos/SahilTikale/hil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SahilTikale/hil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SahilTikale/hil/git/refs{/sha}","trees_url":"https://api.github.com/repos/SahilTikale/hil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SahilTikale/hil/statuses/{sha}","languages_url":"https://api.github.com/repos/SahilTikale/hil/languages","stargazers_url":"https://api.github.com/repos/SahilTikale/hil/stargazers","contributors_url":"https://api.github.com/repos/SahilTikale/hil/contributors","subscribers_url":"https://api.github.com/repos/SahilTikale/hil/subscribers","subscription_url":"https://api.github.com/repos/SahilTikale/hil/subscription","commits_url":"https://api.github.com/repos/SahilTikale/hil/commits{/sha}","git_commits_url":"https://api.github.com/repos/SahilTikale/hil/git/commits{/sha}","comments_url":"https://api.github.com/repos/SahilTikale/hil/comments{/number}","issue_comment_url":"https://api.github.com/repos/SahilTikale/hil/issues/comments{/number}","contents_url":"https://api.github.com/repos/SahilTikale/hil/contents/{+path}","compare_url":"https://api.github.com/repos/SahilTikale/hil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SahilTikale/hil/merges","archive_url":"https://api.github.com/repos/SahilTikale/hil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SahilTikale/hil/downloads","issues_url":"https://api.github.com/repos/SahilTikale/hil/issues{/number}","pulls_url":"https://api.github.com/repos/SahilTikale/hil/pulls{/number}","milestones_url":"https://api.github.com/repos/SahilTikale/hil/milestones{/number}","notifications_url":"https://api.github.com/repos/SahilTikale/hil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SahilTikale/hil/labels{/name}","releases_url":"https://api.github.com/repos/SahilTikale/hil/releases{/id}","deployments_url":"https://api.github.com/repos/SahilTikale/hil/deployments","created_at":"2015-05-13T14:11:46Z","updated_at":"2016-11-07T15:50:34Z","pushed_at":"2017-04-05T21:15:46Z","git_url":"git://github.com/SahilTikale/hil.git","ssh_url":"git@github.com:SahilTikale/hil.git","clone_url":"https://github.com/SahilTikale/hil.git","svn_url":"https://github.com/SahilTikale/hil","homepage":null,"size":2997,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CCI-MOC:master","ref":"master","sha":"21ecab246c69819c113343a78e643d0962aab205","user":{"login":"CCI-MOC","id":3578683,"avatar_url":"https://avatars2.githubusercontent.com/u/3578683?v=3","gravatar_id":"","url":"https://api.github.com/users/CCI-MOC","html_url":"https://github.com/CCI-MOC","followers_url":"https://api.github.com/users/CCI-MOC/followers","following_url":"https://api.github.com/users/CCI-MOC/following{/other_user}","gists_url":"https://api.github.com/users/CCI-MOC/gists{/gist_id}","starred_url":"https://api.github.com/users/CCI-MOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCI-MOC/subscriptions","organizations_url":"https://api.github.com/users/CCI-MOC/orgs","repos_url":"https://api.github.com/users/CCI-MOC/repos","events_url":"https://api.github.com/users/CCI-MOC/events{/privacy}","received_events_url":"https://api.github.com/users/CCI-MOC/received_events","type":"Organization","site_admin":false},"repo":{"id":16487339,"name":"hil","full_name":"CCI-MOC/hil","owner":{"login":"CCI-MOC","id":3578683,"avatar_url":"https://avatars2.githubusercontent.com/u/3578683?v=3","gravatar_id":"","url":"https://api.github.com/users/CCI-MOC","html_url":"https://github.com/CCI-MOC","followers_url":"https://api.github.com/users/CCI-MOC/followers","following_url":"https://api.github.com/users/CCI-MOC/following{/other_user}","gists_url":"https://api.github.com/users/CCI-MOC/gists{/gist_id}","starred_url":"https://api.github.com/users/CCI-MOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCI-MOC/subscriptions","organizations_url":"https://api.github.com/users/CCI-MOC/orgs","repos_url":"https://api.github.com/users/CCI-MOC/repos","events_url":"https://api.github.com/users/CCI-MOC/events{/privacy}","received_events_url":"https://api.github.com/users/CCI-MOC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CCI-MOC/hil","description":"Hardware Isolation Layer, formerly Hardware as a Service","fork":false,"url":"https://api.github.com/repos/CCI-MOC/hil","forks_url":"https://api.github.com/repos/CCI-MOC/hil/forks","keys_url":"https://api.github.com/repos/CCI-MOC/hil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CCI-MOC/hil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CCI-MOC/hil/teams","hooks_url":"https://api.github.com/repos/CCI-MOC/hil/hooks","issue_events_url":"https://api.github.com/repos/CCI-MOC/hil/issues/events{/number}","events_url":"https://api.github.com/repos/CCI-MOC/hil/events","assignees_url":"https://api.github.com/repos/CCI-MOC/hil/assignees{/user}","branches_url":"https://api.github.com/repos/CCI-MOC/hil/branches{/branch}","tags_url":"https://api.github.com/repos/CCI-MOC/hil/tags","blobs_url":"https://api.github.com/repos/CCI-MOC/hil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CCI-MOC/hil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CCI-MOC/hil/git/refs{/sha}","trees_url":"https://api.github.com/repos/CCI-MOC/hil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CCI-MOC/hil/statuses/{sha}","languages_url":"https://api.github.com/repos/CCI-MOC/hil/languages","stargazers_url":"https://api.github.com/repos/CCI-MOC/hil/stargazers","contributors_url":"https://api.github.com/repos/CCI-MOC/hil/contributors","subscribers_url":"https://api.github.com/repos/CCI-MOC/hil/subscribers","subscription_url":"https://api.github.com/repos/CCI-MOC/hil/subscription","commits_url":"https://api.github.com/repos/CCI-MOC/hil/commits{/sha}","git_commits_url":"https://api.github.com/repos/CCI-MOC/hil/git/commits{/sha}","comments_url":"https://api.github.com/repos/CCI-MOC/hil/comments{/number}","issue_comment_url":"https://api.github.com/repos/CCI-MOC/hil/issues/comments{/number}","contents_url":"https://api.github.com/repos/CCI-MOC/hil/contents/{+path}","compare_url":"https://api.github.com/repos/CCI-MOC/hil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CCI-MOC/hil/merges","archive_url":"https://api.github.com/repos/CCI-MOC/hil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CCI-MOC/hil/downloads","issues_url":"https://api.github.com/repos/CCI-MOC/hil/issues{/number}","pulls_url":"https://api.github.com/repos/CCI-MOC/hil/pulls{/number}","milestones_url":"https://api.github.com/repos/CCI-MOC/hil/milestones{/number}","notifications_url":"https://api.github.com/repos/CCI-MOC/hil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CCI-MOC/hil/labels{/name}","releases_url":"https://api.github.com/repos/CCI-MOC/hil/releases{/id}","deployments_url":"https://api.github.com/repos/CCI-MOC/hil/deployments","created_at":"2014-02-03T17:48:01Z","updated_at":"2017-01-11T21:06:44Z","pushed_at":"2017-04-05T21:15:47Z","git_url":"git://github.com/CCI-MOC/hil.git","ssh_url":"git@github.com:CCI-MOC/hil.git","clone_url":"https://github.com/CCI-MOC/hil.git","svn_url":"https://github.com/CCI-MOC/hil","homepage":"","size":2829,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":153,"forks":42,"open_issues":153,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CCI-MOC/hil/pulls/617"},"html":{"href":"https://github.com/CCI-MOC/hil/pull/617"},"issue":{"href":"https://api.github.com/repos/CCI-MOC/hil/issues/617"},"comments":{"href":"https://api.github.com/repos/CCI-MOC/hil/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/CCI-MOC/hil/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/CCI-MOC/hil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CCI-MOC/hil/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/CCI-MOC/hil/statuses/d6e0247f389fb89225bb427ade07d704ff4f0c67"}}}}
{"actor":{"display_login":"zenhack"}}