{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/69","id":117562137,"html_url":"https://github.com/glimmerjs/glimmer-application/pull/69","diff_url":"https://github.com/glimmerjs/glimmer-application/pull/69.diff","patch_url":"https://github.com/glimmerjs/glimmer-application/pull/69.patch","issue_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/69","number":69,"state":"closed","locked":false,"title":"Clean up testing","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars3.githubusercontent.com/u/29122?v=3","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"body":"This PR attempts to clean up tests as follows:\r\n\r\n* By moving TemplateMeta’s definition to @glimmer/component, we can make @glimmer/component a dependency of @glimmer/application (instead of the other way around). (see #64).\r\n\r\n* It introduces a new dependency on @glimmer/application-test-helpers, a new package that was extracted from both @glimmer/application and @glimmer/component.\r\n\r\nThis PR corresponds with https://github.com/glimmerjs/glimmer-component/pull/56, which should be merged first.\r\n","created_at":"2017-04-25T19:27:50Z","updated_at":"2017-05-05T20:43:26Z","closed_at":"2017-05-05T20:43:26Z","merged_at":"2017-05-05T20:43:25Z","merge_commit_sha":"503884139cd23d219fc1295c17fb8440b3097d37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/69/commits","review_comments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/69/comments","review_comment_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/69/comments","statuses_url":"https://api.github.com/repos/glimmerjs/glimmer-application/statuses/4d85d6e50e8dc7af15ac22a1d0af52d449d0cde3","head":{"label":"glimmerjs:test-helpers","ref":"test-helpers","sha":"4d85d6e50e8dc7af15ac22a1d0af52d449d0cde3","user":{"login":"glimmerjs","id":24946286,"avatar_url":"https://avatars3.githubusercontent.com/u/24946286?v=3","gravatar_id":"","url":"https://api.github.com/users/glimmerjs","html_url":"https://github.com/glimmerjs","followers_url":"https://api.github.com/users/glimmerjs/followers","following_url":"https://api.github.com/users/glimmerjs/following{/other_user}","gists_url":"https://api.github.com/users/glimmerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/glimmerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimmerjs/subscriptions","organizations_url":"https://api.github.com/users/glimmerjs/orgs","repos_url":"https://api.github.com/users/glimmerjs/repos","events_url":"https://api.github.com/users/glimmerjs/events{/privacy}","received_events_url":"https://api.github.com/users/glimmerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":80530646,"name":"glimmer-application","full_name":"glimmerjs/glimmer-application","owner":{"login":"glimmerjs","id":24946286,"avatar_url":"https://avatars3.githubusercontent.com/u/24946286?v=3","gravatar_id":"","url":"https://api.github.com/users/glimmerjs","html_url":"https://github.com/glimmerjs","followers_url":"https://api.github.com/users/glimmerjs/followers","following_url":"https://api.github.com/users/glimmerjs/following{/other_user}","gists_url":"https://api.github.com/users/glimmerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/glimmerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimmerjs/subscriptions","organizations_url":"https://api.github.com/users/glimmerjs/orgs","repos_url":"https://api.github.com/users/glimmerjs/repos","events_url":"https://api.github.com/users/glimmerjs/events{/privacy}","received_events_url":"https://api.github.com/users/glimmerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glimmerjs/glimmer-application","description":null,"fork":false,"url":"https://api.github.com/repos/glimmerjs/glimmer-application","forks_url":"https://api.github.com/repos/glimmerjs/glimmer-application/forks","keys_url":"https://api.github.com/repos/glimmerjs/glimmer-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glimmerjs/glimmer-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glimmerjs/glimmer-application/teams","hooks_url":"https://api.github.com/repos/glimmerjs/glimmer-application/hooks","issue_events_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/events{/number}","events_url":"https://api.github.com/repos/glimmerjs/glimmer-application/events","assignees_url":"https://api.github.com/repos/glimmerjs/glimmer-application/assignees{/user}","branches_url":"https://api.github.com/repos/glimmerjs/glimmer-application/branches{/branch}","tags_url":"https://api.github.com/repos/glimmerjs/glimmer-application/tags","blobs_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glimmerjs/glimmer-application/statuses/{sha}","languages_url":"https://api.github.com/repos/glimmerjs/glimmer-application/languages","stargazers_url":"https://api.github.com/repos/glimmerjs/glimmer-application/stargazers","contributors_url":"https://api.github.com/repos/glimmerjs/glimmer-application/contributors","subscribers_url":"https://api.github.com/repos/glimmerjs/glimmer-application/subscribers","subscription_url":"https://api.github.com/repos/glimmerjs/glimmer-application/subscription","commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/glimmerjs/glimmer-application/contents/{+path}","compare_url":"https://api.github.com/repos/glimmerjs/glimmer-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glimmerjs/glimmer-application/merges","archive_url":"https://api.github.com/repos/glimmerjs/glimmer-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glimmerjs/glimmer-application/downloads","issues_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues{/number}","pulls_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls{/number}","milestones_url":"https://api.github.com/repos/glimmerjs/glimmer-application/milestones{/number}","notifications_url":"https://api.github.com/repos/glimmerjs/glimmer-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glimmerjs/glimmer-application/labels{/name}","releases_url":"https://api.github.com/repos/glimmerjs/glimmer-application/releases{/id}","deployments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/deployments","created_at":"2017-01-31T15:01:27Z","updated_at":"2017-04-23T03:01:13Z","pushed_at":"2017-05-05T20:43:25Z","git_url":"git://github.com/glimmerjs/glimmer-application.git","ssh_url":"git@github.com:glimmerjs/glimmer-application.git","clone_url":"https://github.com/glimmerjs/glimmer-application.git","svn_url":"https://github.com/glimmerjs/glimmer-application","homepage":null,"size":210,"stargazers_count":29,"watchers_count":29,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":19,"forks":14,"open_issues":19,"watchers":29,"default_branch":"master"}},"base":{"label":"glimmerjs:master","ref":"master","sha":"37f25815ffe040c9e4c488b8e08c5fa75aae94d6","user":{"login":"glimmerjs","id":24946286,"avatar_url":"https://avatars3.githubusercontent.com/u/24946286?v=3","gravatar_id":"","url":"https://api.github.com/users/glimmerjs","html_url":"https://github.com/glimmerjs","followers_url":"https://api.github.com/users/glimmerjs/followers","following_url":"https://api.github.com/users/glimmerjs/following{/other_user}","gists_url":"https://api.github.com/users/glimmerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/glimmerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimmerjs/subscriptions","organizations_url":"https://api.github.com/users/glimmerjs/orgs","repos_url":"https://api.github.com/users/glimmerjs/repos","events_url":"https://api.github.com/users/glimmerjs/events{/privacy}","received_events_url":"https://api.github.com/users/glimmerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":80530646,"name":"glimmer-application","full_name":"glimmerjs/glimmer-application","owner":{"login":"glimmerjs","id":24946286,"avatar_url":"https://avatars3.githubusercontent.com/u/24946286?v=3","gravatar_id":"","url":"https://api.github.com/users/glimmerjs","html_url":"https://github.com/glimmerjs","followers_url":"https://api.github.com/users/glimmerjs/followers","following_url":"https://api.github.com/users/glimmerjs/following{/other_user}","gists_url":"https://api.github.com/users/glimmerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/glimmerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimmerjs/subscriptions","organizations_url":"https://api.github.com/users/glimmerjs/orgs","repos_url":"https://api.github.com/users/glimmerjs/repos","events_url":"https://api.github.com/users/glimmerjs/events{/privacy}","received_events_url":"https://api.github.com/users/glimmerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glimmerjs/glimmer-application","description":null,"fork":false,"url":"https://api.github.com/repos/glimmerjs/glimmer-application","forks_url":"https://api.github.com/repos/glimmerjs/glimmer-application/forks","keys_url":"https://api.github.com/repos/glimmerjs/glimmer-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glimmerjs/glimmer-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glimmerjs/glimmer-application/teams","hooks_url":"https://api.github.com/repos/glimmerjs/glimmer-application/hooks","issue_events_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/events{/number}","events_url":"https://api.github.com/repos/glimmerjs/glimmer-application/events","assignees_url":"https://api.github.com/repos/glimmerjs/glimmer-application/assignees{/user}","branches_url":"https://api.github.com/repos/glimmerjs/glimmer-application/branches{/branch}","tags_url":"https://api.github.com/repos/glimmerjs/glimmer-application/tags","blobs_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glimmerjs/glimmer-application/statuses/{sha}","languages_url":"https://api.github.com/repos/glimmerjs/glimmer-application/languages","stargazers_url":"https://api.github.com/repos/glimmerjs/glimmer-application/stargazers","contributors_url":"https://api.github.com/repos/glimmerjs/glimmer-application/contributors","subscribers_url":"https://api.github.com/repos/glimmerjs/glimmer-application/subscribers","subscription_url":"https://api.github.com/repos/glimmerjs/glimmer-application/subscription","commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/glimmerjs/glimmer-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/glimmerjs/glimmer-application/contents/{+path}","compare_url":"https://api.github.com/repos/glimmerjs/glimmer-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glimmerjs/glimmer-application/merges","archive_url":"https://api.github.com/repos/glimmerjs/glimmer-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glimmerjs/glimmer-application/downloads","issues_url":"https://api.github.com/repos/glimmerjs/glimmer-application/issues{/number}","pulls_url":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls{/number}","milestones_url":"https://api.github.com/repos/glimmerjs/glimmer-application/milestones{/number}","notifications_url":"https://api.github.com/repos/glimmerjs/glimmer-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glimmerjs/glimmer-application/labels{/name}","releases_url":"https://api.github.com/repos/glimmerjs/glimmer-application/releases{/id}","deployments_url":"https://api.github.com/repos/glimmerjs/glimmer-application/deployments","created_at":"2017-01-31T15:01:27Z","updated_at":"2017-04-23T03:01:13Z","pushed_at":"2017-05-05T20:43:25Z","git_url":"git://github.com/glimmerjs/glimmer-application.git","ssh_url":"git@github.com:glimmerjs/glimmer-application.git","clone_url":"https://github.com/glimmerjs/glimmer-application.git","svn_url":"https://github.com/glimmerjs/glimmer-application","homepage":null,"size":210,"stargazers_count":29,"watchers_count":29,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":19,"forks":14,"open_issues":19,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/69"},"html":{"href":"https://github.com/glimmerjs/glimmer-application/pull/69"},"issue":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/69"},"comments":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/glimmerjs/glimmer-application/statuses/4d85d6e50e8dc7af15ac22a1d0af52d449d0cde3"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars3.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":7,"additions":130,"deletions":272,"changed_files":12}}
{"actor":{"display_login":"rwjblue"}}