{"action":"closed","number":364,"pull_request":{"url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/364","id":105760106,"html_url":"https://github.com/deeplearning4j/dl4j-examples/pull/364","diff_url":"https://github.com/deeplearning4j/dl4j-examples/pull/364.diff","patch_url":"https://github.com/deeplearning4j/dl4j-examples/pull/364.patch","issue_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/issues/364","number":364,"state":"closed","locked":false,"title":"Fix issue with sampleFromDistribution","user":{"login":"tswett","id":1332648,"avatar_url":"https://avatars.githubusercontent.com/u/1332648?v=3","gravatar_id":"","url":"https://api.github.com/users/tswett","html_url":"https://github.com/tswett","followers_url":"https://api.github.com/users/tswett/followers","following_url":"https://api.github.com/users/tswett/following{/other_user}","gists_url":"https://api.github.com/users/tswett/gists{/gist_id}","starred_url":"https://api.github.com/users/tswett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswett/subscriptions","organizations_url":"https://api.github.com/users/tswett/orgs","repos_url":"https://api.github.com/users/tswett/repos","events_url":"https://api.github.com/users/tswett/events{/privacy}","received_events_url":"https://api.github.com/users/tswett/received_events","type":"User","site_admin":false},"body":"In the GravesLSTMCharModellingExample class, the sampleFromDistribution method was assuming that its input distribution would sum to 1. However, rounding error means that this is not guaranteed to be the case. I had the demo crash because the randomly chosen number was 0.99999993, but the sum was only 0.99999985.\r\n\r\nFix this issue by having sampleFromDistribution try up to 10 times.\r\n\r\nI hereby release this contribution under the Apache License, Version 2.0.","created_at":"2017-02-11T17:17:17Z","updated_at":"2017-02-11T17:24:23Z","closed_at":"2017-02-11T17:24:23Z","merged_at":"2017-02-11T17:24:23Z","merge_commit_sha":"dec1745ff095b79c3128a8497512cebd627aaadc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/364/commits","review_comments_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/364/comments","review_comment_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/issues/364/comments","statuses_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/statuses/7e9a4d43f7b263519f02a71eaab0a0f81c947d57","head":{"label":"tswett:master","ref":"master","sha":"7e9a4d43f7b263519f02a71eaab0a0f81c947d57","user":{"login":"tswett","id":1332648,"avatar_url":"https://avatars.githubusercontent.com/u/1332648?v=3","gravatar_id":"","url":"https://api.github.com/users/tswett","html_url":"https://github.com/tswett","followers_url":"https://api.github.com/users/tswett/followers","following_url":"https://api.github.com/users/tswett/following{/other_user}","gists_url":"https://api.github.com/users/tswett/gists{/gist_id}","starred_url":"https://api.github.com/users/tswett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswett/subscriptions","organizations_url":"https://api.github.com/users/tswett/orgs","repos_url":"https://api.github.com/users/tswett/repos","events_url":"https://api.github.com/users/tswett/events{/privacy}","received_events_url":"https://api.github.com/users/tswett/received_events","type":"User","site_admin":false},"repo":{"id":81667935,"name":"dl4j-examples","full_name":"tswett/dl4j-examples","owner":{"login":"tswett","id":1332648,"avatar_url":"https://avatars.githubusercontent.com/u/1332648?v=3","gravatar_id":"","url":"https://api.github.com/users/tswett","html_url":"https://github.com/tswett","followers_url":"https://api.github.com/users/tswett/followers","following_url":"https://api.github.com/users/tswett/following{/other_user}","gists_url":"https://api.github.com/users/tswett/gists{/gist_id}","starred_url":"https://api.github.com/users/tswett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswett/subscriptions","organizations_url":"https://api.github.com/users/tswett/orgs","repos_url":"https://api.github.com/users/tswett/repos","events_url":"https://api.github.com/users/tswett/events{/privacy}","received_events_url":"https://api.github.com/users/tswett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tswett/dl4j-examples","description":"Deeplearning4j Examples (DL4J, DL4J Spark, DataVec)","fork":true,"url":"https://api.github.com/repos/tswett/dl4j-examples","forks_url":"https://api.github.com/repos/tswett/dl4j-examples/forks","keys_url":"https://api.github.com/repos/tswett/dl4j-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tswett/dl4j-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tswett/dl4j-examples/teams","hooks_url":"https://api.github.com/repos/tswett/dl4j-examples/hooks","issue_events_url":"https://api.github.com/repos/tswett/dl4j-examples/issues/events{/number}","events_url":"https://api.github.com/repos/tswett/dl4j-examples/events","assignees_url":"https://api.github.com/repos/tswett/dl4j-examples/assignees{/user}","branches_url":"https://api.github.com/repos/tswett/dl4j-examples/branches{/branch}","tags_url":"https://api.github.com/repos/tswett/dl4j-examples/tags","blobs_url":"https://api.github.com/repos/tswett/dl4j-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tswett/dl4j-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tswett/dl4j-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/tswett/dl4j-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tswett/dl4j-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/tswett/dl4j-examples/languages","stargazers_url":"https://api.github.com/repos/tswett/dl4j-examples/stargazers","contributors_url":"https://api.github.com/repos/tswett/dl4j-examples/contributors","subscribers_url":"https://api.github.com/repos/tswett/dl4j-examples/subscribers","subscription_url":"https://api.github.com/repos/tswett/dl4j-examples/subscription","commits_url":"https://api.github.com/repos/tswett/dl4j-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/tswett/dl4j-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/tswett/dl4j-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/tswett/dl4j-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/tswett/dl4j-examples/contents/{+path}","compare_url":"https://api.github.com/repos/tswett/dl4j-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tswett/dl4j-examples/merges","archive_url":"https://api.github.com/repos/tswett/dl4j-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tswett/dl4j-examples/downloads","issues_url":"https://api.github.com/repos/tswett/dl4j-examples/issues{/number}","pulls_url":"https://api.github.com/repos/tswett/dl4j-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/tswett/dl4j-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/tswett/dl4j-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tswett/dl4j-examples/labels{/name}","releases_url":"https://api.github.com/repos/tswett/dl4j-examples/releases{/id}","deployments_url":"https://api.github.com/repos/tswett/dl4j-examples/deployments","created_at":"2017-02-11T17:09:41Z","updated_at":"2017-02-11T17:09:44Z","pushed_at":"2017-02-11T17:15:24Z","git_url":"git://github.com/tswett/dl4j-examples.git","ssh_url":"git@github.com:tswett/dl4j-examples.git","clone_url":"https://github.com/tswett/dl4j-examples.git","svn_url":"https://github.com/tswett/dl4j-examples","homepage":"http://deeplearning4j.org/","size":145023,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deeplearning4j:master","ref":"master","sha":"8461d4a581f931b465bd974005657d3626142953","user":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars.githubusercontent.com/u/10988606?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"repo":{"id":41310523,"name":"dl4j-examples","full_name":"deeplearning4j/dl4j-examples","owner":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars.githubusercontent.com/u/10988606?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deeplearning4j/dl4j-examples","description":"Deeplearning4j Examples (DL4J, DL4J Spark, DataVec)","fork":false,"url":"https://api.github.com/repos/deeplearning4j/dl4j-examples","forks_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/forks","keys_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/teams","hooks_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/hooks","issue_events_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/issues/events{/number}","events_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/events","assignees_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/assignees{/user}","branches_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/branches{/branch}","tags_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/tags","blobs_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/languages","stargazers_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/stargazers","contributors_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/contributors","subscribers_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/subscribers","subscription_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/subscription","commits_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/contents/{+path}","compare_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/merges","archive_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/downloads","issues_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/issues{/number}","pulls_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/labels{/name}","releases_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/releases{/id}","deployments_url":"https://api.github.com/repos/deeplearning4j/dl4j-examples/deployments","created_at":"2015-08-24T15:17:43Z","updated_at":"2017-02-11T08:26:00Z","pushed_at":"2017-02-11T17:24:23Z","git_url":"git://github.com/deeplearning4j/dl4j-examples.git","ssh_url":"git@github.com:deeplearning4j/dl4j-examples.git","clone_url":"https://github.com/deeplearning4j/dl4j-examples.git","svn_url":"https://github.com/deeplearning4j/dl4j-examples","homepage":"http://deeplearning4j.org/","size":145023,"stargazers_count":312,"watchers_count":312,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":465,"mirror_url":null,"open_issues_count":43,"forks":465,"open_issues":43,"watchers":312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/364"},"html":{"href":"https://github.com/deeplearning4j/dl4j-examples/pull/364"},"issue":{"href":"https://api.github.com/repos/deeplearning4j/dl4j-examples/issues/364"},"comments":{"href":"https://api.github.com/repos/deeplearning4j/dl4j-examples/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deeplearning4j/dl4j-examples/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/deeplearning4j/dl4j-examples/statuses/7e9a4d43f7b263519f02a71eaab0a0f81c947d57"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"raver119","id":12250879,"avatar_url":"https://avatars.githubusercontent.com/u/12250879?v=3","gravatar_id":"","url":"https://api.github.com/users/raver119","html_url":"https://github.com/raver119","followers_url":"https://api.github.com/users/raver119/followers","following_url":"https://api.github.com/users/raver119/following{/other_user}","gists_url":"https://api.github.com/users/raver119/gists{/gist_id}","starred_url":"https://api.github.com/users/raver119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raver119/subscriptions","organizations_url":"https://api.github.com/users/raver119/orgs","repos_url":"https://api.github.com/users/raver119/repos","events_url":"https://api.github.com/users/raver119/events{/privacy}","received_events_url":"https://api.github.com/users/raver119/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"raver119"}}