{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/12957","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/12957/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/12957/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/12957/events","html_url":"https://github.com/xbmc/xbmc/pull/12957","id":268369701,"number":12957,"title":"[android] simplify versioning","user":{"login":"Rechi","id":5367567,"avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"labels":[{"id":278156361,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Android","name":"Android","color":"006b75","default":false},{"id":346616302,"url":"https://api.github.com/repos/xbmc/xbmc/labels/CMake","name":"CMake","color":"ccdb05","default":false},{"id":13087449,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1","default":false},{"id":400751192,"url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-25T11:57:34Z","updated_at":"2017-10-27T11:47:04Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/12957","html_url":"https://github.com/xbmc/xbmc/pull/12957","diff_url":"https://github.com/xbmc/xbmc/pull/12957.diff","patch_url":"https://github.com/xbmc/xbmc/pull/12957.patch"},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\nMake version bumps for android less error prone.\r\nAlso automatically increment versionCode on android for aarch64 by one. This is needed that aarch64 devices download the aarch64 version from the play store.\r\n<!--- Describe your change in detail -->\r\n\r\n## Motivation and Context\r\n@MartijnKaijser you will know\r\nFor the others, he accidentally increased versionCode for 17.5 to a greater number then the versionCode for master.\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\n\r\n## How Has This Been Tested?\r\nchecked versionCode for arm and aarch64\r\n<!--- Please describe in detail how you tested your change -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc -->\r\n\r\n<!--## Screenshots (if appropriate):-->\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [x] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [x] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/339949559","html_url":"https://github.com/xbmc/xbmc/pull/12957#issuecomment-339949559","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/12957","id":339949559,"user":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars1.githubusercontent.com/u/907436?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"created_at":"2017-10-27T11:47:04Z","updated_at":"2017-10-27T11:47:04Z","author_association":"OWNER","body":"@Rechi would be nice if we would also get this in Krypton to prevent further fuck ups"}}
{"actor":{"display_login":"MartijnKaijser"}}