{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14420","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14420/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14420/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14420/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14420","id":205129742,"number":14420,"title":"d3-selection: Correct parent element/datum types for sub-selections","user":{"login":"John-Colvin","id":1867189,"avatar_url":"https://avatars3.githubusercontent.com/u/1867189?v=3","gravatar_id":"","url":"https://api.github.com/users/John-Colvin","html_url":"https://github.com/John-Colvin","followers_url":"https://api.github.com/users/John-Colvin/followers","following_url":"https://api.github.com/users/John-Colvin/following{/other_user}","gists_url":"https://api.github.com/users/John-Colvin/gists{/gist_id}","starred_url":"https://api.github.com/users/John-Colvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/John-Colvin/subscriptions","organizations_url":"https://api.github.com/users/John-Colvin/orgs","repos_url":"https://api.github.com/users/John-Colvin/repos","events_url":"https://api.github.com/users/John-Colvin/events{/privacy}","received_events_url":"https://api.github.com/users/John-Colvin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-02-03T11:07:40Z","updated_at":"2017-03-11T19:58:20Z","closed_at":"2017-03-11T00:28:07Z","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14420","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14420","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14420.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14420.patch"},"body":"Please fill in this template.\r\n\r\n- [x] Make your PR against the `master` branch.\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped#common-mistakes).\r\n- [x] Run `tsc` without errors.\r\n- [x] Run `npm run lint package-name` if a `tslint.json` is present.\r\n\r\nIf changing an existing definition:\r\n- [N/A] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>\r\n- [N/A] Increase the version number in the header if appropriate.\r\n- [N/A] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"../tslint.json\" }`.\r\n--------------\r\n\r\n`append` creates a new selection of elements that have the current selection as parents, so the parent element and data types should be set accordingly. The same applies to `insert`.\r\n\r\nedit: also added overloads to handle the `enter` selection case, where having the old parent types is the correct behaviour"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/285895788","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14420#issuecomment-285895788","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14420","id":285895788,"user":{"login":"tomwanzek","id":16323903,"avatar_url":"https://avatars2.githubusercontent.com/u/16323903?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwanzek","html_url":"https://github.com/tomwanzek","followers_url":"https://api.github.com/users/tomwanzek/followers","following_url":"https://api.github.com/users/tomwanzek/following{/other_user}","gists_url":"https://api.github.com/users/tomwanzek/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwanzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwanzek/subscriptions","organizations_url":"https://api.github.com/users/tomwanzek/orgs","repos_url":"https://api.github.com/users/tomwanzek/repos","events_url":"https://api.github.com/users/tomwanzek/events{/privacy}","received_events_url":"https://api.github.com/users/tomwanzek/received_events","type":"User","site_admin":false},"created_at":"2017-03-11T19:58:20Z","updated_at":"2017-03-11T19:58:20Z","body":"@mhegazy I know that you work extremely hard, that's why I said I appreciate the housekeeping effort 💯 .\r\n\r\nWhenever, something is clear I will certainly go with 👍 👎  or LGTM. For this one I was waiting on @John-Colvin for an example where JS works different than what the TS definitions would support.\r\nSo, my apologies for the pending mid-air PR status.\r\n\r\nI just pushed the reversal PR as #15121 for now. If you could merge it, that would be great\r\n\r\n@John-Colvin to re-open as necessary, could you first create an issue that shows a code snippet (or create a JS plunker) which would demonstrate that the JS implementation of D3 behaves differently than the definitions. Just ping me on the issue and we can take it from there.\r\n\r\nThanks, T\r\n\r\n"}}
{"actor":{"display_login":"tomwanzek"}}