{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/10289","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/10289/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10289/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/10289/events","html_url":"https://github.com/facebook/react-native/pull/10289","id":181731205,"number":10289,"title":"Offload NavigatorExperimental transition animations","user":{"login":"nickhudkins","id":299126,"avatar_url":"https://avatars.githubusercontent.com/u/299126?v=3","gravatar_id":"","url":"https://api.github.com/users/nickhudkins","html_url":"https://github.com/nickhudkins","followers_url":"https://api.github.com/users/nickhudkins/followers","following_url":"https://api.github.com/users/nickhudkins/following{/other_user}","gists_url":"https://api.github.com/users/nickhudkins/gists{/gist_id}","starred_url":"https://api.github.com/users/nickhudkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickhudkins/subscriptions","organizations_url":"https://api.github.com/users/nickhudkins/orgs","repos_url":"https://api.github.com/users/nickhudkins/repos","events_url":"https://api.github.com/users/nickhudkins/events{/privacy}","received_events_url":"https://api.github.com/users/nickhudkins/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":172176599,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2016-10-07T17:58:35Z","updated_at":"2017-01-17T01:09:32Z","closed_at":"2016-10-12T18:41:01Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10289","html_url":"https://github.com/facebook/react-native/pull/10289","diff_url":"https://github.com/facebook/react-native/pull/10289.diff","patch_url":"https://github.com/facebook/react-native/pull/10289.patch"},"body":"**Motivation**\n\nPerforming synchronous operations while a navigation transition are in progress, currently results in janky (http://n.hudk.in/hhwW) animations as the transitions are computed on the JS thread. Thanks to @janicduplessis work on NativeAnimated support, we can get silky smooth (http://n.hudk.in/hh66) transitions with limited effort!\n\n**Test plan**\n\nMy current test plan has been minimal. I would love for some assistance here. However, what I have done is run a small application that performs the following operation immediately after a push transition begins:\n\n```\n      fetch('https://jsonplaceholder.typicode.com/photos').then(async (resp) => {\n        const json = await resp.json();\n        for (var i=0; i < 500; i++) {\n          // Do something absurdly blocking.\n          JSON.stringify(json);\n        }\n        console.log('Finished!');\n      });\n```\n\nprior to the changes made in this PR the result looked like: http://n.hudk.in/hhwW\nand after: http://n.hudk.in/hh66\n\nThis PR includes #9253 and #9598\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/272996566","html_url":"https://github.com/facebook/react-native/pull/10289#issuecomment-272996566","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10289","id":272996566,"user":{"login":"booboothefool","id":13257645,"avatar_url":"https://avatars.githubusercontent.com/u/13257645?v=3","gravatar_id":"","url":"https://api.github.com/users/booboothefool","html_url":"https://github.com/booboothefool","followers_url":"https://api.github.com/users/booboothefool/followers","following_url":"https://api.github.com/users/booboothefool/following{/other_user}","gists_url":"https://api.github.com/users/booboothefool/gists{/gist_id}","starred_url":"https://api.github.com/users/booboothefool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booboothefool/subscriptions","organizations_url":"https://api.github.com/users/booboothefool/orgs","repos_url":"https://api.github.com/users/booboothefool/repos","events_url":"https://api.github.com/users/booboothefool/events{/privacy}","received_events_url":"https://api.github.com/users/booboothefool/received_events","type":"User","site_admin":false},"created_at":"2017-01-17T01:09:32Z","updated_at":"2017-01-17T01:09:32Z","body":"@dmhood Could you let me know exactly what you changed? I'm still unable to get it to work properly."}}
{"actor":{"display_login":"booboothefool"}}