{"action":"opened","number":75,"pull_request":{"url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/75","id":106040316,"html_url":"https://github.com/JuliaGeometry/GeometryTypes.jl/pull/75","diff_url":"https://github.com/JuliaGeometry/GeometryTypes.jl/pull/75.diff","patch_url":"https://github.com/JuliaGeometry/GeometryTypes.jl/pull/75.patch","issue_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/issues/75","number":75,"state":"open","locked":false,"title":"Minimal changes to enable import on v0.6","user":{"login":"rdeits","id":591886,"avatar_url":"https://avatars.githubusercontent.com/u/591886?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"body":"This is not ready for merge yet, but I just wanted to get a sense of what would be required to even import GeometryTypes in Julia v0.6-dev. \r\n\r\nThe tests don't all pass, because there seem to be issues with FixedSizeArrays `fsa_abstract()` like:\r\n\r\n```\r\ntype UnionAll has no field name\r\n  Stacktrace:\r\n   [1] fsa_abstract(...) at /Users/rdeits/.julia/v0.6/FixedSizeArrays/src/core.jl:44\r\n   [2] ndims(...) at /Users/rdeits/.julia/v0.6/FixedSizeArrays/src/core.jl:30\r\n   [3] Type(...) at /Users/rdeits/.julia/v0.6/FixedSizeArrays/src/constructors.jl:64\r\n   [4] macro expansion at /Users/rdeits/.julia/v0.6/GeometryTypes/test/gjk.jl:9 [inlined]\r\n```\r\n\r\nbut this at least fixes failures on import. \r\n\r\nThe primary change is that in Julia v0.6, if you have an abstract type:\r\n\r\n```julia\r\nabstract Foo{T}\r\n```\r\n\r\nthen you can't subtype from `Foo` (without the parameter). So this is an error:\r\n\r\n```julia\r\nabstract Bar <: Foo\r\n```\r\n\r\nbut this is still OK:\r\n\r\n```julia\r\nabstract Bar{T} <: Foo{T}\r\n```\r\n\r\nSee: https://github.com/JuliaLang/julia/issues/19414\r\n\r\nThe fix was to explicitly include the `N` and `T` parameters in the various Mesh types so that we can have `abstract AbstractMesh{N, T, VertT, FaceT} <: AbstractGeometry{N, T}` instead of `abstract AbstractMesh{VertT, FaceT} <: AbstractGeometry`\r\n\r\nNow that we have triangular dispatch in v0.6, it might be possible to do this in a more clever way. I'm not sure yet. \r\n","created_at":"2017-02-14T05:53:54Z","updated_at":"2017-02-14T05:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/75/commits","review_comments_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/75/comments","review_comment_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/issues/75/comments","statuses_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/statuses/d6c655dc536cdf0be7c547d99a4004b65e3811f9","head":{"label":"rdeits:v0.6-compatibility","ref":"v0.6-compatibility","sha":"d6c655dc536cdf0be7c547d99a4004b65e3811f9","user":{"login":"rdeits","id":591886,"avatar_url":"https://avatars.githubusercontent.com/u/591886?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"repo":{"id":81909785,"name":"GeometryTypes.jl","full_name":"rdeits/GeometryTypes.jl","owner":{"login":"rdeits","id":591886,"avatar_url":"https://avatars.githubusercontent.com/u/591886?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeits","html_url":"https://github.com/rdeits","followers_url":"https://api.github.com/users/rdeits/followers","following_url":"https://api.github.com/users/rdeits/following{/other_user}","gists_url":"https://api.github.com/users/rdeits/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeits/subscriptions","organizations_url":"https://api.github.com/users/rdeits/orgs","repos_url":"https://api.github.com/users/rdeits/repos","events_url":"https://api.github.com/users/rdeits/events{/privacy}","received_events_url":"https://api.github.com/users/rdeits/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdeits/GeometryTypes.jl","description":"Geometry types for Julia, based on FixedSizeArrays","fork":true,"url":"https://api.github.com/repos/rdeits/GeometryTypes.jl","forks_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/forks","keys_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/teams","hooks_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/hooks","issue_events_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/issues/events{/number}","events_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/events","assignees_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/assignees{/user}","branches_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/branches{/branch}","tags_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/tags","blobs_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/languages","stargazers_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/stargazers","contributors_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/contributors","subscribers_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/subscribers","subscription_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/subscription","commits_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/contents/{+path}","compare_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/merges","archive_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/downloads","issues_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/issues{/number}","pulls_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/labels{/name}","releases_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/releases{/id}","deployments_url":"https://api.github.com/repos/rdeits/GeometryTypes.jl/deployments","created_at":"2017-02-14T05:46:15Z","updated_at":"2017-02-14T05:46:16Z","pushed_at":"2017-02-14T05:46:26Z","git_url":"git://github.com/rdeits/GeometryTypes.jl.git","ssh_url":"git@github.com:rdeits/GeometryTypes.jl.git","clone_url":"https://github.com/rdeits/GeometryTypes.jl.git","svn_url":"https://github.com/rdeits/GeometryTypes.jl","homepage":"","size":406,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaGeometry:master","ref":"master","sha":"2df57243de3c8b702d97ec8ee6c062a3a2a76b8c","user":{"login":"JuliaGeometry","id":10924607,"avatar_url":"https://avatars.githubusercontent.com/u/10924607?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGeometry","html_url":"https://github.com/JuliaGeometry","followers_url":"https://api.github.com/users/JuliaGeometry/followers","following_url":"https://api.github.com/users/JuliaGeometry/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGeometry/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGeometry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGeometry/subscriptions","organizations_url":"https://api.github.com/users/JuliaGeometry/orgs","repos_url":"https://api.github.com/users/JuliaGeometry/repos","events_url":"https://api.github.com/users/JuliaGeometry/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGeometry/received_events","type":"Organization","site_admin":false},"repo":{"id":32356790,"name":"GeometryTypes.jl","full_name":"JuliaGeometry/GeometryTypes.jl","owner":{"login":"JuliaGeometry","id":10924607,"avatar_url":"https://avatars.githubusercontent.com/u/10924607?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaGeometry","html_url":"https://github.com/JuliaGeometry","followers_url":"https://api.github.com/users/JuliaGeometry/followers","following_url":"https://api.github.com/users/JuliaGeometry/following{/other_user}","gists_url":"https://api.github.com/users/JuliaGeometry/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaGeometry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaGeometry/subscriptions","organizations_url":"https://api.github.com/users/JuliaGeometry/orgs","repos_url":"https://api.github.com/users/JuliaGeometry/repos","events_url":"https://api.github.com/users/JuliaGeometry/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaGeometry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaGeometry/GeometryTypes.jl","description":"Geometry types for Julia, based on FixedSizeArrays","fork":false,"url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl","forks_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/forks","keys_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/teams","hooks_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/events","assignees_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/tags","blobs_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/subscription","commits_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/merges","archive_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/downloads","issues_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/deployments","created_at":"2015-03-16T22:28:22Z","updated_at":"2017-01-15T16:05:21Z","pushed_at":"2017-02-10T17:33:43Z","git_url":"git://github.com/JuliaGeometry/GeometryTypes.jl.git","ssh_url":"git@github.com:JuliaGeometry/GeometryTypes.jl.git","clone_url":"https://github.com/JuliaGeometry/GeometryTypes.jl.git","svn_url":"https://github.com/JuliaGeometry/GeometryTypes.jl","homepage":"","size":406,"stargazers_count":13,"watchers_count":13,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":20,"forks":9,"open_issues":20,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/75"},"html":{"href":"https://github.com/JuliaGeometry/GeometryTypes.jl/pull/75"},"issue":{"href":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/issues/75"},"comments":{"href":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaGeometry/GeometryTypes.jl/statuses/d6c655dc536cdf0be7c547d99a4004b65e3811f9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":25,"deletions":24,"changed_files":5}}
{"actor":{"display_login":"rdeits"}}