{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41380","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41380/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41380/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41380/events","html_url":"https://github.com/kubernetes/kubernetes/pull/41380","id":207417227,"number":41380,"title":"Fix issue: Improve Redis example #24930","user":{"login":"shouhong","id":13680226,"avatar_url":"https://avatars.githubusercontent.com/u/13680226?v=3","gravatar_id":"","url":"https://api.github.com/users/shouhong","html_url":"https://github.com/shouhong","followers_url":"https://api.github.com/users/shouhong/followers","following_url":"https://api.github.com/users/shouhong/following{/other_user}","gists_url":"https://api.github.com/users/shouhong/gists{/gist_id}","starred_url":"https://api.github.com/users/shouhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shouhong/subscriptions","organizations_url":"https://api.github.com/users/shouhong/orgs","repos_url":"https://api.github.com/users/shouhong/repos","events_url":"https://api.github.com/users/shouhong/events{/privacy}","received_events_url":"https://api.github.com/users/shouhong/received_events","type":"User","site_admin":false},"labels":[{"id":477397085,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"assignees":[{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-02-14T04:45:23Z","updated_at":"2017-02-14T09:17:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41380","html_url":"https://github.com/kubernetes/kubernetes/pull/41380","diff_url":"https://github.com/kubernetes/kubernetes/pull/41380.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/41380.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nImprove Redis example\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #24930\r\n\r\n**Special notes for your reviewer**:\r\nImprovements:\r\n1. Remove the usage of self-built redis image.\r\n2. Reduce the example files to only 2 yaml files.\r\n3. Simplify the redis cluster deployment steps from 6 to 2. \r\n\r\nDetailed changes:\r\n1. Delete image folder (No need use self-built redis image. Only use gcr.io/google_containers/redis:v1 image)\r\n2. Delete redis-proxy (Not used)\r\n3. Merge redis-master.yaml and redis-sentinel-service.yaml to redis-bootstrap.yaml\r\n4. Merge redis-controller.yaml and redis-sentinel-controller.yaml to redis-rc.yaml\r\n5. Modify README.md (Simplify the deployment steps from 6 to 2.)\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/279651177","html_url":"https://github.com/kubernetes/kubernetes/pull/41380#issuecomment-279651177","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41380","id":279651177,"user":{"login":"icambridge","id":196942,"avatar_url":"https://avatars.githubusercontent.com/u/196942?v=3","gravatar_id":"","url":"https://api.github.com/users/icambridge","html_url":"https://github.com/icambridge","followers_url":"https://api.github.com/users/icambridge/followers","following_url":"https://api.github.com/users/icambridge/following{/other_user}","gists_url":"https://api.github.com/users/icambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/icambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icambridge/subscriptions","organizations_url":"https://api.github.com/users/icambridge/orgs","repos_url":"https://api.github.com/users/icambridge/repos","events_url":"https://api.github.com/users/icambridge/events{/privacy}","received_events_url":"https://api.github.com/users/icambridge/received_events","type":"User","site_admin":false},"created_at":"2017-02-14T09:17:35Z","updated_at":"2017-02-14T09:17:35Z","body":"Looks good to me.\r\n\r\nI think you need to sign/fix your CLA issues before anyone else will review/merge this."}}
{"actor":{"display_login":"icambridge"}}