{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/10381","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/10381/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/10381/comments","events_url":"https://api.github.com/repos/apple/swift/issues/10381/events","html_url":"https://github.com/apple/swift/pull/10381","id":237013627,"number":10381,"title":"Don't add rpath to swift with statically linking","user":{"login":"keith","id":283886,"avatar_url":"https://avatars0.githubusercontent.com/u/283886?v=3","gravatar_id":"","url":"https://api.github.com/users/keith","html_url":"https://github.com/keith","followers_url":"https://api.github.com/users/keith/followers","following_url":"https://api.github.com/users/keith/following{/other_user}","gists_url":"https://api.github.com/users/keith/gists{/gist_id}","starred_url":"https://api.github.com/users/keith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith/subscriptions","organizations_url":"https://api.github.com/users/keith/orgs","repos_url":"https://api.github.com/users/keith/repos","events_url":"https://api.github.com/users/keith/events{/privacy}","received_events_url":"https://api.github.com/users/keith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-06-19T20:25:40Z","updated_at":"2017-06-20T03:27:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/10381","html_url":"https://github.com/apple/swift/pull/10381","diff_url":"https://github.com/apple/swift/pull/10381.diff","patch_url":"https://github.com/apple/swift/pull/10381.patch"},"body":"This updates the rpath linking logic to only add the rpath that points\r\nto the swift dylibs in the case that the libraries are not statically\r\nlinked into the binary.\r\n\r\nThis fix is marginally relevant to https://bugs.swift.org/browse/SR-1967, but does not solve the core problem here."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/309634664","html_url":"https://github.com/apple/swift/pull/10381#issuecomment-309634664","issue_url":"https://api.github.com/repos/apple/swift/issues/10381","id":309634664,"user":{"login":"keith","id":283886,"avatar_url":"https://avatars0.githubusercontent.com/u/283886?v=3","gravatar_id":"","url":"https://api.github.com/users/keith","html_url":"https://github.com/keith","followers_url":"https://api.github.com/users/keith/followers","following_url":"https://api.github.com/users/keith/following{/other_user}","gists_url":"https://api.github.com/users/keith/gists{/gist_id}","starred_url":"https://api.github.com/users/keith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keith/subscriptions","organizations_url":"https://api.github.com/users/keith/orgs","repos_url":"https://api.github.com/users/keith/repos","events_url":"https://api.github.com/users/keith/events{/privacy}","received_events_url":"https://api.github.com/users/keith/received_events","type":"User","site_admin":false},"created_at":"2017-06-20T03:27:50Z","updated_at":"2017-06-20T03:27:50Z","body":"I've just pushed a test for this. I would love some feedback on how I'm using `FileCheck` to validated the absence of `-rpath`. AFACIT there's no good way to do this. Really I want something like:\r\n\r\n```swift\r\n// SWIFT_STATIC-DAG-NOT: -rpath\r\n```\r\n\r\nInstead I'm using the `-implicit-check-not` flag, which works in this case it seems, but requires a more ordered list of arguments, rather than ignoring the order and using `-DAG` for all of these (since the order doesn't actually matter)"}}
{"actor":{"display_login":"keith"}}