{"action":"created","issue":{"url":"https://api.github.com/repos/Nemocas/Nemo.jl/issues/300","repository_url":"https://api.github.com/repos/Nemocas/Nemo.jl","labels_url":"https://api.github.com/repos/Nemocas/Nemo.jl/issues/300/labels{/name}","comments_url":"https://api.github.com/repos/Nemocas/Nemo.jl/issues/300/comments","events_url":"https://api.github.com/repos/Nemocas/Nemo.jl/issues/300/events","html_url":"https://github.com/Nemocas/Nemo.jl/issues/300","id":265211723,"number":300,"title":"Return type of canonical_unit","user":{"login":"thofma","id":11231648,"avatar_url":"https://avatars0.githubusercontent.com/u/11231648?v=4","gravatar_id":"","url":"https://api.github.com/users/thofma","html_url":"https://github.com/thofma","followers_url":"https://api.github.com/users/thofma/followers","following_url":"https://api.github.com/users/thofma/following{/other_user}","gists_url":"https://api.github.com/users/thofma/gists{/gist_id}","starred_url":"https://api.github.com/users/thofma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thofma/subscriptions","organizations_url":"https://api.github.com/users/thofma/orgs","repos_url":"https://api.github.com/users/thofma/repos","events_url":"https://api.github.com/users/thofma/events{/privacy}","received_events_url":"https://api.github.com/users/thofma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-13T08:41:05Z","updated_at":"2017-10-13T11:20:10Z","closed_at":null,"author_association":"NONE","body":"Currently `u = canonical_unit(r); r = mul!(r, r, u)` does not work generically, since for polynomials the canonical unit is an element of the base ring. We can either\r\n1) Make `canonical_unit(r)` return an element of `base_ring(r)` consistently or\r\n2) Demand that the polynomial interface also includes `mul!(::PolyElem{T}, PolyElem{T}, T)`.\r\n\r\nI personally prefer option 1."},"comment":{"url":"https://api.github.com/repos/Nemocas/Nemo.jl/issues/comments/336424411","html_url":"https://github.com/Nemocas/Nemo.jl/issues/300#issuecomment-336424411","issue_url":"https://api.github.com/repos/Nemocas/Nemo.jl/issues/300","id":336424411,"user":{"login":"wbhart","id":242598,"avatar_url":"https://avatars1.githubusercontent.com/u/242598?v=4","gravatar_id":"","url":"https://api.github.com/users/wbhart","html_url":"https://github.com/wbhart","followers_url":"https://api.github.com/users/wbhart/followers","following_url":"https://api.github.com/users/wbhart/following{/other_user}","gists_url":"https://api.github.com/users/wbhart/gists{/gist_id}","starred_url":"https://api.github.com/users/wbhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbhart/subscriptions","organizations_url":"https://api.github.com/users/wbhart/orgs","repos_url":"https://api.github.com/users/wbhart/repos","events_url":"https://api.github.com/users/wbhart/events{/privacy}","received_events_url":"https://api.github.com/users/wbhart/received_events","type":"User","site_admin":false},"created_at":"2017-10-13T11:20:10Z","updated_at":"2017-10-13T11:20:10Z","author_association":"NONE","body":"Yes, I prefer option 1. We should always explore all possibilities before\nadding further unsafe operations.\n\nOn 13 October 2017 at 10:41, thofma <notifications@github.com> wrote:\n\n> Currently u = canonical_unit(r); r = mul!(r, r, u) does not work\n> generically, since for polynomials the canonical unit is an element of the\n> base ring. We can either\n>\n>    1. Make canonical_unit(r) return an element of base_ring(r)\n>    consistently or\n>    2. Demand that the polynomial interface also includes mul!(::PolyElem{T},\n>    PolyElem{T}, T).\n>\n> I personally prefer option 1.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Nemocas/Nemo.jl/issues/300>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAOzpqnvXvoS5p0lWn3-YK7veqPjwP7yks5sryIigaJpZM4P4J7g>\n> .\n>\n"}}
{"actor":{"display_login":"wbhart"}}