{"action":"created","comment":{"url":"https://api.github.com/repos/celery/celery/pulls/comments/109835608","pull_request_review_id":30961776,"id":109835608,"diff_hunk":"@@ -281,6 +284,17 @@ def tick(self, event_t=event_t, min=min, heappop=heapq.heappop,\n                 return min(verify[0], max_interval)\n         return min(adjust(next_time_to_run) or max_interval, max_interval)\n \n+    def schedules_equal(self, a, b):\n+        if set(a.keys()) != set(b.keys()):\n+            return False\n+        for name, model in a.items():\n+            b_model = b.get(name)\n+            if not b_model:\n+                return False\n+            if model.schedule != b_model.schedule:","path":"celery/beat.py","position":30,"original_position":30,"commit_id":"dcf7eb993c73b6a20d248bce81d5dfd2d9ce4b12","original_commit_id":"dcf7eb993c73b6a20d248bce81d5dfd2d9ce4b12","user":{"login":"brianmay","id":112729,"avatar_url":"https://avatars0.githubusercontent.com/u/112729?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmay","html_url":"https://github.com/brianmay","followers_url":"https://api.github.com/users/brianmay/followers","following_url":"https://api.github.com/users/brianmay/following{/other_user}","gists_url":"https://api.github.com/users/brianmay/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmay/subscriptions","organizations_url":"https://api.github.com/users/brianmay/orgs","repos_url":"https://api.github.com/users/brianmay/repos","events_url":"https://api.github.com/users/brianmay/events{/privacy}","received_events_url":"https://api.github.com/users/brianmay/received_events","type":"User","site_admin":false},"body":"I believe the above code is fine.","created_at":"2017-04-05T06:02:23Z","updated_at":"2017-04-05T06:02:23Z","html_url":"https://github.com/celery/celery/pull/3958#discussion_r109835608","pull_request_url":"https://api.github.com/repos/celery/celery/pulls/3958","_links":{"self":{"href":"https://api.github.com/repos/celery/celery/pulls/comments/109835608"},"html":{"href":"https://github.com/celery/celery/pull/3958#discussion_r109835608"},"pull_request":{"href":"https://api.github.com/repos/celery/celery/pulls/3958"}}},"pull_request":{"url":"https://api.github.com/repos/celery/celery/pulls/3958","id":114294552,"html_url":"https://github.com/celery/celery/pull/3958","diff_url":"https://github.com/celery/celery/pull/3958.diff","patch_url":"https://github.com/celery/celery/pull/3958.patch","issue_url":"https://api.github.com/repos/celery/celery/issues/3958","number":3958,"state":"open","locked":false,"title":"Fix update tasks","user":{"login":"brianmay","id":112729,"avatar_url":"https://avatars0.githubusercontent.com/u/112729?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmay","html_url":"https://github.com/brianmay","followers_url":"https://api.github.com/users/brianmay/followers","following_url":"https://api.github.com/users/brianmay/following{/other_user}","gists_url":"https://api.github.com/users/brianmay/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmay/subscriptions","organizations_url":"https://api.github.com/users/brianmay/orgs","repos_url":"https://api.github.com/users/brianmay/repos","events_url":"https://api.github.com/users/brianmay/events{/privacy}","received_events_url":"https://api.github.com/users/brianmay/received_events","type":"User","site_admin":false},"body":"#3791 was improved and become #3890. This is an improvement on #3890, as it addresses some of the feedback supplied there.\r\n\r\nChecks if the heap is valid. If there are changes in scheduled tasks the heap is populated again.\r\n\r\nThis means, when using django-celery-beat, changes to the ``periodictask`` table are automatically detected without restarting celery.\r\n\r\nFixes celery/django-celery-beat#7\r\n\r\nI can squash/rebase/split/reformat/turn-into-a-penguin as required.","created_at":"2017-04-05T04:40:53Z","updated_at":"2017-04-05T06:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9c9dfd4a4858c3c9b23252ac08c308e809b7486","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/celery/celery/pulls/3958/commits","review_comments_url":"https://api.github.com/repos/celery/celery/pulls/3958/comments","review_comment_url":"https://api.github.com/repos/celery/celery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/celery/celery/issues/3958/comments","statuses_url":"https://api.github.com/repos/celery/celery/statuses/dcf7eb993c73b6a20d248bce81d5dfd2d9ce4b12","head":{"label":"brianmay:fix_update_tasks","ref":"fix_update_tasks","sha":"dcf7eb993c73b6a20d248bce81d5dfd2d9ce4b12","user":{"login":"brianmay","id":112729,"avatar_url":"https://avatars0.githubusercontent.com/u/112729?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmay","html_url":"https://github.com/brianmay","followers_url":"https://api.github.com/users/brianmay/followers","following_url":"https://api.github.com/users/brianmay/following{/other_user}","gists_url":"https://api.github.com/users/brianmay/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmay/subscriptions","organizations_url":"https://api.github.com/users/brianmay/orgs","repos_url":"https://api.github.com/users/brianmay/repos","events_url":"https://api.github.com/users/brianmay/events{/privacy}","received_events_url":"https://api.github.com/users/brianmay/received_events","type":"User","site_admin":false},"repo":{"id":87265948,"name":"celery","full_name":"brianmay/celery","owner":{"login":"brianmay","id":112729,"avatar_url":"https://avatars0.githubusercontent.com/u/112729?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmay","html_url":"https://github.com/brianmay","followers_url":"https://api.github.com/users/brianmay/followers","following_url":"https://api.github.com/users/brianmay/following{/other_user}","gists_url":"https://api.github.com/users/brianmay/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmay/subscriptions","organizations_url":"https://api.github.com/users/brianmay/orgs","repos_url":"https://api.github.com/users/brianmay/repos","events_url":"https://api.github.com/users/brianmay/events{/privacy}","received_events_url":"https://api.github.com/users/brianmay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianmay/celery","description":"Distributed Task Queue (development branch)","fork":true,"url":"https://api.github.com/repos/brianmay/celery","forks_url":"https://api.github.com/repos/brianmay/celery/forks","keys_url":"https://api.github.com/repos/brianmay/celery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianmay/celery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianmay/celery/teams","hooks_url":"https://api.github.com/repos/brianmay/celery/hooks","issue_events_url":"https://api.github.com/repos/brianmay/celery/issues/events{/number}","events_url":"https://api.github.com/repos/brianmay/celery/events","assignees_url":"https://api.github.com/repos/brianmay/celery/assignees{/user}","branches_url":"https://api.github.com/repos/brianmay/celery/branches{/branch}","tags_url":"https://api.github.com/repos/brianmay/celery/tags","blobs_url":"https://api.github.com/repos/brianmay/celery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianmay/celery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianmay/celery/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianmay/celery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianmay/celery/statuses/{sha}","languages_url":"https://api.github.com/repos/brianmay/celery/languages","stargazers_url":"https://api.github.com/repos/brianmay/celery/stargazers","contributors_url":"https://api.github.com/repos/brianmay/celery/contributors","subscribers_url":"https://api.github.com/repos/brianmay/celery/subscribers","subscription_url":"https://api.github.com/repos/brianmay/celery/subscription","commits_url":"https://api.github.com/repos/brianmay/celery/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianmay/celery/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianmay/celery/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianmay/celery/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianmay/celery/contents/{+path}","compare_url":"https://api.github.com/repos/brianmay/celery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianmay/celery/merges","archive_url":"https://api.github.com/repos/brianmay/celery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianmay/celery/downloads","issues_url":"https://api.github.com/repos/brianmay/celery/issues{/number}","pulls_url":"https://api.github.com/repos/brianmay/celery/pulls{/number}","milestones_url":"https://api.github.com/repos/brianmay/celery/milestones{/number}","notifications_url":"https://api.github.com/repos/brianmay/celery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianmay/celery/labels{/name}","releases_url":"https://api.github.com/repos/brianmay/celery/releases{/id}","deployments_url":"https://api.github.com/repos/brianmay/celery/deployments","created_at":"2017-04-05T04:30:00Z","updated_at":"2017-04-05T04:30:06Z","pushed_at":"2017-04-05T05:12:56Z","git_url":"git://github.com/brianmay/celery.git","ssh_url":"git@github.com:brianmay/celery.git","clone_url":"https://github.com/brianmay/celery.git","svn_url":"https://github.com/brianmay/celery","homepage":"http://celeryproject.org","size":45731,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"celery:master","ref":"master","sha":"522ef610ea17ae79695e995ddd82d034e8e8bc7a","user":{"login":"celery","id":319983,"avatar_url":"https://avatars1.githubusercontent.com/u/319983?v=3","gravatar_id":"","url":"https://api.github.com/users/celery","html_url":"https://github.com/celery","followers_url":"https://api.github.com/users/celery/followers","following_url":"https://api.github.com/users/celery/following{/other_user}","gists_url":"https://api.github.com/users/celery/gists{/gist_id}","starred_url":"https://api.github.com/users/celery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celery/subscriptions","organizations_url":"https://api.github.com/users/celery/orgs","repos_url":"https://api.github.com/users/celery/repos","events_url":"https://api.github.com/users/celery/events{/privacy}","received_events_url":"https://api.github.com/users/celery/received_events","type":"Organization","site_admin":false},"repo":{"id":184460,"name":"celery","full_name":"celery/celery","owner":{"login":"celery","id":319983,"avatar_url":"https://avatars1.githubusercontent.com/u/319983?v=3","gravatar_id":"","url":"https://api.github.com/users/celery","html_url":"https://github.com/celery","followers_url":"https://api.github.com/users/celery/followers","following_url":"https://api.github.com/users/celery/following{/other_user}","gists_url":"https://api.github.com/users/celery/gists{/gist_id}","starred_url":"https://api.github.com/users/celery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celery/subscriptions","organizations_url":"https://api.github.com/users/celery/orgs","repos_url":"https://api.github.com/users/celery/repos","events_url":"https://api.github.com/users/celery/events{/privacy}","received_events_url":"https://api.github.com/users/celery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/celery/celery","description":"Distributed Task Queue (development branch)","fork":false,"url":"https://api.github.com/repos/celery/celery","forks_url":"https://api.github.com/repos/celery/celery/forks","keys_url":"https://api.github.com/repos/celery/celery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/celery/celery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/celery/celery/teams","hooks_url":"https://api.github.com/repos/celery/celery/hooks","issue_events_url":"https://api.github.com/repos/celery/celery/issues/events{/number}","events_url":"https://api.github.com/repos/celery/celery/events","assignees_url":"https://api.github.com/repos/celery/celery/assignees{/user}","branches_url":"https://api.github.com/repos/celery/celery/branches{/branch}","tags_url":"https://api.github.com/repos/celery/celery/tags","blobs_url":"https://api.github.com/repos/celery/celery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/celery/celery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/celery/celery/git/refs{/sha}","trees_url":"https://api.github.com/repos/celery/celery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/celery/celery/statuses/{sha}","languages_url":"https://api.github.com/repos/celery/celery/languages","stargazers_url":"https://api.github.com/repos/celery/celery/stargazers","contributors_url":"https://api.github.com/repos/celery/celery/contributors","subscribers_url":"https://api.github.com/repos/celery/celery/subscribers","subscription_url":"https://api.github.com/repos/celery/celery/subscription","commits_url":"https://api.github.com/repos/celery/celery/commits{/sha}","git_commits_url":"https://api.github.com/repos/celery/celery/git/commits{/sha}","comments_url":"https://api.github.com/repos/celery/celery/comments{/number}","issue_comment_url":"https://api.github.com/repos/celery/celery/issues/comments{/number}","contents_url":"https://api.github.com/repos/celery/celery/contents/{+path}","compare_url":"https://api.github.com/repos/celery/celery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/celery/celery/merges","archive_url":"https://api.github.com/repos/celery/celery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/celery/celery/downloads","issues_url":"https://api.github.com/repos/celery/celery/issues{/number}","pulls_url":"https://api.github.com/repos/celery/celery/pulls{/number}","milestones_url":"https://api.github.com/repos/celery/celery/milestones{/number}","notifications_url":"https://api.github.com/repos/celery/celery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/celery/celery/labels{/name}","releases_url":"https://api.github.com/repos/celery/celery/releases{/id}","deployments_url":"https://api.github.com/repos/celery/celery/deployments","created_at":"2009-04-24T11:31:24Z","updated_at":"2017-04-04T16:24:32Z","pushed_at":"2017-04-05T05:12:57Z","git_url":"git://github.com/celery/celery.git","ssh_url":"git@github.com:celery/celery.git","clone_url":"https://github.com/celery/celery.git","svn_url":"https://github.com/celery/celery","homepage":"http://celeryproject.org","size":45730,"stargazers_count":6533,"watchers_count":6533,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2046,"mirror_url":null,"open_issues_count":363,"forks":2046,"open_issues":363,"watchers":6533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/celery/celery/pulls/3958"},"html":{"href":"https://github.com/celery/celery/pull/3958"},"issue":{"href":"https://api.github.com/repos/celery/celery/issues/3958"},"comments":{"href":"https://api.github.com/repos/celery/celery/issues/3958/comments"},"review_comments":{"href":"https://api.github.com/repos/celery/celery/pulls/3958/comments"},"review_comment":{"href":"https://api.github.com/repos/celery/celery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/celery/celery/pulls/3958/commits"},"statuses":{"href":"https://api.github.com/repos/celery/celery/statuses/dcf7eb993c73b6a20d248bce81d5dfd2d9ce4b12"}}}}
{"actor":{"display_login":"brianmay"}}