{"action":"created","comment":{"url":"https://api.github.com/repos/chain/chain/pulls/comments/123656153","pull_request_review_id":45882649,"id":123656153,"diff_hunk":"@@ -290,6 +290,19 @@ func main() {\n \t\topts = append(opts, enableMockHSM(db)...)\n \t\tchainlog.Printf(ctx, \"Launching as unconfigured Core.\")\n \t\th = core.RunUnconfigured(ctx, db, sdb, *listenAddr, opts...)\n+\n+\t\tgo func() {\n+\t\t\tticker := time.Tick(5 * time.Second)","path":"cmd/cored/main.go","position":6,"original_position":6,"commit_id":"3b6550a327dea43de30d42703d0216ba2a44a5bf","original_commit_id":"3b6550a327dea43de30d42703d0216ba2a44a5bf","user":{"login":"tessr","id":773524,"avatar_url":"https://avatars3.githubusercontent.com/u/773524?v=3","gravatar_id":"","url":"https://api.github.com/users/tessr","html_url":"https://github.com/tessr","followers_url":"https://api.github.com/users/tessr/followers","following_url":"https://api.github.com/users/tessr/following{/other_user}","gists_url":"https://api.github.com/users/tessr/gists{/gist_id}","starred_url":"https://api.github.com/users/tessr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessr/subscriptions","organizations_url":"https://api.github.com/users/tessr/orgs","repos_url":"https://api.github.com/users/tessr/repos","events_url":"https://api.github.com/users/tessr/events{/privacy}","received_events_url":"https://api.github.com/users/tessr/received_events","type":"User","site_admin":false},"body":"@kr oh, also, do you have an opinion on the right interval? I think 5 seconds might be a little long. (Maybe 1 second?)","created_at":"2017-06-23T01:24:40Z","updated_at":"2017-06-23T01:24:41Z","html_url":"https://github.com/chain/chain/pull/1373#discussion_r123656153","pull_request_url":"https://api.github.com/repos/chain/chain/pulls/1373","_links":{"self":{"href":"https://api.github.com/repos/chain/chain/pulls/comments/123656153"},"html":{"href":"https://github.com/chain/chain/pull/1373#discussion_r123656153"},"pull_request":{"href":"https://api.github.com/repos/chain/chain/pulls/1373"}}},"pull_request":{"url":"https://api.github.com/repos/chain/chain/pulls/1373","id":127113306,"html_url":"https://github.com/chain/chain/pull/1373","diff_url":"https://github.com/chain/chain/pull/1373.diff","patch_url":"https://github.com/chain/chain/pull/1373.patch","issue_url":"https://api.github.com/repos/chain/chain/issues/1373","number":1373,"state":"open","locked":false,"title":"cmd/cored: update unconfigured cores","user":{"login":"vickiniu","id":7269957,"avatar_url":"https://avatars3.githubusercontent.com/u/7269957?v=3","gravatar_id":"","url":"https://api.github.com/users/vickiniu","html_url":"https://github.com/vickiniu","followers_url":"https://api.github.com/users/vickiniu/followers","following_url":"https://api.github.com/users/vickiniu/following{/other_user}","gists_url":"https://api.github.com/users/vickiniu/gists{/gist_id}","starred_url":"https://api.github.com/users/vickiniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vickiniu/subscriptions","organizations_url":"https://api.github.com/users/vickiniu/orgs","repos_url":"https://api.github.com/users/vickiniu/repos","events_url":"https://api.github.com/users/vickiniu/events{/privacy}","received_events_url":"https://api.github.com/users/vickiniu/received_events","type":"User","site_admin":false},"body":"Adds goroutine for unconfigured cores to check for an updated config from sinkDB and exec themselves to update.\r\n\r\nFixes #1371 ","created_at":"2017-06-23T00:20:03Z","updated_at":"2017-06-23T01:24:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bced28ad72e3e37992d0c553ffda93da3b8efc55","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chain/chain/pulls/1373/commits","review_comments_url":"https://api.github.com/repos/chain/chain/pulls/1373/comments","review_comment_url":"https://api.github.com/repos/chain/chain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chain/chain/issues/1373/comments","statuses_url":"https://api.github.com/repos/chain/chain/statuses/3b6550a327dea43de30d42703d0216ba2a44a5bf","head":{"label":"chain:cluster_config","ref":"cluster_config","sha":"3b6550a327dea43de30d42703d0216ba2a44a5bf","user":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"repo":{"id":71740230,"name":"chain","full_name":"chain/chain","owner":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chain/chain","description":"Chain Core Developer Edition","fork":false,"url":"https://api.github.com/repos/chain/chain","forks_url":"https://api.github.com/repos/chain/chain/forks","keys_url":"https://api.github.com/repos/chain/chain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chain/chain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chain/chain/teams","hooks_url":"https://api.github.com/repos/chain/chain/hooks","issue_events_url":"https://api.github.com/repos/chain/chain/issues/events{/number}","events_url":"https://api.github.com/repos/chain/chain/events","assignees_url":"https://api.github.com/repos/chain/chain/assignees{/user}","branches_url":"https://api.github.com/repos/chain/chain/branches{/branch}","tags_url":"https://api.github.com/repos/chain/chain/tags","blobs_url":"https://api.github.com/repos/chain/chain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chain/chain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chain/chain/git/refs{/sha}","trees_url":"https://api.github.com/repos/chain/chain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chain/chain/statuses/{sha}","languages_url":"https://api.github.com/repos/chain/chain/languages","stargazers_url":"https://api.github.com/repos/chain/chain/stargazers","contributors_url":"https://api.github.com/repos/chain/chain/contributors","subscribers_url":"https://api.github.com/repos/chain/chain/subscribers","subscription_url":"https://api.github.com/repos/chain/chain/subscription","commits_url":"https://api.github.com/repos/chain/chain/commits{/sha}","git_commits_url":"https://api.github.com/repos/chain/chain/git/commits{/sha}","comments_url":"https://api.github.com/repos/chain/chain/comments{/number}","issue_comment_url":"https://api.github.com/repos/chain/chain/issues/comments{/number}","contents_url":"https://api.github.com/repos/chain/chain/contents/{+path}","compare_url":"https://api.github.com/repos/chain/chain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chain/chain/merges","archive_url":"https://api.github.com/repos/chain/chain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chain/chain/downloads","issues_url":"https://api.github.com/repos/chain/chain/issues{/number}","pulls_url":"https://api.github.com/repos/chain/chain/pulls{/number}","milestones_url":"https://api.github.com/repos/chain/chain/milestones{/number}","notifications_url":"https://api.github.com/repos/chain/chain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chain/chain/labels{/name}","releases_url":"https://api.github.com/repos/chain/chain/releases{/id}","deployments_url":"https://api.github.com/repos/chain/chain/deployments","created_at":"2016-10-24T01:12:26Z","updated_at":"2017-06-22T17:13:13Z","pushed_at":"2017-06-23T00:20:59Z","git_url":"git://github.com/chain/chain.git","ssh_url":"git@github.com:chain/chain.git","clone_url":"https://github.com/chain/chain.git","svn_url":"https://github.com/chain/chain","homepage":"https://chain.com","size":136224,"stargazers_count":964,"watchers_count":964,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":45,"forks":149,"open_issues":45,"watchers":964,"default_branch":"main"}},"base":{"label":"chain:main","ref":"main","sha":"2d3da8458b835aa1998b5c834760aebafb5600f6","user":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"repo":{"id":71740230,"name":"chain","full_name":"chain/chain","owner":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chain/chain","description":"Chain Core Developer Edition","fork":false,"url":"https://api.github.com/repos/chain/chain","forks_url":"https://api.github.com/repos/chain/chain/forks","keys_url":"https://api.github.com/repos/chain/chain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chain/chain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chain/chain/teams","hooks_url":"https://api.github.com/repos/chain/chain/hooks","issue_events_url":"https://api.github.com/repos/chain/chain/issues/events{/number}","events_url":"https://api.github.com/repos/chain/chain/events","assignees_url":"https://api.github.com/repos/chain/chain/assignees{/user}","branches_url":"https://api.github.com/repos/chain/chain/branches{/branch}","tags_url":"https://api.github.com/repos/chain/chain/tags","blobs_url":"https://api.github.com/repos/chain/chain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chain/chain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chain/chain/git/refs{/sha}","trees_url":"https://api.github.com/repos/chain/chain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chain/chain/statuses/{sha}","languages_url":"https://api.github.com/repos/chain/chain/languages","stargazers_url":"https://api.github.com/repos/chain/chain/stargazers","contributors_url":"https://api.github.com/repos/chain/chain/contributors","subscribers_url":"https://api.github.com/repos/chain/chain/subscribers","subscription_url":"https://api.github.com/repos/chain/chain/subscription","commits_url":"https://api.github.com/repos/chain/chain/commits{/sha}","git_commits_url":"https://api.github.com/repos/chain/chain/git/commits{/sha}","comments_url":"https://api.github.com/repos/chain/chain/comments{/number}","issue_comment_url":"https://api.github.com/repos/chain/chain/issues/comments{/number}","contents_url":"https://api.github.com/repos/chain/chain/contents/{+path}","compare_url":"https://api.github.com/repos/chain/chain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chain/chain/merges","archive_url":"https://api.github.com/repos/chain/chain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chain/chain/downloads","issues_url":"https://api.github.com/repos/chain/chain/issues{/number}","pulls_url":"https://api.github.com/repos/chain/chain/pulls{/number}","milestones_url":"https://api.github.com/repos/chain/chain/milestones{/number}","notifications_url":"https://api.github.com/repos/chain/chain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chain/chain/labels{/name}","releases_url":"https://api.github.com/repos/chain/chain/releases{/id}","deployments_url":"https://api.github.com/repos/chain/chain/deployments","created_at":"2016-10-24T01:12:26Z","updated_at":"2017-06-22T17:13:13Z","pushed_at":"2017-06-23T00:20:59Z","git_url":"git://github.com/chain/chain.git","ssh_url":"git@github.com:chain/chain.git","clone_url":"https://github.com/chain/chain.git","svn_url":"https://github.com/chain/chain","homepage":"https://chain.com","size":136224,"stargazers_count":964,"watchers_count":964,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":45,"forks":149,"open_issues":45,"watchers":964,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/chain/chain/pulls/1373"},"html":{"href":"https://github.com/chain/chain/pull/1373"},"issue":{"href":"https://api.github.com/repos/chain/chain/issues/1373"},"comments":{"href":"https://api.github.com/repos/chain/chain/issues/1373/comments"},"review_comments":{"href":"https://api.github.com/repos/chain/chain/pulls/1373/comments"},"review_comment":{"href":"https://api.github.com/repos/chain/chain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chain/chain/pulls/1373/commits"},"statuses":{"href":"https://api.github.com/repos/chain/chain/statuses/3b6550a327dea43de30d42703d0216ba2a44a5bf"}}}}
{"actor":{"display_login":"tessr"}}