{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/121172834","pull_request_review_id":43206117,"id":121172834,"diff_hunk":"@@ -48,25 +48,25 @@ func NewCmdCreateService(f cmdutil.Factory, cmdOut, errOut io.Writer) *cobra.Com\n \n var (\n \tserviceClusterIPLong = templates.LongDesc(i18n.T(`\n-    Create a clusterIP service with the specified name.`))\n+    Create a ClusterIP service with the specified name.`))\n \n \tserviceClusterIPExample = templates.Examples(i18n.T(`\n-    # Create a new clusterIP service named my-cs\n+    # Create a new ClusterIP service named my-cs\n     kubectl create service clusterip my-cs --tcp=5678:8080\n \n-    # Create a new clusterIP service named my-cs (in headless mode)\n+    # Create a new ClusterIP service named my-cs (in headless mode)\n     kubectl create service clusterip my-cs --clusterip=\"None\"`))\n )\n \n func addPortFlags(cmd *cobra.Command) {\n \tcmd.Flags().StringSlice(\"tcp\", []string{}, \"Port pairs can be specified as '<port>:<targetPort>'.\")\n }\n \n-// NewCmdCreateServiceClusterIP is a command to create a clusterIP service\n+// NewCmdCreateServiceClusterIP is a command to create a ClusterIP service","path":"pkg/kubectl/cmd/create_service.go","position":22,"original_position":22,"commit_id":"c0477a85a9382ea5dfa9742fa94012de1e5cd26a","original_commit_id":"c0477a85a9382ea5dfa9742fa94012de1e5cd26a","user":{"login":"xiangpengzhao","id":15881573,"avatar_url":"https://avatars3.githubusercontent.com/u/15881573?v=3","gravatar_id":"","url":"https://api.github.com/users/xiangpengzhao","html_url":"https://github.com/xiangpengzhao","followers_url":"https://api.github.com/users/xiangpengzhao/followers","following_url":"https://api.github.com/users/xiangpengzhao/following{/other_user}","gists_url":"https://api.github.com/users/xiangpengzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangpengzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangpengzhao/subscriptions","organizations_url":"https://api.github.com/users/xiangpengzhao/orgs","repos_url":"https://api.github.com/users/xiangpengzhao/repos","events_url":"https://api.github.com/users/xiangpengzhao/events{/privacy}","received_events_url":"https://api.github.com/users/xiangpengzhao/received_events","type":"User","site_admin":false},"body":"Thanks Tim for the advice!","created_at":"2017-06-09T16:49:45Z","updated_at":"2017-06-09T16:49:45Z","html_url":"https://github.com/kubernetes/kubernetes/pull/47250#discussion_r121172834","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/121172834"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47250#discussion_r121172834"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250","id":124896454,"html_url":"https://github.com/kubernetes/kubernetes/pull/47250","diff_url":"https://github.com/kubernetes/kubernetes/pull/47250.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/47250.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47250","number":47250,"state":"open","locked":false,"title":"Populate endpoints for headless service with no ports","user":{"login":"xiangpengzhao","id":15881573,"avatar_url":"https://avatars3.githubusercontent.com/u/15881573?v=3","gravatar_id":"","url":"https://api.github.com/users/xiangpengzhao","html_url":"https://github.com/xiangpengzhao","followers_url":"https://api.github.com/users/xiangpengzhao/followers","following_url":"https://api.github.com/users/xiangpengzhao/following{/other_user}","gists_url":"https://api.github.com/users/xiangpengzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangpengzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangpengzhao/subscriptions","organizations_url":"https://api.github.com/users/xiangpengzhao/orgs","repos_url":"https://api.github.com/users/xiangpengzhao/repos","events_url":"https://api.github.com/users/xiangpengzhao/events{/privacy}","received_events_url":"https://api.github.com/users/xiangpengzhao/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n- populate endpoints with headless service (thanks @fraenkel for the original PR!)\r\n- allow ports with headless service\r\n- nits\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #32796 https://github.com/kubernetes/kubernetes/issues/32796#issuecomment-270462724\r\n\r\n**Special notes for your reviewer**:\r\n/cc @thockin @fraenkel \r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2017-06-09T15:44:23Z","updated_at":"2017-06-09T16:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15ff35ba1a614c6327498c4d627ee1772fab5208","assignee":{"login":"dims","id":23304,"avatar_url":"https://avatars1.githubusercontent.com/u/23304?v=3","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"assignees":[{"login":"dims","id":23304,"avatar_url":"https://avatars1.githubusercontent.com/u/23304?v=3","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},{"login":"bowei","id":837034,"avatar_url":"https://avatars2.githubusercontent.com/u/837034?v=3","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fraenkel","id":929377,"avatar_url":"https://avatars2.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47250/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c0477a85a9382ea5dfa9742fa94012de1e5cd26a","head":{"label":"xiangpengzhao:fix-headless","ref":"fix-headless","sha":"c0477a85a9382ea5dfa9742fa94012de1e5cd26a","user":{"login":"xiangpengzhao","id":15881573,"avatar_url":"https://avatars3.githubusercontent.com/u/15881573?v=3","gravatar_id":"","url":"https://api.github.com/users/xiangpengzhao","html_url":"https://github.com/xiangpengzhao","followers_url":"https://api.github.com/users/xiangpengzhao/followers","following_url":"https://api.github.com/users/xiangpengzhao/following{/other_user}","gists_url":"https://api.github.com/users/xiangpengzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangpengzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangpengzhao/subscriptions","organizations_url":"https://api.github.com/users/xiangpengzhao/orgs","repos_url":"https://api.github.com/users/xiangpengzhao/repos","events_url":"https://api.github.com/users/xiangpengzhao/events{/privacy}","received_events_url":"https://api.github.com/users/xiangpengzhao/received_events","type":"User","site_admin":false},"repo":{"id":57712198,"name":"kubernetes","full_name":"xiangpengzhao/kubernetes","owner":{"login":"xiangpengzhao","id":15881573,"avatar_url":"https://avatars3.githubusercontent.com/u/15881573?v=3","gravatar_id":"","url":"https://api.github.com/users/xiangpengzhao","html_url":"https://github.com/xiangpengzhao","followers_url":"https://api.github.com/users/xiangpengzhao/followers","following_url":"https://api.github.com/users/xiangpengzhao/following{/other_user}","gists_url":"https://api.github.com/users/xiangpengzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangpengzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangpengzhao/subscriptions","organizations_url":"https://api.github.com/users/xiangpengzhao/orgs","repos_url":"https://api.github.com/users/xiangpengzhao/repos","events_url":"https://api.github.com/users/xiangpengzhao/events{/privacy}","received_events_url":"https://api.github.com/users/xiangpengzhao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiangpengzhao/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/xiangpengzhao/kubernetes","forks_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/forks","keys_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/teams","hooks_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/events","assignees_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/tags","blobs_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/languages","stargazers_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/subscription","commits_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/merges","archive_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/downloads","issues_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/xiangpengzhao/kubernetes/deployments","created_at":"2016-05-01T18:03:28Z","updated_at":"2016-05-01T18:03:41Z","pushed_at":"2017-06-09T15:30:30Z","git_url":"git://github.com/xiangpengzhao/kubernetes.git","ssh_url":"git@github.com:xiangpengzhao/kubernetes.git","clone_url":"https://github.com/xiangpengzhao/kubernetes.git","svn_url":"https://github.com/xiangpengzhao/kubernetes","homepage":"http://kubernetes.io","size":439792,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4f73e7a068518cf2e8590a4baca69d3cb2c43601","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-06-09T16:43:43Z","pushed_at":"2017-06-09T16:36:22Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":662962,"stargazers_count":23865,"watchers_count":23865,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8458,"mirror_url":null,"open_issues_count":5193,"forks":8458,"open_issues":5193,"watchers":23865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47250"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47250"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47250/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47250/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c0477a85a9382ea5dfa9742fa94012de1e5cd26a"}}}}
{"actor":{"display_login":"xiangpengzhao"}}