{"action":"created","comment":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/148452333","pull_request_review_id":73694992,"id":148452333,"diff_hunk":"@@ -82,7 +82,10 @@ class CMul[T: ClassTag](\n   }\n \n   private def mulOneDimWeight(dim: Int, expand: Tensor[T], output: Tensor[T]): Unit = {\n-    val (innerNum, outerNum) = Utils.getInnerOuterNum(dim, output)\n+    val multiplyDimSize = expand.size(dim)\n+    var dimOfoutput : Int = 1\n+    while(output.size(dimOfoutput) != multiplyDimSize) dimOfoutput += 1","path":"spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/CMul.scala","position":7,"original_position":7,"commit_id":"6a12a3262f7d0bf5852ed069c18cbd1b46c43d62","original_commit_id":"6a12a3262f7d0bf5852ed069c18cbd1b46c43d62","user":{"login":"yiheng","id":1297418,"avatar_url":"https://avatars3.githubusercontent.com/u/1297418?v=4","gravatar_id":"","url":"https://api.github.com/users/yiheng","html_url":"https://github.com/yiheng","followers_url":"https://api.github.com/users/yiheng/followers","following_url":"https://api.github.com/users/yiheng/following{/other_user}","gists_url":"https://api.github.com/users/yiheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yiheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiheng/subscriptions","organizations_url":"https://api.github.com/users/yiheng/orgs","repos_url":"https://api.github.com/users/yiheng/repos","events_url":"https://api.github.com/users/yiheng/events{/privacy}","received_events_url":"https://api.github.com/users/yiheng/received_events","type":"User","site_admin":false},"body":"What if there's no multiplyDimSize in output.size()? TTry to catch the array outofbound error and throw a more meaningful error msg","created_at":"2017-11-02T06:43:34Z","updated_at":"2017-11-02T06:43:38Z","html_url":"https://github.com/intel-analytics/BigDL/pull/1822#discussion_r148452333","pull_request_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/148452333"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/1822#discussion_r148452333"},"pull_request":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822"}}},"pull_request":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822","id":150213085,"html_url":"https://github.com/intel-analytics/BigDL/pull/1822","diff_url":"https://github.com/intel-analytics/BigDL/pull/1822.diff","patch_url":"https://github.com/intel-analytics/BigDL/pull/1822.patch","issue_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/1822","number":1822,"state":"open","locked":false,"title":"Fix cmul","user":{"login":"lopelopelope","id":17538471,"avatar_url":"https://avatars3.githubusercontent.com/u/17538471?v=4","gravatar_id":"","url":"https://api.github.com/users/lopelopelope","html_url":"https://github.com/lopelopelope","followers_url":"https://api.github.com/users/lopelopelope/followers","following_url":"https://api.github.com/users/lopelopelope/following{/other_user}","gists_url":"https://api.github.com/users/lopelopelope/gists{/gist_id}","starred_url":"https://api.github.com/users/lopelopelope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopelopelope/subscriptions","organizations_url":"https://api.github.com/users/lopelopelope/orgs","repos_url":"https://api.github.com/users/lopelopelope/repos","events_url":"https://api.github.com/users/lopelopelope/events{/privacy}","received_events_url":"https://api.github.com/users/lopelopelope/received_events","type":"User","site_admin":false},"body":"fixed https://github.com/intel-analytics/BigDL/issues/1697\r\n\r\n","created_at":"2017-11-02T06:29:07Z","updated_at":"2017-11-02T06:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca4a7e4066b26eb5df64a2bae0c671061ee7b7e8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822/commits","review_comments_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822/comments","review_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/1822/comments","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/6a12a3262f7d0bf5852ed069c18cbd1b46c43d62","head":{"label":"lopelopelope:fixCmul","ref":"fixCmul","sha":"6a12a3262f7d0bf5852ed069c18cbd1b46c43d62","user":{"login":"lopelopelope","id":17538471,"avatar_url":"https://avatars3.githubusercontent.com/u/17538471?v=4","gravatar_id":"","url":"https://api.github.com/users/lopelopelope","html_url":"https://github.com/lopelopelope","followers_url":"https://api.github.com/users/lopelopelope/followers","following_url":"https://api.github.com/users/lopelopelope/following{/other_user}","gists_url":"https://api.github.com/users/lopelopelope/gists{/gist_id}","starred_url":"https://api.github.com/users/lopelopelope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopelopelope/subscriptions","organizations_url":"https://api.github.com/users/lopelopelope/orgs","repos_url":"https://api.github.com/users/lopelopelope/repos","events_url":"https://api.github.com/users/lopelopelope/events{/privacy}","received_events_url":"https://api.github.com/users/lopelopelope/received_events","type":"User","site_admin":false},"repo":{"id":100452256,"name":"BigDL","full_name":"lopelopelope/BigDL","owner":{"login":"lopelopelope","id":17538471,"avatar_url":"https://avatars3.githubusercontent.com/u/17538471?v=4","gravatar_id":"","url":"https://api.github.com/users/lopelopelope","html_url":"https://github.com/lopelopelope","followers_url":"https://api.github.com/users/lopelopelope/followers","following_url":"https://api.github.com/users/lopelopelope/following{/other_user}","gists_url":"https://api.github.com/users/lopelopelope/gists{/gist_id}","starred_url":"https://api.github.com/users/lopelopelope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopelopelope/subscriptions","organizations_url":"https://api.github.com/users/lopelopelope/orgs","repos_url":"https://api.github.com/users/lopelopelope/repos","events_url":"https://api.github.com/users/lopelopelope/events{/privacy}","received_events_url":"https://api.github.com/users/lopelopelope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lopelopelope/BigDL","description":"BigDL: Distributed Deep Learning Library for Apache Spark","fork":true,"url":"https://api.github.com/repos/lopelopelope/BigDL","forks_url":"https://api.github.com/repos/lopelopelope/BigDL/forks","keys_url":"https://api.github.com/repos/lopelopelope/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lopelopelope/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lopelopelope/BigDL/teams","hooks_url":"https://api.github.com/repos/lopelopelope/BigDL/hooks","issue_events_url":"https://api.github.com/repos/lopelopelope/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/lopelopelope/BigDL/events","assignees_url":"https://api.github.com/repos/lopelopelope/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/lopelopelope/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/lopelopelope/BigDL/tags","blobs_url":"https://api.github.com/repos/lopelopelope/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lopelopelope/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lopelopelope/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/lopelopelope/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lopelopelope/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/lopelopelope/BigDL/languages","stargazers_url":"https://api.github.com/repos/lopelopelope/BigDL/stargazers","contributors_url":"https://api.github.com/repos/lopelopelope/BigDL/contributors","subscribers_url":"https://api.github.com/repos/lopelopelope/BigDL/subscribers","subscription_url":"https://api.github.com/repos/lopelopelope/BigDL/subscription","commits_url":"https://api.github.com/repos/lopelopelope/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/lopelopelope/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/lopelopelope/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/lopelopelope/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/lopelopelope/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/lopelopelope/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lopelopelope/BigDL/merges","archive_url":"https://api.github.com/repos/lopelopelope/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lopelopelope/BigDL/downloads","issues_url":"https://api.github.com/repos/lopelopelope/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/lopelopelope/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/lopelopelope/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/lopelopelope/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lopelopelope/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/lopelopelope/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/lopelopelope/BigDL/deployments","created_at":"2017-08-16T05:47:18Z","updated_at":"2017-08-16T05:47:21Z","pushed_at":"2017-11-02T06:27:39Z","git_url":"git://github.com/lopelopelope/BigDL.git","ssh_url":"git@github.com:lopelopelope/BigDL.git","clone_url":"https://github.com/lopelopelope/BigDL.git","svn_url":"https://github.com/lopelopelope/BigDL","homepage":"https://bigdl-project.github.io/","size":15648,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel-analytics:master","ref":"master","sha":"2d438b5ba3da1dd677d70dc28c62af7a78ac8b2c","user":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars3.githubusercontent.com/u/10941215?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":66823715,"name":"BigDL","full_name":"intel-analytics/BigDL","owner":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars3.githubusercontent.com/u/10941215?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-analytics/BigDL","description":"BigDL: Distributed Deep Learning Library for Apache Spark","fork":false,"url":"https://api.github.com/repos/intel-analytics/BigDL","forks_url":"https://api.github.com/repos/intel-analytics/BigDL/forks","keys_url":"https://api.github.com/repos/intel-analytics/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-analytics/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-analytics/BigDL/teams","hooks_url":"https://api.github.com/repos/intel-analytics/BigDL/hooks","issue_events_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/intel-analytics/BigDL/events","assignees_url":"https://api.github.com/repos/intel-analytics/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/intel-analytics/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/intel-analytics/BigDL/tags","blobs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-analytics/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-analytics/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-analytics/BigDL/languages","stargazers_url":"https://api.github.com/repos/intel-analytics/BigDL/stargazers","contributors_url":"https://api.github.com/repos/intel-analytics/BigDL/contributors","subscribers_url":"https://api.github.com/repos/intel-analytics/BigDL/subscribers","subscription_url":"https://api.github.com/repos/intel-analytics/BigDL/subscription","commits_url":"https://api.github.com/repos/intel-analytics/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-analytics/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-analytics/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/intel-analytics/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-analytics/BigDL/merges","archive_url":"https://api.github.com/repos/intel-analytics/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-analytics/BigDL/downloads","issues_url":"https://api.github.com/repos/intel-analytics/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-analytics/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-analytics/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-analytics/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/intel-analytics/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/intel-analytics/BigDL/deployments","created_at":"2016-08-29T07:59:50Z","updated_at":"2017-11-02T05:37:45Z","pushed_at":"2017-11-02T06:33:09Z","git_url":"git://github.com/intel-analytics/BigDL.git","ssh_url":"git@github.com:intel-analytics/BigDL.git","clone_url":"https://github.com/intel-analytics/BigDL.git","svn_url":"https://github.com/intel-analytics/BigDL","homepage":"https://bigdl-project.github.io/","size":16065,"stargazers_count":2085,"watchers_count":2085,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"open_issues_count":129,"forks":433,"open_issues":129,"watchers":2085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/1822"},"issue":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/1822"},"comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/1822/comments"},"review_comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822/comments"},"review_comment":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1822/commits"},"statuses":{"href":"https://api.github.com/repos/intel-analytics/BigDL/statuses/6a12a3262f7d0bf5852ed069c18cbd1b46c43d62"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yiheng"}}