{"action":"created","comment":{"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments/141988141","pull_request_review_id":66294112,"id":141988141,"diff_hunk":"@@ -0,0 +1,49 @@\n+//  Copyright (c) 2017 Hartmut Kaiser\n+//  Copyright (c) 2017 Alireza Kheirkhahan\n+//\n+//  Distributed under the Boost Software License, Version 1.0. (See accompanying\n+//  file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)\n+\n+#if !defined(PHYLANX_PRIMITIVES_MUL_OPERATION_SEP_25_2017_0900PM)\n+#define PHYLANX_PRIMITIVES_MUL_OPERATION_SEP_25_2017_0900PM\n+\n+#include <phylanx/config.hpp>\n+#include <phylanx/ast/node.hpp>\n+#include <phylanx/ir/node_data.hpp>\n+#include <phylanx/execution_tree/primitives/base_primitive.hpp>\n+\n+#include <hpx/include/components.hpp>\n+\n+#include <utility>\n+#include <vector>\n+\n+namespace phylanx { namespace execution_tree { namespace primitives\n+        {\n+            class HPX_COMPONENT_EXPORT mul_operation\n+                    : public base_primitive\n+            , public hpx::components::component_base<mul_operation>\n+        {\n+            private:\n+            using operands_type = std::vector<ir::node_data<double>>;\n+\n+            public:\n+            mul_operation() = default;\n+\n+            mul_operation(std::vector<ast::literal_value_type>&& literals,\n+            std::vector<primitive>&& operands);\n+\n+            hpx::future<ir::node_data<double>> eval() const override;\n+\n+            protected:\n+            ir::node_data<double> mul0d(operands_type const& ops) const;\n+            ir::node_data<double> mulxd(operands_type const& ops) const;\n+\n+            private:\n+            std::vector<ast::literal_value_type> literals_;\n+            std::vector<primitive> operands_;\n+        };\n+    }}}\n+","path":"phylanx/execution_tree/primitives/mul_operation.hpp","position":46,"original_position":46,"commit_id":"5a73182060972aa559563ca48026750ebc35bb75","original_commit_id":"5a73182060972aa559563ca48026750ebc35bb75","user":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars1.githubusercontent.com/u/568063?v=4","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"body":"Something went wrong with the indentation here.","created_at":"2017-09-29T23:39:30Z","updated_at":"2017-09-29T23:39:30Z","html_url":"https://github.com/STEllAR-GROUP/phylanx/pull/38#discussion_r141988141","pull_request_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments/141988141"},"html":{"href":"https://github.com/STEllAR-GROUP/phylanx/pull/38#discussion_r141988141"},"pull_request":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38","id":143924599,"html_url":"https://github.com/STEllAR-GROUP/phylanx/pull/38","diff_url":"https://github.com/STEllAR-GROUP/phylanx/pull/38.diff","patch_url":"https://github.com/STEllAR-GROUP/phylanx/pull/38.patch","issue_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/38","number":38,"state":"open","locked":false,"title":"adding multiply primitive","user":{"login":"hapoo","id":7526235,"avatar_url":"https://avatars2.githubusercontent.com/u/7526235?v=4","gravatar_id":"","url":"https://api.github.com/users/hapoo","html_url":"https://github.com/hapoo","followers_url":"https://api.github.com/users/hapoo/followers","following_url":"https://api.github.com/users/hapoo/following{/other_user}","gists_url":"https://api.github.com/users/hapoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hapoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapoo/subscriptions","organizations_url":"https://api.github.com/users/hapoo/orgs","repos_url":"https://api.github.com/users/hapoo/repos","events_url":"https://api.github.com/users/hapoo/events{/privacy}","received_events_url":"https://api.github.com/users/hapoo/received_events","type":"User","site_admin":false},"body":"This adds multiply primitive. It works for vector of operands when:\r\n1. all operands are double\r\n2. all operands are matrices\r\n3. when there is mix of doubles and matrices; except when the first operand is double, in this case it only multiplies first to operands and throws exception for 3 operands and more.\r\n\r\nissue: when tested with matrices larger than 100 by 100 got this:\r\nStack overflow in coroutine at address 0x00007f1286f2fbb8. Configure the hpx runtime to allocate a larger coroutine stack size. But the logic works and tests pass for smaller matrices.\r\n","created_at":"2017-09-29T16:05:44Z","updated_at":"2017-09-29T23:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8543d83cd5aa7d93dafe6b3548ba16eecfe78b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38/commits","review_comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38/comments","review_comment_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/38/comments","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/5a73182060972aa559563ca48026750ebc35bb75","head":{"label":"STEllAR-GROUP:multiply_primitive","ref":"multiply_primitive","sha":"5a73182060972aa559563ca48026750ebc35bb75","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":101409977,"name":"phylanx","full_name":"STEllAR-GROUP/phylanx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/phylanx","description":"A Distributed C++ Array Processing Toolkit","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/deployments","created_at":"2017-08-25T14:07:21Z","updated_at":"2017-09-23T17:03:34Z","pushed_at":"2017-09-29T20:48:35Z","git_url":"git://github.com/STEllAR-GROUP/phylanx.git","ssh_url":"git@github.com:STEllAR-GROUP/phylanx.git","clone_url":"https://github.com/STEllAR-GROUP/phylanx.git","svn_url":"https://github.com/STEllAR-GROUP/phylanx","homepage":"","size":277,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":9,"default_branch":"master"}},"base":{"label":"STEllAR-GROUP:master","ref":"master","sha":"9496917c3301b1666055d530e3fe193e923c6459","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":101409977,"name":"phylanx","full_name":"STEllAR-GROUP/phylanx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/phylanx","description":"A Distributed C++ Array Processing Toolkit","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/phylanx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/phylanx/deployments","created_at":"2017-08-25T14:07:21Z","updated_at":"2017-09-23T17:03:34Z","pushed_at":"2017-09-29T20:48:35Z","git_url":"git://github.com/STEllAR-GROUP/phylanx.git","ssh_url":"git@github.com:STEllAR-GROUP/phylanx.git","clone_url":"https://github.com/STEllAR-GROUP/phylanx.git","svn_url":"https://github.com/STEllAR-GROUP/phylanx","homepage":"","size":277,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38"},"html":{"href":"https://github.com/STEllAR-GROUP/phylanx/pull/38"},"issue":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/38"},"comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/STEllAR-GROUP/phylanx/statuses/5a73182060972aa559563ca48026750ebc35bb75"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hkaiser"}}