{"action":"opened","number":329,"pull_request":{"url":"https://api.github.com/repos/spotify/HubFramework/pulls/329","id":115274257,"html_url":"https://github.com/spotify/HubFramework/pull/329","diff_url":"https://github.com/spotify/HubFramework/pull/329.diff","patch_url":"https://github.com/spotify/HubFramework/pull/329.patch","issue_url":"https://api.github.com/repos/spotify/HubFramework/issues/329","number":329,"state":"open","locked":false,"title":"Use dependency injection for UIApplication.","user":{"login":"krris","id":1786612,"avatar_url":"https://avatars1.githubusercontent.com/u/1786612?v=3","gravatar_id":"","url":"https://api.github.com/users/krris","html_url":"https://github.com/krris","followers_url":"https://api.github.com/users/krris/followers","following_url":"https://api.github.com/users/krris/following{/other_user}","gists_url":"https://api.github.com/users/krris/gists{/gist_id}","starred_url":"https://api.github.com/users/krris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krris/subscriptions","organizations_url":"https://api.github.com/users/krris/orgs","repos_url":"https://api.github.com/users/krris/repos","events_url":"https://api.github.com/users/krris/events{/privacy}","received_events_url":"https://api.github.com/users/krris/received_events","type":"User","site_admin":false},"body":"Currently, `UIApplication` is accessed by `[UIApplication sharedApplication]` in many places. It makes it hard to test. Especially, when we want to mock `UIApplication`, which can be used by other frameworks.\r\n\r\nThis PR introduces `HUBApplicationProtocol` and `HUBApplication` (which is a wrapper around `UIApplication`).","created_at":"2017-04-11T09:13:52Z","updated_at":"2017-04-11T09:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/HubFramework/pulls/329/commits","review_comments_url":"https://api.github.com/repos/spotify/HubFramework/pulls/329/comments","review_comment_url":"https://api.github.com/repos/spotify/HubFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/HubFramework/issues/329/comments","statuses_url":"https://api.github.com/repos/spotify/HubFramework/statuses/5c1bf8e7d392c03dafa9b7a80db4a126ec07ccdd","head":{"label":"krris:inject-uiapplication","ref":"inject-uiapplication","sha":"5c1bf8e7d392c03dafa9b7a80db4a126ec07ccdd","user":{"login":"krris","id":1786612,"avatar_url":"https://avatars1.githubusercontent.com/u/1786612?v=3","gravatar_id":"","url":"https://api.github.com/users/krris","html_url":"https://github.com/krris","followers_url":"https://api.github.com/users/krris/followers","following_url":"https://api.github.com/users/krris/following{/other_user}","gists_url":"https://api.github.com/users/krris/gists{/gist_id}","starred_url":"https://api.github.com/users/krris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krris/subscriptions","organizations_url":"https://api.github.com/users/krris/orgs","repos_url":"https://api.github.com/users/krris/repos","events_url":"https://api.github.com/users/krris/events{/privacy}","received_events_url":"https://api.github.com/users/krris/received_events","type":"User","site_admin":false},"repo":{"id":70585558,"name":"HubFramework","full_name":"krris/HubFramework","owner":{"login":"krris","id":1786612,"avatar_url":"https://avatars1.githubusercontent.com/u/1786612?v=3","gravatar_id":"","url":"https://api.github.com/users/krris","html_url":"https://github.com/krris","followers_url":"https://api.github.com/users/krris/followers","following_url":"https://api.github.com/users/krris/following{/other_user}","gists_url":"https://api.github.com/users/krris/gists{/gist_id}","starred_url":"https://api.github.com/users/krris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krris/subscriptions","organizations_url":"https://api.github.com/users/krris/orgs","repos_url":"https://api.github.com/users/krris/repos","events_url":"https://api.github.com/users/krris/events{/privacy}","received_events_url":"https://api.github.com/users/krris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krris/HubFramework","description":"Spotify’s component-driven UI framework for iOS","fork":true,"url":"https://api.github.com/repos/krris/HubFramework","forks_url":"https://api.github.com/repos/krris/HubFramework/forks","keys_url":"https://api.github.com/repos/krris/HubFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krris/HubFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krris/HubFramework/teams","hooks_url":"https://api.github.com/repos/krris/HubFramework/hooks","issue_events_url":"https://api.github.com/repos/krris/HubFramework/issues/events{/number}","events_url":"https://api.github.com/repos/krris/HubFramework/events","assignees_url":"https://api.github.com/repos/krris/HubFramework/assignees{/user}","branches_url":"https://api.github.com/repos/krris/HubFramework/branches{/branch}","tags_url":"https://api.github.com/repos/krris/HubFramework/tags","blobs_url":"https://api.github.com/repos/krris/HubFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krris/HubFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krris/HubFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/krris/HubFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krris/HubFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/krris/HubFramework/languages","stargazers_url":"https://api.github.com/repos/krris/HubFramework/stargazers","contributors_url":"https://api.github.com/repos/krris/HubFramework/contributors","subscribers_url":"https://api.github.com/repos/krris/HubFramework/subscribers","subscription_url":"https://api.github.com/repos/krris/HubFramework/subscription","commits_url":"https://api.github.com/repos/krris/HubFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/krris/HubFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/krris/HubFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/krris/HubFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/krris/HubFramework/contents/{+path}","compare_url":"https://api.github.com/repos/krris/HubFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krris/HubFramework/merges","archive_url":"https://api.github.com/repos/krris/HubFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krris/HubFramework/downloads","issues_url":"https://api.github.com/repos/krris/HubFramework/issues{/number}","pulls_url":"https://api.github.com/repos/krris/HubFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/krris/HubFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/krris/HubFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krris/HubFramework/labels{/name}","releases_url":"https://api.github.com/repos/krris/HubFramework/releases{/id}","deployments_url":"https://api.github.com/repos/krris/HubFramework/deployments","created_at":"2016-10-11T11:15:03Z","updated_at":"2016-10-11T11:15:05Z","pushed_at":"2017-04-11T08:57:50Z","git_url":"git://github.com/krris/HubFramework.git","ssh_url":"git@github.com:krris/HubFramework.git","clone_url":"https://github.com/krris/HubFramework.git","svn_url":"https://github.com/krris/HubFramework","homepage":"https://spotify.github.io/HubFramework","size":80210,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"84a7b19855eec5cf84f91fb07e23eefb0fb2435c","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars1.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":69279243,"name":"HubFramework","full_name":"spotify/HubFramework","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars1.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/HubFramework","description":"Spotify’s component-driven UI framework for iOS","fork":false,"url":"https://api.github.com/repos/spotify/HubFramework","forks_url":"https://api.github.com/repos/spotify/HubFramework/forks","keys_url":"https://api.github.com/repos/spotify/HubFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/HubFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/HubFramework/teams","hooks_url":"https://api.github.com/repos/spotify/HubFramework/hooks","issue_events_url":"https://api.github.com/repos/spotify/HubFramework/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/HubFramework/events","assignees_url":"https://api.github.com/repos/spotify/HubFramework/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/HubFramework/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/HubFramework/tags","blobs_url":"https://api.github.com/repos/spotify/HubFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/HubFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/HubFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/HubFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/HubFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/HubFramework/languages","stargazers_url":"https://api.github.com/repos/spotify/HubFramework/stargazers","contributors_url":"https://api.github.com/repos/spotify/HubFramework/contributors","subscribers_url":"https://api.github.com/repos/spotify/HubFramework/subscribers","subscription_url":"https://api.github.com/repos/spotify/HubFramework/subscription","commits_url":"https://api.github.com/repos/spotify/HubFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/HubFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/HubFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/HubFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/HubFramework/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/HubFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/HubFramework/merges","archive_url":"https://api.github.com/repos/spotify/HubFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/HubFramework/downloads","issues_url":"https://api.github.com/repos/spotify/HubFramework/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/HubFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/HubFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/HubFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/HubFramework/labels{/name}","releases_url":"https://api.github.com/repos/spotify/HubFramework/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/HubFramework/deployments","created_at":"2016-09-26T18:19:58Z","updated_at":"2017-04-11T06:55:28Z","pushed_at":"2017-04-10T12:12:18Z","git_url":"git://github.com/spotify/HubFramework.git","ssh_url":"git@github.com:spotify/HubFramework.git","clone_url":"https://github.com/spotify/HubFramework.git","svn_url":"https://github.com/spotify/HubFramework","homepage":"https://spotify.github.io/HubFramework","size":147857,"stargazers_count":1600,"watchers_count":1600,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":107,"mirror_url":null,"open_issues_count":35,"forks":107,"open_issues":35,"watchers":1600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/HubFramework/pulls/329"},"html":{"href":"https://github.com/spotify/HubFramework/pull/329"},"issue":{"href":"https://api.github.com/repos/spotify/HubFramework/issues/329"},"comments":{"href":"https://api.github.com/repos/spotify/HubFramework/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/HubFramework/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/HubFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/HubFramework/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/HubFramework/statuses/5c1bf8e7d392c03dafa9b7a80db4a126ec07ccdd"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":21,"additions":391,"deletions":62,"changed_files":38}}
{"actor":{"display_login":"krris"}}