{"action":"created","comment":{"url":"https://api.github.com/repos/wpengine/lostromos/pulls/comments/152407816","pull_request_review_id":78266190,"id":152407816,"diff_hunk":"@@ -82,11 +117,20 @@ def setUp(self):\n         Ensure the custom resource definition exists, and set up the status and metrics url.\n         \"\"\"\n         self.__kubectl = Kubectl()\n-\n+        # Set up the tiller and expose it via a nodeport service\n+        self.__helm = Helm()\n+        self.__helm.init()\n+        self.__kubectl.apply(_TEST_DATA_DIRECTORY + \"/tiller_nodeport_service.yml\")\n+        # Ensure the CRD is there and there are no characters, for a clean starting point\n+        self.__kubectl.apply(_CUSTOM_RESOURCE_DEFINION_FILE)","path":"test/scripts/integration_tests.py","position":66,"original_position":66,"commit_id":"5a16506ad3acb6ef083e30a2acabf9e03588145b","original_commit_id":"5a16506ad3acb6ef083e30a2acabf9e03588145b","user":{"login":"wpdrush21","id":30598879,"avatar_url":"https://avatars0.githubusercontent.com/u/30598879?v=4","gravatar_id":"","url":"https://api.github.com/users/wpdrush21","html_url":"https://github.com/wpdrush21","followers_url":"https://api.github.com/users/wpdrush21/followers","following_url":"https://api.github.com/users/wpdrush21/following{/other_user}","gists_url":"https://api.github.com/users/wpdrush21/gists{/gist_id}","starred_url":"https://api.github.com/users/wpdrush21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpdrush21/subscriptions","organizations_url":"https://api.github.com/users/wpdrush21/orgs","repos_url":"https://api.github.com/users/wpdrush21/repos","events_url":"https://api.github.com/users/wpdrush21/events{/privacy}","received_events_url":"https://api.github.com/users/wpdrush21/received_events","type":"User","site_admin":false},"body":"I believe this will break the testing in cases where it is expecting a certain number of events. This was worked around by using a make target to run the tests. Potentially that same make target can be used here, or we can figure out a better way to do the testing.","created_at":"2017-11-21T21:33:40Z","updated_at":"2017-11-21T21:33:40Z","html_url":"https://github.com/wpengine/lostromos/pull/43#discussion_r152407816","pull_request_url":"https://api.github.com/repos/wpengine/lostromos/pulls/43","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wpengine/lostromos/pulls/comments/152407816"},"html":{"href":"https://github.com/wpengine/lostromos/pull/43#discussion_r152407816"},"pull_request":{"href":"https://api.github.com/repos/wpengine/lostromos/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/wpengine/lostromos/pulls/43","id":154000011,"html_url":"https://github.com/wpengine/lostromos/pull/43","diff_url":"https://github.com/wpengine/lostromos/pull/43.diff","patch_url":"https://github.com/wpengine/lostromos/pull/43.patch","issue_url":"https://api.github.com/repos/wpengine/lostromos/issues/43","number":43,"state":"open","locked":false,"title":"Adding wait and timeout options to helm controller","user":{"login":"jhyelton","id":9421517,"avatar_url":"https://avatars2.githubusercontent.com/u/9421517?v=4","gravatar_id":"","url":"https://api.github.com/users/jhyelton","html_url":"https://github.com/jhyelton","followers_url":"https://api.github.com/users/jhyelton/followers","following_url":"https://api.github.com/users/jhyelton/following{/other_user}","gists_url":"https://api.github.com/users/jhyelton/gists{/gist_id}","starred_url":"https://api.github.com/users/jhyelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhyelton/subscriptions","organizations_url":"https://api.github.com/users/jhyelton/orgs","repos_url":"https://api.github.com/users/jhyelton/repos","events_url":"https://api.github.com/users/jhyelton/events{/privacy}","received_events_url":"https://api.github.com/users/jhyelton/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Josh Yelton <josh.yelton@wpengine.com>\r\n\r\n# What Are We Doing Here\r\n\r\nAdding the ability to add the Wait and Timeout options to the helm controller for installs and upgrades.  This allows the operator to conditionally wait for releases to successfully create resources before being marked as DEPLOYED.\r\n\r\n## How to Verify\r\n\r\nI've added steps to the integration tests to deploy a tiller into the minikube instance and wait for a broken release to timeout and be marked as FAILED.","created_at":"2017-11-21T21:01:29Z","updated_at":"2017-11-21T21:33:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef0c26999e10bb71c89a3046470af39fb74f5daf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lvaughn","id":103400,"avatar_url":"https://avatars1.githubusercontent.com/u/103400?v=4","gravatar_id":"","url":"https://api.github.com/users/lvaughn","html_url":"https://github.com/lvaughn","followers_url":"https://api.github.com/users/lvaughn/followers","following_url":"https://api.github.com/users/lvaughn/following{/other_user}","gists_url":"https://api.github.com/users/lvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/lvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvaughn/subscriptions","organizations_url":"https://api.github.com/users/lvaughn/orgs","repos_url":"https://api.github.com/users/lvaughn/repos","events_url":"https://api.github.com/users/lvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/lvaughn/received_events","type":"User","site_admin":false},{"login":"nicolerenee","id":7727092,"avatar_url":"https://avatars2.githubusercontent.com/u/7727092?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolerenee","html_url":"https://github.com/nicolerenee","followers_url":"https://api.github.com/users/nicolerenee/followers","following_url":"https://api.github.com/users/nicolerenee/following{/other_user}","gists_url":"https://api.github.com/users/nicolerenee/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolerenee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolerenee/subscriptions","organizations_url":"https://api.github.com/users/nicolerenee/orgs","repos_url":"https://api.github.com/users/nicolerenee/repos","events_url":"https://api.github.com/users/nicolerenee/events{/privacy}","received_events_url":"https://api.github.com/users/nicolerenee/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wpengine/lostromos/pulls/43/commits","review_comments_url":"https://api.github.com/repos/wpengine/lostromos/pulls/43/comments","review_comment_url":"https://api.github.com/repos/wpengine/lostromos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpengine/lostromos/issues/43/comments","statuses_url":"https://api.github.com/repos/wpengine/lostromos/statuses/5a16506ad3acb6ef083e30a2acabf9e03588145b","head":{"label":"jhyelton:helm_timeout","ref":"helm_timeout","sha":"5a16506ad3acb6ef083e30a2acabf9e03588145b","user":{"login":"jhyelton","id":9421517,"avatar_url":"https://avatars2.githubusercontent.com/u/9421517?v=4","gravatar_id":"","url":"https://api.github.com/users/jhyelton","html_url":"https://github.com/jhyelton","followers_url":"https://api.github.com/users/jhyelton/followers","following_url":"https://api.github.com/users/jhyelton/following{/other_user}","gists_url":"https://api.github.com/users/jhyelton/gists{/gist_id}","starred_url":"https://api.github.com/users/jhyelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhyelton/subscriptions","organizations_url":"https://api.github.com/users/jhyelton/orgs","repos_url":"https://api.github.com/users/jhyelton/repos","events_url":"https://api.github.com/users/jhyelton/events{/privacy}","received_events_url":"https://api.github.com/users/jhyelton/received_events","type":"User","site_admin":false},"repo":{"id":107688648,"name":"lostromos","full_name":"jhyelton/lostromos","owner":{"login":"jhyelton","id":9421517,"avatar_url":"https://avatars2.githubusercontent.com/u/9421517?v=4","gravatar_id":"","url":"https://api.github.com/users/jhyelton","html_url":"https://github.com/jhyelton","followers_url":"https://api.github.com/users/jhyelton/followers","following_url":"https://api.github.com/users/jhyelton/following{/other_user}","gists_url":"https://api.github.com/users/jhyelton/gists{/gist_id}","starred_url":"https://api.github.com/users/jhyelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhyelton/subscriptions","organizations_url":"https://api.github.com/users/jhyelton/orgs","repos_url":"https://api.github.com/users/jhyelton/repos","events_url":"https://api.github.com/users/jhyelton/events{/privacy}","received_events_url":"https://api.github.com/users/jhyelton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhyelton/lostromos","description":"Lostromos is a service that creates Kubernetes resources based on a Custom Resource endpoint in the Kubernetes API","fork":true,"url":"https://api.github.com/repos/jhyelton/lostromos","forks_url":"https://api.github.com/repos/jhyelton/lostromos/forks","keys_url":"https://api.github.com/repos/jhyelton/lostromos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhyelton/lostromos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhyelton/lostromos/teams","hooks_url":"https://api.github.com/repos/jhyelton/lostromos/hooks","issue_events_url":"https://api.github.com/repos/jhyelton/lostromos/issues/events{/number}","events_url":"https://api.github.com/repos/jhyelton/lostromos/events","assignees_url":"https://api.github.com/repos/jhyelton/lostromos/assignees{/user}","branches_url":"https://api.github.com/repos/jhyelton/lostromos/branches{/branch}","tags_url":"https://api.github.com/repos/jhyelton/lostromos/tags","blobs_url":"https://api.github.com/repos/jhyelton/lostromos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhyelton/lostromos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhyelton/lostromos/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhyelton/lostromos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhyelton/lostromos/statuses/{sha}","languages_url":"https://api.github.com/repos/jhyelton/lostromos/languages","stargazers_url":"https://api.github.com/repos/jhyelton/lostromos/stargazers","contributors_url":"https://api.github.com/repos/jhyelton/lostromos/contributors","subscribers_url":"https://api.github.com/repos/jhyelton/lostromos/subscribers","subscription_url":"https://api.github.com/repos/jhyelton/lostromos/subscription","commits_url":"https://api.github.com/repos/jhyelton/lostromos/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhyelton/lostromos/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhyelton/lostromos/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhyelton/lostromos/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhyelton/lostromos/contents/{+path}","compare_url":"https://api.github.com/repos/jhyelton/lostromos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhyelton/lostromos/merges","archive_url":"https://api.github.com/repos/jhyelton/lostromos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhyelton/lostromos/downloads","issues_url":"https://api.github.com/repos/jhyelton/lostromos/issues{/number}","pulls_url":"https://api.github.com/repos/jhyelton/lostromos/pulls{/number}","milestones_url":"https://api.github.com/repos/jhyelton/lostromos/milestones{/number}","notifications_url":"https://api.github.com/repos/jhyelton/lostromos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhyelton/lostromos/labels{/name}","releases_url":"https://api.github.com/repos/jhyelton/lostromos/releases{/id}","deployments_url":"https://api.github.com/repos/jhyelton/lostromos/deployments","created_at":"2017-10-20T14:33:41Z","updated_at":"2017-10-20T14:33:43Z","pushed_at":"2017-11-21T20:58:25Z","git_url":"git://github.com/jhyelton/lostromos.git","ssh_url":"git@github.com:jhyelton/lostromos.git","clone_url":"https://github.com/jhyelton/lostromos.git","svn_url":"https://github.com/jhyelton/lostromos","homepage":"","size":15,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpengine:master","ref":"master","sha":"9da35f82c8d82759b4b4d8bae27c46b975c0fde5","user":{"login":"wpengine","id":749191,"avatar_url":"https://avatars1.githubusercontent.com/u/749191?v=4","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"repo":{"id":107196621,"name":"lostromos","full_name":"wpengine/lostromos","owner":{"login":"wpengine","id":749191,"avatar_url":"https://avatars1.githubusercontent.com/u/749191?v=4","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpengine/lostromos","description":"Lostromos is a service that creates Kubernetes resources based on a Custom Resource endpoint in the Kubernetes API","fork":false,"url":"https://api.github.com/repos/wpengine/lostromos","forks_url":"https://api.github.com/repos/wpengine/lostromos/forks","keys_url":"https://api.github.com/repos/wpengine/lostromos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpengine/lostromos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpengine/lostromos/teams","hooks_url":"https://api.github.com/repos/wpengine/lostromos/hooks","issue_events_url":"https://api.github.com/repos/wpengine/lostromos/issues/events{/number}","events_url":"https://api.github.com/repos/wpengine/lostromos/events","assignees_url":"https://api.github.com/repos/wpengine/lostromos/assignees{/user}","branches_url":"https://api.github.com/repos/wpengine/lostromos/branches{/branch}","tags_url":"https://api.github.com/repos/wpengine/lostromos/tags","blobs_url":"https://api.github.com/repos/wpengine/lostromos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpengine/lostromos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpengine/lostromos/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpengine/lostromos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpengine/lostromos/statuses/{sha}","languages_url":"https://api.github.com/repos/wpengine/lostromos/languages","stargazers_url":"https://api.github.com/repos/wpengine/lostromos/stargazers","contributors_url":"https://api.github.com/repos/wpengine/lostromos/contributors","subscribers_url":"https://api.github.com/repos/wpengine/lostromos/subscribers","subscription_url":"https://api.github.com/repos/wpengine/lostromos/subscription","commits_url":"https://api.github.com/repos/wpengine/lostromos/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpengine/lostromos/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpengine/lostromos/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpengine/lostromos/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpengine/lostromos/contents/{+path}","compare_url":"https://api.github.com/repos/wpengine/lostromos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpengine/lostromos/merges","archive_url":"https://api.github.com/repos/wpengine/lostromos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpengine/lostromos/downloads","issues_url":"https://api.github.com/repos/wpengine/lostromos/issues{/number}","pulls_url":"https://api.github.com/repos/wpengine/lostromos/pulls{/number}","milestones_url":"https://api.github.com/repos/wpengine/lostromos/milestones{/number}","notifications_url":"https://api.github.com/repos/wpengine/lostromos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpengine/lostromos/labels{/name}","releases_url":"https://api.github.com/repos/wpengine/lostromos/releases{/id}","deployments_url":"https://api.github.com/repos/wpengine/lostromos/deployments","created_at":"2017-10-17T00:11:23Z","updated_at":"2017-11-15T23:01:21Z","pushed_at":"2017-11-21T21:01:30Z","git_url":"git://github.com/wpengine/lostromos.git","ssh_url":"git@github.com:wpengine/lostromos.git","clone_url":"https://github.com/wpengine/lostromos.git","svn_url":"https://github.com/wpengine/lostromos","homepage":"","size":144,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpengine/lostromos/pulls/43"},"html":{"href":"https://github.com/wpengine/lostromos/pull/43"},"issue":{"href":"https://api.github.com/repos/wpengine/lostromos/issues/43"},"comments":{"href":"https://api.github.com/repos/wpengine/lostromos/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/wpengine/lostromos/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/wpengine/lostromos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpengine/lostromos/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/wpengine/lostromos/statuses/5a16506ad3acb6ef083e30a2acabf9e03588145b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wpdrush21"}}