{"action":"created","comment":{"url":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments/156888078","pull_request_review_id":83433954,"id":156888078,"diff_hunk":"@@ -42,446 +30,848 @@\n   },\n   {\n    \"cell_type\": \"markdown\",\n-   \"metadata\": {\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n+   \"metadata\": {},\n    \"source\": [\n-    \"Now import a `FieldSet` (from the Peninsula example, in this case)\"\n+    \"First import a `FieldSet` (from the Peninsula example, in this case)\"\n    ]\n   },\n   {\n    \"cell_type\": \"code\",\n    \"execution_count\": 2,\n-   \"metadata\": {\n-    \"collapsed\": true,\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n+   \"metadata\": {},\n    \"outputs\": [],\n    \"source\": [\n     \"fieldset = FieldSet.from_nemo('Peninsula_data/peninsula', allow_time_extrapolation = True)\"\n    ]\n   },\n   {\n    \"cell_type\": \"markdown\",\n-   \"metadata\": {\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n+   \"metadata\": {},\n+   \"source\": [\n+    \"Now, there are two ways to delay the start of particles. Either by defining the whole `ParticleSet` at initialisation and giving each particle its own `time`. Or by using the `repeatdt` argument. We will show both options here\"\n+   ]\n+  },\n+  {\n+   \"cell_type\": \"markdown\",\n+   \"metadata\": {},\n    \"source\": [\n-    \"Define an empty `ParticleSet`\"\n+    \"### Assigning each particle its own `time` ###\"\n+   ]\n+  },\n+  {\n+   \"cell_type\": \"markdown\",\n+   \"metadata\": {},\n+   \"source\": [\n+    \"The simplest way to delaye the start of a particle is to use the `time` argument for each particle\"\n    ]\n   },\n   {\n    \"cell_type\": \"code\",\n    \"execution_count\": 3,\n-   \"metadata\": {\n-    \"collapsed\": true,\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n+   \"metadata\": {},\n    \"outputs\": [],\n    \"source\": [\n-    \"pset = ParticleSet(fieldset=fieldset, lon=[], lat=[], pclass=JITParticle)\"\n+    \"npart = 10  # number of particles to be released\\n\",\n+    \"lon = 0.025 * np.ones(npart)\\n\",\n+    \"lat = np.linspace(0.025 , 0.4, npart, dtype=np.float32)\\n\",\n+    \"time = np.arange(0, npart) * delta(hours=1).total_seconds()  # release every particle one hour later\\n\",\n+    \"\\n\",\n+    \"pset = ParticleSet(fieldset=fieldset, pclass=JITParticle, lon=lon, lat=lat, time=time)\"\n    ]\n   },\n   {\n    \"cell_type\": \"markdown\",\n-   \"metadata\": {\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n+   \"metadata\": {},\n    \"source\": [\n-    \"And now also define some other variables\"\n+    \"Then we can execute the `pset` as usual\"\n    ]\n   },\n   {\n    \"cell_type\": \"code\",\n    \"execution_count\": 4,\n-   \"metadata\": {\n-    \"collapsed\": true,\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n-   \"outputs\": [],\n+   \"metadata\": {},\n+   \"outputs\": [\n+    {\n+     \"name\": \"stderr\",\n+     \"output_type\": \"stream\",\n+     \"text\": [\n+      \"INFO: Compiled JITParticleAdvectionRK4 ==> /var/folders/r2/8593q8z93kd7t4j9kbb_f7p00000gn/T/parcels-501/4b31da299158ef673e01491b786d6e1b.so\\n\"\n+     ]\n+    }\n+   ],\n    \"source\": [\n-    \"npart = 10  # number of particles to be released\\n\",\n-    \"delaytime = delta(hours=1)  # time between each particle release\\n\",\n-    \"endtime = delta(hours=24)  # total time of the experiment\"\n+    \"output_file = pset.ParticleFile(name=\\\"DelayParticle_time\\\")\\n\",\n+    \"pset.execute(AdvectionRK4, runtime=delta(hours=24), dt=delta(minutes=5),\\n\",\n+    \"             interval=delta(hours=1), output_file=output_file)\"\n    ]\n   },\n   {\n    \"cell_type\": \"markdown\",\n-   \"metadata\": {\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n+   \"metadata\": {},\n    \"source\": [\n-    \"We use the same start locations as in `examples/example_peninsula.py`\"\n+    \"And then finally, we can show a movie of the particles. Note that the southern-most particles start to move first.\"\n    ]\n   },\n   {\n    \"cell_type\": \"code\",\n    \"execution_count\": 5,\n-   \"metadata\": {\n-    \"collapsed\": true,\n-    \"deletable\": true,\n-    \"editable\": true\n-   },\n-   \"outputs\": [],\n+   \"metadata\": {},\n+   \"outputs\": [\n+    {\n+     \"data\": {\n+      \"text/html\": [","path":"parcels/examples/tutorial_delaystart.ipynb","position":180,"original_position":180,"commit_id":"1e30adf4fa2434a408545f37037e0d4a0112d3a6","original_commit_id":"1e30adf4fa2434a408545f37037e0d4a0112d3a6","user":{"login":"delandmeterp","id":31093031,"avatar_url":"https://avatars2.githubusercontent.com/u/31093031?v=4","gravatar_id":"","url":"https://api.github.com/users/delandmeterp","html_url":"https://github.com/delandmeterp","followers_url":"https://api.github.com/users/delandmeterp/followers","following_url":"https://api.github.com/users/delandmeterp/following{/other_user}","gists_url":"https://api.github.com/users/delandmeterp/gists{/gist_id}","starred_url":"https://api.github.com/users/delandmeterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delandmeterp/subscriptions","organizations_url":"https://api.github.com/users/delandmeterp/orgs","repos_url":"https://api.github.com/users/delandmeterp/repos","events_url":"https://api.github.com/users/delandmeterp/events{/privacy}","received_events_url":"https://api.github.com/users/delandmeterp/received_events","type":"User","site_admin":false},"body":"Why do we have to commits pynb with the outputs inside? It makes the diff complicate to read, and add unnecessary lines with no meaning. Or do you need it in order to visualise something on oceanparcels.org?\r\nThis file is really thousands of lines!","created_at":"2017-12-14T09:14:14Z","updated_at":"2017-12-14T09:23:25Z","html_url":"https://github.com/OceanParcels/parcels/pull/261#discussion_r156888078","pull_request_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/261","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments/156888078"},"html":{"href":"https://github.com/OceanParcels/parcels/pull/261#discussion_r156888078"},"pull_request":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/OceanParcels/parcels/pulls/261","id":157609557,"html_url":"https://github.com/OceanParcels/parcels/pull/261","diff_url":"https://github.com/OceanParcels/parcels/pull/261.diff","patch_url":"https://github.com/OceanParcels/parcels/pull/261.patch","issue_url":"https://api.github.com/repos/OceanParcels/parcels/issues/261","number":261,"state":"open","locked":false,"title":"Repeated particle release API","user":{"login":"erikvansebille","id":14315062,"avatar_url":"https://avatars0.githubusercontent.com/u/14315062?v=4","gravatar_id":"","url":"https://api.github.com/users/erikvansebille","html_url":"https://github.com/erikvansebille","followers_url":"https://api.github.com/users/erikvansebille/followers","following_url":"https://api.github.com/users/erikvansebille/following{/other_user}","gists_url":"https://api.github.com/users/erikvansebille/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvansebille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvansebille/subscriptions","organizations_url":"https://api.github.com/users/erikvansebille/orgs","repos_url":"https://api.github.com/users/erikvansebille/repos","events_url":"https://api.github.com/users/erikvansebille/events{/privacy}","received_events_url":"https://api.github.com/users/erikvansebille/received_events","type":"User","site_admin":false},"body":"This PR implements two different ways to control the time that particles are released during a `ParticleSet.execute()`, and fixes #258. \r\n\r\nPreviously, all particles were started at the same time (`starttime`). Now, the two options are (both are shown in the updated `tutorial_delaystart.ipynb` notebook):\r\n1. Users can control on a per-particle basis when a `Particle` is released (using the `time` argument in `ParticleSet` construction). \r\n2. Users can 're-release' a `ParticleSet` at a certain interval using the new `releasedt` argument in `ParticleSet` construction\r\n\r\nNote that this means that the `starttime` argument in `ParticleSet.execute()` does not control when particles are released anymore. This may cause some (minor) backward compatibility issues.\r\n\r\nIn fact, it might be simpler and more intuitive to remove `starttime` and `endtime` altogether, and rather have only `runtime` as argument in `ParticleSet.execute()` that controls the length of a simulation? But that is probably better dealt with in a next PR.","created_at":"2017-12-11T16:28:20Z","updated_at":"2017-12-14T09:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f49c472c477d8958669f1e6fb20f946983a0be1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/261/commits","review_comments_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/261/comments","review_comment_url":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OceanParcels/parcels/issues/261/comments","statuses_url":"https://api.github.com/repos/OceanParcels/parcels/statuses/1e30adf4fa2434a408545f37037e0d4a0112d3a6","head":{"label":"OceanParcels:repeated_particle_release_API","ref":"repeated_particle_release_API","sha":"1e30adf4fa2434a408545f37037e0d4a0112d3a6","user":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"repo":{"id":43358723,"name":"parcels","full_name":"OceanParcels/parcels","owner":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OceanParcels/parcels","description":"Main code for Parcels (Probably A Really Computationally Efficient Lagrangian Simulator)","fork":false,"url":"https://api.github.com/repos/OceanParcels/parcels","forks_url":"https://api.github.com/repos/OceanParcels/parcels/forks","keys_url":"https://api.github.com/repos/OceanParcels/parcels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OceanParcels/parcels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OceanParcels/parcels/teams","hooks_url":"https://api.github.com/repos/OceanParcels/parcels/hooks","issue_events_url":"https://api.github.com/repos/OceanParcels/parcels/issues/events{/number}","events_url":"https://api.github.com/repos/OceanParcels/parcels/events","assignees_url":"https://api.github.com/repos/OceanParcels/parcels/assignees{/user}","branches_url":"https://api.github.com/repos/OceanParcels/parcels/branches{/branch}","tags_url":"https://api.github.com/repos/OceanParcels/parcels/tags","blobs_url":"https://api.github.com/repos/OceanParcels/parcels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OceanParcels/parcels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OceanParcels/parcels/git/refs{/sha}","trees_url":"https://api.github.com/repos/OceanParcels/parcels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OceanParcels/parcels/statuses/{sha}","languages_url":"https://api.github.com/repos/OceanParcels/parcels/languages","stargazers_url":"https://api.github.com/repos/OceanParcels/parcels/stargazers","contributors_url":"https://api.github.com/repos/OceanParcels/parcels/contributors","subscribers_url":"https://api.github.com/repos/OceanParcels/parcels/subscribers","subscription_url":"https://api.github.com/repos/OceanParcels/parcels/subscription","commits_url":"https://api.github.com/repos/OceanParcels/parcels/commits{/sha}","git_commits_url":"https://api.github.com/repos/OceanParcels/parcels/git/commits{/sha}","comments_url":"https://api.github.com/repos/OceanParcels/parcels/comments{/number}","issue_comment_url":"https://api.github.com/repos/OceanParcels/parcels/issues/comments{/number}","contents_url":"https://api.github.com/repos/OceanParcels/parcels/contents/{+path}","compare_url":"https://api.github.com/repos/OceanParcels/parcels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OceanParcels/parcels/merges","archive_url":"https://api.github.com/repos/OceanParcels/parcels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OceanParcels/parcels/downloads","issues_url":"https://api.github.com/repos/OceanParcels/parcels/issues{/number}","pulls_url":"https://api.github.com/repos/OceanParcels/parcels/pulls{/number}","milestones_url":"https://api.github.com/repos/OceanParcels/parcels/milestones{/number}","notifications_url":"https://api.github.com/repos/OceanParcels/parcels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OceanParcels/parcels/labels{/name}","releases_url":"https://api.github.com/repos/OceanParcels/parcels/releases{/id}","deployments_url":"https://api.github.com/repos/OceanParcels/parcels/deployments","created_at":"2015-09-29T09:43:00Z","updated_at":"2017-11-23T22:36:57Z","pushed_at":"2017-12-13T18:43:04Z","git_url":"git://github.com/OceanParcels/parcels.git","ssh_url":"git@github.com:OceanParcels/parcels.git","clone_url":"https://github.com/OceanParcels/parcels.git","svn_url":"https://github.com/OceanParcels/parcels","homepage":"http://www.oceanparcels.org","size":5360,"stargazers_count":17,"watchers_count":17,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":16,"watchers":17,"default_branch":"master"}},"base":{"label":"OceanParcels:master","ref":"master","sha":"1c8218589305a128db9aed508b56a2962543a675","user":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"repo":{"id":43358723,"name":"parcels","full_name":"OceanParcels/parcels","owner":{"login":"OceanParcels","id":14887518,"avatar_url":"https://avatars3.githubusercontent.com/u/14887518?v=4","gravatar_id":"","url":"https://api.github.com/users/OceanParcels","html_url":"https://github.com/OceanParcels","followers_url":"https://api.github.com/users/OceanParcels/followers","following_url":"https://api.github.com/users/OceanParcels/following{/other_user}","gists_url":"https://api.github.com/users/OceanParcels/gists{/gist_id}","starred_url":"https://api.github.com/users/OceanParcels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OceanParcels/subscriptions","organizations_url":"https://api.github.com/users/OceanParcels/orgs","repos_url":"https://api.github.com/users/OceanParcels/repos","events_url":"https://api.github.com/users/OceanParcels/events{/privacy}","received_events_url":"https://api.github.com/users/OceanParcels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OceanParcels/parcels","description":"Main code for Parcels (Probably A Really Computationally Efficient Lagrangian Simulator)","fork":false,"url":"https://api.github.com/repos/OceanParcels/parcels","forks_url":"https://api.github.com/repos/OceanParcels/parcels/forks","keys_url":"https://api.github.com/repos/OceanParcels/parcels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OceanParcels/parcels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OceanParcels/parcels/teams","hooks_url":"https://api.github.com/repos/OceanParcels/parcels/hooks","issue_events_url":"https://api.github.com/repos/OceanParcels/parcels/issues/events{/number}","events_url":"https://api.github.com/repos/OceanParcels/parcels/events","assignees_url":"https://api.github.com/repos/OceanParcels/parcels/assignees{/user}","branches_url":"https://api.github.com/repos/OceanParcels/parcels/branches{/branch}","tags_url":"https://api.github.com/repos/OceanParcels/parcels/tags","blobs_url":"https://api.github.com/repos/OceanParcels/parcels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OceanParcels/parcels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OceanParcels/parcels/git/refs{/sha}","trees_url":"https://api.github.com/repos/OceanParcels/parcels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OceanParcels/parcels/statuses/{sha}","languages_url":"https://api.github.com/repos/OceanParcels/parcels/languages","stargazers_url":"https://api.github.com/repos/OceanParcels/parcels/stargazers","contributors_url":"https://api.github.com/repos/OceanParcels/parcels/contributors","subscribers_url":"https://api.github.com/repos/OceanParcels/parcels/subscribers","subscription_url":"https://api.github.com/repos/OceanParcels/parcels/subscription","commits_url":"https://api.github.com/repos/OceanParcels/parcels/commits{/sha}","git_commits_url":"https://api.github.com/repos/OceanParcels/parcels/git/commits{/sha}","comments_url":"https://api.github.com/repos/OceanParcels/parcels/comments{/number}","issue_comment_url":"https://api.github.com/repos/OceanParcels/parcels/issues/comments{/number}","contents_url":"https://api.github.com/repos/OceanParcels/parcels/contents/{+path}","compare_url":"https://api.github.com/repos/OceanParcels/parcels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OceanParcels/parcels/merges","archive_url":"https://api.github.com/repos/OceanParcels/parcels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OceanParcels/parcels/downloads","issues_url":"https://api.github.com/repos/OceanParcels/parcels/issues{/number}","pulls_url":"https://api.github.com/repos/OceanParcels/parcels/pulls{/number}","milestones_url":"https://api.github.com/repos/OceanParcels/parcels/milestones{/number}","notifications_url":"https://api.github.com/repos/OceanParcels/parcels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OceanParcels/parcels/labels{/name}","releases_url":"https://api.github.com/repos/OceanParcels/parcels/releases{/id}","deployments_url":"https://api.github.com/repos/OceanParcels/parcels/deployments","created_at":"2015-09-29T09:43:00Z","updated_at":"2017-11-23T22:36:57Z","pushed_at":"2017-12-13T18:43:04Z","git_url":"git://github.com/OceanParcels/parcels.git","ssh_url":"git@github.com:OceanParcels/parcels.git","clone_url":"https://github.com/OceanParcels/parcels.git","svn_url":"https://github.com/OceanParcels/parcels","homepage":"http://www.oceanparcels.org","size":5360,"stargazers_count":17,"watchers_count":17,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":16,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/261"},"html":{"href":"https://github.com/OceanParcels/parcels/pull/261"},"issue":{"href":"https://api.github.com/repos/OceanParcels/parcels/issues/261"},"comments":{"href":"https://api.github.com/repos/OceanParcels/parcels/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OceanParcels/parcels/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/OceanParcels/parcels/statuses/1e30adf4fa2434a408545f37037e0d4a0112d3a6"}},"author_association":"OWNER"}}
{"actor":{"display_login":"delandmeterp"}}