{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments/120953381","pull_request_review_id":42962005,"id":120953381,"diff_hunk":"@@ -135,6 +137,76 @@ const DisplayChangeDialog = new Lang.Class({\n     },\n });\n \n+const EOSShellWobbly = new Lang.Class({\n+    Name: 'EOSShellWobbly',\n+    Extends: EndlessShellFX.Wobbly,\n+    Properties: {\n+        'settings' : GObject.ParamSpec.object('settings',\n+                                              'Effect GSettings',\n+                                              'Wobbly Effect GSettings',\n+                                              GObject.ParamFlags.CONSTRUCT_ONLY |\n+                                              GObject.ParamFlags.WRITABLE,\n+                                              Gio.Settings)\n+    },\n+\n+    _init: function(params) {\n+        this.parent(params);\n+        this._settings = null;\n+    },\n+\n+    set settings (val)\n+    {\n+         if (val['schema-id'] !== 'org.gnome.shell')\n+             throw Error('EOSShellWobbly: Injected schema must be of ' +\n+                         'org.gnome.shell');\n+\n+         this._settings = val;\n+\n+         let binder = Lang.bind (this, function(key, prop) {\n+             this._settings.bind (key, this, prop, Gio.SettingsBindFlags.GET);\n+         });\n+\n+         /* Bind to effect properties */\n+         binder('wobbly-spring-k', 'spring-k');\n+         binder('wobbly-spring-friction', 'friction');\n+         binder('wobbly-slowdown-factor', 'slowdown-factor');\n+         binder('wobbly-object-movement-range', 'object-movement-range');\n+    },\n+\n+    grabbedByMouse: function() {\n+","path":"js/ui/windowManager.js","position":50,"original_position":50,"commit_id":"2eabd14dcee4924c742a1ecafb597dcb1724fd9b","original_commit_id":"2eabd14dcee4924c742a1ecafb597dcb1724fd9b","user":{"login":"cosimoc","id":13906,"avatar_url":"https://avatars2.githubusercontent.com/u/13906?v=3","gravatar_id":"","url":"https://api.github.com/users/cosimoc","html_url":"https://github.com/cosimoc","followers_url":"https://api.github.com/users/cosimoc/followers","following_url":"https://api.github.com/users/cosimoc/following{/other_user}","gists_url":"https://api.github.com/users/cosimoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cosimoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosimoc/subscriptions","organizations_url":"https://api.github.com/users/cosimoc/orgs","repos_url":"https://api.github.com/users/cosimoc/repos","events_url":"https://api.github.com/users/cosimoc/events{/privacy}","received_events_url":"https://api.github.com/users/cosimoc/received_events","type":"User","site_admin":false},"body":"Remove empty line","created_at":"2017-06-08T17:44:56Z","updated_at":"2017-06-08T17:47:00Z","html_url":"https://github.com/endlessm/gnome-shell/pull/23#discussion_r120953381","pull_request_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments/120953381"},"html":{"href":"https://github.com/endlessm/gnome-shell/pull/23#discussion_r120953381"},"pull_request":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23","id":124633974,"html_url":"https://github.com/endlessm/gnome-shell/pull/23","diff_url":"https://github.com/endlessm/gnome-shell/pull/23.diff","patch_url":"https://github.com/endlessm/gnome-shell/pull/23.patch","issue_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/23","number":23,"state":"open","locked":false,"title":"windowManager: Add wobbly windows.","user":{"login":"smspillaz","id":775309,"avatar_url":"https://avatars0.githubusercontent.com/u/775309?v=3","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"Link to libendless_wobbly (from libwobbly) and add a new\r\nEndlessShellFXWobbly class to bridge between a clutter effect\r\nand the wobbly::Model/wobbly::Anchor.\r\n\r\nUse endless_shell_fx_wobbly_grab to grab a point on the mesh\r\nand move it around.\r\n\r\nUse endless_shell_fx_wobbly_ungrab to release a point on the mesh.\r\n\r\nEach of the above functions may only be called once whilst in the\r\nopposing state and cannot be called again whilst in the same state.\r\n\r\nEOSShellWobbly is a JavaScript subclass of EndlessShellFXWobbly\r\nwhich handles integration between the shell itself and the wobbly\r\neffect. It provides API to handle mouse grab / ungrab of a window\r\nand window movement whilst grabbed.\r\n\r\nProvide the following new keys in org.gnome.shell:\r\n\r\n 'wobbly-spring-k' : Spring K\r\n 'wobbly-spring-friction' : Spring Friction\r\n 'wobbly-slowdown-factor' : Amount to slow effect down\r\n 'wobbly-object-movement-range' : Amount points on the mesh are\r\n  allowed to deviate from their target position once the mesh is\r\n  settled.\r\n\r\nhttps://phabricator.endlessm.com/T17123","created_at":"2017-06-08T12:05:14Z","updated_at":"2017-06-08T17:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbc2aebfaf7a31e567efdc285be43a66e6d91d4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23/commits","review_comments_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23/comments","review_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/23/comments","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/2eabd14dcee4924c742a1ecafb597dcb1724fd9b","head":{"label":"endlessm:T17123","ref":"T17123","sha":"2eabd14dcee4924c742a1ecafb597dcb1724fd9b","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":84589501,"name":"gnome-shell","full_name":"endlessm/gnome-shell","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/gnome-shell","description":"Fork of https://git.gnome.org/browse/gnome-shell","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-shell","forks_url":"https://api.github.com/repos/endlessm/gnome-shell/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-shell/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-shell/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-shell/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-shell/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-shell/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-shell/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-shell/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-shell/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-shell/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-shell/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-shell/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-shell/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-shell/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-shell/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-shell/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-shell/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-shell/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-shell/deployments","created_at":"2017-03-10T18:30:50Z","updated_at":"2017-05-04T06:26:43Z","pushed_at":"2017-06-08T16:58:58Z","git_url":"git://github.com/endlessm/gnome-shell.git","ssh_url":"git@github.com:endlessm/gnome-shell.git","clone_url":"https://github.com/endlessm/gnome-shell.git","svn_url":"https://github.com/endlessm/gnome-shell","homepage":null,"size":18212,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"16b8a4f3f8e763a833ee6c5ed90ea9476b30c5ba","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":84589501,"name":"gnome-shell","full_name":"endlessm/gnome-shell","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/gnome-shell","description":"Fork of https://git.gnome.org/browse/gnome-shell","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-shell","forks_url":"https://api.github.com/repos/endlessm/gnome-shell/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-shell/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-shell/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-shell/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-shell/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-shell/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-shell/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-shell/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-shell/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-shell/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-shell/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-shell/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-shell/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-shell/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-shell/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-shell/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-shell/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-shell/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-shell/deployments","created_at":"2017-03-10T18:30:50Z","updated_at":"2017-05-04T06:26:43Z","pushed_at":"2017-06-08T16:58:58Z","git_url":"git://github.com/endlessm/gnome-shell.git","ssh_url":"git@github.com:endlessm/gnome-shell.git","clone_url":"https://github.com/endlessm/gnome-shell.git","svn_url":"https://github.com/endlessm/gnome-shell","homepage":null,"size":18212,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23"},"html":{"href":"https://github.com/endlessm/gnome-shell/pull/23"},"issue":{"href":"https://api.github.com/repos/endlessm/gnome-shell/issues/23"},"comments":{"href":"https://api.github.com/repos/endlessm/gnome-shell/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/gnome-shell/statuses/2eabd14dcee4924c742a1ecafb597dcb1724fd9b"}}}}
{"actor":{"display_login":"cosimoc"}}