{"action":"created","comment":{"url":"https://api.github.com/repos/opesci/devito/pulls/comments/100089865","pull_request_review_id":20784659,"id":100089865,"diff_hunk":"@@ -112,14 +116,25 @@ def __init__(self, stencils, **kwargs):\n \n         # Now resolve and substitute dimensions for loop index variables\n         subs = {}\n-        nodes = ResolveIterationVariable().visit(nodes, subs=subs)\n+        variable_map = defaultdict(int)","path":"devito/stencilkernel.py","position":42,"original_position":42,"commit_id":"b2fe2e7c717a327f26d82d2bbe608f81ab0fda87","original_commit_id":"6912acc5654a866b508a46f9f4d3faac879b396d","user":{"login":"mlange05","id":5585005,"avatar_url":"https://avatars.githubusercontent.com/u/5585005?v=3","gravatar_id":"","url":"https://api.github.com/users/mlange05","html_url":"https://github.com/mlange05","followers_url":"https://api.github.com/users/mlange05/followers","following_url":"https://api.github.com/users/mlange05/following{/other_user}","gists_url":"https://api.github.com/users/mlange05/gists{/gist_id}","starred_url":"https://api.github.com/users/mlange05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlange05/subscriptions","organizations_url":"https://api.github.com/users/mlange05/orgs","repos_url":"https://api.github.com/users/mlange05/repos","events_url":"https://api.github.com/users/mlange05/events{/privacy}","received_events_url":"https://api.github.com/users/mlange05/received_events","type":"User","site_admin":false},"body":"I tried that, but I got some bizarre pseudo-caching that caused breakages and then I ran out of patience. I'll try again and investigate though.","created_at":"2017-02-08T15:24:50Z","updated_at":"2017-02-08T15:24:50Z","html_url":"https://github.com/opesci/devito/pull/187#discussion_r100089865","pull_request_url":"https://api.github.com/repos/opesci/devito/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments/100089865"},"html":{"href":"https://github.com/opesci/devito/pull/187#discussion_r100089865"},"pull_request":{"href":"https://api.github.com/repos/opesci/devito/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/opesci/devito/pulls/187","id":105231217,"html_url":"https://github.com/opesci/devito/pull/187","diff_url":"https://github.com/opesci/devito/pull/187.diff","patch_url":"https://github.com/opesci/devito/pull/187.patch","issue_url":"https://api.github.com/repos/opesci/devito/issues/187","number":187,"state":"open","locked":false,"title":"Tweaks, hacks and fixes to make Acoustic-Forward run with Devito-3.0","user":{"login":"mlange05","id":5585005,"avatar_url":"https://avatars.githubusercontent.com/u/5585005?v=3","gravatar_id":"","url":"https://api.github.com/users/mlange05","html_url":"https://github.com/mlange05","followers_url":"https://api.github.com/users/mlange05/followers","following_url":"https://api.github.com/users/mlange05/following{/other_user}","gists_url":"https://api.github.com/users/mlange05/gists{/gist_id}","starred_url":"https://api.github.com/users/mlange05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlange05/subscriptions","organizations_url":"https://api.github.com/users/mlange05/orgs","repos_url":"https://api.github.com/users/mlange05/repos","events_url":"https://api.github.com/users/mlange05/events{/privacy}","received_events_url":"https://api.github.com/users/mlange05/received_events","type":"User","site_admin":false},"body":"**WARNING: This merge contains temporary hacks that are necessary due to legacy restrictions. It also attempts to clean a few things for acoustic test, but it does not attempt a full clean-up of our seismic examples. A full clean-up of the examples and a more rigorous generalisation of the temporary hacks will be attempted soon.**\r\n\r\nSo, this PR really contains a series of \"as-clean-as-currently-possible\" changes and fixes to adjust the Acoustic Forward runs to the 3.0 API. It introduces a `legacy` flag on the acoustic examples classes that allows us to switch between the two modes seamlessly and thus compare and contrast. The 3.0 route is not exhaustively tested yet, but it should allow us to run preliminary performance benchmarks to get an overview of how 3.0 will do and fix issues before they arise.\r\n\r\nIn particular we do:\r\n* New and improved treatment of buffered dimensions (eg. time)\r\n* Lift src/rec and wavefield creation to the `Acoustic_cg` wrappers to avoid call signature clashes\r\n* Minor clean up of `test_adjoint` and `test_gradient`.\r\n* Lift necessary time substitutions to the wrapper layer\r\n* Tweaks to the interpolation symbolics","created_at":"2017-02-08T14:48:34Z","updated_at":"2017-02-08T15:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94250c6991ba19ed4a95a686f5d2c96a08b22def","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opesci/devito/pulls/187/commits","review_comments_url":"https://api.github.com/repos/opesci/devito/pulls/187/comments","review_comment_url":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opesci/devito/issues/187/comments","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/b2fe2e7c717a327f26d82d2bbe608f81ab0fda87","head":{"label":"opesci:stencilkernel-acoustic","ref":"stencilkernel-acoustic","sha":"b2fe2e7c717a327f26d82d2bbe608f81ab0fda87","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation framework for automated finite difference computation","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2017-01-28T11:03:57Z","pushed_at":"2017-02-08T15:20:58Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":"http://www.opesci.org/devito-public","size":22035,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":18,"forks":2,"open_issues":18,"watchers":7,"default_branch":"master"}},"base":{"label":"opesci:master","ref":"master","sha":"72ffde835e42e1b337e608a0dfecb4262aa42b71","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation framework for automated finite difference computation","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2017-01-28T11:03:57Z","pushed_at":"2017-02-08T15:20:58Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":"http://www.opesci.org/devito-public","size":22035,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":18,"forks":2,"open_issues":18,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/187"},"html":{"href":"https://github.com/opesci/devito/pull/187"},"issue":{"href":"https://api.github.com/repos/opesci/devito/issues/187"},"comments":{"href":"https://api.github.com/repos/opesci/devito/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/opesci/devito/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opesci/devito/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/opesci/devito/statuses/b2fe2e7c717a327f26d82d2bbe608f81ab0fda87"}}}}
{"actor":{"display_login":"mlange05"}}