{"action":"created","comment":{"url":"https://api.github.com/repos/docker/notary/pulls/comments/109070692","pull_request_review_id":30149005,"id":109070692,"diff_hunk":"@@ -363,6 +363,26 @@ func TestValidateRootWithPinnedCertAndIntermediates(t *testing.T) {\n \t\t}\n \t}\n \trequire.Equal(t, typedSignedRoot, validatedRoot)\n+\n+\t// test is also works with a wildcarded gun in certs","path":"trustpinning/certs_test.go","position":5,"original_position":5,"commit_id":"d7352fcd6725f94dbd9d73d651ef49d564689a30","original_commit_id":"d7352fcd6725f94dbd9d73d651ef49d564689a30","user":{"login":"riyazdf","id":1865981,"avatar_url":"https://avatars0.githubusercontent.com/u/1865981?v=3","gravatar_id":"","url":"https://api.github.com/users/riyazdf","html_url":"https://github.com/riyazdf","followers_url":"https://api.github.com/users/riyazdf/followers","following_url":"https://api.github.com/users/riyazdf/following{/other_user}","gists_url":"https://api.github.com/users/riyazdf/gists{/gist_id}","starred_url":"https://api.github.com/users/riyazdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyazdf/subscriptions","organizations_url":"https://api.github.com/users/riyazdf/orgs","repos_url":"https://api.github.com/users/riyazdf/repos","events_url":"https://api.github.com/users/riyazdf/events{/privacy}","received_events_url":"https://api.github.com/users/riyazdf/received_events","type":"User","site_admin":false},"body":"super nit: s/is/it/","created_at":"2017-03-31T01:04:35Z","updated_at":"2017-03-31T01:11:47Z","html_url":"https://github.com/docker/notary/pull/1126#discussion_r109070692","pull_request_url":"https://api.github.com/repos/docker/notary/pulls/1126","_links":{"self":{"href":"https://api.github.com/repos/docker/notary/pulls/comments/109070692"},"html":{"href":"https://github.com/docker/notary/pull/1126#discussion_r109070692"},"pull_request":{"href":"https://api.github.com/repos/docker/notary/pulls/1126"}}},"pull_request":{"url":"https://api.github.com/repos/docker/notary/pulls/1126","id":113481029,"html_url":"https://github.com/docker/notary/pull/1126","diff_url":"https://github.com/docker/notary/pull/1126.diff","patch_url":"https://github.com/docker/notary/pull/1126.patch","issue_url":"https://api.github.com/repos/docker/notary/issues/1126","number":1126,"state":"open","locked":false,"title":"wildcarded trustpinning for cert ids","user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars2.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"body":"Closes #1123 \r\n\r\nSigned-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)","created_at":"2017-03-30T17:20:58Z","updated_at":"2017-03-31T01:11:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0753d7e25c17cc48f3c9c929af3718dd473fb883","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/notary/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/docker/notary/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/docker/notary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/notary/issues/1126/comments","statuses_url":"https://api.github.com/repos/docker/notary/statuses/d7352fcd6725f94dbd9d73d651ef49d564689a30","head":{"label":"endophage:wildcard_trustpin_key","ref":"wildcard_trustpin_key","sha":"d7352fcd6725f94dbd9d73d651ef49d564689a30","user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars2.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"repo":{"id":37937558,"name":"notary","full_name":"endophage/notary","owner":{"login":"endophage","id":1302091,"avatar_url":"https://avatars2.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endophage/notary","description":null,"fork":true,"url":"https://api.github.com/repos/endophage/notary","forks_url":"https://api.github.com/repos/endophage/notary/forks","keys_url":"https://api.github.com/repos/endophage/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endophage/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endophage/notary/teams","hooks_url":"https://api.github.com/repos/endophage/notary/hooks","issue_events_url":"https://api.github.com/repos/endophage/notary/issues/events{/number}","events_url":"https://api.github.com/repos/endophage/notary/events","assignees_url":"https://api.github.com/repos/endophage/notary/assignees{/user}","branches_url":"https://api.github.com/repos/endophage/notary/branches{/branch}","tags_url":"https://api.github.com/repos/endophage/notary/tags","blobs_url":"https://api.github.com/repos/endophage/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endophage/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endophage/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/endophage/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endophage/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/endophage/notary/languages","stargazers_url":"https://api.github.com/repos/endophage/notary/stargazers","contributors_url":"https://api.github.com/repos/endophage/notary/contributors","subscribers_url":"https://api.github.com/repos/endophage/notary/subscribers","subscription_url":"https://api.github.com/repos/endophage/notary/subscription","commits_url":"https://api.github.com/repos/endophage/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/endophage/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/endophage/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/endophage/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/endophage/notary/contents/{+path}","compare_url":"https://api.github.com/repos/endophage/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endophage/notary/merges","archive_url":"https://api.github.com/repos/endophage/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endophage/notary/downloads","issues_url":"https://api.github.com/repos/endophage/notary/issues{/number}","pulls_url":"https://api.github.com/repos/endophage/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/endophage/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/endophage/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endophage/notary/labels{/name}","releases_url":"https://api.github.com/repos/endophage/notary/releases{/id}","deployments_url":"https://api.github.com/repos/endophage/notary/deployments","created_at":"2015-06-23T18:35:21Z","updated_at":"2016-11-07T22:41:01Z","pushed_at":"2017-03-30T18:01:42Z","git_url":"git://github.com/endophage/notary.git","ssh_url":"git@github.com:endophage/notary.git","clone_url":"https://github.com/endophage/notary.git","svn_url":"https://github.com/endophage/notary","homepage":"","size":29501,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"ff7a2868d681985d3f35919fdf62f459d509ee60","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":37743436,"name":"notary","full_name":"docker/notary","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/notary","description":"Notary is a Docker project that allows anyone to have trust over arbitrary collections of data","fork":false,"url":"https://api.github.com/repos/docker/notary","forks_url":"https://api.github.com/repos/docker/notary/forks","keys_url":"https://api.github.com/repos/docker/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/notary/teams","hooks_url":"https://api.github.com/repos/docker/notary/hooks","issue_events_url":"https://api.github.com/repos/docker/notary/issues/events{/number}","events_url":"https://api.github.com/repos/docker/notary/events","assignees_url":"https://api.github.com/repos/docker/notary/assignees{/user}","branches_url":"https://api.github.com/repos/docker/notary/branches{/branch}","tags_url":"https://api.github.com/repos/docker/notary/tags","blobs_url":"https://api.github.com/repos/docker/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/notary/languages","stargazers_url":"https://api.github.com/repos/docker/notary/stargazers","contributors_url":"https://api.github.com/repos/docker/notary/contributors","subscribers_url":"https://api.github.com/repos/docker/notary/subscribers","subscription_url":"https://api.github.com/repos/docker/notary/subscription","commits_url":"https://api.github.com/repos/docker/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/notary/contents/{+path}","compare_url":"https://api.github.com/repos/docker/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/notary/merges","archive_url":"https://api.github.com/repos/docker/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/notary/downloads","issues_url":"https://api.github.com/repos/docker/notary/issues{/number}","pulls_url":"https://api.github.com/repos/docker/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/notary/labels{/name}","releases_url":"https://api.github.com/repos/docker/notary/releases{/id}","deployments_url":"https://api.github.com/repos/docker/notary/deployments","created_at":"2015-06-19T20:07:53Z","updated_at":"2017-03-30T07:14:10Z","pushed_at":"2017-03-30T19:07:17Z","git_url":"git://github.com/docker/notary.git","ssh_url":"git@github.com:docker/notary.git","clone_url":"https://github.com/docker/notary.git","svn_url":"https://github.com/docker/notary","homepage":"https://docker.com","size":29495,"stargazers_count":828,"watchers_count":828,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":133,"forks":141,"open_issues":133,"watchers":828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/notary/pulls/1126"},"html":{"href":"https://github.com/docker/notary/pull/1126"},"issue":{"href":"https://api.github.com/repos/docker/notary/issues/1126"},"comments":{"href":"https://api.github.com/repos/docker/notary/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/notary/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/notary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/notary/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/docker/notary/statuses/d7352fcd6725f94dbd9d73d651ef49d564689a30"}}}}
{"actor":{"display_login":"riyazdf"}}