{"action":"created","issue":{"url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/847","repository_url":"https://api.github.com/repos/arquillian/arquillian-cube","labels_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/847/labels{/name}","comments_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/847/comments","events_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/847/events","html_url":"https://github.com/arquillian/arquillian-cube/pull/847","id":274060164,"number":847,"title":"WIP Discussion needed! Renaming containes so that port remapping may work with wild star operator","user":{"login":"jelmew","id":11734407,"avatar_url":"https://avatars2.githubusercontent.com/u/11734407?v=4","gravatar_id":"","url":"https://api.github.com/users/jelmew","html_url":"https://github.com/jelmew","followers_url":"https://api.github.com/users/jelmew/followers","following_url":"https://api.github.com/users/jelmew/following{/other_user}","gists_url":"https://api.github.com/users/jelmew/gists{/gist_id}","starred_url":"https://api.github.com/users/jelmew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelmew/subscriptions","organizations_url":"https://api.github.com/users/jelmew/orgs","repos_url":"https://api.github.com/users/jelmew/repos","events_url":"https://api.github.com/users/jelmew/events{/privacy}","received_events_url":"https://api.github.com/users/jelmew/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-15T07:32:01Z","updated_at":"2017-12-01T08:45:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/847","html_url":"https://github.com/arquillian/arquillian-cube/pull/847","diff_url":"https://github.com/arquillian/arquillian-cube/pull/847.diff","patch_url":"https://github.com/arquillian/arquillian-cube/pull/847.patch"},"body":"#### Short description of what this resolves:\r\nWhen using the wildcard operator, the arquillian container name does not match with the name of the cubeContainer. Therefore, when using random ports, these will not be remapped since in the ConfigurationController, it will look up cubes using the 'nameWithWildCard', and the arquillian container has as a 'nameWithoutWildcards.' For a more in-depth description, see issue (https://github.com/arquillian/arquillian-cube/issues/828)\r\n\r\n#### Changes proposed in this pull request:\r\nDiscussion: Currently this pull request updates the containerName to match with the cubeContainer using reflection.  An alternative solution would be to add an extra property to CubeContainer (let's just refer to it as the arquillianContainerName) and to match in containerConfigurationController using this name. Which one is prefered? After some nights of sleep, I would prefer to add an extra property instead of using reflection (which might break), but looking at the code, I don't know how feasible that is.\r\n\r\n\r\n\r\nFixes #\r\nhttps://github.com/arquillian/arquillian-cube/issues/828\r\n"},"comment":{"url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/comments/348436691","html_url":"https://github.com/arquillian/arquillian-cube/pull/847#issuecomment-348436691","issue_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/847","id":348436691,"user":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars2.githubusercontent.com/u/1517153?v=4","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"created_at":"2017-12-01T08:45:33Z","updated_at":"2017-12-01T08:45:33Z","author_association":"OWNER","body":"Ok I see that this solution might be a good solution for this use case. Can you fix the errors that makes build not passing? If `nip` site comes again to live, I'll release a new version today."}}
{"actor":{"display_login":"lordofthejars"}}