{"action":"created","comment":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/comments/128776469","pull_request_review_id":51491210,"id":128776469,"diff_hunk":"@@ -0,0 +1,71 @@\n+import json\n+import os\n+\n+from coalib.bearlib.abstractions.Linter import linter\n+from coalib.bears.GlobalBear import GlobalBear\n+from coalib.misc.Shell import run_shell_command","path":"bears/rust/RustClippyLintBear.py","position":6,"original_position":6,"commit_id":"a36dadea6a097ab7d77fbfb7caf11efd77c09078","original_commit_id":"1f5d1d9a7e8140bc5132db931b51ef09e8db7d85","user":{"login":"Makman2","id":6023916,"avatar_url":"https://avatars3.githubusercontent.com/u/6023916?v=4","gravatar_id":"","url":"https://api.github.com/users/Makman2","html_url":"https://github.com/Makman2","followers_url":"https://api.github.com/users/Makman2/followers","following_url":"https://api.github.com/users/Makman2/following{/other_user}","gists_url":"https://api.github.com/users/Makman2/gists{/gist_id}","starred_url":"https://api.github.com/users/Makman2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makman2/subscriptions","organizations_url":"https://api.github.com/users/Makman2/orgs","repos_url":"https://api.github.com/users/Makman2/repos","events_url":"https://api.github.com/users/Makman2/events{/privacy}","received_events_url":"https://api.github.com/users/Makman2/received_events","type":"User","site_admin":false},"body":"unused import :)","created_at":"2017-07-21T14:33:05Z","updated_at":"2017-07-21T14:33:05Z","html_url":"https://github.com/coala/coala-bears/pull/1467#discussion_r128776469","pull_request_url":"https://api.github.com/repos/coala/coala-bears/pulls/1467","_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments/128776469"},"html":{"href":"https://github.com/coala/coala-bears/pull/1467#discussion_r128776469"},"pull_request":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1467"}}},"pull_request":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/1467","id":108167477,"html_url":"https://github.com/coala/coala-bears/pull/1467","diff_url":"https://github.com/coala/coala-bears/pull/1467.diff","patch_url":"https://github.com/coala/coala-bears/pull/1467.patch","issue_url":"https://api.github.com/repos/coala/coala-bears/issues/1467","number":1467,"state":"open","locked":false,"title":"Rust Clippy","user":{"login":"rubdos","id":1263440,"avatar_url":"https://avatars2.githubusercontent.com/u/1263440?v=4","gravatar_id":"","url":"https://api.github.com/users/rubdos","html_url":"https://github.com/rubdos","followers_url":"https://api.github.com/users/rubdos/followers","following_url":"https://api.github.com/users/rubdos/following{/other_user}","gists_url":"https://api.github.com/users/rubdos/gists{/gist_id}","starred_url":"https://api.github.com/users/rubdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubdos/subscriptions","organizations_url":"https://api.github.com/users/rubdos/orgs","repos_url":"https://api.github.com/users/rubdos/repos","events_url":"https://api.github.com/users/rubdos/events{/privacy}","received_events_url":"https://api.github.com/users/rubdos/received_events","type":"User","site_admin":false},"body":"This is mostly finished now. This integrates [rust-clippy](https://github.com/Manishearth/rust-clippy) with `coala`, which is the de-facto standard linter for Rust.\r\n\r\nI had to work around some stuff. CircleCI uses a rewrite for github clone urls in their default .gitconfig file. As `cargo`, which is the Rust package manager, doesn't like that, I had to circumvent that. When [this issue](https://github.com/rust-lang/cargo/issues/2078), which I am tracking, closes, I'll come and remove the workaround. It consists of the `git config --global --unset url.ssh://git@github.com:.insteadof` option in checkout: post, and the if test in the `.ci/deps.sh` file. The if test is there to distinguish CircleCI from travis at that point.\r\n\r\nOn Windows, the `clippy` linter needs some weird directories in its `PATH`, because of [this Rust bug](https://github.com/rust-lang/cargo/issues/2078).\r\n\r\nAll workarounds are annotated in the source code.\r\n\r\n### Checklist\r\n\r\n- [x] I read the [commit guidelines](http://coala.io/commit) and I've followed\r\n      them.\r\n- [x] I ran coala over my code locally. (*All commits have to pass\r\n      individually.* It is not sufficient to have \"fixup commits\" on your PR,\r\n      our bot will still report the issues for the previous commit.) You will\r\n      likely receive a lot of bot comments and build failures if coala does not\r\n      pass on every single commit!\r\n\r\n### TODO\r\n\r\n- [x] Use `rustup.rs` instead of `rustup.sh`. The former is the successor of the latter. We don't want to have to change that, if we can have it today! :)\r\n- [ ] @jayvdb says this is blocked on https://github.com/coala/coala/issues/3867","created_at":"2017-02-27T17:55:00Z","updated_at":"2017-07-21T14:33:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f90a3b29de4291a718799edf751304eef6e8d38","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/coala/coala-bears/milestones/13","html_url":"https://github.com/coala/coala-bears/milestone/13","labels_url":"https://api.github.com/repos/coala/coala-bears/milestones/13/labels","id":2479217,"number":13,"title":"0.12","description":"","creator":{"login":"jayvdb","id":15092,"avatar_url":"https://avatars1.githubusercontent.com/u/15092?v=4","gravatar_id":"","url":"https://api.github.com/users/jayvdb","html_url":"https://github.com/jayvdb","followers_url":"https://api.github.com/users/jayvdb/followers","following_url":"https://api.github.com/users/jayvdb/following{/other_user}","gists_url":"https://api.github.com/users/jayvdb/gists{/gist_id}","starred_url":"https://api.github.com/users/jayvdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayvdb/subscriptions","organizations_url":"https://api.github.com/users/jayvdb/orgs","repos_url":"https://api.github.com/users/jayvdb/repos","events_url":"https://api.github.com/users/jayvdb/events{/privacy}","received_events_url":"https://api.github.com/users/jayvdb/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":4,"state":"open","created_at":"2017-04-25T06:12:11Z","updated_at":"2017-07-14T01:25:33Z","due_on":"2017-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coala/coala-bears/pulls/1467/commits","review_comments_url":"https://api.github.com/repos/coala/coala-bears/pulls/1467/comments","review_comment_url":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/coala-bears/issues/1467/comments","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/a36dadea6a097ab7d77fbfb7caf11efd77c09078","head":{"label":"rubdos:rust-clippy","ref":"rust-clippy","sha":"a36dadea6a097ab7d77fbfb7caf11efd77c09078","user":{"login":"rubdos","id":1263440,"avatar_url":"https://avatars2.githubusercontent.com/u/1263440?v=4","gravatar_id":"","url":"https://api.github.com/users/rubdos","html_url":"https://github.com/rubdos","followers_url":"https://api.github.com/users/rubdos/followers","following_url":"https://api.github.com/users/rubdos/following{/other_user}","gists_url":"https://api.github.com/users/rubdos/gists{/gist_id}","starred_url":"https://api.github.com/users/rubdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubdos/subscriptions","organizations_url":"https://api.github.com/users/rubdos/orgs","repos_url":"https://api.github.com/users/rubdos/repos","events_url":"https://api.github.com/users/rubdos/events{/privacy}","received_events_url":"https://api.github.com/users/rubdos/received_events","type":"User","site_admin":false},"repo":{"id":83331025,"name":"coala-bears","full_name":"rubdos/coala-bears","owner":{"login":"rubdos","id":1263440,"avatar_url":"https://avatars2.githubusercontent.com/u/1263440?v=4","gravatar_id":"","url":"https://api.github.com/users/rubdos","html_url":"https://github.com/rubdos","followers_url":"https://api.github.com/users/rubdos/followers","following_url":"https://api.github.com/users/rubdos/following{/other_user}","gists_url":"https://api.github.com/users/rubdos/gists{/gist_id}","starred_url":"https://api.github.com/users/rubdos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubdos/subscriptions","organizations_url":"https://api.github.com/users/rubdos/orgs","repos_url":"https://api.github.com/users/rubdos/repos","events_url":"https://api.github.com/users/rubdos/events{/privacy}","received_events_url":"https://api.github.com/users/rubdos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubdos/coala-bears","description":"Bears for coala","fork":true,"url":"https://api.github.com/repos/rubdos/coala-bears","forks_url":"https://api.github.com/repos/rubdos/coala-bears/forks","keys_url":"https://api.github.com/repos/rubdos/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubdos/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubdos/coala-bears/teams","hooks_url":"https://api.github.com/repos/rubdos/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/rubdos/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/rubdos/coala-bears/events","assignees_url":"https://api.github.com/repos/rubdos/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/rubdos/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/rubdos/coala-bears/tags","blobs_url":"https://api.github.com/repos/rubdos/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubdos/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubdos/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubdos/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubdos/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/rubdos/coala-bears/languages","stargazers_url":"https://api.github.com/repos/rubdos/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/rubdos/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/rubdos/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/rubdos/coala-bears/subscription","commits_url":"https://api.github.com/repos/rubdos/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubdos/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubdos/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubdos/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubdos/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/rubdos/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubdos/coala-bears/merges","archive_url":"https://api.github.com/repos/rubdos/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubdos/coala-bears/downloads","issues_url":"https://api.github.com/repos/rubdos/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/rubdos/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/rubdos/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/rubdos/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubdos/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/rubdos/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/rubdos/coala-bears/deployments","created_at":"2017-02-27T16:21:14Z","updated_at":"2017-02-27T16:21:16Z","pushed_at":"2017-07-21T13:54:07Z","git_url":"git://github.com/rubdos/coala-bears.git","ssh_url":"git@github.com:rubdos/coala-bears.git","clone_url":"https://github.com/rubdos/coala-bears.git","svn_url":"https://github.com/rubdos/coala-bears","homepage":"https://coala.io/","size":1769,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"1d3182700dc80785ba7be703f439540c156134fc","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":51688289,"name":"coala-bears","full_name":"coala/coala-bears","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/coala-bears","description":"Bears for coala","fork":false,"url":"https://api.github.com/repos/coala/coala-bears","forks_url":"https://api.github.com/repos/coala/coala-bears/forks","keys_url":"https://api.github.com/repos/coala/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala-bears/teams","hooks_url":"https://api.github.com/repos/coala/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/coala/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala-bears/events","assignees_url":"https://api.github.com/repos/coala/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala-bears/tags","blobs_url":"https://api.github.com/repos/coala/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala-bears/languages","stargazers_url":"https://api.github.com/repos/coala/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/coala/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/coala/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/coala/coala-bears/subscription","commits_url":"https://api.github.com/repos/coala/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala-bears/merges","archive_url":"https://api.github.com/repos/coala/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala-bears/downloads","issues_url":"https://api.github.com/repos/coala/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala-bears/deployments","created_at":"2016-02-14T09:25:11Z","updated_at":"2017-07-07T10:48:01Z","pushed_at":"2017-07-21T14:13:26Z","git_url":"git://github.com/coala/coala-bears.git","ssh_url":"git@github.com:coala/coala-bears.git","clone_url":"https://github.com/coala/coala-bears.git","svn_url":"https://github.com/coala/coala-bears","homepage":"https://coala.io/","size":1797,"stargazers_count":118,"watchers_count":118,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":314,"mirror_url":null,"open_issues_count":485,"forks":314,"open_issues":485,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1467"},"html":{"href":"https://github.com/coala/coala-bears/pull/1467"},"issue":{"href":"https://api.github.com/repos/coala/coala-bears/issues/1467"},"comments":{"href":"https://api.github.com/repos/coala/coala-bears/issues/1467/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1467/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/1467/commits"},"statuses":{"href":"https://api.github.com/repos/coala/coala-bears/statuses/a36dadea6a097ab7d77fbfb7caf11efd77c09078"}}}}
{"actor":{"display_login":"Makman2"}}