{"action":"closed","number":94,"pull_request":{"url":"https://api.github.com/repos/nical/lyon/pulls/94","id":127591411,"html_url":"https://github.com/nical/lyon/pull/94","diff_url":"https://github.com/nical/lyon/pull/94.diff","patch_url":"https://github.com/nical/lyon/pull/94.patch","issue_url":"https://api.github.com/repos/nical/lyon/issues/94","number":94,"state":"closed","locked":false,"title":"Path fill tessellator bug fixes.","user":{"login":"nical","id":264854,"avatar_url":"https://avatars1.githubusercontent.com/u/264854?v=3","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"body":"I had time to kill on a flight today so I added a way to create minimal test cases when tessellating paths using the cli tool (passing the `-d` or `--debug` option to the `tessellate` sub-command will try to reduce the path until the bug stops reproducing if an error happens during tessellation, and dump the test case to stdout).\r\nFrom there I:\r\n\r\n - Worked around a problem that seems to happen when converting fixed-point coordinates back to f32 with some precision less that make a point appear slightly above another when it should be equal or slightly below, which would hit an assertion. The real fix for this might be to move to a more serious fixed point number implementation.\r\n - Fixed a very (shameful) bug in the path tessellator that I thought I had dealt with long ago (but apparently not), which was that some edges were not processed by the tessellator if the path is not manually closed (leading to an assertion in the middle of the tessellation).","created_at":"2017-06-27T00:39:36Z","updated_at":"2017-06-27T00:56:30Z","closed_at":"2017-06-27T00:56:30Z","merged_at":"2017-06-27T00:56:30Z","merge_commit_sha":"ca4e321d7d466f401f7437ccc2baa1757dc64fd1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nical/lyon/pulls/94/commits","review_comments_url":"https://api.github.com/repos/nical/lyon/pulls/94/comments","review_comment_url":"https://api.github.com/repos/nical/lyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nical/lyon/issues/94/comments","statuses_url":"https://api.github.com/repos/nical/lyon/statuses/7116080636a98c21df20d3830e35622708101734","head":{"label":"nical:fixed-to-f32-error","ref":"fixed-to-f32-error","sha":"7116080636a98c21df20d3830e35622708101734","user":{"login":"nical","id":264854,"avatar_url":"https://avatars1.githubusercontent.com/u/264854?v=3","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"repo":{"id":59888340,"name":"lyon","full_name":"nical/lyon","owner":{"login":"nical","id":264854,"avatar_url":"https://avatars1.githubusercontent.com/u/264854?v=3","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nical/lyon","description":"2D graphics rendering experiments in rust.","fork":false,"url":"https://api.github.com/repos/nical/lyon","forks_url":"https://api.github.com/repos/nical/lyon/forks","keys_url":"https://api.github.com/repos/nical/lyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nical/lyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nical/lyon/teams","hooks_url":"https://api.github.com/repos/nical/lyon/hooks","issue_events_url":"https://api.github.com/repos/nical/lyon/issues/events{/number}","events_url":"https://api.github.com/repos/nical/lyon/events","assignees_url":"https://api.github.com/repos/nical/lyon/assignees{/user}","branches_url":"https://api.github.com/repos/nical/lyon/branches{/branch}","tags_url":"https://api.github.com/repos/nical/lyon/tags","blobs_url":"https://api.github.com/repos/nical/lyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nical/lyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nical/lyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/nical/lyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nical/lyon/statuses/{sha}","languages_url":"https://api.github.com/repos/nical/lyon/languages","stargazers_url":"https://api.github.com/repos/nical/lyon/stargazers","contributors_url":"https://api.github.com/repos/nical/lyon/contributors","subscribers_url":"https://api.github.com/repos/nical/lyon/subscribers","subscription_url":"https://api.github.com/repos/nical/lyon/subscription","commits_url":"https://api.github.com/repos/nical/lyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/nical/lyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/nical/lyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/nical/lyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/nical/lyon/contents/{+path}","compare_url":"https://api.github.com/repos/nical/lyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nical/lyon/merges","archive_url":"https://api.github.com/repos/nical/lyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nical/lyon/downloads","issues_url":"https://api.github.com/repos/nical/lyon/issues{/number}","pulls_url":"https://api.github.com/repos/nical/lyon/pulls{/number}","milestones_url":"https://api.github.com/repos/nical/lyon/milestones{/number}","notifications_url":"https://api.github.com/repos/nical/lyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nical/lyon/labels{/name}","releases_url":"https://api.github.com/repos/nical/lyon/releases{/id}","deployments_url":"https://api.github.com/repos/nical/lyon/deployments","created_at":"2016-05-28T10:01:04Z","updated_at":"2017-06-23T22:02:14Z","pushed_at":"2017-06-27T00:56:30Z","git_url":"git://github.com/nical/lyon.git","ssh_url":"git@github.com:nical/lyon.git","clone_url":"https://github.com/nical/lyon.git","svn_url":"https://github.com/nical/lyon","homepage":null,"size":1720,"stargazers_count":186,"watchers_count":186,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":28,"forks":18,"open_issues":28,"watchers":186,"default_branch":"master"}},"base":{"label":"nical:master","ref":"master","sha":"0fd9aad3ded0314c2093b7008e11f869b451d127","user":{"login":"nical","id":264854,"avatar_url":"https://avatars1.githubusercontent.com/u/264854?v=3","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"repo":{"id":59888340,"name":"lyon","full_name":"nical/lyon","owner":{"login":"nical","id":264854,"avatar_url":"https://avatars1.githubusercontent.com/u/264854?v=3","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nical/lyon","description":"2D graphics rendering experiments in rust.","fork":false,"url":"https://api.github.com/repos/nical/lyon","forks_url":"https://api.github.com/repos/nical/lyon/forks","keys_url":"https://api.github.com/repos/nical/lyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nical/lyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nical/lyon/teams","hooks_url":"https://api.github.com/repos/nical/lyon/hooks","issue_events_url":"https://api.github.com/repos/nical/lyon/issues/events{/number}","events_url":"https://api.github.com/repos/nical/lyon/events","assignees_url":"https://api.github.com/repos/nical/lyon/assignees{/user}","branches_url":"https://api.github.com/repos/nical/lyon/branches{/branch}","tags_url":"https://api.github.com/repos/nical/lyon/tags","blobs_url":"https://api.github.com/repos/nical/lyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nical/lyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nical/lyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/nical/lyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nical/lyon/statuses/{sha}","languages_url":"https://api.github.com/repos/nical/lyon/languages","stargazers_url":"https://api.github.com/repos/nical/lyon/stargazers","contributors_url":"https://api.github.com/repos/nical/lyon/contributors","subscribers_url":"https://api.github.com/repos/nical/lyon/subscribers","subscription_url":"https://api.github.com/repos/nical/lyon/subscription","commits_url":"https://api.github.com/repos/nical/lyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/nical/lyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/nical/lyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/nical/lyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/nical/lyon/contents/{+path}","compare_url":"https://api.github.com/repos/nical/lyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nical/lyon/merges","archive_url":"https://api.github.com/repos/nical/lyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nical/lyon/downloads","issues_url":"https://api.github.com/repos/nical/lyon/issues{/number}","pulls_url":"https://api.github.com/repos/nical/lyon/pulls{/number}","milestones_url":"https://api.github.com/repos/nical/lyon/milestones{/number}","notifications_url":"https://api.github.com/repos/nical/lyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nical/lyon/labels{/name}","releases_url":"https://api.github.com/repos/nical/lyon/releases{/id}","deployments_url":"https://api.github.com/repos/nical/lyon/deployments","created_at":"2016-05-28T10:01:04Z","updated_at":"2017-06-23T22:02:14Z","pushed_at":"2017-06-27T00:56:30Z","git_url":"git://github.com/nical/lyon.git","ssh_url":"git@github.com:nical/lyon.git","clone_url":"https://github.com/nical/lyon.git","svn_url":"https://github.com/nical/lyon","homepage":null,"size":1720,"stargazers_count":186,"watchers_count":186,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":28,"forks":18,"open_issues":28,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nical/lyon/pulls/94"},"html":{"href":"https://github.com/nical/lyon/pull/94"},"issue":{"href":"https://api.github.com/repos/nical/lyon/issues/94"},"comments":{"href":"https://api.github.com/repos/nical/lyon/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/nical/lyon/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/nical/lyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nical/lyon/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/nical/lyon/statuses/7116080636a98c21df20d3830e35622708101734"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nical","id":264854,"avatar_url":"https://avatars1.githubusercontent.com/u/264854?v=3","gravatar_id":"","url":"https://api.github.com/users/nical","html_url":"https://github.com/nical","followers_url":"https://api.github.com/users/nical/followers","following_url":"https://api.github.com/users/nical/following{/other_user}","gists_url":"https://api.github.com/users/nical/gists{/gist_id}","starred_url":"https://api.github.com/users/nical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nical/subscriptions","organizations_url":"https://api.github.com/users/nical/orgs","repos_url":"https://api.github.com/users/nical/repos","events_url":"https://api.github.com/users/nical/events{/privacy}","received_events_url":"https://api.github.com/users/nical/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":256,"deletions":130,"changed_files":5}}
{"actor":{"display_login":"nical"}}