{"action":"created","comment":{"url":"https://api.github.com/repos/sigma-dev/sigma/pulls/comments/124036876","pull_request_review_id":46292257,"id":124036876,"diff_hunk":"@@ -655,6 +654,12 @@ definitions:\n           $ref: '#/definitions/ServiceIO'\n       enabled:\n         type: boolean\n+      state:\n+        type: string\n+        enum:","path":"api/v1/gen/v1.yaml","position":14,"original_position":14,"commit_id":"e324758e24be607362d986abaed138fa600530f6","original_commit_id":"e324758e24be607362d986abaed138fa600530f6","user":{"login":"meganokeefe","id":3137106,"avatar_url":"https://avatars3.githubusercontent.com/u/3137106?v=3","gravatar_id":"","url":"https://api.github.com/users/meganokeefe","html_url":"https://github.com/meganokeefe","followers_url":"https://api.github.com/users/meganokeefe/followers","following_url":"https://api.github.com/users/meganokeefe/following{/other_user}","gists_url":"https://api.github.com/users/meganokeefe/gists{/gist_id}","starred_url":"https://api.github.com/users/meganokeefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganokeefe/subscriptions","organizations_url":"https://api.github.com/users/meganokeefe/orgs","repos_url":"https://api.github.com/users/meganokeefe/repos","events_url":"https://api.github.com/users/meganokeefe/events{/privacy}","received_events_url":"https://api.github.com/users/meganokeefe/received_events","type":"User","site_admin":false},"body":"why is this enum needed? also i think service status can be more than just these https://github.com/sigma-dev/sigma/blob/master/model/model.go#L136","created_at":"2017-06-26T15:14:01Z","updated_at":"2017-06-26T15:14:01Z","html_url":"https://github.com/sigma-dev/sigma/pull/171#discussion_r124036876","pull_request_url":"https://api.github.com/repos/sigma-dev/sigma/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/sigma-dev/sigma/pulls/comments/124036876"},"html":{"href":"https://github.com/sigma-dev/sigma/pull/171#discussion_r124036876"},"pull_request":{"href":"https://api.github.com/repos/sigma-dev/sigma/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/sigma-dev/sigma/pulls/171","id":126822109,"html_url":"https://github.com/sigma-dev/sigma/pull/171","diff_url":"https://github.com/sigma-dev/sigma/pull/171.diff","patch_url":"https://github.com/sigma-dev/sigma/pull/171.patch","issue_url":"https://api.github.com/repos/sigma-dev/sigma/issues/171","number":171,"state":"open","locked":false,"title":"First fixes for bug #152","user":{"login":"dlb46","id":26694661,"avatar_url":"https://avatars2.githubusercontent.com/u/26694661?v=3","gravatar_id":"","url":"https://api.github.com/users/dlb46","html_url":"https://github.com/dlb46","followers_url":"https://api.github.com/users/dlb46/followers","following_url":"https://api.github.com/users/dlb46/following{/other_user}","gists_url":"https://api.github.com/users/dlb46/gists{/gist_id}","starred_url":"https://api.github.com/users/dlb46/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlb46/subscriptions","organizations_url":"https://api.github.com/users/dlb46/orgs","repos_url":"https://api.github.com/users/dlb46/repos","events_url":"https://api.github.com/users/dlb46/events{/privacy}","received_events_url":"https://api.github.com/users/dlb46/received_events","type":"User","site_admin":false},"body":"Fix #152 \r\n\r\n### Change log\r\n\r\nFor whatever reason, in convert.go we simply weren't passing the state of the service.  I changed it so that now we do.\r\n\r\nIn v1.yaml I added this \"state\" field to the Service api object.  This allows the state property to be passed back and forth.\r\n\r\nIn server.go I just made a constant for that string per convention.\r\n\r\nIn server_test.go I just made a service with a status, and checked to make sure it was being added and retrieved correctly.\r\n\r\n\r\n### Notes\r\n\r\nI talked to Craig Micallef, and he said that all he needed was the status of the service, so that is why I didn't add in the rest of the serverstatus stuff.  I told him if down the road he decides he wants ends up wanting that information (lastUpdated, logs, description, output), then I will add it there for him.  Doing that should be very intuitive. \r\n\r\nMake sure to run the Makefile in the /gen directory, and replace the existing \"clients\" folder with the one generated by swagger.\r\n\r\n### TODO\r\n\r\nI believe the online \"Sigma API Specification\" page needs to be changed so that this state attribute is added to the GET /Services.  I'm happy to do this, just ping me with the best way to do it.\r\n","created_at":"2017-06-21T17:45:52Z","updated_at":"2017-06-26T15:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"530d80d10d5cb9e7df86e9c7fba891493a32124a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adamschaub","id":1927883,"avatar_url":"https://avatars3.githubusercontent.com/u/1927883?v=3","gravatar_id":"","url":"https://api.github.com/users/adamschaub","html_url":"https://github.com/adamschaub","followers_url":"https://api.github.com/users/adamschaub/followers","following_url":"https://api.github.com/users/adamschaub/following{/other_user}","gists_url":"https://api.github.com/users/adamschaub/gists{/gist_id}","starred_url":"https://api.github.com/users/adamschaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamschaub/subscriptions","organizations_url":"https://api.github.com/users/adamschaub/orgs","repos_url":"https://api.github.com/users/adamschaub/repos","events_url":"https://api.github.com/users/adamschaub/events{/privacy}","received_events_url":"https://api.github.com/users/adamschaub/received_events","type":"User","site_admin":false},{"login":"stephenrlouie","id":2810544,"avatar_url":"https://avatars3.githubusercontent.com/u/2810544?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenrlouie","html_url":"https://github.com/stephenrlouie","followers_url":"https://api.github.com/users/stephenrlouie/followers","following_url":"https://api.github.com/users/stephenrlouie/following{/other_user}","gists_url":"https://api.github.com/users/stephenrlouie/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenrlouie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenrlouie/subscriptions","organizations_url":"https://api.github.com/users/stephenrlouie/orgs","repos_url":"https://api.github.com/users/stephenrlouie/repos","events_url":"https://api.github.com/users/stephenrlouie/events{/privacy}","received_events_url":"https://api.github.com/users/stephenrlouie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sigma-dev/sigma/pulls/171/commits","review_comments_url":"https://api.github.com/repos/sigma-dev/sigma/pulls/171/comments","review_comment_url":"https://api.github.com/repos/sigma-dev/sigma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sigma-dev/sigma/issues/171/comments","statuses_url":"https://api.github.com/repos/sigma-dev/sigma/statuses/e324758e24be607362d986abaed138fa600530f6","head":{"label":"sigma-dev:dakota/bug152","ref":"dakota/bug152","sha":"e324758e24be607362d986abaed138fa600530f6","user":{"login":"sigma-dev","id":27972812,"avatar_url":"https://avatars3.githubusercontent.com/u/27972812?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma-dev","html_url":"https://github.com/sigma-dev","followers_url":"https://api.github.com/users/sigma-dev/followers","following_url":"https://api.github.com/users/sigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/sigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma-dev/subscriptions","organizations_url":"https://api.github.com/users/sigma-dev/orgs","repos_url":"https://api.github.com/users/sigma-dev/repos","events_url":"https://api.github.com/users/sigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/sigma-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":89404176,"name":"sigma","full_name":"sigma-dev/sigma","owner":{"login":"sigma-dev","id":27972812,"avatar_url":"https://avatars3.githubusercontent.com/u/27972812?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma-dev","html_url":"https://github.com/sigma-dev","followers_url":"https://api.github.com/users/sigma-dev/followers","following_url":"https://api.github.com/users/sigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/sigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma-dev/subscriptions","organizations_url":"https://api.github.com/users/sigma-dev/orgs","repos_url":"https://api.github.com/users/sigma-dev/repos","events_url":"https://api.github.com/users/sigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/sigma-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sigma-dev/sigma","description":null,"fork":false,"url":"https://api.github.com/repos/sigma-dev/sigma","forks_url":"https://api.github.com/repos/sigma-dev/sigma/forks","keys_url":"https://api.github.com/repos/sigma-dev/sigma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sigma-dev/sigma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sigma-dev/sigma/teams","hooks_url":"https://api.github.com/repos/sigma-dev/sigma/hooks","issue_events_url":"https://api.github.com/repos/sigma-dev/sigma/issues/events{/number}","events_url":"https://api.github.com/repos/sigma-dev/sigma/events","assignees_url":"https://api.github.com/repos/sigma-dev/sigma/assignees{/user}","branches_url":"https://api.github.com/repos/sigma-dev/sigma/branches{/branch}","tags_url":"https://api.github.com/repos/sigma-dev/sigma/tags","blobs_url":"https://api.github.com/repos/sigma-dev/sigma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sigma-dev/sigma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sigma-dev/sigma/git/refs{/sha}","trees_url":"https://api.github.com/repos/sigma-dev/sigma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sigma-dev/sigma/statuses/{sha}","languages_url":"https://api.github.com/repos/sigma-dev/sigma/languages","stargazers_url":"https://api.github.com/repos/sigma-dev/sigma/stargazers","contributors_url":"https://api.github.com/repos/sigma-dev/sigma/contributors","subscribers_url":"https://api.github.com/repos/sigma-dev/sigma/subscribers","subscription_url":"https://api.github.com/repos/sigma-dev/sigma/subscription","commits_url":"https://api.github.com/repos/sigma-dev/sigma/commits{/sha}","git_commits_url":"https://api.github.com/repos/sigma-dev/sigma/git/commits{/sha}","comments_url":"https://api.github.com/repos/sigma-dev/sigma/comments{/number}","issue_comment_url":"https://api.github.com/repos/sigma-dev/sigma/issues/comments{/number}","contents_url":"https://api.github.com/repos/sigma-dev/sigma/contents/{+path}","compare_url":"https://api.github.com/repos/sigma-dev/sigma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sigma-dev/sigma/merges","archive_url":"https://api.github.com/repos/sigma-dev/sigma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sigma-dev/sigma/downloads","issues_url":"https://api.github.com/repos/sigma-dev/sigma/issues{/number}","pulls_url":"https://api.github.com/repos/sigma-dev/sigma/pulls{/number}","milestones_url":"https://api.github.com/repos/sigma-dev/sigma/milestones{/number}","notifications_url":"https://api.github.com/repos/sigma-dev/sigma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sigma-dev/sigma/labels{/name}","releases_url":"https://api.github.com/repos/sigma-dev/sigma/releases{/id}","deployments_url":"https://api.github.com/repos/sigma-dev/sigma/deployments","created_at":"2017-04-25T20:33:14Z","updated_at":"2017-06-14T00:21:50Z","pushed_at":"2017-06-26T15:08:44Z","git_url":"git://github.com/sigma-dev/sigma.git","ssh_url":"git@github.com:sigma-dev/sigma.git","clone_url":"https://github.com/sigma-dev/sigma.git","svn_url":"https://github.com/sigma-dev/sigma","homepage":"https://sigma-dev.github.io/sigma","size":9517,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":23,"forks":0,"open_issues":23,"watchers":3,"default_branch":"master"}},"base":{"label":"sigma-dev:master","ref":"master","sha":"296d0b767bab46b97fe95d38b8976febc6466eb4","user":{"login":"sigma-dev","id":27972812,"avatar_url":"https://avatars3.githubusercontent.com/u/27972812?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma-dev","html_url":"https://github.com/sigma-dev","followers_url":"https://api.github.com/users/sigma-dev/followers","following_url":"https://api.github.com/users/sigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/sigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma-dev/subscriptions","organizations_url":"https://api.github.com/users/sigma-dev/orgs","repos_url":"https://api.github.com/users/sigma-dev/repos","events_url":"https://api.github.com/users/sigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/sigma-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":89404176,"name":"sigma","full_name":"sigma-dev/sigma","owner":{"login":"sigma-dev","id":27972812,"avatar_url":"https://avatars3.githubusercontent.com/u/27972812?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma-dev","html_url":"https://github.com/sigma-dev","followers_url":"https://api.github.com/users/sigma-dev/followers","following_url":"https://api.github.com/users/sigma-dev/following{/other_user}","gists_url":"https://api.github.com/users/sigma-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma-dev/subscriptions","organizations_url":"https://api.github.com/users/sigma-dev/orgs","repos_url":"https://api.github.com/users/sigma-dev/repos","events_url":"https://api.github.com/users/sigma-dev/events{/privacy}","received_events_url":"https://api.github.com/users/sigma-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sigma-dev/sigma","description":null,"fork":false,"url":"https://api.github.com/repos/sigma-dev/sigma","forks_url":"https://api.github.com/repos/sigma-dev/sigma/forks","keys_url":"https://api.github.com/repos/sigma-dev/sigma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sigma-dev/sigma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sigma-dev/sigma/teams","hooks_url":"https://api.github.com/repos/sigma-dev/sigma/hooks","issue_events_url":"https://api.github.com/repos/sigma-dev/sigma/issues/events{/number}","events_url":"https://api.github.com/repos/sigma-dev/sigma/events","assignees_url":"https://api.github.com/repos/sigma-dev/sigma/assignees{/user}","branches_url":"https://api.github.com/repos/sigma-dev/sigma/branches{/branch}","tags_url":"https://api.github.com/repos/sigma-dev/sigma/tags","blobs_url":"https://api.github.com/repos/sigma-dev/sigma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sigma-dev/sigma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sigma-dev/sigma/git/refs{/sha}","trees_url":"https://api.github.com/repos/sigma-dev/sigma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sigma-dev/sigma/statuses/{sha}","languages_url":"https://api.github.com/repos/sigma-dev/sigma/languages","stargazers_url":"https://api.github.com/repos/sigma-dev/sigma/stargazers","contributors_url":"https://api.github.com/repos/sigma-dev/sigma/contributors","subscribers_url":"https://api.github.com/repos/sigma-dev/sigma/subscribers","subscription_url":"https://api.github.com/repos/sigma-dev/sigma/subscription","commits_url":"https://api.github.com/repos/sigma-dev/sigma/commits{/sha}","git_commits_url":"https://api.github.com/repos/sigma-dev/sigma/git/commits{/sha}","comments_url":"https://api.github.com/repos/sigma-dev/sigma/comments{/number}","issue_comment_url":"https://api.github.com/repos/sigma-dev/sigma/issues/comments{/number}","contents_url":"https://api.github.com/repos/sigma-dev/sigma/contents/{+path}","compare_url":"https://api.github.com/repos/sigma-dev/sigma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sigma-dev/sigma/merges","archive_url":"https://api.github.com/repos/sigma-dev/sigma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sigma-dev/sigma/downloads","issues_url":"https://api.github.com/repos/sigma-dev/sigma/issues{/number}","pulls_url":"https://api.github.com/repos/sigma-dev/sigma/pulls{/number}","milestones_url":"https://api.github.com/repos/sigma-dev/sigma/milestones{/number}","notifications_url":"https://api.github.com/repos/sigma-dev/sigma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sigma-dev/sigma/labels{/name}","releases_url":"https://api.github.com/repos/sigma-dev/sigma/releases{/id}","deployments_url":"https://api.github.com/repos/sigma-dev/sigma/deployments","created_at":"2017-04-25T20:33:14Z","updated_at":"2017-06-14T00:21:50Z","pushed_at":"2017-06-26T15:08:44Z","git_url":"git://github.com/sigma-dev/sigma.git","ssh_url":"git@github.com:sigma-dev/sigma.git","clone_url":"https://github.com/sigma-dev/sigma.git","svn_url":"https://github.com/sigma-dev/sigma","homepage":"https://sigma-dev.github.io/sigma","size":9517,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":23,"forks":0,"open_issues":23,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sigma-dev/sigma/pulls/171"},"html":{"href":"https://github.com/sigma-dev/sigma/pull/171"},"issue":{"href":"https://api.github.com/repos/sigma-dev/sigma/issues/171"},"comments":{"href":"https://api.github.com/repos/sigma-dev/sigma/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/sigma-dev/sigma/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/sigma-dev/sigma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sigma-dev/sigma/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/sigma-dev/sigma/statuses/e324758e24be607362d986abaed138fa600530f6"}}}}
{"actor":{"display_login":"meganokeefe"}}