{"action":"created","issue":{"url":"https://api.github.com/repos/patloew/RxLocation/issues/47","repository_url":"https://api.github.com/repos/patloew/RxLocation","labels_url":"https://api.github.com/repos/patloew/RxLocation/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/patloew/RxLocation/issues/47/comments","events_url":"https://api.github.com/repos/patloew/RxLocation/issues/47/events","html_url":"https://github.com/patloew/RxLocation/pull/47","id":245435328,"number":47,"title":"Use a WeakReference to mitigates a bug in Google Play services which cause memory leak","user":{"login":"ZahidRasheed","id":3254566,"avatar_url":"https://avatars0.githubusercontent.com/u/3254566?v=4","gravatar_id":"","url":"https://api.github.com/users/ZahidRasheed","html_url":"https://github.com/ZahidRasheed","followers_url":"https://api.github.com/users/ZahidRasheed/followers","following_url":"https://api.github.com/users/ZahidRasheed/following{/other_user}","gists_url":"https://api.github.com/users/ZahidRasheed/gists{/gist_id}","starred_url":"https://api.github.com/users/ZahidRasheed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZahidRasheed/subscriptions","organizations_url":"https://api.github.com/users/ZahidRasheed/orgs","repos_url":"https://api.github.com/users/ZahidRasheed/repos","events_url":"https://api.github.com/users/ZahidRasheed/events{/privacy}","received_events_url":"https://api.github.com/users/ZahidRasheed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-25T15:12:23Z","updated_at":"2017-07-25T15:27:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/patloew/RxLocation/pulls/47","html_url":"https://github.com/patloew/RxLocation/pull/47","diff_url":"https://github.com/patloew/RxLocation/pull/47.diff","patch_url":"https://github.com/patloew/RxLocation/pull/47.patch"},"body":"use a WeakReference to mitigates a bug in Google Play services which causes  a memory leak of the registered LocationListener even if FusedLocationProviderApi#removeLocationUpdates(GoogleApiClient, LocationListener) is called correctly. If the LocationListener is directly referencing an activity context, it will leak heavy stuff (View hierarchy etc.). Using WeakReference only the listener will leak and not the containing observer. ref: https://issuetracker.google.com/issues/37126862"},"comment":{"url":"https://api.github.com/repos/patloew/RxLocation/issues/comments/317775252","html_url":"https://github.com/patloew/RxLocation/pull/47#issuecomment-317775252","issue_url":"https://api.github.com/repos/patloew/RxLocation/issues/47","id":317775252,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T15:27:31Z","updated_at":"2017-07-25T15:27:31Z","body":"# [Codecov](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=h1) Report\n> Merging [#47](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=desc) into [master](https://codecov.io/gh/patloew/RxLocation/commit/f01fef4a3688bc82b94130056f4d09c3aea43c1b?src=pr&el=desc) will **decrease** coverage by `0.14%`.\n> The diff coverage is `57.14%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/patloew/RxLocation/pull/47/graphs/tree.svg?token=Zny3TNY9gS&width=650&height=150&src=pr)](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #47      +/-   ##\n==========================================\n- Coverage   82.89%   82.75%   -0.15%     \n==========================================\n  Files          31       31              \n  Lines         456      458       +2     \n  Branches       19       19              \n==========================================\n+ Hits          378      379       +1     \n- Misses         68       69       +1     \n  Partials       10       10\n```\n\n\n| [Impacted Files](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...rxlocation/LocationUpdatesFlowableOnSubscribe.java](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=tree#diff-bGlicmFyeS9zcmMvbWFpbi9qYXZhL2NvbS9wYXRsb2V3L3J4bG9jYXRpb24vTG9jYXRpb25VcGRhdGVzRmxvd2FibGVPblN1YnNjcmliZS5qYXZh) | `61.9% <57.14%> (-1.26%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=footer). Last update [f01fef4...d4a0ee5](https://codecov.io/gh/patloew/RxLocation/pull/47?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}