{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/106764255","pull_request_review_id":27708477,"id":106764255,"diff_hunk":"@@ -1775,6 +1776,26 @@ static void close_from_api(grpc_exec_ctx *exec_ctx, grpc_chttp2_transport *t,\n      It's complicated by the fact that our send machinery would be dead by\n      the time we got around to sending this, so instead we ignore HPACK\n      compression and just write the uncompressed bytes onto the wire. */\n+  if (!s->sent_initial_metadata) {","path":"src/core/ext/transport/chttp2/transport/chttp2_transport.c","position":12,"original_position":12,"commit_id":"59660e55709d29f71d696221d77e0f5d6cc76f7a","original_commit_id":"59660e55709d29f71d696221d77e0f5d6cc76f7a","user":{"login":"makdharma","id":17325098,"avatar_url":"https://avatars3.githubusercontent.com/u/17325098?v=3","gravatar_id":"","url":"https://api.github.com/users/makdharma","html_url":"https://github.com/makdharma","followers_url":"https://api.github.com/users/makdharma/followers","following_url":"https://api.github.com/users/makdharma/following{/other_user}","gists_url":"https://api.github.com/users/makdharma/gists{/gist_id}","starred_url":"https://api.github.com/users/makdharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makdharma/subscriptions","organizations_url":"https://api.github.com/users/makdharma/orgs","repos_url":"https://api.github.com/users/makdharma/repos","events_url":"https://api.github.com/users/makdharma/events{/privacy}","received_events_url":"https://api.github.com/users/makdharma/received_events","type":"User","site_admin":false},"body":"Please comment the thinking behind this condition?","created_at":"2017-03-17T23:47:49Z","updated_at":"2017-03-17T23:53:12Z","html_url":"https://github.com/grpc/grpc/pull/10210#discussion_r106764255","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/10210","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/106764255"},"html":{"href":"https://github.com/grpc/grpc/pull/10210#discussion_r106764255"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/10210"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/10210","id":111380509,"html_url":"https://github.com/grpc/grpc/pull/10210","diff_url":"https://github.com/grpc/grpc/pull/10210.diff","patch_url":"https://github.com/grpc/grpc/pull/10210.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/10210","number":10210,"state":"open","locked":false,"title":"Enable cronet compression","user":{"login":"muxi","id":1054404,"avatar_url":"https://avatars2.githubusercontent.com/u/1054404?v=3","gravatar_id":"","url":"https://api.github.com/users/muxi","html_url":"https://github.com/muxi","followers_url":"https://api.github.com/users/muxi/followers","following_url":"https://api.github.com/users/muxi/following{/other_user}","gists_url":"https://api.github.com/users/muxi/gists{/gist_id}","starred_url":"https://api.github.com/users/muxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxi/subscriptions","organizations_url":"https://api.github.com/users/muxi/orgs","repos_url":"https://api.github.com/users/muxi/repos","events_url":"https://api.github.com/users/muxi/events{/privacy}","received_events_url":"https://api.github.com/users/muxi/received_events","type":"User","site_admin":false},"body":"Allow Cronet transport to send and receive compressed payloads.\r\n\r\nCherry-picked a bug fix (#10208) that allows chttp2 to send :status header field in trailer-only response.","created_at":"2017-03-17T22:57:07Z","updated_at":"2017-03-17T23:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9017f2a0aa5465748955cdbc8007a957055ccb31","assignee":{"login":"makdharma","id":17325098,"avatar_url":"https://avatars3.githubusercontent.com/u/17325098?v=3","gravatar_id":"","url":"https://api.github.com/users/makdharma","html_url":"https://github.com/makdharma","followers_url":"https://api.github.com/users/makdharma/followers","following_url":"https://api.github.com/users/makdharma/following{/other_user}","gists_url":"https://api.github.com/users/makdharma/gists{/gist_id}","starred_url":"https://api.github.com/users/makdharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makdharma/subscriptions","organizations_url":"https://api.github.com/users/makdharma/orgs","repos_url":"https://api.github.com/users/makdharma/repos","events_url":"https://api.github.com/users/makdharma/events{/privacy}","received_events_url":"https://api.github.com/users/makdharma/received_events","type":"User","site_admin":false},"assignees":[{"login":"makdharma","id":17325098,"avatar_url":"https://avatars3.githubusercontent.com/u/17325098?v=3","gravatar_id":"","url":"https://api.github.com/users/makdharma","html_url":"https://github.com/makdharma","followers_url":"https://api.github.com/users/makdharma/followers","following_url":"https://api.github.com/users/makdharma/following{/other_user}","gists_url":"https://api.github.com/users/makdharma/gists{/gist_id}","starred_url":"https://api.github.com/users/makdharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makdharma/subscriptions","organizations_url":"https://api.github.com/users/makdharma/orgs","repos_url":"https://api.github.com/users/makdharma/repos","events_url":"https://api.github.com/users/makdharma/events{/privacy}","received_events_url":"https://api.github.com/users/makdharma/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/10210/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/10210/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/10210/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/59660e55709d29f71d696221d77e0f5d6cc76f7a","head":{"label":"muxi:enable-cronet-compression","ref":"enable-cronet-compression","sha":"59660e55709d29f71d696221d77e0f5d6cc76f7a","user":{"login":"muxi","id":1054404,"avatar_url":"https://avatars2.githubusercontent.com/u/1054404?v=3","gravatar_id":"","url":"https://api.github.com/users/muxi","html_url":"https://github.com/muxi","followers_url":"https://api.github.com/users/muxi/followers","following_url":"https://api.github.com/users/muxi/following{/other_user}","gists_url":"https://api.github.com/users/muxi/gists{/gist_id}","starred_url":"https://api.github.com/users/muxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxi/subscriptions","organizations_url":"https://api.github.com/users/muxi/orgs","repos_url":"https://api.github.com/users/muxi/repos","events_url":"https://api.github.com/users/muxi/events{/privacy}","received_events_url":"https://api.github.com/users/muxi/received_events","type":"User","site_admin":false},"repo":{"id":61651647,"name":"grpc","full_name":"muxi/grpc","owner":{"login":"muxi","id":1054404,"avatar_url":"https://avatars2.githubusercontent.com/u/1054404?v=3","gravatar_id":"","url":"https://api.github.com/users/muxi","html_url":"https://github.com/muxi","followers_url":"https://api.github.com/users/muxi/followers","following_url":"https://api.github.com/users/muxi/following{/other_user}","gists_url":"https://api.github.com/users/muxi/gists{/gist_id}","starred_url":"https://api.github.com/users/muxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxi/subscriptions","organizations_url":"https://api.github.com/users/muxi/orgs","repos_url":"https://api.github.com/users/muxi/repos","events_url":"https://api.github.com/users/muxi/events{/privacy}","received_events_url":"https://api.github.com/users/muxi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muxi/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/muxi/grpc","forks_url":"https://api.github.com/repos/muxi/grpc/forks","keys_url":"https://api.github.com/repos/muxi/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muxi/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muxi/grpc/teams","hooks_url":"https://api.github.com/repos/muxi/grpc/hooks","issue_events_url":"https://api.github.com/repos/muxi/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/muxi/grpc/events","assignees_url":"https://api.github.com/repos/muxi/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/muxi/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/muxi/grpc/tags","blobs_url":"https://api.github.com/repos/muxi/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muxi/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muxi/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/muxi/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muxi/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/muxi/grpc/languages","stargazers_url":"https://api.github.com/repos/muxi/grpc/stargazers","contributors_url":"https://api.github.com/repos/muxi/grpc/contributors","subscribers_url":"https://api.github.com/repos/muxi/grpc/subscribers","subscription_url":"https://api.github.com/repos/muxi/grpc/subscription","commits_url":"https://api.github.com/repos/muxi/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/muxi/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/muxi/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/muxi/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/muxi/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/muxi/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muxi/grpc/merges","archive_url":"https://api.github.com/repos/muxi/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muxi/grpc/downloads","issues_url":"https://api.github.com/repos/muxi/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/muxi/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/muxi/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/muxi/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muxi/grpc/labels{/name}","releases_url":"https://api.github.com/repos/muxi/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/muxi/grpc/deployments","created_at":"2016-06-21T17:00:36Z","updated_at":"2016-06-21T17:00:46Z","pushed_at":"2017-03-17T23:17:33Z","git_url":"git://github.com/muxi/grpc.git","ssh_url":"git@github.com:muxi/grpc.git","clone_url":"https://github.com/muxi/grpc.git","svn_url":"https://github.com/muxi/grpc","homepage":"","size":104149,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"40a947ef93aeddca3b606613f628d4d09f094e77","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars2.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars2.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2017-03-17T23:25:36Z","pushed_at":"2017-03-17T23:45:44Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":107689,"stargazers_count":8965,"watchers_count":8965,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1786,"mirror_url":null,"open_issues_count":1062,"forks":1786,"open_issues":1062,"watchers":8965,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/10210"},"html":{"href":"https://github.com/grpc/grpc/pull/10210"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/10210"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/10210/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/10210/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/10210/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/59660e55709d29f71d696221d77e0f5d6cc76f7a"}}}}
{"actor":{"display_login":"makdharma"}}