{"action":"created","comment":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/136777803","pull_request_review_id":60362445,"id":136777803,"diff_hunk":"@@ -317,7 +317,8 @@ namespace pcl\n       OctreeBreadthFirstIterator<OctreeT>::reset ();\n \n       // Set the current_state_ to the right depth\n-      while( this->current_state_ && ( this->getCurrentOctreeDepth () != depth_ ) ) {\n+      while ( this->current_state_ && ( this->getCurrentOctreeDepth () != depth_ ) )","path":"octree/include/pcl/octree/impl/octree_iterator.hpp","position":null,"original_position":5,"commit_id":"f73c55535ef25826f2e92384b371afafcf1108bb","original_commit_id":"600e237363b9f3d5c5bf702a91351654d1a2cc0e","user":{"login":"taketwo","id":1241736,"avatar_url":"https://avatars0.githubusercontent.com/u/1241736?v=4","gravatar_id":"","url":"https://api.github.com/users/taketwo","html_url":"https://github.com/taketwo","followers_url":"https://api.github.com/users/taketwo/followers","following_url":"https://api.github.com/users/taketwo/following{/other_user}","gists_url":"https://api.github.com/users/taketwo/gists{/gist_id}","starred_url":"https://api.github.com/users/taketwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taketwo/subscriptions","organizations_url":"https://api.github.com/users/taketwo/orgs","repos_url":"https://api.github.com/users/taketwo/repos","events_url":"https://api.github.com/users/taketwo/events{/privacy}","received_events_url":"https://api.github.com/users/taketwo/received_events","type":"User","site_admin":false},"body":"I'm afraid we still have style problems here :D \r\nThere shouldn't be spaces inside brackets, i.e.\r\n\r\n```cpp\r\nwhile (this->current_state_ && (this->getCurrentOctreeDepth () != depth_))\r\n```","created_at":"2017-09-04T09:17:12Z","updated_at":"2017-09-04T09:25:01Z","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1983#discussion_r136777803","pull_request_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/136777803"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/1983#discussion_r136777803"},"pull_request":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983"}}},"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983","id":138947386,"html_url":"https://github.com/PointCloudLibrary/pcl/pull/1983","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/1983.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/1983.patch","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1983","number":1983,"state":"open","locked":false,"title":"[OCTREE] Implementation of the iterator 'BreadthFirstAtDepthIterator'.","user":{"login":"frozar","id":1025244,"avatar_url":"https://avatars2.githubusercontent.com/u/1025244?v=4","gravatar_id":"","url":"https://api.github.com/users/frozar","html_url":"https://github.com/frozar","followers_url":"https://api.github.com/users/frozar/followers","following_url":"https://api.github.com/users/frozar/following{/other_user}","gists_url":"https://api.github.com/users/frozar/gists{/gist_id}","starred_url":"https://api.github.com/users/frozar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozar/subscriptions","organizations_url":"https://api.github.com/users/frozar/orgs","repos_url":"https://api.github.com/users/frozar/repos","events_url":"https://api.github.com/users/frozar/events{/privacy}","received_events_url":"https://api.github.com/users/frozar/received_events","type":"User","site_admin":false},"body":"Add an octree iterator to walk over the `OctreeBranch` at the same depth. The code relies really on the iterator `OctreeBreadthFirstIterator`.\r\n\r\nThe file `octree_viewer.cpp` has been updated to use this iterator.\r\n\r\nTo maintain to homogenity for the different octree class, more things should be done I think. Wait for checking.","created_at":"2017-09-01T18:22:17Z","updated_at":"2017-09-04T09:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df3aefebb609c0d4a91cac1d7c77b624c8d63c49","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones/4","html_url":"https://github.com/PointCloudLibrary/pcl/milestone/4","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones/4/labels","id":1836984,"number":4,"title":"pcl-1.9.0","description":"","creator":{"login":"SergioRAgostinho","id":1709142,"avatar_url":"https://avatars3.githubusercontent.com/u/1709142?v=4","gravatar_id":"","url":"https://api.github.com/users/SergioRAgostinho","html_url":"https://github.com/SergioRAgostinho","followers_url":"https://api.github.com/users/SergioRAgostinho/followers","following_url":"https://api.github.com/users/SergioRAgostinho/following{/other_user}","gists_url":"https://api.github.com/users/SergioRAgostinho/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioRAgostinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioRAgostinho/subscriptions","organizations_url":"https://api.github.com/users/SergioRAgostinho/orgs","repos_url":"https://api.github.com/users/SergioRAgostinho/repos","events_url":"https://api.github.com/users/SergioRAgostinho/events{/privacy}","received_events_url":"https://api.github.com/users/SergioRAgostinho/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":9,"state":"open","created_at":"2016-06-19T23:05:46Z","updated_at":"2017-09-03T10:10:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983/commits","review_comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983/comments","review_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1983/comments","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/f73c55535ef25826f2e92384b371afafcf1108bb","head":{"label":"frozar:octree_iterator","ref":"octree_iterator","sha":"f73c55535ef25826f2e92384b371afafcf1108bb","user":{"login":"frozar","id":1025244,"avatar_url":"https://avatars2.githubusercontent.com/u/1025244?v=4","gravatar_id":"","url":"https://api.github.com/users/frozar","html_url":"https://github.com/frozar","followers_url":"https://api.github.com/users/frozar/followers","following_url":"https://api.github.com/users/frozar/following{/other_user}","gists_url":"https://api.github.com/users/frozar/gists{/gist_id}","starred_url":"https://api.github.com/users/frozar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozar/subscriptions","organizations_url":"https://api.github.com/users/frozar/orgs","repos_url":"https://api.github.com/users/frozar/repos","events_url":"https://api.github.com/users/frozar/events{/privacy}","received_events_url":"https://api.github.com/users/frozar/received_events","type":"User","site_admin":false},"repo":{"id":101550476,"name":"pcl","full_name":"frozar/pcl","owner":{"login":"frozar","id":1025244,"avatar_url":"https://avatars2.githubusercontent.com/u/1025244?v=4","gravatar_id":"","url":"https://api.github.com/users/frozar","html_url":"https://github.com/frozar","followers_url":"https://api.github.com/users/frozar/followers","following_url":"https://api.github.com/users/frozar/following{/other_user}","gists_url":"https://api.github.com/users/frozar/gists{/gist_id}","starred_url":"https://api.github.com/users/frozar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozar/subscriptions","organizations_url":"https://api.github.com/users/frozar/orgs","repos_url":"https://api.github.com/users/frozar/repos","events_url":"https://api.github.com/users/frozar/events{/privacy}","received_events_url":"https://api.github.com/users/frozar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frozar/pcl","description":"Point Cloud Library (PCL)","fork":true,"url":"https://api.github.com/repos/frozar/pcl","forks_url":"https://api.github.com/repos/frozar/pcl/forks","keys_url":"https://api.github.com/repos/frozar/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frozar/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frozar/pcl/teams","hooks_url":"https://api.github.com/repos/frozar/pcl/hooks","issue_events_url":"https://api.github.com/repos/frozar/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/frozar/pcl/events","assignees_url":"https://api.github.com/repos/frozar/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/frozar/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/frozar/pcl/tags","blobs_url":"https://api.github.com/repos/frozar/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frozar/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frozar/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/frozar/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frozar/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/frozar/pcl/languages","stargazers_url":"https://api.github.com/repos/frozar/pcl/stargazers","contributors_url":"https://api.github.com/repos/frozar/pcl/contributors","subscribers_url":"https://api.github.com/repos/frozar/pcl/subscribers","subscription_url":"https://api.github.com/repos/frozar/pcl/subscription","commits_url":"https://api.github.com/repos/frozar/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/frozar/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/frozar/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/frozar/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/frozar/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/frozar/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frozar/pcl/merges","archive_url":"https://api.github.com/repos/frozar/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frozar/pcl/downloads","issues_url":"https://api.github.com/repos/frozar/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/frozar/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/frozar/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/frozar/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frozar/pcl/labels{/name}","releases_url":"https://api.github.com/repos/frozar/pcl/releases{/id}","deployments_url":"https://api.github.com/repos/frozar/pcl/deployments","created_at":"2017-08-27T12:21:25Z","updated_at":"2017-08-27T12:21:37Z","pushed_at":"2017-09-04T08:45:18Z","git_url":"git://github.com/frozar/pcl.git","ssh_url":"git@github.com:frozar/pcl.git","clone_url":"https://github.com/frozar/pcl.git","svn_url":"https://github.com/frozar/pcl","homepage":"http://www.pointclouds.org","size":222574,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PointCloudLibrary:master","ref":"master","sha":"5cc08f862cc436f710467b8a8e5640e7e531b79f","user":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars2.githubusercontent.com/u/2059451?v=4","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":8162615,"name":"pcl","full_name":"PointCloudLibrary/pcl","owner":{"login":"PointCloudLibrary","id":2059451,"avatar_url":"https://avatars2.githubusercontent.com/u/2059451?v=4","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PointCloudLibrary/pcl","description":"Point Cloud Library (PCL)","fork":false,"url":"https://api.github.com/repos/PointCloudLibrary/pcl","forks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/forks","keys_url":"https://api.github.com/repos/PointCloudLibrary/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PointCloudLibrary/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PointCloudLibrary/pcl/teams","hooks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/hooks","issue_events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/events","assignees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/PointCloudLibrary/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/tags","blobs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/PointCloudLibrary/pcl/languages","stargazers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/stargazers","contributors_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contributors","subscribers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscribers","subscription_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscription","commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/PointCloudLibrary/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PointCloudLibrary/pcl/merges","archive_url":"https://api.github.com/repos/PointCloudLibrary/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PointCloudLibrary/pcl/downloads","issues_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/PointCloudLibrary/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels{/name}","releases_url":"https://api.github.com/repos/PointCloudLibrary/pcl/releases{/id}","deployments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/deployments","created_at":"2013-02-12T16:40:25Z","updated_at":"2017-09-04T00:58:49Z","pushed_at":"2017-09-04T08:06:11Z","git_url":"git://github.com/PointCloudLibrary/pcl.git","ssh_url":"git@github.com:PointCloudLibrary/pcl.git","clone_url":"https://github.com/PointCloudLibrary/pcl.git","svn_url":"https://github.com/PointCloudLibrary/pcl","homepage":"http://www.pointclouds.org","size":222567,"stargazers_count":1906,"watchers_count":1906,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1822,"mirror_url":null,"open_issues_count":304,"forks":1822,"open_issues":304,"watchers":1906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/1983"},"issue":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1983"},"comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1983/comments"},"review_comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983/comments"},"review_comment":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1983/commits"},"statuses":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/f73c55535ef25826f2e92384b371afafcf1108bb"}},"author_association":"NONE"}}
{"actor":{"display_login":"taketwo"}}