{"action":"closed","issue":{"url":"https://api.github.com/repos/CreateJS/SoundJS/issues/281","repository_url":"https://api.github.com/repos/CreateJS/SoundJS","labels_url":"https://api.github.com/repos/CreateJS/SoundJS/issues/281/labels{/name}","comments_url":"https://api.github.com/repos/CreateJS/SoundJS/issues/281/comments","events_url":"https://api.github.com/repos/CreateJS/SoundJS/issues/281/events","html_url":"https://github.com/CreateJS/SoundJS/issues/281","id":263629624,"number":281,"title":"SoundJS's AbstractPlugin.js had a set method problem, At version 1.0.0","user":{"login":"MIKUScallion","id":14974790,"avatar_url":"https://avatars2.githubusercontent.com/u/14974790?v=4","gravatar_id":"","url":"https://api.github.com/users/MIKUScallion","html_url":"https://github.com/MIKUScallion","followers_url":"https://api.github.com/users/MIKUScallion/followers","following_url":"https://api.github.com/users/MIKUScallion/following{/other_user}","gists_url":"https://api.github.com/users/MIKUScallion/gists{/gist_id}","starred_url":"https://api.github.com/users/MIKUScallion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIKUScallion/subscriptions","organizations_url":"https://api.github.com/users/MIKUScallion/orgs","repos_url":"https://api.github.com/users/MIKUScallion/repos","events_url":"https://api.github.com/users/MIKUScallion/events{/privacy}","received_events_url":"https://api.github.com/users/MIKUScallion/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-10-07T09:38:10Z","updated_at":"2017-11-08T22:46:23Z","closed_at":"2017-11-08T22:46:23Z","author_association":"NONE","body":"https://github.com/CreateJS/SoundJS/blob/master/src/soundjs/AbstractPlugin.js\r\n\r\n```js\r\n\t/**\r\n\t * Handles internal preload completion.\r\n\t * @method _handlePreloadComplete\r\n\t * @param event\r\n\t * @protected\r\n\t */\r\n\tp._handlePreloadComplete = function (event) {\r\n\t\tvar src = event.target.getItem().src;\r\n\t\tthis._audioSources[src] = event.result;\r\n\t\tfor (var i = 0, l = this._soundInstances[src].length; i < l; i++) {\r\n\t\t\tvar item = this._soundInstances[src][i];\r\n\t\t\titem.setPlaybackResource(this._audioSources[src]);\r\n\t\t\t// ToDo consider adding play call here if playstate == playfailed\r\n\t\t\tthis._soundInstances[src] = null;\r\n\t\t}\r\n\t};\r\n```\r\n\r\nThis method call a set method named **setPlaybackResource**, then the method is replaced with a setter but without a deprecated wrapper.\r\n\r\nIt may cause bug as below.\r\n\r\n<img width=\"668\" alt=\"01\"  src=\"https://user-images.githubusercontent.com/14974790/31306604-2b4a2356-ab86-11e7-9f46-e55a5151d9d6.png\">\r\n\r\nThanks you !"}}
{"actor":{"display_login":"lannymcnie"}}