{"action":"created","issue":{"url":"https://api.github.com/repos/ssokolow/itad_importer/issues/25","repository_url":"https://api.github.com/repos/ssokolow/itad_importer","labels_url":"https://api.github.com/repos/ssokolow/itad_importer/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/ssokolow/itad_importer/issues/25/comments","events_url":"https://api.github.com/repos/ssokolow/itad_importer/issues/25/events","html_url":"https://github.com/ssokolow/itad_importer/pull/25","id":253748849,"number":25,"title":"Improved humble bundle imports and button placement","user":{"login":"sir-maniac","id":608494,"avatar_url":"https://avatars2.githubusercontent.com/u/608494?v=4","gravatar_id":"","url":"https://api.github.com/users/sir-maniac","html_url":"https://github.com/sir-maniac","followers_url":"https://api.github.com/users/sir-maniac/followers","following_url":"https://api.github.com/users/sir-maniac/following{/other_user}","gists_url":"https://api.github.com/users/sir-maniac/gists{/gist_id}","starred_url":"https://api.github.com/users/sir-maniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sir-maniac/subscriptions","organizations_url":"https://api.github.com/users/sir-maniac/orgs","repos_url":"https://api.github.com/users/sir-maniac/repos","events_url":"https://api.github.com/users/sir-maniac/events{/privacy}","received_events_url":"https://api.github.com/users/sir-maniac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-29T17:47:38Z","updated_at":"2017-08-29T20:36:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ssokolow/itad_importer/pulls/25","html_url":"https://github.com/ssokolow/itad_importer/pull/25","diff_url":"https://github.com/ssokolow/itad_importer/pull/25.diff","patch_url":"https://github.com/ssokolow/itad_importer/pull/25.patch"},"body":"I managed to make imports work through the ajax model objects of the site.  The advantages of this, are that the export works for all downloads and keys, no matter which page you are on.\r\n\r\nCurrently the 'Export to ITAD' exports all downloads and keys in one go.  It should be possible to separate this functionality and have 'export keys only', and 'export downloads only' actions.\r\n\r\nHumble bundle downloads are sourced as 'humblestore', keys are set to whatever key service is used ('steam', 'origin', 'uplay', etc).\r\n\r\nThe button is now inserted dynamically for each of the tabs, on both DOM changes and tab clicks. A single button is used and re-inserted in different parts of the DOM in order to be compatible with the caller. =\r\n\r\nLet me know if you would like something changed for the merge.  Thanks."},"comment":{"url":"https://api.github.com/repos/ssokolow/itad_importer/issues/comments/325796325","html_url":"https://github.com/ssokolow/itad_importer/pull/25#issuecomment-325796325","issue_url":"https://api.github.com/repos/ssokolow/itad_importer/issues/25","id":325796325,"user":{"login":"ssokolow","id":46915,"avatar_url":"https://avatars3.githubusercontent.com/u/46915?v=4","gravatar_id":"","url":"https://api.github.com/users/ssokolow","html_url":"https://github.com/ssokolow","followers_url":"https://api.github.com/users/ssokolow/followers","following_url":"https://api.github.com/users/ssokolow/following{/other_user}","gists_url":"https://api.github.com/users/ssokolow/gists{/gist_id}","starred_url":"https://api.github.com/users/ssokolow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssokolow/subscriptions","organizations_url":"https://api.github.com/users/ssokolow/orgs","repos_url":"https://api.github.com/users/ssokolow/repos","events_url":"https://api.github.com/users/ssokolow/events{/privacy}","received_events_url":"https://api.github.com/users/ssokolow/received_events","type":"User","site_admin":false},"created_at":"2017-08-29T20:36:57Z","updated_at":"2017-08-29T20:36:57Z","author_association":"OWNER","body":"Hmm. I'm not sure when I'll have time to review this, but I'll leave the tab open as a reminder and try to find time as soon as possible.\r\n\r\n(At the moment, I'm still clawing my way back from a huge scheduling mess-up that left me both busy and sleep-deprived enough for my motivation on hobby projects to be somewhat erratic. Given how my impression of CoffeeScript has soured as I became a better developer, I'd hoped to to add automated testing before I poked at this more and then start translating it to TypeScript.)\r\n\r\nWhat I can say is that I'd really prefer if you made it possible to omit keys entirely. The inclusion of keys is a bug that was introduced when Humble redid their library view and I could no longer exclude them with the simple scraping code. (The idea being that the script imports what can actually be downloaded from a given source. If you want to import Steam keys, you go to Steam.)"}}
{"actor":{"display_login":"ssokolow"}}