{"push_id":1530463187,"size":44,"distinct_size":44,"ref":"refs/heads/covered_locs","head":"0d1f26923be3499959d55639b446d8803942aa3f","before":"9e816a05bf8e3825c5614431fc72f08b45e7aacf","commits":[{"sha":"6ed613233d15d84e3954326fe4d33462b8f7bd30","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"[parser] don't explode on numbers > 2^32-1\n\nSummary:\njs_of_ocaml's ints are 32-bit, and `int_of_string` throws when you give\nit a bigger number. floats are IEEE 754 double precision in both js_of_ocaml and\nocaml, so they're fine.\n\nwhen parsing octal and binary numbers, we were using `int_of_string` because it\nsupports `0o` and `0b` prefixes while `float_of_string` doesn't (but\n`float_of_string` does support `0x`, so large hex numbers were not affected).\n\ninstead, if we use the `Int64` versions, it also works in js_of_ocaml.\n\nFixes https://github.com/facebook/flow/issues/3238\n\nReviewed By: gabelevi\n\nDifferential Revision: D4448945\n\nfbshipit-source-id: 26e5c956442819e03e199139582f9020d225072a","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/6ed613233d15d84e3954326fe4d33462b8f7bd30"},{"sha":"862359e8fb740dbb2bbaf444e07fd4789c8f8f9f","author":{"name":"Ivan Kurnosov","email":"1f0ce8574d2b27895a4870d3c4f4a6ae22587f35@zerkms.com"},"message":"Minor typo `it's` -> `its`\n\nSummary: Closes https://github.com/facebook/flow/pull/3240\n\nDifferential Revision: D4448857\n\nPulled By: mroch\n\nfbshipit-source-id: 723b3319223412a89da6a7108afc920a82f5aafa","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/862359e8fb740dbb2bbaf444e07fd4789c8f8f9f"},{"sha":"27a5715d419e08fef5ee84c2142633b195ed0b73","author":{"name":"Sam Goldman","email":"5f607728c58b3087da3af141ba66272da38de946@fb.com"},"message":"subst implements list when checking poly class decls\n\nSummary:\nWhen I added implements, I missed the necessary call to `subst` in\n`Class_sig.generate_tests`. I added the missing call and replaced the\ndefault-copy `x with` in the new record constructor to ensure all new fields are\nconsidered in the future.\n\nFixes https://github.com/facebook/flow/issues/3243\n\nReviewed By: mroch\n\nDifferential Revision: D4450116\n\nfbshipit-source-id: c70a608b28ea68a02cf5554bdfcf792b6049f5e6","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/27a5715d419e08fef5ee84c2142633b195ed0b73"},{"sha":"48b8b9b75e97b713725fc39cdd8eeee7121e7833","author":{"name":"Sam Goldman","email":"5f607728c58b3087da3af141ba66272da38de946@fb.com"},"message":"error on unsupported variance for object type get/set\n\nSummary:\nThe variance field is currently ignored, so this doesn't change any behavior.\nThis makes object type parsing match object literal parsing w.r.t. unsupported\nvariance errors on getters and setters.\n\nReviewed By: mroch\n\nDifferential Revision: D4450184\n\nfbshipit-source-id: adfe35ae2be2941001d23ca3b77770488538995c","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/48b8b9b75e97b713725fc39cdd8eeee7121e7833"},{"sha":"46067bca9f0b717c1d6469840f69d19c126f2fdc","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"remove reason origins (for now)\n\nSummary:\nI want to add this back soon, but for now it's not doing anything and\nmaking error printing more complicated. Making sure that repositioning always\ntracks the origin is going to be slightly harder than what this is doing (which,\nAFAICT, is why this doesn't show up right now).\n\nReviewed By: gabelevi\n\nDifferential Revision: D4440325\n\nfbshipit-source-id: 612741fe8f8bea091645941787017e367c865ed1","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/46067bca9f0b717c1d6469840f69d19c126f2fdc"},{"sha":"e32d05b1d0c0e9beb10073031762c36ef50e1752","author":{"name":"Gabe Levi","email":"74afe5e6f5651d063dedb67b26f7904eea6727d4@fb.com"},"message":"Split ObjAssignT into ObjAssign{To,From}T\n\nSummary:\nGiven `Object.assign(target, source)`, `ObjAssignT` has a boolean\nparameter which says whether it is currently resolving `source` or `target`.\nThis is kind of hacky, so I'm splitting it up. Now it goes\n\n  target ~> ObjAssignTo\n  source ~> ObjAssignFrom\n\nI've also updated the `ObjAssign*` types to carry along whether the source is a\nspread or a regular argument. We can basically treat\n\n  Object.assign(target, ...Array<source>)\n\nas\n\n  Object.assign(target, ...source)\n\nand later we can iterate through tuples.\n\nReviewed By: jeffmo\n\nDifferential Revision: D4405026\n\nfbshipit-source-id: f5ce422dc81a35943781eeceec780cab411df2b3","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/e32d05b1d0c0e9beb10073031762c36ef50e1752"},{"sha":"a88c95f6c383c5b273a785dfe19294f4710c0b2e","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"nested prop compat errors between instances and objects\n\nSummary:\nimproves errors when an instance flows into an object type, and the\ninstance's props aren't compatible with the object's props. now, it complains\nabout the instance ~> obj, instead of pointing only at the definitions of the\nprops.\n\nReviewed By: gabelevi\n\nDifferential Revision: D4440575\n\nfbshipit-source-id: 6d6b71c94f098bc8ee9de2917fe348905dfc7156","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/a88c95f6c383c5b273a785dfe19294f4710c0b2e"},{"sha":"46fffaccd545664ec6ff1b86d5fe32a8e9a1f387","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"add reason to MaybeT\n\nSummary:\nadds a reason to `MaybeT` so that it can track its own location that\nincludes the `?`. the `MaybeT` location is used when decomposing into `NullT`\nand `VoidT` so that errors include the `?` so that we get\n\n```\n?string\n^^^^^^^ null. This type is incompatible with\n```\n\ninstead of the slightly nonsensical\n\n```\n?string\n ^^^^^^ null. This type is incompatible with\n```\n\nReviewed By: samwgoldman\n\nDifferential Revision: D4417459\n\nfbshipit-source-id: e1724f055068a7614521e5195833a3e440a50479","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/46fffaccd545664ec6ff1b86d5fe32a8e9a1f387"},{"sha":"feffd93723f2b0369e424b0564e264e4c1834260","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"change reasons of lookups generated by structural_subtype\n\nSummary:\nin other uses of `LookupT`, the reason refers to the object the lookup\nis happening on. for instance, an `EPropAccess` error raised by an\ninvalid `InstanceT ~> LookupT` generates a message like `X. Covariant\nproperty x incompatible with contravariant use in Y`, where `Y` is the reason of\nthe `LookupT`.\n\nin `structural_subtype`, the `LookupT`'s reason referred to the prop instead of\nthe object the prop is on. it also happens to be redundant with `propref`'s\nreason.\n\nReviewed By: gabelevi\n\nDifferential Revision: D4455129\n\nfbshipit-source-id: 66df3588586437c4e50ca49b4b732b12c0e6b27c","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/feffd93723f2b0369e424b0564e264e4c1834260"},{"sha":"d460bf6cb49d2cfe243867fd1279a399e4a0e64d","author":{"name":"Nathan Schloss","email":"46b5f636b8c717b0f2d5f9ef12934351d9100cd0@fb.com"},"message":"Update flow service worker files\n\nSummary: Updating based on changes to the spec. (adding reviewers based on D4172851)\n\nReviewed By: gabelevi\n\nDifferential Revision: D4424505\n\nfbshipit-source-id: e05baee68e3826bb1a7e72006e262df025399a3f","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/d460bf6cb49d2cfe243867fd1279a399e4a0e64d"},{"sha":"5e55038ae2a739dc61285321f308b157f4e20746","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"[parser] fix directive parsing\n\nSummary:\ngroup expressions containing strings were parsed as directives\nincorrectly, and then caused an internal error.\n\nfor example,\n\n```\n(\"not a directive\");\n```\n\nor\n\n```\n\"use strict\";\n(\"also not a directive\");\n```\n\nalso implements the `directive` property on `ExpressionStatement`, per\nhttps://github.com/estree/estree/issues/6.\n\nFixes https://github.com/facebook/flow/issues/3234\n\nReviewed By: gabelevi\n\nDifferential Revision: D4448840\n\nfbshipit-source-id: c04e32315038ce689254f19f4c3170774291a8cd","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/5e55038ae2a739dc61285321f308b157f4e20746"},{"sha":"0914fb6003900d9002a5d3d76a0b84deb1e0e7d7","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"Generalize EIncompatibleObject, improve invalid subtype errors\n\nSummary:\nimproves the errors when A is not a subclass of B, but was supposed to\nbe. generalizes `EIncompatibleObject`'s name since it actually works on any two\ndef types that are incompatible, and uses that to thread the use_op attached to\nthe `ExtendsT` check through to the error message.\n\nReviewed By: gabelevi\n\nDifferential Revision: D4445843\n\nfbshipit-source-id: 79b3a86279221630002c7b39e8c77c860e308494","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/0914fb6003900d9002a5d3d76a0b84deb1e0e7d7"},{"sha":"24c3f988f3cef3893901f4ca7f68ada3aed7dabe","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"fix tests\n\nSummary: didn't re-run the non-parser tests after a last-minute change\n\nReviewed By: jeffmo\n\nDifferential Revision: D4459094\n\nfbshipit-source-id: 5578d33740652c6ad0779195d2a3b75160051b2c","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/24c3f988f3cef3893901f4ca7f68ada3aed7dabe"},{"sha":"2167fc3de4e344851e18719b0f4f00e3218f70a7","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"re-record tool tests\n\nSummary: facepalm\n\nReviewed By: jeffmo\n\nDifferential Revision: D4460106\n\nfbshipit-source-id: 8dc246a7d1ef6cddb857898cdfcc34a8d3475090","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/2167fc3de4e344851e18719b0f4f00e3218f70a7"},{"sha":"c769da5d7776320ea940090322e52bfc808e0f99","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"reposition recursions on super\n\nSummary:\nwhen we recurse on an instance's `super` type, we use the super's\nlocation (the def site of the parent class) as the lower bound in any resulting\nerrors, rather than the location of the instance that caused the lookup.\n\nthis diff repositions the super type's location to that of the instance.\n\nReviewed By: gabelevi\n\nDifferential Revision: D4459910\n\nfbshipit-source-id: b08d0f1256df5ef7a9d72cda3a85c05e20565a36","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/c769da5d7776320ea940090322e52bfc808e0f99"},{"sha":"679a40baeaad600af515f1907eedcd871091cb55","author":{"name":"Marshall Roch","email":"eb7650b0d779dc598de0c979e5c9462b7201df4d@fb.com"},"message":"[easy] fix typo in iterable test\n\nSummary:\nin string.js, the second and third tests were using the same variable\nname so this wasn't testing what it claimed to be testing.\n\nrefactored to not use variables so that it can't happen (also made a similar\nchange to array.js, just for consistency -- but also fixed a comment that was\ninaccurate)\n\nReviewed By: samwgoldman\n\nDifferential Revision: D4463533\n\nfbshipit-source-id: f1540190c55f5f7cd08db6a7232d9f782706ab7a","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/679a40baeaad600af515f1907eedcd871091cb55"},{"sha":"fe525b1933637934d9e476948f15eb8dd947a2fd","author":{"name":"Andres Suarez","email":"93a5d33d60818d15fd1d4728940c146edb25e9fd@gmail.com"},"message":"Add \"dumpTypes\" to flow.js\n\nSummary:\nI'd like to add another tab to Try Flow with this information.\nCloses https://github.com/facebook/flow/pull/3113\n\nReviewed By: AsyncDBConnMarkedDownDBException\n\nDifferential Revision: D4464555\n\nPulled By: jeffmo\n\nfbshipit-source-id: d243d1f6b72173906eedd02f3a65d327fef599f4","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/fe525b1933637934d9e476948f15eb8dd947a2fd"},{"sha":"a5b952e45d71b2cbcf8140d0d4660046e81ff267","author":{"name":"Gabe Levi","email":"74afe5e6f5651d063dedb67b26f7904eea6727d4@fb.com"},"message":"Update ./tool to read CPU profiling stats\n\nReviewed By: samwgoldman\n\nDifferential Revision: D4455832\n\nfbshipit-source-id: eb7289fe15585de83ec1acb236a7740a8c6b7f02","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/a5b952e45d71b2cbcf8140d0d4660046e81ff267"},{"sha":"6e95be3492ba7677cc018b15504b8706ce130d8a","author":{"name":"Gabe Levi","email":"74afe5e6f5651d063dedb67b26f7904eea6727d4@fb.com"},"message":"[Easy] Rename `ResolveRestT` to `ResolveSpreadT\n\nSummary:\n`ResolveRestT` is used to resolve a list of spread elements or\narguments. It is misnamed. This diff renames stuff to make it closer to what it\ndoes.\n\nReviewed By: samwgoldman\n\nDifferential Revision: D4468923\n\nfbshipit-source-id: 6b687d7ed8da684b6b985bafc704324cf21a5695","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/6e95be3492ba7677cc018b15504b8706ce130d8a"},{"sha":"0397062e832687949fe4e25b3e53ac4521a47689","author":{"name":"Gabe Levi","email":"74afe5e6f5651d063dedb67b26f7904eea6727d4@fb.com"},"message":"Support spreading iterables\n\nSummary:\nI forgot that you can spread any `Iterable`. `ResolveSpreadT` should\nsupport flowing `Iterable`'s to spread elements/args. Luckily, this is pretty\neasy to do.\n\nReviewed By: samwgoldman\n\nDifferential Revision: D4468931\n\nfbshipit-source-id: 438dcb50a9fead664e28870005cf1c5e4b9ae150","distinct":true,"url":"https://api.github.com/repos/clarkbw/flow/commits/0397062e832687949fe4e25b3e53ac4521a47689"}]}
{"actor":{"display_login":"clarkbw"}}