{"action":"created","comment":{"url":"https://api.github.com/repos/resin-os/meta-resin/pulls/comments/103731287","pull_request_review_id":24527697,"id":103731287,"diff_hunk":"@@ -4,12 +4,26 @@ set -e\n \n . /usr/sbin/resin-vars\n \n-if [ \"$PERSISTENT_LOGGING\" == \"true\" ]; then\n-    echo \"[INFO] Configure persistent logs in /mnt/conf/root-overlay/var/log/journal\"\n-    echo -e \"[Journal]\\nStorage=persistent\\n\" > /etc/systemd/journald.conf.d/resin-logs.conf\n-elif [ \"$PERSISTENT_LOGGING\" == \"false\" ]; then\n-    echo \"[INFO] Configure volatile logs in /run/log/journal\"\n-    echo -e \"[Journal]\\nStorage=volatile\\n\" > /etc/systemd/journald.conf.d/resin-logs.conf\n+machineID=`cat /etc/machine-id`\n+\n+if [ \"$PERSISTENT_LOGGING\" == \"true\" ] && [ ! -d /var/log/journal ]; then\n+    systemctl start var-log-journal.mount\n+    # Send flush signal to journald\n+    killall -USR1 systemd-journald\n+elif [ -d /var/log/journal ]; then\n+    systemctl stop systemd-journald-dev-log.socket\n+    systemctl stop systemd-journald.socket\n+    systemctl stop systemd-journald.service\n+    systemctl stop var-log-journal.mount\n+\n+    # Copy persistent logs to ram to keep them consistent\n+    mkdir -p /run/log/journal && mv /var/log/journal/$machineID /run/log/journal","path":"meta-resin-common/recipes-support/resin-logs/resin-logs/resin-logs","position":23,"original_position":23,"commit_id":"45996509d95c71587cd2286541834e49da4ccee1","original_commit_id":"b0d009f958d7df98134cb4828f9cf44b6544fdc9","user":{"login":"michal-mazurek","id":20770862,"avatar_url":"https://avatars2.githubusercontent.com/u/20770862?v=3","gravatar_id":"","url":"https://api.github.com/users/michal-mazurek","html_url":"https://github.com/michal-mazurek","followers_url":"https://api.github.com/users/michal-mazurek/followers","following_url":"https://api.github.com/users/michal-mazurek/following{/other_user}","gists_url":"https://api.github.com/users/michal-mazurek/gists{/gist_id}","starred_url":"https://api.github.com/users/michal-mazurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michal-mazurek/subscriptions","organizations_url":"https://api.github.com/users/michal-mazurek/orgs","repos_url":"https://api.github.com/users/michal-mazurek/repos","events_url":"https://api.github.com/users/michal-mazurek/events{/privacy}","received_events_url":"https://api.github.com/users/michal-mazurek/received_events","type":"User","site_admin":false},"body":"Please have a look at the standard: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html\r\nThe -e setting shall be ignored when executing the compound list following the while, until, if, or elif reserved word, a pipeline beginning with the ! reserved word, or any command of an AND-OR list other than the last.","created_at":"2017-03-01T16:47:24Z","updated_at":"2017-03-01T16:47:24Z","html_url":"https://github.com/resin-os/meta-resin/pull/554#discussion_r103731287","pull_request_url":"https://api.github.com/repos/resin-os/meta-resin/pulls/554","_links":{"self":{"href":"https://api.github.com/repos/resin-os/meta-resin/pulls/comments/103731287"},"html":{"href":"https://github.com/resin-os/meta-resin/pull/554#discussion_r103731287"},"pull_request":{"href":"https://api.github.com/repos/resin-os/meta-resin/pulls/554"}}},"pull_request":{"url":"https://api.github.com/repos/resin-os/meta-resin/pulls/554","id":102854491,"html_url":"https://github.com/resin-os/meta-resin/pull/554","diff_url":"https://github.com/resin-os/meta-resin/pull/554.diff","patch_url":"https://github.com/resin-os/meta-resin/pull/554.patch","issue_url":"https://api.github.com/repos/resin-os/meta-resin/issues/554","number":554,"state":"open","locked":false,"title":"Refactor persistent logging","user":{"login":"telphan","id":2796010,"avatar_url":"https://avatars1.githubusercontent.com/u/2796010?v=3","gravatar_id":"","url":"https://api.github.com/users/telphan","html_url":"https://github.com/telphan","followers_url":"https://api.github.com/users/telphan/followers","following_url":"https://api.github.com/users/telphan/following{/other_user}","gists_url":"https://api.github.com/users/telphan/gists{/gist_id}","starred_url":"https://api.github.com/users/telphan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telphan/subscriptions","organizations_url":"https://api.github.com/users/telphan/orgs","repos_url":"https://api.github.com/users/telphan/repos","events_url":"https://api.github.com/users/telphan/events{/privacy}","received_events_url":"https://api.github.com/users/telphan/received_events","type":"User","site_admin":false},"body":"Connects to #450 \r\nConnects to #379 \r\n@agherzan @floion @michal-mazurek ","created_at":"2017-01-24T05:15:31Z","updated_at":"2017-03-01T16:47:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7377ac43be3e9ea7803c979fb74784f56ab03641","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-os/meta-resin/pulls/554/commits","review_comments_url":"https://api.github.com/repos/resin-os/meta-resin/pulls/554/comments","review_comment_url":"https://api.github.com/repos/resin-os/meta-resin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-os/meta-resin/issues/554/comments","statuses_url":"https://api.github.com/repos/resin-os/meta-resin/statuses/45996509d95c71587cd2286541834e49da4ccee1","head":{"label":"resin-os:issue_450","ref":"issue_450","sha":"45996509d95c71587cd2286541834e49da4ccee1","user":{"login":"resin-os","id":16914061,"avatar_url":"https://avatars1.githubusercontent.com/u/16914061?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-os","html_url":"https://github.com/resin-os","followers_url":"https://api.github.com/users/resin-os/followers","following_url":"https://api.github.com/users/resin-os/following{/other_user}","gists_url":"https://api.github.com/users/resin-os/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-os/subscriptions","organizations_url":"https://api.github.com/users/resin-os/orgs","repos_url":"https://api.github.com/users/resin-os/repos","events_url":"https://api.github.com/users/resin-os/events{/privacy}","received_events_url":"https://api.github.com/users/resin-os/received_events","type":"Organization","site_admin":false},"repo":{"id":38546546,"name":"meta-resin","full_name":"resin-os/meta-resin","owner":{"login":"resin-os","id":16914061,"avatar_url":"https://avatars1.githubusercontent.com/u/16914061?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-os","html_url":"https://github.com/resin-os","followers_url":"https://api.github.com/users/resin-os/followers","following_url":"https://api.github.com/users/resin-os/following{/other_user}","gists_url":"https://api.github.com/users/resin-os/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-os/subscriptions","organizations_url":"https://api.github.com/users/resin-os/orgs","repos_url":"https://api.github.com/users/resin-os/repos","events_url":"https://api.github.com/users/resin-os/events{/privacy}","received_events_url":"https://api.github.com/users/resin-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-os/meta-resin","description":"meta-resin is a Yocto layer used to build resin.io operating system images","fork":false,"url":"https://api.github.com/repos/resin-os/meta-resin","forks_url":"https://api.github.com/repos/resin-os/meta-resin/forks","keys_url":"https://api.github.com/repos/resin-os/meta-resin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-os/meta-resin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-os/meta-resin/teams","hooks_url":"https://api.github.com/repos/resin-os/meta-resin/hooks","issue_events_url":"https://api.github.com/repos/resin-os/meta-resin/issues/events{/number}","events_url":"https://api.github.com/repos/resin-os/meta-resin/events","assignees_url":"https://api.github.com/repos/resin-os/meta-resin/assignees{/user}","branches_url":"https://api.github.com/repos/resin-os/meta-resin/branches{/branch}","tags_url":"https://api.github.com/repos/resin-os/meta-resin/tags","blobs_url":"https://api.github.com/repos/resin-os/meta-resin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-os/meta-resin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-os/meta-resin/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-os/meta-resin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-os/meta-resin/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-os/meta-resin/languages","stargazers_url":"https://api.github.com/repos/resin-os/meta-resin/stargazers","contributors_url":"https://api.github.com/repos/resin-os/meta-resin/contributors","subscribers_url":"https://api.github.com/repos/resin-os/meta-resin/subscribers","subscription_url":"https://api.github.com/repos/resin-os/meta-resin/subscription","commits_url":"https://api.github.com/repos/resin-os/meta-resin/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-os/meta-resin/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-os/meta-resin/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-os/meta-resin/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-os/meta-resin/contents/{+path}","compare_url":"https://api.github.com/repos/resin-os/meta-resin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-os/meta-resin/merges","archive_url":"https://api.github.com/repos/resin-os/meta-resin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-os/meta-resin/downloads","issues_url":"https://api.github.com/repos/resin-os/meta-resin/issues{/number}","pulls_url":"https://api.github.com/repos/resin-os/meta-resin/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-os/meta-resin/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-os/meta-resin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-os/meta-resin/labels{/name}","releases_url":"https://api.github.com/repos/resin-os/meta-resin/releases{/id}","deployments_url":"https://api.github.com/repos/resin-os/meta-resin/deployments","created_at":"2015-07-04T20:19:24Z","updated_at":"2017-02-21T20:21:03Z","pushed_at":"2017-03-01T15:59:53Z","git_url":"git://github.com/resin-os/meta-resin.git","ssh_url":"git@github.com:resin-os/meta-resin.git","clone_url":"https://github.com/resin-os/meta-resin.git","svn_url":"https://github.com/resin-os/meta-resin","homepage":null,"size":5568,"stargazers_count":285,"watchers_count":285,"language":"BitBake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":126,"forks":18,"open_issues":126,"watchers":285,"default_branch":"master"}},"base":{"label":"resin-os:master","ref":"master","sha":"bbe9bd5a3b935366db8d2e2598a9c3da951153a7","user":{"login":"resin-os","id":16914061,"avatar_url":"https://avatars1.githubusercontent.com/u/16914061?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-os","html_url":"https://github.com/resin-os","followers_url":"https://api.github.com/users/resin-os/followers","following_url":"https://api.github.com/users/resin-os/following{/other_user}","gists_url":"https://api.github.com/users/resin-os/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-os/subscriptions","organizations_url":"https://api.github.com/users/resin-os/orgs","repos_url":"https://api.github.com/users/resin-os/repos","events_url":"https://api.github.com/users/resin-os/events{/privacy}","received_events_url":"https://api.github.com/users/resin-os/received_events","type":"Organization","site_admin":false},"repo":{"id":38546546,"name":"meta-resin","full_name":"resin-os/meta-resin","owner":{"login":"resin-os","id":16914061,"avatar_url":"https://avatars1.githubusercontent.com/u/16914061?v=3","gravatar_id":"","url":"https://api.github.com/users/resin-os","html_url":"https://github.com/resin-os","followers_url":"https://api.github.com/users/resin-os/followers","following_url":"https://api.github.com/users/resin-os/following{/other_user}","gists_url":"https://api.github.com/users/resin-os/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-os/subscriptions","organizations_url":"https://api.github.com/users/resin-os/orgs","repos_url":"https://api.github.com/users/resin-os/repos","events_url":"https://api.github.com/users/resin-os/events{/privacy}","received_events_url":"https://api.github.com/users/resin-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-os/meta-resin","description":"meta-resin is a Yocto layer used to build resin.io operating system images","fork":false,"url":"https://api.github.com/repos/resin-os/meta-resin","forks_url":"https://api.github.com/repos/resin-os/meta-resin/forks","keys_url":"https://api.github.com/repos/resin-os/meta-resin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-os/meta-resin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-os/meta-resin/teams","hooks_url":"https://api.github.com/repos/resin-os/meta-resin/hooks","issue_events_url":"https://api.github.com/repos/resin-os/meta-resin/issues/events{/number}","events_url":"https://api.github.com/repos/resin-os/meta-resin/events","assignees_url":"https://api.github.com/repos/resin-os/meta-resin/assignees{/user}","branches_url":"https://api.github.com/repos/resin-os/meta-resin/branches{/branch}","tags_url":"https://api.github.com/repos/resin-os/meta-resin/tags","blobs_url":"https://api.github.com/repos/resin-os/meta-resin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-os/meta-resin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-os/meta-resin/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-os/meta-resin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-os/meta-resin/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-os/meta-resin/languages","stargazers_url":"https://api.github.com/repos/resin-os/meta-resin/stargazers","contributors_url":"https://api.github.com/repos/resin-os/meta-resin/contributors","subscribers_url":"https://api.github.com/repos/resin-os/meta-resin/subscribers","subscription_url":"https://api.github.com/repos/resin-os/meta-resin/subscription","commits_url":"https://api.github.com/repos/resin-os/meta-resin/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-os/meta-resin/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-os/meta-resin/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-os/meta-resin/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-os/meta-resin/contents/{+path}","compare_url":"https://api.github.com/repos/resin-os/meta-resin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-os/meta-resin/merges","archive_url":"https://api.github.com/repos/resin-os/meta-resin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-os/meta-resin/downloads","issues_url":"https://api.github.com/repos/resin-os/meta-resin/issues{/number}","pulls_url":"https://api.github.com/repos/resin-os/meta-resin/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-os/meta-resin/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-os/meta-resin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-os/meta-resin/labels{/name}","releases_url":"https://api.github.com/repos/resin-os/meta-resin/releases{/id}","deployments_url":"https://api.github.com/repos/resin-os/meta-resin/deployments","created_at":"2015-07-04T20:19:24Z","updated_at":"2017-02-21T20:21:03Z","pushed_at":"2017-03-01T15:59:53Z","git_url":"git://github.com/resin-os/meta-resin.git","ssh_url":"git@github.com:resin-os/meta-resin.git","clone_url":"https://github.com/resin-os/meta-resin.git","svn_url":"https://github.com/resin-os/meta-resin","homepage":null,"size":5568,"stargazers_count":285,"watchers_count":285,"language":"BitBake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":126,"forks":18,"open_issues":126,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-os/meta-resin/pulls/554"},"html":{"href":"https://github.com/resin-os/meta-resin/pull/554"},"issue":{"href":"https://api.github.com/repos/resin-os/meta-resin/issues/554"},"comments":{"href":"https://api.github.com/repos/resin-os/meta-resin/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-os/meta-resin/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-os/meta-resin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-os/meta-resin/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/resin-os/meta-resin/statuses/45996509d95c71587cd2286541834e49da4ccee1"}}}}
{"actor":{"display_login":"michal-mazurek"}}