{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/comments/139212298","pull_request_review_id":63117550,"id":139212298,"diff_hunk":"@@ -161,7 +161,13 @@ export default class Layout implements IParser {\n         var node = <HTMLElement>this.layouts[state.index];\n         if (node) {\n             // First remove all its existing attributes\n-            while (node.attributes && node.attributes.length > 0) node.removeAttribute(node.attributes[0].name);\n+            if (node.attributes) {\n+                var len = node.attributes.length;\n+                while (node.attributes && len > 0) {\n+                    node.removeAttribute(node.attributes[0].name);\n+                    len--;\n+                }\n+            }","path":"src/visualization/parsers/layout.ts","position":11,"original_position":11,"commit_id":"ebbec286aaab6da3a696de864d419d33350fc0ed","original_commit_id":"ebbec286aaab6da3a696de864d419d33350fc0ed","user":{"login":"ender336","id":74582,"avatar_url":"https://avatars3.githubusercontent.com/u/74582?v=4","gravatar_id":"","url":"https://api.github.com/users/ender336","html_url":"https://github.com/ender336","followers_url":"https://api.github.com/users/ender336/followers","following_url":"https://api.github.com/users/ender336/following{/other_user}","gists_url":"https://api.github.com/users/ender336/gists{/gist_id}","starred_url":"https://api.github.com/users/ender336/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ender336/subscriptions","organizations_url":"https://api.github.com/users/ender336/orgs","repos_url":"https://api.github.com/users/ender336/repos","events_url":"https://api.github.com/users/ender336/events{/privacy}","received_events_url":"https://api.github.com/users/ender336/received_events","type":"User","site_admin":false},"body":"this is an odd change for this CL, was this a perf optimization?","created_at":"2017-09-15T17:56:58Z","updated_at":"2017-09-15T17:56:58Z","html_url":"https://github.com/Microsoft/clarity-tools/pull/11#discussion_r139212298","pull_request_url":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/comments/139212298"},"html":{"href":"https://github.com/Microsoft/clarity-tools/pull/11#discussion_r139212298"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11","id":141146493,"html_url":"https://github.com/Microsoft/clarity-tools/pull/11","diff_url":"https://github.com/Microsoft/clarity-tools/pull/11.diff","patch_url":"https://github.com/Microsoft/clarity-tools/pull/11.patch","issue_url":"https://api.github.com/repos/Microsoft/clarity-tools/issues/11","number":11,"state":"open","locked":false,"title":"Extension 2.0 - Chrome","user":{"login":"pramukhg","id":11171530,"avatar_url":"https://avatars3.githubusercontent.com/u/11171530?v=4","gravatar_id":"","url":"https://api.github.com/users/pramukhg","html_url":"https://github.com/pramukhg","followers_url":"https://api.github.com/users/pramukhg/followers","following_url":"https://api.github.com/users/pramukhg/following{/other_user}","gists_url":"https://api.github.com/users/pramukhg/gists{/gist_id}","starred_url":"https://api.github.com/users/pramukhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pramukhg/subscriptions","organizations_url":"https://api.github.com/users/pramukhg/orgs","repos_url":"https://api.github.com/users/pramukhg/repos","events_url":"https://api.github.com/users/pramukhg/events{/privacy}","received_events_url":"https://api.github.com/users/pramukhg/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-14T18:32:43Z","updated_at":"2017-09-15T17:56:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2450ec6b34904c43ab71c48ace17c71dac3d8d83","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/clarity-tools/issues/11/comments","statuses_url":"https://api.github.com/repos/Microsoft/clarity-tools/statuses/ebbec286aaab6da3a696de864d419d33350fc0ed","head":{"label":"pramukhg:master","ref":"master","sha":"ebbec286aaab6da3a696de864d419d33350fc0ed","user":{"login":"pramukhg","id":11171530,"avatar_url":"https://avatars3.githubusercontent.com/u/11171530?v=4","gravatar_id":"","url":"https://api.github.com/users/pramukhg","html_url":"https://github.com/pramukhg","followers_url":"https://api.github.com/users/pramukhg/followers","following_url":"https://api.github.com/users/pramukhg/following{/other_user}","gists_url":"https://api.github.com/users/pramukhg/gists{/gist_id}","starred_url":"https://api.github.com/users/pramukhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pramukhg/subscriptions","organizations_url":"https://api.github.com/users/pramukhg/orgs","repos_url":"https://api.github.com/users/pramukhg/repos","events_url":"https://api.github.com/users/pramukhg/events{/privacy}","received_events_url":"https://api.github.com/users/pramukhg/received_events","type":"User","site_admin":false},"repo":{"id":103561366,"name":"clarity-tools","full_name":"pramukhg/clarity-tools","owner":{"login":"pramukhg","id":11171530,"avatar_url":"https://avatars3.githubusercontent.com/u/11171530?v=4","gravatar_id":"","url":"https://api.github.com/users/pramukhg","html_url":"https://github.com/pramukhg","followers_url":"https://api.github.com/users/pramukhg/followers","following_url":"https://api.github.com/users/pramukhg/following{/other_user}","gists_url":"https://api.github.com/users/pramukhg/gists{/gist_id}","starred_url":"https://api.github.com/users/pramukhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pramukhg/subscriptions","organizations_url":"https://api.github.com/users/pramukhg/orgs","repos_url":"https://api.github.com/users/pramukhg/repos","events_url":"https://api.github.com/users/pramukhg/events{/privacy}","received_events_url":"https://api.github.com/users/pramukhg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pramukhg/clarity-tools","description":"Sample tools and libraries to demonstrate clarity functionality","fork":true,"url":"https://api.github.com/repos/pramukhg/clarity-tools","forks_url":"https://api.github.com/repos/pramukhg/clarity-tools/forks","keys_url":"https://api.github.com/repos/pramukhg/clarity-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pramukhg/clarity-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pramukhg/clarity-tools/teams","hooks_url":"https://api.github.com/repos/pramukhg/clarity-tools/hooks","issue_events_url":"https://api.github.com/repos/pramukhg/clarity-tools/issues/events{/number}","events_url":"https://api.github.com/repos/pramukhg/clarity-tools/events","assignees_url":"https://api.github.com/repos/pramukhg/clarity-tools/assignees{/user}","branches_url":"https://api.github.com/repos/pramukhg/clarity-tools/branches{/branch}","tags_url":"https://api.github.com/repos/pramukhg/clarity-tools/tags","blobs_url":"https://api.github.com/repos/pramukhg/clarity-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pramukhg/clarity-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pramukhg/clarity-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pramukhg/clarity-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pramukhg/clarity-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pramukhg/clarity-tools/languages","stargazers_url":"https://api.github.com/repos/pramukhg/clarity-tools/stargazers","contributors_url":"https://api.github.com/repos/pramukhg/clarity-tools/contributors","subscribers_url":"https://api.github.com/repos/pramukhg/clarity-tools/subscribers","subscription_url":"https://api.github.com/repos/pramukhg/clarity-tools/subscription","commits_url":"https://api.github.com/repos/pramukhg/clarity-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pramukhg/clarity-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pramukhg/clarity-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pramukhg/clarity-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pramukhg/clarity-tools/contents/{+path}","compare_url":"https://api.github.com/repos/pramukhg/clarity-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pramukhg/clarity-tools/merges","archive_url":"https://api.github.com/repos/pramukhg/clarity-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pramukhg/clarity-tools/downloads","issues_url":"https://api.github.com/repos/pramukhg/clarity-tools/issues{/number}","pulls_url":"https://api.github.com/repos/pramukhg/clarity-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pramukhg/clarity-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pramukhg/clarity-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pramukhg/clarity-tools/labels{/name}","releases_url":"https://api.github.com/repos/pramukhg/clarity-tools/releases{/id}","deployments_url":"https://api.github.com/repos/pramukhg/clarity-tools/deployments","created_at":"2017-09-14T17:24:52Z","updated_at":"2017-09-14T17:24:54Z","pushed_at":"2017-09-14T23:31:30Z","git_url":"git://github.com/pramukhg/clarity-tools.git","ssh_url":"git@github.com:pramukhg/clarity-tools.git","clone_url":"https://github.com/pramukhg/clarity-tools.git","svn_url":"https://github.com/pramukhg/clarity-tools","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a40d650c4b70d9aa8f98180a56d8759105f71dae","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":85209440,"name":"clarity-tools","full_name":"Microsoft/clarity-tools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/clarity-tools","description":"Sample tools and libraries to demonstrate clarity functionality","fork":false,"url":"https://api.github.com/repos/Microsoft/clarity-tools","forks_url":"https://api.github.com/repos/Microsoft/clarity-tools/forks","keys_url":"https://api.github.com/repos/Microsoft/clarity-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/clarity-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/clarity-tools/teams","hooks_url":"https://api.github.com/repos/Microsoft/clarity-tools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/clarity-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/clarity-tools/events","assignees_url":"https://api.github.com/repos/Microsoft/clarity-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/clarity-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/clarity-tools/tags","blobs_url":"https://api.github.com/repos/Microsoft/clarity-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/clarity-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/clarity-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/clarity-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/clarity-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/clarity-tools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/clarity-tools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/clarity-tools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/clarity-tools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/clarity-tools/subscription","commits_url":"https://api.github.com/repos/Microsoft/clarity-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/clarity-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/clarity-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/clarity-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/clarity-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/clarity-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/clarity-tools/merges","archive_url":"https://api.github.com/repos/Microsoft/clarity-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/clarity-tools/downloads","issues_url":"https://api.github.com/repos/Microsoft/clarity-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/clarity-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/clarity-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/clarity-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/clarity-tools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/clarity-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/clarity-tools/deployments","created_at":"2017-03-16T15:08:25Z","updated_at":"2017-09-08T04:32:22Z","pushed_at":"2017-09-14T23:31:32Z","git_url":"git://github.com/Microsoft/clarity-tools.git","ssh_url":"git@github.com:Microsoft/clarity-tools.git","clone_url":"https://github.com/Microsoft/clarity-tools.git","svn_url":"https://github.com/Microsoft/clarity-tools","homepage":null,"size":67,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11"},"html":{"href":"https://github.com/Microsoft/clarity-tools/pull/11"},"issue":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/issues/11"},"comments":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/clarity-tools/statuses/ebbec286aaab6da3a696de864d419d33350fc0ed"}},"author_association":"NONE"}}
{"actor":{"display_login":"ender336"}}