{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/106729044","pull_request_review_id":27670422,"id":106729044,"diff_hunk":"@@ -221,9 +210,9 @@ class FlutterLogoDecoration extends Decoration {\n   @override\n   String toString([String prefix = '', String prefixIndent ]) {\n     final String extra = _inTransition ? ', transition $_position:$_opacity' : '';\n-    if (swatch == null)\n+    if (lightColor == null || darkColor == null)\n       return '$prefix$runtimeType(null, $style$extra)';","path":"packages/flutter/lib/src/painting/flutter_logo.dart","position":150,"original_position":150,"commit_id":"2329bc2a271761e94aebffafc938284b9e17be15","original_commit_id":"2329bc2a271761e94aebffafc938284b9e17be15","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars1.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"you can remove this if and its branch, it doesn't matter any more (it was just trying to prevent a null deref before)","created_at":"2017-03-17T19:29:05Z","updated_at":"2017-03-17T19:29:05Z","html_url":"https://github.com/flutter/flutter/pull/8833#discussion_r106729044","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/8833","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/106729044"},"html":{"href":"https://github.com/flutter/flutter/pull/8833#discussion_r106729044"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/8833"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/8833","id":111172424,"html_url":"https://github.com/flutter/flutter/pull/8833","diff_url":"https://github.com/flutter/flutter/pull/8833.diff","patch_url":"https://github.com/flutter/flutter/pull/8833.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/8833","number":8833,"state":"open","locked":false,"title":"Now each Colors.foo constant is-a Color and a color swatch","user":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars1.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/flutter/flutter/issues/6706\r\n","created_at":"2017-03-16T21:45:35Z","updated_at":"2017-03-17T19:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c3bf0941d5a2eed43d944ced4867d742429f749","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/8833/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/8833/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/8833/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/2329bc2a271761e94aebffafc938284b9e17be15","head":{"label":"HansMuller:rev_colors_api","ref":"rev_colors_api","sha":"2329bc2a271761e94aebffafc938284b9e17be15","user":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars1.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"repo":{"id":45849791,"name":"flutter","full_name":"HansMuller/flutter","owner":{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars1.githubusercontent.com/u/1377460?v=3","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HansMuller/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/HansMuller/flutter","forks_url":"https://api.github.com/repos/HansMuller/flutter/forks","keys_url":"https://api.github.com/repos/HansMuller/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HansMuller/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HansMuller/flutter/teams","hooks_url":"https://api.github.com/repos/HansMuller/flutter/hooks","issue_events_url":"https://api.github.com/repos/HansMuller/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/HansMuller/flutter/events","assignees_url":"https://api.github.com/repos/HansMuller/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/HansMuller/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/HansMuller/flutter/tags","blobs_url":"https://api.github.com/repos/HansMuller/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HansMuller/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HansMuller/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/HansMuller/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HansMuller/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/HansMuller/flutter/languages","stargazers_url":"https://api.github.com/repos/HansMuller/flutter/stargazers","contributors_url":"https://api.github.com/repos/HansMuller/flutter/contributors","subscribers_url":"https://api.github.com/repos/HansMuller/flutter/subscribers","subscription_url":"https://api.github.com/repos/HansMuller/flutter/subscription","commits_url":"https://api.github.com/repos/HansMuller/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/HansMuller/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/HansMuller/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/HansMuller/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/HansMuller/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/HansMuller/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HansMuller/flutter/merges","archive_url":"https://api.github.com/repos/HansMuller/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HansMuller/flutter/downloads","issues_url":"https://api.github.com/repos/HansMuller/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/HansMuller/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/HansMuller/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/HansMuller/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HansMuller/flutter/labels{/name}","releases_url":"https://api.github.com/repos/HansMuller/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/HansMuller/flutter/deployments","created_at":"2015-11-09T16:11:46Z","updated_at":"2015-11-09T16:11:50Z","pushed_at":"2017-03-17T14:50:24Z","git_url":"git://github.com/HansMuller/flutter.git","ssh_url":"git@github.com:HansMuller/flutter.git","clone_url":"https://github.com/HansMuller/flutter.git","svn_url":"https://github.com/HansMuller/flutter","homepage":"http://flutter.io","size":24037,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"dce4bf8599ba5d96692d16eaeade15d0d142a410","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-03-17T16:46:19Z","pushed_at":"2017-03-17T19:16:20Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":23765,"stargazers_count":4087,"watchers_count":4087,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":446,"mirror_url":null,"open_issues_count":1371,"forks":446,"open_issues":1371,"watchers":4087,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/8833"},"html":{"href":"https://github.com/flutter/flutter/pull/8833"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/8833"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/8833/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/8833/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/8833/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/2329bc2a271761e94aebffafc938284b9e17be15"}}}}
{"actor":{"display_login":"Hixie"}}