{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-guacamole-server/issues/113","repository_url":"https://api.github.com/repos/apache/incubator-guacamole-server","labels_url":"https://api.github.com/repos/apache/incubator-guacamole-server/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-guacamole-server/issues/113/comments","events_url":"https://api.github.com/repos/apache/incubator-guacamole-server/issues/113/events","html_url":"https://github.com/apache/incubator-guacamole-server/pull/113","id":260451091,"number":113,"title":"GUACAMOLE-396: Fixing ssh socket for IPv6 address","user":{"login":"sanhex","id":10353316,"avatar_url":"https://avatars0.githubusercontent.com/u/10353316?v=4","gravatar_id":"","url":"https://api.github.com/users/sanhex","html_url":"https://github.com/sanhex","followers_url":"https://api.github.com/users/sanhex/followers","following_url":"https://api.github.com/users/sanhex/following{/other_user}","gists_url":"https://api.github.com/users/sanhex/gists{/gist_id}","starred_url":"https://api.github.com/users/sanhex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanhex/subscriptions","organizations_url":"https://api.github.com/users/sanhex/orgs","repos_url":"https://api.github.com/users/sanhex/repos","events_url":"https://api.github.com/users/sanhex/events{/privacy}","received_events_url":"https://api.github.com/users/sanhex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-09-26T00:04:28Z","updated_at":"2017-09-26T22:11:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-guacamole-server/pulls/113","html_url":"https://github.com/apache/incubator-guacamole-server/pull/113","diff_url":"https://github.com/apache/incubator-guacamole-server/pull/113.diff","patch_url":"https://github.com/apache/incubator-guacamole-server/pull/113.patch"},"body":"GUACAMOLE-396: guacd cannot connect to ssh servers with IPv6 addresses\r\n\r\nRoot Cause:\r\nIn the ssh library of guacd, the TCP socket for connecting to ssh server is created with AF_INET. So it does not support IPv6 address.\r\n\r\nSolution:\r\nWhen guacd creates the socket for ssh in guac_common_ssh_create_session(), stop using hard coded AF_INET for socket() call, use the address family which is returned from getaddrinfo().\r\n\r\nTest:\r\n- Connected successfully via ssh connections with IPv4 and IPv6 hosts.\r\n- No connection error in guacd logs.\r\n- Simulated a connection failure with specifying a ssh server which does not exist. guacd worked well in this case."},"comment":{"url":"https://api.github.com/repos/apache/incubator-guacamole-server/issues/comments/332351172","html_url":"https://github.com/apache/incubator-guacamole-server/pull/113#issuecomment-332351172","issue_url":"https://api.github.com/repos/apache/incubator-guacamole-server/issues/113","id":332351172,"user":{"login":"sanhex","id":10353316,"avatar_url":"https://avatars0.githubusercontent.com/u/10353316?v=4","gravatar_id":"","url":"https://api.github.com/users/sanhex","html_url":"https://github.com/sanhex","followers_url":"https://api.github.com/users/sanhex/followers","following_url":"https://api.github.com/users/sanhex/following{/other_user}","gists_url":"https://api.github.com/users/sanhex/gists{/gist_id}","starred_url":"https://api.github.com/users/sanhex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanhex/subscriptions","organizations_url":"https://api.github.com/users/sanhex/orgs","repos_url":"https://api.github.com/users/sanhex/repos","events_url":"https://api.github.com/users/sanhex/events{/privacy}","received_events_url":"https://api.github.com/users/sanhex/received_events","type":"User","site_admin":false},"created_at":"2017-09-26T22:11:03Z","updated_at":"2017-09-26T22:11:03Z","author_association":"NONE","body":"Hi Mike,\n\nI made 2 commits with the web editor on GitHub. After that, I tried to\nrevert them with GitHub Desktop. So now I can see 4 commits.\n\nI'm following the below official instructions to rebase my commits on Linux\nserver. When I did \"git rebase -i HEAD~4\" My commits cannot be shown in the\ninteractive editor. I also tried \"git rebase -i $hash\". It looks my branch\nis exactly the same with the official master branch. I cannot get my\ncommits in command line. Could you advise? Or maybe I can close this pull\nrequest and create a new one with my latest code.\n\nhttps://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request\n\nOn Tue, Sep 26, 2017 at 12:28 PM, Mike Jumper <notifications@github.com>\nwrote:\n\n> I recommend looking into git's interactive rebase feature.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/apache/incubator-guacamole-server/pull/113#issuecomment-332309085>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AJ36pG1AUZA-54NyKF_BMH2hJcbQrS2oks5smVBBgaJpZM4Pjf-5>\n> .\n>\n"}}
{"actor":{"display_login":"sanhex"}}