{"action":"created","comment":{"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments/146845672","pull_request_review_id":71845396,"id":146845672,"diff_hunk":"@@ -39,3 +39,14 @@ function classloader($class) {\n add_action('widgets_init', __NAMESPACE__ . '\\Widgets\\UserLoginFormWidget::init');\n add_action('init', __NAMESPACE__ . '\\Plugin::init', 20);\n add_action('admin_init', __NAMESPACE__ . '\\Admin::init');\n+\n+if (defined('WP_CLI') && WP_CLI) {\n+  // Subcommands that extend an existing namespace wrongly replace the whole\n+  // namespace, so each subcommand needs to be registered separately.\n+  // @see https://make.wordpress.org/cli/handbook/commands-cookbook/#required-registration-arguments\n+  // @see https://github.com/wp-cli/wp-cli/issues/1767\n+  // @see https://github.com/wp-cli/wp-cli/issues/1795\n+  // @see https://github.com/wp-cli/wp-cli/pull/1877","path":"core-standards.php","position":11,"original_position":11,"commit_id":"baa3d219d9b07a966d0230d32872b1b1d043cb29","original_commit_id":"baa3d219d9b07a966d0230d32872b1b1d043cb29","user":{"login":"fabianmarz","id":863823,"avatar_url":"https://avatars2.githubusercontent.com/u/863823?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianmarz","html_url":"https://github.com/fabianmarz","followers_url":"https://api.github.com/users/fabianmarz/followers","following_url":"https://api.github.com/users/fabianmarz/following{/other_user}","gists_url":"https://api.github.com/users/fabianmarz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianmarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianmarz/subscriptions","organizations_url":"https://api.github.com/users/fabianmarz/orgs","repos_url":"https://api.github.com/users/fabianmarz/repos","events_url":"https://api.github.com/users/fabianmarz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianmarz/received_events","type":"User","site_admin":false},"body":"Sorry, I don't really get the mentioned issues here. The issues are telling, that the subcommands are not listed when running `$ wp help`, which was fixed in v0.19.0. So why did you mention them here?\r\n\r\nAlso this paragraph can be found in the cookbook:\r\n>All commands can be registered to their own top-level namespace (e.g. wp foo), or as subcommands to an existing namespace (e.g. wp core foo). For the latter, simply include the existing namespace as a part of the command definition.\r\n\r\nOr is this working for parent commands but not already existing subcommands?","created_at":"2017-10-25T12:53:15Z","updated_at":"2017-10-25T12:53:52Z","html_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/11#discussion_r146845672","pull_request_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments/146845672"},"html":{"href":"https://github.com/netzstrategen/wordpress-core-standards/pull/11#discussion_r146845672"},"pull_request":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11","id":148540474,"html_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/11","diff_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/11.diff","patch_url":"https://github.com/netzstrategen/wordpress-core-standards/pull/11.patch","issue_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/11","number":11,"state":"open","locked":false,"title":"Added CLI commands for exporting/importing users.","user":{"login":"sun","id":41992,"avatar_url":"https://avatars3.githubusercontent.com/u/41992?v=4","gravatar_id":"","url":"https://api.github.com/users/sun","html_url":"https://github.com/sun","followers_url":"https://api.github.com/users/sun/followers","following_url":"https://api.github.com/users/sun/following{/other_user}","gists_url":"https://api.github.com/users/sun/gists{/gist_id}","starred_url":"https://api.github.com/users/sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sun/subscriptions","organizations_url":"https://api.github.com/users/sun/orgs","repos_url":"https://api.github.com/users/sun/repos","events_url":"https://api.github.com/users/sun/events{/privacy}","received_events_url":"https://api.github.com/users/sun/received_events","type":"User","site_admin":false},"body":"`wp user export-csv` exports all users including core meta data and (hashed) passwords into a CSV file.\r\n\r\n`wp user import-csv-raw` is a wrapper around the native `import-csv` subcommand that allows to import all data from a CSV file including already hashed passwords.\r\n\r\nFor this synchronization to work, the hash salts in wp-config.php need to be identical.\r\n\r\nWarning: Install the plugin disable-emails to ensure that no emails are sent out during import.\r\n\r\nKnown issues:\r\n\r\n- export-csv does not export all existing meta fields, because maintaining a consistent CSV column order across all user records is non-trivial.\r\n\r\n- export-csv does not support any options to select/filter/limit the users to export.\r\n\r\n- import-csv-raw does not support all options of import-csv.","created_at":"2017-10-24T23:54:00Z","updated_at":"2017-10-25T12:53:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70f7f2ea2104e4a777173131a5ae3ed6a418faae","assignee":{"login":"sun","id":41992,"avatar_url":"https://avatars3.githubusercontent.com/u/41992?v=4","gravatar_id":"","url":"https://api.github.com/users/sun","html_url":"https://github.com/sun","followers_url":"https://api.github.com/users/sun/followers","following_url":"https://api.github.com/users/sun/following{/other_user}","gists_url":"https://api.github.com/users/sun/gists{/gist_id}","starred_url":"https://api.github.com/users/sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sun/subscriptions","organizations_url":"https://api.github.com/users/sun/orgs","repos_url":"https://api.github.com/users/sun/repos","events_url":"https://api.github.com/users/sun/events{/privacy}","received_events_url":"https://api.github.com/users/sun/received_events","type":"User","site_admin":false},"assignees":[{"login":"sun","id":41992,"avatar_url":"https://avatars3.githubusercontent.com/u/41992?v=4","gravatar_id":"","url":"https://api.github.com/users/sun","html_url":"https://github.com/sun","followers_url":"https://api.github.com/users/sun/followers","following_url":"https://api.github.com/users/sun/following{/other_user}","gists_url":"https://api.github.com/users/sun/gists{/gist_id}","starred_url":"https://api.github.com/users/sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sun/subscriptions","organizations_url":"https://api.github.com/users/sun/orgs","repos_url":"https://api.github.com/users/sun/repos","events_url":"https://api.github.com/users/sun/events{/privacy}","received_events_url":"https://api.github.com/users/sun/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11/commits","review_comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11/comments","review_comment_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/11/comments","statuses_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/baa3d219d9b07a966d0230d32872b1b1d043cb29","head":{"label":"netzstrategen:user-sync-sun","ref":"user-sync-sun","sha":"baa3d219d9b07a966d0230d32872b1b1d043cb29","user":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"repo":{"id":52965413,"name":"wordpress-core-standards","full_name":"netzstrategen/wordpress-core-standards","owner":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netzstrategen/wordpress-core-standards","description":"Common enhancements for WordPress Core.","fork":false,"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards","forks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/forks","keys_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/teams","hooks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/hooks","issue_events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/events{/number}","events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/events","assignees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/assignees{/user}","branches_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/branches{/branch}","tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/tags","blobs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/languages","stargazers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/stargazers","contributors_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contributors","subscribers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscribers","subscription_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscription","commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contents/{+path}","compare_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/merges","archive_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/downloads","issues_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues{/number}","pulls_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/labels{/name}","releases_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/releases{/id}","deployments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/deployments","created_at":"2016-03-02T13:37:49Z","updated_at":"2017-07-22T16:36:49Z","pushed_at":"2017-10-24T23:54:00Z","git_url":"git://github.com/netzstrategen/wordpress-core-standards.git","ssh_url":"git@github.com:netzstrategen/wordpress-core-standards.git","clone_url":"https://github.com/netzstrategen/wordpress-core-standards.git","svn_url":"https://github.com/netzstrategen/wordpress-core-standards","homepage":null,"size":31,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"netzstrategen:master","ref":"master","sha":"08fd28a28eddba563e20fef2301d86bf20256f38","user":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"repo":{"id":52965413,"name":"wordpress-core-standards","full_name":"netzstrategen/wordpress-core-standards","owner":{"login":"netzstrategen","id":10957709,"avatar_url":"https://avatars0.githubusercontent.com/u/10957709?v=4","gravatar_id":"","url":"https://api.github.com/users/netzstrategen","html_url":"https://github.com/netzstrategen","followers_url":"https://api.github.com/users/netzstrategen/followers","following_url":"https://api.github.com/users/netzstrategen/following{/other_user}","gists_url":"https://api.github.com/users/netzstrategen/gists{/gist_id}","starred_url":"https://api.github.com/users/netzstrategen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzstrategen/subscriptions","organizations_url":"https://api.github.com/users/netzstrategen/orgs","repos_url":"https://api.github.com/users/netzstrategen/repos","events_url":"https://api.github.com/users/netzstrategen/events{/privacy}","received_events_url":"https://api.github.com/users/netzstrategen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netzstrategen/wordpress-core-standards","description":"Common enhancements for WordPress Core.","fork":false,"url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards","forks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/forks","keys_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/teams","hooks_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/hooks","issue_events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/events{/number}","events_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/events","assignees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/assignees{/user}","branches_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/branches{/branch}","tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/tags","blobs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/languages","stargazers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/stargazers","contributors_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contributors","subscribers_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscribers","subscription_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/subscription","commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/contents/{+path}","compare_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/merges","archive_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/downloads","issues_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues{/number}","pulls_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/labels{/name}","releases_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/releases{/id}","deployments_url":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/deployments","created_at":"2016-03-02T13:37:49Z","updated_at":"2017-07-22T16:36:49Z","pushed_at":"2017-10-24T23:54:00Z","git_url":"git://github.com/netzstrategen/wordpress-core-standards.git","ssh_url":"git@github.com:netzstrategen/wordpress-core-standards.git","clone_url":"https://github.com/netzstrategen/wordpress-core-standards.git","svn_url":"https://github.com/netzstrategen/wordpress-core-standards","homepage":null,"size":31,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11"},"html":{"href":"https://github.com/netzstrategen/wordpress-core-standards/pull/11"},"issue":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/11"},"comments":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/netzstrategen/wordpress-core-standards/statuses/baa3d219d9b07a966d0230d32872b1b1d043cb29"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fabianmarz"}}