{"action":"created","issue":{"url":"https://api.github.com/repos/whitequark/irclogger/issues/22","repository_url":"https://api.github.com/repos/whitequark/irclogger","labels_url":"https://api.github.com/repos/whitequark/irclogger/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/whitequark/irclogger/issues/22/comments","events_url":"https://api.github.com/repos/whitequark/irclogger/issues/22/events","html_url":"https://github.com/whitequark/irclogger/pull/22","id":211965752,"number":22,"title":"Fix for channel names containing a forward slash","user":{"login":"StollD","id":7887606,"avatar_url":"https://avatars0.githubusercontent.com/u/7887606?v=3","gravatar_id":"","url":"https://api.github.com/users/StollD","html_url":"https://github.com/StollD","followers_url":"https://api.github.com/users/StollD/followers","following_url":"https://api.github.com/users/StollD/following{/other_user}","gists_url":"https://api.github.com/users/StollD/gists{/gist_id}","starred_url":"https://api.github.com/users/StollD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StollD/subscriptions","organizations_url":"https://api.github.com/users/StollD/orgs","repos_url":"https://api.github.com/users/StollD/repos","events_url":"https://api.github.com/users/StollD/events{/privacy}","received_events_url":"https://api.github.com/users/StollD/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-03-05T16:50:23Z","updated_at":"2017-03-07T08:32:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whitequark/irclogger/pulls/22","html_url":"https://github.com/whitequark/irclogger/pull/22","diff_url":"https://github.com/whitequark/irclogger/pull/22.diff","patch_url":"https://github.com/whitequark/irclogger/pull/22.patch"},"body":"Its me again\r\n\r\n@eggrobin discovered that the log viewer breaks on channel names containing a forward slash, because they don't get escaped. This pull request handles (or at least tries to) this.\r\n\r\nAdditionally, we (or rather eggrobin) detected another bug. When a channel name starts with a . after the #, the logger won't be able to see a difference between #.channelname and ##channelname. Of course this could be changed, by simply leaving the second # there, and not changing it to a ., but this would break the links for this channel on your logging instance: https://irclog.whitequark.org/.openfpga/2017-03-05\r\nAs they might use the logs through the link, breaking it might be a bit unfortunate.\r\n\r\nDo you have any ideas on this?"},"comment":{"url":"https://api.github.com/repos/whitequark/irclogger/issues/comments/284655511","html_url":"https://github.com/whitequark/irclogger/pull/22#issuecomment-284655511","issue_url":"https://api.github.com/repos/whitequark/irclogger/issues/22","id":284655511,"user":{"login":"eggrobin","id":2284290,"avatar_url":"https://avatars3.githubusercontent.com/u/2284290?v=3","gravatar_id":"","url":"https://api.github.com/users/eggrobin","html_url":"https://github.com/eggrobin","followers_url":"https://api.github.com/users/eggrobin/followers","following_url":"https://api.github.com/users/eggrobin/following{/other_user}","gists_url":"https://api.github.com/users/eggrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/eggrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggrobin/subscriptions","organizations_url":"https://api.github.com/users/eggrobin/orgs","repos_url":"https://api.github.com/users/eggrobin/repos","events_url":"https://api.github.com/users/eggrobin/events{/privacy}","received_events_url":"https://api.github.com/users/eggrobin/received_events","type":"User","site_admin":false},"created_at":"2017-03-07T08:32:34Z","updated_at":"2017-03-07T08:32:34Z","body":"@whitequark: Uh, right, may not occur. I need another coffee, clearly. I understand not liking `,` for escapes, it's just that the mathematician in me likes injective things (`~` is fine in a channel name, and I agree, there's probably less of a chance of `~h~` being a thing).\r\n\r\nAlso I nearly typed \"I another coffee\" above, so I am going to make that coffee right now."}}
{"actor":{"display_login":"eggrobin"}}