{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/fetch/pulls/comments/144804225","pull_request_review_id":69510155,"id":144804225,"diff_hunk":"@@ -4855,6 +4855,70 @@ initially a new {{AbortSignal}} object.\n <a for=Request>request</a>'s\n <a for=request>body</a>.\n \n+<dl class=domintro>\n+ <dt><code><var>request</var> = new <a constructor lt=\"Request()\">Request</a>(<var>input</var> [,\n+ <var>init</var>])</code>\n+ <dd>Returns a new <var>request</var> whose <a attribute for=Request>url</a> attribute value is\n+ <var>input</var> if <var>input</var> is a string, and <var>input</var>'s\n+ <a attribute for=Request>url</a> if <var>input</var> is a {{Request}}. The optional\n+ <var>init</var> argument allows for setting attributes appearing in {{RequestInit}} via object\n+ members of the same name.","path":"fetch.bs","position":11,"original_position":11,"commit_id":"93c16438b9c02f1fd3c317de93d4c5ee486e50dd","original_commit_id":"93c16438b9c02f1fd3c317de93d4c5ee486e50dd","user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars0.githubusercontent.com/u/1544111?v=4","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"body":"Describing the dictionary members here seems like a good idea. I think we typically do that. See the observe() method at https://dom.spec.whatwg.org/#interface-mutationobserver for instance.","created_at":"2017-10-16T10:03:01Z","updated_at":"2017-10-16T10:13:06Z","html_url":"https://github.com/whatwg/fetch/pull/617#discussion_r144804225","pull_request_url":"https://api.github.com/repos/whatwg/fetch/pulls/617","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/whatwg/fetch/pulls/comments/144804225"},"html":{"href":"https://github.com/whatwg/fetch/pull/617#discussion_r144804225"},"pull_request":{"href":"https://api.github.com/repos/whatwg/fetch/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/fetch/pulls/617","id":146699388,"html_url":"https://github.com/whatwg/fetch/pull/617","diff_url":"https://github.com/whatwg/fetch/pull/617.diff","patch_url":"https://github.com/whatwg/fetch/pull/617.patch","issue_url":"https://api.github.com/repos/whatwg/fetch/issues/617","number":617,"state":"open","locked":false,"title":"[WIP] Request domintro box","user":{"login":"domfarolino","id":9669289,"avatar_url":"https://avatars1.githubusercontent.com/u/9669289?v=4","gravatar_id":"","url":"https://api.github.com/users/domfarolino","html_url":"https://github.com/domfarolino","followers_url":"https://api.github.com/users/domfarolino/followers","following_url":"https://api.github.com/users/domfarolino/following{/other_user}","gists_url":"https://api.github.com/users/domfarolino/gists{/gist_id}","starred_url":"https://api.github.com/users/domfarolino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domfarolino/subscriptions","organizations_url":"https://api.github.com/users/domfarolino/orgs","repos_url":"https://api.github.com/users/domfarolino/repos","events_url":"https://api.github.com/users/domfarolino/events{/privacy}","received_events_url":"https://api.github.com/users/domfarolino/received_events","type":"User","site_admin":false},"body":"This PR is a WIP, and does not yet contain information about the members of Request objects that are available as a result of implementing the Body interface. I just wanted to push this up before it is finished to get some feedback so I could start working on any requested changes while I work on finishing it.\n\nWas a little unsure as to how vague I should be in the descriptions below, so any feedback on this to fix or clarify would be appreciated. Thanks!\n\nThis satisfies part of https://github.com/whatwg/fetch/issues/543\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n[Preview](https://s3.amazonaws.com/pr-preview/domfarolino/fetch/request-domintro.html) | [Diff](https://s3.amazonaws.com/pr-preview/whatwg/fetch/d84658e...domfarolino:93c1643.html)","created_at":"2017-10-16T05:29:13Z","updated_at":"2017-10-16T10:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab48a1369f00c1d0e96dd334e14786a307f33cab","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/fetch/pulls/617/commits","review_comments_url":"https://api.github.com/repos/whatwg/fetch/pulls/617/comments","review_comment_url":"https://api.github.com/repos/whatwg/fetch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/fetch/issues/617/comments","statuses_url":"https://api.github.com/repos/whatwg/fetch/statuses/93c16438b9c02f1fd3c317de93d4c5ee486e50dd","head":{"label":"domfarolino:request-domintro","ref":"request-domintro","sha":"93c16438b9c02f1fd3c317de93d4c5ee486e50dd","user":{"login":"domfarolino","id":9669289,"avatar_url":"https://avatars1.githubusercontent.com/u/9669289?v=4","gravatar_id":"","url":"https://api.github.com/users/domfarolino","html_url":"https://github.com/domfarolino","followers_url":"https://api.github.com/users/domfarolino/followers","following_url":"https://api.github.com/users/domfarolino/following{/other_user}","gists_url":"https://api.github.com/users/domfarolino/gists{/gist_id}","starred_url":"https://api.github.com/users/domfarolino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domfarolino/subscriptions","organizations_url":"https://api.github.com/users/domfarolino/orgs","repos_url":"https://api.github.com/users/domfarolino/repos","events_url":"https://api.github.com/users/domfarolino/events{/privacy}","received_events_url":"https://api.github.com/users/domfarolino/received_events","type":"User","site_admin":false},"repo":{"id":91711879,"name":"fetch","full_name":"domfarolino/fetch","owner":{"login":"domfarolino","id":9669289,"avatar_url":"https://avatars1.githubusercontent.com/u/9669289?v=4","gravatar_id":"","url":"https://api.github.com/users/domfarolino","html_url":"https://github.com/domfarolino","followers_url":"https://api.github.com/users/domfarolino/followers","following_url":"https://api.github.com/users/domfarolino/following{/other_user}","gists_url":"https://api.github.com/users/domfarolino/gists{/gist_id}","starred_url":"https://api.github.com/users/domfarolino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domfarolino/subscriptions","organizations_url":"https://api.github.com/users/domfarolino/orgs","repos_url":"https://api.github.com/users/domfarolino/repos","events_url":"https://api.github.com/users/domfarolino/events{/privacy}","received_events_url":"https://api.github.com/users/domfarolino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domfarolino/fetch","description":"Fetch Standard","fork":true,"url":"https://api.github.com/repos/domfarolino/fetch","forks_url":"https://api.github.com/repos/domfarolino/fetch/forks","keys_url":"https://api.github.com/repos/domfarolino/fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domfarolino/fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domfarolino/fetch/teams","hooks_url":"https://api.github.com/repos/domfarolino/fetch/hooks","issue_events_url":"https://api.github.com/repos/domfarolino/fetch/issues/events{/number}","events_url":"https://api.github.com/repos/domfarolino/fetch/events","assignees_url":"https://api.github.com/repos/domfarolino/fetch/assignees{/user}","branches_url":"https://api.github.com/repos/domfarolino/fetch/branches{/branch}","tags_url":"https://api.github.com/repos/domfarolino/fetch/tags","blobs_url":"https://api.github.com/repos/domfarolino/fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domfarolino/fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domfarolino/fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/domfarolino/fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domfarolino/fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/domfarolino/fetch/languages","stargazers_url":"https://api.github.com/repos/domfarolino/fetch/stargazers","contributors_url":"https://api.github.com/repos/domfarolino/fetch/contributors","subscribers_url":"https://api.github.com/repos/domfarolino/fetch/subscribers","subscription_url":"https://api.github.com/repos/domfarolino/fetch/subscription","commits_url":"https://api.github.com/repos/domfarolino/fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/domfarolino/fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/domfarolino/fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/domfarolino/fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/domfarolino/fetch/contents/{+path}","compare_url":"https://api.github.com/repos/domfarolino/fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domfarolino/fetch/merges","archive_url":"https://api.github.com/repos/domfarolino/fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domfarolino/fetch/downloads","issues_url":"https://api.github.com/repos/domfarolino/fetch/issues{/number}","pulls_url":"https://api.github.com/repos/domfarolino/fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/domfarolino/fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/domfarolino/fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domfarolino/fetch/labels{/name}","releases_url":"https://api.github.com/repos/domfarolino/fetch/releases{/id}","deployments_url":"https://api.github.com/repos/domfarolino/fetch/deployments","created_at":"2017-05-18T15:51:40Z","updated_at":"2017-05-18T15:51:42Z","pushed_at":"2017-10-16T05:24:54Z","git_url":"git://github.com/domfarolino/fetch.git","ssh_url":"git@github.com:domfarolino/fetch.git","clone_url":"https://github.com/domfarolino/fetch.git","svn_url":"https://github.com/domfarolino/fetch","homepage":"https://fetch.spec.whatwg.org/","size":6437,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"d84658ee3f97b0dafa3ff3e4a2d10dbf8e77c2d6","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":5777189,"name":"fetch","full_name":"whatwg/fetch","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/fetch","description":"Fetch Standard","fork":false,"url":"https://api.github.com/repos/whatwg/fetch","forks_url":"https://api.github.com/repos/whatwg/fetch/forks","keys_url":"https://api.github.com/repos/whatwg/fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/fetch/teams","hooks_url":"https://api.github.com/repos/whatwg/fetch/hooks","issue_events_url":"https://api.github.com/repos/whatwg/fetch/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/fetch/events","assignees_url":"https://api.github.com/repos/whatwg/fetch/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/fetch/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/fetch/tags","blobs_url":"https://api.github.com/repos/whatwg/fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/fetch/languages","stargazers_url":"https://api.github.com/repos/whatwg/fetch/stargazers","contributors_url":"https://api.github.com/repos/whatwg/fetch/contributors","subscribers_url":"https://api.github.com/repos/whatwg/fetch/subscribers","subscription_url":"https://api.github.com/repos/whatwg/fetch/subscription","commits_url":"https://api.github.com/repos/whatwg/fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/fetch/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/fetch/merges","archive_url":"https://api.github.com/repos/whatwg/fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/fetch/downloads","issues_url":"https://api.github.com/repos/whatwg/fetch/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/fetch/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/fetch/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/fetch/deployments","created_at":"2012-09-12T08:39:20Z","updated_at":"2017-10-16T07:46:58Z","pushed_at":"2017-10-16T05:29:14Z","git_url":"git://github.com/whatwg/fetch.git","ssh_url":"git@github.com:whatwg/fetch.git","clone_url":"https://github.com/whatwg/fetch.git","svn_url":"https://github.com/whatwg/fetch","homepage":"https://fetch.spec.whatwg.org/","size":6412,"stargazers_count":790,"watchers_count":790,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":108,"forks":88,"open_issues":108,"watchers":790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/fetch/pulls/617"},"html":{"href":"https://github.com/whatwg/fetch/pull/617"},"issue":{"href":"https://api.github.com/repos/whatwg/fetch/issues/617"},"comments":{"href":"https://api.github.com/repos/whatwg/fetch/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/fetch/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/fetch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/fetch/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/fetch/statuses/93c16438b9c02f1fd3c317de93d4c5ee486e50dd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"annevk"}}