{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/122268846","pull_request_review_id":44369095,"id":122268846,"diff_hunk":"@@ -0,0 +1,100 @@\n+/*!\n+ * Copyright (c) 2017, Okta, Inc. and/or its affiliates. All rights reserved.\n+ * The Okta software accompanied by this notice is provided pursuant to the Apache License, Version 2.0 (the \"License.\")\n+ *\n+ * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0.\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *\n+ * See the License for the specific language governing permissions and limitations under the License.\n+ */\n+\n+define(['okta'], function (Okta) {\n+\n+  var _ = Okta._;\n+\n+  // return true if the complexity is a number and the value is greater than zero\n+  var isComplexityEnabledPosNum = function(complexityValue) {\n+    return complexityValue > 0;","path":"src/util/PasswordComplexityUtil.js","position":19,"original_position":19,"commit_id":"6ae4254376d54eccf584e14715d18a1256cbc625","original_commit_id":"6ae4254376d54eccf584e14715d18a1256cbc625","user":{"login":"samerfanek-okta","id":8701503,"avatar_url":"https://avatars1.githubusercontent.com/u/8701503?v=3","gravatar_id":"","url":"https://api.github.com/users/samerfanek-okta","html_url":"https://github.com/samerfanek-okta","followers_url":"https://api.github.com/users/samerfanek-okta/followers","following_url":"https://api.github.com/users/samerfanek-okta/following{/other_user}","gists_url":"https://api.github.com/users/samerfanek-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/samerfanek-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samerfanek-okta/subscriptions","organizations_url":"https://api.github.com/users/samerfanek-okta/orgs","repos_url":"https://api.github.com/users/samerfanek-okta/repos","events_url":"https://api.github.com/users/samerfanek-okta/events{/privacy}","received_events_url":"https://api.github.com/users/samerfanek-okta/received_events","type":"User","site_admin":false},"body":"Do you want to also perhaps validate that ``complexityValue`` is indeed a number via something like ``!isNaN(complexityValue)``?","created_at":"2017-06-15T17:53:27Z","updated_at":"2017-06-15T17:56:23Z","html_url":"https://github.com/okta/okta-signin-widget/pull/235#discussion_r122268846","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/122268846"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/235#discussion_r122268846"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235","id":125092478,"html_url":"https://github.com/okta/okta-signin-widget/pull/235","diff_url":"https://github.com/okta/okta-signin-widget/pull/235.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/235.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/235","number":235,"state":"open","locked":false,"title":":seedling: update registration schema","user":{"login":"hor-kanchan-okta","id":22689859,"avatar_url":"https://avatars0.githubusercontent.com/u/22689859?v=3","gravatar_id":"","url":"https://api.github.com/users/hor-kanchan-okta","html_url":"https://github.com/hor-kanchan-okta","followers_url":"https://api.github.com/users/hor-kanchan-okta/followers","following_url":"https://api.github.com/users/hor-kanchan-okta/following{/other_user}","gists_url":"https://api.github.com/users/hor-kanchan-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/hor-kanchan-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hor-kanchan-okta/subscriptions","organizations_url":"https://api.github.com/users/hor-kanchan-okta/orgs","repos_url":"https://api.github.com/users/hor-kanchan-okta/repos","events_url":"https://api.github.com/users/hor-kanchan-okta/events{/privacy}","received_events_url":"https://api.github.com/users/hor-kanchan-okta/received_events","type":"User","site_admin":false},"body":"The registration schema now contains 'required', 'fieldOrder' and\r\n'passwordComplexity'.\r\n\r\n<img width=\"409\" alt=\"screen shot 2017-06-12 at 8 20 45 am\" src=\"https://user-images.githubusercontent.com/22689859/27041252-4d60f4e6-4f48-11e7-99a1-97bfdba86da0.png\">\r\n<img width=\"410\" alt=\"screen shot 2017-06-12 at 8 21 22 am\" src=\"https://user-images.githubusercontent.com/22689859/27041259-5151bff4-4f48-11e7-888e-0ecd84fbf2bc.png\">\r\n","created_at":"2017-06-12T09:22:40Z","updated_at":"2017-06-15T17:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d84d9f3a6d999ce3ca264a6d7b7350881215b5e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rchild-okta","id":2889612,"avatar_url":"https://avatars1.githubusercontent.com/u/2889612?v=3","gravatar_id":"","url":"https://api.github.com/users/rchild-okta","html_url":"https://github.com/rchild-okta","followers_url":"https://api.github.com/users/rchild-okta/followers","following_url":"https://api.github.com/users/rchild-okta/following{/other_user}","gists_url":"https://api.github.com/users/rchild-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/rchild-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchild-okta/subscriptions","organizations_url":"https://api.github.com/users/rchild-okta/orgs","repos_url":"https://api.github.com/users/rchild-okta/repos","events_url":"https://api.github.com/users/rchild-okta/events{/privacy}","received_events_url":"https://api.github.com/users/rchild-okta/received_events","type":"User","site_admin":false},{"login":"mauriciocastillosilva-okta","id":6979296,"avatar_url":"https://avatars2.githubusercontent.com/u/6979296?v=3","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/235/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/6ae4254376d54eccf584e14715d18a1256cbc625","head":{"label":"hor-kanchan-okta:hc-OKTA-128910","ref":"hc-OKTA-128910","sha":"6ae4254376d54eccf584e14715d18a1256cbc625","user":{"login":"hor-kanchan-okta","id":22689859,"avatar_url":"https://avatars0.githubusercontent.com/u/22689859?v=3","gravatar_id":"","url":"https://api.github.com/users/hor-kanchan-okta","html_url":"https://github.com/hor-kanchan-okta","followers_url":"https://api.github.com/users/hor-kanchan-okta/followers","following_url":"https://api.github.com/users/hor-kanchan-okta/following{/other_user}","gists_url":"https://api.github.com/users/hor-kanchan-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/hor-kanchan-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hor-kanchan-okta/subscriptions","organizations_url":"https://api.github.com/users/hor-kanchan-okta/orgs","repos_url":"https://api.github.com/users/hor-kanchan-okta/repos","events_url":"https://api.github.com/users/hor-kanchan-okta/events{/privacy}","received_events_url":"https://api.github.com/users/hor-kanchan-okta/received_events","type":"User","site_admin":false},"repo":{"id":71508865,"name":"okta-signin-widget","full_name":"hor-kanchan-okta/okta-signin-widget","owner":{"login":"hor-kanchan-okta","id":22689859,"avatar_url":"https://avatars0.githubusercontent.com/u/22689859?v=3","gravatar_id":"","url":"https://api.github.com/users/hor-kanchan-okta","html_url":"https://github.com/hor-kanchan-okta","followers_url":"https://api.github.com/users/hor-kanchan-okta/followers","following_url":"https://api.github.com/users/hor-kanchan-okta/following{/other_user}","gists_url":"https://api.github.com/users/hor-kanchan-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/hor-kanchan-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hor-kanchan-okta/subscriptions","organizations_url":"https://api.github.com/users/hor-kanchan-okta/orgs","repos_url":"https://api.github.com/users/hor-kanchan-okta/repos","events_url":"https://api.github.com/users/hor-kanchan-okta/events{/privacy}","received_events_url":"https://api.github.com/users/hor-kanchan-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hor-kanchan-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/hor-kanchan-okta/okta-signin-widget/deployments","created_at":"2016-10-20T22:18:10Z","updated_at":"2016-10-20T22:18:13Z","pushed_at":"2017-06-15T01:00:14Z","git_url":"git://github.com/hor-kanchan-okta/okta-signin-widget.git","ssh_url":"git@github.com:hor-kanchan-okta/okta-signin-widget.git","clone_url":"https://github.com/hor-kanchan-okta/okta-signin-widget.git","svn_url":"https://github.com/hor-kanchan-okta/okta-signin-widget","homepage":null,"size":15220,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"a176bd1dc795eed6cabe8fb6a58875529b46087a","user":{"login":"okta","id":362460,"avatar_url":"https://avatars2.githubusercontent.com/u/362460?v=3","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"avatar_url":"https://avatars2.githubusercontent.com/u/362460?v=3","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2017-06-08T19:59:37Z","pushed_at":"2017-06-15T13:13:55Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":15120,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":20,"forks":34,"open_issues":20,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/235"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/235"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/6ae4254376d54eccf584e14715d18a1256cbc625"}}}}
{"actor":{"display_login":"samerfanek-okta"}}