{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/composer/pulls/comments/132441335","pull_request_review_id":55508074,"id":132441335,"diff_hunk":"@@ -232,23 +245,42 @@ export class IdentityCardService {\n         } else {\n             return prefix + '-' + connectionProfile.name;\n         }\n-    };\n+    }\n \n-    private dataRef(cardRef: string): string {\n-        return cardRef + '-pd';\n+    getCardRefFromIdentity(identityName: string, businessNetworkName: string, qualifiedConnectionProfile: string): string {","path":"packages/composer-playground/src/app/services/identity-card.service.ts","position":58,"original_position":58,"commit_id":"1c1f5d69aaf37fd17cbdb64884345ec0f4fa48de","original_commit_id":"1c1f5d69aaf37fd17cbdb64884345ec0f4fa48de","user":{"login":"jt-nti","id":3535067,"avatar_url":"https://avatars2.githubusercontent.com/u/3535067?v=4","gravatar_id":"","url":"https://api.github.com/users/jt-nti","html_url":"https://github.com/jt-nti","followers_url":"https://api.github.com/users/jt-nti/followers","following_url":"https://api.github.com/users/jt-nti/following{/other_user}","gists_url":"https://api.github.com/users/jt-nti/gists{/gist_id}","starred_url":"https://api.github.com/users/jt-nti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jt-nti/subscriptions","organizations_url":"https://api.github.com/users/jt-nti/orgs","repos_url":"https://api.github.com/users/jt-nti/repos","events_url":"https://api.github.com/users/jt-nti/events{/privacy}","received_events_url":"https://api.github.com/users/jt-nti/received_events","type":"User","site_admin":false},"body":"Is this definitely going to get the right thing. Just something Ed reminded me about something Simon said about certificates and cnames that's making me wonder. Would this be necessary without the wallet section of the ID Registry page?","created_at":"2017-08-10T12:39:52Z","updated_at":"2017-08-10T12:48:30Z","html_url":"https://github.com/hyperledger/composer/pull/1828#discussion_r132441335","pull_request_url":"https://api.github.com/repos/hyperledger/composer/pulls/1828","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/comments/132441335"},"html":{"href":"https://github.com/hyperledger/composer/pull/1828#discussion_r132441335"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1828"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/composer/pulls/1828","id":135096754,"html_url":"https://github.com/hyperledger/composer/pull/1828","diff_url":"https://github.com/hyperledger/composer/pull/1828.diff","patch_url":"https://github.com/hyperledger/composer/pull/1828.patch","issue_url":"https://api.github.com/repos/hyperledger/composer/issues/1828","number":1828,"state":"open","locked":false,"title":"Use id cards with identity registry","user":{"login":"caroline-church","id":23044145,"avatar_url":"https://avatars2.githubusercontent.com/u/23044145?v=4","gravatar_id":"","url":"https://api.github.com/users/caroline-church","html_url":"https://github.com/caroline-church","followers_url":"https://api.github.com/users/caroline-church/followers","following_url":"https://api.github.com/users/caroline-church/following{/other_user}","gists_url":"https://api.github.com/users/caroline-church/gists{/gist_id}","starred_url":"https://api.github.com/users/caroline-church/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caroline-church/subscriptions","organizations_url":"https://api.github.com/users/caroline-church/orgs","repos_url":"https://api.github.com/users/caroline-church/repos","events_url":"https://api.github.com/users/caroline-church/events{/privacy}","received_events_url":"https://api.github.com/users/caroline-church/received_events","type":"User","site_admin":false},"body":"Issue Identity uses id card\r\nIdentityComponent uses id card","created_at":"2017-08-10T10:58:32Z","updated_at":"2017-08-10T12:48:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee769b3b4320606bfcdd9240dd4763c447db90f3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/composer/pulls/1828/commits","review_comments_url":"https://api.github.com/repos/hyperledger/composer/pulls/1828/comments","review_comment_url":"https://api.github.com/repos/hyperledger/composer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/composer/issues/1828/comments","statuses_url":"https://api.github.com/repos/hyperledger/composer/statuses/1c1f5d69aaf37fd17cbdb64884345ec0f4fa48de","head":{"label":"caroline-church:update-identity-registry-new","ref":"update-identity-registry-new","sha":"1c1f5d69aaf37fd17cbdb64884345ec0f4fa48de","user":{"login":"caroline-church","id":23044145,"avatar_url":"https://avatars2.githubusercontent.com/u/23044145?v=4","gravatar_id":"","url":"https://api.github.com/users/caroline-church","html_url":"https://github.com/caroline-church","followers_url":"https://api.github.com/users/caroline-church/followers","following_url":"https://api.github.com/users/caroline-church/following{/other_user}","gists_url":"https://api.github.com/users/caroline-church/gists{/gist_id}","starred_url":"https://api.github.com/users/caroline-church/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caroline-church/subscriptions","organizations_url":"https://api.github.com/users/caroline-church/orgs","repos_url":"https://api.github.com/users/caroline-church/repos","events_url":"https://api.github.com/users/caroline-church/events{/privacy}","received_events_url":"https://api.github.com/users/caroline-church/received_events","type":"User","site_admin":false},"repo":{"id":80405620,"name":"fabric-composer","full_name":"caroline-church/fabric-composer","owner":{"login":"caroline-church","id":23044145,"avatar_url":"https://avatars2.githubusercontent.com/u/23044145?v=4","gravatar_id":"","url":"https://api.github.com/users/caroline-church","html_url":"https://github.com/caroline-church","followers_url":"https://api.github.com/users/caroline-church/followers","following_url":"https://api.github.com/users/caroline-church/following{/other_user}","gists_url":"https://api.github.com/users/caroline-church/gists{/gist_id}","starred_url":"https://api.github.com/users/caroline-church/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caroline-church/subscriptions","organizations_url":"https://api.github.com/users/caroline-church/orgs","repos_url":"https://api.github.com/users/caroline-church/repos","events_url":"https://api.github.com/users/caroline-church/events{/privacy}","received_events_url":"https://api.github.com/users/caroline-church/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caroline-church/fabric-composer","description":"A development framework for Hyperledger Fabric","fork":true,"url":"https://api.github.com/repos/caroline-church/fabric-composer","forks_url":"https://api.github.com/repos/caroline-church/fabric-composer/forks","keys_url":"https://api.github.com/repos/caroline-church/fabric-composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caroline-church/fabric-composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caroline-church/fabric-composer/teams","hooks_url":"https://api.github.com/repos/caroline-church/fabric-composer/hooks","issue_events_url":"https://api.github.com/repos/caroline-church/fabric-composer/issues/events{/number}","events_url":"https://api.github.com/repos/caroline-church/fabric-composer/events","assignees_url":"https://api.github.com/repos/caroline-church/fabric-composer/assignees{/user}","branches_url":"https://api.github.com/repos/caroline-church/fabric-composer/branches{/branch}","tags_url":"https://api.github.com/repos/caroline-church/fabric-composer/tags","blobs_url":"https://api.github.com/repos/caroline-church/fabric-composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caroline-church/fabric-composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caroline-church/fabric-composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/caroline-church/fabric-composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caroline-church/fabric-composer/statuses/{sha}","languages_url":"https://api.github.com/repos/caroline-church/fabric-composer/languages","stargazers_url":"https://api.github.com/repos/caroline-church/fabric-composer/stargazers","contributors_url":"https://api.github.com/repos/caroline-church/fabric-composer/contributors","subscribers_url":"https://api.github.com/repos/caroline-church/fabric-composer/subscribers","subscription_url":"https://api.github.com/repos/caroline-church/fabric-composer/subscription","commits_url":"https://api.github.com/repos/caroline-church/fabric-composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/caroline-church/fabric-composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/caroline-church/fabric-composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/caroline-church/fabric-composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/caroline-church/fabric-composer/contents/{+path}","compare_url":"https://api.github.com/repos/caroline-church/fabric-composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caroline-church/fabric-composer/merges","archive_url":"https://api.github.com/repos/caroline-church/fabric-composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caroline-church/fabric-composer/downloads","issues_url":"https://api.github.com/repos/caroline-church/fabric-composer/issues{/number}","pulls_url":"https://api.github.com/repos/caroline-church/fabric-composer/pulls{/number}","milestones_url":"https://api.github.com/repos/caroline-church/fabric-composer/milestones{/number}","notifications_url":"https://api.github.com/repos/caroline-church/fabric-composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caroline-church/fabric-composer/labels{/name}","releases_url":"https://api.github.com/repos/caroline-church/fabric-composer/releases{/id}","deployments_url":"https://api.github.com/repos/caroline-church/fabric-composer/deployments","created_at":"2017-01-30T08:48:16Z","updated_at":"2017-03-02T21:33:36Z","pushed_at":"2017-08-10T10:58:08Z","git_url":"git://github.com/caroline-church/fabric-composer.git","ssh_url":"git@github.com:caroline-church/fabric-composer.git","clone_url":"https://github.com/caroline-church/fabric-composer.git","svn_url":"https://github.com/caroline-church/fabric-composer","homepage":"","size":77421,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:identities","ref":"identities","sha":"a41fc8c648609afe8106f36803542fabb5d97fa4","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":80234065,"name":"composer","full_name":"hyperledger/composer","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/composer","description":"Composer is a framework for building Blockchain business networks","fork":false,"url":"https://api.github.com/repos/hyperledger/composer","forks_url":"https://api.github.com/repos/hyperledger/composer/forks","keys_url":"https://api.github.com/repos/hyperledger/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/composer/teams","hooks_url":"https://api.github.com/repos/hyperledger/composer/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/composer/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/composer/events","assignees_url":"https://api.github.com/repos/hyperledger/composer/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/composer/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/composer/tags","blobs_url":"https://api.github.com/repos/hyperledger/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/composer/languages","stargazers_url":"https://api.github.com/repos/hyperledger/composer/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/composer/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/composer/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/composer/subscription","commits_url":"https://api.github.com/repos/hyperledger/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/composer/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/composer/merges","archive_url":"https://api.github.com/repos/hyperledger/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/composer/downloads","issues_url":"https://api.github.com/repos/hyperledger/composer/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/composer/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/composer/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/composer/deployments","created_at":"2017-01-27T18:27:47Z","updated_at":"2017-08-10T09:17:12Z","pushed_at":"2017-08-10T12:42:02Z","git_url":"git://github.com/hyperledger/composer.git","ssh_url":"git@github.com:hyperledger/composer.git","clone_url":"https://github.com/hyperledger/composer.git","svn_url":"https://github.com/hyperledger/composer","homepage":"https://hyperledger.github.io/composer","size":101104,"stargazers_count":220,"watchers_count":220,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"open_issues_count":261,"forks":149,"open_issues":261,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1828"},"html":{"href":"https://github.com/hyperledger/composer/pull/1828"},"issue":{"href":"https://api.github.com/repos/hyperledger/composer/issues/1828"},"comments":{"href":"https://api.github.com/repos/hyperledger/composer/issues/1828/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1828/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1828/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/composer/statuses/1c1f5d69aaf37fd17cbdb64884345ec0f4fa48de"}}}}
{"actor":{"display_login":"jt-nti"}}