{"action":"created","comment":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/152705703","pull_request_review_id":78608215,"id":152705703,"diff_hunk":"@@ -1136,6 +1136,11 @@\n     'array': (list, tuple),\n }\n \n+# If set, will disable downloading records files by default (can be overriden\n+# by the `skip_files` parameter of `InspireRecord.create` and\n+# `InspireRecord.update`)","path":"inspirehep/config.py","position":6,"original_position":6,"commit_id":"1187dbc6748bad828a41aef64e7c199f312ccc7e","original_commit_id":"1187dbc6748bad828a41aef64e7c199f312ccc7e","user":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars2.githubusercontent.com/u/381280?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"body":"A docstring after the configuration variable will show up when building the docs (e.g. http://inspirehep.readthedocs.io/en/latest/_api/inspirehep.modules.hal.html#module-inspirehep.modules.hal.config), while a comment will be ignored. So I'd say it's better to document variables with docstrings.","created_at":"2017-11-23T00:17:58Z","updated_at":"2017-11-23T00:17:58Z","html_url":"https://github.com/inspirehep/inspire-next/pull/2986#discussion_r152705703","pull_request_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/152705703"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/2986#discussion_r152705703"},"pull_request":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986"}}},"pull_request":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986","id":154271908,"html_url":"https://github.com/inspirehep/inspire-next/pull/2986","diff_url":"https://github.com/inspirehep/inspire-next/pull/2986.diff","patch_url":"https://github.com/inspirehep/inspire-next/pull/2986.patch","issue_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/2986","number":2986,"state":"open","locked":false,"title":"records: allow to skip downloading the files","user":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars2.githubusercontent.com/u/381280?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdds two methods to skip downloading the files:\r\n\r\n* Setting the configuration variable ``RECORDS_SKIP_FILES``.\r\n* Passing the ``skip_files`` parameter to the ``create`` and\r\n  ``update`` methods in ``InspireRecord``.\r\n\r\nNote that the latter has precedence, and that by default the\r\nprevious behavior (downloading the files) is preserved.\r\n\r\n## Related Issue\r\nSupersedes https://github.com/inspirehep/inspire-next/pull/2948\r\n\r\n## Checklist:\r\n- [ ] I have all the information that I need (if not, move to `RFC` and look for it).\r\n- [ ] I linked the related issue(s) in the corresponding commit logs.\r\n- [ ] I wrote [good commit log messages](https://github.com/torvalds/subsurface-for-dirk/blob/5f15ad5a86ada3c5e574041a5f9d85235322dabb/README#L92-L119).\r\n- [ ] My code follows the code style of this project.\r\n- [ ] I've added any new docs if API/utils methods were added.\r\n- [ ] I have updated the existing documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.","created_at":"2017-11-22T22:57:47Z","updated_at":"2017-11-23T00:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20f2334bdc88b22b747676a598c267fe36798f27","assignee":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars2.githubusercontent.com/u/381280?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"assignees":[{"login":"jacquerie","id":381280,"avatar_url":"https://avatars2.githubusercontent.com/u/381280?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986/commits","review_comments_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986/comments","review_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/2986/comments","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/1187dbc6748bad828a41aef64e7c199f312ccc7e","head":{"label":"jacquerie:allow_skip_records_files","ref":"allow_skip_records_files","sha":"1187dbc6748bad828a41aef64e7c199f312ccc7e","user":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars2.githubusercontent.com/u/381280?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"repo":{"id":30241195,"name":"inspire-next","full_name":"jacquerie/inspire-next","owner":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars2.githubusercontent.com/u/381280?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacquerie/inspire-next","description":null,"fork":true,"url":"https://api.github.com/repos/jacquerie/inspire-next","forks_url":"https://api.github.com/repos/jacquerie/inspire-next/forks","keys_url":"https://api.github.com/repos/jacquerie/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacquerie/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacquerie/inspire-next/teams","hooks_url":"https://api.github.com/repos/jacquerie/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/jacquerie/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/jacquerie/inspire-next/events","assignees_url":"https://api.github.com/repos/jacquerie/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/jacquerie/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/jacquerie/inspire-next/tags","blobs_url":"https://api.github.com/repos/jacquerie/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacquerie/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacquerie/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacquerie/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacquerie/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/jacquerie/inspire-next/languages","stargazers_url":"https://api.github.com/repos/jacquerie/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/jacquerie/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/jacquerie/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/jacquerie/inspire-next/subscription","commits_url":"https://api.github.com/repos/jacquerie/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacquerie/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacquerie/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacquerie/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacquerie/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/jacquerie/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacquerie/inspire-next/merges","archive_url":"https://api.github.com/repos/jacquerie/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacquerie/inspire-next/downloads","issues_url":"https://api.github.com/repos/jacquerie/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/jacquerie/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/jacquerie/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/jacquerie/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacquerie/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/jacquerie/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/jacquerie/inspire-next/deployments","created_at":"2015-02-03T12:17:40Z","updated_at":"2017-07-24T11:19:17Z","pushed_at":"2017-11-22T22:55:17Z","git_url":"git://github.com/jacquerie/inspire-next.git","ssh_url":"git@github.com:jacquerie/inspire-next.git","clone_url":"https://github.com/jacquerie/inspire-next.git","svn_url":"https://github.com/jacquerie/inspire-next","homepage":"","size":69802,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inspirehep:master","ref":"master","sha":"a9fd5e66699e88388b4703fdd9e8a8c823a8f8e1","user":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"repo":{"id":15221515,"name":"inspire-next","full_name":"inspirehep/inspire-next","owner":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspirehep/inspire-next","description":"The next version of INSPIRE","fork":false,"url":"https://api.github.com/repos/inspirehep/inspire-next","forks_url":"https://api.github.com/repos/inspirehep/inspire-next/forks","keys_url":"https://api.github.com/repos/inspirehep/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspirehep/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspirehep/inspire-next/teams","hooks_url":"https://api.github.com/repos/inspirehep/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/inspirehep/inspire-next/events","assignees_url":"https://api.github.com/repos/inspirehep/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/inspirehep/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/inspirehep/inspire-next/tags","blobs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspirehep/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspirehep/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/inspirehep/inspire-next/languages","stargazers_url":"https://api.github.com/repos/inspirehep/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/inspirehep/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/inspirehep/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/inspirehep/inspire-next/subscription","commits_url":"https://api.github.com/repos/inspirehep/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspirehep/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspirehep/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/inspirehep/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspirehep/inspire-next/merges","archive_url":"https://api.github.com/repos/inspirehep/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspirehep/inspire-next/downloads","issues_url":"https://api.github.com/repos/inspirehep/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/inspirehep/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/inspirehep/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspirehep/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/inspirehep/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/inspirehep/inspire-next/deployments","created_at":"2013-12-16T09:11:58Z","updated_at":"2017-10-16T13:57:38Z","pushed_at":"2017-11-22T22:57:48Z","git_url":"git://github.com/inspirehep/inspire-next.git","ssh_url":"git@github.com:inspirehep/inspire-next.git","clone_url":"https://github.com/inspirehep/inspire-next.git","svn_url":"https://github.com/inspirehep/inspire-next","homepage":"https://labs.inspirehep.net","size":68813,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":265,"forks":45,"open_issues":265,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/2986"},"issue":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/2986"},"comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/2986/comments"},"review_comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986/comments"},"review_comment":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/2986/commits"},"statuses":{"href":"https://api.github.com/repos/inspirehep/inspire-next/statuses/1187dbc6748bad828a41aef64e7c199f312ccc7e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jacquerie"}}