{"action":"created","issue":{"url":"https://api.github.com/repos/stdlib-js/stdlib/issues/109","repository_url":"https://api.github.com/repos/stdlib-js/stdlib","labels_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/109/comments","events_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/109/events","html_url":"https://github.com/stdlib-js/stdlib/pull/109","id":252793950,"number":109,"title":"Add Bessel function of the first kind of order zero, besselj0","user":{"login":"rreusser","id":572717,"avatar_url":"https://avatars0.githubusercontent.com/u/572717?v=4","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"labels":[{"id":352649354,"url":"https://api.github.com/repos/stdlib-js/stdlib/labels/feature","name":"feature","color":"bfd4f2","default":false},{"id":352661057,"url":"https://api.github.com/repos/stdlib-js/stdlib/labels/math","name":"math","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-08-25T04:11:28Z","updated_at":"2017-08-25T16:53:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/109","html_url":"https://github.com/stdlib-js/stdlib/pull/109","diff_url":"https://github.com/stdlib-js/stdlib/pull/109.diff","patch_url":"https://github.com/stdlib-js/stdlib/pull/109.patch"},"body":"Resolves #28.\r\n\r\n<!--lint disable first-heading-level-->\r\n\r\n## Checklist\r\n\r\n> Please ensure the following tasks are completed before submitting this pull request.\r\n\r\n-   [x] Read, understood, and followed the [contributing guidelines][contributing], including the relevant style guides.\r\n-   [x] Read and understand the [Code of Conduct][code-of-conduct].\r\n-   [x] Read and understood the [licensing terms][license].\r\n-   [x] Searched for existing issues and pull requests **before** submitting this pull request.\r\n-   [x] Filed an issue (or an issue already existed) **prior to** submitting this pull request.\r\n-   [x] Rebased onto latest `develop`.\r\n-   [x] Submitted against `develop` branch.\r\n\r\n## Description\r\n\r\n> What is the purpose of this pull request?\r\n\r\nThis pull request:\r\n\r\n- Adds the Bessel function of the first kind of order zero. I've called it `besselj0`. `j0` would also work, but it seems slightly more name-collision-prone.\r\n\r\n\r\n## Questions\r\n\r\n> Any questions for reviewers of this pull request?\r\n\r\nThe test fixtures are based on julia evaluation. I had to increase the tolerances in the tests. `EPS` didn't do it. Tests close to zero needed more like `2.5 * EPS`. Tests at extremely large magnitudes needed maybe `2000 * EPS` for *all* tests to pass. I'm not sure whether or not that's acceptable. I mean realistically for one of the worst tests that means:\r\n\r\n```\r\nx: 46.34146341463415\r\n     js: -3.223802045828392e-5\r\n      c: -3.2238020458285285e-05\r\n  julia: -3.2238020458285286e-5\r\n python: -3.2238020458601188e-05\r\nwolfram: -3.223802045847041762582146764982149392318058159547287e-5\r\n```\r\n\r\nI don't really know what this means, beyond indicating that it seems like a ballpark expected level of error. Given the same input, it doesn't really seem like anyone is evaluating all the way to floating point epsilon.\r\n\r\n## Other\r\n\r\n> Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.\r\n\r\n- I only added one test with negative value fixtures. It's an even function so it just flips it to positive x and evaluates. It wouldn't *hurt* to test more negative values, but it's hard to imagine any implementation that wouldn't make it trivially correct.\r\n\r\n* * *\r\n\r\n@stdlib-js/reviewers\r\n\r\n<!-- <links> -->\r\n\r\n[contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md\r\n\r\n[code-of-conduct]: https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md\r\n\r\n[license]: https://github.com/stdlib-js/stdlib/blob/develop/LICENSE\r\n\r\n<!-- </links> -->\r\n"},"comment":{"url":"https://api.github.com/repos/stdlib-js/stdlib/issues/comments/324976919","html_url":"https://github.com/stdlib-js/stdlib/pull/109#issuecomment-324976919","issue_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/109","id":324976919,"user":{"login":"rreusser","id":572717,"avatar_url":"https://avatars0.githubusercontent.com/u/572717?v=4","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"created_at":"2017-08-25T16:53:16Z","updated_at":"2017-08-25T16:53:16Z","body":"Yeah, I favor the current inf handling."}}
{"actor":{"display_login":"rreusser"}}