{"action":"created","issue":{"url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/issues/90","repository_url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery","labels_url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/issues/90/comments","events_url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/issues/90/events","html_url":"https://github.com/struts-community-plugins/struts2-jquery/issues/90","id":197128045,"number":90,"title":"add tests for the struts2-jquery-plugin tags","user":{"login":"sdutry","id":7937324,"avatar_url":"https://avatars.githubusercontent.com/u/7937324?v=3","gravatar_id":"","url":"https://api.github.com/users/sdutry","html_url":"https://github.com/sdutry","followers_url":"https://api.github.com/users/sdutry/followers","following_url":"https://api.github.com/users/sdutry/following{/other_user}","gists_url":"https://api.github.com/users/sdutry/gists{/gist_id}","starred_url":"https://api.github.com/users/sdutry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdutry/subscriptions","organizations_url":"https://api.github.com/users/sdutry/orgs","repos_url":"https://api.github.com/users/sdutry/repos","events_url":"https://api.github.com/users/sdutry/events{/privacy}","received_events_url":"https://api.github.com/users/sdutry/received_events","type":"User","site_admin":false},"labels":[{"id":104745796,"url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"sdutry","id":7937324,"avatar_url":"https://avatars.githubusercontent.com/u/7937324?v=3","gravatar_id":"","url":"https://api.github.com/users/sdutry","html_url":"https://github.com/sdutry","followers_url":"https://api.github.com/users/sdutry/followers","following_url":"https://api.github.com/users/sdutry/following{/other_user}","gists_url":"https://api.github.com/users/sdutry/gists{/gist_id}","starred_url":"https://api.github.com/users/sdutry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdutry/subscriptions","organizations_url":"https://api.github.com/users/sdutry/orgs","repos_url":"https://api.github.com/users/sdutry/repos","events_url":"https://api.github.com/users/sdutry/events{/privacy}","received_events_url":"https://api.github.com/users/sdutry/received_events","type":"User","site_admin":false},"assignees":[{"login":"sdutry","id":7937324,"avatar_url":"https://avatars.githubusercontent.com/u/7937324?v=3","gravatar_id":"","url":"https://api.github.com/users/sdutry","html_url":"https://github.com/sdutry","followers_url":"https://api.github.com/users/sdutry/followers","following_url":"https://api.github.com/users/sdutry/following{/other_user}","gists_url":"https://api.github.com/users/sdutry/gists{/gist_id}","starred_url":"https://api.github.com/users/sdutry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdutry/subscriptions","organizations_url":"https://api.github.com/users/sdutry/orgs","repos_url":"https://api.github.com/users/sdutry/repos","events_url":"https://api.github.com/users/sdutry/events{/privacy}","received_events_url":"https://api.github.com/users/sdutry/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/milestones/4","html_url":"https://github.com/struts-community-plugins/struts2-jquery/milestone/4","labels_url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/milestones/4/labels","id":2235364,"number":4,"title":"4.0.3","description":null,"creator":{"login":"jogep","id":141539,"avatar_url":"https://avatars.githubusercontent.com/u/141539?v=3","gravatar_id":"","url":"https://api.github.com/users/jogep","html_url":"https://github.com/jogep","followers_url":"https://api.github.com/users/jogep/followers","following_url":"https://api.github.com/users/jogep/following{/other_user}","gists_url":"https://api.github.com/users/jogep/gists{/gist_id}","starred_url":"https://api.github.com/users/jogep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jogep/subscriptions","organizations_url":"https://api.github.com/users/jogep/orgs","repos_url":"https://api.github.com/users/jogep/repos","events_url":"https://api.github.com/users/jogep/events{/privacy}","received_events_url":"https://api.github.com/users/jogep/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":13,"state":"open","created_at":"2017-01-08T14:11:59Z","updated_at":"2017-01-22T16:34:04Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2016-12-22T09:17:11Z","updated_at":"2017-01-25T08:11:05Z","closed_at":null,"body":"Seeing that it's usualy difficult and time-consuming to test every single tag in isolation, I thought it might be a good idea to have some integration-tests for the tags.\r\n\r\nThis way, it should be easier to detect problems when they occur.\r\n\r\nI've made a small POC for a simple case, illustrating that it's possible.\r\n[struts2-jquery-tests](https://github.com/sdutry/struts2-jquery-tests)\r\n**Edit:** \r\n* ~~this assumes to have struts2-jquery version 4.0.2-SNAPSHOT installed~~\r\n* to run use: `mvn verify`\r\n\r\nThe eventual idea would be to:\r\n* have a seperate module in the project which runs the integration tests\r\n* have tests for each tag\r\n* have tests for each functionality of the tags\r\n\r\nIf there's problems you can think off now for this approach, please let me know.\r\n\r\nPlease let me know your thoughts on this, so that i know if i should put effort in it or not."},"comment":{"url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/issues/comments/275044608","html_url":"https://github.com/struts-community-plugins/struts2-jquery/issues/90#issuecomment-275044608","issue_url":"https://api.github.com/repos/struts-community-plugins/struts2-jquery/issues/90","id":275044608,"user":{"login":"lukaszlenart","id":170103,"avatar_url":"https://avatars.githubusercontent.com/u/170103?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaszlenart","html_url":"https://github.com/lukaszlenart","followers_url":"https://api.github.com/users/lukaszlenart/followers","following_url":"https://api.github.com/users/lukaszlenart/following{/other_user}","gists_url":"https://api.github.com/users/lukaszlenart/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszlenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszlenart/subscriptions","organizations_url":"https://api.github.com/users/lukaszlenart/orgs","repos_url":"https://api.github.com/users/lukaszlenart/repos","events_url":"https://api.github.com/users/lukaszlenart/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszlenart/received_events","type":"User","site_admin":false},"created_at":"2017-01-25T08:11:05Z","updated_at":"2017-01-25T08:11:05Z","body":"(sorry but I was off for few days)\r\n\r\nThe idea with a dedicated profile just for `phantomjs` is very good, you can use `${env.TRAVIS}` to activate it when build is running on TravisCI, just a hint, the current approach also works :)"}}
{"actor":{"display_login":"lukaszlenart"}}