{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/comments/143583874","pull_request_review_id":68115512,"id":143583874,"diff_hunk":"@@ -52,27 +52,29 @@ def generate_html(dir):\n         html.write('<!DOCTYPE html>')\n         html.write('<html>')\n         html.write('<head>')\n+        html.write('<title>Screenshot Test Results</title>')\n         html.write('<script src=\"https://ajax.googleapis.com/ajax/libs/jquery/2.1.3/jquery.min.js\"></script>')\n         html.write('<script src=\"https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.3/jquery-ui.min.js\"></script>')\n         html.write('<script src=\"default.js\"></script>')\n         html.write('<link rel=\"stylesheet\" href=\"https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.3/themes/smoothness/jquery-ui.css\" />')\n         html.write('<link rel=\"stylesheet\" href=\"default.css\"></head>')\n         html.write('<body>')\n \n-        html.write('<!-- begin results -->')\n-\n         for screenshot in sort_screenshots(root.iter('screenshot')):\n             alternate = not alternate\n+            canonical_name = screenshot.find('name').text\n+            last_seperator = canonical_name.rindex('.') + 1","path":"plugin/src/py/android_screenshot_tests/pull_screenshots.py","position":17,"original_position":17,"commit_id":"8b7089f5d776f309a686b0e02f53ecafc98600a1","original_commit_id":"8b7089f5d776f309a686b0e02f53ecafc98600a1","user":{"login":"dimorinny","id":9587692,"avatar_url":"https://avatars1.githubusercontent.com/u/9587692?v=4","gravatar_id":"","url":"https://api.github.com/users/dimorinny","html_url":"https://github.com/dimorinny","followers_url":"https://api.github.com/users/dimorinny/followers","following_url":"https://api.github.com/users/dimorinny/following{/other_user}","gists_url":"https://api.github.com/users/dimorinny/gists{/gist_id}","starred_url":"https://api.github.com/users/dimorinny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimorinny/subscriptions","organizations_url":"https://api.github.com/users/dimorinny/orgs","repos_url":"https://api.github.com/users/dimorinny/repos","events_url":"https://api.github.com/users/dimorinny/events{/privacy}","received_events_url":"https://api.github.com/users/dimorinny/received_events","type":"User","site_admin":false},"body":"As result I have this name: `<name>BannerCardComponent__Long_message_text_action_and_image</name>`","created_at":"2017-10-09T21:40:39Z","updated_at":"2017-10-09T21:40:39Z","html_url":"https://github.com/facebook/screenshot-tests-for-android/pull/117#discussion_r143583874","pull_request_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/comments/143583874"},"html":{"href":"https://github.com/facebook/screenshot-tests-for-android/pull/117#discussion_r143583874"},"pull_request":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117"}},"in_reply_to_id":143581859},"pull_request":{"url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117","id":144519164,"html_url":"https://github.com/facebook/screenshot-tests-for-android/pull/117","diff_url":"https://github.com/facebook/screenshot-tests-for-android/pull/117.diff","patch_url":"https://github.com/facebook/screenshot-tests-for-android/pull/117.patch","issue_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/issues/117","number":117,"state":"closed","locked":false,"title":"Spruce up Results Page","user":{"login":"xiphirx","id":993832,"avatar_url":"https://avatars0.githubusercontent.com/u/993832?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphirx","html_url":"https://github.com/xiphirx","followers_url":"https://api.github.com/users/xiphirx/followers","following_url":"https://api.github.com/users/xiphirx/following{/other_user}","gists_url":"https://api.github.com/users/xiphirx/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphirx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphirx/subscriptions","organizations_url":"https://api.github.com/users/xiphirx/orgs","repos_url":"https://api.github.com/users/xiphirx/repos","events_url":"https://api.github.com/users/xiphirx/events{/privacy}","received_events_url":"https://api.github.com/users/xiphirx/received_events","type":"User","site_admin":false},"body":"The screenshot test result page looked a little sad / bland before, this\r\nmakes it look better (tm). I also inlined the view hierarchy since the\r\nprevious button to view it didnt work, and it didnt make much sense not\r\nto. I also plan on converting the XML into a collapsable hierarchy at\r\nsome point, but this is a quick start on a redesign of the page\r\n\r\n![image](https://user-images.githubusercontent.com/993832/31147176-ff8a53bc-a856-11e7-88f6-d412f6c48d8f.png)\r\n","created_at":"2017-10-03T20:22:13Z","updated_at":"2017-10-09T21:40:39Z","closed_at":"2017-10-03T21:23:01Z","merged_at":"2017-10-03T21:23:01Z","merge_commit_sha":"49b0bb507531b8d780de94a2aa73c0b0fa40b55a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117/commits","review_comments_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117/comments","review_comment_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/issues/117/comments","statuses_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/statuses/8b7089f5d776f309a686b0e02f53ecafc98600a1","head":{"label":"xiphirx:xiphirx/resultspage","ref":"xiphirx/resultspage","sha":"8b7089f5d776f309a686b0e02f53ecafc98600a1","user":{"login":"xiphirx","id":993832,"avatar_url":"https://avatars0.githubusercontent.com/u/993832?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphirx","html_url":"https://github.com/xiphirx","followers_url":"https://api.github.com/users/xiphirx/followers","following_url":"https://api.github.com/users/xiphirx/following{/other_user}","gists_url":"https://api.github.com/users/xiphirx/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphirx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphirx/subscriptions","organizations_url":"https://api.github.com/users/xiphirx/orgs","repos_url":"https://api.github.com/users/xiphirx/repos","events_url":"https://api.github.com/users/xiphirx/events{/privacy}","received_events_url":"https://api.github.com/users/xiphirx/received_events","type":"User","site_admin":false},"repo":{"id":97551944,"name":"screenshot-tests-for-android","full_name":"xiphirx/screenshot-tests-for-android","owner":{"login":"xiphirx","id":993832,"avatar_url":"https://avatars0.githubusercontent.com/u/993832?v=4","gravatar_id":"","url":"https://api.github.com/users/xiphirx","html_url":"https://github.com/xiphirx","followers_url":"https://api.github.com/users/xiphirx/followers","following_url":"https://api.github.com/users/xiphirx/following{/other_user}","gists_url":"https://api.github.com/users/xiphirx/gists{/gist_id}","starred_url":"https://api.github.com/users/xiphirx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiphirx/subscriptions","organizations_url":"https://api.github.com/users/xiphirx/orgs","repos_url":"https://api.github.com/users/xiphirx/repos","events_url":"https://api.github.com/users/xiphirx/events{/privacy}","received_events_url":"https://api.github.com/users/xiphirx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiphirx/screenshot-tests-for-android","description":"screenshot-test-for-android is a library that can generate fast deterministic screenshots while running instrumentation tests in android.","fork":true,"url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android","forks_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/forks","keys_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/teams","hooks_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/hooks","issue_events_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/events","assignees_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/tags","blobs_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/languages","stargazers_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/stargazers","contributors_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/contributors","subscribers_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/subscribers","subscription_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/subscription","commits_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/merges","archive_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/downloads","issues_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/labels{/name}","releases_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/xiphirx/screenshot-tests-for-android/deployments","created_at":"2017-07-18T04:16:21Z","updated_at":"2017-07-18T04:16:23Z","pushed_at":"2017-10-05T15:15:18Z","git_url":"git://github.com/xiphirx/screenshot-tests-for-android.git","ssh_url":"git@github.com:xiphirx/screenshot-tests-for-android.git","clone_url":"https://github.com/xiphirx/screenshot-tests-for-android.git","svn_url":"https://github.com/xiphirx/screenshot-tests-for-android","homepage":"http://facebook.github.io/screenshot-tests-for-android","size":868,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"10acf3be192dc5d1e597dd64b080507829449b37","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":41693388,"name":"screenshot-tests-for-android","full_name":"facebook/screenshot-tests-for-android","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/screenshot-tests-for-android","description":"screenshot-test-for-android is a library that can generate fast deterministic screenshots while running instrumentation tests in android.","fork":false,"url":"https://api.github.com/repos/facebook/screenshot-tests-for-android","forks_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/forks","keys_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/teams","hooks_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/hooks","issue_events_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/events","assignees_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/tags","blobs_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/languages","stargazers_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/stargazers","contributors_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/contributors","subscribers_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/subscribers","subscription_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/subscription","commits_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/merges","archive_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/downloads","issues_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/labels{/name}","releases_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/screenshot-tests-for-android/deployments","created_at":"2015-08-31T18:36:02Z","updated_at":"2017-10-09T15:54:27Z","pushed_at":"2017-10-06T18:51:50Z","git_url":"git://github.com/facebook/screenshot-tests-for-android.git","ssh_url":"git@github.com:facebook/screenshot-tests-for-android.git","clone_url":"https://github.com/facebook/screenshot-tests-for-android.git","svn_url":"https://github.com/facebook/screenshot-tests-for-android","homepage":"http://facebook.github.io/screenshot-tests-for-android","size":882,"stargazers_count":921,"watchers_count":921,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":126,"mirror_url":null,"open_issues_count":29,"forks":126,"open_issues":29,"watchers":921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117"},"html":{"href":"https://github.com/facebook/screenshot-tests-for-android/pull/117"},"issue":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/issues/117"},"comments":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/screenshot-tests-for-android/statuses/8b7089f5d776f309a686b0e02f53ecafc98600a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dimorinny"}}