{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/19840","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/19840/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/19840/comments","events_url":"https://api.github.com/repos/angular/angular/issues/19840/events","html_url":"https://github.com/angular/angular/issues/19840","id":267326658,"number":19840,"title":"Template source maps cause issues for source-map-explorer","user":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars3.githubusercontent.com/u/216296?v=4","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"labels":[{"id":375501288,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20core%20&%20compiler","name":"comp: core & compiler","color":"c7def8","default":false},{"id":375498262,"url":"https://api.github.com/repos/angular/angular/labels/severity5:%20regression","name":"severity5: regression","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-10-20T23:04:34Z","updated_at":"2017-10-23T22:12:36Z","closed_at":null,"author_association":"OWNER","body":"## Current behavior\r\nBefore the recent fix that enabled template source maps, the source-map explorer showed generated factories with full path. After the recent update there are at least two issues with the template source maps:\r\n- [ ] source maps are not prefixed with the path of the original component / template file, causing all component templates to be mixed\r\n- [ ] there is a lot of unaccounted space in the source-map-explorer\r\n\r\n<img width=\"1446\" alt=\"screen shot 2017-10-20 at 3 35 05 pm\" src=\"https://user-images.githubusercontent.com/216296/31844412-62b80c3c-b5ad-11e7-8671-9e1baa98c34e.png\">\r\n\r\n## Expected behavior\r\n- template source maps should be prefixed with the path of the original component/template\r\n- there shouldn't be any significant unaccounted space\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n## Environment\r\n\r\n<pre><code>\r\nAngular CLI: 1.5.0-rc.2\r\nNode: 6.9.5\r\nOS: darwin x64\r\nAngular: 5.0.0-rc.2\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... http, platform-browser, platform-browser-dynamic\r\n... platform-server, router\r\n\r\n@angular/cdk: 2.0.0-beta.12\r\n@angular/cli: 1.5.0-rc.2\r\n@angular/material: 2.0.0-beta.12\r\n@angular/service-worker: 1.0.0-beta.16\r\n@angular-devkit/build-optimizer: 0.0.29\r\n@angular-devkit/core: 0.0.20\r\n@angular-devkit/schematics: 0.0.34\r\n@ngtools/json-schema: 1.1.0\r\n@ngtools/webpack: 1.8.0-rc.2\r\n@schematics/angular: 0.0.48\r\ntypescript: 2.5.3\r\nwebpack: 3.7.1\r\n</code></pre>\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/338812204","html_url":"https://github.com/angular/angular/issues/19840#issuecomment-338812204","issue_url":"https://api.github.com/repos/angular/angular/issues/19840","id":338812204,"user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars1.githubusercontent.com/u/690815?v=4","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"created_at":"2017-10-23T22:12:36Z","updated_at":"2017-10-23T22:12:36Z","author_association":"MEMBER","body":"Soon we will inline the generated code into the `.ts` file itself. What would we do then? There won't be any `.ngfactory` files anymore. Where would we then attribute the generated code to?"}}
{"actor":{"display_login":"tbosch"}}