{"action":"created","issue":{"url":"https://api.github.com/repos/scrapinghub/splash/issues/349","repository_url":"https://api.github.com/repos/scrapinghub/splash","labels_url":"https://api.github.com/repos/scrapinghub/splash/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/scrapinghub/splash/issues/349/comments","events_url":"https://api.github.com/repos/scrapinghub/splash/issues/349/events","html_url":"https://github.com/scrapinghub/splash/issues/349","id":120816043,"number":349,"title":"migrate from qtwebkit to qtwebengine","user":{"login":"pawelmhm","id":2700942,"avatar_url":"https://avatars.githubusercontent.com/u/2700942?v=3","gravatar_id":"","url":"https://api.github.com/users/pawelmhm","html_url":"https://github.com/pawelmhm","followers_url":"https://api.github.com/users/pawelmhm/followers","following_url":"https://api.github.com/users/pawelmhm/following{/other_user}","gists_url":"https://api.github.com/users/pawelmhm/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelmhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelmhm/subscriptions","organizations_url":"https://api.github.com/users/pawelmhm/orgs","repos_url":"https://api.github.com/users/pawelmhm/repos","events_url":"https://api.github.com/users/pawelmhm/events{/privacy}","received_events_url":"https://api.github.com/users/pawelmhm/received_events","type":"User","site_admin":false},"labels":[{"id":337482634,"url":"https://api.github.com/repos/scrapinghub/splash/labels/gsoc-candidate","name":"gsoc-candidate","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2015-12-07T16:42:13Z","updated_at":"2017-02-25T04:43:38Z","closed_at":null,"body":"According to http://blog.qt.io/blog/2014/12/10/qt-5-4-released/\n\n> Qt 5.4 also still contains the older Qt WebKit module. Qt WebKit is still supported, but as of Qt 5.4 we consider it done, so no new functionality will be added to it. We are also planning to deprecate Qt WebKit in future releases, as the new Qt WebEngine provides what is needed. In most use cases, migrating from Qt WebKit to Qt WebEngine is rather straightforward. If you are starting a new project that requires web capabilities, we advise that you already start using Qt WebEngine.\n\nso we should start working on migration to QtWebEngine?\n"},"comment":{"url":"https://api.github.com/repos/scrapinghub/splash/issues/comments/282459790","html_url":"https://github.com/scrapinghub/splash/issues/349#issuecomment-282459790","issue_url":"https://api.github.com/repos/scrapinghub/splash/issues/349","id":282459790,"user":{"login":"leobuskin","id":18386691,"avatar_url":"https://avatars.githubusercontent.com/u/18386691?v=3","gravatar_id":"","url":"https://api.github.com/users/leobuskin","html_url":"https://github.com/leobuskin","followers_url":"https://api.github.com/users/leobuskin/followers","following_url":"https://api.github.com/users/leobuskin/following{/other_user}","gists_url":"https://api.github.com/users/leobuskin/gists{/gist_id}","starred_url":"https://api.github.com/users/leobuskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobuskin/subscriptions","organizations_url":"https://api.github.com/users/leobuskin/orgs","repos_url":"https://api.github.com/users/leobuskin/repos","events_url":"https://api.github.com/users/leobuskin/events{/privacy}","received_events_url":"https://api.github.com/users/leobuskin/received_events","type":"User","site_admin":false},"created_at":"2017-02-25T04:43:38Z","updated_at":"2017-02-25T04:43:38Z","body":"@vedantrathore @kmike hey, I've just checked Splash w/ PyQt 5.8 [SIP 4.19.1] + Qt 5.8 + QtWebKit TP5 for Qt 5.8 (from https://github.com/annulen/webkit) and Ubuntu 16.04. \r\n\r\n`9 failed, 1173 passed, 12 skipped, 26 xfailed, 2 pytest-warnings` - w/o patching Splash, just a lot of package modifications and some workarounds and I'm pretty sure these 9 failures were mine, heh.\r\n\r\nSo, I suggest two-step upgrade:\r\n1. Splash switches from Qt 5.5 to Qt 5.8 + QtWebKit by @annulen (looks like stable repo and good maintainer) - we will get last versions of WebKit w/ new features and would keep community interest;\r\n2. Add BrowserTab-based support for Chromium engine (it could be QtWebEngine or smth CEF-based).\r\n\r\nLooks good, if you want to adopt my solution of first step - what will be the best way to contribute?"}}
{"actor":{"display_login":"leobuskin"}}