{"action":"created","comment":{"url":"https://api.github.com/repos/convox/rack/pulls/comments/94876141","pull_request_review_id":15417697,"id":94876141,"diff_hunk":"@@ -244,73 +244,73 @@ func (p *AWSProvider) serviceApps(s structs.Service) (structs.Apps, error) {\n \treturn apps, nil\n }\n \n-// ServiceList lists the Services\n-func (p *AWSProvider) ServiceList() (structs.Services, error) {\n+// ResourceList lists the Resources\n+func (p *AWSProvider) ResourceList() (structs.Resources, error) {\n \tres, err := p.describeStacks(&cloudformation.DescribeStacksInput{})\n \tif err != nil {\n \t\treturn nil, err\n \t}\n \n-\tservices := structs.Services{}\n+\tresources := structs.Resources{}\n \n \tfor _, stack := range res.Stacks {\n \t\ttags := stackTags(stack)\n \n-\t\t// if it's a service and the Rack tag is either the current rack or blank\n-\t\tif tags[\"System\"] == \"convox\" && tags[\"Type\"] == \"service\" {\n+\t\t// if it's a resource and the Rack tag is either the current rack or blank\n+\t\tif tags[\"System\"] == \"convox\" && (tags[\"Type\"] == \"resource\" || tags[\"Type\"] == \"service\") {\n \t\t\tif tags[\"Rack\"] == p.Rack || tags[\"Rack\"] == \"\" {\n-\t\t\t\tservices = append(services, serviceFromStack(stack))\n+\t\t\t\tresources = append(resources, resourceFromStack(stack))\n \t\t\t}\n \t\t}\n \t}\n \n-\tfor _, s := range services {\n-\t\tapps, err := p.serviceApps(s)\n+\tfor _, s := range resources {\n+\t\tapps, err := p.resourceApps(s)\n \t\tif err != nil {\n \t\t\treturn nil, err\n \t\t}\n \t\ts.Apps = apps\n \t}\n \n-\treturn services, nil\n+\treturn resources, nil\n }\n \n-func (p *AWSProvider) ServiceLink(name, app, process string) (*structs.Service, error) {\n+func (p *AWSProvider) ResourceLink(name, app, process string) (*structs.Resource, error) {","path":"provider/aws/resource.go","position":225,"original_position":225,"commit_id":"e4cc9fbfb0859dbd4ba8a0619ed3600636c8405c","original_commit_id":"e4cc9fbfb0859dbd4ba8a0619ed3600636c8405c","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported method AWSProvider.ResourceLink should have comment or be unexported","created_at":"2017-01-05T23:42:06Z","updated_at":"2017-01-05T23:42:06Z","html_url":"https://github.com/convox/rack/pull/1518#discussion_r94876141","pull_request_url":"https://api.github.com/repos/convox/rack/pulls/1518","_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/comments/94876141"},"html":{"href":"https://github.com/convox/rack/pull/1518#discussion_r94876141"},"pull_request":{"href":"https://api.github.com/repos/convox/rack/pulls/1518"}}},"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/1518","id":100385601,"html_url":"https://github.com/convox/rack/pull/1518","diff_url":"https://github.com/convox/rack/pull/1518.diff","patch_url":"https://github.com/convox/rack/pull/1518.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/1518","number":1518,"state":"open","locked":false,"title":"/resources API endpoint, templates, etc","user":{"login":"soulshake","id":1585815,"avatar_url":"https://avatars.githubusercontent.com/u/1585815?v=3","gravatar_id":"","url":"https://api.github.com/users/soulshake","html_url":"https://github.com/soulshake","followers_url":"https://api.github.com/users/soulshake/followers","following_url":"https://api.github.com/users/soulshake/following{/other_user}","gists_url":"https://api.github.com/users/soulshake/gists{/gist_id}","starred_url":"https://api.github.com/users/soulshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulshake/subscriptions","organizations_url":"https://api.github.com/users/soulshake/orgs","repos_url":"https://api.github.com/users/soulshake/repos","events_url":"https://api.github.com/users/soulshake/events{/privacy}","received_events_url":"https://api.github.com/users/soulshake/received_events","type":"User","site_admin":false},"body":"**Thorough review needed.**\r\n\r\nThis PR renames `service` to `resource` wherever relevant.\r\n\r\nThere are some gray areas where I'm not sure the rename makes sense, in particular in `/provider/aws/resource.go`.\r\n\r\nI added some tests, but these changes affect some still-untested code. ","created_at":"2017-01-05T23:41:55Z","updated_at":"2017-01-05T23:42:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30a49edf7434a932664ef46e17865607f5f8a1f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/1518/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/1518/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/1518/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/e4cc9fbfb0859dbd4ba8a0619ed3600636c8405c","head":{"label":"convox:resources-api-endpoint-2","ref":"resources-api-endpoint-2","sha":"e4cc9fbfb0859dbd4ba8a0619ed3600636c8405c","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS. Deploy Twelve Factor apps to AWS cloud services for maximum privacy and minimum upkeep.","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2017-01-05T10:24:45Z","pushed_at":"2017-01-05T23:41:56Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":70275,"stargazers_count":1412,"watchers_count":1412,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":133,"forks":101,"open_issues":133,"watchers":1412,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"8c28facb5382c4da1a080abb75150085d0d3a550","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS. Deploy Twelve Factor apps to AWS cloud services for maximum privacy and minimum upkeep.","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2017-01-05T10:24:45Z","pushed_at":"2017-01-05T23:41:56Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":70275,"stargazers_count":1412,"watchers_count":1412,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":133,"forks":101,"open_issues":133,"watchers":1412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/1518"},"html":{"href":"https://github.com/convox/rack/pull/1518"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/1518"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/1518/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/1518/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/1518/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/e4cc9fbfb0859dbd4ba8a0619ed3600636c8405c"}}}}
{"actor":{"display_login":"houndci-bot"}}