{"action":"closed","number":3324,"pull_request":{"url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/3324","id":146120601,"html_url":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/3324","diff_url":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/3324.diff","patch_url":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/3324.patch","issue_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/3324","number":3324,"state":"closed","locked":false,"title":"[MIRROR] Minor refactor of how gas IDs are handled","user":{"login":"CitadelStationBot","id":26690887,"avatar_url":"https://avatars2.githubusercontent.com/u/26690887?v=4","gravatar_id":"","url":"https://api.github.com/users/CitadelStationBot","html_url":"https://github.com/CitadelStationBot","followers_url":"https://api.github.com/users/CitadelStationBot/followers","following_url":"https://api.github.com/users/CitadelStationBot/following{/other_user}","gists_url":"https://api.github.com/users/CitadelStationBot/gists{/gist_id}","starred_url":"https://api.github.com/users/CitadelStationBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CitadelStationBot/subscriptions","organizations_url":"https://api.github.com/users/CitadelStationBot/orgs","repos_url":"https://api.github.com/users/CitadelStationBot/repos","events_url":"https://api.github.com/users/CitadelStationBot/events{/privacy}","received_events_url":"https://api.github.com/users/CitadelStationBot/received_events","type":"User","site_admin":false},"body":"Original PR: https://github.com/tgstation/tgstation/pull/31528\n--------------------\nChanges from magic string -> path. At some point some error handling was given up in the name of performance, and now with `assert_gas()` being a define it's just infeasible to go back to the way it was before. Now, these errors will get caught at compile time. Tested, but I'll do more to be safe.\n\nGas strings can be parsed both via IDs as before or via paths; this is handled automatically by the mixture, keeping legacy strings and strings that can't have expressions embedded (ex. mapping) intact.\n\nThis will conflict with assmos @ as334 but should make your life easier while debugging lol\nMay conflict with multipipes @ Kevinz000","created_at":"2017-10-12T05:30:16Z","updated_at":"2017-10-12T11:19:31Z","closed_at":"2017-10-12T11:19:31Z","merged_at":"2017-10-12T11:19:31Z","merge_commit_sha":"f93733576edfcb6ed5dca8a6a62cd752c791718f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/3324/commits","review_comments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/3324/comments","review_comment_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/3324/comments","statuses_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/statuses/301dbad6654857b121ceb66f48d7cbaea97c2efc","head":{"label":"Citadel-Station-13:upstream-merge-31528","ref":"upstream-merge-31528","sha":"301dbad6654857b121ceb66f48d7cbaea97c2efc","user":{"login":"Citadel-Station-13","id":11160241,"avatar_url":"https://avatars0.githubusercontent.com/u/11160241?v=4","gravatar_id":"","url":"https://api.github.com/users/Citadel-Station-13","html_url":"https://github.com/Citadel-Station-13","followers_url":"https://api.github.com/users/Citadel-Station-13/followers","following_url":"https://api.github.com/users/Citadel-Station-13/following{/other_user}","gists_url":"https://api.github.com/users/Citadel-Station-13/gists{/gist_id}","starred_url":"https://api.github.com/users/Citadel-Station-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Citadel-Station-13/subscriptions","organizations_url":"https://api.github.com/users/Citadel-Station-13/orgs","repos_url":"https://api.github.com/users/Citadel-Station-13/repos","events_url":"https://api.github.com/users/Citadel-Station-13/events{/privacy}","received_events_url":"https://api.github.com/users/Citadel-Station-13/received_events","type":"Organization","site_admin":false},"repo":{"id":62485194,"name":"Citadel-Station-13","full_name":"Citadel-Station-13/Citadel-Station-13","owner":{"login":"Citadel-Station-13","id":11160241,"avatar_url":"https://avatars0.githubusercontent.com/u/11160241?v=4","gravatar_id":"","url":"https://api.github.com/users/Citadel-Station-13","html_url":"https://github.com/Citadel-Station-13","followers_url":"https://api.github.com/users/Citadel-Station-13/followers","following_url":"https://api.github.com/users/Citadel-Station-13/following{/other_user}","gists_url":"https://api.github.com/users/Citadel-Station-13/gists{/gist_id}","starred_url":"https://api.github.com/users/Citadel-Station-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Citadel-Station-13/subscriptions","organizations_url":"https://api.github.com/users/Citadel-Station-13/orgs","repos_url":"https://api.github.com/users/Citadel-Station-13/repos","events_url":"https://api.github.com/users/Citadel-Station-13/events{/privacy}","received_events_url":"https://api.github.com/users/Citadel-Station-13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Citadel-Station-13/Citadel-Station-13","description":"Active build for Citadel Station","fork":false,"url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13","forks_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/forks","keys_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/teams","hooks_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/hooks","issue_events_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/events{/number}","events_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/events","assignees_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/assignees{/user}","branches_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/branches{/branch}","tags_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/tags","blobs_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/statuses/{sha}","languages_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/languages","stargazers_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/stargazers","contributors_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/contributors","subscribers_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/subscribers","subscription_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/subscription","commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/contents/{+path}","compare_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/merges","archive_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/downloads","issues_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues{/number}","pulls_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls{/number}","milestones_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/milestones{/number}","notifications_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/labels{/name}","releases_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/releases{/id}","deployments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/deployments","created_at":"2016-07-03T07:00:22Z","updated_at":"2017-10-06T01:20:02Z","pushed_at":"2017-10-12T11:19:31Z","git_url":"git://github.com/Citadel-Station-13/Citadel-Station-13.git","ssh_url":"git@github.com:Citadel-Station-13/Citadel-Station-13.git","clone_url":"https://github.com/Citadel-Station-13/Citadel-Station-13.git","svn_url":"https://github.com/Citadel-Station-13/Citadel-Station-13","homepage":"","size":332870,"stargazers_count":9,"watchers_count":9,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":29,"forks":60,"open_issues":29,"watchers":9,"default_branch":"master"}},"base":{"label":"Citadel-Station-13:master","ref":"master","sha":"5b4e26cb06811b2a5c849c077eb6ca25b16dfdaf","user":{"login":"Citadel-Station-13","id":11160241,"avatar_url":"https://avatars0.githubusercontent.com/u/11160241?v=4","gravatar_id":"","url":"https://api.github.com/users/Citadel-Station-13","html_url":"https://github.com/Citadel-Station-13","followers_url":"https://api.github.com/users/Citadel-Station-13/followers","following_url":"https://api.github.com/users/Citadel-Station-13/following{/other_user}","gists_url":"https://api.github.com/users/Citadel-Station-13/gists{/gist_id}","starred_url":"https://api.github.com/users/Citadel-Station-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Citadel-Station-13/subscriptions","organizations_url":"https://api.github.com/users/Citadel-Station-13/orgs","repos_url":"https://api.github.com/users/Citadel-Station-13/repos","events_url":"https://api.github.com/users/Citadel-Station-13/events{/privacy}","received_events_url":"https://api.github.com/users/Citadel-Station-13/received_events","type":"Organization","site_admin":false},"repo":{"id":62485194,"name":"Citadel-Station-13","full_name":"Citadel-Station-13/Citadel-Station-13","owner":{"login":"Citadel-Station-13","id":11160241,"avatar_url":"https://avatars0.githubusercontent.com/u/11160241?v=4","gravatar_id":"","url":"https://api.github.com/users/Citadel-Station-13","html_url":"https://github.com/Citadel-Station-13","followers_url":"https://api.github.com/users/Citadel-Station-13/followers","following_url":"https://api.github.com/users/Citadel-Station-13/following{/other_user}","gists_url":"https://api.github.com/users/Citadel-Station-13/gists{/gist_id}","starred_url":"https://api.github.com/users/Citadel-Station-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Citadel-Station-13/subscriptions","organizations_url":"https://api.github.com/users/Citadel-Station-13/orgs","repos_url":"https://api.github.com/users/Citadel-Station-13/repos","events_url":"https://api.github.com/users/Citadel-Station-13/events{/privacy}","received_events_url":"https://api.github.com/users/Citadel-Station-13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Citadel-Station-13/Citadel-Station-13","description":"Active build for Citadel Station","fork":false,"url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13","forks_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/forks","keys_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/teams","hooks_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/hooks","issue_events_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/events{/number}","events_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/events","assignees_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/assignees{/user}","branches_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/branches{/branch}","tags_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/tags","blobs_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/statuses/{sha}","languages_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/languages","stargazers_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/stargazers","contributors_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/contributors","subscribers_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/subscribers","subscription_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/subscription","commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/contents/{+path}","compare_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/merges","archive_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/downloads","issues_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues{/number}","pulls_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls{/number}","milestones_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/milestones{/number}","notifications_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/labels{/name}","releases_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/releases{/id}","deployments_url":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/deployments","created_at":"2016-07-03T07:00:22Z","updated_at":"2017-10-06T01:20:02Z","pushed_at":"2017-10-12T11:19:31Z","git_url":"git://github.com/Citadel-Station-13/Citadel-Station-13.git","ssh_url":"git@github.com:Citadel-Station-13/Citadel-Station-13.git","clone_url":"https://github.com/Citadel-Station-13/Citadel-Station-13.git","svn_url":"https://github.com/Citadel-Station-13/Citadel-Station-13","homepage":"","size":332870,"stargazers_count":9,"watchers_count":9,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":29,"forks":60,"open_issues":29,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/3324"},"html":{"href":"https://github.com/Citadel-Station-13/Citadel-Station-13/pull/3324"},"issue":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/3324"},"comments":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/issues/3324/comments"},"review_comments":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/3324/comments"},"review_comment":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/pulls/3324/commits"},"statuses":{"href":"https://api.github.com/repos/Citadel-Station-13/Citadel-Station-13/statuses/301dbad6654857b121ceb66f48d7cbaea97c2efc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"LetterJay","id":9606363,"avatar_url":"https://avatars2.githubusercontent.com/u/9606363?v=4","gravatar_id":"","url":"https://api.github.com/users/LetterJay","html_url":"https://github.com/LetterJay","followers_url":"https://api.github.com/users/LetterJay/followers","following_url":"https://api.github.com/users/LetterJay/following{/other_user}","gists_url":"https://api.github.com/users/LetterJay/gists{/gist_id}","starred_url":"https://api.github.com/users/LetterJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LetterJay/subscriptions","organizations_url":"https://api.github.com/users/LetterJay/orgs","repos_url":"https://api.github.com/users/LetterJay/repos","events_url":"https://api.github.com/users/LetterJay/events{/privacy}","received_events_url":"https://api.github.com/users/LetterJay/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":431,"deletions":418,"changed_files":52}}
{"actor":{"display_login":"LetterJay"}}