{"action":"created","issue":{"url":"https://api.github.com/repos/ARCANEDEV/LogViewer/issues/150","repository_url":"https://api.github.com/repos/ARCANEDEV/LogViewer","labels_url":"https://api.github.com/repos/ARCANEDEV/LogViewer/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/ARCANEDEV/LogViewer/issues/150/comments","events_url":"https://api.github.com/repos/ARCANEDEV/LogViewer/issues/150/events","html_url":"https://github.com/ARCANEDEV/LogViewer/issues/150","id":239165373,"number":150,"title":"Download Filename hardcoded","user":{"login":"disto","id":1729769,"avatar_url":"https://avatars2.githubusercontent.com/u/1729769?v=3","gravatar_id":"","url":"https://api.github.com/users/disto","html_url":"https://github.com/disto","followers_url":"https://api.github.com/users/disto/followers","following_url":"https://api.github.com/users/disto/following{/other_user}","gists_url":"https://api.github.com/users/disto/gists{/gist_id}","starred_url":"https://api.github.com/users/disto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disto/subscriptions","organizations_url":"https://api.github.com/users/disto/orgs","repos_url":"https://api.github.com/users/disto/repos","events_url":"https://api.github.com/users/disto/events{/privacy}","received_events_url":"https://api.github.com/users/disto/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-28T13:33:06Z","updated_at":"2017-06-28T14:17:24Z","closed_at":"2017-06-28T14:17:24Z","body":"- LogViewer Version: 4.3.8\r\n![screen shot 2017-06-28 at 15 26 02](https://user-images.githubusercontent.com/1729769/27639616-0a4527fa-5c17-11e7-86a4-72c05cea832c.png)\r\n\r\n- Laravel Version: 5.4.24\r\n- PHP Version: 7.0.10\r\n\r\n### Description:\r\nIn the config file it is possible to enter a format file name of downloads\r\nmade from log-files.\r\nHowever in the LogViewer.php file the file name is hardcoded.\r\n\r\n### Steps To Reproduce:\r\nAdjust format in config and download a logfile"},"comment":{"url":"https://api.github.com/repos/ARCANEDEV/LogViewer/issues/comments/311673527","html_url":"https://github.com/ARCANEDEV/LogViewer/issues/150#issuecomment-311673527","issue_url":"https://api.github.com/repos/ARCANEDEV/LogViewer/issues/150","id":311673527,"user":{"login":"arcanedev-maroc","id":3282340,"avatar_url":"https://avatars2.githubusercontent.com/u/3282340?v=3","gravatar_id":"","url":"https://api.github.com/users/arcanedev-maroc","html_url":"https://github.com/arcanedev-maroc","followers_url":"https://api.github.com/users/arcanedev-maroc/followers","following_url":"https://api.github.com/users/arcanedev-maroc/following{/other_user}","gists_url":"https://api.github.com/users/arcanedev-maroc/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanedev-maroc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanedev-maroc/subscriptions","organizations_url":"https://api.github.com/users/arcanedev-maroc/orgs","repos_url":"https://api.github.com/users/arcanedev-maroc/repos","events_url":"https://api.github.com/users/arcanedev-maroc/events{/privacy}","received_events_url":"https://api.github.com/users/arcanedev-maroc/received_events","type":"User","site_admin":false},"created_at":"2017-06-28T14:17:24Z","updated_at":"2017-06-28T14:17:24Z","body":"Youn can specify a custom name for the log files to download in the second argument.\r\n\r\n**Example 1:**\r\n\r\n```php\r\nlog_viewer()->download('2017-06-27'); \r\n// This is basically is going to use the default format for the daily log: laravel-2017-06-27.log\r\n```\r\n\r\n**Example 2:**\r\n```php\r\nlog_viewer()->download('2017-06-27', 'my-log-file.log'); \r\n// This is a custom name of the log file to download: my-log-file.log\r\n```\r\n\r\nSo there is no need to add this in the config file because the hardcoded name is used as a fallback.\r\n\r\nThanks for the suggestion 👍 "}}
{"actor":{"display_login":"arcanedev-maroc"}}