{"action":"created","comment":{"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments/155906251","pull_request_review_id":82308773,"id":155906251,"diff_hunk":"@@ -18,7 +18,7 @@ function addon.DrawLoadScreen()\n \tlocal loadProgress = SG.GetLoadProgress()\n \n \t-- fade in & out music with progress\n-\tif (loadProgress > 0.9) then\n+\tif (loadProgress > 0.75) then\n \t\tSpring.SetSoundStreamVolume(1 - ((loadProgress - 0.9) * 10))","path":"LuaIntro/Addons/music.lua","position":15,"original_position":15,"commit_id":"1aff42088cd8e59e82b53386dddfc1f653e70cee","original_commit_id":"1aff42088cd8e59e82b53386dddfc1f653e70cee","user":{"login":"sprunk","id":2573076,"avatar_url":"https://avatars0.githubusercontent.com/u/2573076?v=4","gravatar_id":"","url":"https://api.github.com/users/sprunk","html_url":"https://github.com/sprunk","followers_url":"https://api.github.com/users/sprunk/followers","following_url":"https://api.github.com/users/sprunk/following{/other_user}","gists_url":"https://api.github.com/users/sprunk/gists{/gist_id}","starred_url":"https://api.github.com/users/sprunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprunk/subscriptions","organizations_url":"https://api.github.com/users/sprunk/orgs","repos_url":"https://api.github.com/users/sprunk/repos","events_url":"https://api.github.com/users/sprunk/events{/privacy}","received_events_url":"https://api.github.com/users/sprunk/received_events","type":"User","site_admin":false},"body":"`1 - ((loadProgress - 0.9) * 10)` is >1 in the [0.75; 0.9) set so this either makes the music louder or does nothing.","created_at":"2017-12-09T00:49:36Z","updated_at":"2017-12-09T00:49:36Z","html_url":"https://github.com/ZeroK-RTS/Zero-K/pull/2655#discussion_r155906251","pull_request_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments/155906251"},"html":{"href":"https://github.com/ZeroK-RTS/Zero-K/pull/2655#discussion_r155906251"},"pull_request":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655"}}},"pull_request":{"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655","id":157359076,"html_url":"https://github.com/ZeroK-RTS/Zero-K/pull/2655","diff_url":"https://github.com/ZeroK-RTS/Zero-K/pull/2655.diff","patch_url":"https://github.com/ZeroK-RTS/Zero-K/pull/2655.patch","issue_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/2655","number":2655,"state":"open","locked":false,"title":"Awaken loadscreen music","user":{"login":"The-Yak","id":1368663,"avatar_url":"https://avatars0.githubusercontent.com/u/1368663?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Yak","html_url":"https://github.com/The-Yak","followers_url":"https://api.github.com/users/The-Yak/followers","following_url":"https://api.github.com/users/The-Yak/following{/other_user}","gists_url":"https://api.github.com/users/The-Yak/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Yak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Yak/subscriptions","organizations_url":"https://api.github.com/users/The-Yak/orgs","repos_url":"https://api.github.com/users/The-Yak/repos","events_url":"https://api.github.com/users/The-Yak/events{/privacy}","received_events_url":"https://api.github.com/users/The-Yak/received_events","type":"User","site_admin":false},"body":"Tweak fadeouts, fixed sound level to master volume","created_at":"2017-12-09T00:00:45Z","updated_at":"2017-12-09T00:49:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21583b14961ee10d0ab494f9a1ef53e087495ff0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655/commits","review_comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655/comments","review_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/2655/comments","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/1aff42088cd8e59e82b53386dddfc1f653e70cee","head":{"label":"The-Yak:master","ref":"master","sha":"1aff42088cd8e59e82b53386dddfc1f653e70cee","user":{"login":"The-Yak","id":1368663,"avatar_url":"https://avatars0.githubusercontent.com/u/1368663?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Yak","html_url":"https://github.com/The-Yak","followers_url":"https://api.github.com/users/The-Yak/followers","following_url":"https://api.github.com/users/The-Yak/following{/other_user}","gists_url":"https://api.github.com/users/The-Yak/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Yak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Yak/subscriptions","organizations_url":"https://api.github.com/users/The-Yak/orgs","repos_url":"https://api.github.com/users/The-Yak/repos","events_url":"https://api.github.com/users/The-Yak/events{/privacy}","received_events_url":"https://api.github.com/users/The-Yak/received_events","type":"User","site_admin":false},"repo":{"id":113617832,"name":"Zero-K","full_name":"The-Yak/Zero-K","owner":{"login":"The-Yak","id":1368663,"avatar_url":"https://avatars0.githubusercontent.com/u/1368663?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Yak","html_url":"https://github.com/The-Yak","followers_url":"https://api.github.com/users/The-Yak/followers","following_url":"https://api.github.com/users/The-Yak/following{/other_user}","gists_url":"https://api.github.com/users/The-Yak/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Yak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Yak/subscriptions","organizations_url":"https://api.github.com/users/The-Yak/orgs","repos_url":"https://api.github.com/users/The-Yak/repos","events_url":"https://api.github.com/users/The-Yak/events{/privacy}","received_events_url":"https://api.github.com/users/The-Yak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Yak/Zero-K","description":"Open source RTS game running on the Spring engine","fork":true,"url":"https://api.github.com/repos/The-Yak/Zero-K","forks_url":"https://api.github.com/repos/The-Yak/Zero-K/forks","keys_url":"https://api.github.com/repos/The-Yak/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Yak/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Yak/Zero-K/teams","hooks_url":"https://api.github.com/repos/The-Yak/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/The-Yak/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/The-Yak/Zero-K/events","assignees_url":"https://api.github.com/repos/The-Yak/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/The-Yak/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/The-Yak/Zero-K/tags","blobs_url":"https://api.github.com/repos/The-Yak/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Yak/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Yak/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Yak/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Yak/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Yak/Zero-K/languages","stargazers_url":"https://api.github.com/repos/The-Yak/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/The-Yak/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/The-Yak/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/The-Yak/Zero-K/subscription","commits_url":"https://api.github.com/repos/The-Yak/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Yak/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Yak/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Yak/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Yak/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/The-Yak/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Yak/Zero-K/merges","archive_url":"https://api.github.com/repos/The-Yak/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Yak/Zero-K/downloads","issues_url":"https://api.github.com/repos/The-Yak/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/The-Yak/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Yak/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Yak/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Yak/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/The-Yak/Zero-K/releases{/id}","deployments_url":"https://api.github.com/repos/The-Yak/Zero-K/deployments","created_at":"2017-12-08T21:13:03Z","updated_at":"2017-12-08T21:13:17Z","pushed_at":"2017-12-09T00:00:05Z","git_url":"git://github.com/The-Yak/Zero-K.git","ssh_url":"git@github.com:The-Yak/Zero-K.git","clone_url":"https://github.com/The-Yak/Zero-K.git","svn_url":"https://github.com/The-Yak/Zero-K","homepage":null,"size":472015,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZeroK-RTS:master","ref":"master","sha":"0afe43dda7efde5e40b17611b510677e17d92945","user":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars2.githubusercontent.com/u/5145185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"repo":{"id":11837082,"name":"Zero-K","full_name":"ZeroK-RTS/Zero-K","owner":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars2.githubusercontent.com/u/5145185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZeroK-RTS/Zero-K","description":"Open source RTS game running on the Spring engine","fork":false,"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K","forks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/forks","keys_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/teams","hooks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/events","assignees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/tags","blobs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/languages","stargazers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscription","commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/merges","archive_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/downloads","issues_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/releases{/id}","deployments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/deployments","created_at":"2013-08-02T06:57:00Z","updated_at":"2017-12-07T23:01:14Z","pushed_at":"2017-12-09T00:00:46Z","git_url":"git://github.com/ZeroK-RTS/Zero-K.git","ssh_url":"git@github.com:ZeroK-RTS/Zero-K.git","clone_url":"https://github.com/ZeroK-RTS/Zero-K.git","svn_url":"https://github.com/ZeroK-RTS/Zero-K","homepage":null,"size":472015,"stargazers_count":132,"watchers_count":132,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":310,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":64,"open_issues":310,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655"},"html":{"href":"https://github.com/ZeroK-RTS/Zero-K/pull/2655"},"issue":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/2655"},"comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/2655/comments"},"review_comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655/comments"},"review_comment":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/2655/commits"},"statuses":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/1aff42088cd8e59e82b53386dddfc1f653e70cee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sprunk"}}