{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments/139501089","pull_request_review_id":63442644,"id":139501089,"diff_hunk":"@@ -63,6 +62,7 @@ class EnterpriseModelViewSet(EnterpriseViewSet):\n     \"\"\"\n \n     filter_backends = (filters.OrderingFilter, filters.DjangoFilterBackend)","path":"enterprise/api/v1/views.py","position":17,"original_position":17,"commit_id":"5f20abda0506e3a5333095db3ff768a7d1f73bda","original_commit_id":"5f20abda0506e3a5333095db3ff768a7d1f73bda","user":{"login":"UmanShahzad","id":10018065,"avatar_url":"https://avatars0.githubusercontent.com/u/10018065?v=4","gravatar_id":"","url":"https://api.github.com/users/UmanShahzad","html_url":"https://github.com/UmanShahzad","followers_url":"https://api.github.com/users/UmanShahzad/followers","following_url":"https://api.github.com/users/UmanShahzad/following{/other_user}","gists_url":"https://api.github.com/users/UmanShahzad/gists{/gist_id}","starred_url":"https://api.github.com/users/UmanShahzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmanShahzad/subscriptions","organizations_url":"https://api.github.com/users/UmanShahzad/orgs","repos_url":"https://api.github.com/users/UmanShahzad/repos","events_url":"https://api.github.com/users/UmanShahzad/events{/privacy}","received_events_url":"https://api.github.com/users/UmanShahzad/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2017-09-18T18:22:08Z","updated_at":"2017-09-18T18:22:08Z","html_url":"https://github.com/edx/edx-enterprise/pull/193#discussion_r139501089","pull_request_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/193","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments/139501089"},"html":{"href":"https://github.com/edx/edx-enterprise/pull/193#discussion_r139501089"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/193"}},"in_reply_to_id":139473486},"pull_request":{"url":"https://api.github.com/repos/edx/edx-enterprise/pulls/193","id":141504635,"html_url":"https://github.com/edx/edx-enterprise/pull/193","diff_url":"https://github.com/edx/edx-enterprise/pull/193.diff","patch_url":"https://github.com/edx/edx-enterprise/pull/193.patch","issue_url":"https://api.github.com/repos/edx/edx-enterprise/issues/193","number":193,"state":"open","locked":false,"title":"[ENT-640] Ensure all Enterprise/Consent API endpoints apply appropriate permissioning/filtering scheme","user":{"login":"UmanShahzad","id":10018065,"avatar_url":"https://avatars0.githubusercontent.com/u/10018065?v=4","gravatar_id":"","url":"https://api.github.com/users/UmanShahzad","html_url":"https://github.com/UmanShahzad","followers_url":"https://api.github.com/users/UmanShahzad/followers","following_url":"https://api.github.com/users/UmanShahzad/following{/other_user}","gists_url":"https://api.github.com/users/UmanShahzad/gists{/gist_id}","starred_url":"https://api.github.com/users/UmanShahzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmanShahzad/subscriptions","organizations_url":"https://api.github.com/users/UmanShahzad/orgs","repos_url":"https://api.github.com/users/UmanShahzad/repos","events_url":"https://api.github.com/users/UmanShahzad/events{/privacy}","received_events_url":"https://api.github.com/users/UmanShahzad/received_events","type":"User","site_admin":false},"body":"**Description:** This PR adds proper permission/filter schemes to our API endpoints.\r\n\r\n**JIRA:** [ENT-640](https://openedx.atlassian.net/browse/ENT-640)\r\n\r\n**Merge deadline:** ASAP\r\n\r\n**Testing instructions:**\r\n\r\nPlease see the thread on [the ticket](https://openedx.atlassian.net/browse/ENT-640) to understand how our endpoints should actually be in fact behaving. Then, go through each of the APIs as a staff & non-staff user, and at each step ensuring you get the expected results.\r\n\r\nDetailed instructions TBD when the intended behavior is agreed upon and confirmed.\r\n\r\n**Merge checklist:**\r\n\r\n- [ ] Check that the versions of the requirements in the `platform-master.in` file match edx-platform.\r\n- [ ] New requirements are in the right place (`base.in` if only used in enterprise; in the correct `platform-****.in` files if they're hosted in edx-platform)\r\n- [ ] Regenerate requirements with `make upgrade && make requirements` (and make sure to fix any errors).\r\n  **DO NOT** just add dependencies to `requirements/*.txt` files.\r\n- [ ] All reviewers approved\r\n- [ ] CI build is green\r\n- [ ] Version bumped\r\n- [ ] Changelog record added\r\n- [ ] Documentation updated (not only docstrings)\r\n- [ ] Commits are (reasonably) squashed\r\n- [ ] Translations are updated\r\n- [ ] PR author is listed in AUTHORS\r\n\r\n**Post merge:**\r\n- [ ] Create a tag\r\n- [ ] Check new version is pushed to PyPi after tag-triggered build is finished.\r\n- [ ] Delete working branch (if not needed anymore)\r\n- [ ] edx-platform PR (be sure to include edx-platform requirements upgrades that were present in this PR)\r\n\r\n","created_at":"2017-09-17T22:05:18Z","updated_at":"2017-09-18T18:22:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"136abe12d6863d2660450dd878b7137d8d12015c","assignee":{"login":"UmanShahzad","id":10018065,"avatar_url":"https://avatars0.githubusercontent.com/u/10018065?v=4","gravatar_id":"","url":"https://api.github.com/users/UmanShahzad","html_url":"https://github.com/UmanShahzad","followers_url":"https://api.github.com/users/UmanShahzad/followers","following_url":"https://api.github.com/users/UmanShahzad/following{/other_user}","gists_url":"https://api.github.com/users/UmanShahzad/gists{/gist_id}","starred_url":"https://api.github.com/users/UmanShahzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmanShahzad/subscriptions","organizations_url":"https://api.github.com/users/UmanShahzad/orgs","repos_url":"https://api.github.com/users/UmanShahzad/repos","events_url":"https://api.github.com/users/UmanShahzad/events{/privacy}","received_events_url":"https://api.github.com/users/UmanShahzad/received_events","type":"User","site_admin":false},"assignees":[{"login":"UmanShahzad","id":10018065,"avatar_url":"https://avatars0.githubusercontent.com/u/10018065?v=4","gravatar_id":"","url":"https://api.github.com/users/UmanShahzad","html_url":"https://github.com/UmanShahzad","followers_url":"https://api.github.com/users/UmanShahzad/followers","following_url":"https://api.github.com/users/UmanShahzad/following{/other_user}","gists_url":"https://api.github.com/users/UmanShahzad/gists{/gist_id}","starred_url":"https://api.github.com/users/UmanShahzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmanShahzad/subscriptions","organizations_url":"https://api.github.com/users/UmanShahzad/orgs","repos_url":"https://api.github.com/users/UmanShahzad/repos","events_url":"https://api.github.com/users/UmanShahzad/events{/privacy}","received_events_url":"https://api.github.com/users/UmanShahzad/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"brittneyexline","id":524809,"avatar_url":"https://avatars1.githubusercontent.com/u/524809?v=4","gravatar_id":"","url":"https://api.github.com/users/brittneyexline","html_url":"https://github.com/brittneyexline","followers_url":"https://api.github.com/users/brittneyexline/followers","following_url":"https://api.github.com/users/brittneyexline/following{/other_user}","gists_url":"https://api.github.com/users/brittneyexline/gists{/gist_id}","starred_url":"https://api.github.com/users/brittneyexline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittneyexline/subscriptions","organizations_url":"https://api.github.com/users/brittneyexline/orgs","repos_url":"https://api.github.com/users/brittneyexline/repos","events_url":"https://api.github.com/users/brittneyexline/events{/privacy}","received_events_url":"https://api.github.com/users/brittneyexline/received_events","type":"User","site_admin":false},{"login":"itsjeyd","id":961441,"avatar_url":"https://avatars0.githubusercontent.com/u/961441?v=4","gravatar_id":"","url":"https://api.github.com/users/itsjeyd","html_url":"https://github.com/itsjeyd","followers_url":"https://api.github.com/users/itsjeyd/followers","following_url":"https://api.github.com/users/itsjeyd/following{/other_user}","gists_url":"https://api.github.com/users/itsjeyd/gists{/gist_id}","starred_url":"https://api.github.com/users/itsjeyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsjeyd/subscriptions","organizations_url":"https://api.github.com/users/itsjeyd/orgs","repos_url":"https://api.github.com/users/itsjeyd/repos","events_url":"https://api.github.com/users/itsjeyd/events{/privacy}","received_events_url":"https://api.github.com/users/itsjeyd/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/193/commits","review_comments_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/193/comments","review_comment_url":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/issues/193/comments","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/5f20abda0506e3a5333095db3ff768a7d1f73bda","head":{"label":"edx:uman/proper-api-permissions","ref":"uman/proper-api-permissions","sha":"5f20abda0506e3a5333095db3ff768a7d1f73bda","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":70704345,"name":"edx-enterprise","full_name":"edx/edx-enterprise","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-enterprise","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-enterprise","forks_url":"https://api.github.com/repos/edx/edx-enterprise/forks","keys_url":"https://api.github.com/repos/edx/edx-enterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-enterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-enterprise/teams","hooks_url":"https://api.github.com/repos/edx/edx-enterprise/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-enterprise/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-enterprise/events","assignees_url":"https://api.github.com/repos/edx/edx-enterprise/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-enterprise/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-enterprise/tags","blobs_url":"https://api.github.com/repos/edx/edx-enterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-enterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-enterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-enterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-enterprise/languages","stargazers_url":"https://api.github.com/repos/edx/edx-enterprise/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-enterprise/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-enterprise/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-enterprise/subscription","commits_url":"https://api.github.com/repos/edx/edx-enterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-enterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-enterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-enterprise/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-enterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-enterprise/merges","archive_url":"https://api.github.com/repos/edx/edx-enterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-enterprise/downloads","issues_url":"https://api.github.com/repos/edx/edx-enterprise/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-enterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-enterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-enterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-enterprise/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-enterprise/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-enterprise/deployments","created_at":"2016-10-12T13:48:42Z","updated_at":"2017-08-20T11:15:04Z","pushed_at":"2017-09-18T14:31:22Z","git_url":"git://github.com/edx/edx-enterprise.git","ssh_url":"git@github.com:edx/edx-enterprise.git","clone_url":"https://github.com/edx/edx-enterprise.git","svn_url":"https://github.com/edx/edx-enterprise","homepage":null,"size":2116,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":7,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"189909d244d9c0d519f461c1a2a6d8f01f4b9326","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":70704345,"name":"edx-enterprise","full_name":"edx/edx-enterprise","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-enterprise","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-enterprise","forks_url":"https://api.github.com/repos/edx/edx-enterprise/forks","keys_url":"https://api.github.com/repos/edx/edx-enterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-enterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-enterprise/teams","hooks_url":"https://api.github.com/repos/edx/edx-enterprise/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-enterprise/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-enterprise/events","assignees_url":"https://api.github.com/repos/edx/edx-enterprise/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-enterprise/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-enterprise/tags","blobs_url":"https://api.github.com/repos/edx/edx-enterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-enterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-enterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-enterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-enterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-enterprise/languages","stargazers_url":"https://api.github.com/repos/edx/edx-enterprise/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-enterprise/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-enterprise/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-enterprise/subscription","commits_url":"https://api.github.com/repos/edx/edx-enterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-enterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-enterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-enterprise/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-enterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-enterprise/merges","archive_url":"https://api.github.com/repos/edx/edx-enterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-enterprise/downloads","issues_url":"https://api.github.com/repos/edx/edx-enterprise/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-enterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-enterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-enterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-enterprise/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-enterprise/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-enterprise/deployments","created_at":"2016-10-12T13:48:42Z","updated_at":"2017-08-20T11:15:04Z","pushed_at":"2017-09-18T14:31:22Z","git_url":"git://github.com/edx/edx-enterprise.git","ssh_url":"git@github.com:edx/edx-enterprise.git","clone_url":"https://github.com/edx/edx-enterprise.git","svn_url":"https://github.com/edx/edx-enterprise","homepage":null,"size":2116,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/193"},"html":{"href":"https://github.com/edx/edx-enterprise/pull/193"},"issue":{"href":"https://api.github.com/repos/edx/edx-enterprise/issues/193"},"comments":{"href":"https://api.github.com/repos/edx/edx-enterprise/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-enterprise/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-enterprise/statuses/5f20abda0506e3a5333095db3ff768a7d1f73bda"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"UmanShahzad"}}