{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/131417390","pull_request_review_id":54399305,"id":131417390,"diff_hunk":"@@ -35,7 +35,7 @@\n #include <CGAL/Polygon_mesh_processing/compute_normal.h>\n \n #include <CGAL/Mesh_3/Polyline_with_context.h>\n-#include <CGAL/Polygon_mesh_processing/Detect_features_in_polyhedra.h>\n+#include <CGAL/Polygon_mesh_processing/Detect_features_in_polygon_mesh.h>","path":"Mesh_3/include/CGAL/Polyhedral_complex_mesh_domain_3.h","position":5,"original_position":5,"commit_id":"222f7f39658f6cf800921468d4b6a64724f1bcf7","original_commit_id":"222f7f39658f6cf800921468d4b6a64724f1bcf7","user":{"login":"janetournois","id":11311305,"avatar_url":"https://avatars0.githubusercontent.com/u/11311305?v=4","gravatar_id":"","url":"https://api.github.com/users/janetournois","html_url":"https://github.com/janetournois","followers_url":"https://api.github.com/users/janetournois/followers","following_url":"https://api.github.com/users/janetournois/following{/other_user}","gists_url":"https://api.github.com/users/janetournois/gists{/gist_id}","starred_url":"https://api.github.com/users/janetournois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetournois/subscriptions","organizations_url":"https://api.github.com/users/janetournois/orgs","repos_url":"https://api.github.com/users/janetournois/repos","events_url":"https://api.github.com/users/janetournois/events{/privacy}","received_events_url":"https://api.github.com/users/janetournois/received_events","type":"User","site_admin":false},"body":"+1\r\nAlso, the only files starting with a capital letter in this package are the ones providing a class","created_at":"2017-08-04T15:28:32Z","updated_at":"2017-08-04T15:28:32Z","html_url":"https://github.com/CGAL/cgal/pull/2336#discussion_r131417390","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/2336","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/131417390"},"html":{"href":"https://github.com/CGAL/cgal/pull/2336#discussion_r131417390"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2336"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/2336","id":134164885,"html_url":"https://github.com/CGAL/cgal/pull/2336","diff_url":"https://github.com/CGAL/cgal/pull/2336.diff","patch_url":"https://github.com/CGAL/cgal/pull/2336.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/2336","number":2336,"state":"open","locked":false,"title":"PMP: Detect features","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"body":"## Summary of Changes\r\nThis PR \r\n- replaces the files detect_features_in_polyhedra.h and  detect_features_in_polyhedra_fwd.h \r\nby the file detect_features_in_polygon_mesh.h\r\n- replaces the functor Detect_sharp_features_in_polyhedra by free functions using named parameters\r\n- documents these free functions\r\n- adds an example and a test for the function PMP::detect_features()\r\n\r\n\r\nYou can find the doc [here](https://cgal.geometryfactory.com/~mgimeno/PMP_v1/Polygon_mesh_processing/index.html)\r\n## Release Management\r\n\r\n* Affected package(s):Polygon_mesh_processing\r\n* Feature/Small Feature (if any):soon\r\n\r\n","created_at":"2017-08-04T13:17:26Z","updated_at":"2017-08-04T15:28:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cf4c8aef8106e43666cd149de157fadbf9a5fa6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/25","html_url":"https://github.com/CGAL/cgal/milestone/25","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/25/labels","id":2606767,"number":25,"title":"4.12-beta","description":"","creator":{"login":"sloriot","id":1224632,"avatar_url":"https://avatars2.githubusercontent.com/u/1224632?v=4","gravatar_id":"","url":"https://api.github.com/users/sloriot","html_url":"https://github.com/sloriot","followers_url":"https://api.github.com/users/sloriot/followers","following_url":"https://api.github.com/users/sloriot/following{/other_user}","gists_url":"https://api.github.com/users/sloriot/gists{/gist_id}","starred_url":"https://api.github.com/users/sloriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloriot/subscriptions","organizations_url":"https://api.github.com/users/sloriot/orgs","repos_url":"https://api.github.com/users/sloriot/repos","events_url":"https://api.github.com/users/sloriot/events{/privacy}","received_events_url":"https://api.github.com/users/sloriot/received_events","type":"User","site_admin":false},"open_issues":98,"closed_issues":2,"state":"open","created_at":"2017-06-27T09:50:39Z","updated_at":"2017-08-04T13:42:41Z","due_on":"2018-02-10T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/2336/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/2336/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/2336/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/222f7f39658f6cf800921468d4b6a64724f1bcf7","head":{"label":"maxGimeno:Detect_features-GF","ref":"Detect_features-GF","sha":"222f7f39658f6cf800921468d4b6a64724f1bcf7","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"repo":{"id":38375573,"name":"cgal","full_name":"maxGimeno/cgal","owner":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxGimeno/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/maxGimeno/cgal","forks_url":"https://api.github.com/repos/maxGimeno/cgal/forks","keys_url":"https://api.github.com/repos/maxGimeno/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxGimeno/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxGimeno/cgal/teams","hooks_url":"https://api.github.com/repos/maxGimeno/cgal/hooks","issue_events_url":"https://api.github.com/repos/maxGimeno/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/maxGimeno/cgal/events","assignees_url":"https://api.github.com/repos/maxGimeno/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/maxGimeno/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/maxGimeno/cgal/tags","blobs_url":"https://api.github.com/repos/maxGimeno/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxGimeno/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxGimeno/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxGimeno/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxGimeno/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/maxGimeno/cgal/languages","stargazers_url":"https://api.github.com/repos/maxGimeno/cgal/stargazers","contributors_url":"https://api.github.com/repos/maxGimeno/cgal/contributors","subscribers_url":"https://api.github.com/repos/maxGimeno/cgal/subscribers","subscription_url":"https://api.github.com/repos/maxGimeno/cgal/subscription","commits_url":"https://api.github.com/repos/maxGimeno/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxGimeno/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxGimeno/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxGimeno/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxGimeno/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/maxGimeno/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxGimeno/cgal/merges","archive_url":"https://api.github.com/repos/maxGimeno/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxGimeno/cgal/downloads","issues_url":"https://api.github.com/repos/maxGimeno/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/maxGimeno/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/maxGimeno/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/maxGimeno/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxGimeno/cgal/labels{/name}","releases_url":"https://api.github.com/repos/maxGimeno/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/maxGimeno/cgal/deployments","created_at":"2015-07-01T14:25:52Z","updated_at":"2017-01-20T17:02:24Z","pushed_at":"2017-08-04T14:56:39Z","git_url":"git://github.com/maxGimeno/cgal.git","ssh_url":"git@github.com:maxGimeno/cgal.git","clone_url":"https://github.com/maxGimeno/cgal.git","svn_url":"https://github.com/maxGimeno/cgal","homepage":"http://www.cgal.org","size":547315,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"fd8b1e73660624fa107f0329e19e524fbff45a94","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars0.githubusercontent.com/u/5746664?v=4","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars0.githubusercontent.com/u/5746664?v=4","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository, see the README below","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2017-08-04T03:51:45Z","pushed_at":"2017-08-04T14:56:41Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"https://github.com/CGAL/cgal#readme","size":546256,"stargazers_count":592,"watchers_count":592,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":274,"mirror_url":null,"open_issues_count":208,"forks":274,"open_issues":208,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2336"},"html":{"href":"https://github.com/CGAL/cgal/pull/2336"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/2336"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/2336/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2336/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2336/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/222f7f39658f6cf800921468d4b6a64724f1bcf7"}}}}
{"actor":{"display_login":"janetournois"}}