{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/100840573","pull_request_review_id":21556873,"id":100840573,"diff_hunk":"@@ -1,3 +1,33 @@\n --\n -- PacketFence SQL schema upgrade from X.X.X to X.Y.Z\n --\n+\n+--\n+-- Add a primary key to the radacct_log\n+--\n+\n+ALTER TABLE `radacct_log` ADD COLUMN `radacct_log_id` int NOT NULL PRIMARY KEY AUTO_INCREMENT FIRST;\n+\n+--\n+-- Add a primary key to the iplog_history\n+--\n+\n+ALTER TABLE `iplog_history` ADD COLUMN `iplog_history_id` int NOT NULL PRIMARY KEY AUTO_INCREMENT FIRST;\n+\n+--\n+-- Add a primary key to the iplog_archive\n+--\n+\n+ALTER TABLE `iplog_archive` ADD COLUMN `iplog_archive_id` int NOT NULL PRIMARY KEY AUTO_INCREMENT FIRST;\n+\n+--\n+-- Add a primary key to the locationlog\n+--\n+\n+ALTER TABLE `locationlog` ADD COLUMN `locationlog_id` int NOT NULL PRIMARY KEY AUTO_INCREMENT FIRST;","path":"db/upgrade-X.X.X-X.Y.Z.sql","position":27,"original_position":27,"commit_id":"b246d3bbcdd4febb5e7159803967b70ad84fa784","original_commit_id":"b246d3bbcdd4febb5e7159803967b70ad84fa784","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"In your testing, did this add a value to the pre-existing rows ?\r\n\r\nIf it doesn't, how will the ORM behave ?","created_at":"2017-02-13T16:53:22Z","updated_at":"2017-02-13T16:53:22Z","html_url":"https://github.com/inverse-inc/packetfence/pull/2020#discussion_r100840573","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/100840573"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/2020#discussion_r100840573"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020","id":105512096,"html_url":"https://github.com/inverse-inc/packetfence/pull/2020","diff_url":"https://github.com/inverse-inc/packetfence/pull/2020.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/2020.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/2020","number":2020,"state":"open","locked":false,"title":"feature/pf-orm","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"body":"Description\n-----------\nA simple ORM for packetfence\n\n\nDelete branch after merge\n-------------------------\nNO","created_at":"2017-02-09T20:58:56Z","updated_at":"2017-02-13T16:53:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cfd10742b125b453ecec58f5225c66ecf4274f5","assignee":{"login":"louismunro","id":193997,"avatar_url":"https://avatars.githubusercontent.com/u/193997?v=3","gravatar_id":"","url":"https://api.github.com/users/louismunro","html_url":"https://github.com/louismunro","followers_url":"https://api.github.com/users/louismunro/followers","following_url":"https://api.github.com/users/louismunro/following{/other_user}","gists_url":"https://api.github.com/users/louismunro/gists{/gist_id}","starred_url":"https://api.github.com/users/louismunro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louismunro/subscriptions","organizations_url":"https://api.github.com/users/louismunro/orgs","repos_url":"https://api.github.com/users/louismunro/repos","events_url":"https://api.github.com/users/louismunro/events{/privacy}","received_events_url":"https://api.github.com/users/louismunro/received_events","type":"User","site_admin":false},"assignees":[{"login":"louismunro","id":193997,"avatar_url":"https://avatars.githubusercontent.com/u/193997?v=3","gravatar_id":"","url":"https://api.github.com/users/louismunro","html_url":"https://github.com/louismunro","followers_url":"https://api.github.com/users/louismunro/followers","following_url":"https://api.github.com/users/louismunro/following{/other_user}","gists_url":"https://api.github.com/users/louismunro/gists{/gist_id}","starred_url":"https://api.github.com/users/louismunro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louismunro/subscriptions","organizations_url":"https://api.github.com/users/louismunro/orgs","repos_url":"https://api.github.com/users/louismunro/repos","events_url":"https://api.github.com/users/louismunro/events{/privacy}","received_events_url":"https://api.github.com/users/louismunro/received_events","type":"User","site_admin":false},{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/2020/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/b246d3bbcdd4febb5e7159803967b70ad84fa784","head":{"label":"jrouzierinverse:feature/pf-orm","ref":"feature/pf-orm","sha":"b246d3bbcdd4febb5e7159803967b70ad84fa784","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"repo":{"id":6552051,"name":"packetfence","full_name":"jrouzierinverse/packetfence","owner":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrouzierinverse/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/jrouzierinverse/packetfence","forks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/forks","keys_url":"https://api.github.com/repos/jrouzierinverse/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrouzierinverse/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrouzierinverse/packetfence/teams","hooks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/hooks","issue_events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/events","assignees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/jrouzierinverse/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/tags","blobs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrouzierinverse/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/jrouzierinverse/packetfence/languages","stargazers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/stargazers","contributors_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contributors","subscribers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscribers","subscription_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscription","commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrouzierinverse/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/jrouzierinverse/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrouzierinverse/packetfence/merges","archive_url":"https://api.github.com/repos/jrouzierinverse/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrouzierinverse/packetfence/downloads","issues_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/jrouzierinverse/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/jrouzierinverse/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/jrouzierinverse/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrouzierinverse/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/jrouzierinverse/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/jrouzierinverse/packetfence/deployments","created_at":"2012-11-05T21:28:44Z","updated_at":"2016-12-13T22:00:33Z","pushed_at":"2017-02-10T22:15:20Z","git_url":"git://github.com/jrouzierinverse/packetfence.git","ssh_url":"git@github.com:jrouzierinverse/packetfence.git","clone_url":"https://github.com/jrouzierinverse/packetfence.git","svn_url":"https://github.com/jrouzierinverse/packetfence","homepage":"http://www.packetfence.org","size":183814,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"ebc920d3ca49b723a96cf87baac4f2d472380bd3","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2017-02-10T15:50:50Z","pushed_at":"2017-02-13T15:17:54Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"https://packetfence.org","size":186954,"stargazers_count":264,"watchers_count":264,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":239,"forks":111,"open_issues":239,"watchers":264,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/2020"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/2020"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/2020/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/2020/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/b246d3bbcdd4febb5e7159803967b70ad84fa784"}}}}
{"actor":{"display_login":"julsemaan"}}