{"action":"created","comment":{"url":"https://api.github.com/repos/driftyco/ionic/pulls/comments/114858056","pull_request_review_id":36354059,"id":114858056,"diff_hunk":"@@ -368,7 +369,13 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {\n   /**\n    * @input {function} Same as `ngForTrackBy` which can be used on `ngFor`.\n    */\n-  @Input() virtualTrackBy: TrackByFn;\n+  @Input() set virtualTrackBy(val: TrackByFn) {\n+    if (!isPresent(val)) return;\n+    this._virtualTrackBy = val;\n+    if (isPresent(this._records)) {\n+      this._differ = this._iterableDiffers.find(this._records).create(this.virtualTrackBy);","path":"src/components/virtual-scroll/virtual-scroll.ts","position":null,"original_position":17,"commit_id":"682a88d2b5ae08665304c4ba22715724c18a6e6b","original_commit_id":"5595b8c084cfe2a7b37c52d6cf01d303789890da","user":{"login":"masimplo","id":803983,"avatar_url":"https://avatars1.githubusercontent.com/u/803983?v=3","gravatar_id":"","url":"https://api.github.com/users/masimplo","html_url":"https://github.com/masimplo","followers_url":"https://api.github.com/users/masimplo/followers","following_url":"https://api.github.com/users/masimplo/following{/other_user}","gists_url":"https://api.github.com/users/masimplo/gists{/gist_id}","starred_url":"https://api.github.com/users/masimplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masimplo/subscriptions","organizations_url":"https://api.github.com/users/masimplo/orgs","repos_url":"https://api.github.com/users/masimplo/repos","events_url":"https://api.github.com/users/masimplo/events{/privacy}","received_events_url":"https://api.github.com/users/masimplo/received_events","type":"User","site_admin":false},"body":"Wasn't sure if you prefer I overwrite last commit or add a new one, so I went with the safer choice. ","created_at":"2017-05-04T18:44:01Z","updated_at":"2017-05-04T18:44:01Z","html_url":"https://github.com/driftyco/ionic/pull/11492#discussion_r114858056","pull_request_url":"https://api.github.com/repos/driftyco/ionic/pulls/11492","_links":{"self":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/comments/114858056"},"html":{"href":"https://github.com/driftyco/ionic/pull/11492#discussion_r114858056"},"pull_request":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11492"}}},"pull_request":{"url":"https://api.github.com/repos/driftyco/ionic/pulls/11492","id":118757264,"html_url":"https://github.com/driftyco/ionic/pull/11492","diff_url":"https://github.com/driftyco/ionic/pull/11492.diff","patch_url":"https://github.com/driftyco/ionic/pull/11492.patch","issue_url":"https://api.github.com/repos/driftyco/ionic/issues/11492","number":11492,"state":"open","locked":false,"title":"fix(VirtualScroll): initialise differ with trackByFn","user":{"login":"masimplo","id":803983,"avatar_url":"https://avatars1.githubusercontent.com/u/803983?v=3","gravatar_id":"","url":"https://api.github.com/users/masimplo","html_url":"https://github.com/masimplo","followers_url":"https://api.github.com/users/masimplo/followers","following_url":"https://api.github.com/users/masimplo/following{/other_user}","gists_url":"https://api.github.com/users/masimplo/gists{/gist_id}","starred_url":"https://api.github.com/users/masimplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masimplo/subscriptions","organizations_url":"https://api.github.com/users/masimplo/orgs","repos_url":"https://api.github.com/users/masimplo/repos","events_url":"https://api.github.com/users/masimplo/events{/privacy}","received_events_url":"https://api.github.com/users/masimplo/received_events","type":"User","site_admin":false},"body":"#### Short description of what this resolves:\r\nVirtualScroll trackByFn has no effect due to the random order that Angular interprets input values.\r\n\r\n#### Changes proposed in this pull request:\r\n\r\nVirtual TrackByFn is changed into as setter input, that redefines the change detection mechanism as soon as trackBy is parsed, to take into account the provided function\r\n\r\n**Ionic Version**: 3.x\r\n\r\n**Fixes**: #7531\r\nRelated to #11294\r\n\r\n","created_at":"2017-05-03T13:09:13Z","updated_at":"2017-05-04T18:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22cad5b476c0bb92fa3637278dd41422ca9c1ce6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/driftyco/ionic/pulls/11492/commits","review_comments_url":"https://api.github.com/repos/driftyco/ionic/pulls/11492/comments","review_comment_url":"https://api.github.com/repos/driftyco/ionic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/driftyco/ionic/issues/11492/comments","statuses_url":"https://api.github.com/repos/driftyco/ionic/statuses/682a88d2b5ae08665304c4ba22715724c18a6e6b","head":{"label":"masimplo:feature/virtualscroll-trackby","ref":"feature/virtualscroll-trackby","sha":"682a88d2b5ae08665304c4ba22715724c18a6e6b","user":{"login":"masimplo","id":803983,"avatar_url":"https://avatars1.githubusercontent.com/u/803983?v=3","gravatar_id":"","url":"https://api.github.com/users/masimplo","html_url":"https://github.com/masimplo","followers_url":"https://api.github.com/users/masimplo/followers","following_url":"https://api.github.com/users/masimplo/following{/other_user}","gists_url":"https://api.github.com/users/masimplo/gists{/gist_id}","starred_url":"https://api.github.com/users/masimplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masimplo/subscriptions","organizations_url":"https://api.github.com/users/masimplo/orgs","repos_url":"https://api.github.com/users/masimplo/repos","events_url":"https://api.github.com/users/masimplo/events{/privacy}","received_events_url":"https://api.github.com/users/masimplo/received_events","type":"User","site_admin":false},"repo":{"id":79427466,"name":"ionic","full_name":"masimplo/ionic","owner":{"login":"masimplo","id":803983,"avatar_url":"https://avatars1.githubusercontent.com/u/803983?v=3","gravatar_id":"","url":"https://api.github.com/users/masimplo","html_url":"https://github.com/masimplo","followers_url":"https://api.github.com/users/masimplo/followers","following_url":"https://api.github.com/users/masimplo/following{/other_user}","gists_url":"https://api.github.com/users/masimplo/gists{/gist_id}","starred_url":"https://api.github.com/users/masimplo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masimplo/subscriptions","organizations_url":"https://api.github.com/users/masimplo/orgs","repos_url":"https://api.github.com/users/masimplo/repos","events_url":"https://api.github.com/users/masimplo/events{/privacy}","received_events_url":"https://api.github.com/users/masimplo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/masimplo/ionic","description":"Build amazing native and progressive web apps with Angular and open web technologies. One app running on everything 🎉","fork":true,"url":"https://api.github.com/repos/masimplo/ionic","forks_url":"https://api.github.com/repos/masimplo/ionic/forks","keys_url":"https://api.github.com/repos/masimplo/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masimplo/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masimplo/ionic/teams","hooks_url":"https://api.github.com/repos/masimplo/ionic/hooks","issue_events_url":"https://api.github.com/repos/masimplo/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/masimplo/ionic/events","assignees_url":"https://api.github.com/repos/masimplo/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/masimplo/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/masimplo/ionic/tags","blobs_url":"https://api.github.com/repos/masimplo/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masimplo/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masimplo/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/masimplo/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masimplo/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/masimplo/ionic/languages","stargazers_url":"https://api.github.com/repos/masimplo/ionic/stargazers","contributors_url":"https://api.github.com/repos/masimplo/ionic/contributors","subscribers_url":"https://api.github.com/repos/masimplo/ionic/subscribers","subscription_url":"https://api.github.com/repos/masimplo/ionic/subscription","commits_url":"https://api.github.com/repos/masimplo/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/masimplo/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/masimplo/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/masimplo/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/masimplo/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/masimplo/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masimplo/ionic/merges","archive_url":"https://api.github.com/repos/masimplo/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masimplo/ionic/downloads","issues_url":"https://api.github.com/repos/masimplo/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/masimplo/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/masimplo/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/masimplo/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masimplo/ionic/labels{/name}","releases_url":"https://api.github.com/repos/masimplo/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/masimplo/ionic/deployments","created_at":"2017-01-19T07:30:11Z","updated_at":"2017-01-19T07:30:18Z","pushed_at":"2017-05-04T18:42:40Z","git_url":"git://github.com/masimplo/ionic.git","ssh_url":"git@github.com:masimplo/ionic.git","clone_url":"https://github.com/masimplo/ionic.git","svn_url":"https://github.com/masimplo/ionic","homepage":"http://ionicframework.com/","size":70400,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"driftyco:master","ref":"master","sha":"59dd853f543baf277e8d8828ee95570601e11618","user":{"login":"driftyco","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/driftyco","html_url":"https://github.com/driftyco","followers_url":"https://api.github.com/users/driftyco/followers","following_url":"https://api.github.com/users/driftyco/following{/other_user}","gists_url":"https://api.github.com/users/driftyco/gists{/gist_id}","starred_url":"https://api.github.com/users/driftyco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driftyco/subscriptions","organizations_url":"https://api.github.com/users/driftyco/orgs","repos_url":"https://api.github.com/users/driftyco/repos","events_url":"https://api.github.com/users/driftyco/events{/privacy}","received_events_url":"https://api.github.com/users/driftyco/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"name":"ionic","full_name":"driftyco/ionic","owner":{"login":"driftyco","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/driftyco","html_url":"https://github.com/driftyco","followers_url":"https://api.github.com/users/driftyco/followers","following_url":"https://api.github.com/users/driftyco/following{/other_user}","gists_url":"https://api.github.com/users/driftyco/gists{/gist_id}","starred_url":"https://api.github.com/users/driftyco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driftyco/subscriptions","organizations_url":"https://api.github.com/users/driftyco/orgs","repos_url":"https://api.github.com/users/driftyco/repos","events_url":"https://api.github.com/users/driftyco/events{/privacy}","received_events_url":"https://api.github.com/users/driftyco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/driftyco/ionic","description":"Build amazing native and progressive web apps with Angular and open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/driftyco/ionic","forks_url":"https://api.github.com/repos/driftyco/ionic/forks","keys_url":"https://api.github.com/repos/driftyco/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/driftyco/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/driftyco/ionic/teams","hooks_url":"https://api.github.com/repos/driftyco/ionic/hooks","issue_events_url":"https://api.github.com/repos/driftyco/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/driftyco/ionic/events","assignees_url":"https://api.github.com/repos/driftyco/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/driftyco/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/driftyco/ionic/tags","blobs_url":"https://api.github.com/repos/driftyco/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/driftyco/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/driftyco/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/driftyco/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/driftyco/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/driftyco/ionic/languages","stargazers_url":"https://api.github.com/repos/driftyco/ionic/stargazers","contributors_url":"https://api.github.com/repos/driftyco/ionic/contributors","subscribers_url":"https://api.github.com/repos/driftyco/ionic/subscribers","subscription_url":"https://api.github.com/repos/driftyco/ionic/subscription","commits_url":"https://api.github.com/repos/driftyco/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/driftyco/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/driftyco/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/driftyco/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/driftyco/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/driftyco/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/driftyco/ionic/merges","archive_url":"https://api.github.com/repos/driftyco/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/driftyco/ionic/downloads","issues_url":"https://api.github.com/repos/driftyco/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/driftyco/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/driftyco/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/driftyco/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/driftyco/ionic/labels{/name}","releases_url":"https://api.github.com/repos/driftyco/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/driftyco/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2017-05-04T16:17:00Z","pushed_at":"2017-05-04T18:42:42Z","git_url":"git://github.com/driftyco/ionic.git","ssh_url":"git@github.com:driftyco/ionic.git","clone_url":"https://github.com/driftyco/ionic.git","svn_url":"https://github.com/driftyco/ionic","homepage":"http://ionicframework.com/","size":71598,"stargazers_count":29346,"watchers_count":29346,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7512,"mirror_url":null,"open_issues_count":775,"forks":7512,"open_issues":775,"watchers":29346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11492"},"html":{"href":"https://github.com/driftyco/ionic/pull/11492"},"issue":{"href":"https://api.github.com/repos/driftyco/ionic/issues/11492"},"comments":{"href":"https://api.github.com/repos/driftyco/ionic/issues/11492/comments"},"review_comments":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11492/comments"},"review_comment":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11492/commits"},"statuses":{"href":"https://api.github.com/repos/driftyco/ionic/statuses/682a88d2b5ae08665304c4ba22715724c18a6e6b"}}}}
{"actor":{"display_login":"masimplo"}}