{"action":"created","comment":{"url":"https://api.github.com/repos/conda/conda/pulls/comments/104057690","pull_request_review_id":24872576,"id":104057690,"diff_hunk":"@@ -64,3 +65,9 @@ def make_executable(path):\n         chmod(path, S_IMODE(mode) | S_IXUSR | S_IXGRP | S_IXOTH)\n     else:\n         log.error(\"Cannot make path '%s' executable\", path)\n+\n+\n+def is_executable(path):\n+    if isfile(path):  # for now, leave out `and not islink(path)`\n+        return path.endswith(('.exe', '.bat')) if on_win else access(path, X_OK)\n+    return False","path":"conda/gateways/disk/permissions.py","position":24,"original_position":24,"commit_id":"f2a625e9dc4073f39016b55db1cd65047d2a2b5d","original_commit_id":"91a146a37b2ae4090e8a8f1798667cbe43533e02","user":{"login":"mingwandroid","id":1042804,"avatar_url":"https://avatars2.githubusercontent.com/u/1042804?v=3","gravatar_id":"","url":"https://api.github.com/users/mingwandroid","html_url":"https://github.com/mingwandroid","followers_url":"https://api.github.com/users/mingwandroid/followers","following_url":"https://api.github.com/users/mingwandroid/following{/other_user}","gists_url":"https://api.github.com/users/mingwandroid/gists{/gist_id}","starred_url":"https://api.github.com/users/mingwandroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingwandroid/subscriptions","organizations_url":"https://api.github.com/users/mingwandroid/orgs","repos_url":"https://api.github.com/users/mingwandroid/repos","events_url":"https://api.github.com/users/mingwandroid/events{/privacy}","received_events_url":"https://api.github.com/users/mingwandroid/received_events","type":"User","site_admin":false},"body":"AFAIK, macOS doesn't need this, but it may be safer this way.","created_at":"2017-03-02T23:33:52Z","updated_at":"2017-03-02T23:33:52Z","html_url":"https://github.com/conda/conda/pull/4625#discussion_r104057690","pull_request_url":"https://api.github.com/repos/conda/conda/pulls/4625","_links":{"self":{"href":"https://api.github.com/repos/conda/conda/pulls/comments/104057690"},"html":{"href":"https://github.com/conda/conda/pull/4625#discussion_r104057690"},"pull_request":{"href":"https://api.github.com/repos/conda/conda/pulls/4625"}}},"pull_request":{"url":"https://api.github.com/repos/conda/conda/pulls/4625","id":106035909,"html_url":"https://github.com/conda/conda/pull/4625","diff_url":"https://github.com/conda/conda/pull/4625.diff","patch_url":"https://github.com/conda/conda/pull/4625.patch","issue_url":"https://api.github.com/repos/conda/conda/issues/4625","number":4625,"state":"open","locked":false,"title":"never symlink executables","user":{"login":"kalefranz","id":1418419,"avatar_url":"https://avatars3.githubusercontent.com/u/1418419?v=3","gravatar_id":"","url":"https://api.github.com/users/kalefranz","html_url":"https://github.com/kalefranz","followers_url":"https://api.github.com/users/kalefranz/followers","following_url":"https://api.github.com/users/kalefranz/following{/other_user}","gists_url":"https://api.github.com/users/kalefranz/gists{/gist_id}","starred_url":"https://api.github.com/users/kalefranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalefranz/subscriptions","organizations_url":"https://api.github.com/users/kalefranz/orgs","repos_url":"https://api.github.com/users/kalefranz/repos","events_url":"https://api.github.com/users/kalefranz/events{/privacy}","received_events_url":"https://api.github.com/users/kalefranz/received_events","type":"User","site_admin":false},"body":"A low-level response to https://github.com/conda/conda/issues/3974 and https://github.com/ContinuumIO/anaconda-issues/issues/1392.\r\n\r\nThis is targeted for 4.4.0 because I'd prefer a change like this go through a full feature canary cycle.\r\n\r\nCC @mingwandroid ","created_at":"2017-02-14T04:59:45Z","updated_at":"2017-03-02T23:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0eaed30a8471597999581a9213c37b5fab5a06a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/conda/conda/pulls/4625/commits","review_comments_url":"https://api.github.com/repos/conda/conda/pulls/4625/comments","review_comment_url":"https://api.github.com/repos/conda/conda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conda/conda/issues/4625/comments","statuses_url":"https://api.github.com/repos/conda/conda/statuses/f2a625e9dc4073f39016b55db1cd65047d2a2b5d","head":{"label":"kalefranz:never-symlink-executables","ref":"never-symlink-executables","sha":"f2a625e9dc4073f39016b55db1cd65047d2a2b5d","user":{"login":"kalefranz","id":1418419,"avatar_url":"https://avatars3.githubusercontent.com/u/1418419?v=3","gravatar_id":"","url":"https://api.github.com/users/kalefranz","html_url":"https://github.com/kalefranz","followers_url":"https://api.github.com/users/kalefranz/followers","following_url":"https://api.github.com/users/kalefranz/following{/other_user}","gists_url":"https://api.github.com/users/kalefranz/gists{/gist_id}","starred_url":"https://api.github.com/users/kalefranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalefranz/subscriptions","organizations_url":"https://api.github.com/users/kalefranz/orgs","repos_url":"https://api.github.com/users/kalefranz/repos","events_url":"https://api.github.com/users/kalefranz/events{/privacy}","received_events_url":"https://api.github.com/users/kalefranz/received_events","type":"User","site_admin":false},"repo":{"id":49458781,"name":"conda","full_name":"kalefranz/conda","owner":{"login":"kalefranz","id":1418419,"avatar_url":"https://avatars3.githubusercontent.com/u/1418419?v=3","gravatar_id":"","url":"https://api.github.com/users/kalefranz","html_url":"https://github.com/kalefranz","followers_url":"https://api.github.com/users/kalefranz/followers","following_url":"https://api.github.com/users/kalefranz/following{/other_user}","gists_url":"https://api.github.com/users/kalefranz/gists{/gist_id}","starred_url":"https://api.github.com/users/kalefranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalefranz/subscriptions","organizations_url":"https://api.github.com/users/kalefranz/orgs","repos_url":"https://api.github.com/users/kalefranz/repos","events_url":"https://api.github.com/users/kalefranz/events{/privacy}","received_events_url":"https://api.github.com/users/kalefranz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalefranz/conda","description":"Cross-platform, Python-agnostic binary package manager","fork":true,"url":"https://api.github.com/repos/kalefranz/conda","forks_url":"https://api.github.com/repos/kalefranz/conda/forks","keys_url":"https://api.github.com/repos/kalefranz/conda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalefranz/conda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalefranz/conda/teams","hooks_url":"https://api.github.com/repos/kalefranz/conda/hooks","issue_events_url":"https://api.github.com/repos/kalefranz/conda/issues/events{/number}","events_url":"https://api.github.com/repos/kalefranz/conda/events","assignees_url":"https://api.github.com/repos/kalefranz/conda/assignees{/user}","branches_url":"https://api.github.com/repos/kalefranz/conda/branches{/branch}","tags_url":"https://api.github.com/repos/kalefranz/conda/tags","blobs_url":"https://api.github.com/repos/kalefranz/conda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalefranz/conda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalefranz/conda/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalefranz/conda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalefranz/conda/statuses/{sha}","languages_url":"https://api.github.com/repos/kalefranz/conda/languages","stargazers_url":"https://api.github.com/repos/kalefranz/conda/stargazers","contributors_url":"https://api.github.com/repos/kalefranz/conda/contributors","subscribers_url":"https://api.github.com/repos/kalefranz/conda/subscribers","subscription_url":"https://api.github.com/repos/kalefranz/conda/subscription","commits_url":"https://api.github.com/repos/kalefranz/conda/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalefranz/conda/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalefranz/conda/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalefranz/conda/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalefranz/conda/contents/{+path}","compare_url":"https://api.github.com/repos/kalefranz/conda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalefranz/conda/merges","archive_url":"https://api.github.com/repos/kalefranz/conda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalefranz/conda/downloads","issues_url":"https://api.github.com/repos/kalefranz/conda/issues{/number}","pulls_url":"https://api.github.com/repos/kalefranz/conda/pulls{/number}","milestones_url":"https://api.github.com/repos/kalefranz/conda/milestones{/number}","notifications_url":"https://api.github.com/repos/kalefranz/conda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalefranz/conda/labels{/name}","releases_url":"https://api.github.com/repos/kalefranz/conda/releases{/id}","deployments_url":"https://api.github.com/repos/kalefranz/conda/deployments","created_at":"2016-01-11T22:34:49Z","updated_at":"2016-01-11T22:34:50Z","pushed_at":"2017-03-02T23:24:17Z","git_url":"git://github.com/kalefranz/conda.git","ssh_url":"git@github.com:kalefranz/conda.git","clone_url":"https://github.com/kalefranz/conda.git","svn_url":"https://github.com/kalefranz/conda","homepage":"conda.pydata.org","size":159153,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"conda:4.3.x","ref":"4.3.x","sha":"03dc2d1fc899866dcb4b36adb8660a3680ae32af","user":{"login":"conda","id":6392739,"avatar_url":"https://avatars3.githubusercontent.com/u/6392739?v=3","gravatar_id":"","url":"https://api.github.com/users/conda","html_url":"https://github.com/conda","followers_url":"https://api.github.com/users/conda/followers","following_url":"https://api.github.com/users/conda/following{/other_user}","gists_url":"https://api.github.com/users/conda/gists{/gist_id}","starred_url":"https://api.github.com/users/conda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda/subscriptions","organizations_url":"https://api.github.com/users/conda/orgs","repos_url":"https://api.github.com/users/conda/repos","events_url":"https://api.github.com/users/conda/events{/privacy}","received_events_url":"https://api.github.com/users/conda/received_events","type":"Organization","site_admin":false},"repo":{"id":6235174,"name":"conda","full_name":"conda/conda","owner":{"login":"conda","id":6392739,"avatar_url":"https://avatars3.githubusercontent.com/u/6392739?v=3","gravatar_id":"","url":"https://api.github.com/users/conda","html_url":"https://github.com/conda","followers_url":"https://api.github.com/users/conda/followers","following_url":"https://api.github.com/users/conda/following{/other_user}","gists_url":"https://api.github.com/users/conda/gists{/gist_id}","starred_url":"https://api.github.com/users/conda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda/subscriptions","organizations_url":"https://api.github.com/users/conda/orgs","repos_url":"https://api.github.com/users/conda/repos","events_url":"https://api.github.com/users/conda/events{/privacy}","received_events_url":"https://api.github.com/users/conda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conda/conda","description":"OS-agnostic, system-level binary package manager and ecosystem","fork":false,"url":"https://api.github.com/repos/conda/conda","forks_url":"https://api.github.com/repos/conda/conda/forks","keys_url":"https://api.github.com/repos/conda/conda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conda/conda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conda/conda/teams","hooks_url":"https://api.github.com/repos/conda/conda/hooks","issue_events_url":"https://api.github.com/repos/conda/conda/issues/events{/number}","events_url":"https://api.github.com/repos/conda/conda/events","assignees_url":"https://api.github.com/repos/conda/conda/assignees{/user}","branches_url":"https://api.github.com/repos/conda/conda/branches{/branch}","tags_url":"https://api.github.com/repos/conda/conda/tags","blobs_url":"https://api.github.com/repos/conda/conda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conda/conda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conda/conda/git/refs{/sha}","trees_url":"https://api.github.com/repos/conda/conda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conda/conda/statuses/{sha}","languages_url":"https://api.github.com/repos/conda/conda/languages","stargazers_url":"https://api.github.com/repos/conda/conda/stargazers","contributors_url":"https://api.github.com/repos/conda/conda/contributors","subscribers_url":"https://api.github.com/repos/conda/conda/subscribers","subscription_url":"https://api.github.com/repos/conda/conda/subscription","commits_url":"https://api.github.com/repos/conda/conda/commits{/sha}","git_commits_url":"https://api.github.com/repos/conda/conda/git/commits{/sha}","comments_url":"https://api.github.com/repos/conda/conda/comments{/number}","issue_comment_url":"https://api.github.com/repos/conda/conda/issues/comments{/number}","contents_url":"https://api.github.com/repos/conda/conda/contents/{+path}","compare_url":"https://api.github.com/repos/conda/conda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conda/conda/merges","archive_url":"https://api.github.com/repos/conda/conda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conda/conda/downloads","issues_url":"https://api.github.com/repos/conda/conda/issues{/number}","pulls_url":"https://api.github.com/repos/conda/conda/pulls{/number}","milestones_url":"https://api.github.com/repos/conda/conda/milestones{/number}","notifications_url":"https://api.github.com/repos/conda/conda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conda/conda/labels{/name}","releases_url":"https://api.github.com/repos/conda/conda/releases{/id}","deployments_url":"https://api.github.com/repos/conda/conda/deployments","created_at":"2012-10-15T22:08:03Z","updated_at":"2017-03-02T22:56:54Z","pushed_at":"2017-03-02T23:32:23Z","git_url":"git://github.com/conda/conda.git","ssh_url":"git@github.com:conda/conda.git","clone_url":"https://github.com/conda/conda.git","svn_url":"https://github.com/conda/conda","homepage":"https://conda.io","size":16005,"stargazers_count":1145,"watchers_count":1145,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":374,"mirror_url":null,"open_issues_count":1379,"forks":374,"open_issues":1379,"watchers":1145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conda/conda/pulls/4625"},"html":{"href":"https://github.com/conda/conda/pull/4625"},"issue":{"href":"https://api.github.com/repos/conda/conda/issues/4625"},"comments":{"href":"https://api.github.com/repos/conda/conda/issues/4625/comments"},"review_comments":{"href":"https://api.github.com/repos/conda/conda/pulls/4625/comments"},"review_comment":{"href":"https://api.github.com/repos/conda/conda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conda/conda/pulls/4625/commits"},"statuses":{"href":"https://api.github.com/repos/conda/conda/statuses/f2a625e9dc4073f39016b55db1cd65047d2a2b5d"}}}}
{"actor":{"display_login":"mingwandroid"}}