{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/ditto/pulls/comments/150850829","pull_request_review_id":76461596,"id":150850829,"diff_hunk":"@@ -61,14 +60,26 @@ public void nullAttributesIsJsonNull() {\n         assertThat(underTest.isNull()).isTrue();\n     }\n \n+    @Test\n+    public void nullAttributesIsJsonObject() {\n+        assertThat(underTest.isObject()).isTrue();\n+    }\n+\n+    @Test\n+    public void nullAttributesAsJsonObject() {\n+        assertThat(underTest.asObject()).isEqualTo(JsonFactory.nullObject());","path":"model/things/src/test/java/org/eclipse/ditto/model/things/NullAttributesTest.java","position":35,"original_position":35,"commit_id":"743aa10de791ce61b0be74e51294288226b95048","original_commit_id":"743aa10de791ce61b0be74e51294288226b95048","user":{"login":"dguggemos","id":15028977,"avatar_url":"https://avatars1.githubusercontent.com/u/15028977?v=4","gravatar_id":"","url":"https://api.github.com/users/dguggemos","html_url":"https://github.com/dguggemos","followers_url":"https://api.github.com/users/dguggemos/followers","following_url":"https://api.github.com/users/dguggemos/following{/other_user}","gists_url":"https://api.github.com/users/dguggemos/gists{/gist_id}","starred_url":"https://api.github.com/users/dguggemos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguggemos/subscriptions","organizations_url":"https://api.github.com/users/dguggemos/orgs","repos_url":"https://api.github.com/users/dguggemos/repos","events_url":"https://api.github.com/users/dguggemos/events{/privacy}","received_events_url":"https://api.github.com/users/dguggemos/received_events","type":"User","site_admin":false},"body":"Depends on what we want to test. I just wanted to make sure that `asObject()` returns a null object. ","created_at":"2017-11-14T14:41:25Z","updated_at":"2017-11-14T14:41:25Z","html_url":"https://github.com/eclipse/ditto/pull/44#discussion_r150850829","pull_request_url":"https://api.github.com/repos/eclipse/ditto/pulls/44","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/ditto/pulls/comments/150850829"},"html":{"href":"https://github.com/eclipse/ditto/pull/44#discussion_r150850829"},"pull_request":{"href":"https://api.github.com/repos/eclipse/ditto/pulls/44"}},"in_reply_to_id":150848505},"pull_request":{"url":"https://api.github.com/repos/eclipse/ditto/pulls/44","id":152519033,"html_url":"https://github.com/eclipse/ditto/pull/44","diff_url":"https://github.com/eclipse/ditto/pull/44.diff","patch_url":"https://github.com/eclipse/ditto/pull/44.patch","issue_url":"https://api.github.com/repos/eclipse/ditto/issues/44","number":44,"state":"open","locked":false,"title":" #41 fix message (de)serialization in DittoProtocolAdapter","user":{"login":"dguggemos","id":15028977,"avatar_url":"https://avatars1.githubusercontent.com/u/15028977?v=4","gravatar_id":"","url":"https://api.github.com/users/dguggemos","html_url":"https://github.com/dguggemos","followers_url":"https://api.github.com/users/dguggemos/followers","following_url":"https://api.github.com/users/dguggemos/following{/other_user}","gists_url":"https://api.github.com/users/dguggemos/gists{/gist_id}","starred_url":"https://api.github.com/users/dguggemos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguggemos/subscriptions","organizations_url":"https://api.github.com/users/dguggemos/orgs","repos_url":"https://api.github.com/users/dguggemos/repos","events_url":"https://api.github.com/users/dguggemos/events{/privacy}","received_events_url":"https://api.github.com/users/dguggemos/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-14T14:29:30Z","updated_at":"2017-11-14T14:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f243f6f7b7f351933abc1d3f4f4a1f60084bc961","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/ditto/pulls/44/commits","review_comments_url":"https://api.github.com/repos/eclipse/ditto/pulls/44/comments","review_comment_url":"https://api.github.com/repos/eclipse/ditto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/ditto/issues/44/comments","statuses_url":"https://api.github.com/repos/eclipse/ditto/statuses/743aa10de791ce61b0be74e51294288226b95048","head":{"label":"bsinno:bugfix/issue-41-protocol-adapter-fixes","ref":"bugfix/issue-41-protocol-adapter-fixes","sha":"743aa10de791ce61b0be74e51294288226b95048","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":105869651,"name":"ditto","full_name":"bsinno/ditto","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/ditto","description":null,"fork":true,"url":"https://api.github.com/repos/bsinno/ditto","forks_url":"https://api.github.com/repos/bsinno/ditto/forks","keys_url":"https://api.github.com/repos/bsinno/ditto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/ditto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/ditto/teams","hooks_url":"https://api.github.com/repos/bsinno/ditto/hooks","issue_events_url":"https://api.github.com/repos/bsinno/ditto/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/ditto/events","assignees_url":"https://api.github.com/repos/bsinno/ditto/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/ditto/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/ditto/tags","blobs_url":"https://api.github.com/repos/bsinno/ditto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/ditto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/ditto/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/ditto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/ditto/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/ditto/languages","stargazers_url":"https://api.github.com/repos/bsinno/ditto/stargazers","contributors_url":"https://api.github.com/repos/bsinno/ditto/contributors","subscribers_url":"https://api.github.com/repos/bsinno/ditto/subscribers","subscription_url":"https://api.github.com/repos/bsinno/ditto/subscription","commits_url":"https://api.github.com/repos/bsinno/ditto/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/ditto/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/ditto/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/ditto/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/ditto/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/ditto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/ditto/merges","archive_url":"https://api.github.com/repos/bsinno/ditto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/ditto/downloads","issues_url":"https://api.github.com/repos/bsinno/ditto/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/ditto/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/ditto/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/ditto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/ditto/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/ditto/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/ditto/deployments","created_at":"2017-10-05T09:06:13Z","updated_at":"2017-11-07T09:41:39Z","pushed_at":"2017-11-14T14:28:10Z","git_url":"git://github.com/bsinno/ditto.git","ssh_url":"git@github.com:bsinno/ditto.git","clone_url":"https://github.com/bsinno/ditto.git","svn_url":"https://github.com/bsinno/ditto","homepage":null,"size":4024,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"0d3b328f9b5960d7da7c26de11e7aefc6cbdc6c4","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":87849739,"name":"ditto","full_name":"eclipse/ditto","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/ditto","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/ditto","forks_url":"https://api.github.com/repos/eclipse/ditto/forks","keys_url":"https://api.github.com/repos/eclipse/ditto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/ditto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/ditto/teams","hooks_url":"https://api.github.com/repos/eclipse/ditto/hooks","issue_events_url":"https://api.github.com/repos/eclipse/ditto/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/ditto/events","assignees_url":"https://api.github.com/repos/eclipse/ditto/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/ditto/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/ditto/tags","blobs_url":"https://api.github.com/repos/eclipse/ditto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/ditto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/ditto/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/ditto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/ditto/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/ditto/languages","stargazers_url":"https://api.github.com/repos/eclipse/ditto/stargazers","contributors_url":"https://api.github.com/repos/eclipse/ditto/contributors","subscribers_url":"https://api.github.com/repos/eclipse/ditto/subscribers","subscription_url":"https://api.github.com/repos/eclipse/ditto/subscription","commits_url":"https://api.github.com/repos/eclipse/ditto/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/ditto/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/ditto/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/ditto/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/ditto/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/ditto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/ditto/merges","archive_url":"https://api.github.com/repos/eclipse/ditto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/ditto/downloads","issues_url":"https://api.github.com/repos/eclipse/ditto/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/ditto/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/ditto/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/ditto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/ditto/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/ditto/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/ditto/deployments","created_at":"2017-04-10T19:29:57Z","updated_at":"2017-11-02T11:44:45Z","pushed_at":"2017-11-14T14:29:31Z","git_url":"git://github.com/eclipse/ditto.git","ssh_url":"git@github.com:eclipse/ditto.git","clone_url":"https://github.com/eclipse/ditto.git","svn_url":"https://github.com/eclipse/ditto","homepage":null,"size":4024,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/ditto/pulls/44"},"html":{"href":"https://github.com/eclipse/ditto/pull/44"},"issue":{"href":"https://api.github.com/repos/eclipse/ditto/issues/44"},"comments":{"href":"https://api.github.com/repos/eclipse/ditto/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/ditto/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/ditto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/ditto/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/ditto/statuses/743aa10de791ce61b0be74e51294288226b95048"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dguggemos"}}