{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/118529475","pull_request_review_id":40330014,"id":118529475,"diff_hunk":"@@ -196,8 +222,20 @@ protocol ArgumentProtocol: Hashable {\n     /// for a short names for e.g: `--help` -> `-h`.\n     var shortName: String? { get }\n \n+    /// The parsing strategy to adopt when parsing values.\n+    var strategy: ArrayParsingStrategy { get }\n+\n+    /// Defines is the argument is optional\n+    var isOptional: Bool { get }\n+\n     /// The usage text associated with this argument. Used to generate complete help string.\n     var usage: String? { get }\n+\n+    /// Parses and returns the argument values from the parser.\n+    /// FIXME: Because `ArgumentKindTy`` can't conform to `ArgumentKind`, this function has to be provided","path":"Sources/Utility/ArgumentParser.swift","position":196,"original_position":196,"commit_id":"e0299ca6bbd7a4c855fd95abebb7c216a5917e6d","original_commit_id":"e0299ca6bbd7a4c855fd95abebb7c216a5917e6d","user":{"login":"aciidb0mb3r","id":4136295,"avatar_url":"https://avatars3.githubusercontent.com/u/4136295?v=3","gravatar_id":"","url":"https://api.github.com/users/aciidb0mb3r","html_url":"https://github.com/aciidb0mb3r","followers_url":"https://api.github.com/users/aciidb0mb3r/followers","following_url":"https://api.github.com/users/aciidb0mb3r/following{/other_user}","gists_url":"https://api.github.com/users/aciidb0mb3r/gists{/gist_id}","starred_url":"https://api.github.com/users/aciidb0mb3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aciidb0mb3r/subscriptions","organizations_url":"https://api.github.com/users/aciidb0mb3r/orgs","repos_url":"https://api.github.com/users/aciidb0mb3r/repos","events_url":"https://api.github.com/users/aciidb0mb3r/events{/privacy}","received_events_url":"https://api.github.com/users/aciidb0mb3r/received_events","type":"User","site_admin":false},"body":"nit: FIXME should not be part of doc comments. Use `//` instead.","created_at":"2017-05-25T16:49:44Z","updated_at":"2017-05-25T17:00:23Z","html_url":"https://github.com/apple/swift-package-manager/pull/1206#discussion_r118529475","pull_request_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/118529475"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/1206#discussion_r118529475"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206","id":121655435,"html_url":"https://github.com/apple/swift-package-manager/pull/1206","diff_url":"https://github.com/apple/swift-package-manager/pull/1206.diff","patch_url":"https://github.com/apple/swift-package-manager/pull/1206.patch","issue_url":"https://api.github.com/repos/apple/swift-package-manager/issues/1206","number":1206,"state":"open","locked":false,"title":"Add multiple-value arguments to ArgumentParser","user":{"login":"hartbit","id":325519,"avatar_url":"https://avatars2.githubusercontent.com/u/325519?v=3","gravatar_id":"","url":"https://api.github.com/users/hartbit","html_url":"https://github.com/hartbit","followers_url":"https://api.github.com/users/hartbit/followers","following_url":"https://api.github.com/users/hartbit/following{/other_user}","gists_url":"https://api.github.com/users/hartbit/gists{/gist_id}","starred_url":"https://api.github.com/users/hartbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartbit/subscriptions","organizations_url":"https://api.github.com/users/hartbit/orgs","repos_url":"https://api.github.com/users/hartbit/repos","events_url":"https://api.github.com/users/hartbit/events{/privacy}","received_events_url":"https://api.github.com/users/hartbit/received_events","type":"User","site_admin":false},"body":"Here is a list of modifications:\r\n\r\n* Created `ParserOptionArgument` and `ParserPositionArgument` structs so that `ArgumentParser` can store additional settings about arguments.\r\n* The `ParsingStrategy` setting allows `ArgumentParser` to store the number of values a multiple-value option or positional argument is expecting:\r\n    * `one`: for values which needs to be parsed one-by-one (i.e., `-Xcc`)\r\n    * `multiple`: for values which parse until a non-positional argument\r\n    * `remainder`: for values which will parse all remaining arguments\r\n* Simplified `ArgumentKind` with default implementations of the parser initializer.","created_at":"2017-05-21T10:20:10Z","updated_at":"2017-05-25T17:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5684882066eac33eac21dd83af8624a7913432c7","assignee":{"login":"aciidb0mb3r","id":4136295,"avatar_url":"https://avatars3.githubusercontent.com/u/4136295?v=3","gravatar_id":"","url":"https://api.github.com/users/aciidb0mb3r","html_url":"https://github.com/aciidb0mb3r","followers_url":"https://api.github.com/users/aciidb0mb3r/followers","following_url":"https://api.github.com/users/aciidb0mb3r/following{/other_user}","gists_url":"https://api.github.com/users/aciidb0mb3r/gists{/gist_id}","starred_url":"https://api.github.com/users/aciidb0mb3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aciidb0mb3r/subscriptions","organizations_url":"https://api.github.com/users/aciidb0mb3r/orgs","repos_url":"https://api.github.com/users/aciidb0mb3r/repos","events_url":"https://api.github.com/users/aciidb0mb3r/events{/privacy}","received_events_url":"https://api.github.com/users/aciidb0mb3r/received_events","type":"User","site_admin":false},"assignees":[{"login":"aciidb0mb3r","id":4136295,"avatar_url":"https://avatars3.githubusercontent.com/u/4136295?v=3","gravatar_id":"","url":"https://api.github.com/users/aciidb0mb3r","html_url":"https://github.com/aciidb0mb3r","followers_url":"https://api.github.com/users/aciidb0mb3r/followers","following_url":"https://api.github.com/users/aciidb0mb3r/following{/other_user}","gists_url":"https://api.github.com/users/aciidb0mb3r/gists{/gist_id}","starred_url":"https://api.github.com/users/aciidb0mb3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aciidb0mb3r/subscriptions","organizations_url":"https://api.github.com/users/aciidb0mb3r/orgs","repos_url":"https://api.github.com/users/aciidb0mb3r/repos","events_url":"https://api.github.com/users/aciidb0mb3r/events{/privacy}","received_events_url":"https://api.github.com/users/aciidb0mb3r/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206/commits","review_comments_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206/comments","review_comment_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/issues/1206/comments","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/e0299ca6bbd7a4c855fd95abebb7c216a5917e6d","head":{"label":"hartbit:argument-parser-nargs","ref":"argument-parser-nargs","sha":"e0299ca6bbd7a4c855fd95abebb7c216a5917e6d","user":{"login":"hartbit","id":325519,"avatar_url":"https://avatars2.githubusercontent.com/u/325519?v=3","gravatar_id":"","url":"https://api.github.com/users/hartbit","html_url":"https://github.com/hartbit","followers_url":"https://api.github.com/users/hartbit/followers","following_url":"https://api.github.com/users/hartbit/following{/other_user}","gists_url":"https://api.github.com/users/hartbit/gists{/gist_id}","starred_url":"https://api.github.com/users/hartbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartbit/subscriptions","organizations_url":"https://api.github.com/users/hartbit/orgs","repos_url":"https://api.github.com/users/hartbit/repos","events_url":"https://api.github.com/users/hartbit/events{/privacy}","received_events_url":"https://api.github.com/users/hartbit/received_events","type":"User","site_admin":false},"repo":{"id":80256956,"name":"swift-package-manager","full_name":"hartbit/swift-package-manager","owner":{"login":"hartbit","id":325519,"avatar_url":"https://avatars2.githubusercontent.com/u/325519?v=3","gravatar_id":"","url":"https://api.github.com/users/hartbit","html_url":"https://github.com/hartbit","followers_url":"https://api.github.com/users/hartbit/followers","following_url":"https://api.github.com/users/hartbit/following{/other_user}","gists_url":"https://api.github.com/users/hartbit/gists{/gist_id}","starred_url":"https://api.github.com/users/hartbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartbit/subscriptions","organizations_url":"https://api.github.com/users/hartbit/orgs","repos_url":"https://api.github.com/users/hartbit/repos","events_url":"https://api.github.com/users/hartbit/events{/privacy}","received_events_url":"https://api.github.com/users/hartbit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hartbit/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":true,"url":"https://api.github.com/repos/hartbit/swift-package-manager","forks_url":"https://api.github.com/repos/hartbit/swift-package-manager/forks","keys_url":"https://api.github.com/repos/hartbit/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hartbit/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hartbit/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/hartbit/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/hartbit/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/hartbit/swift-package-manager/events","assignees_url":"https://api.github.com/repos/hartbit/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/hartbit/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/hartbit/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/hartbit/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hartbit/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hartbit/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/hartbit/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hartbit/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/hartbit/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/hartbit/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/hartbit/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/hartbit/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/hartbit/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/hartbit/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/hartbit/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/hartbit/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/hartbit/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/hartbit/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/hartbit/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hartbit/swift-package-manager/merges","archive_url":"https://api.github.com/repos/hartbit/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hartbit/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/hartbit/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/hartbit/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/hartbit/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/hartbit/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hartbit/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/hartbit/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/hartbit/swift-package-manager/deployments","created_at":"2017-01-28T00:15:08Z","updated_at":"2017-01-28T00:15:10Z","pushed_at":"2017-05-25T15:10:12Z","git_url":"git://github.com/hartbit/swift-package-manager.git","ssh_url":"git@github.com:hartbit/swift-package-manager.git","clone_url":"https://github.com/hartbit/swift-package-manager.git","svn_url":"https://github.com/hartbit/swift-package-manager","homepage":"","size":5723,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"24ddb9cde6b4e7f97030872eafcab54c481882a3","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44840041,"name":"swift-package-manager","full_name":"apple/swift-package-manager","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift-package-manager","forks_url":"https://api.github.com/repos/apple/swift-package-manager/forks","keys_url":"https://api.github.com/repos/apple/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/apple/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-package-manager/events","assignees_url":"https://api.github.com/repos/apple/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/apple/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/apple/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/apple/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-package-manager/merges","archive_url":"https://api.github.com/repos/apple/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/apple/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-package-manager/deployments","created_at":"2015-10-23T21:41:12Z","updated_at":"2017-05-25T15:27:10Z","pushed_at":"2017-05-25T15:10:15Z","git_url":"git://github.com/apple/swift-package-manager.git","ssh_url":"git@github.com:apple/swift-package-manager.git","clone_url":"https://github.com/apple/swift-package-manager.git","svn_url":"https://github.com/apple/swift-package-manager","homepage":"","size":5776,"stargazers_count":5529,"watchers_count":5529,"language":"Swift","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":531,"mirror_url":null,"open_issues_count":8,"forks":531,"open_issues":8,"watchers":5529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/1206"},"issue":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/1206"},"comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/1206/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/1206/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-package-manager/statuses/e0299ca6bbd7a4c855fd95abebb7c216a5917e6d"}}}}
{"actor":{"display_login":"aciidb0mb3r"}}