{"action":"created","comment":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments/153066458","pull_request_review_id":79022836,"id":153066458,"diff_hunk":"@@ -0,0 +1,33 @@\n+import React from 'react';\n+\n+import Analyzer from 'Parser/Core/Analyzer';\n+import Wrapper from 'common/Wrapper';\n+import SPELLS from 'common/SPELLS';\n+import SpellLink from 'common/SpellLink';\n+\n+import DamageTracker from 'Parser/Core/Modules/AbilityTracker';\n+\n+import SymbolsDamageTracker from './../RogueCore/SymbolsDamageTracker';\n+\n+class NightbladeDuringSymbols extends Analyzer {\n+  static dependencies = {\n+    damageTracker: DamageTracker,\n+    symbolsDamageTracker: SymbolsDamageTracker,\n+  };\n+\n+  suggestions(when) { \n+    const total = this.damageTracker.getAbility(SPELLS.NIGHTBLADE.id);\n+    const filtered = this.symbolsDamageTracker.getAbility(SPELLS.NIGHTBLADE.id);\n+\n+    const badRefreshShare = filtered.casts / total.casts;\n+    when(badRefreshShare).isGreaterThan(0)\n+    .addSuggestion((suggest, actual, recommended) => {\n+      return suggest(<Wrapper>Do not refresh <SpellLink id={SPELLS.NIGHTBLADE.id} /> during <SpellLink id={SPELLS.SYMBOLS_OF_DEATH.id} /> - cast <SpellLink id={SPELLS.EVISCERATE.id} /> instead. You can refresh <SpellLink id={SPELLS.NIGHTBLADE.id} /> early to make sure that its up for the full duration of <SpellLink id={SPELLS.SYMBOLS_OF_DEATH.id} />. </Wrapper>)\n+        .icon(SPELLS.NIGHTBLADE.icon)\n+        .actual(`You refreshed Nightblade ${filtered.casts} times during Symbols of Death.`)\n+        .recommended(`0 is recommend.`)\n+        .regular(0.1).major(0.2);","path":"src/Parser/Rogue/Subtlety/Modules/BaseRotation/NightbladeDuringSymbols.js","position":29,"original_position":29,"commit_id":"2a6ea58a0796e02409267483a5a6ff28e189e9ec","original_commit_id":"2a6ea58a0796e02409267483a5a6ff28e189e9ec","user":{"login":"Pewtro","id":29204244,"avatar_url":"https://avatars2.githubusercontent.com/u/29204244?v=4","gravatar_id":"","url":"https://api.github.com/users/Pewtro","html_url":"https://github.com/Pewtro","followers_url":"https://api.github.com/users/Pewtro/followers","following_url":"https://api.github.com/users/Pewtro/following{/other_user}","gists_url":"https://api.github.com/users/Pewtro/gists{/gist_id}","starred_url":"https://api.github.com/users/Pewtro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pewtro/subscriptions","organizations_url":"https://api.github.com/users/Pewtro/orgs","repos_url":"https://api.github.com/users/Pewtro/repos","events_url":"https://api.github.com/users/Pewtro/events{/privacy}","received_events_url":"https://api.github.com/users/Pewtro/received_events","type":"User","site_admin":false},"body":"same as above, the recommended should be updated. ","created_at":"2017-11-26T11:02:09Z","updated_at":"2017-11-26T11:17:11Z","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/873#discussion_r153066458","pull_request_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments/153066458"},"html":{"href":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/873#discussion_r153066458"},"pull_request":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873"}}},"pull_request":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873","id":154650911,"html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/873","diff_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/873.diff","patch_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/873.patch","issue_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/873","number":873,"state":"open","locked":false,"title":"Sub Rogue - Base Rotation improvements","user":{"login":"TsaboTavok","id":9116609,"avatar_url":"https://avatars3.githubusercontent.com/u/9116609?v=4","gravatar_id":"","url":"https://api.github.com/users/TsaboTavok","html_url":"https://github.com/TsaboTavok","followers_url":"https://api.github.com/users/TsaboTavok/followers","following_url":"https://api.github.com/users/TsaboTavok/following{/other_user}","gists_url":"https://api.github.com/users/TsaboTavok/gists{/gist_id}","starred_url":"https://api.github.com/users/TsaboTavok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsaboTavok/subscriptions","organizations_url":"https://api.github.com/users/TsaboTavok/orgs","repos_url":"https://api.github.com/users/TsaboTavok/repos","events_url":"https://api.github.com/users/TsaboTavok/events{/privacy}","received_events_url":"https://api.github.com/users/TsaboTavok/received_events","type":"User","site_admin":false},"body":"Created some of the most important Sub Rogue analysis for the base rotation. \r\nRefactored a lot of the existing Sub code to use Ability Tracker from core.","created_at":"2017-11-25T20:11:31Z","updated_at":"2017-11-26T11:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"511f24fbbc46a9bcf5726f9222c8ea66cd4e0cbe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873/commits","review_comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873/comments","review_comment_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/873/comments","statuses_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/statuses/2a6ea58a0796e02409267483a5a6ff28e189e9ec","head":{"label":"TsaboTavok:sub/dance_casts","ref":"sub/dance_casts","sha":"2a6ea58a0796e02409267483a5a6ff28e189e9ec","user":{"login":"TsaboTavok","id":9116609,"avatar_url":"https://avatars3.githubusercontent.com/u/9116609?v=4","gravatar_id":"","url":"https://api.github.com/users/TsaboTavok","html_url":"https://github.com/TsaboTavok","followers_url":"https://api.github.com/users/TsaboTavok/followers","following_url":"https://api.github.com/users/TsaboTavok/following{/other_user}","gists_url":"https://api.github.com/users/TsaboTavok/gists{/gist_id}","starred_url":"https://api.github.com/users/TsaboTavok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsaboTavok/subscriptions","organizations_url":"https://api.github.com/users/TsaboTavok/orgs","repos_url":"https://api.github.com/users/TsaboTavok/repos","events_url":"https://api.github.com/users/TsaboTavok/events{/privacy}","received_events_url":"https://api.github.com/users/TsaboTavok/received_events","type":"User","site_admin":false},"repo":{"id":111231924,"name":"WoWAnalyzer","full_name":"TsaboTavok/WoWAnalyzer","owner":{"login":"TsaboTavok","id":9116609,"avatar_url":"https://avatars3.githubusercontent.com/u/9116609?v=4","gravatar_id":"","url":"https://api.github.com/users/TsaboTavok","html_url":"https://github.com/TsaboTavok","followers_url":"https://api.github.com/users/TsaboTavok/followers","following_url":"https://api.github.com/users/TsaboTavok/following{/other_user}","gists_url":"https://api.github.com/users/TsaboTavok/gists{/gist_id}","starred_url":"https://api.github.com/users/TsaboTavok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsaboTavok/subscriptions","organizations_url":"https://api.github.com/users/TsaboTavok/orgs","repos_url":"https://api.github.com/users/TsaboTavok/repos","events_url":"https://api.github.com/users/TsaboTavok/events{/privacy}","received_events_url":"https://api.github.com/users/TsaboTavok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TsaboTavok/WoWAnalyzer","description":"WoW Analyzer is a comprehensive tool for analyzing your performance based on important metrics for your spec using a Warcraft Logs report. Built by community contributors; PRs welcome!","fork":true,"url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer","forks_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/forks","keys_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/teams","hooks_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/events","assignees_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/tags","blobs_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/languages","stargazers_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/subscription","commits_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/merges","archive_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/downloads","issues_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/TsaboTavok/WoWAnalyzer/deployments","created_at":"2017-11-18T19:12:02Z","updated_at":"2017-11-18T19:12:06Z","pushed_at":"2017-11-26T00:53:08Z","git_url":"git://github.com/TsaboTavok/WoWAnalyzer.git","ssh_url":"git@github.com:TsaboTavok/WoWAnalyzer.git","clone_url":"https://github.com/TsaboTavok/WoWAnalyzer.git","svn_url":"https://github.com/TsaboTavok/WoWAnalyzer","homepage":"http://wowanalyzer.com/","size":59347,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WoWAnalyzer:master","ref":"master","sha":"295e39626011006363b0638acae71bc7f5a0e446","user":{"login":"WoWAnalyzer","id":32273378,"avatar_url":"https://avatars2.githubusercontent.com/u/32273378?v=4","gravatar_id":"","url":"https://api.github.com/users/WoWAnalyzer","html_url":"https://github.com/WoWAnalyzer","followers_url":"https://api.github.com/users/WoWAnalyzer/followers","following_url":"https://api.github.com/users/WoWAnalyzer/following{/other_user}","gists_url":"https://api.github.com/users/WoWAnalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/WoWAnalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WoWAnalyzer/subscriptions","organizations_url":"https://api.github.com/users/WoWAnalyzer/orgs","repos_url":"https://api.github.com/users/WoWAnalyzer/repos","events_url":"https://api.github.com/users/WoWAnalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/WoWAnalyzer/received_events","type":"Organization","site_admin":false},"repo":{"id":80472692,"name":"WoWAnalyzer","full_name":"WoWAnalyzer/WoWAnalyzer","owner":{"login":"WoWAnalyzer","id":32273378,"avatar_url":"https://avatars2.githubusercontent.com/u/32273378?v=4","gravatar_id":"","url":"https://api.github.com/users/WoWAnalyzer","html_url":"https://github.com/WoWAnalyzer","followers_url":"https://api.github.com/users/WoWAnalyzer/followers","following_url":"https://api.github.com/users/WoWAnalyzer/following{/other_user}","gists_url":"https://api.github.com/users/WoWAnalyzer/gists{/gist_id}","starred_url":"https://api.github.com/users/WoWAnalyzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WoWAnalyzer/subscriptions","organizations_url":"https://api.github.com/users/WoWAnalyzer/orgs","repos_url":"https://api.github.com/users/WoWAnalyzer/repos","events_url":"https://api.github.com/users/WoWAnalyzer/events{/privacy}","received_events_url":"https://api.github.com/users/WoWAnalyzer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer","description":"WoW Analyzer is a comprehensive tool for analyzing your performance based on important metrics for your spec using a Warcraft Logs report. Built by community contributors; PRs welcome!","fork":false,"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer","forks_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/forks","keys_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/teams","hooks_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/events","assignees_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/tags","blobs_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/languages","stargazers_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/subscription","commits_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/merges","archive_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/downloads","issues_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/deployments","created_at":"2017-01-30T23:02:17Z","updated_at":"2017-11-25T12:43:30Z","pushed_at":"2017-11-26T00:54:19Z","git_url":"git://github.com/WoWAnalyzer/WoWAnalyzer.git","ssh_url":"git@github.com:WoWAnalyzer/WoWAnalyzer.git","clone_url":"https://github.com/WoWAnalyzer/WoWAnalyzer.git","svn_url":"https://github.com/WoWAnalyzer/WoWAnalyzer","homepage":"http://wowanalyzer.com/","size":59330,"stargazers_count":73,"watchers_count":73,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":113,"forks":119,"open_issues":113,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873"},"html":{"href":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/873"},"issue":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/873"},"comments":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/873/comments"},"review_comments":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873/comments"},"review_comment":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/873/commits"},"statuses":{"href":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/statuses/2a6ea58a0796e02409267483a5a6ff28e189e9ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Pewtro"}}