{"action":"closed","number":20997,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/20997","id":152985716,"html_url":"https://github.com/odoo/odoo/pull/20997","diff_url":"https://github.com/odoo/odoo/pull/20997.diff","patch_url":"https://github.com/odoo/odoo/pull/20997.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/20997","number":20997,"state":"closed","locked":false,"title":"[FIX] Show filename during the selection of a file into a binary field…","user":{"login":"JonathanNEMRY","id":7601731,"avatar_url":"https://avatars1.githubusercontent.com/u/7601731?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanNEMRY","html_url":"https://github.com/JonathanNEMRY","followers_url":"https://api.github.com/users/JonathanNEMRY/followers","following_url":"https://api.github.com/users/JonathanNEMRY/following{/other_user}","gists_url":"https://api.github.com/users/JonathanNEMRY/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanNEMRY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanNEMRY/subscriptions","organizations_url":"https://api.github.com/users/JonathanNEMRY/orgs","repos_url":"https://api.github.com/users/JonathanNEMRY/repos","events_url":"https://api.github.com/users/JonathanNEMRY/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanNEMRY/received_events","type":"User","site_admin":false},"body":"… associated with a filename field.\r\nBefore this fix it was a binary value content that was showned to the user. The BUG was able during the selection of the file but correctly set after the save (the datarecord is correct after a save..but not during the selection so I use the same computation than the ```set_filename``` (maybe better possibility)  So the bug was critical for exemple into a wizard having a binary field)\r\n\r\nCurrent behavior before PR:\r\n\r\n![selection_012](https://user-images.githubusercontent.com/7601731/32882905-1004be54-cab6-11e7-9211-dfddf6288182.png)\r\n\r\n\r\nDesired behavior after PR is merged:\r\n\r\n![selection_011](https://user-images.githubusercontent.com/7601731/32882834-e11db622-cab5-11e7-90aa-a973a1848acd.png)\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2017-11-16T09:11:09Z","updated_at":"2017-11-27T08:40:19Z","closed_at":"2017-11-27T08:40:19Z","merged_at":null,"merge_commit_sha":"2b3f1d791b3fa97a26c6fb9238862bc2a888889a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/20997/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/20997/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/20997/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/a928d7686fe469fc7b8fb2f7cd07c0c23fbadd65","head":{"label":"resultrum:10.0-fix_filename_binary_file-jne","ref":"10.0-fix_filename_binary_file-jne","sha":"a928d7686fe469fc7b8fb2f7cd07c0c23fbadd65","user":{"login":"resultrum","id":22870641,"avatar_url":"https://avatars3.githubusercontent.com/u/22870641?v=4","gravatar_id":"","url":"https://api.github.com/users/resultrum","html_url":"https://github.com/resultrum","followers_url":"https://api.github.com/users/resultrum/followers","following_url":"https://api.github.com/users/resultrum/following{/other_user}","gists_url":"https://api.github.com/users/resultrum/gists{/gist_id}","starred_url":"https://api.github.com/users/resultrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resultrum/subscriptions","organizations_url":"https://api.github.com/users/resultrum/orgs","repos_url":"https://api.github.com/users/resultrum/repos","events_url":"https://api.github.com/users/resultrum/events{/privacy}","received_events_url":"https://api.github.com/users/resultrum/received_events","type":"Organization","site_admin":false},"repo":{"id":99780710,"name":"odoo","full_name":"resultrum/odoo","owner":{"login":"resultrum","id":22870641,"avatar_url":"https://avatars3.githubusercontent.com/u/22870641?v=4","gravatar_id":"","url":"https://api.github.com/users/resultrum","html_url":"https://github.com/resultrum","followers_url":"https://api.github.com/users/resultrum/followers","following_url":"https://api.github.com/users/resultrum/following{/other_user}","gists_url":"https://api.github.com/users/resultrum/gists{/gist_id}","starred_url":"https://api.github.com/users/resultrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resultrum/subscriptions","organizations_url":"https://api.github.com/users/resultrum/orgs","repos_url":"https://api.github.com/users/resultrum/repos","events_url":"https://api.github.com/users/resultrum/events{/privacy}","received_events_url":"https://api.github.com/users/resultrum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resultrum/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":true,"url":"https://api.github.com/repos/resultrum/odoo","forks_url":"https://api.github.com/repos/resultrum/odoo/forks","keys_url":"https://api.github.com/repos/resultrum/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resultrum/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resultrum/odoo/teams","hooks_url":"https://api.github.com/repos/resultrum/odoo/hooks","issue_events_url":"https://api.github.com/repos/resultrum/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/resultrum/odoo/events","assignees_url":"https://api.github.com/repos/resultrum/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/resultrum/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/resultrum/odoo/tags","blobs_url":"https://api.github.com/repos/resultrum/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resultrum/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resultrum/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/resultrum/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resultrum/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/resultrum/odoo/languages","stargazers_url":"https://api.github.com/repos/resultrum/odoo/stargazers","contributors_url":"https://api.github.com/repos/resultrum/odoo/contributors","subscribers_url":"https://api.github.com/repos/resultrum/odoo/subscribers","subscription_url":"https://api.github.com/repos/resultrum/odoo/subscription","commits_url":"https://api.github.com/repos/resultrum/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/resultrum/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/resultrum/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/resultrum/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/resultrum/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/resultrum/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resultrum/odoo/merges","archive_url":"https://api.github.com/repos/resultrum/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resultrum/odoo/downloads","issues_url":"https://api.github.com/repos/resultrum/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/resultrum/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/resultrum/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/resultrum/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resultrum/odoo/labels{/name}","releases_url":"https://api.github.com/repos/resultrum/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/resultrum/odoo/deployments","created_at":"2017-08-09T07:54:29Z","updated_at":"2017-08-28T07:18:34Z","pushed_at":"2017-11-16T09:57:37Z","git_url":"git://github.com/resultrum/odoo.git","ssh_url":"git@github.com:resultrum/odoo.git","clone_url":"https://github.com/resultrum/odoo.git","svn_url":"https://github.com/resultrum/odoo","homepage":"https://www.odoo.com","size":1811325,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.0"}},"base":{"label":"odoo:10.0","ref":"10.0","sha":"d8e49d3886ab7c5443b9173bd9b3e45e05b72c6c","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2017-11-27T08:39:21Z","pushed_at":"2017-11-27T08:39:30Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1862114,"stargazers_count":8093,"watchers_count":8093,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7160,"mirror_url":null,"archived":false,"open_issues_count":3566,"forks":7160,"open_issues":3566,"watchers":8093,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/20997"},"html":{"href":"https://github.com/odoo/odoo/pull/20997"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/20997"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/20997/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/20997/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/20997/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/a928d7686fe469fc7b8fb2f7cd07c0c23fbadd65"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"aab-odoo"}}