{"action":"created","comment":{"url":"https://api.github.com/repos/concord-consortium/codap/pulls/comments/148324782","pull_request_review_id":73549278,"id":148324782,"diff_hunk":"@@ -186,8 +186,18 @@ return {\n    */\n   childrenOfParent: function( iIndex) {\n     var tParents = this.get('parentCases' ),\n-        tParent = (iIndex < tParents.length) ? tParents[ iIndex] : null;\n-    return tParent ? tParent.get('children' ).flatten() : [];\n+        tParent = (iIndex < tParents.length) ? tParents[ iIndex] : null,\n+        tChildren = tParent ? tParent.get('children') : [];\n+    for (var i = 0; i < tChildren.get('length'); ++i) {","path":"apps/dg/components/graph/plots/number_toggle_model.js","position":8,"original_position":8,"commit_id":"f692ca2f778d7408a8a44190a726f5d1e7a0a567","original_commit_id":"f692ca2f778d7408a8a44190a726f5d1e7a0a567","user":{"login":"kswenson","id":235234,"avatar_url":"https://avatars0.githubusercontent.com/u/235234?v=4","gravatar_id":"","url":"https://api.github.com/users/kswenson","html_url":"https://github.com/kswenson","followers_url":"https://api.github.com/users/kswenson/followers","following_url":"https://api.github.com/users/kswenson/following{/other_user}","gists_url":"https://api.github.com/users/kswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/kswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kswenson/subscriptions","organizations_url":"https://api.github.com/users/kswenson/orgs","repos_url":"https://api.github.com/users/kswenson/repos","events_url":"https://api.github.com/users/kswenson/events{/privacy}","received_events_url":"https://api.github.com/users/kswenson/received_events","type":"User","site_admin":false},"body":"`tChildren` is modified inside the loop to achieve the recursive behavior. The behavior of `forEach` is not clear under these circumstances. Your comment points out the need for a comment to that effect, which I will add momentarily.","created_at":"2017-11-01T17:19:22Z","updated_at":"2017-11-01T17:19:22Z","html_url":"https://github.com/concord-consortium/codap/pull/210#discussion_r148324782","pull_request_url":"https://api.github.com/repos/concord-consortium/codap/pulls/210","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/codap/pulls/comments/148324782"},"html":{"href":"https://github.com/concord-consortium/codap/pull/210#discussion_r148324782"},"pull_request":{"href":"https://api.github.com/repos/concord-consortium/codap/pulls/210"}},"in_reply_to_id":148321457},"pull_request":{"url":"https://api.github.com/repos/concord-consortium/codap/pulls/210","id":149931031,"html_url":"https://github.com/concord-consortium/codap/pull/210","diff_url":"https://github.com/concord-consortium/codap/pull/210.diff","patch_url":"https://github.com/concord-consortium/codap/pull/210.patch","issue_url":"https://api.github.com/repos/concord-consortium/codap/issues/210","number":210,"state":"open","locked":false,"title":"Fix number toggle bugs","user":{"login":"kswenson","id":235234,"avatar_url":"https://avatars0.githubusercontent.com/u/235234?v=4","gravatar_id":"","url":"https://api.github.com/users/kswenson","html_url":"https://github.com/kswenson","followers_url":"https://api.github.com/users/kswenson/followers","following_url":"https://api.github.com/users/kswenson/following{/other_user}","gists_url":"https://api.github.com/users/kswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/kswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kswenson/subscriptions","organizations_url":"https://api.github.com/users/kswenson/orgs","repos_url":"https://api.github.com/users/kswenson/repos","events_url":"https://api.github.com/users/kswenson/events{/privacy}","received_events_url":"https://api.github.com/users/kswenson/received_events","type":"User","site_admin":false},"body":"- Fix bugs in handling of 3+ level hierarchies [#152368313]\r\n- Fix bug in handling changes to number toggle label value [#152368622]\r\n","created_at":"2017-10-31T23:24:03Z","updated_at":"2017-11-01T17:19:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d931231c73d8036ca6b149b623326d987202b7bb","assignee":{"login":"bfinzer","id":5677183,"avatar_url":"https://avatars3.githubusercontent.com/u/5677183?v=4","gravatar_id":"","url":"https://api.github.com/users/bfinzer","html_url":"https://github.com/bfinzer","followers_url":"https://api.github.com/users/bfinzer/followers","following_url":"https://api.github.com/users/bfinzer/following{/other_user}","gists_url":"https://api.github.com/users/bfinzer/gists{/gist_id}","starred_url":"https://api.github.com/users/bfinzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfinzer/subscriptions","organizations_url":"https://api.github.com/users/bfinzer/orgs","repos_url":"https://api.github.com/users/bfinzer/repos","events_url":"https://api.github.com/users/bfinzer/events{/privacy}","received_events_url":"https://api.github.com/users/bfinzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"bfinzer","id":5677183,"avatar_url":"https://avatars3.githubusercontent.com/u/5677183?v=4","gravatar_id":"","url":"https://api.github.com/users/bfinzer","html_url":"https://github.com/bfinzer","followers_url":"https://api.github.com/users/bfinzer/followers","following_url":"https://api.github.com/users/bfinzer/following{/other_user}","gists_url":"https://api.github.com/users/bfinzer/gists{/gist_id}","starred_url":"https://api.github.com/users/bfinzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfinzer/subscriptions","organizations_url":"https://api.github.com/users/bfinzer/orgs","repos_url":"https://api.github.com/users/bfinzer/repos","events_url":"https://api.github.com/users/bfinzer/events{/privacy}","received_events_url":"https://api.github.com/users/bfinzer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/concord-consortium/codap/pulls/210/commits","review_comments_url":"https://api.github.com/repos/concord-consortium/codap/pulls/210/comments","review_comment_url":"https://api.github.com/repos/concord-consortium/codap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concord-consortium/codap/issues/210/comments","statuses_url":"https://api.github.com/repos/concord-consortium/codap/statuses/f692ca2f778d7408a8a44190a726f5d1e7a0a567","head":{"label":"concord-consortium:fix-number-toggle-bugs","ref":"fix-number-toggle-bugs","sha":"f692ca2f778d7408a8a44190a726f5d1e7a0a567","user":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":13509707,"name":"codap","full_name":"concord-consortium/codap","owner":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/codap","description":"CODAP (Common Online Data Analysis Platform)","fork":false,"url":"https://api.github.com/repos/concord-consortium/codap","forks_url":"https://api.github.com/repos/concord-consortium/codap/forks","keys_url":"https://api.github.com/repos/concord-consortium/codap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/codap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/codap/teams","hooks_url":"https://api.github.com/repos/concord-consortium/codap/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/codap/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/codap/events","assignees_url":"https://api.github.com/repos/concord-consortium/codap/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/codap/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/codap/tags","blobs_url":"https://api.github.com/repos/concord-consortium/codap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/codap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/codap/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/codap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/codap/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/codap/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/codap/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/codap/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/codap/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/codap/subscription","commits_url":"https://api.github.com/repos/concord-consortium/codap/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/codap/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/codap/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/codap/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/codap/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/codap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/codap/merges","archive_url":"https://api.github.com/repos/concord-consortium/codap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/codap/downloads","issues_url":"https://api.github.com/repos/concord-consortium/codap/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/codap/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/codap/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/codap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/codap/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/codap/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/codap/deployments","created_at":"2013-10-11T21:07:15Z","updated_at":"2017-07-03T12:27:08Z","pushed_at":"2017-11-01T16:50:26Z","git_url":"git://github.com/concord-consortium/codap.git","ssh_url":"git@github.com:concord-consortium/codap.git","clone_url":"https://github.com/concord-consortium/codap.git","svn_url":"https://github.com/concord-consortium/codap","homepage":null,"size":13403,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":31,"default_branch":"master"}},"base":{"label":"concord-consortium:master","ref":"master","sha":"2b4e36e33b1845f81f1ea87010a1094443bf391a","user":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":13509707,"name":"codap","full_name":"concord-consortium/codap","owner":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/codap","description":"CODAP (Common Online Data Analysis Platform)","fork":false,"url":"https://api.github.com/repos/concord-consortium/codap","forks_url":"https://api.github.com/repos/concord-consortium/codap/forks","keys_url":"https://api.github.com/repos/concord-consortium/codap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/codap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/codap/teams","hooks_url":"https://api.github.com/repos/concord-consortium/codap/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/codap/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/codap/events","assignees_url":"https://api.github.com/repos/concord-consortium/codap/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/codap/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/codap/tags","blobs_url":"https://api.github.com/repos/concord-consortium/codap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/codap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/codap/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/codap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/codap/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/codap/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/codap/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/codap/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/codap/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/codap/subscription","commits_url":"https://api.github.com/repos/concord-consortium/codap/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/codap/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/codap/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/codap/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/codap/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/codap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/codap/merges","archive_url":"https://api.github.com/repos/concord-consortium/codap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/codap/downloads","issues_url":"https://api.github.com/repos/concord-consortium/codap/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/codap/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/codap/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/codap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/codap/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/codap/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/codap/deployments","created_at":"2013-10-11T21:07:15Z","updated_at":"2017-07-03T12:27:08Z","pushed_at":"2017-11-01T16:50:26Z","git_url":"git://github.com/concord-consortium/codap.git","ssh_url":"git@github.com:concord-consortium/codap.git","clone_url":"https://github.com/concord-consortium/codap.git","svn_url":"https://github.com/concord-consortium/codap","homepage":null,"size":13403,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/codap/pulls/210"},"html":{"href":"https://github.com/concord-consortium/codap/pull/210"},"issue":{"href":"https://api.github.com/repos/concord-consortium/codap/issues/210"},"comments":{"href":"https://api.github.com/repos/concord-consortium/codap/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/concord-consortium/codap/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/concord-consortium/codap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concord-consortium/codap/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/concord-consortium/codap/statuses/f692ca2f778d7408a8a44190a726f5d1e7a0a567"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kswenson"}}