{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/114613179","pull_request_review_id":36094755,"id":114613179,"diff_hunk":"@@ -153,31 +151,38 @@ abstract class FlutterCommand extends Command<Null> {\n     if (flutterUsage.isFirstRun)\n       flutterUsage.printWelcome();\n \n-    final FlutterCommandResult commandResult = await verifyThenRunCommand();\n-\n-    final DateTime endTime = clock.now();\n-    printTrace(\"'flutter $name' took ${getElapsedAsMilliseconds(endTime.difference(startTime))}.\");\n-    if (usagePath != null) {\n-      final List<String> labels = <String>[];\n-      if (commandResult?.exitStatus != null)\n-        labels.add(getEnumName(commandResult.exitStatus));\n-      if (commandResult?.analyticsParameters?.isNotEmpty ?? false)\n-        labels.addAll(commandResult.analyticsParameters);\n-\n-      final String label = labels\n-          .where((String label) => !isBlank(label))\n-          .join('-');\n-      flutterUsage.sendTiming(\n-        'flutter', \n-        name, \n-        // If the command provides its own end time, use it. Otherwise report\n-        // the duration of the entire execution.\n-        (commandResult?.endTimeOverride ?? endTime).difference(startTime), \n-        // Report in the form of `success-[parameter1-parameter2]`, all of which\n-        // can be null if the command doesn't provide a FlutterCommandResult.\n-        label: label == '' ? null : label,\n-      );\n+    FlutterCommandResult commandResult;\n+    try {\n+      commandResult = await verifyThenRunCommand();\n+    } on ToolExit catch (_) {","path":"packages/flutter_tools/lib/src/runner/flutter_command.dart","position":47,"original_position":47,"commit_id":"dd2a691ac02c8d23d2d5adc2265b79c48f6d70d5","original_commit_id":"dd2a691ac02c8d23d2d5adc2265b79c48f6d70d5","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars1.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"you can remove the `catch (_)` part","created_at":"2017-05-03T18:04:16Z","updated_at":"2017-05-03T18:04:17Z","html_url":"https://github.com/flutter/flutter/pull/9661#discussion_r114613179","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/9661","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/114613179"},"html":{"href":"https://github.com/flutter/flutter/pull/9661#discussion_r114613179"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9661"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/9661","id":118056498,"html_url":"https://github.com/flutter/flutter/pull/9661","diff_url":"https://github.com/flutter/flutter/pull/9661.diff","patch_url":"https://github.com/flutter/flutter/pull/9661.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/9661","number":9661,"state":"open","locked":false,"title":"Report timing on failed executions too","user":{"login":"xster","id":156888,"avatar_url":"https://avatars1.githubusercontent.com/u/156888?v=3","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"body":"#9499","created_at":"2017-04-28T00:03:21Z","updated_at":"2017-05-03T18:04:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99a208b45dffba826d3fd39b4295e421d63955b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/9661/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/9661/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/9661/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/dd2a691ac02c8d23d2d5adc2265b79c48f6d70d5","head":{"label":"xster:analytics","ref":"analytics","sha":"dd2a691ac02c8d23d2d5adc2265b79c48f6d70d5","user":{"login":"xster","id":156888,"avatar_url":"https://avatars1.githubusercontent.com/u/156888?v=3","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"repo":{"id":79845855,"name":"flutter","full_name":"xster/flutter","owner":{"login":"xster","id":156888,"avatar_url":"https://avatars1.githubusercontent.com/u/156888?v=3","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xster/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/xster/flutter","forks_url":"https://api.github.com/repos/xster/flutter/forks","keys_url":"https://api.github.com/repos/xster/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xster/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xster/flutter/teams","hooks_url":"https://api.github.com/repos/xster/flutter/hooks","issue_events_url":"https://api.github.com/repos/xster/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/xster/flutter/events","assignees_url":"https://api.github.com/repos/xster/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/xster/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/xster/flutter/tags","blobs_url":"https://api.github.com/repos/xster/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xster/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xster/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/xster/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xster/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/xster/flutter/languages","stargazers_url":"https://api.github.com/repos/xster/flutter/stargazers","contributors_url":"https://api.github.com/repos/xster/flutter/contributors","subscribers_url":"https://api.github.com/repos/xster/flutter/subscribers","subscription_url":"https://api.github.com/repos/xster/flutter/subscription","commits_url":"https://api.github.com/repos/xster/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/xster/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/xster/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/xster/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/xster/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/xster/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xster/flutter/merges","archive_url":"https://api.github.com/repos/xster/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xster/flutter/downloads","issues_url":"https://api.github.com/repos/xster/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/xster/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/xster/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/xster/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xster/flutter/labels{/name}","releases_url":"https://api.github.com/repos/xster/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/xster/flutter/deployments","created_at":"2017-01-23T20:41:37Z","updated_at":"2017-01-23T20:41:42Z","pushed_at":"2017-05-03T05:20:17Z","git_url":"git://github.com/xster/flutter.git","ssh_url":"git@github.com:xster/flutter.git","clone_url":"https://github.com/xster/flutter.git","svn_url":"https://github.com/xster/flutter","homepage":"https://flutter.io","size":26200,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"9da22bd92fc2b218f615a593ea602664ba8be346","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-05-03T15:50:29Z","pushed_at":"2017-05-03T17:55:46Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":26232,"stargazers_count":4326,"watchers_count":4326,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":468,"mirror_url":null,"open_issues_count":1428,"forks":468,"open_issues":1428,"watchers":4326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9661"},"html":{"href":"https://github.com/flutter/flutter/pull/9661"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/9661"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/9661/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9661/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9661/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/dd2a691ac02c8d23d2d5adc2265b79c48f6d70d5"}}}}
{"actor":{"display_login":"Hixie"}}