{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48505","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48505/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48505/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48505/events","html_url":"https://github.com/kubernetes/kubernetes/pull/48505","id":240702408,"number":48505,"title":"Add Containers and InitContainers to PodPresets, #43874","user":{"login":"krallistic","id":1194712,"avatar_url":"https://avatars0.githubusercontent.com/u/1194712?v=3","gravatar_id":"","url":"https://api.github.com/users/krallistic","html_url":"https://github.com/krallistic","followers_url":"https://api.github.com/users/krallistic/followers","following_url":"https://api.github.com/users/krallistic/following{/other_user}","gists_url":"https://api.github.com/users/krallistic/gists{/gist_id}","starred_url":"https://api.github.com/users/krallistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krallistic/subscriptions","organizations_url":"https://api.github.com/users/krallistic/orgs","repos_url":"https://api.github.com/users/krallistic/repos","events_url":"https://api.github.com/users/krallistic/events{/privacy}","received_events_url":"https://api.github.com/users/krallistic/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":404091735,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":357119284,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/auth","name":"sig/auth","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars1.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"assignees":[{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars1.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars2.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2017-07-05T16:12:47Z","updated_at":"2017-07-08T20:05:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/48505","html_url":"https://github.com/kubernetes/kubernetes/pull/48505","diff_url":"https://github.com/kubernetes/kubernetes/pull/48505.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/48505.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAdds Containers and InitContainers to PodPresets. One use case would be Istio were a sidecar proxy is injected into every pod\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\nFixes #43874\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nAdds ability to define Containers and InitContainers inside PodPresets\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/313878124","html_url":"https://github.com/kubernetes/kubernetes/pull/48505#issuecomment-313878124","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48505","id":313878124,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars3.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-07-08T20:05:15Z","updated_at":"2017-07-08T20:05:15Z","body":"@krallistic: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-federation-e2e-gce | d64e0d6a04001f3f9dff29ffe4d371d7cf1c5fdb | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48505/pull-kubernetes-federation-e2e-gce/13681/) | `/test pull-kubernetes-federation-e2e-gce`\npull-kubernetes-node-e2e | d64e0d6a04001f3f9dff29ffe4d371d7cf1c5fdb | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48505/pull-kubernetes-node-e2e/38539/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-kubemark-e2e-gce | d64e0d6a04001f3f9dff29ffe4d371d7cf1c5fdb | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48505/pull-kubernetes-kubemark-e2e-gce/38573/) | `/test pull-kubernetes-kubemark-e2e-gce`\npull-kubernetes-e2e-kops-aws | d64e0d6a04001f3f9dff29ffe4d371d7cf1c5fdb | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48505/pull-kubernetes-e2e-kops-aws/33848/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-unit | d64e0d6a04001f3f9dff29ffe4d371d7cf1c5fdb | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48505/pull-kubernetes-unit/39659/) | `/test pull-kubernetes-unit`\npull-kubernetes-bazel | d64e0d6a04001f3f9dff29ffe4d371d7cf1c5fdb | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48505/pull-kubernetes-bazel/29322/) | `/test pull-kubernetes-bazel`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/48505). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/krallistic). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}