{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/95341174","pull_request_review_id":15891468,"id":95341174,"diff_hunk":"@@ -387,7 +391,16 @@ class Provider(object):\n     \"\"\"Represent a single provider.\"\"\"\n \n     hass = None\n-    language = None\n+\n+    @property\n+    def language(self):\n+        \"\"\"Default language.\"\"\"\n+        return None\n+\n+    @property\n+    def supported_languages(self):\n+        \"\"\"List of supported languages.\"\"\"\n+        return None","path":"homeassistant/components/tts/__init__.py","position":42,"original_position":42,"commit_id":"95059235660ac6c29923674d7bb2b1a6c4b0795d","original_commit_id":"95059235660ac6c29923674d7bb2b1a6c4b0795d","user":{"login":"andrey-git","id":5478779,"avatar_url":"https://avatars.githubusercontent.com/u/5478779?v=3","gravatar_id":"","url":"https://api.github.com/users/andrey-git","html_url":"https://github.com/andrey-git","followers_url":"https://api.github.com/users/andrey-git/followers","following_url":"https://api.github.com/users/andrey-git/following{/other_user}","gists_url":"https://api.github.com/users/andrey-git/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-git/subscriptions","organizations_url":"https://api.github.com/users/andrey-git/orgs","repos_url":"https://api.github.com/users/andrey-git/repos","events_url":"https://api.github.com/users/andrey-git/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-git/received_events","type":"User","site_admin":false},"body":"The return type must be iterable for `if language_key not in provider.supported_languages`.\r\nMaybe `return []` ?","created_at":"2017-01-10T10:58:08Z","updated_at":"2017-01-10T11:02:43Z","html_url":"https://github.com/home-assistant/home-assistant/pull/5255#discussion_r95341174","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/95341174"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/5255#discussion_r95341174"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255","id":100846224,"html_url":"https://github.com/home-assistant/home-assistant/pull/5255","diff_url":"https://github.com/home-assistant/home-assistant/pull/5255.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/5255.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/5255","number":5255,"state":"open","locked":false,"title":"Cleanup language support on TTS","user":{"login":"pvizeli","id":15338540,"avatar_url":"https://avatars.githubusercontent.com/u/15338540?v=3","gravatar_id":"","url":"https://api.github.com/users/pvizeli","html_url":"https://github.com/pvizeli","followers_url":"https://api.github.com/users/pvizeli/followers","following_url":"https://api.github.com/users/pvizeli/following{/other_user}","gists_url":"https://api.github.com/users/pvizeli/gists{/gist_id}","starred_url":"https://api.github.com/users/pvizeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvizeli/subscriptions","organizations_url":"https://api.github.com/users/pvizeli/orgs","repos_url":"https://api.github.com/users/pvizeli/repos","events_url":"https://api.github.com/users/pvizeli/events{/privacy}","received_events_url":"https://api.github.com/users/pvizeli/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n\r\nAfter we support language also on service call, I make a small refactory of language support for future. Now it is also possible to check language on service call and  protect cache System for produce not correct files.\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51\r\n","created_at":"2017-01-10T10:26:37Z","updated_at":"2017-01-10T11:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88b0fd14e5c503233788bc4f484252897bbe373a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/home-assistant/home-assistant/milestones/37","html_url":"https://github.com/home-assistant/home-assistant/milestone/37","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones/37/labels","id":2224926,"number":37,"title":"0.36","description":null,"creator":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2017-01-03T12:11:27Z","updated_at":"2017-01-10T10:26:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/5255/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/95059235660ac6c29923674d7bb2b1a6c4b0795d","head":{"label":"pvizeli:fix_language_service_tts","ref":"fix_language_service_tts","sha":"95059235660ac6c29923674d7bb2b1a6c4b0795d","user":{"login":"pvizeli","id":15338540,"avatar_url":"https://avatars.githubusercontent.com/u/15338540?v=3","gravatar_id":"","url":"https://api.github.com/users/pvizeli","html_url":"https://github.com/pvizeli","followers_url":"https://api.github.com/users/pvizeli/followers","following_url":"https://api.github.com/users/pvizeli/following{/other_user}","gists_url":"https://api.github.com/users/pvizeli/gists{/gist_id}","starred_url":"https://api.github.com/users/pvizeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvizeli/subscriptions","organizations_url":"https://api.github.com/users/pvizeli/orgs","repos_url":"https://api.github.com/users/pvizeli/repos","events_url":"https://api.github.com/users/pvizeli/events{/privacy}","received_events_url":"https://api.github.com/users/pvizeli/received_events","type":"User","site_admin":false},"repo":{"id":63844094,"name":"home-assistant","full_name":"pvizeli/home-assistant","owner":{"login":"pvizeli","id":15338540,"avatar_url":"https://avatars.githubusercontent.com/u/15338540?v=3","gravatar_id":"","url":"https://api.github.com/users/pvizeli","html_url":"https://github.com/pvizeli","followers_url":"https://api.github.com/users/pvizeli/followers","following_url":"https://api.github.com/users/pvizeli/following{/other_user}","gists_url":"https://api.github.com/users/pvizeli/gists{/gist_id}","starred_url":"https://api.github.com/users/pvizeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvizeli/subscriptions","organizations_url":"https://api.github.com/users/pvizeli/orgs","repos_url":"https://api.github.com/users/pvizeli/repos","events_url":"https://api.github.com/users/pvizeli/events{/privacy}","received_events_url":"https://api.github.com/users/pvizeli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvizeli/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/pvizeli/home-assistant","forks_url":"https://api.github.com/repos/pvizeli/home-assistant/forks","keys_url":"https://api.github.com/repos/pvizeli/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvizeli/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvizeli/home-assistant/teams","hooks_url":"https://api.github.com/repos/pvizeli/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/pvizeli/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/pvizeli/home-assistant/events","assignees_url":"https://api.github.com/repos/pvizeli/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/pvizeli/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/pvizeli/home-assistant/tags","blobs_url":"https://api.github.com/repos/pvizeli/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvizeli/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvizeli/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvizeli/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvizeli/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/pvizeli/home-assistant/languages","stargazers_url":"https://api.github.com/repos/pvizeli/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/pvizeli/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/pvizeli/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/pvizeli/home-assistant/subscription","commits_url":"https://api.github.com/repos/pvizeli/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvizeli/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvizeli/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvizeli/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvizeli/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/pvizeli/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvizeli/home-assistant/merges","archive_url":"https://api.github.com/repos/pvizeli/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvizeli/home-assistant/downloads","issues_url":"https://api.github.com/repos/pvizeli/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/pvizeli/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/pvizeli/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/pvizeli/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvizeli/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/pvizeli/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/pvizeli/home-assistant/deployments","created_at":"2016-07-21T06:45:14Z","updated_at":"2016-07-21T06:45:17Z","pushed_at":"2017-01-10T10:24:20Z","git_url":"git://github.com/pvizeli/home-assistant.git","ssh_url":"git@github.com:pvizeli/home-assistant.git","clone_url":"https://github.com/pvizeli/home-assistant.git","svn_url":"https://github.com/pvizeli/home-assistant","homepage":"https://home-assistant.io","size":99141,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"7e1629a962f645024b0ed8e93c4c1a236804ccb6","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-01-10T10:00:31Z","pushed_at":"2017-01-10T10:26:37Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":47354,"stargazers_count":5323,"watchers_count":5323,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1457,"mirror_url":null,"open_issues_count":411,"forks":1457,"open_issues":411,"watchers":5323,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/5255"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/5255"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/5255/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/5255/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/95059235660ac6c29923674d7bb2b1a6c4b0795d"}}}}
{"actor":{"display_login":"andrey-git"}}