{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/18F/omb-pdf/pulls/15","id":155713067,"html_url":"https://github.com/18F/omb-pdf/pull/15","diff_url":"https://github.com/18F/omb-pdf/pull/15.diff","patch_url":"https://github.com/18F/omb-pdf/pull/15.patch","issue_url":"https://api.github.com/repos/18F/omb-pdf/issues/15","number":15,"state":"closed","locked":false,"title":"Make annotator behavior more predictable and fault tolerant","user":{"login":"toolness","id":124687,"avatar_url":"https://avatars2.githubusercontent.com/u/124687?v=4","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"body":"As suggested in #14, this PR makes annotator behavior more predictable by\r\n\r\n1. converting `ombpdf.annotators.ANNOTATORS` into an `OrderedDict`, and\r\n2. making `set_annotation()` log a warning in the case of a pre-existing annotation, rather than raising an exception.\r\n","created_at":"2017-11-30T20:38:26Z","updated_at":"2017-11-30T20:38:56Z","closed_at":"2017-11-30T20:38:56Z","merged_at":"2017-11-30T20:38:56Z","merge_commit_sha":"26c9c5663f4ab84c0b67e0627c232044d95b62a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/omb-pdf/pulls/15/commits","review_comments_url":"https://api.github.com/repos/18F/omb-pdf/pulls/15/comments","review_comment_url":"https://api.github.com/repos/18F/omb-pdf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/omb-pdf/issues/15/comments","statuses_url":"https://api.github.com/repos/18F/omb-pdf/statuses/34115a0e93034cc91aa76fbf2758076ea39f80d5","head":{"label":"18F:nicer-annotators","ref":"nicer-annotators","sha":"34115a0e93034cc91aa76fbf2758076ea39f80d5","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":111741309,"name":"omb-pdf","full_name":"18F/omb-pdf","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/omb-pdf","description":"Experimenting with pdfminer to import PDFs into the OMB Policy Library.","fork":false,"url":"https://api.github.com/repos/18F/omb-pdf","forks_url":"https://api.github.com/repos/18F/omb-pdf/forks","keys_url":"https://api.github.com/repos/18F/omb-pdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/omb-pdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/omb-pdf/teams","hooks_url":"https://api.github.com/repos/18F/omb-pdf/hooks","issue_events_url":"https://api.github.com/repos/18F/omb-pdf/issues/events{/number}","events_url":"https://api.github.com/repos/18F/omb-pdf/events","assignees_url":"https://api.github.com/repos/18F/omb-pdf/assignees{/user}","branches_url":"https://api.github.com/repos/18F/omb-pdf/branches{/branch}","tags_url":"https://api.github.com/repos/18F/omb-pdf/tags","blobs_url":"https://api.github.com/repos/18F/omb-pdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/omb-pdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/omb-pdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/omb-pdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/omb-pdf/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/omb-pdf/languages","stargazers_url":"https://api.github.com/repos/18F/omb-pdf/stargazers","contributors_url":"https://api.github.com/repos/18F/omb-pdf/contributors","subscribers_url":"https://api.github.com/repos/18F/omb-pdf/subscribers","subscription_url":"https://api.github.com/repos/18F/omb-pdf/subscription","commits_url":"https://api.github.com/repos/18F/omb-pdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/omb-pdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/omb-pdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/omb-pdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/omb-pdf/contents/{+path}","compare_url":"https://api.github.com/repos/18F/omb-pdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/omb-pdf/merges","archive_url":"https://api.github.com/repos/18F/omb-pdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/omb-pdf/downloads","issues_url":"https://api.github.com/repos/18F/omb-pdf/issues{/number}","pulls_url":"https://api.github.com/repos/18F/omb-pdf/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/omb-pdf/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/omb-pdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/omb-pdf/labels{/name}","releases_url":"https://api.github.com/repos/18F/omb-pdf/releases{/id}","deployments_url":"https://api.github.com/repos/18F/omb-pdf/deployments","created_at":"2017-11-22T23:12:29Z","updated_at":"2017-11-30T17:30:03Z","pushed_at":"2017-11-30T20:38:56Z","git_url":"git://github.com/18F/omb-pdf.git","ssh_url":"git@github.com:18F/omb-pdf.git","clone_url":"https://github.com/18F/omb-pdf.git","svn_url":"https://github.com/18F/omb-pdf","homepage":null,"size":188,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"3e54641b435104f8adcd154bcd25d69841872494","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":111741309,"name":"omb-pdf","full_name":"18F/omb-pdf","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/omb-pdf","description":"Experimenting with pdfminer to import PDFs into the OMB Policy Library.","fork":false,"url":"https://api.github.com/repos/18F/omb-pdf","forks_url":"https://api.github.com/repos/18F/omb-pdf/forks","keys_url":"https://api.github.com/repos/18F/omb-pdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/omb-pdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/omb-pdf/teams","hooks_url":"https://api.github.com/repos/18F/omb-pdf/hooks","issue_events_url":"https://api.github.com/repos/18F/omb-pdf/issues/events{/number}","events_url":"https://api.github.com/repos/18F/omb-pdf/events","assignees_url":"https://api.github.com/repos/18F/omb-pdf/assignees{/user}","branches_url":"https://api.github.com/repos/18F/omb-pdf/branches{/branch}","tags_url":"https://api.github.com/repos/18F/omb-pdf/tags","blobs_url":"https://api.github.com/repos/18F/omb-pdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/omb-pdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/omb-pdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/omb-pdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/omb-pdf/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/omb-pdf/languages","stargazers_url":"https://api.github.com/repos/18F/omb-pdf/stargazers","contributors_url":"https://api.github.com/repos/18F/omb-pdf/contributors","subscribers_url":"https://api.github.com/repos/18F/omb-pdf/subscribers","subscription_url":"https://api.github.com/repos/18F/omb-pdf/subscription","commits_url":"https://api.github.com/repos/18F/omb-pdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/omb-pdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/omb-pdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/omb-pdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/omb-pdf/contents/{+path}","compare_url":"https://api.github.com/repos/18F/omb-pdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/omb-pdf/merges","archive_url":"https://api.github.com/repos/18F/omb-pdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/omb-pdf/downloads","issues_url":"https://api.github.com/repos/18F/omb-pdf/issues{/number}","pulls_url":"https://api.github.com/repos/18F/omb-pdf/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/omb-pdf/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/omb-pdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/omb-pdf/labels{/name}","releases_url":"https://api.github.com/repos/18F/omb-pdf/releases{/id}","deployments_url":"https://api.github.com/repos/18F/omb-pdf/deployments","created_at":"2017-11-22T23:12:29Z","updated_at":"2017-11-30T17:30:03Z","pushed_at":"2017-11-30T20:38:56Z","git_url":"git://github.com/18F/omb-pdf.git","ssh_url":"git@github.com:18F/omb-pdf.git","clone_url":"https://github.com/18F/omb-pdf.git","svn_url":"https://github.com/18F/omb-pdf","homepage":null,"size":188,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/omb-pdf/pulls/15"},"html":{"href":"https://github.com/18F/omb-pdf/pull/15"},"issue":{"href":"https://api.github.com/repos/18F/omb-pdf/issues/15"},"comments":{"href":"https://api.github.com/repos/18F/omb-pdf/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/omb-pdf/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/omb-pdf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/omb-pdf/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/18F/omb-pdf/statuses/34115a0e93034cc91aa76fbf2758076ea39f80d5"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"toolness","id":124687,"avatar_url":"https://avatars2.githubusercontent.com/u/124687?v=4","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":19,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"toolness"}}