{"action":"closed","number":161,"pull_request":{"url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/161","id":125595261,"html_url":"https://github.com/rtfeldman/node-test-runner/pull/161","diff_url":"https://github.com/rtfeldman/node-test-runner/pull/161.diff","patch_url":"https://github.com/rtfeldman/node-test-runner/pull/161.patch","issue_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/161","number":161,"state":"closed","locked":false,"title":"Fix condition for reporter options","user":{"login":"jfmengels","id":3869412,"avatar_url":"https://avatars2.githubusercontent.com/u/3869412?v=3","gravatar_id":"","url":"https://api.github.com/users/jfmengels","html_url":"https://github.com/jfmengels","followers_url":"https://api.github.com/users/jfmengels/followers","following_url":"https://api.github.com/users/jfmengels/following{/other_user}","gists_url":"https://api.github.com/users/jfmengels/gists{/gist_id}","starred_url":"https://api.github.com/users/jfmengels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfmengels/subscriptions","organizations_url":"https://api.github.com/users/jfmengels/orgs","repos_url":"https://api.github.com/users/jfmengels/repos","events_url":"https://api.github.com/users/jfmengels/events{/privacy}","received_events_url":"https://api.github.com/users/jfmengels/received_events","type":"User","site_admin":false},"body":"While looking at the source code, I came across this line. The conditions always evaluated to true, regardless of the reporter passed to it, which I assume is not the intended behavior.","created_at":"2017-06-14T13:27:30Z","updated_at":"2017-06-14T17:51:03Z","closed_at":"2017-06-14T17:51:03Z","merged_at":"2017-06-14T17:51:03Z","merge_commit_sha":"5bd61c3eacb0bde2d0f434e6164b8d3548488ef6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/161/commits","review_comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/161/comments","review_comment_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/161/comments","statuses_url":"https://api.github.com/repos/rtfeldman/node-test-runner/statuses/bbf37b9805d869da4af20a312fb86c459533a26f","head":{"label":"jfmengels:fix-reporter-options","ref":"fix-reporter-options","sha":"bbf37b9805d869da4af20a312fb86c459533a26f","user":{"login":"jfmengels","id":3869412,"avatar_url":"https://avatars2.githubusercontent.com/u/3869412?v=3","gravatar_id":"","url":"https://api.github.com/users/jfmengels","html_url":"https://github.com/jfmengels","followers_url":"https://api.github.com/users/jfmengels/followers","following_url":"https://api.github.com/users/jfmengels/following{/other_user}","gists_url":"https://api.github.com/users/jfmengels/gists{/gist_id}","starred_url":"https://api.github.com/users/jfmengels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfmengels/subscriptions","organizations_url":"https://api.github.com/users/jfmengels/orgs","repos_url":"https://api.github.com/users/jfmengels/repos","events_url":"https://api.github.com/users/jfmengels/events{/privacy}","received_events_url":"https://api.github.com/users/jfmengels/received_events","type":"User","site_admin":false},"repo":{"id":94333483,"name":"node-test-runner","full_name":"jfmengels/node-test-runner","owner":{"login":"jfmengels","id":3869412,"avatar_url":"https://avatars2.githubusercontent.com/u/3869412?v=3","gravatar_id":"","url":"https://api.github.com/users/jfmengels","html_url":"https://github.com/jfmengels","followers_url":"https://api.github.com/users/jfmengels/followers","following_url":"https://api.github.com/users/jfmengels/following{/other_user}","gists_url":"https://api.github.com/users/jfmengels/gists{/gist_id}","starred_url":"https://api.github.com/users/jfmengels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfmengels/subscriptions","organizations_url":"https://api.github.com/users/jfmengels/orgs","repos_url":"https://api.github.com/users/jfmengels/repos","events_url":"https://api.github.com/users/jfmengels/events{/privacy}","received_events_url":"https://api.github.com/users/jfmengels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfmengels/node-test-runner","description":"Runs elm-test suites from Node.js. Get it with npm install -g elm-test","fork":true,"url":"https://api.github.com/repos/jfmengels/node-test-runner","forks_url":"https://api.github.com/repos/jfmengels/node-test-runner/forks","keys_url":"https://api.github.com/repos/jfmengels/node-test-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfmengels/node-test-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfmengels/node-test-runner/teams","hooks_url":"https://api.github.com/repos/jfmengels/node-test-runner/hooks","issue_events_url":"https://api.github.com/repos/jfmengels/node-test-runner/issues/events{/number}","events_url":"https://api.github.com/repos/jfmengels/node-test-runner/events","assignees_url":"https://api.github.com/repos/jfmengels/node-test-runner/assignees{/user}","branches_url":"https://api.github.com/repos/jfmengels/node-test-runner/branches{/branch}","tags_url":"https://api.github.com/repos/jfmengels/node-test-runner/tags","blobs_url":"https://api.github.com/repos/jfmengels/node-test-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfmengels/node-test-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfmengels/node-test-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfmengels/node-test-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfmengels/node-test-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/jfmengels/node-test-runner/languages","stargazers_url":"https://api.github.com/repos/jfmengels/node-test-runner/stargazers","contributors_url":"https://api.github.com/repos/jfmengels/node-test-runner/contributors","subscribers_url":"https://api.github.com/repos/jfmengels/node-test-runner/subscribers","subscription_url":"https://api.github.com/repos/jfmengels/node-test-runner/subscription","commits_url":"https://api.github.com/repos/jfmengels/node-test-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfmengels/node-test-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfmengels/node-test-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfmengels/node-test-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfmengels/node-test-runner/contents/{+path}","compare_url":"https://api.github.com/repos/jfmengels/node-test-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfmengels/node-test-runner/merges","archive_url":"https://api.github.com/repos/jfmengels/node-test-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfmengels/node-test-runner/downloads","issues_url":"https://api.github.com/repos/jfmengels/node-test-runner/issues{/number}","pulls_url":"https://api.github.com/repos/jfmengels/node-test-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/jfmengels/node-test-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/jfmengels/node-test-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfmengels/node-test-runner/labels{/name}","releases_url":"https://api.github.com/repos/jfmengels/node-test-runner/releases{/id}","deployments_url":"https://api.github.com/repos/jfmengels/node-test-runner/deployments","created_at":"2017-06-14T13:23:27Z","updated_at":"2017-06-14T13:23:30Z","pushed_at":"2017-06-14T13:23:38Z","git_url":"git://github.com/jfmengels/node-test-runner.git","ssh_url":"git@github.com:jfmengels/node-test-runner.git","clone_url":"https://github.com/jfmengels/node-test-runner.git","svn_url":"https://github.com/jfmengels/node-test-runner","homepage":"","size":5056,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rtfeldman:master","ref":"master","sha":"ccdd1e8d8d9e985020a057a4713df425ece40845","user":{"login":"rtfeldman","id":1094080,"avatar_url":"https://avatars0.githubusercontent.com/u/1094080?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"repo":{"id":37029814,"name":"node-test-runner","full_name":"rtfeldman/node-test-runner","owner":{"login":"rtfeldman","id":1094080,"avatar_url":"https://avatars0.githubusercontent.com/u/1094080?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtfeldman/node-test-runner","description":"Runs elm-test suites from Node.js. Get it with npm install -g elm-test","fork":false,"url":"https://api.github.com/repos/rtfeldman/node-test-runner","forks_url":"https://api.github.com/repos/rtfeldman/node-test-runner/forks","keys_url":"https://api.github.com/repos/rtfeldman/node-test-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfeldman/node-test-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfeldman/node-test-runner/teams","hooks_url":"https://api.github.com/repos/rtfeldman/node-test-runner/hooks","issue_events_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/events{/number}","events_url":"https://api.github.com/repos/rtfeldman/node-test-runner/events","assignees_url":"https://api.github.com/repos/rtfeldman/node-test-runner/assignees{/user}","branches_url":"https://api.github.com/repos/rtfeldman/node-test-runner/branches{/branch}","tags_url":"https://api.github.com/repos/rtfeldman/node-test-runner/tags","blobs_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfeldman/node-test-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfeldman/node-test-runner/languages","stargazers_url":"https://api.github.com/repos/rtfeldman/node-test-runner/stargazers","contributors_url":"https://api.github.com/repos/rtfeldman/node-test-runner/contributors","subscribers_url":"https://api.github.com/repos/rtfeldman/node-test-runner/subscribers","subscription_url":"https://api.github.com/repos/rtfeldman/node-test-runner/subscription","commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfeldman/node-test-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfeldman/node-test-runner/contents/{+path}","compare_url":"https://api.github.com/repos/rtfeldman/node-test-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfeldman/node-test-runner/merges","archive_url":"https://api.github.com/repos/rtfeldman/node-test-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfeldman/node-test-runner/downloads","issues_url":"https://api.github.com/repos/rtfeldman/node-test-runner/issues{/number}","pulls_url":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfeldman/node-test-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfeldman/node-test-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfeldman/node-test-runner/labels{/name}","releases_url":"https://api.github.com/repos/rtfeldman/node-test-runner/releases{/id}","deployments_url":"https://api.github.com/repos/rtfeldman/node-test-runner/deployments","created_at":"2015-06-07T19:48:23Z","updated_at":"2017-06-03T11:27:39Z","pushed_at":"2017-06-14T17:51:03Z","git_url":"git://github.com/rtfeldman/node-test-runner.git","ssh_url":"git@github.com:rtfeldman/node-test-runner.git","clone_url":"https://github.com/rtfeldman/node-test-runner.git","svn_url":"https://github.com/rtfeldman/node-test-runner","homepage":"","size":5064,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":15,"forks":34,"open_issues":15,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/161"},"html":{"href":"https://github.com/rtfeldman/node-test-runner/pull/161"},"issue":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/161"},"comments":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/rtfeldman/node-test-runner/statuses/bbf37b9805d869da4af20a312fb86c459533a26f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zwilias","id":1038427,"avatar_url":"https://avatars0.githubusercontent.com/u/1038427?v=3","gravatar_id":"","url":"https://api.github.com/users/zwilias","html_url":"https://github.com/zwilias","followers_url":"https://api.github.com/users/zwilias/followers","following_url":"https://api.github.com/users/zwilias/following{/other_user}","gists_url":"https://api.github.com/users/zwilias/gists{/gist_id}","starred_url":"https://api.github.com/users/zwilias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwilias/subscriptions","organizations_url":"https://api.github.com/users/zwilias/orgs","repos_url":"https://api.github.com/users/zwilias/repos","events_url":"https://api.github.com/users/zwilias/events{/privacy}","received_events_url":"https://api.github.com/users/zwilias/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"zwilias"}}