{"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/drools/pulls/comments/116747549","pull_request_review_id":38392269,"id":116747549,"diff_hunk":"@@ -55,9 +55,11 @@ public static boolean valueMatchesInUnaryTests(List<UnaryTest> unaryTests, Objec\n         EvaluationContextImpl ctx = new EvaluationContextImpl( null );\n         try {\n             ctx.enterFrame();\n-            // need to set the values for in context variables...\n-            for ( Map.Entry<String,Object> entry : dmnContext.getAll().entrySet() ) {\n-                ctx.setValue( entry.getKey(), entry.getValue() );\n+            if ( dmnContext != null ) {\n+                // need to set the values for in context variables...\n+                for ( Map.Entry<String,Object> entry : dmnContext.getAll().entrySet() ) {\n+                    ctx.setValue( entry.getKey(), entry.getValue() );","path":"kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNFEELHelper.java","position":10,"original_position":10,"commit_id":"c9470b27b576a75951767fc8301ad6c43ceb1793","original_commit_id":"c9470b27b576a75951767fc8301ad6c43ceb1793","user":{"login":"tarilabs","id":1699252,"avatar_url":"https://avatars1.githubusercontent.com/u/1699252?v=3","gravatar_id":"","url":"https://api.github.com/users/tarilabs","html_url":"https://github.com/tarilabs","followers_url":"https://api.github.com/users/tarilabs/followers","following_url":"https://api.github.com/users/tarilabs/following{/other_user}","gists_url":"https://api.github.com/users/tarilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tarilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarilabs/subscriptions","organizations_url":"https://api.github.com/users/tarilabs/orgs","repos_url":"https://api.github.com/users/tarilabs/repos","events_url":"https://api.github.com/users/tarilabs/events{/privacy}","received_events_url":"https://api.github.com/users/tarilabs/received_events","type":"User","site_admin":false},"body":"as before, but avoid NPE for calls coming with null DMNContext (below)","created_at":"2017-05-16T13:49:25Z","updated_at":"2017-05-16T13:59:00Z","html_url":"https://github.com/kiegroup/drools/pull/1269#discussion_r116747549","pull_request_url":"https://api.github.com/repos/kiegroup/drools/pulls/1269","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/comments/116747549"},"html":{"href":"https://github.com/kiegroup/drools/pull/1269#discussion_r116747549"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/1269"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/drools/pulls/1269","id":120831971,"html_url":"https://github.com/kiegroup/drools/pull/1269","diff_url":"https://github.com/kiegroup/drools/pull/1269.diff","patch_url":"https://github.com/kiegroup/drools/pull/1269.patch","issue_url":"https://api.github.com/repos/kiegroup/drools/issues/1269","number":1269,"state":"open","locked":false,"title":"DROOLS-1563 Align InputData values check using BaseDMNTypeImpl.isAssi…","user":{"login":"tarilabs","id":1699252,"avatar_url":"https://avatars1.githubusercontent.com/u/1699252?v=3","gravatar_id":"","url":"https://api.github.com/users/tarilabs","html_url":"https://github.com/tarilabs","followers_url":"https://api.github.com/users/tarilabs/followers","following_url":"https://api.github.com/users/tarilabs/following{/other_user}","gists_url":"https://api.github.com/users/tarilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tarilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarilabs/subscriptions","organizations_url":"https://api.github.com/users/tarilabs/orgs","repos_url":"https://api.github.com/users/tarilabs/repos","events_url":"https://api.github.com/users/tarilabs/events{/privacy}","received_events_url":"https://api.github.com/users/tarilabs/received_events","type":"User","site_admin":false},"body":"…gnableValue","created_at":"2017-05-16T13:48:45Z","updated_at":"2017-05-16T13:59:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c10c0b375057fa199d597f9a68fca4df3ba549","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/drools/pulls/1269/commits","review_comments_url":"https://api.github.com/repos/kiegroup/drools/pulls/1269/comments","review_comment_url":"https://api.github.com/repos/kiegroup/drools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/drools/issues/1269/comments","statuses_url":"https://api.github.com/repos/kiegroup/drools/statuses/c9470b27b576a75951767fc8301ad6c43ceb1793","head":{"label":"tarilabs:d1563","ref":"d1563","sha":"c9470b27b576a75951767fc8301ad6c43ceb1793","user":{"login":"tarilabs","id":1699252,"avatar_url":"https://avatars1.githubusercontent.com/u/1699252?v=3","gravatar_id":"","url":"https://api.github.com/users/tarilabs","html_url":"https://github.com/tarilabs","followers_url":"https://api.github.com/users/tarilabs/followers","following_url":"https://api.github.com/users/tarilabs/following{/other_user}","gists_url":"https://api.github.com/users/tarilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tarilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarilabs/subscriptions","organizations_url":"https://api.github.com/users/tarilabs/orgs","repos_url":"https://api.github.com/users/tarilabs/repos","events_url":"https://api.github.com/users/tarilabs/events{/privacy}","received_events_url":"https://api.github.com/users/tarilabs/received_events","type":"User","site_admin":false},"repo":{"id":16978837,"name":"drools","full_name":"tarilabs/drools","owner":{"login":"tarilabs","id":1699252,"avatar_url":"https://avatars1.githubusercontent.com/u/1699252?v=3","gravatar_id":"","url":"https://api.github.com/users/tarilabs","html_url":"https://github.com/tarilabs","followers_url":"https://api.github.com/users/tarilabs/followers","following_url":"https://api.github.com/users/tarilabs/following{/other_user}","gists_url":"https://api.github.com/users/tarilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tarilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarilabs/subscriptions","organizations_url":"https://api.github.com/users/tarilabs/orgs","repos_url":"https://api.github.com/users/tarilabs/repos","events_url":"https://api.github.com/users/tarilabs/events{/privacy}","received_events_url":"https://api.github.com/users/tarilabs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tarilabs/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":true,"url":"https://api.github.com/repos/tarilabs/drools","forks_url":"https://api.github.com/repos/tarilabs/drools/forks","keys_url":"https://api.github.com/repos/tarilabs/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarilabs/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarilabs/drools/teams","hooks_url":"https://api.github.com/repos/tarilabs/drools/hooks","issue_events_url":"https://api.github.com/repos/tarilabs/drools/issues/events{/number}","events_url":"https://api.github.com/repos/tarilabs/drools/events","assignees_url":"https://api.github.com/repos/tarilabs/drools/assignees{/user}","branches_url":"https://api.github.com/repos/tarilabs/drools/branches{/branch}","tags_url":"https://api.github.com/repos/tarilabs/drools/tags","blobs_url":"https://api.github.com/repos/tarilabs/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarilabs/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarilabs/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarilabs/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarilabs/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/tarilabs/drools/languages","stargazers_url":"https://api.github.com/repos/tarilabs/drools/stargazers","contributors_url":"https://api.github.com/repos/tarilabs/drools/contributors","subscribers_url":"https://api.github.com/repos/tarilabs/drools/subscribers","subscription_url":"https://api.github.com/repos/tarilabs/drools/subscription","commits_url":"https://api.github.com/repos/tarilabs/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarilabs/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarilabs/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarilabs/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarilabs/drools/contents/{+path}","compare_url":"https://api.github.com/repos/tarilabs/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarilabs/drools/merges","archive_url":"https://api.github.com/repos/tarilabs/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarilabs/drools/downloads","issues_url":"https://api.github.com/repos/tarilabs/drools/issues{/number}","pulls_url":"https://api.github.com/repos/tarilabs/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/tarilabs/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/tarilabs/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarilabs/drools/labels{/name}","releases_url":"https://api.github.com/repos/tarilabs/drools/releases{/id}","deployments_url":"https://api.github.com/repos/tarilabs/drools/deployments","created_at":"2014-02-19T09:08:38Z","updated_at":"2015-02-12T11:33:41Z","pushed_at":"2017-05-16T13:46:52Z","git_url":"git://github.com/tarilabs/drools.git","ssh_url":"git@github.com:tarilabs/drools.git","clone_url":"https://github.com/tarilabs/drools.git","svn_url":"https://github.com/tarilabs/drools","homepage":"http://www.jboss.org/drools","size":145374,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"68590c30e0cbf2308c6d59309ef6e9fed112232a","user":{"login":"kiegroup","id":517980,"avatar_url":"https://avatars0.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":1381673,"name":"drools","full_name":"kiegroup/drools","owner":{"login":"kiegroup","id":517980,"avatar_url":"https://avatars0.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiegroup/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":false,"url":"https://api.github.com/repos/kiegroup/drools","forks_url":"https://api.github.com/repos/kiegroup/drools/forks","keys_url":"https://api.github.com/repos/kiegroup/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/drools/teams","hooks_url":"https://api.github.com/repos/kiegroup/drools/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/drools/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/drools/events","assignees_url":"https://api.github.com/repos/kiegroup/drools/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/drools/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/drools/tags","blobs_url":"https://api.github.com/repos/kiegroup/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/drools/languages","stargazers_url":"https://api.github.com/repos/kiegroup/drools/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/drools/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/drools/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/drools/subscription","commits_url":"https://api.github.com/repos/kiegroup/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/drools/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/drools/merges","archive_url":"https://api.github.com/repos/kiegroup/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/drools/downloads","issues_url":"https://api.github.com/repos/kiegroup/drools/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/drools/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/drools/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/drools/deployments","created_at":"2011-02-18T08:37:05Z","updated_at":"2017-05-16T06:50:27Z","pushed_at":"2017-05-16T13:48:46Z","git_url":"git://github.com/kiegroup/drools.git","ssh_url":"git@github.com:kiegroup/drools.git","clone_url":"https://github.com/kiegroup/drools.git","svn_url":"https://github.com/kiegroup/drools","homepage":"http://www.drools.org","size":146830,"stargazers_count":902,"watchers_count":902,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1073,"mirror_url":null,"open_issues_count":6,"forks":1073,"open_issues":6,"watchers":902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/1269"},"html":{"href":"https://github.com/kiegroup/drools/pull/1269"},"issue":{"href":"https://api.github.com/repos/kiegroup/drools/issues/1269"},"comments":{"href":"https://api.github.com/repos/kiegroup/drools/issues/1269/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/1269/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/1269/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/drools/statuses/c9470b27b576a75951767fc8301ad6c43ceb1793"}}}}
{"actor":{"display_login":"tarilabs"}}