{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1207","id":212019406,"number":1207,"title":"Cover art UX improvements","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars3.githubusercontent.com/u/9455094?v=4","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"labels":[{"id":734631092,"url":"https://api.github.com/repos/mixxxdj/mixxx/labels/ui","name":"ui","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2017-03-06T04:05:44Z","updated_at":"2017-11-24T18:39:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1207","html_url":"https://github.com/mixxxdj/mixxx/pull/1207","diff_url":"https://github.com/mixxxdj/mixxx/pull/1207.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1207.patch"},"body":"Rework the UX for showing DlgCoverArtFullSize:\r\n  * don't close DlgCoverArtFullSize when moving cursor off WCoverArt. IMO this was surprising and confusing.\r\n  * close DlgCoverArtFullSize when clicked\r\n  * show DlgCoverArtFullSize when right clicking WSpinny. Before, right clicking on WSpinny paused the track and enabled slip mode. I can't think of a use case for that behavior. The change allows skins to show only WSpinny with cover art but without taking space with a redundant WCoverArt and still make DlgCoverArtFullSize available."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/346881423","html_url":"https://github.com/mixxxdj/mixxx/pull/1207#issuecomment-346881423","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207","id":346881423,"user":{"login":"uklotzde","id":1474154,"avatar_url":"https://avatars1.githubusercontent.com/u/1474154?v=4","gravatar_id":"","url":"https://api.github.com/users/uklotzde","html_url":"https://github.com/uklotzde","followers_url":"https://api.github.com/users/uklotzde/followers","following_url":"https://api.github.com/users/uklotzde/following{/other_user}","gists_url":"https://api.github.com/users/uklotzde/gists{/gist_id}","starred_url":"https://api.github.com/users/uklotzde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uklotzde/subscriptions","organizations_url":"https://api.github.com/users/uklotzde/orgs","repos_url":"https://api.github.com/users/uklotzde/repos","events_url":"https://api.github.com/users/uklotzde/events{/privacy}","received_events_url":"https://api.github.com/users/uklotzde/received_events","type":"User","site_admin":false},"created_at":"2017-11-24T18:39:07Z","updated_at":"2017-11-24T18:39:07Z","author_association":"CONTRIBUTOR","body":"LGTM 👍 I like it. It really improves the usability of the full size cover art window.\r\n\r\nI can deal with the remaining open issues. After upgrading to Qt5 we need to revisit all UI elements again, so I would not spend more time on polishing every detail.\r\n\r\nSome final thoughts from the other reviewers? Unfortunately I'm using the same OS and skin as @Be-ing  so my opinion might be biased ;)"}}
{"actor":{"display_login":"uklotzde"}}