{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/ucs-service/pulls/comments/148715159","pull_request_review_id":74001962,"id":148715159,"diff_hunk":"@@ -4,5 +4,8 @@\n     \"httpsEnabled\": true,\n     \"certFile\": null,\n     \"keyFile\": null,\n-    \"debug\": false\n+    \"debug\": false,\n+    \"callbackUrl\": \"http://172.31.128.1:9988/api/current/ucsCallback\",","path":"config.json","position":6,"original_position":6,"commit_id":"b59f43b1f24b85a3d6732ba8de12f7731beef673","original_commit_id":"8bac39d882d5ac6a7167ab96a7b1becebd77eecf","user":{"login":"pengz1","id":13991453,"avatar_url":"https://avatars1.githubusercontent.com/u/13991453?v=4","gravatar_id":"","url":"https://api.github.com/users/pengz1","html_url":"https://github.com/pengz1","followers_url":"https://api.github.com/users/pengz1/followers","following_url":"https://api.github.com/users/pengz1/following{/other_user}","gists_url":"https://api.github.com/users/pengz1/gists{/gist_id}","starred_url":"https://api.github.com/users/pengz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengz1/subscriptions","organizations_url":"https://api.github.com/users/pengz1/orgs","repos_url":"https://api.github.com/users/pengz1/repos","events_url":"https://api.github.com/users/pengz1/events{/privacy}","received_events_url":"https://api.github.com/users/pengz1/received_events","type":"User","site_admin":false},"body":"I set this API as a default API, which is from our common configure file in:\r\nhttps://github.com/RackHD/RackHD/blob/master/docker/monorail/config.json","created_at":"2017-11-03T06:24:15Z","updated_at":"2017-11-03T06:24:15Z","html_url":"https://github.com/RackHD/ucs-service/pull/28#discussion_r148715159","pull_request_url":"https://api.github.com/repos/RackHD/ucs-service/pulls/28","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RackHD/ucs-service/pulls/comments/148715159"},"html":{"href":"https://github.com/RackHD/ucs-service/pull/28#discussion_r148715159"},"pull_request":{"href":"https://api.github.com/repos/RackHD/ucs-service/pulls/28"}},"in_reply_to_id":148705332},"pull_request":{"url":"https://api.github.com/repos/RackHD/ucs-service/pulls/28","id":149447816,"html_url":"https://github.com/RackHD/ucs-service/pull/28","diff_url":"https://github.com/RackHD/ucs-service/pull/28.diff","patch_url":"https://github.com/RackHD/ucs-service/pull/28.patch","issue_url":"https://api.github.com/repos/RackHD/ucs-service/issues/28","number":28,"state":"open","locked":false,"title":"Implement handle keep session","user":{"login":"pengz1","id":13991453,"avatar_url":"https://avatars1.githubusercontent.com/u/13991453?v=4","gravatar_id":"","url":"https://api.github.com/users/pengz1","html_url":"https://github.com/pengz1","followers_url":"https://api.github.com/users/pengz1/followers","following_url":"https://api.github.com/users/pengz1/following{/other_user}","gists_url":"https://api.github.com/users/pengz1/gists{/gist_id}","starred_url":"https://api.github.com/users/pengz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengz1/subscriptions","organizations_url":"https://api.github.com/users/pengz1/orgs","repos_url":"https://api.github.com/users/pengz1/repos","events_url":"https://api.github.com/users/pengz1/events{/privacy}","received_events_url":"https://api.github.com/users/pengz1/received_events","type":"User","site_admin":false},"body":"*Background*\r\n     UCS login is found to cost about 2 seconds, that is two long for a http\r\n     request. To avoid waiting, session keeping feature is introduced in\r\n     ucs service\r\n\r\n*Details*\r\n     1. For synchronous API, we leverage flask.current_app to store a global\r\n     ucs handler to keep session alive\r\n     2. For asynchronous API, we create a global ucs handler for each\r\n     worker, each worker will have an alive ucs session\r\n     3. Cleanup will be done to close those session if accident happens\r\n\r\nPaired with @bbcyyb\r\n@bbcyyb @anhou @mcgG ","created_at":"2017-10-30T06:54:26Z","updated_at":"2017-11-03T06:24:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0157873a6e208ed7be48eab5d8f30b4fb82f8ddd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/ucs-service/pulls/28/commits","review_comments_url":"https://api.github.com/repos/RackHD/ucs-service/pulls/28/comments","review_comment_url":"https://api.github.com/repos/RackHD/ucs-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/ucs-service/issues/28/comments","statuses_url":"https://api.github.com/repos/RackHD/ucs-service/statuses/b59f43b1f24b85a3d6732ba8de12f7731beef673","head":{"label":"pengz1:Implement-handle-keep-session","ref":"Implement-handle-keep-session","sha":"b59f43b1f24b85a3d6732ba8de12f7731beef673","user":{"login":"pengz1","id":13991453,"avatar_url":"https://avatars1.githubusercontent.com/u/13991453?v=4","gravatar_id":"","url":"https://api.github.com/users/pengz1","html_url":"https://github.com/pengz1","followers_url":"https://api.github.com/users/pengz1/followers","following_url":"https://api.github.com/users/pengz1/following{/other_user}","gists_url":"https://api.github.com/users/pengz1/gists{/gist_id}","starred_url":"https://api.github.com/users/pengz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengz1/subscriptions","organizations_url":"https://api.github.com/users/pengz1/orgs","repos_url":"https://api.github.com/users/pengz1/repos","events_url":"https://api.github.com/users/pengz1/events{/privacy}","received_events_url":"https://api.github.com/users/pengz1/received_events","type":"User","site_admin":false},"repo":{"id":99207828,"name":"ucs-service","full_name":"pengz1/ucs-service","owner":{"login":"pengz1","id":13991453,"avatar_url":"https://avatars1.githubusercontent.com/u/13991453?v=4","gravatar_id":"","url":"https://api.github.com/users/pengz1","html_url":"https://github.com/pengz1","followers_url":"https://api.github.com/users/pengz1/followers","following_url":"https://api.github.com/users/pengz1/following{/other_user}","gists_url":"https://api.github.com/users/pengz1/gists{/gist_id}","starred_url":"https://api.github.com/users/pengz1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengz1/subscriptions","organizations_url":"https://api.github.com/users/pengz1/orgs","repos_url":"https://api.github.com/users/pengz1/repos","events_url":"https://api.github.com/users/pengz1/events{/privacy}","received_events_url":"https://api.github.com/users/pengz1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pengz1/ucs-service","description":null,"fork":true,"url":"https://api.github.com/repos/pengz1/ucs-service","forks_url":"https://api.github.com/repos/pengz1/ucs-service/forks","keys_url":"https://api.github.com/repos/pengz1/ucs-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pengz1/ucs-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pengz1/ucs-service/teams","hooks_url":"https://api.github.com/repos/pengz1/ucs-service/hooks","issue_events_url":"https://api.github.com/repos/pengz1/ucs-service/issues/events{/number}","events_url":"https://api.github.com/repos/pengz1/ucs-service/events","assignees_url":"https://api.github.com/repos/pengz1/ucs-service/assignees{/user}","branches_url":"https://api.github.com/repos/pengz1/ucs-service/branches{/branch}","tags_url":"https://api.github.com/repos/pengz1/ucs-service/tags","blobs_url":"https://api.github.com/repos/pengz1/ucs-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pengz1/ucs-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pengz1/ucs-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/pengz1/ucs-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pengz1/ucs-service/statuses/{sha}","languages_url":"https://api.github.com/repos/pengz1/ucs-service/languages","stargazers_url":"https://api.github.com/repos/pengz1/ucs-service/stargazers","contributors_url":"https://api.github.com/repos/pengz1/ucs-service/contributors","subscribers_url":"https://api.github.com/repos/pengz1/ucs-service/subscribers","subscription_url":"https://api.github.com/repos/pengz1/ucs-service/subscription","commits_url":"https://api.github.com/repos/pengz1/ucs-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/pengz1/ucs-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/pengz1/ucs-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/pengz1/ucs-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/pengz1/ucs-service/contents/{+path}","compare_url":"https://api.github.com/repos/pengz1/ucs-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pengz1/ucs-service/merges","archive_url":"https://api.github.com/repos/pengz1/ucs-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pengz1/ucs-service/downloads","issues_url":"https://api.github.com/repos/pengz1/ucs-service/issues{/number}","pulls_url":"https://api.github.com/repos/pengz1/ucs-service/pulls{/number}","milestones_url":"https://api.github.com/repos/pengz1/ucs-service/milestones{/number}","notifications_url":"https://api.github.com/repos/pengz1/ucs-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pengz1/ucs-service/labels{/name}","releases_url":"https://api.github.com/repos/pengz1/ucs-service/releases{/id}","deployments_url":"https://api.github.com/repos/pengz1/ucs-service/deployments","created_at":"2017-08-03T08:09:51Z","updated_at":"2017-08-03T08:09:52Z","pushed_at":"2017-11-03T04:01:37Z","git_url":"git://github.com/pengz1/ucs-service.git","ssh_url":"git@github.com:pengz1/ucs-service.git","clone_url":"https://github.com/pengz1/ucs-service.git","svn_url":"https://github.com/pengz1/ucs-service","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:Async-api-design","ref":"Async-api-design","sha":"20ee81cc8e517ae78c06a46d6f31ecb129b2c310","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars2.githubusercontent.com/u/13982662?v=4","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":79835453,"name":"ucs-service","full_name":"RackHD/ucs-service","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars2.githubusercontent.com/u/13982662?v=4","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/ucs-service","description":null,"fork":false,"url":"https://api.github.com/repos/RackHD/ucs-service","forks_url":"https://api.github.com/repos/RackHD/ucs-service/forks","keys_url":"https://api.github.com/repos/RackHD/ucs-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/ucs-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/ucs-service/teams","hooks_url":"https://api.github.com/repos/RackHD/ucs-service/hooks","issue_events_url":"https://api.github.com/repos/RackHD/ucs-service/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/ucs-service/events","assignees_url":"https://api.github.com/repos/RackHD/ucs-service/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/ucs-service/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/ucs-service/tags","blobs_url":"https://api.github.com/repos/RackHD/ucs-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/ucs-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/ucs-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/ucs-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/ucs-service/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/ucs-service/languages","stargazers_url":"https://api.github.com/repos/RackHD/ucs-service/stargazers","contributors_url":"https://api.github.com/repos/RackHD/ucs-service/contributors","subscribers_url":"https://api.github.com/repos/RackHD/ucs-service/subscribers","subscription_url":"https://api.github.com/repos/RackHD/ucs-service/subscription","commits_url":"https://api.github.com/repos/RackHD/ucs-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/ucs-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/ucs-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/ucs-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/ucs-service/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/ucs-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/ucs-service/merges","archive_url":"https://api.github.com/repos/RackHD/ucs-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/ucs-service/downloads","issues_url":"https://api.github.com/repos/RackHD/ucs-service/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/ucs-service/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/ucs-service/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/ucs-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/ucs-service/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/ucs-service/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/ucs-service/deployments","created_at":"2017-01-23T18:44:29Z","updated_at":"2017-03-30T16:11:56Z","pushed_at":"2017-11-03T04:01:38Z","git_url":"git://github.com/RackHD/ucs-service.git","ssh_url":"git@github.com:RackHD/ucs-service.git","clone_url":"https://github.com/RackHD/ucs-service.git","svn_url":"https://github.com/RackHD/ucs-service","homepage":null,"size":86,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/ucs-service/pulls/28"},"html":{"href":"https://github.com/RackHD/ucs-service/pull/28"},"issue":{"href":"https://api.github.com/repos/RackHD/ucs-service/issues/28"},"comments":{"href":"https://api.github.com/repos/RackHD/ucs-service/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/ucs-service/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/ucs-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/ucs-service/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/ucs-service/statuses/b59f43b1f24b85a3d6732ba8de12f7731beef673"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pengz1"}}