{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/142055394","pull_request_review_id":66362369,"id":142055394,"diff_hunk":"@@ -26,21 +26,35 @@ class Fastd < Formula\n   end\n \n   depends_on \"cmake\" => :build\n-  depends_on \"libuecc\"\n-  depends_on \"libsodium\"\n   depends_on \"bison\" => :build # fastd requires bison >= 2.5\n   depends_on \"pkg-config\" => :build\n   depends_on \"json-c\"\n+  depends_on \"libuecc\"\n   depends_on \"openssl\" => :optional\n   depends_on :tuntap => :optional\n \n+  # https://projects.universe-factory.net/issues/251\n+  resource \"libsodium\" do\n+    url \"https://github.com/jedisct1/libsodium/releases/download/1.0.14/libsodium-1.0.14.tar.gz\"\n+    sha256 \"3cfc84d097fdc891b40d291f2ac2c3f99f71a87e36b20cc755c6fa0e97a77ee7\"\n+  end\n+\n   def install\n     args = std_cmake_args\n     args << \"-DENABLE_LTO=ON\"\n     args << \"-DENABLE_OPENSSL=ON\" if build.with? \"openssl\"\n-    args << buildpath\n+\n+    resource(\"libsodium\").stage do","path":"Formula/fastd.rb","position":34,"original_position":34,"commit_id":"17d2c51a36ef0cff3fc4edd225359cd72ffdff2c","original_commit_id":"17d2c51a36ef0cff3fc4edd225359cd72ffdff2c","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"It seems weird it only broke one of them. Have you tried to patch it or drop the dependency?","created_at":"2017-10-02T04:03:37Z","updated_at":"2017-10-02T04:03:37Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/18806#discussion_r142055394","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/142055394"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/18806#discussion_r142055394"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806","id":144080394,"html_url":"https://github.com/Homebrew/homebrew-core/pull/18806","diff_url":"https://github.com/Homebrew/homebrew-core/pull/18806.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/18806.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/18806","number":18806,"state":"open","locked":false,"title":"libsodium 1.0.15","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars0.githubusercontent.com/u/6998367?v=4","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nThey changed the major version library, hence, revision bumps for pretty much everything:\r\n\r\n> Note that due to these incompatible changes, the library version major was bumped up.","created_at":"2017-10-01T17:43:08Z","updated_at":"2017-10-02T04:03:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"883366e69669d176eae331c94f1c56f7c4f5c809","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/18806/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/17d2c51a36ef0cff3fc4edd225359cd72ffdff2c","head":{"label":"DomT4:libsodium","ref":"libsodium","sha":"17d2c51a36ef0cff3fc4edd225359cd72ffdff2c","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars0.githubusercontent.com/u/6998367?v=4","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"repo":{"id":55303615,"name":"homebrew-core","full_name":"DomT4/homebrew-core","owner":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars0.githubusercontent.com/u/6998367?v=4","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DomT4/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/DomT4/homebrew-core","forks_url":"https://api.github.com/repos/DomT4/homebrew-core/forks","keys_url":"https://api.github.com/repos/DomT4/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DomT4/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DomT4/homebrew-core/teams","hooks_url":"https://api.github.com/repos/DomT4/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/DomT4/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/DomT4/homebrew-core/events","assignees_url":"https://api.github.com/repos/DomT4/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/DomT4/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/DomT4/homebrew-core/tags","blobs_url":"https://api.github.com/repos/DomT4/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DomT4/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DomT4/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DomT4/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DomT4/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DomT4/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/DomT4/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/DomT4/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/DomT4/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/DomT4/homebrew-core/subscription","commits_url":"https://api.github.com/repos/DomT4/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DomT4/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DomT4/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DomT4/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DomT4/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/DomT4/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DomT4/homebrew-core/merges","archive_url":"https://api.github.com/repos/DomT4/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DomT4/homebrew-core/downloads","issues_url":"https://api.github.com/repos/DomT4/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/DomT4/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DomT4/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DomT4/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DomT4/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/DomT4/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/DomT4/homebrew-core/deployments","created_at":"2016-04-02T16:09:23Z","updated_at":"2017-08-01T00:02:27Z","pushed_at":"2017-10-01T23:43:23Z","git_url":"git://github.com/DomT4/homebrew-core.git","ssh_url":"git@github.com:DomT4/homebrew-core.git","clone_url":"https://github.com/DomT4/homebrew-core.git","svn_url":"https://github.com/DomT4/homebrew-core","homepage":"","size":142935,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"2105c573bd1cb60a0c5e46bee8f2a9f6537455c6","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2017-10-01T16:23:53Z","pushed_at":"2017-10-02T01:13:59Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":142873,"stargazers_count":2146,"watchers_count":2146,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3245,"mirror_url":null,"open_issues_count":111,"forks":3245,"open_issues":111,"watchers":2146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/18806"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/18806"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/18806/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/18806/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/17d2c51a36ef0cff3fc4edd225359cd72ffdff2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ilovezfs"}}