{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/152988238","pull_request_review_id":78937147,"id":152988238,"diff_hunk":"@@ -1161,32 +1176,39 @@ private Boolean isExecutionCalendarGIDefined(String jobDescriptor) {\n         NodeList list = root.getChildNodes();\n         for (int i = 0; i < list.getLength(); i++) {\n             Node node = list.item(i);\n-            if (node.getNodeName() == \"info\" && node.hasAttributes()) { // node.getNodeType() == Node.ELEMENT_NODE\n+            if (node.getNodeName() == \"info\" && node.hasAttributes()) {\n                 NamedNodeMap attributes = node.getAttributes();\n                 for (int j = 0; j < attributes.getLength(); j++) {\n                     Node attribute = attributes.item(j);\n                     if (attribute.getNodeType() == Node.ATTRIBUTE_NODE && attribute.getNodeName().equals(\"name\") &&\n                         attribute.getNodeValue().equals(\"EXECUTION_CALENDARS\")) {\n                         exists = true;\n                     }\n-                    if (attribute.getNodeType() == Node.ATTRIBUTE_NODE && attribute.getNodeName().equals(\"value\") &&\n-                        exists) {\n-                        if (attribute.getNodeValue() != null) {\n+                    if (isAttributeExecCalendarValueDefined(attribute, \"value\") && exists) {\n+                        if (attribute.getNodeValue() != null && attribute.getNodeValue().toString() != \"\" && exists) {\n                             executionCalendarDefined = true;\n-                        } else {\n-                            displayErrorMessage(\"EXECUTION_CALENDAR value is empty.\");\n+                            if (attribute.getNodeValue() != \"\") {\n+                                isExecCalendarValueNull = false;\n+                            } else {\n+                                isExecCalendarValueNull = true;\n+                            }","path":"scheduler-portal/src/main/java/org/ow2/proactive_grid_cloud_portal/scheduler/client/SubmitWindow.java","position":414,"original_position":238,"commit_id":"7542799f697ffcf6be827b7fddad5ea1d2babe2b","original_commit_id":"7542799f697ffcf6be827b7fddad5ea1d2babe2b","user":{"login":"amouhoub","id":1918419,"avatar_url":"https://avatars0.githubusercontent.com/u/1918419?v=4","gravatar_id":"","url":"https://api.github.com/users/amouhoub","html_url":"https://github.com/amouhoub","followers_url":"https://api.github.com/users/amouhoub/followers","following_url":"https://api.github.com/users/amouhoub/following{/other_user}","gists_url":"https://api.github.com/users/amouhoub/gists{/gist_id}","starred_url":"https://api.github.com/users/amouhoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amouhoub/subscriptions","organizations_url":"https://api.github.com/users/amouhoub/orgs","repos_url":"https://api.github.com/users/amouhoub/repos","events_url":"https://api.github.com/users/amouhoub/events{/privacy}","received_events_url":"https://api.github.com/users/amouhoub/received_events","type":"User","site_admin":false},"body":"4 nested ifs, I don't think the others will validate this","created_at":"2017-11-24T15:08:35Z","updated_at":"2017-11-24T15:20:50Z","html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/383#discussion_r152988238","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/152988238"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/383#discussion_r152988238"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383","id":154213362,"html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/383","diff_url":"https://github.com/ow2-proactive/scheduling-portal/pull/383.diff","patch_url":"https://github.com/ow2-proactive/scheduling-portal/pull/383.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/383","number":383,"state":"open","locked":false,"title":"Display a new radio button on SubmitWindow when the Job has EXECUTION_CALENDARS Generic Information defined","user":{"login":"zeineb","id":368264,"avatar_url":"https://avatars3.githubusercontent.com/u/368264?v=4","gravatar_id":"","url":"https://api.github.com/users/zeineb","html_url":"https://github.com/zeineb","followers_url":"https://api.github.com/users/zeineb/followers","following_url":"https://api.github.com/users/zeineb/following{/other_user}","gists_url":"https://api.github.com/users/zeineb/gists{/gist_id}","starred_url":"https://api.github.com/users/zeineb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeineb/subscriptions","organizations_url":"https://api.github.com/users/zeineb/orgs","repos_url":"https://api.github.com/users/zeineb/repos","events_url":"https://api.github.com/users/zeineb/events{/privacy}","received_events_url":"https://api.github.com/users/zeineb/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-22T17:21:39Z","updated_at":"2017-11-24T15:20:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04a8372e3632679f5b95d45ba3f95fae823c434c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/383/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/7542799f697ffcf6be827b7fddad5ea1d2babe2b","head":{"label":"zeineb:master","ref":"master","sha":"7542799f697ffcf6be827b7fddad5ea1d2babe2b","user":{"login":"zeineb","id":368264,"avatar_url":"https://avatars3.githubusercontent.com/u/368264?v=4","gravatar_id":"","url":"https://api.github.com/users/zeineb","html_url":"https://github.com/zeineb","followers_url":"https://api.github.com/users/zeineb/followers","following_url":"https://api.github.com/users/zeineb/following{/other_user}","gists_url":"https://api.github.com/users/zeineb/gists{/gist_id}","starred_url":"https://api.github.com/users/zeineb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeineb/subscriptions","organizations_url":"https://api.github.com/users/zeineb/orgs","repos_url":"https://api.github.com/users/zeineb/repos","events_url":"https://api.github.com/users/zeineb/events{/privacy}","received_events_url":"https://api.github.com/users/zeineb/received_events","type":"User","site_admin":false},"repo":{"id":110946187,"name":"scheduling-portal","full_name":"zeineb/scheduling-portal","owner":{"login":"zeineb","id":368264,"avatar_url":"https://avatars3.githubusercontent.com/u/368264?v=4","gravatar_id":"","url":"https://api.github.com/users/zeineb","html_url":"https://github.com/zeineb","followers_url":"https://api.github.com/users/zeineb/followers","following_url":"https://api.github.com/users/zeineb/following{/other_user}","gists_url":"https://api.github.com/users/zeineb/gists{/gist_id}","starred_url":"https://api.github.com/users/zeineb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeineb/subscriptions","organizations_url":"https://api.github.com/users/zeineb/orgs","repos_url":"https://api.github.com/users/zeineb/repos","events_url":"https://api.github.com/users/zeineb/events{/privacy}","received_events_url":"https://api.github.com/users/zeineb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeineb/scheduling-portal","description":null,"fork":true,"url":"https://api.github.com/repos/zeineb/scheduling-portal","forks_url":"https://api.github.com/repos/zeineb/scheduling-portal/forks","keys_url":"https://api.github.com/repos/zeineb/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeineb/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeineb/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/zeineb/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/zeineb/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/zeineb/scheduling-portal/events","assignees_url":"https://api.github.com/repos/zeineb/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/zeineb/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/zeineb/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/zeineb/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeineb/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeineb/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeineb/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeineb/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/zeineb/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/zeineb/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/zeineb/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/zeineb/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/zeineb/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/zeineb/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeineb/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeineb/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeineb/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeineb/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/zeineb/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeineb/scheduling-portal/merges","archive_url":"https://api.github.com/repos/zeineb/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeineb/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/zeineb/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/zeineb/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/zeineb/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/zeineb/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeineb/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/zeineb/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/zeineb/scheduling-portal/deployments","created_at":"2017-11-16T08:44:05Z","updated_at":"2017-11-16T08:44:09Z","pushed_at":"2017-11-24T14:05:15Z","git_url":"git://github.com/zeineb/scheduling-portal.git","ssh_url":"git@github.com:zeineb/scheduling-portal.git","clone_url":"https://github.com/zeineb/scheduling-portal.git","svn_url":"https://github.com/zeineb/scheduling-portal","homepage":"http://try.activeeon.com","size":118624,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"a5f76ab045e83b39105c78f354b537195b379df6","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725080,"name":"scheduling-portal","full_name":"ow2-proactive/scheduling-portal","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling-portal","description":null,"fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2016-10-27T17:28:08Z","pushed_at":"2017-11-24T14:05:16Z","git_url":"git://github.com/ow2-proactive/scheduling-portal.git","ssh_url":"git@github.com:ow2-proactive/scheduling-portal.git","clone_url":"https://github.com/ow2-proactive/scheduling-portal.git","svn_url":"https://github.com/ow2-proactive/scheduling-portal","homepage":"http://try.activeeon.com","size":118616,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":61,"forks":28,"open_issues":61,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/383"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/383"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/383/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/383/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/7542799f697ffcf6be827b7fddad5ea1d2babe2b"}},"author_association":"NONE"}}
{"actor":{"display_login":"amouhoub"}}