{"action":"created","comment":{"url":"https://api.github.com/repos/LinkValue/CraCra/pulls/comments/97963677","pull_request_review_id":18589172,"id":97963677,"diff_hunk":"@@ -1,21 +1,33 @@\n .printer {\n   display: none;\n   font-size: 1.1rem;\n+  width: 19cm; /* A4 format 21x29.7 minus 2cm of page margin */\n }\n \n .printerTable {\n   border-collapse: collapse;\n+  margin: 0 auto;\n }\n \n .printerSeparator {\n-  height: 0.3rem;\n+  height: 0.5rem;\n   border: solid 1px #000000;\n }\n \n+.printerHeader {\n+  border: solid 1px #000000;\n+  height: 2rem;\n+}\n+\n+tr.printerHeader td {","path":"src/components/printer/printer.scss","position":23,"original_position":23,"commit_id":"920721dfbda5464288b4eb750b7eb984783d7a81","original_commit_id":"920721dfbda5464288b4eb750b7eb984783d7a81","user":{"login":"D34THWINGS","id":1787785,"avatar_url":"https://avatars.githubusercontent.com/u/1787785?v=3","gravatar_id":"","url":"https://api.github.com/users/D34THWINGS","html_url":"https://github.com/D34THWINGS","followers_url":"https://api.github.com/users/D34THWINGS/followers","following_url":"https://api.github.com/users/D34THWINGS/following{/other_user}","gists_url":"https://api.github.com/users/D34THWINGS/gists{/gist_id}","starred_url":"https://api.github.com/users/D34THWINGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D34THWINGS/subscriptions","organizations_url":"https://api.github.com/users/D34THWINGS/orgs","repos_url":"https://api.github.com/users/D34THWINGS/repos","events_url":"https://api.github.com/users/D34THWINGS/events{/privacy}","received_events_url":"https://api.github.com/users/D34THWINGS/received_events","type":"User","site_admin":false},"body":"Use a class instead, selector is too strong and hard to override if needed.  Also classes rely less on the DOM structure allowing to move objects around without having to rewrite CSS.","created_at":"2017-01-26T10:14:16Z","updated_at":"2017-01-26T10:19:48Z","html_url":"https://github.com/LinkValue/CraCra/pull/40#discussion_r97963677","pull_request_url":"https://api.github.com/repos/LinkValue/CraCra/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/LinkValue/CraCra/pulls/comments/97963677"},"html":{"href":"https://github.com/LinkValue/CraCra/pull/40#discussion_r97963677"},"pull_request":{"href":"https://api.github.com/repos/LinkValue/CraCra/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/LinkValue/CraCra/pulls/40","id":103273585,"html_url":"https://github.com/LinkValue/CraCra/pull/40","diff_url":"https://github.com/LinkValue/CraCra/pull/40.diff","patch_url":"https://github.com/LinkValue/CraCra/pull/40.patch","issue_url":"https://api.github.com/repos/LinkValue/CraCra/issues/40","number":40,"state":"open","locked":false,"title":"fix printer css to be able to print in A4 portrait mode","user":{"login":"mvand","id":3083735,"avatar_url":"https://avatars.githubusercontent.com/u/3083735?v=3","gravatar_id":"","url":"https://api.github.com/users/mvand","html_url":"https://github.com/mvand","followers_url":"https://api.github.com/users/mvand/followers","following_url":"https://api.github.com/users/mvand/following{/other_user}","gists_url":"https://api.github.com/users/mvand/gists{/gist_id}","starred_url":"https://api.github.com/users/mvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvand/subscriptions","organizations_url":"https://api.github.com/users/mvand/orgs","repos_url":"https://api.github.com/users/mvand/repos","events_url":"https://api.github.com/users/mvand/events{/privacy}","received_events_url":"https://api.github.com/users/mvand/received_events","type":"User","site_admin":false},"body":"The Printer is now able to display the CraCra within an A4 format.\r\n\r\nBefore, the width was too much big and needed to be print in landscape mode.\r\n\r\nTo reduce it, i updated the css and I changed the HTML structure, re-positioned activity name at the top of the am/pm rows instead of start.\r\nI also replace the 0 by spaces, personal preference but can be easily reverted if it isn't the general one :p ","created_at":"2017-01-26T09:20:14Z","updated_at":"2017-01-26T10:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63c07f0e6dacccea5606c183f1839a3e83edaa2c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LinkValue/CraCra/pulls/40/commits","review_comments_url":"https://api.github.com/repos/LinkValue/CraCra/pulls/40/comments","review_comment_url":"https://api.github.com/repos/LinkValue/CraCra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LinkValue/CraCra/issues/40/comments","statuses_url":"https://api.github.com/repos/LinkValue/CraCra/statuses/920721dfbda5464288b4eb750b7eb984783d7a81","head":{"label":"LinkValue:fix/print-A4","ref":"fix/print-A4","sha":"920721dfbda5464288b4eb750b7eb984783d7a81","user":{"login":"LinkValue","id":8301788,"avatar_url":"https://avatars.githubusercontent.com/u/8301788?v=3","gravatar_id":"","url":"https://api.github.com/users/LinkValue","html_url":"https://github.com/LinkValue","followers_url":"https://api.github.com/users/LinkValue/followers","following_url":"https://api.github.com/users/LinkValue/following{/other_user}","gists_url":"https://api.github.com/users/LinkValue/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkValue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkValue/subscriptions","organizations_url":"https://api.github.com/users/LinkValue/orgs","repos_url":"https://api.github.com/users/LinkValue/repos","events_url":"https://api.github.com/users/LinkValue/events{/privacy}","received_events_url":"https://api.github.com/users/LinkValue/received_events","type":"Organization","site_admin":false},"repo":{"id":62293861,"name":"CraCra","full_name":"LinkValue/CraCra","owner":{"login":"LinkValue","id":8301788,"avatar_url":"https://avatars.githubusercontent.com/u/8301788?v=3","gravatar_id":"","url":"https://api.github.com/users/LinkValue","html_url":"https://github.com/LinkValue","followers_url":"https://api.github.com/users/LinkValue/followers","following_url":"https://api.github.com/users/LinkValue/following{/other_user}","gists_url":"https://api.github.com/users/LinkValue/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkValue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkValue/subscriptions","organizations_url":"https://api.github.com/users/LinkValue/orgs","repos_url":"https://api.github.com/users/LinkValue/repos","events_url":"https://api.github.com/users/LinkValue/events{/privacy}","received_events_url":"https://api.github.com/users/LinkValue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LinkValue/CraCra","description":"CRA editor","fork":false,"url":"https://api.github.com/repos/LinkValue/CraCra","forks_url":"https://api.github.com/repos/LinkValue/CraCra/forks","keys_url":"https://api.github.com/repos/LinkValue/CraCra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LinkValue/CraCra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LinkValue/CraCra/teams","hooks_url":"https://api.github.com/repos/LinkValue/CraCra/hooks","issue_events_url":"https://api.github.com/repos/LinkValue/CraCra/issues/events{/number}","events_url":"https://api.github.com/repos/LinkValue/CraCra/events","assignees_url":"https://api.github.com/repos/LinkValue/CraCra/assignees{/user}","branches_url":"https://api.github.com/repos/LinkValue/CraCra/branches{/branch}","tags_url":"https://api.github.com/repos/LinkValue/CraCra/tags","blobs_url":"https://api.github.com/repos/LinkValue/CraCra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LinkValue/CraCra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LinkValue/CraCra/git/refs{/sha}","trees_url":"https://api.github.com/repos/LinkValue/CraCra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LinkValue/CraCra/statuses/{sha}","languages_url":"https://api.github.com/repos/LinkValue/CraCra/languages","stargazers_url":"https://api.github.com/repos/LinkValue/CraCra/stargazers","contributors_url":"https://api.github.com/repos/LinkValue/CraCra/contributors","subscribers_url":"https://api.github.com/repos/LinkValue/CraCra/subscribers","subscription_url":"https://api.github.com/repos/LinkValue/CraCra/subscription","commits_url":"https://api.github.com/repos/LinkValue/CraCra/commits{/sha}","git_commits_url":"https://api.github.com/repos/LinkValue/CraCra/git/commits{/sha}","comments_url":"https://api.github.com/repos/LinkValue/CraCra/comments{/number}","issue_comment_url":"https://api.github.com/repos/LinkValue/CraCra/issues/comments{/number}","contents_url":"https://api.github.com/repos/LinkValue/CraCra/contents/{+path}","compare_url":"https://api.github.com/repos/LinkValue/CraCra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LinkValue/CraCra/merges","archive_url":"https://api.github.com/repos/LinkValue/CraCra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LinkValue/CraCra/downloads","issues_url":"https://api.github.com/repos/LinkValue/CraCra/issues{/number}","pulls_url":"https://api.github.com/repos/LinkValue/CraCra/pulls{/number}","milestones_url":"https://api.github.com/repos/LinkValue/CraCra/milestones{/number}","notifications_url":"https://api.github.com/repos/LinkValue/CraCra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LinkValue/CraCra/labels{/name}","releases_url":"https://api.github.com/repos/LinkValue/CraCra/releases{/id}","deployments_url":"https://api.github.com/repos/LinkValue/CraCra/deployments","created_at":"2016-06-30T08:29:50Z","updated_at":"2016-11-30T09:51:52Z","pushed_at":"2017-01-26T09:29:45Z","git_url":"git://github.com/LinkValue/CraCra.git","ssh_url":"git@github.com:LinkValue/CraCra.git","clone_url":"https://github.com/LinkValue/CraCra.git","svn_url":"https://github.com/LinkValue/CraCra","homepage":null,"size":173,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"LinkValue:master","ref":"master","sha":"14635e7eff163a5037613de846a28a16c5f77ec0","user":{"login":"LinkValue","id":8301788,"avatar_url":"https://avatars.githubusercontent.com/u/8301788?v=3","gravatar_id":"","url":"https://api.github.com/users/LinkValue","html_url":"https://github.com/LinkValue","followers_url":"https://api.github.com/users/LinkValue/followers","following_url":"https://api.github.com/users/LinkValue/following{/other_user}","gists_url":"https://api.github.com/users/LinkValue/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkValue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkValue/subscriptions","organizations_url":"https://api.github.com/users/LinkValue/orgs","repos_url":"https://api.github.com/users/LinkValue/repos","events_url":"https://api.github.com/users/LinkValue/events{/privacy}","received_events_url":"https://api.github.com/users/LinkValue/received_events","type":"Organization","site_admin":false},"repo":{"id":62293861,"name":"CraCra","full_name":"LinkValue/CraCra","owner":{"login":"LinkValue","id":8301788,"avatar_url":"https://avatars.githubusercontent.com/u/8301788?v=3","gravatar_id":"","url":"https://api.github.com/users/LinkValue","html_url":"https://github.com/LinkValue","followers_url":"https://api.github.com/users/LinkValue/followers","following_url":"https://api.github.com/users/LinkValue/following{/other_user}","gists_url":"https://api.github.com/users/LinkValue/gists{/gist_id}","starred_url":"https://api.github.com/users/LinkValue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinkValue/subscriptions","organizations_url":"https://api.github.com/users/LinkValue/orgs","repos_url":"https://api.github.com/users/LinkValue/repos","events_url":"https://api.github.com/users/LinkValue/events{/privacy}","received_events_url":"https://api.github.com/users/LinkValue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LinkValue/CraCra","description":"CRA editor","fork":false,"url":"https://api.github.com/repos/LinkValue/CraCra","forks_url":"https://api.github.com/repos/LinkValue/CraCra/forks","keys_url":"https://api.github.com/repos/LinkValue/CraCra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LinkValue/CraCra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LinkValue/CraCra/teams","hooks_url":"https://api.github.com/repos/LinkValue/CraCra/hooks","issue_events_url":"https://api.github.com/repos/LinkValue/CraCra/issues/events{/number}","events_url":"https://api.github.com/repos/LinkValue/CraCra/events","assignees_url":"https://api.github.com/repos/LinkValue/CraCra/assignees{/user}","branches_url":"https://api.github.com/repos/LinkValue/CraCra/branches{/branch}","tags_url":"https://api.github.com/repos/LinkValue/CraCra/tags","blobs_url":"https://api.github.com/repos/LinkValue/CraCra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LinkValue/CraCra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LinkValue/CraCra/git/refs{/sha}","trees_url":"https://api.github.com/repos/LinkValue/CraCra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LinkValue/CraCra/statuses/{sha}","languages_url":"https://api.github.com/repos/LinkValue/CraCra/languages","stargazers_url":"https://api.github.com/repos/LinkValue/CraCra/stargazers","contributors_url":"https://api.github.com/repos/LinkValue/CraCra/contributors","subscribers_url":"https://api.github.com/repos/LinkValue/CraCra/subscribers","subscription_url":"https://api.github.com/repos/LinkValue/CraCra/subscription","commits_url":"https://api.github.com/repos/LinkValue/CraCra/commits{/sha}","git_commits_url":"https://api.github.com/repos/LinkValue/CraCra/git/commits{/sha}","comments_url":"https://api.github.com/repos/LinkValue/CraCra/comments{/number}","issue_comment_url":"https://api.github.com/repos/LinkValue/CraCra/issues/comments{/number}","contents_url":"https://api.github.com/repos/LinkValue/CraCra/contents/{+path}","compare_url":"https://api.github.com/repos/LinkValue/CraCra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LinkValue/CraCra/merges","archive_url":"https://api.github.com/repos/LinkValue/CraCra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LinkValue/CraCra/downloads","issues_url":"https://api.github.com/repos/LinkValue/CraCra/issues{/number}","pulls_url":"https://api.github.com/repos/LinkValue/CraCra/pulls{/number}","milestones_url":"https://api.github.com/repos/LinkValue/CraCra/milestones{/number}","notifications_url":"https://api.github.com/repos/LinkValue/CraCra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LinkValue/CraCra/labels{/name}","releases_url":"https://api.github.com/repos/LinkValue/CraCra/releases{/id}","deployments_url":"https://api.github.com/repos/LinkValue/CraCra/deployments","created_at":"2016-06-30T08:29:50Z","updated_at":"2016-11-30T09:51:52Z","pushed_at":"2017-01-26T09:29:45Z","git_url":"git://github.com/LinkValue/CraCra.git","ssh_url":"git@github.com:LinkValue/CraCra.git","clone_url":"https://github.com/LinkValue/CraCra.git","svn_url":"https://github.com/LinkValue/CraCra","homepage":null,"size":173,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LinkValue/CraCra/pulls/40"},"html":{"href":"https://github.com/LinkValue/CraCra/pull/40"},"issue":{"href":"https://api.github.com/repos/LinkValue/CraCra/issues/40"},"comments":{"href":"https://api.github.com/repos/LinkValue/CraCra/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/LinkValue/CraCra/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/LinkValue/CraCra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LinkValue/CraCra/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/LinkValue/CraCra/statuses/920721dfbda5464288b4eb750b7eb984783d7a81"}}}}
{"actor":{"display_login":"D34THWINGS"}}