{"action":"closed","number":1984,"pull_request":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/1984","id":126889698,"html_url":"https://github.com/MvvmCross/MvvmCross/pull/1984","diff_url":"https://github.com/MvvmCross/MvvmCross/pull/1984.diff","patch_url":"https://github.com/MvvmCross/MvvmCross/pull/1984.patch","issue_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1984","number":1984,"state":"closed","locked":false,"title":"added features to be able to provided the selected image on tab item","user":{"login":"biozal","id":176927,"avatar_url":"https://avatars0.githubusercontent.com/u/176927?v=3","gravatar_id":"","url":"https://api.github.com/users/biozal","html_url":"https://github.com/biozal","followers_url":"https://api.github.com/users/biozal/followers","following_url":"https://api.github.com/users/biozal/following{/other_user}","gists_url":"https://api.github.com/users/biozal/gists{/gist_id}","starred_url":"https://api.github.com/users/biozal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biozal/subscriptions","organizations_url":"https://api.github.com/users/biozal/orgs","repos_url":"https://api.github.com/users/biozal/repos","events_url":"https://api.github.com/users/biozal/events{/privacy}","received_events_url":"https://api.github.com/users/biozal/received_events","type":"User","site_admin":false},"body":"## :sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)\r\nfeature\r\n\r\n## :arrow_heading_down: What is the current behavior?\r\nyou can set a tab bar item's image, but not the selected image\r\n\r\n## :new: What is the new behavior (if this is a feature change)?\r\nyou can provide the selected image icon\r\n\r\n## :boom: Does this PR introduce a breaking change?\r\nI don't think so because the string for selected image can be null and if it's null then it's not set on the tab bar item\r\n\r\n## :bug: Recommendations for testing\r\nI updated the code in the play ground for testing\r\n\r\n## :memo: Links to relevant issues/docs\r\nI mentioned this in slack to the team\r\n\r\n## :thinking: Checklist before submitting\r\n\r\n- [X] All projects build\r\n- [X] Follows style guide lines ([code style guide](https://github.com/MvvmCross/MvvmCross#code-style-guidelines))\r\n- [ ] Relevant documentation was updated ([docs style guide](https://www.mvvmcross.com/documentation/contribute/mvvmcross-docs-style-guide))\r\n- [x] Nuspec files were updated (when applicable)\r\n- [ ] Rebased onto current develop","created_at":"2017-06-22T00:51:07Z","updated_at":"2017-06-22T07:51:54Z","closed_at":"2017-06-22T07:51:54Z","merged_at":"2017-06-22T07:51:54Z","merge_commit_sha":"d4d1d804b2160f212700e58e985cfe5e3df66de5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/1984/commits","review_comments_url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/1984/comments","review_comment_url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1984/comments","statuses_url":"https://api.github.com/repos/MvvmCross/MvvmCross/statuses/d976dec5787e460db684dc8ca396dd09d4bf2789","head":{"label":"biozal:feature/iosTabItemSelectedImage","ref":"feature/iosTabItemSelectedImage","sha":"d976dec5787e460db684dc8ca396dd09d4bf2789","user":{"login":"biozal","id":176927,"avatar_url":"https://avatars0.githubusercontent.com/u/176927?v=3","gravatar_id":"","url":"https://api.github.com/users/biozal","html_url":"https://github.com/biozal","followers_url":"https://api.github.com/users/biozal/followers","following_url":"https://api.github.com/users/biozal/following{/other_user}","gists_url":"https://api.github.com/users/biozal/gists{/gist_id}","starred_url":"https://api.github.com/users/biozal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biozal/subscriptions","organizations_url":"https://api.github.com/users/biozal/orgs","repos_url":"https://api.github.com/users/biozal/repos","events_url":"https://api.github.com/users/biozal/events{/privacy}","received_events_url":"https://api.github.com/users/biozal/received_events","type":"User","site_admin":false},"repo":{"id":95058782,"name":"MvvmCross","full_name":"biozal/MvvmCross","owner":{"login":"biozal","id":176927,"avatar_url":"https://avatars0.githubusercontent.com/u/176927?v=3","gravatar_id":"","url":"https://api.github.com/users/biozal","html_url":"https://github.com/biozal","followers_url":"https://api.github.com/users/biozal/followers","following_url":"https://api.github.com/users/biozal/following{/other_user}","gists_url":"https://api.github.com/users/biozal/gists{/gist_id}","starred_url":"https://api.github.com/users/biozal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biozal/subscriptions","organizations_url":"https://api.github.com/users/biozal/orgs","repos_url":"https://api.github.com/users/biozal/repos","events_url":"https://api.github.com/users/biozal/events{/privacy}","received_events_url":"https://api.github.com/users/biozal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/biozal/MvvmCross","description":"The .NET MVVM framework for cross-platform solutions, including Xamarin.iOS, Xamarin.Android, Windows and Mac.","fork":true,"url":"https://api.github.com/repos/biozal/MvvmCross","forks_url":"https://api.github.com/repos/biozal/MvvmCross/forks","keys_url":"https://api.github.com/repos/biozal/MvvmCross/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biozal/MvvmCross/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biozal/MvvmCross/teams","hooks_url":"https://api.github.com/repos/biozal/MvvmCross/hooks","issue_events_url":"https://api.github.com/repos/biozal/MvvmCross/issues/events{/number}","events_url":"https://api.github.com/repos/biozal/MvvmCross/events","assignees_url":"https://api.github.com/repos/biozal/MvvmCross/assignees{/user}","branches_url":"https://api.github.com/repos/biozal/MvvmCross/branches{/branch}","tags_url":"https://api.github.com/repos/biozal/MvvmCross/tags","blobs_url":"https://api.github.com/repos/biozal/MvvmCross/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biozal/MvvmCross/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biozal/MvvmCross/git/refs{/sha}","trees_url":"https://api.github.com/repos/biozal/MvvmCross/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biozal/MvvmCross/statuses/{sha}","languages_url":"https://api.github.com/repos/biozal/MvvmCross/languages","stargazers_url":"https://api.github.com/repos/biozal/MvvmCross/stargazers","contributors_url":"https://api.github.com/repos/biozal/MvvmCross/contributors","subscribers_url":"https://api.github.com/repos/biozal/MvvmCross/subscribers","subscription_url":"https://api.github.com/repos/biozal/MvvmCross/subscription","commits_url":"https://api.github.com/repos/biozal/MvvmCross/commits{/sha}","git_commits_url":"https://api.github.com/repos/biozal/MvvmCross/git/commits{/sha}","comments_url":"https://api.github.com/repos/biozal/MvvmCross/comments{/number}","issue_comment_url":"https://api.github.com/repos/biozal/MvvmCross/issues/comments{/number}","contents_url":"https://api.github.com/repos/biozal/MvvmCross/contents/{+path}","compare_url":"https://api.github.com/repos/biozal/MvvmCross/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biozal/MvvmCross/merges","archive_url":"https://api.github.com/repos/biozal/MvvmCross/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biozal/MvvmCross/downloads","issues_url":"https://api.github.com/repos/biozal/MvvmCross/issues{/number}","pulls_url":"https://api.github.com/repos/biozal/MvvmCross/pulls{/number}","milestones_url":"https://api.github.com/repos/biozal/MvvmCross/milestones{/number}","notifications_url":"https://api.github.com/repos/biozal/MvvmCross/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biozal/MvvmCross/labels{/name}","releases_url":"https://api.github.com/repos/biozal/MvvmCross/releases{/id}","deployments_url":"https://api.github.com/repos/biozal/MvvmCross/deployments","created_at":"2017-06-22T00:41:44Z","updated_at":"2017-06-22T00:41:49Z","pushed_at":"2017-06-22T01:39:14Z","git_url":"git://github.com/biozal/MvvmCross.git","ssh_url":"git@github.com:biozal/MvvmCross.git","clone_url":"https://github.com/biozal/MvvmCross.git","svn_url":"https://github.com/biozal/MvvmCross","homepage":"http://mvvmcross.com","size":63925,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MvvmCross:develop","ref":"develop","sha":"2ae765ee60e39740aea10812a840585d64cdd91f","user":{"login":"MvvmCross","id":3919206,"avatar_url":"https://avatars2.githubusercontent.com/u/3919206?v=3","gravatar_id":"","url":"https://api.github.com/users/MvvmCross","html_url":"https://github.com/MvvmCross","followers_url":"https://api.github.com/users/MvvmCross/followers","following_url":"https://api.github.com/users/MvvmCross/following{/other_user}","gists_url":"https://api.github.com/users/MvvmCross/gists{/gist_id}","starred_url":"https://api.github.com/users/MvvmCross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MvvmCross/subscriptions","organizations_url":"https://api.github.com/users/MvvmCross/orgs","repos_url":"https://api.github.com/users/MvvmCross/repos","events_url":"https://api.github.com/users/MvvmCross/events{/privacy}","received_events_url":"https://api.github.com/users/MvvmCross/received_events","type":"Organization","site_admin":false},"repo":{"id":2870911,"name":"MvvmCross","full_name":"MvvmCross/MvvmCross","owner":{"login":"MvvmCross","id":3919206,"avatar_url":"https://avatars2.githubusercontent.com/u/3919206?v=3","gravatar_id":"","url":"https://api.github.com/users/MvvmCross","html_url":"https://github.com/MvvmCross","followers_url":"https://api.github.com/users/MvvmCross/followers","following_url":"https://api.github.com/users/MvvmCross/following{/other_user}","gists_url":"https://api.github.com/users/MvvmCross/gists{/gist_id}","starred_url":"https://api.github.com/users/MvvmCross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MvvmCross/subscriptions","organizations_url":"https://api.github.com/users/MvvmCross/orgs","repos_url":"https://api.github.com/users/MvvmCross/repos","events_url":"https://api.github.com/users/MvvmCross/events{/privacy}","received_events_url":"https://api.github.com/users/MvvmCross/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MvvmCross/MvvmCross","description":"The .NET MVVM framework for cross-platform solutions, including Xamarin.iOS, Xamarin.Android, Windows and Mac.","fork":false,"url":"https://api.github.com/repos/MvvmCross/MvvmCross","forks_url":"https://api.github.com/repos/MvvmCross/MvvmCross/forks","keys_url":"https://api.github.com/repos/MvvmCross/MvvmCross/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MvvmCross/MvvmCross/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MvvmCross/MvvmCross/teams","hooks_url":"https://api.github.com/repos/MvvmCross/MvvmCross/hooks","issue_events_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/events{/number}","events_url":"https://api.github.com/repos/MvvmCross/MvvmCross/events","assignees_url":"https://api.github.com/repos/MvvmCross/MvvmCross/assignees{/user}","branches_url":"https://api.github.com/repos/MvvmCross/MvvmCross/branches{/branch}","tags_url":"https://api.github.com/repos/MvvmCross/MvvmCross/tags","blobs_url":"https://api.github.com/repos/MvvmCross/MvvmCross/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MvvmCross/MvvmCross/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MvvmCross/MvvmCross/git/refs{/sha}","trees_url":"https://api.github.com/repos/MvvmCross/MvvmCross/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MvvmCross/MvvmCross/statuses/{sha}","languages_url":"https://api.github.com/repos/MvvmCross/MvvmCross/languages","stargazers_url":"https://api.github.com/repos/MvvmCross/MvvmCross/stargazers","contributors_url":"https://api.github.com/repos/MvvmCross/MvvmCross/contributors","subscribers_url":"https://api.github.com/repos/MvvmCross/MvvmCross/subscribers","subscription_url":"https://api.github.com/repos/MvvmCross/MvvmCross/subscription","commits_url":"https://api.github.com/repos/MvvmCross/MvvmCross/commits{/sha}","git_commits_url":"https://api.github.com/repos/MvvmCross/MvvmCross/git/commits{/sha}","comments_url":"https://api.github.com/repos/MvvmCross/MvvmCross/comments{/number}","issue_comment_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/comments{/number}","contents_url":"https://api.github.com/repos/MvvmCross/MvvmCross/contents/{+path}","compare_url":"https://api.github.com/repos/MvvmCross/MvvmCross/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MvvmCross/MvvmCross/merges","archive_url":"https://api.github.com/repos/MvvmCross/MvvmCross/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MvvmCross/MvvmCross/downloads","issues_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues{/number}","pulls_url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls{/number}","milestones_url":"https://api.github.com/repos/MvvmCross/MvvmCross/milestones{/number}","notifications_url":"https://api.github.com/repos/MvvmCross/MvvmCross/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MvvmCross/MvvmCross/labels{/name}","releases_url":"https://api.github.com/repos/MvvmCross/MvvmCross/releases{/id}","deployments_url":"https://api.github.com/repos/MvvmCross/MvvmCross/deployments","created_at":"2011-11-28T22:45:55Z","updated_at":"2017-06-21T19:00:40Z","pushed_at":"2017-06-22T07:51:54Z","git_url":"git://github.com/MvvmCross/MvvmCross.git","ssh_url":"git@github.com:MvvmCross/MvvmCross.git","clone_url":"https://github.com/MvvmCross/MvvmCross.git","svn_url":"https://github.com/MvvmCross/MvvmCross","homepage":"http://mvvmcross.com","size":63946,"stargazers_count":2043,"watchers_count":2043,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":774,"mirror_url":null,"open_issues_count":120,"forks":774,"open_issues":120,"watchers":2043,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/1984"},"html":{"href":"https://github.com/MvvmCross/MvvmCross/pull/1984"},"issue":{"href":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1984"},"comments":{"href":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/1984/comments"},"review_comments":{"href":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/1984/comments"},"review_comment":{"href":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/1984/commits"},"statuses":{"href":"https://api.github.com/repos/MvvmCross/MvvmCross/statuses/d976dec5787e460db684dc8ca396dd09d4bf2789"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Cheesebaron","id":249719,"avatar_url":"https://avatars0.githubusercontent.com/u/249719?v=3","gravatar_id":"","url":"https://api.github.com/users/Cheesebaron","html_url":"https://github.com/Cheesebaron","followers_url":"https://api.github.com/users/Cheesebaron/followers","following_url":"https://api.github.com/users/Cheesebaron/following{/other_user}","gists_url":"https://api.github.com/users/Cheesebaron/gists{/gist_id}","starred_url":"https://api.github.com/users/Cheesebaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cheesebaron/subscriptions","organizations_url":"https://api.github.com/users/Cheesebaron/orgs","repos_url":"https://api.github.com/users/Cheesebaron/repos","events_url":"https://api.github.com/users/Cheesebaron/events{/privacy}","received_events_url":"https://api.github.com/users/Cheesebaron/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":29,"deletions":2,"changed_files":6}}
{"actor":{"display_login":"Cheesebaron"}}