{"action":"opened","number":261,"pull_request":{"url":"https://api.github.com/repos/intel-ros/realsense/pulls/261","id":135472985,"html_url":"https://github.com/intel-ros/realsense/pull/261","diff_url":"https://github.com/intel-ros/realsense/pull/261.diff","patch_url":"https://github.com/intel-ros/realsense/pull/261.patch","issue_url":"https://api.github.com/repos/intel-ros/realsense/issues/261","number":261,"state":"open","locked":false,"title":"Fix R200 color cloud misalignment by using rectified color calibration","user":{"login":"skohlbr","id":205963,"avatar_url":"https://avatars0.githubusercontent.com/u/205963?v=4","gravatar_id":"","url":"https://api.github.com/users/skohlbr","html_url":"https://github.com/skohlbr","followers_url":"https://api.github.com/users/skohlbr/followers","following_url":"https://api.github.com/users/skohlbr/following{/other_user}","gists_url":"https://api.github.com/users/skohlbr/gists{/gist_id}","starred_url":"https://api.github.com/users/skohlbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skohlbr/subscriptions","organizations_url":"https://api.github.com/users/skohlbr/orgs","repos_url":"https://api.github.com/users/skohlbr/repos","events_url":"https://api.github.com/users/skohlbr/events{/privacy}","received_events_url":"https://api.github.com/users/skohlbr/received_events","type":"User","site_admin":false},"body":"This PR vastly improves R200 cloud/color camera alignment issues reported in issues stated below.\r\n \r\nFixes Issue: #30,  #184, #201, #233\r\n\r\nChanges proposed in this pull request:\r\n- Use rectified camera stream calibration instead of unrectified. It has to be noted that while this improves alignment significantly, the correct way to do things would be to use the rectified color stream consistently for the R200. As a lot of the stream handling is done in base_nodelet for all camera types, performing the necessary changes without breaking other cameras (SR300 etc.) is not trivial (also applies to this PR as it is). Looking for feedback by the maintainers. See #201 for details of how this PR came about (screenshots etc.).\r\n\r\n","created_at":"2017-08-12T21:10:03Z","updated_at":"2017-08-12T21:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel-ros/realsense/pulls/261/commits","review_comments_url":"https://api.github.com/repos/intel-ros/realsense/pulls/261/comments","review_comment_url":"https://api.github.com/repos/intel-ros/realsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel-ros/realsense/issues/261/comments","statuses_url":"https://api.github.com/repos/intel-ros/realsense/statuses/3e4e6da2eb2da32c6a4c8015f8b61cb4b6489d6a","head":{"label":"skohlbr:fix_cloud_color_misalignment","ref":"fix_cloud_color_misalignment","sha":"3e4e6da2eb2da32c6a4c8015f8b61cb4b6489d6a","user":{"login":"skohlbr","id":205963,"avatar_url":"https://avatars0.githubusercontent.com/u/205963?v=4","gravatar_id":"","url":"https://api.github.com/users/skohlbr","html_url":"https://github.com/skohlbr","followers_url":"https://api.github.com/users/skohlbr/followers","following_url":"https://api.github.com/users/skohlbr/following{/other_user}","gists_url":"https://api.github.com/users/skohlbr/gists{/gist_id}","starred_url":"https://api.github.com/users/skohlbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skohlbr/subscriptions","organizations_url":"https://api.github.com/users/skohlbr/orgs","repos_url":"https://api.github.com/users/skohlbr/repos","events_url":"https://api.github.com/users/skohlbr/events{/privacy}","received_events_url":"https://api.github.com/users/skohlbr/received_events","type":"User","site_admin":false},"repo":{"id":80410710,"name":"realsense","full_name":"skohlbr/realsense","owner":{"login":"skohlbr","id":205963,"avatar_url":"https://avatars0.githubusercontent.com/u/205963?v=4","gravatar_id":"","url":"https://api.github.com/users/skohlbr","html_url":"https://github.com/skohlbr","followers_url":"https://api.github.com/users/skohlbr/followers","following_url":"https://api.github.com/users/skohlbr/following{/other_user}","gists_url":"https://api.github.com/users/skohlbr/gists{/gist_id}","starred_url":"https://api.github.com/users/skohlbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skohlbr/subscriptions","organizations_url":"https://api.github.com/users/skohlbr/orgs","repos_url":"https://api.github.com/users/skohlbr/repos","events_url":"https://api.github.com/users/skohlbr/events{/privacy}","received_events_url":"https://api.github.com/users/skohlbr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skohlbr/realsense","description":"Intel(R) RealSense(TM) ROS Camera","fork":true,"url":"https://api.github.com/repos/skohlbr/realsense","forks_url":"https://api.github.com/repos/skohlbr/realsense/forks","keys_url":"https://api.github.com/repos/skohlbr/realsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skohlbr/realsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skohlbr/realsense/teams","hooks_url":"https://api.github.com/repos/skohlbr/realsense/hooks","issue_events_url":"https://api.github.com/repos/skohlbr/realsense/issues/events{/number}","events_url":"https://api.github.com/repos/skohlbr/realsense/events","assignees_url":"https://api.github.com/repos/skohlbr/realsense/assignees{/user}","branches_url":"https://api.github.com/repos/skohlbr/realsense/branches{/branch}","tags_url":"https://api.github.com/repos/skohlbr/realsense/tags","blobs_url":"https://api.github.com/repos/skohlbr/realsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skohlbr/realsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skohlbr/realsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/skohlbr/realsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skohlbr/realsense/statuses/{sha}","languages_url":"https://api.github.com/repos/skohlbr/realsense/languages","stargazers_url":"https://api.github.com/repos/skohlbr/realsense/stargazers","contributors_url":"https://api.github.com/repos/skohlbr/realsense/contributors","subscribers_url":"https://api.github.com/repos/skohlbr/realsense/subscribers","subscription_url":"https://api.github.com/repos/skohlbr/realsense/subscription","commits_url":"https://api.github.com/repos/skohlbr/realsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/skohlbr/realsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/skohlbr/realsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/skohlbr/realsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/skohlbr/realsense/contents/{+path}","compare_url":"https://api.github.com/repos/skohlbr/realsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skohlbr/realsense/merges","archive_url":"https://api.github.com/repos/skohlbr/realsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skohlbr/realsense/downloads","issues_url":"https://api.github.com/repos/skohlbr/realsense/issues{/number}","pulls_url":"https://api.github.com/repos/skohlbr/realsense/pulls{/number}","milestones_url":"https://api.github.com/repos/skohlbr/realsense/milestones{/number}","notifications_url":"https://api.github.com/repos/skohlbr/realsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skohlbr/realsense/labels{/name}","releases_url":"https://api.github.com/repos/skohlbr/realsense/releases{/id}","deployments_url":"https://api.github.com/repos/skohlbr/realsense/deployments","created_at":"2017-01-30T10:11:40Z","updated_at":"2017-06-07T23:01:14Z","pushed_at":"2017-08-12T20:57:31Z","git_url":"git://github.com/skohlbr/realsense.git","ssh_url":"git@github.com:skohlbr/realsense.git","clone_url":"https://github.com/skohlbr/realsense.git","svn_url":"https://github.com/skohlbr/realsense","homepage":"http://wiki.ros.org/RealSense","size":1998,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"indigo-devel"}},"base":{"label":"intel-ros:indigo-devel","ref":"indigo-devel","sha":"3a95351c5bae0502a38f224397c5b35c5f97b63e","user":{"login":"intel-ros","id":16890105,"avatar_url":"https://avatars3.githubusercontent.com/u/16890105?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-ros","html_url":"https://github.com/intel-ros","followers_url":"https://api.github.com/users/intel-ros/followers","following_url":"https://api.github.com/users/intel-ros/following{/other_user}","gists_url":"https://api.github.com/users/intel-ros/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-ros/subscriptions","organizations_url":"https://api.github.com/users/intel-ros/orgs","repos_url":"https://api.github.com/users/intel-ros/repos","events_url":"https://api.github.com/users/intel-ros/events{/privacy}","received_events_url":"https://api.github.com/users/intel-ros/received_events","type":"Organization","site_admin":false},"repo":{"id":52400453,"name":"realsense","full_name":"intel-ros/realsense","owner":{"login":"intel-ros","id":16890105,"avatar_url":"https://avatars3.githubusercontent.com/u/16890105?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-ros","html_url":"https://github.com/intel-ros","followers_url":"https://api.github.com/users/intel-ros/followers","following_url":"https://api.github.com/users/intel-ros/following{/other_user}","gists_url":"https://api.github.com/users/intel-ros/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-ros/subscriptions","organizations_url":"https://api.github.com/users/intel-ros/orgs","repos_url":"https://api.github.com/users/intel-ros/repos","events_url":"https://api.github.com/users/intel-ros/events{/privacy}","received_events_url":"https://api.github.com/users/intel-ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-ros/realsense","description":"Intel(R) RealSense(TM) ROS Camera","fork":false,"url":"https://api.github.com/repos/intel-ros/realsense","forks_url":"https://api.github.com/repos/intel-ros/realsense/forks","keys_url":"https://api.github.com/repos/intel-ros/realsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-ros/realsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-ros/realsense/teams","hooks_url":"https://api.github.com/repos/intel-ros/realsense/hooks","issue_events_url":"https://api.github.com/repos/intel-ros/realsense/issues/events{/number}","events_url":"https://api.github.com/repos/intel-ros/realsense/events","assignees_url":"https://api.github.com/repos/intel-ros/realsense/assignees{/user}","branches_url":"https://api.github.com/repos/intel-ros/realsense/branches{/branch}","tags_url":"https://api.github.com/repos/intel-ros/realsense/tags","blobs_url":"https://api.github.com/repos/intel-ros/realsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-ros/realsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-ros/realsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-ros/realsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-ros/realsense/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-ros/realsense/languages","stargazers_url":"https://api.github.com/repos/intel-ros/realsense/stargazers","contributors_url":"https://api.github.com/repos/intel-ros/realsense/contributors","subscribers_url":"https://api.github.com/repos/intel-ros/realsense/subscribers","subscription_url":"https://api.github.com/repos/intel-ros/realsense/subscription","commits_url":"https://api.github.com/repos/intel-ros/realsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-ros/realsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-ros/realsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-ros/realsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-ros/realsense/contents/{+path}","compare_url":"https://api.github.com/repos/intel-ros/realsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-ros/realsense/merges","archive_url":"https://api.github.com/repos/intel-ros/realsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-ros/realsense/downloads","issues_url":"https://api.github.com/repos/intel-ros/realsense/issues{/number}","pulls_url":"https://api.github.com/repos/intel-ros/realsense/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-ros/realsense/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-ros/realsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-ros/realsense/labels{/name}","releases_url":"https://api.github.com/repos/intel-ros/realsense/releases{/id}","deployments_url":"https://api.github.com/repos/intel-ros/realsense/deployments","created_at":"2016-02-23T23:52:58Z","updated_at":"2017-08-05T02:42:06Z","pushed_at":"2017-08-10T10:21:32Z","git_url":"git://github.com/intel-ros/realsense.git","ssh_url":"git@github.com:intel-ros/realsense.git","clone_url":"https://github.com/intel-ros/realsense.git","svn_url":"https://github.com/intel-ros/realsense","homepage":"http://wiki.ros.org/RealSense","size":2118,"stargazers_count":138,"watchers_count":138,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":26,"forks":145,"open_issues":26,"watchers":138,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/intel-ros/realsense/pulls/261"},"html":{"href":"https://github.com/intel-ros/realsense/pull/261"},"issue":{"href":"https://api.github.com/repos/intel-ros/realsense/issues/261"},"comments":{"href":"https://api.github.com/repos/intel-ros/realsense/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/intel-ros/realsense/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/intel-ros/realsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel-ros/realsense/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/intel-ros/realsense/statuses/3e4e6da2eb2da32c6a4c8015f8b61cb4b6489d6a"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"skohlbr"}}