{"action":"opened","number":422,"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/422","id":128781820,"html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/422","diff_url":"https://github.com/clojure-emacs/cider-nrepl/pull/422.diff","patch_url":"https://github.com/clojure-emacs/cider-nrepl/pull/422.patch","issue_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/422","number":422,"state":"open","locked":false,"title":"Find relative path for cljs & boot in info [#421]","user":{"login":"SevereOverfl0w","id":6136282,"avatar_url":"https://avatars3.githubusercontent.com/u/6136282?v=3","gravatar_id":"","url":"https://api.github.com/users/SevereOverfl0w","html_url":"https://github.com/SevereOverfl0w","followers_url":"https://api.github.com/users/SevereOverfl0w/followers","following_url":"https://api.github.com/users/SevereOverfl0w/following{/other_user}","gists_url":"https://api.github.com/users/SevereOverfl0w/gists{/gist_id}","starred_url":"https://api.github.com/users/SevereOverfl0w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SevereOverfl0w/subscriptions","organizations_url":"https://api.github.com/users/SevereOverfl0w/orgs","repos_url":"https://api.github.com/users/SevereOverfl0w/repos","events_url":"https://api.github.com/users/SevereOverfl0w/events{/privacy}","received_events_url":"https://api.github.com/users/SevereOverfl0w/received_events","type":"User","site_admin":false},"body":"This fixes a case where in clojurescript the `:file` is stored as an\r\nabsolute path, meaning it points to a temporary file in boot.\r\n\r\nIt uses java.nio.file.Path to find all paths with the prefixes deleted,\r\nand filters them until it finds one on the classpath. This implicitly\r\nfinds the longest one.\r\n\r\nIf it cannot find a contracted version of the file on the classpath, it\r\nwill pass through the original absolute path which points to a temporary\r\nfile.\r\n\r\nA small optimisation here is doing this only for boot. But that does\r\nmean that the results will be different for boot & lein as opposed to\r\npreviously where it was clj & cljs. I've not tested if there's a\r\nperformance improvement, but it will likely reduce unexpected behaviour.\r\n\r\n| | CLJ | CLJS |\r\n|-|-----|----------\r\n| Boot | `:resource` |`:resource` most of the time |\r\n| Lein | `:resource` | `:resource` unset |\r\n\r\nCurrently cljs never has `:resource`. I have no idea if this will matter\r\nto any consumers, only future ones if at all, and it can be enabled by\r\ndisabling the check.\r\n\r\n- [X] The commits are consistent with our [contribution guidelines](CONTRIBUTING.md). *NB: I'm skipping the testing because it would require launching a real version of boot, which is a major extension to the testing*\r\n- [X] You've added tests to cover your change(s)\r\n- [X] All tests are passing\r\n- [X] The new code is not generating reflection warnings *NB: Doesn't seem to be*\r\n- [X] You've updated the readme (if adding/changing middleware)\r\n","created_at":"2017-07-04T11:22:37Z","updated_at":"2017-07-04T11:22:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/422/commits","review_comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/422/comments","review_comment_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/422/comments","statuses_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/74f12689f1893056435868bbda3931f24e30c09a","head":{"label":"SevereOverfl0w:bootinfotemppath","ref":"bootinfotemppath","sha":"74f12689f1893056435868bbda3931f24e30c09a","user":{"login":"SevereOverfl0w","id":6136282,"avatar_url":"https://avatars3.githubusercontent.com/u/6136282?v=3","gravatar_id":"","url":"https://api.github.com/users/SevereOverfl0w","html_url":"https://github.com/SevereOverfl0w","followers_url":"https://api.github.com/users/SevereOverfl0w/followers","following_url":"https://api.github.com/users/SevereOverfl0w/following{/other_user}","gists_url":"https://api.github.com/users/SevereOverfl0w/gists{/gist_id}","starred_url":"https://api.github.com/users/SevereOverfl0w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SevereOverfl0w/subscriptions","organizations_url":"https://api.github.com/users/SevereOverfl0w/orgs","repos_url":"https://api.github.com/users/SevereOverfl0w/repos","events_url":"https://api.github.com/users/SevereOverfl0w/events{/privacy}","received_events_url":"https://api.github.com/users/SevereOverfl0w/received_events","type":"User","site_admin":false},"repo":{"id":51830254,"name":"cider-nrepl","full_name":"SevereOverfl0w/cider-nrepl","owner":{"login":"SevereOverfl0w","id":6136282,"avatar_url":"https://avatars3.githubusercontent.com/u/6136282?v=3","gravatar_id":"","url":"https://api.github.com/users/SevereOverfl0w","html_url":"https://github.com/SevereOverfl0w","followers_url":"https://api.github.com/users/SevereOverfl0w/followers","following_url":"https://api.github.com/users/SevereOverfl0w/following{/other_user}","gists_url":"https://api.github.com/users/SevereOverfl0w/gists{/gist_id}","starred_url":"https://api.github.com/users/SevereOverfl0w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SevereOverfl0w/subscriptions","organizations_url":"https://api.github.com/users/SevereOverfl0w/orgs","repos_url":"https://api.github.com/users/SevereOverfl0w/repos","events_url":"https://api.github.com/users/SevereOverfl0w/events{/privacy}","received_events_url":"https://api.github.com/users/SevereOverfl0w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SevereOverfl0w/cider-nrepl","description":"nREPL middleware for CIDER","fork":true,"url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl","forks_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/forks","keys_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/teams","hooks_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/hooks","issue_events_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/events","assignees_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/tags","blobs_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/languages","stargazers_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/stargazers","contributors_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/contributors","subscribers_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/subscribers","subscription_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/subscription","commits_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/merges","archive_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/downloads","issues_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/SevereOverfl0w/cider-nrepl/deployments","created_at":"2016-02-16T11:12:00Z","updated_at":"2016-02-16T11:12:01Z","pushed_at":"2017-07-04T11:15:08Z","git_url":"git://github.com/SevereOverfl0w/cider-nrepl.git","ssh_url":"git@github.com:SevereOverfl0w/cider-nrepl.git","clone_url":"https://github.com/SevereOverfl0w/cider-nrepl.git","svn_url":"https://github.com/SevereOverfl0w/cider-nrepl","homepage":null,"size":1069,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clojure-emacs:master","ref":"master","sha":"636ee9423941c7cc821a6abc0c7b611db22f15a4","user":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars3.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":15360927,"name":"cider-nrepl","full_name":"clojure-emacs/cider-nrepl","owner":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars3.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clojure-emacs/cider-nrepl","description":"nREPL middleware for CIDER","fork":false,"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl","forks_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/forks","keys_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/events","assignees_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/merges","archive_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/deployments","created_at":"2013-12-21T15:27:38Z","updated_at":"2017-06-29T09:52:11Z","pushed_at":"2017-07-01T06:52:21Z","git_url":"git://github.com/clojure-emacs/cider-nrepl.git","ssh_url":"git@github.com:clojure-emacs/cider-nrepl.git","clone_url":"https://github.com/clojure-emacs/cider-nrepl.git","svn_url":"https://github.com/clojure-emacs/cider-nrepl","homepage":null,"size":1138,"stargazers_count":294,"watchers_count":294,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":21,"forks":95,"open_issues":21,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/422"},"html":{"href":"https://github.com/clojure-emacs/cider-nrepl/pull/422"},"issue":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/422"},"comments":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/74f12689f1893056435868bbda3931f24e30c09a"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"SevereOverfl0w"}}