{"action":"created","issue":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/7840","repository_url":"https://api.github.com/repos/dmwm/WMCore","labels_url":"https://api.github.com/repos/dmwm/WMCore/issues/7840/labels{/name}","comments_url":"https://api.github.com/repos/dmwm/WMCore/issues/7840/comments","events_url":"https://api.github.com/repos/dmwm/WMCore/issues/7840/events","html_url":"https://github.com/dmwm/WMCore/issues/7840","id":226565259,"number":7840,"title":"Retrieve assignment default arguments for assignment via web UI","user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars3.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dmwm/WMCore/milestones/136","html_url":"https://github.com/dmwm/WMCore/milestone/136","labels_url":"https://api.github.com/repos/dmwm/WMCore/milestones/136/labels","id":2188337,"number":136,"title":"WMAgent1705","description":"","creator":{"login":"ticoann","id":1247993,"avatar_url":"https://avatars3.githubusercontent.com/u/1247993?v=3","gravatar_id":"","url":"https://api.github.com/users/ticoann","html_url":"https://github.com/ticoann","followers_url":"https://api.github.com/users/ticoann/followers","following_url":"https://api.github.com/users/ticoann/following{/other_user}","gists_url":"https://api.github.com/users/ticoann/gists{/gist_id}","starred_url":"https://api.github.com/users/ticoann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ticoann/subscriptions","organizations_url":"https://api.github.com/users/ticoann/orgs","repos_url":"https://api.github.com/users/ticoann/repos","events_url":"https://api.github.com/users/ticoann/events{/privacy}","received_events_url":"https://api.github.com/users/ticoann/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":4,"state":"open","created_at":"2016-12-10T04:43:41Z","updated_at":"2017-05-05T12:59:21Z","due_on":"2017-05-31T07:00:00Z","closed_at":null},"comments":2,"created_at":"2017-05-05T12:59:16Z","updated_at":"2017-05-08T10:40:47Z","closed_at":null,"body":"Since we separated the creation from assignment arguments, the ReqMgr2 assignment form no longer shows the default assignment values for some of those arguments (merge and block args in general).\r\n\r\nWe should change it such that:\r\n1) it retrieves the assignment arguments definition, as in:\r\nhttps://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMSpec/StdSpecs/StdBase.py#L1042\r\n2) it retrieves the request dictionary (it already does)\r\n3) then it overrides the default arguments by the request one\r\n4) fill in the form with the pre-selected values."},"comment":{"url":"https://api.github.com/repos/dmwm/WMCore/issues/comments/299833490","html_url":"https://github.com/dmwm/WMCore/issues/7840#issuecomment-299833490","issue_url":"https://api.github.com/repos/dmwm/WMCore/issues/7840","id":299833490,"user":{"login":"amaltaro","id":1798520,"avatar_url":"https://avatars3.githubusercontent.com/u/1798520?v=3","gravatar_id":"","url":"https://api.github.com/users/amaltaro","html_url":"https://github.com/amaltaro","followers_url":"https://api.github.com/users/amaltaro/followers","following_url":"https://api.github.com/users/amaltaro/following{/other_user}","gists_url":"https://api.github.com/users/amaltaro/gists{/gist_id}","starred_url":"https://api.github.com/users/amaltaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaltaro/subscriptions","organizations_url":"https://api.github.com/users/amaltaro/orgs","repos_url":"https://api.github.com/users/amaltaro/repos","events_url":"https://api.github.com/users/amaltaro/events{/privacy}","received_events_url":"https://api.github.com/users/amaltaro/received_events","type":"User","site_admin":false},"created_at":"2017-05-08T10:40:47Z","updated_at":"2017-05-08T10:40:47Z","body":"Valentin, I'm talking about the \"Assign\" page, for example this workflow is GOOD and it has all the default values already set in the web form (because their json has ALL key/value args since its creation):\r\nhttps://cmsweb-testbed.cern.ch/reqmgr2/fetch?rid=amaltaro_ReDigi_BadTier_HG1704_Validation_170327_150804_7008\r\n\r\non the other hand, this workflow Assign page is BAD, as you can see there are lots of unfilled fields (because we still don't have several key args in the request json):\r\nhttps://cmsweb-testbed.cern.ch/reqmgr2/fetch?rid=amaltaro_TaskChain_EpL_HG1705_Validation_170426_211542_1394\r\n\r\nHmm, we already have these args hard-coded here:\r\nhttps://github.com/dmwm/WMCore/blob/master/src/python/WMCore/ReqMgr/Web/ReqMgrService.py#L394\r\n\r\nwhy they don't show up in the web form then?\r\nBesides that, my initial suggestion is to get rid of these args and fetch them from StdBase specification (my first comment here), and cache it in memory, since it only changes during cmsweb deployments."}}
{"actor":{"display_login":"amaltaro"}}