{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/136150476","pull_request_review_id":59649219,"id":136150476,"diff_hunk":"@@ -338,7 +338,7 @@ var reset = (doneP) => {\n   if (!doneP) files.push(statePath)\n   files.forEach((file) => {\n     fs.unlink(pathName(file), (err) => {\n-      if ((err) && (err.code !== 'ENOENT')) console.log(err)\n+      if ((err) && (err.code !== 'ENOENT')) console.error(err)","path":"app/ledger.js","position":32,"original_position":32,"commit_id":"2045098aa3eb61e4a935f2af98ac7f9265665613","original_commit_id":"2045098aa3eb61e4a935f2af98ac7f9265665613","user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"body":"It might be helpful to also add in where it failed.  For example: `console.error('Error when deleting file \"' + file + '\": ', err)` ","created_at":"2017-08-30T18:20:24Z","updated_at":"2017-08-30T18:20:24Z","html_url":"https://github.com/brave/browser-laptop/pull/10722#discussion_r136150476","pull_request_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10722","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/136150476"},"html":{"href":"https://github.com/brave/browser-laptop/pull/10722#discussion_r136150476"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10722"}}},"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/10722","id":138471869,"html_url":"https://github.com/brave/browser-laptop/pull/10722","diff_url":"https://github.com/brave/browser-laptop/pull/10722.diff","patch_url":"https://github.com/brave/browser-laptop/pull/10722.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/10722","number":10722,"state":"open","locked":false,"title":"Switch console.log to console.error or console.warn where appropriate","user":{"login":"sjlehn","id":6686486,"avatar_url":"https://avatars2.githubusercontent.com/u/6686486?v=4","gravatar_id":"","url":"https://api.github.com/users/sjlehn","html_url":"https://github.com/sjlehn","followers_url":"https://api.github.com/users/sjlehn/followers","following_url":"https://api.github.com/users/sjlehn/following{/other_user}","gists_url":"https://api.github.com/users/sjlehn/gists{/gist_id}","starred_url":"https://api.github.com/users/sjlehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjlehn/subscriptions","organizations_url":"https://api.github.com/users/sjlehn/orgs","repos_url":"https://api.github.com/users/sjlehn/repos","events_url":"https://api.github.com/users/sjlehn/events{/privacy}","received_events_url":"https://api.github.com/users/sjlehn/received_events","type":"User","site_admin":false},"body":"Closes brave/browser-laptop#10581\r\n\r\nSubmitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n\r\nTest Plan:\r\n\r\n\r\nReviewer Checklist:\r\n\r\nTests\r\n\r\n\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n","created_at":"2017-08-30T16:28:31Z","updated_at":"2017-08-30T18:20:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb12eaccf100f284e9427d4f6aa2abd84a346922","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10722/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10722/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/10722/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/2045098aa3eb61e4a935f2af98ac7f9265665613","head":{"label":"sjlehn:browser-laptop-10581","ref":"browser-laptop-10581","sha":"2045098aa3eb61e4a935f2af98ac7f9265665613","user":{"login":"sjlehn","id":6686486,"avatar_url":"https://avatars2.githubusercontent.com/u/6686486?v=4","gravatar_id":"","url":"https://api.github.com/users/sjlehn","html_url":"https://github.com/sjlehn","followers_url":"https://api.github.com/users/sjlehn/followers","following_url":"https://api.github.com/users/sjlehn/following{/other_user}","gists_url":"https://api.github.com/users/sjlehn/gists{/gist_id}","starred_url":"https://api.github.com/users/sjlehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjlehn/subscriptions","organizations_url":"https://api.github.com/users/sjlehn/orgs","repos_url":"https://api.github.com/users/sjlehn/repos","events_url":"https://api.github.com/users/sjlehn/events{/privacy}","received_events_url":"https://api.github.com/users/sjlehn/received_events","type":"User","site_admin":false},"repo":{"id":101900248,"name":"browser-laptop","full_name":"sjlehn/browser-laptop","owner":{"login":"sjlehn","id":6686486,"avatar_url":"https://avatars2.githubusercontent.com/u/6686486?v=4","gravatar_id":"","url":"https://api.github.com/users/sjlehn","html_url":"https://github.com/sjlehn","followers_url":"https://api.github.com/users/sjlehn/followers","following_url":"https://api.github.com/users/sjlehn/following{/other_user}","gists_url":"https://api.github.com/users/sjlehn/gists{/gist_id}","starred_url":"https://api.github.com/users/sjlehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjlehn/subscriptions","organizations_url":"https://api.github.com/users/sjlehn/orgs","repos_url":"https://api.github.com/users/sjlehn/repos","events_url":"https://api.github.com/users/sjlehn/events{/privacy}","received_events_url":"https://api.github.com/users/sjlehn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjlehn/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/sjlehn/browser-laptop","forks_url":"https://api.github.com/repos/sjlehn/browser-laptop/forks","keys_url":"https://api.github.com/repos/sjlehn/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjlehn/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjlehn/browser-laptop/teams","hooks_url":"https://api.github.com/repos/sjlehn/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/sjlehn/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/sjlehn/browser-laptop/events","assignees_url":"https://api.github.com/repos/sjlehn/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/sjlehn/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/sjlehn/browser-laptop/tags","blobs_url":"https://api.github.com/repos/sjlehn/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjlehn/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjlehn/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjlehn/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjlehn/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/sjlehn/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/sjlehn/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/sjlehn/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/sjlehn/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/sjlehn/browser-laptop/subscription","commits_url":"https://api.github.com/repos/sjlehn/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjlehn/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjlehn/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjlehn/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjlehn/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/sjlehn/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjlehn/browser-laptop/merges","archive_url":"https://api.github.com/repos/sjlehn/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjlehn/browser-laptop/downloads","issues_url":"https://api.github.com/repos/sjlehn/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/sjlehn/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/sjlehn/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/sjlehn/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjlehn/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/sjlehn/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/sjlehn/browser-laptop/deployments","created_at":"2017-08-30T15:46:51Z","updated_at":"2017-08-30T15:46:57Z","pushed_at":"2017-08-30T16:26:18Z","git_url":"git://github.com/sjlehn/browser-laptop.git","ssh_url":"git@github.com:sjlehn/browser-laptop.git","clone_url":"https://github.com/sjlehn/browser-laptop.git","svn_url":"https://github.com/sjlehn/browser-laptop","homepage":"https://www.brave.com","size":52813,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"f9f4aeb83573e3475af4cfab05592c6f796032a1","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2017-08-30T16:37:41Z","pushed_at":"2017-08-30T16:42:17Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":52810,"stargazers_count":5638,"watchers_count":5638,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":675,"mirror_url":null,"open_issues_count":2477,"forks":675,"open_issues":2477,"watchers":5638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10722"},"html":{"href":"https://github.com/brave/browser-laptop/pull/10722"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/10722"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/10722/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10722/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10722/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/2045098aa3eb61e4a935f2af98ac7f9265665613"}},"author_association":"NONE"}}
{"actor":{"display_login":"bsclifton"}}