{"action":"created","comment":{"url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/comments/121930049","pull_request_review_id":43998198,"id":121930049,"diff_hunk":"@@ -161,10 +163,16 @@ func (o *SignalFxFirehoseNozzle) datapointsFromEnvelope(envelope *events.Envelop\n         dimensions[\"app_instance_index\"] = strconv.Itoa(int(contMetric.GetInstanceIndex()))\n         dimensions[\"app_id\"] = guid\n \n+        // Send app metadata as both dims and properties since navigator views\n+        // seem to really want them as properties.\n         properties[\"app_name\"] = o.metadataFetcher.GetAppNameForGUID(guid)\n         properties[\"app_space\"] = o.metadataFetcher.GetSpaceNameForGUID(guid)\n         properties[\"app_org\"] = o.metadataFetcher.GetOrgNameForGUID(guid)\n \n+        dimensions[\"app_name\"] = properties[\"app_name\"]","path":"metrics/firehose_nozzle.go","position":19,"original_position":19,"commit_id":"0e2ab2680568a096ebe22208c054b8e3768ddd22","original_commit_id":"0e2ab2680568a096ebe22208c054b8e3768ddd22","user":{"login":"keitwb","id":614344,"avatar_url":"https://avatars1.githubusercontent.com/u/614344?v=3","gravatar_id":"","url":"https://api.github.com/users/keitwb","html_url":"https://github.com/keitwb","followers_url":"https://api.github.com/users/keitwb/followers","following_url":"https://api.github.com/users/keitwb/following{/other_user}","gists_url":"https://api.github.com/users/keitwb/gists{/gist_id}","starred_url":"https://api.github.com/users/keitwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keitwb/subscriptions","organizations_url":"https://api.github.com/users/keitwb/orgs","repos_url":"https://api.github.com/users/keitwb/repos","events_url":"https://api.github.com/users/keitwb/events{/privacy}","received_events_url":"https://api.github.com/users/keitwb/received_events","type":"User","site_admin":false},"body":"When selecting what fields to show in charts (e.g. in list charts, which items to show as the item name) they have to be dimensions, properties don't show up.  In the navigator views, when selecting what to show in the list below the heatmap as well as what shows up in the tooltip for each host, they seem to have to be properties to work.  Dimensions don't work based on my testing.\r\n\r\nIf you know any other workarounds let me know.","created_at":"2017-06-14T12:20:41Z","updated_at":"2017-06-14T12:20:41Z","html_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge/pull/10#discussion_r121930049","pull_request_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/comments/121930049"},"html":{"href":"https://github.com/signalfx/signalfx-cloudfoundry-bridge/pull/10#discussion_r121930049"},"pull_request":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10","id":125467444,"html_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge/pull/10","diff_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge/pull/10.diff","patch_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge/pull/10.patch","issue_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/10","number":10,"state":"open","locked":false,"title":"Correcting metric types for a few metrics","user":{"login":"keitwb","id":614344,"avatar_url":"https://avatars1.githubusercontent.com/u/614344?v=3","gravatar_id":"","url":"https://api.github.com/users/keitwb","html_url":"https://github.com/keitwb","followers_url":"https://api.github.com/users/keitwb/followers","following_url":"https://api.github.com/users/keitwb/following{/other_user}","gists_url":"https://api.github.com/users/keitwb/gists{/gist_id}","starred_url":"https://api.github.com/users/keitwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keitwb/subscriptions","organizations_url":"https://api.github.com/users/keitwb/orgs","repos_url":"https://api.github.com/users/keitwb/repos","events_url":"https://api.github.com/users/keitwb/events{/privacy}","received_events_url":"https://api.github.com/users/keitwb/received_events","type":"User","site_admin":false},"body":"Also sending Garden app metadata as both properties and dimensions to satisfy\r\ncurrent nav view constraints.\r\n\r\nAdding License file as well.","created_at":"2017-06-13T21:37:45Z","updated_at":"2017-06-14T12:20:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"900e0c971f77a8e64d1a769c3ded21ebcba46e7c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10/commits","review_comments_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10/comments","review_comment_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/10/comments","statuses_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/statuses/0e2ab2680568a096ebe22208c054b8e3768ddd22","head":{"label":"signalfx:metric-tweaks","ref":"metric-tweaks","sha":"0e2ab2680568a096ebe22208c054b8e3768ddd22","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":79366029,"name":"signalfx-cloudfoundry-bridge","full_name":"signalfx/signalfx-cloudfoundry-bridge","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge","description":"SignalFx Cloud Foundry integration","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge","forks_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/deployments","created_at":"2017-01-18T17:38:57Z","updated_at":"2017-05-31T20:44:08Z","pushed_at":"2017-06-13T21:37:45Z","git_url":"git://github.com/signalfx/signalfx-cloudfoundry-bridge.git","ssh_url":"git@github.com:signalfx/signalfx-cloudfoundry-bridge.git","clone_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge.git","svn_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge","homepage":"","size":2442,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"signalfx:master","ref":"master","sha":"b25609de08c7794d7d09019982ad0716c3a24493","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":79366029,"name":"signalfx-cloudfoundry-bridge","full_name":"signalfx/signalfx-cloudfoundry-bridge","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars3.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge","description":"SignalFx Cloud Foundry integration","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge","forks_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/deployments","created_at":"2017-01-18T17:38:57Z","updated_at":"2017-05-31T20:44:08Z","pushed_at":"2017-06-13T21:37:45Z","git_url":"git://github.com/signalfx/signalfx-cloudfoundry-bridge.git","ssh_url":"git@github.com:signalfx/signalfx-cloudfoundry-bridge.git","clone_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge.git","svn_url":"https://github.com/signalfx/signalfx-cloudfoundry-bridge","homepage":"","size":2442,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10"},"html":{"href":"https://github.com/signalfx/signalfx-cloudfoundry-bridge/pull/10"},"issue":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/10"},"comments":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/signalfx/signalfx-cloudfoundry-bridge/statuses/0e2ab2680568a096ebe22208c054b8e3768ddd22"}}}}
{"actor":{"display_login":"keitwb"}}