{"action":"closed","issue":{"url":"https://api.github.com/repos/Azure/azure-iot-arduino/issues/17","repository_url":"https://api.github.com/repos/Azure/azure-iot-arduino","labels_url":"https://api.github.com/repos/Azure/azure-iot-arduino/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-iot-arduino/issues/17/comments","events_url":"https://api.github.com/repos/Azure/azure-iot-arduino/issues/17/events","html_url":"https://github.com/Azure/azure-iot-arduino/issues/17","id":148492276,"number":17,"title":"Explore replacing default agenttime.c adapter","user":{"login":"sandeepmistry","id":1163840,"avatar_url":"https://avatars2.githubusercontent.com/u/1163840?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepmistry","html_url":"https://github.com/sandeepmistry","followers_url":"https://api.github.com/users/sandeepmistry/followers","following_url":"https://api.github.com/users/sandeepmistry/following{/other_user}","gists_url":"https://api.github.com/users/sandeepmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepmistry/subscriptions","organizations_url":"https://api.github.com/users/sandeepmistry/orgs","repos_url":"https://api.github.com/users/sandeepmistry/repos","events_url":"https://api.github.com/users/sandeepmistry/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepmistry/received_events","type":"User","site_admin":false},"labels":[{"id":295519100,"url":"https://api.github.com/repos/Azure/azure-iot-arduino/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"JetstreamRoySprowl","id":10535302,"avatar_url":"https://avatars0.githubusercontent.com/u/10535302?v=3","gravatar_id":"","url":"https://api.github.com/users/JetstreamRoySprowl","html_url":"https://github.com/JetstreamRoySprowl","followers_url":"https://api.github.com/users/JetstreamRoySprowl/followers","following_url":"https://api.github.com/users/JetstreamRoySprowl/following{/other_user}","gists_url":"https://api.github.com/users/JetstreamRoySprowl/gists{/gist_id}","starred_url":"https://api.github.com/users/JetstreamRoySprowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetstreamRoySprowl/subscriptions","organizations_url":"https://api.github.com/users/JetstreamRoySprowl/orgs","repos_url":"https://api.github.com/users/JetstreamRoySprowl/repos","events_url":"https://api.github.com/users/JetstreamRoySprowl/events{/privacy}","received_events_url":"https://api.github.com/users/JetstreamRoySprowl/received_events","type":"User","site_admin":false},"assignees":[{"login":"JetstreamRoySprowl","id":10535302,"avatar_url":"https://avatars0.githubusercontent.com/u/10535302?v=3","gravatar_id":"","url":"https://api.github.com/users/JetstreamRoySprowl","html_url":"https://github.com/JetstreamRoySprowl","followers_url":"https://api.github.com/users/JetstreamRoySprowl/followers","following_url":"https://api.github.com/users/JetstreamRoySprowl/following{/other_user}","gists_url":"https://api.github.com/users/JetstreamRoySprowl/gists{/gist_id}","starred_url":"https://api.github.com/users/JetstreamRoySprowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetstreamRoySprowl/subscriptions","organizations_url":"https://api.github.com/users/JetstreamRoySprowl/orgs","repos_url":"https://api.github.com/users/JetstreamRoySprowl/repos","events_url":"https://api.github.com/users/JetstreamRoySprowl/events{/privacy}","received_events_url":"https://api.github.com/users/JetstreamRoySprowl/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-04-14T21:50:15Z","updated_at":"2017-04-12T18:38:39Z","closed_at":"2017-04-12T18:38:39Z","body":"From discussion in https://github.com/arduino-libraries/AzureIoT/pull/16#discussion_r59782801\n\nThe default [agenttime.c](https://github.com/Azure/azure-c-shared-utility/blob/13c10cff52c6752f25f4d66e19d1d7a7add1091b/adapters/agenttime.c) is currently used, and then the POSIX based time layer is implemented in [src/samd/time.cpp](https://github.com/arduino-libraries/AzureIoT/blob/master/src/samd/time.cpp) using `RTCZero` on SAMD.\n\nWe should explore using a custom [`agenttime.h`](https://github.com/Azure/azure-c-shared-utility/blob/13c10cff52c6752f25f4d66e19d1d7a7add1091b/inc/azure_c_shared_utility/agenttime.h) implementation that is backed by the `NTPClient`. This would remove the dependency on `RTCZero` as the NTPClient can auto-sync the time with the NTP server at a preconfigured interval.\n\nThen a `UDP` instance or `NTPClient` instance could be passed in the constructor. Another added benefit is the library is portable to any Arduino board that provides a SSLClient type and UDP type.\n"}}
{"actor":{"display_login":"JetstreamRoySprowl"}}