{"action":"created","comment":{"url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/comments/106613692","pull_request_review_id":27544106,"id":106613692,"diff_hunk":"@@ -35,11 +33,72 @@ let fables  =\n let packages  =\n       !! \"src/*/package.json\"\n \n-// version info\n-let version = \"0.5\"  // or retrieve from CI server\n+let dotnetcliVersion = \"1.0.1\"\n+let dotnetSDKPath = \n+    System.Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData) </> \"dotnetcore\" \n+    |> FullName\n+\n+let dotnetExePath =\n+    dotnetSDKPath </> (if isWindows then \"dotnet.exe\" else \"dotnet\")\n+    |> FullName\n+\n+\n+Target \"InstallDotNetCore\" (fun _ ->","path":"build.fsx","position":45,"original_position":45,"commit_id":"df827c9e9a6d66a76abdffc33f4e604cae62f216","original_commit_id":"df827c9e9a6d66a76abdffc33f4e604cae62f216","user":{"login":"forki","id":57396,"avatar_url":"https://avatars2.githubusercontent.com/u/57396?v=3","gravatar_id":"","url":"https://api.github.com/users/forki","html_url":"https://github.com/forki","followers_url":"https://api.github.com/users/forki/followers","following_url":"https://api.github.com/users/forki/following{/other_user}","gists_url":"https://api.github.com/users/forki/gists{/gist_id}","starred_url":"https://api.github.com/users/forki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forki/subscriptions","organizations_url":"https://api.github.com/users/forki/orgs","repos_url":"https://api.github.com/users/forki/repos","events_url":"https://api.github.com/users/forki/events{/privacy}","received_events_url":"https://api.github.com/users/forki/received_events","type":"User","site_admin":false},"body":"we should really submit this as a Task to FAKE","created_at":"2017-03-17T09:39:19Z","updated_at":"2017-03-17T09:39:19Z","html_url":"https://github.com/fable-compiler/fable-elmish/pull/46#discussion_r106613692","pull_request_url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/comments/106613692"},"html":{"href":"https://github.com/fable-compiler/fable-elmish/pull/46#discussion_r106613692"},"pull_request":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46","id":110936056,"html_url":"https://github.com/fable-compiler/fable-elmish/pull/46","diff_url":"https://github.com/fable-compiler/fable-elmish/pull/46.diff","patch_url":"https://github.com/fable-compiler/fable-elmish/pull/46.patch","issue_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/46","number":46,"state":"open","locked":false,"title":"[WIP] Update to Fable 1.0","user":{"login":"alfonsogarciacaro","id":8275461,"avatar_url":"https://avatars3.githubusercontent.com/u/8275461?v=3","gravatar_id":"","url":"https://api.github.com/users/alfonsogarciacaro","html_url":"https://github.com/alfonsogarciacaro","followers_url":"https://api.github.com/users/alfonsogarciacaro/followers","following_url":"https://api.github.com/users/alfonsogarciacaro/following{/other_user}","gists_url":"https://api.github.com/users/alfonsogarciacaro/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsogarciacaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsogarciacaro/subscriptions","organizations_url":"https://api.github.com/users/alfonsogarciacaro/orgs","repos_url":"https://api.github.com/users/alfonsogarciacaro/repos","events_url":"https://api.github.com/users/alfonsogarciacaro/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsogarciacaro/received_events","type":"User","site_admin":false},"body":"Please don't merge it yet as this is a WIP. I still need to write some documentation about the new workflow but you can have an idea with this PR. I already updated the react/counter example so you can check out the branch and try it out (see the updated README for the sample).\r\n\r\nAs you can see, with Fable 1.0 libraries will be distributing sources directly so there's no need to build anything now (though something will probably be needed for version management). Sorry for changing the name of the folders but, as now we're using project references, it's better to keep the same structure that will be replicated in `node_modules`.\r\n\r\nAnother thing to note for library authors is the `$(NodeModulesDir)` MSBuild property in Fable.Elmish.fsproj. This is because during development, npm dependencies (like fable-powerpack) will be in the `node_modules` folder, but later they will be on the same level.\r\n\r\nPlease have a look and tell me if you have any suggestion. I'm planning to announce the beta of Fable 1.0 soon and I'd like to have fable-elmish (with both react and snabbdom renderers) also available.","created_at":"2017-03-15T20:32:44Z","updated_at":"2017-03-17T09:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96698fdf8673440791bc7cf484b2a1d06c330d84","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46/commits","review_comments_url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46/comments","review_comment_url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/46/comments","statuses_url":"https://api.github.com/repos/fable-compiler/fable-elmish/statuses/df827c9e9a6d66a76abdffc33f4e604cae62f216","head":{"label":"fable-compiler:next","ref":"next","sha":"df827c9e9a6d66a76abdffc33f4e604cae62f216","user":{"login":"fable-compiler","id":21062526,"avatar_url":"https://avatars3.githubusercontent.com/u/21062526?v=3","gravatar_id":"","url":"https://api.github.com/users/fable-compiler","html_url":"https://github.com/fable-compiler","followers_url":"https://api.github.com/users/fable-compiler/followers","following_url":"https://api.github.com/users/fable-compiler/following{/other_user}","gists_url":"https://api.github.com/users/fable-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/fable-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fable-compiler/subscriptions","organizations_url":"https://api.github.com/users/fable-compiler/orgs","repos_url":"https://api.github.com/users/fable-compiler/repos","events_url":"https://api.github.com/users/fable-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/fable-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":67582233,"name":"fable-elmish","full_name":"fable-compiler/fable-elmish","owner":{"login":"fable-compiler","id":21062526,"avatar_url":"https://avatars3.githubusercontent.com/u/21062526?v=3","gravatar_id":"","url":"https://api.github.com/users/fable-compiler","html_url":"https://github.com/fable-compiler","followers_url":"https://api.github.com/users/fable-compiler/followers","following_url":"https://api.github.com/users/fable-compiler/following{/other_user}","gists_url":"https://api.github.com/users/fable-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/fable-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fable-compiler/subscriptions","organizations_url":"https://api.github.com/users/fable-compiler/orgs","repos_url":"https://api.github.com/users/fable-compiler/repos","events_url":"https://api.github.com/users/fable-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/fable-compiler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fable-compiler/fable-elmish","description":"Elm-like abstractions for F# apps","fork":false,"url":"https://api.github.com/repos/fable-compiler/fable-elmish","forks_url":"https://api.github.com/repos/fable-compiler/fable-elmish/forks","keys_url":"https://api.github.com/repos/fable-compiler/fable-elmish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fable-compiler/fable-elmish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fable-compiler/fable-elmish/teams","hooks_url":"https://api.github.com/repos/fable-compiler/fable-elmish/hooks","issue_events_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/events{/number}","events_url":"https://api.github.com/repos/fable-compiler/fable-elmish/events","assignees_url":"https://api.github.com/repos/fable-compiler/fable-elmish/assignees{/user}","branches_url":"https://api.github.com/repos/fable-compiler/fable-elmish/branches{/branch}","tags_url":"https://api.github.com/repos/fable-compiler/fable-elmish/tags","blobs_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/refs{/sha}","trees_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fable-compiler/fable-elmish/statuses/{sha}","languages_url":"https://api.github.com/repos/fable-compiler/fable-elmish/languages","stargazers_url":"https://api.github.com/repos/fable-compiler/fable-elmish/stargazers","contributors_url":"https://api.github.com/repos/fable-compiler/fable-elmish/contributors","subscribers_url":"https://api.github.com/repos/fable-compiler/fable-elmish/subscribers","subscription_url":"https://api.github.com/repos/fable-compiler/fable-elmish/subscription","commits_url":"https://api.github.com/repos/fable-compiler/fable-elmish/commits{/sha}","git_commits_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/commits{/sha}","comments_url":"https://api.github.com/repos/fable-compiler/fable-elmish/comments{/number}","issue_comment_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/comments{/number}","contents_url":"https://api.github.com/repos/fable-compiler/fable-elmish/contents/{+path}","compare_url":"https://api.github.com/repos/fable-compiler/fable-elmish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fable-compiler/fable-elmish/merges","archive_url":"https://api.github.com/repos/fable-compiler/fable-elmish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fable-compiler/fable-elmish/downloads","issues_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues{/number}","pulls_url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls{/number}","milestones_url":"https://api.github.com/repos/fable-compiler/fable-elmish/milestones{/number}","notifications_url":"https://api.github.com/repos/fable-compiler/fable-elmish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fable-compiler/fable-elmish/labels{/name}","releases_url":"https://api.github.com/repos/fable-compiler/fable-elmish/releases{/id}","deployments_url":"https://api.github.com/repos/fable-compiler/fable-elmish/deployments","created_at":"2016-09-07T07:19:46Z","updated_at":"2017-03-16T20:26:50Z","pushed_at":"2017-03-16T21:02:36Z","git_url":"git://github.com/fable-compiler/fable-elmish.git","ssh_url":"git@github.com:fable-compiler/fable-elmish.git","clone_url":"https://github.com/fable-compiler/fable-elmish.git","svn_url":"https://github.com/fable-compiler/fable-elmish","homepage":null,"size":1322,"stargazers_count":58,"watchers_count":58,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":58,"default_branch":"master"}},"base":{"label":"fable-compiler:master","ref":"master","sha":"34d202a2eaa3f1e8b83393b759e5aca3d3c1e33c","user":{"login":"fable-compiler","id":21062526,"avatar_url":"https://avatars3.githubusercontent.com/u/21062526?v=3","gravatar_id":"","url":"https://api.github.com/users/fable-compiler","html_url":"https://github.com/fable-compiler","followers_url":"https://api.github.com/users/fable-compiler/followers","following_url":"https://api.github.com/users/fable-compiler/following{/other_user}","gists_url":"https://api.github.com/users/fable-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/fable-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fable-compiler/subscriptions","organizations_url":"https://api.github.com/users/fable-compiler/orgs","repos_url":"https://api.github.com/users/fable-compiler/repos","events_url":"https://api.github.com/users/fable-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/fable-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":67582233,"name":"fable-elmish","full_name":"fable-compiler/fable-elmish","owner":{"login":"fable-compiler","id":21062526,"avatar_url":"https://avatars3.githubusercontent.com/u/21062526?v=3","gravatar_id":"","url":"https://api.github.com/users/fable-compiler","html_url":"https://github.com/fable-compiler","followers_url":"https://api.github.com/users/fable-compiler/followers","following_url":"https://api.github.com/users/fable-compiler/following{/other_user}","gists_url":"https://api.github.com/users/fable-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/fable-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fable-compiler/subscriptions","organizations_url":"https://api.github.com/users/fable-compiler/orgs","repos_url":"https://api.github.com/users/fable-compiler/repos","events_url":"https://api.github.com/users/fable-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/fable-compiler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fable-compiler/fable-elmish","description":"Elm-like abstractions for F# apps","fork":false,"url":"https://api.github.com/repos/fable-compiler/fable-elmish","forks_url":"https://api.github.com/repos/fable-compiler/fable-elmish/forks","keys_url":"https://api.github.com/repos/fable-compiler/fable-elmish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fable-compiler/fable-elmish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fable-compiler/fable-elmish/teams","hooks_url":"https://api.github.com/repos/fable-compiler/fable-elmish/hooks","issue_events_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/events{/number}","events_url":"https://api.github.com/repos/fable-compiler/fable-elmish/events","assignees_url":"https://api.github.com/repos/fable-compiler/fable-elmish/assignees{/user}","branches_url":"https://api.github.com/repos/fable-compiler/fable-elmish/branches{/branch}","tags_url":"https://api.github.com/repos/fable-compiler/fable-elmish/tags","blobs_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/refs{/sha}","trees_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fable-compiler/fable-elmish/statuses/{sha}","languages_url":"https://api.github.com/repos/fable-compiler/fable-elmish/languages","stargazers_url":"https://api.github.com/repos/fable-compiler/fable-elmish/stargazers","contributors_url":"https://api.github.com/repos/fable-compiler/fable-elmish/contributors","subscribers_url":"https://api.github.com/repos/fable-compiler/fable-elmish/subscribers","subscription_url":"https://api.github.com/repos/fable-compiler/fable-elmish/subscription","commits_url":"https://api.github.com/repos/fable-compiler/fable-elmish/commits{/sha}","git_commits_url":"https://api.github.com/repos/fable-compiler/fable-elmish/git/commits{/sha}","comments_url":"https://api.github.com/repos/fable-compiler/fable-elmish/comments{/number}","issue_comment_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/comments{/number}","contents_url":"https://api.github.com/repos/fable-compiler/fable-elmish/contents/{+path}","compare_url":"https://api.github.com/repos/fable-compiler/fable-elmish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fable-compiler/fable-elmish/merges","archive_url":"https://api.github.com/repos/fable-compiler/fable-elmish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fable-compiler/fable-elmish/downloads","issues_url":"https://api.github.com/repos/fable-compiler/fable-elmish/issues{/number}","pulls_url":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls{/number}","milestones_url":"https://api.github.com/repos/fable-compiler/fable-elmish/milestones{/number}","notifications_url":"https://api.github.com/repos/fable-compiler/fable-elmish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fable-compiler/fable-elmish/labels{/name}","releases_url":"https://api.github.com/repos/fable-compiler/fable-elmish/releases{/id}","deployments_url":"https://api.github.com/repos/fable-compiler/fable-elmish/deployments","created_at":"2016-09-07T07:19:46Z","updated_at":"2017-03-16T20:26:50Z","pushed_at":"2017-03-16T21:02:36Z","git_url":"git://github.com/fable-compiler/fable-elmish.git","ssh_url":"git@github.com:fable-compiler/fable-elmish.git","clone_url":"https://github.com/fable-compiler/fable-elmish.git","svn_url":"https://github.com/fable-compiler/fable-elmish","homepage":null,"size":1322,"stargazers_count":58,"watchers_count":58,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46"},"html":{"href":"https://github.com/fable-compiler/fable-elmish/pull/46"},"issue":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/46"},"comments":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/fable-compiler/fable-elmish/statuses/df827c9e9a6d66a76abdffc33f4e604cae62f216"}}}}
{"actor":{"display_login":"forki"}}