{"action":"created","issue":{"url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/342","repository_url":"https://api.github.com/repos/SixLabors/ImageSharp","labels_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/342/comments","events_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/342/events","html_url":"https://github.com/SixLabors/ImageSharp/pull/342","id":258845270,"number":342,"title":"Fix for Little/BigEndianBitConverter.ToInt64 reading wrong value in some cases","user":{"login":"JBildstein","id":12777835,"avatar_url":"https://avatars2.githubusercontent.com/u/12777835?v=4","gravatar_id":"","url":"https://api.github.com/users/JBildstein","html_url":"https://github.com/JBildstein","followers_url":"https://api.github.com/users/JBildstein/followers","following_url":"https://api.github.com/users/JBildstein/following{/other_user}","gists_url":"https://api.github.com/users/JBildstein/gists{/gist_id}","starred_url":"https://api.github.com/users/JBildstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBildstein/subscriptions","organizations_url":"https://api.github.com/users/JBildstein/orgs","repos_url":"https://api.github.com/users/JBildstein/repos","events_url":"https://api.github.com/users/JBildstein/events{/privacy}","received_events_url":"https://api.github.com/users/JBildstein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-19T14:37:33Z","updated_at":"2017-09-19T14:37:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SixLabors/ImageSharp/pulls/342","html_url":"https://github.com/SixLabors/ImageSharp/pull/342","diff_url":"https://github.com/SixLabors/ImageSharp/pull/342.diff","patch_url":"https://github.com/SixLabors/ImageSharp/pull/342.patch"},"body":"### Prerequisites\r\n\r\n- [x] I have written a descriptive pull-request title\r\n- [x] I have verified that there are no overlapping [pull-requests](https://github.com/SixLabors/ImageSharp/pulls) open\r\n- [x] I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules :cop:.\r\n- [x] I have provided test coverage for my change (where applicable)\r\n\r\n### Description\r\nThe ToInt64 of the Little- and BigEndianConverter classes read wrong values when the least significant half of the number was negative. A negative 32bit integer extended to 64bit is filled up with 1s. Then when combining both halfs of the number with an OR, the other half is effectively ignored. By zeroing out those filled up 1s the bug gets fixed."},"comment":{"url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/comments/330560595","html_url":"https://github.com/SixLabors/ImageSharp/pull/342#issuecomment-330560595","issue_url":"https://api.github.com/repos/SixLabors/ImageSharp/issues/342","id":330560595,"user":{"login":"CLAassistant","id":11571300,"avatar_url":"https://avatars1.githubusercontent.com/u/11571300?v=4","gravatar_id":"","url":"https://api.github.com/users/CLAassistant","html_url":"https://github.com/CLAassistant","followers_url":"https://api.github.com/users/CLAassistant/followers","following_url":"https://api.github.com/users/CLAassistant/following{/other_user}","gists_url":"https://api.github.com/users/CLAassistant/gists{/gist_id}","starred_url":"https://api.github.com/users/CLAassistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLAassistant/subscriptions","organizations_url":"https://api.github.com/users/CLAassistant/orgs","repos_url":"https://api.github.com/users/CLAassistant/repos","events_url":"https://api.github.com/users/CLAassistant/events{/privacy}","received_events_url":"https://api.github.com/users/CLAassistant/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T14:37:41Z","updated_at":"2017-09-19T14:37:41Z","author_association":"NONE","body":"[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/SixLabors/ImageSharp?pullRequest=342) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/SixLabors/ImageSharp?pullRequest=342) before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/SixLabors/ImageSharp?pullRequest=342) it.</sub>"}}
{"actor":{"display_login":"CLAassistant"}}