{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/scanning/pulls/comments/107874269","pull_request_review_id":28872054,"id":107874269,"diff_hunk":"@@ -76,25 +78,27 @@\n \n \tLinkedList<IDataListener> listeners = new LinkedList<>();\n \t\n+\tint dim0,\n+\t\tdim1,","path":"org.eclipse.scanning.connector.epicsv3/src/org/eclipse/scanning/connector/epicsv3/EpicsV3DynamicDatasetConnector.java","position":21,"original_position":21,"commit_id":"330cf5b0b158519fa371a929b666955147f0fc37","original_commit_id":"330cf5b0b158519fa371a929b666955147f0fc37","user":{"login":"gerring","id":1318764,"avatar_url":"https://avatars2.githubusercontent.com/u/1318764?v=3","gravatar_id":"","url":"https://api.github.com/users/gerring","html_url":"https://github.com/gerring","followers_url":"https://api.github.com/users/gerring/followers","following_url":"https://api.github.com/users/gerring/following{/other_user}","gists_url":"https://api.github.com/users/gerring/gists{/gist_id}","starred_url":"https://api.github.com/users/gerring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerring/subscriptions","organizations_url":"https://api.github.com/users/gerring/orgs","repos_url":"https://api.github.com/users/gerring/repos","events_url":"https://api.github.com/users/gerring/events{/privacy}","received_events_url":"https://api.github.com/users/gerring/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png 'Severity: MINOR') Declare \"dim1\" on a separate line. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1659)\n","created_at":"2017-03-24T10:33:08Z","updated_at":"2017-03-24T10:33:08Z","html_url":"https://github.com/eclipse/scanning/pull/46#discussion_r107874269","pull_request_url":"https://api.github.com/repos/eclipse/scanning/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/eclipse/scanning/pulls/comments/107874269"},"html":{"href":"https://github.com/eclipse/scanning/pull/46#discussion_r107874269"},"pull_request":{"href":"https://api.github.com/repos/eclipse/scanning/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/scanning/pulls/46","id":112425658,"html_url":"https://github.com/eclipse/scanning/pull/46","diff_url":"https://github.com/eclipse/scanning/pull/46.diff","patch_url":"https://github.com/eclipse/scanning/pull/46.patch","issue_url":"https://api.github.com/repos/eclipse/scanning/issues/46","number":46,"state":"open","locked":false,"title":"Epics.data size.fix","user":{"login":"Mark-Booth","id":1576793,"avatar_url":"https://avatars0.githubusercontent.com/u/1576793?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-Booth","html_url":"https://github.com/Mark-Booth","followers_url":"https://api.github.com/users/Mark-Booth/followers","following_url":"https://api.github.com/users/Mark-Booth/following{/other_user}","gists_url":"https://api.github.com/users/Mark-Booth/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-Booth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-Booth/subscriptions","organizations_url":"https://api.github.com/users/Mark-Booth/orgs","repos_url":"https://api.github.com/users/Mark-Booth/repos","events_url":"https://api.github.com/users/Mark-Booth/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-Booth/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-24T10:22:45Z","updated_at":"2017-03-24T10:33:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2006ff3b4635a4275cf752d0939ca9287fbe922","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/scanning/pulls/46/commits","review_comments_url":"https://api.github.com/repos/eclipse/scanning/pulls/46/comments","review_comment_url":"https://api.github.com/repos/eclipse/scanning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/scanning/issues/46/comments","statuses_url":"https://api.github.com/repos/eclipse/scanning/statuses/330cf5b0b158519fa371a929b666955147f0fc37","head":{"label":"eclipse:epics.dataSize.fix","ref":"epics.dataSize.fix","sha":"330cf5b0b158519fa371a929b666955147f0fc37","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":83696502,"name":"scanning","full_name":"eclipse/scanning","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/scanning","description":"Scanning is an open source project for moving scientific instruments and writing NeXus (http://www.nexusformat.org/) compliant files. It is designed to be control system neutral, EPICS, TANGO etc. may be used. See https://projects.eclipse.org/proposals/scanning and https://github.com/eclipse/scanning/blob/master/GETTINGSTARTED.pdf","fork":false,"url":"https://api.github.com/repos/eclipse/scanning","forks_url":"https://api.github.com/repos/eclipse/scanning/forks","keys_url":"https://api.github.com/repos/eclipse/scanning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/scanning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/scanning/teams","hooks_url":"https://api.github.com/repos/eclipse/scanning/hooks","issue_events_url":"https://api.github.com/repos/eclipse/scanning/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/scanning/events","assignees_url":"https://api.github.com/repos/eclipse/scanning/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/scanning/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/scanning/tags","blobs_url":"https://api.github.com/repos/eclipse/scanning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/scanning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/scanning/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/scanning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/scanning/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/scanning/languages","stargazers_url":"https://api.github.com/repos/eclipse/scanning/stargazers","contributors_url":"https://api.github.com/repos/eclipse/scanning/contributors","subscribers_url":"https://api.github.com/repos/eclipse/scanning/subscribers","subscription_url":"https://api.github.com/repos/eclipse/scanning/subscription","commits_url":"https://api.github.com/repos/eclipse/scanning/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/scanning/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/scanning/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/scanning/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/scanning/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/scanning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/scanning/merges","archive_url":"https://api.github.com/repos/eclipse/scanning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/scanning/downloads","issues_url":"https://api.github.com/repos/eclipse/scanning/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/scanning/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/scanning/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/scanning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/scanning/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/scanning/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/scanning/deployments","created_at":"2017-03-02T15:58:52Z","updated_at":"2017-03-13T11:33:31Z","pushed_at":"2017-03-24T10:23:53Z","git_url":"git://github.com/eclipse/scanning.git","ssh_url":"git@github.com:eclipse/scanning.git","clone_url":"https://github.com/eclipse/scanning.git","svn_url":"https://github.com/eclipse/scanning","homepage":"","size":8025,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"9687d6637113f29a3db4d46b9ef50a91d465e555","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":83696502,"name":"scanning","full_name":"eclipse/scanning","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/scanning","description":"Scanning is an open source project for moving scientific instruments and writing NeXus (http://www.nexusformat.org/) compliant files. It is designed to be control system neutral, EPICS, TANGO etc. may be used. See https://projects.eclipse.org/proposals/scanning and https://github.com/eclipse/scanning/blob/master/GETTINGSTARTED.pdf","fork":false,"url":"https://api.github.com/repos/eclipse/scanning","forks_url":"https://api.github.com/repos/eclipse/scanning/forks","keys_url":"https://api.github.com/repos/eclipse/scanning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/scanning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/scanning/teams","hooks_url":"https://api.github.com/repos/eclipse/scanning/hooks","issue_events_url":"https://api.github.com/repos/eclipse/scanning/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/scanning/events","assignees_url":"https://api.github.com/repos/eclipse/scanning/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/scanning/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/scanning/tags","blobs_url":"https://api.github.com/repos/eclipse/scanning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/scanning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/scanning/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/scanning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/scanning/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/scanning/languages","stargazers_url":"https://api.github.com/repos/eclipse/scanning/stargazers","contributors_url":"https://api.github.com/repos/eclipse/scanning/contributors","subscribers_url":"https://api.github.com/repos/eclipse/scanning/subscribers","subscription_url":"https://api.github.com/repos/eclipse/scanning/subscription","commits_url":"https://api.github.com/repos/eclipse/scanning/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/scanning/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/scanning/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/scanning/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/scanning/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/scanning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/scanning/merges","archive_url":"https://api.github.com/repos/eclipse/scanning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/scanning/downloads","issues_url":"https://api.github.com/repos/eclipse/scanning/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/scanning/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/scanning/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/scanning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/scanning/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/scanning/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/scanning/deployments","created_at":"2017-03-02T15:58:52Z","updated_at":"2017-03-13T11:33:31Z","pushed_at":"2017-03-24T10:23:53Z","git_url":"git://github.com/eclipse/scanning.git","ssh_url":"git@github.com:eclipse/scanning.git","clone_url":"https://github.com/eclipse/scanning.git","svn_url":"https://github.com/eclipse/scanning","homepage":"","size":8025,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/scanning/pulls/46"},"html":{"href":"https://github.com/eclipse/scanning/pull/46"},"issue":{"href":"https://api.github.com/repos/eclipse/scanning/issues/46"},"comments":{"href":"https://api.github.com/repos/eclipse/scanning/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/scanning/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/scanning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/scanning/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/scanning/statuses/330cf5b0b158519fa371a929b666955147f0fc37"}}}}
{"actor":{"display_login":"gerring"}}