{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/144423430","pull_request_review_id":69079784,"id":144423430,"diff_hunk":"@@ -317,3 +321,20 @@ func (c *Container) IsInternal() bool {\n func (c *Container) IsRunning() bool {\n \treturn c.GetKnownStatus().IsRunning()\n }\n+\n+// IsMetadataFileUpdated() returns true if the metadata file has been once the","path":"agent/api/container.go","position":16,"original_position":16,"commit_id":"347977d5d27e3288961c87878510637b4cfbd919","original_commit_id":"347977d5d27e3288961c87878510637b4cfbd919","user":{"login":"adnxn","id":596369,"avatar_url":"https://avatars2.githubusercontent.com/u/596369?v=4","gravatar_id":"","url":"https://api.github.com/users/adnxn","html_url":"https://github.com/adnxn","followers_url":"https://api.github.com/users/adnxn/followers","following_url":"https://api.github.com/users/adnxn/following{/other_user}","gists_url":"https://api.github.com/users/adnxn/gists{/gist_id}","starred_url":"https://api.github.com/users/adnxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnxn/subscriptions","organizations_url":"https://api.github.com/users/adnxn/orgs","repos_url":"https://api.github.com/users/adnxn/repos","events_url":"https://api.github.com/users/adnxn/events{/privacy}","received_events_url":"https://api.github.com/users/adnxn/received_events","type":"User","site_admin":false},"body":"yep gone. ","created_at":"2017-10-12T22:12:15Z","updated_at":"2017-10-12T22:12:15Z","html_url":"https://github.com/aws/amazon-ecs-agent/pull/981#discussion_r144423430","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/144423430"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/981#discussion_r144423430"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981"}},"in_reply_to_id":144391961},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981","id":140613718,"html_url":"https://github.com/aws/amazon-ecs-agent/pull/981","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/981.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/981.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/981","number":981,"state":"open","locked":false,"title":"metadata service continued","user":{"login":"adnxn","id":596369,"avatar_url":"https://avatars2.githubusercontent.com/u/596369?v=4","gravatar_id":"","url":"https://api.github.com/users/adnxn","html_url":"https://github.com/adnxn","followers_url":"https://api.github.com/users/adnxn/followers","following_url":"https://api.github.com/users/adnxn/following{/other_user}","gists_url":"https://api.github.com/users/adnxn/gists{/gist_id}","starred_url":"https://api.github.com/users/adnxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnxn/subscriptions","organizations_url":"https://api.github.com/users/adnxn/orgs","repos_url":"https://api.github.com/users/adnxn/repos","events_url":"https://api.github.com/users/adnxn/events{/privacy}","received_events_url":"https://api.github.com/users/adnxn/received_events","type":"User","site_admin":false},"body":"### Summary\r\n<!-- What does this pull request do? -->\r\ncarried over work from #913 with following additions:\r\n* fix mismatch of generated mocks between metadata service and dev branch\r\n* includes dev changes up to 6f11735d92bbf1ce7bbe099721a17384095fdff7\r\n* updated gomock to latest version and regenerated all mocks\r\n* added code to handle agent restarts and unit test\r\n* functional testing for unix\r\n\r\n### Implementation details\r\nn/a\r\n\r\n### Testing\r\n<!-- How was this tested? -->\r\n<!--\r\nNote for external contributors:\r\n`make test` and `make run-integ-tests` can run in a Linux development\r\nenvironment like your laptop.  `go test -timeout=25s ./agent/...` and\r\n`.\\scripts\\run-integ.tests.ps1` can run in a Windows development environment\r\nlike your laptop.  Please ensure unit and integration tests pass (on at least\r\none platform) before opening the pull request.  `make run-functional-tests` and\r\n`.\\scripts\\run-functional-tests.ps1` must be run on an EC2 instance with an\r\ninstance profile allowing it access to AWS resources.  Running\r\n`make run-functional-tests` and `.\\scripts\\run-functional-tests.ps1` may incur\r\ncharges to your AWS account; if you're unable or unwilling to run these tests\r\nin your own account, we can run the tests and provide test results.\r\n-->\r\n- [x] Builds on Linux (`make release`)\r\n- [x] Builds on Windows (`go build -out amazon-ecs-agent.exe ./agent`)\r\n- [x] Unit tests on Linux (`make test`) pass\r\n- [x] Unit tests on Windows (`go test -timeout=25s ./agent/...`) pass\r\n- [x] Integration tests on Linux (`make run-integ-tests`) pass\r\n- [x] Integration tests on Windows (`.\\scripts\\run-integ-tests.ps1`) pass\r\n- [x] Functional tests on Linux (`make run-functional-tests`) pass\r\n- [x] Functional tests on Windows (`.\\scripts\\run-functional-tests.ps1`) pass\r\n\r\nNew tests cover the changes: <!-- yes|no -->\r\n\r\n### Description for the changelog\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog.\r\nYou can see our changelog entry style here:\r\nhttps://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f\r\n-->\r\n\r\n### Licensing\r\n<!--\r\nPlease confirm that this contribution is under the terms of the Apache 2.0\r\nLicense.\r\n-->\r\nThis contribution is under the terms of the Apache 2.0 License: <!-- yes -->\r\n","created_at":"2017-09-12T15:32:10Z","updated_at":"2017-10-12T22:12:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29cecde8b87ae2775aef8c807872279a87ba033d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/981/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/347977d5d27e3288961c87878510637b4cfbd919","head":{"label":"adnxn:mdservice-dev","ref":"mdservice-dev","sha":"347977d5d27e3288961c87878510637b4cfbd919","user":{"login":"adnxn","id":596369,"avatar_url":"https://avatars2.githubusercontent.com/u/596369?v=4","gravatar_id":"","url":"https://api.github.com/users/adnxn","html_url":"https://github.com/adnxn","followers_url":"https://api.github.com/users/adnxn/followers","following_url":"https://api.github.com/users/adnxn/following{/other_user}","gists_url":"https://api.github.com/users/adnxn/gists{/gist_id}","starred_url":"https://api.github.com/users/adnxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnxn/subscriptions","organizations_url":"https://api.github.com/users/adnxn/orgs","repos_url":"https://api.github.com/users/adnxn/repos","events_url":"https://api.github.com/users/adnxn/events{/privacy}","received_events_url":"https://api.github.com/users/adnxn/received_events","type":"User","site_admin":false},"repo":{"id":82206481,"name":"amazon-ecs-agent","full_name":"adnxn/amazon-ecs-agent","owner":{"login":"adnxn","id":596369,"avatar_url":"https://avatars2.githubusercontent.com/u/596369?v=4","gravatar_id":"","url":"https://api.github.com/users/adnxn","html_url":"https://github.com/adnxn","followers_url":"https://api.github.com/users/adnxn/followers","following_url":"https://api.github.com/users/adnxn/following{/other_user}","gists_url":"https://api.github.com/users/adnxn/gists{/gist_id}","starred_url":"https://api.github.com/users/adnxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnxn/subscriptions","organizations_url":"https://api.github.com/users/adnxn/orgs","repos_url":"https://api.github.com/users/adnxn/repos","events_url":"https://api.github.com/users/adnxn/events{/privacy}","received_events_url":"https://api.github.com/users/adnxn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adnxn/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":true,"url":"https://api.github.com/repos/adnxn/amazon-ecs-agent","forks_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/adnxn/amazon-ecs-agent/deployments","created_at":"2017-02-16T17:20:49Z","updated_at":"2017-02-16T17:20:52Z","pushed_at":"2017-10-11T19:51:26Z","git_url":"git://github.com/adnxn/amazon-ecs-agent.git","ssh_url":"git@github.com:adnxn/amazon-ecs-agent.git","clone_url":"https://github.com/adnxn/amazon-ecs-agent.git","svn_url":"https://github.com/adnxn/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":21467,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:dev","ref":"dev","sha":"ed1cd673f0640bad262076b2a47062c28da4d4df","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2017-10-12T17:56:27Z","pushed_at":"2017-10-12T21:53:11Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"git@github.com:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":6910,"stargazers_count":1011,"watchers_count":1011,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":267,"mirror_url":null,"open_issues_count":134,"forks":267,"open_issues":134,"watchers":1011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/981"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/981"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/981/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/981/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/347977d5d27e3288961c87878510637b4cfbd919"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adnxn"}}