{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57033","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57033/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57033/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57033/events","html_url":"https://github.com/kubernetes/kubernetes/pull/57033","id":280956488,"number":57033,"title":"Refactor calculate inter pod affinity priority function","user":{"login":"guangxuli","id":17472298,"avatar_url":"https://avatars2.githubusercontent.com/u/17472298?v=4","gravatar_id":"","url":"https://api.github.com/users/guangxuli","html_url":"https://github.com/guangxuli","followers_url":"https://api.github.com/users/guangxuli/followers","following_url":"https://api.github.com/users/guangxuli/following{/other_user}","gists_url":"https://api.github.com/users/guangxuli/gists{/gist_id}","starred_url":"https://api.github.com/users/guangxuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guangxuli/subscriptions","organizations_url":"https://api.github.com/users/guangxuli/orgs","repos_url":"https://api.github.com/users/guangxuli/repos","events_url":"https://api.github.com/users/guangxuli/events{/privacy}","received_events_url":"https://api.github.com/users/guangxuli/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"assignees":[{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},{"login":"jayunit100","id":826111,"avatar_url":"https://avatars3.githubusercontent.com/u/826111?v=4","gravatar_id":"","url":"https://api.github.com/users/jayunit100","html_url":"https://github.com/jayunit100","followers_url":"https://api.github.com/users/jayunit100/followers","following_url":"https://api.github.com/users/jayunit100/following{/other_user}","gists_url":"https://api.github.com/users/jayunit100/gists{/gist_id}","starred_url":"https://api.github.com/users/jayunit100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayunit100/subscriptions","organizations_url":"https://api.github.com/users/jayunit100/orgs","repos_url":"https://api.github.com/users/jayunit100/repos","events_url":"https://api.github.com/users/jayunit100/events{/privacy}","received_events_url":"https://api.github.com/users/jayunit100/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-12-11T09:59:46Z","updated_at":"2017-12-11T10:39:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57033","html_url":"https://github.com/kubernetes/kubernetes/pull/57033","diff_url":"https://github.com/kubernetes/kubernetes/pull/57033.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/57033.patch"},"body":"**What this PR does / why we need it**:\r\nRef #24246. exactly ref https://github.com/kubernetes/kubernetes/issues/51455, the PR aim to unify priority functions(deprecated) by using map/reduce pattern. \r\nPrevious related PR is https://github.com/kubernetes/kubernetes/pull/51192 (merged)\r\nPrevious related PR is https://github.com/kubernetes/kubernetes/pull/56317 (waiting review)\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nThis is the last PR to fix  issue #24246 or  #51455\r\n\r\n**Special notes for your reviewer**:\r\n1) use a global/public data place to save the node score since each node not only computes its own score, and after run Reduce function we will cleanup/reinit the global/public data pointer.\r\n2) change `HostPriorityList `from **slice struct** to **slice \\*struct**,  this is  because we can't get the raw correct score for each node  until all nodes finished computing process(Map). exactly at [here](https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/scheduler/core/generic_scheduler.go#L552)\r\n3. add the filtered node list to priority meta data.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNone\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/350686418","html_url":"https://github.com/kubernetes/kubernetes/pull/57033#issuecomment-350686418","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57033","id":350686418,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-12-11T10:39:16Z","updated_at":"2017-12-11T10:39:16Z","author_association":"COLLABORATOR","body":"@guangxuli: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-test | 0a456bebac060d292d4b8b6ff4ca9f9d13d0104f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-bazel-test/21227/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-node-e2e | 0a456bebac060d292d4b8b6ff4ca9f9d13d0104f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-node-e2e/66402/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-verify | 0a456bebac060d292d4b8b6ff4ca9f9d13d0104f | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-verify/67029/) | `/test pull-kubernetes-verify`\npull-kubernetes-e2e-gce-device-plugin-gpu | 40bd5beb3d25a651052803c696d7d6e3f2cd7fa7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-e2e-gce-device-plugin-gpu/9048/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-kubemark-e2e-gce | 40bd5beb3d25a651052803c696d7d6e3f2cd7fa7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-kubemark-e2e-gce/67090/) | `/test pull-kubernetes-kubemark-e2e-gce`\npull-kubernetes-e2e-gce | 40bd5beb3d25a651052803c696d7d6e3f2cd7fa7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-e2e-gce/10849/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-kops-aws | 40bd5beb3d25a651052803c696d7d6e3f2cd7fa7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-e2e-kops-aws/64193/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-bazel-build | 40bd5beb3d25a651052803c696d7d6e3f2cd7fa7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-bazel-build/20041/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-unit | 40bd5beb3d25a651052803c696d7d6e3f2cd7fa7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/57033/pull-kubernetes-unit/70243/) | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/57033). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/guangxuli). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}