{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/19668","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/19668/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/19668/comments","events_url":"https://api.github.com/repos/angular/angular/issues/19668/events","html_url":"https://github.com/angular/angular/pull/19668","id":264690634,"number":19668,"title":"docs(aio): fix toh-pt6 example","user":{"login":"kapunahelewong","id":4116963,"avatar_url":"https://avatars1.githubusercontent.com/u/4116963?v=4","gravatar_id":"","url":"https://api.github.com/users/kapunahelewong","html_url":"https://github.com/kapunahelewong","followers_url":"https://api.github.com/users/kapunahelewong/followers","following_url":"https://api.github.com/users/kapunahelewong/following{/other_user}","gists_url":"https://api.github.com/users/kapunahelewong/gists{/gist_id}","starred_url":"https://api.github.com/users/kapunahelewong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapunahelewong/subscriptions","organizations_url":"https://api.github.com/users/kapunahelewong/orgs","repos_url":"https://api.github.com/users/kapunahelewong/repos","events_url":"https://api.github.com/users/kapunahelewong/events{/privacy}","received_events_url":"https://api.github.com/users/kapunahelewong/received_events","type":"User","site_admin":false},"labels":[{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":175085143,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20docs","name":"comp: docs","color":"c7def8","default":false},{"id":217969169,"url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20review","name":"PR action: review","color":"fbca04","default":false},{"id":655699838,"url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-10-11T18:33:59Z","updated_at":"2017-10-16T13:18:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/19668","html_url":"https://github.com/angular/angular/pull/19668","diff_url":"https://github.com/angular/angular/pull/19668.diff","patch_url":"https://github.com/angular/angular/pull/19668.patch"},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [ ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nPlunker uses `json().data` but that breaks it. Removed `.data`, plunker works now.\r\n\r\nIssue Number: #19602\r\n\r\n\r\n## What is the new behavior?\r\nNow you can `getHero`, `getHeroes`, `delete`, `create`, `update`.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\nFixes #19602.\r\n\r\n@petebacondarwin Could you review this when you get a chance? I've marked it WIP because I have questions regarding `HttpClient`, the Promises, and that locally, when running it, it can't find `app.module.ngfactory`.\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/336883677","html_url":"https://github.com/angular/angular/pull/19668#issuecomment-336883677","issue_url":"https://api.github.com/repos/angular/angular/issues/19668","id":336883677,"user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"created_at":"2017-10-16T13:18:02Z","updated_at":"2017-10-16T13:18:02Z","author_association":"MEMBER","body":"I tried this against latest master and it works.\r\nThere are still some failures against 4.4.x. Investigating..."}}
{"actor":{"display_login":"gkalpak"}}