{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/comments/143543241","pull_request_review_id":68069473,"id":143543241,"diff_hunk":"@@ -65,7 +66,8 @@ export function PlotlyOAuth() {\n                       res.setCookie('db-connector-auth-token',\n                                     dbConnectorAccessToken, {\n                                         'maxAge': getAccessTokenExpiry(),\n-                                        'path': '/'\n+                                        'path': getSetting('DB_CONNECTOR_URL'),\n+                                        'secure': getSetting('PLOTLY_API_SSL_ENABLED')","path":"backend/plugins/authorization.js","position":null,"original_position":40,"commit_id":"7204ec66554f53e5732be3d1da64fcd020c0323d","original_commit_id":"7204ec66554f53e5732be3d1da64fcd020c0323d","user":{"login":"chriddyp","id":1280389,"avatar_url":"https://avatars3.githubusercontent.com/u/1280389?v=4","gravatar_id":"","url":"https://api.github.com/users/chriddyp","html_url":"https://github.com/chriddyp","followers_url":"https://api.github.com/users/chriddyp/followers","following_url":"https://api.github.com/users/chriddyp/following{/other_user}","gists_url":"https://api.github.com/users/chriddyp/gists{/gist_id}","starred_url":"https://api.github.com/users/chriddyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriddyp/subscriptions","organizations_url":"https://api.github.com/users/chriddyp/orgs","repos_url":"https://api.github.com/users/chriddyp/repos","events_url":"https://api.github.com/users/chriddyp/events{/privacy}","received_events_url":"https://api.github.com/users/chriddyp/received_events","type":"User","site_admin":false},"body":"I think that we need a separate setting for this. Something like `CONNECTOR_SSL_ENABLED` or even just `SSL_ENABLED`. \r\n\r\nIf someone is running this on their own servers against plot.ly, then they may or may not have SSL enabled even though https://plot.ly is.","created_at":"2017-10-09T18:23:45Z","updated_at":"2017-10-09T18:23:45Z","html_url":"https://github.com/plotly/plotly-database-connector/pull/180#discussion_r143543241","pull_request_url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/comments/143543241"},"html":{"href":"https://github.com/plotly/plotly-database-connector/pull/180#discussion_r143543241"},"pull_request":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180","id":140917699,"html_url":"https://github.com/plotly/plotly-database-connector/pull/180","diff_url":"https://github.com/plotly/plotly-database-connector/pull/180.diff","patch_url":"https://github.com/plotly/plotly-database-connector/pull/180.patch","issue_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues/180","number":180,"state":"open","locked":false,"title":"Implement Authentication","user":{"login":"tarzzz","id":1546532,"avatar_url":"https://avatars1.githubusercontent.com/u/1546532?v=4","gravatar_id":"","url":"https://api.github.com/users/tarzzz","html_url":"https://github.com/tarzzz","followers_url":"https://api.github.com/users/tarzzz/followers","following_url":"https://api.github.com/users/tarzzz/following{/other_user}","gists_url":"https://api.github.com/users/tarzzz/gists{/gist_id}","starred_url":"https://api.github.com/users/tarzzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarzzz/subscriptions","organizations_url":"https://api.github.com/users/tarzzz/orgs","repos_url":"https://api.github.com/users/tarzzz/repos","events_url":"https://api.github.com/users/tarzzz/events{/privacy}","received_events_url":"https://api.github.com/users/tarzzz/received_events","type":"User","site_admin":false},"body":"@chriddyp I have implemented a barebones version of how authorization will take place in DB Connector. \r\n\r\nIt would be great if you could take a preliminary look and let me know if I am going in the right direction.. 😸 \r\n\r\nMeanwhile, I would be working on implementing the actual logic and the process.","created_at":"2017-09-13T20:06:18Z","updated_at":"2017-10-09T18:23:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd55c2c8d92e396dc6e36c41e5e3d8cbceef3397","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180/commits","review_comments_url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180/comments","review_comment_url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues/180/comments","statuses_url":"https://api.github.com/repos/plotly/plotly-database-connector/statuses/7204ec66554f53e5732be3d1da64fcd020c0323d","head":{"label":"plotly:oauth","ref":"oauth","sha":"7204ec66554f53e5732be3d1da64fcd020c0323d","user":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":58595223,"name":"plotly-database-connector","full_name":"plotly/plotly-database-connector","owner":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/plotly-database-connector","description":"Connect the Plotly Chart Creator to your SQL Database :sparkles: ","fork":false,"url":"https://api.github.com/repos/plotly/plotly-database-connector","forks_url":"https://api.github.com/repos/plotly/plotly-database-connector/forks","keys_url":"https://api.github.com/repos/plotly/plotly-database-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/plotly-database-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/plotly-database-connector/teams","hooks_url":"https://api.github.com/repos/plotly/plotly-database-connector/hooks","issue_events_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/plotly-database-connector/events","assignees_url":"https://api.github.com/repos/plotly/plotly-database-connector/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/plotly-database-connector/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/plotly-database-connector/tags","blobs_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/plotly-database-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/plotly-database-connector/languages","stargazers_url":"https://api.github.com/repos/plotly/plotly-database-connector/stargazers","contributors_url":"https://api.github.com/repos/plotly/plotly-database-connector/contributors","subscribers_url":"https://api.github.com/repos/plotly/plotly-database-connector/subscribers","subscription_url":"https://api.github.com/repos/plotly/plotly-database-connector/subscription","commits_url":"https://api.github.com/repos/plotly/plotly-database-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/plotly-database-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/plotly-database-connector/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/plotly-database-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/plotly-database-connector/merges","archive_url":"https://api.github.com/repos/plotly/plotly-database-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/plotly-database-connector/downloads","issues_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/plotly-database-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/plotly-database-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/plotly-database-connector/labels{/name}","releases_url":"https://api.github.com/repos/plotly/plotly-database-connector/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/plotly-database-connector/deployments","created_at":"2016-05-12T01:03:48Z","updated_at":"2017-10-05T13:39:25Z","pushed_at":"2017-10-09T18:05:19Z","git_url":"git://github.com/plotly/plotly-database-connector.git","ssh_url":"git@github.com:plotly/plotly-database-connector.git","clone_url":"https://github.com/plotly/plotly-database-connector.git","svn_url":"https://github.com/plotly/plotly-database-connector","homepage":"https://plot.ly/create?upload=sql","size":8188,"stargazers_count":87,"watchers_count":87,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":87,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"c318602d517110c824401c025aafaf8b4c8188d8","user":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":58595223,"name":"plotly-database-connector","full_name":"plotly/plotly-database-connector","owner":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/plotly-database-connector","description":"Connect the Plotly Chart Creator to your SQL Database :sparkles: ","fork":false,"url":"https://api.github.com/repos/plotly/plotly-database-connector","forks_url":"https://api.github.com/repos/plotly/plotly-database-connector/forks","keys_url":"https://api.github.com/repos/plotly/plotly-database-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/plotly-database-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/plotly-database-connector/teams","hooks_url":"https://api.github.com/repos/plotly/plotly-database-connector/hooks","issue_events_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/plotly-database-connector/events","assignees_url":"https://api.github.com/repos/plotly/plotly-database-connector/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/plotly-database-connector/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/plotly-database-connector/tags","blobs_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/plotly-database-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/plotly-database-connector/languages","stargazers_url":"https://api.github.com/repos/plotly/plotly-database-connector/stargazers","contributors_url":"https://api.github.com/repos/plotly/plotly-database-connector/contributors","subscribers_url":"https://api.github.com/repos/plotly/plotly-database-connector/subscribers","subscription_url":"https://api.github.com/repos/plotly/plotly-database-connector/subscription","commits_url":"https://api.github.com/repos/plotly/plotly-database-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/plotly-database-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/plotly-database-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/plotly-database-connector/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/plotly-database-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/plotly-database-connector/merges","archive_url":"https://api.github.com/repos/plotly/plotly-database-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/plotly-database-connector/downloads","issues_url":"https://api.github.com/repos/plotly/plotly-database-connector/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/plotly-database-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/plotly-database-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/plotly-database-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/plotly-database-connector/labels{/name}","releases_url":"https://api.github.com/repos/plotly/plotly-database-connector/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/plotly-database-connector/deployments","created_at":"2016-05-12T01:03:48Z","updated_at":"2017-10-05T13:39:25Z","pushed_at":"2017-10-09T18:05:19Z","git_url":"git://github.com/plotly/plotly-database-connector.git","ssh_url":"git@github.com:plotly/plotly-database-connector.git","clone_url":"https://github.com/plotly/plotly-database-connector.git","svn_url":"https://github.com/plotly/plotly-database-connector","homepage":"https://plot.ly/create?upload=sql","size":8188,"stargazers_count":87,"watchers_count":87,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180"},"html":{"href":"https://github.com/plotly/plotly-database-connector/pull/180"},"issue":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/issues/180"},"comments":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/plotly-database-connector/statuses/7204ec66554f53e5732be3d1da64fcd020c0323d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chriddyp"}}