{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/17723","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17723/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17723/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17723/events","html_url":"https://github.com/cms-sw/cmssw/pull/17723","id":211378471,"number":17723,"title":"Improved muon track validation (new code + customization)","user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars2.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"labels":[{"id":334305616,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-notrun","name":"comparison-notrun","color":"bfe5bf","default":false},{"id":52882241,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-approved","name":"dqm-approved","color":"009800","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131220,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65","html_url":"https://github.com/cms-sw/cmssw/milestone/65","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65/labels","id":2358370,"number":65,"title":"Next CMSSW_9_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":107,"state":"open","created_at":"2017-03-02T09:15:47Z","updated_at":"2017-03-15T10:51:32Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2017-03-02T12:34:40Z","updated_at":"2017-03-15T11:09:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/17723","html_url":"https://github.com/cms-sw/cmssw/pull/17723","diff_url":"https://github.com/cms-sw/cmssw/pull/17723.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/17723.patch"},"body":"This PR superseded #16646, which had been automatically ported to 90X from the previous PR #15153  (let's hope this time it will make through swiftly !!)\r\n\r\n-- Summary description\r\n\r\nThis PR contains new code and configuration files, introduced alongside with the current code and cfgs. The new code is not yet used in the standard workflows, i.e. nothing should change anywhere.\r\n\r\nA customization function will allow the new and the default code to run (both) for a given prerelease cycle in few selected muon RelVals. This will allow for a smooth transition between the current and the new validation code. The plan foresees to deploy the new validation at the prerelease following the one with duplicate validations. At that point the old code should be possibly removed.\r\n\r\nThe new code and configuration has been flagged by a prefix \"New\" in filenames, class/module names, when it is a duplicate of the current production code.\r\n\r\nFeatures of the initial PR:\r\n\r\n- much clearer code, easier maintenance and developments, some technical improvements\r\n- new plots for performance vs PU, charge misid ...\r\n- removal of a few unused plots\r\n- improved settings of the histogram binning/ranges for different types of muons. All such settings contained in a cfg file \"histoParameters_cff.py\".\r\n- better choice of names for histograms, corrected labels etc...\r\n- better use of selectors to clean up the cfgs\r\n- slimmed/clearer cfgs as a consequence of the above changes\r\n- kept legacy configurations for use of TrackAssociatorByPosition in separate files, avoiding to clutter the main cfgs as in the current version\r\n- new default setting of the MuonAssociatorByHits to flag as fakes global muons with tracker and muon hits matched to different particles: this will produce sensible fake rates (much higher than what is obtained currently). Side note: the current configuration has always lived for historical reasons.\r\n\r\nAdded features to the current PR:\r\n- removed the pointer to DQMStore (as requested)\r\n- synchronized the New validation code to the current code, after parallel developments in the last few months (for upgrades)\r\n- customization function to activate the New validation for the temporary period of coexistence with the old one (thanks to Carlo Battilana)\r\n\nAutomatically ported from CMSSW_9_0_X #17489 (original by @abbiendi).\nPlease wait for a new IB (12 to 24H) before requesting to test this PR."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/286710930","html_url":"https://github.com/cms-sw/cmssw/pull/17723#issuecomment-286710930","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17723","id":286710930,"user":{"login":"abbiendi","id":5655983,"avatar_url":"https://avatars0.githubusercontent.com/u/5655983?v=3","gravatar_id":"","url":"https://api.github.com/users/abbiendi","html_url":"https://github.com/abbiendi","followers_url":"https://api.github.com/users/abbiendi/followers","following_url":"https://api.github.com/users/abbiendi/following{/other_user}","gists_url":"https://api.github.com/users/abbiendi/gists{/gist_id}","starred_url":"https://api.github.com/users/abbiendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbiendi/subscriptions","organizations_url":"https://api.github.com/users/abbiendi/orgs","repos_url":"https://api.github.com/users/abbiendi/repos","events_url":"https://api.github.com/users/abbiendi/events{/privacy}","received_events_url":"https://api.github.com/users/abbiendi/received_events","type":"User","site_admin":false},"created_at":"2017-03-15T11:09:14Z","updated_at":"2017-03-15T11:09:14Z","body":"Hi. Again the failures have nothing to do with the PR.\r\n"}}
{"actor":{"display_login":"abbiendi"}}