{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1337","repository_url":"https://api.github.com/repos/bitcoinj/bitcoinj","labels_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1337/labels{/name}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1337/comments","events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1337/events","html_url":"https://github.com/bitcoinj/bitcoinj/issues/1337","id":205353497,"number":1337,"title":"Deserialization transaction with non standard transaction version number","user":{"login":"jdojff","id":8099887,"avatar_url":"https://avatars.githubusercontent.com/u/8099887?v=3","gravatar_id":"","url":"https://api.github.com/users/jdojff","html_url":"https://github.com/jdojff","followers_url":"https://api.github.com/users/jdojff/followers","following_url":"https://api.github.com/users/jdojff/following{/other_user}","gists_url":"https://api.github.com/users/jdojff/gists{/gist_id}","starred_url":"https://api.github.com/users/jdojff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdojff/subscriptions","organizations_url":"https://api.github.com/users/jdojff/orgs","repos_url":"https://api.github.com/users/jdojff/repos","events_url":"https://api.github.com/users/jdojff/events{/privacy}","received_events_url":"https://api.github.com/users/jdojff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-02-04T15:18:53Z","updated_at":"2017-02-05T17:47:14Z","closed_at":null,"body":"Recently there were mined several transactions with version 2. Wallet noticed it as non standard transaction and saved them to the wallet file.\r\nProblem is with deserialization: Transaction object is created with default version 1 and no value is taken from protobuf object. This causes protobuf object hash and newly calculated transaction hash to mismatch because of different version value in different objects of the transaction.\r\nI believe while deserializing in ``readTransaction`` version number should be read as well. What about other issues regarding this, in other parts of the library?"},"comment":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/comments/277535661","html_url":"https://github.com/bitcoinj/bitcoinj/issues/1337#issuecomment-277535661","issue_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1337","id":277535661,"user":{"login":"schildbach","id":743306,"avatar_url":"https://avatars.githubusercontent.com/u/743306?v=3","gravatar_id":"","url":"https://api.github.com/users/schildbach","html_url":"https://github.com/schildbach","followers_url":"https://api.github.com/users/schildbach/followers","following_url":"https://api.github.com/users/schildbach/following{/other_user}","gists_url":"https://api.github.com/users/schildbach/gists{/gist_id}","starred_url":"https://api.github.com/users/schildbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schildbach/subscriptions","organizations_url":"https://api.github.com/users/schildbach/orgs","repos_url":"https://api.github.com/users/schildbach/repos","events_url":"https://api.github.com/users/schildbach/events{/privacy}","received_events_url":"https://api.github.com/users/schildbach/received_events","type":"User","site_admin":false},"created_at":"2017-02-05T17:47:14Z","updated_at":"2017-02-05T17:47:14Z","body":"Ok version 2 transactions seem to be relevant to [BIP68](https://github.com/bitcoin/bips/blob/master/bip-0068.mediawiki) and [BIP112](https://github.com/bitcoin/bips/blob/master/bip-0112.mediawiki)."}}
{"actor":{"display_login":"schildbach"}}