{"action":"closed","number":691,"pull_request":{"url":"https://api.github.com/repos/cyverse/troposphere/pulls/691","id":136894843,"html_url":"https://github.com/cyverse/troposphere/pull/691","diff_url":"https://github.com/cyverse/troposphere/pull/691.diff","patch_url":"https://github.com/cyverse/troposphere/pull/691.patch","issue_url":"https://api.github.com/repos/cyverse/troposphere/issues/691","number":691,"state":"closed","locked":false,"title":"Handle Instance Launch submission before closing modal","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n### Problem\r\n\r\nWhen we moved to the `api/v2/instances` endpoint for launching new instances, we introduced latency to the ProjectResources view from when the instance is launched & it appears in the view (so the modal closing, but the POST is still _pending_ and could be so for 90 or more seconds). \r\n\r\n### Options\r\n\r\n#### Option A\r\n\r\nI looked into mirroring the \"pending\" resource approaches that is used by Volumes. This approach does an _eager-add_ into a collection that is conditionally concatenated when `getVolumesFor(project)` is called. \r\n\r\nI did attempt this approach first. It did not appear that the view as receiving _updates_. I was somewhat concerned with introducing the manual handling of _pending_ models. I do have the rough changes for this stashed.\r\n\r\n#### Option B\r\n\r\nAlter the behavior of the modal to make the Instance create submission prior to _hiding_/closing. There is an open feature request for this behavior ([ATMO-1153](https://pods.iplantcollaborative.org/jira/browse/ATMO-1153)). The reason is that when an instance launch fails, all of the \"work\" done selecting options is **lost**. A more _helpful_ approach would be for the launch modal to remain open. If launch fails, a different provider or different size would be selected and re-attempted. \r\n\r\nThis has the added benefit of \"distracting\" anyone from the latency/delay associated with POSTing to `api/v2/instances`. \r\n\r\n- on success ✅  http://recordit.co/6HDS73e3Hp\r\n- on failure :x: http://recordit.co/AFaBAvCnyC\r\n\r\nThere still needs to be some polish and improvements to the animation for \"replacing\" the <kbd>LAUNCH INSTANCE</kbd> with a spinner. Also, the text positioning within that placeholder could be aligned, vertically, to the baseline of the <kbd>CANCEL</kbd> text. \r\n\r\n**Option B** is being presented as an enhance (see ATMO-1153) and as a resolution to a visual feedback quirk regarding the appearance of the Instance within `<InstanceList />` of the Project Resources view.\r\n\r\n## Checklist before merging Pull Requests\r\n- [ ] New test(s) included to reproduce the bug/verify the feature\r\n- [ ] ~Documentation created/updated at [Example link to documentation](https://example.test/doc#new_section) to give context to the feature~\r\n- [ ] Reviewed and approved by at least one other contributor.\r\n- [ ] ~New variables supported in Clank~\r\n- [ ] ~New variables committed to secrets repos~\r\n","created_at":"2017-08-22T05:34:11Z","updated_at":"2017-08-22T17:31:09Z","closed_at":"2017-08-22T17:31:09Z","merged_at":"2017-08-22T17:31:09Z","merge_commit_sha":"a442cf88c1f556e9e1619e491a45c5f76a3401aa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/cyverse/troposphere/milestones/16","html_url":"https://github.com/cyverse/troposphere/milestone/16","labels_url":"https://api.github.com/repos/cyverse/troposphere/milestones/16/labels","id":2679609,"number":16,"title":"Ancient-Asteroid (v27)","description":"Atmosphere Release v27.0","creator":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":11,"state":"open","created_at":"2017-08-03T19:17:32Z","updated_at":"2017-08-22T17:31:09Z","due_on":"2017-08-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cyverse/troposphere/pulls/691/commits","review_comments_url":"https://api.github.com/repos/cyverse/troposphere/pulls/691/comments","review_comment_url":"https://api.github.com/repos/cyverse/troposphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyverse/troposphere/issues/691/comments","statuses_url":"https://api.github.com/repos/cyverse/troposphere/statuses/aa51d25eec65e84e0f4678e26d24bf6e6fc6517a","head":{"label":"lenards:atmo-1153","ref":"atmo-1153","sha":"aa51d25eec65e84e0f4678e26d24bf6e6fc6517a","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"repo":{"id":42893619,"name":"troposphere","full_name":"lenards/troposphere","owner":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lenards/troposphere","description":"Atmosphere web client","fork":true,"url":"https://api.github.com/repos/lenards/troposphere","forks_url":"https://api.github.com/repos/lenards/troposphere/forks","keys_url":"https://api.github.com/repos/lenards/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lenards/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lenards/troposphere/teams","hooks_url":"https://api.github.com/repos/lenards/troposphere/hooks","issue_events_url":"https://api.github.com/repos/lenards/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/lenards/troposphere/events","assignees_url":"https://api.github.com/repos/lenards/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/lenards/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/lenards/troposphere/tags","blobs_url":"https://api.github.com/repos/lenards/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lenards/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lenards/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/lenards/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lenards/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/lenards/troposphere/languages","stargazers_url":"https://api.github.com/repos/lenards/troposphere/stargazers","contributors_url":"https://api.github.com/repos/lenards/troposphere/contributors","subscribers_url":"https://api.github.com/repos/lenards/troposphere/subscribers","subscription_url":"https://api.github.com/repos/lenards/troposphere/subscription","commits_url":"https://api.github.com/repos/lenards/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/lenards/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/lenards/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/lenards/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/lenards/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/lenards/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lenards/troposphere/merges","archive_url":"https://api.github.com/repos/lenards/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lenards/troposphere/downloads","issues_url":"https://api.github.com/repos/lenards/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/lenards/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/lenards/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/lenards/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lenards/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/lenards/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/lenards/troposphere/deployments","created_at":"2015-09-21T21:05:47Z","updated_at":"2016-03-22T20:17:51Z","pushed_at":"2017-08-22T17:25:58Z","git_url":"git://github.com/lenards/troposphere.git","ssh_url":"git@github.com:lenards/troposphere.git","clone_url":"https://github.com/lenards/troposphere.git","svn_url":"https://github.com/lenards/troposphere","homepage":null,"size":9731,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyverse:v27","ref":"v27","sha":"adae3d4722ef6ecddefe6acf2d8cd0d0fb11b74c","user":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars0.githubusercontent.com/u/15638129?v=4","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":17913633,"name":"troposphere","full_name":"cyverse/troposphere","owner":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars0.githubusercontent.com/u/15638129?v=4","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse/troposphere","description":"Atmosphere web client","fork":false,"url":"https://api.github.com/repos/cyverse/troposphere","forks_url":"https://api.github.com/repos/cyverse/troposphere/forks","keys_url":"https://api.github.com/repos/cyverse/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse/troposphere/teams","hooks_url":"https://api.github.com/repos/cyverse/troposphere/hooks","issue_events_url":"https://api.github.com/repos/cyverse/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse/troposphere/events","assignees_url":"https://api.github.com/repos/cyverse/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse/troposphere/tags","blobs_url":"https://api.github.com/repos/cyverse/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse/troposphere/languages","stargazers_url":"https://api.github.com/repos/cyverse/troposphere/stargazers","contributors_url":"https://api.github.com/repos/cyverse/troposphere/contributors","subscribers_url":"https://api.github.com/repos/cyverse/troposphere/subscribers","subscription_url":"https://api.github.com/repos/cyverse/troposphere/subscription","commits_url":"https://api.github.com/repos/cyverse/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse/troposphere/merges","archive_url":"https://api.github.com/repos/cyverse/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse/troposphere/downloads","issues_url":"https://api.github.com/repos/cyverse/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/cyverse/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse/troposphere/deployments","created_at":"2014-03-19T17:26:44Z","updated_at":"2016-11-21T17:04:16Z","pushed_at":"2017-08-22T17:31:09Z","git_url":"git://github.com/cyverse/troposphere.git","ssh_url":"git@github.com:cyverse/troposphere.git","clone_url":"https://github.com/cyverse/troposphere.git","svn_url":"https://github.com/cyverse/troposphere","homepage":null,"size":9272,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":14,"forks":16,"open_issues":14,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/691"},"html":{"href":"https://github.com/cyverse/troposphere/pull/691"},"issue":{"href":"https://api.github.com/repos/cyverse/troposphere/issues/691"},"comments":{"href":"https://api.github.com/repos/cyverse/troposphere/issues/691/comments"},"review_comments":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/691/comments"},"review_comment":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyverse/troposphere/pulls/691/commits"},"statuses":{"href":"https://api.github.com/repos/cyverse/troposphere/statuses/aa51d25eec65e84e0f4678e26d24bf6e6fc6517a"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lenards","id":5923,"avatar_url":"https://avatars1.githubusercontent.com/u/5923?v=4","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":117,"deletions":87,"changed_files":6}}
{"actor":{"display_login":"lenards"}}