{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk_elements/issues/533","repository_url":"https://api.github.com/repos/alphagov/govuk_elements","labels_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/533/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/533/comments","events_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/533/events","html_url":"https://github.com/alphagov/govuk_elements/pull/533","id":244661071,"number":533,"title":"Add custom styling for select elements","user":{"login":"danmitchell-","id":3071606,"avatar_url":"https://avatars3.githubusercontent.com/u/3071606?v=4","gravatar_id":"","url":"https://api.github.com/users/danmitchell-","html_url":"https://github.com/danmitchell-","followers_url":"https://api.github.com/users/danmitchell-/followers","following_url":"https://api.github.com/users/danmitchell-/following{/other_user}","gists_url":"https://api.github.com/users/danmitchell-/gists{/gist_id}","starred_url":"https://api.github.com/users/danmitchell-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmitchell-/subscriptions","organizations_url":"https://api.github.com/users/danmitchell-/orgs","repos_url":"https://api.github.com/users/danmitchell-/repos","events_url":"https://api.github.com/users/danmitchell-/events{/privacy}","received_events_url":"https://api.github.com/users/danmitchell-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-07-21T12:57:28Z","updated_at":"2017-07-25T18:01:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk_elements/pulls/533","html_url":"https://github.com/alphagov/govuk_elements/pull/533","diff_url":"https://github.com/alphagov/govuk_elements/pull/533.diff","patch_url":"https://github.com/alphagov/govuk_elements/pull/533.patch"},"body":"#### What problem does the pull request solve?\r\nOverwrites the default browser styling on select elements to make them consistent with other inputs\r\n\r\n#### How has this been tested?\r\nChrome, Safari, Firefox, ie9, ie10, ie11, Edge\r\n\r\n#### Screenshots (if appropriate):\r\n#### Before\r\n![screen shot 2017-07-24 at 10 34 01](https://user-images.githubusercontent.com/3071606/28517225-abc010ce-705b-11e7-8cf2-b7e839d382c2.png)\r\n\r\n#### After\r\n![screen shot 2017-07-21 at 13 47 17](https://user-images.githubusercontent.com/3071606/28463981-21d7ea90-6e1b-11e7-9473-5a0d1319ba4e.png)\r\n![screen shot 2017-07-21 at 13 47 06](https://user-images.githubusercontent.com/3071606/28463983-21d83a4a-6e1b-11e7-9056-436443e81b12.png)\r\n![screen shot 2017-07-21 at 13 45 35](https://user-images.githubusercontent.com/3071606/28463982-21d85f02-6e1b-11e7-8c6f-88c1dfb5c1aa.png)\r\n![screen shot 2017-07-24 at 15 03 02](https://user-images.githubusercontent.com/3071606/28527057-4de6fbfe-7081-11e7-9629-924e2607cfa0.png)\r\n![screen shot 2017-07-24 at 15 02 39](https://user-images.githubusercontent.com/3071606/28527061-5323b576-7081-11e7-8e87-c8518975087a.png)\r\n\r\n#### What type of change is it?\r\n- New feature (non-breaking change which adds functionality)\r\n\r\n#### Has the documentation been updated?\r\n- Not required\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/govuk_elements/issues/comments/317819469","html_url":"https://github.com/alphagov/govuk_elements/pull/533#issuecomment-317819469","issue_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/533","id":317819469,"user":{"login":"selfthinker","id":108893,"avatar_url":"https://avatars3.githubusercontent.com/u/108893?v=4","gravatar_id":"","url":"https://api.github.com/users/selfthinker","html_url":"https://github.com/selfthinker","followers_url":"https://api.github.com/users/selfthinker/followers","following_url":"https://api.github.com/users/selfthinker/following{/other_user}","gists_url":"https://api.github.com/users/selfthinker/gists{/gist_id}","starred_url":"https://api.github.com/users/selfthinker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selfthinker/subscriptions","organizations_url":"https://api.github.com/users/selfthinker/orgs","repos_url":"https://api.github.com/users/selfthinker/repos","events_url":"https://api.github.com/users/selfthinker/events{/privacy}","received_events_url":"https://api.github.com/users/selfthinker/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T18:01:03Z","updated_at":"2017-07-25T18:01:03Z","body":"Harry Roberts made a case against e.g. using `background: red` instead of `background-color: red`. And I agree with that sentiment.\r\nThis case here is about grouping lots of existing properties, though, which is a different case.\r\n\r\nNowhere in his article does he say shorthand is always bad. We cannot generalise based on that click bait article heading. ;-)\r\nHis words (which I agree with):\r\n> The key thing to remember is that shorthand is bad when it’s affecting properties that you don’t actually need to modify.\r\n\r\nOr I would say, it's important to know when to use it and when not to use it. But I would definitely not call it an \"anti-pattern\". (I hate that term!)"}}
{"actor":{"display_login":"selfthinker"}}