{"action":"opened","issue":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/4470","repository_url":"https://api.github.com/repos/syncthing/syncthing","labels_url":"https://api.github.com/repos/syncthing/syncthing/issues/4470/labels{/name}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/4470/comments","events_url":"https://api.github.com/repos/syncthing/syncthing/issues/4470/events","html_url":"https://github.com/syncthing/syncthing/issues/4470","id":268922121,"number":4470,"title":"strange weak hash benchmark results","user":{"login":"DrSchnagels","id":20019440,"avatar_url":"https://avatars2.githubusercontent.com/u/20019440?v=4","gravatar_id":"","url":"https://api.github.com/users/DrSchnagels","html_url":"https://github.com/DrSchnagels","followers_url":"https://api.github.com/users/DrSchnagels/followers","following_url":"https://api.github.com/users/DrSchnagels/following{/other_user}","gists_url":"https://api.github.com/users/DrSchnagels/gists{/gist_id}","starred_url":"https://api.github.com/users/DrSchnagels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrSchnagels/subscriptions","organizations_url":"https://api.github.com/users/DrSchnagels/orgs","repos_url":"https://api.github.com/users/DrSchnagels/repos","events_url":"https://api.github.com/users/DrSchnagels/events{/privacy}","received_events_url":"https://api.github.com/users/DrSchnagels/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-26T21:46:23Z","updated_at":"2017-10-26T21:46:23Z","closed_at":null,"author_association":"NONE","body":"v0.14.40-rc.3, Windows 10 Fall Creators Update (64 bit), Dell XPS 9360 with 2/4 Intel 7th gen CPU (7500U 2.7 GHz) gives me this result in the console:\r\n\r\n```\r\n[OGKQU] 23:08:20 INFO: Single thread SHA256 performance is 431 MB/s using minio/sha256-simd (363 MB/s using crypto/sha256).\r\n[OGKQU] 23:08:20 INFO: Hashing performance with weak hash is 354.24 MB/s\r\n[OGKQU] 23:08:21 INFO: Hashing performance without weak hash is 417.51 MB/s\r\n[OGKQU] 23:08:21 INFO: Weak hash enabled, as it has an acceptable performance impact.\r\n```\r\n\r\nShouldn't weak hash be disabled since it gives a worse performance?\r\n\r\nFurthermore (sorry): What does weak hash do anyway?\r\nIt makes me silly-like think that my files might get weakly hashed. I would prefer to have them perfectly super good hashed and super secured ;). I'm a civil engineer and I just did calculations with 90 tons of force.\r\nWeak is a mean word for me ;). Why not rename it to quick hash?\r\n\r\nI used to set Weak Hash Selection Method to never but I really don't understand what it does.\r\nAnd why is it always disabled on Android (forced?) ?\r\n\r\nThanks a lot for your help!"}}
{"actor":{"display_login":"DrSchnagels"}}