{"action":"created","comment":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/123867496","pull_request_review_id":46079271,"id":123867496,"diff_hunk":"@@ -0,0 +1,8 @@\n+#!/usr/bin/env php","path":"bin/acl-xdmod-management","position":1,"original_position":1,"commit_id":"d3b68df66e7644c3585692b5519e12d70249a71b","original_commit_id":"d3b68df66e7644c3585692b5519e12d70249a71b","user":{"login":"jpwhite4","id":5342179,"avatar_url":"https://avatars1.githubusercontent.com/u/5342179?v=3","gravatar_id":"","url":"https://api.github.com/users/jpwhite4","html_url":"https://github.com/jpwhite4","followers_url":"https://api.github.com/users/jpwhite4/followers","following_url":"https://api.github.com/users/jpwhite4/following{/other_user}","gists_url":"https://api.github.com/users/jpwhite4/gists{/gist_id}","starred_url":"https://api.github.com/users/jpwhite4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpwhite4/subscriptions","organizations_url":"https://api.github.com/users/jpwhite4/orgs","repos_url":"https://api.github.com/users/jpwhite4/repos","events_url":"https://api.github.com/users/jpwhite4/events{/privacy}","received_events_url":"https://api.github.com/users/jpwhite4/received_events","type":"User","site_admin":false},"body":"Why do you have a php script that executes a subshell to run a program? Surely this could be a shell script with the following content:\r\n```\r\nacl-etl -pacls-xdmod-management -g\r\n```\r\nIs this wrapper even needed? Surely you can just call the acl-etl script directly?","created_at":"2017-06-24T01:40:39Z","updated_at":"2017-06-24T01:59:23Z","html_url":"https://github.com/ubccr/xdmod/pull/97#discussion_r123867496","pull_request_url":"https://api.github.com/repos/ubccr/xdmod/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments/123867496"},"html":{"href":"https://github.com/ubccr/xdmod/pull/97#discussion_r123867496"},"pull_request":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/ubccr/xdmod/pulls/97","id":115837018,"html_url":"https://github.com/ubccr/xdmod/pull/97","diff_url":"https://github.com/ubccr/xdmod/pull/97.diff","patch_url":"https://github.com/ubccr/xdmod/pull/97.patch","issue_url":"https://api.github.com/repos/ubccr/xdmod/issues/97","number":97,"state":"open","locked":false,"title":"Modular Acls: ETL Support","user":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars1.githubusercontent.com/u/10520715?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"body":"Adding in the files required to bootstrap / support the new modular Acl system.\r\n\r\n## Description\r\nThere are two ETL pipelines:\r\n- acls::AclTableManagement: Can be run any number of times, will keep the db structure up to date. \r\n- acl_bootstrap::AclTableImport: Should only be run once. Boostraps the tables with their initial data.\r\n\r\nIncluded are the table definition files ( etl/etl_tables.d/acls/*.json ) and the scripts for populating them \r\n( etl/etl_sql.d/acls/*.sql ). Where possible the scripts attempt to only insert records when a record that matches the values being inserted is not found. \r\n\r\n## Motivation and Context\r\nTo serve as the basis for the rest of the Acl system ( and to provide a baseline for the rest of the broken up PR's )\r\n\r\n## Tests performed\r\nmanual tests on a dev cloud instance installing locally. \r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [X] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [X] My code follows the code style of this project as found in the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n","created_at":"2017-04-13T20:32:09Z","updated_at":"2017-06-24T01:59:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77cdcf8f9d4c71a4ba6c6ef7cc7239f8b0e2dcfd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/ubccr/xdmod/milestones/4","html_url":"https://github.com/ubccr/xdmod/milestone/4","labels_url":"https://api.github.com/repos/ubccr/xdmod/milestones/4/labels","id":2453508,"number":4,"title":"v7.0.0","description":"","creator":{"login":"tyearke","id":8796171,"avatar_url":"https://avatars0.githubusercontent.com/u/8796171?v=3","gravatar_id":"","url":"https://api.github.com/users/tyearke","html_url":"https://github.com/tyearke","followers_url":"https://api.github.com/users/tyearke/followers","following_url":"https://api.github.com/users/tyearke/following{/other_user}","gists_url":"https://api.github.com/users/tyearke/gists{/gist_id}","starred_url":"https://api.github.com/users/tyearke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyearke/subscriptions","organizations_url":"https://api.github.com/users/tyearke/orgs","repos_url":"https://api.github.com/users/tyearke/repos","events_url":"https://api.github.com/users/tyearke/events{/privacy}","received_events_url":"https://api.github.com/users/tyearke/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":39,"state":"open","created_at":"2017-04-12T18:16:42Z","updated_at":"2017-06-22T20:48:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ubccr/xdmod/pulls/97/commits","review_comments_url":"https://api.github.com/repos/ubccr/xdmod/pulls/97/comments","review_comment_url":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubccr/xdmod/issues/97/comments","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/d3b68df66e7644c3585692b5519e12d70249a71b","head":{"label":"ryanrath:acl_etl","ref":"acl_etl","sha":"d3b68df66e7644c3585692b5519e12d70249a71b","user":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars1.githubusercontent.com/u/10520715?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"repo":{"id":77923709,"name":"xdmod","full_name":"ryanrath/xdmod","owner":{"login":"ryanrath","id":10520715,"avatar_url":"https://avatars1.githubusercontent.com/u/10520715?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanrath","html_url":"https://github.com/ryanrath","followers_url":"https://api.github.com/users/ryanrath/followers","following_url":"https://api.github.com/users/ryanrath/following{/other_user}","gists_url":"https://api.github.com/users/ryanrath/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanrath/subscriptions","organizations_url":"https://api.github.com/users/ryanrath/orgs","repos_url":"https://api.github.com/users/ryanrath/repos","events_url":"https://api.github.com/users/ryanrath/events{/privacy}","received_events_url":"https://api.github.com/users/ryanrath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanrath/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":true,"url":"https://api.github.com/repos/ryanrath/xdmod","forks_url":"https://api.github.com/repos/ryanrath/xdmod/forks","keys_url":"https://api.github.com/repos/ryanrath/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanrath/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanrath/xdmod/teams","hooks_url":"https://api.github.com/repos/ryanrath/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ryanrath/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ryanrath/xdmod/events","assignees_url":"https://api.github.com/repos/ryanrath/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ryanrath/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ryanrath/xdmod/tags","blobs_url":"https://api.github.com/repos/ryanrath/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanrath/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanrath/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanrath/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanrath/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanrath/xdmod/languages","stargazers_url":"https://api.github.com/repos/ryanrath/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ryanrath/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ryanrath/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ryanrath/xdmod/subscription","commits_url":"https://api.github.com/repos/ryanrath/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanrath/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanrath/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanrath/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanrath/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ryanrath/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanrath/xdmod/merges","archive_url":"https://api.github.com/repos/ryanrath/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanrath/xdmod/downloads","issues_url":"https://api.github.com/repos/ryanrath/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ryanrath/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanrath/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanrath/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanrath/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ryanrath/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ryanrath/xdmod/deployments","created_at":"2017-01-03T14:23:30Z","updated_at":"2017-01-03T14:23:34Z","pushed_at":"2017-06-23T20:05:20Z","git_url":"git://github.com/ryanrath/xdmod.git","ssh_url":"git@github.com:ryanrath/xdmod.git","clone_url":"https://github.com/ryanrath/xdmod.git","svn_url":"https://github.com/ryanrath/xdmod","homepage":"http://open.xdmod.org","size":5429,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"xdmod6.5"}},"base":{"label":"ubccr:xdmod7.0","ref":"xdmod7.0","sha":"78c14958a7c8f922ec1a62ea9fa5c8ced0dc1728","user":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars1.githubusercontent.com/u/2301947?v=3","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"repo":{"id":72233032,"name":"xdmod","full_name":"ubccr/xdmod","owner":{"login":"ubccr","id":2301947,"avatar_url":"https://avatars1.githubusercontent.com/u/2301947?v=3","gravatar_id":"","url":"https://api.github.com/users/ubccr","html_url":"https://github.com/ubccr","followers_url":"https://api.github.com/users/ubccr/followers","following_url":"https://api.github.com/users/ubccr/following{/other_user}","gists_url":"https://api.github.com/users/ubccr/gists{/gist_id}","starred_url":"https://api.github.com/users/ubccr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubccr/subscriptions","organizations_url":"https://api.github.com/users/ubccr/orgs","repos_url":"https://api.github.com/users/ubccr/repos","events_url":"https://api.github.com/users/ubccr/events{/privacy}","received_events_url":"https://api.github.com/users/ubccr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubccr/xdmod","description":"An open framework for collecting and analyzing HPC metrics.","fork":false,"url":"https://api.github.com/repos/ubccr/xdmod","forks_url":"https://api.github.com/repos/ubccr/xdmod/forks","keys_url":"https://api.github.com/repos/ubccr/xdmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubccr/xdmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubccr/xdmod/teams","hooks_url":"https://api.github.com/repos/ubccr/xdmod/hooks","issue_events_url":"https://api.github.com/repos/ubccr/xdmod/issues/events{/number}","events_url":"https://api.github.com/repos/ubccr/xdmod/events","assignees_url":"https://api.github.com/repos/ubccr/xdmod/assignees{/user}","branches_url":"https://api.github.com/repos/ubccr/xdmod/branches{/branch}","tags_url":"https://api.github.com/repos/ubccr/xdmod/tags","blobs_url":"https://api.github.com/repos/ubccr/xdmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubccr/xdmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubccr/xdmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubccr/xdmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubccr/xdmod/statuses/{sha}","languages_url":"https://api.github.com/repos/ubccr/xdmod/languages","stargazers_url":"https://api.github.com/repos/ubccr/xdmod/stargazers","contributors_url":"https://api.github.com/repos/ubccr/xdmod/contributors","subscribers_url":"https://api.github.com/repos/ubccr/xdmod/subscribers","subscription_url":"https://api.github.com/repos/ubccr/xdmod/subscription","commits_url":"https://api.github.com/repos/ubccr/xdmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubccr/xdmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubccr/xdmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubccr/xdmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubccr/xdmod/contents/{+path}","compare_url":"https://api.github.com/repos/ubccr/xdmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubccr/xdmod/merges","archive_url":"https://api.github.com/repos/ubccr/xdmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubccr/xdmod/downloads","issues_url":"https://api.github.com/repos/ubccr/xdmod/issues{/number}","pulls_url":"https://api.github.com/repos/ubccr/xdmod/pulls{/number}","milestones_url":"https://api.github.com/repos/ubccr/xdmod/milestones{/number}","notifications_url":"https://api.github.com/repos/ubccr/xdmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubccr/xdmod/labels{/name}","releases_url":"https://api.github.com/repos/ubccr/xdmod/releases{/id}","deployments_url":"https://api.github.com/repos/ubccr/xdmod/deployments","created_at":"2016-10-28T18:41:25Z","updated_at":"2017-06-14T09:54:52Z","pushed_at":"2017-06-23T21:26:26Z","git_url":"git://github.com/ubccr/xdmod.git","ssh_url":"git@github.com:ubccr/xdmod.git","clone_url":"https://github.com/ubccr/xdmod.git","svn_url":"https://github.com/ubccr/xdmod","homepage":"http://open.xdmod.org","size":4951,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":17,"default_branch":"xdmod7.0"}},"_links":{"self":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/97"},"html":{"href":"https://github.com/ubccr/xdmod/pull/97"},"issue":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/97"},"comments":{"href":"https://api.github.com/repos/ubccr/xdmod/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubccr/xdmod/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/ubccr/xdmod/statuses/d3b68df66e7644c3585692b5519e12d70249a71b"}}}}
{"actor":{"display_login":"jpwhite4"}}