{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/137282076","pull_request_review_id":60927777,"id":137282076,"diff_hunk":"@@ -201,7 +201,8 @@ def _check_glob_minions(self, expr, greedy):  # pylint: disable=unused-argument\n         '''\n         Return the minions found by looking via globs\n         '''\n-        return fnmatch.filter(self._pki_minions(), expr)\n+        return {'minions': fnmatch.filter(self._pki_minions(), expr),\n+                'missing': list()}","path":"salt/utils/minions.py","position":null,"original_position":6,"commit_id":"0acf0ffd69cac1f0b00d51f5f54005891110081f","original_commit_id":"92bc4fa39b5e6dce6f13ee7763948ad1f9c96373","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars0.githubusercontent.com/u/718525?v=4","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"body":":+1: I have replaced all the occurrences of `list()` with `[]`","created_at":"2017-09-06T14:23:01Z","updated_at":"2017-09-06T14:23:02Z","html_url":"https://github.com/saltstack/salt/pull/42915#discussion_r137282076","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/42915","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/137282076"},"html":{"href":"https://github.com/saltstack/salt/pull/42915#discussion_r137282076"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/42915"}},"in_reply_to_id":137136517},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/42915","id":135650116,"html_url":"https://github.com/saltstack/salt/pull/42915","diff_url":"https://github.com/saltstack/salt/pull/42915.diff","patch_url":"https://github.com/saltstack/salt/pull/42915.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/42915","number":42915,"state":"open","locked":false,"title":"Show missing minions in lists & nodegroups","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars0.githubusercontent.com/u/718525?v=4","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nMarks non-existent nodes specified in a list or as part of a node group as failed when called via the `salt` command.\r\n\r\n### What issues does this PR fix or reference?\r\n#41326\r\n\r\n### Previous Behavior\r\nNon-existent nodes were silently ignored.\r\n\r\n### New Behavior\r\nCommands are not sent to non-existent nodes but they are included in the final output and marked as failed.\r\n\r\n### Tests written?\r\nYes\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n","created_at":"2017-08-14T17:50:12Z","updated_at":"2017-09-06T14:23:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11dd0dfb6146955fc0af5d4f4ad083adbea2fe05","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/42915/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/42915/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/42915/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/0acf0ffd69cac1f0b00d51f5f54005891110081f","head":{"label":"garethgreenaway:missing_minions_branch","ref":"missing_minions_branch","sha":"0acf0ffd69cac1f0b00d51f5f54005891110081f","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars0.githubusercontent.com/u/718525?v=4","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"repo":{"id":29325120,"name":"salt","full_name":"garethgreenaway/salt","owner":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars0.githubusercontent.com/u/718525?v=4","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garethgreenaway/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/garethgreenaway/salt","forks_url":"https://api.github.com/repos/garethgreenaway/salt/forks","keys_url":"https://api.github.com/repos/garethgreenaway/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethgreenaway/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethgreenaway/salt/teams","hooks_url":"https://api.github.com/repos/garethgreenaway/salt/hooks","issue_events_url":"https://api.github.com/repos/garethgreenaway/salt/issues/events{/number}","events_url":"https://api.github.com/repos/garethgreenaway/salt/events","assignees_url":"https://api.github.com/repos/garethgreenaway/salt/assignees{/user}","branches_url":"https://api.github.com/repos/garethgreenaway/salt/branches{/branch}","tags_url":"https://api.github.com/repos/garethgreenaway/salt/tags","blobs_url":"https://api.github.com/repos/garethgreenaway/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethgreenaway/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethgreenaway/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethgreenaway/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethgreenaway/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/garethgreenaway/salt/languages","stargazers_url":"https://api.github.com/repos/garethgreenaway/salt/stargazers","contributors_url":"https://api.github.com/repos/garethgreenaway/salt/contributors","subscribers_url":"https://api.github.com/repos/garethgreenaway/salt/subscribers","subscription_url":"https://api.github.com/repos/garethgreenaway/salt/subscription","commits_url":"https://api.github.com/repos/garethgreenaway/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethgreenaway/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethgreenaway/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethgreenaway/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/garethgreenaway/salt/contents/{+path}","compare_url":"https://api.github.com/repos/garethgreenaway/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethgreenaway/salt/merges","archive_url":"https://api.github.com/repos/garethgreenaway/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethgreenaway/salt/downloads","issues_url":"https://api.github.com/repos/garethgreenaway/salt/issues{/number}","pulls_url":"https://api.github.com/repos/garethgreenaway/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/garethgreenaway/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/garethgreenaway/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethgreenaway/salt/labels{/name}","releases_url":"https://api.github.com/repos/garethgreenaway/salt/releases{/id}","deployments_url":"https://api.github.com/repos/garethgreenaway/salt/deployments","created_at":"2015-01-16T00:28:10Z","updated_at":"2016-02-08T00:06:44Z","pushed_at":"2017-09-06T14:17:22Z","git_url":"git://github.com/garethgreenaway/salt.git","ssh_url":"git@github.com:garethgreenaway/salt.git","clone_url":"https://github.com/garethgreenaway/salt.git","svn_url":"https://github.com/garethgreenaway/salt","homepage":"saltstack.com","size":172191,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"2d05aa0db1e2cdfc74282846432ffd81e6853d26","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2017-09-06T14:16:59Z","pushed_at":"2017-09-06T14:22:05Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":175138,"stargazers_count":8068,"watchers_count":8068,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3762,"mirror_url":null,"open_issues_count":4500,"forks":3762,"open_issues":4500,"watchers":8068,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/42915"},"html":{"href":"https://github.com/saltstack/salt/pull/42915"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/42915"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/42915/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/42915/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/42915/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/0acf0ffd69cac1f0b00d51f5f54005891110081f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"garethgreenaway"}}