{"action":"created","issue":{"url":"https://api.github.com/repos/kesne/babel-plugin-inline-react-svg/issues/6","repository_url":"https://api.github.com/repos/kesne/babel-plugin-inline-react-svg","labels_url":"https://api.github.com/repos/kesne/babel-plugin-inline-react-svg/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/kesne/babel-plugin-inline-react-svg/issues/6/comments","events_url":"https://api.github.com/repos/kesne/babel-plugin-inline-react-svg/issues/6/events","html_url":"https://github.com/kesne/babel-plugin-inline-react-svg/issues/6","id":215084310,"number":6,"title":"Use dangerouslySetInnerHTML for contents of SVG","user":{"login":"lencioni","id":195534,"avatar_url":"https://avatars0.githubusercontent.com/u/195534?v=3","gravatar_id":"","url":"https://api.github.com/users/lencioni","html_url":"https://github.com/lencioni","followers_url":"https://api.github.com/users/lencioni/followers","following_url":"https://api.github.com/users/lencioni/following{/other_user}","gists_url":"https://api.github.com/users/lencioni/gists{/gist_id}","starred_url":"https://api.github.com/users/lencioni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lencioni/subscriptions","organizations_url":"https://api.github.com/users/lencioni/orgs","repos_url":"https://api.github.com/users/lencioni/repos","events_url":"https://api.github.com/users/lencioni/events{/privacy}","received_events_url":"https://api.github.com/users/lencioni/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-17T18:20:26Z","updated_at":"2017-06-20T15:34:09Z","closed_at":"2017-06-20T15:34:09Z","body":"It looks like this plugin transform each node of the SVG into a React element. I wonder if we can make these more performant at runtime by instead using `dangerouslySetInnerHTML` for the contents of the SVG itself. This would allow us to continue passing props to the SVG element but avoid React overhead of managing props for every `path` etc contained by the SVG."},"comment":{"url":"https://api.github.com/repos/kesne/babel-plugin-inline-react-svg/issues/comments/309797751","html_url":"https://github.com/kesne/babel-plugin-inline-react-svg/issues/6#issuecomment-309797751","issue_url":"https://api.github.com/repos/kesne/babel-plugin-inline-react-svg/issues/6","id":309797751,"user":{"login":"kesne","id":498479,"avatar_url":"https://avatars2.githubusercontent.com/u/498479?v=3","gravatar_id":"","url":"https://api.github.com/users/kesne","html_url":"https://github.com/kesne","followers_url":"https://api.github.com/users/kesne/followers","following_url":"https://api.github.com/users/kesne/following{/other_user}","gists_url":"https://api.github.com/users/kesne/gists{/gist_id}","starred_url":"https://api.github.com/users/kesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kesne/subscriptions","organizations_url":"https://api.github.com/users/kesne/orgs","repos_url":"https://api.github.com/users/kesne/repos","events_url":"https://api.github.com/users/kesne/events{/privacy}","received_events_url":"https://api.github.com/users/kesne/received_events","type":"User","site_admin":false},"created_at":"2017-06-20T15:34:09Z","updated_at":"2017-06-20T15:34:09Z","body":"This article seems to suggest that `dangerouslySetInnerHTML` has some performance drawbacks: https://medium.com/@paularmstrong/twitter-lite-and-high-performance-react-progressive-web-apps-at-scale-d28a00e780a3\r\n\r\nI'm going to close this out now."}}
{"actor":{"display_login":"kesne"}}