{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments/152417165","pull_request_review_id":78277352,"id":152417165,"diff_hunk":"@@ -90,7 +90,8 @@ def create_full_tear_sheet(returns,\n                            factor_returns=None,\n                            factor_loadings=None,\n                            pos_in_dollars=True,\n-                           header_rows=None):\n+                           header_rows=None,\n+                           factor_partitions=None):","path":"pyfolio/tears.py","position":6,"original_position":6,"commit_id":"2d2c3e3fc1a501950005279b19daaa7cf0256cb8","original_commit_id":"2d2c3e3fc1a501950005279b19daaa7cf0256cb8","user":{"login":"yankees714","id":790109,"avatar_url":"https://avatars0.githubusercontent.com/u/790109?v=4","gravatar_id":"","url":"https://api.github.com/users/yankees714","html_url":"https://github.com/yankees714","followers_url":"https://api.github.com/users/yankees714/followers","following_url":"https://api.github.com/users/yankees714/following{/other_user}","gists_url":"https://api.github.com/users/yankees714/gists{/gist_id}","starred_url":"https://api.github.com/users/yankees714/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yankees714/subscriptions","organizations_url":"https://api.github.com/users/yankees714/orgs","repos_url":"https://api.github.com/users/yankees714/repos","events_url":"https://api.github.com/users/yankees714/events{/privacy}","received_events_url":"https://api.github.com/users/yankees714/received_events","type":"User","site_admin":false},"body":"Should this be `factor_partitions=FACTOR_PARTITIONS`?","created_at":"2017-11-21T22:16:12Z","updated_at":"2017-11-21T22:16:41Z","html_url":"https://github.com/quantopian/pyfolio/pull/490#discussion_r152417165","pull_request_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/490","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments/152417165"},"html":{"href":"https://github.com/quantopian/pyfolio/pull/490#discussion_r152417165"},"pull_request":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/quantopian/pyfolio/pulls/490","id":154013894,"html_url":"https://github.com/quantopian/pyfolio/pull/490","diff_url":"https://github.com/quantopian/pyfolio/pull/490.diff","patch_url":"https://github.com/quantopian/pyfolio/pull/490.patch","issue_url":"https://api.github.com/repos/quantopian/pyfolio/issues/490","number":490,"state":"open","locked":false,"title":"MAINT: add factor_partitions param to full tear sheet","user":{"login":"vikram-narayan","id":8713773,"avatar_url":"https://avatars1.githubusercontent.com/u/8713773?v=4","gravatar_id":"","url":"https://api.github.com/users/vikram-narayan","html_url":"https://github.com/vikram-narayan","followers_url":"https://api.github.com/users/vikram-narayan/followers","following_url":"https://api.github.com/users/vikram-narayan/following{/other_user}","gists_url":"https://api.github.com/users/vikram-narayan/gists{/gist_id}","starred_url":"https://api.github.com/users/vikram-narayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikram-narayan/subscriptions","organizations_url":"https://api.github.com/users/vikram-narayan/orgs","repos_url":"https://api.github.com/users/vikram-narayan/repos","events_url":"https://api.github.com/users/vikram-narayan/events{/privacy}","received_events_url":"https://api.github.com/users/vikram-narayan/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-21T22:09:07Z","updated_at":"2017-11-21T22:16:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1071a8c78f3f1ef32673038629ffa31ce735db02","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/490/commits","review_comments_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/490/comments","review_comment_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/pyfolio/issues/490/comments","statuses_url":"https://api.github.com/repos/quantopian/pyfolio/statuses/2d2c3e3fc1a501950005279b19daaa7cf0256cb8","head":{"label":"vikram-narayan:factor-partitions-param","ref":"factor-partitions-param","sha":"2d2c3e3fc1a501950005279b19daaa7cf0256cb8","user":{"login":"vikram-narayan","id":8713773,"avatar_url":"https://avatars1.githubusercontent.com/u/8713773?v=4","gravatar_id":"","url":"https://api.github.com/users/vikram-narayan","html_url":"https://github.com/vikram-narayan","followers_url":"https://api.github.com/users/vikram-narayan/followers","following_url":"https://api.github.com/users/vikram-narayan/following{/other_user}","gists_url":"https://api.github.com/users/vikram-narayan/gists{/gist_id}","starred_url":"https://api.github.com/users/vikram-narayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikram-narayan/subscriptions","organizations_url":"https://api.github.com/users/vikram-narayan/orgs","repos_url":"https://api.github.com/users/vikram-narayan/repos","events_url":"https://api.github.com/users/vikram-narayan/events{/privacy}","received_events_url":"https://api.github.com/users/vikram-narayan/received_events","type":"User","site_admin":false},"repo":{"id":100541918,"name":"pyfolio","full_name":"vikram-narayan/pyfolio","owner":{"login":"vikram-narayan","id":8713773,"avatar_url":"https://avatars1.githubusercontent.com/u/8713773?v=4","gravatar_id":"","url":"https://api.github.com/users/vikram-narayan","html_url":"https://github.com/vikram-narayan","followers_url":"https://api.github.com/users/vikram-narayan/followers","following_url":"https://api.github.com/users/vikram-narayan/following{/other_user}","gists_url":"https://api.github.com/users/vikram-narayan/gists{/gist_id}","starred_url":"https://api.github.com/users/vikram-narayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikram-narayan/subscriptions","organizations_url":"https://api.github.com/users/vikram-narayan/orgs","repos_url":"https://api.github.com/users/vikram-narayan/repos","events_url":"https://api.github.com/users/vikram-narayan/events{/privacy}","received_events_url":"https://api.github.com/users/vikram-narayan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vikram-narayan/pyfolio","description":"Portfolio and risk analytics in Python","fork":true,"url":"https://api.github.com/repos/vikram-narayan/pyfolio","forks_url":"https://api.github.com/repos/vikram-narayan/pyfolio/forks","keys_url":"https://api.github.com/repos/vikram-narayan/pyfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikram-narayan/pyfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikram-narayan/pyfolio/teams","hooks_url":"https://api.github.com/repos/vikram-narayan/pyfolio/hooks","issue_events_url":"https://api.github.com/repos/vikram-narayan/pyfolio/issues/events{/number}","events_url":"https://api.github.com/repos/vikram-narayan/pyfolio/events","assignees_url":"https://api.github.com/repos/vikram-narayan/pyfolio/assignees{/user}","branches_url":"https://api.github.com/repos/vikram-narayan/pyfolio/branches{/branch}","tags_url":"https://api.github.com/repos/vikram-narayan/pyfolio/tags","blobs_url":"https://api.github.com/repos/vikram-narayan/pyfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikram-narayan/pyfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikram-narayan/pyfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikram-narayan/pyfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikram-narayan/pyfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/vikram-narayan/pyfolio/languages","stargazers_url":"https://api.github.com/repos/vikram-narayan/pyfolio/stargazers","contributors_url":"https://api.github.com/repos/vikram-narayan/pyfolio/contributors","subscribers_url":"https://api.github.com/repos/vikram-narayan/pyfolio/subscribers","subscription_url":"https://api.github.com/repos/vikram-narayan/pyfolio/subscription","commits_url":"https://api.github.com/repos/vikram-narayan/pyfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikram-narayan/pyfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikram-narayan/pyfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikram-narayan/pyfolio/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikram-narayan/pyfolio/contents/{+path}","compare_url":"https://api.github.com/repos/vikram-narayan/pyfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikram-narayan/pyfolio/merges","archive_url":"https://api.github.com/repos/vikram-narayan/pyfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikram-narayan/pyfolio/downloads","issues_url":"https://api.github.com/repos/vikram-narayan/pyfolio/issues{/number}","pulls_url":"https://api.github.com/repos/vikram-narayan/pyfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/vikram-narayan/pyfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/vikram-narayan/pyfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikram-narayan/pyfolio/labels{/name}","releases_url":"https://api.github.com/repos/vikram-narayan/pyfolio/releases{/id}","deployments_url":"https://api.github.com/repos/vikram-narayan/pyfolio/deployments","created_at":"2017-08-16T23:42:38Z","updated_at":"2017-08-16T23:42:41Z","pushed_at":"2017-11-21T22:08:00Z","git_url":"git://github.com/vikram-narayan/pyfolio.git","ssh_url":"git@github.com:vikram-narayan/pyfolio.git","clone_url":"https://github.com/vikram-narayan/pyfolio.git","svn_url":"https://github.com/vikram-narayan/pyfolio","homepage":"https://quantopian.github.io/pyfolio","size":81286,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quantopian:master","ref":"master","sha":"e37cf77d6a2d15c59ff4f5bbd76bea99bf5765dd","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":36670205,"name":"pyfolio","full_name":"quantopian/pyfolio","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars0.githubusercontent.com/u/1393215?v=4","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/pyfolio","description":"Portfolio and risk analytics in Python","fork":false,"url":"https://api.github.com/repos/quantopian/pyfolio","forks_url":"https://api.github.com/repos/quantopian/pyfolio/forks","keys_url":"https://api.github.com/repos/quantopian/pyfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/pyfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/pyfolio/teams","hooks_url":"https://api.github.com/repos/quantopian/pyfolio/hooks","issue_events_url":"https://api.github.com/repos/quantopian/pyfolio/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/pyfolio/events","assignees_url":"https://api.github.com/repos/quantopian/pyfolio/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/pyfolio/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/pyfolio/tags","blobs_url":"https://api.github.com/repos/quantopian/pyfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/pyfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/pyfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/pyfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/pyfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/pyfolio/languages","stargazers_url":"https://api.github.com/repos/quantopian/pyfolio/stargazers","contributors_url":"https://api.github.com/repos/quantopian/pyfolio/contributors","subscribers_url":"https://api.github.com/repos/quantopian/pyfolio/subscribers","subscription_url":"https://api.github.com/repos/quantopian/pyfolio/subscription","commits_url":"https://api.github.com/repos/quantopian/pyfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/pyfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/pyfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/pyfolio/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/pyfolio/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/pyfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/pyfolio/merges","archive_url":"https://api.github.com/repos/quantopian/pyfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/pyfolio/downloads","issues_url":"https://api.github.com/repos/quantopian/pyfolio/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/pyfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/pyfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/pyfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/pyfolio/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/pyfolio/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/pyfolio/deployments","created_at":"2015-06-01T15:31:39Z","updated_at":"2017-11-21T13:55:37Z","pushed_at":"2017-11-21T22:09:08Z","git_url":"git://github.com/quantopian/pyfolio.git","ssh_url":"git@github.com:quantopian/pyfolio.git","clone_url":"https://github.com/quantopian/pyfolio.git","svn_url":"https://github.com/quantopian/pyfolio","homepage":"https://quantopian.github.io/pyfolio","size":81282,"stargazers_count":1336,"watchers_count":1336,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":375,"mirror_url":null,"archived":false,"open_issues_count":55,"forks":375,"open_issues":55,"watchers":1336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/490"},"html":{"href":"https://github.com/quantopian/pyfolio/pull/490"},"issue":{"href":"https://api.github.com/repos/quantopian/pyfolio/issues/490"},"comments":{"href":"https://api.github.com/repos/quantopian/pyfolio/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/pyfolio/statuses/2d2c3e3fc1a501950005279b19daaa7cf0256cb8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yankees714"}}